Page MenuHomePhabricator

DavidBrooks
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 14 2015, 9:27 PM (394 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DavidBrooks [ Global Accounts ]

Recent Activity

Tue, Jan 24

DavidBrooks added a comment to T73138: Flow: Use the wpwatchlisthideown preference.

Still a problem: I finally turned "Hide my edits from the watchlist" on in Preferences and it didn't do as expected. Especially when I've done a batch of edits to pages that are on my watchlist, for the rare instance when someone else touches the same group of pages, not much else is visible on a Watchlist display. It's disappointing that this setting has ben ignored for so long (although as I have just admitted I hadn't actually been using it).

Tue, Jan 24, 11:36 PM · patch-welcome, Growth-Team, StructuredDiscussions

Dec 17 2022

DavidBrooks added a comment to T325445: General fixes damaging a picture caption when previous text has unbalanced square brackets..

"...with fewer characters of plain text..." If the distinction lies with the intervening newline, then possibly related to the WikiFunctions::Parse::UnbalancedBrackets.cs::DoubleSquareBrackets Regex not having RegexOptions.SingleLine? I haven't had the brainwidth to unwind the Regex, but SingleLine/MultiLine errors are all too familiar.

Dec 17 2022, 11:27 PM · WorkType-Maintenance, AutoWikiBrowser

Nov 28 2022

DavidBrooks added a comment to T180153: API:Usercontribs should allow clients to order by timestamp.

"This won't be possible when combined with ucuserprefix, of course..." I assume the same is true for uciprange (unfortunately, because a:b:c:d::/64 is frequently all the same user).

Nov 28 2022, 9:29 PM · MediaWiki-Action-API

Oct 19 2022

DavidBrooks created T321221: After navigating to an anchor, the header slides down to hide the anchor text.
Oct 19 2022, 5:05 PM · Readers-Web-Backlog, Desktop Improvements (Vector 2022)

Aug 8 2022

DavidBrooks added a comment to T313611: In vector-2022 the main menu becomes full screen width under 1000px.

@Jdlrobson My apologies; I had not realized the implication of the linked entry (in my defense, I was too much triggered by the word "expected", but that's my fault not yours). I'll get off my high horse and temporarily go back to classic Vector. Is there a task I can track that will tell me when the better solution is rolled out?

Aug 8 2022, 2:12 PM · Readers-Web-Backlog, Regression, Desktop Improvements (Vector 2022)

Aug 7 2022

DavidBrooks added a comment to T313611: In vector-2022 the main menu becomes full screen width under 1000px.

Sorry, but closing this as "by design" is unacceptable if Vector-2022 is to become the default for new users. On Windows, docking to the left or right, so that the user can see two portrait windows side-by-side, was promoted as a common practice for those of us who suffered Windows 8, and I can't imagine I'm the only one who still has it as part of the normal workflow. Now, on most screens with an HD-like aspect ratio (somewhat old 1920x1080, or today's 2736x1824 at 175% OS scaling), docking to one side results in [https://1drv.ms/u/s!AtuCZY0YF4hGpK07b9IGdnUnGtV3_Q this] view of the main page. Is that the initial impression we want to give? I'm going to have to revert to Vector-2010 until this problem is addressed.

Aug 7 2022, 11:53 PM · Readers-Web-Backlog, Regression, Desktop Improvements (Vector 2022)

Aug 6 2022

DavidBrooks created T314708: On a sufficiently narrow window, initial view is just navbar and widened dividers.
Aug 6 2022, 1:36 PM · Desktop Improvements (Vector 2022)

Jun 10 2022

DavidBrooks added a comment to T310369: Vector-2022: Title underline and language menu collide with geographic coordinates.

I should have specified that the examples have display=title (or inline,title) as parameters to the coord template.

Jun 10 2022, 6:01 PM · Desktop Improvements (Vector 2022)
DavidBrooks created T310369: Vector-2022: Title underline and language menu collide with geographic coordinates.
Jun 10 2022, 3:18 PM · Desktop Improvements (Vector 2022)

May 2 2022

DavidBrooks added a comment to T307271: Links in the TOC of vector 2022 are not clickable for some Chromium based browsers.

I reported this bug at Village Pump using Edge, and reported that Chrome did respond to clicks. If someone else has repro'ed it in Chrome, then that's OK with me, but I'd like to be sure the fix applies to Edge too.

May 2 2022, 2:22 PM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements (Vector 2022), Vector (legacy skin), Browser-Support-Google-Chrome

May 3 2021

DavidBrooks added a comment to T281644: API iwlinks does not pick up a correction that changes only letter case.

I need to generalize this bug report: when correcting an interwiki link to a nonexistent page, an iwlinks query does not pick up the correction if the changed text HAS THE SAME LENGTH. I first noticed this in a few cases where only capitalization was changed, but obviously that's a subset of the "same-length" bug.
Example:
https://en.wikipedia.org/w/api.php?action=query&prop=iwlinks&titles=Eildon%20Hill
Should list prefix: "s", *: "1911_Encyclop\u00e6dia_Britannica/Eildon_Hills, but doesn't.
The "recent change" in question was to correct the EB1911 link from "Hill, Eildon", which is the same length as the correct "Eildon Hills".

May 3 2021, 4:17 PM · MediaWiki-Interwiki, MediaWiki-Action-API

May 2 2021

DavidBrooks created T281644: API iwlinks does not pick up a correction that changes only letter case.
May 2 2021, 5:00 PM · MediaWiki-Interwiki, MediaWiki-Action-API

Apr 30 2021

DavidBrooks created T281584: API iwlinks documentation typo: refers to interlanguage link.
Apr 30 2021, 3:16 PM · MW-1.35-notes, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, MediaWiki-Action-API, Documentation

Sep 28 2020

DavidBrooks created T264036: Ctrl+G makes it too easy to lose edits.
Sep 28 2020, 7:05 PM · WorkType-Maintenance, AutoWikiBrowser

Mar 26 2020

DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

How long is too long? I really have no feel for what the official parsing logic does, but (with obviously apologies for still appearing to self-promote) my fairly simple-minded approach currently runs 3.5 seconds from the end of download to installing the highlighted text in the UI control, for two fairly large articles ("West Virginia" in both WP and EB1911), and last time I used earwig I was getting pretty comparable results. That's on my Surface 4, an Intel i5 2-core laptop. I mean, if that's significantly longer than the server, then I'll step back, but otherwise you're free to re-use the logic (I realize C# to py may be a problem).

Mar 26 2020, 3:10 PM · Tools

Mar 7 2020

DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

From the for-what-it's-worth department, I have thrown together a clean-room simplified implementation of only the "URL comparison" feature in a Windows exe creatively called "Copyvios". It has limited applicability (i.e. it scratches my own personal itch so far as the exterior URL is concerned) explained in its README. It does the comparison in a few seconds at most, and the result is broadly comparable with the online tool.

Mar 7 2020, 12:28 AM · Tools

Feb 22 2020

DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

@Earwig I was going to ask: Purely selfishly, how easy would it be to break out the "URL comparison" feature into a separate tool? Presumably it uses fewer resources, and (as I said, purely selfishly) it's the only feature I use.

Feb 22 2020, 6:39 AM · Tools

Feb 18 2020

DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

Thanks for the efforts so far. Hope you can track it down.

Feb 18 2020, 7:08 AM · Tools

Feb 17 2020

DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

It came back briefly, but it's gone again. From where I am, it connects to the server and then 504's after 3 minutes.

Feb 17 2020, 11:38 PM · Tools
DavidBrooks added a comment to T245426: Earwig's copyvio tool 504 gateway time-out issues.

Looking (for the first time) at that grafana graph, and due respect to your 30% calculation: the usage reported there was spiky for the first ~9 days, but went to an almost-solid 100% about them time we noticed the timeouts.

Feb 17 2020, 8:50 PM · Tools

Dec 18 2019

DavidBrooks added a comment to T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging.

Ah, that makes it more complex. Again, I guess there's no evidence that anyone else is encountering the API failures due to an out-of-date security infrastructure; AWB for example still uses fx 4.5 but the code must have been fixed well back, so all seems well. I know I've been heard, so you can put this on infinite backlog.

Dec 18 2019, 5:29 PM · Traffic-Icebox, SRE
DavidBrooks renamed T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging from /sec-warning page: please add a helpful XML comment explaining why it's being delivered. to /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging.
Dec 18 2019, 2:27 PM · Traffic-Icebox, SRE
DavidBrooks added a comment to T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging.

Suggest: near the top of the /sec-warning file, add an HTML comment:

Dec 18 2019, 2:25 PM · Traffic-Icebox, SRE
DavidBrooks added a comment to T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging.

Yes, an HTML comment, embedded near the top of the page text, not in the response headers. I called it an XML comment because it's in the XML format. Sorry if that was a misdirection. It probably belongs properly in a <HEAD> element (actually, so does the TITLE).

Dec 18 2019, 4:57 AM · Traffic-Icebox, SRE
DavidBrooks reopened T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging as "Open".

I want to dispute the closing of this because I was specifically asked by the other folks in the linked task to open this separately. Can you get together and decide how to handle it? As I said, it's probably moot but that's not for me to decide.

Dec 18 2019, 12:09 AM · Traffic-Icebox, SRE

Dec 15 2019

DavidBrooks created T240794: /sec-warning page: please add an HTML comment that is more easily visible to API and transport-level inspection/debugging.
Dec 15 2019, 3:00 PM · Traffic-Icebox, SRE
DavidBrooks closed T240497: API Querying for XML/JSON, you might get the Browser Connection Security warning HTML page (which is invalid XML) as Invalid.

Closed as suggested. Sorry about the delay; I'll open another ticket although it's rapidly becoming moot. Is this the equivalent of "By Design"?

Dec 15 2019, 2:40 PM · SRE, Traffic

Dec 12 2019

DavidBrooks added a comment to T240497: API Querying for XML/JSON, you might get the Browser Connection Security warning HTML page (which is invalid XML).

Thanks, BBlack, for the obvious thoughtful care that went into this. And, in my case, it had the desired end-result, although I had to read to the end of the page to get me started.

Dec 12 2019, 3:30 PM · SRE, Traffic
DavidBrooks added a comment to T240497: API Querying for XML/JSON, you might get the Browser Connection Security warning HTML page (which is invalid XML).

Oh, goodness, my thinking is muddled today. Blame a cold.

Dec 12 2019, 5:19 AM · SRE, Traffic

Dec 11 2019

DavidBrooks added a comment to T240497: API Querying for XML/JSON, you might get the Browser Connection Security warning HTML page (which is invalid XML).

Thanks for picking this up. I assume the answer is buried deep in XmlDocument.Load(). According to the stack trace it's System.Xml.XmlTextReaderImpl.ParseEndElement() that gets upset. But you're probably right; I didn't look critically enough. The <IMG> element isn't closed.

Dec 11 2019, 10:52 PM · SRE, Traffic
DavidBrooks created T240497: API Querying for XML/JSON, you might get the Browser Connection Security warning HTML page (which is invalid XML).
Dec 11 2019, 7:49 PM · SRE, Traffic

Oct 10 2018

DavidBrooks added a comment to T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode).

I don't know if this is late to the game, but from the perspective of one who uses the http API: in the past 2 weeks or so, on en.wikipedia.org, a multi-user "usercontribs" query went from always returning immediately (sub-second) to always timing out. Is this change intended to fix that?

Oct 10 2018, 6:48 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Patch-For-Review, Regression, MediaWiki-Special-pages, Performance Issue
DavidBrooks added a comment to T33197: Implement revision filter by namespace for big wikis in "miser mode".

Your issue isn't really related to this task. But I suspect it'll be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/461440, when that gets merged.

Oct 10 2018, 12:18 AM · MediaWiki-Special-pages

Oct 9 2018

DavidBrooks added a comment to T33197: Implement revision filter by namespace for big wikis in "miser mode".

I was sent here from a thread in mediawiki.org API talk:Usercontribs. On the English Wikipedia, in recent days, a simple usercontribs list request with two ucusers has changed from always responding immediately (sub-second) to always timing out. Here's the actual URL I recently tried:
GET /w/api.php?action=query&format=xml&list=usercontribs&ucuser=DavidBrooks%7CDavidBrooks-AWB&uclimit=20&ucnamespace=0&ucprop=title%7Ctimestamp%7Ccomment%7Cflags&continue= HTTP/1.1

Oct 9 2018, 2:12 PM · MediaWiki-Special-pages

Jul 18 2015

DavidBrooks added a comment to T106189: Cannot connect to svn repository.

I thought that might be the case. Just wanted to be sure you were aware.

Jul 18 2015, 4:49 AM · AutoWikiBrowser

Jul 17 2015

DavidBrooks created T106189: Cannot connect to svn repository.
Jul 17 2015, 9:54 PM · AutoWikiBrowser

Jul 15 2015

DavidBrooks added a comment to T105839: Newtonsoft.Json assembly manifest doesnt match assembly reference.

Repro steps work - thanks for the quick fix.

Jul 15 2015, 5:25 PM · AutoWikiBrowser

Jul 14 2015

DavidBrooks added a comment to T105839: Newtonsoft.Json assembly manifest doesnt match assembly reference.

Confirmed: I just downloaded version 5700. When trying to switch projects, the UI says it cannot load Newtonsoft.Json, version 7.0.0.0. The version in the download zip is 6.0.8.18111.

Jul 14 2015, 9:29 PM · AutoWikiBrowser