Page MenuHomePhabricator

Dbrant (Dmitry Brant)
Senior Software Engineer (Android)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2014, 7:08 PM (238 w, 3 d)
Availability
Available
IRC Nick
dbrant
LDAP User
Dbrant
MediaWiki User
DBrant (WMF) [ Global Accounts ]

Recent Activity

Fri, May 17

Dbrant claimed T223530: 2.7.280-alpha-2019-05-16 crashes when taping on reference numbers.
Fri, May 17, 6:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T223530: 2.7.280-alpha-2019-05-16 crashes when taping on reference numbers from Backlog to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, May 17, 6:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T223530: 2.7.280-alpha-2019-05-16 crashes when taping on reference numbers from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Fri, May 17, 6:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T223530: 2.7.280-alpha-2019-05-16 crashes when taping on reference numbers from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Fri, May 17, 6:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant closed T223650: [Alpha] Some space wasted in bottom bar as Declined.

This is by design. The table-of-contents icon is aligned to the right (where the table of contents pops out), and the other icons are aligned to the left. On a wider display, the space between those icons will expand.

Fri, May 17, 6:09 PM · Android-app-Bugs, Wikipedia-Android-App-Backlog

Wed, May 15

Dbrant closed T158807: Add translation test to ensure Wikitext and Markdown translations are forbidden as Resolved.
Wed, May 15, 1:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Dbrant closed T198474: Update TranslationTests to be able to catch more types of errors/crashes as Resolved.
Wed, May 15, 1:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Dbrant closed T208054: [BUG] Ensure that the TOC message is not cut off on smaller devices and that the TOC slider is visible when the message is shown as Resolved.
Wed, May 15, 1:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt, Android-app-feature-Navigation
Dbrant closed T219692: "Next" button cut off when editing as Resolved.
Wed, May 15, 1:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant closed T208054: [BUG] Ensure that the TOC message is not cut off on smaller devices and that the TOC slider is visible when the message is shown, a subtask of T197178: Perform second round of usability testing on the implemented android navigation design from Jaffa release, as Resolved.
Wed, May 15, 1:18 PM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Dbrant closed T219462: Provide an option to enable/disable all cards related to “Suggested edits“ as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant closed T220218: Context menu (long press) has extremely light grey text with the dark and black themes as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant closed T221464: Dictionary only intermittently works as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant closed T220532: Design updates for bottom/top bars as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant closed T221926: [Bug] “Editor tasks“ should be “Suggested edits“ as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant closed T221926: [Bug] “Editor tasks“ should be “Suggested edits“, a subtask of T215630: [EPIC] Design improvements for suggested edits, as Resolved.
Wed, May 15, 1:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Tue, May 14

Dbrant closed T223293: on Pixel, unrelated (1st) article appears in back arrow sequence from articles as Resolved.

This should no longer be the case in the (very) latest alpha.

Tue, May 14, 3:53 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs

Mon, May 13

Dbrant moved T223128: Modify gallery screen for Suggested Edits from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Mon, May 13, 5:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Dbrant updated the task description for T223121: [Bug] Invisible app bar on article page with image.
Mon, May 13, 5:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant added a comment to T221856: Update logout functions in mobile apps.

[When this passes QA, I'll simply untag Android, so that it can be completed on iOS]

Mon, May 13, 2:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile
Dbrant moved T221856: Update logout functions in mobile apps from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, May 13, 2:12 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile
Dbrant moved T222056: Improve navigation model from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, May 13, 2:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T221889: Gracefully handle remote logout and/or changing of credentials. from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, May 13, 2:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Fri, May 10

Dbrant added a comment to T209997: Create a new API endpoint which returns Commons images in need of a caption or caption translation.

It makes total sense to start with identifying popular Wiki articles, and seeing if the images they contain have a structured caption. This will certainly be better than picking Commons images at random, most of which won't be linked to any Wikipedia article.

Fri, May 10, 8:43 PM · Reading-Infrastructure-Team-Backlog (Kanban), WikimediaEditorTasks

Thu, May 9

Dbrant closed T222915: reduce apk size as Invalid.

The app is configured to be built with ABI-splits, i.e. one APK per each ABI, which makes it roughly 10MB. It also builds a universal APK, which is 17MB.
If F-Droid would like to distribute per-architecture APKs (instead of the universal APK) they are welcome to do so.

Thu, May 9, 6:53 PM · Wikipedia-Android-App-Backlog

Wed, May 8

Dbrant updated subscribers of T222821: Sunset /page/definitions?.

So it looks like we have an average of 3800 clicks per day on the "Define" option, over the last month:

Wed, May 8, 6:35 PM · Wikipedia-Android-App-Backlog, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog (Kanban)

Tue, May 7

Dbrant added a comment to T222656: Fix active EventLogging schemas that added backwards incompatable required fields..

The most egregious offense! Type changes are definitely not allowed!

Tue, May 7, 6:13 PM · Patch-For-Review, Product-Analytics, Discovery-Analysis, Analytics-Kanban, EventBus, Analytics
Dbrant added a comment to T222056: Improve navigation model.

@schoenbaechler Correct, this is what the latest update will do.

Tue, May 7, 5:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant added a comment to T222056: Improve navigation model.

@schoenbaechler Sure, that sounds good. Should we perhaps hide the "0" tab button when there are no tabs left in the Tab screen, as well?

Tue, May 7, 2:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant added a comment to T222056: Improve navigation model.

02) Lead users to the last view after they’ve closed the last remaining tab.

Tue, May 7, 1:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mon, May 6

Dbrant added a subtask for T221665: Integrate with References endpoint: T222384: Enable storage and pre-generation for PCS endpoints.
Mon, May 6, 5:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant added a parent task for T222384: Enable storage and pre-generation for PCS endpoints: T221665: Integrate with References endpoint.
Mon, May 6, 5:50 PM · Services (later), Reading-Infrastructure-Team-Backlog, Core Platform Team Backlog (Later), Page Content Service, ChangeProp, RESTBase
Dbrant moved T222056: Improve navigation model from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, May 6, 3:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T221889: Gracefully handle remote logout and/or changing of credentials. from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, May 6, 3:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant claimed T221889: Gracefully handle remote logout and/or changing of credentials..
Mon, May 6, 3:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Thu, May 2

Dbrant added a comment to T222056: Improve navigation model.

01) An indicator that displays “0“ so prominently in the interface can lead to confusion

Thu, May 2, 1:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Tue, Apr 30

Dbrant moved T222056: Improve navigation model from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 30, 9:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T222056: Improve navigation model from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 30, 8:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant claimed T222056: Improve navigation model.
Tue, Apr 30, 8:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T218201: Explore new ways to display content instead of showing placeholder images from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 30, 4:34 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant moved T218201: Explore new ways to display content instead of showing placeholder images from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Tue, Apr 30, 4:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant moved T218201: Explore new ways to display content instead of showing placeholder images from UX Debt Backlog to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Tue, Apr 30, 4:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant set the point value for T222202: In list items, change from overflow menu to long-press dialog. to 3.
Tue, Apr 30, 4:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant created T222202: In list items, change from overflow menu to long-press dialog..
Tue, Apr 30, 4:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant set the point value for T218201: Explore new ways to display content instead of showing placeholder images to 3.
Tue, Apr 30, 4:28 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant moved T222056: Improve navigation model from Needs Design/Design doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 30, 4:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant set the point value for T222056: Improve navigation model to 3.
Tue, Apr 30, 4:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mon, Apr 29

Dbrant added a comment to T222054: Make status bar transparent.

Interesting, what does “not work consistently“ mean exactly?

Mon, Apr 29, 8:05 PM · Wikipedia-Android-App-Backlog
Dbrant added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

@matmarex Yes, thanks; this should be OK from our end.

Mon, Apr 29, 7:31 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
Dbrant closed T150797: PageActivity should not have page load logic in it as Resolved.
Mon, Apr 29, 7:14 PM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog
Dbrant closed T180190: Make event logging more efficient as Invalid.
Mon, Apr 29, 7:09 PM · Wikipedia-Android-App-Backlog
Dbrant closed T117380: [Dev] Crash report description should include device locale as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Dbrant closed T169945: “Piggyback” EL with other network requests as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt, Reading Epics (Analytics)
Dbrant closed T206855: mobile-html: Android prototype as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant closed T206855: mobile-html: Android prototype, a subtask of T177433: Develop HTML Content API to be used with companion structured JSON APIs, as Resolved.
Mon, Apr 29, 6:55 PM · Reading-Infrastructure-Team-Backlog, Epic, Page Content Service, Reading Epics (Platform JS CSS and HTML consolidation)
Dbrant closed T213132: Increase the number of the limit of open tabs as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant closed T215255: Review app to find re-used translations as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Dbrant closed T219808: Migrate to Android X as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant closed T220628: Add "unique clicks" counter in Suggested Edits analytics instrumentation as Resolved.
Mon, Apr 29, 6:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Product-Analytics
Dbrant closed T202930: [BUG] Showing an error page when trying to edit a redirected page as Resolved.
Mon, Apr 29, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Patch-For-Review, Chinese-Sites
Dbrant closed T218806: Rename everything that relates to "Suggested edits" as Resolved.
Mon, Apr 29, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Dbrant closed T218594: Instrument MobileWikiAppSuggestedEdits as Resolved.
Mon, Apr 29, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Patch-For-Review, Product-Analytics
Dbrant closed T218594: Instrument MobileWikiAppSuggestedEdits, a subtask of T213460: Analytics schema for edit action feed, as Resolved.
Mon, Apr 29, 6:54 PM · Product-Analytics
Dbrant moved T221464: Dictionary only intermittently works from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 29, 6:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T221464: Dictionary only intermittently works from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 29, 5:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant claimed T221464: Dictionary only intermittently works.
Mon, Apr 29, 5:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T221464: Dictionary only intermittently works from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Mon, Apr 29, 5:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T221464: Dictionary only intermittently works from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Mon, Apr 29, 4:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T221856: Update logout functions in mobile apps from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 29, 3:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile
Dbrant claimed T221856: Update logout functions in mobile apps.
Mon, Apr 29, 3:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile
Dbrant added a comment to T222054: Make status bar transparent.
  • What happens when the user scrolls down past the lead image?
  • This is possible, but it's known to not work consistently on different manufacturers and/or APIs. This would add considerably more complexity, and would make QA much more difficult.
Mon, Apr 29, 2:08 PM · Wikipedia-Android-App-Backlog

Fri, Apr 26

Dbrant updated the task description for T221856: Update logout functions in mobile apps.
Fri, Apr 26, 6:43 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile
Dbrant moved T169945: “Piggyback” EL with other network requests from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Apr 26, 2:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt, Reading Epics (Analytics)
Dbrant moved T219692: "Next" button cut off when editing from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Apr 26, 2:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Dbrant moved T208054: [BUG] Ensure that the TOC message is not cut off on smaller devices and that the TOC slider is visible when the message is shown from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Apr 26, 2:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt, Android-app-feature-Navigation
Dbrant moved T220218: Context menu (long press) has extremely light grey text with the dark and black themes from Blocked/Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Apr 26, 2:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T221023: Showing "An error occurred" when logging in from Android-app-release-v2.7.28x-M-Mochi to Bug Backlog on the Wikipedia-Android-App-Backlog board.
Fri, Apr 26, 2:56 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Dbrant moved T221951: Change unlock criteria for Add/translate descriptions to 24h and 3 edits from Android-app-release-v2.7.28x-M-Mochi to Tracking on the Wikipedia-Android-App-Backlog board.
Fri, Apr 26, 2:55 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Reading-Infrastructure-Team-Backlog (Kanban)

Thu, Apr 25

Dbrant created T221889: Gracefully handle remote logout and/or changing of credentials..
Thu, Apr 25, 7:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T221856: Update logout functions in mobile apps from Needs Triage to Android-app-release-v2.7.28x-M-Mochi on the Wikipedia-Android-App-Backlog board.
Thu, Apr 25, 7:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Android-app-Bugs, Mobile

Tue, Apr 23

Dbrant created T221666: Investigate usage of evaluateJavascript directly.
Tue, Apr 23, 4:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant created T221665: Integrate with References endpoint.
Tue, Apr 23, 4:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Dbrant moved T219651: Design recommendations for “Add/translate descriptions“ from Needs Design/Design doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 23, 4:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant changed the point value for T219651: Design recommendations for “Add/translate descriptions“ from 4 to 3.
Tue, Apr 23, 4:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Dbrant added a comment to T178014: Update android-builder cloud instance.

@Mholloway Yep, this can be taken down now.

Tue, Apr 23, 2:09 PM · Wikipedia-Android-App-Backlog

Fri, Apr 19

Dbrant closed T221465: Images dimmed in dark/black modes even when image dimming is turned off as Resolved.

This is fixed in our upcoming beta.

Fri, Apr 19, 5:33 PM · Android-app-Bugs, Wikipedia-Android-App-Backlog

Apr 19 2019

Dbrant closed T205596: App automatically logs out the user as Resolved.
Apr 19 2019, 1:43 PM · Android-app-Bugs, Wikipedia-Android-App-Backlog

Apr 18 2019

Dbrant moved T169945: “Piggyback” EL with other network requests from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 18 2019, 4:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt, Reading Epics (Analytics)
Dbrant claimed T169945: “Piggyback” EL with other network requests.
Apr 18 2019, 4:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt, Reading Epics (Analytics)

Apr 17 2019

Dbrant added a comment to T221171: Some Java clients unable to handle beta cluster TLS.

It's now working correctly on all of my Android devices. It's actually still failing in my mock app on Windows, but I'm suspecting that it really is a root certificate issue specific to Windows (since it was also failing with librenms), and therefore unrelated.
And I've asked the Commons team to report whether they're still having the issue, but I'm hopeful that this is the correct solution.

Apr 17 2019, 3:15 PM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant awarded T221171: Some Java clients unable to handle beta cluster TLS a Doubloon token.
Apr 17 2019, 2:57 PM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant added a comment to T221171: Some Java clients unable to handle beta cluster TLS.

@Krenair And... that seems to be working! Thanks for digging into it.

Apr 17 2019, 2:57 PM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant added a comment to T221171: Some Java clients unable to handle beta cluster TLS.

Does it happen with plain Java URLConnection then?

Apr 17 2019, 2:22 PM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant added a comment to T221171: Some Java clients unable to handle beta cluster TLS.

I have also tried making network requests using a different library (Volley), and still getting the same errors, so we can rule out any issues that might be specific to any library.

Apr 17 2019, 1:34 PM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant added a comment to T221171: Some Java clients unable to handle beta cluster TLS.

Right, here we go:

    javax.net.ssl.SSLHandshakeException: Chain validation failed
        at com.android.org.conscrypt.ConscryptFileDescriptorSocket.startHandshake(ConscryptFileDescriptorSocket.java:229)
        at okhttp3.internal.connection.RealConnection.connectTls(RealConnection.java:336)
        at okhttp3.internal.connection.RealConnection.establishProtocol(RealConnection.java:300)
        at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:185)
        at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.java:224)
        at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.java:107)
        at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.java:87)
        at okhttp3.internal.connection.Transmitter.newExchange(Transmitter.java:169)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:41)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:94)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:88)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.TestStubInterceptor.intercept(TestStubInterceptor.kt:17)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.OfflineCacheInterceptor.intercept(OfflineCacheInterceptor.java:84)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.DefaultMaxStaleRequestInterceptor.intercept(DefaultMaxStaleRequestInterceptor.kt:36)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.CommonHeaderRequestInterceptor.intercept(CommonHeaderRequestInterceptor.kt:22)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.StatusResponseInterceptor.intercept(StatusResponseInterceptor.kt:21)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at org.wikipedia.dataclient.okhttp.UnsuccessfulResponseInterceptor.intercept(UnsuccessfulResponseInterceptor.kt:11)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
        at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.java:223)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
2019-04-16 19:44:31.555 19672-19741/org.wikipedia.dev D/org.wikipedia.analytics.EventLoggingService:     at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:221)
        at okhttp3.RealCall.execute(RealCall.java:81)
        at org.wikipedia.analytics.EventLoggingService.lambda$log$0(EventLoggingService.java:73)
        at org.wikipedia.analytics.-$$Lambda$EventLoggingService$SxwWpT16qHlNDlLVHH7OAyvsBWo.run(Unknown Source:2)
        at io.reactivex.internal.operators.completable.CompletableFromAction.subscribeActual(CompletableFromAction.java:34)
        at io.reactivex.Completable.subscribe(Completable.java:2234)
        at io.reactivex.internal.operators.completable.CompletableSubscribeOn$SubscribeOnObserver.run(CompletableSubscribeOn.java:64)
        at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)
     Caused by: java.security.cert.CertificateException: Chain validation failed
        at com.android.org.conscrypt.TrustManagerImpl.verifyChain(TrustManagerImpl.java:707)
        at com.android.org.conscrypt.TrustManagerImpl.checkTrustedRecursive(TrustManagerImpl.java:539)
        at com.android.org.conscrypt.TrustManagerImpl.checkTrustedRecursive(TrustManagerImpl.java:560)
        at com.android.org.conscrypt.TrustManagerImpl.checkTrustedRecursive(TrustManagerImpl.java:628)
        at com.android.org.conscrypt.TrustManagerImpl.checkTrusted(TrustManagerImpl.java:495)
        at com.android.org.conscrypt.TrustManagerImpl.checkTrusted(TrustManagerImpl.java:418)
        at com.android.org.conscrypt.TrustManagerImpl.getTrustedChainForServer(TrustManagerImpl.java:339)
        at android.security.net.config.NetworkSecurityTrustManager.checkServerTrusted(NetworkSecurityTrustManager.java:94)
        at android.security.net.config.RootTrustManager.checkServerTrusted(RootTrustManager.java:88)
        at com.android.org.conscrypt.Platform.checkServerTrusted(Platform.java:208)
        at com.android.org.conscrypt.ConscryptFileDescriptorSocket.verifyCertificateChain(ConscryptFileDescriptorSocket.java:404)
        at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
        at com.android.org.conscrypt.NativeSsl.doHandshake(NativeSsl.java:375)
        at com.android.org.conscrypt.ConscryptFileDescriptorSocket.startHandshake(ConscryptFileDescriptorSocket.java:224)
        	... 54 more
     Caused by: java.security.cert.CertPathValidatorException: Response is unreliable: its validity interval is out-of-date
        at sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:135)
        at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:222)
        at sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:140)
        at sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79)
        at java.security.cert.CertPathValidator.validate(CertPathValidator.java:301)
        at com.android.org.conscrypt.TrustManagerImpl.verifyChain(TrustManagerImpl.java:703)
        	... 67 more
     Caused by: java.security.cert.CertPathValidatorException: Response is unreliable: its validity interval is out-of-date
        at sun.security.provider.certpath.OCSPResponse.verify(OCSPResponse.java:619)
        at sun.security.provider.certpath.RevocationChecker.checkOCSP(RevocationChecker.java:709)
        at sun.security.provider.certpath.RevocationChecker.check(RevocationChecker.java:363)
        at sun.security.provider.certpath.RevocationChecker.check(RevocationChecker.java:337)
        at sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:125)
        	... 72 more
2019-04-16 19:44:31.556 19672-19741/org.wikipedia.dev D/org.wikipedia.analytics.EventLoggingService: 	Suppressed: java.security.cert.CertPathValidatorException: Could not determine revocation status
        at sun.security.provider.certpath.RevocationChecker.buildToNewKey(RevocationChecker.java:1092)
        at sun.security.provider.certpath.RevocationChecker.verifyWithSeparateSigningKey(RevocationChecker.java:910)
        at sun.security.provider.certpath.RevocationChecker.checkCRLs(RevocationChecker.java:577)
        at sun.security.provider.certpath.RevocationChecker.checkCRLs(RevocationChecker.java:465)
        at sun.security.provider.certpath.RevocationChecker.check(RevocationChecker.java:394)
        		... 74 more
Apr 17 2019, 12:37 AM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog
Dbrant created T221171: Some Java clients unable to handle beta cluster TLS.
Apr 17 2019, 12:22 AM · Patch-For-Review, Beta-Cluster-reproducible, Wikipedia-Android-App-Backlog

Apr 16 2019

Dbrant added a comment to T220911: Hardcoded UI strings in view_wikitext_keyboard.xml.

The Gerrit project for the app is read-only, and contains a notice to go to GitHub:
https://gerrit.wikimedia.org/r/#/admin/projects/apps/android/wikipedia

Apr 16 2019, 7:38 PM · Wikipedia-Android-App-Backlog, Android-app-feature-Multilingual
Dbrant added a comment to T219561: Untranslated and incorrect strings in not English versions of Wikipedia Android apps.

@Patriccck You should be able to edit the task description and remove any content you don't want.

Apr 16 2019, 5:23 PM · Wikipedia-Android-App-Backlog, I18n, Android-app-Bugs
Dbrant moved T180190: Make event logging more efficient from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.
Apr 16 2019, 3:13 PM · Wikipedia-Android-App-Backlog
Dbrant moved T197580: Automatically set Serbian Cyrillic/Latin variant based on the user's selected keyboard from Needs Triage to UX Debt Backlog on the Wikipedia-Android-App-Backlog board.
Apr 16 2019, 3:12 PM · Android-app-feature-Multilingual, Wikipedia-Android-App-Backlog