Fri, Mar 22
@Mholloway The latter, I'm afraid.
Thu, Mar 21
Our strings are translated by the volunteers at TranslateWiki.net. This particular string is located here:
The issue was client-side after all.
Tue, Mar 19
@mpopov We can theoretically make an API call and set a new userjs-option that contains the data, e.g. userjs-accountcreatesource = Android v270
I'm afraid I still can't reproduce this :(
If you can reproduce it on your device, can you pause what you're doing and jump on a hangout, where we can inspect the DOM of the article that is in your WebView?
Fri, Mar 15
@Sharvaniharan Please look at the APP_VERSION_NAME before filing the task.
Thu, Mar 14
we probably can remove the android jenkins plugin as well
Wed, Mar 13
Tue, Mar 12
Aha, my confusion ran deeper than I thought. I believe I understand the whole issue now, and will reply on the patch.
@schoenbaechler Well actually, in the current code itself, it looks like we have all the correct values that should be there.
And in fact, I'm a bit confused about where this color is coming from:
@schoenbaechler To clarify, the color you specified seems to correspond to paper_color, but with a shaded opacity on top of it. That's not quite the way it works: we need the total combined color value for each theme. It sounds like we might need to create a new meta-color such as paper_color_shaded that provides these color values.
But image placeholder colors are still off. I guess it has something to do with the background-color.
Thu, Mar 7
@schoenbaechler The limit is set to 2 in the Alpha version of the app. In the production version it will be 50.
Wed, Mar 6
As with other strings in the app, these are translated by the volunteers at TranslateWiki (independently of our deadlines), and are automatically incorporated into the app at weekly increments (some can take much longer than others). I think it's acceptable to verify only the English variation of the string.
@Charlotte @schoenbaechler From our latest check-in with Reading Infrastructure, it will not be feasible to differentiate between "added descriptions" and "translated descriptions" for this first iteration of the endpoint. (It will require quite a bit more logic and careful thinking about how to do it properly). It will still differentiate between different languages of the edits, but everything will have to be under a single bucket of general "contributions" for now. Can we update the design to reflect this?
@Nikerabbit We haven't seen any new TWN commits made to the github repo. Is there anything else that needs to be configured?
Fri, Mar 1
Article thumbnails should be 56px x 56px as well
Thumbnail width should be 56x56px
Thu, Feb 28
Looks like it imported pretty nicely, thanks!
@schoenbaechler Can we have an SVG file of the graphic in the center of the onboarding screen? (including the little embellishments outside of the main circle)
Wed, Feb 27
Tue, Feb 26
Fixed indeed! Thanks all.
Mon, Feb 25
Unfortunately this is still not fully fixed, namely on API 19 (KitKat):
Apparently the version of Chromium shipped with KitKat does not support the unset keyword in CSS, therefore the fix applied earlier is not having any effect. It's possible that there's a webkit-specific keyword that we can use, but I can't find it...
Sun, Feb 24
Sat, Feb 23
Feb 21 2019
Feb 18 2019
Yes, it should be safe. We will take care of updating the repo description and readme shortly.
@Nikerabbit I sent an invite to the translatewiki.net user to become a collaborator on the github repo. Does someone need to accept the invite?
Feb 13 2019
Feb 12 2019
Feb 11 2019
I have taken care of "OK", "Cancel", "Yes", and "No" messages
This is far from done; we have a large number of places throughout the app that reuse "OK", "Cancel", "Yes", and "No" messages. However, the priority of deduplicating those strings is probably quite low.