In T399974#11263752, @System625 wrote:

Hello @Pepe_piton

I've completed this task and created a merge request: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/30

The implementation adds pagination to both search results pages and author works lists with 50 items per page.

Note: All search filters (gender, nationality, type_of_work, country_of_origin) are preserved when navigating between pages. The "in-public-domain" filter is not currently preserved across pagination due to Jinja2 template limitations with parameter names containing hyphens. If this needs to be addressed, I can implement a workaround.

Ready for review!

In T399974#11263576, @shreya-bhagat wrote:

@Nat_WDU @Pepe_piton kindly review!

Changes made:

1. Creation of Previous and Next button. Both on Author and Works Results page. On the first page, "Previous" button remains disabled, and likewise on the last page, "Next" remains disabled.
2. If someone tries to enter a page no. which is a negative number, of a number greater than the total no of pages, they are redirected to first and last page respectively.
3. No. of results per page is limited to 10.
4. The button design is coherent with the rest of the elements on the page.

PR: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/16
Changes preview:

@shreya-bhagat, @Aradhya05, @Dipanshu1223 code looks ok and I was able to see the new dropdown type-to-search behavior on your PRs.

In T405621#11283851, @Afanyulionel wrote:

Hello @Pepe_piton , @Nat_WDU Here's the result of my version of the task: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/112

In T405621#11287742, @Oluwatumininu.m wrote:

In T405621#11284544, @DidiCoronel wrote:

In T405621#11261016, @Oluwatumininu.m wrote:

I discovered a new issue while solving this issue and I have fixed it. I will include the before and after videos whilst creating a new PR.

The "Country of Origin" dropdown type-to-select feature currently matches countries anywhere in the name (e.g., typing "N" shows Afghanistan before Nigeria).

I have improved this behavior so that the filter prioritizes countries that START with the typed letters.

What I did:

1. Found the code responsible for filtering or matching country names in the dropdown.
2. Updated the logic so that countries whose names start with the typed query appear first.
   • Used toLowerCase().startsWith(query.toLowerCase()) to check for prefix matches.
   • Optionally, I still included other matches (that contain the query later), but listed them after the prefix matches.
3. Ensured the alphabetical order of countries remains consistent.
4. Tested that typing "N" now shows countries like "Namibia", "Nepal", "Nigeria" first.

@Oluwatumininu.m, I think this is an improvement for the behavior of the combobox and was able to verify it work as intended. Although I do have a question about the PR, there are two divs with class "combobox-container" added here. Are both actually needed? May have more questions or comments later.

Thank you very much for the feedback!

This was a duplication issue that I missed.

I have removed the duplicate div and made a commit. I'll be expecting more comments and feedback.

In T405621#11261016, @Oluwatumininu.m wrote:

I discovered a new issue while solving this issue and I have fixed it. I will include the before and after videos whilst creating a new PR.

The "Country of Origin" dropdown type-to-select feature currently matches countries anywhere in the name (e.g., typing "N" shows Afghanistan before Nigeria).

I have improved this behavior so that the filter prioritizes countries that START with the typed letters.

What I did:

1. Found the code responsible for filtering or matching country names in the dropdown.
2. Updated the logic so that countries whose names start with the typed query appear first.
   • Used toLowerCase().startsWith(query.toLowerCase()) to check for prefix matches.
   • Optionally, I still included other matches (that contain the query later), but listed them after the prefix matches.
3. Ensured the alphabetical order of countries remains consistent.
4. Tested that typing "N" now shows countries like "Namibia", "Nepal", "Nigeria" first.

In T405621#11282045, @shreya-bhagat wrote:

Hello @DidiCoronel!
I think just before pushing I made a mistake in the css file. I've fixed that now, have a look: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/90/diffs?diff_id=136659&start_sha=f7156e42826322923b25e9e1091c5a51585ba6e1

Hope it works fine now. I use chrome browser on Ubuntu 24.04.3

so sorry for the inconvenience!

The approach looks good, but I'm unable to reproduce the expected behavior on my Ubuntu environment on Firefox and Chrome.
This is how I see the dropdown.

Feature implemented on Authors search but not on Works search yet.

Just requested Toolforge membership. Will wait to see how it goes.
Thanks!

• User:DidiCoronel