Page MenuHomePhabricator

DidiCoronel (David Coronel)
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Saturday

  • No visible events.

User Details

User Since
Aug 5 2024, 4:38 PM (70 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DidiCoronel [ Global Accounts ]

Recent Activity

Oct 22 2025

DidiCoronel added a comment to T399974: Results pagination.

Hello @Pepe_piton

I've completed this task and created a merge request: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/30

The implementation adds pagination to both search results pages and author works lists with 50 items per page.

Note: All search filters (gender, nationality, type_of_work, country_of_origin) are preserved when navigating between pages. The "in-public-domain" filter is not currently preserved across pagination due to Jinja2 template limitations with parameter names containing hyphens. If this needs to be addressed, I can implement a workaround.

Ready for review!

Oct 22 2025, 11:01 PM · Tool-paulina
DidiCoronel added a comment to T399974: Results pagination.

@Nat_WDU @Pepe_piton kindly review!

Changes made:

  1. Creation of Previous and Next button. Both on Author and Works Results page. On the first page, "Previous" button remains disabled, and likewise on the last page, "Next" remains disabled.
  2. If someone tries to enter a page no. which is a negative number, of a number greater than the total no of pages, they are redirected to first and last page respectively.
  3. No. of results per page is limited to 10.
  4. The button design is coherent with the rest of the elements on the page.

PR: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/16
Changes preview:

Oct 22 2025, 10:52 PM · Tool-paulina
DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..

@shreya-bhagat, @Aradhya05, @Dipanshu1223 code looks ok and I was able to see the new dropdown type-to-search behavior on your PRs.

Oct 22 2025, 5:17 PM · Tool-paulina
DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..
Oct 22 2025, 4:38 PM · Tool-paulina
DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..

I discovered a new issue while solving this issue and I have fixed it. I will include the before and after videos whilst creating a new PR.

The "Country of Origin" dropdown type-to-select feature currently matches countries anywhere in the name (e.g., typing "N" shows Afghanistan before Nigeria).

I have improved this behavior so that the filter prioritizes countries that START with the typed letters.

What I did:

  1. Found the code responsible for filtering or matching country names in the dropdown.
  2. Updated the logic so that countries whose names start with the typed query appear first.
    • Used toLowerCase().startsWith(query.toLowerCase()) to check for prefix matches.
    • Optionally, I still included other matches (that contain the query later), but listed them after the prefix matches.
  3. Ensured the alphabetical order of countries remains consistent.
  4. Tested that typing "N" now shows countries like "Namibia", "Nepal", "Nigeria" first.

@Oluwatumininu.m, I think this is an improvement for the behavior of the combobox and was able to verify it work as intended. Although I do have a question about the PR, there are two divs with class "combobox-container" added here. Are both actually needed? May have more questions or comments later.

Thank you very much for the feedback!

This was a duplication issue that I missed.

I have removed the duplicate div and made a commit. I'll be expecting more comments and feedback.

Oct 22 2025, 4:27 PM · Tool-paulina

Oct 17 2025

DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..

I discovered a new issue while solving this issue and I have fixed it. I will include the before and after videos whilst creating a new PR.

The "Country of Origin" dropdown type-to-select feature currently matches countries anywhere in the name (e.g., typing "N" shows Afghanistan before Nigeria).

I have improved this behavior so that the filter prioritizes countries that START with the typed letters.

What I did:

  1. Found the code responsible for filtering or matching country names in the dropdown.
  2. Updated the logic so that countries whose names start with the typed query appear first.
    • Used toLowerCase().startsWith(query.toLowerCase()) to check for prefix matches.
    • Optionally, I still included other matches (that contain the query later), but listed them after the prefix matches.
  3. Ensured the alphabetical order of countries remains consistent.
  4. Tested that typing "N" now shows countries like "Namibia", "Nepal", "Nigeria" first.
Oct 17 2025, 9:21 AM · Tool-paulina
DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..

Hello @DidiCoronel!
I think just before pushing I made a mistake in the css file. I've fixed that now, have a look: https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/90/diffs?diff_id=136659&start_sha=f7156e42826322923b25e9e1091c5a51585ba6e1

Hope it works fine now. I use chrome browser on Ubuntu 24.04.3

so sorry for the inconvenience!

Oct 17 2025, 9:16 AM · Tool-paulina

Oct 16 2025

DidiCoronel added a comment to T405621: Improve country dropdown for the "country of origin" filter in the advanced search for works..

The approach looks good, but I'm unable to reproduce the expected behavior on my Ubuntu environment on Firefox and Chrome.
This is how I see the dropdown.

image.png (917×768 px, 345 KB)

Oct 16 2025, 3:58 PM · Tool-paulina

Aug 1 2025

DidiCoronel created T401015: Create functional tests for the basic flows.
Aug 1 2025, 5:03 PM · Tool-paulina

Jun 17 2025

DidiCoronel claimed T397241: Authors page info displays wrong public domain message.
Jun 17 2025, 5:29 PM · Tool-paulina
DidiCoronel created T397241: Authors page info displays wrong public domain message.
Jun 17 2025, 5:27 PM · Tool-paulina
DidiCoronel added a comment to T393278: Improve country dropdown.

Feature implemented on Authors search but not on Works search yet.

Jun 17 2025, 5:20 PM · Tool-paulina

Mar 20 2025

DidiCoronel added a comment to T389444: Requesting GitLab account activation for davidcoronel.

Just requested Toolforge membership. Will wait to see how it goes.
Thanks!

Mar 20 2025, 3:05 PM · GitLab (Account Approval), Release-Engineering-Team

Mar 19 2025

DidiCoronel updated the task description for T389444: Requesting GitLab account activation for davidcoronel.
Mar 19 2025, 11:32 PM · GitLab (Account Approval), Release-Engineering-Team
DidiCoronel created T389444: Requesting GitLab account activation for davidcoronel.
Mar 19 2025, 11:27 PM · GitLab (Account Approval), Release-Engineering-Team

Feb 18 2025

DidiCoronel added a watcher for Tool-paulina: DidiCoronel.
Feb 18 2025, 7:13 PM

Aug 5 2024

DidiCoronel added a comment to T371399: Autoconfirm test users on test.wiki.
  • User:DidiCoronel
Aug 5 2024, 4:42 PM · Add A Fact (v0 Release - Aug 1, 2024), Future-Audiences