Works as expected.

Saw VE for both logged in and logged out(tested in incognito) users.

Since the commit addresses both: cmd + . works in mac, not cmd + ,(inferred behaviour)

Switches between duplicate and merge, depending on whether distance between links satisfies adjacency

Verifying, since there's no traction on previous feedback. Engineering team can look into feedback at a later time.

/w/index.php?title=Basic_example_test_sheet&veaction=edit:1 Access to XMLHttpRequest at 'https://www.mediawiki.org/w/api.php?action=query&format=json&origin=https%3A%2F%2Fen.wikipedia.beta.wmcloud.org&meta=userinfo%7Ctokens' from origin 'https://en.wikipedia.beta.wmcloud.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
jquery.js:9940 GET https://www.mediawiki.org/w/api.php?action=query&format=json&origin=https%3A%2F%2Fen.wikipedia.beta.wmcloud.org&meta=userinfo%7Ctokens net::ERR_FAILED
.
.
.
/w/index.php?title=Basic_example_test_sheet&veaction=edit:1 Access to XMLHttpRequest at 'https://www.mediawiki.org/w/api.php?action=query&format=json&origin=https%3A%2F%2Fen.wikipedia.beta.wmcloud.org&meta=userinfo%7Ctokens' from origin 'https://en.wikipedia.beta.wmcloud.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

In T416247#12034858, @DLynch wrote:

Very fuzzy QA requirements: "go to big talk pages on slow devices and see if they seem quicker to load now".

Well, and more pragmatically, is anything about the reply button and overflow menu broken?

Tested on en-beta:

Tested on enbeta using data from editcheck/editcheck-config.schema.json:

Test on enbeta

In T418197#12001401, @DLynch wrote:

Context: this is the same toast that's triggered by clicking the timestamp, so this was a long-ago behavioral decision. It could be revisited if we want.

Looks good to me. It's worth noting that the mobile experience has a scroll to view and expanded accordion flow.

In T420268#11847506, @ppelberg wrote:

In T420268#11774529, @EAkinloose wrote:

Suggestion mode state gets stuck if user tries toggling off after clicking the "Add citation" button...

@EAkinloose: great spot. Two follow-up questions for you:

1. What (if any) other issues/unexpected behavior (beyond the quoted bit above) did you encounter when QA'ing this task?
2. Could you please review T424101 and ensure it accurately describes the issue you encountered ?

Tested with accented characters:

"naive": "naïve",
"fööbar": "qüux",
"wîbble": "wôbble",
"frobnicate": "frob",
"qux": "xyzzy",
"plain": "éclair"

In T422931#11869925, @bmartinezcalvo wrote:

@medelius I've reviewed the fixed implementation in the patch and it looks good. Just the text style of the title in the bottom sheet should use the line-height-large (28px).

import errors do not affect the rest of the TextMatch work