Overall looking good!

Interactions by wiki

• I think the current mean per open is useful to see (especially as a way to compare between wikis), but would appreciate also having the total numbers. Would add one more line graph below to show totals for each variable - this will help show us how often generally these things are happening, not just per session.
• Wanted to clarify: the success rate of adding params means that someone adds, puts a value in, and then saves the dialog - correct?
• Can we add the success rate for editing parameters as well? Is this significantly more work?
• This is another area where I think it would be helpful to have the total of all wikis, plus ability to filter by the indiv wikis we are tracking. Already, I think it's interesting how significant the differences between them are.

Adding one more comment here. Was going through open questions on https://phabricator.wikimedia.org/T260157#6402243 and saw that @thiemowmde noted one other piece of missing current behavior:

Moved any open questions left into the subtickets

• Decided not to implement maximum number of item limitation at this time. We should keep an eye for if this causes any problems.
• Decided to add to number param types (in addition to those listen in the sub ticket)

Note: was not implemented on test instance but we still want to implement in real life. Renamed to reflect that.

This was very helpful to be able to test them both out in detail. After looking into this and discussing quite a bit, it's clear that both combo boxes (with and without filtering) have room for improvement. Goal was to understand which is most useful without any changes, and what would be the ideal state for each. Then to decide our next steps.

Thanks @thiemowmde and @Esanders !

Hey @Andrew-WMDE thanks for sharing the board for review. I have a few questions, some which came out of the discussions about the CodeMirror board and some which are related to just TemplateData.

@lilients_WMDE Thanks! I think it's much clearer and the table you made above is very helpful. I have a few follow-up comments and questions:

@thiemowmde Thanks for the helpful overview! Will review with @Lena_WMDE when she's back next week.

Oops realized a couple things - the first patch demo didn't work because I accidentally got a bit overzealous unchecking extensions and unchecked vector skin. The second worked, but made me realize that patch demo doesn't work because bracket matching is only on beta. -_- I basically just wanted to try out Ed's version in action to see how it looks and feels.

@lilients_WMDE Small note on the graphana intro text:

@devs - added this based on our quick convo, please update if not accurate.

Thanks @alexhollender !

@alexhollender agreed, would be good to have it all consistent. Thanks for offering, that would be great!

@alexhollender Thanks for bringing this change to our attention. I'm not sure this needs it's own ticket, I think the mocks just need to be updated in this ticket to reflect the checkbox vs radio button design: T265709: Merge Page Preview and Reference Preview preferences. It includes both the preference merge and the changed wording to the 'Previews' title to cover both pop-ups.

@alexhollender Agree, not much seems changed but the fact that it's centered seems like a nice improvement. Also seems like the icon is a bit larger, but that doesn't look like a problem to me. I think it'll be fine to eventually use the same, updated version on RefPreviews when we add the cog there.

Work on the test instance prototype is complete

@thiemowmde Thanks for tagging me, sorry this fell through the cracks. I agree both 2 & 3 are acceptable and I'm comfortable with RefPreviews using whichever the page previews team chose to implement.

You might already know this, but wanted to comment in case it's helpful. As we were looking at the current behavior on beta both Lena and I noticed the horizontal scrollbar was still showing up in Firefox (Chrome was fine for me). Let me know if screenshots are helpful (was using the same link as above).

@thiemowmde Thank you for sharing all these examples. It was very helpful, particularly in seeing that the location at the edge isn't the problem. I think the added whitespace feels a bit odd/more off than before (both the 1px and 8px options).

Also the required parameter change is checked but was not implemented:

Note: scope was reduced in order to meet deadline for usability testing. This ticket did not complete the investigation into pop-us.

Note from review: all bugs were fixed but in the process we realized that the following note was actually not fixing something we broke, but adding a new feature.

Support wikitext in template and parameter descriptions.

As a result of this, we noticed that it created new problems (esp with templates). If we implement this, we need to review.

Looks like a good suggestion. Thanks @thiemowmde

I just realized this is the perfect use of Patch Demo! I was introduced to it awhile ago so I'll see if I can get it working. Agree doesn't seem worth the hassle to get it onto the test instance.

With scrollbars:

Is there a reason that there is a horizontal scrollbar visible? It should only ever be a vertical one right?

@lilients_WMDE Ya I can see how this is not ideal, as people are looking for the message to disappear as they edit to see if their changes are the changes needed. I think it's good to mark this as an issue if we implement this, but would leave it for the prototype. Will be interesting to see if this assumption is true, I'll document if it's an issue or not.

Looking good to me. As discussed, ideally it would not appear until done typing but this is working well enough for testing. We can save that bit for later if this feature is chosen for implementation.

Looks fixed to me!

As discussed in the daily - unfortunately, More/Less expand collapse button and functionality has disappeared

Unfortunately, it looks like this is not totally resolved. Noticed when adding the template "Template:Quote" on the english test instance. Can take a look here: https://en-wmde-templates-alpha.wmcloud.org/wiki/User:Elco?veaction=edit

Sorry just saw all these comments! But I've tested it and it seems to be working well, so I'm happy with the decisions you made as you implemented it.

Noting here for the record: after daily decided that this last functionality is not necessary for testing and will not implement (adding undocumented parameters to templates without parameters). Even though this is definitely an important use case, we are not testing this feature.

Just checked and the current wording for Number and Date parameter warnings is incorrect. Please update it to match the wording in this ticket. Also if possible, switch it to the warning style. This is more important than adding the missing messages included in this task. Thanks!

Ok thought more about our discussion - let's change the blue to #36c.

Remove background highlighting for nested elements

Tested and it looks like the background highlighting is still there at the moment both with this and with the colorblind color scheme. This still needs to be removed

Looks like the accessibility typo is still there in your screenshot, though when I check on the test instance it's looking alright

Doesn't show "no parameters found"

If we're tight on time, this is acceptable to leave out for testing

Good points! I'm going to update the task description but will also give answers here.

Looks great! I think this is working to the level we need.

This is unfortunately not yet working for me - example, try adding Infobox book on the english test instance (or see here: https://en-wmde-templates-alpha.wmcloud.org/wiki/User:Elco?veaction=edit). The parameter 'Border' shows up in the correct place on the right hand side, but not in the left sidebar. (See TemplateData order: https://en-wmde-templates-alpha.wmcloud.org/wiki/Template:Infobox_book/doc)