Page MenuHomePhabricator

ECohen_WMDE (Elisha Cohen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 10 2020, 2:29 PM (79 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Elisha Cohen (WMDE) [ Global Accounts ]

Recent Activity

Today

ECohen_WMDE added a comment to T289041: Bug: VE template dialog inputs are unfocused and focused again.

I wasn't able to reproduce this to understand the issue. When I'm clicking back and forth between the two, focus seems to be working as expected for me.

Thu, Sep 16, 8:47 AM · WMDE-TechWish-Sprint-2021-09-15, WMDE-Templates-FocusArea, VisualEditor
ECohen_WMDE added a subtask for T289043: Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane: T289653: Screenreader support for the new VisualEditor template editor sidebar.
Thu, Sep 16, 8:44 AM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE added a parent task for T289653: Screenreader support for the new VisualEditor template editor sidebar: T289043: Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.
Thu, Sep 16, 8:44 AM · Accessibility, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290262: Add keyboard shortcuts for VE template dialog.
Thu, Sep 16, 8:43 AM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290262: Add keyboard shortcuts for VE template dialog.
Thu, Sep 16, 8:16 AM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea

Yesterday

ECohen_WMDE updated the task description for T290140: Handling non-existing templates in the new dialog.
Wed, Sep 15, 1:37 PM · WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290262: Add keyboard shortcuts for VE template dialog.
Wed, Sep 15, 1:02 PM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290140: Handling non-existing templates in the new dialog.
Wed, Sep 15, 12:51 PM · WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290140: Handling non-existing templates in the new dialog.
Wed, Sep 15, 10:47 AM · WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290140: Handling non-existing templates in the new dialog.
Wed, Sep 15, 10:45 AM · WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T290975: Synchronize scroll and focus when template dialog is in narrow-screen mode from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Sep 15, 8:10 AM · WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE moved T291059: [DRAFT] Adjust messages for special alias edge cases from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Sep 15, 8:10 AM · Patch-For-Review, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T107544: Consider removing the extra asterisk for the required parameters inside the template dialog.

Our new sidebar design fixes this problem, so I'm lowering the priority of fixing for the old interface.

I think once the VE template dialog updates are deployed, this ticket can be closed as our changes solve the issue.

Wed, Sep 15, 8:05 AM · Google-Code-In-2015, Design, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates, VisualEditor
ECohen_WMDE closed T285869: Add error handling for the undocumented parameter input as Resolved.

We reviewed this ticket during demo time. It was implemented according the requirements and can be closed. A few behaviors were noted as confusing and will be dealt with in a follow-up ticket T291059: [DRAFT] Adjust messages for special alias edge cases (currently a draft, ideal behavior TBD).

Wed, Sep 15, 7:58 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE moved T285869: Add error handling for the undocumented parameter input from Doing to Done on the WMDE-TechWish-Sprint-2021-09-01 board.
Wed, Sep 15, 7:58 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE closed T285869: Add error handling for the undocumented parameter input, a subtask of T272487: New input for undocumented parameters, as Resolved.
Wed, Sep 15, 7:58 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE closed T285869: Add error handling for the undocumented parameter input, a subtask of T290977: Hide "duplicate parameter" error message when it doesn't apply any more, as Resolved.
Wed, Sep 15, 7:57 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), WMDE-TechWish-Sprint-2021-09-15, WMDE-TechWish-Sprint-2021-09-01, Unplanned-Sprint-Work, WMDE-TechWish, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE created T291059: [DRAFT] Adjust messages for special alias edge cases.
Wed, Sep 15, 7:55 AM · Patch-For-Review, WMDE-Templates-FocusArea, WMDE-TechWish

Tue, Sep 14

ECohen_WMDE updated the task description for T289653: Screenreader support for the new VisualEditor template editor sidebar.
Tue, Sep 14, 10:44 AM · Accessibility, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T289043: Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.
Tue, Sep 14, 10:34 AM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE moved T276574: Add reactive notices and warnings in VE template dialog from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.
Tue, Sep 14, 9:00 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T272487: New input for undocumented parameters from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.
Tue, Sep 14, 8:49 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE moved T274554: Make sidebar responsive from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.
Tue, Sep 14, 8:34 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish-Sprint-2021-07-21, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T285869: Add error handling for the undocumented parameter input.

In this case, should we show the alias error (third attached mock), or the duplicate parameter error (first attached mock)?

After reading through, I think for this case we can simply show the alias error (third mock F34533178). From my understanding, the text still makes sense. I think this resolves all the above issues but if there is still something outstanding, let me know

Tue, Sep 14, 7:59 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish

Tue, Sep 7

ECohen_WMDE updated the task description for T290492: VE dialog margins/spacing off .
Tue, Sep 7, 3:09 PM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), WMDE-TechWish-Sprint-2021-09-01, WMDE-Templates-FocusArea
ECohen_WMDE moved T290492: VE dialog margins/spacing off from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.
Tue, Sep 7, 3:05 PM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), WMDE-TechWish-Sprint-2021-09-01, WMDE-Templates-FocusArea
ECohen_WMDE set the point value for T290492: VE dialog margins/spacing off to 3.
Tue, Sep 7, 3:05 PM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), WMDE-TechWish-Sprint-2021-09-01, WMDE-Templates-FocusArea
ECohen_WMDE created T290492: VE dialog margins/spacing off .
Tue, Sep 7, 3:05 PM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), WMDE-TechWish-Sprint-2021-09-01, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290262: Add keyboard shortcuts for VE template dialog.
Tue, Sep 7, 2:14 PM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE moved T290262: Add keyboard shortcuts for VE template dialog from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
Tue, Sep 7, 1:58 PM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE renamed T290262: Add keyboard shortcuts for VE template dialog from Make sure the template dialog is usable exclusively with the keyboard to Add keyboard shortcuts for VE template dialog.
Tue, Sep 7, 1:51 PM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T290262: Add keyboard shortcuts for VE template dialog.
Tue, Sep 7, 1:49 PM · Design, WMDE-Design, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T285869: Add error handling for the undocumented parameter input.
Tue, Sep 7, 1:44 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE updated the task description for T285869: Add error handling for the undocumented parameter input.
Tue, Sep 7, 1:44 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish

Fri, Sep 3

ECohen_WMDE updated subscribers of T285869: Add error handling for the undocumented parameter input.

@thiemowmde

Just disable the button when the input is not even a valid parameter name. Forbidden characters are {, =, |, and }.

If this is another case where the user is blocked, I think it makes sense to include an error message here as well while we are adding the rest. Such as "($symbol) is a forbidden character. Please remove it to add the parameter." Otherwise I'm not sure it would be totally clear as to why the button is disabled.

Fri, Sep 3, 1:42 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish

Thu, Sep 2

ECohen_WMDE renamed T287383: Increase contrast for line numbers (2017 wikitext editor) from Improve contrast for text color & background in line numbers to Increase contrast for line numbers (2017 wikitext editor).
Thu, Sep 2, 11:56 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea

Wed, Sep 1

ECohen_WMDE updated the task description for T276574: Add reactive notices and warnings in VE template dialog.
Wed, Sep 1, 2:15 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T276574: Add reactive notices and warnings in VE template dialog.

Re: non-existing templates

In the context of T290140: Handling non-existing templates in the new dialog I just wanted to note here, that we're currently planing on not showing the This template may be intended for use without parameters[2]. If this template does contain parameters, they are undocumented[4]. message for templates that do not exist on the wiki.

Wed, Sep 1, 2:13 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T288465: VE template dialog: Update description margins and help text.
Wed, Sep 1, 1:05 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE placed T287383: Increase contrast for line numbers (2017 wikitext editor) up for grabs.
Wed, Sep 1, 8:43 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea

Tue, Aug 31

ECohen_WMDE added a comment to T274554: Make sidebar responsive.

Toolbar icons are centered, which looks bad. @ECohen_WMDE button placement in full-width sidebar mode needs design.

Thanks for your patience - this slipped through the cracks a bit! It looks like on beta they were changed to align left. This is what I would have suggested and I think it looks good!

Tue, Aug 31, 1:54 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish-Sprint-2021-07-21, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T272487: New input for undocumented parameters.
Tue, Aug 31, 8:54 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE reopened T272487: New input for undocumented parameters, a subtask of T286992: Deploy VE template dialog improvements to small set of wikis, as Open.
Tue, Aug 31, 8:53 AM · Dagbani-Sites, VisualEditor-MediaWiki-Templates, VisualEditor, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE reopened T272487: New input for undocumented parameters as "Open".

This still needs the text updated from the comment above: T272487#7314421

Tue, Aug 31, 8:53 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T288465: VE template dialog: Update description margins and help text.

Ah right, forgot about this case when writing the ticket. In this case I would leave the existing help text as is. Don't remove it.

Tue, Aug 31, 7:43 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T288465: VE template dialog: Update description margins and help text.

TemplateData exists and includes a description: show the new help text given here, and the description from templatedata.

Yes. And if TemplateData exists but is missing a description, the description field will be empty but the help text will still show.

Tue, Aug 31, 7:12 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T276574: Add reactive notices and warnings in VE template dialog.

@WMDE-Fisch After some thought and talking through with Lena, we will go ahead and implement as-is.

Tue, Aug 31, 7:08 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea

Mon, Aug 30

ECohen_WMDE added a comment to T288465: VE template dialog: Update description margins and help text.

Noting that the "add unknown" input should probably get the same margins:

Mon, Aug 30, 11:40 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea

Fri, Aug 27

ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

I think this is correct. We alphabetize the unknown params, rather than show them in the order added or in the order given in the template invocation. (Note that when serialized, the template invocation order / order added are preserved.)

Oh I see! I wasn't part of the sprint review where this was discussed. Feel free to ignore the 'bug report' part of my comment then!

Fri, Aug 27, 10:12 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

Also after looking on beta, a few notes for the styling:

Screen Shot 2021-08-27 at 10.55.31.png (1×1 px, 383 KB)

Fri, Aug 27, 9:59 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

I've updated the task description and the mock to show the new description based on @awight and @thiemowmde 's feedback. It removes the phrase "existing undocumented parameters" and also removes the double negative from the second sentence:

Fri, Aug 27, 9:55 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE updated the task description for T272487: New input for undocumented parameters.
Fri, Aug 27, 9:52 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE updated the task description for T289659: Display message inviting users to take syntax highlighting survey.
Fri, Aug 27, 8:05 AM · MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T289659: Display message inviting users to take syntax highlighting survey.
Fri, Aug 27, 7:23 AM · MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea

Wed, Aug 25

ECohen_WMDE updated the task description for T289659: Display message inviting users to take syntax highlighting survey.
Wed, Aug 25, 1:43 PM · MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T289043: Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.

Documenting the decision here to not re-implement the on-scroll behavior and confirm the requirements as currently written in the task. Focus and sync-scrolling should only happen after a user has clicked somewhere, triggering a change.

Wed, Aug 25, 10:45 AM · WMDE-TechWish-Sprint-2021-09-15, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE renamed T287383: Increase contrast for line numbers (2017 wikitext editor) from Accessibility : Improve contrast for text color & background in line numbers to Improve contrast for text color & background in line numbers.
Wed, Aug 25, 10:27 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE moved T289653: Screenreader support for the new VisualEditor template editor sidebar from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Aug 25, 10:27 AM · Accessibility, VisualEditor, WMDE-Templates-FocusArea
ECohen_WMDE moved T285323: Implement keyboard navigation for VE template dialog from In preparation to In sprint on the WMDE-Templates-FocusArea board.
Wed, Aug 25, 9:16 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE moved T289659: Display message inviting users to take syntax highlighting survey from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
Wed, Aug 25, 9:16 AM · MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
ECohen_WMDE moved T287383: Increase contrast for line numbers (2017 wikitext editor) from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
Wed, Aug 25, 9:09 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T287383: Increase contrast for line numbers (2017 wikitext editor).
Wed, Aug 25, 9:09 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE moved T287383: Increase contrast for line numbers (2017 wikitext editor) from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Aug 25, 9:01 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE created T289659: Display message inviting users to take syntax highlighting survey.
Wed, Aug 25, 8:46 AM · MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T285323: Implement keyboard navigation for VE template dialog.
Wed, Aug 25, 8:21 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea

Mon, Aug 23

ECohen_WMDE added a comment to T276574: Add reactive notices and warnings in VE template dialog.

Is also missing. I will leave this link out for now.

Ya go ahead and leave out for now. I'm working on this at the moment but will just include this in the follow-up ticket with the others once the documentation has been updated since I'm not sure exactly when that's going to be. Currently have a placeholder but it needs work: T284985: [Placeholder] Add links to documentation throughout template VE workflow

Mon, Aug 23, 1:50 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE renamed T285323: Implement keyboard navigation for VE template dialog from Placeholder: implement access keys for VE template dialog to Implement keyboard navigation for VE template dialog.
Mon, Aug 23, 9:54 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T285669: VE Template Dialog: Remove [[]] button.
Mon, Aug 23, 9:52 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T285323: Implement keyboard navigation for VE template dialog.

Last comment: I think it would be helpful if the task description helped show the current progress. I'm not sure if the way that you updated it Friday @thiemowmde also reflects the current state?

Mon, Aug 23, 7:21 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T285323: Implement keyboard navigation for VE template dialog.

Just realized I forgot to respond to this one:

Spacebar toggles a checkbox on/off. Should enabling a checkbox with the spacebar move the focus to the content pane on the right? (Note that enter already does this.)

I think it's actually nice that they behave slightly differently, then a user has options. If they want to check a bunch of parameters, then they can move down the list using the spacebar. If they want to turn it on, then directly fill it out, they can press enter. I would leave it as it currently is then.

Mon, Aug 23, 7:15 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T285323: Implement keyboard navigation for VE template dialog.

Thanks @thiemowmde for the detailed breakdown! It's obviously quite complex. I have a few questions below to make sure that I'm clear on the issues before making any recommendations.

Mon, Aug 23, 7:10 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, Accessibility, WMDE-Templates-FocusArea

Fri, Aug 20

ECohen_WMDE added a comment to T272589: Aggregate VisualEditor TemplateData availability metrics.

How about we start by simply counting multi-template sessions to see how common the use case is. We could easily count these at open and save, which gives us * the percentage of sessions which involve multi-part transclusions, and * the success rate of multi-template sessions.

Sounds good! This seems like a simpler first step that would still give us useful information about that situation.

Fri, Aug 20, 8:40 AM · Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-07-07, WMDE-Templates-FocusArea, WMDE-TechWish (Sprint-2021-01-20)
ECohen_WMDE updated subscribers of T272589: Aggregate VisualEditor TemplateData availability metrics.

@awight @Andrew-WMDE @Lena_WMDE
For question #1 I agree that the second option is more meaningful and what we should go with:

"What proportion of sessions had templatedata available?" is answered by |A| / (|A| + |B|) = 99 / (99 + 1) = 0.99

The individual sessions are what we care about because we are tracking the times a user tries to make an edit and if TD supported them in doing that. If it's the same template it doesn't really matter since they want to do something different to it than last time and we just want to see if they can complete that action successfully.

Fri, Aug 20, 8:29 AM · Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-07-07, WMDE-Templates-FocusArea, WMDE-TechWish (Sprint-2021-01-20)

Aug 12 2021

ECohen_WMDE updated the task description for T272487: New input for undocumented parameters.
Aug 12 2021, 8:30 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish

Aug 11 2021

ECohen_WMDE moved T285660: CodeMirror: Disable line numbers for mobile devices from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.
Aug 11 2021, 2:17 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Browser-Support-Android-Google-Chrome, WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish, WMDE-Templates-FocusArea, MediaWiki-extensions-CodeMirror
ECohen_WMDE set the point value for T285660: CodeMirror: Disable line numbers for mobile devices to 3.
Aug 11 2021, 2:16 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Browser-Support-Android-Google-Chrome, WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish, WMDE-Templates-FocusArea, MediaWiki-extensions-CodeMirror
ECohen_WMDE renamed T273966: Show file preview for file type parameters in VE from DRAFT: Show file preview for file type parameters in VE to Show file preview for file type parameters in VE.
Aug 11 2021, 2:00 PM · Epic, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE renamed T273962: Custom input for file type parameters in VE - Link to Media Selector from DRAFT: Custom input for file type parameters in VE - Link to Media Selector to Custom input for file type parameters in VE - Link to Media Selector.
Aug 11 2021, 2:00 PM · Epic, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE closed T262813: Analyze actual usage of File and Page template parameters as Declined.

From storytime today:
We’re deciding not to do this research. Instead, the file preview will behave correctly according to which data type is in use. (ie. File type does not expect a prefix but page type accepts prefixes)

Aug 11 2021, 1:59 PM · WMDE-Templates-FocusArea
ECohen_WMDE set the point value for T285669: VE Template Dialog: Remove [[]] button to 3.
Aug 11 2021, 1:58 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE set the point value for T288465: VE template dialog: Update description margins and help text to 3.
Aug 11 2021, 1:57 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea

Aug 10 2021

ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

This adds very little technical complexity, no worries!

That's great news!

Aug 10 2021, 3:48 PM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

Heads up - design change coming but I'm still working out the details. Would like to discuss the technical complexity (or hopefully not!) of this change. Sorry for the last minute nature, just had the idea but think it has the potential to be a big improvement since we are now showing this input in significantly more situations (based on the decision to show when no params are documented, even if a template has TD).

Aug 10 2021, 3:29 PM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

I wanted to highlight an interaction with T288202: Parameter search also filters main content area: when the content area is being filtered, the undocumented parameter entry is hidden. This feels like an accident, can you confirm the intended behavior?

Aug 10 2021, 7:46 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE moved T276574: Add reactive notices and warnings in VE template dialog from Watching (Stalled / Epic) to Sprint Backlog on the WMDE-TechWish-Sprint-2021-08-04 board.
Aug 10 2021, 7:30 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE renamed T276574: Add reactive notices and warnings in VE template dialog from Reactive notices/warnings/descriptions in VE to Add reactive notices and warnings in VE template dialog.
Aug 10 2021, 7:30 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added projects to T288465: VE template dialog: Update description margins and help text: WMDE-TechWish, VisualEditor-MediaWiki-Templates.
Aug 10 2021, 7:29 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T288465: VE template dialog: Update description margins and help text from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.
Aug 10 2021, 7:27 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea

Aug 9 2021

ECohen_WMDE updated the task description for T276574: Add reactive notices and warnings in VE template dialog.
Aug 9 2021, 3:47 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-18, WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE created T288465: VE template dialog: Update description margins and help text.
Aug 9 2021, 3:39 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-09-01, WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T273966: Show file preview for file type parameters in VE from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
Aug 9 2021, 10:17 AM · Epic, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T273962: Custom input for file type parameters in VE - Link to Media Selector from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
Aug 9 2021, 10:17 AM · Epic, WMDE-TechWish, WMDE-Templates-FocusArea

Aug 6 2021

ECohen_WMDE added a comment to T285669: VE Template Dialog: Remove [[]] button.

Writing to confirm the notes - this was my understanding of our decisions as well. For your questions:

Aug 6 2021, 9:43 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), WMDE-TechWish-Sprint-2021-08-18, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea

Aug 5 2021

ECohen_WMDE updated the task description for T272487: New input for undocumented parameters.
Aug 5 2021, 3:48 PM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE closed T274549: Handle "no parameter" templates as Invalid.

Closing this as invalid because the implementation plan has changed. Requirements updated in T272487: New input for undocumented parameters to include this state (template with TD but no documented parameters) to show the undoc param input and associated notice. Wording to be updated there as well to cover this situation better and message to be changed from warning to notice as it's likely that nothing is actually wrong or needs fixing.

Aug 5 2021, 10:11 AM · WMDE-TechWish-Sprint-2021-08-04, Patch-For-Review, WMDE-TechWish-Sprint-2021-07-21, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE closed T274549: Handle "no parameter" templates, a subtask of T272368: Add checkboxes to param list sidebar in VE TemplateDialog, as Invalid.
Aug 5 2021, 10:11 AM · Epic, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T272487: New input for undocumented parameters.

I suggest that we update the metrics, to record a new event type "show undocumented param input" so we get an idea of how often this logic is triggered.

Aug 5 2021, 10:07 AM · WMDE-TechWish-Sprint-2021-09-01, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), WMDE-TechWish-Sprint-2021-08-18, Patch-For-Review, WMDE-TechWish-Sprint-2021-08-04, WMDE-Templates-FocusArea, WMDE-TechWish
ECohen_WMDE closed T274552: Synchronize scroll and focus between content and outline panes as Resolved.

Resolving this ticket based on our story time discussion yesterday. Created ticket for the follow-up work T288202: Parameter search also filters main content area.
Can the last box under requirements above be checked? @lilients_WMDE

Aug 5 2021, 10:02 AM · WMDE-TechWish-Sprint-2021-08-04, WMDE-TechWish-Sprint-2021-07-21, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE closed T274552: Synchronize scroll and focus between content and outline panes, a subtask of T272368: Add checkboxes to param list sidebar in VE TemplateDialog, as Resolved.
Aug 5 2021, 10:02 AM · Epic, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea
ECohen_WMDE moved T288202: Parameter search also filters main content area from Backlog to In sprint on the WMDE-Templates-FocusArea board.
Aug 5 2021, 10:00 AM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), WMDE-TechWish-Sprint-2021-08-04, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish, WMDE-Templates-FocusArea