Page MenuHomePhabricator

ECohen_WMDE (Elisha Cohen)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 10 2020, 2:29 PM (44 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Elisha Cohen (WMDE) [ Global Accounts ]

Recent Activity

Fri, Jan 15

ECohen_WMDE added a comment to T270243: Grafana board for TemplateData.

Overall looking good!

Fri, Jan 15, 3:25 PM · WMDE-QWERTY-Sprint-2021-01-06, WMDE-QWERTY-Sprint-2020-12-16, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Wed, Jan 13

ECohen_WMDE added a comment to T270242: Grafana board for VE Template Dialog.

Interactions by wiki

  • I think the current mean per open is useful to see (especially as a way to compare between wikis), but would appreciate also having the total numbers. Would add one more line graph below to show totals for each variable - this will help show us how often generally these things are happening, not just per session.
  • Wanted to clarify: the success rate of adding params means that someone adds, puts a value in, and then saves the dialog - correct?
  • Can we add the success rate for editing parameters as well? Is this significantly more work?
  • This is another area where I think it would be helpful to have the total of all wikis, plus ability to filter by the indiv wikis we are tracking. Already, I think it's interesting how significant the differences between them are.
Wed, Jan 13, 4:31 PM · WMDE-QWERTY-Sprint-2021-01-06, WMDE-QWERTY-Sprint-2020-12-16, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 4:17 PM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271898: DRAFT: Add combobox to VE to display suggested values.
Wed, Jan 13, 4:15 PM · VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T271399: Test instance: Disable filtering for comobobox widget.

Adding one more comment here. Was going through open questions on https://phabricator.wikimedia.org/T260157#6402243 and saw that @thiemowmde noted one other piece of missing current behavior:

Wed, Jan 13, 4:14 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).

Moved any open questions left into the subtickets

Wed, Jan 13, 3:15 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated the task description for T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).
Wed, Jan 13, 3:15 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated the task description for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 3:15 PM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).
  • Decided not to implement maximum number of item limitation at this time. We should keep an eye for if this causes any problems.
  • Decided to add to number param types (in addition to those listen in the sub ticket)
Wed, Jan 13, 3:13 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated the task description for T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).
Wed, Jan 13, 3:12 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated the task description for T271802: Fuzzier search - search for keywords out of order in template search (Template findability).
Wed, Jan 13, 1:07 PM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263533: TemplateData editor allow text input fields to expand/autosize.

Note: was not implemented on test instance but we still want to implement in real life. Renamed to reflect that.

Wed, Jan 13, 10:34 AM · WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE renamed T263533: TemplateData editor allow text input fields to expand/autosize from Test instance: TemplateData editor allow text input fields to expand to TemplateData editor allow text input fields to expand/autosize.
Wed, Jan 13, 10:34 AM · WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 10:34 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE edited projects for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor, added: TemplateData; removed Epic.
Wed, Jan 13, 10:32 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE edited projects for T271898: DRAFT: Add combobox to VE to display suggested values, added: VisualEditor-MediaWiki-Templates; removed Epic.
Wed, Jan 13, 10:32 AM · VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
ECohen_WMDE moved T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Jan 13, 10:31 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE moved T271898: DRAFT: Add combobox to VE to display suggested values from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Wed, Jan 13, 10:31 AM · VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 10:31 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE added a parent task for T271898: DRAFT: Add combobox to VE to display suggested values: T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 10:29 AM · VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
ECohen_WMDE added a subtask for T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor: T271898: DRAFT: Add combobox to VE to display suggested values.
Wed, Jan 13, 10:29 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE created T271898: DRAFT: Add combobox to VE to display suggested values.
Wed, Jan 13, 10:28 AM · VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
ECohen_WMDE created T271897: DRAFT: Add suggested values parameter property to TemplateData and to TemplateData editor.
Wed, Jan 13, 10:11 AM · VisualEditor, TemplateData, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271895: Update CodeMirror syntax highlighting color scheme to meet accessibility standards.
Wed, Jan 13, 9:45 AM · MediaWiki-extensions-CodeMirror, Community-Tech, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271895: Update CodeMirror syntax highlighting color scheme to meet accessibility standards.
Wed, Jan 13, 9:39 AM · MediaWiki-extensions-CodeMirror, Community-Tech, WMDE-Templates-FocusArea
ECohen_WMDE created T271895: Update CodeMirror syntax highlighting color scheme to meet accessibility standards.
Wed, Jan 13, 9:35 AM · MediaWiki-extensions-CodeMirror, Community-Tech, WMDE-Templates-FocusArea
ECohen_WMDE renamed T271802: Fuzzier search - search for keywords out of order in template search (Template findability) from DRAFT: (Template Findability, VE TemplateDialog, Template Wizard) Search for keywords out of order in template search / Fuzzier search to Fuzzier search - search for keywords out of order in template search (Template findability).
Wed, Jan 13, 8:59 AM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added projects to T271802: Fuzzier search - search for keywords out of order in template search (Template findability): MediaWiki-extensions-TemplateWizard, VisualEditor-MediaWiki-Templates.
Wed, Jan 13, 8:59 AM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Tue, Jan 12

thiemowmde awarded T271399: Test instance: Disable filtering for comobobox widget a Love token.
Tue, Jan 12, 5:49 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).
Tue, Jan 12, 5:24 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated subscribers of T271399: Test instance: Disable filtering for comobobox widget.

This was very helpful to be able to test them both out in detail. After looking into this and discussing quite a bit, it's clear that both combo boxes (with and without filtering) have room for improvement. Goal was to understand which is most useful without any changes, and what would be the ideal state for each. Then to decide our next steps.

Tue, Jan 12, 5:19 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE moved T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM) from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Tue, Jan 12, 4:51 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE created T271825: DRAFT: (TemplateData, VE Template Dialog) Add suggested values to TemplateData and the related input in VE (ENUM).
Tue, Jan 12, 4:19 PM · WMDE-Templates-FocusArea, Epic
ECohen_WMDE updated the task description for T271802: Fuzzier search - search for keywords out of order in template search (Template findability).
Tue, Jan 12, 2:32 PM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE moved T270926: Refine bracket matching styling from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2021-01-06 board.
Tue, Jan 12, 12:24 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
ECohen_WMDE closed T270926: Refine bracket matching styling as Resolved.

Thanks @thiemowmde and @Esanders !

Tue, Jan 12, 12:23 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
ECohen_WMDE closed T270926: Refine bracket matching styling, a subtask of T261857: Implement bracket matching in CodeMirror behind a feature flag, as Resolved.
Tue, Jan 12, 12:22 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), WMDE-QWERTY-Sprint-2020-12-16, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE moved T271802: Fuzzier search - search for keywords out of order in template search (Template findability) from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Tue, Jan 12, 11:53 AM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE created T271802: Fuzzier search - search for keywords out of order in template search (Template findability).
Tue, Jan 12, 11:52 AM · Community-Tech, VisualEditor-MediaWiki-Templates, VisualEditor, MediaWiki-extensions-TemplateWizard, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE moved T271800: DRAFT: (VE Template Dialog) Move parameter descriptions below field labels from Backlog to In preparation on the WMDE-Templates-FocusArea board.
Tue, Jan 12, 11:35 AM · WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE created T271800: DRAFT: (VE Template Dialog) Move parameter descriptions below field labels.
Tue, Jan 12, 11:34 AM · WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Mon, Jan 11

ECohen_WMDE updated subscribers of T270243: Grafana board for TemplateData.

Hey @Andrew-WMDE thanks for sharing the board for review. I have a few questions, some which came out of the discussions about the CodeMirror board and some which are related to just TemplateData.

Mon, Jan 11, 5:52 PM · WMDE-QWERTY-Sprint-2021-01-06, WMDE-QWERTY-Sprint-2020-12-16, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Fri, Jan 8

ECohen_WMDE added a comment to T270265: Grafana board for CodeMirror.

@lilients_WMDE Thanks! I think it's much clearer and the table you made above is very helpful. I have a few follow-up comments and questions:

Fri, Jan 8, 2:17 PM · WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-12-16, WMDE-Technical-Wishes-Team
ECohen_WMDE added a comment to T271399: Test instance: Disable filtering for comobobox widget.

@thiemowmde Thanks for the helpful overview! Will review with @Lena_WMDE when she's back next week.

Fri, Jan 8, 1:57 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T270926: Refine bracket matching styling.

Oops realized a couple things - the first patch demo didn't work because I accidentally got a bit overzealous unchecking extensions and unchecked vector skin. The second worked, but made me realize that patch demo doesn't work because bracket matching is only on beta. -_- I basically just wanted to try out Ed's version in action to see how it looks and feels.

Fri, Jan 8, 1:20 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
ECohen_WMDE added a comment to T270265: Grafana board for CodeMirror.

@lilients_WMDE Small note on the graphana intro text:

Fri, Jan 8, 10:17 AM · WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-12-16, WMDE-Technical-Wishes-Team

Thu, Jan 7

ECohen_WMDE moved T271399: Test instance: Disable filtering for comobobox widget from Backlog to In sprint on the WMDE-Templates-FocusArea board.
Thu, Jan 7, 11:32 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE added a project to T271399: Test instance: Disable filtering for comobobox widget: Unplanned-Sprint-Work.
Thu, Jan 7, 11:12 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE added a project to T271399: Test instance: Disable filtering for comobobox widget: WMDE-Technical-Wishes-Team.
Thu, Jan 7, 9:05 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE set the point value for T271399: Test instance: Disable filtering for comobobox widget to 1.

@devs - added this based on our quick convo, please update if not accurate.

Thu, Jan 7, 9:04 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea
ECohen_WMDE created T271399: Test instance: Disable filtering for comobobox widget.
Thu, Jan 7, 9:04 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2021-01-06, WMDE-Templates-FocusArea

Wed, Jan 6

ECohen_WMDE placed T235737: Discuss and decide on underspecified behavior for anonymous users up for grabs.
Wed, Jan 6, 9:03 AM · WMDE-Design, Page-Previews, WMDE-Technical-Wishes-Team, Design, Reference Previews

Dec 10 2020

ECohen_WMDE awarded T261961: Provide more context for articles in “Top read” a Love token.
Dec 10 2020, 3:55 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Android-app-feature-UX-Debt

Dec 4 2020

ECohen_WMDE moved T269094: Integrate bracket matching for CodeMirror with VisualEditor from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Dec 4 2020, 1:18 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), WMDE-QWERTY-Sprint-2020-12-16, Patch-For-Review, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE moved T261857: Implement bracket matching in CodeMirror behind a feature flag from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Dec 4 2020, 1:18 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), WMDE-QWERTY-Sprint-2020-12-16, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Nov 27 2020

ECohen_WMDE awarded T268842: Disabled components should display disabled labels a Like token.
Nov 27 2020, 7:44 AM · Wikidata, Wikidata Design System

Nov 24 2020

ECohen_WMDE added a comment to T265709: Merge Page Preview and Reference Preview preferences.

Thanks @alexhollender !

Nov 24 2020, 9:26 AM · WMDE-Technical-Wishes-Team, Reference Previews

Nov 17 2020

ECohen_WMDE added a comment to T267960: Update text on Preferences > Appearance > Reading preferences.

@alexhollender agreed, would be good to have it all consistent. Thanks for offering, that would be great!

Nov 17 2020, 5:26 PM · WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T267960: Update text on Preferences > Appearance > Reading preferences.

@alexhollender Thanks for bringing this change to our attention. I'm not sure this needs it's own ticket, I think the mocks just need to be updated in this ticket to reflect the checkbox vs radio button design: T265709: Merge Page Preview and Reference Preview preferences. It includes both the preference merge and the changed wording to the 'Previews' title to cover both pop-ups.

Nov 17 2020, 12:45 PM · WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T256504: Page previews cog should use OOUI settings icon.

@alexhollender Agree, not much seems changed but the fact that it's centered seems like a nice improvement. Also seems like the icon is a bit larger, but that doesn't look like a problem to me. I think it'll be fine to eventually use the same, updated version on RefPreviews when we add the cog there.

Nov 17 2020, 12:39 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, WMDE-QWERTY-Sprint-2020-10-21, UI-Standardization, Page-Previews

Nov 16 2020

ECohen_WMDE added a project to T261857: Implement bracket matching in CodeMirror behind a feature flag: MediaWiki-extensions-CodeMirror.
Nov 16 2020, 11:35 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), WMDE-QWERTY-Sprint-2020-12-16, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T260816: VE Dialog on the Test Instance: Sidebar and Dialog layout/behaviour changes.
Nov 16 2020, 10:44 AM · WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE closed T260816: VE Dialog on the Test Instance: Sidebar and Dialog layout/behaviour changes as Resolved.

Work on the test instance prototype is complete

Nov 16 2020, 10:44 AM · WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE created T267911: Add line numbering to syntax highlighting (CodeMirror extension) on first wikis.
Nov 16 2020, 10:34 AM · Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Nov 13 2020

ECohen_WMDE moved T261857: Implement bracket matching in CodeMirror behind a feature flag from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.
Nov 13 2020, 3:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), WMDE-QWERTY-Sprint-2020-12-16, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T256504: Page previews cog should use OOUI settings icon.

@thiemowmde Thanks for tagging me, sorry this fell through the cracks. I agree both 2 & 3 are acceptable and I'm comfortable with RefPreviews using whichever the page previews team chose to implement.

Nov 13 2020, 10:03 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, WMDE-QWERTY-Sprint-2020-10-21, UI-Standardization, Page-Previews

Nov 10 2020

ECohen_WMDE updated the task description for T261857: Implement bracket matching in CodeMirror behind a feature flag.
Nov 10 2020, 4:32 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), WMDE-QWERTY-Sprint-2020-12-16, WMDE-QWERTY-Sprint-2020-12-02, Community-Tech, MediaWiki-extensions-CodeMirror, Epic, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Nov 4 2020

ECohen_WMDE added a comment to T266859: More aggressive word wrapping in reference preview popups.

You might already know this, but wanted to comment in case it's helpful. As we were looking at the current behavior on beta both Lena and I noticed the horizontal scrollbar was still showing up in Firefox (Chrome was fine for me). Let me know if screenshots are helpful (was using the same link as above).

Nov 4 2020, 2:58 PM · WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE closed T249530: Move scrollbar to outer container as Resolved.

@thiemowmde Thank you for sharing all these examples. It was very helpful, particularly in seeing that the location at the edge isn't the problem. I think the added whitespace feels a bit odd/more off than before (both the 1px and 8px options).

Nov 4 2020, 2:56 PM · WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, Reference Previews

Nov 3 2020

ECohen_WMDE updated the task description for T263405: VE Dialog on the Test Instance: Implement soft validation.
Nov 3 2020, 12:54 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263405: VE Dialog on the Test Instance: Implement soft validation.

Also the required parameter change is checked but was not implemented:

Nov 3 2020, 12:54 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263405: VE Dialog on the Test Instance: Implement soft validation.

Note: scope was reduced in order to meet deadline for usability testing. This ticket did not complete the investigation into pop-us.

Nov 3 2020, 12:52 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T266320: Assorted bugfixes and last-minute features for test instance.

Note from review: all bugs were fixed but in the process we realized that the following note was actually not fixing something we broke, but adding a new feature.

Support wikitext in template and parameter descriptions.

As a result of this, we noticed that it created new problems (esp with templates). If we implement this, we need to review.

Nov 3 2020, 12:48 PM · Unplanned-Sprint-Work, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-10-21

Oct 30 2020

ECohen_WMDE added a comment to T266859: More aggressive word wrapping in reference preview popups.

Looks like a good suggestion. Thanks @thiemowmde

Oct 30 2020, 1:16 PM · WMDE-QWERTY-Sprint-2020-11-04, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team, Reference Previews

Oct 29 2020

ECohen_WMDE added a comment to T265482: On click [ref], jump down to references section.


nevermind...

Oct 29 2020, 2:51 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T265482: On click [ref], jump down to references section.

I just realized this is the perfect use of Patch Demo! I was introduced to it awhile ago so I'll see if I can get it working. Agree doesn't seem worth the hassle to get it onto the test instance.

Oct 29 2020, 2:44 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T265482: On click [ref], jump down to references section.

With scrollbars:

Is there a reason that there is a horizontal scrollbar visible? It should only ever be a vertical one right?

Oct 29 2020, 12:16 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team, Reference Previews

Oct 28 2020

ECohen_WMDE added a comment to T263405: VE Dialog on the Test Instance: Implement soft validation.

@lilients_WMDE Ya I can see how this is not ideal, as people are looking for the message to disappear as they edit to see if their changes are the changes needed. I think it's good to mark this as an issue if we implement this, but would leave it for the prototype. Will be interesting to see if this assumption is true, I'll document if it's an issue or not.

Oct 28 2020, 9:43 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Oct 26 2020

ECohen_WMDE added a comment to T266320: Assorted bugfixes and last-minute features for test instance.

Odd that's not happening for me?

Oct 26 2020, 9:49 AM · Unplanned-Sprint-Work, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-10-21
ECohen_WMDE added a comment to T263405: VE Dialog on the Test Instance: Implement soft validation.

Looking good to me. As discussed, ideally it would not appear until done typing but this is working well enough for testing. We can save that bit for later if this feature is chosen for implementation.

Oct 26 2020, 9:13 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T265356: Test instance: Sidebar checkboxes should match right-side content.

Looks fixed to me!

Oct 26 2020, 9:10 AM · WMDE-QWERTY-Sprint-2020-10-21, Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T266320: Assorted bugfixes and last-minute features for test instance.

As discussed in the daily - unfortunately, More/Less expand collapse button and functionality has disappeared

Oct 26 2020, 9:07 AM · Unplanned-Sprint-Work, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-10-21

Oct 23 2020

ECohen_WMDE reopened T265356: Test instance: Sidebar checkboxes should match right-side content as "Open".

Unfortunately, it looks like this is not totally resolved. Noticed when adding the template "Template:Quote" on the english test instance. Can take a look here: https://en-wmde-templates-alpha.wmcloud.org/wiki/User:Elco?veaction=edit

Oct 23 2020, 10:52 AM · WMDE-QWERTY-Sprint-2020-10-21, Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Templates-FocusArea

Oct 22 2020

ECohen_WMDE added a comment to T265029: Removing a parameter should not cause the outline to scroll.

Sorry just saw all these comments! But I've tested it and it seems to be working well, so I'm happy with the decisions you made as you implemented it.

Oct 22 2020, 2:43 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263573: VE Dialog on the Test Instance: Add undocumented parameters.

Noting here for the record: after daily decided that this last functionality is not necessary for testing and will not implement (adding undocumented parameters to templates without parameters). Even though this is definitely an important use case, we are not testing this feature.

Oct 22 2020, 12:21 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T263405: VE Dialog on the Test Instance: Implement soft validation.
Oct 22 2020, 8:39 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263405: VE Dialog on the Test Instance: Implement soft validation.

Just checked and the current wording for Number and Date parameter warnings is incorrect. Please update it to match the wording in this ticket. Also if possible, switch it to the warning style. This is more important than adding the missing messages included in this task. Thanks!

Oct 22 2020, 8:31 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Oct 21 2020

ECohen_WMDE added projects to T266112: Complex articles for usability testing tasks: WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2020-10-21, WMDE-Technical-Wishes-Team.
Oct 21 2020, 10:55 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-10-21, WMDE-Templates-FocusArea
ECohen_WMDE created T266112: Complex articles for usability testing tasks.
Oct 21 2020, 10:55 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-QWERTY-Sprint-2020-10-21, WMDE-Templates-FocusArea

Oct 20 2020

ECohen_WMDE added a comment to T263410: Test instance: Update CodeMirror color scheme.

Ok thought more about our discussion - let's change the blue to #36c.

Oct 20 2020, 2:18 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE updated the task description for T263405: VE Dialog on the Test Instance: Implement soft validation.
Oct 20 2020, 12:16 PM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263410: Test instance: Update CodeMirror color scheme.

Remove background highlighting for nested elements

Tested and it looks like the background highlighting is still there at the moment both with this and with the colorblind color scheme. This still needs to be removed

Oct 20 2020, 11:59 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263416: Test instance: add accessibility preference and colorblind-friendly syntax highlighting.

Looks like the accessibility typo is still there in your screenshot, though when I check on the test instance it's looking alright

Oct 20 2020, 11:51 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T263474: VE Dialog on Test Instance: Search for parameters within a template.

Doesn't show "no parameters found"

If we're tight on time, this is acceptable to leave out for testing

Oct 20 2020, 11:49 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Oct 19 2020

ECohen_WMDE renamed T220208: Hide graphics which do not fit and add notice from Add notice for graphics which do no work/fit in preview (tables, nav boxes) to Hide graphics which do not fit and add notice.
Oct 19 2020, 10:04 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, Patch-For-Review, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE moved T220208: Hide graphics which do not fit and add notice from Before Default to In preparation on the Reference Previews board.
Oct 19 2020, 9:08 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, Patch-For-Review, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE renamed T220208: Hide graphics which do not fit and add notice from Expandable tables inside of reference preview not working to Add notice for graphics which do no work/fit in preview (tables, nav boxes).
Oct 19 2020, 9:07 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, Patch-For-Review, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T220208: Hide graphics which do not fit and add notice.

Good points! I'm going to update the task description but will also give answers here.

Oct 19 2020, 9:04 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, Patch-For-Review, WMDE-Technical-Wishes-Team, Reference Previews
ECohen_WMDE added a comment to T263414: Change behaviour for adding/removing templates.

Looks great! I think this is working to the level we need.

Oct 19 2020, 8:32 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-10-07, WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
ECohen_WMDE added a comment to T265025: Test instance: Use TemplateData order in sidebar and content pane.

This is unfortunately not yet working for me - example, try adding Infobox book on the english test instance (or see here: https://en-wmde-templates-alpha.wmcloud.org/wiki/User:Elco?veaction=edit). The parameter 'Border' shows up in the correct place on the right hand side, but not in the left sidebar. (See TemplateData order: https://en-wmde-templates-alpha.wmcloud.org/wiki/Template:Infobox_book/doc)

Oct 19 2020, 8:29 AM · WMDE-QWERTY-Sprint-2020-10-21, WMDE-QWERTY-Sprint-2020-10-07, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea