EddieGP (Eddie Greiner-Petter)
Volunteer developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 6 2017, 6:31 PM (40 w, 3 d)
Availability
Available
IRC Nick
eddiegp
LDAP User
EddieGP
MediaWiki User
EddieGP

Located in Germany: CET (UTC+1)/CEST (UTC+2)

GPG: 84E7 0489 0F69 0544 0A59 86D8 C485 27CF 7D40 8CDE

Recent Activity

Wed, Nov 15

EddieGP created T180581: "Last edited" date is sometimes wrong.
Wed, Nov 15, 11:30 AM · MobileFrontend, Readers-Web-Backlog
EddieGP added a comment to T180548: Git 2.15: "git review -d" is broken since "-set-upstream" got removed.

I just noticed there already is a patch for this at https://review.openstack.org/#/c/517831/

Wed, Nov 15, 1:28 AM · Upstream, Gerrit
EddieGP created T180548: Git 2.15: "git review -d" is broken since "-set-upstream" got removed.
Wed, Nov 15, 1:08 AM · Upstream, Gerrit
EddieGP closed T180441: Temporary lift of IP cap from 2017-11-14 to 2017-11-21 as Resolved.

The throttle override is now set to be active between 2017-11-14 midnight UTC and 2017-11-22 midnight UTC (to include the whole of 2017-11-21). The limit is increased to be 50 registrations/24h (instead of normal 6 reg./24h). Have fun at your event! :-)

Wed, Nov 15, 12:54 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests

Tue, Nov 7

EddieGP added a comment to D613: Update group list.

No worries, that just happens sometimes. And sorry from my side too - for getting frustrated too easily (once again) and abandoning the patch earlier. I'm trying to grow a bit more patience about the code reviews in general, but that's haaaaard ;)

Tue, Nov 7, 8:52 AM

Mon, Nov 6

EddieGP reclaimed D613: Update group list.

I've just run across this tool again and noticed it's still broken in that the wrong groups are listed. So actually this still should be merged.

Mon, Nov 6, 10:32 PM
EddieGP updated the summary of D613: Update group list.
Mon, Nov 6, 10:32 PM

Fri, Nov 3

EddieGP closed T176566: Log when throttle exemption applied as Resolved.

This is now done - however, as described before, we do not know whether the throttle would have been applied if the exemption would not have existed.

Fri, Nov 3, 5:48 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP archived P6258 $dbw dump.
Fri, Nov 3, 12:15 PM
EddieGP created P6258 $dbw dump.
Fri, Nov 3, 12:14 PM
EddieGP created P6256 Query log.
Fri, Nov 3, 11:22 AM

Oct 12 2017

EddieGP closed T177705: REGRESSION - Option to suppress user accounts on blocks (hideuser) disappeared after migrating to OOjs UI as Resolved.

Tested. The suppress option only appears if you select an 'infinite' expiry time (which is okay as temporary hideuser blocks make no sense).

Oct 12 2017, 8:43 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Regression, Stewards-and-global-tools, MediaWiki-User-management

Oct 11 2017

EddieGP added a comment to T177705: REGRESSION - Option to suppress user accounts on blocks (hideuser) disappeared after migrating to OOjs UI.

Special:Block is now using OOUI again on group 0 & 1 (that is everything exept most -pedias). Could you have a look whether this works again now (preferably before this goes out to group 2 tomorrow)?

Oct 11 2017, 8:16 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Regression, Stewards-and-global-tools, MediaWiki-User-management
EddieGP updated the task description for T177974: Drop #wikimedia-codereview channel.
Oct 11 2017, 7:47 PM · Patch-For-Review, wikimedia-irc-freenode
EddieGP added a comment to T177974: Drop #wikimedia-codereview channel.

My vote is redirect to #wikimedia-dev

Oct 11 2017, 6:39 PM · Patch-For-Review, wikimedia-irc-freenode
EddieGP added a comment to T177974: Drop #wikimedia-codereview channel.

I haven't found any "irc-managers" or something like that tag, so Operations seemd to fit best. I thought about "dropping" as making it forward it to another (more popular) channel that will be used instead (maybe kicking people first? Don't know how forwarding works for people already in that channel).

Oct 11 2017, 6:13 PM · Patch-For-Review, wikimedia-irc-freenode
EddieGP created T177974: Drop #wikimedia-codereview channel.
Oct 11 2017, 6:03 PM · Patch-For-Review, wikimedia-irc-freenode
EddieGP moved T176754: Regularly purge expired temporary userrights from DB tables from Blocked external/Not db team to Backlog on the DBA board.

Per comments given on the patch, it will need a +1 from DBA to proceed. I'm moving this on your workboard so you are aware this needs your input, without any expectations when it may be done :)

Oct 11 2017, 12:01 AM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)

Oct 10 2017

EddieGP removed a project from T171208: contentadmin has suddenly less permissions: Patch-For-Review.
Oct 10 2017, 11:23 PM · wikitech.wikimedia.org, cloud-services-team
EddieGP closed T171208: contentadmin has suddenly less permissions as Resolved.

massmessage, nuke and spamblacklistlog are now available to contentadmin. The following rights remain as the difference between sysops and contentadmins and were not added as they are missing intentionally:

Oct 10 2017, 11:18 PM · wikitech.wikimedia.org, cloud-services-team
EddieGP moved T27000: Review and deploy ThrottleOverride extension to Wikimedia wikis from Backlog to Blocked on development on the Wikimedia-Extension-setup board.
Oct 10 2017, 9:56 PM · wikimedia-extension-review-queue, Possible-Tech-Projects, Wikimedia-Hackathon-2017, Wikimedia-Developer-Summit (2017), MediaWiki-extensions-ThrottleOverride, Wikimedia-Extension-setup

Oct 6 2017

EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

Let's stop meta-talking about the issue, and start working on it, ok?

Amen.

Oct 6 2017, 12:03 AM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)

Oct 4 2017

EddieGP added a comment to T176370: Migrate to PHP 7 in WMF production.

Probably. This task would block that; we can't change MW core until WMF production is migrated and stable on PHP7 instead of HHVM

Oct 4 2017, 8:26 PM · NewPHP, HHVM, TechCom-RfC, MediaWiki-Platform-Team, Operations
EddieGP lowered the priority of T176754: Regularly purge expired temporary userrights from DB tables from Normal to Low.

The issue here is that MediaWiki is keeping, with regards to temporary user rights, old and incorrect data as you correctly mention as well as others.

Oct 4 2017, 8:01 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP updated subscribers of T176754: Regularly purge expired temporary userrights from DB tables.

When digging a bit further into this, I found that it was somewhat (ableit for other reasons) discussed in T153817 and @MaxSem had https://gerrit.wikimedia.org/r/#/c/350961/ for it: When mw does the "get all groups for user X" operation, it already has to check if one of the results it got is about an expired group and filter that one out. Whenever an expired row was seen in that step, the patch would schedule a job (which just called UserGroupMembership::purgeExpired(); ) to clean up the table. I'd love to hear what the "different direction" mentioned when abandoning that patch was.

Oct 4 2017, 6:19 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP claimed T176754: Regularly purge expired temporary userrights from DB tables.

..of course pending that DBAs are ok with this running as cron.

Oct 4 2017, 1:00 AM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)

Oct 3 2017

EddieGP added a comment to T171208: contentadmin has suddenly less permissions.

Hmm. I think I can safely say we wouldn't want a contentadmin using tboverride

Oct 3 2017, 6:04 PM · wikitech.wikimedia.org, cloud-services-team

Oct 2 2017

EddieGP added a comment to T121378: Impossible to override an array-valued global created by extension registration.

Discussed again in T142663, the preferred solution is not not use flat arrays, but assoc ones instead.

Oct 2 2017, 5:05 PM · MediaWiki-Configuration
EddieGP merged T121378: Impossible to override an array-valued global created by extension registration into T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays.
Oct 2 2017, 5:04 PM · Patch-For-Review, MediaWiki-Configuration
EddieGP merged task T121378: Impossible to override an array-valued global created by extension registration into T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays.
Oct 2 2017, 5:04 PM · MediaWiki-Configuration
EddieGP added a comment to T171208: contentadmin has suddenly less permissions.

I know why at least one of those is considered a security-sensitive right.

Oct 2 2017, 12:05 AM · wikitech.wikimedia.org, cloud-services-team

Oct 1 2017

EddieGP updated subscribers of T171208: contentadmin has suddenly less permissions.

User rights explicitely removed from 'contentadmin' in CommonSettings.php:

Oct 1 2017, 11:03 PM · wikitech.wikimedia.org, cloud-services-team
EddieGP added a comment to T94149: Get rid of Zend 5.5 tests for wmf branches.

Should this be declined due to T176370?

Oct 1 2017, 8:27 PM · Release-Engineering-Team (Someday), Continuous-Integration-Config, Continuous-Integration-Infrastructure (Little Steps Sprint)

Sep 27 2017

EddieGP added a comment to T159028: Unpatrol moved pages on English Wikipedia.

So what is the official channel for getting the WMF to address these issues/requests - or is Phab simply the place they move stuff to they just don't want to do?

Sep 27 2017, 12:58 AM · Wikimedia-Site-requests
EddieGP added a comment to T176287: Lift IP cap for account creation for John Michael Kohler Art Center - Thur Sept 21, Sun Sept 24 & Tues Sept 26..

Can this be deployed?

Sep 27 2017, 12:55 AM · Patch-For-Review, Wikimedia-Site-requests
EddieGP added a comment to T159028: Unpatrol moved pages on English Wikipedia.

Question regarding this: it has been marked as blocked on development. Does this mean it is not moving forward? I am asking because of the potential impact it might have on gathering statistics during ACTRIAL if it is implemented in the middle of the trial.

Sep 27 2017, 12:32 AM · Wikimedia-Site-requests

Sep 26 2017

EddieGP renamed T176754: Regularly purge expired temporary userrights from DB tables from Temporary userrights not expiring in DB tables to Regularly purge expired temporary userrights from DB tables.
Sep 26 2017, 11:20 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

We could certainly think about running a cronjob for purging expired user groups.

Sep 26 2017, 11:19 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP added a comment to T173770: Code Review Hours advertised but not taking place?.

If we had a gerrit group for new users we could do a search for ownerin:'GROUP' but other than that I can't see any way to identify new users in gerrit.

Sep 26 2017, 10:57 PM · Developer-Relations
EddieGP added a comment to T173770: Code Review Hours advertised but not taking place?.

1 week seems pretty ambitious considering we currently have patches sitting for > 6 months, however, I agree that 1 week seems like a reasonable expectation for contributors. I can certainly imagine that, as a new contributor, I might start to feel discouraged after 1 weeks' time.

Sep 26 2017, 10:38 PM · Developer-Relations
EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

The problem is that we will never be able to ensure that rows are removed from the table the very second they expire. This means that when you run a query at 13:30, asking for user groups (of which one expired at 12:30) but the next purge is scheduled for 18:00, you'll see wrong results. Sure, purging more regularly (in terms of weeks or days instead of "when a new group is added") means the probability to run into this decreases and you'll see it less often. My point is that this won't be solving the bug, but only make it appear less often. The path forward to really fix it would be to update the consumers of that table.

Sep 26 2017, 3:21 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

I tested that on tyvwiki. I added myself to the administrator group and removed myself afterwards. Now the dbdata is up-to-date. However that expired entries ain't removed until any user is added to a new user group means that in some cases wrong or outdated data be displayed wrong indefinitely or for a very very long time. That is not okay IMHO.

Sep 26 2017, 3:12 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

This one was a bit longer temporary permission on angwiki:

(change visibility) 20:02, 26 April 2017 Vituzzu (talk | contribs | block) changed group membership for Vituzzu@angwiki from (none) to CheckUser (temporary, until 20:17, 26 April 2017) (checking abuse)

https://tools.wmflabs.org/rightstool/cgi-bin/rightslogsearch?user=%40angwiki shows there hasn't been any user rights changes on angwiki since that one.

Sep 26 2017, 3:07 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)
EddieGP added a comment to T176754: Regularly purge expired temporary userrights from DB tables.

mediawiki checks whether the timestamp given in ug_expiry is >= the current time. All other tools getting user group information from the database should be doing the same. So these expired rows don't really do any harm, they don't need to be removed immediately.

Sep 26 2017, 2:59 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, DBA, Operations, Community-Tech, MediaWiki-General-or-Unknown, Stewards-and-global-tools (Temporary-UserRights)

Sep 25 2017

Restricted Application updated subscribers of T104148: Change Squid references in Wikimedia configuration files.
Sep 25 2017, 10:54 PM · Patch-For-Review, Wikimedia-Site-requests
EddieGP reopened T176676: Some tools missing routes for trailing slash as "Open".

Sorry, saw your message just after that.

Sep 25 2017, 9:48 PM · XTools
EddieGP closed T176676: Some tools missing routes for trailing slash as Invalid.

For reference, we came from https://meta.wikimedia.org/w/index.php?title=Tech&oldid=17263651#Admin_activity_tool

Sep 25 2017, 9:47 PM · XTools
EddieGP added a comment to T176676: Some tools missing routes for trailing slash.

GET /adminstats/ is wrong, which is my mistake. I needs to be /adminstats (without trailing slash). There's no 404 then.

Sep 25 2017, 9:41 PM · XTools
EddieGP moved T176566: Log when throttle exemption applied from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 25 2017, 11:22 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T93719: Special:OverrideThrottle should show log extract for previous log entries from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 25 2017, 11:22 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T93719: Special:OverrideThrottle should show log extract for previous log entries from Backlog to Doing on the MediaWiki-extensions-ThrottleOverride board.
Sep 25 2017, 12:48 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP claimed T93719: Special:OverrideThrottle should show log extract for previous log entries.
Sep 25 2017, 12:48 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T174225: Offer option to disable captchas.

I've just looked into this, there really is no hook to tell ConfirmEdit (CAPTCHA extension) it should stop requiring captchas for ips we have an exemption for. I created T176589 for adding a hook that gets us this functionality. So this task is blocked until we've implemented T176589.

Sep 25 2017, 12:17 AM · MediaWiki-extensions-ThrottleOverride
EddieGP moved T176589: Offer a hook manipulating the need for solving captchas from Backlog to Meta / Tracking on the MediaWiki-extensions-ThrottleOverride board.
Sep 25 2017, 12:11 AM · ConfirmEdit (CAPTCHA extension), MediaWiki-extensions-ThrottleOverride
EddieGP added a project to T176589: Offer a hook manipulating the need for solving captchas: ConfirmEdit (CAPTCHA extension).
Sep 25 2017, 12:01 AM · ConfirmEdit (CAPTCHA extension), MediaWiki-extensions-ThrottleOverride

Sep 24 2017

EddieGP raised the priority of T176589: Offer a hook manipulating the need for solving captchas from High to Needs Triage.

Reset priority, which was inherited from the parent task.

Sep 24 2017, 11:59 PM · ConfirmEdit (CAPTCHA extension), MediaWiki-extensions-ThrottleOverride
EddieGP created T176589: Offer a hook manipulating the need for solving captchas.
Sep 24 2017, 11:59 PM · ConfirmEdit (CAPTCHA extension), MediaWiki-extensions-ThrottleOverride
EddieGP moved T176566: Log when throttle exemption applied from Backlog to Doing on the MediaWiki-extensions-ThrottleOverride board.
Sep 24 2017, 11:28 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP claimed T176566: Log when throttle exemption applied.
Sep 24 2017, 11:28 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T176566: Log when throttle exemption applied.

Famous last words. Not as simple as I thought: It's easy to identify whether ThrottleOverride returned "bypass this throttle, there's an exemption for it". This is what the patch does.

Sep 24 2017, 11:27 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T176566: Log when throttle exemption applied.

Oh, in that case it'd probably be a very simple thing.

Sep 24 2017, 10:24 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T176566: Log when throttle exemption applied.

We don't have this with the current implementation, has this ever been a problem?

Sep 24 2017, 12:22 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP closed T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays as Declined.

You can use array_keys( array_filter( $var ) )

Sep 24 2017, 10:25 AM · Patch-For-Review, MediaWiki-Configuration
EddieGP closed T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays, a subtask of T87915: Convert FlaggedRevs to use extension registration, as Declined.
Sep 24 2017, 10:25 AM · MediaWiki-extensions-FlaggedRevs
EddieGP raised the priority of T174186: Page is deadend after applying throttle from Low to Normal.
Sep 24 2017, 12:32 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP raised the priority of T62419: Types of throttles are hardcoded in SpecialOverrideThrottle::getFormFields from Low to Normal.
Sep 24 2017, 12:32 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays.

Is there some function that effectively maps boolean config variables to flat arrays internally in core? So one could have a config variable $wgVar = [ 'foo' => true, 'bar' => false, 'foobar' => true, 'baz' => 'false' ] and then call Something::getBooleanConfigAsFlatArray( 'wgVar' ) which would return [ 'foo', 'foobar' ]? I'm primarily interested in a way to simply iterate over a config variable (which works fine with flat arrays, but not with boolean ones, at least I'm not aware of a really short way) and wrote such a function for https://gerrit.wikimedia.org/r/#/c/380061/. Maybe it'd be worth to have such a helper function in core. That way one could use the boolean config variables and overwrite them in whatever way seems best, but still get config variables as flat arrays when it's necessary/easier at runtime.

Sep 24 2017, 12:30 AM · Patch-For-Review, MediaWiki-Configuration
EddieGP moved T62419: Types of throttles are hardcoded in SpecialOverrideThrottle::getFormFields from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 24 2017, 12:15 AM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride

Sep 23 2017

EddieGP added a comment to T91928: The Event Organiser's Userright.

Thank you for confirming that my statement "The proposed solution /when deployed/ will not not resolve the issue described" is true.

Sep 23 2017, 11:12 PM · MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T93468: ThrottleOverride should allow setting starting time and ending time.

While this is reasonable, I don't really see it as an deployment blocker for ThrottleOverride (that is, a feature this extension needs to be secure/usable like logging, ability to remove throttles etc.).

Sep 23 2017, 9:29 PM · MediaWiki-extensions-ThrottleOverride
EddieGP removed a subtask for T27000: Review and deploy ThrottleOverride extension to Wikimedia wikis: T93468: ThrottleOverride should allow setting starting time and ending time.
Sep 23 2017, 9:25 PM · wikimedia-extension-review-queue, Possible-Tech-Projects, Wikimedia-Hackathon-2017, Wikimedia-Developer-Summit (2017), MediaWiki-extensions-ThrottleOverride, Wikimedia-Extension-setup
EddieGP removed a parent task for T93468: ThrottleOverride should allow setting starting time and ending time: T27000: Review and deploy ThrottleOverride extension to Wikimedia wikis.
Sep 23 2017, 9:25 PM · MediaWiki-extensions-ThrottleOverride
EddieGP moved T174186: Page is deadend after applying throttle from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 23 2017, 9:03 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T62421: Log changes to throttle overrides from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 23 2017, 9:03 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP added a comment to T62420: Need way to remove throttle overrides.

Is there an easier way than having another special page for this? I'd like to avoid unnecessary special pages, but it seems something like Special:Unblock would be the easiest thing.

Sep 23 2017, 9:02 PM · MediaWiki-extensions-ThrottleOverride

Sep 22 2017

EddieGP added a comment to T173770: Code Review Hours advertised but not taking place?.

Honestly I feel that Wikimedia's code-review culture is a complete failure and needs significant overhaul.

I've submitted my first patch in February and I've felt that the system in place isn't perfect really quickly. That impression continuously increased and my motivation for further contributions, especially to mw core, continuously shrunk. As of today, I can only say that I completely agree with that statement and code review is the most frustrating part of wikimedia-land for me. And judging from the amounts of tasks, mailing lists threads, events, ... on this topic, there seem to be quite a few people who feel (or at least felt) that way.

Sep 22 2017, 10:02 PM · Developer-Relations
EddieGP placed T64103: Drop ss_admins from postgres up for grabs.

Not doing mw core work any more, at least in the short-term future.

Sep 22 2017, 8:37 PM · Technical-Debt, MediaWiki-Installer, PostgreSQL
EddieGP placed T56888: Fresh MW lists "-1 recent contributors" / Overhaul site_stats table up for grabs.
Sep 22 2017, 8:36 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Schema-change, Ladies-That-FOSS-MediaWiki, MediaWiki-Installer, MediaWiki-User-login-and-signup
EddieGP added a comment to T173770: Code Review Hours advertised but not taking place?.

IMHO:

  • I think #wikimedia-codereview shouldn't exist. This was already discussed on T128371 right after that channel was created and of course it "feels right" to have a dedicated place for something as "important as code review", but the effect basically is that fewer people take notice of these events. As I write this, 27 accounts are idle in that channel. #wikimedia-tech has 237. Move there, that automatically increases the number of people aware of the event - at least on the side of people being able to review and CR+2, as much more of them seem to actively look into #wikimedia-tech regularly.
  • The Technical Advice IRC meeting sends mails to wikitech-l (labs-l? mediawiki-l?) once a week (e.g. [2]). In addition, they announce these events on #mediawiki a few minutes before they start. Maybe CR hours should do the same.
  • When I asked for review in that channel several times around Feb/Mar this year, the only one noticing or able/willing to review was @mmodell and when looking into the logs it seems this hasn't changed. Tackle T129842 or find some other way to get a group of people in for actively looking for requests and reviewing changes (just like there's a group of people who are "swat deployers" and there's always somebody saying "I can swat today").
Sep 22 2017, 12:47 AM · Developer-Relations

Sep 21 2017

EddieGP triaged T174895: Convert ThrottleOverride to use a wiki page for storage as Low priority.

Is there some extension which might be used as a reference for storing data as json within a wiki page?
I'm personally only aware of extensions storing single strings per wiki page (like translations, a paragraph gets it's own page and each translation gets it's own page as well) but not of any storing structured data (e.g. json, yaml, whatever).

Sep 21 2017, 5:18 PM · MediaWiki-extensions-ThrottleOverride
EddieGP triaged T174816: Allow more than 1 IP range in a throttle as Low priority.

Having the backend store multiple entries into the database and thus applying multiple throttles at once isn't hard. A textbox with "one range per line" for the target field would do for just that, inserting one db entry for each target.
But those entries (after saving) cannot be related to each other in the current schema. Would we want to track exemptions that were created together (e.g. to change them all at once, delete them together etc.)? That needs changes to the current db schema as well as thoughts about the UI of ThrottleOverrideList.

Sep 21 2017, 3:59 PM · MediaWiki-extensions-ThrottleOverride
EddieGP triaged T174225: Offer option to disable captchas as High priority.
Sep 21 2017, 3:49 PM · MediaWiki-extensions-ThrottleOverride
EddieGP triaged T147367: Special page actions should have API equivalents as Normal priority.

T174895 is related.

Sep 21 2017, 3:48 PM · MediaWiki-extensions-ThrottleOverride
EddieGP triaged T93719: Special:OverrideThrottle should show log extract for previous log entries as Low priority.
Sep 21 2017, 3:47 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP claimed T62419: Types of throttles are hardcoded in SpecialOverrideThrottle::getFormFields.
Sep 21 2017, 3:46 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T62419: Types of throttles are hardcoded in SpecialOverrideThrottle::getFormFields from Done to Doing on the MediaWiki-extensions-ThrottleOverride board.
Sep 21 2017, 3:46 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T62419: Types of throttles are hardcoded in SpecialOverrideThrottle::getFormFields from WMF Deployment Blockers to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 21 2017, 3:46 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T174186: Page is deadend after applying throttle from WMF Deployment Blockers to Doing on the MediaWiki-extensions-ThrottleOverride board.
Sep 21 2017, 3:46 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP claimed T174186: Page is deadend after applying throttle.
Sep 21 2017, 3:45 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T27000: Review and deploy ThrottleOverride extension to Wikimedia wikis from WMF Deployment Blockers to Meta / Tracking on the MediaWiki-extensions-ThrottleOverride board.
Sep 21 2017, 3:44 PM · wikimedia-extension-review-queue, Possible-Tech-Projects, Wikimedia-Hackathon-2017, Wikimedia-Developer-Summit (2017), MediaWiki-extensions-ThrottleOverride, Wikimedia-Extension-setup
EddieGP moved T91928: The Event Organiser's Userright from WMF Deployment Blockers to Meta / Tracking on the MediaWiki-extensions-ThrottleOverride board.
Sep 21 2017, 3:44 PM · MediaWiki-extensions-ThrottleOverride

Sep 1 2017

EddieGP moved T174186: Page is deadend after applying throttle from Backlog to WMF Deployment Blockers on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:52 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T174221: Language::sprintfDate doesn't like infinity from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:19 PM · MediaWiki-extensions-ThrottleOverride
EddieGP closed T174221: Language::sprintfDate doesn't like infinity as Resolved.

As mentioned before, this is resolved by https://gerrit.wikimedia.org/r/198687

Sep 1 2017, 7:19 PM · MediaWiki-extensions-ThrottleOverride
EddieGP moved T152964: overridethrottle message is misleading from Backlog to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T50954: Add page for listing and removing throttle overrides from Backlog to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · MediaWiki-extensions-ThrottleOverride
EddieGP moved T62409: Warning: strtr() expects parameter 1 to be string, array given in /vagrant/mediawiki/includes/Html.php on line 555 from Backlog to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · MediaWiki-extensions-ThrottleOverride
EddieGP moved T152877: Hackathon Project: Get ThrottleOverride ready for WMF deployment from Backlog to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · Wikimedia-Developer-Summit (2017), MediaWiki-extensions-ThrottleOverride
EddieGP moved T147363: Purge expired throttles from Backlog to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride
EddieGP moved T174189: ooui-ify ThrottleOverride from Doing to Done on the MediaWiki-extensions-ThrottleOverride board.
Sep 1 2017, 7:17 PM · Patch-For-Review, MediaWiki-extensions-ThrottleOverride