Page MenuHomePhabricator

Edokter (Erwin Dokter)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 1:00 PM (258 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Edokter [ Global Accounts ]

Recent Activity

Jun 29 2016

Edokter added a comment to T138622: Help community migrate away from legacy Main page special casing.

@Jdlrobson I'm waiting for TemplateStyles to be deployed, but it has a major blocker in that it does not support media queries (see T135788), on which the new main page relies heavily. Other then that, I just have to ensure 100% consensus from the community :)

Jun 29 2016, 6:08 PM · Readers-Web-Backlog (Tracking), Readers-Community-Engagement, Reading-Web-Local-Wiki-Issues

Jun 19 2016

Edokter added a comment to T138159: Not allowing linebreaks in Special:Contributions options box causes side-scrolling.

A line break (\n) after each list item should provide a clean output allowing breaks.

Jun 19 2016, 8:28 AM · MediaWiki-Special-pages

May 27 2016

Edokter added a comment to T134515: "updated since my last visit" marker (updatedmarker) not styled in MW core, Vector.

It applies to all skins. But can we decide on a unified selector please?

May 27 2016, 3:21 PM · MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), UI-Standardization, UI-Standardization-Kanban, User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)), Design, Readers-Web-Backlog, Vector, MediaWiki-History-and-Diffs

May 26 2016

Nemo_bis awarded T76945: "center" does not center non-thumb image on tablets in Minerva a Pterodactyl token.
May 26 2016, 10:13 AM · Readers-Web-Backlog (Design), MobileFrontend

May 23 2016

Edokter added a comment to T483: RfC: Allow styling in templates.

I'm hoping to find some time to play around with TemplateStyles this week. I'm curious whether features such as url() will be totally banned or only banned for non-Wikimedia domains. If we're going to disallow certain kinds of CSS (i.e., if we're only going to allow a subset of CSS), we'll want to make sure that the documentation and user interface both make this clear early and often to prevent headaches and frustration.

May 23 2016, 11:46 AM · User-Ryasmeen, TechCom-RFC (TechCom-Approved), VisualEditor, Parsing-Team, Proposal, TemplateStyles, Wikimedia-Hackathon-2016

May 22 2016

Edokter added a comment to T46304: Categories should avoid orphans (single entries) when splitting a letter's entries into two columns ("Cont.").

To clarify, even if this is the older task, the code responsible for this bug is no longer present since Category view switched to CSS cloumns.

May 22 2016, 6:55 AM · MediaWiki-Categories
Edokter merged T46304: Categories should avoid orphans (single entries) when splitting a letter's entries into two columns ("Cont.") into T104541: Category pages causes articles to list in one row and the "letter" in another.
May 22 2016, 6:51 AM · MediaWiki-Categories
Edokter merged task T46304: Categories should avoid orphans (single entries) when splitting a letter's entries into two columns ("Cont.") into T104541: Category pages causes articles to list in one row and the "letter" in another.
May 22 2016, 6:51 AM · MediaWiki-Categories

May 5 2016

Edokter added a comment to T134515: "updated since my last visit" marker (updatedmarker) not styled in MW core, Vector.

If we're not touching the colors set in the other skins, they will override this, and the colors set in enwiki's common.css will have to remain.

May 5 2016, 7:58 PM · MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), UI-Standardization, UI-Standardization-Kanban, User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)), Design, Readers-Web-Backlog, Vector, MediaWiki-History-and-Diffs

Apr 25 2016

Edokter added a comment to T37704: Drop support in wikitext for inline styles.

This would remove the ability for dynamic styling (unless parser functions work inside <TemplateStyles>, but that is a coding nightmare), so that is a definite no for me. As @Nbdd0121 says, this is a super-breaking change, and wihtout a good rationale. Both inline and <style> have their uses, and neither has the full set of features that the other lacks.

Apr 25 2016, 8:35 PM · Community-consensus-needed, Epic, MediaWiki-Page-editing, Accessibility, MediaWiki-Interface

Apr 24 2016

Edokter added a comment to T132607: Increase font size for MathML.

@fredw, the current release version (45) still uses the internal font stack, which is why I find it odd we override it in the first place. But if the internal stack is removed, we may as well leave it.

Apr 24 2016, 6:32 PM · TCB-Team, German-Community-Wishlist, Math, Services

Apr 20 2016

Edokter added a comment to T483: RfC: Allow styling in templates.

I think scoping to #mw-content-text should be enough. Any tempate appearing outside actual content is usually protected anyway.

Apr 20 2016, 1:24 PM · User-Ryasmeen, TechCom-RFC (TechCom-Approved), VisualEditor, Parsing-Team, Proposal, TemplateStyles, Wikimedia-Hackathon-2016

Apr 19 2016

Restricted Application updated subscribers of T483: RfC: Allow styling in templates.

It should probably be avoided that templates can leak styles into that area.

Apr 19 2016, 3:30 PM · User-Ryasmeen, TechCom-RFC (TechCom-Approved), VisualEditor, Parsing-Team, Proposal, TemplateStyles, Wikimedia-Hackathon-2016

Apr 17 2016

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

OK, let me explain my exact goals again...

Apr 17 2016, 7:22 AM · Patch-For-Review, MediaWiki-General

Apr 16 2016

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.
Apr 16 2016, 5:20 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.
Apr 16 2016, 5:16 PM · Patch-For-Review, MediaWiki-General

Apr 7 2016

Edokter added a comment to T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup.
Apr 7 2016, 3:23 PM · MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release-notes, MediaWiki-General

Mar 25 2016

Edokter added a comment to T130846: Hat-note FOUC on mobile skin.

Yes, lets move all CSS inline to the templates... I think not. Why shouldn't the loading of Mobile.css be fixed instead?

Mar 25 2016, 4:29 PM · MobileFrontend

Mar 17 2016

Edokter added a comment to T116318: Images in tables are too small.

Where is the max-width coming from?

Mar 17 2016, 2:00 PM · Reading-Web-Local-Wiki-Issues, WorkType-Maintenance

Mar 8 2016

[[mw:User:Edokter]] <gerritpatchuploader@gmail.com> committed rSVEV35ca341ed4e9: Minor header fixes for Typography Refresh (authored by Edokter).
Minor header fixes for Typography Refresh
Mar 8 2016, 3:29 PM

Dec 30 2015

Edokter added a comment to T104541: Category pages causes articles to list in one row and the "letter" in another.

@MaxSem That breaks up the list, which creates accessability issues on its own. The better choice is to use column-break CSS. But browser support is fragmanted.

Dec 30 2015, 6:54 PM · MediaWiki-Categories

Dec 25 2015

Edokter added a comment to T121002: Double quote (") immediately after an external link looks ugly: icon is too close to the double quote.

From what I can see, the content is evenly spaced on both sides inside the quotes. Adding the margin would break that symmetry, which would look bad in ohter situations. Spacing also depends on client font metrics. Plus this adds micro-managing CSS bloat; we should not fall into these "1px"-trap because something looks off. Suggest WONTFIX.

Dec 25 2015, 9:28 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Design, good first bug, Vector

Dec 13 2015

Edokter added a comment to T74515: Vector and MobileFrontend should accept “Linux Libertine O” on Ubuntu for “Linux Libertine” usage.

I don't agree with removing Linux Libertine; I want Georgia removed. But anyway...

Dec 13 2015, 9:44 AM · Vector, Design, WMF-Design, UI-Standardization, Front-end-Standards-Group, MediaWiki-Interface

Dec 2 2015

Edokter added a comment to T112724: Add generic personal toolbar links for IP users to MediaWiki core.

I'll remove it. When will it be deployed?

Dec 2 2015, 5:24 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), User-notice, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Interface, JavaScript

Nov 22 2015

Edokter added a comment to T118792: "Uncaught TypeError: Cannot read property 'insertRule' of undefined" from MwEmbedSupport/Spinner.js .

I get this (blocking) error on any page on enwiki with an .ogg file on it. Chrome does not like somthing about the embedded player (that replaces the native player).

Nov 22 2015, 12:31 PM · MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, Multimedia, Regression, Wikimedia-production-error, JavaScript, MediaWiki-extensions-MwEmbedSupport

Nov 12 2015

Edokter added a comment to T118475: Quick survey breaks h2 and infobox positioning.

Yeah, I removed that, as it !forced any clears to none, which interfered with some templates.

Nov 12 2015, 9:56 PM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)), MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)), Reading Web Sprint 60 - Boom Headshot!, QuickSurveys

Nov 2 2015

Edokter added a comment to T108879: Collect font support metrics.

Wikipedia:Typography links to some archived font surveys that break down the installed fonts for each of the three popular platforms (Windows, Mac, Linux). Some will regard those as outdated, but it provides a good base non the less.

Nov 2 2015, 10:17 PM · UI-Standardization, Design

Oct 24 2015

Edokter added a comment to T116422: Remove Mediawiki's pre-translation of the &lang; and &rang; named entities.

Your guess is as good as mine. I found the code once, but now I searched the entire core and I can't find it anymore...

Oct 24 2015, 8:34 AM · MediaWiki-General

Oct 23 2015

Edokter updated the task description for T116422: Remove Mediawiki's pre-translation of the &lang; and &rang; named entities.
Oct 23 2015, 7:27 PM · MediaWiki-General
Edokter created T116422: Remove Mediawiki's pre-translation of the &lang; and &rang; named entities.
Oct 23 2015, 7:26 PM · MediaWiki-General

Oct 17 2015

Edokter added a comment to T104541: Category pages causes articles to list in one row and the "letter" in another.

That would be a terrible hack that defeats the purpose of using clumns in the first place.

Oct 17 2015, 6:08 PM · MediaWiki-Categories

Sep 25 2015

Edokter added a comment to T113741: DateInputWidget: popup CalendarWidget shouldn't have a blue border.

I don't think that is sufficient reason to remove focussing all together.

Sep 25 2015, 6:13 PM · MediaWiki-Interface, UI-Standardization

Sep 20 2015

Edokter added a comment to T112724: Add generic personal toolbar links for IP users to MediaWiki core.

I made some small modifications to the Dutch script, but I like having it closer to the MW implementation. I'll move the 'Create account' to the right, but I'm not sure what to do with the user page link: remove it or link it? Thoughts?

Sep 20 2015, 10:47 AM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), User-notice, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Interface, JavaScript

Sep 13 2015

Edokter closed T109935: Page titles on my en.wp watchlist are bolded for a half second, then back to unbolded as Invalid.

This is a local problem. Normally, unvisited pages on your watchlist are bolded. On enwiki, this is changed to a green bullet. Recently, changes to the ResourceLoader forced me to move the CSS associated with the watchlist to a gadget, to ensure the correct loading order.

Sep 13 2015, 6:19 PM · MediaWiki-Watchlist

Aug 29 2015

Edokter added a comment to T110749: Load all gadgets via ResourceLoader regardless of definition.

If a gadget doesn't work and other scripts are affected, I'm sure such admins will be taken to task pretty quick.

Aug 29 2015, 7:24 AM · Gadgets, JavaScript

Aug 22 2015

Edokter added a comment to T98878: Gallery styles should only be loaded on pages that need them (desktop and mobile).

I hope this trend is not pushing towards other (generic) classes, such as thumbs. Those are used by templates, and this may apply to galleries as well.

Aug 22 2015, 9:44 AM · Reading-Web-Sprint-56-Four Lions, WMF-deploy-2015-09-08_(1.26wmf22), Patch-For-Review, Reading-Web-Planning, MW-1.26-release, WMF-deploy-2015-09-01_(1.26wmf21), MediaWiki-Interface, MobileFrontend

Aug 12 2015

Edokter added a comment to T73240: Re-evaluate serif font stack for headers.

@Volker_E, You mean the font stack? Last revision is here, it then moved to a separate CSS page before it was killed off. Now, Common.js only loads two common Unicode fonts, and only on XP.

Aug 12 2015, 6:44 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), Design, Vector
Edokter added a comment to T73240: Re-evaluate serif font stack for headers.

We should not specify fonts that are marginally installed by default. Some time back, enwiki had a font stack for unicode fonts that included 30(!) fonts. It grew over the years because each time some glyph didn't work, another font was added. I ended up removing it as it started to interfere with the browser's glyph fallback. So let's not fall into that trap, lest we end up with 30 fonts.

Aug 12 2015, 3:19 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), Design, Vector

Aug 9 2015

Edokter added a comment to T107560: <abbr> is double-underlined in Firefox 40.

Glad you understand. We shouldn't use @supports for initial, there would be no end to it and we'd end up with duplicate rulesets everywhere. Just avoid initial where ever you can.

Aug 9 2015, 10:03 AM · WMF-deploy-2015-08-11_(1.26wmf18), MW-1.26-release, MediaWiki-Interface

Aug 8 2015

Edokter added a comment to T107560: <abbr> is double-underlined in Firefox 40.

@mxn, IE does support @supports in the nighlies, but not initial. So this creates a problem is they decide to implement text-decoration-style.

Aug 8 2015, 7:37 PM · WMF-deploy-2015-08-11_(1.26wmf18), MW-1.26-release, MediaWiki-Interface
Edokter added a comment to T107560: <abbr> is double-underlined in Firefox 40.

Oh dear, we just moved the problem from Firefox to Internet Explorer; IE does not support initial (and probably never will), but it will someday support text-decoration-style, which will cause the same problem we're trying to solve here. And it already supports @supports in the nightlies, where it will throw an unneeded CSS error in the console.

Aug 8 2015, 7:46 AM · WMF-deploy-2015-08-11_(1.26wmf18), MW-1.26-release, MediaWiki-Interface

Jul 30 2015

Edokter added a comment to T102077: Load bottom script "site" and "user" asynchronously.

Now site and user are loaded twice. @Krinkle calls this 'harmless', but it is extremely annoying having to dig through duplicate properties, not knowing where they come from. I also experience occasional load order issues and discrepancies between bedug and live loads.

Jul 30 2015, 7:56 PM · WMF-deploy-2015-08-04_(1.26wmf17), MW-1.26-release, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Jul 26 2015

Edokter created T106977: mw-ui-checkbox control does not respond in Opera 12.17.
Jul 26 2015, 12:09 PM · Browser-Support-Opera, MediaWiki-General

Jul 25 2015

Edokter added a comment to T99369: Remove client-side MathJax rendering mode.

Yes, Mathoid (which is nothing more than server-side MathJax for those who missed that...)

Jul 25 2015, 11:11 AM · WMF-deploy-2015-07-21_(1.26wmf15), Patch-For-Review, User-notice, Math

Jul 24 2015

Edokter added a comment to T99369: Remove client-side MathJax rendering mode.

What @DavidEppstein said...

Jul 24 2015, 7:16 PM · WMF-deploy-2015-07-21_(1.26wmf15), Patch-For-Review, User-notice, Math

Jul 21 2015

Edokter added a comment to T99369: Remove client-side MathJax rendering mode.

This comes as quite a shock... I was so glad to get rid of those awful PNGs. But it is not much of a suprise that it was unmaintainable due to the way MathJax was integrated.

Jul 21 2015, 3:29 PM · WMF-deploy-2015-07-21_(1.26wmf15), Patch-For-Review, User-notice, Math

Jul 11 2015

Edokter added a comment to T95739: Support dynamic columns directly in wikitext.

I don't think it is too hard using inline CSS; it is the most straightforward approach. Personally, I would choose [| and |] as column markers, with | (and |-) as optional column break points. That should not create a conflict with existing markup. HTML-wise, they should translate to somthing like:

Jul 11 2015, 12:13 PM · MediaWiki-Parser
Edokter added a comment to T65440: Please offer larger image thumbnail sizes in Special:Preferences.

I chose those values as they inherently include their own 1.5x and 2x versions (not al of them need to be listed in preferences though). The cleanup is due anyway. I once suggested an expiring mechanism for (existing) thumbs that have been stale for 90 days, but it requires a daily task to run.

Jul 11 2015, 7:49 AM · Operations, User-notice, Patch-For-Review, Performance-Team, Multimedia, Wikimedia-Site-requests

Jul 10 2015

Edokter added a comment to T69: Top bar of Phabricator should signify to users they are interacting with a Wikimedia project space.

But not so consistent with other projects like Gerrit.

Jul 10 2015, 3:26 PM · Patch-For-Review, Phabricator, Wikimedia Phabricator RfC
Edokter added a comment to T65440: Please offer larger image thumbnail sizes in Special:Preferences.

I think we should build on multiples of 120 and 160. That should result in the following common cached image sizes: 120, 160, 180, 240, 320, 360, 480, 640, 720, 960, 1280, 1440, 1920... with 240 as the default.

Jul 10 2015, 3:23 PM · Operations, User-notice, Patch-For-Review, Performance-Team, Multimedia, Wikimedia-Site-requests

Jul 9 2015

Edokter added a comment to T69: Top bar of Phabricator should signify to users they are interacting with a Wikimedia project space.

I ment if the Wikimedia logo should be black and white?

Jul 9 2015, 8:14 PM · Patch-For-Review, Phabricator, Wikimedia Phabricator RfC

Jul 8 2015

Edokter added a comment to T78418: Introduce MediaWiki:Mainpage.css.

I'm saying we could use existing code for that, for example: https://www.mediawiki.org/wiki/Extension:CSS and https://www.mediawiki.org/wiki/Extension:NewPageCSS

Jul 8 2015, 6:45 PM · Performance-Team, Technical-Debt, MediaWiki-ResourceLoader
Edokter added a comment to T78418: Introduce MediaWiki:Mainpage.css.

We already have several extensions that can load page-bound CSS. Why are these not used?

Jul 8 2015, 3:45 PM · Performance-Team, Technical-Debt, MediaWiki-ResourceLoader
Edokter added a comment to T68413: Obsolete style attributes like bgcolor are ignored by mobile site.

Good! Now we have an actual example of an obsolete attribute being removed from a browser. That will kill any argument claiming "but these attributes still work and will be supported forever!".

Jul 8 2015, 3:41 PM · MediaWiki-Parser, MediaWiki-Interface

Jul 6 2015

Edokter added a comment to T69: Top bar of Phabricator should signify to users they are interacting with a Wikimedia project space.

I'll have a shot at it. Does it have to be black-and-white?

Jul 6 2015, 5:32 PM · Patch-For-Review, Phabricator, Wikimedia Phabricator RfC

Jul 4 2015

Edokter added a comment to T104767: Vector: Both selected and un-selected .vectorTabs should have same defined height value.

Locally as in enwiki? I would also oppose that, as I do see other elements shrinking, such as the search box. So a universal box-sizing:border-box is ill-conceived. There is nothing in the way to choose border-box for certain elements, but it makes no sense whatsoever to apply it to all elements; they have been designed with content-box in mind after all.

Jul 4 2015, 6:01 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Google-Code-In-2016, Readers-Web-Backlog, good first bug, Vector
Edokter added a comment to T104767: Vector: Both selected and un-selected .vectorTabs should have same defined height value.

You may want to reword your proposal, because I somehow still have the idea that you want to apply the first snippet somewhere, and I would certainly oppose that.

Jul 4 2015, 5:26 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Google-Code-In-2016, Readers-Web-Backlog, good first bug, Vector
Edokter added a comment to T104767: Vector: Both selected and un-selected .vectorTabs should have same defined height value.

Sorry, I am wrong to asume the first snippet is not already in Vector? If not, why put a patch in core to fix a local CSS issue?

Jul 4 2015, 2:40 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Google-Code-In-2016, Readers-Web-Backlog, good first bug, Vector
Edokter added a comment to T104767: Vector: Both selected and un-selected .vectorTabs should have same defined height value.

Where can I see the bug in action?

Jul 4 2015, 1:06 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Google-Code-In-2016, Readers-Web-Backlog, good first bug, Vector
Edokter added a comment to T104486: Scripts loaded via importScript() are blocked from Googlebot.

Common.js still loads edit.js and watchlist.js through importScript; edit.js because of a seemingly longstanding bug T10912, and extra buttons for the old edit toolbar; and watchlist.js to add butons to dismiss watchlist messages.

Jul 4 2015, 12:42 PM · SEO, Performance-Team, JavaScript, MediaWiki-General

Jun 28 2015

Edokter added a comment to T104067: SyntaxHighlight in list item produces unbalanced HTML.

I would prefer T70466: Add parser test for multiline <pre> or <syntaxhighlight> elements inside a dd element created by ":", to suport better the usage of these elements inside of lists.

Jun 28 2015, 8:53 PM · WMF-deploy-2015-07-07_(1.26wmf13), Regression, SyntaxHighlight
Edokter added a comment to T104067: SyntaxHighlight in list item produces unbalanced HTML.

It has alwasy broken inside a list item wihtout the enclose=div option (which was a hack in itself). We should make it a good habit of no longer using it inside a wikilist item. Other then that, wether it is Tidy or the parser getting confused (I'd have to test using ExpandTemplates), the extension should always treat it as a new block context.

Jun 28 2015, 8:16 AM · WMF-deploy-2015-07-07_(1.26wmf13), Regression, SyntaxHighlight
Edokter renamed T104067: SyntaxHighlight in list item produces unbalanced HTML from Source highlighting doesn't work properly if the <source> tag begins in a wikitext list to Source highlighting doesn't work properly if the <source> tag does not start on a new line.
Jun 28 2015, 8:12 AM · WMF-deploy-2015-07-07_(1.26wmf13), Regression, SyntaxHighlight

Jun 21 2015

Edokter changed the status of T97299: WikiEditor styles are not loaded when editing any JS or CSS page from Duplicate to Resolved.
Jun 21 2015, 2:57 PM · WikiEditor
Edokter updated subscribers of T97299: WikiEditor styles are not loaded when editing any JS or CSS page.
Jun 21 2015, 2:56 PM · WikiEditor
Edokter merged task T102738: The textarea should not horizontal resizeable into T97299: WikiEditor styles are not loaded when editing any JS or CSS page.
Jun 21 2015, 2:56 PM · WMF-deploy-2015-06-23_(1.26wmf11), CodeEditor

Jun 14 2015

Edokter added a comment to T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window.

Then I was partly wrong, and it still presents a problem.

Jun 14 2015, 7:57 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector
Edokter added a comment to T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window.

Also, as @Krinkle hase pointed out in the patch, divs cannot have focus and thus cannot be navigated using the keyboard. That hurts accessability more then the purported middle-click would.

Jun 14 2015, 2:16 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector

Jun 9 2015

Edokter added a comment to T73240: Re-evaluate serif font stack for headers.

It is clear that the design team knows nothing about the technical aspects of web typography. All the issues raised here are real, especially the non-Latin use of fonts (and Georgia in particular). But perhaps I expect too much when trying to explain something that transcends outside the expertise of designers.

Jun 9 2015, 8:51 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), Design, Vector

Jun 8 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

Let me rephrase that: Declining a task should only be done if the request is eihter unreasonable, hard to implement or going against core design priciples. Neither of those apply, so no single dev can decline.

Jun 8 2015, 9:56 PM · Patch-For-Review, MediaWiki-General
Edokter reopened T94307: Page status indicator should not be automatically sorted outside main namespace as "Open".

Reopening... @Krinkle, you do not have the authority do decline this request, and I will not leave this alone until users have some control over ordering, wihtout having to revert to indicator name-hacking.

Jun 8 2015, 9:04 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T73240: Re-evaluate serif font stack for headers.

Those are the less distinct corrections. The core of the Typography Refresh--the actual fonts--would all be reverted to just "sans-serif".

Jun 8 2015, 8:52 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), Design, Vector
Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

To allow...?

Jun 8 2015, 2:26 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T73240: Re-evaluate serif font stack for headers.

I'm just about ready to fully support reverting back to sans-serif for the headers. There has been plenty of feedback from readers on mediawiki.org, and all of them are blissfully ignored. That is what happens when you stand by a change dispite its shortcomings.

Jun 8 2015, 8:35 AM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), Design, Vector

Jun 3 2015

Edokter added a comment to T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window.

Not convinced this needs action. It will also break any script interacting with the menu... again.

Jun 3 2015, 7:23 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector

Jun 2 2015

Edokter added a comment to T71998: Vector: h3 should not appear as heavier weight than h2.

I once already suggested throwing out Georgia as being diproportionate to the other fonts. See https://www.mediawiki.org/wiki/Talk:Typography_refresh#Header_fontstack. I also suggested ohter fontstacks that are very similair in design and metrics. But ditching Georgia is the main argument in all of them.

Jun 2 2015, 1:00 PM · I18n, Patch-For-Review, Vector

May 30 2015

Edokter added a comment to T100883: Missing dependencies for mediawiki.cookie causes javascript errors on en.wiki.

That did not clear the problem for me, so caching issue is server-side.

May 30 2015, 2:28 PM · MediaWiki-General
Edokter added a comment to T100883: Missing dependencies for mediawiki.cookie causes javascript errors on en.wiki.

Very possible. But these deploy/cahcing issues seem to become a weekly occurence.

May 30 2015, 11:56 AM · MediaWiki-General
Edokter created T100883: Missing dependencies for mediawiki.cookie causes javascript errors on en.wiki.
May 30 2015, 10:58 AM · MediaWiki-General

May 29 2015

Edokter added a comment to T97410: Make position of modules currently added with addModuleStyles explicit.

I thought the point of all CSS loading at top by default is that there is no point in loading CSS at the bottom. I can think of no scenario where CSS is not needed at page load. The only possible advantage is that content comes sooner, but you also risk style flashes.

May 29 2015, 8:21 AM · WMF-deploy-2015-06-16_(1.26wmf10), Patch-For-Review, WMF-deploy-2015-06-09_(1.26wmf9), Wikimedia-production-error, MW-1.26-release, WMF-deploy-2015-05-27_(1.26wmf8), MediaWiki-ResourceLoader, Performance-Team

May 24 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

How can it be a regression? It's a new feature with a new bug?

May 24 2015, 12:12 PM · Patch-For-Review, MediaWiki-General

May 23 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

@Jdforrester-WMF, I don't think there has been any case studies done with regards to indicator use, and I think you have no idea how indicators are used in real wiki-life. I am talking from experience and as the one how implemented it on enwiki, I get all the complaints regarding sorting.

May 23 2015, 5:54 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

Then discuss... I have put my arguments forward in that auto-sorting gives more trouble then advantages, and that sorting can easily be achieved localy instead.

May 23 2015, 4:46 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

Because I'd like to have this cleared before it gets released.

May 23 2015, 2:14 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T66477: Wrap MediaWiki toolbar menu to HTML5 <nav> and <aside> tag.

Any HTML5 will not degrade gracefully on IE8; while it safely ignores the tag, any associated CSS wil also be ignored.

May 23 2015, 12:48 PM · Accessibility, Patch-For-Review, MediaWiki-Interface
Edokter added a comment to T63801: Wrap MediaWiki footer to HTML5 <footer> tag.

Any HTML5 will not degrade gracefully on IE8; while it safely ignores the tag, any associated CSS wil also be ignored.

May 23 2015, 12:48 PM · Accessibility, Parsoid-DOM, MediaWiki-Interface
Gerrit Code Review <gerrit@wikimedia.org> committed rSKINb944b6afa8b4: Updated mediawiki/skins Project: mediawiki/skins/Vector… (authored by Edokter).
Updated mediawiki/skins Project: mediawiki/skins/Vector…
May 23 2015, 12:15 PM
[[mw:User:Edokter]] <gerritpatchuploader@gmail.com> committed rSVEC35ca341ed4e9: Minor header fixes for Typography Refresh (authored by Edokter).
Minor header fixes for Typography Refresh
May 23 2015, 12:14 PM
Edokter added a comment to T66653: Typography refresh fixup: list line-height, h1 margin, h3 font-size.

Final patch pending. Once merged, this can be closed.

May 23 2015, 12:09 PM · MediaWiki-Interface, Vector

May 19 2015

Edokter added a project to T94307: Page status indicator should not be automatically sorted outside main namespace: MW-1.25-release.
May 19 2015, 10:35 AM · Patch-For-Review, MediaWiki-General
Edokter added a project to T66653: Typography refresh fixup: list line-height, h1 margin, h3 font-size: MW-1.25-release.
May 19 2015, 10:32 AM · MediaWiki-Interface, Vector

May 17 2015

Edokter added a comment to T99416: In category pages page links may jump to another column when clicked .

Chrome bug to monitor: https://code.google.com/p/chromium/issues/detail?id=439820 (EDIT:) which is now marked as "fixed".

May 17 2015, 1:32 PM · Browser-Support-Google-Chrome, MediaWiki-Interface, MediaWiki-Categories
Edokter added a comment to T99335: Sandbox link should follow redirects.

I think the shortest path is, as @EoRdE6 points out, is to allow users to supress redirects, but only when moving from their own user space. What were the reasons this was shot down?

May 17 2015, 1:24 PM · MediaWiki-extensions-SandboxLink

May 16 2015

Edokter closed T99214: Add a switch on Special:Preferences to unenable the Sandboxlink as Declined.

This will lead to option-bloat. If there is a user option to disable this particular interface element, what about all the other elements that some editors don't want to see? There would be no end in sight. Therefor declined.

May 16 2015, 7:47 PM · MediaWiki-extensions-SandboxLink
Edokter added a comment to T99335: Sandbox link should follow redirects.

Perhaps supress the creation of a redirect by default when moving a draft.

May 16 2015, 6:45 AM · MediaWiki-extensions-SandboxLink

May 15 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

Again, no editor is directly using <indicator>, but uses templates, which there are a few hundreds of, and I am not about to go through them all again to add a name parameter, which has other disadvantages, like breaking id naming.

May 15 2015, 7:52 PM · Patch-For-Review, MediaWiki-General
Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

I don't understand the seemingly strong push for this request: what's so hard about making indicators have names which sort in the way you want, whatever it is?

May 15 2015, 3:50 PM · Patch-For-Review, MediaWiki-General
Ricordisamoa awarded T94307: Page status indicator should not be automatically sorted outside main namespace a Dislike token.
May 15 2015, 12:56 PM · Patch-For-Review, MediaWiki-General
Edokter updated the task description for T66653: Typography refresh fixup: list line-height, h1 margin, h3 font-size.
May 15 2015, 9:58 AM · MediaWiki-Interface, Vector
Edokter added a comment to T73477: Enable the MediaWiki UI / "Form Refresh" Beta Feature in production.

I'm with @Quiddity. What causes all the control to be misplaced? If checkboxes are placed on one line, I expect them to be on one line. The controls should behave as standard UI controls with regards to being placed inline or as block elements.

May 15 2015, 8:49 AM · UI-Standardization, Beta-Feature, Roadmap, Notice, Patch-For-Review, Wikimedia-Site-requests