Page MenuHomePhabricator

Edtadros (Edward Tadros)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 15 2019, 2:06 PM (13 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Edtadros [ Global Accounts ]

Recent Activity

Mon, Apr 15

Edtadros edited projects for T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail, added: Audiences-QA (RW-Test-Cases); removed Audiences-QA.
Mon, Apr 15, 4:37 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews
Edtadros reassigned T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail from Edtadros to ovasileva.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Mon, Apr 15, 4:36 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews

Sun, Apr 14

Edtadros moved T217298: Repurpose BetaOptinPanel as a Panel from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Sun, Apr 14, 11:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros assigned T217298: Repurpose BetaOptinPanel as a Panel to ovasileva.
Sun, Apr 14, 11:16 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros added a comment to T217298: Repurpose BetaOptinPanel as a Panel.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP (iPhoneX emulated on Chrome devtools)

Sun, Apr 14, 11:14 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros added a project to T218731: Regression: Mark all as read button in notifications overlay larger than header: Audiences-QA (RW-Test-Cases).
Sun, Apr 14, 10:54 PM · Audiences-QA (RW-Test-Cases), Notifications, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, Regression
Edtadros reassigned T218731: Regression: Mark all as read button in notifications overlay larger than header from Edtadros to ovasileva.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP, iPhoneX (Chrome devtools emulator)

Sun, Apr 14, 10:52 PM · Audiences-QA (RW-Test-Cases), Notifications, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, Regression
Edtadros reassigned T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field from Edtadros to nray.

Test Result

Sun, Apr 14, 10:36 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Edtadros moved T220159: Inline templates for mobile editor from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Sun, Apr 14, 9:23 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros reassigned T220159: Inline templates for mobile editor from Edtadros to nray.

@nray This needs QA steps.

Sun, Apr 14, 9:23 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Tue, Apr 9

Edtadros updated the task description for T219771: 'Confirm you want to leave' unload message shown when it shouldn't be.
Tue, Apr 9, 5:40 AM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros reassigned T219771: 'Confirm you want to leave' unload message shown when it shouldn't be from Edtadros to Ramsey-WMF.

**=== Test Result

Tue, Apr 9, 5:40 AM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros updated the task description for T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs.
Tue, Apr 9, 5:31 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
Edtadros reassigned T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs from Edtadros to Cparle.

Status: ❌ FAIL
OS: macOS Mojave
Browser: Chrome
Device: MBP

Tue, Apr 9, 5:29 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
Edtadros updated the task description for T215304: "Depicts walking": Add/edit depicts statements in UploadWizard.
Tue, Apr 9, 5:13 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata
Edtadros updated the task description for T215304: "Depicts walking": Add/edit depicts statements in UploadWizard.
Tue, Apr 9, 5:12 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata
Edtadros reassigned T215304: "Depicts walking": Add/edit depicts statements in UploadWizard from Edtadros to matthiasmullie.

Status: : ❌ FAIL
OS: macOS Mojave
Browser: Chrome

Tue, Apr 9, 5:10 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata
Edtadros reassigned T219874: It should be possible to view the desktop history page in AMC from Edtadros to ovasileva.

@Jdlrobson these are foolproof QA steps! Thanks!

Tue, Apr 9, 4:34 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Edtadros added a project to T219874: It should be possible to view the desktop history page in AMC: Audiences-QA (RW-Test-Cases).
Tue, Apr 9, 4:31 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Edtadros updated the task description for T219874: It should be possible to view the desktop history page in AMC.
Tue, Apr 9, 4:31 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Edtadros added a comment to T219874: It should be possible to view the desktop history page in AMC.

Status: ✅ PASS
OS: iOS
Browser: Chrome browser on (iPhone XS Max)

Tue, Apr 9, 4:30 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

Thu, Apr 4

Edtadros reassigned T219368: Basic depicts support for campaigns in UploadWizard from Edtadros to Cparle.

Reassigning to @Cparle to add "newbie" QA steps.

Thu, Apr 4, 2:20 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-on-a-big-boy-bicycle), Multimedia-Current-Work, Patch-For-Review, SDC Engineering, Multimedia
Edtadros added a project to T218807: [Bug] No history button shown on server rendered page (grade C browsers): Audiences-QA (RW-Test-Cases).
Thu, Apr 4, 1:51 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Edtadros added a project to T219028: [Bug] AMC toggle takes two taps to turn off/on: Audiences-QA (RW-Test-Cases).
Thu, Apr 4, 1:51 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Edtadros added a project to T216198: MFA: ImageOverlay should be an Overlay Composed of Components: Audiences-QA (RW-Test-Cases).
Thu, Apr 4, 1:50 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros added a project to T218304: Allow quicksurveys to target based on registration date: Audiences-QA (RW-Test-Cases).
Thu, Apr 4, 1:49 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
Edtadros added a project to T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen: Audiences-QA (RW-Test-Cases).
Thu, Apr 4, 1:48 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
Edtadros reassigned T219515: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state from Edtadros to Ramsey-WMF.
Thu, Apr 4, 1:48 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros added a comment to T219515: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state.

@Cparle thanks...updating the test result T219515#5085052 to ✅ Pass

Thu, Apr 4, 1:43 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros added a comment to T219515: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state.

Status: ❓Need More Info
OS: macOS Mojave
Browser: Chrome
Device: MBP

Thu, Apr 4, 1:32 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros reassigned T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen from Edtadros to ovasileva.
Thu, Apr 4, 4:48 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
Edtadros updated the task description for T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.
Thu, Apr 4, 4:46 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
Edtadros added a comment to T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.

Status: ✅ PASS
OS: iOS
Browser: Safari
Device: iPhone X

Thu, Apr 4, 4:46 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
Edtadros added a comment to T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.

This is waiting on clarification of the QA criteria in T215597

Thu, Apr 4, 1:13 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T215597: QA edit tags for moderation actions.

@Tbayer Can you help define "tagged accordingly" in the QA Criteria. I don't want to make any assumptions as I recall this is a very important task.

Thu, Apr 4, 1:12 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Apr 4, 1:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.
Thu, Apr 4, 1:03 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.

@pmiazga thanks for clarifying this. I have updated T212216#5047451 with the info you provided.

Thu, Apr 4, 1:00 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.

@pmiazga please go to the very bottom of T212216#5047451 the only item remaining to test is AC9 for Arabic. You helped me test it before. It appears we are looking for a page with the discussion tab and project page tab, but I'm not entirely sure.

Thu, Apr 4, 12:29 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Apr 4, 12:14 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros reassigned T213352: AMC: add history link to actions menu from Edtadros to ovasileva.

Status: In Progress
OS: iOS
Browser: Chrome (iPhoneXS Max and iPad Pro)

Thu, Apr 4, 12:09 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions

Wed, Apr 3

Edtadros reassigned T201339: Cannot access user contributions when following red link to user page on mobile from Edtadros to Jdlrobson.
Wed, Apr 3, 1:27 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Advanced Mobile Contributions, MobileFrontend
Edtadros updated the task description for T201339: Cannot access user contributions when following red link to user page on mobile.
Wed, Apr 3, 1:27 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Advanced Mobile Contributions, MobileFrontend
Edtadros added a comment to T201339: Cannot access user contributions when following red link to user page on mobile.

*OS: macOS Mojave
Browser:** Chrome DevTools Device Emulator (iPhone X)

Wed, Apr 3, 1:25 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Advanced Mobile Contributions, MobileFrontend

Tue, Apr 2

Edtadros updated the task description for T218304: Allow quicksurveys to target based on registration date.
Tue, Apr 2, 10:25 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
Edtadros reassigned T218304: Allow quicksurveys to target based on registration date from Jdlrobson to ovasileva.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Tue, Apr 2, 10:23 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
Edtadros added a comment to T218304: Allow quicksurveys to target based on registration date.

@Jdlrobson and @pmiazga thanks for your help. I should have been clearer. I only included the "Central user log in" page as informational because I don't recall seeing it before. I am still seeing the survey for AC1. That is the reason I failed. I did try again with HTTPS and sure enough I don't see the "Central user log in" page, but I am still seeing the survey.

Tue, Apr 2, 9:50 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
Edtadros reassigned T218304: Allow quicksurveys to target based on registration date from Edtadros to Jdlrobson.

Status: ❌ FAIL
OS: macOS Mojave
Browser: Chrome

Tue, Apr 2, 9:33 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
Edtadros claimed T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Tue, Apr 2, 5:11 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T218304: Allow quicksurveys to target based on registration date.

@Jdlrobson Those are some seriously personalized QA steps!

Tue, Apr 2, 12:23 AM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys

Mon, Apr 1

Edtadros claimed T213352: AMC: add history link to actions menu.
Mon, Apr 1, 5:11 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions

Sat, Mar 30

Edtadros reassigned T217157: Make sure federation works on beta from Edtadros to Ramsey-WMF.
Sat, Mar 30, 4:50 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Statements (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia
Edtadros updated the task description for T217157: Make sure federation works on beta.
Sat, Mar 30, 4:50 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Statements (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia
Edtadros added a comment to T217157: Make sure federation works on beta.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 4:49 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Statements (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia
Edtadros reassigned T216763: Add "remove all" and "learn more" to statement from Edtadros to Ramsey-WMF.
Sat, Mar 30, 4:35 PM · SDC Engineering, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), Multimedia, Patch-For-Review
Edtadros added a comment to T216763: Add "remove all" and "learn more" to statement .

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 4:34 PM · SDC Engineering, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), Multimedia, Patch-For-Review
Edtadros reassigned T218318: Can't save after deleting a statement (and not doing anything else) from Edtadros to Ramsey-WMF.
Sat, Mar 30, 4:26 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
Edtadros added a comment to T218318: Can't save after deleting a statement (and not doing anything else).

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 4:24 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
Edtadros updated the task description for T218629: Auto-suggest dropdown for statements is too short.
Sat, Mar 30, 4:14 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros reassigned T218629: Auto-suggest dropdown for statements is too short from Edtadros to Ramsey-WMF.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 4:13 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros reassigned T218431: [Alpha/Labs] Basic Search labels + help text need updating from Edtadros to matthiasmullie.

@matthiasmullie I believe I can make out the test steps from the Acceptance Criteria. Can you let me know what environment (URL would be helpful) I should be testing this in?

Sat, Mar 30, 4:02 PM · SDC-Statements (Depicts-on-training-wheels), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
Edtadros updated the task description for T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs.
Sat, Mar 30, 3:53 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
Edtadros reassigned T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs from Edtadros to Cparle.

@Cparle I have a few questions about the QA steps.

Sat, Mar 30, 3:51 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
Edtadros reassigned T199120: Build search/depicts prototype from Edtadros to Ramsey-WMF.

@Ramsey-WMF This all passes.

Sat, Mar 30, 3:59 AM · Multimedia-Current-Work, SDC-Statements (Depicts-on-training-wheels), SDC Engineering (Depicts and other statements on a bicycle), Patch-For-Review, Multimedia, Multimedia-Team-Working-Board
Edtadros updated the task description for T199120: Build search/depicts prototype.
Sat, Mar 30, 3:59 AM · Multimedia-Current-Work, SDC-Statements (Depicts-on-training-wheels), SDC Engineering (Depicts and other statements on a bicycle), Patch-For-Review, Multimedia, Multimedia-Team-Working-Board
Edtadros added a comment to T199120: Build search/depicts prototype.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 3:56 AM · Multimedia-Current-Work, SDC-Statements (Depicts-on-training-wheels), SDC Engineering (Depicts and other statements on a bicycle), Patch-For-Review, Multimedia, Multimedia-Team-Working-Board
Edtadros updated the task description for T215304: "Depicts walking": Add/edit depicts statements in UploadWizard.
Sat, Mar 30, 3:12 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata
Edtadros reassigned T215304: "Depicts walking": Add/edit depicts statements in UploadWizard from Edtadros to matthiasmullie.

=== Test Result

Sat, Mar 30, 3:09 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata
Edtadros updated the task description for T218628: Structured fields don't show a notice about IP logging for users who aren't logged in.
Sat, Mar 30, 2:35 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Multimedia-Current-Work, SDC Design, Multimedia
Edtadros added a comment to T218628: Structured fields don't show a notice about IP logging for users who aren't logged in.

Status: ❓ Please review
OS: macOS Mojave
Browser: Chrome

Sat, Mar 30, 2:31 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Multimedia-Current-Work, SDC Design, Multimedia
Edtadros reassigned T216198: MFA: ImageOverlay should be an Overlay Composed of Components from Edtadros to ovasileva.
Sat, Mar 30, 1:29 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros updated the task description for T216198: MFA: ImageOverlay should be an Overlay Composed of Components.
Sat, Mar 30, 1:29 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros added a comment to T216198: MFA: ImageOverlay should be an Overlay Composed of Components.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Sat, Mar 30, 1:28 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros reassigned T201339: Cannot access user contributions when following red link to user page on mobile from Edtadros to Jdlrobson.

@Jdlrobson the QA steps state that both IP or Registered user links should allow you to access their contributions using links at the top of the page. I was only able to get the links for the registered user.

Sat, Mar 30, 1:15 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Advanced Mobile Contributions, MobileFrontend
Edtadros added a comment to T201339: Cannot access user contributions when following red link to user page on mobile.

Status: ❓ *OS: macOS Mojave
Browser:** Chrome DevTools Device Emulator (iPhone X)

Sat, Mar 30, 1:12 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Advanced Mobile Contributions, MobileFrontend

Fri, Mar 29

Edtadros reassigned T219028: [Bug] AMC toggle takes two taps to turn off/on from Edtadros to ovasileva.
Fri, Mar 29, 11:48 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T219028: [Bug] AMC toggle takes two taps to turn off/on.
Fri, Mar 29, 11:47 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T219028: [Bug] AMC toggle takes two taps to turn off/on.

Status: ✅ PASS
OS: iOS
Browser: Chrome on (iPhone XS Max)

Fri, Mar 29, 11:45 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T218807: [Bug] No history button shown on server rendered page (grade C browsers).
Fri, Mar 29, 11:38 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Edtadros reassigned T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Edtadros to ovasileva.

Status: ✅ PASS
OS: iOS
Browser: Safari on (iPhone XS Max)

Fri, Mar 29, 11:36 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Edtadros updated subscribers of T219028: [Bug] AMC toggle takes two taps to turn off/on.

@Jdlrobson Where do I test this? I am still seeing this behavior in Prod.

Fri, Mar 29, 2:41 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Edtadros reassigned T217296: Use the Overlay.make pattern for notification feature from Edtadros to ovasileva.

@ovasileva This was tested on the URL that @Jdlrobson provided (thanks!), but the QA Steps state it should also be run in an RTL language. So I'm putting it in needs more work. If you don't need another language this can go to Ready for Signoff.

Fri, Mar 29, 2:32 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros updated the task description for T217296: Use the Overlay.make pattern for notification feature.
Fri, Mar 29, 2:07 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Edtadros added a comment to T217296: Use the Overlay.make pattern for notification feature.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X, iPad Pro)

Fri, Mar 29, 2:06 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Thu, Mar 28

Edtadros reassigned T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias from Edtadros to ovasileva.

@ovasileva The table in the description summarizes what I have found. Please let me know if you have any questions.

Thu, Mar 28, 11:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Mar 28, 11:03 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.

Need more information to test. See T215597#5068061

Thu, Mar 28, 11:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros assigned T215597: QA edit tags for moderation actions to ovasileva.

@ovasileva I need more detail on with regards to what the validations will be for each of the QA Criteria listed in the description. It might be obvious, but I'm not certain what "tagged accordingly"

Thu, Mar 28, 10:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Mar 28, 9:50 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.

Tag Thanks actions with AMC tag

T215477

Thu, Mar 28, 9:49 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T215477: Tag Thanks actions with AMC tag.

Status: ✅ PASS
OS: iOS
Browser: Chrome browser on (iPhone XS Max)

Thu, Mar 28, 9:47 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Product-Analytics, Advanced Mobile Contributions, Growth-Team, Thanks
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Mar 28, 9:30 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Thu, Mar 28, 9:28 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.

Remove AMC Article/Talk tabs from main page

T214724

Thu, Mar 28, 9:27 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T214724: Remove AMC Article/Talk tabs from Main page.

Status: ✅ PASS
OS: iOS
Browser: Chrome browser on (iPhone XS Max)

Thu, Mar 28, 9:26 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214195: Design updates to Settings page & AMC opt-in toggle.
Thu, Mar 28, 9:08 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Mar 28, 9:08 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.

Design updates to Settings page & AMC opt-in toggle

T214195

Thu, Mar 28, 9:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T214195: Design updates to Settings page & AMC opt-in toggle.

Status: ✅ PASS
OS: iOS
Browser: Chrome browser on (iPhone XS Max)

Thu, Mar 28, 9:04 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.
Thu, Mar 28, 8:49 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Advanced Mobile Contributions