Page MenuHomePhabricator

Edtadros (Edward Tadros)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 15 2019, 2:06 PM (5 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Edtadros [ Global Accounts ]

Recent Activity

Thu, Feb 21

Edtadros reassigned T191562: Special:MobileLanguages tweaks (label and margin) from Edtadros to ovasileva.

Thanks for the clarification, @Jdlrobson and @alexhollender.

Thu, Feb 21, 9:42 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Design (RW-Design-Debt), good first bug, MobileFrontend, Mobile
Edtadros updated the task description for T191562: Special:MobileLanguages tweaks (label and margin).
Thu, Feb 21, 9:41 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Design (RW-Design-Debt), good first bug, MobileFrontend, Mobile
Edtadros reassigned T214697: Move blue links on user page from Jdlrobson to ovasileva.
Thu, Feb 21, 6:23 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214697: Move blue links on user page.
Thu, Feb 21, 6:22 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T214697: Move blue links on user page.

@alexhollender good catch. QA the QA! I will update the test results with the correct screenshot.
@Jdlrobson I'm seeing the same thing.

Thu, Feb 21, 6:18 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T214697: Move blue links on user page from Edtadros to Jdlrobson.

@Jdlrobson , I want to be sure before I pass this. The AC states " This should be for all user pages (not just AMC mode)". I tried a few other user pages but none of them had the links. Did you mean that this should work for the specific page in the task description but for all scenarios (AMC on, AMC off, and not logged in)?

Thu, Feb 21, 7:35 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214697: Move blue links on user page.
Thu, Feb 21, 7:32 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T214697: Move blue links on user page.

Status: Need Clarification before passing.
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Thu, Feb 21, 7:31 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T212376: Extract pageIssues.js view code from Edtadros to ovasileva.
Thu, Feb 21, 7:04 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Edtadros updated the task description for T212376: Extract pageIssues.js view code.
Thu, Feb 21, 7:04 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Edtadros added a comment to T212376: Extract pageIssues.js view code.

Status: ✅ PASS
OS: macOS Mojave, iOS 12.1.4
Browser: Chrome DevTools Device Emulator (iPhone X, iPad, Galaxy S5), Safari on iOS

Thu, Feb 21, 7:03 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Edtadros reassigned T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation from Edtadros to ovasileva.
Thu, Feb 21, 6:42 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros updated the task description for T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.
Thu, Feb 21, 6:41 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

Acceptance Criteria #1

Thu, Feb 21, 6:41 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros reassigned T216514: Add talk button to AMC main page from Edtadros to ovasileva.
Thu, Feb 21, 6:35 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Advanced Mobile Contributions
Edtadros updated the task description for T216514: Add talk button to AMC main page.
Thu, Feb 21, 6:34 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Advanced Mobile Contributions
Edtadros added a comment to T216514: Add talk button to AMC main page.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Thu, Feb 21, 6:32 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Advanced Mobile Contributions
Edtadros reassigned T214658: Separate Lazy loading code from Skin.js from Edtadros to ovasileva.

Thanks @Jdlrobson, the clarification really helped!

Thu, Feb 21, 6:06 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros updated the task description for T214658: Separate Lazy loading code from Skin.js.
Thu, Feb 21, 6:04 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros added a comment to T214658: Separate Lazy loading code from Skin.js.

Status: ✅ PASS
OS: iOS 12.1.4
Browser: Safari

Thu, Feb 21, 6:02 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros reassigned T191562: Special:MobileLanguages tweaks (label and margin) from Edtadros to Jdlrobson.

@Jdlrobson This could be a pass depending on how particular you want to be with regards to alignment.

Thu, Feb 21, 5:50 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Design (RW-Design-Debt), good first bug, MobileFrontend, Mobile
Edtadros updated the task description for T191562: Special:MobileLanguages tweaks (label and margin).
Thu, Feb 21, 5:48 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Design (RW-Design-Debt), good first bug, MobileFrontend, Mobile
Edtadros added a comment to T191562: Special:MobileLanguages tweaks (label and margin).

Status: Not Complete
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Thu, Feb 21, 5:44 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Design (RW-Design-Debt), good first bug, MobileFrontend, Mobile
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Thu, Feb 21, 12:19 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T214724: Remove AMC Article/Talk tabs from Main page from Edtadros to ovasileva.

Status:Not Complete
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Thu, Feb 21, 12:16 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Tue, Feb 19

Edtadros reassigned T214658: Separate Lazy loading code from Skin.js from Edtadros to Jdlrobson.

@Jdlrobson, For the last two steps:

Tue, Feb 19, 1:19 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros reassigned T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation from Edtadros to Jdrewniak.

@Jdrewniak I am not sure how to verify the z-order variables. I'm not sure I have access. You can walk me through it, or just provide me a test artifact of some sort....screen shot, code snippet, etc...

Tue, Feb 19, 12:59 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros updated the task description for T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.
Tue, Feb 19, 12:57 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

Acceptance Criteria #2: The bug is fixed.

Tue, Feb 19, 12:48 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros reassigned T214724: Remove AMC Article/Talk tabs from Main page from Jdlrobson to ovasileva.

I updated the QA comments in the description and the test artifacts in T214724#4962141 to reflect the clarification from T214724#4962164 for Step #4.

Tue, Feb 19, 12:05 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Tue, Feb 19, 12:01 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Mon, Feb 18

Edtadros updated the task description for T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.
Mon, Feb 18, 5:56 PM · Readers-Web-Backlog (Design), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
Edtadros reassigned T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable from Edtadros to alexhollender.

Status: ❌ FAIL
OS: iOS12.1.4
Browser: Safari iPhone XS Max

Mon, Feb 18, 5:55 PM · Readers-Web-Backlog (Design), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
Edtadros reassigned T214724: Remove AMC Article/Talk tabs from Main page from Edtadros to Jdlrobson.

@Jdlrobson Can you take a look at the QA steps 3 and 4. When I toggle AMC off I see the Discussion button. When I toggle it on, I don't see it. It seems like a Fail, but I wanted to make sure the QA steps were correct.

Mon, Feb 18, 5:42 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Mon, Feb 18, 5:37 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Mon, Feb 18, 5:36 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T214724: Remove AMC Article/Talk tabs from Main page.

Status:Not Complete
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Mon, Feb 18, 5:35 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Mon, Feb 18, 5:26 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214724: Remove AMC Article/Talk tabs from Main page.
Mon, Feb 18, 5:26 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Thu, Feb 14

Edtadros reassigned T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event) from Edtadros to ovasileva.
Thu, Feb 14, 2:50 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Edtadros updated the task description for T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Thu, Feb 14, 2:49 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Edtadros updated the task description for T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Thu, Feb 14, 2:49 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Edtadros added a comment to T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Thu, Feb 14, 2:47 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Edtadros reassigned T211197: Build AMC opt-in toggle from Edtadros to ovasileva.

Thanks @phuedx!

Thu, Feb 14, 2:43 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T211197: Build AMC opt-in toggle.
Thu, Feb 14, 2:42 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Wed, Feb 13

Edtadros claimed T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).
Wed, Feb 13, 6:13 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)

Tue, Feb 12

Edtadros added a comment to T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event).

@Jdlrobson I just want to be sure of the following:

Tue, Feb 12, 6:07 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Edtadros reassigned T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation from Edtadros to alexhollender.

@Jdrewniak & @alexhollender I'm not sure if this is a feature or a bug, but the "Learn more" link appears right justified when I check it with a phone aspect ratio but left justified when I check it with a tablet or desktop. I am happy to document the test for tablets or desktop, but when I click the hamburger with a phone emulation, the link goes off screen to the right so I cannot verify it. Let me know how you'd like me to proceed.

Tue, Feb 12, 5:10 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Edtadros reassigned T215536: Regression: Nested references do not work from Edtadros to ovasileva.
Tue, Feb 12, 4:46 AM · MinervaNeue, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros updated the task description for T215536: Regression: Nested references do not work.
Tue, Feb 12, 4:39 AM · MinervaNeue, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros added a comment to T215536: Regression: Nested references do not work.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Tue, Feb 12, 4:37 AM · MinervaNeue, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros reassigned T215648: Regression: UBN! Languages feature broken on beta cluster from Edtadros to ovasileva.
Tue, Feb 12, 4:09 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros updated the task description for T215648: Regression: UBN! Languages feature broken on beta cluster.
Tue, Feb 12, 4:08 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros added a comment to T215648: Regression: UBN! Languages feature broken on beta cluster.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Tue, Feb 12, 4:07 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Edtadros updated the task description for T211197: Build AMC opt-in toggle.
Tue, Feb 12, 3:57 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T211197: Build AMC opt-in toggle.
Tue, Feb 12, 3:54 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T211197: Build AMC opt-in toggle.
NOTE: This testing only covers the first four testing criteria listed in the description and listed (numbered) here for convenience
Tue, Feb 12, 3:46 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Thu, Feb 7

Edtadros added a comment to T212959: Create AMC edit tag.

@ovasileva, you are correct.

Thu, Feb 7, 6:12 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T211197: Build AMC opt-in toggle.

@ovasileva, Just in case my network continues misbehaving during today's standup, I think (and @phuedx agrees) that it would be helpful for me to work with the engineer for verifying the 5th acceptance criteria (When a user opts in to (or out of) the AMC mode we need to ensure it is logged and compatible with Schema:PrefUpdate in WikimediaEvents ...we also get T212516 fixed for free!). If @Jdlrobson is up for it we can do a hangout later today.

Thu, Feb 7, 2:58 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T211197: Build AMC opt-in toggle from pmiazga to Jdlrobson.

@Jdlrobson I checked and verified that the AMC toggle appears when logged in, and doesn't appear when not logged in. I can pass it if those are the only QA criteria. My concern is that the acceptance criteria list a few more items. Do you have steps you can provide for the rest of the criteria?

Thu, Feb 7, 7:11 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T211197: Build AMC opt-in toggle.
Thu, Feb 7, 6:55 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated the task description for T214180: Add informational links to AMC opt-in toggle.
Thu, Feb 7, 6:52 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T214180: Add informational links to AMC opt-in toggle from Edtadros to ovasileva.

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Test Artifact(s):

Thu, Feb 7, 6:50 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T213336: Regression: Mobile gallery loading spinner appears on left instead of centered from Edtadros to ovasileva.
Thu, Feb 7, 6:18 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Edtadros updated the task description for T213336: Regression: Mobile gallery loading spinner appears on left instead of centered.
Thu, Feb 7, 6:17 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Edtadros added a comment to T213336: Regression: Mobile gallery loading spinner appears on left instead of centered.

Status: ✅ PASS
OS: macOS Mojave
Browser: Safari
Test Artifact:

Thu, Feb 7, 6:15 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Edtadros updated the task description for T212959: Create AMC edit tag.
Thu, Feb 7, 5:53 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros reassigned T212959: Create AMC edit tag from Edtadros to ovasileva.

Edit tag tested and verified. The history of the testing edits can be seen below. The Edit moderator action is Passed.

Thu, Feb 7, 5:47 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Tue, Feb 5

Edtadros updated the task description for T212959: Create AMC edit tag.
Tue, Feb 5, 7:50 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T212959: Create AMC edit tag.

@ovasileva, After some clarification (Thanks @Tbayer and @pmiazga), it was suggested to break out (reverts/undo/rollback) into 2 separate moderation actions, Undo and Rollback. Also, it appears that I missed listing Edit. I placed the QA results table in the description to not clutter the comments. I also updated the Status in (https://phabricator.wikimedia.org/T212959#4907948) to indicate that reverts/undo/rollback is not completed.

Tue, Feb 5, 7:35 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros updated subscribers of T214180: Add informational links to AMC opt-in toggle.

@Niedzielski can you answer a few questions please:

Tue, Feb 5, 4:58 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Wed, Jan 30

Edtadros reassigned T210745: Regression: Page history divider is too narrow from Edtadros to ovasileva.

I confirmed that the issue does exist in the production site and it is fixed on the beta cluster site that was given in the description.

Wed, Jan 30, 3:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), good first bug, Regression, MobileFrontend

Tue, Jan 29

Edtadros reassigned T213336: Regression: Mobile gallery loading spinner appears on left instead of centered from Edtadros to Jdlrobson.

I tested this following the QA steps (very helpful @Jdlrobson! ). The spinner always appeared in the center horizontally. However, it appears to be off-centered vertically. I have attached a screen video. I put some crude red lines to show more clearly.

Tue, Jan 29, 4:47 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Edtadros reassigned T211691: [Regression] Menu panel has black background when another drawer is first opened from Edtadros to ovasileva.

Tested this with Chrome DevTools emulating the Pixel Slate resolution of 3000x2000 pixels in both landscape and portrait mode. The menu background did not become bullet hole black in either of those scenarios. Additionally, I tested the Galaxy S5, Pixel 2, Pixel 2XL, iPhone 6/7/8 (plus and non-plus), and the iPad Pro. They all worked.

Tue, Jan 29, 3:56 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
Edtadros added a comment to T211691: [Regression] Menu panel has black background when another drawer is first opened.

This passed with a ChromeOS virtual machine. I'm going to check it with an emulator that allows me to test with the same resolution as a Pixel Slate.

Tue, Jan 29, 3:14 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend

Fri, Jan 25

Edtadros reassigned T212959: Create AMC edit tag from Edtadros to ovasileva.
Fri, Jan 25, 1:27 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Edtadros added a comment to T212959: Create AMC edit tag.
Moderation ActionStatusDetails
reverts/undo/rollback⬜ Not CompletedTested the QA Steps in Safari and Chrome on Mac OS, Did not test completely.
reviewing new pages (cf. Special:NewPagesFeed)⬜ Not Run
blocking⬜ Not Run
unblocking⬜ Not Run
deleting⬜ Not Run
protecting pages⬜ Not Run
moving pages⬜ Not Run
thanks⬜ Not Run
pending changes (cf. log on enwiki)⬜ Not Run
Fri, Jan 25, 1:26 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 23 2019

Edtadros updated the task description for T211197: Build AMC opt-in toggle.
Jan 23 2019, 12:21 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 22 2019

Edtadros added a comment to T211197: Build AMC opt-in toggle.

Worked with Piotr and we were able to test the first 4 items in the acceptance criteria and verified they worked as described on:

Jan 22 2019, 11:12 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions