Page MenuHomePhabricator

Ejegg (Elliott Eggleston)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2014, 11:22 PM (279 w, 5 d)
Availability
Available
LDAP User
Ejegg
MediaWiki User
EEggleston (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Ejegg created T245380: WMF LYBUNT times out or generates invalid SQL.
Mon, Feb 17, 1:50 AM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Wed, Feb 12

Ejegg closed T198733: Move queue message docs to mw.o, update, a subtask of T209872: epic: frtech onwiki documentation overhaul, as Resolved.
Wed, Feb 12, 4:24 PM · Epic, fundraising-tech-ops, Fundraising-Backlog
Ejegg closed T198733: Move queue message docs to mw.o, update as Resolved.
Wed, Feb 12, 4:24 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Oh hey, that was easy! *poof* and it's gone

Wed, Feb 12, 4:04 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

OK, I'll see if I can figure out how to decommission it to free up those resources.

Wed, Feb 12, 4:02 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T244946: Incorrect currency conversion amounts on Paypal payment form (USD only countries).

Looks like it's actually reasonably current - it was last updated in September.

Wed, Feb 12, 4:01 PM · Fundraising-Backlog
Ejegg added a comment to T244946: Incorrect currency conversion amounts on Paypal payment form (USD only countries).

Oh yeah, those are built from a hard-coded list that we update 1x a year or so. It's probably overdue for another update!

Wed, Feb 12, 4:24 AM · Fundraising-Backlog

Tue, Feb 11

Ejegg moved T233374: Automatic DAF thank you email from Review to Pending Deployment on the Fundraising Sprint CAPS LOCK CULTS board.
Tue, Feb 11, 8:30 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising Sprint Autocorrect Astrology Ascendant, Patch-For-Review, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T244583: Card input for 3DS appears off-centered on Desktop views.

Yep, I just checked (by highlighting the white-on-white text) and it does indeed just say Total 30.00 SEK (since we don't send an itemization).

Tue, Feb 11, 7:18 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog
Ejegg added a comment to T244588: Unclear error message on card input for 3DS.

It looks like we can change this text via the language packs in the key gc.general.paymentProductFields.validationErrors.allowedInContext.label

Tue, Feb 11, 5:03 PM · Fundraising-Backlog
Ejegg added a comment to T229039: Apple Pay Specs - Adyen.

@DStrine I got some bad news from our Adyen contact on Friday - they decided not to build the HPP integration for Apple Pay. So to get it through Adyen we'd need to switch to the Checkout integration.

Tue, Feb 11, 4:58 PM · Fr-planning-ahead, FR-Adyen, Fundraising-Backlog
Ejegg added a comment to T244583: Card input for 3DS appears off-centered on Desktop views.

The title of the page is 'Cards', which we should probably change too. It seems to be set in the language pack's gc.general.paymentProductGroups.cards.name

Tue, Feb 11, 4:49 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog
Ejegg added a comment to T244583: Card input for 3DS appears off-centered on Desktop views.

We're limited in our ability to change this page. They let us hide certain elements, but to hide the 'shopping cart' (list of items and prices) we had to set the text to white on white. Here's an example of what it would look like to change it back to black text on white:

Tue, Feb 11, 4:38 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog
Ejegg created T244885: Switch ejegg's Yubikey for frack access.
Tue, Feb 11, 4:30 PM · fundraising-tech-ops
Ejegg added a comment to T244588: Unclear error message on card input for 3DS.

Payments-wiki requires javascript too - there's really no way to get to the credit card entry without it. That error is probably just triggered because the random card number doesn't pass the Luhn check. If you want a test card number that doesn't trigger the check error, you can always use 4111 1111 1111 1111.

Tue, Feb 11, 4:15 PM · Fundraising-Backlog
Ejegg created T244871: Errors recording refunds in CiviCRM.
Tue, Feb 11, 3:39 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Thu, Feb 6

Ejegg added a comment to T243098: 16 Multilingual Thank You Emails.

@CDenes_WMF these are all on the staging server. Feel free to use the TY mail test page to send them to yourself and anyone who's helping review them.

Thu, Feb 6, 10:43 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg moved T243098: 16 Multilingual Thank You Emails from Doing to Review on the Fundraising Sprint CAPS LOCK CULTS board.
Thu, Feb 6, 10:43 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T238736: First Batch of TY Emails Pushed to Gerritt.

Did the versions sent on Jan 7th look good? I don't see any obvious errors looking at the patch.

Thu, Feb 6, 10:31 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Is cn-staging-1 used for anything? I see it's on stretch while -2 is on buster.

Thu, Feb 6, 10:14 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg moved T243011: Collapse countries and regions into one column in the campaign list from Backlog to Doing on the Fundraising Sprint CAPS LOCK CULTS board.
Thu, Feb 6, 9:27 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg updated the task description for T244527: Deadlocks due to soft credit search/report.
Thu, Feb 6, 9:20 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
Ejegg added a comment to T243011: Collapse countries and regions into one column in the campaign list.

Hmm, and while Portuguese regions DO have numeric identifiers, US regions should be using the 2 letter state abbreviations.

Thu, Feb 6, 9:18 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg created T244536: Adyen PaymentProvider / API classes should be split out like Ingenico ones..
Thu, Feb 6, 9:16 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, FR-Smashpig
Ejegg created T244527: Deadlocks due to soft credit search/report.
Thu, Feb 6, 7:41 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
Ejegg added a comment to T243011: Collapse countries and regions into one column in the campaign list.

I would expect to see the countries in alphabetical order whether they had regions or not, and have the regions listed in parenthesis after their relevant country. So something like

BR, CA (AB, BC), CO, US (MA)

To represent all of Brazil and Columbia, the US state of MA, and the Canada provinces of AB and BC.

Thu, Feb 6, 7:22 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg created T244518: Don't send failmail on duplicate contribution_recur insert.
Thu, Feb 6, 6:36 PM · Recurring-Donations, FR-Ingenico, Fundraising-Backlog
Ejegg closed T165087: Recurring payment messages from frontend should go to recurring queue as Declined.

On second thought, no, let's send all payment messages to the donations queue.

Thu, Feb 6, 5:47 PM · FR-PayPal-ExpressCheckout, Fundraising-Backlog, MediaWiki-extensions-DonationInterface
Ejegg added a comment to T240581: Send recurring payment notifications to the donations queue.

The recurring-specific normalization has two parts: 1) finding the contribution_tracking_id and 2) dealing with paypal inconsistencies in migrating legacy to new subscription ID formats.

Thu, Feb 6, 5:40 PM · Patch-For-Review, Recurring-Donations, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
Ejegg renamed T240581: Send recurring payment notifications to the donations queue from Should we send recurring payment notifications to the donations queue to Send recurring payment notifications to the donations queue.
Thu, Feb 6, 5:40 PM · Patch-For-Review, Recurring-Donations, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
Ejegg added a comment to T229039: Apple Pay Specs - Adyen.

Here's what we got from Adyen back in 2016:

Thu, Feb 6, 5:34 PM · Fr-planning-ahead, FR-Adyen, Fundraising-Backlog
Ejegg created T244503: Determine how to blank text of old TY mails w/o losing other mail.
Thu, Feb 6, 4:59 PM · Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
Ejegg moved T243294: Review and comment on several upcoming projects from Backlog to Doing on the Fundraising Sprint CAPS LOCK CULTS board.
Thu, Feb 6, 3:48 PM · Fundraising Sprint CAPS LOCK CULTS, Fr-planning-ahead, Fundraising-Backlog, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T198733: Move queue message docs to mw.o, update.

These docs have been moved and updated

Thu, Feb 6, 12:48 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back

Wed, Feb 5

Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

I had basically fixed it locally to confirm that it was my PS25 change at fault, so I went ahead and pushed that up. The multiselects and the geotargeting bits should now work in the 'add campaign' section like they do on the 'edit campaign' page.

Wed, Feb 5, 10:31 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

OK, it's due to a change I made to centralnotice.js back in PS25 - I took a chunk of UI initialization code and moved it from centralnotice.js into campaignManager.js:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/518449/24..25

Wed, Feb 5, 9:32 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

Yep, something's busted there. Looks like some scripts aren't being loaded. The multiselects for language and project are also unstyled.

Wed, Feb 5, 9:26 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Once we get some things set up (users, content), we should back up the db and make it easy to restore if the vagrant box gets wiped and reinstalled.

Wed, Feb 5, 5:58 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T243098: 16 Multilingual Thank You Emails.

I think we want to pull all of them onto the staging server to test

Wed, Feb 5, 4:31 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg moved T198733: Move queue message docs to mw.o, update from Backlog to Review on the Fundraising Sprint CAPS LOCK CULTS board.
Wed, Feb 5, 4:29 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Nice! Looks like https works too: https://cn-stage-2.wmflabs.org.

Wed, Feb 5, 3:55 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T243011: Collapse countries and regions into one column in the campaign list.

Ah, just saw your update. So we should probably change the title of the column (maybe Geotargeting?). The list would look something like CO, US (MA) to indicate that all of Colombia and the US state of MA are selected.

Wed, Feb 5, 3:52 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T243011: Collapse countries and regions into one column in the campaign list.

This ticket is about fixing it in the campaign list (the main page that shows up on Special:CentralNotice).

Wed, Feb 5, 3:49 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T243013: Fix tests and code to make Geotargeting pass CI.

Looks like the phan checks were fixed by someone upgrading the mediawiki-phan configuration (one of the dependency updates). The link above was to some Jenkins logs, which I guess get purged pretty often. It was showing one of the Phan checks saying we were vulnerable to XSS, but now I don't think it was accurate. So... I think we can close this ticket!

Wed, Feb 5, 3:46 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a comment to T243011: Collapse countries and regions into one column in the campaign list.

When I pull down the latest version of the patch I still see separate columns for country and region: F31550196. Do you have local work to combine them?

Wed, Feb 5, 3:38 PM · Patch-For-Review, Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Tue, Feb 4

Ejegg moved T174267: 2017 USA banners may freeze your browser for 1-2 seconds from Backlog to BannerContent on the MediaWiki-extensions-CentralNotice board.
Tue, Feb 4, 4:23 PM · Performance-Team (Radar), Wikimedia-CentralNotice-Administration, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, Fundraising-Backlog, Wikimedia-General-or-Unknown, Performance Issue
Ejegg added a comment to T125272: Investigation: Create Preference Center for donors to manage email subscription preferences.

The task list from @XenoRyet looks pretty good!

Tue, Feb 4, 12:56 AM · Fr-planning-ahead, Fundraising Sprint Princess Mongodb, Epic, Fundraising-Backlog
Ejegg added a comment to T234342: PAN Verification issue during India Test campaign.

Weird - the original donor should have gotten through based on the current rules, which just look for a 10 character string.

Tue, Feb 4, 12:18 AM · Patch-For-Review, FR-dlocal, Fundraising-Backlog

Thu, Jan 30

Ejegg edited P10291 Generate refund CSV.
Thu, Jan 30, 7:28 PM
Ejegg created T243967: Use idempotency headers in payment processing requests.
Thu, Jan 30, 7:11 PM · FR-Smashpig, Fundraising-Backlog
Ejegg added a comment to T243873: January spike in duplicate donations?.

Here's a draft of a SQL query to make a refund CSV for the Ingenico donations: P10291

Thu, Jan 30, 2:07 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico
Ejegg created P10291 Generate refund CSV.
Thu, Jan 30, 2:05 AM

Wed, Jan 29

Ejegg added a comment to T243873: January spike in duplicate donations?.

There are timeouts in the logs for both the PayPal and the Ingenico donations mentioned here. Looking at email addresses with multiple donations in a day, there were 25 on Jan 26th, 47 on Jan 27th, and 4 each on the 28th and 29th.

Wed, Jan 29, 10:07 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Byzantine Empire Strikes Back, Fundraising-Backlog, FR-Ingenico

Tue, Jan 28

Ejegg created T243806: Process-control should have an option to kill a stuck job.
Tue, Jan 28, 12:29 AM · Patch-For-Review, Fundraising-Backlog

Fri, Jan 24

Ejegg added a comment to T243627: Large recurring PayPal txn in Civi but no money collected.

Also note that you can get to the paypal record by adding the subscr_id (starts with I-) to the end of this URL:

Fri, Jan 24, 8:15 PM · FR-PayPal-ExpressCheckout, Fundraising-Backlog
Ejegg added a comment to T243627: Large recurring PayPal txn in Civi but no money collected.

As of Jan 24 2020 the status of the contribution and contribution_recur records were both complete, but I will manually set those two to canceled so as to make our totals more accurate.

Fri, Jan 24, 7:58 PM · FR-PayPal-ExpressCheckout, Fundraising-Backlog
Ejegg created T243627: Large recurring PayPal txn in Civi but no money collected.
Fri, Jan 24, 7:56 PM · FR-PayPal-ExpressCheckout, Fundraising-Backlog

Thu, Jan 23

Ejegg updated subscribers of T243463: i18n for monthly convert.
Thu, Jan 23, 4:08 AM · Recurring-Donations, Fundraising-Backlog

Wed, Jan 22

Ejegg added a comment to T243463: i18n for monthly convert.

It looks like our helpful translate-wiki friends have already translated the payments-wiki text into French, Turkish, Brazilian Portuguese, Norwegian, Hebrew and Arabic, with partial translations in a few other languages.

Wed, Jan 22, 11:32 PM · Recurring-Donations, Fundraising-Backlog
Ejegg renamed T243012: Show selected countries and regions under tree selector from Collapse countries and regions into one column in the campaign list to Show selected countries and regions under tree selector.
Wed, Jan 22, 11:18 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg updated subscribers of T241070: Server for previewing/usability testing new CentralNotice features.

@Jgreen and @Dwisehaupt : We have a Cloud VPS project! You are both admins, along with the rest of us on fr-tech. I'm reading through all the links from https://wikitech.wikimedia.org/wiki/Help:MediaWiki-Vagrant_in_Cloud_VPS before I actually take any of the steps there, so nothing is set up yet.

Wed, Jan 22, 6:13 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg updated the task description for T242278: Update civi SmashPig extension to be able to charge Adyen recurring.
Wed, Jan 22, 5:49 PM · Fundraising Sprint CAPS LOCK CULTS, Recurring-Donations, FR-Adyen, Fundraising-Backlog
Ejegg added a comment to T194313: upstream creditnote_id fix.

There's this: https://github.com/civicrm/civicrm-core/pull/15235 , in which we try to be all clever and actually guarantee a continuous sequence of numbers starting from wherever you start.

Wed, Jan 22, 2:56 PM · Fundraising Sprint CAPS LOCK CULTS, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg moved T198733: Move queue message docs to mw.o, update from Backlog to Review on the Fundraising Sprint Byzantine Empire Strikes Back board.
Wed, Jan 22, 2:53 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg created T243421: Increase SmashPig PHP minimum version to 7.0.
Wed, Jan 22, 2:52 PM · FR-Smashpig, Fundraising-Backlog
Ejegg updated subscribers of T243356: Civi: January 2020 Ingenico recurrings processing in duplicate?.

Hi @MBeat33. @AndyRussG (along with @Cstone and @Eileenmcnaughton) exported a file with the problems and ran the batch refund.

Wed, Jan 22, 5:22 AM · Fundraising Sprint Byzantine Empire Strikes Back, Recurring-Donations, Fundraising-Backlog
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Our project has been approved and we can start setting up an instance! I've added all of fundraising tech as admins. To log into https://horizon.wikimedia.org we'll all need to turn on 2FA for our Wikitech accounts.

Wed, Jan 22, 2:21 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T242812: Request creation of centralnotice-staging VPS project.

Thanks @Bstorm ! I've added the rest of fundraising-tech (including ops) as admins.

Wed, Jan 22, 2:17 AM · cloud-services-team (Kanban), Cloud-VPS (Project-requests)

Tue, Jan 21

Ejegg closed T242161: decide where the recurring logic is going to live, a subtask of T242160: Maintenance script to perform recurring payment capture, as Resolved.
Tue, Jan 21, 11:30 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, FR-Adyen, Recurring-Donations, Fundraising Sprint Autocorrect Astrology Ascendant, Patch-For-Review, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg closed T242161: decide where the recurring logic is going to live as Resolved.
Tue, Jan 21, 11:30 PM · Fundraising Sprint Autocorrect Astrology Ascendant, Recurring-Donations, FR-Adyen, Fundraising-Backlog
Ejegg created T243340: Normalize createPayment responses for Ingenico and Adyen PaymentProviders.
Tue, Jan 21, 9:13 PM · Fundraising Sprint CAPS LOCK CULTS, Patch-For-Review, Fundraising-Backlog, FR-Adyen, Recurring-Donations, Fundraising Sprint Byzantine Empire Strikes Back

Jan 17 2020

Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

Well, the rebase worked fine, but we're now failing tests because of a couple new Phan checks. Fixing one of them just needs a @suppress comment, but this one should probably be fixed in code: https://integration.wikimedia.org/ci/job/mwext-php72-phan-seccheck-docker/29593/console

Jan 17 2020, 12:55 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a subtask for T226438: Rebase and finish Geotargeting (sub national targeting): T241070: Server for previewing/usability testing new CentralNotice features.
Jan 17 2020, 12:04 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg added a parent task for T241070: Server for previewing/usability testing new CentralNotice features: T226438: Rebase and finish Geotargeting (sub national targeting).
Jan 17 2020, 12:04 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

The big rebase that needed some code rewritten is already done, and I did another simple rebase on Jan 3rd. I'll try another rebase now just to make sure nothing else has come in that will interfere.

Jan 17 2020, 11:58 AM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Ejegg moved T198733: Move queue message docs to mw.o, update from Doing to Review on the Fundraising Sprint Autocorrect Astrology Ascendant board.
Jan 17 2020, 11:55 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back

Jan 16 2020

Ejegg added a comment to T160134: Paypal audit - don't look up name when we already have it.

Also maybe related to T129379. That 'Stop denormalizing' patch may have fixed it.

Jan 16 2020, 7:06 PM · Patch-For-Review, FR-Paypal, Fundraising-Backlog
Ejegg created T243005: PayPal audit: don't send BAD_AUDIT_LINE / missing subscr_id when donation is present in DB.
Jan 16 2020, 7:01 PM · FR-WMF-Audit, FR-Paypal, Fundraising-Backlog
Ejegg added a comment to T226438: Rebase and finish Geotargeting (sub national targeting).

So I haven't yet implemented any of the changes mentioned in David's and my comments from Dec 18th: https://phabricator.wikimedia.org/T226438#5751615

Jan 16 2020, 3:07 PM · Fundraising Sprint YAMLton, the Musical, Fundraising Sprint X-rays, Patch-For-Review, Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fr-cross-training, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Jan 15 2020

Ejegg moved T241070: Server for previewing/usability testing new CentralNotice features from Q3 (January-February) 2019-20 to Current Sprint on the Fundraising-Backlog board.
Jan 15 2020, 4:52 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg moved T241070: Server for previewing/usability testing new CentralNotice features from Backlog to Doing on the Fundraising Sprint Autocorrect Astrology Ascendant board.
Jan 15 2020, 4:52 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg claimed T241070: Server for previewing/usability testing new CentralNotice features.
Jan 15 2020, 4:51 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back

Jan 14 2020

Ejegg created T242812: Request creation of centralnotice-staging VPS project.
Jan 14 2020, 11:19 PM · cloud-services-team (Kanban), Cloud-VPS (Project-requests)
Ejegg added a comment to T241070: Server for previewing/usability testing new CentralNotice features.

Looks like a cloud VPS project is what we want here, potentially using https://wikitech.wikimedia.org/wiki/Help:MediaWiki-Vagrant_in_Cloud_VPS

Jan 14 2020, 11:11 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, MediaWiki-extensions-CentralNotice, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg closed T241658: Italian Thank You Email and Subject Line as Resolved.
Jan 14 2020, 9:40 PM · Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog
Ejegg closed T241662: Swedish Thank You Email and Subject Line as Resolved.
Jan 14 2020, 9:40 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog
Ejegg assigned T241662: Swedish Thank You Email and Subject Line to CDenes_WMF.
Jan 14 2020, 9:39 PM · Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog
Ejegg moved T242161: decide where the recurring logic is going to live from Review to Deployed on the Fundraising Sprint Autocorrect Astrology Ascendant board.
Jan 14 2020, 9:39 PM · Fundraising Sprint Autocorrect Astrology Ascendant, Recurring-Donations, FR-Adyen, Fundraising-Backlog
Ejegg added a comment to T242277: Update Adyen SmashPig code to be able to create recurring donations.

Adding the authorize call can be an opportunity to define the normalization of the API responses.
So for example instead of passing back { 'pspReference':1234567 } it would pass back { 'gateway_txn_id':1234567 }

Jan 14 2020, 9:12 PM · Fundraising Sprint CAPS LOCK CULTS, Recurring-Donations, Patch-For-Review, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising-Backlog, FR-Adyen, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg added a comment to T242161: decide where the recurring logic is going to live.

We're pretty clear on where everything needs to go.

Jan 14 2020, 8:50 PM · Fundraising Sprint Autocorrect Astrology Ascendant, Recurring-Donations, FR-Adyen, Fundraising-Backlog
Ejegg moved T198733: Move queue message docs to mw.o, update from Backlog to Doing on the Fundraising Sprint Autocorrect Astrology Ascendant board.
Jan 14 2020, 2:51 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back
Ejegg claimed T198733: Move queue message docs to mw.o, update.
Jan 14 2020, 2:39 AM · Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, Fundraising Sprint Autocorrect Astrology Ascendant, Fundraising Sprint Byzantine Empire Strikes Back

Jan 13 2020

Ejegg added a comment to T242673: Update QueueConsumer to handle recurring adyen tokens.

If they're sent in the same format as the payment tokens for Ingenico Connect, we shouldn't need any change in the queue consumer. We just need to update the Adyen gateway code in DonationInterface to add the shopperReference to the queue messages as 'recurring_payment_token'.

Jan 13 2020, 10:54 PM · Fundraising Sprint Autocorrect Astrology Ascendant, FR-Adyen, Fundraising-Backlog
Ejegg renamed Fundraising Sprint Autocorrect Astrology Ascendant from Fundraising Sprint Autocorrect Astrology Ascendant to Fundraising Sprint Autocorrect Astrology Ascendant.
Jan 13 2020, 9:52 PM

Jan 10 2020

Ejegg added a comment to T111972: Leave GC donations in the limbo queue if API calls fail at result switcher.

To investigate: is anything like this still happening for Ingenico Connect? The limbo queue is now the pending table, and we delete from that when we get a donation or payments-initial queue message with the final status of the donation attempt.

Jan 10 2020, 8:01 PM · FR-Ingenico, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
Ejegg added a comment to T242452: Ingenico transactions not deleted from pending.

As a fix, the pending database could fall back to invoice_id when order_id is not present.

Jan 10 2020, 7:56 PM · Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig
Ejegg created T242452: Ingenico transactions not deleted from pending.
Jan 10 2020, 7:54 PM · Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig

Jan 9 2020

Ejegg added a comment to T228945: 3DS2.0.

The bit about the cardholder name is somewhat confusing on that page. It says

As the cardHolderName is a required property in most regions, we will also automatically capture that property in case 3-D Secure has been enabled on your account.

Jan 9 2020, 11:31 PM · Fundraising-Backlog
Ejegg created T242386: Move queue handling from SmashPig civi extension to hook.
Jan 9 2020, 11:21 PM · Wikimedia-Fundraising-CiviCRM, FR-Smashpig, Fundraising-Backlog
Ejegg added a parent task for T242349: Update Adyen IPN processing for recurring txns: T238101: EPIC recurring for Adyen.
Jan 9 2020, 4:40 PM · FR-Smashpig, Recurring-Donations, FR-Adyen, Fundraising-Backlog