Oops, wrong date - that should have been 2018-12-07 22:31 UTC

@CCogdill_WMF, @MNoorWMF, @kaythaney this was deployed at 2018-12-05 22:31 UTC. Any endowment donations received via payments-wiki before then are marked no_thank_you='Endowment Gift' so will still need to be manually thanked. Endowment gifts from that moment forward will have blank no_thank_you like normal donations, and will receive the new email from Jimmy Wales.

@CCogdill_WMF This is why the links to the form chooser weren't working as expected and sent some USD donors to Adyen.

I'd rather use one template if possible - the change to multiple templates would be a lot bigger than just switching the from name. I tried being really granular about putting the tags in around just the words that needed changing and ended up with something that looked really confusing for translators. I think I'll just do one big "if endowment" clause with the whole Jimmy letter in it.

@CCogdil_WMF / @MNoorWMF: the approved text has a lot more differences from the existing TY letter than I expected. Will it be too incoherent to add it to the existing template with the conditional tags? Do you need the TY sender to handle two completely different templates?

OK, I've got a draft of some code to swap the "From" name depending on the financial type, and to add the financial type to the template parameters.
We'll still be using the same template for all emails, so we'll need to add some conditional blocks like this:

https://etherpad.wikimedia.org/p/ct-spof has some notes from the Queen Mary

In the IPN logs for XWKN57071ELU in November I see a two recurring_payment_skipped notifications and one recurring_payment_failed.
For ERDY25X3X3F3 I also see two _skipped and one _failed notification in November.

Since banner-protect is defined in wmf-settings (rOMWC7d084e54705) and not in the actual extension code, that means the documentation string should be in the MediaWiki messages namespace on-wiki, right?

Hi @MarcoAurelio! This might be a lot less annoying shortly, without anyone changing any code.

Shoot, there's at least 1 from last Wednesday, and we haven't deployed any additional fixes since then. Think we might need to fix something in the audit parser.

@XenoRyet I see 105 rows from this query:

select count(*)
from wmf_contribution_extra wca1
inner join wmf_contribution_extra wca2
on wca1.gateway_txn_id = wca2.gateway_txn_id
and wca1.gateway='paypal'
and wca2.gateway='paypal_ec'
and wca1.id > 55000000
and wca2.id > 55000000;

Are you sure we're out of the woods? We should at least delete the 105 duplicate rows, right?

Trying to upstream the fix this time:
https://www.drupal.org/project/oauth/issues/3015132

Oof, that form chooser logic!

Sent an email to d-local asking if Perú and Uruguay are activated for our account

@MBeat33 very sorry about that. Donatewiki should be linking donors to the Ingenico form again by default.

ok, looks like we're getting 'Payment method not found' back from Astropay.
I set the selection weight down very low on the astropay forms for PE and UY, but the form chooser is still steering people there. Looking at the logic again to see what I missed.

One more on 2018-11-05, with the Connect integration: 60400492.1

Deployed & configured

OK, this is up in production and looking good

When you imported it with batch size 100, did you see the progress bar make it all the way across the screen? Or did it stop at some point?

@LeanneS the tech details: @Eileenmcnaughton's new code uploads the whole file when you hit submit, then processes it piece by piece while showing a progress bar. Your browser makes a new request for each piece, so if those requests are timing out you can try smaller pieces.

This is still working locally, so it's not an issue of the code dying. There's got to be something in the environment.

@MBeat33 and @Pcoombe , this should be working correctly now

Account created - still needs cert

I think if we want to show both, we would have to put the currency symbol in parens after the amount. The fancy localization function we use to get the currency symbol also decides whether to put the symbol before or after the amount, as appropriate (and also selects the right char to use as the decimal separator). So how does this look?

$1.25 (1.25 MXN)

OK, this is up on production. Sent a test version to fr-tech@ and it looks good at first glance.

Hi @MBeat33, your initial writeup of the problem on the description of this ticket looks great! If you send that, screenshot and all, it should get the message across.

Aha, we were doing some dumb amount fiddling in validation, trying to second guess the browser and user's number formatting. I've got the minimum viable fix up for review, but we maybe should drop the whole chunk of code that does the reformatting.

Was easy to add this to the ignore list. Pulling into sprint to cut down on irrelevant failmail at this crucial time.

This is all in the card processor's iframe, so we'll have to request it from them. Looks like the (new) Ingenico Connect form, right?

OK, I just looked up all the messages from this month with had old_subscr_id, and we're not storing a reference to the new subscr_id for any of them. Should be fine to use the old_subscr_id whenever that's present.