Page MenuHomePhabricator

Emwiemaikel (Emwiemaikel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 31 2017, 7:01 AM (367 w, 6 d)
Availability
Available
LDAP User
Emwiemaikel
MediaWiki User
Unknown

Recent Activity

Dec 2 2023

Emwiemaikel added a comment to T349900: "Save and Continue" loses data if any value contains a square bracket.

I checked out Master and the behavior is still unchanged. I cannot even see any possibly related commits.

Dec 2 2023, 9:43 PM · MediaWiki-extensions-Page_Forms

Nov 24 2023

Emwiemaikel added a comment to T349900: "Save and Continue" loses data if any value contains a square bracket.

Hello @TechieNK . Cab you please, share a commit or branch or release, that I should check.

Nov 24 2023, 7:14 PM · MediaWiki-extensions-Page_Forms

Oct 27 2023

Emwiemaikel added a comment to T349896: PF deletes error messages from external validation functions before showing them.

GR8! Thanks, Yaron!

Oct 27 2023, 5:41 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel added a comment to T349897: PF's DateTimePicker is not disabled, when it should be.

GR8! Thanks Yaron!

Oct 27 2023, 5:40 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel created T349900: "Save and Continue" loses data if any value contains a square bracket.
Oct 27 2023, 1:10 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel assigned T349897: PF's DateTimePicker is not disabled, when it should be to Yaron_Koren.

I was able to fix it with a small patch. Unfortunately I am too stupid or inexperienced to follow the right process for submitting the patch. Thus I share it here.

Oct 27 2023, 12:51 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel created T349897: PF's DateTimePicker is not disabled, when it should be.
Oct 27 2023, 12:50 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel assigned T349896: PF deletes error messages from external validation functions before showing them to Yaron_Koren.

I was able to fix it with a small patch. Unfortunately I am too stupid or inexperienced to follow the right process for submitting the patch. Thus I share it here.

Oct 27 2023, 12:46 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel added a comment to T349896: PF deletes error messages from external validation functions before showing them.

I defined a couple of validation functions and successfully register them via

Oct 27 2023, 12:43 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel created T349896: PF deletes error messages from external validation functions before showing them.
Oct 27 2023, 12:39 PM · MediaWiki-extensions-Page_Forms

Jul 6 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

THX

Jul 6 2023, 7:23 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 22 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

They do give different lists of values, I was just verifying if the patch also covers the other case and it does not. As I wrote above, the valueList is properly fetched but later it is overwritten in setPossibleValues later with null again.

Jun 22 2023, 6:51 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 20 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

Thanks Yaron. I can confirm that the issue is solved for fields with the "property=..." annotation.
But for fields with "values from property" the list of values now is empty.
this code is executed and does the right stuff

$f->mPossibleValues = PFValuesUtils::getAllValuesForProperty( $propertyName );

But in setPossibleValues later it gets overwritten with null again.

Jun 20 2023, 8:14 PM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 19 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

I am using property=... which sets $semantic_property but none of the parameters to the later call to setPossibleValues. Consequently all three values are null.

Jun 19 2023, 5:07 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 16 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

After more analysis I found:

  • since the reg-ex gets confused, the PFFormField in the PFTemplate has the wrong list of $mPossibleValues
  • since I am using property=xxx the setPossibleValues function will choose the default case of $this->mPossibleValues = $this->template_field->getPossibleValues(); which will take the faulty possibleValues from the template :(
Jun 16 2023, 11:12 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms
Emwiemaikel added a comment to T338753: property and values from property broken.

Hm OK, then sth. down stream is wrong.
As you can see the reg-ex thinks it is doing a good job but it associates the fieldNames ($matches[1]) with the wrong properyNames ($matches[2]).

Jun 16 2023, 7:29 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 15 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

Found the Problem. It comes from loadTemplateFieldsSMWAndOther in PF_Template.php

Jun 15 2023, 9:53 PM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 12 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

Yes, more or less. the template is quite big and I reduced for debugging purposes to the bare minimum. If you want a bigger picture it looks like this.

<noinclude>
Some text.
</noinclude>
<includeonly>
{{#ask:
  [[Categorie:SomeCategore]]
  {{#if:{{{Parameter1|}}}|[[Property1::>{{{Parameter1}}}]]|}}
  {{#if:{{{Parameter2|}}}|[[Property2::<{{{Parameter2}}}]]|}}
  {{#if:{{{Parameter3|}}}|[[Property3::{{#arraymap:{{{Parameter3|}}}|,|xxx|xxx| {{!!}}}}]]|}}
  {{#if:{{{Parameter4|}}}|[[Property4::{{#arraymap:{{{Parameter4|}}}|,|xxx|xxx| {{!!}}}}]]|}}
  | ?Property3
  | ?Property4
  | ?Property5
  | ?Property6
  |format=broadtable
  |limit=500
}}
</includeonly>

And in previous versions of PF this used to work as expected.

Jun 12 2023, 8:30 PM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms
Emwiemaikel added a comment to T338753: property and values from property broken.

Hi Yoren,
the syntax is correct, because it is part of an #ask query. The part of the query will and should look like this

[[Foo::P1V1||P1V2||P2V3]]
Jun 12 2023, 7:05 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Jun 11 2023

Emwiemaikel added a comment to T338753: property and values from property broken.

After a couple of hours of debugging I find that the template from "for template" is relevant.

  • Testing the above with a non-existing template works well. All fields appear as expected.
  • Removing the content of the template works. All fields appear as expected.
Jun 11 2023, 3:00 PM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms
Emwiemaikel created T338753: property and values from property broken.
Jun 11 2023, 12:59 PM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-Page_Forms

Mar 15 2022

Emwiemaikel created T303871: SpecialNuke: Call to undefined method Title::getId().
Mar 15 2022, 7:05 PM · MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), MW-1.38-notes, MW-1.37-notes, MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MediaWiki-extensions-Nuke

Nov 26 2018

Emwiemaikel added a comment to T208610: Save-And-Continue not fully supported by Multi-Instance-Templates.
diff --git a/libs/PF_submit.js b/libs/PF_submit.js
index 0120f361..94b33ca4 100644
--- a/libs/PF_submit.js
+++ b/libs/PF_submit.js
@@ -87,7 +87,7 @@
Nov 26 2018, 2:05 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel added a comment to T208610: Save-And-Continue not fully supported by Multi-Instance-Templates.

@Aklapper I really have problems with the gerrit setup here. I followed the Gerrit-Tutorial which is partially good.

  • But I had to learn where I need to put my SSH key the hard way :(
  • I did it on phabricator and mediawiki but not on Gerrit, itself :(
  • Further, the browsing support for the repos is really bad, compared to github and bitbucket :(
  • I cannot use git-review thus apparently there is no way for me to push anything to anywhere ;(
  • I cannot create a branch as recommended in the gerrit-tutorial :(
  • I cannot use the patch-uploader "No existing author found with 'erdmann@diqa-pm.com'" ;(
Nov 26 2018, 2:04 PM · MediaWiki-extensions-Page_Forms

Nov 2 2018

Emwiemaikel added a comment to T208610: Save-And-Continue not fully supported by Multi-Instance-Templates.

I have a patch to fix this. But where should I put it and how?

Nov 2 2018, 5:52 PM · MediaWiki-extensions-Page_Forms
Emwiemaikel created T208610: Save-And-Continue not fully supported by Multi-Instance-Templates.
Nov 2 2018, 5:50 PM · MediaWiki-extensions-Page_Forms

Jun 16 2017

Emwiemaikel added a comment to T148582: Lockdown blocks extensions relying on API interaction.

We looked into this issue and found that apparently the error occurs, if we hava sth. like this in your local settings.

$wgGroupPermissions['*']['read'] = false;

Lockdown seems to assume that the anonymous user is calling the API and will check this uer's effective group, which will also be '*' and thus Lockdown will most likely block the access.

Jun 16 2017, 11:16 AM · Patch-For-Review, MW-1.27-release, MediaWiki-extensions-Lockdown