Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (301 w, 5 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders added a comment to T259865: Create voting tool.

Surprisingly, voting didn't come up very high in the TPC. I think it's only covered under "Workflows": https://www.mediawiki.org/wiki/Talk_pages_consultation_2019/Phase_1_report#Workflows

Sat, Aug 8, 11:37 AM · DiscussionTools

Yesterday

Esanders added a comment to T259925: Karma tests using Firefox in VisualEditor/VisualEditor repo are failing.

Ran fine for me with fresh:

Running "karma:firefox" (karma) task
07 08 2020 21:46:05.332:WARN [filelist]: All files matched by "/ve/node_modules/qunit/qunit/qunit.js" were excluded or matched by prior matchers.
07 08 2020 21:46:05.412:INFO [karma-server]: Karma v5.0.9 server started at http://0.0.0.0:9876/
07 08 2020 21:46:05.412:INFO [launcher]: Launching browsers FirefoxHeadless with concurrency unlimited
07 08 2020 21:46:05.414:INFO [launcher]: Starting browser FirefoxHeadless
07 08 2020 21:46:07.793:INFO [Firefox 68.0 (Linux x86_64)]: Connected on socket wsnpt1qoY8bSQkiSAAAB with id 29299701
................................................................................
................................................................................
................................................................................
......................................................................
Firefox 68.0 (Linux x86_64): Executed 310 of 310 SUCCESS (12.555 secs / 12.457 secs)
Fri, Aug 7, 9:47 PM · Editing-team (FY2020-21 Kanban Board), ci-test-error (WMF-deployed Build Failure), VisualEditor, Continuous-Integration-Infrastructure
Esanders added a comment to T259906: Audio Icon.

+1 we could do with a video icon as well :)

Fri, Aug 7, 9:26 PM · VideoJS player, Wikimedia Design Style Guide, OOUI
Esanders added a comment to T259834: More clearly relate the Reply Tool to the comment being responded to.

Expected the Reply tool's compose window to open right beneath the comment being replied to.

Fri, Aug 7, 3:13 PM · DiscussionTools, Editing Design
Esanders added a comment to T254208: Revise position and behavior of Reply tool's text input.

Sticky is positioned relative to the parent element, so I don't think position sticky can be used here due to the widget being embedded deep in the DOM to take the correct position within the list.

Fri, Aug 7, 3:06 PM · OWC2020 (Reply Tool Opt Out), DiscussionTools, Editing Design
Esanders added a comment to T259193: [betalabs] FF only - Notifications - vertical scrolling in the header.

This should be testable on Beta now.

Fri, Aug 7, 3:01 PM · Growth-Team, Notifications
Esanders moved T259889: Disable page previews (popups) in all VE surfaces, including DiscussionTools from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Fri, Aug 7, 2:34 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Page-Previews, DiscussionTools
Esanders created T259889: Disable page previews (popups) in all VE surfaces, including DiscussionTools.
Fri, Aug 7, 2:22 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Page-Previews, DiscussionTools
Esanders created T259887: Provide the VE wikitext editing mode on mobile for users who have enabled the beta feature.
Fri, Aug 7, 1:42 PM · Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-MediaWiki-Mobile
Esanders merged T259828: Visual mode needs a white background into T259811: Reply widget's white background is inconsistent between source and visual mode.
Fri, Aug 7, 1:32 PM · Editing Design, Editing-team (FY2020-21 Kanban Board), VisualEditor, DiscussionTools
Esanders merged task T259828: Visual mode needs a white background into T259811: Reply widget's white background is inconsistent between source and visual mode.
Fri, Aug 7, 1:32 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T259811: Reply widget's white background is inconsistent between source and visual mode.

I filed and fixed this in T259828

Fri, Aug 7, 12:06 PM · Editing Design, Editing-team (FY2020-21 Kanban Board), VisualEditor, DiscussionTools

Thu, Aug 6

Esanders moved T259828: Visual mode needs a white background from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Aug 6, 8:00 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a project to T259828: Visual mode needs a white background: Editing-team (FY2020-21 Kanban Board).
Thu, Aug 6, 8:00 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders created T259828: Visual mode needs a white background.
Thu, Aug 6, 7:00 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T259786: Special pages don't interact well with Desktop Improvements.

the Special page tab is somewhat in the middle

Thu, Aug 6, 4:58 PM · Desktop Improvements
Esanders updated the task description for T259774: Improve messaging of block drawer.
Thu, Aug 6, 2:56 PM · MediaWiki-Blocks, Readers-Web-Backlog (Tracking), Anti-Harassment, MobileFrontend
Esanders updated the task description for T259775: Improve call to action in block drawer.
Thu, Aug 6, 2:55 PM · MediaWiki-Blocks, Readers-Web-Backlog (Tracking), Anti-Harassment, MobileFrontend
Esanders added a comment to T252084: Add header to username suggestion list.

Increased width and colours fixed:

Thu, Aug 6, 2:53 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, Editing Design, VisualEditor
Esanders moved T252084: Add header to username suggestion list from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Aug 6, 2:52 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, Editing Design, VisualEditor

Wed, Aug 5

Esanders added a comment to T250332: Explore enabling wikis to customize what syntax is used for @ mentions.

We weren't using the content language for the prefix message, this should be fixed at http://patchdemo.wmflabs.org/wikis/03cf1da7dd9d63e9e8bb70b558d6086b/w/index.php/Talk:Main_Page

Wed, Aug 5, 5:51 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor
Esanders assigned T259320: The options under Visual mode start overlapping at certain point and become completely un-usable to matmarex.
Wed, Aug 5, 4:48 PM · Editing Design, Editing-team (FY2020-21 Kanban Board), OWC2020 (Reply Tool Opt Out), Patch-For-Review, DiscussionTools
Esanders added a comment to T249391: Add support for customizing edit summaries for comments posted using Reply tool.

In looking into this with Jess, the summary edit message is heavily customised on many wikis, for example on zh.wiki it is used to provide a gadget that adds clickable common edit summaries:

Wed, Aug 5, 3:00 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, Editing Design
Esanders added a comment to T249391: Add support for customizing edit summaries for comments posted using Reply tool.

Not also that on article pages the edit summary label is defined in the message summary which many wikis override, for example in en.wiki it links to a help page and says "Briefly describe your changes" in small text: https://en.wikipedia.org/wiki/MediaWiki:Summary

Wed, Aug 5, 2:01 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, Editing Design
Esanders added a comment to T249391: Add support for customizing edit summaries for comments posted using Reply tool.

Of the three, it seems least likely to catch the attention of, and [potentially] subsequently confuse, Junior Contributors

Wed, Aug 5, 1:57 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, Editing Design
Esanders added a comment to T259193: [betalabs] FF only - Notifications - vertical scrolling in the header.

Note the above patch is in in OOUI, so this won't be testable on beta until the next OOUI release.

Wed, Aug 5, 1:55 PM · Growth-Team, Notifications

Tue, Aug 4

Esanders added a comment to T257644: [SPIKE] How might we programmatically categorize talk page edits? .

As part of our investigation into notifications, we believe we will be able to identify when comments have been posted using any tool (see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/614907)

Tue, Aug 4, 6:22 PM · OWC2020, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
Esanders moved T259563: Write API for publishing new sections to pages from Needs Discussion / Investigation to Ready for Development on the Editing-team (FY2020-21 Kanban Board) board.
Tue, Aug 4, 6:13 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated the task description for T259563: Write API for publishing new sections to pages.
Tue, Aug 4, 6:13 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T252558: Create a low bandwidth reply API using parser.php/modifier.php.

Thanks, can you link to a diff of this happening?

Tue, Aug 4, 6:08 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Editing QA, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T259320: The options under Visual mode start overlapping at certain point and become completely un-usable .

I think this is very low priority. I don't think we need to design too much for very low widths on desktop. In general the whole interface, not just our tool, breaks down below a certain size.

Tue, Aug 4, 2:28 PM · Editing Design, Editing-team (FY2020-21 Kanban Board), OWC2020 (Reply Tool Opt Out), Patch-For-Review, DiscussionTools

Mon, Aug 3

Esanders added a comment to T259538: Dirty diff appending to <noinclude> graveyard on private wiki (officewiki).

This appears to be the first bad edit: https://office.wikimedia.org/w/index.php?title=Community_Relations_Specialists/Audiences/Meetings_with_Product&diff=prev&oldid=271810&diffmode=source ?

Mon, Aug 3, 5:40 PM · VisualEditor
Esanders created T259538: Dirty diff appending to <noinclude> graveyard on private wiki (officewiki).
Mon, Aug 3, 5:32 PM · VisualEditor
Esanders moved T250332: Explore enabling wikis to customize what syntax is used for @ mentions from Freezer to Needs Prioritization on the OWC2020 (OWC2020 Replying 2.0) board.
Mon, Aug 3, 2:18 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor
Esanders moved T250332: Explore enabling wikis to customize what syntax is used for @ mentions from Doing to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Mon, Aug 3, 2:18 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor
Esanders added a comment to T250332: Explore enabling wikis to customize what syntax is used for @ mentions.

http://patchdemo.wmflabs.org/wikis/34a9f7f45cb7952af0528ea2bbff9f17/w/index.php/Talk:Main_Page

Mon, Aug 3, 2:12 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor

Sat, Aug 1

Esanders added a comment to T258743: Change what symbol is prepended to pings on ar.wiki.

Note that all the implementation will be done on T250332. This ticket will just be editing a message on ar.wiki to change it from '@' to '◀'.

Sat, Aug 1, 12:01 PM · User-Dyolf77, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor

Fri, Jul 31

Esanders assigned T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog to matmarex.
Fri, Jul 31, 11:49 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T259193: [betalabs] FF only - Notifications - vertical scrolling in the header.

I could reproduce this when changing the browser zoom, but not at 100%:

Fri, Jul 31, 11:15 PM · Growth-Team, Notifications
Esanders added a comment to T259193: [betalabs] FF only - Notifications - vertical scrolling in the header.

What browser/OS?

Fri, Jul 31, 11:11 PM · Growth-Team, Notifications
Esanders added a comment to T259184: How are notifications received.

Of the email notifications that are sent for talk page events, what proportion of them are opened?

Most email clients prevent this being tracked even if we tried (and I don't think we do try)

Fri, Jul 31, 10:12 PM · DiscussionTools, Product-Analytics, Editing-team (Tracking)
Esanders updated the task description for T252558: Create a low bandwidth reply API using parser.php/modifier.php.
Fri, Jul 31, 5:57 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Editing QA, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T252558: Create a low bandwidth reply API using parser.php/modifier.php.

It's possible but very unlikely to get edit conflicts with this tool. The two requests would need to arrive at the server probably within a second of each other. That said when it does happen, the behaviour you describe in (2) sounds correct as these are the rules for same-user edit conflicts.

Fri, Jul 31, 5:54 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Editing QA, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders awarded T258954: Special:Notifications filter overlay never closes in Minerva a Like token.
Fri, Jul 31, 2:40 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Growth-Team (Current Sprint), Regression, MinervaNeue, Notifications
Esanders added a comment to T259083: [Regression] UI regressions in VE on Beta cluster.

I would guess that T259272 and the top margin issue will be fixed in one patch, as they both stem from a single line of CSS (that applies negative margins to the toolbar).

Fri, Jul 31, 2:16 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Editing-team (Tracking), Vector, Desktop Improvements, VisualEditor
Esanders added a project to T259354: ActionField + dropdown styling issues: TemplateData.

(2) is visible in the TemplateData dialog:

Fri, Jul 31, 2:03 PM · User-Ryasmeen, OOUI (OOUI-0.40.1), VisualEditor, TemplateData
Esanders created T259354: ActionField + dropdown styling issues.
Fri, Jul 31, 2:02 PM · User-Ryasmeen, OOUI (OOUI-0.40.1), VisualEditor, TemplateData
Esanders created T259348: Import button is wider than the dialog.
Fri, Jul 31, 1:19 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), VisualEditor, TemplateData
Esanders updated the task description for T258743: Change what symbol is prepended to pings on ar.wiki.
Fri, Jul 31, 12:28 PM · User-Dyolf77, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor

Thu, Jul 30

Esanders moved T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 cursor from Ready for Development to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Jul 30, 2:49 PM · Editing Design, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 cursor.

I verified this fix on the live site with iOS 14 beta. @Ferdi2005 does this work for you now in iOS13.4?

Thu, Jul 30, 2:36 PM · Editing Design, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T259083: [Regression] UI regressions in VE on Beta cluster.

Note that the toolbar doesn't left align with the tabs when it should:

Thu, Jul 30, 2:26 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Editing-team (Tracking), Vector, Desktop Improvements, VisualEditor
Esanders added a comment to T255173: iPad, mobile mode, text editing is unstable.
Thu, Jul 30, 2:17 PM · Editing-team (FY2020-21 Kanban Board), Browser-Support-Apple-Safari, VisualEditor, MobileFrontend

Wed, Jul 29

Volker_E awarded T258705: Focusing a notification draws an odd outline a Like token.
Wed, Jul 29, 11:13 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders added a comment to T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog.

@Tacsipacsi do you know the keyboard shortcut for indenting in Gmail in Hungarian?

Wed, Jul 29, 6:43 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T255191: ULS IME icon partially obscures Reply button.

Peter filed the resize issue as T258840. As this was merged last week it will be deployed this week unless reverted.

Wed, Jul 29, 5:19 PM · OWC2020 (Reply Tool Opt Out), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, UniversalLanguageSelector, Accessibility
Esanders added a comment to T255622: Uncaught TypeError: Cannot read property 'getScrollTop' of null.

Also the error is coming from deep within Ace, so there may not be a lot we can do.

Wed, Jul 29, 5:00 PM · CodeEditor, Editing-team (FY2020-21 Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor
Esanders claimed T252555: Perform addReplyLinks on the server.
Wed, Jul 29, 3:23 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders merged T259091: [wmf.1-regression] mobile Special:Notifications becomes unresponsive after changing filters into T258954: Special:Notifications filter overlay never closes in Minerva.
Wed, Jul 29, 1:29 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Growth-Team (Current Sprint), Regression, MinervaNeue, Notifications
Esanders merged task T259091: [wmf.1-regression] mobile Special:Notifications becomes unresponsive after changing filters into T258954: Special:Notifications filter overlay never closes in Minerva.
Wed, Jul 29, 1:29 PM · Mobile, MinervaNeue, Notifications, Growth-Team, Regression
Esanders added a comment to T258990: [minor] "Stop watching the topic" label overflows the timestamp.

After:

Wed, Jul 29, 11:52 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Growth-Team (Current Sprint), UI-Standardization, Notifications
Esanders created T259113: userTalk icon should be renamed.
Wed, Jul 29, 10:25 AM · Growth-Team, OOUI, Notifications

Tue, Jul 28

Esanders added a comment to Blog Post: All code is built.

Some clarifications:

Tue, Jul 28, 9:24 PM
Esanders added a comment to T255190: Parsoid "HTML4BlockTags" tokens are a lie.

@Esanders As of T255190#6313944, we've removed HTML4BlockTags. But why are you copying this list? Is it to mimic some Parsoid specific behaviour that we should account for or just a convenient place to lookup what was once considered block tags?

Tue, Jul 28, 6:56 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor
Esanders added a comment to T258840: ULS component remains in a fixed position as the text input area grows.

There's a technical issue here as the resize is done outside of the IME code, which make it harder to notify the IME that a resize has taken place.

Tue, Jul 28, 6:01 PM · Accessibility, UniversalLanguageSelector, DiscussionTools
Esanders claimed T258990: [minor] "Stop watching the topic" label overflows the timestamp.
Tue, Jul 28, 3:59 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Growth-Team (Current Sprint), UI-Standardization, Notifications

Mon, Jul 27

Esanders updated the task description for T258964: HtmlFormatter library: Code stewardship review.
Mon, Jul 27, 6:26 PM · Readers-Web-Backlog (Tracking), RemexHtml, HtmlFormatter, TextExtracts, Code-Stewardship-Reviews
Esanders created T258954: Special:Notifications filter overlay never closes in Minerva.
Mon, Jul 27, 2:44 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Growth-Team (Current Sprint), Regression, MinervaNeue, Notifications
Esanders created T258939: Special:Notifications header too wide for mobile.
Mon, Jul 27, 12:00 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Growth-Team (Current Sprint), Notifications, MinervaNeue
Esanders created T258937: Font size in notification action menu too large in Minerva.
Mon, Jul 27, 11:56 AM · MinervaNeue (Tracking), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Notifications, Growth-Team
Esanders created T258936: Move Echo/Notifications CSS code out of Minerva.
Mon, Jul 27, 11:55 AM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MinervaNeue, Growth-Team, Notifications

Fri, Jul 24

Esanders closed T237018: Section expand/collapse icons should be centred. not top-aligned as Resolved.

This appears to have been resolved at some point:

Fri, Jul 24, 9:26 PM · Readers-Web-Backlog (Design), Design, MobileFrontend
Esanders added a comment to T254263: [Technical Investigation] What constraints limit what notifications can be sent and how they can be delivered?.

I think it does know—the author is the user who hit the save button. This should be available even without DT. The other two pieces of information aren’t, though, and probably it won’t be possible ever to reliably guess them, like when someone replies to several people in one edit.

We might have a way to detect all three pieces of information, regardless of the tool/interface being used to post the comment. Although, it's still too early to say for certain.

Fri, Jul 24, 7:57 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
Esanders updated subscribers of T255191: ULS IME icon partially obscures Reply button.

@santhosh has merged the patch on GH, so this is back with the Editing team. Thanks.

Fri, Jul 24, 11:09 AM · OWC2020 (Reply Tool Opt Out), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, UniversalLanguageSelector, Accessibility

Thu, Jul 23

Esanders added a comment to T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog.

The easy way to fix all of this is to unbind tab/shift+tab from VE completely as we already have CTRL+[ and CTRL+] bound (this is what GMail does). The only issue is if this works on other keyboard layouts that may not have easy access to '['.

Thu, Jul 23, 7:55 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders assigned T257234: DiscussionTools' reply widget might default to visual mode when the user has completely disabled visual editor for articles to matmarex.
Thu, Jul 23, 7:51 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), Editing QA, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), DiscussionTools
Esanders added a comment to T130109: Set minimum width on action labels.

Setting to 7em:

Thu, Jul 23, 4:59 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Notifications
Esanders added a comment to T258201: MoveLeadParagraphTransformInfobox re-order should apply other floated elements, e.g. images.

FYI both the mobile apps, which also implement lede paragraph reordering, apply the transform to images:

Thu, Jul 23, 3:57 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, MobileFrontend
Esanders closed T119374: Styling adjustments for the Notification Panel, a subtask of T113228: Better organization for the Notification panel, as Resolved.
Thu, Jul 23, 3:18 PM · Growth-Team, Epic, Notifications
Esanders closed T119374: Styling adjustments for the Notification Panel as Resolved.

All the blocked tasks have been resolved

Thu, Jul 23, 3:17 PM · Growth-Team, Collaboration-Team-Triage, Notifications
Esanders claimed T258710: Mark as read/unread buttons have no focus state.
Thu, Jul 23, 2:46 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders created T258714: Remove double border from notification bundles.
Thu, Jul 23, 2:46 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders added a comment to T163802: Alignment issues in Echo popover.

Since this was filed, the horizontal alignment as been fixed:

Thu, Jul 23, 2:31 PM · Growth-Team, UI-Standardization, UI-Standardization-Kanban, Notifications
Esanders created T258710: Mark as read/unread buttons have no focus state.
Thu, Jul 23, 2:14 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders added a comment to T258705: Focusing a notification draws an odd outline.

Related: anywhere outside these outlines is not clickable and does not get cursor:pointer

Thu, Jul 23, 1:56 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders updated the task description for T258705: Focusing a notification draws an odd outline.
Thu, Jul 23, 1:46 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders claimed T258701: Alignment of buttons in grouped notification.
Thu, Jul 23, 1:23 PM · Growth-Team (Current Sprint), UI-Standardization, Notifications
Esanders claimed T258705: Focusing a notification draws an odd outline.
Thu, Jul 23, 1:23 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders claimed T258706: After being clicked, the cursor for "Expand" / "Collapse" is default and not pointer..
Thu, Jul 23, 1:23 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders claimed T258703: Inconsistent hover states in notification.
Thu, Jul 23, 1:23 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders created T258706: After being clicked, the cursor for "Expand" / "Collapse" is default and not pointer..
Thu, Jul 23, 1:22 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders created T258705: Focusing a notification draws an odd outline.
Thu, Jul 23, 1:18 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders added a comment to T258703: Inconsistent hover states in notification.
Thu, Jul 23, 1:01 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders created T258703: Inconsistent hover states in notification.
Thu, Jul 23, 12:50 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), UI-Standardization, Notifications
Esanders created T258701: Alignment of buttons in grouped notification.
Thu, Jul 23, 12:45 PM · Growth-Team (Current Sprint), UI-Standardization, Notifications

Tue, Jul 21

Esanders added a comment to T252058: Support timestamped signatures generated by "unsigned" templates that haven't been substituted.

@Lofhi I would expect so.

Tue, Jul 21, 9:29 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Editing QA, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), DiscussionTools, OWC2020 (OWC2020 Replying 1.0)
Esanders moved T258457: WWT makes API request on every page view before button is clicked. from Backlog to In progress on the Who-Wrote-That board.
Tue, Jul 21, 1:49 PM · Community-Tech, Who-Wrote-That
Esanders added a comment to T258457: WWT makes API request on every page view before button is clicked..

https://github.com/wikimedia/WhoWroteThat/pull/167

Tue, Jul 21, 1:30 PM · Community-Tech, Who-Wrote-That
Esanders added a comment to T258457: WWT makes API request on every page view before button is clicked..

It appears they are used for this feature, which is loaded even later (also async):

Tue, Jul 21, 12:43 PM · Community-Tech, Who-Wrote-That
Esanders added a comment to T258457: WWT makes API request on every page view before button is clicked..

These are the messages which are fetched:

Tue, Jul 21, 12:40 PM · Community-Tech, Who-Wrote-That