Esanders (Ed Sanders)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (181 w, 5 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF)

Recent Activity

Today

Esanders added a comment to T191266: De-emphasize toolbar tool group borders.

we might wanna get rid of borders for action toolbar simple button item borders, all together. if not then all tool borders should be B80

Sat, Apr 21, 1:47 PM · Patch-For-Review, UI-Standardization-Kanban, OOUI, UI-Standardization

Yesterday

Esanders created T192671: Remove ve.Range#clone & ve.dm.Selection#clone.
Fri, Apr 20, 4:41 PM · Patch-For-Review, VisualEditor-DataModel, VisualEditor
Esanders added a comment to T191756: Guess parameters for templates without TemplateData.

Looks like you found it already.

Fri, Apr 20, 9:06 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Esanders added a comment to T191756: Guess parameters for templates without TemplateData.

Note that the template data editor already does this, so that would be the first place to look.

Fri, Apr 20, 9:04 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Thu, Apr 19

Esanders added a comment to T192545: Error loading table with broken wikitext syntax.

Minimal test case:

{| class="wikitable sortable"
!Foo
|-
|-
|Bar
|-
|}
Thu, Apr 19, 1:19 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work), VisualEditor-ContentEditable, ContentTranslation
Esanders renamed T192545: Error loading table with broken wikitext syntax from ve.ce.MWTableNode#getTablesorterHeaderCells throws Javascript error to Error loading table with broken wikitext syntax.
Thu, Apr 19, 1:05 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work), VisualEditor-ContentEditable, ContentTranslation
Esanders triaged T192545: Error loading table with broken wikitext syntax as Low priority.

The root cause is broken table syntax (defining the row twice). Ideally VE should be able to handle that.

Thu, Apr 19, 1:04 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work), VisualEditor-ContentEditable, ContentTranslation

Wed, Apr 18

Esanders added a comment to T170001: Support CodeMirror syntax highlighting on RTL wikis.

@Esanders Do you think it's possible for us to take away cursor control from CM and let the browser handle it for the classic/advanced editors in the way that VE does it? CM doesn't provide a config option for that in the library and insists on handling cursor movements itself, which it is not very good at.

Wed, Apr 18, 1:04 PM · I18n, RTL, MediaWiki-extensions-CodeMirror
Esanders moved T190967: Align further (VE) icons to icon guidelines from In progress to Done on the VisualEditor (Current work) board.
Wed, Apr 18, 10:49 AM · VisualEditor (Current work), Design, OOUI

Tue, Apr 17

Esanders added a comment to T192408: Popup anchor not positioned correctly.

One option would be to bind a mousemove listener on mouseenter (and unbind on mouseleave/show popup), and use that to update the anchor position. The position should only 'lock' when the show animation starts.

Tue, Apr 17, 9:09 PM · Readers-Web-Backlog, Page-Previews
Esanders created T192408: Popup anchor not positioned correctly.
Tue, Apr 17, 8:51 PM · Readers-Web-Backlog, Page-Previews
Esanders merged T192401: block data urls generated by safe web/safe browsing extension polluting the content surface into T192392: [[data:image/png;base64... added to article when editing using the visual editor due to broken browser extension.
Tue, Apr 17, 7:35 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-CopyPaste
Esanders merged task T192401: block data urls generated by safe web/safe browsing extension polluting the content surface into T192392: [[data:image/png;base64... added to article when editing using the visual editor due to broken browser extension.
Tue, Apr 17, 7:35 PM · VisualEditor
Esanders added a comment to T192320: Visual Editor: Cite > Manual > Basic not stripping unwanted formatting.

Regression caused by https://gerrit.wikimedia.org/r/#/c/422955/ @DLynch

Tue, Apr 17, 7:34 PM · Patch-For-Review, VisualEditor (Current work)
Esanders added a comment to T192392: [[data:image/png;base64... added to article when editing using the visual editor due to broken browser extension.

The images being inserted here are these: This might be the logo of the extension (I don't recognize it, unfortunately).

These are appearing after ISBN's so I would guess some citation plugin.

Tue, Apr 17, 7:14 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-CopyPaste
Esanders added a comment to T192392: [[data:image/png;base64... added to article when editing using the visual editor due to broken browser extension.

Shouldn't we just blacklist all images with a data URL?

Tue, Apr 17, 7:06 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-CopyPaste
Esanders added a comment to T192341: Alternatives for “Clear styling” icon.

Additionally, a separate "unlink" icon (i.e. crossed out variant of the current "link" icon) for removing a link would perhaps make sense.

Tue, Apr 17, 2:56 PM · Design, VisualEditor
Esanders added a comment to T191923: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature.

There is a direction button in VE (under the hamburger menu / alt+shift+x), although testing it now it appears the CM functionality has regressed.
Alt-Shift-x is special:randompage

I believe you meant Ctrl-Shift-x

It varies depending on your OS

Tue, Apr 17, 9:52 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Community-Tech, RTL, MediaWiki-extensions-CodeMirror, I18n

Mon, Apr 16

Esanders edited projects for T191823: No toolbar on mobile views using Firefox and Chromium, added: MobileFrontend; removed Browser-Support-Google-Chrome, Browser-Support-Firefox.
Mon, Apr 16, 6:03 PM · MobileFrontend, VisualEditor
Esanders added a comment to T191823: No toolbar on mobile views using Firefox and Chromium.

Case 1:

  1. visit a page
  2. click on Mobile view
  3. edit the page (pen icon) Result: no editor, and the ful page is not leading
Mon, Apr 16, 6:03 PM · MobileFrontend, VisualEditor
Esanders added a comment to T191923: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature.

We could just hard-code in to CodeMirror's code for the 2010/2006/2003 editors that it's disabled on RTL wikis, and then enable everywhere-everywhere, and so the 2017 editor would "just work"?

I didn't think you'd be the one suggesting putting in hacks, James!
I think adding a config flag would be cleaner and not much additional work, honestly. We won't be breaking things randomly for a third party wiki either (if one uses Codemirror). :)

Mon, Apr 16, 4:02 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Community-Tech, RTL, MediaWiki-extensions-CodeMirror, I18n
Esanders added a comment to T191923: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature.

Tried again. It works on desktop, but Alt-Shift does not work.

Is it any more or less broken than VE (in either visual or source mode)?

Mon, Apr 16, 3:53 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Community-Tech, RTL, MediaWiki-extensions-CodeMirror, I18n
Esanders added a comment to T191823: No toolbar on mobile views using Firefox and Chromium.

Which link? Do you mean 'Mobile view' while already in the editor?

Mon, Apr 16, 3:03 PM · MobileFrontend, VisualEditor
Esanders claimed T192227: VE is creating internal <span> tags in the end result.
Mon, Apr 16, 3:00 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-CopyPaste, VisualEditor (Current work)
Esanders edited projects for T192227: VE is creating internal <span> tags in the end result, added: VisualEditor (Current work); removed VisualEditor.
Mon, Apr 16, 3:00 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-CopyPaste, VisualEditor (Current work)
Esanders added a comment to T192227: VE is creating internal <span> tags in the end result.

data-ve-attributes means the cause is the user pasting from another article, however I can't reproduce this bug. I've looked at the codepath, and the only way for the attribute to not get removed is if the JSON didn't parse, but looking at the saved wikitext that shouldn't be the problem here. The patch above removes the dependency on the JSON parsing, but without reproduction steps, I'm not sure it will fix the issue.

Mon, Apr 16, 3:00 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-CopyPaste, VisualEditor (Current work)
Esanders added a comment to T192258: VisualEditor: Add a shortcut to add an image.

We're pretty low on keyboard shortcuts (we already get conflicts), and any sequence would want to start with '[[' which would conflict with the link sequence.

Mon, Apr 16, 2:37 PM · VisualEditor
Esanders added a comment to T183749: Align notification icons with the icon styleguide.

I think the new cog icon is little harder to read at smaller sizes, the old version as okay:

Mon, Apr 16, 1:57 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications, UI-Standardization
Esanders added a comment to T183749: Align notification icons with the icon styleguide.

Can you attach SVGs?

Mon, Apr 16, 1:38 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications, UI-Standardization

Sun, Apr 15

Esanders added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

You could look into subclassing SelectWidget.

Sun, Apr 15, 12:25 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Sat, Apr 14

Honischboy awarded T192076: Removal of license template isn't shown in visual diff a Yellow Medal token.
Sat, Apr 14, 8:19 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), VisualEditor-VisualDiffs

Fri, Apr 13

Esanders added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

I've replaced 'arrowNext' with 'next'. The next/previous icons are rotations of the expand/collapse pair, and this action is 'collapse'. Also the arrow icons haven't been used anywhere yet (according to T141801 their usage is "Planned in MinervaNeue").

Fri, Apr 13, 8:30 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Esanders added a comment to T161330: Flow: Notification icons point to different directions.

Note also that only some of the speech bubble icons have RTL variants, so in RTL it will still be inconsistent after the parent bug is fixed (T183749).

Fri, Apr 13, 6:17 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Esanders reopened T191623: Add missing icons for table row/col move as "Open".

The icons provided in https://gerrit.wikimedia.org/r/#/c/425415/ use white shapes to mask out parts. OOUI icons are only supposed to contain black and transparent, otherwise they won't work against light colour backgrounds, and they won't get inverted properly.

Fri, Apr 13, 5:18 PM · Patch-For-Review, User-Ryasmeen, VisualEditor-Tables, OOUI (OOUI-0.26.3), VisualEditor, Design
Esanders reopened T191623: Add missing icons for table row/col move, a subtask of T190967: Align further (VE) icons to icon guidelines, as Open.
Fri, Apr 13, 5:18 PM · VisualEditor (Current work), Design, OOUI
Esanders added a parent task for T161330: Flow: Notification icons point to different directions: T183749: Align notification icons with the icon styleguide.
Fri, Apr 13, 4:50 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Esanders added a subtask for T183749: Align notification icons with the icon styleguide: T161330: Flow: Notification icons point to different directions.
Fri, Apr 13, 4:50 PM · Patch-For-Review, Collaboration-Team-Triage, Notifications, UI-Standardization
Esanders moved T192117: Tabbing on the caption field gives error "Uncaught TypeError: selection.isSingleCell is not a function" from Up next to Code review and QA on the VisualEditor (Current work) board.
Fri, Apr 13, 4:43 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor-Tables, VisualEditor (Current work)
Esanders claimed T192117: Tabbing on the caption field gives error "Uncaught TypeError: selection.isSingleCell is not a function".
Fri, Apr 13, 4:42 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor-Tables, VisualEditor (Current work)
Esanders added a comment to T93243: Flow's VE toolbar v2.

Hmm - it looks like the toolbar popup is in a local overlay, so all we can do here is clip it to the content area.

Fri, Apr 13, 3:51 PM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, User-notice, Collaboration-Team-Triage, StructuredDiscussions

Thu, Apr 12

Volker_E awarded T191031: Use OOUI icons in WikiEditor a Like token.
Thu, Apr 12, 10:47 PM · Verified, User-notice, VisualEditor (Current work), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Design, WikiEditor
Esanders triaged T191590: Section name still appears in edit summary when you switch to full article editing as Low priority.
Thu, Apr 12, 9:54 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T192049: Tools column responsiveness with VE Context tools minimum width .

Inspectors, in particular, are going to require the full 400px.

Thu, Apr 12, 9:51 PM · Language-2018-Apr-June, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor, Design, ContentTranslation
Esanders moved T182402: Pasting HTML in NWE can't be undone via keyboard from In progress to Code review and QA on the VisualEditor (Current work) board.
Thu, Apr 12, 9:48 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Capt_Swing awarded T184467: CodeMirror in 2017 Wikitext Editor shows overlapping text in Firefox a Heartbreak token.
Thu, Apr 12, 4:00 PM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), Patch-For-Review, VisualEditor (Current work), Browser-Support-Firefox, MediaWiki-extensions-CodeMirror, Chinese-Sites, Community-Tech
Esanders added a comment to T192081: Toolbar menu appears underneath column.

I would suggest partially reverting https://gerrit.wikimedia.org/r/#/c/413707/ and making the second toolbar an OOUI toolbar.

Thu, Apr 12, 2:37 PM · ContentTranslation
Esanders created T192081: Toolbar menu appears underneath column.
Thu, Apr 12, 2:32 PM · ContentTranslation
Esanders added a comment to T191823: No toolbar on mobile views using Firefox and Chromium.

Yeah - that is the noJS mobile editor.

Thu, Apr 12, 2:08 PM · MobileFrontend, VisualEditor
Esanders claimed T192076: Removal of license template isn't shown in visual diff.
Thu, Apr 12, 1:58 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), VisualEditor-VisualDiffs
Elitre awarded T192076: Removal of license template isn't shown in visual diff a Like token.
Thu, Apr 12, 1:57 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders added a comment to T192076: Removal of license template isn't shown in visual diff.

Testing with a monkey patch:

Thu, Apr 12, 1:57 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

I was wondering before if the dialog should contain either a visual example of rich vs plaintext, or a snippet of your actual pasted content in both modes? The latter probably has more problems, e.g. when your pasted text is very long or contains almost no formatting.

Thu, Apr 12, 12:29 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T178387: Standardise vertical option/button group popup widgets.

Experimenting, one of the problems is DropdownWidgets clip the menu width to the same size as the handle width. We need a dropdown that behaves more like a menu tool group.

Thu, Apr 12, 11:57 AM · UI-Standardization, UI-Standardization-Kanban, OOUI
Esanders added a comment to T191432: Use 14px font size in ContentTranslation.

This should be addressed soon - at least in the translation view, as frontend work is now proceeding, and issues around font-size and layout are somewhat blocked on this.

Thu, Apr 12, 11:30 AM · UI-Standardization-Kanban, UI-Standardization, ContentTranslation

Wed, Apr 11

Esanders moved T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector from Up next to Code review and QA on the VisualEditor (Current work) board.
Wed, Apr 11, 9:25 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Contributors-Team, VisualEditor (Current work)
Esanders edited projects for T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector, added: VisualEditor (Current work); removed VisualEditor.
Wed, Apr 11, 9:19 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Contributors-Team, VisualEditor (Current work)
Esanders triaged T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector as Unbreak Now! priority.
Wed, Apr 11, 3:31 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Contributors-Team, VisualEditor (Current work)
Esanders created T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector.
Wed, Apr 11, 3:22 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Contributors-Team, VisualEditor (Current work)
Esanders added a comment to T184467: CodeMirror in 2017 Wikitext Editor shows overlapping text in Firefox.

I've tested with FF 59.0 and OSX 10.11 (El Capitan) and everything looks perfect on the linked page.

Wed, Apr 11, 11:48 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), Patch-For-Review, VisualEditor (Current work), Browser-Support-Firefox, MediaWiki-extensions-CodeMirror, Chinese-Sites, Community-Tech

Tue, Apr 10

Esanders updated subscribers of T93243: Flow's VE toolbar v2.

The z-index should be an easy fix, I'm sure @matmarex knows what to do.

Tue, Apr 10, 7:39 PM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, User-notice, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T178387: Standardise vertical option/button group popup widgets.

I'm thinking this could be done with some small changes the DropdownWidget, such as making the handle frameless, and not changing the label when an item is selected.

Tue, Apr 10, 6:51 PM · UI-Standardization, UI-Standardization-Kanban, OOUI
Esanders added a comment to T178387: Standardise vertical option/button group popup widgets.

This would also apply to the topic bar in Flow:


Tue, Apr 10, 6:49 PM · UI-Standardization, UI-Standardization-Kanban, OOUI
Esanders added a comment to T93243: Flow's VE toolbar v2.

Yes, but that's a bigger piece of work. My commit was just to restore some advanced formatting in a minimally disruptive way.

Tue, Apr 10, 6:40 PM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, User-notice, Collaboration-Team-Triage, StructuredDiscussions
Esanders renamed T169890: Replace Apex icons with WikimediaUI icons from Backfill missing Apex icons with WikimediaUI icons to Replace Apex icons with WikimediaUI icons.
Tue, Apr 10, 5:12 PM · OOUI (OOUI-0.26.3)
Esanders added a comment to T191031: Use OOUI icons in WikiEditor.

Also if you are referring to some icons being different in Apex that's because they are, but that will soon change with T169890.

Tue, Apr 10, 5:11 PM · Verified, User-notice, VisualEditor (Current work), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Design, WikiEditor
Esanders updated subscribers of T191031: Use OOUI icons in WikiEditor.

Also I note that the new elements don't have textual content, only a title= attribute. As such this is a reduction in accessibility from before.

Tue, Apr 10, 5:09 PM · Verified, User-notice, VisualEditor (Current work), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Design, WikiEditor
stjn awarded T191031: Use OOUI icons in WikiEditor a Love token.
Tue, Apr 10, 11:40 AM · Verified, User-notice, VisualEditor (Current work), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Design, WikiEditor
Esanders created T191883: API sandbox: Tag popup has no padding.
Tue, Apr 10, 10:26 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, MediaWiki-Special-pages
Esanders renamed T191878: Insertion link into an empty table cell causes scroll jump from Insertion link into a table causes scroll jump to Insertion link into an empty table cell causes scroll jump.
Tue, Apr 10, 9:50 AM · VisualEditor-Tables, VisualEditor (Current work), Patch-For-Review
Esanders created T191878: Insertion link into an empty table cell causes scroll jump.
Tue, Apr 10, 9:47 AM · VisualEditor-Tables, VisualEditor (Current work), Patch-For-Review
Esanders triaged T191858: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) as Low priority.

That is definitely very broken table syntax, but ideally we wouldn't throw an exception.

Tue, Apr 10, 9:43 AM · VisualEditor-ContentEditable, VisualEditor

Mon, Apr 9

Esanders claimed T191818: Linear context mixins break nested widgets.
Mon, Apr 9, 5:15 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work)
Esanders moved T191818: Linear context mixins break nested widgets from Up next to Code review and QA on the VisualEditor (Current work) board.
Mon, Apr 9, 5:15 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work)
Esanders edited projects for T191818: Linear context mixins break nested widgets, added: VisualEditor (Current work); removed VisualEditor.
Mon, Apr 9, 5:13 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work)
Esanders added a comment to T93243: Flow's VE toolbar v2.

It just goes straight up past the edge of the textarea, it is only bounded by the browser window.

Mon, Apr 9, 5:13 PM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, User-notice, Collaboration-Team-Triage, StructuredDiscussions
Esanders created T191818: Linear context mixins break nested widgets.
Mon, Apr 9, 4:57 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work)
Esanders added a comment to T93612: Auto-save post boxes locally.

VE now has an API for this (ve.dm.Surface#startAutoSave). It uses sessionStorage, as we are worried about storage limits with multiple large documents, but that could easily be switched to localStoarge - but sessionStorage is good enough for crash recovery.

Mon, Apr 9, 4:12 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T125222: Support a given subpage as the "official" documentation subpage for templates, to avoid duplicate TemplateData.

Is the purpose of this task to determine what doc pages usually are called on different projects?

Mon, Apr 9, 1:23 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), TemplateData
Esanders added a comment to T125222: Support a given subpage as the "official" documentation subpage for templates, to avoid duplicate TemplateData.

cswiki should be doc, but in that system message it is correct

Mon, Apr 9, 1:22 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), TemplateData
Esanders closed T58701: Flow: Agora CSS issues in IE8 as Declined.

5 years later and IE8 is not longer a supported client.

Mon, Apr 9, 12:40 PM · Collaboration-Team-Triage, StructuredDiscussions, Browser-Support-Internet-Explorer
Esanders closed T58701: Flow: Agora CSS issues in IE8, a subtask of T56360: implement updated appearance to Mediawiki.ui (tracking), as Declined.
Mon, Apr 9, 12:40 PM · Tracking, Design, MediaWiki-MediaWiki-UI
Esanders closed T58701: Flow: Agora CSS issues in IE8, a subtask of T87121: IE 8 support - Flow issues (tracking), as Declined.
Mon, Apr 9, 12:40 PM · Browser-Support-Internet-Explorer, Collaboration-Team-Triage, StructuredDiscussions, Tracking
Esanders closed T66030: Flow: hover state of Expand topics icon needs RTL version as Resolved.
Mon, Apr 9, 12:38 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders closed T70464: Flow: inconsistent right margins and right-aligned icon placement as Resolved.

These are either fixed or no longer valid

Mon, Apr 9, 12:36 PM · Collaboration-Team-Triage, Design, StructuredDiscussions
Esanders closed T110309: Editing pencil for Flow descriptions is always blue as Resolved.

This is now a standard OOUI progressive button, with blue text and icon.

Mon, Apr 9, 12:27 PM · WorkType-NewFunctionality, Collaboration-Team-Triage, StructuredDiscussions

Sun, Apr 8

Esanders triaged T191644: Ctrl + M shortcut is supposed to clear style in visual mode but it opens the ULS inspector instead on Chromium as Low priority.
Sun, Apr 8, 4:34 PM · VisualEditor

Sat, Apr 7

Esanders merged T139804: Feature request: text is auto-saved in flow into T93612: Auto-save post boxes locally.
Sat, Apr 7, 4:40 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders merged task T139804: Feature request: text is auto-saved in flow into T93612: Auto-save post boxes locally.
Sat, Apr 7, 4:40 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T93243: Flow's VE toolbar v2.

The above just adds 'more' to the text styling menu, which exposes the remaining text styling tools.

Sat, Apr 7, 1:19 PM · User-notice-collaboration, Patch-For-Review, Community-Liaisons, User-notice, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T191693: Restore toolbar border in SD+WMUI/Vector.

After:

Sat, Apr 7, 12:40 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Design, StructuredDiscussions
Esanders created T191693: Restore toolbar border in SD+WMUI/Vector.
Sat, Apr 7, 12:38 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Design, StructuredDiscussions
Esanders edited projects for T190079: Prompt user before automatically converting pasted HTML to wikitext, added: VisualEditor (Current work); removed VisualEditor.
Sat, Apr 7, 11:45 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Esanders created P6966 esanders pubkey 2.
Sat, Apr 7, 11:15 AM

Fri, Apr 6

Esanders updated the task description for T124020: Duplicate icons: Bigger/Smaller and LargerText/SmallerText.
Fri, Apr 6, 12:34 PM · OOUI
Esanders added a parent task for T191623: Add missing icons for table row/col move: T190967: Align further (VE) icons to icon guidelines.
Fri, Apr 6, 12:32 PM · Patch-For-Review, User-Ryasmeen, VisualEditor-Tables, OOUI (OOUI-0.26.3), VisualEditor, Design
Esanders added a subtask for T190967: Align further (VE) icons to icon guidelines: T191623: Add missing icons for table row/col move.
Fri, Apr 6, 12:32 PM · VisualEditor (Current work), Design, OOUI
Esanders triaged T191623: Add missing icons for table row/col move as High priority.
Fri, Apr 6, 12:31 PM · Patch-For-Review, User-Ryasmeen, VisualEditor-Tables, OOUI (OOUI-0.26.3), VisualEditor, Design
Esanders created T191623: Add missing icons for table row/col move.
Fri, Apr 6, 12:31 PM · Patch-For-Review, User-Ryasmeen, VisualEditor-Tables, OOUI (OOUI-0.26.3), VisualEditor, Design
Esanders added a subtask for T55733: Use the same icons to represent the same things (tracking): T177847: Merge Cite icons into OOUI.
Fri, Apr 6, 12:28 PM · UI-Standardization, OOUI, Tracking, Easy, Design, MediaWiki-General-or-Unknown
Esanders added a parent task for T177847: Merge Cite icons into OOUI: T55733: Use the same icons to represent the same things (tracking).
Fri, Apr 6, 12:28 PM · Cite, OOUI