Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (325 w, 1 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders claimed T272314: "References" section always has a grey background for some reason in visual diffs.
Tue, Jan 19, 10:40 PM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T272314: "References" section always has a grey background for some reason in visual diffs.

Looks like it has data-diff-move="null", I don't think that attribute should be there at all if the value is null

Tue, Jan 19, 10:35 PM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T271614: Code gets copied double-spaced on new syntax-highlighted pages on Firefox.

https://patchdemo.wmflabs.org/wikis/b47a017de5c94e68321e246f05fbd175/w/index.php/MediaWiki:Common.css

Tue, Jan 19, 8:55 PM · Patch-For-Review, SyntaxHighlight
Esanders added a comment to T271614: Code gets copied double-spaced on new syntax-highlighted pages on Firefox.

Actually it turns out that the previous hack of user-select:none is causing FF to split the selection into multiple ranges, which adds the linebreaks. Removing that hack fixes FF.

Tue, Jan 19, 8:31 PM · Patch-For-Review, SyntaxHighlight
Esanders added a comment to T271614: Code gets copied double-spaced on new syntax-highlighted pages on Firefox.

Well that's annoying. I can see no reason for FF to add those linebreaks, and I've tried messing around with the styling of the numbers (resetting white-space:pre on them, using different display values) to no avail.

Tue, Jan 19, 8:23 PM · Patch-For-Review, SyntaxHighlight
Esanders added a project to T271773: Consider the tab order for the Reply tool: Accessibility.
Tue, Jan 19, 6:27 PM · Accessibility, DiscussionTools
Esanders renamed T272393: Title not cleared when discarding a new topic from Bug: clearing out cancelled content on new discussions to Title not cleared when discarding a new topic.
Tue, Jan 19, 5:26 PM · Patch-For-Review, OWC2020 (New Discussion 1.0), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated the task description for T272393: Title not cleared when discarding a new topic.
Tue, Jan 19, 5:25 PM · Patch-For-Review, OWC2020 (New Discussion 1.0), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T267404: Add reply links to the parser cache.

Yes, eventually: T251207: [Epic] Scale DiscussionTools to all Wikipedias

Tue, Jan 19, 5:07 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, Performance Issue, DiscussionTools
Esanders added a comment to T267404: Add reply links to the parser cache.

@Esanders is this something that can be disabled/expired if needed?

  • what if once this is deployed it causes disk issues on our parsercache infra? can this be rolled back/disabled/keys deleted

It's pretty easy to rollback this feature, we will also have a flag so it can disabled via config.

Tue, Jan 19, 4:58 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, Performance Issue, DiscussionTools
Esanders closed T272188: VE API: Return structured information about edit notices so they can be filtered by clients, a subtask of T270454: Implement edit notice logic, as Resolved.
Tue, Jan 19, 3:43 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
Esanders closed T272188: VE API: Return structured information about edit notices so they can be filtered by clients as Resolved.

Not much to sign off here either.

Tue, Jan 19, 3:43 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), VisualEditor-MediaWiki, VisualEditor, Editing-team (FY2020-21 Kanban Board), OWC2020 (New Discussion 1.0)
Esanders created T272389: Starting a new discussion while the tool is already open will launch the old editor.
Tue, Jan 19, 3:38 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), OWC2020 (New Discussion 1.0), DiscussionTools
Esanders added a comment to T272322: Check for line breaks in user signatures.

This seems sensible and uncontroversial:

  • they cause problems
  • they add no real value
  • they are extremely rare
  • it is already implied that you aren’t supposed to use them because the signature input is single line
Tue, Jan 19, 12:45 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Parsoid, DiscussionTools, MediaWiki-User-preferences

Sat, Jan 16

Esanders added a comment to T272231: WikiLambda initial installation fails when TemplateData is installed.

Also the test suite fails.

Sat, Jan 16, 10:06 PM · VisualEditor, TemplateData, Abstract Wikipedia
Esanders added a comment to T271868: New Vector skin breaks "position: sticky" layouts.

This also affects the sticky button bar on Special:Preference (for save/cancel buttons). The patch above appears to fix it.

Sat, Jan 16, 5:07 PM · Desktop Improvements, Vector, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Esanders added a comment to T270120: Revise existing Discussion tools Beta Feature .

nb we can link straight to the discussion section using Special:Preferences#mw-prefsection-editing-discussion

Sat, Jan 16, 4:56 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated subscribers of T272077: Enable the New Discussion Tool as an opt-out setting on Beta Cluster.

After talking with @Ryasmeen, we came to think there is value in keeping the New Discussion Tool deployed as a beta feature on the beta cluster initially [i] to ensure the pre-deployment QA we have planned [ii] will happen in an environment that closely resembles the environments where it will be available.

Once we verify the tool is working as expected in this environment, we can graduate it to an opt-out setting on the beta cluster.

Sat, Jan 16, 4:40 PM · Patch-For-Review, DiscussionTools, Editing-team

Fri, Jan 15

Esanders created T272188: VE API: Return structured information about edit notices so they can be filtered by clients.
Fri, Jan 15, 10:50 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), VisualEditor-MediaWiki, VisualEditor, Editing-team (FY2020-21 Kanban Board), OWC2020 (New Discussion 1.0)
Esanders updated the task description for T270454: Implement edit notice logic.
Fri, Jan 15, 10:30 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
Esanders added a comment to T270454: Implement edit notice logic.

It appears that talkpagetext is not included in the VE edit notices API (which the tool would use) so is not currently an issue. Clearly we never bothered to add it because VE is not supposed to be used on talk pages.

Fri, Jan 15, 10:28 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
Esanders added a comment to T271792: Put line numbers in left side also in RTL wikis.

Verified on beta cluster: https://he.wikipedia.beta.wmflabs.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Common.css

Fri, Jan 15, 10:18 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, I18n, RTL
Esanders committed rESHGe5238a17a848: Line numbers use mw-content-ltr/rtl direction (authored by Ebraminio).
Line numbers use mw-content-ltr/rtl direction
Fri, Jan 15, 10:08 PM
Esanders committed rESHGc895f1c9e4e4: Remove unused directionality styles (authored by Esanders).
Remove unused directionality styles
Fri, Jan 15, 10:08 PM
Esanders committed rESHG2d3af74c3915: Add mw-content-ltr/rtl classes to inline snippets (authored by Esanders).
Add mw-content-ltr/rtl classes to inline snippets
Fri, Jan 15, 9:37 PM
Esanders committed rESHG76fd10659b67: Remove -o-tab-size rule, no longer required by Grade C browsers (authored by Esanders).
Remove -o-tab-size rule, no longer required by Grade C browsers
Fri, Jan 15, 9:37 PM
Esanders added a comment to T265094: Line break in a link label was changed to a space.

This still appears to be happening today on wmf26: https://dtcheck.toolforge.org/dtcheck-2021-01-15.html

Fri, Jan 15, 9:23 PM · Patch-For-Review, Editing-team (Tracking), DiscussionTools, Parsoid
Esanders added a comment to T259865: Add support for voting-style discussions.

Is this vote easy enough to figure out?

Fri, Jan 15, 9:17 PM · Editing-team (Tracking), DiscussionTools
Esanders added a comment to T270146: New Vector breaks OO.ui.Element.static.scrollIntoView and sticky layouts.

Verified on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page using OO.ui.Element.static.scrollIntoView( $('#footer-info-credits')[0] )

Fri, Jan 15, 9:05 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector, OOUI
Esanders updated subscribers of T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.

Could be https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630182 ?

Fri, Jan 15, 5:50 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MediaWiki-extensions-FlaggedRevs, ci-test-error
Esanders added a project to T271792: Put line numbers in left side also in RTL wikis: SyntaxHighlight.
Fri, Jan 15, 5:38 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, I18n, RTL
Esanders added a comment to T271792: Put line numbers in left side also in RTL wikis.

Thanks for this. The extension is actually supposed to support <syntaxhighlight dir=rtl>.... In this case the line numbers would be on the right, so I've amended your patch to position line numbers based on code block directionality (which defaults to LTR on all wikis).

Fri, Jan 15, 5:38 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, I18n, RTL
Jdforrester-WMF awarded T270775: Arrange diffs with CSS grid layout a Like token.
Fri, Jan 15, 5:02 PM · Patch-For-Review, MediaWiki-Page-diffs
Esanders added a comment to T272076: Enable the New Discussion Tool as a beta feature on Beta Cluster.

Note also that the newtopictool was enabled by default on beta for the last 2 days, as we hadn't touched the config file for the beta cluster (only the file for production wikis). After the patch above was merged it is now a beta feature.

Fri, Jan 15, 12:07 AM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), DiscussionTools

Thu, Jan 14

Esanders added a comment to T272076: Enable the New Discussion Tool as a beta feature on Beta Cluster.

I think we should just make the tool available by default on the beta cluster, as we did with the reply tool in T255223.

Thu, Jan 14, 11:57 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T272071: Investigate how to retain Discussion tools beta feature when some sub-features are fully deployed.

I agree, I don't think the beta feature needs to be visible if it does nothing, we just don't want it to wipe a user's previous preference.

Thu, Jan 14, 11:38 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders committed rESHG8d645a385c5e: De-emphasise line numbers (authored by Esanders).
De-emphasise line numbers
Thu, Jan 14, 6:23 PM
Esanders committed rESHG63c5943a9f6b: Don't try to highlight elements not in a code block (authored by Esanders).
Don't try to highlight elements not in a code block
Thu, Jan 14, 6:23 PM
Esanders committed rESHG8f09ace86bf3: Don't throw an error when location.hash in unparseable (authored by Esanders).
Don't throw an error when location.hash in unparseable
Thu, Jan 14, 6:23 PM
Esanders created T272048: Edit summary should be restored by auto-save.
Thu, Jan 14, 3:57 PM · VisualEditor-MediaWiki, VisualEditor
Esanders renamed T271956: De-emphasise line numbers when showing code from De-emphasise line numbers when printing code to De-emphasise line numbers when showing code.
Thu, Jan 14, 12:11 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor
Esanders updated the task description for T271956: De-emphasise line numbers when showing code.
Thu, Jan 14, 12:11 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor
Esanders updated the task description for T271956: De-emphasise line numbers when showing code.
Thu, Jan 14, 12:06 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor
Esanders added a comment to T270926: Refine bracket matching styling.

I agree that on a very dense template definition page, the bracket matching benefits from being stronger, however syntax highlighting is used on all pages and I suspect the vast majority of users are using it to just edit article content, so most bracket matching will be for simple wiki links. This is the use case I encountered and where I found the background change to disrupt the readability of the content.

Thu, Jan 14, 11:58 AM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Esanders closed T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js) as Resolved.

@Krinkle You might want to cross post the above comment to T9356, as it’s out of scope for this task, but is a good outline for how that task might be resolved.

Thu, Jan 14, 11:46 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Krinkle awarded T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js) a Orange Medal token.
Thu, Jan 14, 2:21 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight

Wed, Jan 13

Esanders added a comment to T244114: "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null".

@Pginer-WMF @santhosh We've had a brief look at this, but we're struggling to reproduce the issue. Could you provide or highlight the reproduction steps?

Wed, Jan 13, 9:14 PM · Language-Team (Language-2021-January-March), JavaScript, Editing-team (FY2020-21 Kanban Board), Wikimedia-production-error, ContentTranslation
Esanders moved T269157: Create more aesthetic cohesion between components in New Discussion from Ready for Development to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Jan 13, 8:57 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Editing Design, OWC2020
Esanders claimed T269157: Create more aesthetic cohesion between components in New Discussion .
Wed, Jan 13, 8:55 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Editing Design, OWC2020
Esanders added a comment to T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.

I've fixed the links in the task description.

Wed, Jan 13, 8:54 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight
Esanders updated the task description for T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.
Wed, Jan 13, 8:53 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight
Esanders added a comment to T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.

I see the error if the hash is set to #/search

Wed, Jan 13, 8:33 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight
Esanders added a comment to T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.

Also can't reproduce, or see the error in logstash with the link provided

Wed, Jan 13, 8:29 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight
Esanders updated subscribers of T260815: Store real SVGs icon files in the repo.
Wed, Jan 13, 7:18 PM · WVUI, Vue.js
Esanders added a comment to T267404: Add reply links to the parser cache.

@LSobanski we are adding a new parser cache option, which can only ever be set on talk pages (approximately).

Wed, Jan 13, 6:52 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, Performance Issue, DiscussionTools
Od1n awarded T271956: De-emphasise line numbers when showing code a Like token.
Wed, Jan 13, 5:48 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor
Esanders added a comment to T270120: Revise existing Discussion tools Beta Feature .

Personally I don't think this is worth the effort. A message which just describes the possible features with links to your preferences would be sufficient, given the nature of beta features.

Wed, Jan 13, 5:25 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T32773: Enable line numbers for pages handled by SyntaxHighlight.

Follow-up: T271956

Wed, Jan 13, 4:54 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), SyntaxHighlight
Esanders created T271956: De-emphasise line numbers when showing code.
Wed, Jan 13, 4:48 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor
Esanders updated subscribers of T267404: Add reply links to the parser cache.

CC @LSobanski . We are planning to merge this for next week's train. It will split the parser cache on talk pages for user who have this feature enabled.

Wed, Jan 13, 4:40 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, Performance Issue, DiscussionTools
Esanders updated the task description for T271942: CodeMirror toolbar should not show "> Cite" button.
Wed, Jan 13, 2:52 PM · CodeEditor
Esanders created T271942: CodeMirror toolbar should not show "> Cite" button.
Wed, Jan 13, 2:48 PM · CodeEditor

Tue, Jan 12

Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

Some users have reported that sessionStorage does not appear to persist in Firefox when the browser crashes.

Tue, Jan 12, 8:50 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, VisualEditor-MediaWiki
Esanders updated the task description for T267404: Add reply links to the parser cache.
Tue, Jan 12, 6:54 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, Performance Issue, DiscussionTools
Esanders added a comment to T32773: Enable line numbers for pages handled by SyntaxHighlight.

I set them to the same colour as they are in the editor. They could probably be a bit lighter but we will need to maintain an accessible contrast and consistency between interfaces.

Tue, Jan 12, 6:34 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), SyntaxHighlight
Esanders added a comment to T270121: Always show Reply Tool preference in Special:Preferences when Discussion Tools Beta Feature is enabled .

This can currently be verified on mediawiki.org. The reply tool option now shows in the Editing section of Special:Preferences.

Tue, Jan 12, 6:29 PM · Verified, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated subscribers of T271153: iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page message.

@Tsevener do you find that most users auto-update to the latest version of the app quite quickly? i.e. should we expect to see edits with the <p> tags dry up soon after the deployment?

Tue, Jan 12, 6:28 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog, Editing-team (Tracking), iOS-app-Bugs

Mon, Jan 11

Esanders reopened T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js) as "Open".

Re-using this task for the Scribunto (Lua modules) support.

Mon, Jan 11, 7:55 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Esanders added a comment to T221908: Deploy visual section editing on Desktop.
  • the editor loads faster (sometimes much faster)
Mon, Jan 11, 5:43 PM · VisualEditor
Esanders added a comment to T270107: Show reason, date in CitationNeededContextItem when available.

Because fr.wiki uses the same template for a simple "citation needed" number and also wrapped text (Template:Citation_needed_span on English Wikipedia) I would advise not setting it up until T265907 is resolved, otherwise people using the tool on wrapped text usages would get the text deleted.

Mon, Jan 11, 5:33 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), User-Ryasmeen, User-notice, Cite, VisualEditor
SD0001 awarded T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js) a Love token.
Mon, Jan 11, 4:55 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Esanders added a comment to T270107: Show reason, date in CitationNeededContextItem when available.

If the wiki is already using the feature successfully, you can copy the params config from en.wiki: https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-template-tools-definition.json

Mon, Jan 11, 3:44 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), User-Ryasmeen, User-notice, Cite, VisualEditor
Esanders added a comment to T270107: Show reason, date in CitationNeededContextItem when available.

Documentation task is here T265878, but we need to close out T265907 before rolling out to more wikis. Which wiki were you thinking?

Mon, Jan 11, 3:43 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), User-Ryasmeen, User-notice, Cite, VisualEditor
Esanders added a comment to T266140: HTML entity replaced by the Unicode character in an edit.

Appears to be working on beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User_talk:ESanders_(WMF)&type=revision&diff=469806&oldid=469805&diffmode=source

Mon, Jan 11, 3:40 PM · Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Parsoid, DiscussionTools
Esanders added a comment to T270120: Revise existing Discussion tools Beta Feature .

If it is essentially to list which features are still in beta, that would be easiest to do as an actual list, then we can build it dynamically, e.g.

Enables experimental talk page features:

  • a new workflow for [replying to specific comments]
  • [adding new discussion topics]
  • [visual enhancements]

...I like this idea; I've updated the task description to incorporate the above.

Mon, Jan 11, 3:30 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Sat, Jan 9

Esanders added a comment to T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js).

@Johan, correct.

And why is that? Why exclude Lua? Bizarre choice.

Sat, Jan 9, 2:41 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight

Fri, Jan 8

Izno awarded T32773: Enable line numbers for pages handled by SyntaxHighlight a Love token.
Fri, Jan 8, 5:19 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), SyntaxHighlight
Esanders added a comment to T270926: Refine bracket matching styling.

I was wondering why the patchdemo wasn't working, but I remembered that the feature is currently disabled by default behind a feature flag. Currently you can't change mediawiki config while setting up a patchdemo (unless you create a patch to change the config).

Fri, Jan 8, 2:31 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Esanders added a comment to T270926: Refine bracket matching styling.

unchecked vector skin.

Fri, Jan 8, 2:29 PM · Unplanned-Sprint-Work, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea, WMDE-QWERTY-Sprint-2021-01-06, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror

Thu, Jan 7

Esanders added a comment to T271457: Uncaught TypeError: Cannot read property 'modules' of undefined.

The above patch just bails if the editor input no longer has WikiEditor data when the initialisation runs.

Thu, Jan 7, 9:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), JavaScript, Wikimedia-production-error, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Esanders added a comment to T271457: Uncaught TypeError: Cannot read property 'modules' of undefined.

The offending change made sure that the syntax highlight plugin runs more reliably by running as a hook instead of an event.

Thu, Jan 7, 9:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), JavaScript, Wikimedia-production-error, Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Esanders added a comment to T264028: Whitespace in <nowiki>…</nowiki> normalized or something.

Also https://fr.wikipedia.org/?diff=178528344 and maybe https://fr.wikipedia.org/?diff=178513936 (a self-closing nowiki removed)

Thu, Jan 7, 7:57 PM · DiscussionTools, Parsoid
Esanders added a comment to T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js).

Is there a way to opt-out of this?

Thu, Jan 7, 1:37 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Esanders renamed T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js) from Implement link anchors to line numbers of <syntaxhighlight> contents to Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js).
Thu, Jan 7, 1:30 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Esanders added a comment to T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js).

@Johan, correct.

Thu, Jan 7, 1:28 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight
Esanders added a comment to T241403: Make talk page language discussion-specific.

Also “contents” in the table of contents.

Thu, Jan 7, 1:28 PM · Editing Design, DiscussionTools, Editing-team
Esanders added a comment to T252902: Redesign empty state for talk pages that have not been created.

If we wanted to give people the option to use the new discussion tool on empty pages, we would need to intercept red links. We would likely still want to give people the option to use the full page editor.

Thu, Jan 7, 1:10 PM · DiscussionTools, Editing Design, Editing-team, OWC2020
Esanders updated the task description for T252902: Redesign empty state for talk pages that have not been created.
Thu, Jan 7, 1:03 PM · DiscussionTools, Editing Design, Editing-team, OWC2020
Esanders removed a project from T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog: Editing QA.
Thu, Jan 7, 12:46 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders moved T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog from Blocked / Needs More Work to Doing on the Editing-team (FY2020-21 Kanban Board) board.

Sorry @Ryasmeen, the patch was reverted, hence the “re-apply” patch that is still in review.

Thu, Jan 7, 12:46 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders moved T172694: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog from Doing to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Jan 7, 12:45 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions

Tue, Jan 5

Esanders updated the task description for T250768: [SPIKE] How will the New Discussion Tool be made to support preloaded discussion templates.
Tue, Jan 5, 7:52 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
Esanders added a comment to T270796: Message boxes classes should carry `mw-`.

I feel like the word order should be changed to be increasing specificity, so <namespace>-<feature>-<modifier> instead of <namespace>-<modifier>-<feature>.

Tue, Jan 5, 7:33 PM · Tech-Ambassadors, Patch-For-Review, MediaWiki-Installer, MediaWiki-General, CSS
Esanders added a comment to T270883: Bundlesize should not be cause V-1 when size increases by a few bytes.

I don't think we should be rounding up to 0.1kb. That's silly IMO and I suspect rounding up by say 0.5kb would reduce the frequency of these errors.

Tue, Jan 5, 7:22 PM · Readers-Web-Backlog, Vector
Esanders added a comment to T270146: New Vector breaks OO.ui.Element.static.scrollIntoView and sticky layouts.

Copied from Slack:

Tue, Jan 5, 5:36 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector, OOUI
Esanders added a comment to T221908: Deploy visual section editing on Desktop.
  1. I would feel more comfortable if we did some kind of test between the solutions to:
    • validate if this is a change that is warranted (although I personally am a fan of the standardization)
Tue, Jan 5, 1:05 PM · VisualEditor

Mon, Jan 4

Esanders added a comment to T271153: iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page message.

PR: https://github.com/wikimedia/wikipedia-ios/pull/3818

Mon, Jan 4, 9:06 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog, Editing-team (Tracking), iOS-app-Bugs
Esanders added a comment to T271153: iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page message.

This looks like the source: https://github.com/wikimedia/wikipedia-ios/commit/f64a83b00275d13439b2d9c5cf5dcaf169b8226f

Mon, Jan 4, 9:04 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog, Editing-team (Tracking), iOS-app-Bugs
Esanders triaged T271153: iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page message as High priority.
Mon, Jan 4, 8:24 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog, Editing-team (Tracking), iOS-app-Bugs
Esanders added a comment to T265094: Line break in a link label was changed to a space.

@matmarex How do users get linebreaks in their signatures in the first place? (e.g. https://simple.wikipedia.org/w/index.php?target=Fehufanga&namespace=3&tagfilter=&start=&end=&limit=50&title=Special%3AContributions)

Mon, Jan 4, 12:23 PM · Patch-For-Review, Editing-team (Tracking), DiscussionTools, Parsoid