T306440 has been merged.
Tue, Aug 16
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804591/ has been merged, which means we can set expiry times on local storage items. Along with the above patch I think all the technical barriers to doing this have been lifted.
The above patch partially resolves this issue by setting wgPostEdit when redirecting after save. As VE always redirects after save when creating a new page this should be sufficient for your use case @ifried, however wgPostEdit is still not set after edits to existing pages, so we should leave this task open.
The "created" notification was still working but only because undefined is falsey.
Actually that won't work for page creations because we redirect setting venotify. We can set wgPostEdit when that happens though, based on venotify...
Looks like I made a scope typo in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/791691/2/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js
There is code present to set venotify to restored so I assume this is just a regression.
We don't set wgPostEdit (that could probably be adding to jsconfigvars in ApiVisualEditorEdit.php), but when we fire the postEdit hook, the target still exists, so you can check if it's a new page by looking at ve.init.target.pageExists.
Mon, Aug 15
It's a regression from Vector classic
There are a few dozens test cases in parserTests.txt where the whole table of contents is asserted, checking things like this encoding issue and also deduplication of duplicate headings. I would suggesting making a Vector-2022 version of these tests.
Fri, Aug 12
Per my comment above I propose changing the current wording of the notification from:
- Topic X was removed from page Y
- Topic X was archived or removed from page Y
- Is it possible to filter out/suppress/not notify people about discussions that are moved by bots? If so, how much complexity would implementing this add to this task?
As part of this task, offer people the ability to elect to stop receiving notifications of this sort
Thu, Aug 11
You can test the new heading with dtenable=1: https://fa.wikipedia.org/w/index.php?oldid=35343366&dtenable=1#A_report:_IP_Editing_Restriction_Study_on_Farsi_Wikipedia
I like the current amount of whitespace. The proposed spacing looks too tight, and it looks odd that the spacing between comments is equal or greater than the spacing between the comment area and the heading.
append the banner on the page after loading the parsed content
I do not want to be notified when a discussion gets moved to an /Archive page. This is a normal and routine action. If you are an experienced editor, you will expect it; if you are an inexperienced editor, you may be confused by it (what's archiving?!). It does not deserve my attention. Just make the subscription keep working and don't bother me about it. Notifications are for things that need my attention, not for convincing me that the topic subscriptions software works.
Wed, Aug 10
Both are set to 60em, but one is at 16px font size and the preview is at 14px, hence the difference.
- That should be removed in Vector 2022. I think in classic Vector it is to make the toolbar top border a continuous line.
- Not really, but I don't think there's a good way to prevent it. Setting overflow:hidden on the toolbar would probably cause many other problems.
The patch above adds "first subscribed" and "latest notification" dates to the table.
Tue, Aug 9
Decided with @ppelberg:
- Not to display any display names in the default list when you first press '@'
- If a search string matches a display name, then show any matches, example from task description: Search for "jame" would show "Jdforrester" as a match
Testing extracting display names against our test corpus (which isn't very representative: it include a Village Pump (technical) snapshot, and some other talk pages from fr/ar/pl), I've tried to categorise the results so we can what type of things we would get by pulling in display names. I've excluded any results where the display name is a substring of the username.
Transliteration - these are "good" results and one of the big reasons we should try to support this
"Adil Faouzi -> عادل فوزي" "Arvedui89 -> Aʀvєδuι" "Azoee -> Azoée" "Azoee -> azoée" "Bander7799 -> بندر" "Daxipedia -> Daxipedia - 達克斯百科" "FShbib -> شبيب.." "Mustafa -> مصطفى" "Þjarkur -> Thjarkur" "קיפודנחש -> קיפודנחש (aka kipod)" // Removing some diacritics? "شيماء -> شَيْمَاء"
The patch above uses the messages:
- Replying on <pagename>
- Starting new topic on <pagename>
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/821353 would probably allow you do this with CSS. Care should be taken to support copying of the title with the original : so it can be used for linking.
Sun, Aug 7
Sat, Aug 6
The timezone format on that wiki was changed around 2015 (https://cs.wikipedia.org/wiki/Diskuse:Hlavn%C3%AD_strana/Archiv3). I believe we identified this issue when we were deploying the reply tool, and obviously it affects all tools. Our assumption is that the vast majority of conversations that old have been archived.
Fri, Aug 5
I'm still unsure as to why something that's supposed to be part of the interface shows up on parsed HTML
This is also true of section edit links
The use case being you have just edited a page and the banner should be shown. An editor like VE which updates the page dynamically does so by fetching the new page contents from action=parse, so this needs to return the full rendering of the page, including this banner.
Thu, Aug 4
Also doesn't show for me. The new topic buttons should not show on any pages with __NONEWSECTIONLINK__ such as this one. Do you have any gadgets enabled that could be causing this? What happens if you load the page in safemode (https://www.mediawiki.org/wiki/Manual:Safemode)?
NB this is just for history pages. Visual diffs have been enabled in VE by default for a long time. I agree this is pretty low risk, the default is still wikitext and this will just show a switcher in the top right.
Wed, Aug 3
Yes - just exposing the UI to create them.
Tue, Aug 2
The CommentParser will only consider content from the signature back to the next heading to be part of a comment. Sub headings are more often used to break up conversations than be part of a comment.
Screenshot from Slack:
Mon, Aug 1
The above three patches fix the three issues in the description respectively.
Sun, Jul 31
Sat, Jul 30
Since we fixed T301839 this can just be enabled on mobile.
Thu, Jul 28
This will ride the train next week, so on each day of the train (Group 0/1/2 Tue/Wed/Thu) we should do some sanity checking on a few wikis in each group, where we look at the main page and some random talk pages.
Wed, Jul 27
When the Preview reloads, DISABLE or hide the toolbar:
Tue, Jul 26
See also T313804
Sun, Jul 24
Fri, Jul 22
This patch ^ solves the topic container issue without addressing T298617.
From the patch: