Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (273 w, 3 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Thu, Jan 16

Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

I think it would be more consistent to remove borders from all tool groups (except menus) by default, then if individual products have use cases to add them back in they can. We could even add an API for manual spacers.

Thu, Jan 16, 7:31 PM · Patch-For-Review, VisualEditor (Current work), Editing Design, Design, OOUI
Esanders added a comment to T237019: Spacing between icons and labels is too large in tablet mode.

We don't do uneven px distances in our interfaces, but try to orient on an 8px base (4px is ok, 6px should be the absolute exception).

Thu, Jan 16, 1:45 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Design, MinervaNeue
Esanders added a comment to T237019: Spacing between icons and labels is too large in tablet mode.

In the vertical menu the horizontal spacing is less of an issue, but I wouldn't say it looks too cramped, it's probably just a case of what you are used to. I think the benefit of having a consistent guide for others to follow outweighs that preference, for example we use the same spacing in all other OOUI components:

Thu, Jan 16, 1:32 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Design, MinervaNeue

Wed, Jan 15

Esanders closed T222243: PageUp and PageDown act as Home and End in Visual editing as Resolved.

The FF issue was fixed in version 72. No one has reproduced this is Chrome so I'm closing. Feel free to re-open if that is incorrect.

Wed, Jan 15, 8:27 PM · User-Ryasmeen, VisualEditor
Esanders closed T231988: Page up/down in Firefox causes the page to scroll to start/end of document as Resolved.
Wed, Jan 15, 8:27 PM · User-Ryasmeen, Upstream, Browser-Support-Firefox, VisualEditor
Esanders added a comment to T231988: Page up/down in Firefox causes the page to scroll to start/end of document.

Yep, announced in https://bugzilla.mozilla.org/show_bug.cgi?id=1577058#c22

Wed, Jan 15, 8:22 PM · User-Ryasmeen, Upstream, Browser-Support-Firefox, VisualEditor
Esanders added a comment to T151308: Make VisualEditor compatible with "extends" parameter.

Following on from our discussion earlier, it should be possible to warn users editing sub-references, or disable them from being editing. Parsoid will pass through the "extends" attribute in the data-mw already, so in the VE model for the referenceNode, we can look at model.attrs.extends.

Wed, Jan 15, 8:14 PM · Parsoid, Book-Referencing, German-Community-Wishlist, VisualEditor, TCB-Team, Cite
Esanders removed a project from T236548: "visualeditor" Cloud VPS project jessie deprecation: VisualEditor.

Removing VE team tag. Feel free to close out @bd808

Wed, Jan 15, 6:08 PM · Cloud-VPS (Debian Jessie Deprecation)
Esanders added a comment to T242477: [Regression] The alignment icons are missing inside Media Settings dialog when opening the dialog first time in a login session .

Couldn't reproduce (iOS 13.1.3). Definitely a browser glitch, because there's not sensible reason why those icons wouldn't render.

Wed, Jan 15, 4:38 PM · VisualEditor (Current work)
Esanders added a comment to T242362: [Regression] None of the options under any drop down are visible on mobile VE .

Couldn't reproduce on iOS 13.1.3:

Wed, Jan 15, 4:34 PM · VisualEditor (Current work)
Esanders moved T241393: Abandon changes dialog appears unexpectedly from Ready for Development to Code review on the VisualEditor (Current work) board.
Wed, Jan 15, 4:24 PM · Verified, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders added a comment to T241393: Abandon changes dialog appears unexpectedly .

Note - this bug only occurs when there is an error redrawing the page after save, which shouldn't happen, but I've added a fix that does the widget teardown sooner so even if the redraw fails, you won't see the abandon dialog.

Wed, Jan 15, 4:24 PM · Verified, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders claimed T241393: Abandon changes dialog appears unexpectedly .
Wed, Jan 15, 4:22 PM · Verified, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders added a comment to T241393: Abandon changes dialog appears unexpectedly .

This appears to be a side-effect of T241391. After saving a comment and redrawing the page, the last thing we do is remove the system abandon changes dialog, so if there are any bugs before than, that code won't run and the beforeunload handler will still be bound.

Wed, Jan 15, 4:19 PM · Verified, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders reassigned T242184: Create a change tag for edits made using DiscussionTools from ppelberg to DLynch.
Wed, Jan 15, 4:09 PM · Editing Design, VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders moved T240639: Highlighting of the replies is incorrect on Beta cluster from In progress to Code review on the VisualEditor (Current work) board.
Wed, Jan 15, 4:08 PM · Patch-For-Review, VisualEditor (Current work), DiscussionTools, OWC2020
Esanders moved T240639: Highlighting of the replies is incorrect on Beta cluster from Incoming to In progress on the VisualEditor (Current work) board.
Wed, Jan 15, 4:08 PM · Patch-For-Review, VisualEditor (Current work), DiscussionTools, OWC2020
Esanders claimed T240639: Highlighting of the replies is incorrect on Beta cluster .
Wed, Jan 15, 4:07 PM · Patch-For-Review, VisualEditor (Current work), DiscussionTools, OWC2020
Esanders added a comment to T240639: Highlighting of the replies is incorrect on Beta cluster .

The issue here is that the highlight is positioned relative to .mw-parser-output, but that is not position:relative.

Wed, Jan 15, 3:59 PM · Patch-For-Review, VisualEditor (Current work), DiscussionTools, OWC2020
Esanders added a comment to T240639: Highlighting of the replies is incorrect on Beta cluster .

For me, it doesn’t highlight at all (FF 68.3 ESR on Debian). I see

TypeError: range.cloneRange is not a function

Wed, Jan 15, 3:56 PM · Patch-For-Review, VisualEditor (Current work), DiscussionTools, OWC2020
Esanders added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

All the Debian-8 instances have been deleted. We now have 3 instances left, all running Buster (visualeditor-test3, visualeditor-prototype3, patchdemo).

Wed, Jan 15, 12:44 PM · Cloud-VPS (Debian Jessie Deprecation)

Wed, Jan 8

Esanders moved T241880: References are not visually highlighted when they are a part of a larger text selection from Code review to QA on the VisualEditor (Current work) board.
Wed, Jan 8, 9:58 PM · Verified, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), VisualEditor (Current work), Cite, VisualEditor-MediaWiki-References
Esanders moved T241193: Replies with <gallery>...</gallery> tags do not render in preview properly from Code review to Engineering QA on the VisualEditor (Current work) board.
Wed, Jan 8, 9:56 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders moved T209493: VE is transforming citation templates into formatted text with "cite class" tags (when copying a reference defined within template-generated reflist) from Code review to QA on the VisualEditor (Current work) board.
Wed, Jan 8, 9:54 PM · Verified, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), VisualEditor (Current work), Cite, Parsoid
Esanders moved T241906: Press backspace to remove a space before a colon make any chars typed then not considered while publishing from Code review to QA on the VisualEditor (Current work) board.
Wed, Jan 8, 9:52 PM · Verified, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), VisualEditor-DataModel, VisualEditor (Current work)
Esanders removed a project from T241708: Arrows in "Move before" and "Move after" icons in tables must be swapped in RTL: VisualEditor (Current work).
Wed, Jan 8, 9:30 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, OOUI, RTL, I18n
Esanders moved T241708: Arrows in "Move before" and "Move after" icons in tables must be swapped in RTL from In progress to Code review on the VisualEditor (Current work) board.
Wed, Jan 8, 9:29 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, OOUI, RTL, I18n

Mon, Jan 6

Esanders renamed T241388: When inserting {{welcome}} reply preview is different to saved content from Reply preview is different from how it is saved to talk page to When inserting {{welcome}} reply preview is different to saved content.
Mon, Jan 6, 5:22 PM · VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders added a project to T241708: Arrows in "Move before" and "Move after" icons in tables must be swapped in RTL: Regression.
Mon, Jan 6, 4:17 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Regression, OOUI, RTL, I18n

Dec 20 2019

Esanders added a comment to T239861: Bug: Not able to post comment on beta.

It definitely should be (and was until recently). Not sure who is responsible for keeping those services up...

Dec 20 2019, 6:03 PM · User-Ryasmeen, Core Platform Team, VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020

Dec 19 2019

Esanders triaged T240955: Firefox CI tests keep failing in VE as High priority.

This is failing quite regularly now.

Dec 19 2019, 4:19 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config, VisualEditor

Dec 18 2019

Esanders added a comment to T237019: Spacing between icons and labels is too large in tablet mode.

Hamburger menu with 7px spacing:

Dec 18 2019, 10:29 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Design, MinervaNeue
1997kB awarded T203151: Consider adding a button to let users edit the whole page in MobileFrontend a Manufacturing Defect? token.
Dec 18 2019, 5:00 PM · Design, MobileFrontend, VisualEditor

Dec 17 2019

Esanders created T240955: Firefox CI tests keep failing in VE.
Dec 17 2019, 3:01 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config, VisualEditor
Esanders added a comment to T214880: [Bug] On Firefox mobile editor textarea should auto-expand.

VE had a similar issue with ContentEditable: T196839

Dec 17 2019, 2:30 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
Esanders moved T214880: [Bug] On Firefox mobile editor textarea should auto-expand from Incoming to Code review on the VisualEditor (Current work) board.
Dec 17 2019, 2:29 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
Esanders edited projects for T214880: [Bug] On Firefox mobile editor textarea should auto-expand, added: VisualEditor (Current work); removed VisualEditor.
Dec 17 2019, 2:21 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
Esanders merged T240883: Wasted editing space in mobile source editing on Firefox into T214880: [Bug] On Firefox mobile editor textarea should auto-expand.
Dec 17 2019, 12:52 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
Esanders merged task T240883: Wasted editing space in mobile source editing on Firefox into T214880: [Bug] On Firefox mobile editor textarea should auto-expand.
Dec 17 2019, 12:52 PM · Browser-Support-Firefox, Readers-Web-Backlog, MobileFrontend, Mobile
Esanders added a project to T240883: Wasted editing space in mobile source editing on Firefox: Browser-Support-Firefox.
Dec 17 2019, 12:41 PM · Browser-Support-Firefox, Readers-Web-Backlog, MobileFrontend, Mobile

Dec 16 2019

Esanders added a comment to T158617: npm install fails for changeprop service in MW-Vagrant (cp rdkafka: permission denied).

The suggested quick fix here is to run vagrant settings nfs_shares off to disable NFS shares and reload your VM...

Dec 16 2019, 8:20 PM · Core Platform Team Legacy (Watching / External), Services (watching), MediaWiki-Vagrant
Esanders renamed T240875: Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor from Can't start a vagrant instance on a new buster-10.0 instance to Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor.
Dec 16 2019, 5:11 PM · cloud-services-team (Kanban), MediaWiki-Vagrant, Cloud-VPS
Esanders added a comment to T240875: Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor.

With help from @DLynch we narrowed this down to a missing apparmor:

kemayo@visualeditor-test3:/srv/mediawiki-vagrant$ sudo lxc-start --name mediawiki-vagrant_default_1576514393929_92435 -F
lxc-start: mediawiki-vagrant_default_1576514393929_92435: lsm/apparmor.c: apparmor_prepare: 974 Cannot use generated profile: apparmor_parser not available
        lxc-start: mediawiki-vagrant_default_1576514393929_92435: start.c: lxc_init: 899 Failed to initialize LSM
Dec 16 2019, 5:10 PM · cloud-services-team (Kanban), MediaWiki-Vagrant, Cloud-VPS
Esanders created T240875: Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor.
Dec 16 2019, 5:05 PM · cloud-services-team (Kanban), MediaWiki-Vagrant, Cloud-VPS
Esanders created P9882 vagrant up failure.
Dec 16 2019, 5:04 PM

Dec 15 2019

Esanders added a comment to T240643: One of the replies gets lost during a race condition .

I think it is also not possible to edit conflict with yourself, you have to test with two accounts (or one logged out).

Dec 15 2019, 6:48 PM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), DiscussionTools, OWC2020

Dec 13 2019

Esanders renamed T240696: Make linebreak behaviour consistent regardless of indentation level from Make linebreak consistent regardless of indentation level to Make linebreak behaviour consistent regardless of indentation level.
Dec 13 2019, 6:07 PM · DiscussionTools, OWC2020
Esanders created T240696: Make linebreak behaviour consistent regardless of indentation level.
Dec 13 2019, 6:04 PM · DiscussionTools, OWC2020

Dec 12 2019

Esanders added a comment to T240608: Standardise a control for switching diff types from side by side to inline/visual.

NB we also use this control in the save dialog

Dec 12 2019, 8:23 PM · Patch-For-Review, VisualEditor, Readers-Web-Backlog (Design), User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
Esanders added a comment to T240608: Standardise a control for switching diff types from side by side to inline/visual.

Designers: Is the ButtonWidget appropriate here

Dec 12 2019, 8:21 PM · Patch-For-Review, VisualEditor, Readers-Web-Backlog (Design), User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
Esanders reopened T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|` as "Open".

(re-opening as the discussion is active)

Dec 12 2019, 7:58 PM · OWC2020, VisualEditor, Parsoid
Esanders added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

In this example a lot of the page is corrupted because the previous edit added an unclosed table.

Dec 12 2019, 7:57 PM · OWC2020, VisualEditor, Parsoid
Esanders added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

I think what makes this case unique is that the failure is so catastrophic. The entirety of the page (or just after the table?) gets corrupted during the edit.

Dec 12 2019, 6:43 PM · OWC2020, VisualEditor, Parsoid
Esanders renamed T240582: Check user has right to edit the page before showing 'Reply' buttons from Check has user and edit rights before showing 'Reply' buttons to Check user has right to edit the page before showing 'Reply' buttons.
Dec 12 2019, 4:01 PM · DiscussionTools, OWC2020
Esanders created T240582: Check user has right to edit the page before showing 'Reply' buttons.
Dec 12 2019, 3:55 PM · DiscussionTools, OWC2020

Dec 11 2019

Esanders created T240468: Deploy DiscussionTools to beta cluster.
Dec 11 2019, 3:47 PM · VisualEditor (Current work), Editing-team, OWC2020

Dec 10 2019

Esanders added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

@bd808 We're in the middle of migrating visualeditor-prototype2 and visualeditor-test2, but would like an extension as we have a lot of important work going on this month that needs to take priority. We should be able to get around to finish the migration next quarter. Thanks,

Dec 10 2019, 5:40 PM · Cloud-VPS (Debian Jessie Deprecation)
Esanders added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

Being able to corrupt the entire document just because of some unbalanced wikitext elsewhere on the page seems less than ideal...

Dec 10 2019, 5:19 PM · OWC2020, VisualEditor, Parsoid
Esanders moved T240259: Implement `unload handlers` for compose from Incoming to Code review on the VisualEditor (Current work) board.
Dec 10 2019, 3:45 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), Editing-team, OWC2020
Esanders moved T240271: Warn contributors before they discard a draft from Incoming to Code review on the VisualEditor (Current work) board.
Dec 10 2019, 3:44 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), Editing-team, OWC2020
Esanders added a comment to T240271: Warn contributors before they discard a draft.

These are the default messages for AbandonEdit, which we can override:

Dec 10 2019, 3:44 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), Editing-team, OWC2020
Esanders renamed T240257: Add auto-save to the reply widget from Build auto-save to Add auto-save to the reply widget.
Dec 10 2019, 2:53 PM · DiscussionTools, Editing-team, OWC2020
Esanders added a comment to T240327: Browser spellchecking broken in VE for words with special characters.

VE seems to insert some invisible word breaks before the umlauts

Dec 10 2019, 2:52 PM · VisualEditor

Dec 9 2019

Esanders created T240268: Inspector vertical alignment regressions in Apex/Monobook.
Dec 9 2019, 9:15 PM · Regression, VisualEditor
Esanders updated the task description for T240259: Implement `unload handlers` for compose.
Dec 9 2019, 9:04 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), Editing-team, OWC2020
Esanders added a comment to T239966: [Pre-deployment testing] Retaining draft comments/replies.

Given the page can be reloaded we would need to implement LocalStorage/SessionStorage based auto-save to support that.

Dec 9 2019, 5:21 PM · DiscussionTools, OWC2020, VisualEditor
Esanders moved T239873: [Pre-deployment testing] Clicking on edit on "Talk:Reply test" page, gives error "Uncaught TypeError: Cannot read property 'range' of undefined" from Incoming to Code review on the VisualEditor (Current work) board.
Dec 9 2019, 2:44 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, OWC2020
Esanders edited projects for T239873: [Pre-deployment testing] Clicking on edit on "Talk:Reply test" page, gives error "Uncaught TypeError: Cannot read property 'range' of undefined", added: VisualEditor (Current work); removed VisualEditor.
Dec 9 2019, 2:44 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, OWC2020
Esanders added a comment to T239873: [Pre-deployment testing] Clicking on edit on "Talk:Reply test" page, gives error "Uncaught TypeError: Cannot read property 'range' of undefined".

We need to avoid running the code on edit pages.

Dec 9 2019, 2:24 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, OWC2020
Esanders moved T239865: [Pre-deployment testing] Same reply can get posted multiple times if you click on "Reply" button multiple times from Incoming to Code review on the VisualEditor (Current work) board.
Dec 9 2019, 1:43 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, OWC2020
Esanders edited projects for T239865: [Pre-deployment testing] Same reply can get posted multiple times if you click on "Reply" button multiple times, added: VisualEditor (Current work); removed VisualEditor.
Dec 9 2019, 1:42 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, OWC2020

Dec 6 2019

Esanders moved T239859: ADD: ability to post comment using keyboard shortcut from Incoming to Code review on the VisualEditor (Current work) board.
Dec 6 2019, 6:29 PM · Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders edited projects for T239859: ADD: ability to post comment using keyboard shortcut, added: VisualEditor (Current work); removed VisualEditor.
Dec 6 2019, 6:28 PM · Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020

Dec 5 2019

Esanders added a comment to T239859: ADD: ability to post comment using keyboard shortcut.

In Flow this is bound to CTRL+Enter

Dec 5 2019, 4:58 PM · Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020
Esanders added a comment to T239861: Bug: Not able to post comment on beta.

I seem to be able to post multiple replies. Is there are specific thread where this happens? Are you logged in? Can you reproduce with the developer console open and see if there are any errors or warnings in the console?

Dec 5 2019, 3:58 PM · User-Ryasmeen, Core Platform Team, VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020

Dec 4 2019

Esanders added a comment to T235592: Replies v1.0: Create mockups.

In the anon warning we say "your IP address (12.34.56.78)" however we currently don't have access to the IP address in the client. We could make this available, but I don't know if this was done deliberately?

Dec 4 2019, 2:14 PM · Editing Design, Editing-team, OWC2020

Dec 3 2019

Esanders updated subscribers of T239676: Mobile VE: Fall back to wikitext editor if the loading takes too long.
Dec 3 2019, 6:14 PM · Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Dec 2 2019

Esanders updated the task description for T131632: Eliminate activation-blocking API request from VisualEditor startup.
Dec 2 2019, 6:01 PM · Performance-Team (Radar), Technical-Debt, VisualEditor-MediaWiki, VisualEditor-Performance, VisualEditor
Esanders added a comment to T131632: Eliminate activation-blocking API request from VisualEditor startup.

Started on this in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/472514/ which separates out the metadata processing so that in theory we could show the editor once just the RESTBase data had loaded. The main issue is that if the metadata request fails, or there is a revision id mismatch, we need to close/reload the editor.

Dec 2 2019, 6:00 PM · Performance-Team (Radar), Technical-Debt, VisualEditor-MediaWiki, VisualEditor-Performance, VisualEditor
Esanders added a comment to T239520: Mobile section editing sometimes scrolls to the wrong place.

It doesn't affect all pages, e.g. https://en.m.wikipedia.org/wiki/The_Irishman_(2019_film) works fine.

Dec 2 2019, 9:51 AM · Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Nov 30 2019

Esanders created T239520: Mobile section editing sometimes scrolls to the wrong place.
Nov 30 2019, 7:39 PM · Verified, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Nov 26 2019

Esanders updated subscribers of T239209: XSS in Visual Editor via Copy&Paste (CVE-2019-19708).
Nov 26 2019, 6:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security

Nov 20 2019

Esanders added a comment to T225600: VE still explicitely blacklists Opera < 12.

I don't think we should be serving JS to environments we explicitly don't trust to work correctly.

Nov 20 2019, 9:53 PM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki

Nov 19 2019

Esanders committed rECIT2a222b61d091: Remove deprecated TargetWidget APIs (authored by Esanders).
Remove deprecated TargetWidget APIs
Nov 19 2019, 8:22 AM

Nov 15 2019

Esanders committed rECEX3c42ad9b7c31: build: Update linters (authored by Esanders).
build: Update linters
Nov 15 2019, 5:22 PM
Esanders committed rECIT26c78a2b900d: build: Update linters (authored by Esanders).
build: Update linters
Nov 15 2019, 5:03 PM

Nov 14 2019

Esanders closed T167019: Issues with 2017 editor and Grammarly as Resolved.

Grammarly should be disabled on VE surfaces (at least wikitext mode)

Nov 14 2019, 5:04 PM · User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders closed T191566: Using Undo after inserting formatted element resets cursor as Resolved.

Assume this was fixed in the last two years. Please reopen if you can reproduce.

Nov 14 2019, 4:49 PM · User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T180511: Percent-encoding stops link from working.

The link [[Stadskanaal#/maplink/1]] does take me to the correct page. Can you still reproduce this @Whatamidoing-WMF ?

Nov 14 2019, 4:44 PM · MediaWiki-General, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders closed T222249: 2017WTE loses focus after making a link as Resolved.

Please re-open if you can reproduce.

Nov 14 2019, 4:38 PM · VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Esanders closed T158170: Pasting formatted code at the end of a paragraph breaks cursor positioning as Resolved.

We removed a bunch of annotation rendering code from NWE. If you can still reproduce this please re-open.

Nov 14 2019, 4:35 PM · User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders updated subscribers of T238332: Retried-load results in document showing twice.

I've seen bug reports in the past where VE was loaded along side other content, such as the classic WikiEditor, and I imagine this is the cause. Do you remember these @Whatamidoing-WMF ?

Nov 14 2019, 3:57 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression
Esanders added a comment to T157113: VE plugins from user scripts not always loaded.

I'm not sure it would be a good idea to run plugins that are loaded after target init. Plugins is designed to run before target init, and some plugins may depend on this behaviour. It sounds like the issue is user scripts loading too late, but that would be an issue with MW core?

Nov 14 2019, 3:56 PM · VisualEditor, VisualEditor-Initialisation
Esanders moved T238332: Retried-load results in document showing twice from Incoming to Code review on the VisualEditor (Current work) board.
Nov 14 2019, 3:24 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression
Esanders edited projects for T238332: Retried-load results in document showing twice, added: VisualEditor (Current work); removed VisualEditor.
Nov 14 2019, 3:24 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression
Esanders closed T184786: Pages protected against creation show a wrong message about loading the editor as Resolved.

The editor now loads correctly, with the appropriate edit warnings.

Nov 14 2019, 3:20 PM · User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, VisualEditor-Initialisation
Esanders updated subscribers of T225600: VE still explicitely blacklists Opera < 12.

JS appears to still be running in Opera 12, and even 11, so either our matrix is wrong or the feature check is wrong. CC @Krinkle

Nov 14 2019, 3:18 PM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki
Esanders updated the task description for T238332: Retried-load results in document showing twice.
Nov 14 2019, 3:08 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression
Esanders added a comment to T238332: Retried-load results in document showing twice.

Looks like the ve-active class isn't added to the body. This is the one that hides the read article.

Nov 14 2019, 2:56 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression
Esanders created T238332: Retried-load results in document showing twice.
Nov 14 2019, 2:55 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), VisualEditor (Current work), Regression