Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (256 w, 15 h)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders added a comment to T133900: Clicking the black frame should close Multimediaviewer.

It would not occur to me to click on the black area to close the lightbox. If anything, in a full-screen slideshow mode, I would expect click on the image to advance through the gallery, although in MW I appreciate this takes you to the full size image.

Mon, Sep 23, 7:08 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Readers-Web-Backlog (Design), Wikimedia-Hackathon-2019, Multimedia, Design, good first bug, MediaViewer
Esanders added a project to T231895: Media viewer on 3D files closes when releasing drag: 3D.
Mon, Sep 23, 6:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 3D, Regression, MediaViewer
Esanders merged T233651: MediaViewer closes as soon as you interact with a 3D object into T231895: Media viewer on 3D files closes when releasing drag.
Mon, Sep 23, 6:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 3D, Regression, MediaViewer
Esanders merged task T233651: MediaViewer closes as soon as you interact with a 3D object into T231895: Media viewer on 3D files closes when releasing drag.
Mon, Sep 23, 6:50 PM · MediaViewer, 3D
Esanders created T233651: MediaViewer closes as soon as you interact with a 3D object.
Mon, Sep 23, 6:44 PM · MediaViewer, 3D
Mvolz awarded T211243: Add a useful call-to-action in the context for citation needed templates a Like token.
Mon, Sep 23, 1:37 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

There are 63 redirects to {{Citation needed}} on en.wiki, but just listing the first 4 most common will get us over 99% coverage:

Mon, Sep 23, 12:10 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Sat, Sep 21

Esanders committed rECIT659d46180667: Citation needed template handling (authored by Esanders).
Citation needed template handling
Sat, Sep 21, 7:27 PM

Fri, Sep 20

Esanders added a project to T233401: MMV fails under race condition if slideshow present on page and RL debug set to true: MediaWiki-Gallery.
Fri, Sep 20, 12:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MediaWiki-Gallery, MediaViewer
Esanders created T233401: MMV fails under race condition if slideshow present on page and RL debug set to true.
Fri, Sep 20, 12:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MediaWiki-Gallery, MediaViewer

Wed, Sep 18

Esanders added a comment to T204937: CX2: Don't add block templates to the translation if equivalent template is missing.

So what you approach is trying to do is take an infobox, e.g. <table typeof="transclusion">...</table> and parse this as a paragraph-like node. However on the first parse you want to ignore the contents of the <table> so you disallowed the paragraph from containing any child nodes. The problem with this approach is it doesn't work for subsequent parses, i.e. when the document is written to/read from the database. You now have <p typeof="unadapted-transclusion"> which will use the same toDomElements/toDataElements paths, and so try to throw away the contents.

Wed, Sep 18, 4:18 PM · VisualEditor, Language-Team (Language-2019-July-September), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, ContentTranslation
Esanders added a comment to T233171: [ICONS] editor-loading header.

There is a gap at the bottom of the header (maybe related to T215426?)

Wed, Sep 18, 1:36 PM · VisualEditor, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Esanders added a comment to T233171: [ICONS] editor-loading header.

The word loading is not centered in the header

Wed, Sep 18, 1:34 PM · VisualEditor, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Trizek-WMF awarded T211243: Add a useful call-to-action in the context for citation needed templates a Love token.
Wed, Sep 18, 8:03 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Tue, Sep 17

Esanders committed rECEXac54ad7948aa: build: Update linters (authored by Esanders).
build: Update linters
Tue, Sep 17, 2:47 PM
Esanders added a comment to T208758: Extend Popups-Extension to render popups for annotated <math>.

Filed as T233099

Tue, Sep 17, 11:38 AM · Readers-Web-Backlog (Needs Product Owner Decisions), Patch-For-Review, Page-Previews
Esanders created T233099: Page previews should be externally extendable.
Tue, Sep 17, 11:37 AM · Readers-Web-Backlog (Needs Product Owner Decisions), Page-Previews
Esanders updated the task description for T211243: Add a useful call-to-action in the context for citation needed templates.
Tue, Sep 17, 11:25 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
Esanders changed the status of T226168: Chemistry beaker icon should have open top from Declined to Resolved.
Tue, Sep 17, 11:22 AM · Design, OOUI

Mon, Sep 16

Esanders added a comment to T230033: [ICONS] Increase touch targets from 40x40 to 44x44.

After the latest icon fixes, most of these are now 40x40, which is just slightly below the recommended size. Was this a deliberate choice?

Mon, Sep 16, 3:45 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Accessibility, Advanced Mobile Contributions
Esanders added a comment to T232528: Pasting multiple list items in VisualEditor in Firefox results in incorrect display and saving .

Indeed in this situation an exception is thrown on copy

TypeError: startNode is null ve.dm.Document.js:535:14
    shallowCloneFromRange http://localhost/VisualEditor/lib/ve/src/dm/ve.dm.Document.js:535
    shallowCloneFromSelection http://localhost/VisualEditor/lib/ve/src/dm/ve.dm.Document.js:446
    onCopy http://localhost/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js:1929
Mon, Sep 16, 1:57 PM · VisualEditor-ContentEditable, VisualEditor-CopyPaste, VisualEditor
Esanders added a project to T232528: Pasting multiple list items in VisualEditor in Firefox results in incorrect display and saving : VisualEditor-ContentEditable.

This happens when the selection starts in the slug above the list. Such a selection can't be created in Chrome, but in FF you can create it by selecting backwards and ending your selection above the list. The selection then starts at offset 0.

Mon, Sep 16, 12:26 PM · VisualEditor-ContentEditable, VisualEditor-CopyPaste, VisualEditor
Esanders added a comment to T232530: Potential API Errors Associated with VE on Meta-Wiki.

Can you still reproduce this error? It could have been a transient server issue.

Mon, Sep 16, 12:18 PM · VisualEditor
Esanders removed a project from T232668: VisualEditor cURL Error: 7, Debian 9.11: VisualEditor.
Mon, Sep 16, 12:17 PM · Parsoid
Esanders moved T232944: ve.ui.MWWikitextStringTransferHandler uses bare content from Incoming to In progress on the VisualEditor (Current work) board.
Mon, Sep 16, 12:15 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), User-Ryasmeen, VisualEditor-DataModel
Esanders moved T232942: TreeModifier#applyTreeOperation doesn't delete text nodes emptied by moveText operations from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Sep 16, 12:15 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), VisualEditor-DataModel
Esanders edited projects for T232942: TreeModifier#applyTreeOperation doesn't delete text nodes emptied by moveText operations, added: VisualEditor (Current work); removed VisualEditor.
Mon, Sep 16, 12:15 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), VisualEditor-DataModel
Esanders edited projects for T232944: ve.ui.MWWikitextStringTransferHandler uses bare content, added: VisualEditor (Current work); removed VisualEditor.
Mon, Sep 16, 12:14 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), User-Ryasmeen, VisualEditor-DataModel

Sun, Sep 15

Esanders added a project to T230653: Use a parser function to encapsulate signatures: OWC2020.
Sun, Sep 15, 3:01 PM · OWC2020, MediaWiki-Parser
Esanders updated subscribers of T230653: Use a parser function to encapsulate signatures.
Sun, Sep 15, 3:01 PM · OWC2020, MediaWiki-Parser
Esanders added a project to T230654: Parser support for talk pages: OWC2020.
Sun, Sep 15, 2:56 PM · OWC2020, Parsoid, MediaWiki-Parser

Sat, Sep 14

Esanders added a comment to T232601: Provide a mechanism for in-surface autocomplete.

Thanks, that's very cool. I made a fork with some improvements: https://en.wikipedia.org/w/index.php?title=User:ESanders_(WMF)/veSuggestions.js&action=history (feel free to merge them across)

Sat, Sep 14, 4:38 PM · OWC2020, VisualEditor (Current work)

Fri, Sep 13

Esanders added a comment to T232754: Mangling of non existing media links by VisualEditor.

Could be a Parsoid issue?

Fri, Sep 13, 5:49 PM · Parsoid, VisualEditor, VisualEditor-MediaWiki-Links
Esanders added a project to T232754: Mangling of non existing media links by VisualEditor: Parsoid.
Fri, Sep 13, 5:48 PM · Parsoid, VisualEditor, VisualEditor-MediaWiki-Links
Esanders moved T230552: Mobile page goes blank or flickers briefly when loading VE from Code review to QA on the VisualEditor (Current work) board.
Fri, Sep 13, 10:01 AM · Verified, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders claimed T227769: Never show the unswitchable welcome dialog.
Fri, Sep 13, 10:00 AM · VisualEditor (Current work), Patch-For-Review
Esanders added a comment to T222217: When creating a "New section", the text for the body is not properly aligned with the rest of the page.

@Whatamidoing-WMF does this sound like the cause (using a non-standard font size)?

Fri, Sep 13, 9:59 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Esanders assigned T222217: When creating a "New section", the text for the body is not properly aligned with the rest of the page to matmarex.
Fri, Sep 13, 9:55 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Esanders moved T232461: Read-mode references pasted into VE via a third-party editor are not stripped from In progress to QA on the VisualEditor (Current work) board.
Fri, Sep 13, 9:53 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor-MediaWiki-References, VisualEditor (Current work), VisualEditor-CopyPaste

Thu, Sep 12

Esanders updated the task description for T232782: Investigate convenient-discussions gadget.
Thu, Sep 12, 8:29 PM · OWC2020, VisualEditor (Current work)
Esanders updated the task description for T232781: Investigate reply-link gadget.
Thu, Sep 12, 8:29 PM · OWC2020, VisualEditor (Current work)
Esanders created T232782: Investigate convenient-discussions gadget.
Thu, Sep 12, 8:29 PM · OWC2020, VisualEditor (Current work)
Esanders created T232781: Investigate reply-link gadget.
Thu, Sep 12, 8:28 PM · OWC2020, VisualEditor (Current work)
Esanders created T232780: Write a client-side parser for signatures (username & timestamp).
Thu, Sep 12, 8:27 PM · OWC2020, VisualEditor (Current work)
Esanders assigned T232601: Provide a mechanism for in-surface autocomplete to DLynch.
Thu, Sep 12, 8:24 PM · OWC2020, VisualEditor (Current work)

Wed, Sep 11

Esanders closed T213330: Warning 'Passing a string ID to infuse is deprecated. Use an HTMLElement or jQuery collection instead.' when running unit tests as Declined.

Just because it's deprecated, doesn't mean we shouldn't test it.

Wed, Sep 11, 4:28 PM · OOUI
Esanders added a comment to T208758: Extend Popups-Extension to render popups for annotated <math>.

It's not good that in order to add popups support for a particular extension (Math in this case) the Popups extension itself needs to be modified, and know about that extension. There should really be a public API for registering extra popups functionality, c.f. https://www.mediawiki.org/wiki/Manual:Extension_registration#Attributes

I agree with you at 100%! However, we need to start from what's available. Currently, our goal is to push as much functionality to the math extension as possible and keep changes to the popup extension minimal.

Wed, Sep 11, 4:25 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Patch-For-Review, Page-Previews
Esanders added a comment to T231815: Consider removing toolbar borders.
  1. I'd agree that the indicators set up a useful expectation of the tool not acting instantly. I think the reduced sized indicators remove a lot of the clutter they were causing
  2. Either way this should be separated into a separate discussion.
  3. I agree with Volker, half borders would be more code to implement, and I don't think would resolve the visual clutter issue for narrow screens.
  4. Also not seeing the difference. Perhaps there's some confusion from my screenshots which were taken on desktop in mobile simulator mode, but the toolbar touches the top, left and right edges of the screen, so the shadow only appears beneath it.
Wed, Sep 11, 4:19 PM · VisualEditor (Current work), Editing Design, Patch-For-Review, Design, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T230659: Automatically-assigned id attributes for list items.

In T230683#5432585 @Anomie proposes using the revision ID of the edit that creates the comment as its persistent identifier.

Wed, Sep 11, 3:40 PM · OWC2020, MediaWiki-Parser
Esanders added a comment to T209266: CX2: Support for references added by name when the details are inside a template.

@Esanders, can you tell us more about how Visual Editor is doing this? In particular:

  • Can VE identify problematic references?
Wed, Sep 11, 3:28 PM · VisualEditor, Language-Team (Language-2019-July-September), ContentTranslation
Esanders added a comment to T232521: Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed.

The patches above have fixed some known uses, but I'm concerned that the ext property should've be deprecated first as we may not have caught every case.

Wed, Sep 11, 3:09 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MediaViewer, Multimedia
Esanders updated the task description for T232601: Provide a mechanism for in-surface autocomplete.
Wed, Sep 11, 12:12 PM · OWC2020, VisualEditor (Current work)
Esanders updated the task description for T232601: Provide a mechanism for in-surface autocomplete.
Wed, Sep 11, 12:09 PM · OWC2020, VisualEditor (Current work)
Esanders updated the task description for T232601: Provide a mechanism for in-surface autocomplete.
Wed, Sep 11, 12:08 PM · OWC2020, VisualEditor (Current work)
Esanders created T232601: Provide a mechanism for in-surface autocomplete.
Wed, Sep 11, 11:53 AM · OWC2020, VisualEditor (Current work)

Tue, Sep 10

Esanders added a comment to T232521: Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed.

Not sure why that is my fault, but it looks like it should be .getExtension() instead of .extension.

Tue, Sep 10, 7:34 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MediaViewer, Multimedia
Esanders added a comment to T232170: [Regression] Disabling the ability to edit the whole article can make it impossible to edit on mobile in a specific scenario.

There are 13,000 uses on en.wiki: https://en.wikipedia.org/w/index.php?sort=relevance&search=insource%3A%2F__NOEDITSECTION__%2F&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current=%7B%7D&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1

Tue, Sep 10, 3:38 PM · VisualEditor
Esanders added a comment to T229079: Instrument each step of mobile VE edit flow.

I assume this should be tracked in non-VE editors as well. In which case "firstTransaction" might be renamed "firstEdit" or "firstChange" as non VE surfaces don't necessarily use transactions. We should also write patches for those editors.

Tue, Sep 10, 1:40 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T232461: Read-mode references pasted into VE via a third-party editor are not stripped from Incoming to In progress on the VisualEditor (Current work) board.
Tue, Sep 10, 11:27 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor-MediaWiki-References, VisualEditor (Current work), VisualEditor-CopyPaste
Esanders claimed T232461: Read-mode references pasted into VE via a third-party editor are not stripped.
Tue, Sep 10, 11:27 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor-MediaWiki-References, VisualEditor (Current work), VisualEditor-CopyPaste
Esanders created T232461: Read-mode references pasted into VE via a third-party editor are not stripped.
Tue, Sep 10, 11:26 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor-MediaWiki-References, VisualEditor (Current work), VisualEditor-CopyPaste

Mon, Sep 9

Esanders added a comment to T232170: [Regression] Disabling the ability to edit the whole article can make it impossible to edit on mobile in a specific scenario.
  • This is technically a regression in VE, but this has always been the functionality in the mobile wikitext editor
  • The __NOEDITSECTION__ marker which triggers this use very rarely, and usually when the section itself contains just a transclusion of another page, e.g.
== Section 1 ==
{{Included section}}
== Section 2 ==
{{Next included section}}

In these cases there aren't really meaningful section edits to be made, especially on mobile

Mon, Sep 9, 3:50 PM · VisualEditor
GoogleLegacy awarded T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle a Barnstar token.
Mon, Sep 9, 1:51 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog, MW-1.35-release, Growth-Team, Metrolook, Vector, WikiEditor, Wikidata, MediaWiki-extensions-Translate, RelatedArticles, MobileFrontend, MediaViewer, MassMessage, Maps (Kartographer), MediaWiki-extensions-InputBox, Graphs, StructuredDiscussions, MediaWiki-extensions-CentralNotice, Patch-For-Review, Technical-Debt (Deprecation), JavaScript, MediaWiki-General
Esanders added a comment to T232172: [Regression] Single tapping on a link is enabling the label editing mode.

Double tapping to enable the label editing makes sense but not single tapping.

Mon, Sep 9, 1:30 PM · VisualEditor

Sat, Sep 7

Esanders added a comment to T232175: Investigate VE as default A/B test findings.

How do the results vary by platform (iOS vs Android)? If they differ a lot we could investigate further.

Sat, Sep 7, 5:04 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Fri, Sep 6

Esanders added a comment to T231815: Consider removing toolbar borders.

Updated the prototype with more compact dropdown indicators (75%):
320px:


360px:

Fri, Sep 6, 12:23 PM · VisualEditor (Current work), Editing Design, Patch-For-Review, Design, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

I don't think the action toolbar tools (on the right) need borders, see other page-level toolbars (top rows):

Fri, Sep 6, 12:19 PM · VisualEditor (Current work), Editing Design, Design, OOUI
Esanders added a project to T232136: Scroll-past-infobox code not working anymore: Editing QA.
Fri, Sep 6, 12:15 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Thu, Sep 5

Esanders updated the task description for T232136: Scroll-past-infobox code not working anymore.
Thu, Sep 5, 6:58 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T232136: Scroll-past-infobox code not working anymore from Incoming to Code review on the VisualEditor (Current work) board.
Thu, Sep 5, 6:30 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T232136: Scroll-past-infobox code not working anymore.
Thu, Sep 5, 6:18 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T232134: Flickering when opening mobile VE.
Thu, Sep 5, 6:03 PM · VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

One option would be keeping the borders on MenuToolGroups:

Thu, Sep 5, 1:23 PM · VisualEditor (Current work), Editing Design, Design, OOUI
Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

This is what I meant by

Thu, Sep 5, 1:13 PM · VisualEditor (Current work), Editing Design, Design, OOUI

Wed, Sep 4

Esanders moved T150418: References pasted from read mode should be dropped until we can support them properly from Incoming to QA on the VisualEditor (Current work) board.
Wed, Sep 4, 5:31 PM · Verified, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), VisualEditor-MediaWiki-References, Cite, VisualEditor-CopyPaste
Esanders edited projects for T150418: References pasted from read mode should be dropped until we can support them properly, added: VisualEditor (Current work); removed VisualEditor.
Wed, Sep 4, 5:31 PM · Verified, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), VisualEditor-MediaWiki-References, Cite, VisualEditor-CopyPaste
Esanders reopened T150418: References pasted from read mode should be dropped until we can support them properly as "Open".

Looks like this fix regressed during a recent refactor on target inheritance. The above patch should fix it again.

Wed, Sep 4, 4:16 PM · Verified, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), VisualEditor-MediaWiki-References, Cite, VisualEditor-CopyPaste
Jdforrester-WMF awarded T232003: Remove borders from toolbars in WMUI a Like token.
Wed, Sep 4, 3:39 PM · VisualEditor (Current work), Editing Design, Design, OOUI
Esanders created T232003: Remove borders from toolbars in WMUI.
Wed, Sep 4, 3:34 PM · VisualEditor (Current work), Editing Design, Design, OOUI
Esanders updated the task description for T231815: Consider removing toolbar borders.
Wed, Sep 4, 2:21 PM · VisualEditor (Current work), Editing Design, Patch-For-Review, Design, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T231988: Page up/down in Firefox causes the page to scroll to start/end of document.

If we don't want to wait for Mozilla to fix this we could completely take over page up/down behaviour, but that would be annoying to have to re-implement something the browser should be doing.

Wed, Sep 4, 2:12 PM · Browser-Support-Firefox, VisualEditor
Esanders added a comment to T231988: Page up/down in Firefox causes the page to scroll to start/end of document.

This appears to be a regression in FF introduced in version 65, I've on the upstream task: https://bugzilla.mozilla.org/show_bug.cgi?id=1577058

Wed, Sep 4, 12:43 PM · Browser-Support-Firefox, VisualEditor
Esanders created T231988: Page up/down in Firefox causes the page to scroll to start/end of document.
Wed, Sep 4, 12:17 PM · Browser-Support-Firefox, VisualEditor

Mon, Sep 2

Esanders updated subscribers of T231815: Consider removing toolbar borders.

Comparative analysis:

Mon, Sep 2, 4:42 PM · VisualEditor (Current work), Editing Design, Patch-For-Review, Design, VisualEditor-MediaWiki-Mobile
ppelberg awarded T231825: Auto-save not working when editing lede section on mobile a 100 token.
Mon, Sep 2, 3:36 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T231825: Auto-save not working when editing lede section on mobile from In progress to Code review on the VisualEditor (Current work) board.
Mon, Sep 2, 3:32 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T231825: Auto-save not working when editing lede section on mobile from Incoming to In progress on the VisualEditor (Current work) board.
Mon, Sep 2, 3:32 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders claimed T231825: Auto-save not working when editing lede section on mobile.
Mon, Sep 2, 3:30 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T231825: Auto-save not working when editing lede section on mobile.
Mon, Sep 2, 3:25 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T231815: Consider removing toolbar borders.
Mon, Sep 2, 1:16 PM · VisualEditor (Current work), Editing Design, Patch-For-Review, Design, VisualEditor-MediaWiki-Mobile

Sat, Aug 31

Esanders reopened T215426: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) as "Open".

That's fine for the grey site-header, but there are a few overlays still to fix:

Sat, Aug 31, 9:18 PM · VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-Ryasmeen, Readers-Web-Backlog (Needs Product Owner Decisions), Patch-For-Review, MobileFrontend, MinervaNeue
Esanders reopened T215426: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px), a subtask of T210630: [Engineering EPIC]: Loading screen improvements, as Open.
Sat, Aug 31, 9:18 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work)
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

(The above patch is just the infrastructure needed for this in VE, not the citation-needed feature itself)

Sat, Aug 31, 8:27 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Fri, Aug 30

Esanders added a comment to T166936: In MW 1.29, Visual editor displays chemical equations incorrectly (plus sign on same level as index number).

This is partially fixed now T140217 is resolved:

Fri, Aug 30, 6:29 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Mathoid, Math, Chemical-Markup
Esanders added a comment to T140217: Adjust texvcjs to prevent whitespace modifications in ce-tags.

@Physikerwelt The documentation at https://en.wikipedia.org/wiki/Help:Displaying_a_formula#Chemistry states "Please note that there are still major issues with mhchem support in MediaWiki." and links to this task. Should that be updated now this task is resolved?

Fri, Aug 30, 6:26 PM · Patch-For-Review, Texvcjs
Esanders added a comment to T226168: Chemistry beaker icon should have open top.

Even if there are no experimental features active right now, we need to decide whether the beaker icon should cover also this meaning or it should be restricted only to represent "chemical formulas".

Fri, Aug 30, 6:19 PM · Design, OOUI
Esanders added a comment to T231622: Deploy toolbar v1 to all wikis.

Patch is merged, see T211789

Fri, Aug 30, 5:44 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Esanders added a comment to T228230: Add "✔️" into link modal.

In technical terms this would be anything that uses ve.ui.FragmentWindow

Fri, Aug 30, 5:08 PM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
Esanders closed T220009: Add icon(s) for audiovisual media (music / movie) to the cite tool css classes as Resolved.

I set it to use the play icon from OOUI: https://gl.wikipedia.org/w/index.php?title=MediaWiki%3AVisualeditor-cite-tool-definition.json&type=revision&diff=5117742&oldid=3805660

Fri, Aug 30, 4:59 PM · User-Ryasmeen, VisualEditor, good first bug
Esanders added a comment to T228230: Add "✔️" into link modal.

+1, we should treat the link inspector differently. Should be at least all mobile inspectors and dialogs (except publish/save dialog).

Fri, Aug 30, 3:38 PM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design