Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (203 w, 4 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

Can we add a border?

Sat, Sep 22, 11:51 AM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile

Yesterday

Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

In fact on my local environment, it appears to ignore base90 as being too close to white, and leaves the header bar as white.

Fri, Sep 21, 8:41 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

I don't think this example matches what is happening in VE. There is a single pixel border above the toolbar, which isn't present in my screenshots. The original issue was that there was no delineation when there was no border.

Fri, Sep 21, 8:27 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T205123: eslint really slow to run in lib/ve.

Testing locally, all the JS files take 17s, whereas the handful of HTML files take 60s, so there's something wrong with the plugin. Filed upstream as https://github.com/BenoitZugmeyer/eslint-plugin-html/issues/102

Fri, Sep 21, 5:57 PM · VisualEditor (Current work), Patch-For-Review
Esanders moved T205123: eslint really slow to run in lib/ve from Up next to Code review on the VisualEditor (Current work) board.
Fri, Sep 21, 5:55 PM · VisualEditor (Current work), Patch-For-Review
Esanders edited projects for T205123: eslint really slow to run in lib/ve, added: VisualEditor (Current work); removed VisualEditor.
Fri, Sep 21, 5:55 PM · VisualEditor (Current work), Patch-For-Review
Esanders created T205123: eslint really slow to run in lib/ve.
Fri, Sep 21, 5:40 PM · VisualEditor (Current work), Patch-For-Review
Esanders moved T205096: DimensionWidget in a FieldLayout always disables the FieldLayout from Up next to Code review on the VisualEditor (Current work) board.
Fri, Sep 21, 2:17 PM · Patch-For-Review, VisualEditor (Current work)
Esanders created T205096: DimensionWidget in a FieldLayout always disables the FieldLayout.
Fri, Sep 21, 2:16 PM · Patch-For-Review, VisualEditor (Current work)
Esanders added a comment to T203889: MediaSizeWidget in a FieldLayout always disables the FieldLayout.

Actually I was wrong there, the maps dialog is not a MediaSizeWidget, it's a DimensionsWidget. The MSW is used on the media dialog only, so this would only affect the WIP for the media dialog which hasn't been merged yet. It looks like the DimensionsWidget suffers from the same problem so I'll fix that too.

Fri, Sep 21, 2:11 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-Media, VisualEditor (Current work)
Esanders added a comment to T194068: CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces.

Can you add screenshots showing the before/after of editing a file page in VE/VE source mode?

Fri, Sep 21, 2:06 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
Esanders committed rETHR9c8b37ccbac6: Fix check for already-wrapped thumbnails (authored by Esanders).
Fix check for already-wrapped thumbnails
Fri, Sep 21, 2:03 PM
Esanders committed rETHR300d4f8d52a8: Get rid of attachBadge (authored by Esanders).
Get rid of attachBadge
Fri, Sep 21, 2:03 PM
Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

Here it is with a theme colour of #eaecf0, as suggested by Volker:

Fri, Sep 21, 1:58 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders renamed T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android from MobileFrontend overlay toolbar can have no top border on Android to MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.
Fri, Sep 21, 1:52 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

It seems like the standard practice is to make the status bar a darker version of the color used for the header, would that be possible? As in:

Fri, Sep 21, 1:42 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile

Thu, Sep 20

Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

Here is a theme colour of #eee:

Thu, Sep 20, 12:34 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T203237: Certain dialogues in the mobile visual editor are larger than necessary on certain screen sizes, added: VisualEditor; removed VisualEditor (Current work).
Thu, Sep 20, 11:22 AM · VisualEditor, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements
Esanders moved T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console from Up next to Stalled/Waiting on the VisualEditor (Current work) board.

(ping @Niedzielski)

Thu, Sep 20, 11:21 AM · VisualEditor (Current work), Readers-Web-Backlog (Tracking)
Esanders removed a project from T204873: "Special page" tab accidentally renamed to "CollabPad" : VisualEditor (Current work).
Thu, Sep 20, 10:11 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Special-pages
Liuxinyu970226 awarded T204873: "Special page" tab accidentally renamed to "CollabPad" a Party Time token.
Thu, Sep 20, 4:28 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Special-pages

Wed, Sep 19

Krinkle awarded T203350: English dialects should use fallback to English icons a Orange Medal token.
Wed, Sep 19, 11:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), User-Nikerabbit, Performance-Team (Radar), I18n, MediaWiki-ResourceLoader
Framawiki awarded T204873: "Special page" tab accidentally renamed to "CollabPad" a Party Time token.
Wed, Sep 19, 9:38 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Special-pages
Esanders edited projects for T204873: "Special page" tab accidentally renamed to "CollabPad" , added: MediaWiki-Special-pages; removed VisualEditor.
Wed, Sep 19, 8:21 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Special-pages
Esanders added a comment to T204873: "Special page" tab accidentally renamed to "CollabPad" .

Oops. Reverted: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/461467/

Wed, Sep 19, 8:19 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Special-pages
Esanders added a comment to T204850: } in a table cell corrupts the table.

Yep - this is Parsoid only. <table><tr><td>}</td></tr></table> does not round-trip.

Wed, Sep 19, 7:58 PM · Parsoid-Edit-Support
Esanders renamed T204850: } in a table cell corrupts the table from } in a table cell corrupt the table to } in a table cell corrupts the table.
Wed, Sep 19, 7:57 PM · Parsoid-Edit-Support
Esanders removed a project from T204850: } in a table cell corrupts the table: VisualEditor.
Wed, Sep 19, 7:57 PM · Parsoid-Edit-Support
Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

@Jdlrobson not sure if this was intended or not, but on staging I'm seeing the status bar + the browser header as black, which is a bit intense.

Wed, Sep 19, 7:42 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

The web manifest is only used for installed web apps, and the background color property is only used for the splash screen: https://developers.google.com/web/fundamentals/web-app-manifest/

Wed, Sep 19, 5:34 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders updated the task description for T204621: Reduce footprint of ext.3d on page initialisation.
Wed, Sep 19, 5:23 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Multimedia, 3D, Performance-Team (Radar)
Esanders added a comment to T198477: [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not <ref> tags).
Wed, Sep 19, 4:43 PM · VisualEditor (Current work)
Esanders moved T201551: Write up and share findings of VE Expert Review from Up next to In progress on the VisualEditor (Current work) board.
Wed, Sep 19, 4:42 PM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Design-Research, Design
Esanders edited projects for T202619: Get rid of tiny hogan templates in mobile.editor.ve, added: VisualEditor; removed VisualEditor (Current work).
Wed, Sep 19, 4:40 PM · VisualEditor, Editing Q1 2018-19 mobile improvements, Technical-Debt, VisualEditor-MediaWiki-Mobile
Esanders moved T196117: [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping from Code review to QA on the VisualEditor (Current work) board.
Wed, Sep 19, 4:28 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, VisualEditor (Current work)
Esanders moved T203156: Refactor source mode conversion from Stalled/Waiting to QA on the VisualEditor (Current work) board.
Wed, Sep 19, 4:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), Performance, Technical-Debt, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T203156: Refactor source mode conversion.

It's pretty well covered by unit tests, but loading & saving VE source mode are the areas affected (or not, hopefully)

Wed, Sep 19, 4:23 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), Performance, Technical-Debt, VisualEditor-MediaWiki-2017WikitextEditor
Esanders committed rETHR6aaf2076e75b: Only load 3D JS on file page (authored by Esanders).
Only load 3D JS on file page
Wed, Sep 19, 3:55 PM
Esanders committed rETHR33b179cb0885: Fix 3D thumbnail HTML in PHP (authored by Esanders).
Fix 3D thumbnail HTML in PHP
Wed, Sep 19, 3:55 PM
Esanders committed rETHR03628e5d3f58: Only load 3D JS on file page (authored by Esanders).
Only load 3D JS on file page
Wed, Sep 19, 1:51 PM
Esanders committed rETHR9bc90049431e: Fix 3D thumbnail HTML in PHP (authored by Esanders).
Fix 3D thumbnail HTML in PHP
Wed, Sep 19, 1:48 PM
Esanders committed rETHR44733b63562c: Follow-up Ia0df4884b: Only teardown 3D viewer inside MMV (authored by Esanders).
Follow-up Ia0df4884b: Only teardown 3D viewer inside MMV
Wed, Sep 19, 1:48 PM
Esanders added a comment to T204816: LESS in ResourceLoader can't parse two ampersands on one line.

less.php hasn't been touched in two years and has 88 open issues: https://github.com/oyejorge/less.php :/

Wed, Sep 19, 11:28 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Performance-Team, MediaWiki-ResourceLoader
Esanders added a comment to T204816: LESS in ResourceLoader can't parse two ampersands on one line.

The above patch works around the issue, it is not a fix.

Wed, Sep 19, 11:19 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Performance-Team, MediaWiki-ResourceLoader
Esanders created T204816: LESS in ResourceLoader can't parse two ampersands on one line.
Wed, Sep 19, 11:16 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Performance-Team, MediaWiki-ResourceLoader

Tue, Sep 18

Esanders added a comment to T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

Any overlay that uses a header will have it blend into the status bar, so the wikitext editor at least, and I assume there are other overlays that have headers.

Tue, Sep 18, 7:00 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders committed rETHR79ed1a4c6d1a: Follow-up Ia0df4884b: Only teardown 3D viewer inside MMV (authored by Esanders).
Follow-up Ia0df4884b: Only teardown 3D viewer inside MMV
Tue, Sep 18, 6:52 PM
Esanders added a comment to T198448: After viewing a 3D file, all files viewed afterwards are displayed as "3D".

Caused T204749...

Tue, Sep 18, 6:49 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Multimedia-Team-Working-Board, 3D, Commons, Multimedia, MediaWiki-File-management
Esanders added a project to T204749: Thumbnails disappear after opening 3D image in MultimediaViewer: Regression.
Tue, Sep 18, 6:49 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Regression, Multimedia, 3D
Esanders triaged T204749: Thumbnails disappear after opening 3D image in MultimediaViewer as High priority.
Tue, Sep 18, 6:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Regression, Multimedia, 3D
Esanders created T204749: Thumbnails disappear after opening 3D image in MultimediaViewer.
Tue, Sep 18, 6:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Regression, Multimedia, 3D
Esanders committed rETHR0e514715cd81: Lazy-build the placeholderTemplate (authored by Esanders).
Lazy-build the placeholderTemplate
Tue, Sep 18, 6:16 PM
Esanders added a comment to T187562: Use a better method for detecting STL files on the page.

@brion Are you saying that's a blocker to this task?

Tue, Sep 18, 6:16 PM · Performance, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 3D, Multimedia
marcella awarded T202978: Move MobileFrontend's VisualEditor styles back to MobileFrontend a Grey Medal token.
Tue, Sep 18, 5:52 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Readers-Web-Backlog (Tracking), VisualEditor (Current work), Technical-Debt, MinervaNeue, MobileFrontend
Esanders created T204733: Re-think positioning of mobile contexts.
Tue, Sep 18, 4:14 PM · VisualEditor-MediaWiki-Mobile, Design, VisualEditor
Volker_E awarded T204388: Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view a Piece of Eight token.
Tue, Sep 18, 3:49 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T204388: Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view from Up next to Code review on the VisualEditor (Current work) board.
Tue, Sep 18, 2:31 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders edited projects for T204388: Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view, added: VisualEditor (Current work); removed VisualEditor.
Tue, Sep 18, 2:31 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T204197: On a page with recovered autosaved changes, using Ctrl+Z to undo clears the DM selection (and CE selection is desync'd) from Code review to QA on the VisualEditor (Current work) board.
Tue, Sep 18, 2:30 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor-DataModel, VisualEditor (Current work)
Esanders moved T204718: Mobile: Selection handles obscured after scrollCursorIntoView from Up next to Code review on the VisualEditor (Current work) board.
Tue, Sep 18, 2:29 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T204718: Mobile: Selection handles obscured after scrollCursorIntoView, added: VisualEditor (Current work); removed VisualEditor.
Tue, Sep 18, 2:28 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders created T204718: Mobile: Selection handles obscured after scrollCursorIntoView.
Tue, Sep 18, 2:13 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders moved T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android from Up next to Code review on the VisualEditor (Current work) board.
Tue, Sep 18, 1:08 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android, added: VisualEditor (Current work); removed VisualEditor.
Tue, Sep 18, 1:08 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders renamed T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android from VE mobile toolbar can have no top border on Android to MobileFrontend overlay toolbar can have no top border on Android.
Tue, Sep 18, 12:20 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders updated the task description for T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.
Tue, Sep 18, 12:20 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.

This should probably be fixed upstream in MobileFrontend, as it applies to any overlay toolbar.

Tue, Sep 18, 12:19 PM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders created T204691: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android.
Tue, Sep 18, 11:31 AM · Readers-Web-Backlog, Browser-Support-Android-Google-Chrome, UI-Standardization, VisualEditor (Current work), Patch-For-Review, MobileFrontend, VisualEditor-MediaWiki-Mobile
Esanders created T204690: Close button on WLM banner is too small on mobile.
Tue, Sep 18, 11:30 AM · Wiki-Loves-Monuments

Mon, Sep 17

Esanders added a comment to T204428: Colon rendered as plaintext when on a line with definition list from template.

I believe we are talking about two different issues here?

Mon, Sep 17, 11:55 PM · Parsoid
Esanders awarded T202978: Move MobileFrontend's VisualEditor styles back to MobileFrontend a The World Burns token.
Mon, Sep 17, 11:51 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Readers-Web-Backlog (Tracking), VisualEditor (Current work), Technical-Debt, MinervaNeue, MobileFrontend
Esanders added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Auto-save could go in the other schema (for editor life cycle events)

Mon, Sep 17, 11:45 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
Esanders added a comment to T204621: Reduce footprint of ext.3d on page initialisation.

1 & 2 should be easy. 3 is probably blocked on T187562.

Mon, Sep 17, 11:42 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Multimedia, 3D, Performance-Team (Radar)
Esanders added a comment to T203889: MediaSizeWidget in a FieldLayout always disables the FieldLayout.

This came up in the update for mobile of MapsDialog. If that change has been merged you can just verify that the label there is not disabled.

Mon, Sep 17, 11:33 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-Media, VisualEditor (Current work)
Esanders added a comment to T203136: Develop new schema for editing feature usage.

Small note: in our code we use "textStyle/bold" instead of "textStyle/Bold" (and similarly lower case for italic/underline)

Mon, Sep 17, 5:18 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
Esanders added a comment to T204428: Colon rendered as plaintext when on a line with definition list from template.

The definition list is in fact a series of templates. Accordingly we provide a way to insert content between them with an "Insert paragraph button":

Mon, Sep 17, 2:28 PM · Parsoid
Esanders added a comment to T204239: Investigate ways to improve the copy-pasting workflow on mobile.

(@Deskana)

Mon, Sep 17, 12:25 PM · Editing Q1 2018-19 mobile improvements, VisualEditor

Sat, Sep 15

Esanders added a comment to T203470: Fix graph dialog in mobile visual editor.

It's already hacked in to be left and right aligned context-specifically.

Sat, Sep 15, 10:20 AM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Fri, Sep 14

Esanders created T204388: Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view.
Fri, Sep 14, 11:00 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T204387: Can't drag a collapsed selection across a reference on mobile.
Fri, Sep 14, 10:57 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders claimed T202935: Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari, but the problem is intermittent.
Fri, Sep 14, 12:50 PM · Patch-For-Review, VisualEditor (Current work), Browser-Support-Apple-Safari
Esanders moved T202935: Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari, but the problem is intermittent from Up next to Code review on the VisualEditor (Current work) board.
Fri, Sep 14, 12:49 PM · Patch-For-Review, VisualEditor (Current work), Browser-Support-Apple-Safari
Esanders removed a project from T202324: Visualdiff stuck on particular diff due to "null is not an object"-error: JavaScript.
Fri, Sep 14, 11:12 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders moved T203156: Refactor source mode conversion from Code review to QA on the VisualEditor (Current work) board.
Fri, Sep 14, 11:11 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), Performance, Technical-Debt, VisualEditor-MediaWiki-2017WikitextEditor
Esanders moved T203114: 2017 source editor trimmed whitespace inside a "source" block from Code review to QA on the VisualEditor (Current work) board.
Fri, Sep 14, 11:11 AM · VisualEditor-MediaWiki-2017WikitextEditor, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), SyntaxHighlight

Thu, Sep 13

Esanders committed rERSL351bdcfae7b2: build: Update linters (authored by Esanders).
build: Update linters
Thu, Sep 13, 8:59 PM
Esanders assigned T204194: VisualEditor (NWE) doesn't exit cleanly when clicking the namespace tab on a discussion page to matmarex.
Thu, Sep 13, 5:55 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-MediaWiki
Esanders moved T202324: Visualdiff stuck on particular diff due to "null is not an object"-error from In progress to Code review on the VisualEditor (Current work) board.
Thu, Sep 13, 5:55 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders moved T202324: Visualdiff stuck on particular diff due to "null is not an object"-error from Up next to In progress on the VisualEditor (Current work) board.
Thu, Sep 13, 5:51 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders claimed T202324: Visualdiff stuck on particular diff due to "null is not an object"-error.
Thu, Sep 13, 5:51 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders added a comment to T202324: Visualdiff stuck on particular diff due to "null is not an object"-error.

This is actually the fault of my template-generated ref list code, not the visual diff code :/

Thu, Sep 13, 5:50 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders updated subscribers of T202324: Visualdiff stuck on particular diff due to "null is not an object"-error.
Thu, Sep 13, 3:45 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders added a comment to T204239: Investigate ways to improve the copy-pasting workflow on mobile.

Duplicate of T101113?

Thu, Sep 13, 3:17 PM · Editing Q1 2018-19 mobile improvements, VisualEditor
Esanders added a comment to T204241: Investigate ways of attaching toolbars to the bottom of the viewport.

I've researched this in the past, and the answer is basically that it's currently impossible. The best I found was people guessing based on knowing the phone model & OS version, but even then it will vary with autocomplete and different IMEs.

Thu, Sep 13, 3:16 PM · Editing Q1 2018-19 mobile improvements, VisualEditor
Esanders added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

@dchan I've separated the patch into Android/iOS versions. The Android part works fine and should be fairly uncontroversial.

Thu, Sep 13, 11:51 AM · Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders moved T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it) from Code review to In progress on the VisualEditor (Current work) board.
Thu, Sep 13, 11:48 AM · Verified, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
Esanders moved T201721: Exception thrown in list diff from Code review to QA on the VisualEditor (Current work) board.
Thu, Sep 13, 11:46 AM · Verified, VisualEditor-EditingTools, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders added a comment to T201721: Exception thrown in list diff.

Diff after monkey-patch

Thu, Sep 13, 11:45 AM · Verified, VisualEditor-EditingTools, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
Esanders claimed T204197: On a page with recovered autosaved changes, using Ctrl+Z to undo clears the DM selection (and CE selection is desync'd).
Thu, Sep 13, 11:40 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor-DataModel, VisualEditor (Current work)
Esanders moved T204197: On a page with recovered autosaved changes, using Ctrl+Z to undo clears the DM selection (and CE selection is desync'd) from Up next to Code review on the VisualEditor (Current work) board.
Thu, Sep 13, 11:40 AM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor-DataModel, VisualEditor (Current work)