Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (475 w, 2 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders closed T121357: Cannot cursor out of a unicorned annotation as Resolved.

Observe that Left/Right won't exit the unicorned underline.

Thu, Dec 7, 3:57 PM · VisualEditor-ContentEditable, VisualEditor
Esanders merged T120855: Consider splitting observed transactions on word boundaries into T127834: Undo history breakpoints should be inserted at word breaks.
Thu, Dec 7, 3:56 PM · MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), VisualEditor-ContentLanguage, VisualEditor-DataModel, VisualEditor
Esanders merged task T120855: Consider splitting observed transactions on word boundaries into T127834: Undo history breakpoints should be inserted at word breaks.
Thu, Dec 7, 3:56 PM · VisualEditor-ContentEditable, VisualEditor
Esanders merged T119516: Backspace in an empty paragraph after a template / table selects it but doesn't remove the paragraph into T338622: Can't remove an empty linebreak between two tables.
Thu, Dec 7, 3:52 PM · Verified, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor
Esanders merged task T119516: Backspace in an empty paragraph after a template / table selects it but doesn't remove the paragraph into T338622: Can't remove an empty linebreak between two tables.
Thu, Dec 7, 3:52 PM · VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T106708: Cannot select across a floated template.

Mouse selection works now, but not keyboard.

Thu, Dec 7, 3:48 PM · VisualEditor-ContentEditable, VisualEditor-CopyPaste, VisualEditor
Esanders closed T69265: VisualEditor: resizing audio file causes it to resize 0px dialogs do not report size. as Resolved.

This no longer happens.

Thu, Dec 7, 3:46 PM · VisualEditor-MediaWiki-Media, VisualEditor, VisualEditor-ContentEditable
Esanders closed T69212: VisualEditor: Block items converted to inline initially show a flash of highlight trying to select the previous line, and then the selection normalises to just the item as Resolved.

Can't reproduce. Very old bug so probably been fixed.

Thu, Dec 7, 3:44 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T67593: VisualEditor: Can't cut or copy citation template in Reference dialog as Resolved.

Can't reproduce. Given the age of the task I'll assume it's fixed. Please re-open otherwise.

Thu, Dec 7, 3:41 PM · VisualEditor, VisualEditor-ContentEditable, Browser-Support-Apple-Safari
Esanders closed T64287: VisualEditor: Caption of nested image is centered in image dialog box as Resolved.

Text is now correctly aligned.

Thu, Dec 7, 3:35 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T63863: VisualEditor: Pressing backspace when cursor is in the first position in a nested list item should unindent, not merge it with the previous item in the parent list as Resolved.

This behaves more sensibly now.

Thu, Dec 7, 3:32 PM · Parsoid (Tracking), VisualEditor, VisualEditor-ContentEditable
Esanders closed T63371: VisualEditor: Span tags getting added to references when pasting from Microsoft Office as Resolved.

Copy paste sanitisation has improved significantly since 2014, so closing. If this is still happening, please re-open.

Thu, Dec 7, 3:29 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T63524: VisualEditor: Error thrown when typing something while a left aligned image is selected as Resolved.

IME cursor code has changed significantly since 2014 and I can't reproduce. Please re-open if this is still hapenning.

Thu, Dec 7, 3:29 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T60998: VisualEditor: document.activeElement can change unexpectedly while typing in VE editor as Declined.

This is intentional. We move the selection the paste target so we can intercept copy events. Users should not care what document.activeElement is set to.

Thu, Dec 7, 3:23 PM · VisualEditor, VisualEditor-ContentEditable
Esanders merged T59372: VisualEditor: Adjacent floating tables are offset by vertical space because of intervening <span> into T54304: VisualEditor: Display of several float:left-ed tables side-by-side inserts slugs that break them up.
Thu, Dec 7, 3:21 PM · VisualEditor, VisualEditor-ContentEditable
Esanders merged task T59372: VisualEditor: Adjacent floating tables are offset by vertical space because of intervening <span> into T54304: VisualEditor: Display of several float:left-ed tables side-by-side inserts slugs that break them up.
Thu, Dec 7, 3:21 PM · VisualEditor, VisualEditor-ContentEditable
Esanders added a comment to T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.

We could have VE output <br> when you press shift enter in a list, but I think this should be done in Parsoid:

  • We are only using <br> because wikitext doesn't support linebreaks
  • In other contexts, we generally don't want people using <br> (e.g. table cell), or even in main paragraphs if they press shift+enter accidentally.
Thu, Dec 7, 3:17 PM · VisualEditor, Patch-Needs-Improvement, Parsoid
Esanders added a subtask for T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead: T95518: Shift-enter should create <br> line break.
Thu, Dec 7, 3:10 PM · VisualEditor, Patch-Needs-Improvement, Parsoid
Esanders added a parent task for T95518: Shift-enter should create <br> line break: T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Thu, Dec 7, 3:10 PM · VisualEditor-ContentEditable, VisualEditor
Esanders merged T57746: Multiline list items rendering differently in ContentEditable than the resulting wikitext into T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Thu, Dec 7, 3:08 PM · VisualEditor, Patch-Needs-Improvement, Parsoid
Esanders merged task T57746: Multiline list items rendering differently in ContentEditable than the resulting wikitext into T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Thu, Dec 7, 3:07 PM · VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentEditable
Esanders added a comment to T57746: Multiline list items rendering differently in ContentEditable than the resulting wikitext.

Duplicate of T110986. This one is older, but the other has more discussion on it (sorry @Mooeypoo)

Thu, Dec 7, 3:07 PM · VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentEditable
Esanders closed T54332: VisualEditor: Selecting with Shift-arrow selects the heading after a list item as Declined.

Pressing shift+down moves your cursor down visually in the browser. This is just how native selection works in the browser (for example, in read mode, select the first 'l' in 'list item 1', then press shift down, and the same thing happens).

Thu, Dec 7, 2:59 PM · VisualEditor, VisualEditor-ContentEditable
Esanders added a comment to T341845: Delete edit recovery data when logging out.

I don't think we do much wiping of data when users log out in general, and you could argue this is either a good or bad thing.

Thu, Dec 7, 2:52 PM · Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery
Esanders closed T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__, a subtask of T251653: [Epic] Enable DiscussionTools on pages not in a talk namespace, as Resolved.
Thu, Dec 7, 12:22 PM · TPP-Scaling, Editing-team, DiscussionTools
Esanders closed T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__, a subtask of T350450: No subscribe links for VillagePump / bar on mobile, as Resolved.
Thu, Dec 7, 12:21 PM · Editing-team (Kanban Board), DiscussionTools
Esanders closed T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__ as Resolved.
Thu, Dec 7, 12:21 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders updated the task description for T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.
Thu, Dec 7, 12:21 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders closed T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_, a subtask of T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__, as Resolved.
Thu, Dec 7, 12:19 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders closed T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_ as Resolved.
Thu, Dec 7, 12:19 PM · Editing QA, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools

Tue, Dec 5

Esanders added a comment to T78696: Break up ve.ce.Surface.js by functionality.

After the above patch it dropped to 3,400 lines. Today it is 5,400 (!)

Tue, Dec 5, 10:09 PM · Technical-Debt, VisualEditor-ContentEditable, VisualEditor
Esanders closed T59085: VisualEditor: Selecting text with command+down actually selects the whole current paragraph and also the 0th character of the next one; show this more obviously as Declined.

The rendering is consistent with native selections. We should ignore the empty partial selection for most actions, but that is T52419.

Tue, Dec 5, 10:08 PM · VisualEditor, Design, VisualEditor-ContentEditable
Esanders closed T57448: VisualEditor: Clean up phantom mouse event code in ve.ce.ProtectedNode as Resolved.
Tue, Dec 5, 10:05 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T55544: VisualEditor: Added templates in RTL wikis should float in appropriate direction, a subtask of T35126: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking), as Resolved.
Tue, Dec 5, 10:02 PM · User-Ryasmeen, RTL, VisualEditor-InterfaceLanguage, VisualEditor, Tracking-Neverending, I18n, VisualEditor-ContentLanguage
Esanders closed T55544: VisualEditor: Added templates in RTL wikis should float in appropriate direction as Resolved.

This is working for me. Feel free to re-open if this is still an issue.

Tue, Dec 5, 10:02 PM · VisualEditor, VisualEditor-ContentEditable
Esanders updated the task description for T352797: Consider more languages to get the reply icon treatment based on their translation of "Reply".
Tue, Dec 5, 6:31 PM · DiscussionTools
Esanders added a comment to T352797: Consider more languages to get the reply icon treatment based on their translation of "Reply".

Of these I think Korean is an obvious ommission, and was discussed in the original task (T323537#8461963).

Tue, Dec 5, 6:30 PM · DiscussionTools
Esanders updated the task description for T352797: Consider more languages to get the reply icon treatment based on their translation of "Reply".
Tue, Dec 5, 6:29 PM · DiscussionTools
Esanders created T352797: Consider more languages to get the reply icon treatment based on their translation of "Reply".
Tue, Dec 5, 6:21 PM · DiscussionTools
Esanders updated the task description for T52908: Confusing behaviour when increasing the indentation of the first item in a list.
Tue, Dec 5, 5:36 PM · VisualEditor, VisualEditor-ContentEditable
Esanders added a comment to T54770: VisualEditor: cutting block level elements changes the type of following element.

Similar to T52419 in that it involves selections which overflow into the next CBN.

Tue, Dec 5, 5:35 PM · Editing QA, Editing-team (Kanban Board), Patch-For-Review, VisualEditor, VisualEditor-ContentEditable
Esanders added a comment to T52908: Confusing behaviour when increasing the indentation of the first item in a list.

Google Docs and LibreOffice don't allow you to indent the first item of a list. They instead visually (but not semantically) indent the entire list. Doing that in MediaWiki (with our <dd> hack indentation) would be even more confusing, so I think doing nothing would make more sense here. Users should probably have to create a bullet list above the first one before increasing indentation.

Tue, Dec 5, 5:31 PM · VisualEditor, VisualEditor-ContentEditable
Esanders renamed T52908: Confusing behaviour when increasing the indentation of the first item in a list from VisualEditor: Show multi-level lists in a better way in VisualEditor (and in MediaWiki?) to Confusing behaviour when increasing the indentation of the first item in a list.
Tue, Dec 5, 5:28 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T52741: VisualEditor: Show a different cursor when Ctrl (Cmd on Mac) is held down, as the interaction will be different as Resolved.

Browsers do this automatically now (tested Chrome + FF).

Tue, Dec 5, 5:24 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T50461: VisualEditor: Image in template gets cut off as Resolved.

Not happening for me in Chrome or FF. Assuming this was a browser bug that has since been fixed, but please re-open if it is still happening.

Tue, Dec 5, 4:56 PM · VisualEditor, VisualEditor-ContentEditable
Esanders closed T50461: VisualEditor: Image in template gets cut off, a subtask of T53792: VisualEditor: Non-English Wikipedia issues (tracking), as Resolved.
Tue, Dec 5, 4:56 PM · User-Ryasmeen, VisualEditor pre-2015 work, Tracking-Neverending, VisualEditor
Esanders updated the task description for T275729: Comment permalinks: design and implement user experience.
Tue, Dec 5, 1:33 PM · Editing QA, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), Goal, TPP-Phase1, Design, DiscussionTools
Esanders closed T45351: Add clickable anchors to timestamps on Talk pages as Resolved.

This has been implemented in DiscussionTools in T275729.

Tue, Dec 5, 1:31 PM · MediaWiki-Page-editing
Esanders moved T275729: Comment permalinks: design and implement user experience from Doing to QA on the Editing-team (Kanban Board) board.
Tue, Dec 5, 1:25 PM · Editing QA, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), Goal, TPP-Phase1, Design, DiscussionTools
Esanders moved T304579: Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive) from Design Review to Code Review on the Editing-team (Kanban Board) board.
Tue, Dec 5, 12:23 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Design, TPP-Phase1, Goal, DiscussionTools

Mon, Dec 4

Esanders created T352708: Edit check reference change "no survey" page has scrollbar in Arabic.
Mon, Dec 4, 6:25 PM · VisualEditor
Esanders closed T347363: Ensure Edit Check is sufficiently translated for partner wikis, a subtask of T331947: [RELEASE TICKET] Make Edit Check MVP available to all newcomers at Partner Wikipedias, as Resolved.
Mon, Dec 4, 6:23 PM · Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T347363: Ensure Edit Check is sufficiently translated for partner wikis as Resolved.

Verified

image.png (325×445 px, 39 KB)

Mon, Dec 4, 6:23 PM · Editing QA, Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T345096: Show new topics subscription button on history pages as Resolved.
Mon, Dec 4, 6:18 PM · Verified, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), DiscussionTools
Esanders moved T345096: Show new topics subscription button on history pages from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Mon, Dec 4, 6:18 PM · Verified, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T333709: [CONSULT] Collaborate with volunteers to define Edit Check key results.
Mon, Dec 4, 6:11 PM · Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders renamed T304579: Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive) from Define user experience for when it is ambiguous what page permalink should lead you to to Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive).
Mon, Dec 4, 3:39 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Design, TPP-Phase1, Goal, DiscussionTools
Esanders moved T349653: Permalink redirecting: Support plain section links from Doing to Code Review on the Editing-team (Kanban Board) board.
Mon, Dec 4, 3:37 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, DiscussionTools, Editing-team (Kanban Board)
Esanders created T352661: Gadget source code pages should show user count, or default status, when viewing or editing.
Mon, Dec 4, 12:57 PM · Patch-For-Review, MediaWiki-extensions-Gadgets

Sun, Dec 3

Esanders added a comment to T352591: Show page-level discussion statistics.

It might be useful for people to get a sense for the activity of a page if we also showed at least the "X people are commenting"

Sun, Dec 3, 7:48 PM · Editing-team (Design Backlog), Editing Design, DiscussionTools

Fri, Dec 1

Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

I've applied my own fix with @disksance 's blessing and things appear to be working now.

Fri, Dec 1, 3:19 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

This still sets an href, it just sets the href to the current page. Now click on OOUI tools reload the page. The fix to the library (https://github.com/wikimedia-gadgets/VariantAlly/pull/5) should cause it to skip over non-href <a> tags.

Fri, Dec 1, 2:48 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

Appears to the VariantAlly script: https://github.com/wikimedia-gadgets/VariantAlly/issues/4

Fri, Dec 1, 2:26 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352526: Enable visual editor in the property talk namespace on Wikidata.

We generally don't enable VE on talk namespaces, as it doesn't support indented discussion threads well. One can still add ?veaction=edit to the URL to force the visual editor to load.

Fri, Dec 1, 2:02 PM · VisualEditor, Wikidata
Esanders added a comment to T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.

I've moved 11 of the remaining 37 pages, but the other 26 will require someone with more rights across all wikis.

Fri, Dec 1, 1:36 PM · Technical-Debt, VisualEditor, Cite

Thu, Nov 30

Esanders added a comment to T350270: Mobile Reply: enter+backspace strange behavior.

May have been fixed since T312558. Is this still broken @Ponor ?

Thu, Nov 30, 6:28 PM · Editing-team, VisualEditor-ContentEditable, VisualEditor, DiscussionTools
Esanders updated the task description for T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.
Thu, Nov 30, 6:01 PM · Technical-Debt, VisualEditor, Cite
Esanders updated the task description for T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.
Thu, Nov 30, 6:00 PM · Technical-Debt, VisualEditor, Cite
Esanders added a comment to T351529: Assist with linking to article sections within the Reply Tool.

That is T52881. While that would make fragment linking easier, this task argues that a specific tool for quickly linking to sections of the page you are talking about would be helpful tool.

Thu, Nov 30, 5:57 PM · DiscussionTools
Esanders added a comment to T352455: DiscussionTools handle out of range dates.

I looked into this a bit, and the problem isn't the year is 0 (both our PHP and JS timestamp libraries support the non-existent year 0).

Thu, Nov 30, 5:35 PM · Patch-For-Review, DiscussionTools
Esanders added a comment to T352455: DiscussionTools handle out of range dates.

so that comment with invalid timestamps can be replied to

Thu, Nov 30, 4:40 PM · Patch-For-Review, DiscussionTools
Esanders added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

^ core patch has broken DT headings:

image.png (481×1 px, 80 KB)

Thu, Nov 30, 11:24 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
Esanders added a comment to T249893: Add "Thanks" to talk page comments.

I don’t agree. What users can and cannot thank should be a product/design decision informed by technical possibilities, not a purely technical decision.

Thu, Nov 30, 10:54 AM · Patch-Needs-Improvement, DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks

Wed, Nov 29

Esanders added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

You will also need to inherit wikimedia/jsdoc instead of wikimedia/jsduck in eslintrc.

Wed, Nov 29, 2:19 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Tech-Docs-Team, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Esanders moved T352289: Reply link icon not shown in language variants of designated "short reply button" languages from Incoming to Code Review on the Editing-team (Kanban Board) board.
Wed, Nov 29, 1:58 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders claimed T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:58 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders updated the task description for T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:51 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders created T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:46 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_.

Thanks, done.

Wed, Nov 29, 1:07 PM · Editing QA, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders updated the task description for T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_.
Wed, Nov 29, 1:07 PM · Editing QA, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools

Tue, Nov 28

Esanders added a comment to T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.

Clarifying what this patch does:

  • Applies to anyone who has visual enhancements enabled (either via the beta feature (which exposes the new preference as enabled by default), the A/B test on certain wikis, or by being on mobile where enhancements are always enabled)
  • Enables visual enhancements whenver the __NEWSECTIONLINK__ marker is present (as opposed to only in talk namespaces)
  • However this does not apply in the article namespace, unless the article namespace is in wgExtraSignatureNamespaces (such as on mediawiki.org)
    • This prevents our styling ever applying to Wikipedia articles, even if a user accidentally adds the marker to that page.
Tue, Nov 28, 6:29 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders updated the task description for T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.
Tue, Nov 28, 5:57 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders closed T351530: Exception thrown when typing `#...` into the link inspector as Resolved.
Tue, Nov 28, 1:21 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), VisualEditor

Mon, Nov 27

Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

You can override the gutter with this user CSS:

.client-js .mw-editform #wpTextbox1 {
  margin-left: 0;
  width: 100%;
}
Mon, Nov 27, 5:33 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

Who benefits from this?

Anyone switching between highlighting and not highlighting. It also removes the jitter while CodeMirror is loading, which was the original reason for the change. Any fix would add even more complexity for little benefit.

Mon, Nov 27, 5:31 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T349622: [design] Notifications (mw.notify) are a long way from the content on wide screens.

Presumably just limiting the patch to fixed width Vector 2022, and leaving as-is in other situations, would be fine (an improvement on the status quo)?

Mon, Nov 27, 4:09 PM · Web-Team-Backlog (FY2023-24 Q2 Sprint 5), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Desktop Improvements (Vector 2022)
Esanders added a comment to T52881: VisualEditor: Link input widget should suggest section links.

3 & 4 are fixed. 1 is more complicated as it requires more interaction between VE and this core component (VE needs to override the list of available sections, rather than use an API call). I think that should probably be fixed later.

Mon, Nov 27, 4:03 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools, Browser-Support-Google-Chrome

Wed, Nov 22

Esanders added a comment to T52881: VisualEditor: Link input widget should suggest section links.

Thanks for the feedback.
1 sounds useful and should be fixable.
I think points 2-3 can be addressed later in follow ups.
4 should be fixed, we should replace underscores when normalising.
5: if you start typing # immediately you get no page name. Removing the page name could arguably be a Parsoid job, or something we should leave in if the user types it explicitly, but we could remove it locally.

Wed, Nov 22, 7:57 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools, Browser-Support-Google-Chrome

Fri, Nov 17

Esanders created T351530: Exception thrown when typing `#...` into the link inspector.
Fri, Nov 17, 1:46 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), VisualEditor
Esanders created T351529: Assist with linking to article sections within the Reply Tool.
Fri, Nov 17, 1:41 PM · DiscussionTools
Esanders renamed T265269: Assist with linking to other comments within the Reply Tool from Assist with linking to other comments within the LinkInspector to Assist with linking to other comments within the Reply Tool.
Fri, Nov 17, 1:39 PM · DiscussionTools
Esanders updated subscribers of T351487: Gutter doesn't disappear after disabling code editor.
Fri, Nov 17, 1:05 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

I would call this a feature. When toggling between plain and code height the content will not jump and reflow, and you won't lose your place.

Fri, Nov 17, 1:05 PM · Patch-For-Review, CodeEditor
Esanders created T351515: Fragment with '%20' in plain text doesn't round trip.
Fri, Nov 17, 1:02 PM · Parsoid
Esanders closed T308390: Avoid direct link to edit non-existing talk pages in Minerva as Resolved.

DT mobile is deployed everywhere.

Fri, Nov 17, 12:51 PM · DiscussionTools, MinervaNeue

Thu, Nov 16

Esanders added a comment to T351448: Extra right padding inside username autocompletion dropdown.

Note that we disable clipping in CSS in this widget:

.ve-ui-completionWidget .oo-ui-popupWidget-body {
	/* The contained MenuSelectWidget is already clipped (T330401) */
	/* TODO: This could be done in JS if OO.ui.ClippableElement provided a way to disable clipping */
	overflow: hidden !important; /* stylelint-disable-line declaration-no-important */
}
Thu, Nov 16, 6:49 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
Esanders added a comment to T351448: Extra right padding inside username autocompletion dropdown.

Looks like this is caused by scrollbar-gutter: stable.

Thu, Nov 16, 6:46 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
Esanders created T351448: Extra right padding inside username autocompletion dropdown.
Thu, Nov 16, 6:37 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools

Sat, Nov 11

Esanders added a project to T351011: Remove unused module dependencies from DiscussionTools: Technical-Debt.
Sat, Nov 11, 5:37 PM · Technical-Debt, DiscussionTools

Thu, Nov 9

Esanders added a comment to T350902: Cannot read properties of undefined (reading 'getRange').

I assumed this was related to https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/966217 but that hasn't been merged yet...

Thu, Nov 9, 6:47 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, Wikimedia-production-error