Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (220 w, 5 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Fri, Jan 18

Esanders set the point value for T214203: Education dots rendering issues to 0.5.
Fri, Jan 18, 9:04 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor, VisualEditor-MediaWiki
Esanders added a comment to T214203: Education dots rendering issues.

After:

Fri, Jan 18, 9:04 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor, VisualEditor-MediaWiki
Esanders created T214203: Education dots rendering issues.
Fri, Jan 18, 8:58 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor, VisualEditor-MediaWiki
Esanders added a comment to T210569: Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?).

@Ladsgroup can you confirm this issue, and if there are any other shortcut issues with a Persian keyboard?

Fri, Jan 18, 6:24 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders assigned T209610: On mobile, template context menu doesn't show the name of the template to matmarex.
Fri, Jan 18, 2:19 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, VisualEditor-EditingTools
Esanders claimed T211243: Add a useful call-to-action in the context for citation needed templates.
Fri, Jan 18, 2:17 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
Esanders moved T206014: Mobile editors do not log loaded events from Code review to Engineering QA on the VisualEditor (Current work) board.
Fri, Jan 18, 2:17 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Thu, Jan 17

iamjessklein awarded T203151: Consider adding a button to let users edit the whole page in MobileFrontend a Like token.
Thu, Jan 17, 10:09 PM · MobileFrontend, VisualEditor
Esanders added a comment to T203112: Splitting a paragraph duplicated it.

I think this is deliberate when we split nodes, so that wikitext formatting is preserved (not an issue for paragraphs, but for headings/table cells/lists etc.)

Thu, Jan 17, 7:50 PM · Parsoid, VisualEditor
Esanders added a comment to T213774: Custom VE error handling for AbuseFilter etc. is not enabled on mobile.

Oy that "targets" property....

Thu, Jan 17, 7:22 PM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, VisualEditor-MediaWiki
Esanders added a comment to T207796: Add flag to log tracking events to console.

So this is resolved then?

Thu, Jan 17, 7:20 PM · VisualEditor (Current work)
Esanders added a comment to T213429: Build Section Editing Prototype.
  • In Source editing mode, selecting to edit the whole article only shows the intro section when it should reveal the entire article

This was a deliberate decision made by the then mobile team, I believe made for performance reasons. I think there is a separate ticket about create separate links for edit-whole-document and edit-lede-section. I have an update to the patch which matches this behaviour in visual mode (so it edits the lede section). If we want to change this is should be consistent in both modes and we should be aware it would be a big change to the current mobile wikitext experience.

Thu, Jan 17, 5:57 PM · Editing Design , VisualEditor (Current work)
Esanders moved T202271: Allow restbase url to be set directly in Citoid extension, overwriting the VE url. from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Thu, Jan 17, 2:47 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), Citoid
Esanders moved T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Thu, Jan 17, 2:46 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend, MinervaNeue
Esanders moved T202723: Mobile native selection context menu can obscure the VE toolbar from Stalled/Waiting to Code review on the VisualEditor (Current work) board.
Thu, Jan 17, 2:46 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

we can consider if we need a different fix for older versions.

Thu, Jan 17, 2:02 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

It looks like this floating context became standard around Android 6 or 7. Your test device (Android 4.4) is the oldest we support.

Thu, Jan 17, 1:55 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Wed, Jan 16

Esanders claimed T213120: Restore section hash fragment after section editing in mobile VE.
Wed, Jan 16, 6:48 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T213922: VE removes all new lines when editing a template.

CC @Krinkle in case this is related to recent TemplateData changes?

Wed, Jan 16, 6:44 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates
Esanders added a project to T213922: VE removes all new lines when editing a template: Parsoid.
Wed, Jan 16, 6:38 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), User-notice, VisualEditor (Current work), Parsoid, VisualEditor-MediaWiki-Templates
Esanders added a comment to T135833: Implement browser compatibility detection in OOjs.

This was a while ago, and probably before we dropped ES3 support fully, so probably not as pressing now. I think I had in mind third party support so that users could avoid loading apps built with OO if the browser didn't support them.

Wed, Jan 16, 2:54 PM · OOjs

Tue, Jan 15

Esanders added a comment to T213199: Upstream Score's music icon to OOUI.

https://en.wikipedia.org/wiki/Beam_(music)#Positioning

Tue, Jan 15, 8:31 PM · OOUI (OOUI-0.30.2), Design
Esanders added a comment to T213199: Upstream Score's music icon to OOUI.

To clarify, the horizontal beam would require the notes to be at the same height, as the stem should be the same height:

Tue, Jan 15, 8:28 PM · OOUI (OOUI-0.30.2), Design
Esanders added a comment to T213429: Build Section Editing Prototype.
  • Performance - The load time feels exceptionally slow

The labs instances are generally going to be slower, this is not indicative of production, where it should be slightly faster than the existing system.

Tue, Jan 15, 2:40 PM · Editing Design , VisualEditor (Current work)

Mon, Jan 14

Esanders added a parent task for T53547: VisualEditor: Provide a "view VE" mode / disable editing for protected pages: T210142: Create an "inspect" mode for Visual Editor.
Mon, Jan 14, 6:01 PM · VisualEditor-MediaWiki-2017WikitextEditor, Design, VisualEditor, VisualEditor-MediaWiki
Esanders added a subtask for T210142: Create an "inspect" mode for Visual Editor: T53547: VisualEditor: Provide a "view VE" mode / disable editing for protected pages.
Mon, Jan 14, 6:01 PM · VisualEditor
Esanders added a comment to T210142: Create an "inspect" mode for Visual Editor.

Copied from my comment on T197075:

Mon, Jan 14, 5:59 PM · VisualEditor

Sat, Jan 12

Esanders created T213639: CSS classes should be prefixed.
Sat, Jan 12, 11:26 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Multimedia-Team-Working-Board, Multimedia, SDC Engineering
Esanders committed rEWBId370f22f771d: Create dependency on Wikibase extension (hackily) (authored by Esanders).
Create dependency on Wikibase extension (hackily)
Sat, Jan 12, 5:56 PM

Fri, Jan 11

Esanders added a comment to T209984: Isolate Section Editing: Determine New Workflows .

@Neil_P._Quinn_WMF Yeah I mentioned before some controls to change back to full editing after entering section editing, or load in additional sections one at a time. With the current implementation there would be a few changes necessary, and some UI work too.

Fri, Jan 11, 10:10 PM · Editing Design , VisualEditor
Esanders committed rEWBI0ce4913a08f5: build: Update eslint-config-wikimedia to 0.10.0 (authored by Esanders).
build: Update eslint-config-wikimedia to 0.10.0
Fri, Jan 11, 10:01 PM
Esanders committed rEWBI573cdc61183f: Remove 99% width hack (authored by Esanders).
Remove 99% width hack
Fri, Jan 11, 9:57 PM
Esanders added a comment to T204621: Reduce footprint of ext.3d on page initialisation.

Yeah

Fri, Jan 11, 7:35 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Multimedia, 3D, Performance-Team (Radar)
Esanders committed rETHR824126ba5c88: Fix selector to not check extension (authored by Esanders).
Fix selector to not check extension
Fri, Jan 11, 4:32 PM
Esanders committed rETHR8461b37b95b4: Fix thumbnail selector (authored by Esanders).
Fix thumbnail selector
Fri, Jan 11, 2:59 PM
Esanders committed rETHRa33ae9e8bbff: Fix selector to not check extension (authored by Esanders).
Fix selector to not check extension
Fri, Jan 11, 2:59 PM
Esanders committed rETHR7bce9af05a58: build: Update linters (authored by Esanders).
build: Update linters
Fri, Jan 11, 2:59 PM
Esanders added a comment to T209610: On mobile, template context menu doesn't show the name of the template.

Compare with the dialog, which doesn't show the word "Template" anywhere:

Fri, Jan 11, 2:41 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, VisualEditor-EditingTools
Esanders added a comment to T209610: On mobile, template context menu doesn't show the name of the template.

It would also be nice to show templatedata descriptions in the context when available. Our original designs had even more descriptive labels, which would probably require extra templatedata: https://commons.wikimedia.org/wiki/File:VisualEditor_context_designs_2015.png

Fri, Jan 11, 2:36 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, VisualEditor-EditingTools
Esanders added a comment to T209610: On mobile, template context menu doesn't show the name of the template.

I think the desktop version should have more verbose description, in some cases the template name itself could read like a message and so could be misleading without some context showing it is just a template name, e.g.


Fri, Jan 11, 2:27 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, VisualEditor-EditingTools
Esanders created T213539: Tags are case sensitive, but i18n message keys must be lowercase.
Fri, Jan 11, 12:49 PM · MediaWiki-extensions-WikimediaEvents, MediaWiki-Change-tagging

Thu, Jan 10

Esanders created T213468: Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded.
Thu, Jan 10, 6:59 PM · Patch-For-Review, Parsoid
Esanders added a comment to T213338: Toggling from VE to source to VE in MobileFrontend breaks.

The problem is not the hook, but the unnecessary addPlugin call, which runs every time the target is created. The second time it runs, it fires the hook immediately to catch up with previous calls, but the new target hasn't been activated yet.

Thu, Jan 10, 4:08 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, MobileFrontend, VisualEditor (Current work), MediaWiki-extensions-WikimediaEvents, Growth-Team (Current Sprint)
Esanders added a comment to T213279: mobile.special.watchlist.scripts/watchlist.js contains overly generic selectors.

A similar issue on uploads.js

if ( $( '.errorbox' ).length === 0 ) {
Thu, Jan 10, 2:54 PM · Need-volunteer, good first bug, Readers-Web-Backlog, Technical-Debt, MobileFrontend
Esanders added a comment to T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle.
$ mwgrep $.throttle
enwiki              MediaWiki:Gadget-ptoc.js
plwiktionary        MediaWiki:Gadget-persistent-toc.js
$ mwgrep $.debounce
commonswiki         MediaWiki:Gadget-catMoveLink.js
frwiki              MediaWiki:Gadget-CommonEdit.js
frwiki              MediaWiki:Gadget-ExternalSearch.js
Thu, Jan 10, 1:27 PM · Technical-Debt (Deprecation), Patch-For-Review, JavaScript, MediaWiki-General-or-Unknown
Esanders created T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle.
Thu, Jan 10, 1:21 PM · Technical-Debt (Deprecation), Patch-For-Review, JavaScript, MediaWiki-General-or-Unknown

Wed, Jan 9

Samwilson awarded T170263: Create a PHP fallback for SelectFileWidget a Like token.
Wed, Jan 9, 10:55 PM · OOUI
Esanders added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

@Ryasmeen can you provide a screenshot? Also details of the Android OS used.

Wed, Jan 9, 3:25 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders created T213279: mobile.special.watchlist.scripts/watchlist.js contains overly generic selectors.
Wed, Jan 9, 1:07 PM · Need-volunteer, good first bug, Readers-Web-Backlog, Technical-Debt, MobileFrontend

Tue, Jan 8

Esanders added a comment to T213199: Upstream Score's music icon to OOUI.

The right one is more acceptable, although it is still uncommon to use stems of different lengths. If you really want to avoid the diagonal beam, you can just put the notes at the same height.

Tue, Jan 8, 10:52 PM · OOUI (OOUI-0.30.2), Design
Esanders added a comment to T213199: Upstream Score's music icon to OOUI.

Where is the task for the most recent change (from the VE version to the OOUI version)?

Tue, Jan 8, 10:38 PM · OOUI (OOUI-0.30.2), Design
Esanders added a comment to T213199: Upstream Score's music icon to OOUI.

To anyone who reads musical notation (the target audience here), as opposed to basketball fans, this just looks wrong.

Tue, Jan 8, 10:37 PM · OOUI (OOUI-0.30.2), Design
Esanders created T213199: Upstream Score's music icon to OOUI.
Tue, Jan 8, 5:51 PM · OOUI (OOUI-0.30.2), Design
Esanders awarded T211325: CX2: Make version 2 the default a Like token.
Tue, Jan 8, 5:47 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Language-Team (Language-2019-January-March), ContentTranslation
Esanders added a comment to T210847: Resize the OOUI 'x` close icon?.

you should probably leave a link to this bug in the code, to prevent someone from "fixing" this in future

Tue, Jan 8, 5:42 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), OOUI (OOUI-0.30.1)
Esanders added a comment to T197701: CX2: Show publish settings as a dialog with more detailed descriptions.

The publish destination section will have an information icon that will open the corresponding documentation page in a new tab/window.

Tue, Jan 8, 12:56 PM · Language-Team (Language-2019-January-March), WorkType-NewFunctionality, ContentTranslation

Mon, Jan 7

Esanders created T213120: Restore section hash fragment after section editing in mobile VE.
Mon, Jan 7, 10:50 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Fri, Jan 4

Esanders added a comment to T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation).

So if I understand correctly, you would want something like this in the reference context menu:

Fri, Jan 4, 4:01 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-References

Thu, Jan 3

Esanders triaged T212458: VE Page settings option for indexing/non-indexing does not communicate to user when the option cannot be applied as Low priority.
Thu, Jan 3, 6:27 PM · VisualEditor-MediaWiki, VisualEditor
Esanders edited projects for T212458: VE Page settings option for indexing/non-indexing does not communicate to user when the option cannot be applied, added: VisualEditor-MediaWiki; removed VisualEditor-ContentEditable.
Thu, Jan 3, 6:27 PM · VisualEditor-MediaWiki, VisualEditor
Esanders claimed T212554: Visual editor source editing preview does not link to changed reference footnotes.
Thu, Jan 3, 5:09 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, VisualEditor (Current work)
Esanders moved T72266: Make the CAPTCHA more visible when saving from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Jan 3, 4:28 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), Patch-For-Review, Design, VisualEditor-MediaWiki
Esanders edited projects for T72266: Make the CAPTCHA more visible when saving, added: VisualEditor (Current work); removed TestMe, VisualEditor.
Thu, Jan 3, 4:28 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), Patch-For-Review, Design, VisualEditor-MediaWiki
Esanders added a comment to T72266: Make the CAPTCHA more visible when saving.
BeforeAfter
Thu, Jan 3, 4:27 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), Patch-For-Review, Design, VisualEditor-MediaWiki
Esanders updated subscribers of T209705: Dashboard EditSchema timing metrics.

So it looks like the Grafana dashboard only plots the 'activation' events, which have been disabled in mobile since 2015: T109525, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/242952/

Thu, Jan 3, 4:04 PM · Product-Analytics, VisualEditor (Current work)
Esanders moved T212809: [Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Jan 3, 3:14 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor-MediaWiki-Media, VisualEditor (Current work)
Esanders edited projects for T212809: [Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery, added: VisualEditor (Current work); removed VisualEditor.
Thu, Jan 3, 3:14 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor-MediaWiki-Media, VisualEditor (Current work)
Esanders claimed T212809: [Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery.
Thu, Jan 3, 3:14 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor-MediaWiki-Media, VisualEditor (Current work)
Esanders merged T212342: VisualEditor sometimes changes <references responsive> to <references responsive =""> into T101841: Value-less extension attributes not preserved.
Thu, Jan 3, 3:03 PM · Parsoid
Esanders merged task T212342: VisualEditor sometimes changes <references responsive> to <references responsive =""> into T101841: Value-less extension attributes not preserved.
Thu, Jan 3, 3:03 PM · Parsoid
Esanders removed a project from T212342: VisualEditor sometimes changes <references responsive> to <references responsive ="">: VisualEditor.

Parsoid round-trips <references responsive /> to <references responsive="" />, and in fact does this with all XML-style attributes probably by design.

Thu, Jan 3, 3:02 PM · Parsoid
Esanders added a project to T212342: VisualEditor sometimes changes <references responsive> to <references responsive ="">: Parsoid.
Thu, Jan 3, 2:59 PM · Parsoid
Esanders triaged T212743: Scroll can change when switching out temporary wikitext editor for full surface in NWE as Low priority.

We record the scroll offset and restore it when the temporary editor is replaced with the full editor. I'm not sure a lot can be done as the browser probably allows scrolling while blocking JS is running.

Thu, Jan 3, 2:58 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders renamed T212743: Scroll can change when switching out temporary wikitext editor for full surface in NWE from Do not move scroll position after page load to Scroll can change when switching out temporary wikitext editor for full surface in NWE.
Thu, Jan 3, 2:56 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders closed T212810: Make textarea focusable (even editable?) from the get-go as Invalid.

If it is matmarex describes then there is nothing to be done here.

Thu, Jan 3, 11:32 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T212790: OOUI workarounds required for search prototype.

Another thing: how do we deal with longer depicts input?
By default, OOUI's TagMultiselectWidget element expands down. Are we ok with that? If not, what do we want? (and this will probably incur a lot of work...)
And when all elements are in a horizontal layout, this also causes the other elements (dropdown, search icon) to drop slightly since they're middle-aligned (fixing that so that the other elements remain at the top should be a pretty easy override, though)

Thu, Jan 3, 10:48 AM · Multimedia, Multimedia-Team-Working-Board, SDC Engineering

Wed, Jan 2

Esanders added a comment to T208765: TemplateData module is loaded too often.

Yes

Wed, Jan 2, 5:29 PM · Performance-Team (Radar), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), TemplateData
Esanders moved T207325: Footnote weirdness after editing the title parameter from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Wed, Jan 2, 5:28 PM · Patch-For-Review, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), TemplateStyles
Esanders added a comment to T212790: OOUI workarounds required for search prototype.

The closest we have at the moment is ActionField, which has styles for combining text inputs and buttons, and dropdowns and buttons. There is no generic mechanism for combining widgets.

Wed, Jan 2, 5:23 PM · Multimedia, Multimedia-Team-Working-Board, SDC Engineering
Esanders updated subscribers of T207325: Footnote weirdness after editing the title parameter.

Regression was caused by moving renderHtmlAttributeList to initialize unconditionally in https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/195238/ (by @Catrope). I think for GeneratedContentNodes, we don't need to call renderHtmlAttributeList when updating.

Wed, Jan 2, 1:21 PM · Patch-For-Review, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), TemplateStyles

Sun, Dec 30

Esanders added a comment to T212607: Citoid not fully configured on huwiki.

This message need to be created, I think: https://hu.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json

Sun, Dec 30, 11:48 PM · Citoid
Esanders renamed T212607: Citoid not fully configured on huwiki from Integrate VisualEditor template dialog into cite dialog to Citoid not fully configured on huwiki.
Sun, Dec 30, 10:48 PM · Citoid
Esanders edited projects for T212607: Citoid not fully configured on huwiki, added: Citoid; removed VisualEditor, VisualEditor-MediaWiki-References.

Yes this is Citoid not being fully configured. Note also the manual tab is empty when creating a new citation.

Sun, Dec 30, 10:48 PM · Citoid
MGChecker awarded T203151: Consider adding a button to let users edit the whole page in MobileFrontend a Love token.
Sun, Dec 30, 10:43 PM · MobileFrontend, VisualEditor

Thu, Dec 27

Esanders added a comment to T212603: VisualEditor loses work when you leave an unsaved cite dialog.

After step 3 the only option is currently to insert. Can you give more detail reproduction steps?

Thu, Dec 27, 9:17 PM · VisualEditor
Esanders updated the task description for T212603: VisualEditor loses work when you leave an unsaved cite dialog.
Thu, Dec 27, 9:16 PM · VisualEditor

Wed, Dec 26

Esanders added a comment to T212607: Citoid not fully configured on huwiki.

Which wiki is this on? Citations that contain a single template should take you to the template editor instead, when the wiki is correctly configured.

Wed, Dec 26, 4:35 PM · Citoid

Mon, Dec 24

Esanders added a comment to T212575: Many cawiki users experience VisualEditor getting stuck during loading (due to local script).

Can you ask the affected users to open the developer console (F12) while loading the editor, to see if any errors are reported?

Mon, Dec 24, 1:52 PM · User-Ryasmeen, VisualEditor

Dec 18 2018

Esanders added a comment to T211154: Deprecate passing string IDs to OO.ui.infuse.

Fixed all on-wiki uses.

Dec 18 2018, 11:20 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), OOUI (OOUI-0.30.0)
Esanders added a comment to T211154: Deprecate passing string IDs to OO.ui.infuse.
mwgrep "\.infuse\("
commonswiki         MediaWiki:Gadget-advanced-search.js
dewiki              MediaWiki:Gadget-old-movepage.js
hewiki              MediaWiki:Nosaving.js
huwiki              MediaWiki:Gadget-QPreview.js
jawiki              MediaWiki:Common.js/titleChecker.js
jawiki              MediaWiki:Vector.js
plwiki              MediaWiki:Gadget-sk.js
plwikibooks         MediaWiki:Gadget-sk.js
plwikinews          MediaWiki:Gadget-sk.js

Not all of these will be passing string.

Dec 18 2018, 10:45 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), OOUI (OOUI-0.30.0)
Esanders added a comment to T150781: Click target for dropdown on ComboBoxInputWidget is tiny in Apex.

they are both handling clicks with different results

Dec 18 2018, 6:36 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), OOUI (OOUI-0.30.0)
Esanders added a comment to T150781: Click target for dropdown on ComboBoxInputWidget is tiny in Apex.

From gerrit:

Dec 18 2018, 6:34 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), OOUI (OOUI-0.30.0)
Esanders added a comment to T150781: Click target for dropdown on ComboBoxInputWidget is tiny in Apex.

I think there's an argument for not using the gradient styling on the button. DropdownWidgets in Apex have hover styling, are clickable, but have no shading:

wmuiapex
Dec 18 2018, 6:31 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), OOUI (OOUI-0.30.0)
Esanders awarded T206485: Set root: true in eslintrc.json a Cup of Joe token.
Dec 18 2018, 3:12 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Front-end-Standards-Group, MediaWiki-extensions-General

Dec 17 2018

Esanders added a comment to T209708: Catalogue where the MobileFrontend loading overlay is used.

Is there a way to bootstrap the loading of VE to get the first load smaller? Maybe by providing a minimal set of components to render the editing interface for typing without the toolbar? Many of the mobile overlays load quite slow these days (to the point beta cluster selenium tests timeout) and it would be great to find a way to make this less noticeable by improving performance rather than focusing on the UI portion of it.

Dec 17 2018, 6:29 PM · VisualEditor (Current work), Readers-Web-Backlog (Design), Design
Esanders updated the task description for T75972: Loading indicators / Progress indicators are inconsistent. .
Dec 17 2018, 6:18 PM · Design, WMF-Design, UI-Standardization, Contributors-Team
Esanders created T212146: Consider design of non-full-screen tab layouts (non-"framed").
Dec 17 2018, 6:10 PM · OOUI

Dec 15 2018

Esanders added a comment to T129546: Support preserving external links in pasted HTML content.

This isn't a priority for the team at the moment, but community patches are always welcome.

Dec 15 2018, 4:04 PM · VisualEditor, VisualEditor-CopyPaste

Dec 14 2018

Esanders added a comment to T210133: OOUI Documentation: ClippableElement: Fix typo in #$element.

Why is $element not a link? I note on https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.mixin.ClippableElement that $clippable and $clippableContainer are links. Shouldn't we be fixing $element to be a link, rather than unlinking it?

Dec 14 2018, 5:52 PM · OOUI
Esanders committed rEBOP532ef28beffe: build: Update eslint-config-wikimedia to 0.9.0 (authored by Esanders).
build: Update eslint-config-wikimedia to 0.9.0
Dec 14 2018, 4:36 PM