Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (24)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (407 w, 2 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders added a comment to T313636: Add space between talk page namespace and page title.

T306440 has been merged.

Wed, Aug 17, 9:29 AM · Patch-For-Review, TPP-Phase1, Goal, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020

Tue, Aug 16

Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804591/ has been merged, which means we can set expiry times on local storage items. Along with the above patch I think all the technical barriers to doing this have been lifted.

Tue, Aug 16, 3:23 PM · Patch-For-Review, Editing-team, DiscussionTools, VisualEditor, VisualEditor-MediaWiki
Esanders added a comment to T240041: wgPostEdit is not set/updated after editing with VE or 2017 wikitext editor.

The above patch partially resolves this issue by setting wgPostEdit when redirecting after save. As VE always redirects after save when creating a new page this should be sufficient for your use case @ifried, however wgPostEdit is still not set after edits to existing pages, so we should leave this task open.

Tue, Aug 16, 2:30 PM · Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T315320: Post edit notice not shown when editing an old revision ("The page has been restored").

The "created" notification was still working but only because undefined is falsey.

Tue, Aug 16, 2:22 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T240041: wgPostEdit is not set/updated after editing with VE or 2017 wikitext editor.

Actually that won't work for page creations because we redirect setting venotify. We can set wgPostEdit when that happens though, based on venotify...

Tue, Aug 16, 2:18 PM · Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T315320: Post edit notice not shown when editing an old revision ("The page has been restored").

Looks like I made a scope typo in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/791691/2/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js

Tue, Aug 16, 2:13 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor-MediaWiki, VisualEditor
Esanders updated subscribers of T315320: Post edit notice not shown when editing an old revision ("The page has been restored").
Tue, Aug 16, 2:05 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor-MediaWiki, VisualEditor
Esanders added a project to T315320: Post edit notice not shown when editing an old revision ("The page has been restored"): Regression.

There is code present to set venotify to restored so I assume this is just a regression.

Tue, Aug 16, 2:01 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor-MediaWiki, VisualEditor
Esanders created T315320: Post edit notice not shown when editing an old revision ("The page has been restored").
Tue, Aug 16, 2:00 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor-MediaWiki, VisualEditor
Esanders renamed T240041: wgPostEdit is not set/updated after editing with VE or 2017 wikitext editor from wgPostEdit does not work with VE or 2017 wikitext editor to wgPostEdit is not set/updated after editing with VE or 2017 wikitext editor.
Tue, Aug 16, 1:55 PM · Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T240041: wgPostEdit is not set/updated after editing with VE or 2017 wikitext editor.

We don't set wgPostEdit (that could probably be adding to jsconfigvars in ApiVisualEditorEdit.php), but when we fire the postEdit hook, the target still exists, so you can check if it's a new page by looking at ve.init.target.pageExists.

Tue, Aug 16, 1:55 PM · Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Mon, Aug 15

Esanders added a comment to T315222: New vector TOC not escape hash fragments and generating invalid URLs.

It's a regression from Vector classic

Mon, Aug 15, 1:33 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, MW-1.39-release, MediaWiki-Parser, Desktop Improvements
Esanders updated subscribers of T315222: New vector TOC not escape hash fragments and generating invalid URLs.

There are a few dozens test cases in parserTests.txt where the whole table of contents is asserted, checking things like this encoding issue and also deduplication of duplicate headings. I would suggesting making a Vector-2022 version of these tests.

Mon, Aug 15, 12:12 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, MW-1.39-release, MediaWiki-Parser, Desktop Improvements
Esanders created T315222: New vector TOC not escape hash fragments and generating invalid URLs.
Mon, Aug 15, 11:58 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, MW-1.39-release, MediaWiki-Parser, Desktop Improvements

Fri, Aug 12

Esanders added a comment to T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to.

Per my comment above I propose changing the current wording of the notification from:

  • Topic X was removed from page Y

to

  • Topic X was archived or removed from page Y
Fri, Aug 12, 2:42 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Patch-For-Review, DiscussionTools
Esanders added a comment to T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to.
  1. Is it possible to filter out/suppress/not notify people about discussions that are moved by bots? If so, how much complexity would implementing this add to this task?
Fri, Aug 12, 2:16 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Patch-For-Review, DiscussionTools
Esanders added a comment to T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to.

As part of this task, offer people the ability to elect to stop receiving notifications of this sort

Fri, Aug 12, 2:12 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Patch-For-Review, DiscussionTools
Esanders renamed T269954: Enable talk page topics to be collapsed and expanded on desktop from Enable talk page topics to be collapsed and expanded to Enable talk page topics to be collapsed and expanded on desktop.
Fri, Aug 12, 2:04 PM · Editing-team (Design Backlog), DiscussionTools, Editing Design

Thu, Aug 11

Esanders added a comment to T315037: subscribe button is on the way of differenrtly aligned content.

You can test the new heading with dtenable=1: https://fa.wikipedia.org/w/index.php?oldid=35343366&dtenable=1#A_report:_IP_Editing_Restriction_Study_on_Farsi_Wikipedia

Thu, Aug 11, 7:04 PM · Editing-team, DiscussionTools, I18n, RTL
Esanders added a comment to T314449: Reconsider the amount of whitespace between Topic Container and first comment (desktop).

I like the current amount of whitespace. The proposed spacing looks too tight, and it looks odd that the spacing between comments is equal or greater than the spacing between the comment area and the heading.

Thu, Aug 11, 4:55 PM · Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
Esanders added a comment to T262066: Make it possible to tell if Reply Tool is open from browser tab's name.

By typing part of the title in the browser's address bar, you can quickly switch to the tab. In Firefox, you can enter "reply" and the tab is shown - it works. But in Chrome, no results are shown for the "reply"; it will be shown if you enter part of the old title (for example, "patch") - is there any way to update the tab information for it too?

Thu, Aug 11, 4:49 PM · TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T314623: DiscussionTools appends emptystate banner on `action=parse`.

append the banner on the page after loading the parsed content

Thu, Aug 11, 3:27 PM · DiscussionTools
Esanders moved T314230: Adding a wikilink in basic reference shows overlay error from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Aug 11, 2:39 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a project to T315008: VisualEditor on Cantonese Wikipedia defaults to foreign keyword for "#REDIRECT": Parsoid.
Thu, Aug 11, 2:38 PM · Parsoid (Tracking), Wikimedia-Site-requests, VisualEditor, VisualEditor-ContentLanguage
Esanders added a comment to T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to.

I do not want to be notified when a discussion gets moved to an /Archive page. This is a normal and routine action. If you are an experienced editor, you will expect it; if you are an inexperienced editor, you may be confused by it (what's archiving?!). It does not deserve my attention. Just make the subscription keep working and don't bother me about it. Notifications are for things that need my attention, not for convincing me that the topic subscriptions software works.

Thu, Aug 11, 1:14 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Patch-For-Review, DiscussionTools

Wed, Aug 10

Esanders added a comment to T312963: Wikitext preview re-renders article preview at the wrong width.

Both are set to 60em, but one is at 16px font size and the preview is at 14px, hence the difference.

Wed, Aug 10, 4:47 PM · Community-Tech (CommTech-Sprint-31), MediaWiki-Page-editing, Desktop Improvements
Esanders added a comment to T311311: Visual refinements to page toolbar & VE toolbar.
  1. That should be removed in Vector 2022. I think in classic Vector it is to make the toolbar top border a continuous line.
  2. Not really, but I don't think there's a good way to prevent it. Setting overflow:hidden on the toolbar would probably cause many other problems.
Wed, Aug 10, 3:40 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
Esanders added a comment to T294162: Special:TopicSubscriptions: Make it easy for me to find conversation(s) I'm subscribed to.

The patch above adds "first subscribed" and "latest notification" dates to the table.

Wed, Aug 10, 12:47 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), TPP-Phase1, DiscussionTools

Tue, Aug 9

Esanders updated the task description for T296354: Ensure Topic Container code adheres to technical standards and best practices.
Tue, Aug 9, 5:26 PM · TPP-Phase1, Goal, Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders added a project to T294162: Special:TopicSubscriptions: Make it easy for me to find conversation(s) I'm subscribed to: TPP-Phase1.
Tue, Aug 9, 5:20 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), TPP-Phase1, DiscussionTools
Esanders added a project to T309752: Enable people to use Topic Containers to reveal the usernames of the people participating in a discussion : TPP-Phase1.
Tue, Aug 9, 5:20 PM · TPP-Phase1, Editing Design, DiscussionTools
ppelberg awarded T266401: Include users’ “signature name” in @-mention autocomplete a Like token.
Tue, Aug 9, 4:42 PM · Editing-team, DiscussionTools
Esanders added a comment to T266401: Include users’ “signature name” in @-mention autocomplete .

Decided with @ppelberg:

  • Not to display any display names in the default list when you first press '@'
  • If a search string matches a display name, then show any matches, example from task description: Search for "jame" would show "Jdforrester" as a match
Tue, Aug 9, 4:42 PM · Editing-team, DiscussionTools
Esanders added a comment to T266401: Include users’ “signature name” in @-mention autocomplete .

Testing extracting display names against our test corpus (which isn't very representative: it include a Village Pump (technical) snapshot, and some other talk pages from fr/ar/pl), I've tried to categorise the results so we can what type of things we would get by pulling in display names. I've excluded any results where the display name is a substring of the username.
Transliteration - these are "good" results and one of the big reasons we should try to support this

"Adil Faouzi -> عادل فوزي"
"Arvedui89 -> Aʀvєδuι"
"Azoee -> Azoée"
"Azoee -> azoée"
"Bander7799 -> بندر"
"Daxipedia -> Daxipedia - 達克斯百科"
"FShbib -> شبيب.."
"Mustafa -> مصطفى"
"Þjarkur -> Thjarkur"
"קיפודנחש -> קיפודנחש (aka kipod)"
// Removing some diacritics?
"شيماء -> شَيْمَاء"
Tue, Aug 9, 2:51 PM · Editing-team, DiscussionTools
Esanders moved T262066: Make it possible to tell if Reply Tool is open from browser tab's name from Incoming to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Aug 9, 2:16 PM · TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders claimed T262066: Make it possible to tell if Reply Tool is open from browser tab's name.
Tue, Aug 9, 2:15 PM · TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T262066: Make it possible to tell if Reply Tool is open from browser tab's name.

registered myself as a user

Tue, Aug 9, 2:15 PM · TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T262066: Make it possible to tell if Reply Tool is open from browser tab's name.

The patch above uses the messages:

  • Replying on <pagename>
  • Starting new topic on <pagename>
Tue, Aug 9, 2:12 PM · TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T36295: Allow full-width colon as namespace separator for consistency of page name texts.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/821353 would probably allow you do this with CSS. Care should be taken to support copying of the title with the original : so it can be used for linking.

Tue, Aug 9, 11:48 AM · MediaWiki-Internationalization

Sun, Aug 7

Esanders created T314744: Error on "Other Media" tab if UploadThumbnailRenderMap is not configured.
Sun, Aug 7, 9:23 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Structured-Data-Backlog (Current Work), SDAW-MediaSearch
Esanders created T314732: Height flicker when switching tabs.
Sun, Aug 7, 12:43 PM · SDAW-MediaSearch, Structured-Data-Backlog

Sat, Aug 6

Esanders added a comment to T314713: MediaSearch shouldn't depend on CirrusSearch and Elastica.
Sat, Aug 6, 11:03 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Structured-Data-Backlog (Current Work), SDAW-MediaSearch
Esanders added a comment to T314713: MediaSearch shouldn't depend on CirrusSearch and Elastica.

See https://github.com/MatmaRex/patchdemo/issues/487

Sat, Aug 6, 10:45 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Structured-Data-Backlog (Current Work), SDAW-MediaSearch
Esanders created T314713: MediaSearch shouldn't depend on CirrusSearch and Elastica.
Sat, Aug 6, 10:44 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Structured-Data-Backlog (Current Work), SDAW-MediaSearch
Esanders moved T314588: Launch visual diffs on history pages out of beta and provide it to all users from Incoming to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.
Sat, Aug 6, 1:40 PM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, MediaWiki-Page-history, VisualEditor, VisualEditor-VisualDiffs
Esanders added a project to T314588: Launch visual diffs on history pages out of beta and provide it to all users: Editing-team (FY2021-22 Kanban Board).
Sat, Aug 6, 1:39 PM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, MediaWiki-Page-history, VisualEditor, VisualEditor-VisualDiffs
Esanders triaged T314702: Invitation banner not always desired as Low priority.

The timezone format on that wiki was changed around 2015 (https://cs.wikipedia.org/wiki/Diskuse:Hlavn%C3%AD_strana/Archiv3). I believe we identified this issue when we were deploying the reply tool, and obviously it affects all tools. Our assumption is that the vast majority of conversations that old have been archived.

Sat, Aug 6, 1:32 PM · DiscussionTools

Fri, Aug 5

Esanders added a comment to T314623: DiscussionTools appends emptystate banner on `action=parse`.

I'm still unsure as to why something that's supposed to be part of the interface shows up on parsed HTML

This is also true of section edit links

Fri, Aug 5, 9:42 PM · DiscussionTools
Esanders added a comment to T314623: DiscussionTools appends emptystate banner on `action=parse`.

The use case being you have just edited a page and the banner should be shown. An editor like VE which updates the page dynamically does so by fetching the new page contents from action=parse, so this needs to return the full rendering of the page, including this banner.

Fri, Aug 5, 9:37 PM · DiscussionTools

Thu, Aug 4

Esanders added a comment to T314547: Prevent Start a discussion about from showing on certain pages.

Also doesn't show for me. The new topic buttons should not show on any pages with __NONEWSECTIONLINK__ such as this one. Do you have any gadgets enabled that could be causing this? What happens if you load the page in safemode (https://www.mediawiki.org/wiki/Manual:Safemode)?

Thu, Aug 4, 10:09 PM · Editing-team, DiscussionTools
Esanders added a comment to T314588: Launch visual diffs on history pages out of beta and provide it to all users.

NB this is just for history pages. Visual diffs have been enabled in VE by default for a long time. I agree this is pretty low risk, the default is still wikitext and this will just show a switcher in the top right.

Thu, Aug 4, 10:04 PM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, MediaWiki-Page-history, VisualEditor, VisualEditor-VisualDiffs
Esanders created T314573: Link to latest comment fails when header contains mix of encodable text and plain percent encoding.
Thu, Aug 4, 1:23 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Wed, Aug 3

Esanders moved T298371: Viewport overflow because of data-mw-comment-start/end from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Aug 3, 2:51 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing QA, Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders moved T298371: Viewport overflow because of data-mw-comment-start/end from Inbox to Low Priority on the Editing QA board.
Wed, Aug 3, 2:51 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing QA, Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders created T314488: Revise the appearance of the sticky header's "Add topic" button (activated state).
Wed, Aug 3, 2:13 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Design, DiscussionTools, Desktop Improvements
Esanders moved T314260: Reply links no longer showing on old revisions from Inbox to Low Priority on the Editing QA board.
Wed, Aug 3, 12:16 AM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, DiscussionTools
Esanders moved T314260: Reply links no longer showing on old revisions from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Aug 3, 12:16 AM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, DiscussionTools
Esanders added a comment to T273341: Topic permalinks: design and implement user experience .

Yes - just exposing the UI to create them.

Wed, Aug 3, 12:15 AM · TPP-Phase1, Design, Editing-team, DiscussionTools
Esanders triaged T314450: Pasting sentence ending in citation from different visual editor results in unexpected line break as Low priority.
Wed, Aug 3, 12:14 AM · VisualEditor-CopyPaste, VisualEditor

Tue, Aug 2

Esanders added a comment to T314349: Entirety of new topic not highlighted upon publishing.

The CommentParser will only consider content from the signature back to the next heading to be part of a comment. Sub headings are more often used to break up conversations than be part of a comment.

Tue, Aug 2, 8:29 PM · Editing-team, DiscussionTools
Esanders moved T307726: Add topic button should become disabled after click from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Aug 2, 1:19 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
Esanders added a comment to T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to.

Screenshot from Slack:

image.png (990×1 px, 139 KB)

Tue, Aug 2, 12:36 PM · Editing-team (FY2021-22 Kanban Board), TPP-Phase1, Patch-For-Review, DiscussionTools

Mon, Aug 1

Esanders added a comment to T313686: Clicking "Add link" on a selected work has UX issues.

The above three patches fix the three issues in the description respectively.

Mon, Aug 1, 3:43 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Unplanned-Sprint-Work, Language-Team (Language-2022-July-September), ContentTranslation
Esanders moved T298263: Abusefilter warnings do not always appear when using reply tool from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Mon, Aug 1, 12:32 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Editing-team (FY2021-22 Kanban Board), AbuseFilter, DiscussionTools
Esanders moved T298263: Abusefilter warnings do not always appear when using reply tool from Inbox to Low Priority on the Editing QA board.
Mon, Aug 1, 12:32 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Editing-team (FY2021-22 Kanban Board), AbuseFilter, DiscussionTools
Esanders moved T311760: Hide mobile lede section when DiscussionTools is enabled from Inbox to High Priority on the Editing QA board.
Mon, Aug 1, 12:30 PM · Verified, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders moved T311677: File caption in a gallery duplicated to alt= after being edited from Inbox to Low Priority on the Editing QA board.
Mon, Aug 1, 12:29 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure), VisualEditor, Parsoid
Esanders moved T312739: Unable to preview user page on mobile from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Mon, Aug 1, 12:29 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), MobileFrontend
Esanders moved T312599: Show the new topic empty state experience on pages which have templates, but no discussions from Inbox to High Priority on the Editing QA board.
Mon, Aug 1, 12:29 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Esanders moved T312739: Unable to preview user page on mobile from Inbox to Low Priority on the Editing QA board.
Mon, Aug 1, 12:29 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), MobileFrontend
Esanders claimed T314076: [Config Change] Make new Reply affordance styling available at mediawiki.org.
Mon, Aug 1, 12:17 PM · Verified, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
Esanders moved T314076: [Config Change] Make new Reply affordance styling available at mediawiki.org from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Mon, Aug 1, 12:17 PM · Verified, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
Esanders updated the task description for T314076: [Config Change] Make new Reply affordance styling available at mediawiki.org.
Mon, Aug 1, 12:17 PM · Verified, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

Sun, Jul 31

Esanders created T314260: Reply links no longer showing on old revisions.
Sun, Jul 31, 9:42 PM · Verified, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team (FY2021-22 Kanban Board), Regression, DiscussionTools

Sat, Jul 30

Esanders added a comment to T301929: Introduce new comment notifications within Reply Tool (mobile).

Since we fixed T301839 this can just be enabled on mobile.

Sat, Jul 30, 11:10 PM · TPP-Phase1, Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

Thu, Jul 28

Esanders added a comment to T313560: Ensure Topic Container metadata and section heading styling appear simultaneously.

This will ride the train next week, so on each day of the train (Group 0/1/2 Tue/Wed/Thu) we should do some sanity checking on a few wikis in each group, where we look at the main page and some random talk pages.

Thu, Jul 28, 5:26 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders added a comment to T312599: Show the new topic empty state experience on pages which have templates, but no discussions.

Thanks! Another observation I made: the message also appears on talk page redirects with ?redirect=no (e.g. https://de.wikipedia.org/w/index.php?title=Modul_Diskussion:Radsportplatzierungen&redirect=no). This should also be avoided IMO.

Good spot!

Thu, Jul 28, 1:48 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Esanders created T314048: Don't show "new section" / "add topic" tab on redirect pages.
Thu, Jul 28, 1:47 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), MediaWiki-Core-Skin-Architecture
Esanders added a comment to T312599: Show the new topic empty state experience on pages which have templates, but no discussions.

Thanks! Another observation I made: the message also appears on talk page redirects with ?redirect=no (e.g. https://de.wikipedia.org/w/index.php?title=Modul_Diskussion:Radsportplatzierungen&redirect=no). This should also be avoided IMO.

Thu, Jul 28, 1:30 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, DiscussionTools, Editing-team (FY2021-22 Kanban Board)

Wed, Jul 27

Esanders added a comment to T311405: Preview gives no indication that it is out of date.

When the Preview reloads, DISABLE or hide the toolbar:

Wed, Jul 27, 5:43 PM · Realtime Preview
Esanders moved T313560: Ensure Topic Container metadata and section heading styling appear simultaneously from Incoming to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 27, 4:28 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders claimed T313560: Ensure Topic Container metadata and section heading styling appear simultaneously.
Wed, Jul 27, 4:27 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders added a comment to T313804: Add ability to search Special:Preferences.

This is very cool! I'll definitely see if we can incorporate this into our mobile design if you move ahead with deploying for desktop.

Wed, Jul 27, 12:37 PM · Patch-For-Review, MediaWiki-Core-Preferences
Esanders added a comment to T313804: Add ability to search Special:Preferences.

image.png (1×1 px, 152 KB)

Wed, Jul 27, 12:28 PM · Patch-For-Review, MediaWiki-Core-Preferences

Tue, Jul 26

Jdlrobson awarded T313804: Add ability to search Special:Preferences a Love token.
Tue, Jul 26, 3:40 PM · Patch-For-Review, MediaWiki-Core-Preferences
Esanders added a comment to T311717: Display Special:Preferences as a vertical menu instead of tabs on mobile for AMC users.

See also T313804

Tue, Jul 26, 3:34 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), MinervaNeue, MediaWiki-Core-Preferences
Esanders added a comment to T313804: Add ability to search Special:Preferences.

https://patchdemo.wmflabs.org/wikis/e808299dc3/w/index.php?title=Special:UserLogin&returnto=Special%3APreferences&returntoquery=&warning=prefsnologintext2

Tue, Jul 26, 1:50 PM · Patch-For-Review, MediaWiki-Core-Preferences
Esanders moved T313801: Empty state not appearing on some DT-enabled mobile talk page views from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 26, 1:43 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders created T313804: Add ability to search Special:Preferences.
Tue, Jul 26, 1:30 PM · Patch-For-Review, MediaWiki-Core-Preferences
Esanders moved T313801: Empty state not appearing on some DT-enabled mobile talk page views from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 26, 12:55 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders moved T313801: Empty state not appearing on some DT-enabled mobile talk page views from Incoming to Doing on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 26, 12:41 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders created T313801: Empty state not appearing on some DT-enabled mobile talk page views.
Tue, Jul 26, 12:41 PM · Verified, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Sun, Jul 24

Esanders created T313686: Clicking "Add link" on a selected work has UX issues.
Sun, Jul 24, 12:59 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Unplanned-Sprint-Work, Language-Team (Language-2022-July-September), ContentTranslation
Esanders created T313685: Can't click on "Why?" link in "Translation services not available" warning.
Sun, Jul 24, 12:53 PM · ContentTranslation
Esanders renamed T298617: Unable to subscribe when there is no signature in section but a signature present in subsection from Ability to subscribe when no signature in section but signature present in subsection to Ability subscribing when there is no signature in section but a signature present in subsection.
Sun, Jul 24, 11:49 AM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools

Fri, Jul 22

Esanders moved T298617: Unable to subscribe when there is no signature in section but a signature present in subsection from Incoming to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Fri, Jul 22, 9:50 PM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a project to T298617: Unable to subscribe when there is no signature in section but a signature present in subsection: Editing-team (FY2021-22 Kanban Board).
Fri, Jul 22, 9:49 PM · Editing-team (FY2021-22 Kanban Board), Patch-For-Review, DiscussionTools
Esanders added a comment to T312140: Topic containers not handling sub headings (<h3+> correctly).

This patch ^ solves the topic container issue without addressing T298617.

Fri, Jul 22, 9:48 PM · Verified, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders added a comment to T312140: Topic containers not handling sub headings (<h3+> correctly).

From the patch:

Fri, Jul 22, 9:39 PM · Verified, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Esanders moved T304188: Enable sticky header on Talk pages from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Fri, Jul 22, 9:28 PM · Verified, Editing-team (FY2021-22 Kanban Board), Desktop Improvements, Editing Design, DiscussionTools