Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (246 w, 20 h)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders added a comment to T228118: A reflist under a section shows only the reference from the previous section and then suddenly expands to show the remaining upon pressing return.

I was unaware of this functionality, although I think in practice this is never done because it is really confusing (and a horrible feature). If multiple ref lists are used on a page, they are each given their own unique group.

Tue, Jul 16, 2:40 PM · VisualEditor
Esanders added a comment to T228165: Hide "options" bar under edit summary input when hidden.

In VE it would look like this:

Tue, Jul 16, 2:12 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T228165: Hide "options" bar under edit summary input when hidden.

An inline counter is used in old wikitext editor:


although that editor doesn't use a multi-line input, so they don't have the issue with the summary not wrapping.

Tue, Jul 16, 2:07 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T228165: Hide "options" bar under edit summary input when hidden.

I don' think this is for showing "progress" but rather for "warning" the user when they are about to run out of space, as we aren't encouraging very long edit summaries.

Tue, Jul 16, 2:03 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T227899: Error message should display when content in search field is in an unacceptable format.

"Enter a full URL, e.g. https://example.org"

Tue, Jul 16, 1:51 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Editing Design
Esanders moved T228165: Hide "options" bar under edit summary input when hidden from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Jul 16, 1:34 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T228165: Hide "options" bar under edit summary input when hidden, added: VisualEditor (Current work); removed VisualEditor.
Tue, Jul 16, 1:33 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders created T228165: Hide "options" bar under edit summary input when hidden.
Tue, Jul 16, 1:32 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T228096: No loading progress shown when switching from mobile wikitext to mobile VE.

Filed T228159 as follow up.

Tue, Jul 16, 12:56 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders created T228159: Improve loading progress appearance when loading MF, or switching from MF to VE.
Tue, Jul 16, 12:56 PM · Design, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T228096: No loading progress shown when switching from mobile wikitext to mobile VE.

We just fixed the regression, so it looks like it did before:

Tue, Jul 16, 12:20 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T227899: Error message should display when content in search field is in an unacceptable format.
Tue, Jul 16, 10:20 AM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Editing Design

Yesterday

Esanders added a comment to T227630: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience .

I can't reproduce this. I see the edit card after adding an external link on Android Chrome and iOS Safari.

Mon, Jul 15, 9:47 PM · VisualEditor-Edit Cards , VisualEditor
Esanders updated the task description for T228070: Ref list blanks after first transaction when section editing on mobile.
Mon, Jul 15, 9:13 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T228070: Ref list blanks after first transaction when section editing on mobile from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Mon, Jul 15, 9:11 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T228096: No loading progress shown when switching from mobile wikitext to mobile VE.
Mon, Jul 15, 7:46 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T228096: No loading progress shown when switching from mobile wikitext to mobile VE.

We didn't really design for this case, but I would guess showing the * Editor loading spinner would suffice.

Mon, Jul 15, 7:46 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders updated the task description for T228096: No loading progress shown when switching from mobile wikitext to mobile VE.
Mon, Jul 15, 7:41 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders created T228096: No loading progress shown when switching from mobile wikitext to mobile VE.
Mon, Jul 15, 7:38 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T227627: [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view.

It also looks like it might be related to some of @matmarex's iOS scrolling hacks?

Mon, Jul 15, 6:52 PM · VisualEditor-Edit Cards , VisualEditor
Esanders updated subscribers of T227628: [Pre-deployment bug] Scrolling the page when a link is selected resizes the edit card itself it seems..
Mon, Jul 15, 6:51 PM · VisualEditor-Edit Cards , VisualEditor
Esanders added a comment to T227628: [Pre-deployment bug] Scrolling the page when a link is selected resizes the edit card itself it seems..

This is correct behaviour as the bottom padding area is added to avoid having any links that would conflict with the bottom menu bar (clicking in that area just brings the menu bar up).

Mon, Jul 15, 6:50 PM · VisualEditor-Edit Cards , VisualEditor
Esanders added a comment to T227627: [Pre-deployment bug] While trying to change label for a link in Edit card V2 the page scrolls up making the link go out of view.

I could reproduce this on my iOS 9 device, but not my newer one. What version are you testing on?

Mon, Jul 15, 6:47 PM · VisualEditor-Edit Cards , VisualEditor
Esanders added a comment to T227897: Editing lede section in VE mobile loads the whole article.

Is it impossible to add a section editing button to the lede (option c) while also incorporating an Edit All button that only loads on click in the toolbar?

Mon, Jul 15, 6:40 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T227486: "No storage group configured for dev.wiki.local.wmftest.net" error running restbase under vagrant.

So config.example.yaml should be updated?

Mon, Jul 15, 4:12 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Workboards (Team 2), RESTBase, MediaWiki-Vagrant
Esanders added a comment to T215717: When section editing, do not build whole CE tree.

Testing second load times (i.e with the code and page data already fetched and cached), time to loaded was ~2300ms without the patch, and ~1300ms with.

Mon, Jul 15, 4:01 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders added a comment to T227894: [EPIC] User Testing Outcomes.

Add "globe" icon to external link search

Mon, Jul 15, 3:56 PM · VisualEditor-Edit Cards , Editing Design, VisualEditor (Current work)
Esanders removed a project from T227049: Workflow for reviewing your changes (diff) to type in the edit summary is annoying: Editing Design.
Mon, Jul 15, 3:51 PM · Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders moved T227049: Workflow for reviewing your changes (diff) to type in the edit summary is annoying from Design review to QA on the VisualEditor (Current work) board.
Mon, Jul 15, 3:50 PM · Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders updated subscribers of T228070: Ref list blanks after first transaction when section editing on mobile.
Mon, Jul 15, 3:49 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders created T228070: Ref list blanks after first transaction when section editing on mobile.
Mon, Jul 15, 3:35 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T227899: Error message should display when content in search field is in an unacceptable format.

As implemented:

Mon, Jul 15, 2:01 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Editing Design
Esanders added a comment to T227897: Editing lede section in VE mobile loads the whole article.

Is it impossible to add a section editing button to the lede (option c) while also incorporating an Edit All button that only loads on click in the toolbar?

Mon, Jul 15, 1:59 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T221299: Edit cards v2: conduct usertesting.com test.

Thanks for the analysis, sounds pretty successful overall.

Mon, Jul 15, 11:52 AM · Editing Design, VisualEditor (Current work)

Sat, Jul 13

Esanders added a comment to T215717: When section editing, do not build whole CE tree.

Here's how it will look after T215717 is fixed:


Here's the same graph without the intermediate step

Sat, Jul 13, 1:02 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

Here's how it will look after T215717 is fixed:

Sat, Jul 13, 1:01 PM · Performance-Team (Radar), Performance-Team-publish, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
Esanders added a comment to T215717: When section editing, do not build whole CE tree.

See also T206228

Sat, Jul 13, 12:37 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders added a comment to T215717: When section editing, do not build whole CE tree.

Monkey patched on live and edited a section of a long article (mobile site on desktop) (https://en.m.wikipedia.org/wiki/Megan_Rapinoe)

Sat, Jul 13, 12:35 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders updated subscribers of T227944: Section editing doesn't work on sections which are not children of the root, e.g. div-wrapped sections.
Sat, Jul 13, 12:14 PM · VisualEditor
Esanders created T227944: Section editing doesn't work on sections which are not children of the root, e.g. div-wrapped sections.
Sat, Jul 13, 10:50 AM · VisualEditor

Fri, Jul 12

Esanders claimed T215717: When section editing, do not build whole CE tree.
Fri, Jul 12, 11:53 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders added a comment to T227897: Editing lede section in VE mobile loads the whole article.

So here are the problems if we don't do this:

  • Our A/B test becomes less meaningful as we are comparing different experiences when the user presses the first edit button (which is probably a large percentage of users, if not a majority)
  • VE is given an unfair disadvantage in this A/B test as the full page takes so many times longer to load.
Fri, Jul 12, 7:20 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T227897: Editing lede section in VE mobile loads the whole article.
Fri, Jul 12, 6:04 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders triaged T227897: Editing lede section in VE mobile loads the whole article as High priority.
Fri, Jul 12, 3:44 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

I've just discovered this bug which is probably having a fairly big impact on performance: T227897. Basically the first edit pencil opens the editor for the whole page (it shouldn't) which is many times slower than just loading a section.

Fri, Jul 12, 3:43 PM · Patch-For-Review, Product-Analytics, VisualEditor (Current work)
Esanders created T227897: Editing lede section in VE mobile loads the whole article.
Fri, Jul 12, 3:42 PM · Editing QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari.

The drawback of this approach is that when there is nothing to scroll, Safari's menu bar is never minimized, and so we reduce the amount of screen space available for the dialog's contents (see screenshots below).

Fri, Jul 12, 3:29 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Browser-Support-Apple-Safari, OOUI
Esanders added a comment to T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari.

What are we doing differently in the VE save dialog, because if I view a long diff it scrolls fine?

Fri, Jul 12, 11:02 AM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Browser-Support-Apple-Safari, OOUI

Thu, Jul 11

Esanders added a comment to T227049: Workflow for reviewing your changes (diff) to type in the edit summary is annoying.

Clearly much better on mobile :)

Thu, Jul 11, 7:42 PM · Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders renamed T225021: Support a new "close" flag (distinct from "back") in OOUI dialogs from Distinguish "back" from "close" actions in OOUI dialogs to Support a new "close" flag (distinct from "back") in OOUI dialogs.
Thu, Jul 11, 7:14 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, OOUI (OOUI-0.33.0), VisualEditor (Current work)
Esanders added a comment to T225021: Support a new "close" flag (distinct from "back") in OOUI dialogs.

Can you update the screenshot with the correct icon ('previous')?

Thu, Jul 11, 6:20 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, OOUI (OOUI-0.33.0), VisualEditor (Current work)
Esanders added a comment to T227769: Never show the unswitchable welcome dialog.

Just as a note, it's totally incorrect to imply that the one-action dialog is not as it was designed.

Thu, Jul 11, 5:12 PM · VisualEditor (Current work), Patch-For-Review
Esanders added a project to T167047: Confusion between changes and revisions in visualisation: Design.
Thu, Jul 11, 3:31 PM · Design, Revision-Slider, TCB-Team
Esanders added a comment to T227769: Never show the unswitchable welcome dialog.

Does this seem sensible to you @ppelberg ?

Thu, Jul 11, 3:31 PM · VisualEditor (Current work), Patch-For-Review
Esanders added a comment to T167047: Confusion between changes and revisions in visualisation.

An example of the confusion on desktop:
Q: If I press show changes on this selection, will I see the 1 April change, the 3 April change, or both?


The answer is the 3 April change, but there is no way for the user to work this out, other than by trying.

Thu, Jul 11, 3:11 PM · Design, Revision-Slider, TCB-Team
Esanders added a comment to T167047: Confusion between changes and revisions in visualisation.

Hi @Esanders, right now the highlighting represents the versions that are being shown on the diff page. So they are the exact equivalents of the radio buttons you select on the diff page.

Yes the radio buttons on desktop suffer from the same problem.

Thu, Jul 11, 3:00 PM · Design, Revision-Slider, TCB-Team
Esanders updated subscribers of T167047: Confusion between changes and revisions in visualisation.

cc @cmadeo who is thinking about revision comparison on mobile apps.

Thu, Jul 11, 2:56 PM · Design, Revision-Slider, TCB-Team
Esanders updated subscribers of T227769: Never show the unswitchable welcome dialog.
Thu, Jul 11, 1:20 PM · VisualEditor (Current work), Patch-For-Review
Esanders created T227769: Never show the unswitchable welcome dialog.
Thu, Jul 11, 1:20 PM · VisualEditor (Current work), Patch-For-Review

Wed, Jul 10

Esanders reopened T226822: New dialog action design doesn't work well for labelled safe actions, a subtask of T226045: Improve process dialog appearance – simplify actions, as Open.
Wed, Jul 10, 8:36 PM · OOUI (OOUI-0.33.3), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Editing Design, Design
Esanders reopened T226822: New dialog action design doesn't work well for labelled safe actions as "Open".

If the action has a 'back' flag then it doesn't get the correct styling as it assumes the message will be converted to an icon, which it isn't on desktop (yet):

Wed, Jul 10, 8:36 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.1)
Esanders added a comment to T226045: Improve process dialog appearance – simplify actions.

The patch didn't switch all 'back' buttons to use an icon on desktop, which we may want to address is a future release?

Wed, Jul 10, 8:20 PM · OOUI (OOUI-0.33.3), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Editing Design, Design
Esanders created T227686: Investigate mapping PHP HTML to Parsoid HTML for talk page features.
Wed, Jul 10, 5:14 PM · VisualEditor
Esanders removed a project from T227655: VE drag-n-drop csv creates missing wikicode: VisualEditor.
Wed, Jul 10, 1:50 PM · Parsoid
Esanders closed T227655: VE drag-n-drop csv creates missing wikicode as Declined.

The first |- is not required in wikitext, and the examples in the documentation omit it: https://www.mediawiki.org/wiki/Help:Tables#Basics

Wed, Jul 10, 1:50 PM · Parsoid

Tue, Jul 9

Esanders added a comment to T206829: Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page.

The tricky part is figuring out how to adapt the styling of existing messages to the mobile interface.

Tue, Jul 9, 4:48 PM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, MobileFrontend, Mobile
Esanders claimed T227532: New edit cards obscure content at the bottom of the page.
Tue, Jul 9, 3:40 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T227532: New edit cards obscure content at the bottom of the page, added: VisualEditor (Current work); removed VisualEditor.
Tue, Jul 9, 3:40 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T220495: Content copied from Content Translation into Visual Editor exposes internal attributes.

The content can be cleaned up when copying and the converter has separate modes when generating HTML for Parsoid/Clipboard.

Tue, Jul 9, 3:39 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Language-Team (Language-2019-July-September), ContentTranslation
Esanders added a comment to T209266: CX2: Support for references added by name when the details are inside a template.

I'll try and get around to looking into this this week as I don't know the answer off the top of my head.

Tue, Jul 9, 3:12 PM · Language-Team (Language-2019-July-September), ContentTranslation

Mon, Jul 8

Esanders updated subscribers of T227532: New edit cards obscure content at the bottom of the page.

Cc @matmarex, we used to do something like this on iOS?

Mon, Jul 8, 10:23 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders created T227532: New edit cards obscure content at the bottom of the page.
Mon, Jul 8, 10:23 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
Esanders moved T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Jul 8, 11:56 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Esanders edited projects for T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters, added: VisualEditor (Current work); removed VisualEditor.
Mon, Jul 8, 11:56 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

Actually as this is a regression, we should probably take a look.

Mon, Jul 8, 11:46 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor

Fri, Jul 5

Esanders added a comment to T206309: CX2: Don't show reference details when they are not in the reference.

Replied on gerrit.

Fri, Jul 5, 2:13 PM · Language-Team (Language-2019-July-September), Patch-For-Review, ContentTranslation

Thu, Jul 4

Esanders created T227271: Dialog footers should be moved up on iOS when navigation menu isn't visible..
Thu, Jul 4, 11:35 AM · OOUI
Esanders moved T227216: Adding or editing citations using VisualEditor causes major formatting issues involving pipes, equals signs and nowiki tags from To Triage to External and Administrivia on the VisualEditor board.
Thu, Jul 4, 9:54 AM · User-Ryasmeen, Parsoid, VisualEditor

Wed, Jul 3

Esanders updated the task description for T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome).
Wed, Jul 3, 9:43 PM · VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders renamed T226780: Adding icons to dialog actions results in wrong padding from Adding icons to dialog actions results in wrong colour to Adding icons to dialog actions results in wrong padding.
Wed, Jul 3, 8:58 PM · OOUI (OOUI-0.33.3), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression
Esanders added a comment to T226780: Adding icons to dialog actions results in wrong padding.

The colour is now fixed, but the padding is still incorrect

Wed, Jul 3, 8:52 PM · OOUI (OOUI-0.33.3), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Regression
Esanders added a comment to T227040: Dialog title is neither centered nor left-aligned on mobile.

It looks like the centering code that adds inline padding styles to the title hasn't been disabled (or made desktop-only)

Wed, Jul 3, 7:14 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), OOUI (OOUI-0.33.2)
Esanders added a comment to T226822: New dialog action design doesn't work well for labelled safe actions.

After patch:


Wed, Jul 3, 7:12 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.1)
Esanders moved T221287: [Regression] Opening an existing gallery throws error "Uncaught TypeError: Cannot read property 'model' of undefined" from In progress to QA on the VisualEditor (Current work) board.
Wed, Jul 3, 5:14 PM · Verified, VisualEditor (Current work)
Esanders added a comment to T221287: [Regression] Opening an existing gallery throws error "Uncaught TypeError: Cannot read property 'model' of undefined".

Yeah - I think the error was just some debounced calculations happening on an old surface, so I think the try/catch fix is ok.

Wed, Jul 3, 5:14 PM · Verified, VisualEditor (Current work)
Esanders added a comment to T206829: Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page.

Looks like the original report is talking about "semi-protected" pages which are only uneditable by logged out users, so I've updated the title.

I wonder if it makes sense to consider both cases (protected & semi-protected) here? See T206829#5202751 in case you didn't already.

Wed, Jul 3, 5:04 PM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, MobileFrontend, Mobile
Esanders moved T96289: Fix the jump when opening the mobile context from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Wed, Jul 3, 2:31 PM · Editing QA, VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T96289: Fix the jump when opening the mobile context, added: VisualEditor (Current work); removed VisualEditor.

As we have deployed the new edit cards to bn/he/fa we can just QA them on those wikis?

Wed, Jul 3, 2:31 PM · Editing QA, VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
Esanders moved T136840: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome from Stalled/Waiting to QA on the VisualEditor (Current work) board.

As we have deployed the new edit cards to bn/he/fa we can just QA them on those wikis?

Wed, Jul 3, 2:30 PM · Editing QA, VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor-ContentEditable, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T206829: Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page.

Looks like the original report is talking about "semi-protected" pages which are only uneditable by logged out users, so I've updated the title.

Wed, Jul 3, 2:28 PM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, MobileFrontend, Mobile
Esanders renamed T206829: Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page from Lack of next steps for new users on mobile devices when attempting to edit a protected page to Lack of next steps for new users on mobile devices when attempting to edit a semi-protected page.
Wed, Jul 3, 2:27 PM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, MobileFrontend, Mobile
Esanders added a comment to T227189: Easy to accidentally launch the editor while expanding a section.

This is something I have personally stumbled on quite a few times, as a quickly open/close sections to see if they contain the information I need. It would be interesting to hear if anyone else has encountered this. Potentially we could do a small A/B test to see if expanding sections by default results in fewer editor launches (but the same number of editor completions).

Wed, Jul 3, 2:18 PM · Design, VisualEditor-MediaWiki-Mobile, VisualEditor, MobileFrontend
Restricted Application added a project to T227189: Easy to accidentally launch the editor while expanding a section: VisualEditor.
Wed, Jul 3, 11:22 AM · Design, VisualEditor-MediaWiki-Mobile, VisualEditor, MobileFrontend

Tue, Jul 2

Esanders awarded T226573: Graph edit completion rate over time a Like token.
Tue, Jul 2, 6:55 PM · VisualEditor, Product-Analytics
Esanders added a project to T226692: Add mw-disambig class to original content in VE: Parsoid.
Tue, Jul 2, 4:52 PM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator
Esanders added a comment to T226692: Add mw-disambig class to original content in VE.

I'm not actually seeing the disambig class in the Parsoid output: https://de.wikipedia.org/api/rest_v1/page/html/0/187176557

Tue, Jul 2, 4:51 PM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator

Mon, Jul 1

Esanders added a comment to T226045: Improve process dialog appearance – simplify actions.

We didn't stop users of OOUI to make frameless buttons primary so far, also I could imagine that there's use cases for exactly that as well.

Mon, Jul 1, 5:32 PM · OOUI (OOUI-0.33.3), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Editing Design, Design
Esanders added a comment to T226822: New dialog action design doesn't work well for labelled safe actions.

I will provide patches for the identified issues. In this case it's simple side borders/backgrounds around “safe” actions.

Mon, Jul 1, 5:10 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.1)
Esanders added a comment to T226168: Chemistry beaker icon should have open top.

Due to the fact that there seems to be two very distinct sets of values and backgrounds going into this discussion, I'd suggest that we utilize UserTesting.com to get feedback from a more general group of potential users.

Mon, Jul 1, 2:26 PM · Patch-For-Review, Design, OOUI
Esanders added a comment to T226168: Chemistry beaker icon should have open top.

I understand why on pure aesthetics the closed top looks better to a designer, but I would suggest you consult with the intended audience here as their experience may be different from your own. I have spoken to a few friends who studied chemistry all of whom agreed (although admittedly all from the same background as myself).

Mon, Jul 1, 1:37 PM · Patch-For-Review, Design, OOUI