Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (490 w, 14 h)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders added a comment to T360335: Alter "This has moved" popup font size.

The above patch uses the same variable as used in the other popup/dropdown menus (@font-size-dropdown). Presumably this will get migrated to the small/standard/large CSS variables when that switch happens.

Mon, Mar 18, 4:33 PM · Patch-For-Review, Desktop Improvements (Vector 2022), Web-Team-Backlog

Sat, Mar 16

Esanders added a comment to T360143: Suggested design changes to Popups.

given our plans for changing the font size,

Sat, Mar 16, 12:39 AM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Unplanned-Sprint-Work, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Desktop Improvements (Vector 2022)

Fri, Mar 15

IKhitron awarded T358250: Full screen dialogs are truncated by scrollbar gutter a Burninate token.
Fri, Mar 15, 12:31 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression

Thu, Mar 14

Esanders updated subscribers of T342831: Temporary Accounts: Update StructuredDiscussions (Flow).

See this commit message for why @Catrope left in "undelete" (and therefore "delete"): https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/415514

Thu, Mar 14, 10:50 PM · Growth-Team, StructuredDiscussions, IP-Masking-Growth-Team, Temporary accounts
Esanders added a comment to T342831: Temporary Accounts: Update StructuredDiscussions (Flow).

$wgFlowReadOnly still allows for deleting/undeleting content

Thu, Mar 14, 10:39 PM · Growth-Team, StructuredDiscussions, IP-Masking-Growth-Team, Temporary accounts
Esanders added a comment to T360143: Suggested design changes to Popups.

After:

image.png (157×389 px, 11 KB)

Thu, Mar 14, 6:53 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Unplanned-Sprint-Work, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Desktop Improvements (Vector 2022)
Esanders added a comment to T360143: Suggested design changes to Popups.

Also the font size should be 14px (for now): https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1011166

Thu, Mar 14, 6:52 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Unplanned-Sprint-Work, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Desktop Improvements (Vector 2022)
Esanders created T360143: Suggested design changes to Popups.
Thu, Mar 14, 6:42 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Unplanned-Sprint-Work, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Desktop Improvements (Vector 2022)
Esanders added a comment to T360026: Skip and then fix flapping reuseRefs tests.

To make tests more resilient in general we should:

  • Avoid looking for specific i18n messages
  • Add some CSS classes judiciously to make our selectors less fragile, e.g. by helping us avoid nth child selectors
Thu, Mar 14, 5:22 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), ci-test-error, WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, WMDE-TechWish-Sprint-2024-02-28, VisualEditor, WMDE-References-FocusArea, Cite
Esanders added a comment to T360084: Reload button appears on top of VE switcher menu.

There's a rule in CodeMirror (written by myself 5 years ago) that gives the toolbar a z-index of 7, so this is only broken when CodeMirror is not installed.

Thu, Mar 14, 12:04 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), VisualEditor, Realtime Preview

Wed, Mar 13

Esanders added a comment to T360084: Reload button appears on top of VE switcher menu.

This doesn't appear to happen consistently for me locally:

image.png (270×446 px, 30 KB)

Wed, Mar 13, 11:54 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), VisualEditor, Realtime Preview
Esanders closed T64933: Detect no-op transactions on objects as well as annotations as Resolved.

We don't have these transaction types anymore.

Wed, Mar 13, 8:31 PM · VisualEditor-DataModel, VisualEditor, Technical-Debt
Esanders closed T64933: Detect no-op transactions on objects as well as annotations, a subtask of T76546: Provide real-time collaborative editing in VisualEditor, as Resolved.
Wed, Mar 13, 8:30 PM · VisualEditor-EditingTools, VisualEditor
Esanders added a comment to T360063: ButtonGroupWidget/ButtonSelectWidget has different hover states to ToggleButtonGroup.

The same applies to ToggleButton (codex) vs ToggleButtonWidget (OOUI)

Wed, Mar 13, 7:23 PM · OOUI
Esanders created T360063: ButtonGroupWidget/ButtonSelectWidget has different hover states to ToggleButtonGroup.
Wed, Mar 13, 7:21 PM · OOUI
Esanders created T360061: Icons not quite aligned with headings in mobile Special:Preferences.
Wed, Mar 13, 7:06 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Core-Preferences
Esanders attached a referenced file: F42583741: image.png.
Wed, Mar 13, 4:21 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders attached a referenced file: F42583754: image.png.
Wed, Mar 13, 4:21 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders created T360045: Cursor not visible when edit notice shown on load.
Wed, Mar 13, 4:21 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor

Tue, Mar 12

Esanders updated the task description for T221967: Can't reliably gather list of annotation views from a DM offset.
Tue, Mar 12, 11:48 PM · VisualEditor-DataModel, VisualEditor
Esanders added a comment to T359815: Enable Visual Editor on Wikipedia namespace (hywik).

We want to avoid enabling VE on namespaces which contain discussions, such as the page you linked to (VE does not handle the indentation used in discussions very well). Are most pages in the Wikipedia: namespace on your wiki non-discussion content?

Tue, Mar 12, 1:04 AM · Wikimedia-Site-requests, VisualEditor
Esanders created T359893: Templates which only render categories are not visible.
Tue, Mar 12, 12:06 AM · Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor

Sun, Mar 10

Esanders added a comment to T359758: DiscussionTools: subscribe button is hidden behind collapsed sections.

The easier fix here is to avoid level 2 headings unless you are starting a new discussion , e.g. by using level 3 instead

Sun, Mar 10, 12:42 PM · DiscussionTools

Thu, Mar 7

Esanders claimed T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference.
Thu, Mar 7, 2:05 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
Esanders moved T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference from Incoming to Code Review on the Editing-team (Kanban Board) board.
Thu, Mar 7, 2:04 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
Esanders renamed T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference from Automatic reference to youtu.be gives "unreliable site" warning, doesn't let you insert reference to Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference.
Thu, Mar 7, 1:50 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
Esanders added a comment to T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference.

I also note that Citoid expands the shortened URL to youtube.com, which is allowed - but we do our validation on the inputted URL.

Thu, Mar 7, 1:30 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
Esanders added a comment to T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference.

The error message you get in the save dialog is a lot more verbose, and includes information about not using URL shorteners:

image.png (391×530 px, 62 KB)

Thu, Mar 7, 1:26 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
Esanders added a comment to T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference.
Thu, Mar 7, 1:23 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid

Wed, Mar 6

Esanders added a comment to T359489: Analyze initial permalink usage.

Will we prioritize making permalinks more discoverable at this time?

Wed, Mar 6, 9:42 PM · Product-Analytics, Editing-team (Tracking), DiscussionTools
Esanders updated the task description for T359489: Analyze initial permalink usage.
Wed, Mar 6, 9:41 PM · Product-Analytics, Editing-team (Tracking), DiscussionTools
Esanders renamed T359214: Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work from Non-English characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work to Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work.
Wed, Mar 6, 9:38 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), I18n, SyntaxHighlight
Esanders added a comment to T359214: Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work.

The code checks if the prefix is ctype_alpha in PHP. The check for generating the links doesn't include the ctype_alpha check.

Wed, Mar 6, 9:31 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), I18n, SyntaxHighlight

Tue, Mar 5

Esanders added a comment to T359182: Instrument permalink timestamps.

It'd be pretty easy to hook into the same code that's highlighting permalinked comments and log to that schema from there, if we want to track usage, too.

Tue, Mar 5, 9:57 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
Esanders claimed T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE.
Tue, Mar 5, 9:57 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
Esanders added a project to T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE: Editing-team (Kanban Board).
Tue, Mar 5, 9:55 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE.

This was a Codex regression, as the icon went from having padding to having margin.

Tue, Mar 5, 9:54 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
Esanders renamed T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE from Heading don't fully transition to the margin to Heading collapse button doesn't fully transition to the margin when opening mobile VE.
Tue, Mar 5, 9:51 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T359182: Instrument permalink timestamps.

Note that this doesn't measure if the permalink is used. We could perhaps track on-wiki usage by looking for #c- or #h- in wikitext diffs, but not off-wiki use:
https://en.wikipedia.org/w/index.php?search=insource%3A%2F%5C%23c%5C-%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns710=1&ns711=1&ns828=1&ns829=1

Tue, Mar 5, 3:31 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
Esanders created T359182: Instrument permalink timestamps.
Tue, Mar 5, 3:10 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
Esanders closed T302012: Define URL schema for talk page comment and discussion URLs, a subtask of T302011: [Release Ticket] Introduce permalinks on wikitext talk pages, as Resolved.
Tue, Mar 5, 3:05 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Esanders closed T302012: Define URL schema for talk page comment and discussion URLs, a subtask of T304578: Enable iOS and Android apps to implement talk page topic and comment permalinking, as Resolved.
Tue, Mar 5, 3:05 PM · DiscussionTools
Esanders closed T302012: Define URL schema for talk page comment and discussion URLs as Resolved.
Tue, Mar 5, 3:05 PM · Editing-team (Kanban Board), TPP-Phase1, Design, DiscussionTools
Esanders added a comment to T358250: Full screen dialogs are truncated by scrollbar gutter.

Given the age of those issues we shouldn't expect them to be fixed any time soon.

Tue, Mar 5, 1:27 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
Esanders updated subscribers of T359143: Signatures containing score are not recognized by DiscussionTools.
Tue, Mar 5, 9:46 AM · DiscussionTools, MediaWiki-extensions-Score
Esanders triaged T359143: Signatures containing score are not recognized by DiscussionTools as Low priority.

Anything that generates block level HTML should be disallowed in a signature, if not automatically by our signature validator, then by policy.

Tue, Mar 5, 9:44 AM · DiscussionTools, MediaWiki-extensions-Score

Mon, Mar 4

Esanders moved T349261: Introduce an API to enable editing interfaces to offer feedback about reference reliability from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.

The initial API has been implemented, it returns "blocked" or "allowed" for a given URL based on MediaWiki:Spam-blacklist and MediaWiki:BlockedExternalDomains.json.

Mon, Mar 4, 5:35 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), SpamBlacklist, Editing-team (Kanban Board), Community-Wishlist-Survey-2023, EditCheck, VisualEditor
Esanders renamed T358973: VisualEditor renders empty table rows (rows with no cells) from VisualEditor inserts shows extra empty in table to VisualEditor renders empty table rows (rows with no cells).
Mon, Mar 4, 5:27 PM · Parsoid (Tracking), VisualEditor, VisualEditor-Tables
Esanders added a project to T358973: VisualEditor renders empty table rows (rows with no cells): Parsoid.
Mon, Mar 4, 5:27 PM · Parsoid (Tracking), VisualEditor, VisualEditor-Tables
Esanders added a comment to T262093: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps (allow more flexibility in lead paragraph identification).

If this rewrites identifyInfoboxElement, please make the class name infobox configurable.

The French wiki hasn't been able to use this feature (and Mobile Page Issues, for the same reason ) because that class name causes problems there.

Mon, Mar 4, 10:25 AM · Web-Team-Backlog, User-notice, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MobileFrontend
Esanders added a comment to T310544: Ensure MobileFrontend works with Parsoid read views for discussion tools.

See also T262093.

Mon, Mar 4, 8:26 AM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Editing-team (Tracking), Parsing-Active-Work, DiscussionTools, Parsoid
Esanders added a comment to T358981: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled.

I think T262093 would help with the infobox issue.

Mon, Mar 4, 8:26 AM · Parsoid (Tracking), DiscussionTools, MobileFrontend, Parsoid-Read-Views

Sat, Mar 2

Esanders updated the task description for T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE.
Sat, Mar 2, 9:04 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
Esanders created T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE.
Sat, Mar 2, 9:03 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile

Fri, Mar 1

Esanders closed T310217: Evaluate usage of the "Read as as wiki page" mobile talk page view, a subtask of T280417: Converge on a single mobile talk page view, as Resolved.
Fri, Mar 1, 12:25 PM · Verified, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Editing-team (Kanban Board), DiscussionTools
Esanders closed T310217: Evaluate usage of the "Read as as wiki page" mobile talk page view as Resolved.
Fri, Mar 1, 12:25 PM · Editing-team (Kanban Board), DiscussionTools
Esanders closed T354847: Citoid: Move 'insert' button to inspector header when only one result is presented, a subtask of T352134: Build reference reliability check MVP (mobile + desktop), as Resolved.
Fri, Mar 1, 12:25 PM · Verified, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T354847: Citoid: Move 'insert' button to inspector header when only one result is presented as Resolved.
Fri, Mar 1, 12:25 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Verified, Citoid, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders added a comment to T354847: Citoid: Move 'insert' button to inspector header when only one result is presented.

I'm not sure this needs a tech news announcement, but if you want:
Usability improvements to the "Add a citation" workflow: Moved the "Insert" button to the popup header.

Fri, Mar 1, 12:05 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Verified, Citoid, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders added a project to T358839: logo is covered by search bar on mobile : Wikimedia-Portals.
Fri, Mar 1, 9:50 AM · Wikimedia-Portals, Regression, Web-Team-Backlog
Esanders edited projects for T358839: logo is covered by search bar on mobile , added: Web-Team-Backlog, Regression; removed MobileFrontend.
Fri, Mar 1, 9:44 AM · Wikimedia-Portals, Regression, Web-Team-Backlog

Thu, Feb 29

Esanders closed T71888: <source lang="sql"> breaks with # in the query and output is not nicely formatted as Declined.

The highlighter is for formatting SQL syntax only, not an interactive SQL command prompt. Such a request could be made upstream.

Thu, Feb 29, 4:03 PM · SyntaxHighlight

Wed, Feb 28

Esanders added a comment to T356858: Create a first set of end to end test for reference re-use in VE.

Note that there are existing selenium-webdriver test in VE-MW (in tests/selenium and build/screenshots.js), and some existing infrastructure (the wdio-mediawiki package). If there are good reasons to use another platform (the patch above uses cypress), then the case for that should be documented and a plan made to make sure all VE browser tests use the same technology, where possible, to reduce maintenance burden.

Wed, Feb 28, 1:27 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, VisualEditor, WMDE-References-FocusArea, Cite

Tue, Feb 27

Esanders added a comment to T224429: Hunt and remove unused i18n messages in mediawiki core.

oldpassword seems unused since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/280945

Tue, Feb 27, 6:40 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), translatewiki.net, Wikimania-Hackathon-2019, I18n, MediaWiki-Internationalization
Esanders added a comment to T341845: Delete edit recovery data when logging out.

What about a prompt on logout? e.g. "You have unsaved edits for recovery — do you want to keep these?"

Tue, Feb 27, 2:56 PM · Patch-For-Review, Community-Tech (CommTech-Kanban), Edit Recovery

Mon, Feb 26

Esanders added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

On the subject of inverting colours, it is worth noting that while we try to uninvert colours of photographs with mw-no-invert, due to the way CSS hue transforms are calculated this always results in some distortion of the colours[1][2]. While this is subtle and acceptable for photographs, it is not really acceptable for instances where the colour is the information, e.g. on https://en.wikipedia.org/wiki/Pantone#Color_of_the_Year:

Mon, Feb 26, 6:00 PM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface

Sun, Feb 25

Esanders added a comment to T358261: Mobile VisualEditor inspectors have scrolling glitches on iOS.

If it isn't toolbar hacks causing it, we could just reset the page scroll to 0 while full screen dialogs are open.

Sun, Feb 25, 8:50 AM · Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T358261: Mobile VisualEditor inspectors have scrolling glitches on iOS.

Interestingly, this only happens when the page beneath the dialog is *not* scrolled to the top, so I suspect some of our scrolling hacks for the page toolbar are kicking in in dialog mode, which might be a simple fix...

Sun, Feb 25, 8:41 AM · Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor

Fri, Feb 23

Esanders merged T358353: {{subst:}} inside <ref> not expanded into T4700: Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, status indicators, pipe trick, subst, signatures).
Fri, Feb 23, 3:46 PM · Patch-For-Review, Cite, Epic, MediaWiki-Parser
Esanders merged task T358353: {{subst:}} inside <ref> not expanded into T4700: Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, status indicators, pipe trick, subst, signatures).
Fri, Feb 23, 3:44 PM · VisualEditor, Parsoid
Esanders created T358353: {{subst:}} inside <ref> not expanded.
Fri, Feb 23, 3:41 PM · VisualEditor, Parsoid
Esanders created T358347: SonarQube Bot suggestion for unused parameter is unhelpful.
Fri, Feb 23, 3:10 PM · SonarQube Bot
Esanders added a comment to T358316: Changing timestamps on a page creates regenerates New topics notifications.

We could probably be more vandalism resistant by limiting the number of new topics we detect per edit. Although there may be legitimate case where this happens, e.g. a handful of discussions being moved to a more relevant page.
It just depends which edge case you want to design for...

Fri, Feb 23, 1:09 PM · DiscussionTools, Notifications, Growth-Team

Thu, Feb 22

Esanders added a comment to T354847: Citoid: Move 'insert' button to inspector header when only one result is presented.

+1 unless @nayoub disagrees

Thu, Feb 22, 6:55 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Verified, Citoid, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T356983: Gallery node not highlighted after closing gallery dialog as Resolved.
Thu, Feb 22, 6:53 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), VisualEditor-MediaWiki, Editing-team (Kanban Board), VisualEditor
Esanders closed T356131: Discussion permalink links to a page with transclusions that doesn't actually show the comment as Resolved.
Thu, Feb 22, 6:52 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), DiscussionTools
Esanders closed T355865: Help popup button attached to FieldsetLayout has incorrect click target as Resolved.
Thu, Feb 22, 6:52 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Editing-team (Kanban Board), VisualEditor, OOUI
Esanders renamed T358248: Lists have too much spacing in VE from List have too much spacing in VE to Lists have too much spacing in VE.
Thu, Feb 22, 6:50 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Desktop Improvements (Vector 2022), Editing-team (Kanban Board), Regression
Esanders updated the task description for T358258: Can't set label for external link on mobile.
Thu, Feb 22, 5:42 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders updated the task description for T358258: Can't set label for external link on mobile.
Thu, Feb 22, 5:41 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders edited projects for T358258: Can't set label for external link on mobile, added: VisualEditor-MediaWiki-Links; removed VisualEditor-Links.
Thu, Feb 22, 5:28 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders created T358258: Can't set label for external link on mobile.
Thu, Feb 22, 5:28 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders updated the task description for T358252: Codex CSS buttons in mobile editor have uneven vertical padding.
Thu, Feb 22, 5:12 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Codex, Design-System-Team, Regression
Esanders updated the task description for T358252: Codex CSS buttons in mobile editor have uneven vertical padding.
Thu, Feb 22, 5:11 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Codex, Design-System-Team, Regression
Esanders created T358252: Codex CSS buttons in mobile editor have uneven vertical padding.
Thu, Feb 22, 5:09 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Codex, Design-System-Team, Regression
Esanders added a comment to T358250: Full screen dialogs are truncated by scrollbar gutter.

This issue only appears to affect Chrome. Firefox works fine.

Thu, Feb 22, 5:05 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
Esanders added a comment to T358250: Full screen dialogs are truncated by scrollbar gutter.

Real world example of full screen dialogs is the kartographer extension:
https://en.wikipedia.org/wiki/Golden_Gate_Bridge#/map/0

Thu, Feb 22, 5:04 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
Esanders created T358250: Full screen dialogs are truncated by scrollbar gutter.
Thu, Feb 22, 5:00 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
Esanders updated the task description for T358248: Lists have too much spacing in VE.
Thu, Feb 22, 4:54 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Desktop Improvements (Vector 2022), Editing-team (Kanban Board), Regression
Esanders moved T358248: Lists have too much spacing in VE from Incoming to Code Review on the Editing-team (Kanban Board) board.
Thu, Feb 22, 4:54 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Desktop Improvements (Vector 2022), Editing-team (Kanban Board), Regression
Esanders created T358248: Lists have too much spacing in VE.
Thu, Feb 22, 4:53 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Desktop Improvements (Vector 2022), Editing-team (Kanban Board), Regression

Mon, Feb 19

Esanders triaged T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project) as Unbreak Now! priority.
Mon, Feb 19, 6:45 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, DiscussionTools, MediaWiki-General, Regression
Esanders created T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project).
Mon, Feb 19, 6:44 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, DiscussionTools, MediaWiki-General, Regression
Esanders added a comment to T273341: Topic permalinks: design and implement user experience .

As noted above, topic permalinks, which begin #h- are already implemented and work, they just aren't exposed in the UI anywhere:

Mon, Feb 19, 6:39 PM · Editing-team, Goal, TPP-Phase1, Design, DiscussionTools
Esanders merged T357927: [permalinks] Provide a permalink for an entire section into T273341: Topic permalinks: design and implement user experience .
Mon, Feb 19, 6:35 PM · Editing-team, Goal, TPP-Phase1, Design, DiscussionTools
Esanders merged task T357927: [permalinks] Provide a permalink for an entire section into T273341: Topic permalinks: design and implement user experience .
Mon, Feb 19, 6:35 PM · DiscussionTools
Esanders reopened T273341: Topic permalinks: design and implement user experience , a subtask of T302011: [Release Ticket] Introduce permalinks on wikitext talk pages, as Open.
Mon, Feb 19, 6:34 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Esanders reopened T273341: Topic permalinks: design and implement user experience as "Open".

Reason: to start [i], the user experience for generating a permanent link to a comment and topic will be one and the same...

Mon, Feb 19, 6:34 PM · Editing-team, Goal, TPP-Phase1, Design, DiscussionTools
Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

... Is there anything we can do for in that project that'd help you with VE's autosave? (I'm assuming it can't use the same stored data because the structure is different and VE needs much more info to be stored) ...

Mon, Feb 19, 3:43 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), VisualEditor, VisualEditor-MediaWiki

Feb 13 2024

Esanders added a comment to T347209: Investigate: Grey background for temporary usernames in signatures, mentions etc.

In T325768, the appearance was specified for temp user links in history pages, which adds 2px/8px padding, and this was implemented in the .mw-tempuserlink class as the default.

Feb 13 2024, 7:06 PM · Patch-For-Review, Temporary accounts