Esanders (Ed Sanders)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (142 w, 6 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF)

Recent Activity

Sat, Jul 22

Esanders created T171387: Recent change date range popup usability issues.
Sat, Jul 22, 6:09 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Jul 21

Esanders added a comment to T161054: Investigation: CodeMirror + New WikiText Editor performance issues.

Given Marijn's response on https://github.com/codemirror/CodeMirror/issues/4076 I don't think viewport optimisation is a realistic goal.

Fri, Jul 21, 6:22 PM · Community-Tech-Sprint, Performance, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
Esanders added a comment to T171276: Impossible to split a list.

I think that's how most editors do it as well.

Fri, Jul 21, 3:05 PM · VisualEditor
Esanders added a comment to T161054: Investigation: CodeMirror + New WikiText Editor performance issues.

My main concerns are not with load times, as they should be comparable to VE (slightly faster), but without the viewport optimisation every keystroke can trigger a full document re-rerender which makes typing sluggish on long articles (e.g. Obama).

Fri, Jul 21, 12:27 PM · Community-Tech-Sprint, Performance, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
Esanders created T171296: Everything vertically misaligned in Apex's TextInputWidget.
Fri, Jul 21, 11:07 AM · OOjs-UI
Esanders created T171292: Refactor and upstream Education Popups.
Fri, Jul 21, 10:56 AM · OOjs-UI, VisualEditor

Thu, Jul 20

Esanders added a comment to T171201: Make 'monospace' the default font for the wikitext editor.

This is still a fairly big change for a large percentage of users, so will need some announcing if we proceed.

Thu, Jul 20, 8:02 PM · MediaWiki-User-preferences, Patch-For-Review, User-notice, MediaWiki-Page-editing, Design, WikiEditor, VisualEditor
Esanders added a comment to T171201: Make 'monospace' the default font for the wikitext editor.

Yeah, that would be the next logical step, but I didn't mention it here to limit the scope.

Thu, Jul 20, 7:03 PM · MediaWiki-User-preferences, Patch-For-Review, User-notice, MediaWiki-Page-editing, Design, WikiEditor, VisualEditor
Esanders added a comment to T171181: Review and fix Wikipedia logos on mobile site.

As this is quite a long list, wouldn't it be better to switch to a text logo by default (when sitename !== 'Wikipedia'), and then add SVG versions incrementally?

Thu, Jul 20, 6:23 PM · Reading-Web-Backlog, Wikimedia-Site-requests
Esanders added a project to T171201: Make 'monospace' the default font for the wikitext editor: Design.
Thu, Jul 20, 6:01 PM · MediaWiki-User-preferences, Patch-For-Review, User-notice, MediaWiki-Page-editing, Design, WikiEditor, VisualEditor
Esanders created T171201: Make 'monospace' the default font for the wikitext editor.
Thu, Jul 20, 6:00 PM · MediaWiki-User-preferences, Patch-For-Review, User-notice, MediaWiki-Page-editing, Design, WikiEditor, VisualEditor
Esanders updated the task description for T170263: Create a PHP fallback for SelectFileWidget.
Thu, Jul 20, 5:08 PM · OOjs-UI
Esanders updated subscribers of T170263: Create a PHP fallback for SelectFileWidget.
Thu, Jul 20, 5:07 PM · OOjs-UI
Esanders added a comment to T162010: Use text for project name instead of generic logos.

Going by a site config file for site name, it's 86 logos over 127 wikis:

Thu, Jul 20, 9:44 AM · Patch-For-Review, Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Wikimedia-Site-requests, I18n, MobileFrontend, Reading-Web-Backlog
Esanders added a comment to T162010: Use text for project name instead of generic logos.

Just looking at https://meta.wikimedia.org/wiki/List_of_Wikipedias there are probably over 100 wikis not using the Latin script, we only have 7 logos. There are also many Latin logos that aren't simply Wikipedia that we don't have.

Thu, Jul 20, 9:34 AM · Patch-For-Review, Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Wikimedia-Site-requests, I18n, MobileFrontend, Reading-Web-Backlog

Wed, Jul 19

Esanders added a comment to T162010: Use text for project name instead of generic logos.

Why is the fallback for Wikipedia to use the English logo? Surely the local name as text would be better there too?

Wed, Jul 19, 10:33 PM · Patch-For-Review, Unplanned-Sprint-Work, Reading-Web-Kanban-Board, Wikimedia-Site-requests, I18n, MobileFrontend, Reading-Web-Backlog
Esanders added a comment to T170382: [NWE + CodeMirror] Syntaxhighlighting and actual text out of sync for some special characters.

I believe so

Wed, Jul 19, 9:46 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
Esanders added a comment to T171062: Unknown dependency: mobile.site when trying to use Minerva on desktop.

Thanks. I commented out mobile.site to test, and the next exception thrown is on this line in skins.minerva.editor/init.js

Wed, Jul 19, 4:23 PM · Reading-Web-Backlog, MobileFrontend, MinervaNeue (Desktop)
Esanders added a comment to T171062: Unknown dependency: mobile.site when trying to use Minerva on desktop.

Should mobile.site load for all skins and all MF pages, or just Minerva?

Wed, Jul 19, 3:59 PM · Reading-Web-Backlog, MobileFrontend, MinervaNeue (Desktop)
Esanders added a comment to T171000: [Epic] Remove MobileFrontend dependency from Minerva.

Why do I get Error: Unknown dependency: mobile.site when trying to use Minerva on desktop?

Wed, Jul 19, 2:03 PM · Epic, MinervaNeue (Desktop)
Esanders created T171055: Ellipsis not indented correctly in reference list diffs.
Wed, Jul 19, 1:31 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, User-Ryasmeen, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T169398: In visual diff, parameter changes to templates inside references are shown out of place.

We have a bunch of reverse loops due to how the tree diff is calculated. It looks like reference changes aren't adding sidebar items in the correct order.

Wed, Jul 19, 12:55 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T132848: Stop jumping all the way to the beginning of the wikicode when the user starts typing.

If the user is talking about wikicode, why is this tagged with VE?

Wed, Jul 19, 12:24 PM · VisualEditor, Contributors-Team, MobileFrontend, Mobile, Accessibility, Regression
Esanders added a comment to T170746: VisualEditor Error on Insert menu.

Also make sure you have the latest version of lib/ve that goes with your VE extension (use git submodule update). It looks like they may be out of sync.

Wed, Jul 19, 11:54 AM · User-Ryasmeen, VisualEditor-Media, VisualEditor
Esanders removed a project from T170999: AceEditor doesn't understand media queries: VisualEditor.
Wed, Jul 19, 11:50 AM · CodeEditor, Upstream
Esanders added a comment to T170999: AceEditor doesn't understand media queries.

This is an upstream issue with Ace.

Wed, Jul 19, 11:50 AM · CodeEditor, Upstream

Tue, Jul 18

Esanders added a comment to T170896: Using Hotcat after saving with visual editor tries to edit old version.

Fixed with https://commons.wikimedia.org/w/index.php?title=MediaWiki%3AGadget-HotCat.js&type=revision&diff=252283079&oldid=245282108

Tue, Jul 18, 9:14 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T170896: Using Hotcat after saving with visual editor tries to edit old version.

The bug appears to be in HotCat - it uses wgCurRevisionId, but it makes a local copy of mw config: conf = mw.config.get() so even though VE updates wgCurRevisionId, HotCat doesn't see it.

Tue, Jul 18, 8:59 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T170235: Visual diff (on history page) shows changes to reference numbers caused by inserting more references.

Just to be clear, this behaviour should not be happening and should go away once T170269 is fixed. I think if we are to discuss changes to the reference diff display it should be starting from the feature as it is correctly working correctly in VE, otherwise things are going to get very confusing :)

Tue, Jul 18, 4:41 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders committed rERSL092e5639c689: Use core wgDiffOldId/wgDiffNewId JS config values (authored by Esanders).
Use core wgDiffOldId/wgDiffNewId JS config values
Tue, Jul 18, 3:54 PM
Esanders added a comment to T170919: Insert menu scrolls vertically and horiztonally, and has clipped message at the bottom of it.

It will only affect wikis that have Citoid enabled, configured, but also have it demoted from the toolbar. I think most wikis that bother setting up Citoid leave it in the toolbar...

Tue, Jul 18, 3:44 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), VisualEditor-MediaWiki, Patch-For-Review, VisualEditor

Mon, Jul 17

Esanders added a comment to T164791: Add class mw-parser-output to Flow comment- or content- containing elements.

This should also be verified to be true when creating a Flow post; T164790: Add class mw-parser-output to VE's editing area may be relevant to that.

Mon, Jul 17, 5:09 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, VisualEditor, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), TemplateStyles, Flow
Esanders added a comment to T164790: Add class mw-parser-output to VE's editing area.

Adding mw-parser-output to the CE surface is a trivial one line fix. If this class exists solely to support TemplateStyles then it's fine, otherwise it should be noted somewhere that this class does not guarantee the contents is parser output as the name suggests, just that it wants to be rendered as if it were.

Mon, Jul 17, 4:58 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), User-Ryasmeen, TemplateStyles, VisualEditor
Esanders added a comment to T170693: Can't move images to a different location.

WFM in Firefox + Ubuntu and Firefox + OSX. The image goes grey, and I get a horizontal line showing me where the image will land.

Mon, Jul 17, 2:42 PM · VisualEditor-MediaWiki-Media, VisualEditor

Wed, Jul 12

Esanders added a comment to T170466: Show preview stopped working in Microsoft Edge.

We also have crossbrowsertesting accounts although they're a little slower.

Wed, Jul 12, 8:12 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Browser-Support-Microsoft-Edge, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Elitre awarded T153315: Pasting annotated wikitext results in double encoding and therefore <nowiki>s a Doubloon token.
Wed, Jul 12, 5:23 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T30980: parser tags such as <ref>, <poem>, <timeline> etc. cannot be localized.

Tangential: In the long term my wish is to migrate also these files to JSON format and make them available for translation in translatewiki.net.

Wed, Jul 12, 3:20 PM · Parsoid, Cite, RTL, Patch-For-Review, I18n, MediaWiki-Internationalization
Esanders added a comment to T170371: Allow reviewing your changes as visual diff in NWE.

We probably want to fix T170269 before making historical visual diffs more available.

Wed, Jul 12, 2:30 PM · Patch-For-Review, Epic, VisualEditor-VisualDiffs, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T170269: Reference diffs not working correctly on historical diffs.

I also imagine this is quite a lot of work.

Wed, Jul 12, 2:29 PM · VisualEditor-VisualDiffs, VisualEditor

Tue, Jul 11

Esanders updated subscribers of T140451: Redesign save dialog / diff view.
Tue, Jul 11, 6:14 PM · Design, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T166088: Cursor should be focused in Citoid's automatic box.
  1. I can reproduce if doing this is the very first thing that I try to do in the document.
Tue, Jul 11, 5:19 PM · Citoid, VisualEditor
Esanders updated subscribers of T170269: Reference diffs not working correctly on historical diffs.
Tue, Jul 11, 1:41 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T170269: Reference diffs not working correctly on historical diffs.

The current version of the visual diff makes a lot of assumptions about the internal list being append-only, i.e. that document B's internalList is a superset of document A, however if parse the documents separately from the server that is not the case.

Tue, Jul 11, 1:40 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T170235: Visual diff (on history page) shows changes to reference numbers caused by inserting more references.

Probably related to T170269, marking as subtask

Tue, Jul 11, 1:37 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders added a subtask for T170235: Visual diff (on history page) shows changes to reference numbers caused by inserting more references: T170269: Reference diffs not working correctly on historical diffs.
Tue, Jul 11, 1:37 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders created T170269: Reference diffs not working correctly on historical diffs.
Tue, Jul 11, 1:37 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T168089: Use 12.8 instead of 14px font size.

I don't know which is the rationale for using a 12.8px font in VE's UI, but in terms of consistency with other Mediawiki font sizes, this seems to be the outlier. Given the above, I'd not expect that moving from 12.8px to 14px font size would result in a major breaking change since it would align the text to a size already in use.

Tue, Jul 11, 1:04 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Esanders added a comment to T167047: Confusion between changes and revisions in visualisation.

Example: the old timeline selector in Google Analytics:

Tue, Jul 11, 12:21 PM · Revision-Slider, TCB-Team
Esanders created T170263: Create a PHP fallback for SelectFileWidget.
Tue, Jul 11, 12:15 PM · OOjs-UI

Mon, Jul 10

Esanders triaged T170194: Add VE support for 'responsive' attribute on references tag as Low priority.

Given most wikis are using ref list templates, and even when not, most users wouldn't want to change the responsive attribute, this isn't high priority.

Mon, Jul 10, 7:53 PM · VisualEditor-MediaWiki-References, VisualEditor
Esanders added a comment to T160589: VisualDiffs: Add custom messages for reference changes.

Filed as T170194.

Mon, Jul 10, 7:52 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), VisualEditor-MediaWiki-References, Cite, VisualEditor
Esanders created T170194: Add VE support for 'responsive' attribute on references tag.
Mon, Jul 10, 7:51 PM · VisualEditor-MediaWiki-References, VisualEditor
Esanders added a comment to T160589: VisualDiffs: Add custom messages for reference changes.

For {{reflist}] there is probably a column attribute, but we don't yet support templates but that's a separate issue. For <references> list we recently introduced the responsive attribute, so maybe we could add a message if that is changed, but given we don't have a UI for changing it in VE yet - I'd say we're done here.

Mon, Jul 10, 7:48 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), VisualEditor-MediaWiki-References, Cite, VisualEditor
Esanders updated subscribers of T166088: Cursor should be focused in Citoid's automatic box.

Can't reproduce in FF+Safari. Can you? Can someone else with a Mac (@Jdforrester-WMF ?)

Mon, Jul 10, 7:42 PM · Citoid, VisualEditor
Esanders created T170170: Possible to select CodeMirror surface under VE NWE using slight gap and end of document.
Mon, Jul 10, 4:43 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T170156: Should we indicate to users that visual diffs are in beta?.

I think the most important part is to provide a way for users to leave feedback - such a feature would make it obvious that there are known issues and that the feature is under active development.

Mon, Jul 10, 4:33 PM · User-Ryasmeen, Design, VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

Show formatting and link changes as side notes

Mon, Jul 10, 4:11 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

Show formatting and link changes as side notes

Mon, Jul 10, 4:09 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders created T170160: Insert table adds extra linebreaks in wikitext mode.
Mon, Jul 10, 3:19 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), VisualEditor, Regression, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T170107: Nothing shown in visual diff when editing invisible templates.

The problem is the template is invisible in the main document - in this case it only outputs to <indicators>

Mon, Jul 10, 11:02 AM · VisualEditor, VisualEditor-VisualDiffs
Esanders renamed T170107: Nothing shown in visual diff when editing invisible templates from No context shown when editing the first template to Nothing shown in visual diff when editing invisible templates.
Mon, Jul 10, 11:01 AM · VisualEditor, VisualEditor-VisualDiffs

Sun, Jul 9

Esanders created T170074: Deleting column with sparse cells leaves behind CE cells that don't exist in model.
Sun, Jul 9, 10:27 AM · VisualEditor-Tables, VisualEditor

Sat, Jul 8

Esanders closed T170057: Using delete key above the line for indented text in NWE+CodeMirror leads to bug as Resolved.

I think this was fixed by https://gerrit.wikimedia.org/r/#/c/363644/ , seems to work on beta labs now.

Sat, Jul 8, 7:54 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

Fri, Jul 7

Esanders added a comment to T169851: [NWE + CodeMirror] Long words cause following text to fall out of sync.

The lines thing shouldn't be an issue as both inputs have the same CSS, but they could've got out of sync for another reason. Can you test again on beta labs after https://gerrit.wikimedia.org/r/#/c/363644/ is merged?

Fri, Jul 7, 4:32 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T169925: [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block .

Can't reproduce. If still broken for you can you leave more detailed steps (wiki, browser, page etc.)?

Fri, Jul 7, 4:28 PM · VisualEditor
Esanders added a comment to T57370: VisualEditor: Implement some form of auto-save.

The main concern is what happens when we run out of storage.

Fri, Jul 7, 4:19 PM · Epic, VisualEditor, VisualEditor-MediaWiki
Esanders merged T169965: VisualEditor doesn't recover from browser crashes (unlike classical editor) into T57370: VisualEditor: Implement some form of auto-save.
Fri, Jul 7, 4:10 PM · Epic, VisualEditor, VisualEditor-MediaWiki
Esanders merged task T169965: VisualEditor doesn't recover from browser crashes (unlike classical editor) into T57370: VisualEditor: Implement some form of auto-save.
Fri, Jul 7, 4:10 PM · VisualEditor
Esanders added a comment to T169982: OOjs UI fields with dynamic labels get the user cursor out of position when content it too long (e.g. edit summary field).

Works for me, I see a bit of scroll flickering, but generally it does what I expect.

Fri, Jul 7, 4:09 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Editing-team, MediaWiki-Page-editing, OOjs-UI
Esanders added a comment to T169342: Gallery output for missing images is not consistent with PHP parser and is missing data.

Filed as T169975

Fri, Jul 7, 11:10 AM · Patch-For-Review, Parsoid
Esanders created T169975: Missing images render as broken img tags, not redlinks.
Fri, Jul 7, 11:10 AM · Parsoid
Esanders added a comment to T169342: Gallery output for missing images is not consistent with PHP parser and is missing data.

Yes - I suppose plain images already diverge from PHP in this way already (rendering a missing image instead of text).

Fri, Jul 7, 11:02 AM · Patch-For-Review, Parsoid

Thu, Jul 6

Esanders created T169890: Backfill missing Apex icons with WikimediaUI icons.
Thu, Jul 6, 2:07 PM · OOjs-UI
Esanders updated subscribers of T169389: [Regression pre-wmf.8] Table context menu is appearing over table cell menu.

@matmarex was changing z-indices *points finger*

Thu, Jul 6, 1:55 PM · Verified-in-Phase0, Verified, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), VisualEditor-Tables, User-Ryasmeen, VisualEditor

Mon, Jul 3

Esanders updated subscribers of T169307: Editing references (cite web) through Visual Editor just got more complicated.

Looks like it was @matmarex's fix, locally it's trying to compare "Cite web" to "Cite web\n".

Mon, Jul 3, 4:23 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, Regression, VisualEditor-MediaWiki-References, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders triaged T169307: Editing references (cite web) through Visual Editor just got more complicated as Unbreak Now! priority.
Mon, Jul 3, 4:07 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, Regression, VisualEditor-MediaWiki-References, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Sun, Jul 2

Esanders added a comment to T169399: Links to sister projects should not look like external links in preview .

Slightly different use case, but basically the same as T103636.

Sun, Jul 2, 11:17 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Fri, Jun 30

Esanders added a comment to T168236: <title> is still "Editing ..." after page is published.

This only happens when you load the page via action=edit

Fri, Jun 30, 5:06 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki, WMSE-Bug-Reporting-and-Translation-2017
Esanders renamed T168236: <title> is still "Editing ..." after page is published from Firefox title field and tab header still says "Editing" after page is published to <title> is still "Editing ..." after page is published.
Fri, Jun 30, 5:05 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki, WMSE-Bug-Reporting-and-Translation-2017
Esanders added a comment to T168703: DropdownInputWidget has broken width in PHP.

Just tweaking the padding and image position makes it look better in Chrome & Firefox:
(set width to 100%+1px, and background position to right 1px)

Fri, Jun 30, 4:56 PM · OOjs-UI
Esanders renamed T169342: Gallery output for missing images is not consistent with PHP parser and is missing data from Gallery output for missing images is not consistent with PHP parser to Gallery output for missing images is not consistent with PHP parser and is missing data.
Fri, Jun 30, 4:43 PM · Patch-For-Review, Parsoid
Esanders added a comment to T169342: Gallery output for missing images is not consistent with PHP parser and is missing data.

Also how is one supposed to access the image resource from the DOM in this case? Also the alt text is missing...

Fri, Jun 30, 4:43 PM · Patch-For-Review, Parsoid
Esanders created T169342: Gallery output for missing images is not consistent with PHP parser and is missing data.
Fri, Jun 30, 2:44 PM · Patch-For-Review, Parsoid
Esanders added a comment to T168086: jQuery 3 catches all exceptions within promises.

...unless the exception is on the thousandth iteration of a loop, in which case you need to make the breakpoint conditional, and then you need to work out what the condition is.

Fri, Jun 30, 2:21 PM · Performance-Team, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), JavaScript, MediaWiki-ResourceLoader
Esanders created T169337: Gallery dialog doesn't open when it contains missing images.
Fri, Jun 30, 2:00 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, MediaWiki-Gallery, VisualEditor, VisualEditor-EditingTools

Thu, Jun 29

Esanders added a comment to T168901: Can't drag-and-drop text to rearrange (cut and paste) in Safari.

Turns out Safari is still garbage. Just calling e.dataTransfer.setData(..) within a dragstart listener is enough to kill the text drop cursor. Needs more trial an error bashing. *sigh*

Thu, Jun 29, 11:07 PM · Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor
Esanders added a comment to T168086: jQuery 3 catches all exceptions within promises.

Is it unavoidable that these exceptions will all now be caught? A logged stack trace is considerably less useful than an uncaught exception that pauses the debugger.

Thu, Jun 29, 9:36 PM · Performance-Team, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), JavaScript, MediaWiki-ResourceLoader
Esanders added a comment to T169219: Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled, which causes errors..

Above patch reduces the dialog to a single tab:

Thu, Jun 29, 4:23 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), VisualEditor-MediaWiki-References, VisualEditor-MediaWiki, User-Ryasmeen, VisualEditor, Citoid
Esanders added a comment to T169219: Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled, which causes errors..

It looks like neither the Cite tool nor citoid are actually enabled on hr wiki

Thu, Jun 29, 3:47 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), VisualEditor-MediaWiki-References, VisualEditor-MediaWiki, User-Ryasmeen, VisualEditor, Citoid

Wed, Jun 28

Esanders added a comment to T153315: Pasting annotated wikitext results in double encoding and therefore <nowiki>s.

Firstly I think we should be able to address the issue of pasting wikitext, as we do this already in visual mode. If you paste {{foo}} into visual mode you get an instance of the template, not some <nowiki>'d code. We should be able to re-use this code in source mode.

Wed, Jun 28, 3:04 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T169090: Provide a DraggableListWidget or similar.

cf mw.TemplateData.ParamSelectWidget / mw.TemplateData.ParamWidget in TemplateData

Wed, Jun 28, 2:02 PM · OOjs-UI
Elitre awarded T167009: Offsets calculated incorrectly with inline images in MediaWiki a Like token.
Wed, Jun 28, 10:42 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor-Tables, VisualEditor

Mon, Jun 26

Esanders added a comment to T64803: VisualEditor: Extract red link API code from VE and put into Parsoid.

Red link code is now in Parsoid so can be removed from VE

Mon, Jun 26, 6:58 PM · VisualEditor, Technical-Debt

Jun 24 2017

Esanders created T168762: TagMultiselectWidget has broken margins/alignments in Apex.
Jun 24 2017, 12:36 AM · OOjs-UI
Esanders created T168761: RC filters doesn't look so good outside of Vector/WikimediaUI.
Jun 24 2017, 12:31 AM · Edit-Review-Improvements-Integrated-Filters, Design, Collaboration-Team-Triage, OOjs-UI

Jun 23 2017

Esanders added a comment to T168091: Filter callouts anchored to close icons, instead of whole label.

the callout is [now placed] centrally

Jun 23 2017, 11:21 PM · MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Esanders created T168760: Clarify appropriate use of 'pending' background texture.
Jun 23 2017, 11:12 PM · Edit-Review-Improvements-Integrated-Filters, Notifications, Collaboration-Team-Triage, OOjs-UI
Esanders created T168745: DraggableElement / DraggableGroupElement should have no skin styles applied..
Jun 23 2017, 6:56 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Regression, OOjs-UI, VisualEditor
Krinkle awarded T168598: In Vector, sidebar items and headings are not aligned well a Orange Medal token.
Jun 23 2017, 3:13 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Design, Vector
Liuxinyu970226 awarded T76523: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load a Party Time token.
Jun 23 2017, 8:51 AM · User-Ryasmeen, Verified-in-Phase2, User-notice, Verified-in-Phase0, WMF-deploy-2015-03-04_(1.25wmf20), VisualEditor 2014/15 Q3 blockers, VisualEditor-Performance, VisualEditor, Performance