Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (237 w, 5 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

Um... A lot of it actually is defined locally on the wiki and won't work without non-trivial JSON configuration that maps it to local templates.

Sun, May 19, 12:44 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor

Yesterday

Esanders created T223745: Create a mediawiki.widgets demo page.
Sat, May 18, 5:44 PM · OOUI
Esanders added a project to T223705: Make visual editor the default editor for redlinks at euwiki: VisualEditor.
Sat, May 18, 11:08 AM · Wikimedia-Site-requests, VisualEditor, Wikimedia-User-Group-Basque
Esanders added a comment to T223705: Make visual editor the default editor for redlinks at euwiki.

The issue here is that we have to assume that action=edit is wikitext, as the main edit links use this to open source mode, as opposed to veaction=edit for visualeditor.

Sat, May 18, 11:07 AM · Wikimedia-Site-requests, VisualEditor, Wikimedia-User-Group-Basque
Esanders added a comment to T223700: Add some horizontal padding to title inputs.

Works in monobook too:

Sat, May 18, 10:35 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Design, ContentTranslation
Esanders created T223700: Add some horizontal padding to title inputs.
Sat, May 18, 10:32 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Design, ContentTranslation
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

There is no good reason for this differentiation. Many templates could be first-class features like "Cite", although global templates should probably implemented first.

Sat, May 18, 9:49 AM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor

Fri, May 17

Esanders added a comment to T1181: VisualEditor loading indicator should feel more integrated into the mobile interface.

Migrating comments from gerrit:

Fri, May 17, 9:33 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, Design
Esanders added a comment to T58313: Make postedit messages ("Your edit was saved.") and mw.notification messages ("The page has been added to your watchlist.") look the same.

Note that on mobile these messages are already unified, with both the post-edit notification, and other notifications showing at the bottom of the page in a black box.

Fri, May 17, 6:12 PM · Patch-For-Review, MW-1.30-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), UI-Standardization, Design, MediaWiki-Interface
Esanders updated subscribers of T58313: Make postedit messages ("Your edit was saved.") and mw.notification messages ("The page has been added to your watchlist.") look the same.

CC @iamjessklein

Fri, May 17, 6:10 PM · Patch-For-Review, MW-1.30-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), UI-Standardization, Design, MediaWiki-Interface
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

That's the list of most popular (aka most used templates), right?

Fri, May 17, 5:14 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

Here's how it looks on my local install:

Fri, May 17, 4:56 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

I think the first one would work.

Fri, May 17, 4:16 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

I think for a first pass on this we can allow wikis to define a list of most common templates on wiki, e.g.

MediaWiki:Template-directory.json
[
  "Biografia infotaula automatikoa",
  ...
]

This could then be fetched by the template dialog and show in the space below the search input:

In the future we would probably want to make this more flexible, such as by grouping templates together, e.g.

MediaWiki:Template-directory.json
[
  {
    "group": "Infoboxes",
    "templates": [
      "Biografia infotaula automatikoa",
      ...
    ]
  }
]

which would necessitate a slightly more complex UI.

Fri, May 17, 4:15 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders added a comment to T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.

When we click in the insert template button we get a white pop-up where we must figure out what the correct template is. In Basque wikipedia we are using a reduced automatic templates system, so it would be very useful to have them listed just below, so you can click them and choose.

Most useful infoboxes:

  • {{biografia infotaula automatikoa}}
  • {{artelan infotaula automatikoa}} < for artworks
  • {{Eraikin infotaula automatikoa}} < buildings
  • {{Hiri orokor infotaula}} < cities
  • {{Probintzia orokor infotaula}} < administrative units up from cities
  • {{taxotaula automatikoa}} < taxobox
Fri, May 17, 4:14 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders edited projects for T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor, added: Wikimedia-Hackathon-2019, VisualEditor-MediaWiki-Templates, Wikimedia-User-Group-Basque; removed VisualEditor-EditingTools.
Fri, May 17, 4:11 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders merged T223534: Add a easy list for most common templates on VisualEditor into T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.
Fri, May 17, 4:10 PM · User-notice, Patch-For-Review, Wikimedia-User-Group-Basque, VisualEditor-MediaWiki-Templates, Wikimedia-Hackathon-2019, Design, VisualEditor
Esanders merged task T223534: Add a easy list for most common templates on VisualEditor into T55590: VisualEditor: Provide some kind of template suggestion in the transclusion editor.
Fri, May 17, 4:10 PM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Esanders added a comment to T223534: Add a easy list for most common templates on VisualEditor.

I think T96710 is asking for a similar feature, but adding buttons to the toolbar, not the template dialog.

Fri, May 17, 4:06 PM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Esanders moved T222859: Cursor focus not set on editsummary box when publishing dialog opens from Code review to Product owner review on the VisualEditor (Current work) board.
Fri, May 17, 1:11 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools
Esanders added a comment to T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.

Browser seems to be pretty good now, covering most of our support browsers: https://www.caniuse.com/#search=flex

Fri, May 17, 1:10 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Esanders added a comment to T219862: Add copy button to URL shortener result.

Fri, May 17, 11:45 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, User-TheDJ, Wikimedia-Hackathon-2019, MediaWiki-extensions-UrlShortener
Esanders added a comment to T219862: Add copy button to URL shortener result.

I didn't see this task before writing the patch, sorry. I went with the "articles" icon:

Fri, May 17, 11:43 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, User-TheDJ, Wikimedia-Hackathon-2019, MediaWiki-extensions-UrlShortener
Esanders added a comment to T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.

This toolbar is one of the most prominent interfaces for editors using wikitext every single day, and this change imho simply makes it out of tone with the skin.

Fri, May 17, 11:36 AM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders added projects to T223534: Add a easy list for most common templates on VisualEditor: VisualEditor, VisualEditor-MediaWiki-Templates.
Fri, May 17, 10:56 AM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Esanders added a comment to T221957: Offer proposals or automatically link a word in an article to the existing Wikipedia page for that word .

Also discussed were possible UI improvements to the link tool in the 2010 wikitext editor, which is less user friendly than the tool in VE:

Fri, May 17, 10:38 AM · VisualEditor, Wikimedia-Hackathon-2019
Esanders added a comment to T221957: Offer proposals or automatically link a word in an article to the existing Wikipedia page for that word .

This sounds like a WMF project from a few years ago that was eventually abandoned: T107630. There may be other more detailed tasks than that one, but the people who worked on that would be good to talk to as well.

Fri, May 17, 10:32 AM · VisualEditor, Wikimedia-Hackathon-2019
Esanders added a comment to T223534: Add a easy list for most common templates on VisualEditor.

For anyone interested working on this, the code would go in ve.ui.MWTemplatePlaceholderPage, and would need to do the following:

  1. Fetch the JSON data for the local wiki using mw.message, see ve.ui.Citoid.init.js for an example of this.
  2. Get the template descriptions for the listed templates using the API, see the request that the search box uses
  3. Append a list of mw.widgets.TitleOptionWidgets to the page
Fri, May 17, 10:15 AM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Esanders added a comment to T223534: Add a easy list for most common templates on VisualEditor.

I think for a first pass on this we can allow wikis to define a list of most common templates on wiki, e.g.

MediaWiki:Template-directory.json
[
  "Biografia infotaula automatikoa",
  ...
]
Fri, May 17, 9:58 AM · Patch-For-Review, VisualEditor-MediaWiki-Templates, VisualEditor, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikimedia-User-Group-Basque
Esanders updated the task description for T223178: Prague Hackathon: conduct usability testing .
Fri, May 17, 8:59 AM · Wikimedia-Hackathon-2019, VisualEditor (Current work)

Thu, May 16

Esanders added a comment to T221195: VE mobile default: design A/B test.

###Update | 16-May

  • Sticky preferences: @Whatamidoing-WMF and I talked today and decided there's no issue with including all contributors who do not have a sticky preference set into the A/B test. This means that contributors who have used wikitext on mobile before, but have not switched to mobile VE and back again to wikitext, will potentially be included in the test group. reflected in task's description
Thu, May 16, 8:07 PM · Product-Analytics, VisualEditor

Wed, May 15

Esanders added a comment to T223369: WTE section=new mode allows switching to VE, but VE doesn't support this mode.

Disable the switch to VE tool when section === 'new'? (Note also you can probably switch via edit tabs/shortcuts)

Wed, May 15, 10:48 PM · VisualEditor
Esanders added a comment to T211255: [EPIC] Mobile VE toolbar improvements.

We should ensure we put "mobile" in the title of mobile tickets, and also use the Visualeditor-MediaWiki-Mobile tag.

Wed, May 15, 10:35 PM · VisualEditor-MediaWiki-Mobile, Editing Design, VisualEditor

Tue, May 14

Esanders added a comment to T189557: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines.

We could also try representing wikitext documents as just one huge paragraph node with newlines… we'd still have this problem for some normal documents, but they would be rarer. I don't know what's the reason for the current representation.

This is a possibility. It was just easier at the time, and allowed us to do single line regexes more easily.

Tue, May 14, 8:10 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.

Tested locally - it appears to be mostly sensible in cursoring between and selecting across paragraphs. Obviously you need to cursor up from the lede paragraph to get to the infobox, but given cursoring is an edge case on mobile I'm not too worried about that.

Tue, May 14, 5:00 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Esanders added a comment to T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.

arrow keys

Tue, May 14, 4:53 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Esanders added a comment to T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.

Also sharing on task, the arrows should be replaced in WikimediaUI style by carets

Tue, May 14, 4:47 PM · UI-Standardization, Patch-For-Review, WikiEditor
Volker_E awarded T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style a Like token.
Tue, May 14, 4:05 PM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders updated the task description for T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Tue, May 14, 3:46 PM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders added a comment to T1181: VisualEditor loading indicator should feel more integrated into the mobile interface.

The videos are showing the slower end of our expected loading times (~5s). I think the median load time is less than 2s and for quick loads a progress bar can feel a bit heavy. Unfortunately we can't know ahead of time how long the page will take to load.

Tue, May 14, 1:03 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, Design
Esanders updated the task description for T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Tue, May 14, 12:57 PM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders updated subscribers of T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Tue, May 14, 11:56 AM · UI-Standardization, Patch-For-Review, WikiEditor

Mon, May 13

Esanders updated the task description for T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Mon, May 13, 7:14 PM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders created T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Mon, May 13, 6:29 PM · UI-Standardization, Patch-For-Review, WikiEditor
Esanders moved T223086: Image resize handles showing on mobile from Code review to Product owner review on the VisualEditor (Current work) board.
Mon, May 13, 6:13 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.

Pure CSS approach:

@media (narrow) {
  .mf-section-0 {
    display: flex;
    flex-direction: column;
  }
  .mf-section-0 > * {
    order: 1;
  }
  .mf-section-0 > table.infobox + p {
    order: 0;
  }
}
Mon, May 13, 3:41 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Esanders created T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.
Mon, May 13, 3:30 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Esanders moved T223086: Image resize handles showing on mobile from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, May 13, 2:22 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T219512: Rename 'citefromid' to Citoid.

Updated on-wiki usages listed in description.

Mon, May 13, 12:50 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Citoid
Esanders updated subscribers of T222944: Citoid doesn't load when uselang=qqx.

Since https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/470181/ 'qqx' always returns (key) in the client, so the Citoid config is not returned, even though the JSON is manually loaded into the message store.

Mon, May 13, 12:27 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage
Esanders triaged T222944: Citoid doesn't load when uselang=qqx as Lowest priority.

Shouldn't the config be loaded in content language always and thus not be breaking on changing the interface language?

Mon, May 13, 12:15 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage
Esanders renamed T222944: Citoid doesn't load when uselang=qqx from Interface reports different interface messages than the actually used to Citoid doesn't load when uselang=qqx.
Mon, May 13, 12:13 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage
Esanders created T223086: Image resize handles showing on mobile.
Mon, May 13, 10:59 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, Regression, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T222859: Cursor focus not set on editsummary box when publishing dialog opens from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, May 13, 10:52 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools
Esanders edited projects for T222859: Cursor focus not set on editsummary box when publishing dialog opens, added: VisualEditor (Current work); removed VisualEditor.
Mon, May 13, 10:52 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools
Esanders updated subscribers of T222859: Cursor focus not set on editsummary box when publishing dialog opens.

Caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/507704/ CC @matmarex

Mon, May 13, 10:48 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools

Sun, May 12

Esanders added a comment to T222944: Citoid doesn't load when uselang=qqx.

When you have uselang=qqx set it appears to be breaking the Citoid config (which is loaded via messages), so you get the plain Cite menu instead.

Sun, May 12, 9:56 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage
Esanders updated subscribers of T222944: Citoid doesn't load when uselang=qqx.

CC @Nikerabbit . We renamed some messages in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Citoid/+/500732/15/i18n/en.json - is it too late to rename these automatically on TW?

Sun, May 12, 5:45 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage
Esanders added a comment to T223023: Switching from source to visual editing in mobile web removes all other sections.

I think this will be fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/503651/, but looks like we removed a discard warning too soon.

Sun, May 12, 5:22 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, MobileFrontend, Section Editing

Sat, May 11

Esanders added a comment to T215426: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px).

This will be resolved with T211255

Sat, May 11, 10:40 PM · VisualEditor, Editing Design, Readers-Web-Backlog (Design), Patch-For-Review, MobileFrontend, MinervaNeue
Esanders renamed T222957: Set VisualEditor as standard on all types of pages at pap.wikipedia.org (Papiamentu Wikipedia) from Set VisualEditor as standard on all types of pages at pap.wikipedia.org to Set VisualEditor as standard on all types of pages at pap.wikipedia.org (Papiamento Wikipedia).
Sat, May 11, 8:33 PM · VisualEditor, Wikimedia-Site-requests, Wiki-goes-Caribbean
Esanders moved T222999: Preview of editing summary missing in VE from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sat, May 11, 8:28 PM · Verified, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders edited projects for T222999: Preview of editing summary missing in VE, added: VisualEditor (Current work); removed VisualEditor.
Sat, May 11, 8:28 PM · Verified, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders added a project to T222999: Preview of editing summary missing in VE: Regression.
Sat, May 11, 8:16 PM · Verified, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression, VisualEditor-MediaWiki

Thu, May 9

Esanders updated subscribers of T222894: Chinese IME issue in 2017 WTE.
Thu, May 9, 3:00 PM · Chinese-Sites, VisualEditor
Esanders created T222894: Chinese IME issue in 2017 WTE.
Thu, May 9, 2:54 PM · Chinese-Sites, VisualEditor

Wed, May 8

Esanders added a comment to T163142: Buttons in the toolbar should be actual tools.

This is implemented in OOUI, and fixed in VE and CX which are the only users.

Wed, May 8, 9:43 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), ContentTranslation, Patch-For-Review, OOUI (OOUI-0.31.4), VisualEditor (Current work), Technical-Debt
Esanders moved T209599: Show block notices on mobile visual editor from Code review to QA on the VisualEditor (Current work) board.
Wed, May 8, 9:14 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Editing QA, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki
Esanders created T222831: mw.widgets.TitleWidget should not support interwiki links by default.
Wed, May 8, 6:45 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-General-or-Unknown
Esanders added a comment to T219627: Sometimes an ISBN turns up wrapped in nowiki-tags.

@jeblad It is detected by Parsoid because it scans the entire document again. Similarly with links it would <nowiki> anything that might get autolinked by wikitext rules but was not linked by VE. Parsoid has no way to determine if the ISBN/link was no linked deliberately by the user so just respects what we send them (i.e. in this case, unlinked text).

Wed, May 8, 5:50 PM · VisualEditor, Citoid
Esanders added a comment to T222251: Warn user if they set the whole page to a different language.

We should probably have some help text given that this is a bit of a unusual tool, but I haven't seen this happen often and the tool is suitably hidden away.

Wed, May 8, 5:41 PM · VisualEditor
Esanders added a comment to T185083: Consistently style links (internal, inter-wiki and external).

"This does not fix the rendering of new or modified interwiki links, which will require an API request."

Wed, May 8, 4:32 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor-MediaWiki, Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T222707: switch eslint to require dangling comma with "always-multiline".

Object literal trailing comma support was only added to IE in version 9. IE8 support was only dropped a few years ago. We also need to support IE8 in the resource loader init file, which is currently enforceable just by setting the environment to ES3, so this would add another exception.

Wed, May 8, 2:09 PM · Front-end-Standards-Group, Wikidata, JavaScript, Code-Health, Wikidata-Campsite
Esanders added a comment to T220227: Focusable nodes don't scroll past toolbar when focused.

"product owner review" means it's just awaiting final review by the PM before being closed

Wed, May 8, 1:48 PM · OOUI (OOUI-0.31.4), VisualEditor (Current work)

Tue, May 7

Esanders added a comment to T185083: Consistently style links (internal, inter-wiki and external).

The Parsoid side is finished, but we still render interwiki links as external in VE.

Tue, May 7, 7:24 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor-MediaWiki, Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki-2017WikitextEditor

Mon, May 6

Esanders moved T211898: Bits of WikiEditor UI being shown when following red link in WTE2017 from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Mon, May 6, 10:01 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, VisualEditor (Current work), Technical-Debt, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T222312: Mobile switching with changes from WTE to VE fails on non-RESTBase setups.

It is supposed to be disabled. I'm not sure what happens without the RESTBase stash, maybe a full doc dirty diff?

Mon, May 6, 10:00 PM · VisualEditor (Current work), Patch-For-Review
Esanders moved T222525: Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, May 6, 8:00 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), VisualEditor-MediaWiki, Patch-For-Review, VisualEditor (Current work), User-DannyS712

Sun, May 5

Esanders added a comment to T221291: [Regression] Cursor moves to the beginning of the article on mobile VE while adding manual citation.

3 is expected, it shows the citation is not finished yet. 1&2 should be filed as bugs.

Sun, May 5, 1:38 PM · Editing QA, VisualEditor (Current work), Patch-For-Review

Fri, May 3

Esanders added a project to T76426: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are: Editing QA.
Fri, May 3, 2:40 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools
Esanders added a project to T209162: [Regression] Blockquotes can't be edited, because they're alienated content: Editing QA.
Fri, May 3, 2:40 PM · Verified, VisualEditor (Current work)
Esanders added a project to T209599: Show block notices on mobile visual editor: Editing QA.
Fri, May 3, 2:40 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Editing QA, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki
Esanders added a project to T220633: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile: Editing QA.
Fri, May 3, 2:40 PM · Verified, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
Esanders added a project to T216792: Ordered lists look broken in mobile VE: Editing QA.
Fri, May 3, 2:40 PM · Verified, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor (Current work)
Esanders added a project to T221716: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active: Editing QA.
Fri, May 3, 2:40 PM · Verified, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-Links, VisualEditor (Current work)
Esanders added a project to T221903: Visual diff showing too much context in section editing mode: Editing QA.
Fri, May 3, 2:40 PM · Verified, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-VisualDiffs
Esanders claimed T221855: Don't show anon editor warning after switching on Mobile.
Fri, May 3, 1:46 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Thu, May 2

Esanders added a comment to T221967: Can't reliably gather list of annotation views from a DM offset.

That's correct, but the pattern for nodes is view.getNodeFromOffset( modelOffset ) which doesn't violate that rule, so we should have something similar for annotations.

Thu, May 2, 5:14 PM · VisualEditor
Esanders added a comment to T222329: Special:Search generates "TypeError: this.pushPending is not a function".

Exposed by OOUI, but is a downstream issue.

Thu, May 2, 4:14 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Discovery-Search, MediaWiki-Search, Regression, OOUI
Esanders renamed T222370: Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel" from Use OO.ui.alert instead of system alert when pressing "cancel" to Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel".
Thu, May 2, 3:16 PM · UI-Standardization, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Multimedia, SDC Engineering
Esanders edited projects for T222370: Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel", added: SDC Engineering; removed StructuredDataOnCommons.
Thu, May 2, 2:58 PM · UI-Standardization, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Multimedia, SDC Engineering
Esanders created T222370: Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel".
Thu, May 2, 2:56 PM · UI-Standardization, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Multimedia, SDC Engineering
Esanders added a comment to T222312: Mobile switching with changes from WTE to VE fails on non-RESTBase setups.

Switching from WTE to VE with changes shouldn't be possible on a non-restbase setup. Restbase is required to stash the modified HTML version of the doc. On desktop we tell users they can "discard changes and switch".

Thu, May 2, 10:40 AM · VisualEditor (Current work), Patch-For-Review

Wed, May 1

Esanders added a comment to T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).

Yeah, as James says this is a beta feature so only represents a small proportion of edits. As a result we don't plan on prioritising this for now, unless you have some other information on the impact?

Wed, May 1, 5:06 PM · VisualEditor, Performance-Team (Radar), MediaWiki-Page-editing, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T222229: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode .

Needs backport

Wed, May 1, 1:22 PM · Verified, User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MobileFrontend, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Esanders claimed T222229: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode .
Wed, May 1, 1:21 PM · Verified, User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MobileFrontend, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Esanders edited projects for T222229: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode , added: VisualEditor (Current work); removed VisualEditor.
Wed, May 1, 1:21 PM · Verified, User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MobileFrontend, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Esanders added a comment to T221967: Can't reliably gather list of annotation views from a DM offset.

A side effect of this is if you cursor onto a link from the right, the preview doesn't render:

Wed, May 1, 1:09 PM · VisualEditor
Esanders added a comment to T222250: [wmf.3 - regression] testwiki - placeholded image for cx-selected-source-page__image not displayed.

Extending TitleOptionWidget here would help...

Wed, May 1, 10:30 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Language-Team (Language-2019-April-June), Regression, ContentTranslation

Tue, Apr 30

Esanders assigned T216792: Ordered lists look broken in mobile VE to matmarex.
Tue, Apr 30, 8:37 PM · Verified, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor (Current work)