Esanders (Ed Sanders)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (194 w, 4 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders created T200076: 'Select a date' placeholder not vertically centered in UploadWizard.
Fri, Jul 20, 11:40 AM · Multimedia, UploadWizard

Thu, Jul 19

Esanders closed T195180: rebaser: Import an page to Special:CollabPad as Resolved.
Thu, Jul 19, 3:57 PM · User-Ryasmeen, VisualEditor
Esanders added a comment to T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute.

From what I can see, Parsoid doesn't even expose the contents on <includeonly> tags to the editor, so we have nothing to diff. I assume it is only preserved by SelSer?

Thu, Jul 19, 11:39 AM · Parsoid
Esanders added a project to T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute: Parsoid.
Thu, Jul 19, 11:37 AM · Parsoid

Wed, Jul 18

Esanders created T199934: Overlapping NailedAnnotations don't work very well.
Wed, Jul 18, 5:54 PM · VisualEditor
Esanders added a comment to T199740: Bold and big not highlighted correctly in the 2017WTE.

We disabled the bold/italic rules as in some browsers (probably IE) they were causing sub-pixel width differences.

Wed, Jul 18, 5:10 PM · MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T199752: Toolbar menu positioning broken when zoom level > 100%.

Maybe just Chrome only.

Wed, Jul 18, 5:09 PM · VisualEditor
Esanders added a comment to T58656: Create a new, nice logo for Parsoid.

The only reason this version didn't stick is because the then-lead dev vetoed it, but if the current team are happy with it we could restore it?

Wed, Jul 18, 2:50 PM · Design, Parsoid
Esanders added a comment to T58656: Create a new, nice logo for Parsoid.

There's also the 2013 version from the file history. We used it on the VE release shirts.

Wed, Jul 18, 2:13 PM · Design, Parsoid
Esanders added a project to T199849: VisualEditor manipulation based on TemplateData source code formatting does not handle newlines before and after correctly: Parsoid.
Wed, Jul 18, 2:08 PM · Parsoid, VisualEditor, TemplateData

Mon, Jul 16

Esanders renamed T199752: Toolbar menu positioning broken when zoom level > 100% from Toolbar menu positioning broken on en.wiki to Toolbar menu positioning broken when zoom level > 100%.
Mon, Jul 16, 9:52 PM · VisualEditor
Esanders created T199752: Toolbar menu positioning broken when zoom level > 100%.
Mon, Jul 16, 9:49 PM · VisualEditor

Sun, Jul 15

Esanders added a comment to T198021: Resolve inconsistent numbering of references in text and in bibliography.

Our team only uses "assigned to" for current work.

Sun, Jul 15, 2:19 PM · Design, Need-volunteer, Cite
Esanders placed T198021: Resolve inconsistent numbering of references in text and in bibliography up for grabs.
Sun, Jul 15, 2:16 PM · Design, Need-volunteer, Cite

Thu, Jul 12

Esanders updated subscribers of T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

Having a comment node as a child of a list node seems like a violation of
ve.dm.ListNode.static.childNodeTypes = [ 'listItem' ];
so ideally we would just fix the placement of that comment node (which might be more in @dchan 's ball park)

Thu, Jul 12, 6:00 PM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Esanders moved T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined" from To Triage to TR6: Visual diffs on the VisualEditor board.
Thu, Jul 12, 5:55 PM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Esanders moved T190657: Closing mobile VE doesn't abandon auto save from To Triage to Current work on the VisualEditor board.
Thu, Jul 12, 5:54 PM · VisualEditor (Current work), Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T199138: NWE produces newline when selecting, copying and immediatly re-pasting text.

Also behaves correctly for me.

Thu, Jul 12, 5:53 PM · User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders created T199463: No keyboard shortcut for adding reviewers in PolyGerrit.
Thu, Jul 12, 4:45 PM · Upstream, Gerrit
Esanders moved T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute from To Triage to TR6: Visual diffs on the VisualEditor board.
Thu, Jul 12, 10:26 AM · Parsoid
Esanders renamed T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute from Visualdiff does not recognize hyphen types to Visualdiff does not recognize content in <includeonly>.
Thu, Jul 12, 9:44 AM · Parsoid
Liuxinyu970226 awarded T99256: Convert Special:Watchlist to OOUI (HTMLForm?) a Heartbreak token.
Thu, Jul 12, 8:36 AM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), Front-end-Standards-Group, User-notice, MediaWiki-Watchlist, UI-Standardization

Tue, Jul 10

Krinkle awarded T195986: FOUC in special preferences OOUI a Orange Medal token.
Tue, Jul 10, 5:03 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, MediaWiki-Special-pages, MediaWiki-User-preferences
Esanders triaged T199207: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) as High priority.
Tue, Jul 10, 1:10 PM · User-Ryasmeen, VisualEditor, Phabricator

Mon, Jul 9

Esanders added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

Just to add a few points in defence of the current approach (although again, I think both have their pros and cons):

Mon, Jul 9, 5:05 PM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

We should disable on mobile, like we do with toolbar shortcuts, should be easy enough.

Mon, Jul 9, 4:53 PM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

Thanks Pau, I think we both discussed this option at the time and I don't really have any strong objections to it. Both approaches (dialog/fixup) have their merits (for example the dialog is more intrusive, but gives less preference to either option). In the end the dialog seemed to be more feasible technically, and we wanted to get something in place for users to try out. With this issue (adding the keyboard shortcut) I am not ruling out trying this different approach in the future.

Mon, Jul 9, 4:41 PM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

What does it look like on mobile? Aside from taking up extra screen space, these shortcuts also wouldn't be much good to a mobile user who doesn't have a keyboard?

Mon, Jul 9, 4:28 PM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T198798: Can not use Citoid when editing a reference.

The steps for this case should then be: get the url from the url parameter

Mon, Jul 9, 4:26 PM · VisualEditor-MediaWiki-References, Citoid, VisualEditor
Liuxinyu970226 awarded T109123: Please add either <code> or <kbd> to the existing VisualEditor toolbar in Flow a 100 token.
Mon, Jul 9, 4:10 AM · Growth-Team, User-notice, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Collaboration-Team-Triage, StructuredDiscussions

Fri, Jul 6

Esanders moved T198912: Clicking on focusable inside table cell can jump cursor to start of document from Up next to Code review on the VisualEditor (Current work) board.
Fri, Jul 6, 8:17 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-ContentEditable
Esanders edited projects for T198912: Clicking on focusable inside table cell can jump cursor to start of document, added: VisualEditor (Current work); removed VisualEditor.
Fri, Jul 6, 8:17 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-ContentEditable
Trizek-WMF awarded T145850: While editing on VE, ctrl+click should open the link in a new tab, not opening link inspector a Like token.
Fri, Jul 6, 7:56 AM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-Links, VisualEditor-MediaWiki-Links, VisualEditor (Current work)

Thu, Jul 5

Esanders created T198912: Clicking on focusable inside table cell can jump cursor to start of document.
Thu, Jul 5, 8:24 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-ContentEditable
Esanders added a comment to T191095: The image behind the intro dialog on mobile VE stretches strangely and makes the dialog look broken.

Patch fixes landscape, but portrait is now overlapping:

Thu, Jul 5, 5:27 PM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor (Current work)
Esanders added a comment to T197760: References can get lost while editing under some circumstances.

Yeah - fixing this in the current state is going to be a nightmare, and the situation only arises if the user deletes a ref list (very rare), so I'm tempted to wait until Parsoid have taken over more of the ref handling code before we re-visit this.

Thu, Jul 5, 4:11 PM · Parsoid, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T197845: CX2: Uncaught TypeError: Cannot read property 'element' of null.

Same exception as T198826, so we should check if the fix there fixes this (it might not, the error was much further up the stack).

Thu, Jul 5, 4:08 PM · Language-2018-July-September, VisualEditor, ContentTranslation
Esanders added a comment to T198871: Create tests for PreviewElement.

Above patch is only basic tests, includes TODO comment for more advanced tests.

Thu, Jul 5, 3:15 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), Technical-Debt
Esanders edited projects for T198871: Create tests for PreviewElement, added: VisualEditor (Current work); removed VisualEditor.
Thu, Jul 5, 3:12 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), Technical-Debt
Esanders created T198871: Create tests for PreviewElement.
Thu, Jul 5, 3:11 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), Technical-Debt
Esanders moved T198826: Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode from Up next to Code review on the VisualEditor (Current work) board.
Thu, Jul 5, 2:51 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-References, Cite, VisualEditor-MediaWiki
Esanders added a comment to T198742: "TopicListQuery.php: Cannot unpack array with string keys".

This appears to be happening on my other existing flow page now too. Creating a new flow page appears to work fine though.

Thu, Jul 5, 2:28 PM · Growth-Team (Current Sprint), Collaboration-Team-Triage, StructuredDiscussions
Esanders edited projects for T198826: Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode, added: VisualEditor (Current work); removed VisualEditor.
Thu, Jul 5, 2:16 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-References, Cite, VisualEditor-MediaWiki
Esanders claimed T198826: Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode.
Thu, Jul 5, 2:16 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-References, Cite, VisualEditor-MediaWiki
Esanders added a comment to T198798: Can not use Citoid when editing a reference.

References that contain a single URL should generate a 'Convert' button in the initial context popup, allowing you to feed the URL into Citoid.

Thu, Jul 5, 1:32 PM · VisualEditor-MediaWiki-References, Citoid, VisualEditor

Tue, Jul 3

Esanders added a comment to T198742: "TopicListQuery.php: Cannot unpack array with string keys".

I did var_dump($nodeList) on the line before the exception:

array(3) {
  ["sucy3ehmwotrzndq"]=>
  array(15) {
    ["sucy3ehmwotrzndq"]=>
    object(Flow\Model\UUID)#1413 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "sucy3ehmwotrzndq"
      ["timestamp":protected]=>
      NULL
    }
    ["sucy3ehq0zo3s2se"]=>
    object(Flow\Model\UUID)#1414 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "sucy3ehq0zo3s2se"
      ["timestamp":protected]=>
      NULL
    }
    ["sultbwfgg10uiz32"]=>
    object(Flow\Model\UUID)#1415 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "sultbwfgg10uiz32"
      ["timestamp":protected]=>
      NULL
    }
    ["t13ey6eezhrrucl3"]=>
    object(Flow\Model\UUID)#1416 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "t13ey6eezhrrucl3"
      ["timestamp":protected]=>
      NULL
    }
    ["t7ezqo017hk4onqv"]=>
    object(Flow\Model\UUID)#1417 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "t7ezqo017hk4onqv"
      ["timestamp":protected]=>
      NULL
    }
    ["t7f0dojduioioenr"]=>
    object(Flow\Model\UUID)#1418 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "t7f0dojduioioenr"
      ["timestamp":protected]=>
      NULL
    }
    ["tb5aw7wu9poafrcn"]=>
    object(Flow\Model\UUID)#1419 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tb5aw7wu9poafrcn"
      ["timestamp":protected]=>
      NULL
    }
    ["tlyp96rpr608sunr"]=>
    object(Flow\Model\UUID)#1420 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tlyp96rpr608sunr"
      ["timestamp":protected]=>
      NULL
    }
    ["tti5wfw14v52h9vb"]=>
    object(Flow\Model\UUID)#1421 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tti5wfw14v52h9vb"
      ["timestamp":protected]=>
      NULL
    }
    ["tti61n4qvjb9s5yv"]=>
    object(Flow\Model\UUID)#1422 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tti61n4qvjb9s5yv"
      ["timestamp":protected]=>
      NULL
    }
    ["tti6dt8hjwqjskl3"]=>
    object(Flow\Model\UUID)#1423 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tti6dt8hjwqjskl3"
      ["timestamp":protected]=>
      NULL
    }
    ["u748kg8axkx3xy5z"]=>
    object(Flow\Model\UUID)#1424 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u748kg8axkx3xy5z"
      ["timestamp":protected]=>
      NULL
    }
    ["u749yz7aasqkpkxj"]=>
    object(Flow\Model\UUID)#1425 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u749yz7aasqkpkxj"
      ["timestamp":protected]=>
      NULL
    }
    ["u74am3r58wdbbvav"]=>
    object(Flow\Model\UUID)#1426 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u74am3r58wdbbvav"
      ["timestamp":protected]=>
      NULL
    }
    ["uc04g8znxvmcb1vb"]=>
    object(Flow\Model\UUID)#1427 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "uc04g8znxvmcb1vb"
      ["timestamp":protected]=>
      NULL
    }
  }
  ["u9eolrqf7gh8s4l3"]=>
  array(2) {
    ["u9eolrqf7gh8s4l3"]=>
    object(Flow\Model\UUID)#1428 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u9eolrqf7gh8s4l3"
      ["timestamp":protected]=>
      NULL
    }
    ["u9eolrqgrmvx8d9z"]=>
    object(Flow\Model\UUID)#1429 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u9eolrqgrmvx8d9z"
      ["timestamp":protected]=>
      NULL
    }
  }
  ["tuhzerifusdmfuif"]=>
  array(4) {
    ["tuhzerifusdmfuif"]=>
    object(Flow\Model\UUID)#1430 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tuhzerifusdmfuif"
      ["timestamp":protected]=>
      NULL
    }
    ["tuhzeriheysaw37b"]=>
    object(Flow\Model\UUID)#1431 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tuhzeriheysaw37b"
      ["timestamp":protected]=>
      NULL
    }
    ["tveyw71m0i6dg853"]=>
    object(Flow\Model\UUID)#1432 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "tveyw71m0i6dg853"
      ["timestamp":protected]=>
      NULL
    }
    ["u1o8skoz326dcd2v"]=>
    object(Flow\Model\UUID)#1433 (4) {
      ["binaryValue":protected]=>
      NULL
      ["hexValue":protected]=>
      NULL
      ["alphadecimalValue":protected]=>
      string(16) "u1o8skoz326dcd2v"
      ["timestamp":protected]=>
      NULL
    }
  }
}
Tue, Jul 3, 6:39 PM · Growth-Team (Current Sprint), Collaboration-Team-Triage, StructuredDiscussions
Esanders created T198742: "TopicListQuery.php: Cannot unpack array with string keys".
Tue, Jul 3, 6:36 PM · Growth-Team (Current Sprint), Collaboration-Team-Triage, StructuredDiscussions
Esanders renamed T145850: While editing on VE, ctrl+click should open the link in a new tab, not opening link inspector from While editing on VE, ctrl+clic should open the link in a new tab, not opening link inspector to While editing on VE, ctrl+click should open the link in a new tab, not opening link inspector.
Tue, Jul 3, 5:15 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-Links, VisualEditor-MediaWiki-Links, VisualEditor (Current work)
Esanders claimed T198565: VE: Broken link to file-description page.
Tue, Jul 3, 4:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki-Media, VisualEditor (Current work)
Esanders moved T145850: While editing on VE, ctrl+click should open the link in a new tab, not opening link inspector from Up next to Code review on the VisualEditor (Current work) board.
Tue, Jul 3, 4:37 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-Links, VisualEditor-MediaWiki-Links, VisualEditor (Current work)
Esanders edited projects for T145850: While editing on VE, ctrl+click should open the link in a new tab, not opening link inspector, added: VisualEditor (Current work); removed VisualEditor.
Tue, Jul 3, 4:37 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-Links, VisualEditor-MediaWiki-Links, VisualEditor (Current work)
Esanders closed T188819: Direct navigation to "external link" tab in VisualEditor as Declined.

Given the scarcity of available keyboard shortcuts, I'm going to decline this for now. There are already accessible ways to enter external links.

Tue, Jul 3, 4:04 PM · VisualEditor
Esanders renamed T198688: Switching between editors on Wikisource, the header and footer are moved into the body from Switching between editors, the header and footer are moved into the body to Switching between editors on WIkiSource, the header and footer are moved into the body.
Tue, Jul 3, 1:31 PM · VisualEditor, ProofreadPage
Esanders added a comment to T198710: Apex theme: Make faux 3D widget gradient more subtle, less gimmicky.

Difference looks very small to me, so don't object.

Tue, Jul 3, 1:30 PM · OOUI (OOUI-0.27.5), UI-Standardization-Kanban, UI-Standardization
Esanders moved T198583: Warning "Toolgroups must have a 'name' property" from Up next to Code review on the VisualEditor (Current work) board.
Tue, Jul 3, 1:25 PM · Verified, VisualEditor-MediaWiki-Mobile, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki
Esanders edited projects for T198583: Warning "Toolgroups must have a 'name' property" , added: VisualEditor (Current work); removed VisualEditor.
Tue, Jul 3, 1:24 PM · Verified, VisualEditor-MediaWiki-Mobile, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki

Mon, Jul 2

Esanders created T198644: Link suggestion context doesn't work with changing selection with keyboard, or by dragging..
Mon, Jul 2, 6:30 PM · ContentTranslation
Esanders renamed T198615: Input focus cannot moved through surface widgets from Input focus cannot moved through some dialog fields to Input focus cannot moved through surface widgets.
Mon, Jul 2, 5:55 PM · Accessibility, VisualEditor
Esanders added a comment to T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.

Accessibility is an important aspect for us. Do you have an example of such problems, with steps to reproduce, so that we could take a closer look? I have been doing some tests but I only found a potential issue with dialogs (T198615), but that does not seem to be CX-specific.

Mon, Jul 2, 4:06 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation
Esanders renamed T194838: rebaser: Issues with reference insertion/editing from 5ucaaaaaaa to rebaser: Issues with reference insertion/editing.
Mon, Jul 2, 3:08 PM · VisualEditor (Current work), MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review

Sat, Jun 30

Esanders added a comment to T190040: [cx2-testing] VE Find and replace dialog doesn't fit in narrow sidebar.

I see scrollbars (non-OSX), but looks even less usable:

Sat, Jun 30, 6:34 PM · ContentTranslation
Esanders renamed T190040: [cx2-testing] VE Find and replace dialog doesn't fit in narrow sidebar from [cx2-testing] VE Find and replace dialog doesn't fit in narrow toolbar to [cx2-testing] VE Find and replace dialog doesn't fit in narrow sidebar.
Sat, Jun 30, 6:33 PM · ContentTranslation
Esanders renamed T190040: [cx2-testing] VE Find and replace dialog doesn't fit in narrow sidebar from [cx2-testing] VE Find toolbox needs horizontal scrolling to [cx2-testing] VE Find and replace dialog doesn't fit in narrow toolbar.
Sat, Jun 30, 6:29 PM · ContentTranslation
Esanders updated subscribers of T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.

There are also serious accessibility issues with breaking the modality of dialog. OOUI adds aria-hidden attributes to elements not in the dialog, and we go to great lengths to prevent the user from accessing elements beneath the dialog using the keyboard (something they would actually want to do now). @Volker_E and @matmarex may have some thoughts on this.

Sat, Jun 30, 6:21 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation
Esanders added a comment to T191011: ve.dm.InternalList#sortGroupIndexes throws javascript error.

We haven't seen this in VE, so this likely something to do with adding references through translation.

Sat, Jun 30, 5:45 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
Esanders added a comment to T198274: [Regression wmf.8?] The textbox size inside Add template dialog is too small on Firefox.

The action fields are using display:table-cell, which means they need a display:table parent. They did when first implemented, but that appears to have been lost during various refactors.

Sat, Jun 30, 11:25 AM · User-Ryasmeen, Verified, Browser-Support-Firefox, VisualEditor-MediaWiki-Templates, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
Esanders updated subscribers of T198274: [Regression wmf.8?] The textbox size inside Add template dialog is too small on Firefox.

Probably caused by T195973 (@Volker_E )

Sat, Jun 30, 11:17 AM · User-Ryasmeen, Verified, Browser-Support-Firefox, VisualEditor-MediaWiki-Templates, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
Esanders moved T198529: List differ gets confused by empty lines being removed from To Triage to TR6: Visual diffs on the VisualEditor board.
Sat, Jun 30, 11:14 AM · VisualEditor-VisualDiffs, VisualEditor
Esanders triaged T198529: List differ gets confused by empty lines being removed as Low priority.
Sat, Jun 30, 11:13 AM · VisualEditor-VisualDiffs, VisualEditor
Esanders created T198529: List differ gets confused by empty lines being removed.
Sat, Jun 30, 11:13 AM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T198456: Users entering small numbers into automatic citations, expecting it to re-use an existing citation.

Seems sensible. If the user enters a 1-3 digit number we should show a warning under the input, telling them to use the 're-use' reference tab instead.

Sat, Jun 30, 10:59 AM · VisualEditor
Esanders renamed T198456: Users entering small numbers into automatic citations, expecting it to re-use an existing citation from Disambigius automatic citations to Users entering small numbers into automatic citations, expecting it to re-use an existing citation.
Sat, Jun 30, 10:51 AM · VisualEditor

Thu, Jun 28

Esanders added a comment to T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link.

From gerrit:
I'd just make this (the default message) 'Remove', for example the comment annotation isn't really 'formatting' and it's clear from the context what it is removing.

Thu, Jun 28, 9:34 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, Patch-For-Review, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy

Wed, Jun 27

Esanders added a comment to T198266: TMH video player frontend fails to initialize on Parsoid HTML format (mwembed).

Merged the above patch, but I think you need to fix videos-in-galleries too.

Wed, Jun 27, 9:32 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), TimedMediaHandler-Player
Jdlrobson awarded T198339: ResourceLoaderImageModule should be able to pull colours from core themes by name a Like token.
Wed, Jun 27, 5:20 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader, Performance-Team
Esanders added a comment to T197909: ResourceLoaderImage module should support a default color.

As discussed in latest FESG meeting: T198339

Wed, Jun 27, 5:01 PM · Patch-For-Review, Performance-Team (Radar), MinervaNeue, MediaWiki-ResourceLoader, Readers-Web-Backlog, Front-end-Standards-Group
Esanders created T198339: ResourceLoaderImageModule should be able to pull colours from core themes by name.
Wed, Jun 27, 5:00 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader, Performance-Team
Esanders created T198332: Always output videos as block level (figure, not figure-inline).
Wed, Jun 27, 2:37 PM · TimedMediaHandler, Parsoid

Tue, Jun 26

Esanders added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

I think the issue is TMH currently only knows about PHP HTML, so doesn't work with Parsoid HTML.

Tue, Jun 26, 1:18 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
Esanders renamed T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile from Regression: Editing workflow broken for non-JS users and template editors to Regression: Editing workflow broken for non-JS users and template editors on mobile.
Tue, Jun 26, 12:58 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, VisualEditor (Current work), MobileFrontend, Mobile, Regression

Mon, Jun 25

Esanders created T198150: 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE.
Mon, Jun 25, 10:39 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work)
Esanders updated subscribers of T196065: CX2: Better communicate the default status in the Automatic Translation card.
Mon, Jun 25, 12:46 PM · Language-2018-Apr-June, ContentTranslation
Esanders added a comment to T196065: CX2: Better communicate the default status in the Automatic Translation card.

We should style the secondary text the same as OOUI menus:

Mon, Jun 25, 12:46 PM · Language-2018-Apr-June, ContentTranslation
Esanders added a comment to T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.

I really don't like the proposed solution here. It breaks the modality of dialogs, and will lead to more problems down the line, e.g. narrower screens (mobile/tablet), wider dialogs (image dialog) or sidebar buttons being clickable when they should be obscured by the modal (causing unexpected action sequences).

Mon, Jun 25, 10:53 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation
Esanders updated the task description for T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.
Mon, Jun 25, 10:42 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation
Esanders moved T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor from Up next to Code review on the VisualEditor (Current work) board.
Mon, Jun 25, 10:11 AM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
Esanders updated the task description for T197951: Show category content when switching from source code to visual editing.
Mon, Jun 25, 10:10 AM · MediaWiki-Categories, VisualEditor-MediaWiki, VisualEditor
Esanders added a project to T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link: Easy.
Mon, Jun 25, 9:59 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, Patch-For-Review, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy

Sun, Jun 24

Esanders added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

Including shortcut keys in buttons

Sun, Jun 24, 6:13 PM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders triaged T198015: Syntax highlighting for 2017 wikitext editor interacts badly with the responsive design mode of Firefox as Low priority.
Sun, Jun 24, 10:43 AM · Community-Tech, MediaWiki-extensions-CodeMirror, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sat, Jun 23

Esanders edited projects for T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor, added: VisualEditor (Current work); removed VisualEditor.
Sat, Jun 23, 8:38 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
Esanders renamed T197972: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message. from Editing a newly inserted citoid citation opens the basic (manual) citation dialog at sdwiki to Citoid not fully set up on sdwiki.
Sat, Jun 23, 2:41 PM · I18n, RTL, VisualEditor, Citoid
Esanders added a comment to T197972: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message..

Looks like there is not template mapping file setup on the wiki:

Sat, Jun 23, 2:41 PM · I18n, RTL, VisualEditor, Citoid
Esanders added a comment to T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined.

The above patch results in a worse rendering of the [collapsible] button in order, at the expense of the CE not crashing:

Sat, Jun 23, 1:21 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders moved T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined from Up next to Code review on the VisualEditor (Current work) board.
Sat, Jun 23, 1:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders edited projects for T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined, added: VisualEditor (Current work); removed VisualEditor.
Sat, Jun 23, 1:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders raised the priority of T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined from Normal to High.
Sat, Jun 23, 1:16 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders added a comment to T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined.

This is the culprit (cc @matmarex):
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/432421/

Sat, Jun 23, 12:38 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders added a comment to T197987: Uncaught TypeError: Cannot read property 'ownerDocument' of undefined.

https://en.wikipedia.org/wiki/All-time_table_of_the_FIFA_World_Cup

Sat, Jun 23, 11:29 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
Esanders added a project to T197990: Visual editor inserts extraneous blank lines (due to <nowiki/> pulled out of paragraph and then disappearing): Parsoid.
Sat, Jun 23, 11:27 AM · VisualEditor-MediaWiki, VisualEditor