Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (263 w, 1 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders created T238155: Text not vertically centred properly on homepage.
Tue, Nov 12, 9:29 PM · ContentTranslation

Mon, Nov 11

Esanders moved T147230: Generate links locally in NWE (new wikitext editor) in trivial cases from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Nov 11, 6:52 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-Performance, VisualEditor-MediaWiki
Esanders edited projects for T147230: Generate links locally in NWE (new wikitext editor) in trivial cases, added: VisualEditor (Current work); removed VisualEditor.
Mon, Nov 11, 6:52 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-Performance, VisualEditor-MediaWiki
Esanders added a comment to T147230: Generate links locally in NWE (new wikitext editor) in trivial cases.

WikiEditor seems to think the only thing that needs escaping is two or more close square brackets, so this should be quite simple.

Mon, Nov 11, 6:52 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-Performance, VisualEditor-MediaWiki

Sat, Nov 9

Esanders added a comment to T234323: Load a single section in Content translation's editor.

We don't necessary need to load full article.

Sat, Nov 9, 1:53 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost
Esanders added a comment to T234323: Load a single section in Content translation's editor.

VE added support for section editing earlier this year (T76541). In your current approach, you are still building the full CE tree, and having it laid out. Setting attachedRoot to the required <section> node in ve.dm.Surface will be much faster :)

Sat, Nov 9, 1:21 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost

Thu, Nov 7

Esanders added a comment to T191566: Using Undo after inserting formatted element resets cursor.

I can't reproduce this.

Thu, Nov 7, 2:04 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T233972: Keyboard shortcut puts � into the page, instead of opening the correct dialog.

I can't reproduce this is Safari 11 or 13. Is this still happening for you @Whatamidoing-WMF or was it just a Safari 12 issue?

Thu, Nov 7, 1:57 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T222249: 2017WTE loses focus after making a link.

This was probably a regression around link inspector refactoring, but appears to have been fixed. Can you confirm @Whatamidoing-WMF ?

Thu, Nov 7, 1:00 PM · VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Wed, Nov 6

Esanders moved T157956: NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected from Incoming to QA on the VisualEditor (Current work) board.
Wed, Nov 6, 7:13 PM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders edited projects for T157956: NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected, added: VisualEditor (Current work); removed VisualEditor.
Wed, Nov 6, 7:13 PM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders moved T201561: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Nov 6, 7:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders edited projects for T201561: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line, added: VisualEditor (Current work); removed VisualEditor.
Wed, Nov 6, 7:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders changed the status of T190291: 2017 source editor - copy/paste issues in iOS from Open to Stalled.

Works fine for me in iOS13.

Wed, Nov 6, 5:54 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T201561: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line.

The OSX terminal produces HTML, with each line wrapped in a <p>:

<style type="text/css">
p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Menlo; color: #000000; background-color: #ffffff}
span.s1 {font-variant-ligatures: no-common-ligatures}
</style>
Wed, Nov 6, 5:53 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders committed rEASR59e6602229e3: build: Update linters (authored by Esanders).
build: Update linters
Wed, Nov 6, 4:10 PM
Esanders updated the task description for T171616: Font size changes, and then the editor crashes.
Wed, Nov 6, 2:17 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T157956: NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected.

The issue here is that middle-click clone only triggers a paste event, and not a copy event, so the data is written to the clipboard from the CE selection, and not by our special copy handling code. This issue affects visual mode too, in that all formatting is lost.

Wed, Nov 6, 1:40 PM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
Esanders closed T156906: Insertion of linear model's annotation stack as plain text into the page after paste in Safari somehow as Resolved.

Stalled for over 2 years and not reported since.

Wed, Nov 6, 1:16 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Tue, Nov 5

Esanders updated subscribers of T164954: Be able to re-use a citoid citation in VisualEditor's wikitext mode.
Tue, Nov 5, 10:40 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders committed rWGPI00779f6741d6: eslint: Enable valid-jsdoc (authored by Esanders).
eslint: Enable valid-jsdoc
Tue, Nov 5, 6:02 PM
Esanders committed rWGPI0acea00c3831: Avoid Array.prototype.includes (authored by Esanders).
Avoid Array.prototype.includes
Tue, Nov 5, 6:00 PM
Esanders committed rWGPI3f7690268031: eslint: Enable no-jquery/no-event-shorthand (authored by Esanders).
eslint: Enable no-jquery/no-event-shorthand
Tue, Nov 5, 6:00 PM
Esanders committed rWGPI4fc633eacf61: eslint: Enable no-comma-dangle (authored by Esanders).
eslint: Enable no-comma-dangle
Tue, Nov 5, 6:00 PM
Esanders committed rWGPIf85372faa40d: eslint: Enable no-jquery/variable-pattern (authored by Esanders).
eslint: Enable no-jquery/variable-pattern
Tue, Nov 5, 5:57 PM
Esanders committed rWGPIe1c0677ddd2e: eslint: Enable quote-props (authored by Esanders).
eslint: Enable quote-props
Tue, Nov 5, 5:57 PM
Esanders committed rWGPI096b7cc553cb: eslint: Enable some basic rules (authored by Esanders).
eslint: Enable some basic rules
Tue, Nov 5, 5:55 PM
Esanders committed rWGPI672ae3759edf: eslint: Enable whitespace rules (authored by Esanders).
eslint: Enable whitespace rules
Tue, Nov 5, 5:55 PM
Esanders committed rWGPIbf81e5094d02: build: Replace jshint with eslint and add test script (authored by Esanders).
build: Replace jshint with eslint and add test script
Tue, Nov 5, 5:53 PM
Esanders added a comment to T233470: Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open.

I've merged this patch so it will go out on Thursday.

Tue, Nov 5, 2:18 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Editing QA, Editing Design, VisualEditor (Current work), Patch-For-Review

Mon, Nov 4

Esanders added a comment to T237289: Vertical alignment regressions in desktop link contexts.

It does, but the height addition is useful in increasing the click target, so I added negative margin instead.

Mon, Nov 4, 7:47 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders moved T237289: Vertical alignment regressions in desktop link contexts from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Nov 4, 7:38 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders edited projects for T237289: Vertical alignment regressions in desktop link contexts, added: VisualEditor (Current work); removed VisualEditor.
Mon, Nov 4, 7:38 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders updated subscribers of T237289: Vertical alignment regressions in desktop link contexts.

cc @Volker_E @matmarex

Mon, Nov 4, 6:34 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders added a comment to T237289: Vertical alignment regressions in desktop link contexts.

Bisect unsurprisingly blames an OOUI update. v0.35.1 :)

Mon, Nov 4, 6:30 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders created T237289: Vertical alignment regressions in desktop link contexts.
Mon, Nov 4, 5:59 PM · Verified, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), VisualEditor-Links
Esanders moved T231815: Consider removing toolbar borders from Design and Product Analytics review to Code review on the VisualEditor (Current work) board.
Mon, Nov 4, 4:23 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

If I get around to updating this, we many need to check the configs currently deployed:

$ mwgrep citationNeeded
enwiki              MediaWiki:Visualeditor-template-tools-definition.json
hewiki              MediaWiki:Visualeditor-template-tools-definition.json
lvwiki              MediaWiki:Visualeditor-template-tools-definition.json
slwiki              MediaWiki:Visualeditor-template-tools-definition.json
Mon, Nov 4, 3:36 PM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders added a comment to T228230: Add "✔️" into link modal.

Yes, OOUI icons are localisable. However if the checkmark is deemed to not be universal it should be fixed upstream in OOUI as it would apply to every use of it, not just in VE, so would be out of scope for this ticket.

Mon, Nov 4, 2:39 PM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design

Sat, Nov 2

Esanders committed rECIR979203238bbc: eslint: Enable prefer-const (authored by Esanders).
eslint: Enable prefer-const
Sat, Nov 2, 12:28 AM
Esanders committed rECIR3c9deabe6580: build: Update linters (authored by Esanders).
build: Update linters
Sat, Nov 2, 12:28 AM

Fri, Nov 1

Esanders updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Fri, Nov 1, 10:21 PM · Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018
Esanders added a comment to T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).

CirrusSearch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/490331/

Fri, Nov 1, 10:20 PM · Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018
Esanders added a comment to T237126: UploadWizard Upload interface messed up.

Thanks for the fix!

Fri, Nov 1, 9:09 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), UploadWizard
Esanders updated the task description for T236944: The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on the target system.
Fri, Nov 1, 8:50 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Desktop Improvements, VisualEditor, Readers-Web-Backlog (Tracking), Performance-Team (Radar), MediaWiki-General
Jdforrester-WMF awarded T161601: Consider square icon-only buttons for toolbar tools a Like token.
Fri, Nov 1, 6:31 PM · OOUI
Esanders added a comment to T235796: The ext.3d.styles module should not be added unconditionally to every page and should set target mobile.

The 3D viewer doesn't work on mobile yet because it requires MMV.

Fri, Nov 1, 6:14 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking), 3D
Esanders awarded T234907: RFC: Where to implement Desktop Improvements project a Party Time token.
Fri, Nov 1, 5:28 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC
Esanders added a project to T223775: Change "Media" to "Images and media" in the visual editor toolbar: Skipped QA.
Fri, Nov 1, 5:27 PM · Skipped QA, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), WikiEditor, VisualEditor (Current work), User-Zoranzoki21, Wikimedia-Hackathon-2019, good first bug
Esanders renamed T223775: Change "Media" to "Images and media" in the visual editor toolbar from Change "Media" to "Photos and media" in the visual editor toolbar to Change "Media" to "Images and media" in the visual editor toolbar.
Fri, Nov 1, 5:26 PM · Skipped QA, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), WikiEditor, VisualEditor (Current work), User-Zoranzoki21, Wikimedia-Hackathon-2019, good first bug
Esanders committed rSMNB3314ffcc06a7: build: Update linters (authored by Esanders).
build: Update linters
Fri, Nov 1, 2:18 AM

Thu, Oct 31

Esanders added a comment to T233470: Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open.

Did a brief test on iOS 12.4 on crossbrowsertesting, and it seemed to work:

Thu, Oct 31, 8:40 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Editing QA, Editing Design, VisualEditor (Current work), Patch-For-Review
Esanders added a comment to T233470: Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open.

Yes, I put this on the prototype for testing. I found an issue when scrolling a long way (~2-3 pages worth?).

Thu, Oct 31, 3:18 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Editing QA, Editing Design, VisualEditor (Current work), Patch-For-Review
Esanders created T237019: Spacing between icons and labels is too large in tablet mode.
Thu, Oct 31, 2:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Design, MinervaNeue, MobileFrontend
Esanders updated the task description for T237018: Section expand/collapse icons should be centred. not top-aligned.
Thu, Oct 31, 2:24 PM · Readers-Web-Backlog (Design), Design, MobileFrontend
Esanders created T237018: Section expand/collapse icons should be centred. not top-aligned.
Thu, Oct 31, 2:23 PM · Readers-Web-Backlog (Design), Design, MobileFrontend
Esanders created T237015: Regression: Scroll position lost when closing reference preview.
Thu, Oct 31, 2:06 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend
Esanders added a comment to T233470: Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open.

This is much better!

Thu, Oct 31, 12:21 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Editing QA, Editing Design, VisualEditor (Current work), Patch-For-Review

Wed, Oct 30

Esanders updated subscribers of T236958: 1.35.0-wmf.4: Wikilove background image no longer displayed.

This was broken by a change in Vector: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/545904/

Wed, Oct 30, 9:48 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-DannyS712, Growth-Team, WikiLove
Esanders added a comment to T236958: 1.35.0-wmf.4: Wikilove background image no longer displayed.
Wed, Oct 30, 9:41 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-DannyS712, Growth-Team, WikiLove
Esanders created T236931: Disabled progressive tools have incorrect opacity.
Wed, Oct 30, 5:36 PM · OOUI, VisualEditor
Esanders moved T230400: Replace old unofficial Indian rupee symbol ₨ with ₹ in "Special character(s) > Symbols" section from Code review to Product owner review on the VisualEditor (Current work) board.
Wed, Oct 30, 3:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, WikiEditor
Esanders added a project to T234601: Have the References list tool insert a References header if not present on the page: good first bug.
Wed, Oct 30, 2:39 PM · good first bug, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T227686: Investigate mapping PHP HTML to Parsoid HTML for talk page features.

In my current patch (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DiscussionTools/+/545615/) I am just assuming the comment trees are identical, and aligning comments left to right. This could probably be made more robust by looking a tree position.

Wed, Oct 30, 2:24 PM · VisualEditor (Current work), OWC2020
Esanders closed T227686: Investigate mapping PHP HTML to Parsoid HTML for talk page features as Resolved.
Wed, Oct 30, 2:22 PM · VisualEditor (Current work), OWC2020
Esanders moved T230400: Replace old unofficial Indian rupee symbol ₨ with ₹ in "Special character(s) > Symbols" section from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Oct 30, 2:21 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, WikiEditor
Esanders edited projects for T230400: Replace old unofficial Indian rupee symbol ₨ with ₹ in "Special character(s) > Symbols" section, added: VisualEditor (Current work); removed VisualEditor.
Wed, Oct 30, 2:21 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, WikiEditor
Esanders added a comment to T230400: Replace old unofficial Indian rupee symbol ₨ with ₹ in "Special character(s) > Symbols" section.

This needs to be added to each Indian script like Telugu, Tamil, Kannada, Devanagari, Gujarati and in Symbols section

Wed, Oct 30, 2:20 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, WikiEditor
Esanders moved T226604: After replacing last match, still one match shown from In progress to Code review on the VisualEditor (Current work) board.
Wed, Oct 30, 2:10 PM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Esanders moved T226604: After replacing last match, still one match shown from Code review to In progress on the VisualEditor (Current work) board.
Wed, Oct 30, 2:03 PM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Esanders added a comment to T231245: Search and replace leaves bogus text highlight at the end.

Actually they're slightly different.

Wed, Oct 30, 2:02 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders reopened T231245: Search and replace leaves bogus text highlight at the end as "Open".
Wed, Oct 30, 2:02 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders moved T226604: After replacing last match, still one match shown from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Oct 30, 2:01 PM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Esanders edited projects for T226604: After replacing last match, still one match shown, added: VisualEditor (Current work); removed VisualEditor.
Wed, Oct 30, 2:01 PM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Esanders merged T231245: Search and replace leaves bogus text highlight at the end into T226604: After replacing last match, still one match shown.
Wed, Oct 30, 2:00 PM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Esanders merged task T231245: Search and replace leaves bogus text highlight at the end into T226604: After replacing last match, still one match shown.
Wed, Oct 30, 2:00 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders moved T231245: Search and replace leaves bogus text highlight at the end from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Oct 30, 2:00 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders edited projects for T231245: Search and replace leaves bogus text highlight at the end, added: VisualEditor (Current work); removed VisualEditor.
Wed, Oct 30, 1:59 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders added a comment to T231245: Search and replace leaves bogus text highlight at the end.

Confirmed in VE standalone.

Wed, Oct 30, 1:54 PM · Verified, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work)
Esanders added a comment to T236220: As a contributor I want to know why references pasted from read mode do not appear in VE.

As discussed offline, we may want to consider the case where the user selects and copies a single reference differently to the case where the user selects a block of text containing multiple references.

Wed, Oct 30, 1:51 PM · VisualEditor
Esanders moved T236247: Collapsible elements are not visible in VisualEditor from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Oct 30, 1:48 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
Esanders edited projects for T236247: Collapsible elements are not visible in VisualEditor, added: VisualEditor (Current work), VisualEditor-ContentEditable; removed MW-1.33-release, VisualEditor.
Wed, Oct 30, 1:47 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
Esanders added a comment to T236658: Rephrase "for now can only be edited/previewed in source mode".

The messages are:

"cite-ve-referenceslist-missingref": "This reference is defined in a template or other generated block, and for now can only be edited in source mode.",
"cite-ve-referenceslist-missingref-in-list": "This reference is defined in a template or other generated block, and for now can only be previewed in source mode.",
"cite-ve-referenceslist-missingreflist": "This reference list is generated by a template, and for now can only be edited in source mode.",
Wed, Oct 30, 1:28 PM · Design, Cite, VisualEditor
Esanders added a comment to T236840: Enable VisualEditor Extension on bn.wikibooks at রন্ধনপ্রণালী (cookbook) Namespace .

This indeed looks like a namespace for article-like content, and not discussions, so this seems like a reasonable request.

Wed, Oct 30, 1:23 PM · User-Ryasmeen, User-Majavah, VisualEditor, Wikimedia-Site-requests, Bengali-Sites

Tue, Oct 29

Esanders added a comment to T221603: Disabled progressive buttons in MobileFrontend header should be gray, not 50% opacity.

Looks like it was the disabled "Next" button in the mobile wikitext editor, and was fixed by the attached patch:

Tue, Oct 29, 7:46 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MobileFrontend
Esanders moved T236802: Blank page when CX is used without Cite from To Triage to External and Administrivia on the VisualEditor board.
Tue, Oct 29, 7:28 PM · Cite, VisualEditor, ContentTranslation
Esanders added a comment to T234907: RFC: Where to implement Desktop Improvements project.

I don't think we want to be in a situation where have to maintain more skins, especially no more skins with significant user bases. The amount of support we need to give each skin is proportional to the number of people using it. Accordingly monobook gets very little attention, but this is mostly accepted by the community. If we end up in a situation where VectorNew is the default for new users, but because it diverged too quickly, most of the experienced community is still using VectorClassic for gadget support or comfort, then this will translate into an increased developer burden.

Tue, Oct 29, 7:22 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Mon, Oct 28

Esanders added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

The two VE prototype servers are going to require a fair bit of work to migrate, and probably wouldn't take priority in our current workload - but we are actively using them. The togetherjs and dumpgrepper servers were setup by @cscott and maybe @ssastry respectively. I asked in the past if these can be deleted and got a "probably? we should check..." response.

Mon, Oct 28, 12:20 PM · VisualEditor, Cloud-VPS (Debian Jessie Deprecation)

Fri, Oct 25

Volker_E awarded T211243: Add a useful call-to-action in the context for citation needed templates a Like token.
Fri, Oct 25, 6:36 PM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

This wouldn't help with param mapping, although at the moment those are unused.

Fri, Oct 25, 3:44 PM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

I was pointed to the CitationHunt tool, which mentions in the code that all or most wikis have a redirect at "Template:Citation needed" to the local canonical version (https://github.com/eggpi/citationhunt/blob/1fbf340f68c8539ed087ba52e40d06e343f3b5c4/config.py)

Fri, Oct 25, 2:42 PM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki
Esanders added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

We need to add some documentation for this but to set this up you just need to copy the configuration file from https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-template-tools-definition.json to your wiki, then change the list under "title" to be the titles of templates uses on your wiki for citation needed.

Fri, Oct 25, 9:49 AM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki

Thu, Oct 24

Esanders edited projects for T236400: Surface not deactivating for inspector when using nullSelectionOnBlur, added: VisualEditor (Current work); removed VisualEditor.
Thu, Oct 24, 5:10 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020
Esanders added a parent task for T236400: Surface not deactivating for inspector when using nullSelectionOnBlur: T234403: Create a VE-based text input for replying.
Thu, Oct 24, 4:03 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020
Esanders added a subtask for T234403: Create a VE-based text input for replying: T236400: Surface not deactivating for inspector when using nullSelectionOnBlur.
Thu, Oct 24, 4:03 PM · VisualEditor (Current work), Editing-team, OWC2020
Esanders updated the task description for T236400: Surface not deactivating for inspector when using nullSelectionOnBlur.
Thu, Oct 24, 3:56 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020
Esanders updated the task description for T236400: Surface not deactivating for inspector when using nullSelectionOnBlur.
Thu, Oct 24, 3:54 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020
Esanders added a project to T236400: Surface not deactivating for inspector when using nullSelectionOnBlur: StructuredDiscussions.
Thu, Oct 24, 3:52 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020
Esanders created T236400: Surface not deactivating for inspector when using nullSelectionOnBlur.
Thu, Oct 24, 3:51 PM · Verified, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), VisualEditor (Current work), StructuredDiscussions, Growth-Team, OWC2020

Tue, Oct 22

Esanders renamed T236210: Replace EasyDeflate with faster library from Replace EasyDeflate with fast library to Replace EasyDeflate with faster library.
Tue, Oct 22, 8:28 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team (Radar)