Esanders (Ed Sanders)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (152 w, 48 m)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF)

Recent Activity

Today

Esanders added a comment to T176646: Image inspector obscures caption.

After patch:

Mon, Sep 25, 4:02 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, VisualEditor-Media, VisualEditor
Esanders created T176646: Image inspector obscures caption.
Mon, Sep 25, 3:47 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, VisualEditor-Media, VisualEditor
Esanders triaged T176425: visual editor inserts a reference tag as High priority.
Mon, Sep 25, 2:32 PM · User-Ryasmeen, Patch-For-Review, Parsoid, VisualEditor
Esanders added a comment to T176425: visual editor inserts a reference tag.

Looks like the reference wrapper is going breaking Parsoid's about grouping:

Mon, Sep 25, 2:32 PM · User-Ryasmeen, Patch-For-Review, Parsoid, VisualEditor
Esanders added a project to T176425: visual editor inserts a reference tag: Parsoid.
Mon, Sep 25, 2:20 PM · User-Ryasmeen, Patch-For-Review, Parsoid, VisualEditor
Esanders created T176626: Language selector at top of suggested pages, suggests languages that don't have wikis.
Mon, Sep 25, 1:00 PM · ContentTranslation
Esanders added a comment to T174481: Unable to switch to View from Edit.

The easiest fix would be to move #mw-page-header-links above #firstHeading and then visually re-order then with CSS.

Mon, Sep 25, 10:12 AM · MediaWiki-extensions-Translate, VisualEditor, Timeless
Esanders added a comment to T174481: Unable to switch to View from Edit.

Not to do with translate. VE expects navigation tabs to come before firstHeading, in Timeless they are after so that get treated like a sub heading and get greyed-out and disabled.

Mon, Sep 25, 10:08 AM · MediaWiki-extensions-Translate, VisualEditor, Timeless
Esanders updated subscribers of T159292: In IE 11 cursor moves to the next line while adding a Page Title/heading etc..

Sounds like a slugging issue. Pinging @dchan

Mon, Sep 25, 10:03 AM · VisualEditor-ContentEditable, Browser-Support-Internet-Explorer, VisualEditor
Esanders added a comment to T176034: Handle tabs of IndexLayout that don't fit on the screen horizontally (scrolling or wrapping).

And what about the ellipsis approach? (which browsers use for multiple tabs...)

Mon, Sep 25, 9:32 AM · Patch-For-Review, OOjs-UI

Yesterday

Esanders renamed T176442: Previews of some interwiki links do not work as expected in link inspector from Previews of some interwiki links do not work as expected in parsoid preview to Previews of some interwiki links do not work as expected in link inspector.
Sun, Sep 24, 3:48 PM · VisualEditor, VisualEditor-MediaWiki-Links
Esanders edited projects for T176571: Fix the automatic cite feature of VisualEditor in Sundanese Wikipedia, added: Citoid; removed Wikimedia-General-or-Unknown, Cite.
Sun, Sep 24, 3:46 PM · Citoid, VisualEditor

Sat, Sep 23

Esanders added a comment to T176034: Handle tabs of IndexLayout that don't fit on the screen horizontally (scrolling or wrapping).

Do we have to support this? Button groups neither wrap nor scroll, you are just supposed to design your interface around that :)

Sat, Sep 23, 1:35 PM · Patch-For-Review, OOjs-UI

Fri, Sep 22

Esanders updated subscribers of T176212: CX requires Node 6 because of JSDOM.

Sure, whatever the services team is happy with (@ssastry, @GWicke?). Also https://www.mediawiki.org/wiki/Content_translation/cxserver/Setup should be updated.

Fri, Sep 22, 4:44 PM · Language-2017-July-Sept, Patch-For-Review, ContentTranslation-CXserver, ContentTranslation
Esanders added a comment to T176474: 'Live update' button animation draws attention to wrong place.

The speed of the animation may also be a factor. Looking at that page with the fast pulsing makes me feel agitated :) The pulsing on the education popups is much more pedestrian.

Fri, Sep 22, 11:57 AM · Collaboration-Team-Triage, Design, Edit-Review-Improvements-RC-Page
Esanders created T176474: 'Live update' button animation draws attention to wrong place.
Fri, Sep 22, 11:56 AM · Collaboration-Team-Triage, Design, Edit-Review-Improvements-RC-Page

Thu, Sep 21

Esanders added a comment to T176425: visual editor inserts a reference tag.

Doesn't sound like a problem with VE, just the user doing what they shouldn't.

Thu, Sep 21, 9:14 PM · User-Ryasmeen, Patch-For-Review, Parsoid, VisualEditor
Esanders updated subscribers of T176440: Undefined variable: content in ApiVisualEditor.

Looks like a regression from the preload patch. Pinging @DLynch

Thu, Sep 21, 9:06 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, VisualEditor, Wikimedia-log-errors

Wed, Sep 20

Esanders added a comment to T157212: Make translation dashboard layout responsive to adapt to small screens.

Wouldn't it be better to show labels and icons in the wide version, that way users can become familiar with the meaning of the icons should they then go on to use a smaller screen size?

Wed, Sep 20, 2:02 PM · Patch-For-Review, User-Petar.petkovic, ContentTranslation

Tue, Sep 19

Esanders added a comment to T176265: Block images lose captions when moved.

The above patch fixes symptom but not the cause. Pinging @dchan

Tue, Sep 19, 9:00 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Regression, VisualEditor-MediaWiki, VisualEditor
Esanders triaged T176265: Block images lose captions when moved as Unbreak Now! priority.
Tue, Sep 19, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Regression, VisualEditor-MediaWiki, VisualEditor
Esanders created T176265: Block images lose captions when moved.
Tue, Sep 19, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Regression, VisualEditor-MediaWiki, VisualEditor
Esanders merged T176216: Support <references responsive /> into T159894: Add support to Parsoid's cite code for `responsive` parameter.
Tue, Sep 19, 2:32 PM · User-Ryasmeen, Patch-For-Review, Parsoid, VisualEditor-MediaWiki-References, VisualEditor, Cite
Esanders merged task T176216: Support <references responsive /> into T159894: Add support to Parsoid's cite code for `responsive` parameter.
Tue, Sep 19, 2:32 PM · Parsoid
Esanders added a subtask for T53260: Support editing <references /> tags to set multi-column display on/off: T176216: Support <references responsive />.
Tue, Sep 19, 2:29 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, VisualEditor-MediaWiki-References, VisualEditor, Design, Cite
Esanders added a parent task for T176216: Support <references responsive />: T53260: Support editing <references /> tags to set multi-column display on/off.
Tue, Sep 19, 2:29 PM · Parsoid
Esanders created T176216: Support <references responsive />.
Tue, Sep 19, 2:28 PM · Parsoid
Esanders added a comment to T175989: Switching between Visual Editor and Wikitexteditor may result in loose of responsive-Keyword.

I think this is a dupe/side-effect of T53260

Tue, Sep 19, 2:19 PM · VisualEditor
Esanders added a comment to T175953: OOjs UI: Support Responsive Toolbars.

VE Mobile is currently using context-sensitive toolbars, similar to Google Docs mobile, such that when the document is not focused you see navigation and document-level tools:

Tue, Sep 19, 2:00 PM · UI-Standardization-Kanban, UI-Standardization, OOjs-UI
Esanders created T176212: CX requires Node 6 because of JSDOM.
Tue, Sep 19, 1:34 PM · Language-2017-July-Sept, Patch-For-Review, ContentTranslation-CXserver, ContentTranslation
TheDJ awarded T175863: Minerva causes Special:JavaScriptTest to fail in debug mode a Doubloon token.
Tue, Sep 19, 11:08 AM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Readers-Web-Backlog, MinervaNeue

Mon, Sep 18

Esanders updated subscribers of T176066: JavaScript freeze/loop when editing or adding references.

I think TreeModifier could be to blame, emitting more events than we used to and causing the list to rebuild many more times. Pinging @dchan .

Mon, Sep 18, 2:34 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor
Esanders updated the task description for T176066: JavaScript freeze/loop when editing or adding references.
Mon, Sep 18, 1:45 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor
Esanders added a comment to T176066: JavaScript freeze/loop when editing or adding references.

The above patch fixes the symptom if not the cause.

Mon, Sep 18, 12:12 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor
Esanders added a comment to T175059: Insertions with references too easily cause rebase conflicts.
Mon, Sep 18, 11:52 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor
Esanders added a comment to T176066: JavaScript freeze/loop when editing or adding references.

The problem is they have started using the <references> tag again, which is a good thing because it means the ref list updates dynamically. Unfortunately the large wikis have been using {{references}} templates for so long that we haven't noticed the performance issues.

Mon, Sep 18, 11:47 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor

Fri, Sep 15

Esanders updated the task description for T150652: Content Translation feature parity checklist post VisualEditor integration.
Fri, Sep 15, 1:53 PM · WorkType-NewFunctionality, Design, Contributors-Team, VisualEditor, ContentTranslation

Thu, Sep 14

Esanders updated the task description for T171451: Stop showing excessive moves when moving a paragraph across the page.
Thu, Sep 14, 1:12 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T150652: Content Translation feature parity checklist post VisualEditor integration.

Presently you can add a link to the source text

Thu, Sep 14, 10:57 AM · WorkType-NewFunctionality, Design, Contributors-Team, VisualEditor, ContentTranslation

Wed, Sep 13

Esanders created T175863: Minerva causes Special:JavaScriptTest to fail in debug mode.
Wed, Sep 13, 8:22 PM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Readers-Web-Backlog, MinervaNeue
Esanders added a project to T175852: Firefox throws an exception every time enter is pressed: Regression.
Wed, Sep 13, 6:50 PM · User-Ryasmeen, Patch-For-Review, Regression, VisualEditor-ContentEditable, VisualEditor
Esanders triaged T175852: Firefox throws an exception every time enter is pressed as High priority.

regression introduce in TreeModifier commit

Wed, Sep 13, 6:50 PM · User-Ryasmeen, Patch-For-Review, Regression, VisualEditor-ContentEditable, VisualEditor
Esanders created T175852: Firefox throws an exception every time enter is pressed.
Wed, Sep 13, 6:34 PM · User-Ryasmeen, Patch-For-Review, Regression, VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T173618: MultimediaViewer uses an old version of jquery.scrollTop which is broken for Chrome 61.

What is the purpose of this lib? Why not use $(window).scrollTop()?

Wed, Sep 13, 5:53 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Multimedia, MediaWiki-extensions-MultimediaViewer, JavaScript, Browser-Support-Google-Chrome
Esanders added a comment to T173618: MultimediaViewer uses an old version of jquery.scrollTop which is broken for Chrome 61.

Chrome 61 is now released as stable, and this breaks MV badly.

Wed, Sep 13, 5:46 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Multimedia, MediaWiki-extensions-MultimediaViewer, JavaScript, Browser-Support-Google-Chrome
Esanders created T175843: Input events which occur away from the current ContentBranchNode do not get observed.
Wed, Sep 13, 5:25 PM · VisualEditor-ContentEditable, VisualEditor
Esanders triaged T175828: [wmf.18] VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs) as Unbreak Now! priority.
Wed, Sep 13, 2:25 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Browser-Support-Internet-Explorer, VisualEditor, VisualEditor-MediaWiki
Esanders updated subscribers of T175828: [wmf.18] VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs).

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

Wed, Sep 13, 2:03 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Browser-Support-Internet-Explorer, VisualEditor, VisualEditor-MediaWiki

Tue, Sep 12

Esanders added a project to T57370: VisualEditor: Implement some form of auto-save: Front-end-Standards-Group.
Tue, Sep 12, 8:18 PM · Front-end-Standards-Group, Epic, VisualEditor, VisualEditor-MediaWiki
Esanders added a comment to T57370: VisualEditor: Implement some form of auto-save.

do our own memory management

Tue, Sep 12, 8:00 PM · Front-end-Standards-Group, Epic, VisualEditor, VisualEditor-MediaWiki
Esanders added a comment to T57370: VisualEditor: Implement some form of auto-save.

silently fail when the user's machine either has local storage disabled or is full?

Tue, Sep 12, 7:56 PM · Front-end-Standards-Group, Epic, VisualEditor, VisualEditor-MediaWiki
Esanders closed T85468: Undoing the insertion of a template leaves almost all of the toolbar grayed out as Resolved.

Probably fixed at some point in the last 2.75 years

Tue, Sep 12, 7:33 PM · User-Ryasmeen, VisualEditor
Esanders closed T67713: VisualEditor: Undo/redo should not (?) remain active when surface is blurred as Declined.
Tue, Sep 12, 7:31 PM · VisualEditor, VisualEditor-ContentEditable
Esanders created T175734: History tools not updating state in standalone demo.
Tue, Sep 12, 7:18 PM · User-Ryasmeen, VisualEditor-EditingTools, Patch-For-Review, Regression, VisualEditor
Esanders added a comment to T175634: "Undo" doesn't work from mouse (Chrome/Linux).

The patch will only work on the very latest versions of Chrome (>=60), and MobileSafari (10.0 with WebKit >603). On any other browser it is basically impossible to know that the user requested an 'undo'. So the best we can do (and we already do) is observe the change the system makes, and record the transaction.

Tue, Sep 12, 6:50 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, Browser-Support-Google-Chrome, VisualEditor
Esanders added a comment to T175634: "Undo" doesn't work from mouse (Chrome/Linux).

Unfortunately this doesn't fire a reliable event. In Chrome it looks like you get event.inputType = 'historyUndo' / 'historyRedo', but in FF you get nothing (and I imagine IE).

Tue, Sep 12, 1:56 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, Browser-Support-Google-Chrome, VisualEditor
Esanders created T175688: Non-JS reply input is too wide.
Tue, Sep 12, 1:32 PM · Patch-For-Review, Collaboration-Team-Triage, StructuredDiscussions
Esanders created T175683: 'Edit description' button jumps right a few pixels after loading.
Tue, Sep 12, 12:57 PM · Patch-For-Review, StructuredDiscussions, Collaboration-Team-Triage
Esanders created T175682: FOUC on Flow's "Start a new topic" input.
Tue, Sep 12, 12:46 PM · StructuredDiscussions, Collaboration-Team-Triage
Esanders updated subscribers of T175548: Exception when unbulleting the final bullet of a list.

Should we be reverting TreeModifier again before release then? @Deskana @Jdforrester-WMF

Tue, Sep 12, 10:57 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor

Mon, Sep 11

Esanders updated subscribers of T175417: VE table columns editing is destroyed in RTL.

Pinging @DLynch

Mon, Sep 11, 9:18 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Regression, RTL, VisualEditor, I18n

Sun, Sep 10

Esanders added a comment to T175489: Lost session data after browser or system crash.

Basically a duplicate of T57370

Sun, Sep 10, 7:39 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sat, Sep 9

Esanders added a comment to T175446: 2017 wikitext editor doesn't load when I want to undo an edit.

This is T114531 or T78550

Sat, Sep 9, 10:08 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T174774: Editing captions in Firefox is so unpredictable as to be useless.

Interesting, the moz documentation doesn't mention the prefixed value: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select

Sat, Sep 9, 7:40 PM · Patch-For-Review, Verified, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-Media, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor
Esanders created T175449: Allow special keys in keyboard shortcuts to be translated.
Sat, Sep 9, 11:13 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), VisualEditor-EditingTools, User-Ryasmeen, I18n, VisualEditor

Fri, Sep 8

Esanders added a comment to T175417: VE table columns editing is destroyed in RTL.

Bisect blames https://gerrit.wikimedia.org/r/#/c/363619/1

Fri, Sep 8, 10:19 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Regression, RTL, VisualEditor, I18n
Esanders added a comment to T174774: Editing captions in Firefox is so unpredictable as to be useless.

If putting display:block inside display:table is going to trigger mystery browser bugs we should definitely avoid it. So I'd suggest we revisit that decision on the figure DOM structure, and attach the zoom icon back to the figcaption. IIRC the only downside to that was that the icon wouldn't show if the caption was empty, but that could either be ignored or worked around.

Fri, Sep 8, 8:36 PM · Patch-For-Review, Verified, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-Media, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor
Esanders updated subscribers of T174774: Editing captions in Firefox is so unpredictable as to be useless.

Looks like this is a regression caused by https://gerrit.wikimedia.org/r/#/c/366898/ (pinging @Arlolra), which changed figcaptions to be display:block inside display:table, instead of display:table-caption. We discussed the invalidness of this at the time, but it didn't appear to be problematic. Now it does...

Fri, Sep 8, 7:55 PM · Patch-For-Review, Verified, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-Media, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T174774: Editing captions in Firefox is so unpredictable as to be useless.

Looks like a browser bug, if we don't set -moz-user-select: none on ve-ce-focusableNode * and then reset it to text on ve-ce-activeNode it works fine. Strangely it works in standalone, where the CSS is very similar.

Fri, Sep 8, 7:48 PM · Patch-For-Review, Verified, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-Media, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T174774: Editing captions in Firefox is so unpredictable as to be useless.

Interestingly it works fine in the standalone demo, so must just be some MW weirdness...

Fri, Sep 8, 6:53 PM · Patch-For-Review, Verified, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-Media, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor
Esanders created T175366: Support VE source mode (NWE) in Flow.
Fri, Sep 8, 1:43 PM · StructuredDiscussions, VisualEditor-MediaWiki-2017WikitextEditor, Collaboration-Team-Triage, VisualEditor
Esanders added a comment to T175237: Resize an image floating close to a list moves the bullets.

Can you link to a page? That looks a lot like a browser bug, so there may be nothing we can do...

Fri, Sep 8, 11:07 AM · VisualEditor
Esanders created T175352: Clipping fails in PopupToolGroup when next to the right edge of the screen.
Fri, Sep 8, 11:03 AM · OOjs-UI

Thu, Sep 7

Esanders added a comment to T175250: Add cancel button to parameter editing dialog in GUI TD editor.

The difficulty here is that changes to the fields update the model instantly, not just when 'done' is pressed, so there would need to be a significant refactoring to support a 'cancel' option.

Thu, Sep 7, 11:09 AM · TemplateData, VisualEditor
Esanders added a comment to T175250: Add cancel button to parameter editing dialog in GUI TD editor.

It's provided by the TemplateData extension, written VE and former-VE members to support VE's template editing.

Thu, Sep 7, 11:02 AM · TemplateData, VisualEditor

Wed, Sep 6

Esanders updated subscribers of T175157: Copy-paste of template-generated link from a subpage in VE gives the wrong href.

Pinging @Catrope.

Wed, Sep 6, 4:22 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, VisualEditor

Tue, Sep 5

Esanders added a comment to T172141: Removal of template parameter inside the reference tag not shown in changes.

Sounds like bad wikitext then, close as invalid?

Tue, Sep 5, 2:45 PM · VisualEditor, VisualEditor-VisualDiffs

Mon, Sep 4

Esanders merged T174846: VE: Ghost rectangle after changing image alignment into T129541: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it .
Mon, Sep 4, 7:36 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Verified, User-Ryasmeen, VisualEditor-ContentEditable, Regression, VisualEditor
Esanders merged T174846: VE: Ghost rectangle after changing image alignment into T129541: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it .
Mon, Sep 4, 7:36 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Verified, User-Ryasmeen, VisualEditor-ContentEditable, Regression, VisualEditor
Esanders merged task T174846: VE: Ghost rectangle after changing image alignment into T129541: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it .
Mon, Sep 4, 7:36 PM · VisualEditor
Esanders merged task T174846: VE: Ghost rectangle after changing image alignment into T129541: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it .
Mon, Sep 4, 7:36 PM · VisualEditor
Esanders added a comment to T174892: Image caption only works with the "Thumbnail" image type, but Visual Editor doesn't make it clear.

There is a very old bug around redesigning the media dialog somewhere. There were also some technical reasons for keeping the caption if it can still appear in the wikitext (even if it doesn't render), but I agree it is odd.

Mon, Sep 4, 5:25 PM · VisualEditor, Design

Thu, Aug 31

Esanders added a comment to T160791: Allow people to put a MenuToolGroup in a ButtonGroupWidget.

The list group doesn't style properly when disabled.

Thu, Aug 31, 11:22 AM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.21.1), Patch-For-Review, VisualEditor

Wed, Aug 30

Esanders added a comment to T172361: Visual diff on historical diffs shows changes for date-dependent content.

I'm not sure it's possible to tell the parser to render the page as it was on a certain day. A related issue would be that templates used change independently of the article, as even parser logic/installed extensions may have changed, so any rendering of an old version is actually today's rendering of that day's wikitext, it isn't generally possible to recover the HTML on a specific day.

Wed, Aug 30, 10:44 PM · User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor
Esanders updated the task description for T150652: Content Translation feature parity checklist post VisualEditor integration.
Wed, Aug 30, 7:31 PM · WorkType-NewFunctionality, Design, Contributors-Team, VisualEditor, ContentTranslation

Tue, Aug 29

Esanders created T174497: ActionSet does not work as documented.
Tue, Aug 29, 8:43 PM · OOjs-UI
Esanders added a comment to T174464: Typing enter to complete unicode character entry also adds a line break.

Here's mine:

[
	{"imeIdentifier":"","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0","startDom":""},
	{"seq":0,"time":2.434,"action":"sendEvent","args":["keydown",{"keyCode":17}]},
	{"seq":1,"time":2.437,"action":"endLoop","args":[]},
	{"seq":2,"time":2.443,"action":"sendEvent","args":["keydown",{"keyCode":16}]},
	{"seq":3,"time":2.444,"action":"endLoop","args":[]},
	{"seq":4,"time":2.895,"action":"sendEvent","args":["compositionstart",{}]},
	{"seq":5,"time":2.897,"action":"changeText","args":["u"]},
	{"seq":6,"time":2.897,"action":"changeSel","args":[1,1]},
	{"seq":7,"time":2.897,"action":"sendEvent","args":["input",{}]},
	{"seq":8,"time":2.898,"action":"endLoop","args":[]},
	{"seq":9,"time":3.738,"action":"changeText","args":["u0"]},
	{"seq":10,"time":3.738,"action":"changeSel","args":[2,2]},
	{"seq":11,"time":3.738,"action":"sendEvent","args":["input",{}]},
	{"seq":12,"time":3.74,"action":"endLoop","args":[]},
	{"seq":13,"time":3.922,"action":"changeText","args":["u00"]},
	{"seq":14,"time":3.922,"action":"changeSel","args":[3,3]},
	{"seq":15,"time":3.922,"action":"sendEvent","args":["input",{}]},
	{"seq":16,"time":3.927,"action":"endLoop","args":[]},
	{"seq":17,"time":4.218,"action":"changeText","args":["u00e"]},
	{"seq":18,"time":4.218,"action":"changeSel","args":[4,4]},
	{"seq":19,"time":4.218,"action":"sendEvent","args":["input",{}]},
	{"seq":20,"time":4.221,"action":"endLoop","args":[]},
	{"seq":21,"time":4.386,"action":"changeText","args":["u00e9"]},
	{"seq":22,"time":4.386,"action":"changeSel","args":[5,5]},
	{"seq":23,"time":4.386,"action":"sendEvent","args":["input",{}]},
	{"seq":24,"time":4.389,"action":"endLoop","args":[]},
	{"seq":25,"time":4.698,"action":"changeText","args":["<br>"]},
	{"seq":26,"time":4.698,"action":"changeSel","args":[0,0]},
	{"seq":27,"time":4.698,"action":"sendEvent","args":["input",{}]},
	{"seq":28,"time":4.701,"action":"sendEvent","args":["compositionend",{}]},
	{"seq":29,"time":4.702,"action":"sendEvent","args":["input",{}]},
	{"seq":30,"time":4.703,"action":"sendEvent","args":["compositionstart",{}]},
	{"seq":31,"time":4.704,"action":"changeText","args":["é<br>"]},
	{"seq":32,"time":4.704,"action":"changeSel","args":[1,1]},
	{"seq":33,"time":4.704,"action":"sendEvent","args":["compositionend",{}]},
	{"seq":34,"time":4.707,"action":"sendEvent","args":["input",{}]},
	{"seq":35,"time":4.711,"action":"endLoop","args":[]},
	{"seq":36,"time":4.809,"action":"sendEvent","args":["keyup",{"keyCode":13}]},
	{"seq":37,"time":4.811,"action":"endLoop","args":[]}
]
Tue, Aug 29, 8:17 PM · VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T174464: Typing enter to complete unicode character entry also adds a line break.
  1. Can you go here: https://doc.wikimedia.org/VisualEditor/master/lib/ve/demos/ve/eventLogger.html
  2. Click "Start Logging..."
  3. Type your unicode sequence
  4. Click in the giant text area and copy the contents, then paste here.
Tue, Aug 29, 6:52 PM · VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T174464: Typing enter to complete unicode character entry also adds a line break.

I can't reproduce in Ubuntu 16.04, Chrome/Firefox. Sounds like a broken IME implementation in that distro... :/

Tue, Aug 29, 6:48 PM · VisualEditor-ContentEditable, VisualEditor
Esanders updated subscribers of T174464: Typing enter to complete unicode character entry also adds a line break.

IME issue for @dchan

Tue, Aug 29, 6:46 PM · VisualEditor-ContentEditable, VisualEditor
Esanders added a project to T174464: Typing enter to complete unicode character entry also adds a line break: VisualEditor-ContentEditable.
Tue, Aug 29, 6:45 PM · VisualEditor-ContentEditable, VisualEditor
Esanders updated the task description for T150652: Content Translation feature parity checklist post VisualEditor integration.
Tue, Aug 29, 6:02 PM · WorkType-NewFunctionality, Design, Contributors-Team, VisualEditor, ContentTranslation
Esanders added a comment to T170223: Remove 'browser default' as an option for the 'editfont' user preference option.

Yes, let's, before people starting using it!

Tue, Aug 29, 3:37 PM · Patch-For-Review, MediaWiki-User-preferences
Esanders added a comment to T174202: [Regression wmf.15?] The "Remove field" icon is appearing inside the field for Cite journal template.

Looks like the buttons got wider and so ran out of room on one line.

Tue, Aug 29, 1:29 PM · User-Ryasmeen, Verified, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Regression, VisualEditor
Esanders updated subscribers of T174202: [Regression wmf.15?] The "Remove field" icon is appearing inside the field for Cite journal template.

...and @Volker_E

Tue, Aug 29, 1:21 PM · User-Ryasmeen, Verified, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Regression, VisualEditor

Mon, Aug 28

Esanders added a comment to T174268: Copy-paste inserts paragraph into top line, instead of inserting text at correct position, in Visual Editor (due to Emoji Keyboard extension).

Paste works fine for me - can you give more precise steps with the exact way you copied the text, if reproducible?

Mon, Aug 28, 2:47 PM · VisualEditor, VisualEditor-CopyPaste

Sun, Aug 27

Esanders added a comment to T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror.

So it turns out CodeMirror has a CE mode as well (inputStyle: 'contenteditable'). They still disable spellchecking, and when I override that it seemed to work okay, although it moved the cursor to the wrong place after using it. It probably handles RTL and IMEs better, so it seems like a better system.

Sun, Aug 27, 5:12 PM · User-notice, Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-CodeMirror
Esanders updated subscribers of T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror.

The VE surface was designed to use all the built in features of ContentEditable (such as spell check and RTL support) and @dchan has spent a lot of time making sure that when you use these features it synchronises directly to the model. I can't envision CodeMirror addressing these problems any time soon, but the way VE integration works is we use the VE surface as an invisible input, and only use CodeMirror for colouring, by rendering underneath VE.

Sun, Aug 27, 11:24 AM · User-notice, Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-CodeMirror

Aug 25 2017

Esanders created T174180: Allow extensions to disable VE.
Aug 25 2017, 5:08 PM · Technical-Debt, VisualEditor-MediaWiki, VisualEditor
Esanders created T174169: Too much left padding in Flow.
Aug 25 2017, 3:04 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, StructuredDiscussions