Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (475 w, 12 h)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders moved T304579: Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive) from Design Review to Code Review on the Editing-team (Kanban Board) board.
Tue, Dec 5, 12:23 AM · Patch-For-Review, Editing-team (Kanban Board), Design, TPP-Phase1, Goal, DiscussionTools

Yesterday

Esanders created T352708: Edit check reference change "no survey" page has scrollbar in Arabic.
Mon, Dec 4, 6:25 PM · VisualEditor
Esanders closed T347363: Ensure Edit Check is sufficiently translated for partner wikis, a subtask of T331947: [RELEASE TICKET] Make Edit Check MVP available to all newcomers at Partner Wikipedias, as Resolved.
Mon, Dec 4, 6:23 PM · Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T347363: Ensure Edit Check is sufficiently translated for partner wikis as Resolved.

Verified

image.png (325×445 px, 39 KB)

Mon, Dec 4, 6:23 PM · Editing QA, Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders closed T345096: Show new topics subscription button on history pages as Resolved.
Mon, Dec 4, 6:18 PM · Verified, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), DiscussionTools
Esanders moved T345096: Show new topics subscription button on history pages from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Mon, Dec 4, 6:18 PM · Verified, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T333709: [CONSULT] Collaborate with volunteers to define Edit Check key results.
Mon, Dec 4, 6:11 PM · Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
Esanders renamed T304579: Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive) from Define user experience for when it is ambiguous what page permalink should lead you to to Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive).
Mon, Dec 4, 3:39 PM · Patch-For-Review, Editing-team (Kanban Board), Design, TPP-Phase1, Goal, DiscussionTools
Esanders moved T349653: Permalink redirecting: Support plain section links from Doing to Code Review on the Editing-team (Kanban Board) board.
Mon, Dec 4, 3:37 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders created T352661: Gadget source code pages should show user count, or default status, when viewing or editing.
Mon, Dec 4, 12:57 PM · Patch-For-Review, MediaWiki-extensions-Gadgets

Sun, Dec 3

Esanders added a comment to T352591: Show page-level discussion statistics.

It might be useful for people to get a sense for the activity of a page if we also showed at least the "X people are commenting"

Sun, Dec 3, 7:48 PM · Editing-team (Design Backlog), Editing Design, DiscussionTools

Fri, Dec 1

Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

I've applied my own fix with @disksance 's blessing and things appear to be working now.

Fri, Dec 1, 3:19 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

This still sets an href, it just sets the href to the current page. Now click on OOUI tools reload the page. The fix to the library (https://github.com/wikimedia-gadgets/VariantAlly/pull/5) should cause it to skip over non-href <a> tags.

Fri, Dec 1, 2:48 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352501: Navigation error caused by "VariantAlly" gadget: "Page not found: /w/undefined".

Appears to the VariantAlly script: https://github.com/wikimedia-gadgets/VariantAlly/issues/4

Fri, Dec 1, 2:26 PM · Reading-Web-Local-Wiki-Issues, Chinese-Sites
Esanders added a comment to T352526: Enable visual editor in the property talk namespace on Wikidata.

We generally don't enable VE on talk namespaces, as it doesn't support indented discussion threads well. One can still add ?veaction=edit to the URL to force the visual editor to load.

Fri, Dec 1, 2:02 PM · VisualEditor, Wikidata
Esanders added a comment to T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.

I've moved 11 of the remaining 37 pages, but the other 26 will require someone with more rights across all wikis.

Fri, Dec 1, 1:36 PM · Technical-Debt, VisualEditor, Cite

Thu, Nov 30

Esanders added a comment to T350270: Mobile Reply: enter+backspace strange behavior.

May have been fixed since T312558. Is this still broken @Ponor ?

Thu, Nov 30, 6:28 PM · Editing-team, VisualEditor-ContentEditable, VisualEditor, DiscussionTools
Esanders updated the task description for T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.
Thu, Nov 30, 6:01 PM · Technical-Debt, VisualEditor, Cite
Esanders updated the task description for T264183: Move visualeditor-cite-tool-definition.json to cite-tool-definition.json.
Thu, Nov 30, 6:00 PM · Technical-Debt, VisualEditor, Cite
Esanders added a comment to T351529: Assist with linking to article sections within the Reply Tool.

That is T52881. While that would make fragment linking easier, this task argues that a specific tool for quickly linking to sections of the page you are talking about would be helpful tool.

Thu, Nov 30, 5:57 PM · DiscussionTools
Esanders added a comment to T352455: DiscussionTools handle out of range dates.

I looked into this a bit, and the problem isn't the year is 0 (both our PHP and JS timestamp libraries support the non-existent year 0).

Thu, Nov 30, 5:35 PM · Patch-For-Review, DiscussionTools
Esanders added a comment to T352455: DiscussionTools handle out of range dates.

so that comment with invalid timestamps can be replied to

Thu, Nov 30, 4:40 PM · Patch-For-Review, DiscussionTools
Esanders added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

^ core patch has broken DT headings:

image.png (481×1 px, 80 KB)

Thu, Nov 30, 11:24 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
Esanders added a comment to T249893: Add "Thanks" to talk page comments.

I don’t agree. What users can and cannot thank should be a product/design decision informed by technical possibilities, not a purely technical decision.

Thu, Nov 30, 10:54 AM · Patch-Needs-Improvement, DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks

Wed, Nov 29

Esanders added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

You will also need to inherit wikimedia/jsdoc instead of wikimedia/jsduck in eslintrc.

Wed, Nov 29, 2:19 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Tech-Docs-Team, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Esanders moved T352289: Reply link icon not shown in language variants of designated "short reply button" languages from Incoming to Code Review on the Editing-team (Kanban Board) board.
Wed, Nov 29, 1:58 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders claimed T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:58 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders updated the task description for T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:51 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders created T352289: Reply link icon not shown in language variants of designated "short reply button" languages.
Wed, Nov 29, 1:46 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing QA, Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_.

Thanks, done.

Wed, Nov 29, 1:07 PM · Patch-For-Review, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders updated the task description for T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_.
Wed, Nov 29, 1:07 PM · Patch-For-Review, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools

Tue, Nov 28

Esanders added a comment to T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.

Clarifying what this patch does:

  • Applies to anyone who has visual enhancements enabled (either via the beta feature (which exposes the new preference as enabled by default), the A/B test on certain wikis, or by being on mobile where enhancements are always enabled)
  • Enables visual enhancements whenver the __NEWSECTIONLINK__ marker is present (as opposed to only in talk namespaces)
  • However this does not apply in the article namespace, unless the article namespace is in wgExtraSignatureNamespaces (such as on mediawiki.org)
    • This prevents our styling ever applying to Wikipedia articles, even if a user accidentally adds the marker to that page.
Tue, Nov 28, 6:29 PM · Patch-For-Review, CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders updated the task description for T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.
Tue, Nov 28, 5:57 PM · Patch-For-Review, CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
Esanders closed T351530: Exception thrown when typing `#...` into the link inspector as Resolved.
Tue, Nov 28, 1:21 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), VisualEditor

Mon, Nov 27

Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

You can override the gutter with this user CSS:

.client-js .mw-editform #wpTextbox1 {
  margin-left: 0;
  width: 100%;
}
Mon, Nov 27, 5:33 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

Who benefits from this?

Anyone switching between highlighting and not highlighting. It also removes the jitter while CodeMirror is loading, which was the original reason for the change. Any fix would add even more complexity for little benefit.

Mon, Nov 27, 5:31 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T349622: [design] Notifications (mw.notify) are a long way from the content on wide screens.

Presumably just limiting the patch to fixed width Vector 2022, and leaving as-is in other situations, would be fine (an improvement on the status quo)?

Mon, Nov 27, 4:09 PM · Web-Team-Backlog (FY2023-24 Q2 Sprint 5), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Desktop Improvements (Vector 2022)
Esanders added a comment to T52881: VisualEditor: Link input widget should suggest section links.

3 & 4 are fixed. 1 is more complicated as it requires more interaction between VE and this core component (VE needs to override the list of available sections, rather than use an API call). I think that should probably be fixed later.

Mon, Nov 27, 4:03 PM · Patch-For-Review, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools, Browser-Support-Google-Chrome

Wed, Nov 22

Esanders added a comment to T52881: VisualEditor: Link input widget should suggest section links.

Thanks for the feedback.
1 sounds useful and should be fixable.
I think points 2-3 can be addressed later in follow ups.
4 should be fixed, we should replace underscores when normalising.
5: if you start typing # immediately you get no page name. Removing the page name could arguably be a Parsoid job, or something we should leave in if the user types it explicitly, but we could remove it locally.

Wed, Nov 22, 7:57 AM · Patch-For-Review, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools, Browser-Support-Google-Chrome

Fri, Nov 17

Esanders created T351530: Exception thrown when typing `#...` into the link inspector.
Fri, Nov 17, 1:46 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), VisualEditor
Esanders created T351529: Assist with linking to article sections within the Reply Tool.
Fri, Nov 17, 1:41 PM · DiscussionTools
Esanders renamed T265269: Assist with linking to other comments within the Reply Tool from Assist with linking to other comments within the LinkInspector to Assist with linking to other comments within the Reply Tool.
Fri, Nov 17, 1:39 PM · DiscussionTools
Esanders updated subscribers of T351487: Gutter doesn't disappear after disabling code editor.
Fri, Nov 17, 1:05 PM · Patch-For-Review, CodeEditor
Esanders added a comment to T351487: Gutter doesn't disappear after disabling code editor.

I would call this a feature. When toggling between plain and code height the content will not jump and reflow, and you won't lose your place.

Fri, Nov 17, 1:05 PM · Patch-For-Review, CodeEditor
Esanders created T351515: Fragment with '%20' in plain text doesn't round trip.
Fri, Nov 17, 1:02 PM · Parsoid
Esanders closed T308390: Avoid direct link to edit non-existing talk pages in Minerva as Resolved.

DT mobile is deployed everywhere.

Fri, Nov 17, 12:51 PM · DiscussionTools, MinervaNeue

Thu, Nov 16

Esanders added a comment to T351448: Extra right padding inside username autocompletion dropdown.

Note that we disable clipping in CSS in this widget:

.ve-ui-completionWidget .oo-ui-popupWidget-body {
	/* The contained MenuSelectWidget is already clipped (T330401) */
	/* TODO: This could be done in JS if OO.ui.ClippableElement provided a way to disable clipping */
	overflow: hidden !important; /* stylelint-disable-line declaration-no-important */
}
Thu, Nov 16, 6:49 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
Esanders added a comment to T351448: Extra right padding inside username autocompletion dropdown.

Looks like this is caused by scrollbar-gutter: stable.

Thu, Nov 16, 6:46 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
Esanders created T351448: Extra right padding inside username autocompletion dropdown.
Thu, Nov 16, 6:37 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools

Sat, Nov 11

Esanders added a project to T351011: Remove unused module dependencies from DiscussionTools: Technical-Debt.
Sat, Nov 11, 5:37 PM · Technical-Debt, DiscussionTools

Thu, Nov 9

Esanders added a comment to T350902: Cannot read properties of undefined (reading 'getRange').

I assumed this was related to https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/966217 but that hasn't been merged yet...

Thu, Nov 9, 6:47 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, Wikimedia-production-error

Wed, Nov 8

Esanders moved T349261: Introduce an API to enable editing interfaces to offer feedback about reference reliability from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
Wed, Nov 8, 4:17 PM · Patch-For-Review, SpamBlacklist, Editing-team (Kanban Board), Community-Wishlist-Survey-2023, EditCheck, VisualEditor
Esanders added a comment to T350777: 1.42.0-wmf.4: Structured Data on Wikimedia Commons not longer available.
Wed, Nov 8, 3:56 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), WikibaseMediaInfo, Structured-Data-Backlog, Wikidata, SDC General, Regression

Tue, Nov 7

ppelberg awarded T349622: [design] Notifications (mw.notify) are a long way from the content on wide screens a Love token.
Tue, Nov 7, 6:46 PM · Web-Team-Backlog (FY2023-24 Q2 Sprint 5), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Desktop Improvements (Vector 2022)
Esanders added a comment to T346424: Visual diff: jQuery.Deferred exception: char1.match is not a function.

Testing with diff_match_patch.prototype.diff_cleanupSemanticLossless = function() {} in the console, output looks reasonable again:

Tue, Nov 7, 4:55 PM · VisualEditor, VisualEditor-VisualDiffs

Mon, Nov 6

Esanders placed T350570: Visual editor preview overlaps with Vector 2022 header up for grabs.
Mon, Nov 6, 11:26 AM · Regression, Desktop Improvements (Vector 2022), VisualEditor
Esanders reopened T350570: Visual editor preview overlaps with Vector 2022 header as "Open".
Mon, Nov 6, 11:26 AM · Regression, Desktop Improvements (Vector 2022), VisualEditor
Esanders closed T350570: Visual editor preview overlaps with Vector 2022 header as Resolved.

Caused by teleport changes?

Mon, Nov 6, 11:25 AM · Regression, Desktop Improvements (Vector 2022), VisualEditor
Esanders closed T350528: Avoid pinging a user in their own talk page while writing a message using DiscussionTools as Declined.

Thanks for bringing it to our attention.

Mon, Nov 6, 10:43 AM · DiscussionTools

Sun, Nov 5

Esanders moved T160588: VisualDiffs: Show annotation creations and removals in the sidebar from In progress to Backlog on the VisualEditor-VisualDiffs board.
Sun, Nov 5, 1:38 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), VisualEditor-VisualDiffs, VisualEditor-EditingTools, VisualEditor
Esanders updated the task description for T349622: [design] Notifications (mw.notify) are a long way from the content on wide screens.
Sun, Nov 5, 1:34 PM · Web-Team-Backlog (FY2023-24 Q2 Sprint 5), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Desktop Improvements (Vector 2022)
Esanders closed T350032: Diff of templates in table detects unchanged templates as changed as Resolved.

After:

image.png (966×1 px, 189 KB)

Sun, Nov 5, 1:22 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, VisualEditor-VisualDiffs
Esanders closed T332791: Some unchanged table cells shown as empty in visual diff as Resolved.

Fixed by https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/969952/2

Sun, Nov 5, 1:21 PM · VisualEditor-VisualDiffs, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

We could also consider IndexedDB which has a much larger quota.

Sun, Nov 5, 1:17 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), VisualEditor, VisualEditor-MediaWiki

Nov 4 2023

Esanders moved T344629: Top align buttons (expand/collapse and ellipsis) within mobile headings from Incoming to QA on the Editing-team (Kanban Board) board.
Nov 4 2023, 11:41 AM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Design, DiscussionTools
Esanders edited projects for T344629: Top align buttons (expand/collapse and ellipsis) within mobile headings, added: Editing-team (Kanban Board); removed Editing-team.
Nov 4 2023, 11:41 AM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Design, DiscussionTools
Esanders added a comment to T332791: Some unchanged table cells shown as empty in visual diff.

Could be a duplicate of T350032

Nov 4 2023, 9:56 AM · VisualEditor-VisualDiffs, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T350528: Avoid pinging a user in their own talk page while writing a message using DiscussionTools.

IIRC we make sure only one notification is sent in this situation. I don't think we need to complicate the interface with this logic when the extra mention is harmless. Arguably it keeps the user in the good habit of mentioning people they want to ensure get notified.

Nov 4 2023, 8:35 AM · DiscussionTools

Nov 3 2023

Esanders updated subscribers of T318259: Changes inside wiktionary NavFrame's don't show.

Wiktionary don't use mw-collapsible for their boxes, but a custom gadget https://en.wiktionary.org/wiki/MediaWiki:Gadget-defaultVisibilityToggles.js. This task is about fixing an on-wiki gadget to use the correct hooks.

Nov 3 2023, 4:08 PM · VisualEditor, MediaWiki-Interface (collapsible elements), VisualEditor-VisualDiffs
Esanders renamed T318259: Changes inside wiktionary NavFrame's don't show from Changes inside collapsed templates don't show to Changes inside wiktionary NavFrame's don't show.
Nov 3 2023, 4:08 PM · VisualEditor, MediaWiki-Interface (collapsible elements), VisualEditor-VisualDiffs
Esanders added a comment to T224429: Hunt and remove unused i18n messages in mediawiki core.

Example output:

image.png (1×792 px, 170 KB)

Nov 3 2023, 1:29 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), translatewiki.net, Wikimania-Hackathon-2019, I18n, MediaWiki-Internationalization
Esanders added a comment to T350450: No subscribe links for VillagePump / bar on mobile.

This would be fixed by T331635

Nov 3 2023, 9:08 AM · Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T224429: Hunt and remove unused i18n messages in mediawiki core.

I wrote a script to search the current codebase for existing messages, either in the code or documentation:

Nov 3 2023, 8:23 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), translatewiki.net, Wikimania-Hackathon-2019, I18n, MediaWiki-Internationalization

Nov 1 2023

Esanders added a comment to T337698: Non-existent localisation message ⧼visualeditor-listbutton-undefined-tooltip⧽ appears in a visual diff.

T324354 may be related

Nov 1 2023, 6:46 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T337698: Non-existent localisation message ⧼visualeditor-listbutton-undefined-tooltip⧽ appears in a visual diff.

Looks like the differ is detecting a DefinitionList changing to a List (numbered or bullet), but our description code can't handle that. Not sure if we should consider definition lists as comparable to bullet/numbered lists or not...

Nov 1 2023, 6:44 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders updated the task description for T338278: Heading moved while changing levels mislabelled in visual diff.
Nov 1 2023, 6:36 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T338278: Heading moved while changing levels mislabelled in visual diff.

The heading is labelled with "Moved down" when it was actually moved up

Nov 1 2023, 6:36 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added projects to T350270: Mobile Reply: enter+backspace strange behavior: VisualEditor, VisualEditor-ContentEditable.
Nov 1 2023, 5:57 PM · Editing-team, VisualEditor-ContentEditable, VisualEditor, DiscussionTools
Esanders moved T326500: The new talk pages should not send posts by pressing enter from Code Review to QA on the Editing-team (Kanban Board) board.
Nov 1 2023, 5:53 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T350270: Mobile Reply: enter+backspace strange behavior.

Could be T202719

Nov 1 2023, 5:40 PM · Editing-team, VisualEditor-ContentEditable, VisualEditor, DiscussionTools

Oct 30 2023

Esanders claimed T349866: Subscribe link is misaligned.
Oct 30 2023, 4:05 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools
Esanders moved T349866: Subscribe link is misaligned from Upcoming to Untriaged on the Editing-team board.
Oct 30 2023, 4:05 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools
Esanders moved T349866: Subscribe link is misaligned from Backlog to Triaged on the DiscussionTools board.
Oct 30 2023, 4:04 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools
Esanders created T350032: Diff of templates in table detects unchanged templates as changed.
Oct 30 2023, 1:43 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T242562: Develop a technical approach for editing a specific comment.

See also T242999

Oct 30 2023, 1:39 PM · DiscussionTools

Oct 29 2023

Esanders added a comment to T349866: Subscribe link is misaligned.

snap

Oct 29 2023, 6:11 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T349866: Subscribe link is misaligned.

Regression caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/857542 (cc @matmarex)

Oct 29 2023, 6:11 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools
Esanders added a comment to T275572: Inappropriate line breaks inserted when editing in the visual mode.

This is clearly not happening regularly, and I can't reproduce it, but it seems likely related to wrapper paragraph logic. We did change this recently to fix a similar bug (T348467), but there is an instance form 2022 that pre-dates this.

Oct 29 2023, 12:55 PM · DiscussionTools
Esanders removed a project from T275572: Inappropriate line breaks inserted when editing in the visual mode: Parsoid.
Oct 29 2023, 12:49 PM · DiscussionTools
Esanders added a project to T275572: Inappropriate line breaks inserted when editing in the visual mode: Parsoid.
Oct 29 2023, 8:34 AM · DiscussionTools
Esanders added a comment to T275572: Inappropriate line breaks inserted when editing in the visual mode.

From T349871:

Oct 29 2023, 8:34 AM · DiscussionTools

Oct 28 2023

Esanders added a comment to T349653: Permalink redirecting: Support plain section links.

(Currently a fragment with random characters gives a notification "This comment could not be found. It might have been deleted or moved." – is that expected? Also maybe unsuccessful lookup should be reflected in the notification text as well.)

Oct 28 2023, 2:17 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)

Oct 26 2023

Esanders updated subscribers of T349653: Permalink redirecting: Support plain section links.

CC @SD0001 & @Jack_who_built_the_house

Oct 26 2023, 5:45 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders updated the task description for T349653: Permalink redirecting: Support plain section links.
Oct 26 2023, 5:44 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders updated the task description for T349653: Permalink redirecting: Support plain section links.
Oct 26 2023, 5:40 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders updated the task description for T349653: Permalink redirecting: Support plain section links.
Oct 26 2023, 5:39 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders added a comment to T349653: Permalink redirecting: Support plain section links.

Demo: https://patchdemo.wmflabs.org/wikis/fd311f2936/wiki/Talk:DiscussionTools#Where_to_post_SQL_requests

Oct 26 2023, 5:21 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
Esanders added a comment to T348482: Visual Editor template editor dialog should allow more room for Alternative text.

However, it might be worth seeing if there's anything out there that this might cause issues for first...

Oct 26 2023, 12:31 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), VisualEditor-MediaWiki-Templates, VisualEditor
Esanders moved T349319: Wrap lines in alt-text input in media dialog from Code Review to QA on the Editing-team (Kanban Board) board.
Oct 26 2023, 12:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor
Esanders updated the task description for T349319: Wrap lines in alt-text input in media dialog.
Oct 26 2023, 12:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor