Esanders (Ed Sanders)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (160 w, 3 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF)

Recent Activity

Today

Esanders created T181230: data-mw autoGenerated applied to ref list <ol>, not wrapper.
Thu, Nov 23, 12:41 PM · Parsoid
Esanders added a comment to T181229: Content after reference tag in template disappears.

Possibly related to about group re-parenting (T176425).

Thu, Nov 23, 12:38 PM · Parsoid
Esanders created T181229: Content after reference tag in template disappears.
Thu, Nov 23, 12:35 PM · Parsoid
Esanders created T181226: Don't output section wrappers in body_only mode.
Thu, Nov 23, 12:24 PM · Parsoid

Tue, Nov 21

Esanders added a comment to T180427: Align betafeature SVGs to each other.

NB there is also a template file in the BF extension itself: screenshot-template-ltr/rtl.svg

Tue, Nov 21, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Readers-Web-Backlog (Tracking), UI-Standardization
Esanders created T181063: 'Reply' button is enabled even if nothing has been typed.
Tue, Nov 21, 4:13 PM · User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), StructuredDiscussions
Esanders added a comment to T117790: Convert Special:EditWatchlist to OOUI.

The latest OOUI packs the checkboxes a lot closer together:

Tue, Nov 21, 3:27 PM · MediaWiki-Watchlist, Patch-Needs-Improvement, Patch-For-Review, UI-Standardization
Esanders added a comment to T180949: A URL with a < in it can't be added using VE.

WFM in Chrome/Firefox. Can anyone else reproduce?

Tue, Nov 21, 2:56 PM · VisualEditor
Esanders added a comment to T181030: Vertical scrollbar does not appear in diffs view in Safari.

It is a deliberate feature of OSX that it doesn't show the scroll bar until you start scrolling. This is also true when you are reading pages. Suggest we decline.

Tue, Nov 21, 2:52 PM · Browser-Support-Apple-Safari, VisualEditor-VisualDiffs, VisualEditor

Mon, Nov 20

Esanders added a comment to T180393: Find behaves strangely in preview in Safari.

We set aria-hidden on content when OOUI modals are open, but it looks like browsers don't respect this. Unless there's another attribute for hiding content, there's not much we can do short of detaching the whole page from the DOM

Mon, Nov 20, 12:23 PM · Browser-Support-Apple-Safari, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sun, Nov 19

Esanders added a comment to T180890: Icons not visible in Windows' high contrast dark mode.

The text is visible, but the icons (which are black) aren't.

Sun, Nov 19, 8:01 PM · OOjs-UI, VisualEditor, Accessibility
Esanders renamed T180890: Icons not visible in Windows' high contrast dark mode from On Edge, in high contrast mode, the text of some visual editor tabs is not shown to Icons not visible in Windows' high contrast dark mode.
Sun, Nov 19, 8:01 PM · OOjs-UI, VisualEditor, Accessibility
Esanders updated subscribers of T180890: Icons not visible in Windows' high contrast dark mode.
Sun, Nov 19, 7:06 PM · OOjs-UI, VisualEditor, Accessibility
Esanders added a project to T180824: Parsoid should use <br/> to handle paragraph tags in single-line-mode wikitext constructs like list items: Parsoid.
Sun, Nov 19, 6:57 PM · Parsoid
Esanders added a comment to T180824: Parsoid should use <br/> to handle paragraph tags in single-line-mode wikitext constructs like list items.

Current pressing shift-enter in a list splits the paragraph:

Sun, Nov 19, 6:56 PM · Parsoid

Sat, Nov 18

Esanders renamed T180848: Citoid depends on newer version of OOUI that MediaWiki 1.29 contains from VisualEditor/citoid unknown JS error to Citoid depends on newer version of OOUI that MediaWiki 1.29 contains.
Sat, Nov 18, 1:40 PM · Citoid, VisualEditor
Esanders added a comment to T180848: Citoid depends on newer version of OOUI that MediaWiki 1.29 contains.

Looks like TabPanelLayout was first included in OOUI 0.21.3 (https://gerrit.wikimedia.org/r/#/c/337220/), whereas MediaWiki 1.29 shipped with 0.21.1. Whereas the first version of Citoid to use it was before the 1.29 cut (https://gerrit.wikimedia.org/r/#/c/354096/).

Sat, Nov 18, 1:39 PM · Citoid, VisualEditor
Esanders added a comment to T169306: Change tablecell style menu to take into account scope attribute.

The choice of cells for markup for row headers and row scope is rather more problematical. Priority should be on adding scope for column headers as that should be easily achievable and much less likely to encounter opposition.

The other really significant addition would be for VisualEditor to encourage editors to add a caption by setting the default property to 'on', but whether that should be considered in this thread or separately is debatable.

Sat, Nov 18, 1:02 PM · VisualEditor-Tables, VisualEditor-EditingTools, Accessibility, VisualEditor
Esanders added a comment to T169306: Change tablecell style menu to take into account scope attribute.

Just a quick note about the downside here: This markup, although officially recommended at enwiki, is almost never used at any wiki, even in Featured Articles (where it is nominally required). When this is implemented, I think we can reasonably expect experienced editors to be surprised, and therefore to complain about the visual mode adding "unnecessary" markup and creating dirty diffs every time a table is touched.

We should implement it anyway.

Sat, Nov 18, 1:02 PM · VisualEditor-Tables, VisualEditor-EditingTools, Accessibility, VisualEditor
Esanders merged T180867: Support scope for columns and rows in tables into T169306: Change tablecell style menu to take into account scope attribute.
Sat, Nov 18, 1:01 PM · VisualEditor-Tables, VisualEditor-EditingTools, Accessibility, VisualEditor
Esanders merged task T180867: Support scope for columns and rows in tables into T169306: Change tablecell style menu to take into account scope attribute.
Sat, Nov 18, 1:01 PM · VisualEditor, VisualEditor-Tables

Fri, Nov 17

Esanders committed rERSL44d7504798f4: i18n: Refer to 'RevisionSlider' as 'revision slider' consistently (authored by Esanders).
i18n: Refer to 'RevisionSlider' as 'revision slider' consistently
Fri, Nov 17, 6:14 PM
Esanders added a comment to T180138: PHP DropdownInputWidget layout broken on Firefox 57.

Looks like it will be fixed upstream soon. Will this affect any other CSS in MediaWiki?

Fri, Nov 17, 5:03 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, MediaWiki-HTMLForm, OOjs-UI, Browser-Support-Firefox
Esanders added a comment to T180678: Text and selection are shifted.

Finding this hard to reproduce. Note that these errors will probably be the result of specific page content and viewport width, so if you come across this error, record the exact page and revision (or wikitext) and the viewport width, by opening the console (in portrait mode) and typing innerWidth.

Fri, Nov 17, 4:30 PM · VisualEditor, SyntaxHighlight, VisualEditor-MediaWiki-2017WikitextEditor
Esanders updated the task description for T180678: Text and selection are shifted.
Fri, Nov 17, 1:49 PM · VisualEditor, SyntaxHighlight, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T180740: Please convert a URL to the internal link that I want for redirecting a page .

Can you give a specific example?

Fri, Nov 17, 1:48 PM · VisualEditor

Wed, Nov 15

Liuxinyu970226 awarded T115847: Provide an auto-correct feature a Like token.
Wed, Nov 15, 1:39 PM · VisualEditor-MediaWiki, Epic, VisualEditor

Mon, Nov 13

Esanders added a comment to T180155: Single edit tab: Setting should apply per-namespace.

I think want we want to do is just not override the preference if the namespace only supports one mode, rather than store a separate preference for every namespace.

Mon, Nov 13, 9:37 PM · VisualEditor
Esanders added a comment to T180363: Update citoid image in documentation.

(Apologies, I noticed too late that you tagged this as GCI)

Mon, Nov 13, 9:27 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Citoid, MediaWiki-Documentation, Documentation, VisualEditor
Esanders added a comment to T180363: Update citoid image in documentation.

Once this patch ^^ has been deployed and the bot does a run we can also update manual and re-use screenshots.

Mon, Nov 13, 5:41 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Citoid, MediaWiki-Documentation, Documentation, VisualEditor
Esanders added a comment to T180363: Update citoid image in documentation.

I've updated it to use the LanguageScreenshotBot generated one, so it will also get localised. We should add the manual tab to that task too.

Mon, Nov 13, 5:25 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Citoid, MediaWiki-Documentation, Documentation, VisualEditor

Sat, Nov 11

Esanders added a comment to T180261: Undo still doesn't use VisualEditor's 2017 wikitext mode.

This is either T114531 or a subtask of it.

Sat, Nov 11, 7:30 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Esanders added a comment to T160918: Adjust the personal header to align with the design styleguide.

With this changes we are aligning it with the mobile header that @Nirzar worked on for the mobile web view, and with the design style

Sat, Nov 11, 6:15 PM · Language-2017-Oct-Dec, Patch-For-Review, ContentTranslation, UI-Standardization

Fri, Nov 10

Esanders added a comment to T160918: Adjust the personal header to align with the design styleguide.

Also, here's how the current patch looks in monobook:

Fri, Nov 10, 4:21 PM · Language-2017-Oct-Dec, Patch-For-Review, ContentTranslation, UI-Standardization
Esanders added a comment to T160918: Adjust the personal header to align with the design styleguide.

Shouldn't we be coming up with improvements to our existing skins to make them more responsive, rather than diverging the CX pseudo-skin even more?

Fri, Nov 10, 4:12 PM · Language-2017-Oct-Dec, Patch-For-Review, ContentTranslation, UI-Standardization

Wed, Nov 8

Esanders added a comment to T179773: [feature request] User scenario to fix old raw references.

We already have some of this feature: T114564

Wed, Nov 8, 10:15 PM · VisualEditor
Esanders added a comment to T179994: Link to action=edit of a specific revision shows current revision in VE.

This is not expected, nor is it specific to NWE...

Wed, Nov 8, 2:19 PM · User-Ryasmeen, VisualEditor-MediaWiki, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), VisualEditor
Esanders removed a project from T179994: Link to action=edit of a specific revision shows current revision in VE: VisualEditor-MediaWiki-2017WikitextEditor.
Wed, Nov 8, 2:19 PM · User-Ryasmeen, VisualEditor-MediaWiki, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), VisualEditor
Esanders renamed T179994: Link to action=edit of a specific revision shows current revision in VE from Link to action=edit of a specific revision shows current revision in NWE to Link to action=edit of a specific revision shows current revision in VE.
Wed, Nov 8, 2:19 PM · User-Ryasmeen, VisualEditor-MediaWiki, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), VisualEditor
Esanders updated subscribers of T180010: Parsoid creates broken wikitext for link inside square brackets.

This is a pure Parsoid bug. The HTML>WT>HTML round trip is:

Wed, Nov 8, 2:04 PM · Patch-For-Review, Parsoid
Esanders renamed T180010: Parsoid creates broken wikitext for link inside square brackets from VE/Parsoid creates broken wikitext for link inside square brackets to Parsoid creates broken wikitext for link inside square brackets.
Wed, Nov 8, 1:59 PM · Patch-For-Review, Parsoid
Esanders removed a project from T180010: Parsoid creates broken wikitext for link inside square brackets: VisualEditor.
Wed, Nov 8, 1:59 PM · Patch-For-Review, Parsoid

Tue, Nov 7

Esanders added a project to T179870: Re-use a citation isn't finding citations: Regression.
Tue, Nov 7, 4:04 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Regression, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T179870: Re-use a citation isn't finding citations.

The connection to PreviewWidget (now PreviewElement), is that the index is built by creating previews of each reference and running them through jQuery.text. It was assumed that some rendering will be available synchronously from the CE node, but that CE node was never actually appended to the PreviewElement.

Tue, Nov 7, 4:03 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Regression, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T179870: Re-use a citation isn't finding citations.

I've gone back to the creation of PreviewWidget, and it looks like it never actually used the CE rendering, which we assumed it did: https://github.com/wikimedia/VisualEditor/commit/db2ed0b1282e41f558987225fdab4b9706101176#diff-de3066494436ef8a305ab69f3805373a

Tue, Nov 7, 3:57 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Regression, VisualEditor, VisualEditor-MediaWiki-References
Esanders added a comment to T179870: Re-use a citation isn't finding citations.

This is probably a jQuery 3 async regression...

Tue, Nov 7, 3:42 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Regression, VisualEditor, VisualEditor-MediaWiki-References

Sun, Nov 5

Esanders added a comment to T178719: Flow should respect editor preference settings (i.e. visual editor vs wikitext).

Looks like the preference is set, but only after the editor is typed in to.

Sun, Nov 5, 12:08 PM · Collaboration-Team-Triage, StructuredDiscussions

Sat, Nov 4

Esanders removed a project from T178719: Flow should respect editor preference settings (i.e. visual editor vs wikitext): Regression.
Sat, Nov 4, 10:41 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T178719: Flow should respect editor preference settings (i.e. visual editor vs wikitext).
Sat, Nov 4, 9:55 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders added a project to T178719: Flow should respect editor preference settings (i.e. visual editor vs wikitext): Regression.
Sat, Nov 4, 9:53 PM · Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T178691: Remember previous choice of visual/wikitext diff for next edit.

Also we need two preferences: one for VE and one for NWE.

Sat, Nov 4, 6:29 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T178691: Remember previous choice of visual/wikitext diff for next edit.

we can avoid adding yet another user preference

Sat, Nov 4, 6:07 PM · VisualEditor-VisualDiffs, VisualEditor
Esanders added a comment to T179691: Create or improve citoid logo.

Same happened with Parsoid: https://commons.wikimedia.org/wiki/File:Parsoid_logo.svg

Sat, Nov 4, 3:45 PM · Design, Citoid, VisualEditor, Google-Code-in-2017
Esanders updated subscribers of T179751: Typed characters get misplaced after changing a bullet item to a numbered item or vice versa.
Sat, Nov 4, 3:41 PM · VisualEditor

Fri, Nov 3

Esanders added a comment to T175953: OOjs UI: Support Responsive Toolbars.

Another trick GDocs mobile uses is an additional bottom toolbar - but last time we checked that wasn't possible to implement reliably across Android and iOS.

Fri, Nov 3, 4:19 PM · UI-Standardization-Kanban, UI-Standardization, OOjs-UI
Esanders added a comment to T175953: OOjs UI: Support Responsive Toolbars.

VE Mobile is currently using context-sensitive toolbars, similar to Google Docs mobile, such that when the document is not focused you see navigation and document-level tools

Could we show a different context menu if text is selected? Is this useful/possible?

Fri, Nov 3, 4:15 PM · UI-Standardization-Kanban, UI-Standardization, OOjs-UI

Thu, Nov 2

Esanders added a comment to T179618: Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline.

Looks like the problem is the newline text node between them paragraph and the autogenerated ref, so the paragraph unwrapping test fails.

Thu, Nov 2, 9:50 PM · Patch-For-Review, VisualEditor, Regression, VisualEditor-MediaWiki
Esanders added a comment to T179618: Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline.

Hmm, ve.ce.MWTransclusionNode.static.filterRendering appears to be in the correct order. Investigating.

Thu, Nov 2, 9:48 PM · Patch-For-Review, VisualEditor, Regression, VisualEditor-MediaWiki
Esanders added a comment to T179618: Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline.

When you ask Parsoid for a single ref it will <p> wrap it and also append a auto-generated ref list. We have code that removes the auto-generated ref list, and also unwraps documents that are a single paragraph. I suspect that they are happening in the wrong order though, so the paragraph unwrapping never happens because it thinks the document is more complex.

Thu, Nov 2, 9:47 PM · Patch-For-Review, VisualEditor, Regression, VisualEditor-MediaWiki

Wed, Nov 1

Esanders committed rELINT4056214937b9: Use VE's new offset conversion method (authored by Esanders).
Use VE's new offset conversion method
Wed, Nov 1, 9:47 PM
Esanders committed rELINT25c8a5772eef: Wait for selection reset when setting selection in NWE (authored by Esanders).
Wait for selection reset when setting selection in NWE
Wed, Nov 1, 9:47 PM
Esanders updated subscribers of T179427: Impossible to create pages when opted into Minerva skin on desktop.

It is assumed that you need to some 'edit' link to trigger and re-trigger the editor. Pinging @matmarex who wrote this code.

Wed, Nov 1, 8:16 PM · MinervaNeue, VisualEditor
Nemo_bis awarded T179248: Inline the 'discard translation' button a Haypence token.
Wed, Nov 1, 5:49 PM · Patch-For-Review, Design, ContentTranslation
Esanders added a comment to T179427: Impossible to create pages when opted into Minerva skin on desktop.

This is the offending line:

public function getPageActions() {
    return $this->isFallbackEditor() ? [] : $this->data['page_actions'];
}
Wed, Nov 1, 3:01 PM · MinervaNeue, VisualEditor
Esanders added a comment to T179427: Impossible to create pages when opted into Minerva skin on desktop.

I'll go back to my first guess. It is expected that once isSupportedEditPage returns true, that the page will have all the elements for initialising the editor in place. In this case the page doesn't have the #ca-edit link.

Wed, Nov 1, 2:46 PM · MinervaNeue, VisualEditor
Esanders added a comment to T179427: Impossible to create pages when opted into Minerva skin on desktop.
Wed, Nov 1, 2:32 PM · MinervaNeue, VisualEditor
Esanders added a comment to T179427: Impossible to create pages when opted into Minerva skin on desktop.
Wed, Nov 1, 2:23 PM · MinervaNeue, VisualEditor
Esanders added a comment to T178387: Standardise vertical option/button group popup widgets.

aren't menus on toolbars already using such pattern?

Wed, Nov 1, 12:37 PM · UI-Standardization-Kanban, UI-Standardization, OOjs-UI
Esanders added a comment to T176959: Display proper section collapsing within article namespace.

I would recommend going with the mentioned 3. Do the conceptually "right" thing as @cscott mentions, and then perform reading specific transforms in the PCS layer, with an eye to upstreaming them to the parsoid layer when proven stable. That way we avoid unnecessary changes and synchronization between teams because of the parsoid layer if the reading requirements shift.

Wed, Nov 1, 12:27 PM · Marvin, Epic

Tue, Oct 31

Esanders added a comment to T176959: Display proper section collapsing within article namespace.

That is all irrelevant as along as the transformation is done before the HTML is first appended to the document, which is the question I asked @Jdlrobson in T176959#3723286

Tue, Oct 31, 9:12 PM · Marvin, Epic
Esanders added a comment to M229: Refined WikimediaUI icons proposal.

We don't have any plans to support a dark skin on the web. The mobile app does have one though.

Tue, Oct 31, 4:26 PM · UI-Standardization, OOjs-UI
Esanders added a comment to T179248: Inline the 'discard translation' button.

The menu widget uses a bunch of non widget-library custom styling (see also T178387) which is therefore prone to regressions. It would be good to get rid of it if there is no compelling reason to keep it.

Tue, Oct 31, 2:55 PM · Patch-For-Review, Design, ContentTranslation
Esanders added a comment to T176959: Display proper section collapsing within article namespace.

Yes we have considered this in the past but the radical restructure would cause a reflow for us as well as a repaint since we need to provide server side rendered.

Could you explain how the Parsoid content is making it to the page first time in your use case? I was imaging this pass would take place before the first paint so as to avoid a reflow (be that in the client or on the server).

Tue, Oct 31, 2:21 PM · Marvin, Epic

Mon, Oct 30

Esanders added a comment to T179315: VisualEditor/NWE do not allow you to expand dropdowns in page notice.

The problem here is that we aren't firing the wikipage.content hook.

Mon, Oct 30, 10:15 PM · VisualEditor-MediaWiki, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), VisualEditor
Esanders committed rERSLb9f0e2adfe83: Use LESS nesting features (authored by Esanders).
Use LESS nesting features
Mon, Oct 30, 9:26 PM
Esanders added a comment to T179294: Visual diff ignores arrangement of citations.

We generate our own version of the reflist for diffing purposes, because on many large wikis they use a localised template instead of a <references/> tag. This makes it difficult to identify the reference list and its settings in a generic way.

Mon, Oct 30, 4:18 PM · VisualEditor, VisualEditor-VisualDiffs
Esanders removed projects from T174481: Unable to switch to View from Edit: MediaWiki-extensions-Translate, VisualEditor.
Mon, Oct 30, 12:57 PM · Timeless
Esanders added a comment to T179259: Visual Editor removing whitespace from infoboxes by default.

NB many users of Infobox television use a fixed width equal to the longest parameter in use, such that if a longer parameter is added, all the existing parameters need to be re-indented. TemplateData does not allow you to specify such a "variable-fixed width". Many also use simple block format with singles spaces, so whichever format is chosen, there is going to be some temporary disruption as usages are normalised.

Mon, Oct 30, 12:56 PM · Parsoid, VisualEditor
Esanders added a comment to T179259: Visual Editor removing whitespace from infoboxes by default.

The formatting for 'Infobox television' is 'unspecified', which I assume means leave whitespace alone, but the Parsoid team will need to answer this.

Mon, Oct 30, 11:34 AM · Parsoid, VisualEditor
Esanders added a project to T179259: Visual Editor removing whitespace from infoboxes by default: Parsoid.
Mon, Oct 30, 11:30 AM · Parsoid, VisualEditor
Esanders added a comment to T176959: Display proper section collapsing within article namespace.

FYI such wrapping code would be fairly simple:

Array.prototype.forEach.call( document.querySelectorAll( 'section > h2' ), function ( element ) {
  var wrapper = document.createElement( 'div' );
  while ( element.nextSibling ) { wrapper.appendChild( element.nextSibling ); }
  element.parentNode.appendChild( wrapper );
} );
Mon, Oct 30, 11:20 AM · Marvin, Epic
Esanders added a comment to T176959: Display proper section collapsing within article namespace.

That is something for @Jdlrobson or @phuedx to answer based on product needs.

Mon, Oct 30, 11:05 AM · Marvin, Epic
Esanders added a comment to T178867: Unify and optimize SVG markup across Foundation products.

Ideally we would have a linting task to enforce this going forward.

Mon, Oct 30, 10:57 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization

Sun, Oct 29

Esanders added a comment to T176959: Display proper section collapsing within article namespace.

So, unless there is a solution that doesn't require adding the <div> tag anywhere, this is probably the best compromise solution.

Sun, Oct 29, 9:52 PM · Marvin, Epic
Esanders added a comment to T176959: Display proper section collapsing within article namespace.

I think there needs to be a balance between which use cases require the client to unwrap nodes (e.g. editors which want to ignore the section wrappers) and which cases might require the client to add more wrapping.

Sun, Oct 29, 1:55 PM · Marvin, Epic
Esanders created T179248: Inline the 'discard translation' button.
Sun, Oct 29, 1:27 PM · Patch-For-Review, Design, ContentTranslation

Fri, Oct 27

Esanders committed rERSL51227c4648aa: Use LESS nesting features (authored by Esanders).
Use LESS nesting features
Fri, Oct 27, 7:00 PM
Esanders committed rERSL684c6c4b0c5c: Use LESS color calculation for blue/yellow slider styling (authored by Esanders).
Use LESS color calculation for blue/yellow slider styling
Fri, Oct 27, 7:00 PM
Esanders committed rERSL3ceff1f45b2b: build: Update devDependencies (authored by Esanders).
build: Update devDependencies
Fri, Oct 27, 11:08 AM
Esanders committed rERSL99fc222169b5: Use LESS nesting features (authored by Esanders).
Use LESS nesting features
Fri, Oct 27, 11:04 AM
Esanders committed rERSLbc17a6e9aba8: Fix collpase button margin/padding (authored by Esanders).
Fix collpase button margin/padding
Fri, Oct 27, 11:04 AM
Esanders committed rERSLde2afc506992: Use LESS color calculation for blue/yellow slider styling (authored by Esanders).
Use LESS color calculation for blue/yellow slider styling
Fri, Oct 27, 10:18 AM
Esanders committed rERSL28b436eb1641: Cast strings to numbers (authored by Esanders).
Cast strings to numbers
Fri, Oct 27, 10:03 AM

Thu, Oct 26

Esanders added a comment to T175843: Input events which occur away from the current ContentBranchNode do not get observed.

It is possible to modify the document without triggering any events, such as right-click-to-undo, or spellcheck. We work around this by continuously polling your current paragraph for changes, but in the case of right-click-to-undo that can modify a completely different part of the document.

Thu, Oct 26, 5:18 PM · VisualEditor-ContentEditable, VisualEditor
Esanders updated subscribers of T177061: Shift+Up doesn't work in IE11.
Thu, Oct 26, 11:42 AM · Browser-Support-Internet-Explorer, VisualEditor-ContentEditable, VisualEditor

Wed, Oct 25

Esanders added a comment to T178970: A left-floating template is broken while editing in an RTL wiki.

I've fixed the template, will be fixed when the RESTBase caches clear.

Wed, Oct 25, 4:15 PM · Parsoid
Esanders added a comment to T178970: A left-floating template is broken while editing in an RTL wiki.

So the wikitext is indeed to blame. The whole table is wrapped in a <span style="position:absolute;">, which the old parser throws away as invalid HTML4(?), but Parsoid allows it, so it only works in the old parser accidentally. I'll leave this here for the Parsoid team to look at, but most likely this is a known difference between the parsers.

Wed, Oct 25, 4:11 PM · Parsoid
Esanders added a comment to T178970: A left-floating template is broken while editing in an RTL wiki.

Most likely there is a problem with the wikitext used to render that template, because other floated templates on the wiki work fine.

Wed, Oct 25, 4:03 PM · Parsoid
Esanders edited projects for T178970: A left-floating template is broken while editing in an RTL wiki, added: Parsoid; removed VisualEditor.
Wed, Oct 25, 4:02 PM · Parsoid
Esanders added a comment to T178970: A left-floating template is broken while editing in an RTL wiki.

I see the same thing directly from RESTBase so this must be a Parsoid issue, not VE: https://he.wikipedia.org/api/rest_v1/page/html/%D7%94%D7%99%D7%A1%D7%98%D7%95%D7%A8%D7%99%D7%94_%D7%90%D7%91%D7%95%D7%9C%D7%95%D7%A6%D7%99%D7%95%D7%A0%D7%99%D7%AA_%D7%A9%D7%9C_%D7%94%D7%97%D7%99%D7%99%D7%9D

Wed, Oct 25, 4:02 PM · Parsoid