Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (211 w, 4 h)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders committed rESCCf87da6e999b0: build: Update devDependencies (authored by Esanders).
build: Update devDependencies
Mon, Nov 12, 10:22 PM
Esanders committed rESCCb74bb24047a7: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Mon, Nov 12, 10:22 PM
Esanders committed rESCC36300a0a1886: build: Update devDependencies (authored by Esanders).
build: Update devDependencies
Mon, Nov 12, 7:54 PM
Esanders committed rESCCf0334be04c6d: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Mon, Nov 12, 7:54 PM
Esanders committed rELINT1558e4515f96: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Mon, Nov 12, 4:08 PM
Esanders committed rELINTb8a03444dd59: build: Update devDependencies (authored by Esanders).
build: Update devDependencies
Mon, Nov 12, 4:08 PM
Esanders updated the task description for T208575: Multiple results in citoid doesn't look great.
Mon, Nov 12, 4:05 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders added a comment to T208575: Multiple results in citoid doesn't look great.

On further investigation it looks like the API is only returning one result for these queries, so must be a config issue with the beta cluster, as suspected.

Mon, Nov 12, 4:01 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders added a comment to T208575: Multiple results in citoid doesn't look great.

I was seeing the single result on beta cluster before merging, so I assume it's a config issue. The patches are CSS only, so unlikely to be the cause of hiding a result.

Mon, Nov 12, 3:55 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders committed rELINT27b23e9150ea: build: Update devDependencies (authored by Esanders).
build: Update devDependencies
Mon, Nov 12, 3:03 PM
Esanders committed rELINT6b1a2a6d8879: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Mon, Nov 12, 3:03 PM

Yesterday

Esanders added a comment to T200868: RFC: Modernise our JavaScript with the goal that mediawiki global object should not depend on jQuery.

It is also possible to migrate to ES6 promises while maintaining a jQuery.Deferred-like API. This would allow use to remove the dependency more easily, then switch over to a native Promise API in a piecemeal fashion (if we want to).

Sun, Nov 11, 3:52 PM · JavaScript, Performance-Team, Proposal, MediaWiki-ResourceLoader, Readers-Web-Backlog (Tracking), User-Jdlrobson
Esanders created P7788 ES6 Deferred.
Sun, Nov 11, 3:47 PM
Esanders renamed T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization from Edit page metadata is very slow to load from the Action API, slowing down VisualEditor to Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization.
Sun, Nov 11, 12:19 PM · VisualEditor, Performance, VisualEditor-MediaWiki
Liuxinyu970226 awarded T104479: Provide a modern wikitext editor a Like token.
Sun, Nov 11, 6:58 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, VisualEditor-MediaWiki, Design, Epic
Liuxinyu970226 awarded T132288: Create tool to identify plain references and offer a fix a Like token.
Sun, Nov 11, 6:56 AM · Design, VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-References, Citoid

Fri, Nov 9

Esanders moved T206228: Analyse load time performance of FA-length pages on mobile from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Fri, Nov 9, 7:54 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
Esanders claimed T206228: Analyse load time performance of FA-length pages on mobile.
Fri, Nov 9, 7:54 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
Esanders added a comment to T209162: [Regression] Blockquotes can't be edited, because they're alienated content.

To do that would mean making them BranchNodes, instead of ContentBranchNodes, and so affects a lot of things..

Fri, Nov 9, 6:40 PM · VisualEditor
Esanders created T209152: Exception thrown in VisualDiff.
Fri, Nov 9, 2:28 PM · VisualEditor, VisualEditor-VisualDiffs

Thu, Nov 8

Esanders created T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization.
Thu, Nov 8, 5:23 PM · VisualEditor, Performance, VisualEditor-MediaWiki
Esanders added a comment to T209015: VisualEditor on mobile: Toolbar should be reduced in height.

cf https://www.youtube.com/watch?v=VjpcLplkMUs

Thu, Nov 8, 3:54 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Mobile, MinervaNeue, VisualEditor
Esanders added a comment to T209015: VisualEditor on mobile: Toolbar should be reduced in height.

This is also the size non-OOUI ovelays in MobileFrontend. Seems like a pretty big change with lots of knock on effects, but in principle I think we should be considering if we can get away with smaller buttons. By comparison the tools in GoogleDocs mobile app are much smaller than ours.

Thu, Nov 8, 3:54 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Mobile, MinervaNeue, VisualEditor
Esanders added a comment to T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.

This should result in a very significant improvement to mobile page load times.

Thu, Nov 8, 3:11 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
Esanders moved T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Nov 8, 3:10 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
Esanders claimed T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.
Thu, Nov 8, 3:10 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
Esanders updated subscribers of T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.

We should check with @Neil_P._Quinn_WMF that we have reasonable page load timings for Mobile VE before we deploy any improvements.

Thu, Nov 8, 1:03 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
Esanders created T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.
Thu, Nov 8, 12:59 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

With network throttling:

  • Fast 3G: Not much change, metadata takes 800ms and HTML takes 600ms. As metadata is the slower of the two in parallel this is only 80ms slower than above.
  • Slow 3G: Metadata take a similar amount of time, ~2000ms.
Thu, Nov 8, 12:56 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
Esanders added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

Loading https://en.m.wikipedia.org/wiki/Nemegtomaia

Thu, Nov 8, 12:39 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance

Wed, Nov 7

Esanders moved T208515: Improve test coverage for ve.ce.ResizableNode from Code review to Engineering QA on the VisualEditor (Current work) board.
Wed, Nov 7, 8:35 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Test-Coverage, VisualEditor (Current work)
Esanders added a comment to T206138: [EPIC] Increase test coverage for VE.ce code.

Now 3876/4745 (81.69%) 🎉🎉🎉

Wed, Nov 7, 8:17 PM · VisualEditor
Esanders moved T205948: Scroll position is always preserved when switching tab in an dialog using IndexLayout from In progress to QA on the VisualEditor (Current work) board.
Wed, Nov 7, 8:10 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, VisualEditor-EditingTools, VisualEditor (Current work)
Esanders moved T208575: Multiple results in citoid doesn't look great from Code review to QA on the VisualEditor (Current work) board.
Wed, Nov 7, 7:52 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders claimed T208575: Multiple results in citoid doesn't look great.
Wed, Nov 7, 7:51 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders moved T207083: Investigation spike to add test coverage for ve.ce.FocusableNode from Ready for Pick Up to Engineering QA on the VisualEditor (Current work) board.
Wed, Nov 7, 7:20 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), VisualEditor-ContentEditable, VisualEditor (Current work)
Esanders claimed T208396: Add basic coverage for Dialog/Inspector opening in UI.
Wed, Nov 7, 7:10 PM · VisualEditor (Current work)
Esanders moved T208964: Can't scroll the page on iOS 9 from To Triage to Bug Fixes on the VisualEditor board.
Wed, Nov 7, 6:47 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a project to T208964: Can't scroll the page on iOS 9: Browser-Support-Apple-Safari.
Wed, Nov 7, 5:28 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T208964: Can't scroll the page on iOS 9.

Interestingly this fails on the live site, but I can't reproduce locally..

Wed, Nov 7, 5:25 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T208964: Can't scroll the page on iOS 9.

Note that most of our users are on MobileSafari11/12 . MobileSafari9 is <3% of 37%.

Wed, Nov 7, 5:22 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders created T208964: Can't scroll the page on iOS 9.
Wed, Nov 7, 5:20 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders created T208962: Allow specification of version limits for optional dependencies.
Wed, Nov 7, 5:01 PM · MediaWiki-Configuration
Esanders added a comment to T208947: Save dialog message has scrollbar when pressing <enter> in comment field.

After:

Wed, Nov 7, 4:30 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders renamed T208947: Save dialog message has scrollbar when pressing <enter> in comment field from Save dialog has scrollbar when pressing <enter> in comment field to Save dialog message has scrollbar when pressing <enter> in comment field.
Wed, Nov 7, 4:29 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders committed rEBOPcccaf6749141: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Wed, Nov 7, 3:36 PM
Esanders committed rETHR5d9165b0436b: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Wed, Nov 7, 3:21 PM
Esanders committed rEASRc795c3ab2386: Remove obsolete aliases from closures (authored by Esanders).
Remove obsolete aliases from closures
Wed, Nov 7, 3:17 PM
Esanders created T208951: Remove obsolete aliases from closures.
Wed, Nov 7, 3:07 PM · JavaScript, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MediaWiki-extensions-General, Patch-For-Review
Esanders moved T208947: Save dialog message has scrollbar when pressing <enter> in comment field from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Wed, Nov 7, 1:52 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders created T208947: Save dialog message has scrollbar when pressing <enter> in comment field.
Wed, Nov 7, 1:51 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Esanders added a comment to T208891: Alt+Shift+V (or other acceskey for visual "Edit" tab) should preserve scroll position (it doesn't on Firefox).

We set the cursor offset to [1,1] (or the first content position, so by current behaviour it should scroll to the top of the page in all browsers.

Wed, Nov 7, 1:41 PM · Browser-Support-Firefox, VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T208575: Multiple results in citoid doesn't look great.

Do we plausibly still need a max height anyway?

Wed, Nov 7, 12:18 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid

Tue, Nov 6

Esanders added a comment to T208751: Allow arbitrary search strings in citoid from existing footnotes.

The citoid service will try both. If it gets results from both, it gives two results. Citoid picks up only the first link though.

Tue, Nov 6, 10:39 PM · VisualEditor, Citoid
Esanders created P7768 Uses of "[^\.]addPortletLink".
Tue, Nov 6, 7:38 PM
Esanders added a comment to T208751: Allow arbitrary search strings in citoid from existing footnotes.

Edge cases:

  • Text contains a link, do we search for the link or the text, or give up? e.g. <ref>[http://news.example.com/title-of-article Title of Article]</ref>
  • Text contains multiple links, do we pick the first link, or use the text, or give up?
  • Citation contains another template we don't recognise, do we use the generated output or give up? e.g. <ref>{{other-link-generator|param}}</ref>
  • Citation contains template and text, do we ignore the template, or give up?, e.g. <ref>Title of Article {{from-this-news-site}}</ref>
Tue, Nov 6, 5:36 PM · VisualEditor, Citoid
Esanders added a comment to T208751: Allow arbitrary search strings in citoid from existing footnotes.

Are there particular patterns we should look for to blacklist/whitelist, or should we just provide the "convert" button for every non-template citation?

Tue, Nov 6, 5:31 PM · VisualEditor, Citoid
Esanders added a comment to T208826: Toolbar breaks when I focus on editable content after clicking omega character.

I edited my comment, this looks like expected behaviour...

Tue, Nov 6, 5:29 PM · VisualEditor
Esanders claimed T208732: [regression] Template diff messages broken.
Tue, Nov 6, 5:28 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders claimed T208853: Citoid fallback icon missing.
Tue, Nov 6, 5:28 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Citoid
Esanders triaged T206729: VE's image type dropdown icon of media dialog need to be aligned to icon guidelines as Low priority.

It's a bit against convention to even have icons in a dropdown (as in Apex the selected item uses a check icon). If we really want to show the user what each mode looks like we should probably use larger images and a different widget.

Tue, Nov 6, 5:27 PM · UI-Standardization, Design, VisualEditor
Esanders moved T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Nov 6, 5:25 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders edited projects for T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox, added: VisualEditor (Current work); removed VisualEditor.
Tue, Nov 6, 5:24 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders added a comment to T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox.

After:

Tue, Nov 6, 5:24 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders added a comment to T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox.

The patch will fix renderings in infoboxes and other non-editable areas, but there will continue to be slight rendering differences between read mode and edit mode. I don't really want to change that as there may be a good reason for using word breaking by default in edit mode.

Tue, Nov 6, 5:24 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders triaged T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox as Low priority.

The parent contentEdtiable=true changes the word-break behaviour (even though the infobox is ce=false). Think we've seen this before, probably a browser bug but not a big issue.

Tue, Nov 6, 5:08 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders added a comment to T207426: In Visual Editor, caption appears vertically to the left of the image in the infobox.
Tue, Nov 6, 5:01 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Browser-Support-Google-Chrome
Esanders lowered the priority of T207875: File search only returns word matches from Normal to Low.

This doesn't appear to be a problem on WMF wikis, so lowering priority. Maybe it depends on which search provider you use on your wiki?

Tue, Nov 6, 4:56 PM · MediaWiki-Search, Discovery-Search, VisualEditor
Esanders triaged T208631: Copy/Paste in Visual editor does not work browser page to browser page as expected as Low priority.

Interesting. Turns out that when you copy an image in the browser, it is stored in the clipboard in two formats: as the actual image, and as HTML like this:

<html>
<body>
<!--StartFragment--><img src="https://apod.nasa.gov/apod/image/1705/Arp273Main_HubblePestana_3079.jpg" alt="Image result for galaxy"/><!--EndFragment-->
</body>
</html>

When this is pasted into VisualEditor, we use the HTML instead of the image (ve.ce.Surface.prototype.handleDataTransfer), because:

	// Only look for files if HTML is not available:
	//  - If a file is pasted/dropped it is unlikely it will have HTML fallback (it will have plain text fallback though)
	//  - HTML generated from some clients has an image fallback(!) that is a screenshot of the HTML snippet (e.g. LibreOffice Calc)

Then our paste sanitization strips that HTML down to nothing (since <img> tags using external resources are not possible in wikitext), and then nothing is pasted.

@Thedonquixotic Can you file a separate task about this?

(As a workaround, I guess you can paste into Paint, then copy from Paint.)

Tue, Nov 6, 4:38 PM · media-storage, VisualEditor, UploadWizard, VisualEditor-EditingTools, Multimedia
Esanders moved T208575: Multiple results in citoid doesn't look great from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Nov 6, 4:24 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders edited projects for T208575: Multiple results in citoid doesn't look great, added: VisualEditor (Current work); removed VisualEditor.
Tue, Nov 6, 4:24 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders edited projects for T208575: Multiple results in citoid doesn't look great, added: Regression; removed Design.

Looks like we had code in to put separators but it wasn't working as intended, so marking this a regression instead.
After separator patch:

Tue, Nov 6, 4:23 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders added a comment to T208575: Multiple results in citoid doesn't look great.

After above patch


window-clipped:

Tue, Nov 6, 4:00 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Mvolz awarded T208853: Citoid fallback icon missing a Like token.
Tue, Nov 6, 2:45 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Citoid
Esanders added a comment to T208575: Multiple results in citoid doesn't look great.

I have a preference for having a default icon for non-registered templates.

Tue, Nov 6, 2:43 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, Patch-For-Review, Citoid
Esanders created T208853: Citoid fallback icon missing.
Tue, Nov 6, 2:42 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Citoid
Esanders added a comment to T208826: Toolbar breaks when I focus on editable content after clicking omega character.

Can't reproduce this...

Tue, Nov 6, 2:31 PM · VisualEditor
Esanders added a comment to T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.

My personal preference is not to make a decision for the user

Tue, Nov 6, 2:21 PM · Patch-For-Review, OOUI (OOUI-0.29.4), Regression
Esanders added a comment to T208836: Link gets lost when converting a paste to wikitext.

We deliberately strip external links from external paste sources so that external links don't get accidentally added to Wikipedia articles.

Tue, Nov 6, 12:35 PM · VisualEditor-CopyPaste, VisualEditor

Mon, Nov 5

Esanders moved T208595: First context menu shown after opening the page is all broken from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Nov 5, 8:24 PM · OOUI (OOUI-0.29.4), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Verified, VisualEditor-EditingTools, VisualEditor (Current work), Regression
Esanders edited projects for T208595: First context menu shown after opening the page is all broken, added: VisualEditor (Current work); removed VisualEditor.
Mon, Nov 5, 8:23 PM · OOUI (OOUI-0.29.4), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Verified, VisualEditor-EditingTools, VisualEditor (Current work), Regression
Esanders moved T208686: Missing icon 'menu' in VisualEditor from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Nov 5, 7:55 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Esanders lowered the priority of T208686: Missing icon 'menu' in VisualEditor from High to Normal.
Mon, Nov 5, 7:55 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Esanders added a comment to T208686: Missing icon 'menu' in VisualEditor.

This has not been an issue on WMF wiki as the TemplateData extension is loading this module for us. Filed T208765 as a follow-up.

Mon, Nov 5, 7:53 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Esanders added a comment to T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.

Yes.

Mon, Nov 5, 7:44 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders created T208765: TemplateData module is loaded too often.
Mon, Nov 5, 7:24 PM · TemplateData, VisualEditor
Esanders renamed T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog from User can't tab out focussed “Visual editing” textarea in Flow to User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.
Mon, Nov 5, 5:17 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.

The reason for this is that tab/shift+tab perform actions in some contexts in VE, specifically in a list they change indentation, and in table selections they cycle through cells. It is easy enough to allow change focus to work only in non-list/non-table contexts, but I'm not sure this is the greatest solution.

Mon, Nov 5, 5:15 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders added a comment to T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.

This is true of all VE surfaces, include the TargetWidgets found in media/gallery dialogs:

Mon, Nov 5, 5:13 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders added projects to T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog: VisualEditor, VisualEditor-MediaWiki.
Mon, Nov 5, 5:12 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders merged T198615: Input focus cannot moved through surface widgets into T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.
Mon, Nov 5, 5:11 PM · VisualEditor-MediaWiki, VisualEditor, Growth-Team, Accessibility, Collaboration-Team-Triage, StructuredDiscussions
Esanders merged task T198615: Input focus cannot moved through surface widgets into T172694: User can't tab out VisualEditor surfaces, e.g. Flow input widgets, media dialog.
Mon, Nov 5, 5:11 PM · Accessibility, VisualEditor
Esanders added a comment to T154218: Make it possible to tab from one surface section to the next in Safari, Firefox.

Is this still present in Safari? If the browser vendors have fixed it for us we should probably just close.

Mon, Nov 5, 4:55 PM · User-Ryasmeen, VisualEditor-ContentEditable, Browser-Support-Apple-Safari, VisualEditor
Esanders moved T208732: [regression] Template diff messages broken from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Nov 5, 3:20 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders edited projects for T208732: [regression] Template diff messages broken, added: VisualEditor (Current work); removed VisualEditor.
Mon, Nov 5, 3:19 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders added a comment to T208732: [regression] Template diff messages broken.

After:

Mon, Nov 5, 3:19 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders triaged T208732: [regression] Template diff messages broken as High priority.
Mon, Nov 5, 3:19 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders created T208732: [regression] Template diff messages broken.
Mon, Nov 5, 3:17 PM · Verified, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Regression, VisualEditor-VisualDiffs
Esanders moved T208720: Template parameter alias "pills" vertically truncated [regression] from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Nov 5, 11:52 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki
Esanders edited projects for T208720: Template parameter alias "pills" vertically truncated [regression], added: VisualEditor (Current work); removed VisualEditor.
Mon, Nov 5, 11:52 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), VisualEditor (Current work), Regression, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki