Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (346 w, 1 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Today

Esanders closed T284563: Watchlist Expiry: enable by default in MediaWiki as Declined.
Tue, Jun 15, 3:20 PM · Patch-For-Review, Community-Tech, Expiring-Watchlist-Items

Yesterday

Esanders updated the task description for T284935: OOjs + ES6.
Mon, Jun 14, 3:43 PM · Performance-Team, OOjs
Esanders created T284935: OOjs + ES6.
Mon, Jun 14, 3:40 PM · Performance-Team, OOjs

Thu, Jun 10

Esanders moved T284758: Keyboard shortcut help in reply tool shows commands which aren't available from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Jun 10, 3:38 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders claimed T284758: Keyboard shortcut help in reply tool shows commands which aren't available.
Thu, Jun 10, 3:38 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools
Esanders created T284758: Keyboard shortcut help in reply tool shows commands which aren't available.
Thu, Jun 10, 3:38 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools

Wed, Jun 9

Esanders added a comment to T153367: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor.

You can use $overlay: this.$overlay within a dialog.

Wed, Jun 9, 4:34 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-TemplateSandbox

Tue, Jun 8

Esanders added a comment to T265163: Create a system to encode best practices into editing experiences.

T225750 might live under this task somewhere

Tue, Jun 8, 5:43 PM · Editing-team, VisualEditor
Esanders added a comment to T284567: [regression] Reply tool padding and height broken.

Apologies to the web team for the speculative tagging, turned out to be just an internal issue.

Tue, Jun 8, 4:31 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), Regression, DiscussionTools
Esanders triaged T284567: [regression] Reply tool padding and height broken as Unbreak Now! priority.
Tue, Jun 8, 1:36 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), Regression, DiscussionTools
Esanders created T284567: [regression] Reply tool padding and height broken.
Tue, Jun 8, 1:36 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), Regression, DiscussionTools
Esanders created T284563: Watchlist Expiry: enable by default in MediaWiki.
Tue, Jun 8, 12:57 PM · Patch-For-Review, Community-Tech, Expiring-Watchlist-Items

Mon, Jun 7

Lens0021 awarded T211243: Add a useful call-to-action in the context for citation needed templates a Like token.
Mon, Jun 7, 4:36 AM · VisualEditor, User-notice, Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Editing Design, VisualEditor-MediaWiki

Fri, Jun 4

Esanders updated subscribers of T284312: Language variant inspector looks all messed up.
Fri, Jun 4, 7:41 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (Design Backlog), VisualEditor, VisualEditor-MediaWiki

Thu, Jun 3

Esanders created T284262: Test that CE nodes can call onTeardown before onSetup.
Thu, Jun 3, 9:58 PM · Technical-Debt, VisualEditor
Esanders added a comment to T280180: TypeError: this.$overlay is undefined.

We should probably add a test runner that calls instantiates every CE node, the checks that teardown works without setup.

Thu, Jun 3, 9:56 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), VisualEditor, Wikimedia-production-error
Esanders added a comment to T280180: TypeError: this.$overlay is undefined.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/698063 fixes a similar issue (teardown before setup)

Thu, Jun 3, 9:55 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), VisualEditor, Wikimedia-production-error
Esanders moved T280180: TypeError: this.$overlay is undefined from To Triage to Triaged on the VisualEditor board.
Thu, Jun 3, 9:38 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2020-21 Kanban Board), VisualEditor, Wikimedia-production-error
Esanders moved T282285: Firefox: When editing maps, only the first map can be selected from To Triage to Triaged on the VisualEditor board.
Thu, Jun 3, 8:55 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), VisualEditor, TemplateData
Esanders moved T283598: There is a div element which partially prevents interaction with the special character menu in Citation "basic form" from To Triage to Triaged on the VisualEditor board.
Thu, Jun 3, 8:02 PM · Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor
Esanders moved T283853: VE paste surface read by screenreader from To Triage to Triaged on the VisualEditor board.
Thu, Jun 3, 7:53 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), VisualEditor, Accessibility, DiscussionTools
Esanders added a project to T284075: Visual Editor doesn't work with sqlite and without curl: Editing-team (Third-party).
Thu, Jun 3, 7:33 PM · Editing-team (Third-party), MediaWiki-General, MW-1.36-release, MW-1.35-release, MediaWiki-Debian, SQLite, VisualEditor
Esanders moved T282789: Make "Convert formatting to wikitext" feature non modal from Design Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Jun 3, 6:00 PM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor
Esanders updated the task description for T284175: Topic subscription notifications are not sent on the beta cluster.
Thu, Jun 3, 5:52 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders moved T284175: Topic subscription notifications are not sent on the beta cluster from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

Notifications are working for me on beta now:

Thu, Jun 3, 5:52 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders moved T281471: Topic Subscription Prototype: Highlight thread after following a notification from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Jun 3, 3:30 PM · Patch-For-Review, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
Esanders updated the task description for T282789: Make "Convert formatting to wikitext" feature non modal.
Thu, Jun 3, 10:54 AM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor

Tue, Jun 1

Esanders moved T279151: Topic Subscriptions: Define copy and ensure consistent treatment across touchpoints for Notifications from Ready to Be Worked On to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Tue, Jun 1, 3:47 PM · Editing-team (FY2020-21 Kanban Board), OWC2020
Esanders added a comment to T279151: Topic Subscriptions: Define copy and ensure consistent treatment across touchpoints for Notifications.

The main patch has been updated with the new copy: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/685413/5..6/i18n/en.json

Tue, Jun 1, 3:46 PM · Editing-team (FY2020-21 Kanban Board), OWC2020
Esanders renamed T284035: Resolve the spacebar's conflicting meanings from Resolve the spacebar's conflicting meanings to Allow subscribe/unsubscribe links to be "clicked" with the spacebar.
Tue, Jun 1, 1:45 PM · DiscussionTools
Esanders added a comment to T284035: Resolve the spacebar's conflicting meanings.

The linked to demo is using a old version of the patch. The latest one already addresses this: https://patchdemo.wmflabs.org/wikis/c647283588/wiki/Talk:Main_Page

Tue, Jun 1, 1:45 PM · DiscussionTools
Lens0021 awarded T58313: Make postedit messages ("Your edit was saved.") and mw.notification messages ("The page has been added to your watchlist.") look the same a Like token.
Tue, Jun 1, 8:30 AM · Patch-Needs-Improvement, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.30-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), UI-Standardization, Design, MediaWiki-Interface

Wed, May 26

Esanders moved T281471: Topic Subscription Prototype: Highlight thread after following a notification from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Wed, May 26, 8:07 PM · Patch-For-Review, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
Esanders updated the task description for T281471: Topic Subscription Prototype: Highlight thread after following a notification .
Wed, May 26, 8:07 PM · Patch-For-Review, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
Esanders placed T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization up for grabs.
Wed, May 26, 8:05 PM · Patch-Needs-Improvement, VisualEditor, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Performance Issue, VisualEditor-MediaWiki
Esanders closed T214450: Analyze impact of parallel loading of page content and mobile visual editor code as Resolved.
Wed, May 26, 8:02 PM · VisualEditor, Product-Analytics, Performance Issue, VisualEditor-MediaWiki-Mobile
Esanders moved T275949: Implement topic subscription notification bundling from Ready to Be Worked On to QA on the Editing-team (FY2020-21 Kanban Board) board.
Wed, May 26, 3:49 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated the task description for T275949: Implement topic subscription notification bundling.
Wed, May 26, 3:49 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders assigned T282699: Create topic subscription table to DLynch.
Wed, May 26, 3:47 PM · User-Urbanecm, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a project to T277649: Update Echo for the EditResult revert detection improvements: Technical-Debt.
Wed, May 26, 12:53 PM · Technical-Debt, Growth-Team-Filtering, Patch-For-Review, Editing-team (FY2020-21 Kanban Board), Growth-Team, Notifications
Esanders removed a project from T264684: "Invalid response from server." when using hCaptcha and Visual Editor: Editing-team (FY2020-21 Kanban Board).
Wed, May 26, 12:52 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)
Esanders added a comment to T281471: Topic Subscription Prototype: Highlight thread after following a notification .

The above patch highlights the comment in blue when you follow the link:

Wed, May 26, 12:46 PM · Patch-For-Review, DiscussionTools, Editing-team (FY2020-21 Kanban Board)

Mon, May 24

Esanders committed rETSAcefeaa8d4792: Move var declarations inline (authored by Esanders).
Move var declarations inline
Mon, May 24, 7:59 PM
Esanders claimed T272197: Update Discussion tools beta feature to include topic subscriptions.
Mon, May 24, 1:49 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
Esanders added a comment to T272197: Update Discussion tools beta feature to include topic subscriptions.

Implemented as:
* [https://www.mediawiki.org/wiki/Talk_pages_project/Notifications Receive notifications] when new comments are added in sections you have subscribed to.

Mon, May 24, 1:48 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
Esanders added a comment to T272197: Update Discussion tools beta feature to include topic subscriptions.

Receive Echo notifications

"Echo" is a deprecated internal product name. They should just be called "notifications" in the UI

Mon, May 24, 1:40 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
Esanders claimed T279400: Make the feedback link for New Discussion tool point to the project page about the New Discussion tool (not the Reply tool).
Mon, May 24, 1:37 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders moved T247661: "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VisualEditor and DiscussionTools from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Mon, May 24, 1:04 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, Anti-Harassment, Platform Engineering (Icebox), MediaWiki-API, AbuseFilter, VisualEditor
Esanders edited projects for T247661: "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VisualEditor and DiscussionTools, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team (Tracking).
Mon, May 24, 1:04 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, Anti-Harassment, Platform Engineering (Icebox), MediaWiki-API, AbuseFilter, VisualEditor
Esanders claimed T283119: Offer the Reply and New Discussion Tools at Wikitech.
Mon, May 24, 1:00 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Mon, May 17

Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 7:09 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:54 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:50 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:45 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:37 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders added a comment to T283014: Font and font-sizes broken in VE.

DiscussionTools reply widget is broken by the patch that adds mw-body-content to MW surfaces unconditionally, as the widget was already within the mw-body-content, so the font-size: 0.875em rule is applied twice.

Mon, May 17, 6:35 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:13 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 6:11 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 5:58 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated the task description for T283014: Font and font-sizes broken in VE.
Mon, May 17, 5:56 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders added a comment to T283014: Font and font-sizes broken in VE.

Other places that could be affected by these changes:

  • ContentTranslation
  • Preview within 2017WTE
  • Reference previews inside VE reference context popups
  • Visual diffs (both within VE, and on the history page)
Mon, May 17, 3:41 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders updated subscribers of T283014: Font and font-sizes broken in VE.

Looks like this was caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/682774

Mon, May 17, 2:47 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders triaged T283014: Font and font-sizes broken in VE as Unbreak Now! priority.
Mon, May 17, 2:38 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor
Esanders created T283014: Font and font-sizes broken in VE.
Mon, May 17, 2:38 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, VisualEditor

May 13 2021

Esanders added a comment to T282789: Make "Convert formatting to wikitext" feature non modal.

Demo: https://patchdemo.wmflabs.org/wikis/b1cca98add/wiki/Main_Page?veaction=editsource

May 13 2021, 3:51 PM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T281009: Better integrate the "Convert formatting to wikitext" feature into text paste workflow.

I think step 0 should be "Make the existing prompt non modal" (T282789), as already implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/551313. I don't think should block on step 1 above.

May 13 2021, 3:44 PM · DiscussionTools
Esanders moved T282789: Make "Convert formatting to wikitext" feature non modal from Needs Discussion / Investigation to Blocked / Needs More Work on the Editing-team (FY2020-21 Kanban Board) board.
May 13 2021, 3:44 PM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a project to T282789: Make "Convert formatting to wikitext" feature non modal: Editing-team (FY2020-21 Kanban Board).
May 13 2021, 3:44 PM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor
Esanders created T282789: Make "Convert formatting to wikitext" feature non modal.
May 13 2021, 2:56 PM · Editing QA, VisualEditor, Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor
Esanders renamed T277241: Add syntax highlighting to DiscussionTools' source mode from Add highlighting of syntax to DiscussionTools' source mode to Add syntax highlighting to DiscussionTools' source mode.
May 13 2021, 1:34 PM · DiscussionTools
Esanders moved T280605: Reduce parser cache retention temporarily for DiscussionTools from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
May 13 2021, 1:28 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Editing-team (FY2020-21 Kanban Board), DBA, Patch-For-Review, Performance-Team, DiscussionTools
Esanders edited projects for T280605: Reduce parser cache retention temporarily for DiscussionTools, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
May 13 2021, 1:27 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Editing-team (FY2020-21 Kanban Board), DBA, Patch-For-Review, Performance-Team, DiscussionTools
Esanders moved T279149: Topic Subscriptions: Improve user interface element for subscribing and unsubscribing to topics on Talk Pages from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
May 13 2021, 1:17 PM · DiscussionTools, Editing QA, Editing-team (FY2020-21 Kanban Board), OWC2020

May 12 2021

Esanders added a comment to T282625: Figure out icon system architecture.
  1. The strong binding of available icons to javascript helps you to use quickly discover and pick an icon through autocompletion features of popular IDEs.
  2. A build step or even real time checks by IDE make sure you are not refering an icon that does not exist. This is better than a loose dependency like CSS classnames
May 12 2021, 10:25 PM · Vue.js, WVUI

May 6 2021

Esanders added a comment to T281624: When opening a diff, highlight newly added comments.

We built something similar when creating infrastructure for the topic subscriptions feature, so this should be mostly design work:

May 6 2021, 3:56 PM · Patch-For-Review, DiscussionTools

May 5 2021

Esanders added a comment to T280606: Post-deployment: evaluate impact on site performance.

Sounds good. Do you need any more input from the Editing team at this point?

May 5 2021, 5:35 PM · Performance-Team, Editing-team (Tracking), DBA, DiscussionTools
Esanders assigned T264684: "Invalid response from server." when using hCaptcha and Visual Editor to matmarex.
May 5 2021, 5:18 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)
Esanders moved T277783: Remove the cookie hack for testing the reply tool from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
May 5 2021, 5:11 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders updated the task description for T258457: WWT makes API request on every page view before button is clicked..
May 5 2021, 4:12 PM · Community-Tech, Who-Wrote-That
Esanders added a comment to T258457: WWT makes API request on every page view before button is clicked..

The above pull request needs review ^

May 5 2021, 4:10 PM · Community-Tech, Who-Wrote-That
Esanders added a comment to T279149: Topic Subscriptions: Improve user interface element for subscribing and unsubscribing to topics on Talk Pages .

I think bracket-less might be more plain than with brackets. Without brackets it looks like a prototype, with it looks like we consciously designed it to look like [ edit ] links?

May 5 2021, 1:55 PM · DiscussionTools, Editing QA, Editing-team (FY2020-21 Kanban Board), OWC2020

May 4 2021

Esanders added a comment to T280606: Post-deployment: evaluate impact on site performance.

As we are proposing applying a shorter expiry time to talk pages, our analysis should probably evaluate talk pages separately (if that is not already planned) to ensure there is no significant regression.

May 4 2021, 5:19 PM · Performance-Team, Editing-team (Tracking), DBA, DiscussionTools
Esanders added a comment to T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget.

The above patch does indeed result in a flicker (on Android, haven't tested iOS), but I think this is neater than setting ce=true.

May 4 2021, 12:23 PM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint)
Esanders added a comment to T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget.

readOnly mode keeps ce=true so that we can detect cursor placement (which it make invisible) and launch contexts.

May 4 2021, 11:49 AM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint)

May 3 2021

Esanders created T281741: Problems with hidden tags on enhanced Special:RecentChanges.
May 3 2021, 5:59 PM · Growth-Team, MediaWiki-Recent-changes
Esanders added a comment to T279157: Create a hidden change tag for edits made with the new source mode.

@matmarex/@Esanders :This doesn't seem to be working in Beta. When I try to filter the recent changes with #discussiontools-source-enhanced, it doesn't show the edit made with Reply tool's experimental source mode. Rather it says "No filters found".

May 3 2021, 5:44 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders claimed T279157: Create a hidden change tag for edits made with the new source mode.
May 3 2021, 5:43 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T279483: When I reply to someone, please indicate the person's gender.

In languages which don't vary the user namespace title by gender (e.g. English) this will result in user genders becoming a lot more visible to other users. While user gender is not considered private data, making it more visible may have unintended consequences.

May 3 2021, 4:47 PM · Editing-team (FY2020-21 Kanban Board), Gender-Support, DiscussionTools
Esanders moved T279124: Make config change to expose source mode with tools functionality and setting from Upcoming to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
May 3 2021, 4:29 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders added a comment to T280784: Aggregate table not working after superset upgrade.

Thanks - I had to recreate most of the filters and groups from scratch as well.

May 3 2021, 4:21 PM · Analytics-Kanban, Analytics, Product-Analytics
Esanders moved T280561: Use the ParserOutputPostCacheTransform hook from Code Review to Needs Discussion / Investigation on the Editing-team (FY2020-21 Kanban Board) board.
May 3 2021, 1:58 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), Technical-Debt, DiscussionTools
Esanders claimed T279150: Topic Subscriptions: Unsubscribe from Notifications from within dropdown.
May 3 2021, 1:57 PM · Editing QA, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
Esanders assigned T263505: Create logging instrumentation for Wikitext editor not affected by ad blockers to DLynch.
May 3 2021, 1:53 PM · Skipped QA, Editing-team (FY2020-21 Kanban Board), Better Use Of Data, Product-Analytics, WikiEditor
Esanders claimed T279448: Content preloaded with visual editor is lost when changing to wikitext editor.
May 3 2021, 1:53 PM · Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor
Esanders claimed T280745: Ensure plain text is pasted into DiscussionTools source mode.
May 3 2021, 1:53 PM · Verified, MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Esanders moved T279448: Content preloaded with visual editor is lost when changing to wikitext editor from Upcoming to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
May 3 2021, 1:35 PM · Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor
Esanders added a comment to T279149: Topic Subscriptions: Improve user interface element for subscribing and unsubscribing to topics on Talk Pages .

I've looked into this a bit more and I'm no longer sure it's a good idea to re-use the section edit link area right now:

  • It makes the subscribe feature harder to pick out on the page, and it is grouped in with a tool that performs a very different action (edit)
  • There will be inconsistency across pages and headings:
    • On most talk pages where VE is disabled you will see [ edit | unsubscribe ]
    • On project pages with __NEWSECTIONLINK__ you may see [ edit | edit source | unsubscribe ]
    • Any heading lower than an h2 will only show [ edit ] or [ edit | edit source ], making it harder to see quickly which sections are subscribe-able.
  • Section edit links are configurable:
    • There's no user preference to disable them, but...
    • They can be disabled for a whole page using the __NOEDITSECTION__ magic word
      • It may be possible to work around this by recreating the section edit link group ourselves, and then just adding one link so you get [ unsubscribe ], but this feels hacky and flaky.
May 3 2021, 1:08 PM · DiscussionTools, Editing QA, Editing-team (FY2020-21 Kanban Board), OWC2020
Esanders added a comment to T273971: Increase VE template dialog size.

The existing sizes in OOUI are:

	small: {
		width: 300
	},
	medium: {
		width: 500
	},
	large: {
		width: 700
	},
	larger: {
		width: 900
	},
	full: {
		width: '100%',
		height: '100%'
	}
May 3 2021, 12:41 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), WMDE-TechWish-Sprint-2021-05-12, Patch-For-Review, WMDE-TechWish-Sprint-2021-04-28, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-Templates-FocusArea
Esanders added a comment to T273426: Add truncation to descriptions.

NB There is also "Read more" functionality in the media search widget:

May 3 2021, 12:20 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (Tracking), WMDE-TechWish-Sprint-2021-04-28, VisualEditor, VisualEditor-MediaWiki-Templates, WMDE-TechWish-Sprint-2021-04-14, WMDE-Templates-FocusArea

May 2 2021

Esanders created T281642: Most infobox images flicker when loading on mobile (from left aligned to centre aligned).
May 2 2021, 4:29 PM · Reading-Web-Local-Wiki-Issues, MobileFrontend