Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (229 w, 6 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders added a comment to T218781: Table changes width after tablesorter initialises.

Amended the selector to be limited to the first row. This will remove the icon from the H1/H2 second row headers in the first example, causing a width change, but fixes the row-headers case which is probably more common.

Sun, Mar 24, 12:38 AM · Patch-For-Review, Performance, MediaWiki-jQuery-Tablesorter
Esanders added a comment to T218781: Table changes width after tablesorter initialises.

I think a solution that results in FOUC in <10% of cases is better than one that results in a FOUC in 100% of cases.

Sun, Mar 24, 12:25 AM · Patch-For-Review, Performance, MediaWiki-jQuery-Tablesorter

Sat, Mar 23

Esanders created T219068: Unwanted scrolling when opening and closing toolbar after scrolling down on iOS.
Sat, Mar 23, 1:55 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders updated subscribers of T219066: Cursor pushed off screen when focussing first line in iOS.
Sat, Mar 23, 1:53 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders updated the task description for T219066: Cursor pushed off screen when focussing first line in iOS.
Sat, Mar 23, 1:24 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders created T219066: Cursor pushed off screen when focussing first line in iOS.
Sat, Mar 23, 1:23 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS.

Related to this topic: it seems like we'd benefit (both on iOS and Android) from moving the "Publish" button in the Talk > Reply UI to the header. For Android users this would mean the button is always visible, and for both iOS and Android it would be a more consistent experience with other Publish/Save actions.

Sat, Mar 23, 12:14 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, MobileFrontend
Esanders moved T218062: Dialogs in iOS mobile VE can't be scrolled from Inbox to High Priority on the Editing QA board.
Sat, Mar 23, 12:07 PM · Editing QA, Readers-Web-Backlog (Tracking), VisualEditor-MediaWiki-Mobile, Patch-For-Review, MobileFrontend, VisualEditor (Current work)
Esanders moved T217798: Selection lags behind scroll on iPhone from Inbox to High Priority on the Editing QA board.
Sat, Mar 23, 12:07 PM · Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders moved T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS from Inbox to High Priority on the Editing QA board.
Sat, Mar 23, 12:07 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, MobileFrontend
Esanders moved T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS from Code review to QA on the VisualEditor (Current work) board.
Sat, Mar 23, 12:07 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, MobileFrontend

Fri, Mar 22

Esanders added a project to T209987: [Engineering EPIC]: Isolate Section Editing: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
Esanders added a project to T215908: Section Editing: Pre-Deployment QA : VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
Esanders added a project to T215717: When section editing, do not build whole CE tree: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable
Esanders added a project to T217198: [Regression wmf.19] Adding a new section shows the heading of the section on top of the TOC momentarily when section edit link is disabled: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, Regression, VisualEditor
Esanders added a project to T217291: Execute Section Editing User Testing Plan: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work)
Esanders added a project to T217269: [Regression wmf.19] Adding a new section does not scroll to the bottom of the page anymore: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, Regression, VisualEditor
Esanders added a project to T217563: [Section Editing] New feature request: add sections while editing: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
Esanders added a project to T217564: [Section Editing] Research Performance Time SPIKE : VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Section Editing
Esanders added a project to T217769: Excessive white space at the end of article/section on iOS: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), Browser-Support-Apple-Safari, Section Editing
Esanders added a project to T218939: Deploy mobile section editing to the next set of wikis (listed in the description): VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Patch-For-Review, Section Editing
Esanders added a project to T217801: Close Section Editing User Test running on MediaWiki: VisualEditor-MediaWiki-Mobile.
Fri, Mar 22, 7:03 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work)
Esanders moved T217769: Excessive white space at the end of article/section on iOS from Code review to QA on the VisualEditor (Current work) board.
Fri, Mar 22, 7:02 PM · VisualEditor-MediaWiki-Mobile, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), Browser-Support-Apple-Safari, Section Editing
Esanders renamed T1181: VisualEditor loading indicator should feel more integrated into the interface from Polish : VisualEditor Loading indicator should feel more integrated into the interface to VisualEditor loading indicator should feel more integrated into the interface.
Fri, Mar 22, 6:50 PM · VisualEditor-MediaWiki-Mobile, Editing Design , VisualEditor-MediaWiki, Design, VisualEditor
Esanders updated subscribers of T218939: Deploy mobile section editing to the next set of wikis (listed in the description).

What is the next step to provisionally schedule this deploy for that date? CC @DLynch, @Jdforrester-WMF

Fri, Mar 22, 6:48 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Patch-For-Review, Section Editing
Esanders created T219021: Create API for setting 'bucket' in VE analytics.
Fri, Mar 22, 6:17 PM · VisualEditor-MediaWiki, VisualEditor
Esanders added a parent task for T219019: Add a bucket field to Schema:EditAttemptStep: T219018: Support bucketing in VE analytics.
Fri, Mar 22, 6:14 PM · Patch-For-Review, VisualEditor-MediaWiki, VisualEditor
Esanders added a subtask for T219018: Support bucketing in VE analytics: T219019: Add a bucket field to Schema:EditAttemptStep.
Fri, Mar 22, 6:14 PM · VisualEditor-MediaWiki, VisualEditor
Esanders created T219019: Add a bucket field to Schema:EditAttemptStep.
Fri, Mar 22, 6:14 PM · Patch-For-Review, VisualEditor-MediaWiki, VisualEditor
Esanders updated the task description for T219016: Add a bucket field to Schema:VisualEditorFeatureUse.
Fri, Mar 22, 6:13 PM · VisualEditor-MediaWiki, VisualEditor
Esanders added a parent task for T219016: Add a bucket field to Schema:VisualEditorFeatureUse: T219018: Support bucketing in VE analytics.
Fri, Mar 22, 6:13 PM · VisualEditor-MediaWiki, VisualEditor
Esanders added a subtask for T219018: Support bucketing in VE analytics: T219016: Add a bucket field to Schema:VisualEditorFeatureUse.
Fri, Mar 22, 6:13 PM · VisualEditor-MediaWiki, VisualEditor
Esanders created T219018: Support bucketing in VE analytics.
Fri, Mar 22, 6:13 PM · VisualEditor-MediaWiki, VisualEditor
Esanders created T219016: Add a bucket field to Schema:VisualEditorFeatureUse.
Fri, Mar 22, 5:41 PM · VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T218851: Instrument mobile visual editor for a section editing experiment.

For future reference it should be noted that userId's are not persistent across wikis for the same user, so if we have a more complex bucket function we should use username to ensure users end up in the same bucket across wikis.

Fri, Mar 22, 5:33 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics
Esanders added a comment to T218939: Deploy mobile section editing to the next set of wikis (listed in the description).
  1. Section Editing should not be deployed to the Wikis listed above until the vanishing-toolbars-while-scrolling (T218414) patch is live on the wikis listed above
Fri, Mar 22, 5:33 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Patch-For-Review, Section Editing
Esanders added a comment to T1181: VisualEditor loading indicator should feel more integrated into the interface.

Side note: we've historically used a gif for that loading spinner, but we could just as easily do it in CSS: https://loading.io/css/

Fri, Mar 22, 4:31 PM · VisualEditor-MediaWiki-Mobile, Editing Design , VisualEditor-MediaWiki, Design, VisualEditor
Esanders added a comment to T1181: VisualEditor loading indicator should feel more integrated into the interface.

Minor nitpicks for when we implement:

  • The text looks like it might be bold, it probably shouldn't be
  • The spacing between the spinner are the text should be reduced. If the spinner has the same spacing either side as the close icon, it looks like there are three separate componenets: close, spinner, message, whereas I think it should look more like: close, spinner+message
  • We can probably probably have a text ellipsis after the message, i.e. "❋ Loading editor..."
Fri, Mar 22, 4:29 PM · VisualEditor-MediaWiki-Mobile, Editing Design , VisualEditor-MediaWiki, Design, VisualEditor
Esanders updated subscribers of T219004: [regression] PHP DropdownInputWidgets have no border in Apex.

Bisect blames https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/444924/ from 8 months ago (@Volker_E)

Fri, Mar 22, 3:52 PM · OOUI (OOUI-0.31.2), Regression
Esanders created T219004: [regression] PHP DropdownInputWidgets have no border in Apex.
Fri, Mar 22, 3:39 PM · OOUI (OOUI-0.31.2), Regression

Thu, Mar 21

Esanders added a comment to T217798: Selection lags behind scroll on iPhone.

Nice!

Thu, Mar 21, 8:17 PM · Editing QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Esanders updated the task description for T218882: Support an 'indeterminate' state for checkboxes.
Thu, Mar 21, 1:55 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences, OOUI
Esanders created T218882: Support an 'indeterminate' state for checkboxes.
Thu, Mar 21, 1:54 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences, OOUI
Esanders added a comment to T218851: Instrument mobile visual editor for a section editing experiment.

The above patch introduces a new 'mobile-ab' config setting that turns on mobile section editing for odd-numbered users. We can use that setting on the next set of wikis we deploy to.

Thu, Mar 21, 1:20 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics
Esanders added a comment to T218851: Instrument mobile visual editor for a section editing experiment.

Given the time constraints I'll skip the nice-to-haves, and we can just bucket users by odd/even userIDs.

Thu, Mar 21, 1:15 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Wed, Mar 20

Esanders added a project to T163142: Buttons in the toolbar should be actual tools: VisualEditor.
Wed, Mar 20, 4:33 PM · Patch-For-Review, VisualEditor, Technical-Debt, OOUI
Esanders moved T217740: CX2: Spellcheck and IME appearing for source sections from QA to Product owner review on the VisualEditor (Current work) board.

Moving out of VE's QA column as QA will be done by the CX team.

Wed, Mar 20, 2:58 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), VisualEditor-ContentEditable, Language-Team (Language-2019-January-March), ContentTranslation
Esanders added a comment to T218781: Table changes width after tablesorter initialises.

After the above patch here is the change in appearance for a simple sortable table, and @matmarex 's minimal failing test case from the previous attempt:

beforeafter
Wed, Mar 20, 1:54 PM · Patch-For-Review, Performance, MediaWiki-jQuery-Tablesorter
Esanders added a project to T218781: Table changes width after tablesorter initialises: Performance.
Wed, Mar 20, 1:49 PM · Patch-For-Review, Performance, MediaWiki-jQuery-Tablesorter
Esanders created T218781: Table changes width after tablesorter initialises.
Wed, Mar 20, 1:37 PM · Patch-For-Review, Performance, MediaWiki-jQuery-Tablesorter
Esanders added a comment to T214132: Switch the 2010 wikitext editor's EditAttemptStep logging to the client side.

There's also not a great place to do saveSuccess client-side, since it'd be on the redirect to a regular article page...

Wed, Mar 20, 12:44 AM · Product-Analytics, VisualEditor
Esanders added a comment to T214132: Switch the 2010 wikitext editor's EditAttemptStep logging to the client side.

If we are to do the timing the same way VE does it, then init should fire when the edit tab is clicked, and ready/loaded should fire on the edit page after init.

Wed, Mar 20, 12:39 AM · Product-Analytics, VisualEditor
Esanders added a comment to T217563: [Section Editing] New feature request: add sections while editing.

Adding headings is something we will be considering as part of our toolbar/context work.

Wed, Mar 20, 12:33 AM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
Esanders renamed T218645: Wikimaniawiki: enable VisualEditor in the "2019:" namespace from Wikimaniawiki: activate the VisualEditor tabs in 2019: namespace to Wikimaniawiki: enable VisualEditor in the "2019:" namespace.
Wed, Mar 20, 12:24 AM · Patch-For-Review, Wikimedia-Site-requests, VisualEditor
Esanders renamed T218492: Remove conflicting section anchors in historical visual diffs from Remove section anchors in historical visual diffs to Remove conflicting section anchors in historical visual diffs.
Wed, Mar 20, 12:20 AM · VisualEditor, VisualEditor-VisualDiffs
Esanders renamed T218492: Remove conflicting section anchors in historical visual diffs from Remove section anchors in visual view to Remove section anchors in historical visual diffs.
Wed, Mar 20, 12:16 AM · VisualEditor, VisualEditor-VisualDiffs
Esanders added a comment to T18691: RFC: Section headings should have a clickable anchor.

For shorter articles that don't have any/many h3's that might be fine, but for feature-article length pages it would be not very useful.

Maybe making this configurable per-wiki is a potential solution?

Wed, Mar 20, 12:14 AM · Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface
Esanders added a comment to T18691: RFC: Section headings should have a clickable anchor.

While the stats on heading levels usage are interesting, I'm not sure they will help with the dilemma: If a heading is commonly used that makes the case for both adding the sharing links and that adding those links will clutter the interface. Conversely for less-used headings it is safer to drop the sharing links, but also won't help will reducing clutter.

Wed, Mar 20, 12:13 AM · Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Tue, Mar 19

Esanders added a comment to T214543: Feature: Recovery of edits after a crash.

I think in the second case we'll fail to recover the edits currently.

Tue, Mar 19, 11:03 PM · VisualEditor
Esanders added a comment to T217783: Lose edits if idle on page.

It sounds like this may have only happened because this was loaded as a webview from withing GChat. Is there a general problem with data being lost when iOS resume from sleep?

Tue, Mar 19, 11:01 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

Mobile browsers unloading the page (T217783)

Tue, Mar 19, 11:01 PM · VisualEditor, VisualEditor-MediaWiki
Esanders renamed T217783: Lose edits if idle on page from [Section Editing} Lose edits if idle on page to Lose edits if idle on page.
Tue, Mar 19, 10:59 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
Esanders added a comment to T218663: Consider switching from sessionStorage to localStorage for autosave.

The main issue with localStorage is not just that we would need to manage old entries, but that we could also run into limits more often (which would probably result in data loss)

  • Even with aggressive garbage collection some users may have multiple documents in storage at any one time
  • ResourceLoader uses up a lot of the storage for its cache
  • On Firefox quota is shared across the whole domain, not subdomains, making it more likely to hit quota. RL caching was disabled on FF for this reason.
Tue, Mar 19, 10:57 PM · VisualEditor, VisualEditor-MediaWiki
Esanders moved T218694: fatal: Project not found: p/VisualEditor/VisualEditor from To Triage to External and Administrivia on the VisualEditor board.
Tue, Mar 19, 10:42 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor, User-zeljkofilipin, MediaWiki-Release-Tools, Release-Engineering-Team (Kanban)
Esanders added a project to T217833: Multiple repaints when loading GlobalPreferences (FOUC): Performance.
Tue, Mar 19, 6:53 PM · Performance, MediaWiki-extensions-GlobalPreferences
Esanders moved T194068: CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces from Code review to QA on the VisualEditor (Current work) board.
Tue, Mar 19, 6:47 PM · Verified, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
Esanders added a comment to T212521: RFC: Let's stop using QUnit as a mechanism for integration tests.

I also think we need to clarify that we really have no strict definition for the difference between a unit test and an integration test. If I test the construction of a complex object, like a VisualEditor data-model document, is that a unit test because it is one method, or an integration test because it triggers thousands of method calls in hundreds of classes?

Tue, Mar 19, 5:29 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
Esanders added a comment to T212521: RFC: Let's stop using QUnit as a mechanism for integration tests.

Selenium tests are slow, fragile, hard to maintain and hard to understand. Using it for integration tests would just make testing harder.

Tue, Mar 19, 5:21 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
Esanders added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

This is an visualisation of the performance improvements over the past few months (loading html/metadata early, speeding up metadata, client side section editing), based on my initial measurements from November:

Tue, Mar 19, 3:46 PM · Performance-Team (Radar), Performance-Team-notice, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
Esanders moved T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization from In progress to QA on the VisualEditor (Current work) board.
Tue, Mar 19, 2:59 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki
Esanders added a comment to T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization.

Given that the metadata request is still block in some cases (especially on shorter articles, or when loading the page a second time) we should go ahead and try and merge the metadata promise separation patch.

Tue, Mar 19, 2:53 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki
Esanders added a comment to T217784: Toolbar in loading overlay should display sooner in sequencing.

On proposal "B" you have "might compete with browser loader".

Tue, Mar 19, 2:46 PM · VisualEditor (Current work)
Esanders added a comment to T1181: VisualEditor loading indicator should feel more integrated into the interface.

I'm not a big fan of the loading dots being used inline. They have only been used once before which is in CX (see T75972) where they are centred on the screen with more padding and at a larger size.

Tue, Mar 19, 2:40 PM · VisualEditor-MediaWiki-Mobile, Editing Design , VisualEditor-MediaWiki, Design, VisualEditor
Esanders moved T217880: Keyboard shortcuts open link inspector in read-only mode from In progress to QA on the VisualEditor (Current work) board.

Let's file the flicker issue as new task, I think it is relative minor given this is already an edge case. I'm sure we could find a way around this, but it may be diminishing returns on the effort required.

Tue, Mar 19, 2:29 PM · Verified, VisualEditor (Current work), Regression, ContentTranslation

Mon, Mar 18

Esanders added a comment to T214790: Allow selection of the page title in Visual Editor.

We should also add cursor:text to indicator the text is selectable, however this also requires user-select to be re-enabled too. @matmarex In your comment you talk about section-0 edit links as content tested in <h1>, where do those appear? Could we add a selector like h1 > a to re-disable those?

Mon, Mar 18, 10:30 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor-MediaWiki, VisualEditor (Current work)
Esanders created T218602: "clear" indicator has narrow click target in SearchInputWidget.
Mon, Mar 18, 10:28 PM · Accessibility, OOUI
ppelberg awarded T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki a 100 token.
Mon, Mar 18, 10:06 PM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile
Esanders added a comment to T208826: Toolbar breaks when I focus on editable content after clicking omega character.

We recently made the heading selectable again. This means it wouldn't make sense to keep the tools available when you click on the heading.

Mon, Mar 18, 4:36 PM · VisualEditor (Current work), Editing Design
Esanders moved T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki from Code review to Product owner review on the VisualEditor (Current work) board.
Mon, Mar 18, 4:24 PM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile
Esanders edited projects for T213522: Reconsider URL changes done by Visual Diff, added: VisualEditor; removed VisualEditor (Current work).

and in these cases users indeed changed the mode twice or even more often to compare.

Mon, Mar 18, 4:23 PM · VisualEditor, VisualEditor-VisualDiffs

Sat, Mar 16

Esanders triaged T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS as High priority.
Sat, Mar 16, 11:24 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, MobileFrontend
Esanders added a comment to T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization.

Here is a 7-day rolling overage of 5th centile load times:


and 50th centile / median:

Sat, Mar 16, 11:12 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki
Esanders added a comment to T209078: Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization.

Re-running the featured-article tests from T206228, metadata and page html now take about roughly the same time. The issue is now less severe, but there are probably more benefits to be had by not blocking on metadata at all.

Sat, Mar 16, 11:04 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki

Fri, Mar 15

Esanders added a comment to T218358: Add data-title attribute to anchors.

VE does this here: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/8846e65e4475fb1942e2d30478d072b5261cd4a7/modules/ve-mw/ve.MWutils.js#L163

Fri, Mar 15, 11:31 PM · Readers-Web-Backlog (Tracking), Parsing-Team, MediaWiki-Parser, Internet-Archive, Parsoid, Technical-Debt
Esanders added a comment to T218358: Add data-title attribute to anchors.

My understanding is that if the link is marked with mw:wikilink you can just infer the title from the relative path. Is there a case where this wouldn't work?

Fri, Mar 15, 11:27 PM · Readers-Web-Backlog (Tracking), Parsing-Team, MediaWiki-Parser, Internet-Archive, Parsoid, Technical-Debt
Esanders added a parent task for T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki: T217230: Section Editing: Deployment Plan.
Fri, Mar 15, 11:23 PM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile
Esanders added a subtask for T217230: Section Editing: Deployment Plan: T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki.
Fri, Mar 15, 11:23 PM · VisualEditor (Current work)
TheDJ awarded T216775: Add ability to cite books by scanning their ISBN barcode in mobile web a Love token.
Fri, Mar 15, 7:01 PM · User-notice, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-Mobile, Citoid
Esanders updated the task description for T218409: Create a button-only mode for SelectFileWidget.
Fri, Mar 15, 4:22 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), OOUI (OOUI-0.31.1)
Esanders added a parent task for T218409: Create a button-only mode for SelectFileWidget: T218407: Use OOUI SelectFileWidget on UploadWizard.
Fri, Mar 15, 4:21 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), OOUI (OOUI-0.31.1)
Esanders added a subtask for T218407: Use OOUI SelectFileWidget on UploadWizard: T218409: Create a button-only mode for SelectFileWidget.
Fri, Mar 15, 4:21 PM · SDC Engineering, UploadWizard, Multimedia
Esanders created T218409: Create a button-only mode for SelectFileWidget.
Fri, Mar 15, 4:20 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), OOUI (OOUI-0.31.1)
Esanders added a parent task for T218408: Add "multiple" attribute support to SelectFileWidget/SelectFileInputWidget: T218407: Use OOUI SelectFileWidget on UploadWizard.
Fri, Mar 15, 4:19 PM · Patch-For-Review, OOUI
Esanders added a subtask for T218407: Use OOUI SelectFileWidget on UploadWizard: T218408: Add "multiple" attribute support to SelectFileWidget/SelectFileInputWidget.
Fri, Mar 15, 4:19 PM · SDC Engineering, UploadWizard, Multimedia
Esanders created T218408: Add "multiple" attribute support to SelectFileWidget/SelectFileInputWidget.
Fri, Mar 15, 4:19 PM · Patch-For-Review, OOUI
Esanders created T218407: Use OOUI SelectFileWidget on UploadWizard.
Fri, Mar 15, 4:18 PM · SDC Engineering, UploadWizard, Multimedia
Esanders updated subscribers of T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki.
Fri, Mar 15, 12:45 AM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile
Esanders moved T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Fri, Mar 15, 12:43 AM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile
Esanders created T218375: Deploy mobile section editing to he.wiki, bn.wiki, zh-yue.wiki.
Fri, Mar 15, 12:38 AM · Bengali-Sites, Patch-For-Review, VisualEditor (Current work), Section Editing, VisualEditor-MediaWiki-Mobile

Thu, Mar 14

Esanders moved T217740: CX2: Spellcheck and IME appearing for source sections from Code review to QA on the VisualEditor (Current work) board.
Thu, Mar 14, 11:15 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), VisualEditor-ContentEditable, Language-Team (Language-2019-January-March), ContentTranslation