Adding the custom messages reflecting Welcome survey responses.

Mobile

The screenshots for review.
Desktop

Note: The size of the popup seems bigger than in the mockup .
<div class="oo-ui-window-frame" style="transition: all 0.25s ease-out 0s; width: 700px; height: 512px;">

Checked in betalabs.
(1) They can dismiss the overlay by clicking away.

• the spec is not in place - with the popup everything else becomes inactive.

The issues mentioned in this comment - have been fixed.
One thing to take a look at - the arrows look kind of big (it's in production)

Moving for Design review - to decide if the issue require some additional work.
Checked in betalabs - it doesn't seem to fix the particular problem when the task description occupies more than one line. The info icon insists on being on a new line if the description is spanned on several lines (it's also the case for variants C/D).

I checked in betalabs and production wmf.9 (tested in Chrome and Chrome mobile emulator and a real iOS device); listed some issues below.

Checked in production wmf.9 - max-width: 20px is set for all three elements:

The issue with jumpiness seemed to be due to length/placement of labels for difficulty levels (also the info icon and the task time estimation) which was changed (this @kostajh comment)

Thanks @Aklapper - the issue is confirmed; I added Regression tag and some clarification points to the steps you described.

The specs for the info icon (20x20px) are in place:

.oo-ui-iconElement-icon {
    background-size: contain;
    background-position: center center;
    background-repeat: no-repeat;
    position: absolute;
    top: 0;
    min-width: 20px;
    width: 1.42857143em;
    min-height: 20px;
    height: 100%;
}

Mobile

betalabs	mockup

Checked in commons wmf.9 - all is in place, except for

The metadata shown for each page result should be: Page title, page size (page size will be handled as part of T262992), word count (this is currently not feasible)

Checked in commons wmf.9

Verified in commons wmf.9 - works as expected.

In T263042#6467804, @kostajh wrote:

@Etonkovidova is your user opted into new Vector or the old Vector?

For Design Review:

For Design review - A, B, C, D are done (marked with check marks). Please review E - the blue background is displayed with a gap after overlay-header header :

Checked in betalabs - the banner header is removed:

variation C/D	the header is present

Just FYI- checked in hewiki wmf.8 (also re-checked for regression in`arwiki`) - the issue is fixed.

In T164307#6463957, @Urbanecm wrote:

This was just deployed :-).

In T258110#6448684, @CBogen wrote:

@Etonkovidova, would you be willing to test this again on production? I was able to verify the close and more details buttons, but I don't have the right tools to verify w3 accessibility compliance.

Checked in commons wmf.8.

I've added comments (and the testing results for testwiki wmf.8 to T164307)

In T261173#6449479, @MMiller_WMF wrote:

@Etonkovidova -- thanks for thinking about this. I'm not too worried about it, for two reasons:

• This would only be an issue on desktop, not mobile.
• Our reports that use this EventLogging are mostly for us to track increases and decreases over time -- not as measures of exact numbers of how many users do a certain thing. We already know that we're missing some portion of users who don't have Javascript or don't get events logged for other reasons, so we know the numbers aren't perfect.

Thanks, @Tgr ! I wonder if it's possible to estimate how many users open links in a different tab/window. We might be missing a good chunk of relevant stats.

Checked for #Reverted tag filter on testwiki wmf.8 - looks good.

Checked in testwiki wmf.8

Checked in betalabs - moved to Verify in production.

Checked in betalabs - works as described in Expected Results.

For Design review - thanks @Catrope for the screenshots in this comment, I don't need to provide any additional screenshots here.

Thanks @Dyolf77 for rechecking and clarification.

@RHo - If I understood the mockup correctly, there seems to be a difference between the desktop mockup where the mockup has the following:

-Icon-24x24px {
width: 24px;
height: 24px;
}

and betalabs has

growthexperiments-homepage-module-suggested-edits.growthexperiments-homepage-module-desktop .growthexperiments-homepage-module-header-icon .oo-ui-iconWidget {
    min-width: 30px;
    min-height: 30px;
}

betalabs with 30pxX30px	betalabs with 24pxX24px

Confirmed in betalabs. The echo_event='pagetriage-mark-as-reviewed' should have a primary link to The reviewed page ($3) (Notifications spreadsheet. If a page with a redirect was the page that, in fact, was reviewed, the primary link should lead to it.

Thanks, @Dyolf77 for reporting! I checked on arwiki betalabs for both - when a question is answered on a Mentor discussion page and for questions answered on Help desk. I did not see that Reply with mention will produce two notifications.

In T261819#6430000, @PPham wrote:

@Aklapper Hi, sorry for using WMF account on this personal matter. I'm Bluetpp. Here are the two diffs that I got pinged but wasn't notified:

• Diff 1
• Diff 2

These are the 2 times that I found out, there may be other cases as well that I haven't known of.

Thank you.

In T261800#6430421, @CBogen wrote:

@Etonkovidova I believe this is a duplicate of T261818 - if you think there is some difference, please reopen. Thanks!

@MMiller_WMF - the issue looks familiar but I could not find any direct references to it in the phabricator.

Checked on betalabs - works according to the specs.
The animated gif shows opening SE article, the Help panel opening/closing (in real life the animation is much smoother than in the gif).

As a follow up on the issues in my comment (and after testing T256673) based on @CBogen's comment on T256673, the following tickets have been filed:

In T256673#6423251, @CBogen wrote:

@Etonkovidova thanks for reporting these. I think that the delay issue should be fixed as part of this ticket (unless you'd rather have a new ticket, @AnneT).

For the other issues you mentioned in T252891, I think it's best to file them as new tickets. I don't think we need an epic to track them. We can assign them to the Media Search Release Candidate milestone. Some of them may be addressed by the work the Search team is doing on Query Completion, which is currently waiting for legal review (T250436), but I'm not sure. The issues with CJK languages mentioned will hopefully be addressed by Query Completion as well.

In T232410#6424488, @Catrope wrote:

My patch addresses these styling tweaks:

In T232410#6377157, @MMiller_WMF wrote:

1. Error message styling:
   • Make background color #FFF instead of base90
   • Make font-size smaller (14px)
   • Adding padding-top:4px

1. The page https://fr.wikipedia.org/wiki/Discussion_utilisateur:Braaark (no > at the end - since it make the title invalid) is not Flow -based (page_content_model: wikitext). The page gets archived periodically.

Closing as Resolved - however, might follow up on accessibility testing. Chrome Lighthouse Accessibility report marks the page as 86% passed. The complaints are about

Failing Elements
span#imageSize__textbox.wbmi-select__current-selection
span#mimeType__textbox.wbmi-select__current-selection

Checked on commons wmf.6 - the autocomplete is present.

Checked on commons betalabs - no Vue warn were displayed.

In T258453#6416211, @CBogen wrote:

Hi @Etonkovidova - now that we have the list of test cases, can we close this task?

Thanks, @AnneT - yes, indeed it was a mystery:)
Only after some time spent on re-checking I think I figured it out - a trailing space or some punctuation at the end of the search items dramatically change the returned result.

Checked (also on mobile) no issues have been found - moving to PM Review.

Checked on commons wmf.6 - all looks according to the specs (T261365 was filed separately).

Checked on commons wmf.6 - looks fine. If @mwilliams doesn't have any adjustments/comments -then the task can be Resolved.

Checked on commons wmf.6.

Checked on commons wmf.6 -works according to the specs.

Checked in commons wmf.5

• Images, Audio, Video files are displayed correctly in Quickview when url parameter changed or when a selection of a language is made in the sidebar menu.

Another similar issue - T261171: Echo notification clickable link area overlapping Homepage link