For Design review:
|present production - testwiki| betalabs with the fix

Checked in betalabs:

Checked in betalabs - all specs seems to be in place:

For Design review:

     .growthexperiments-homepage-mobile-details .growthexperiments-homepage-mentorship-intro, .growthexperiments-homepage-module-mobile-overlay .growthexperiments-homepage-mentorship-intro {
font-size: 1.1em;
letter-spacing: 0.016em;

For design review -checked in betalabs.
Below is comparison with the present production:

Since T203893: Deduplicate mention and mention-summary notifications for the same edit refers to a different venue for triggering duplicate messages, it'd be worth to keep this issue separate (especially, since it is in the context of the newly introduced Help panel).

In T229779#5414966, @DannyS712 wrote:

In T229779#5414957, @Etonkovidova wrote:

@dom_walden In betalabs the "Add a message for the creator" textfield is displayed (I was checking NewPagesFeed for issues unrelated to this ticket):

What page are you looking at? The "add a message for the creator" should be displayed on articles, just not for user pages

Yes, you're right - I see it now, sorry. So, all is working as expected. User pages do not display the textfield, the article pages doesn't display it.

@dom_walden In betalabs the "Add a message for the creator" textfield is displayed (I was checking NewPagesFeed for issues unrelated to this ticket):

The issue is not specific to Special:RecentChangesLinked - other transcluded Special pages (e.g. Special:RecentChanges) display the default timezone (the server time, UTC) instead of a user preferences.

On mobile there are other places where the date format is displayed differently when being loaded- in the animated gif below 'a year ago' changes to '1 year ago':

In T222836#5409552, @kostajh wrote:

@Etonkovidova how come this is in progress? Is there anything else to do for this task?

Some of the facts about newcomers' biggest challenges and needs in which the projects are grounded.

In T229271#5408898, @kostajh wrote:

FWIW, I can't reproduce either of these issues on wmf.17 (testwiki) or beta, but the approach in the patch seems better than what we have now.

Checked in betalabs - the issue is fixed.

@Cntlsn - please take a quick look: (I'll follow up on the bug reported above).

@Catrope - there is a regression in betalabs only; the articles' edits are displayed on one line:

From	to

Moving to Need Discussion/Analysis on Growth-Team workboard - it seems some overlook in functionality when Hide option for filters was added.
The screen recording (animated) shows the absence of the "View new changes..." link when filters are hidden.

In T230150#5404043, @Nirmos wrote:

The colon is there in the screenshot you added (directly below "Active filters"). I should probably mention that this is not a new issue – it's been like this since Recent Changes was revamped. This is just speculation from my part, but it looks like some developer tried to add the colon there to emphasize that the filter has to do with namespaces (which contain colons), but added it on the wrong side of the namespace itself (i.e. :MediaWiki instead of MediaWiki:).

@DannyS712 - to restore a deleted topic a user needs to have admin rights.

@DannyS712 - can you provide a link to the page?

@Nirmos - can you clarify where did you see a stray colon? Following the link in the task and searching for MediaWiki - the label seems to be displayed correctly:

@Cntlsn - there are two things to notice

• in your mockup the parentheses around (change) link are black - on Homepage the parentheses are part of the link:

<a class="growthexperiments-homepage-email-change-link" href="/wiki/Special:Preferences#mw-prefsection-personal-email">(change)</a>

• the (change) link color looks different in Mobile vs desktop. The color changes when you switch from Vector (default) skin on desktop to MinervaNeue - from #0645ad; to #3366cc; and it's not because the links were visited.

Checked after deployment on wmf.17 and wmf.16 - seems to be working fine
@Trizek - some users who attempted to disable Structured Discussion beta features before the fix may have the checkbox for the option unchecked. To disable it now they may need to check it again/save, and then uncheck/save to disable it.

Closing since the task has been done during Outreachy term. @Ephemeralwaves currently works on other Automation tests tasks.

In T225941#5397130, @JTannerWMF wrote:

@kostajh, a question that came up in Triage is why this marked only for Mobile?
We are going to move this task to Upcoming to discuss priority in Grooming.

Since the patch was deployed to wmf.14, wmf.15, wmf.16 and no errors were reported, and, also, logstash for testwiki (wmf.17) doesn't display such errors - I'm closing the task as Resolved.

The issue is confirmed on testwiki, arwiki, and cawiki. Even 'Restore all default settings' does not disable Structured discussion (the checkbox is displayed unchecked in Beta features).

No console errors for ContentTranslation with Minerva skin.

Checked the reported issue in

In T218839#5378480, @Catrope wrote:

(2) A protected page has 'View source' option for users who cannot edit protected pages. Clicks on 'View source' won't trigger impression event.

Are you saying the help panel is displayed, but no impression event is logged? Or is the help panel not displayed on View source page views at all?

Yes, the issue is not present anymore - not in betalabs, not in testwiki (wmf.16).

@kostajh When a page is loaded, there is a short dispaly of an actual date of registration, see the screen recording below (similar issue to T229271). On slow connection network it's more noticeable, of course.

The default view for the middle tab is as the following and it looks acceptable to me (I checked with a real device and browser emulators):

My testing verifies what @SBisson wrote in the following comment:

It's still easy to trigger such an error by adding gibberish in topic_format- e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Unj7kyi6l90b6ahp&action=edit-title&topic_postId=unj7kyi6l90b6ahp&topic_format=GvgRTzVl .

Tested in betalabs - enabling Homepage (from Special:Preferences or by default for a new user) doesn't enable AMC. I checked the absence of AMC according to list AMC-related features T229295.

There are some changes to UI in T225669 that make the reported issues not-relevant.

Checked after deployment to wmf.15.

I checked with my testing users in production - two of them were assigned mentors and with custom descriptions and descriptions were displayed, as in Dyolf77_WM comment.

Checked in betalabs - no second tour is shown to new users.

Another error on Create account:

[XUBvxawQBHcAABhPC58AAAAG] /w/index.php?title=Special:CreateAccount&returnto=User:ET240 ExternalStoreException from line 140 of /srv/mediawiki/php-master/includes/externalstore/ExternalStoreAccess.php: Unable to store text to external storage

@Cntlsn Added the screenshots after the above patch was merged:

@Trizek-WMF - please check the following examples or real arwiki accounts with Arabic native speakers.

@Cntlsn - if all look satisfactory to you, please move to PM Review column.
Posting the same screenshots (but bigger) as in https://phabricator.wikimedia.org/T227109#5334845 comment:

In T225669#5320868, @kostajh wrote:

5. [Mobile] Help panel X has frame

Re-checked -fixed with T225669

@Cntlsn - for your review. I copied the task description screenshot and added the third column for the most current state on beta:

@herron I use two email addresses when testing email creating/confirmation/updating. Both of them were failing to display confirmation links, although all emails to such addresses (from users who previously set their email) was fine.

Agree with @kostajh and @Dyolf77 - re-checked in betalabs with the text from Mentors page, the descriptions get displayed:

Checked the fix in betalabs - works as expected.

I checked how icons in CologneBlue and Modern look like (comparing it with the screenshots in https://phabricator.wikimedia.org/T141944#3148178.

CologneBlue			"You have new messages" is partially obscured
Modern			somewhat hard to see blue (active) color for Notices against blue background

Merged T228946 into this task;

Checked in betalabs - the issue is fixed. Added to the to post-deployment checklist.