Checked in commons wmf.33

Before	After (wmf.33)

For Design review - the specs seem to be in place. However, please review the following

I'm closing this task as Resolved (tentatively) since there is T276634: [wmf.33-regression] Homepage: "Ask your mentor" panel displayed short which might be caused by one of the patches for this task (it seems unlikely though).

@Urbanecm_WMF - Since hrwiki does not have Mentor list, the https://hr.wikipedia.org/wiki/Posebno:Tvrde_prido%C5%A1lica?uselang=en displays [[]] istead of the Mentor list page. Do you think it'd be worth improving the error message on the page?

In T275684#6883280, @Zblace wrote:

Hi folx - is it possible to test use this on HR Wikipedia without full translation? Most younger Croatians actually only know English terminology of interface as very few apps are translated and localized anyway. I would like to trey to show it to a few I plan to work with. Best Z

UI language can be switched to English in User preferences. Or uselang=en can be used as an URL parameter to see the page in English.

Checked in wmf.33 - no impact_module_state errors are present (and no other errors for bnwiki).

For @RHo quick review

@RHo - thanks to @mewoph for the screenshots posted above. Also I verified that all changes from your comments seem to be in place.
If all look ok to you, you may mark the ticket as Resolved.

Checked - all seem to be in place. I'll keep the ticket in QA column to recheck after deployment in real mode.

Checked - seems to be ok. Testing various queries via cirrusDumpResult, e.g.
https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&cirrusDumpResult=&q=%22mavetuna*cat%22&ns0=1, there were never failures, timeouts, or negative scores.

Re-checked the query + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / with https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&cirrusDumpResult=&q=https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&cirrusDumpResult=&q=%2B+-+%3D+%26%26+%7C%7C+%3E+%3C+%21+%28+%29+%7B+%7D+%5B+%5D+%5E+%22+~+%2A+%3F+%3A+%5C+%2F&ns0=1&ns0=1

Re-tested in commons wmf.32 - all issues listed in the task are not present anymore.

For @RHo review - the animated gifs are from betalabs (please disregard temporary deficiencies, e.g. double labels and zero results) and testwiki wmf.32 for comparison.

Re-checked - the error is not present anymore. I'm assuming that the schema version is now have been properly updated to 1.1.0 .

I'll be re-testing the ticket today and posting the results here. I feel that some of the issues do not exist anymore on IE11.

During testing for wmf.32 deployment I noticed that VE Media search is slower than Special:MediaSearch on commons. Repeated searches (the searches run second time with the same search terms) run significantly faster.

@Urbanecm_WMF and @MMiller_WMF - thanks for the putting together the doc!

I was monitoring logstash eventgate-validation dashboard for couple of recent deploys - there were no new (or old) errors recorded that haven't had a phab task (as @kostajh said, there are specific tasks for individual errors).

In T274198#6862670, @Tgr wrote:

• there are no ORES topics on beta. We'd have to set a bunch manually.

Checked in commons wmf.32 - no 429 errors, the thumbnails are promptly displayed when scrolling.

Tested on commons wmf.32
@egardner, @Matthias - please confirm that the following is the expected behavior.

In T256126#6814576, @Urbanecm_WMF wrote:

Thanks @Etonkovidova! I'm wondering what "some account upon creation have a prompt (on a page, not a popup) to enable Homepage" refers to? I'm not sure if that's right behavior.

Checked on severall wikis - arwiki, hewiki, ruwiki, srwiki, bnwiki, and thwiki - the welcome survey is present (without any issues) on Special:WelcomeSurvey page.

Checked bnwiki wmf.31

Moving to PM review - FYI only. No issues.

Checked on rowiki wmf.31 and testwiki wmf.32 - all seems to be back to normal. A mentor once assigned is not changed with reloading the page or any user action (except for "Restore all default settings" in Prefeences).

Thanks, @Moson81! The issue is not reproducible in our testing environment, although it's consistently reproducible in production following the steps that I described above.

Please confirm that the following is expected - Special:Homepage can be enabled via Special:Preferences. I created a new user - Homepage was not enabled, but there were a message with links directing to go and enable Homepage in Preferences.

• lots of untranslated labels
• no 'Add link' tasks
• no Mentorship module
• Special:Homepage -> พิเศษ:หน้าแรก - is not found, only พิเศษ:Homepage is found. I checked for Special:RecentChanges ->พิเศษ:ปรับปรุงล่าสุด -- both (English and Thai) are found.
• there are small visual discrepancies. I guess that's because of translation is not done. I compared with testwiki for possible regression - no regressions. I will re-check after ore translation will be done.

thwiki	testwiki

Minor questions

• So the de-facto default is "All"?
• "Discussion" and "General Help" labels assume that users do know which namespaces are included in those groups?
• "Custom" label might be viewed as implying that something is "custom" with namespaces not with the selection of namespaces

Checked rowiki - the issue is confirmed. When Special:Homepage reloads, the Mentor gets reassigned.

I've created a slide deck to summarize my experience with logstash and eventlogging - QA presentation_Logstash.

In T262271#6507823, @matthiasmullie wrote:

Ok, so here's what'a relevant for VE:
1: We make mediasearch the default search profile for NS_FILE searches on Commons (that's this ticket). Nothing needs to change for VE since they're already doing the perfect API requests. Everything will remain the same as VE is concerned, except that the search results should start to become better.
2: (optional) VE currently sends language-agnostic API requests - I've prepared a small patch that adds the user language, which should improve multilingual searches (e.g. could better differentiate between English or German "gift")

Checked in betalabs - looks great. Added to the list of post-deployment checking.

For @RHo review - the following differences between mockups and implementation have been confirmed (in comments) as correct.

• no capitalization of Suggested edits
• suggested edits are bolded

Thanks, @Matthias and @egardner - yes, it's interesting that some misspellings do not return any results. And re-checking if there are (with filter selections) any results will be expensive. Overall, all is working as expected.

Checked in commons wmf.31 - works as expected, Did you mean is displayed with the suggested correction for a query.

Checked production commons wmf.31 - logstash eventgate-validation dashboard predictably shows
'.action' should be equal to one of the allowed values

for @RHo review if all objectives of this tasks are done and since you mentioned that you're ready to close the task.

In T272531#6831087, @NicoV wrote:

Hi @Etonkovidova

I thought it was happening again today, I even took screenshots, but I noticed one line with several hundreds modifications from Wikidata for a single user page...
It was probably something similar last time, I think we can close this task.

In T269366#6833275, @kostajh wrote:

@Etonkovidova do you want to do more QA or shall we resolve this? I think the QA is basically to check the full workflow of suggested edits (difficulty filters, guidance content, change tags after edit). The code has been in production for a few trains now.

@egardner Yes, I wasn't sure about 1.0.0 - some schemas have been migrated, some haven't. There was a case with HomepageModule schema when events were rejected because of old version number, so I made a note to re-check in production. Good thing that you caught the incorrect versioning!

In T271174#6836263, @matthiasmullie wrote:

I think that looks great

for @RHo review. The screenshots are animated gifs - click to see the animation.
(1) Here is the current behavior in production (wmf.30) with network throttling (2G) - the counter shows up practically instantaneously.

Changing topic filter	Changing difficulty level

Checked in betalabs - both events are present

@egardner - https://gerrit.wikimedia.org/r/650145 need some additional action to be Merged? I see that you +2ed it, but the patch has 'Ready to submit' and 'Merge if Necessary' status.

Checked in wmf.30 - the error is not present.

Here are the steps when the issue happens (I'm almost sure that the issue occurs for some different scenarios too).

Checked in wmf.30 (along with T273700) - the errors are not present.

Thanks everybody for the comments! Lots of info to digest, it's great.

The issue is not specific to bnwiki. Other languages - Russian and German, for example - display the same issue.

Russian lang	German lang

Checked in betalabs - the search term teszing The link in "Did you mean: testing" starts the search for testing.

Cross-browser testing is done, looks as expected.

In T274610#6826367, @CBogen wrote:

On category redirects, I agree they may not be informative but fixing that issue seems out of scope of this UI right now.

I'm inclined to close this as declined, but will wait until we discuss at backlog grooming.

"More" menu displayed inependently from Advanced mode.
Enabling Homepage will remove "More" menu from UI - the issue is confirmed.