For @RHo review - functionality-wise, all seem to be in place.

• is the dimming a little bit too strong?

For @RHo review:

In T238460#5691928, @Tgr wrote:

When the modal dialog opens, the whole page can shift left. (Only seems to happen on narrow mobile screens; I saw it in desktop Chrome in mobile emulation mode using iPhone 8.) That's due to rGOJU6a5914dda8f8: Compensate for loss of margin when opening modals and not related to the patch, but it becomes much more jarring now that it affects the button that's being clicked. Not sure what to do about that; it seems like an OOUI bug, but maybe I just don't understand what it is for (or maybe it doesn't affect real mobile devices?).

before click	after click

mediawiki does shows some results for the "Translation" filter (which, btw, coincides with the the Namespace filter Translation). So the result set look like fetching results for pages starting with Translations: or log entries that related to deletion/moving of such pages:

In T235717#5712124, @kostajh wrote:

@Etonkovidova we need to update one of the beta labs environments to use the local configuration + search. Maybe CS wiki? And we should probably switch Testwiki to use a local configuration and search as well.

Checked in betalabs eventlogging db and it seems that several issues noticed by @MMiller_WMF

Notes for testing: check mdiawiki-new-errors dashboars after wmf.8 will be deployed to group 2. Presently, there are numerous errros on DeferredUpdates (especially for viwiki).

Checked in betalabs - HomepageModule homepage_pageview_token will match EditAttmeptStep:editing_session_id when a user clicks on Suggested edits' article.

Checked in betalabs - mobile-overlay is recorded only when a user taps the module.

Checked in arwiki - Welcome survey looks fine; also the responses are stored in db.

In T229078#5679406, @ssastry wrote:

@Etonkovidova Can you run your Flow tests on Beta cluster again? Basic tests as well as more complex tests to make sure all content use cases continue to work.

@Tgr -is this config setup missing?

In T238178#5689413, @kostajh wrote:

Another nice-to-have with this for local development and QA would be to parse GERestbaseUrl, if set, and extract the domain (e.g. cs.wikipedia.org) to use there, rather than relying on wgServer.

@MMiller_WMF

In T232419#5672996, @MMiller_WMF wrote:

I just tested and confirmed today that the correct personalization is happening with each welcome survey response. The text in the start module changes appropriately.

All specs seem to be in place

Re-checked the following comments - the patch worked for both issues:

After the user has initiated the SE module, and they attempt to return to it through the start module, they have to go through the overlays >again. They should not get the overlays again; they should go straight to the module.

[mediawiki/extensions/GrowthExperiments@master] Disable done button when no checkboxes are selected
https://gerrit.wikimedia.org/r/551809

I went through comments and recent changes/fixes and below is the summary of major points for this task:

Thanks, @Tgr! I agree that the behavior is reasonable. Moving to PM column.

Checked in betalabs - the logic for alternating articles based on difficulty filter seems to be working as intended. There is the case when, e.g.
Easy -"Add links" is selected and it fetches only 33 articles and Hard - "Expand short" filter is selected which fetches only 16 articles. In this case, first 16 articles will be alternating, and remaining 33-16 Easy-"Add links" articles will be displayed in uninterrupted sequence, of course.

Re-opening the task since T237483 does not address this particular issue.

There is still an issue with placing pageviews correctly (as per the comment - https://phabricator.wikimedia.org/T237483#5662244 and T238322).
The examples from production:

For Design Review - the issue is fixed (checked in betalabs).

Checked in betalabs (including the following phab tasks - T238322, T238324, T238325). I've added this task to the list of tasks to check in production.

Thanks, @Urbanecm - I re-checked and it works. I had to create a new user to see that the issue is fixed.

Just to clarify - the task description means:
"Currently, if the user opens up the difficulty filter (and does not make any selection/de-selection of filters) and dismisses it with the "x" (which means "cancel"), the whole set of suggestions is refreshed again from random."

Checked in betalabs - looks acceptable (including IE11 and Edge): and confirmed as such by @Volker_E.

@Catrope - is the patch really merged? That what I still see in kowiki betalabs.

1. Login to kowiki betalabs as a user with not enabled Homepage ->and enable Homepage
2. On Homepage click to activate Suggested edits
3. The Suggested edits module will present Easy filter as default with 'No suggestions' image
4. Click on the filter selection button - and deselect/select the only Easy filter that it's present - the suggested edit card appears.

The sequence of screenshots is as the following;

In T238169#5659280, @revi wrote:

Catrope's version LGTM from my eyes. Nothing cut from the above.

Context-driven testing about testing best practices - the discussion topic

I'm moving the task back to Ready for Development since not all specs have been implemented.
(1)

Once the user initiates the suggested edits module and completes the overlays, the submodule about suggested edits should remain in the start module. It should not disappear like on desktop.

The current display matches the behavior on the desktop:

@MMiller_WMF - moving to PM just for informing you that the task is done and was verified in production.
Checked in wmf.5 - all links listed in the table are in place.

@revi - thanks fo testing. Yes, what you described it's a workaround.

Suggested edits do load after activation - a user does not need to do any additional actions after clicking on 'Get suggestions' on the second intro overlay, however, there is T238037: Newcomer tasks: on mobile 'Suggested edits' activation will flash 'Start here' module and Homepage.
Closing this task as resolved since the scope of the issue was to eliminated redundant user actions - this is done.

Mobile screenshots with notes

• there is a bug T237710: [mobile] Newcomer tasks - <vector-view-edit> is displayed in intro overlay - needs to be fixed
• the link a the bottom - "you can learn how here" - cannot be clicked cause it cannot be scrolled into the view (even in the landscape position). It's essentially the same problem as in T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay (case #2), but for the intro overlay is critical to have that link available. I've updated T236854

Checked in production wmf5 with the hidden feature - the numbers listed in the task description are not displayed.
euwiki (Basque wiki )- 900K
cswiki 20M
kowiki 30M
viwiki 30M
arwiki 80M

@MMiller_WMF - moving to PM Review column to inform you that the issue is resolved.

Re-checked - the issue does not present on beta, but it's still on testwiki. I'll add this to the list of what should be checked after the next deployment.

All three problematic notifications are thank-you-edit notifications. I checked cawikisource- I cannot thank a user for the edit. The link cannot be clicked (not sure if it's relevant to the reported problem).
I moved the task to Growth Current sprint so it can be triaged and evaluated.

For Design review - the following spec displays a differenct logic (checked in betalabs):

If the user unchecks all the boxes, the "Done" button is disabled, and a warning message is displayed at the top of the overlay. If they close the dialog, it is like "Cancel", and their settings are unchanged from when they opened it.

Checked as per T237056

Checked in testwiki and cswiki - the text extracts look as expected (no wikitext and no references to templates).

Checked in betalabs - the patch fixed the placement of the label:

Difficulty overlay:

Screenshots for Design review - Personalized content based on user answers on Welcome survey:

To fix a typo or error in a Wikipedia article
To add or change information to a Wikipedia article
To add a photo or image to a Wikipedia article
To create a new Wikipedia article
I'm participating in a program, class, or event (To read Wikipedia, Other)

For Design review - A slight deviation from the mockup (marked with )

The overlay's header is "Suggested edits to get started".
Then there is a second header that says, "Wikipedia is built by people like you working together."

Mockup	Current implementation

When a article card changes - there will be three url requests present
e.g.

https://cs.wikipedia.org/w/api.php?action=query&format=json&prop=info%7Cpageviews%7Cpageimages&inprop=protection%7Curl&pvipdays=1&pithumbsize=260&generator=growthtasks&ggttasktypes=copyedit%7Clinks%7Creferences%7Cupdate%7Cexpand&formatversion=2&uselang=cs

Checked Flow pages on betalabs - with T234242 being resolved, all seem to be working now.

Checked in testwiki wmf.5 - looks good. Two new issues are found and filed separately - T237681 and T237684.