Page MenuHomePhabricator

Florian (Florianschmidtwelzow)
Volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:13 AM (249 w, 2 d)
Availability
Available
IRC Nick
FlorianSW
LDAP User
Florianschmidtwelzow
MediaWiki User
Florianschmidtwelzow [ Global Accounts ]

Recent Activity

Today

Florian created T228445: Special:SpecialPages throws error when not logged in.
Thu, Jul 18, 4:03 PM · Patch-For-Review, GoogleLogin

Sun, Jul 7

Florian created T227401: MediaWiki does not select master if reader lags for viewing pages.
Sun, Jul 7, 10:48 AM · MW-1.34-release, MediaWiki-Database

Tue, Jul 2

Florian closed T223749: ReCaptcha v1 not supported anymore as Resolved.
Tue, Jul 2, 4:03 PM · ConfirmEdit (CAPTCHA extension)

Jun 1 2019

Florian added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

One more thing that frustates me a lot (and directly pays in into the developer Productivity vision in my opinion) is, that MediaWiki makes it complicated to run tests for people who didn't know how it's done specifically in MediaWiki. Like phpunit tests. You can't run them out of IntelliJ at all (as far as I know, I'm not sure how this is in other IDEs) and you can't run them easily with the default phpunit commands (which you may know from other PHP projects already). So a new MediaWiki developer needs to go through a lot of documentation first in order to know how to run tests.

Jun 1 2019, 10:30 PM · International-Developer-Events

May 30 2019

Florian added a comment to T223898: Remove the requirement to enter a password during the login flow.

I played a bit with the first solution, however, it turns out that, even if we move the password field into a second step (which would mean, that the AbstractPasswordPrimaryAuthenticationProvider needs to return a UI AuthenticationResponse in the beginPrimaryAuthentication step), there's the problem thet AuthManager requires a response from continuePrimaryAuthentication to be non-ABSTAIN (which makes kind of sense). However, this means, that there can only be one password authentication provider listening for the second, new, UI step, however, core ships with 2 already (temporary and local passwords).

May 30 2019, 7:48 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization
Florian committed rEPLL7e48d2f11c64: Remove separate login with smartphone button (authored by Florian).
Remove separate login with smartphone button
May 30 2019, 7:41 PM
Florian committed rEPLLe747c8f1b4ab: Save confirm status when user confirmed a new device (authored by Florian).
Save confirm status when user confirmed a new device
May 30 2019, 7:41 PM
Florian committed rEPLL718128cbdeee: Remove separate login with smartphone button (authored by Florian).
Remove separate login with smartphone button
May 30 2019, 7:39 PM
Florian committed rEPLLcd67d93236c2: Save confirm status when user confirmed a new device (authored by Florian).
Save confirm status when user confirmed a new device
May 30 2019, 7:33 PM
Florian committed rEPLL21993f55be4d: Correctly abstain on non-confirmed device (authored by Florian).
Correctly abstain on non-confirmed device
May 30 2019, 7:18 PM
Florian committed rEPLL4fcd6bd43728: Use wgExtensionAssetsPath instead of scriptpath (authored by Florian).
Use wgExtensionAssetsPath instead of scriptpath
May 30 2019, 3:17 PM
Florian closed T224371: Move PasswordlessLogin extension to gerrit as Resolved.
May 30 2019, 3:16 PM · PasswordlessLogin
Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 30 2019, 3:16 PM · PasswordlessLogin
Florian committed rEPLL0c42f34ce03e: Use wgExtensionAssetsPath instead of scriptpath (authored by Florian).
Use wgExtensionAssetsPath instead of scriptpath
May 30 2019, 3:16 PM
Florian committed rEPLL62d661839277: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 3:04 PM
Florian committed rEPLL30f9768de4bc: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:58 PM
Florian committed rEPLL1ea74fbeee12: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:54 PM
Florian committed rEPLL756af56fec79: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:45 PM
Florian committed rEPLL14f017d1149a: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:16 PM
Florian committed rEPLL62eea916eaea: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:11 PM
Florian committed rEPLLfeacec8f3d75: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:01 PM
Florian committed rEPLLea3dd181416d: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:36 PM
Florian committed rEPLLea782fe0c01a: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:27 PM
Florian committed rEPLL17d98f5fdcaa: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:25 PM
Florian committed rEPLLaa042ca54ce5: Use php 7.0 compatible libraries (authored by Florian).
Use php 7.0 compatible libraries
May 30 2019, 12:42 PM
Florian changed the status of T224667: Bump endroid/qr-code to latest php 7.2 compatible version from Open to Stalled.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian created T224667: Bump endroid/qr-code to latest php 7.2 compatible version.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian changed the status of T224666: Bump endroid/qr-code to latest php 7.1 compatible version from Open to Stalled.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian created T224666: Bump endroid/qr-code to latest php 7.1 compatible version.
May 30 2019, 12:30 PM · PasswordlessLogin
Florian committed rEPLLb52321421d57: Use php 7.0 compatible libraries (authored by Florian).
Use php 7.0 compatible libraries
May 30 2019, 12:29 PM

May 29 2019

Florian closed T224438: Link to Play Store app as Resolved.
May 29 2019, 5:16 PM · Patch-For-Review, PasswordlessLogin
Florian committed rEPLL545c59ac2d4a: Add a play store link for the Andorid app (authored by Florian).
Add a play store link for the Andorid app
May 29 2019, 5:16 PM
Florian committed rEPLL4b6ed85e358c: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 29 2019, 5:04 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEPLL1a6627d3d6f1: Merge "Render QR code in backend and remove odd client script" (authored by Florian).
Merge "Render QR code in backend and remove odd client script"
May 29 2019, 5:04 PM
Florian claimed T224438: Link to Play Store app.
May 29 2019, 4:52 PM · Patch-For-Review, PasswordlessLogin

May 27 2019

Florian committed rEPLL767be488e2a7: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 27 2019, 5:42 PM
Florian committed rEPLLb1e007e2c71f: Use correct description for i18n message (authored by Florian).
Use correct description for i18n message
May 27 2019, 5:39 PM
Florian committed rEPLL3b7b906cf7f7: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 27 2019, 5:35 PM
Florian created T224438: Link to Play Store app.
May 27 2019, 5:19 PM · Patch-For-Review, PasswordlessLogin
Florian committed rEPLLa11152f0b1a1: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:25 PM
Florian committed rEPLL734bf4ec67f9: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:20 PM
Florian committed rEPLLadd322d3930d: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:17 PM
Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 27 2019, 3:45 PM · PasswordlessLogin

May 26 2019

Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 26 2019, 4:00 PM · PasswordlessLogin
Florian created T224371: Move PasswordlessLogin extension to gerrit.
May 26 2019, 3:56 PM · PasswordlessLogin
Florian closed T224045: Add an app information screen as Resolved.
May 26 2019, 3:54 PM · PasswordlessLogin
Florian claimed T224045: Add an app information screen.
May 26 2019, 1:09 PM · PasswordlessLogin
Florian closed T224044: Some design work for the Android app as Resolved.

This is how the app now looks like:

May 26 2019, 1:03 PM · PasswordlessLogin
Florian claimed T224044: Some design work for the Android app.
May 26 2019, 10:33 AM · PasswordlessLogin
Florian closed T224043: Finish linking a new device as Resolved.

This is done in the extension and the Android app itself, too :)

May 26 2019, 10:33 AM · PasswordlessLogin
Florian closed T211848: SimpleCaptcha::loadText() loads section 0 when passed false, as all callers do as Resolved.
May 26 2019, 10:30 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), ConfirmEdit (CAPTCHA extension)

May 21 2019

Florian claimed T224043: Finish linking a new device.
May 21 2019, 6:01 PM · PasswordlessLogin
Florian added a comment to T223893: Create a project for mediawiki extension Passwordless Login.

TODO: Creating an extension homepage on mediawiki.org (and then updating the project description) is welcome. :)

May 21 2019, 5:26 PM · Project-Admins
Florian edited Description on PasswordlessLogin.
May 21 2019, 5:25 PM
Florian created T224049: Require https for the api URL.
May 21 2019, 5:21 PM · PasswordlessLogin
Florian triaged T224048: Elaborate if "dynamic" certificate pinning can be used to even secure the login process more as Low priority.
May 21 2019, 5:20 PM · PasswordlessLogin
Florian created T224048: Elaborate if "dynamic" certificate pinning can be used to even secure the login process more.
May 21 2019, 5:20 PM · PasswordlessLogin
Florian closed T220418: Passwordless login (login with your smartphone) as Resolved.

I created follow up tasks for this extension under the new PasswordlessLogin tag, so I think this task (as a hackathon task) can be closed :)

May 21 2019, 5:06 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019
Florian created T224045: Add an app information screen.
May 21 2019, 5:05 PM · PasswordlessLogin
Florian created T224044: Some design work for the Android app.
May 21 2019, 5:03 PM · PasswordlessLogin
Florian created T224043: Finish linking a new device.
May 21 2019, 5:01 PM · PasswordlessLogin
Florian created T223991: Allow authentication providers to add images as form fields.
May 21 2019, 12:04 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization, PasswordlessLogin

May 20 2019

Florian created T223898: Remove the requirement to enter a password during the login flow.
May 20 2019, 11:44 AM · PasswordlessLogin, MediaWiki-Authentication-and-authorization
Florian created T223893: Create a project for mediawiki extension Passwordless Login.
May 20 2019, 11:20 AM · Project-Admins

May 19 2019

Smalyshev awarded T220418: Passwordless login (login with your smartphone) a Like token.
May 19 2019, 1:23 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019
Florian closed T222590: ReCaptchaNoCaptcha displaying a <div class="error">$1</div> message in the edit form as Resolved.
May 19 2019, 8:46 AM · Patch-For-Review, Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), ConfirmEdit (CAPTCHA extension)
Florian closed T221045: Possible dead code in ConfigRepository.php as Resolved.
May 19 2019, 8:45 AM · MW-1.32-notes, Wikimedia-Hackathon-2019, MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, MediaWiki-Configuration

May 18 2019

Florian created T223749: ReCaptcha v1 not supported anymore.
May 18 2019, 7:31 PM · ConfirmEdit (CAPTCHA extension)
Florian claimed T222590: ReCaptchaNoCaptcha displaying a <div class="error">$1</div> message in the edit form.

Working on it :)

May 18 2019, 7:16 PM · Patch-For-Review, Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), ConfirmEdit (CAPTCHA extension)
Florian claimed T221045: Possible dead code in ConfigRepository.php.

I'll take a look into it. It is totally possible that I simply missed tht during the implementation and changes of this feature :)

May 18 2019, 6:41 PM · MW-1.32-notes, Wikimedia-Hackathon-2019, MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, MediaWiki-Configuration
Florian added a comment to T220418: Passwordless login (login with your smartphone).

The source code of the extension (build during the hackthon) can actually be found here:
https://github.com/FlorianSW/mediawiki-extension-PassswordlessLogin
The app:
https://github.com/FlorianSW/mediawiki-app-PasswordlessLogin

May 18 2019, 6:36 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019
Florian removed a watcher for Repository-Admins: Florian.
May 18 2019, 6:35 PM
Florian added a comment to T215964: Can publicSuffixArray.php be made optional if $wgGLAllowedDomains is specified?.

Making the file to contain an empty array does probably match your use case, as you (my assumption) does want to check for a TLD domain already (e.g. mymailserver.de). However, if you need to whitelist a specific subdomain only, you need this file. The preficxes are used by GoogleLogin to find out what the parts of a specific domain are, e.g., mymailserver.co.us, where mymailserver is the host and co.us is the TLD. If the co.us isn't known as a TLD, GoogleLogin (when not in strict mode) would allow all domains of co.us to login with Google on the wiki (as it would think that co is the host and us is the TLD).

May 18 2019, 6:31 PM · GoogleLogin
Florian closed T215965: Document maintenance/updatePublicSuffixArray.php as Resolved.

https://www.mediawiki.org/wiki/Extension:GoogleLogin#updatePublicSuffixArray.php
It's also mentioned in the corresponding configuration option.

May 18 2019, 6:25 PM · Wikimedia-Hackathon-2019, GoogleLogin
Florian added a project to T215965: Document maintenance/updatePublicSuffixArray.php: Wikimedia-Hackathon-2019.

Btw.: Please do not assign tasks to people directly :) If a person wants to do a task, they most likely assign themself :) Thanks! :)

May 18 2019, 6:15 PM · Wikimedia-Hackathon-2019, GoogleLogin
Florian added a comment to T218095: allow html in message Cookiewarning-info to allow multiple clickable links.

Having HTML messages opens a wide door of variations and "stuff" people can do with it. Can I kindly ask, why these links can not be on the "More information" link page?

May 18 2019, 6:14 PM · MediaWiki-extensions-CookieWarning
Florian added a comment to T220418: Passwordless login (login with your smartphone).

I would love to see this as a 2FA feature (eg. you want to save Common.js, MediaWiki sends you a phone notification asking whether you are really trying to do that, you tap through - it's a far less painful alternative to going through login / OATH again, which is what we are currently doing as a security check).
Maybe it can be built on the top of T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications)?
Note Wikimedia will probably serve push notifications soon (currently planned for 2020 spring) so maybe time to think about some sort of push service in core.

May 18 2019, 5:50 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019

May 15 2019

Tgr awarded T220418: Passwordless login (login with your smartphone) a Love token.
May 15 2019, 6:55 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019

May 7 2019

Florian added a comment to T220418: Passwordless login (login with your smartphone).

First of all: Yes, this would be for Android only, and please see this more or less as a Proof-of-Concept, about a theoretical idea I had. I want to implement this during the hackathon, and for me it means, that it is not locked to a specific vendor and has the possibility to be ported to other devices, too (at least the APIs needed would be open to be used I think).

May 7 2019, 4:43 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019

Apr 8 2019

Florian moved T220418: Passwordless login (login with your smartphone) from Backlog to Projects on the Wikimedia-Hackathon-2019 board.
Apr 8 2019, 4:07 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019
Florian created T220418: Passwordless login (login with your smartphone).
Apr 8 2019, 4:06 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization, Wikimedia-Hackathon-2019

Apr 5 2019

Mill <mill@mail.com> committed rERSL0ae5ebcc7cb0: t7baaaaaaaaaaa (authored by Florian).
t7baaaaaaaaaaa
Apr 5 2019, 10:34 PM

Mar 21 2019

Mill <mill@mail.com> committed rECW16d837484d95: r5aaaaaaaaaaaa (authored by Florian).
r5aaaaaaaaaaaa
Mar 21 2019, 12:31 AM

Mar 16 2019

Florian added a comment to T218494: `become`, `crontab` et al missing from Trusty hosts.

I've found the same issue while trying to migrate jobs from the trusty grid to the new one (or better deleting the tool at all) :/

Mar 16 2019, 10:19 PM · Patch-For-Review, cloud-services-team (Kanban), Toolforge

Feb 9 2019

Florian created T215692: Delete tool askbot-01.
Feb 9 2019, 10:55 AM · Toolforge (Tools to be deleted)

Jan 31 2019

Florian added a comment to T212827: Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019.

Yes, I'm available.

Jan 31 2019, 6:13 PM · Developer-Advocacy (Jan-Mar 2019), Google-Code-in-2018

Jan 27 2019

Florian closed T212782: Google+ APIs being shutdown on March 7, 2019 as Invalid.

As far as I know, this is already reflected in the current code base, as it does not require the profile permission anymore, and does not request it either, since:
https://github.com/wikimedia/mediawiki-extensions-GoogleLogin/commit/9cfa2b0c9a8fc6af4d81816f8755b28a5bc2d562

Jan 27 2019, 8:40 PM · GoogleLogin
Florian added a comment to T186080: GoogleLogin Auto Account Creation .

I think, because:

Jan 27 2019, 8:37 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization, GoogleLogin
Florian added a project to T204794: GoogleLogin not triggering "Keep me logged in" automatically: MediaWiki-Authentication-and-authorization.
Jan 27 2019, 8:30 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian added a comment to T204794: GoogleLogin not triggering "Keep me logged in" automatically.

The documentation is correct from my point of view. If you check the keep me logged in checkbox, you will be kept login even if you use GoogleLogin to login. However, if you remove all authentication methods (which bypasses the Login form completely for convenience of the users) you can't check this checkbox.

Jan 27 2019, 8:26 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian closed T203419: Error when attempting to link User to Google ID: Class 'GoogleLogin\Specials\ExtensionRegistry' not found as Resolved.
Jan 27 2019, 8:15 PM · Patch-For-Review, GoogleLogin
Florian claimed T203419: Error when attempting to link User to Google ID: Class 'GoogleLogin\Specials\ExtensionRegistry' not found.
Jan 27 2019, 7:53 PM · Patch-For-Review, GoogleLogin
Florian closed T197478: Skin dependencies use the wrong key (skin instead of skins) as Resolved.
Jan 27 2019, 7:44 PM · MW-1.31-release-notes, MediaWiki-Interface, Patch-For-Review

Jan 8 2019

Florian added a comment to T212827: Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019.

I wasn't very active this year, either. However, if no-one else has time or is interested, I'd be happy to attend, nevertheless.

Jan 8 2019, 8:50 PM · Developer-Advocacy (Jan-Mar 2019), Google-Code-in-2018

Jan 2 2019

MarcoAurelio awarded T204107: UserMerge is missing messages for log entries a Barnstar token.
Jan 2 2019, 6:34 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), I18n, MediaWiki-extensions-UserMerge

Nov 13 2018

Charlie_WMDE awarded T165835: RevisionSlider for mobile view a Cookie token.
Nov 13 2018, 2:30 PM · WMDE-MediaWiki-maintenance, MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), TCB-Team, Revision-Slider

Nov 11 2018

Liuxinyu970226 awarded T73966: Show categories of a page in the Android app a Love token.
Nov 11 2018, 11:37 AM · Mobile, Community-Wishlist-Survey-2016, Wikipedia-Android-App-Backlog

Nov 4 2018

Florian committed rECWd6f20cdb3a9e: Enable GeoLocation service being replaced by ther providers (authored by Florian).
Enable GeoLocation service being replaced by ther providers
Nov 4 2018, 3:20 PM
Florian committed rECWdc3e26c56536: Enable GeoLocation service being replaced by ther providers (authored by Florian).
Enable GeoLocation service being replaced by ther providers
Nov 4 2018, 3:20 PM

Oct 28 2018

Florian added a comment to T208005: Move Language::viewPrevNext to a better place.

Jap! :)

Oct 28 2018, 9:15 AM · MediaWiki-Internationalization