Page MenuHomePhabricator

Florian (Florianschmidtwelzow)
Volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:13 AM (232 w, 4 d)
Availability
Available
IRC Nick
FlorianSW
LDAP User
Florianschmidtwelzow
MediaWiki User
Florianschmidtwelzow [ Global Accounts ]

Recent Activity

Thu, Mar 21

Mill <mill@mail.com> committed rECW16d837484d95: r5aaaaaaaaaaaa (authored by Florian).
r5aaaaaaaaaaaa
Thu, Mar 21, 12:31 AM

Sat, Mar 16

Florian added a comment to T218494: `become`, `crontab` et al missing from Trusty hosts.

I've found the same issue while trying to migrate jobs from the trusty grid to the new one (or better deleting the tool at all) :/

Sat, Mar 16, 10:19 PM · Patch-For-Review, cloud-services-team (Kanban), Toolforge

Feb 9 2019

Florian created T215692: Delete tool askbot-01.
Feb 9 2019, 10:55 AM · Toolforge

Jan 31 2019

Florian added a comment to T212827: Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019.

Yes, I'm available.

Jan 31 2019, 6:13 PM · Developer-Advocacy (Jan-Mar 2019), Google-Code-in-2018

Jan 27 2019

Florian closed T212782: Google+ APIs being shutdown on March 7, 2019 as Invalid.

As far as I know, this is already reflected in the current code base, as it does not require the profile permission anymore, and does not request it either, since:
https://github.com/wikimedia/mediawiki-extensions-GoogleLogin/commit/9cfa2b0c9a8fc6af4d81816f8755b28a5bc2d562

Jan 27 2019, 8:40 PM · GoogleLogin
Florian added a comment to T186080: GoogleLogin Auto Account Creation .

I think, because:

Jan 27 2019, 8:37 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian added a project to T204794: GoogleLogin not triggering "Keep me logged in" automatically: MediaWiki-Authentication-and-authorization.
Jan 27 2019, 8:30 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian added a comment to T204794: GoogleLogin not triggering "Keep me logged in" automatically.

The documentation is correct from my point of view. If you check the keep me logged in checkbox, you will be kept login even if you use GoogleLogin to login. However, if you remove all authentication methods (which bypasses the Login form completely for convenience of the users) you can't check this checkbox.

Jan 27 2019, 8:26 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian closed T203419: Error when attempting to link User to Google ID: Class 'GoogleLogin\Specials\ExtensionRegistry' not found as Resolved.
Jan 27 2019, 8:15 PM · Patch-For-Review, GoogleLogin
Florian claimed T203419: Error when attempting to link User to Google ID: Class 'GoogleLogin\Specials\ExtensionRegistry' not found.
Jan 27 2019, 7:53 PM · Patch-For-Review, GoogleLogin
Florian closed T197478: Skin dependencies use the wrong key (skin instead of skins) as Resolved.
Jan 27 2019, 7:44 PM · MW-1.31-release-notes, MediaWiki-Interface, Patch-For-Review

Jan 8 2019

Florian added a comment to T212827: Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019.

I wasn't very active this year, either. However, if no-one else has time or is interested, I'd be happy to attend, nevertheless.

Jan 8 2019, 8:50 PM · Developer-Advocacy (Jan-Mar 2019), Google-Code-in-2018

Jan 2 2019

MarcoAurelio awarded T204107: UserMerge is missing messages for log entries a Barnstar token.
Jan 2 2019, 6:34 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), I18n, MediaWiki-extensions-UserMerge

Nov 13 2018

Charlie_WMDE awarded T165835: RevisionSlider for mobile view a Cookie token.
Nov 13 2018, 2:30 PM · WMDE-MediaWiki-maintenance, MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), TCB-Team, Revision-Slider

Nov 11 2018

Liuxinyu970226 awarded T73966: Show categories of a page in the Android app a Love token.
Nov 11 2018, 11:37 AM · Mobile, Community-Wishlist-Survey-2016, Wikipedia-Android-App-Backlog

Nov 4 2018

Florian committed rECWd6f20cdb3a9e: Enable GeoLocation service being replaced by ther providers (authored by Florian).
Enable GeoLocation service being replaced by ther providers
Nov 4 2018, 3:20 PM
Florian committed rECWdc3e26c56536: Enable GeoLocation service being replaced by ther providers (authored by Florian).
Enable GeoLocation service being replaced by ther providers
Nov 4 2018, 3:20 PM

Oct 28 2018

Florian added a comment to T208005: Move Language::viewPrevNext to a better place.

Jap! :)

Oct 28 2018, 9:15 AM · MediaWiki-Internationalization
Florian merged task T208005: Move Language::viewPrevNext to a better place into T207977: remove prev/next message dependency from Language.
Oct 28 2018, 9:15 AM · MediaWiki-Internationalization
Florian merged T208005: Move Language::viewPrevNext to a better place into T207977: remove prev/next message dependency from Language.
Oct 28 2018, 9:15 AM · Core Platform Team Kanban, Core Platform Team (Code Health (TEC13)), MediaWiki-Decoupling, MediaWiki-Internationalization, Patch-For-Review

Oct 25 2018

Florian created T208005: Move Language::viewPrevNext to a better place.
Oct 25 2018, 11:44 PM · MediaWiki-Internationalization
Florian added a comment to T136599: [Epic] editing on client.

There's a design prototype on wiki: https://m.wikidata.org/wiki/Wikidata:Client_editing_prototype

Oct 25 2018, 10:44 PM · MediaWiki-extensions-WikibaseClient, Epic, Wikidata

Oct 23 2018

Florian added a project to T137067: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no: Google-Code-in-2018.

Imported as https://codein.withgoogle.com/dashboard/tasks/6289154326396928/ for Google-Code-In

Oct 23 2018, 4:59 PM · MobileFrontend, Google-Code-in-2018, Ladies-That-FOSS-MediaWiki, good first bug, Contributors-Team
Florian added a project to T123228: Include namespace information on action=info page: Google-Code-in-2018.

Imported as https://codein.withgoogle.com/dashboard/tasks/5814559299338240/

Oct 23 2018, 4:52 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Google-Code-in-2018, good first bug, MediaWiki-General-or-Unknown
Florian added a project to T116124: Provide minimal doxygen documentation for SkinFallback: Google-Code-in-2018.

Imported as https://codein.withgoogle.com/dashboard/tasks/6021695304368128/ :)

Oct 23 2018, 4:45 PM · Google-Code-in-2018, MediaWiki-Documentation, Documentation, good first bug

Oct 1 2018

RandomDSdevel awarded T117781: Convert Special:Preferences to OOUI a Barnstar token.
Oct 1 2018, 11:52 PM · User-Ryasmeen, User-notice, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Front-end-Standards-Group, Epic, UI-Standardization
RandomDSdevel awarded T117739: Convert Special:NewPages to OOUI a Haypence token.
Oct 1 2018, 1:26 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), User-notice, UI-Standardization
RandomDSdevel awarded T117737: Convert Special:Log to OOUI a Doubloon token.
Oct 1 2018, 1:23 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), User-notice, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), MediaWiki-Logging, UI-Standardization

Sep 27 2018

Niharika awarded T117781: Convert Special:Preferences to OOUI a Love token.
Sep 27 2018, 11:30 PM · User-Ryasmeen, User-notice, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Front-end-Standards-Group, Epic, UI-Standardization
Samwilson awarded T117781: Convert Special:Preferences to OOUI a Love token.
Sep 27 2018, 10:04 PM · User-Ryasmeen, User-notice, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Front-end-Standards-Group, Epic, UI-Standardization

Sep 16 2018

Florian closed T202183: Special:Redirect should give more specific error messages as Resolved.
Sep 16 2018, 7:16 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, MediaWiki-Special-pages
Florian claimed T204456: Target user field can not be empty (as stated in the documentation).
Sep 16 2018, 7:11 PM · Patch-For-Review, MediaWiki-extensions-UserMerge
Florian created T204456: Target user field can not be empty (as stated in the documentation).
Sep 16 2018, 6:50 PM · Patch-For-Review, MediaWiki-extensions-UserMerge
Florian claimed T204107: UserMerge is missing messages for log entries.

Found this issue, too, I'll add these messages in a patch and upload it in a second :)

Sep 16 2018, 6:43 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), I18n, MediaWiki-extensions-UserMerge

Sep 1 2018

Framawiki awarded T168557: "Keep me logged in" check box shouldn't be shown when a logged-in user is being verified a Love token.
Sep 1 2018, 3:33 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization

Aug 11 2018

Florian closed T201754: Setting $wgCookieWarningGeoIPLookup to false does not disable freegeoip.net request as Invalid.

Coming from ULS, not CookieWarning.

Aug 11 2018, 10:47 AM · MediaWiki-extensions-CookieWarning
Florian created T201754: Setting $wgCookieWarningGeoIPLookup to false does not disable freegeoip.net request.
Aug 11 2018, 10:34 AM · MediaWiki-extensions-CookieWarning
Florian edited projects for T201753: Don't use freegeoip service by default anymore, added: MediaWiki-extensions-CentralNotice; removed MediaWiki-extensions-General.
Aug 11 2018, 10:31 AM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Florian renamed T201753: Don't use freegeoip service by default anymore from Freegeoip.net service is shutdown to Don't use freegeoip service by default anymore.
Aug 11 2018, 10:30 AM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Florian created T201753: Don't use freegeoip service by default anymore.
Aug 11 2018, 10:30 AM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice
Florian created T201752: Don't use freegeoip service by default anymore.
Aug 11 2018, 10:28 AM · MediaWiki-extensions-CookieWarning
Florian added a parent task for T199106: wgULSGeoService and https://freegeoip.net/ out of service: T201751: Freegeoip.net service is shutdown.
Aug 11 2018, 10:28 AM · Language-Team (Language-2018-October-December), MediaWiki Language Extension Bundle, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), UniversalLanguageSelector
Florian added a subtask for T201751: Freegeoip.net service is shutdown: T199106: wgULSGeoService and https://freegeoip.net/ out of service.
Aug 11 2018, 10:28 AM · MediaWiki-extensions-General
Florian created T201751: Freegeoip.net service is shutdown.
Aug 11 2018, 10:27 AM · MediaWiki-extensions-General

Aug 6 2018

Florian committed rECW1a2dd83c15e2: Use wgUseMediaWikiUIEverywhere true in tests (authored by Florian).
Use wgUseMediaWikiUIEverywhere true in tests
Aug 6 2018, 8:25 PM
Florian added a comment to T201359: Tests are broken in CookieWarning.

Already working on it...

Aug 6 2018, 8:09 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning
Florian claimed T201359: Tests are broken in CookieWarning.
Aug 6 2018, 8:09 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning
Florian closed T200000: Elaborate match Google user with e-mail address in addition to user ID as Resolved.
Aug 6 2018, 8:06 PM · Patch-For-Review, GoogleLogin
Liuxinyu970226 awarded T117739: Convert Special:NewPages to OOUI a Party Time token.
Aug 6 2018, 4:12 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), User-notice, UI-Standardization

Aug 2 2018

Florian closed T201076: Extension should not link to droidwiki.de in Special:Version as Resolved.
Aug 2 2018, 7:03 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning
Florian committed rECWe3479eafd83a: Link to the extension doku page on Special:Version (authored by Florian).
Link to the extension doku page on Special:Version
Aug 2 2018, 7:02 PM
Florian created T201076: Extension should not link to droidwiki.de in Special:Version.
Aug 2 2018, 6:54 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning

Jul 26 2018

Jayprakash12345 awarded T117737: Convert Special:Log to OOUI a 100 token.
Jul 26 2018, 5:14 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), User-notice, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), MediaWiki-Logging, UI-Standardization

Jul 23 2018

Harej awarded T200000: Elaborate match Google user with e-mail address in addition to user ID a Meh! token.
Jul 23 2018, 1:22 AM · Patch-For-Review, GoogleLogin

Jul 22 2018

MGChecker awarded T200000: Elaborate match Google user with e-mail address in addition to user ID a Party Time token.
Jul 22 2018, 1:45 PM · Patch-For-Review, GoogleLogin
Tgr awarded T200000: Elaborate match Google user with e-mail address in addition to user ID a Party Time token.
Jul 22 2018, 11:28 AM · Patch-For-Review, GoogleLogin

Jul 21 2018

Florian closed T200122: Remove Special:GoogleLogin as it doesn't serve any useful functionality anymore as Resolved.
Jul 21 2018, 10:34 AM · Patch-For-Review, GoogleLogin
Florian created T200122: Remove Special:GoogleLogin as it doesn't serve any useful functionality anymore.
Jul 21 2018, 10:16 AM · Patch-For-Review, GoogleLogin
Florian closed T200077: array_key_exists(): The first argument should be either a string or an integer as Resolved.
Jul 21 2018, 10:00 AM · Patch-For-Review, MediaWiki-extensions-CookieWarning

Jul 20 2018

Florian committed rECW7afcc5bfd795: Show cookiewarning banner if IP could not be located (authored by Florian).
Show cookiewarning banner if IP could not be located
Jul 20 2018, 12:26 PM
Florian added a comment to T200077: array_key_exists(): The first argument should be either a string or an integer.

Btw.: It seems you don't have the latest master version, latest master does not contain the CookieWarningDecisions class anymore, but instead the Decisions class.

Jul 20 2018, 12:25 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning
Florian claimed T200077: array_key_exists(): The first argument should be either a string or an integer.
Jul 20 2018, 12:19 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning
Florian added a comment to T200000: Elaborate match Google user with e-mail address in addition to user ID.

First of all: I kind of thought, that you can already set an e-mail address only to one user, so that there's a one-to-one-relation from one user to one e-mail-address and vice versa. However, this turns out to be a wrong assumption. I'll cover the obligations resulting from that in the following answers to the comments :)

Jul 20 2018, 11:31 AM · Patch-For-Review, GoogleLogin
Florian updated the task description for T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 20 2018, 11:31 AM · Patch-For-Review, GoogleLogin
Florian updated the task description for T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 20 2018, 11:11 AM · Patch-For-Review, GoogleLogin
Florian updated the task description for T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 20 2018, 11:03 AM · Patch-For-Review, GoogleLogin
Florian closed T155908: There should be a way to process config options in ExtensionRegistry as Resolved.
Jul 20 2018, 11:02 AM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, MediaWiki-Configuration
Florian closed T155908: There should be a way to process config options in ExtensionRegistry, a subtask of T155155: Implement a way to view (extension) configuration options and its value on-wiki, as Resolved.
Jul 20 2018, 11:02 AM · MediaWiki-Configuration

Jul 19 2018

Luke081515 awarded T200000: Elaborate match Google user with e-mail address in addition to user ID a 100 token.
Jul 19 2018, 6:27 PM · Patch-For-Review, GoogleLogin
Krenair awarded T200000: Elaborate match Google user with e-mail address in addition to user ID a Y So Serious token.
Jul 19 2018, 6:18 PM · Patch-For-Review, GoogleLogin
Florian closed T199999: GoogleLogin login button should take precedence over username/password as Resolved.
Jul 19 2018, 1:33 PM · GoogleLogin
Florian added a comment to T195424: Pressing the ok button does not hide it until the cookie is gone.

Thanks for the response :) Great to hear, that the problem is fixed :)

Jul 19 2018, 12:35 PM · MediaWiki-extensions-CookieWarning
Florian closed T195424: Pressing the ok button does not hide it until the cookie is gone as Invalid.
Jul 19 2018, 12:35 PM · MediaWiki-extensions-CookieWarning
Florian updated subscribers of T200000: Elaborate match Google user with e-mail address in addition to user ID.

@Tgr and @Anomie I would like to hear your opinion about (generally spoken) matching a user based on their e-mail address instead of their user account ID. Is there something which comes to your mind why this could be a bad thing? :)

Jul 19 2018, 12:25 PM · Patch-For-Review, GoogleLogin
Florian updated the task description for T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 19 2018, 12:22 PM · Patch-For-Review, GoogleLogin
Florian updated the task description for T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 19 2018, 12:22 PM · Patch-For-Review, GoogleLogin
Florian created T200000: Elaborate match Google user with e-mail address in addition to user ID.
Jul 19 2018, 12:19 PM · Patch-For-Review, GoogleLogin
Florian created T199999: GoogleLogin login button should take precedence over username/password.
Jul 19 2018, 12:18 PM · GoogleLogin
Florian closed T198439: Does not require people permission for logging in as Resolved.
Jul 19 2018, 11:55 AM · Patch-For-Review, GoogleLogin
Florian added a comment to T198439: Does not require people permission for logging in.

Scope profile removed, *yay* :)

Jul 19 2018, 11:55 AM · Patch-For-Review, GoogleLogin
Florian added a comment to T193716: Support whitelisting IPs in CookieWarning extension.

Hmm, is whitelisting the IP really the correct way of doing that? How does the electron service get's the content of the page? If it is displaying it like a normal user, it can just put the cookiewarning_dismissed cookie into the request and CookieWarning will not render the warning header at all. Isn't that a reasonable solution? :)

Jul 19 2018, 11:23 AM · MediaWiki-extensions-CookieWarning
Florian added a comment to T195424: Pressing the ok button does not hide it until the cookie is gone.

Thanks for filing this bug report and please excuse the very late response here :( Unfortunately it seems that there're some information missing. I tested it locally with MediaWiki 1.30 and the latest CookieWarning and it works pretty well. Does this problem still exist for you?

Jul 19 2018, 11:19 AM · MediaWiki-extensions-CookieWarning
Florian committed rECW90d2e5809636: Move classes into CookieWarning namespace (authored by Florian).
Move classes into CookieWarning namespace
Jul 19 2018, 11:00 AM
Florian committed rECW9349b33e47f2: Move classes into CookieWarning namespace (authored by Florian).
Move classes into CookieWarning namespace
Jul 19 2018, 10:54 AM

Jul 18 2018

Florian committed rECW6f519c961813: Add caching functionality for IP lookup (authored by Florian).
Add caching functionality for IP lookup
Jul 18 2018, 2:08 PM
Florian committed rECW4649d2110f53: Don't use deprecated `mediawiki.api.options` (authored by Jdforrester-WMF).
Don't use deprecated `mediawiki.api.options`
Jul 18 2018, 2:08 PM
Florian committed rECW611f7a1f6138: Add caching functionality for IP lookup (authored by Florian).
Add caching functionality for IP lookup
Jul 18 2018, 11:17 AM
Florian committed rECW6efe41fa5567: Add caching functionality for IP lookup (authored by Florian).
Add caching functionality for IP lookup
Jul 18 2018, 11:17 AM
Florian committed rECW2f5f294ac8e6: Refactor Hooks code and move it to separate services (authored by Florian).
Refactor Hooks code and move it to separate services
Jul 18 2018, 11:17 AM
Florian committed rECWfed15fd7a567: Refactor Hooks code and move it to separate services (authored by Florian).
Refactor Hooks code and move it to separate services
Jul 18 2018, 11:17 AM
Florian awarded T199865: +2 for Matěj Suchánek in mediawiki/* a Like token.
Jul 18 2018, 8:01 AM · Repository-Ownership-Requests
Florian awarded T199868: +2 for Jack Phoenix in mediawiki/* a Like token.
Jul 18 2018, 7:57 AM · Repository-Ownership-Requests
Florian added a comment to T199868: +2 for Jack Phoenix in mediawiki/*.

I already worked with him and it was like a charm, nothing that would prevent him getting +2 rights from my point of view. +1!

Jul 18 2018, 7:57 AM · Repository-Ownership-Requests

Jul 17 2018

Volker_E awarded T117737: Convert Special:Log to OOUI a Meh! token.
Jul 17 2018, 12:07 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), User-notice, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), MediaWiki-Logging, UI-Standardization

Jul 15 2018

Florian awarded T191221: "Wikipedia reading lists" browser extensions a Like token.
Jul 15 2018, 9:46 AM · Patch-For-Review, Epic, Reading-Infrastructure-Team-Backlog, Reading Epics (Synchronized Reading Lists)
Florian awarded T188830: Adding a list system for the desktop version a Love token.
Jul 15 2018, 9:46 AM · Reading-Infrastructure-Team-Backlog, Reading List Service

Jul 12 2018

Liuxinyu970226 awarded T99256: Convert old Special:Watchlist to OOUI (HTMLForm?) a Heartbreak token.
Jul 12 2018, 8:36 AM · Growth-Team, MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), Front-end-Standards-Group, User-notice, MediaWiki-Watchlist, UI-Standardization

Jul 7 2018

Florian placed T199037: [Google Adsense] Allow to pause ad delivery as long as the user was asked for consent up for grabs.
Jul 7 2018, 11:37 PM · MediaWiki-extensions-Other
Florian created T199037: [Google Adsense] Allow to pause ad delivery as long as the user was asked for consent.
Jul 7 2018, 10:39 PM · MediaWiki-extensions-Other
Florian created T199036: Convert GoogleAdSense extension to extension registration.
Jul 7 2018, 10:33 PM · MediaWiki-extensions-Other