Florian (Florianschmidtwelzow)
Volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:13 AM (189 w, 3 d)
Availability
Available
IRC Nick
FlorianSW
LDAP User
Florianschmidtwelzow
MediaWiki User
Florianschmidtwelzow

Recent Activity

Mon, May 21

Florian awarded T195220: +2 for Jakob in mediawiki/* a Like token.
Mon, May 21, 2:16 PM · User-Addshore, Repository-Ownership-Requests

Sun, May 20

Florian added a parent task for T195117: Make translate article menu available for mobile: T132900: Design the translation experience on mobile.
Sun, May 20, 2:39 PM · Wikidata, ArticlePlaceholder
Florian added a subtask for T132900: Design the translation experience on mobile: T195117: Make translate article menu available for mobile.
Sun, May 20, 2:39 PM · Design, Epic, ContentTranslation
Florian added a project to T194915: Support Ctrl-Enter as a way to save translations: Patch-For-Review.

-> https://gerrit.wikimedia.org/r/#/c/434157/

Sun, May 20, 10:35 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, Easy, MediaWiki-extensions-Translate
Florian added a comment to T194915: Support Ctrl-Enter as a way to save translations.

I'm wondering if, when pressing Ctrl-Enter if nothing was changed, should be the same as clicking "Skip to next"?

Sun, May 20, 10:33 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, Easy, MediaWiki-extensions-Translate
Florian claimed T194915: Support Ctrl-Enter as a way to save translations.
Sun, May 20, 10:30 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, Easy, MediaWiki-extensions-Translate
Florian edited parent tasks for T195117: Make translate article menu available for mobile, added: T105190: [Epic] Mobile stategy for ContentTranslation; removed: T192067: Prototype ideas for translation on mobile.
Sun, May 20, 10:00 AM · Wikidata, ArticlePlaceholder
Florian added a subtask for T105190: [Epic] Mobile stategy for ContentTranslation: T195117: Make translate article menu available for mobile.
Sun, May 20, 10:00 AM · Mobile, Epic, ContentTranslation
Florian removed a subtask for T192067: Prototype ideas for translation on mobile: T195117: Make translate article menu available for mobile.
Sun, May 20, 10:00 AM · Wikimedia-Hackathon-2018, Design, ContentTranslation
Florian added a parent task for T195117: Make translate article menu available for mobile: T192067: Prototype ideas for translation on mobile.
Sun, May 20, 9:59 AM · Wikidata, ArticlePlaceholder
Florian added a subtask for T192067: Prototype ideas for translation on mobile: T195117: Make translate article menu available for mobile.
Sun, May 20, 9:59 AM · Wikimedia-Hackathon-2018, Design, ContentTranslation
Florian added a comment to T195117: Make translate article menu available for mobile.

Ok, the overview page of ContentTranslation is kind of working (and looks already really good on mobile, *thumbsup*), however, actually translating pages does not work at all, so this task is kind of being blocked by T192067: Prototype ideas for translation on mobile maybe? I haven't found any better task for now :)

Sun, May 20, 9:59 AM · Wikidata, ArticlePlaceholder
Florian moved T195117: Make translate article menu available for mobile from Incoming to Backlog on the ArticlePlaceholder board.
Sun, May 20, 9:58 AM · Wikidata, ArticlePlaceholder
Florian closed T156056: HTMLFormFields nodata functionality should be documented as Resolved.
Sun, May 20, 9:52 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Documentation, MediaWiki-Documentation, Patch-For-Review, MediaWiki-HTMLForm

Sat, May 19

Florian updated subscribers of T195007: [Design} Create a cata-dogoat drawing.

We should create buttons or stickers for the next hackathon! @bd808 would that be possible? :D

Sat, May 19, 11:33 PM · Wikimedia-Hackathon-2018, Design, Goatification
Florian created T195117: Make translate article menu available for mobile.
Sat, May 19, 8:29 PM · Wikidata, ArticlePlaceholder
Florian updated the task description for T140807: Remove $wgResourceLoaderLESSImportPaths.
Sat, May 19, 10:03 AM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Technical-Debt
Florian committed rECW60929abb6964: Drop Minerva LESS dependency (authored by Konfused-Kitten).
Drop Minerva LESS dependency
Sat, May 19, 9:54 AM

Fri, May 18

Florian closed T189860: Redirect link in Special:What_links_here should link to original page and not target page as Resolved.
Fri, May 18, 4:45 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, MediaWiki-Redirects
Florian closed T174313: Add checkbox on Special:ListUsers to display only users in temporary user groups as Resolved.
Fri, May 18, 4:40 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), User-notice, Patch-For-Review, WorkType-NewFunctionality, MediaWiki-Special-pages

Sat, May 12

Florian closed T183657: The cookiewarning_dismissed cookie should be evaluated at client side, not server side as Resolved.
Sat, May 12, 1:00 PM · Patch-For-Review, MediaWiki-extensions-CookieWarning

Mon, May 7

Jdlrobson awarded T126877: Collapsible table breaks anchor linking a Like token.
Mon, May 7, 6:05 PM · MediaWiki-Interface, MediaWiki-General-or-Unknown

Apr 23 2018

Prtksxna awarded T117737: Convert Special:Log to OOUI a Goat token.
Apr 23 2018, 6:00 AM · Patch-For-Review, MediaWiki-Logging, UI-Standardization

Mar 31 2018

Florian added a project to T191138: Namespace drop-down should be sorted in human-friendly order: MediaWiki-Interface.
Mar 31 2018, 4:31 PM · MediaWiki-Interface

Mar 30 2018

Florian committed rEPFMf6c5ba98afe0: Replace usage of EDIT_TOKEN_SUFFIX with Wikimedia\Session\Token::SUFFIX (authored by Florian).
Replace usage of EDIT_TOKEN_SUFFIX with Wikimedia\Session\Token::SUFFIX
Mar 30 2018, 9:22 PM
Florian committed rECWeb27449d7064: Fix phpcs exclude rules (authored by Fomafix).
Fix phpcs exclude rules
Mar 30 2018, 8:59 PM

Feb 12 2018

Florian added a comment to T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California.

I'd happily take the advantage to meet one of our students personally :)

Feb 12 2018, 3:57 PM · Developer-Relations (Jan-Mar-2018), Google-Code-in-2017

Jan 21 2018

Florian added a comment to T184953: mw.Title.exists() is not helpful.

Hmm, I wonder, if it wouldn't make more sense to "finish" that feature, or at least to clarify, if it was meant to have a lookup functionality or not (if not, it should imho be documented, that it does not look up, if the title exists or not, thoguh)?

Jan 21 2018, 12:25 PM · JavaScript, MediaWiki-General-or-Unknown

Jan 20 2018

TheFanoulis awarded T95396: Inform the user, when there is a new message on their talk page a Like token.
Jan 20 2018, 5:40 PM · Easy, WorkType-NewFunctionality, Wikipedia-Android-App-Backlog

Jan 18 2018

Florian added a comment to T138678: AuthManager should support to create a new account for a Link PrimaryAuthenticationProvider.

@Tgr: I tested the UI a bit, however, if I'm not mistaken, there's one important feature missing: The creation of a new account? The message given to the user (that the authentication data was correct, but that there's no loal user account linked with it yet) already mentions, that the user should login or _create_ an account with which the external account should be linked, to. However, the UI just allows me to login, not to create a new account?

Jan 18 2018, 9:11 PM · User-Tgr, GoogleLogin, MediaWiki-User-login-and-signup, MediaWiki-Authentication-and-authorization
Florian added a comment to T138678: AuthManager should support to create a new account for a Link PrimaryAuthenticationProvider.

@Tgr: I remember you (or was it someone else) "somewhere" said, that there's "big" problem here:
a user, who authenticated with an external source and was redirected to a "create new account" page afterwards (as no local user was found in the database)

Jan 18 2018, 5:46 PM · User-Tgr, GoogleLogin, MediaWiki-User-login-and-signup, MediaWiki-Authentication-and-authorization

Jan 4 2018

Florian added a comment to T184037: Cite: Replace "getSelectedItem" with "findSelectedItem".

Ah, ok, +1! @Aklapper already imported the task :P

Jan 4 2018, 10:06 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), User-Ryasmeen, VisualEditor, Cite, User-Zoranzoki21, Google-Code-in-2017, Technical-Debt, OOUI

Jan 3 2018

Florian added a comment to T184037: Cite: Replace "getSelectedItem" with "findSelectedItem".

Does this depend on https://gerrit.wikimedia.org/r/#/c/398005/1?

Jan 3 2018, 10:34 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), User-Ryasmeen, VisualEditor, Cite, User-Zoranzoki21, Google-Code-in-2017, Technical-Debt, OOUI
Florian added a comment to T89815: Convert WikiLove from jQuery UI to OOUI.

That's fine, too! Not all tasks can be done in the GCI contest, that's ok and even not the goal :) Participating in Google Code-in needs to be fun for the student _and_ for the mentor(s), if this can't be achieved with this task, then it's better to resolve it outside of the contest :) Thanks however for proposing the task and taking the time to look into it, how this could be done during GCI :) If you've other tasks that may fit better into the contest frame, feel free to mentor or propose these! :)

Jan 3 2018, 10:28 AM · Possible-Tech-Projects, Collaboration-Team-Triage, UI-Standardization, WikiLove
Florian closed T133289: wgRestrictionEdit should be defined (as an empty array) on Education Program pages as Resolved.
Jan 3 2018, 9:54 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-Page-protection, Patch-For-Review, Google-Code-in-2017, Ladies-That-FOSS-MediaWiki, MediaWiki-extensions-EducationProgram, JavaScript
Florian added a comment to T183909: Update the example of (non) legacy code wich uses the array wgRestrictionEdit.

This will always be undefined in this case. Please see the exact code of the example:
if ( mw.config.exists('wgRestrictionEdit') ) { ... }

Jan 3 2018, 9:51 AM · MediaWiki-Documentation, Documentation, Easy

Jan 2 2018

Florian added a comment to T181875: Score should output MP3 files.

@Ebe123 Thanks for the feedback. I saw the edit of the task. I think it's now more clear what a student needs to do. I've published it and hope that a student will take this task, as I think it can be nice to hack at this problem :D Good luck to anyone who might take it :P

Jan 2 2018, 9:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score
Florian added a comment to T181875: Score should output MP3 files.

Is this really a task that can be done by a GCI student? It sounds more complicated, at least to me, but I probably do not really understand what needs to be done :) (hey: That could also be an indicator, that some more explanation for a GCI student is missing, too, probably you can give some more hints where to look, where to start and what exactly needs to be done? :))

Jan 2 2018, 6:14 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, TimedMediaHandler, MediaWiki-extensions-Score

Jan 1 2018

Florian added a comment to T133289: wgRestrictionEdit should be defined (as an empty array) on Education Program pages.

If that would help in this case (haven't checked), I would suggest to use the TitleExists hook and return true, whenever the EducationProgram page should be recognized as existing (I'm not sure, if there's a function to find out if such a page has content or something like that).

Jan 1 2018, 11:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-Page-protection, Patch-For-Review, Google-Code-in-2017, Ladies-That-FOSS-MediaWiki, MediaWiki-extensions-EducationProgram, JavaScript

Dec 30 2017

Florian added a comment to T133289: wgRestrictionEdit should be defined (as an empty array) on Education Program pages.

Couldn't this be changed somewhere in the extension itself? However: I updated the doc to say, that if a page does not exist, that the variable is not set.

Dec 30 2017, 9:38 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-Page-protection, Patch-For-Review, Google-Code-in-2017, Ladies-That-FOSS-MediaWiki, MediaWiki-extensions-EducationProgram, JavaScript
Florian added a comment to T178872: Fix dropdown position for autocomplete suggestions for Special:SearchTranslations.

Deleted task in GCI.

Dec 30 2017, 8:22 PM · Easy, MediaWiki-extensions-Translate
Florian removed a project from T178597: Define an interface for CAPTCHA modules: Google-Code-in-2017.

When I think about that, it isn't really suitable for GCI :/

Dec 30 2017, 8:09 PM · Technical-Debt, ConfirmEdit (CAPTCHA extension)

Dec 28 2017

Florian closed T180982: Individual newsletter pages should have a visual hierarchy as Resolved.
Dec 28 2017, 5:49 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian added a comment to T180982: Individual newsletter pages should have a visual hierarchy.

That's the result of the patch:

Dec 28 2017, 5:48 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 27 2017

Florian closed T179532: Call to undefined method WikiPage::getText() as Resolved.
Dec 27 2017, 4:04 PM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, Easy, MediaWiki-extensions-Wikilog
Florian closed T179532: Call to undefined method WikiPage::getText(), a subtask of T145750: WikiPage::getText() is deprecated, as Resolved.
Dec 27 2017, 4:04 PM · MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release-notes, Patch-For-Review, Technical-Debt, MediaWiki-ContentHandler

Dec 23 2017

Florian added a comment to T32234: Allow definition of Extension Dependencies.

Where should the "suggests"/"recommend" message be printed to? If we would have something like "php maintenance/mwscript installExtension FooBar" which installs/updates an extension (like composer update/install), it would probably be easy to just print out, that dependencies are installed or that some dependencies are suggested by the extension. But currently, extensions are installed manually by adding it to the wfLoadExtensions function call.

Dec 23 2017, 9:19 PM · MediaWiki-Configuration, WorkType-NewFunctionality
Florian added a comment to T181931: MediaWiki PHPUnit fails with PHP 7.2.

Then for anyone running composer themselves (not using wikimedia's mediawiki-vendor), composer will select an appropriate version of phpunit to run for them?

What would be the "appropriate" version in this case? (Which can be selected by composer in a generic way)? I think composer will select the most up-to-date version that matches the constraint. As you just wrote version numbers, 4.8.36 || 5.7.25 || 6.5.2 would be the same as 6.5.2.

Dec 23 2017, 7:50 PM · Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-General-or-Unknown, MediaWiki-Core-Tests
Florian added a comment to T157213: HHVM and PHP handle non-static input to call_user_func_array() different.

So I guess we will want to revisit the php.ini confguration file being shipped and most probably make sure strict errors are reported.

+1 I think that seeing strict standards is reasonable; it will bring up problems earlier, not when they already became important (e.g. for that example: WHat happens if php decides, that non-static methods, called statically, will throw a fatal). It's like not taking notices into account, which could result in weird undicovered problems.

Dec 23 2017, 7:35 PM · Patch-For-Review, Upstream, HHVM
Florian added a comment to T183322: mwext-php70-phan-docker should've php-curl extension installed.

I opened T183643: Do not check platform requirements with composer in a validate step (ci-src-setup) for that :) Thanks for the hint @Addshore!

Dec 23 2017, 7:07 PM · Continuous-Integration-Infrastructure (shipyard), Patch-For-Review
Florian created T183643: Do not check platform requirements with composer in a validate step (ci-src-setup).
Dec 23 2017, 7:07 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Florian closed T166355: Detect when CirrusSearch is used without curl and fail gracefully as Resolved.
Dec 23 2017, 7:03 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch

Dec 22 2017

Florian closed T177997: WikiImporter::notice echoing of unescaped values is a dangerous api as Resolved.
Dec 22 2017, 11:28 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Easy, Security-Core, Security, MediaWiki-Export-or-Import

Dec 21 2017

Florian committed rLCSH72781cb21a79: Link to line in diffusion for line links (authored by Florian).
Link to line in diffusion for line links
Dec 21 2017, 12:27 PM
Florian created T183461: Link to line opens the file without linking to the line.
Dec 21 2017, 12:24 PM · Patch-For-Review, VPS-project-codesearch
Florian committed rLCSH436b5ac29fe0: Link to line in diffusion for line links (authored by Florian).
Link to line in diffusion for line links
Dec 21 2017, 12:22 PM
Florian committed rLCSH2c980c795ed3: Link to line in diffusion for line links (authored by Florian).
Link to line in diffusion for line links
Dec 21 2017, 12:20 PM

Dec 20 2017

Florian added projects to T180979: List of Newsletters should have a column showing the number of issues: Performance, DBA.

Ok, during implementation and after chatting to @Bawolff about that, we came to the conclusion, that see some things we need to discuss further before merging anything :] The main things we're worried of is the amount of data the database needs to go through for each request of the Special:Newsletters page, which can be a performance killer. I'll add @jcrespo hoping that he has some ideas how we can improve on the solutions we already have or maybe he has a completely different idea :)

Dec 20 2017, 6:18 PM · DBA, Performance, Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian closed T180980: Special:Newsletters should have a help link to Help:Extension:Newsletter as Resolved.
Dec 20 2017, 5:57 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian closed T183365: Unable to Integrate Google Login Extension as Invalid.

Hi! Thanks for reporting this. However, this is not a bug, as it works like expected. As you haven't connected your Google-account with any local wiki account so far, GoogleLogin doesn't know which user to login with this google account. So, first login with your username and password and then navigate to Special:LinkAccounts. Click the "link with Google account" button. If that was successful, logout and try to login with your Google account, which should work now.

Dec 20 2017, 4:00 PM · GoogleLogin
Florian added a comment to T166355: Detect when CirrusSearch is used without curl and fail gracefully.

Now that I think about that: You're right. Even if Elastica is currently only required by the CirrusSearch extension (I think), the requirement comes from Elastica, so it should life there. I'll propose changes to change the place, sorry :(

Dec 20 2017, 1:28 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch
Florian created T183322: mwext-php70-phan-docker should've php-curl extension installed.
Dec 20 2017, 12:48 AM · Continuous-Integration-Infrastructure (shipyard), Patch-For-Review

Dec 19 2017

Florian added a comment to T166355: Detect when CirrusSearch is used without curl and fail gracefully.

@Phantom42 That sounds good, too. That's a simple change, too, would you like to do that in your change in gerrit, too? :)

Dec 19 2017, 11:31 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch

Dec 17 2017

Florian added a comment to T166355: Detect when CirrusSearch is used without curl and fail gracefully.

@Phantom42 Great! If you've any questions or if you run into problems, feel free to ask :)

Dec 17 2017, 10:01 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch

Dec 16 2017

Florian closed T54711: Echo: Help tooltip in preferences is not accessible as Resolved.
Dec 16 2017, 2:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Accessibility, MediaWiki-User-preferences

Dec 11 2017

Florian added a comment to T177810: Fix up PHPCS violations that are excluded in phpcs.xml.

You mean, 5-10 separate changes?

Dec 11 2017, 9:21 AM · Epic, MediaWiki-extensions-General, MediaWiki-General-or-Unknown, Google-Code-in-2017

Dec 6 2017

Florian awarded T182002: +2 for WMDE-Fisch in mediawiki/* a Like token.
Dec 6 2017, 8:01 PM · User-Addshore, Repository-Ownership-Requests

Dec 5 2017

Florian awarded T181904: +2 for Ebe123 in mediawiki/extensions/Score a Like token.
Dec 5 2017, 6:47 AM · MediaWiki-extensions-Score, Repository-Ownership-Requests
Samwilson awarded T117781: Convert Special:Preferences to OOUI a Heartbreak token.
Dec 5 2017, 12:39 AM · Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Patch-For-Review, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization

Dec 4 2017

Niharika awarded T117781: Convert Special:Preferences to OOUI a Heartbreak token.
Dec 4 2017, 5:04 PM · Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Patch-For-Review, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization

Dec 2 2017

Florian awarded T181904: +2 for Ebe123 in mediawiki/extensions/Score a Like token.
Dec 2 2017, 11:06 PM · MediaWiki-extensions-Score, Repository-Ownership-Requests
Florian moved T166355: Detect when CirrusSearch is used without curl and fail gracefully from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.
Dec 2 2017, 10:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch
Florian added a project to T166355: Detect when CirrusSearch is used without curl and fail gracefully: Google-Code-in-2017.

Imported as: https://codein.withgoogle.com/dashboard/tasks/6565444326522880/

Dec 2 2017, 10:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch
Florian added a comment to T166355: Detect when CirrusSearch is used without curl and fail gracefully.

What MediaWiki itself does, when a library is missing, it outputs a nice error message with the MediaWiki logo and a message what is missing and what the visitor (hopefully the system administrator) can do to fix that. It can be accessed by the PHPVersionCheck class with the triggerError() method. That could be a good option.

Dec 2 2017, 10:52 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Google-Code-in-2017, Need-volunteer, Easy, Discovery-Search, Discovery, CirrusSearch
Florian moved T177997: WikiImporter::notice echoing of unescaped values is a dangerous api from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

I'll mentor this, imported as: https://codein.withgoogle.com/dashboard/tasks/5638122769481728/

Dec 2 2017, 10:40 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Easy, Security-Core, Security, MediaWiki-Export-or-Import
Florian added a project to T177997: WikiImporter::notice echoing of unescaped values is a dangerous api: Google-Code-in-2017.
Dec 2 2017, 10:39 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Easy, Security-Core, Security, MediaWiki-Export-or-Import
Florian moved T179532: Call to undefined method WikiPage::getText() from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

I'll mentor this!

Dec 2 2017, 10:26 PM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, Easy, MediaWiki-extensions-Wikilog
Florian added a project to T179532: Call to undefined method WikiPage::getText(): Google-Code-in-2017.
Dec 2 2017, 10:25 PM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, Easy, MediaWiki-extensions-Wikilog
Florian added a comment to T181673: wfWaitForSlaves is deprecated, replace usages.

Hmm, if I understood Reedy correctly, some usages of wfWaitForSlaves() were already be converted to wfGetLBFactory()->waitForReplication() without keeping the notes from @Anomie in mind? What would be the best way to proceed here? Having the timeout reduced because of this change looks like a massive problem, as well as not waiting for the wiki but for every cluster.

Dec 2 2017, 10:24 AM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, MediaWiki-Maintenance-scripts

Nov 29 2017

Florian added a comment to T180979: List of Newsletters should have a column showing the number of issues.

I'm happy to mentor this task, too! :)

Nov 29 2017, 10:17 PM · DBA, Performance, Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian added a comment to T180982: Individual newsletter pages should have a visual hierarchy.

I was free to added me as a mentor, too, together with @MtDu and @01tonythomas we can get this! :)

Nov 29 2017, 10:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian added a comment to T180980: Special:Newsletters should have a help link to Help:Extension:Newsletter.

I would like to mentor this task together with @MtDu :)

Nov 29 2017, 10:13 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Florian added a comment to T177810: Fix up PHPCS violations that are excluded in phpcs.xml.

I think 5-10 changes should be reasonable, wouldn't it? @Reedy Do you want to mentor this task together with me? :D

Nov 29 2017, 10:08 PM · Epic, MediaWiki-extensions-General, MediaWiki-General-or-Unknown, Google-Code-in-2017
Florian moved T181673: wfWaitForSlaves is deprecated, replace usages from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

Three (cloneable) tasks for now, let's see what happens! :D
https://codein.withgoogle.com/tasks/5553397937733632/
https://codein.withgoogle.com/tasks/5066947928522752/
https://codein.withgoogle.com/tasks/6252978451251200/

Nov 29 2017, 10:01 PM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, MediaWiki-Maintenance-scripts
Florian added a comment to T181673: wfWaitForSlaves is deprecated, replace usages.

I'll mentor this in GCI :) I think that fixing at least 5 occurences per task (instance) sounds like a reasonable amount :)

Nov 29 2017, 9:57 PM · Patch-For-Review, Google-Code-in-2017, Technical-Debt, MediaWiki-Maintenance-scripts
Florian closed T179582: Warning: in_array() expects parameter 2 to be array, null given in when allowed Domains saved in DB, but no domain existent as Resolved.
Nov 29 2017, 9:55 PM · GoogleLogin
Florian added a comment to T179342: When searching "My lists" or "History", whitespace should be trimmed..

What @Filip said would be ok for me, too, depending on how much effort you already invested in the task :)

Nov 29 2017, 3:12 PM · Google-Code-in-2017, Wikipedia-Android-App-Backlog
Florian added a comment to T179342: When searching "My lists" or "History", whitespace should be trimmed..

Hi @AnmolSingh! Big sorry for that confusion, please excuse my fault when publishing/creating the GCI task :/ The task shouldn't have 2 instances, it should've only one. It would be great if you could abandon the task in GCI. Again, please excuse this confusion :/

Nov 29 2017, 3:11 PM · Google-Code-in-2017, Wikipedia-Android-App-Backlog

Nov 19 2017

Florian added a comment to T179776: Localize some hard-coded strings in the interface.

There's a column on the Google-Code-in-2017 board (Imported in GCI site). However, the communication for task/implementation related stuff should be done within phabricator (so anyone can follow it), and only GCI related things should be done on the GCI site (it's possible to do all of the communication in the GCI site, though). So, I wouldn't close the task once it is imported into GCI, but it's up to you :)

Nov 19 2017, 1:52 PM · Google-Code-in-2017, I18n, Huggle
Florian added a comment to T179776: Localize some hard-coded strings in the interface.

@Petrb Was it intentional that you closed this task as resolved? It could be confusing for a GCI student to click on the "external URL" link in the GCI platform and then seeing an already resolved task :/

Nov 19 2017, 11:32 AM · Google-Code-in-2017, I18n, Huggle

Nov 18 2017

Florian moved T166216: Imagegrid should lazy load from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

For GCI students: What is the acceptance criteria, when does a student now, when the task is finished? :) Is there any material which could help them to solve this task?

Nov 18 2017, 12:18 PM · Wikidata Query UI, Patch-For-Review, Design, WMDE-Design, Google-Code-in-2017, Need-volunteer, Discovery, Easy, Wikidata
Florian added a project to T166216: Imagegrid should lazy load: Google-Code-in-2017.
Nov 18 2017, 12:17 PM · Wikidata Query UI, Patch-For-Review, Design, WMDE-Design, Google-Code-in-2017, Need-volunteer, Discovery, Easy, Wikidata
Florian moved T173213: Implement keyboard accessibility for Query.Wikidata.org from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

Was already imported as: https://codein.withgoogle.com/dashboard/tasks/4880480144982016/

Nov 18 2017, 12:16 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
Florian added a project to T173213: Implement keyboard accessibility for Query.Wikidata.org: Google-Code-in-2017.
Nov 18 2017, 12:15 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic

Nov 16 2017

Florian added a comment to T94020: The labels and numbers in CX translation trend graph are not localized.

Thanks for the info @Nikerabbit! :)

Nov 16 2017, 5:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Language-2018-Jan-Mar, Google-Code-in-2017, WorkType-Maintenance, I18n, Easy, ContentTranslation
Florian updated the task description for T94020: The labels and numbers in CX translation trend graph are not localized.
Nov 16 2017, 5:14 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Language-2018-Jan-Mar, Google-Code-in-2017, WorkType-Maintenance, I18n, Easy, ContentTranslation
Florian added a comment to T180207: Convert "Show diff" part of Special:Undelete to OOUI.

I also updated the GCI task :)

Nov 16 2017, 5:12 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Google-Code-in-2017, Easy, MediaWiki-Special-pages, Design
Florian added a subtask for T107037: Convert all MW core special pages to OOUI: T180207: Convert "Show diff" part of Special:Undelete to OOUI.
Nov 16 2017, 5:11 PM · Front-end-Standards-Group, Tracking, Epic, UI-Standardization
Florian added a parent task for T180207: Convert "Show diff" part of Special:Undelete to OOUI: T107037: Convert all MW core special pages to OOUI.
Nov 16 2017, 5:11 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Google-Code-in-2017, Easy, MediaWiki-Special-pages, Design
Florian renamed T180207: Convert "Show diff" part of Special:Undelete to OOUI from Add margin between buttons on Special:Undelete to Convert "Show diff" part of Special:Undelete to OOUI.
Nov 16 2017, 5:11 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Google-Code-in-2017, Easy, MediaWiki-Special-pages, Design