Page MenuHomePhabricator

Florian (Florianschmidtwelzow)
Volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:13 AM (321 w, 4 d)
Availability
Available
IRC Nick
FlorianSW
LDAP User
Florianschmidtwelzow
MediaWiki User
Florianschmidtwelzow [ Global Accounts ]

Recent Activity

Wed, Dec 2

Florian closed T269178: MemcachedClient: PHP Warning: Resource ID#784 used as offset, casting to integer (784) as Resolved.

Ok, thx for the info :)

Wed, Dec 2, 11:22 PM · MW-1.31-release-notes, MW-1.35-notes, MW-1.31-release, MW-1.35-release, Patch-For-Review, PHP 8.0 support, MediaWiki-Cache
Florian closed T267669: MediaWiki 1.36 now requires php-intl extension as Resolved.

Last changes are +2ed, so this should be fine to be closed :)

Wed, Dec 2, 11:21 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Patch-For-Review, MediaWiki-Internationalization, MediaWiki-General
Florian added a comment to T269178: MemcachedClient: PHP Warning: Resource ID#784 used as offset, casting to integer (784).

Hmm, you're right, didn't see that. Thanks for the patch. Not sure, who should merge the Backport to the release branches, though (may I merge them as well?). Therefore keeping the task open for now.

Wed, Dec 2, 11:07 PM · MW-1.31-release-notes, MW-1.35-notes, MW-1.31-release, MW-1.35-release, Patch-For-Review, PHP 8.0 support, MediaWiki-Cache
Florian added a comment to T269173: Migrate default of $wgMinervaEnableSiteNotice to true.

Thanks @Florian for taking care of that one!

Wed, Dec 2, 11:03 PM · Patch-For-Review, MinervaNeue

Tue, Dec 1

Florian created T269178: MemcachedClient: PHP Warning: Resource ID#784 used as offset, casting to integer (784).
Tue, Dec 1, 11:08 PM · MW-1.31-release-notes, MW-1.35-notes, MW-1.31-release, MW-1.35-release, Patch-For-Review, PHP 8.0 support, MediaWiki-Cache
Florian added a comment to T214824: CookieWarning does not interact correctly with MobileFrontend.

I'm not quite sure, but this could be done with T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook resolved?

Tue, Dec 1, 10:42 PM · MediaWiki-extensions-CookieWarning
Jdlrobson awarded T269173: Migrate default of $wgMinervaEnableSiteNotice to true a Like token.
Tue, Dec 1, 10:40 PM · Patch-For-Review, MinervaNeue
Florian updated the task description for T269173: Migrate default of $wgMinervaEnableSiteNotice to true.
Tue, Dec 1, 10:20 PM · Patch-For-Review, MinervaNeue
Florian updated the task description for T269173: Migrate default of $wgMinervaEnableSiteNotice to true.
Tue, Dec 1, 10:17 PM · Patch-For-Review, MinervaNeue
Florian created T269173: Migrate default of $wgMinervaEnableSiteNotice to true.
Tue, Dec 1, 10:12 PM · Patch-For-Review, MinervaNeue

Thu, Nov 26

Florian removed a project from T131629: JS ComboBoxInputWidget should support autocompletion by non-prefix searches as well: Patch-Needs-Improvement.
Thu, Nov 26, 6:16 PM · OOUI
Florian placed T131629: JS ComboBoxInputWidget should support autocompletion by non-prefix searches as well up for grabs.
Thu, Nov 26, 6:16 PM · OOUI
Florian placed T168557: "Keep me logged in" check box shouldn't be shown when a logged-in user is being verified up for grabs.
Thu, Nov 26, 6:15 PM · Patch-Needs-Improvement, MediaWiki-Authentication-and-authorization
Florian removed a project from T106894: action=render has no effect on Special pages: Patch-Needs-Improvement.
Thu, Nov 26, 6:15 PM · MediaWiki-Special-pages, MediaWiki-General
Florian placed T106894: action=render has no effect on Special pages up for grabs.
Thu, Nov 26, 6:15 PM · MediaWiki-Special-pages, MediaWiki-General
Florian placed T114756: Special:Contributions should sort by rev_id if two revisions have the same rev_timestamp up for grabs.
Thu, Nov 26, 6:14 PM · TestMe, MediaWiki-Special-pages
Florian closed T150053: Wikipedia namespace on Wikipedia should have a Cite link as Resolved.
Thu, Nov 26, 6:14 PM · CiteThisPage

Sun, Nov 22

Florian closed T254525: Don't use internal FallbackTemplate inside code, a subtask of T254048: Render the FallbackSkin and SkinApi with a simplistic SkinMustache class, as Resolved.
Sun, Nov 22, 2:46 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), MediaWiki-Core-Skin-Architecture
Florian closed T254525: Don't use internal FallbackTemplate inside code as Resolved.

CookieWarning doesn't use FallbackTemplate from what I can see.

Sun, Nov 22, 2:46 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Technical-Debt, MediaWiki-extensions-CookieWarning
Florian merged T267436: Cookie Warning does not appear in MediaWiki 1.35 and Vector skin into T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.
Sun, Nov 22, 2:45 PM · MediaWiki-extensions-CookieWarning
Florian merged task T267436: Cookie Warning does not appear in MediaWiki 1.35 and Vector skin into T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.
Sun, Nov 22, 2:44 PM · MediaWiki-extensions-CookieWarning
Florian added a comment to T267436: Cookie Warning does not appear in MediaWiki 1.35 and Vector skin.

Yep, this is a duplicate of T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

Sun, Nov 22, 2:44 PM · MediaWiki-extensions-CookieWarning

Tue, Nov 10

Florian created T267669: MediaWiki 1.36 now requires php-intl extension.
Tue, Nov 10, 5:50 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Patch-For-Review, MediaWiki-Internationalization, MediaWiki-General

Oct 9 2020

Florian added a comment to T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).

I commented upstream to let ask whether this was intentional and/or whether it will be documented or backported as warning.

Oct 9 2020, 9:34 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-ResourceLoader, MediaWiki-Parser, Performance-Team, PHP 8.0 support

Oct 3 2020

Florian renamed T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str) from Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str) in /code/w/includes/resourceloader/ResourceLoader.php:1899 to Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).
Oct 3 2020, 3:21 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-ResourceLoader, MediaWiki-Parser, Performance-Team, PHP 8.0 support
Florian added a comment to T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).

One more in Preprocessor_Hash, adding to the task description.

Oct 3 2020, 3:20 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-ResourceLoader, MediaWiki-Parser, Performance-Team, PHP 8.0 support
Florian added a subtask for T248925: Make MediaWiki compatible with PHP 8: T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).
Oct 3 2020, 3:08 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
Florian added a parent task for T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str): T248925: Make MediaWiki compatible with PHP 8.
Oct 3 2020, 3:08 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-ResourceLoader, MediaWiki-Parser, Performance-Team, PHP 8.0 support
Florian created T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).
Oct 3 2020, 3:07 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-ResourceLoader, MediaWiki-Parser, Performance-Team, PHP 8.0 support
Florian closed T253895: Cannot create an actor for a usable name that is not an existing user as Resolved.

Fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/588388

Oct 3 2020, 2:43 PM · MediaWiki-User-management, Patch-For-Review, MediaWiki-extensions-UserMerge

May 13 2020

Florian added a comment to T250488: ReCaptchaNoCaptcha not working in VisualEditor.

No, I think it's ok to close this task :-) If we find a good way to test this feature, we can still write a patch or a separate task for it :)

May 13 2020, 3:39 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Skipped QA, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, ConfirmEdit (CAPTCHA extension)
Florian added a comment to T252427: Proxy support for hCaptcha.

Wouldn't it be more consistent to have a single configuration in ConfirmEdit to configure a proxy? E.g. ReCaptcha would benefit from having a proxy configuration as well, if it is used in such an environment. We could provide an own service (like one for DI) which can be used by Captcha modules in ConfirmEdit to make outbund HTTP requests?

May 13 2020, 3:38 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), ConfirmEdit (CAPTCHA extension)

Apr 18 2020

Florian claimed T250544: Update external JS loading for CSP friendlyness.
Apr 18 2020, 9:35 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), ContentSecurityPolicy, ConfirmEdit (CAPTCHA extension)
Florian added a comment to T250488: ReCaptchaNoCaptcha not working in VisualEditor.

@matmarex I'm not that deep into how VE works, but is there a possibility to have a test from somewhere on this side? Something like a JavaScript testing module, which checks, that the plugin is registered? That would not check the functionality itself, sure, but at least we know, if the plugin is there and _would_ work?

Apr 18 2020, 9:22 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Skipped QA, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, ConfirmEdit (CAPTCHA extension)
Florian added a comment to T250544: Update external JS loading for CSP friendlyness.

The same probably for reCaptcha as well, right?

Apr 18 2020, 9:19 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), ContentSecurityPolicy, ConfirmEdit (CAPTCHA extension)

Apr 17 2020

Florian closed T250236: renocaptcha-info used in ReCaptchaNoCaptcha.php but not defined as Resolved.
Apr 17 2020, 4:00 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), ConfirmEdit (CAPTCHA extension)
Florian claimed T250236: renocaptcha-info used in ReCaptchaNoCaptcha.php but not defined.
Apr 17 2020, 3:29 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), ConfirmEdit (CAPTCHA extension)
Florian updated the task description for T250297: ReCaptchaNoCaptcha should use recaptcha.net domain instead of google.com.
Apr 17 2020, 3:06 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Patch-For-Review, ConfirmEdit (CAPTCHA extension)
Florian awarded T250227: Investigate and evaluate hCaptcha to replace Wikimedia's Fancy Captcha a Like token.
Apr 17 2020, 3:01 PM · Privacy, ConfirmEdit (CAPTCHA extension), Security-Team
Florian created T250488: ReCaptchaNoCaptcha not working in VisualEditor.
Apr 17 2020, 1:45 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Skipped QA, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, ConfirmEdit (CAPTCHA extension)

Apr 13 2020

Florian added a comment to T249248: CookieWarning's GDPR compliance.
  1. A way for extensions to tell CookieWarning what other cookies they are setting which would require consent and which categories they belong to. This is best accomplished by a custom hook imo

Do we really need such a hook? Aren't categories like

  • "functional" (which never can be "deactivated")
  • "tracking" (like Google Analytics, matomo or whatever tool that tracks the user, probably also EventLogging?)
  • "advertising" (like Google AdSense or any other advertisers, which are shipped from external sources)

enough? Especially speaking about how additional categories are described (by a message, e.g.) is probably too much overhead in the first version of such an enhanced consent thingy?

Apr 13 2020, 2:35 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
Florian claimed T238632: "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous").
Apr 13 2020, 11:23 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-extensions-UserMerge
Florian renamed T238632: "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous") from Problem with merge to "Anonymous" in Mediawiki 1.33 to "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous").
Apr 13 2020, 10:59 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-extensions-UserMerge
Florian added a comment to T238632: "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous").

Had the same issue on one of my wikis as well (when trying to delete a user account). Working on it, the solution from T241839: UserMerge cannot create an actor for a usable name that is not an existing user. looks promising, but needs to be done in a way that the extension does that for someone :D

Apr 13 2020, 10:59 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-extensions-UserMerge
Florian merged task T241839: UserMerge cannot create an actor for a usable name that is not an existing user. into T238632: "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous").
Apr 13 2020, 10:50 AM · MediaWiki-extensions-UserMerge
Florian merged T241839: UserMerge cannot create an actor for a usable name that is not an existing user. into T238632: "Cannot create an actor for a usable name that is not an existing user" when deleting a user (merge to "Anonymous").
Apr 13 2020, 10:49 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-extensions-UserMerge

Apr 4 2020

Florian removed a project from T240775: RFC: Support PHP 7.4 preload: Patch-For-Review.
Apr 4 2020, 1:33 PM · Performance-Team, TechCom-RFC
Florian added a comment to T240775: RFC: Support PHP 7.4 preload.

Ok, looking at the status of the opcache after the server startup, it looks like, that the function wfWebStartSetup is present in the cache, like one would expect. However, when WebStart.php is included from index.php or load.php, we evaluate, if a constant named MW_SETUP_CALLBACK is defined already (which is later called in Setup.php, which does not matter for the current case). This constant is, also like expected, not defined when running from index.php or load.php and MediaWiki tries to register the callback function wfWebStartSetup. The problem seems to be, that evaluating this code, MediaWiki defines the function conditionally inside of the defined check for the MW_SETUP_CALLBACK constant. This seems to result in PHP trying to define the wfWebStartSetup function again, even given it is already defined from the preloading run during startup.

Apr 4 2020, 1:33 PM · Performance-Team, TechCom-RFC

Apr 3 2020

Florian added a comment to T199037: [Google Adsense] Allow to pause ad delivery as long as the user was asked for consent.

This task is probably related to T249248, which could provide a way on how a user could be asked for consent.

Apr 3 2020, 5:27 PM · MediaWiki-extensions-GoogleAdSense
Florian added a comment to T249248: CookieWarning's GDPR compliance.

but I guess the easier way to implement this it would be for the scripts to be added through CookieWarning itself.

Apr 3 2020, 5:25 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
Florian added a comment to T249248: CookieWarning's GDPR compliance.

Please also (as an information) do not assign tasks to other people, if they did not explicitly stated that they work on it :) This leaves space for other developers to take up a task they would like to work on and enables assigned developers to manage their tasks, they work on, on their own :)

Apr 3 2020, 2:59 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
Florian placed T249248: CookieWarning's GDPR compliance up for grabs.
Apr 3 2020, 2:58 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning
Florian added a comment to T249248: CookieWarning's GDPR compliance.

The idea sounds promising. However, the question would be: How is the extension able to block scripts, that needs to be blocked. I think we're talking about analytics (like Google Analytics) and ad code (like Google AdSense)? How does your wiki add these scripts:

  • Is it another extension?
  • Is it added through a hook manually (like in LocalSettings.php)?
  • Is it added by another script on the page (client-side JavaScript)?
  • Is the code added in the skin/template?
Apr 3 2020, 2:58 PM · Privacy Engineering, MediaWiki-extensions-CookieWarning

Mar 21 2020

Florian assigned T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime to AdhamKhatean.

@AdhamKhatean Thanks for taking a look into it and trying to solve this task! :)

Mar 21 2020, 10:28 AM · Patch-Needs-Improvement, Platform Engineering (Icebox), Google-Code-in-2019, good first task, MediaWiki-Logevents

Mar 20 2020

Florian placed T128487: Support more CAPTCHA modules of ConfirmEdit in the Api up for grabs.
Mar 20 2020, 8:34 AM · ConfirmEdit (CAPTCHA extension)
Florian placed T165835: RevisionSlider for mobile view up for grabs.

Un-assigning myself, as I'm not working on at the moment.

Mar 20 2020, 8:34 AM · WMDE-Technical-Wishes-Maintenance, MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), archived--TCB-Team, Revision-Slider
Florian placed T148112: Transcluding the list of changes with a specific tag on not supported non latyn script languages. up for grabs.

Un-assigning myself, not even sure how I ended up being assigned here in the first place.

Mar 20 2020, 8:33 AM · Growth-Team, MediaWiki-Recent-changes

Mar 7 2020

Florian awarded T99740: Use static php array files for l10n cache at WMF (instead of CDB) a Yellow Medal token.
Mar 7 2020, 12:59 PM · Patch-For-Review, Performance-Team, Release-Engineering-Team-TODO, Scap, MediaWiki-Internationalization

Mar 6 2020

Florian created T247108: package-lock.json is not up to date with package.json.
Mar 6 2020, 5:36 PM · Citoid

Mar 2 2020

srishakatux awarded T241869: Display convenient links from OAuth special pages to each other (where appropriate) a Stroopwafel token.
Mar 2 2020, 11:29 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), good first task, MediaWiki-extensions-OAuth

Mar 1 2020

Florian closed T241869: Display convenient links from OAuth special pages to each other (where appropriate), a subtask of T98880: Improve OAuth management interface, as Resolved.
Mar 1 2020, 12:15 PM · Product-Infrastructure-Team-Backlog, Epic, MediaWiki-extensions-OAuth
Florian closed T241869: Display convenient links from OAuth special pages to each other (where appropriate) as Resolved.
Mar 1 2020, 12:15 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), good first task, MediaWiki-extensions-OAuth

Feb 18 2020

alcarazzam awarded T241927: Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) a Love token.
Feb 18 2020, 6:23 PM · Developer-Advocacy (Jan-Mar 2020), Google-Code-in-2019

Feb 17 2020

Florian closed T165517: XenForoAuth: "Call to a member function isAnon() on a non-object (boolean)" when logging in as Resolved.
Feb 17 2020, 5:44 PM · Patch-For-Review, MediaWiki-extensions-Other
Florian reopened T241869: Display convenient links from OAuth special pages to each other (where appropriate) as "Open".

Oops, nice to see that this one was resolved, however, there're still links missing:

Feb 17 2020, 5:35 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), good first task, MediaWiki-extensions-OAuth
Florian reopened T241869: Display convenient links from OAuth special pages to each other (where appropriate), a subtask of T98880: Improve OAuth management interface, as Open.
Feb 17 2020, 5:35 PM · Product-Infrastructure-Team-Backlog, Epic, MediaWiki-extensions-OAuth

Feb 15 2020

IAmNetx awarded T241927: Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) a Love token.
Feb 15 2020, 3:37 PM · Developer-Advocacy (Jan-Mar 2020), Google-Code-in-2019

Feb 13 2020

Florian awarded T245178: Fatal: Argument to LogPage::getTitleLink() must be Language, StubUserLang given (via LogPage.php) a Heartbreak token.
Feb 13 2020, 8:06 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MediaWiki-Logevents, Wikimedia-production-error
Florian added a comment to T245178: Fatal: Argument to LogPage::getTitleLink() must be Language, StubUserLang given (via LogPage.php).

Thanks to everyone involved in fixing this here, shame on me for not seeing this in the code-re iew :(

Feb 13 2020, 8:06 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MediaWiki-Logevents, Wikimedia-production-error
Florian added a comment to T241927: Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21).

Yes, from mean s well, @Ebe123 is a reasonable choice here :)

Feb 13 2020, 4:37 PM · Developer-Advocacy (Jan-Mar 2020), Google-Code-in-2019

Feb 12 2020

Florian awarded T243667: Cannot log in when username contains spaces in PHP 7.4: "wrong username or password" a Love token.
Feb 12 2020, 8:51 PM · Upstream, PHP 7.4 support, MediaWiki-User-login-and-signup
Florian added a comment to T241927: Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21).

I'm available for both dates and would be happy to get to know our winner tudents :)

Feb 12 2020, 6:03 AM · Developer-Advocacy (Jan-Mar 2020), Google-Code-in-2019

Feb 11 2020

Florian added a comment to T241927: Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21).

I think we'd the instance count vs. task count in the others years as well, however, especially for tasks with multiple mentors, a mentor may not interact with the task on the platform, but interacted with the student on IRC, Gerrit or phabricator, justd isn't approve the task in GCI (e.g. it turned night in their Timezone or whatever). Last times the task count seemed to be a good compromise between the interaction count and instance count.

Feb 11 2020, 7:04 AM · Developer-Advocacy (Jan-Mar 2020), Google-Code-in-2019

Feb 10 2020

Florian closed T240774: OAuth error not rendered properly as Resolved.
Feb 10 2020, 9:28 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Google-Code-in-2019, MediaWiki-extensions-OAuth

Feb 9 2020

Florian updated the task description for T241869: Display convenient links from OAuth special pages to each other (where appropriate).
Feb 9 2020, 4:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), good first task, MediaWiki-extensions-OAuth
Florian updated the task description for T241869: Display convenient links from OAuth special pages to each other (where appropriate).
Feb 9 2020, 3:24 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), good first task, MediaWiki-extensions-OAuth

Feb 1 2020

Florian added a comment to T240775: RFC: Support PHP 7.4 preload.

The latest master of php (mentioned as 8.0.0-dev) seems to work with preloading MediaWiki, at least it does not segfault anymore, as of now. However, there seems to be some stuff that needs to be investigated, as I currently get a fatal error, that a function in WebStart can not be redeclared:

Feb 1 2020, 7:16 PM · Performance-Team, TechCom-RFC

Jan 24 2020

Florian added a comment to T204794: GoogleLogin not triggering "Keep me logged in" automatically.

Just out of curiosity: The default setting for cookies when logging in of MediaWiki should be 30 days. Is it possible that you configured https://www.mediawiki.org/wiki/Manual:$wgCookieExpiration to a way lower amount of time? This would probably the right way to change the default time until a user is logged out.

Jan 24 2020, 5:47 PM · MediaWiki-Authentication-and-authorization, GoogleLogin
Florian closed T241354: Drop support for passing a User to ApiBase::checkTitleUserPermissions, deprecated and unused as Resolved.
Jan 24 2020, 5:31 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-DannyS712, Technical-Debt (Deprecation process)

Jan 20 2020

Florian added a comment to T243156: Sitename with whitespace breaks over the header size.

Sorry, I should've said that: I made the images, as I intended to fix this issue on the local wiki by adding the css property in the timeless.css. That's why you can't actually reproduce this issue on the linked wiki anymore, however it still persists and should (from what I see) not be browser-specific.

Jan 20 2020, 6:18 PM · Timeless

Jan 19 2020

Florian closed T225862: Create tests for UploadFromUrl::isAllowedHost as Resolved.
Jan 19 2020, 8:14 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-Majavah, Google-Code-in-2019, Multimedia, good first task, MediaWiki-Uploading, MediaWiki-Core-Testing
Florian created T243156: Sitename with whitespace breaks over the header size.
Jan 19 2020, 3:47 PM · Timeless
Florian reassigned T242504: Upgrade Timeless skin.json schema to manifest_version 2 from Florian to Ammarpad.
Jan 19 2020, 3:45 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Timeless
Florian closed T242504: Upgrade Timeless skin.json schema to manifest_version 2, a subtask of T242503: Upgrade skins skin.json schema to manifest_version 2, as Resolved.
Jan 19 2020, 3:45 PM · Other-skins
Florian closed T242504: Upgrade Timeless skin.json schema to manifest_version 2 as Resolved.
Jan 19 2020, 3:45 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Timeless
Florian added a comment to T225862: Create tests for UploadFromUrl::isAllowedHost.

@Majavah Yeah, that's what I mean :) Sorry, that I didn't link this in the first place, I didn't think about, that this is probably gerrit-specific and that not everyone might know about this :)

Jan 19 2020, 2:16 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-Majavah, Google-Code-in-2019, Multimedia, good first task, MediaWiki-Uploading, MediaWiki-Core-Testing
Florian added a comment to T225862: Create tests for UploadFromUrl::isAllowedHost.

Good catch, didn't see that, sorry for the confusion! I worked on this change to make the tests working again (and bring them back from the broken group). Is it ok for you to work on top of this change? Then your new tests should work as well :)

Jan 19 2020, 1:19 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-Majavah, Google-Code-in-2019, Multimedia, good first task, MediaWiki-Uploading, MediaWiki-Core-Testing

Jan 18 2020

Florian moved T233402: GettextFFS should implement isContentEqual from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.
Jan 18 2020, 10:45 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Majavah, Google-Code-in-2019, good first task, MediaWiki-extensions-Translate
Florian added a project to T233402: GettextFFS should implement isContentEqual: Google-Code-in-2019.

It's late, but I imported this task into GCI as https://codein.withgoogle.com/dashboard/tasks/4964700098396160/ Let's see if someone claims this in the last days of the contest :)

Jan 18 2020, 10:45 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Majavah, Google-Code-in-2019, good first task, MediaWiki-extensions-Translate
Kaartic awarded T117736: Convert Special:Contributions to OOUI a Love token.
Jan 18 2020, 6:39 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization

Jan 17 2020

Florian closed T242923: Guzzle conflict in GoogleLogin as Resolved.

@Reedy Thanks for checking my assumption :)
@Wolfhelius It would be awesome, however, I would suggest that we move this discussion somewhere else. Either you edit the GoogleLogin documentation on mediawiki.org directly (what I would welcome), or you can point out the improvements on the discussion page.

Jan 17 2020, 4:41 PM · GoogleLogin

Jan 16 2020

Florian added a comment to T242923: Guzzle conflict in GoogleLogin.

So, this is resolved or did I miss something? I'm not sure, what we can do in GoogleLogin to mitigate this problem :(

Jan 16 2020, 7:13 PM · GoogleLogin
Florian created T243006: Key "CanonicalNamespaceNames" not found in input sources in includes/config/ServiceOptions.php:52.
Jan 16 2020, 7:05 PM · MediaWiki-extensions-Lingo

Jan 15 2020

Florian added a comment to T242645: Remove MWOAuth prefix from classes and PHP files in the OAuth extension.

@Ammarpad I was so free to assign myself as well, so we can co-mentor this :]

Jan 15 2020, 5:39 PM · Patch-For-Review, Google-Code-in-2019, good first task, MediaWiki-extensions-OAuth

Jan 10 2020

Florian moved T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files) from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.

Imported as https://codein.withgoogle.com/dashboard/tasks/5648057396363264/ with 10 task instances for now :)

Jan 10 2020, 5:42 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Google-Code-in-2019, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), good first task, MediaWiki-General, Test-Coverage, MediaWiki-Core-Testing
Florian added a project to T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files): Google-Code-in-2019.

Sounds like a good task for GCI, I'll mentor this :)

Jan 10 2020, 5:38 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Google-Code-in-2019, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), good first task, MediaWiki-General, Test-Coverage, MediaWiki-Core-Testing
Florian moved T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.

Imported as https://codein.withgoogle.com/dashboard/tasks/5169077006368768/

Jan 10 2020, 5:33 PM · Patch-Needs-Improvement, Platform Engineering (Icebox), Google-Code-in-2019, good first task, MediaWiki-Logevents
Florian added a project to T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime: Google-Code-in-2019.

Let's see if a student wants to take this, I'll mentor it :)

Jan 10 2020, 5:27 PM · Patch-Needs-Improvement, Platform Engineering (Icebox), Google-Code-in-2019, good first task, MediaWiki-Logevents
Florian moved T225862: Create tests for UploadFromUrl::isAllowedHost from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.

Imported as https://codein.withgoogle.com/dashboard/tasks/5658834341724160/

Jan 10 2020, 5:21 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-Majavah, Google-Code-in-2019, Multimedia, good first task, MediaWiki-Uploading, MediaWiki-Core-Testing
Florian added a comment to T225862: Create tests for UploadFromUrl::isAllowedHost.

I'll mentor this in GCI :)

Jan 10 2020, 5:16 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-Majavah, Google-Code-in-2019, Multimedia, good first task, MediaWiki-Uploading, MediaWiki-Core-Testing