Page MenuHomePhabricator

Fomafix (Fomafix)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2014, 8:51 AM (314 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Fomafix [ Global Accounts ]

Recent Activity

Sat, Oct 24

Fomafix added a comment to T256466: Opening Echo flyout undefines $.widget.extend (jQuery UI) if there are past notifications.

I guess rECHO121cbd6ee87d: Fix incorrect use of $.extend() (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/631939) solved the problem.

Sat, Oct 24, 5:54 PM · Growth-Team, Notifications
Fomafix added a comment to T256466: Opening Echo flyout undefines $.widget.extend (jQuery UI) if there are past notifications.

I also can't reproduce the problem anymore.

Sat, Oct 24, 12:35 PM · Growth-Team, Notifications

Wed, Sep 30

Fomafix added a comment to T256466: Opening Echo flyout undefines $.widget.extend (jQuery UI) if there are past notifications.

I can confirm this problem on using Echo. But sometimes $.widget.extend is undefined on my watchlist after same time although I didn't used Echo.

Wed, Sep 30, 7:26 AM · Growth-Team, Notifications

Jun 14 2020

Fomafix created T255367: Global script is not loaded on debug=true.
Jun 14 2020, 1:42 PM · Performance-Team, MediaWiki-ResourceLoader, GlobalCssJs

May 12 2020

Fomafix added a comment to T200280: Syntax highlighter disables Undo button in 2010 wikitext editor.
May 12 2020, 11:00 AM · Upstream, Browser-Support-Firefox, Browser-Support-Google-Chrome, MediaWiki-extensions-CodeMirror, WikiEditor

May 11 2020

Fomafix closed T87196: Search suggestion box keeps open when closing the link assistant via Esc as Resolved.

I also can't reproduce this problem on Firefox 75 anymore. The issue is probably fixed in Firefox.

May 11 2020, 2:15 PM · Browser-Support-Firefox, WikiEditor

May 4 2020

Fomafix closed T251682: Expand arrow of heading menu is misplaced on skin MonoBook as Resolved.
May 4 2020, 8:05 AM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), WikiEditor

May 2 2020

Fomafix created T251682: Expand arrow of heading menu is misplaced on skin MonoBook.
May 2 2020, 7:55 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), WikiEditor

Apr 27 2020

Ladsgroup awarded T63115: Remove 'setlang' query parameter feature from ULS a Love token.
Apr 27 2020, 5:30 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Language-Team (Language-2020-January-March), User-notice, Sustainability (MediaWiki-MultiDC), Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector
Lucas_Werkmeister_WMDE awarded T63115: Remove 'setlang' query parameter feature from ULS a Love token.
Apr 27 2020, 2:45 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Language-Team (Language-2020-January-March), User-notice, Sustainability (MediaWiki-MultiDC), Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector

Apr 21 2020

Fomafix added a comment to T248137: Ensure `#content`, `#footer` and `.portal` code occurrences are element agnostic.

The CSS selector #footer also matches to the heading created by the wikitext

== footer ==

This add strange styling to the heading. This is bad.

Apr 21 2020, 6:54 AM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Desktop Improvements, CSS, MonoBook, MediaWiki-General, Vector, Technical-Debt

Apr 20 2020

Fomafix added a comment to T210789: Table of contents' hidden state isn't kept after reload.

Is a cookie the right way to store the state? Isn't an user option a better way?

Apr 20 2020, 8:00 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Performance-Team, Regression, JavaScript, MediaWiki-Interface

Apr 13 2020

Fomafix added a comment to T33918: Expose action parameters in JavaScript (ViewAction diff, SpecialContributions target etc.) regardless of GET, POST or url encoding.

Can the support of ISO 8859-1 URL encoding dropped?

Apr 13 2020, 10:05 AM · JavaScript, MediaWiki-General

Apr 2 2020

Fomafix added a subtask for T248352: Move deprecated language codes from MediaWiki to WMF configuration: T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration.
Apr 2 2020, 9:24 AM · Language codes, Patch-For-Review, I18n, MediaWiki-Internationalization
Fomafix added a parent task for T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration: T248352: Move deprecated language codes from MediaWiki to WMF configuration.
Apr 2 2020, 9:23 AM · Language codes, MediaWiki-Internationalization, Language-Team, I18n

Mar 25 2020

Fomafix updated the task description for T248352: Move deprecated language codes from MediaWiki to WMF configuration.
Mar 25 2020, 10:49 AM · Language codes, Patch-For-Review, I18n, MediaWiki-Internationalization
Draceane awarded T181677: Implement syntax highlight for U+00A0 (no-break space, nbsp) a Burninate token.
Mar 25 2020, 7:37 AM · Patch-Needs-Improvement, MediaWiki-extensions-CodeMirror

Mar 24 2020

Fomafix renamed T248352: Move deprecated language codes from MediaWiki to WMF configuration from Move DEPRECATED_LANGUAGE_CODE_MAPPING from MediaWiki to WMF configuration to Move deprecated language codes from MediaWiki to WMF configuration.
Mar 24 2020, 7:41 PM · Language codes, Patch-For-Review, I18n, MediaWiki-Internationalization

Mar 23 2020

Fomafix created T248352: Move deprecated language codes from MediaWiki to WMF configuration.
Mar 23 2020, 8:43 PM · Language codes, Patch-For-Review, I18n, MediaWiki-Internationalization

Mar 15 2020

Fomafix added a comment to T105637: "TypeError: context is undefined" when searchSuggest.js is used on Wikidata.

Obviously $searchInput.data( 'suggestionsContext' ) is undefined in this situation.

Mar 15 2020, 8:40 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-Search, Wikidata, Discovery, JavaScript
Fomafix changed the subtype of T105637: "TypeError: context is undefined" when searchSuggest.js is used on Wikidata from "Task" to "Bug Report".

I can still reproduce the error message on Wikidata. Steps to reproduce:

  • Load a page in WIkidata.
  • Open JavaScript console and activate Preserve log.
  • Enter something in the search bar and press Enter.

In the JavaScript console occurs

  • TypeError: context is undefined (Firefox) or
  • Uncaught TypeError: Cannot read property 'config' of undefined (Chrome)

before the next page gets loaded.

Mar 15 2020, 7:20 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-Search, Wikidata, Discovery, JavaScript

Mar 12 2020

Fomafix updated subscribers of T247537: Regression: Border color of Vector action menu is black.
Mar 12 2020, 4:26 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, Vector
Fomafix created T247537: Regression: Border color of Vector action menu is black.
Mar 12 2020, 4:25 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Regression, Vector

Mar 5 2020

Fomafix updated the task description for T244108: Firefox makes a column break inside of list items on Special:AllPages.
Mar 5 2020, 9:10 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), MediaWiki-Special-pages, Browser-Support-Firefox

Mar 4 2020

Fomafix closed T234705: The TemplateParser do an unnecessary HTML entity encoding as Resolved.

The umlauts are no HTML entities anymore:

Mar 4 2020, 7:33 AM · MediaWiki-HTML-Templating

Feb 29 2020

Fomafix created T246550: Icons of the toolbar overlaps with the heading pull down menu.
Feb 29 2020, 9:22 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), WikiEditor

Feb 21 2020

Fomafix added a comment to T232932: User content can redirect the logout button to different URL (CVE-2020-10959).

I guess there is no caching problem on deployment. And even when the new JavaScript is delivered to the browsers before the new HTML, then the fallback way of the logout button still works.

Feb 21 2020, 5:22 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Feb 14 2020

Fomafix added a comment to T232932: User content can redirect the logout button to different URL (CVE-2020-10959).

Can there a caching issue happen? The old selector also matches to the new HTML but the new selector doesn't match to the old HTML. If the deployment can't ensure that always a new HTML is loaded when the new JavaScript is delivered to the browsers then this patch have to split up.

Feb 14 2020, 5:23 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Feb 12 2020

Fomafix added a comment to T232932: User content can redirect the logout button to different URL (CVE-2020-10959).

mitigates the second vulnerability. Just the trailing whitespace in BaseTemplate.php is wrong.

Feb 12 2020, 5:24 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface
Fomafix added a comment to T232932: User content can redirect the logout button to different URL (CVE-2020-10959).

This is only the query part. The logout button doesn't have the attribute data-mw="interface" yet.

Feb 12 2020, 7:33 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Feb 9 2020

Fomafix created T244659: config-error-box overlaps with config-page-list.
Feb 9 2020, 10:24 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MediaWiki-Installer

Feb 7 2020

Fomafix updated the task description for T244108: Firefox makes a column break inside of list items on Special:AllPages.
Feb 7 2020, 1:09 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), MediaWiki-Special-pages, Browser-Support-Firefox

Feb 3 2020

Fomafix created T244108: Firefox makes a column break inside of list items on Special:AllPages.
Feb 3 2020, 6:11 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), MediaWiki-Special-pages, Browser-Support-Firefox

Jan 23 2020

Fomafix committed rEDKMd499f6c4f1b1: Move styles to a separate style module (authored by Fomafix).
Move styles to a separate style module
Jan 23 2020, 2:21 PM

Jan 21 2020

Fomafix committed rEDKM8a56e7239380: Add PHP type hints (authored by Fomafix).
Add PHP type hints
Jan 21 2020, 5:54 AM

Jan 20 2020

Fomafix committed rEDKM384a6d51cc71: Wait for document ready before query DOM (authored by Fomafix).
Wait for document ready before query DOM
Jan 20 2020, 10:11 PM
Fomafix committed rEDKM28337fb6b35a: Use document.documentElement instead of 'html' as jQuery selector (authored by Fomafix).
Use document.documentElement instead of 'html' as jQuery selector
Jan 20 2020, 10:11 PM

Jan 13 2020

Fomafix claimed T233677: Avoid eager loading of mediawiki.searchSuggest scripts and dependencies.
Jan 13 2020, 5:29 PM · Performance-Team-publish, Performance-Team (Radar), MediaWiki-Search, MediaWiki-Interface

Dec 20 2019

Krinkle awarded T63115: Remove 'setlang' query parameter feature from ULS a Orange Medal token.
Dec 20 2019, 3:38 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Language-Team (Language-2020-January-March), User-notice, Sustainability (MediaWiki-MultiDC), Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector

Dec 19 2019

Fomafix added a comment to T63115: Remove 'setlang' query parameter feature from ULS.
  • The dialog doesn't have a support for keyboard navigation.
  • A click on Don't change removes the URL parameter setlang. But ...
    • ... on some links like Printable version, Login, Mobile view the URL parameter is still there and on a click the dialog comes again.
    • ... on history back the URL parameter setlang is there again. (Fixed by https://gerrit.wikimedia.org/r/559573)
  • When the value of the URL parameter setlang is equal to the current user interface language then there is no dialog but the URL parameter setlang gets not removed. On a language change with the ULS language changer the new page is loaded with the old setlang value and the dialog wants to switch back to the old language. I think it is better to remove the URL parameter setlang in this case. (Fixed by https://gerrit.wikimedia.org/r/559575)
  • The scroll position is wrong when there is an URL with a fragment like Special:Version?setlang=de#Installed_software (Fixed by https://gerrit.wikimedia.org/r/559775)
Dec 19 2019, 7:07 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Language-Team (Language-2020-January-March), User-notice, Sustainability (MediaWiki-MultiDC), Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector

Dec 3 2019

Fomafix closed T239718: The Vector menu expand indicator doesn't flip as Resolved.
Dec 3 2019, 6:24 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Vector, Regression
Fomafix claimed T239718: The Vector menu expand indicator doesn't flip.
Dec 3 2019, 4:49 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Vector, Regression
Fomafix added a comment to T239718: The Vector menu expand indicator doesn't flip.

Caused by rSVEC481c90798e53: Make extra `<span>` in Vector tabs optional.

Dec 3 2019, 4:39 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Vector, Regression
Fomafix added a comment to T239718: The Vector menu expand indicator doesn't flip.

Yes, a click keeps the menu open and the arrow is the indicator for this. The CSS style is still there

.vectorMenuCheckbox:checked + h3 span:after {
	transform: scaleY( -1 );
}

but is doesn't work anymore.

Dec 3 2019, 4:32 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Vector, Regression
Fomafix created T239718: The Vector menu expand indicator doesn't flip.
Dec 3 2019, 3:30 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Vector, Regression

Nov 19 2019

Fomafix added a comment to T154449: The generated redirect after move of a JavaScript page is missing on Special:WhatLinksHere.

https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-purge.js&action=info shows

Nov 19 2019, 6:55 AM · JavaScript, MediaWiki-Redirects

Nov 18 2019

Fomafix added a comment to T154449: The generated redirect after move of a JavaScript page is missing on Special:WhatLinksHere.

The the current content of https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-purge.js&redirect=no is

/* #REDIRECT */mw.loader.load("//www.wikidata.org/w/index.php?title=MediaWiki:Gadget-purgeTab.js\u0026action=raw\u0026ctype=text/javascript");

Would just inserting [[MediaWiki:Gadget-purgeTab.js]] somewhere solve the problem? I suggest to add this like

/* #REDIRECT [[MediaWiki:Gadget-purgeTab.js]] */mw.loader.load("//www.wikidata.org/w/index.php?title=MediaWiki:Gadget-purgeTab.js\u0026action=raw\u0026ctype=text/javascript");

This requires an update of JavaScriptContent::getRedirectTarget() with a backward compatibility.

Nov 18 2019, 12:14 PM · JavaScript, MediaWiki-Redirects

Oct 10 2019

Fomafix updated the task description for T149837: Consider using 'Cache-Control: immutable' on versioned/long-cache load.php responses.
Oct 10 2019, 9:46 AM · EngProd-Virtual-Hackathon, Performance-Team, MediaWiki-ResourceLoader

Oct 8 2019

Fomafix updated the task description for T126744: Sorting of month names in tables should depend on page content language.
Oct 8 2019, 8:26 PM · MediaWiki-Interface (jQuery-Tablesorter), Patch-For-Review

Oct 5 2019

Fomafix created T234705: The TemplateParser do an unnecessary HTML entity encoding.
Oct 5 2019, 5:36 AM · MediaWiki-HTML-Templating

Sep 27 2019

Fomafix committed rEEJB33a1af6e243d: Call getDeprecationInformation with $context (authored by Fomafix).
Call getDeprecationInformation with $context
Sep 27 2019, 9:26 PM

Sep 26 2019

Fomafix added a comment to T232932: User content can redirect the logout button to different URL (CVE-2020-10959).

The click handler for the logout button was introduced in rMW8f033911030d included in REL1_34. This has two vulnerabilities by user content:

  1. The target of the redirect of the logout button can manipulated. This is fixed in rMWd4a552e65bdf included in REL1_34. A backport to older releases is not needed.
  2. The user content can create an own logout button and do click catching. This is not fixed yet. This can be done by protecting the link with [data-mw="interface"].
Sep 26 2019, 7:31 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Sep 17 2019

Fomafix updated the task description for T232932: User content can redirect the logout button to different URL (CVE-2020-10959).
Sep 17 2019, 9:46 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Sep 14 2019

Fomafix updated the task description for T232932: User content can redirect the logout button to different URL (CVE-2020-10959).
Sep 14 2019, 7:47 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface
Fomafix created T232932: User content can redirect the logout button to different URL (CVE-2020-10959).
Sep 14 2019, 7:44 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Security-Team, Security, MediaWiki-Interface

Sep 12 2019

Fomafix renamed T229311: Avoid unnecessary encoding of '<', '>' and '&' in output of load.php from Remove unnecessary escaping of '<', '>' and '&' in styles and messages to Avoid unnecessary encoding of '<', '>' and '&' in output of load.php.
Sep 12 2019, 11:18 AM · Performance-Team, MediaWiki-ResourceLoader

Sep 9 2019

Fomafix committed rEOAU0198f80f6ab3: Apply coding conventions for JavaScript (authored by Fomafix).
Apply coding conventions for JavaScript
Sep 9 2019, 7:40 PM
Fomafix added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

Then this is a good chance to fix this, too.

Sep 9 2019, 9:27 AM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Fomafix added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

It is bad to have message keys that doesn't match to the content.

Sep 9 2019, 8:52 AM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Fomafix added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

https://gerrit.wikimedia.org/r/179450 is not reverted and the messages in the developer module mediawiki.inspect report KiB instead of KB or kB.

Sep 9 2019, 8:02 AM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General

Aug 17 2019

Fomafix renamed T230382: Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia from Remove aliases `minnan` and `zh-cfr` for `nan`/`zh-min-nan` to Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia.
Aug 17 2019, 7:34 PM · Patch-For-Review, Traffic, Operations, Wikimedia-Apache-configuration, DNS

Aug 12 2019

Fomafix closed T230387: Special:SiteMatrix shows the Cantonese Wiktionary as missing as Invalid.

On https://en.wikipedia.org/wiki/Special:SiteMatrix the entry for the Cantonese Wiktionary is in the line yue. Is is not missing. Cantonese is just twice in the list.

Aug 12 2019, 9:45 PM · SiteMatrix
Fomafix created T230387: Special:SiteMatrix shows the Cantonese Wiktionary as missing.
Aug 12 2019, 9:35 PM · SiteMatrix
Fomafix created T230382: Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia.
Aug 12 2019, 8:33 PM · Patch-For-Review, Traffic, Operations, Wikimedia-Apache-configuration, DNS
Fomafix updated the task description for T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Aug 12 2019, 11:55 AM · Wikimedia-Interwiki-links
Fomafix updated the task description for T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Aug 12 2019, 10:28 AM · Wikimedia-Interwiki-links
Fomafix reopened T167513: Redirect lzh.wikipedia to zh-classical.wikipedia, a subtask of T30443: Rename zh-classical -> lzh (invalid lang tag format), as Open.
Aug 12 2019, 7:53 AM · Wikidata-Query-Service, Wikidata, Wiki-Setup (Rename), Community-consensus-needed, Wikimedia-Language-setup
Fomafix reopened T167513: Redirect lzh.wikipedia to zh-classical.wikipedia as "Open".

lzh.wikipedia.org works:

$ curl https://lzh.wikipedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="https://zh-classical.wikipedia.org/">here</a>.</p>
</body></html>
Aug 12 2019, 7:53 AM · Patch-For-Review, Traffic, Wikimedia-Apache-configuration, Operations, DNS

Aug 9 2019

Fomafix created T230228: Replace `[[cmn:` by `[[:cmn:` in the wikitext.
Aug 9 2019, 6:46 PM · Wikimedia-Interwiki-links
Fomafix created T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Aug 9 2019, 6:35 PM · Wikimedia-Interwiki-links

Aug 4 2019

Fomafix updated the task description for T31186: Rename Võro Wikipedia, fiu-vro -> vro.
Aug 4 2019, 7:37 PM · Patch-For-Review, Wiki-Setup (Rename), Wikimedia-Language-setup

Aug 1 2019

Fomafix renamed T229311: Avoid unnecessary encoding of '<', '>' and '&' in output of load.php from Remove unnecessary escaping of '<', '> and '&' in styles and messages to Remove unnecessary escaping of '<', '>' and '&' in styles and messages.
Aug 1 2019, 6:29 PM · Performance-Team, MediaWiki-ResourceLoader
Fomafix renamed T229311: Avoid unnecessary encoding of '<', '>' and '&' in output of load.php from Remove unnecessary escaping in styles to Remove unnecessary escaping of '<', '> and '&' in styles and messages.
Aug 1 2019, 6:28 PM · Performance-Team, MediaWiki-ResourceLoader
Fomafix renamed T229301: Remove unnecessary escaping of UTF-8 characters in messages from Remove unnecessary escaping in messages to Remove unnecessary escaping of UTF-8 characters in messages.
Aug 1 2019, 6:28 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Performance-Team, MediaWiki-ResourceLoader

Jul 30 2019

Fomafix created T229311: Avoid unnecessary encoding of '<', '>' and '&' in output of load.php.
Jul 30 2019, 8:43 AM · Performance-Team, MediaWiki-ResourceLoader
Fomafix created T229301: Remove unnecessary escaping of UTF-8 characters in messages.
Jul 30 2019, 5:27 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Performance-Team, MediaWiki-ResourceLoader

Jul 25 2019

Fomafix renamed T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn from Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl to Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.
Jul 25 2019, 5:37 AM · Language codes, Patch-For-Review, MediaWiki-Internationalization, I18n

Jul 23 2019

Fomafix committed rEEJBffcb30c7b82c: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn (authored by Fomafix).
Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn
Jul 23 2019, 7:01 AM

Jul 18 2019

Fomafix committed rEEJB34a0bc7d62c5: Remove arrays around the strings in languageScripts (authored by Fomafix).
Remove arrays around the strings in languageScripts
Jul 18 2019, 7:00 AM

Jul 13 2019

Fomafix committed rEEJB2118de7f7ba5: Fix languageScripts mapping from language code to file names (authored by Fomafix).
Fix languageScripts mapping from language code to file names
Jul 13 2019, 7:30 PM

Jul 11 2019

Fomafix added a comment to T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration.

An alternative is to drop the mapping from als to gsw completely.

Jul 11 2019, 7:18 PM · Language codes, MediaWiki-Internationalization, Language-Team, I18n
Fomafix created T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration.
Jul 11 2019, 7:17 PM · Language codes, MediaWiki-Internationalization, Language-Team, I18n

Jul 4 2019

Fomafix committed rEGTO345954e83098: Simplify by using mw.util.getUrl (authored by Fomafix).
Simplify by using mw.util.getUrl
Jul 4 2019, 7:46 PM
Fomafix added a comment to T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.

No of course not, as the website literally predates the new fangled standard (2009) as well as any sort of 'process' being in place to begin with.

BCP 47 is much older than 2009. sr-ec has even with RFC 1766 from 1995 the meaning Serbian in Ecuador.

Jul 4 2019, 2:36 PM · Language codes, Patch-For-Review, MediaWiki-Internationalization, I18n
Fomafix committed rSANIb8700271fb26: Remove htmlspecialchars where HTML escaping is already present (authored by Fomafix).
Remove htmlspecialchars where HTML escaping is already present
Jul 4 2019, 2:00 PM
Fomafix added a comment to T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.
  1. I see no community discussion approving this change across multiple wikis in the task description. I only see a (partial) technical discussion above

Was there a community discussion for introducing the not BCP 47 conform language codes sr-ec and sr-el instead of the BCP 47 conform language codes sr-cyrl and sr-latn? The standard BCP 47 is not made by the community.

Jul 4 2019, 1:56 PM · Language codes, Patch-For-Review, MediaWiki-Internationalization, I18n

Jul 3 2019

Fomafix committed rSEXAMPLE081c41ee7f07: Remove htmlspecialchars where HTML escaping is already present (authored by Fomafix).
Remove htmlspecialchars where HTML escaping is already present
Jul 3 2019, 7:10 AM

Jun 24 2019

Fomafix claimed T225845: Remove support for automatic 'dir' parameter inference for load.php urls .
Jun 24 2019, 12:05 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 18 2019

Fomafix added a comment to T68598: mw.loader state of module stuck at "loading" if request was aborted.

Maybe the online and offline events are also interesting in this context.

Jun 18 2019, 3:51 PM · Performance-Team (Radar), patch-welcome, JavaScript, MediaWiki-ResourceLoader
Fomafix added a comment to T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.

This change is similar to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

Jun 18 2019, 10:56 AM · Performance-Team, MediaWiki-ResourceLoader
Fomafix added a subtask for T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor: T225899: Set the default parameter for load.php in client-side by a parameter in server-side.
Jun 18 2019, 10:55 AM · Performance-Team, MediaWiki-ResourceLoader
Fomafix added a parent task for T225899: Set the default parameter for load.php in client-side by a parameter in server-side: T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.
Jun 18 2019, 10:55 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Performance-Team (Radar), MediaWiki-ResourceLoader
Fomafix created T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.
Jun 18 2019, 7:55 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 16 2019

Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

I like this one most. It would be very efficient and reduces the amount of information and code required on the client. You can use the existing $VARS that StartupModule and mediawiki.js make use of to very efficiently export these for the current context. I think you can replace reqBase with a $VARS.something assignment to make this work. E.g. skin/lang always, and debug/dir only as needed.

Jun 16 2019, 8:37 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader
Fomafix created T225899: Set the default parameter for load.php in client-side by a parameter in server-side.
Jun 16 2019, 7:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Performance-Team (Radar), MediaWiki-ResourceLoader
Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

A similar dependency is the call of Language::getFallbacksFor. This can avoided in ResourceLoader by transmitting always the whole fallback language chain instead of only the user interface language. By the way this allows an user individual fallback chain.

Jun 16 2019, 6:27 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 15 2019

Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

T181684: Add ability to get language directionality from mw.language also requires the language directionality of a language in JavaScript.

Jun 15 2019, 8:23 AM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader
Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

The server-side part is easy.
The client-side part requires the information of the direction on JavaScript side. I see four possibilities to get this information:

  • Add an addition JavaScript config variable wgUserDirection or wgUserLanguageDirection.
  • Get the information from the existing JavaScript config variable wgUserLanguage via a mapping table. ULS already contains such a table. A complete table is big. Maybe the table can just filled with the used language codes wgUserLanguage and maybe other languages that are used.
  • Get the information from the browser.
  • Add a new JavaScript config variable specific for resource load containing all URL parameters that just reflected to the server. Default values like dir=ltr or debug=false can be omitted in this variable.
Jun 15 2019, 8:04 AM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 12 2019

Restricted Application added a project to T225589: Load search suggestion for strings typed before initializing JavaScript: Discovery-Search.
Jun 12 2019, 7:37 AM · Discovery-Search, OOUI, MediaWiki-Search
Fomafix added a comment to T224952: On some special pages the search suggestions get shown on browser history back.

I updated the description to match the change. Only the search suggestion field on browser history back is a regression.

Jun 12 2019, 6:00 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search