Page MenuHomePhabricator

Fomafix (Fomafix)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2014, 8:51 AM (235 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Fomafix [ Global Accounts ]

Recent Activity

Sat, Apr 20

Fomafix triaged T221439: Static mapframe not clickable in 1.34.0-wmf.1 as Unbreak Now! priority.
Sat, Apr 20, 8:36 AM · Regression, Patch-For-Review, Maps (Kartographer)

Fri, Apr 19

Fomafix created T221443: JavaScript click hander for watch/unwatch pages on the watchlist is not attached for items loaded from rcfilters.
Fri, Apr 19, 10:14 AM · Growth-Team, MediaWiki-Watchlist
Fomafix claimed T221439: Static mapframe not clickable in 1.34.0-wmf.1 .
Fri, Apr 19, 9:04 AM · Regression, Patch-For-Review, Maps (Kartographer)

Thu, Apr 18

Fomafix added a comment to T63115: Drop URL parameter setlang.

T25227 requires a token for logout.

Thu, Apr 18, 5:07 PM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector

Wed, Apr 17

Restricted Application added a project to T146349: The logout button and the mobile view button contains the markasread parameter: Growth-Team.

The problem still exist. https://www.wikidata.org/wiki/Special:Notifications contains links like https://www.wikidata.org/wiki/Q3938?markasread=123456789&markasreadwiki=wikidatawiki

Wed, Apr 17, 7:01 PM · Growth-Team, Collaboration-Team-Triage, Notifications

Tue, Apr 9

Fomafix claimed T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

https://gerrit.wikimedia.org/r/502396 is merged. Please test again when it is deployed.

Tue, Apr 9, 8:13 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

I found the reason for the race condition:

Tue, Apr 9, 5:22 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

Fixed in https://de.wikivoyage.org/w/index.php?title=MediaWiki:ListingEditor.js&diff=1195136&oldid=1195058

Tue, Apr 9, 2:14 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

In https://de.wikivoyage.org/wiki/MediaWiki:ListingEditor.js a dependency on module mediawiki.api is missing because it uses mw.Api(). I identified this with a throttled network connection in Firefox.

Tue, Apr 9, 1:30 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix created T220489: Use `data-mw="interface"` instead of `mw-data="interface"`.
Tue, Apr 9, 10:46 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Maps (Kartographer)
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

With https://gerrit.wikimedia.org/r/502396 I fix an failure in Maps (Kartographer) which causes the exception in T220308#5091821.

Tue, Apr 9, 10:32 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix closed T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js as Invalid.

I just got also the error message above. This error come from extension Maps (Kartographer). As visible result the TocTree gets not executed. But this is not a fault of TocTree.

Tue, Apr 9, 5:07 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

There are some missing dependencies in https://de.wikivoyage.org/ that lead to race conditions. But the extension TocTree is not the root cause.

Tue, Apr 9, 4:57 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree

Mon, Apr 8

Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

TocTree is correct as far as I see. Maybe there is a race-condition somewhere else.

Mon, Apr 8, 7:15 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree

Thu, Apr 4

Fomafix added a comment to T57876: Add Hakka (hak) to LanguageConverter.

I just rebased https://gerrit.wikimedia.org/r/116691 and applied the changes from similar files.

Thu, Apr 4, 7:23 AM · Patch-For-Review, I18n, MediaWiki-Language-converter
Fomafix removed a project from T35871: Port mediawiki.legacy.protect to modern JavaScript: Patch-For-Review.
Thu, Apr 4, 7:02 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix closed T215737: The included enhanced RecentChanges has a different collapsible toggle button as Resolved.
Thu, Apr 4, 5:56 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes

Wed, Apr 3

Fomafix closed T35871: Port mediawiki.legacy.protect to modern JavaScript as Resolved.
Wed, Apr 3, 8:26 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix changed the subtype of T207981: uselang=/ leads to unhandled exception in installer from "Task" to "Bug Report".
Wed, Apr 3, 5:16 AM · Patch-For-Review, MediaWiki-Installer

Tue, Apr 2

Fomafix placed T35871: Port mediawiki.legacy.protect to modern JavaScript up for grabs.
Tue, Apr 2, 8:22 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix reopened T35871: Port mediawiki.legacy.protect to modern JavaScript as "Open".

Reopen: The JavaScript global variable window.ProtectionForm still gets assigned.

Tue, Apr 2, 8:22 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript

Sun, Mar 31

Fomafix added a comment to T36514: Language and direction of first heading should depend on page content language instead of user interface language.

The browser and especially the operating systems have a bad support for the Explicit Directional Isolate Formatting Characters (LRI, RLI, FSI, PDI) introduced in Unicode 6.3:

Sun, Mar 31, 12:50 PM · Patch-For-Review, RTL, I18n, MediaWiki-Internationalization

Sat, Mar 30

Fomafix closed T219359: lang attribute of page title is empty as Resolved.

@PerfektesChaos I support you comments, but this task is the wrong place. This task is just for restoring the previous behavior after making a typo in the refactoring. This is solved and therefor this task is solved.

Sat, Mar 30, 4:10 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Regression, User-Michael, Vector, Wikidata-Campsite, Accessibility, Wikidata

Wed, Mar 27

Fomafix added a comment to T219340: Remove wgMonthNames and wgMonthNamesShort from mw.config.

There are some gadgets and user scripts that depend on wgMonthNames.

Wed, Mar 27, 2:59 PM · Readers-Web-Backlog, patch-welcome, Performance-Team, MediaWiki-Interface, Technical-Debt (Deprecation)

Mon, Mar 25

Fomafix created T219189: The DateInputWidget does not close the date selector after a tab.
Mon, Mar 25, 5:19 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), MediaWiki-Special-pages

Mar 21 2019

Mill <mill@mail.com> committed rESCC5d021c959d41: 6baaaaaaaaaaaa (authored by Fomafix).
6baaaaaaaaaaaa
Mar 21 2019, 12:30 AM
Fomafix committed rESCC14fd48890b44: Integrate module 'ext.TwoColConflict.Inline.BaseVersionSelectorCss' (authored by Fomafix).
Integrate module 'ext.TwoColConflict.Inline.BaseVersionSelectorCss'
Mar 21 2019, 12:29 AM

Mar 14 2019

Fomafix changed the subtype of T213767: HTMLSelectField doesn't use the `default` value when an invalid value is submitted from "Task" to "Bug Report".
Mar 14 2019, 8:35 PM · MediaWiki-HTMLForm

Mar 8 2019

Fomafix added a comment to T213767: HTMLSelectField doesn't use the `default` value when an invalid value is submitted.

On Special:AllMessages the parameter limit has the same problem. The drop down menu has values for 20, 50, 100, 250, 500 and 5000. The default is 50. When using a different value in the URL parameter limit like limit=2 the query on the system messages get correctly limited to 2 entries. In case of a value which is not in the list of the drop down menu the preselected value is always 20 because 20 is the first entry in the list. Expected value is 50 because this is the default value when the parameter limit is not present.

Mar 8 2019, 10:23 AM · MediaWiki-HTMLForm

Mar 4 2019

Fomafix added a comment to T89561: Implement a CSS preprocessor for direction flipping based on the content direction.

The selector .mw-editsection is a bad example because it is (mostly) used in content. I currently can not find a usage on a special page. But I'm sure there is one.

Mar 4 2019, 6:48 AM · Performance-Team, MediaWiki-ResourceLoader

Mar 3 2019

Fomafix added a comment to T89561: Implement a CSS preprocessor for direction flipping based on the content direction.

It is intended to have .mw-editsection in the user interface part and in the content part.

Mar 3 2019, 9:32 PM · Performance-Team, MediaWiki-ResourceLoader
Fomafix updated the task description for T89561: Implement a CSS preprocessor for direction flipping based on the content direction.
Mar 3 2019, 9:31 PM · Performance-Team, MediaWiki-ResourceLoader

Mar 2 2019

Fomafix changed the subtype of T105214: Preview shows wikitext instead of page title on test.wikipedia.org from "Task" to "Bug Report".
Mar 2 2019, 2:15 PM · JavaScript, MediaWiki-Page-editing
Fomafix changed the subtype of T151524: Maps fast preview is broken on 2nd attempt from "Task" to "Bug Report".
Mar 2 2019, 2:14 PM · Maps (Kartographer)
Fomafix added a comment to T105214: Preview shows wikitext instead of page title on test.wikipedia.org.

https://test.wikipedia.org/wiki/MediaWiki:Editing got deleted so it is no longer reproducible on this project.

Mar 2 2019, 2:10 PM · JavaScript, MediaWiki-Page-editing
Fomafix changed the subtype of T180342: Single quotes in selflinks activates italic/bold from "Task" to "Bug Report".
Mar 2 2019, 11:54 AM · MediaWiki-Parser
Fomafix changed the subtype of T185904: Special:Upload fails on ":w:" as destination filename from "Task" to "Bug Report".
Mar 2 2019, 11:52 AM · Multimedia, MediaWiki-Uploading, MediaWiki-API
Fomafix changed the subtype of T208145: api.php?uselang=sr shows language converter syntax in the HTML from "Task" to "Bug Report".
Mar 2 2019, 11:04 AM · MediaWiki-API, Patch-For-Review, MediaWiki-Language-converter, MediaWiki-Parser
Fomafix updated the task description for T212276: Suggestions of input field on Special:Categories strips leading "Category:" from category name.
Mar 2 2019, 10:26 AM · MediaWiki-Special-pages
Fomafix changed the subtype of T212276: Suggestions of input field on Special:Categories strips leading "Category:" from category name from "Task" to "Bug Report".
Mar 2 2019, 10:21 AM · MediaWiki-Special-pages

Feb 28 2019

Fomafix changed the subtype of T213479: On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa' from "Task" to "Bug Report".
Feb 28 2019, 7:58 AM · Patch-For-Review, Regression, MediaWiki-Special-pages
Fomafix changed the subtype of T214863: ULS causes JQMIGRATE: jQuery.fn.offset() requires a valid DOM element from "Task" to "Bug Report".
Feb 28 2019, 7:57 AM · UniversalLanguageSelector
Fomafix changed the subtype of T187866: The language code 'no' is ignored in Accept-Language HTTP header from "Task" to "Bug Report".
Feb 28 2019, 7:50 AM · MediaWiki-Installer, Patch-For-Review, I18n, UniversalLanguageSelector
Fomafix changed the subtype of T215737: The included enhanced RecentChanges has a different collapsible toggle button from "Task" to "Bug Report".
Feb 28 2019, 7:43 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes

Feb 23 2019

Fomafix closed T216889: MediaWiki Extension WikiEditor README File typo as Resolved.
Feb 23 2019, 6:31 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Documentation, WikiEditor

Feb 18 2019

Fomafix added a comment to T177509: No in-browser spell checking in Firefox when "Wikitext syntax highlighting" beta feature is enabled with the 2010 wikitext editor.

Firefox 63 is affected by the accesskey problem. Firefox 64 is untested. Therefor I disabled the spellchecker for Firefox < 65 in PS5.

Feb 18 2019, 8:26 PM · Patch-For-Review, Browser-Support-Firefox, MediaWiki-extensions-CodeMirror

Feb 17 2019

Fomafix added a comment to T177509: No in-browser spell checking in Firefox when "Wikitext syntax highlighting" beta feature is enabled with the 2010 wikitext editor.

This means, that disabling of the spellchecking in Firefox is not needed anymore. https://gerrit.wikimedia.org/r/421349 removes the disabling of the spellchecking and can now merged. Maybe a version check of the exact Firefox version should remain to prevent that older Firefox versions accidentally insert accesskey characters into the content when the accesskey is used.

Feb 17 2019, 12:00 PM · Patch-For-Review, Browser-Support-Firefox, MediaWiki-extensions-CodeMirror

Feb 16 2019

Fomafix added a comment to T188607: Syntax highlighting disables middle button copy/paste in Firefox.

I can confirm a different behavior with CodeMirror and without CodeMirror on WikiText editor 2010 on Linux.

Feb 16 2019, 3:28 PM · Browser-Support-Firefox, MediaWiki-extensions-CodeMirror
Fomafix added a comment to T177509: No in-browser spell checking in Firefox when "Wikitext syntax highlighting" beta feature is enabled with the 2010 wikitext editor.

On Firefox 65 the problem with the accesskeys does not exist anymore. Mozilla probably fixed this problem in a version between 59 and 65.

Feb 16 2019, 1:14 PM · Patch-For-Review, Browser-Support-Firefox, MediaWiki-extensions-CodeMirror

Feb 14 2019

Fomafix claimed T210789: Table of contents' hidden state isn't kept after reload.
Feb 14 2019, 9:25 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface

Feb 13 2019

Fomafix claimed T172618: Use CSS instead of JavaScript for collapsing on enhanced changes list.
Feb 13 2019, 1:39 PM · Patch-For-Review, Growth-Team, CSS, Performance, MediaWiki-Watchlist, MediaWiki-Recent-changes

Feb 12 2019

Fomafix added a comment to T215737: The included enhanced RecentChanges has a different collapsible toggle button.

https://gerrit.wikimedia.org/r/489485 fixes the collapsing toggle button.

Feb 12 2019, 1:25 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes
Fomafix updated the task description for T215737: The included enhanced RecentChanges has a different collapsible toggle button.
Feb 12 2019, 1:21 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes

Feb 10 2019

Fomafix created T215737: The included enhanced RecentChanges has a different collapsible toggle button.
Feb 10 2019, 8:12 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes
Restricted Application added a project to T172618: Use CSS instead of JavaScript for collapsing on enhanced changes list: Growth-Team.

As in, you have the button, but it doesn't work yet ?

Feb 10 2019, 3:50 PM · Patch-For-Review, Growth-Team, CSS, Performance, MediaWiki-Watchlist, MediaWiki-Recent-changes

Feb 8 2019

Fomafix added a comment to T18691: RFC: Section headings should have a clickable anchor.

Please carefully test cases like:

[[File:Foo.png|thumb|left|Left floating object]]
== Heading ==
Feb 8 2019, 12:12 PM · Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Feb 6 2019

Fomafix added a comment to T184792: Toggle icons don't match in some fonts.

The shape and the size of the three triangles depends on the font. Maybe it is better to use just one symbol and rotate it via CSS.

Feb 6 2019, 11:43 AM · Patch-For-Review, MediaWiki-extensions-CategoryTree
Fomafix claimed T184792: Toggle icons don't match in some fonts.
Feb 6 2019, 11:39 AM · Patch-For-Review, MediaWiki-extensions-CategoryTree

Jan 30 2019

Fomafix added a comment to T163740: Languages sidebar portlet visibly changes label (otherlanguages > uls-plang-title-languages).

As far as I see there is no fitting hook on server-side to do this manipulation there.

Jan 30 2019, 6:14 PM · Language-Team, Performance-Team (Radar), UniversalLanguageSelector

Jan 28 2019

Fomafix created T214863: ULS causes JQMIGRATE: jQuery.fn.offset() requires a valid DOM element.
Jan 28 2019, 6:35 PM · UniversalLanguageSelector

Jan 23 2019

Fomafix closed T212820: MediaWiki API help page loads module 'ext.categoryTree' although there no sidebar as Resolved.
Jan 23 2019, 12:54 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MediaWiki-extensions-CategoryTree

Jan 11 2019

Fomafix removed a project from T211650: Use BCP 47 conform language codes for the HTML attribute hreflang: Patch-For-Review.

Verified with https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.wikidata.org%2Fw%2Findex.php%3Ftitle%3DQ5296%26diff%3D807351493%26oldid%3D272854

Jan 11 2019, 8:26 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseView, Wikidata

Jan 10 2019

Fomafix renamed T213479: On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa' from The URL lang on Special:AllMessages with empty, invalid or unknown value selects language 'aa' to On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa'.
Jan 10 2019, 9:09 PM · Patch-For-Review, Regression, MediaWiki-Special-pages
Fomafix created T213479: On Special:AllMessages the URL parameter lang with empty, invalid or unknown value selects language 'aa'.
Jan 10 2019, 8:34 PM · Patch-For-Review, Regression, MediaWiki-Special-pages

Jan 2 2019

Fomafix created T212820: MediaWiki API help page loads module 'ext.categoryTree' although there no sidebar.
Jan 2 2019, 11:39 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MediaWiki-extensions-CategoryTree
Fomafix closed T212752: MediaWiki API help page loads module 'mediawiki.searchSuggest' although there no search field as Resolved.
Jan 2 2019, 11:11 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MediaWiki-Interface, Performance-Team

Jan 1 2019

Fomafix created T212752: MediaWiki API help page loads module 'mediawiki.searchSuggest' although there no search field.
Jan 1 2019, 11:58 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MediaWiki-Interface, Performance-Team
Fomafix removed a project from T195053: Reduce page jumps in table of contents: Patch-For-Review.
Jan 1 2019, 5:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Performance-Team (Radar), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board-Old, CSS, JavaScript, MediaWiki-Interface

Dec 29 2018

Fomafix closed T211384: Special:ReplaceText generates Error: Widget not found: searchText in JavaScript console as Resolved.
Dec 29 2018, 7:28 AM · MediaWiki-extensions-ReplaceText

Dec 22 2018

Fomafix claimed T211384: Special:ReplaceText generates Error: Widget not found: searchText in JavaScript console.
Dec 22 2018, 6:33 PM · MediaWiki-extensions-ReplaceText

Dec 21 2018

Fomafix updated the task description for T44296: page history shows unreviewed revisions, reversions in wrong order.
Dec 21 2018, 8:55 AM · MediaWiki-History-and-Diffs

Dec 19 2018

Fomafix added a comment to T211650: Use BCP 47 conform language codes for the HTML attribute hreflang.

Actual report from HTML Validator before deployment:

Dec 19 2018, 5:18 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseView, Wikidata
Fomafix created T212276: Suggestions of input field on Special:Categories strips leading "Category:" from category name.
Dec 19 2018, 6:26 AM · MediaWiki-Special-pages
Fomafix closed T171767: Mobile Frontend support as Resolved.
Dec 19 2018, 5:21 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), MediaWiki-extensions-CategoryTree

Dec 16 2018

Fomafix created T212086: Special:ExpandTemplates shows edit section buttons in preview.
Dec 16 2018, 1:47 PM · MediaWiki-Special-pages

Dec 15 2018

Fomafix merged T107409: CategoryTree in sidebar does not display drill-down into T171778: Fix sidebar tree support.
Dec 15 2018, 11:00 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Performance-Team, MediaWiki-extensions-CategoryTree
Fomafix merged task T107409: CategoryTree in sidebar does not display drill-down into T171778: Fix sidebar tree support.
Dec 15 2018, 11:00 PM · MediaWiki-extensions-CategoryTree
Fomafix created T212059: Special:ExpandTemplates does not load modules for CategoryTree.
Dec 15 2018, 10:56 PM · MediaWiki-Special-pages, MediaWiki-extensions-CategoryTree

Dec 11 2018

Fomafix created T211650: Use BCP 47 conform language codes for the HTML attribute hreflang.
Dec 11 2018, 6:45 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseView, Wikidata

Dec 9 2018

Fomafix committed rESCC8e017a68bbdd: Add missing dependency on core module 'user.options' (authored by Fomafix).
Add missing dependency on core module 'user.options'
Dec 9 2018, 1:34 PM

Dec 6 2018

Fomafix created T211384: Special:ReplaceText generates Error: Widget not found: searchText in JavaScript console.
Dec 6 2018, 9:54 PM · MediaWiki-extensions-ReplaceText

Dec 3 2018

Fomafix added a comment to T210851: Spacing between diff and pipe separator is double what it should be in Special:Contributions.

The some local messages replace the first space by &nbsp; (U+00A0) to prevent that the line gets wrapped before the pipe (or similar) symbol. Because U+00A0 is not a whitespace it can not collapse with the whitespace between the two spans.

Dec 3 2018, 6:41 AM · Accessibility, MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson

Dec 1 2018

Fomafix added a comment to T210789: Table of contents' hidden state isn't kept after reload.

It is possible to reimplement the former behavior and store the status in a cookie on a change. Restoring the status from a cookie with JavaScript can only be done after DOM ready and this leads to a flash of the full ToC before it get minimized. A way to avoid this is to hide the ToC already on server-side. With a cookie this would also be possible but cookies are unwanted for such a think. An alternative is to store the status in a user option. Anonymous user have no user options and therefor they can not store the status in the user options. An advantage of storing in user options is that the status is shared for browser the user uses.

Dec 1 2018, 1:35 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface

Nov 30 2018

Fomafix added a comment to T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.

A newline is also a whitespace. Does a space (U+0020) instead of the newline (U+000A) prevent problem in the screen reader?

Nov 30 2018, 11:43 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Notice, Accessibility, MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson
Fomafix added a comment to T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.

@Graham87 As far as I see the is a whitespace in the HTML in all examples that I check. Can you link an example where you find

<span class="mw-uctop">current</span>

without a whitespace before?

Nov 30 2018, 11:08 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Notice, Accessibility, MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson

Nov 28 2018

Fomafix created T210574: Scrolling in the rcdays input field in the preferences leads to decimal value with lots of digits.
Nov 28 2018, 6:10 AM · Browser-Support-Firefox, OOUI, MediaWiki-User-preferences

Nov 14 2018

Fomafix added a comment to T188817: Disable text manipulating buttons on read-only pages.

A simple styling for disabled buttons is

opacity: .5;
Nov 14 2018, 8:35 PM · User-TheDJ, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WikiEditor

Nov 13 2018

Fomafix committed rEWLEfadd1195c82d: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Legoktm).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 13 2018, 5:00 PM

Nov 12 2018

Fomafix added a comment to P7788 ES6 Deferred.

catch() is missing.

Nov 12 2018, 8:43 AM

Nov 9 2018

Fomafix added a comment to T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.

The outer list <ul class="mw-contributions-list"> is unchanged.

Nov 9 2018, 3:20 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Notice, Accessibility, MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson
Fomafix added a comment to T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.

@Graham87 Is it better to change from

Nov 9 2018, 2:37 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Notice, Accessibility, MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson

Nov 8 2018

Fomafix committed rEWBI1ec3660ca558: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Jdforrester-WMF).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 8 2018, 6:09 AM

Nov 7 2018

Fomafix committed rEWBI0ba6cf317d8a: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Jdforrester-WMF).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 7 2018, 6:47 PM
Fomafix added a comment to T174057: Namespaces are shown in the local language rather than in the user interface language.

There are more places where the namespace names in content language are shown in the UI which are not covered by rMW9f28aa0709d0:

Nov 7 2018, 5:11 PM · MediaWiki-Interface, I18n

Nov 6 2018

Fomafix closed T208249: -{R|...}- is visible around display title in error message on preview on page content languages with active language conversion as Resolved.
Nov 6 2018, 7:08 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MediaWiki-Parser, Page-Previews, MediaWiki-Language-converter
Fomafix committed rEWLEef6736d67d03: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Legoktm).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 6 2018, 5:29 PM
Fomafix committed rEWLEa78fd81883ff: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Legoktm).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 6 2018, 4:38 PM
Fomafix committed rEWLEd9771906116f: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Legoktm).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 6 2018, 5:41 AM

Nov 5 2018

Fomafix committed rEWLE215858f2931c: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Legoktm).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 5 2018, 7:28 PM

Nov 1 2018

Fomafix committed rEWBI919ad2209d59: Adapt to new MediaWikiLocalizedTextProvider constructor (authored by Jdforrester-WMF).
Adapt to new MediaWikiLocalizedTextProvider constructor
Nov 1 2018, 9:21 AM