Page MenuHomePhabricator

Fomafix (Fomafix)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2014, 8:51 AM (252 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Fomafix [ Global Accounts ]

Recent Activity

Yesterday

Fomafix renamed T230382: Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia from Remove aliases `minnan` and `zh-cfr` for `nan`/`zh-min-nan` to Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia.
Sat, Aug 17, 7:34 PM · Patch-For-Review, Traffic, Operations, Wikimedia-Apache-configuration, DNS

Mon, Aug 12

Fomafix closed T230387: Special:SiteMatrix shows the Cantonese Wiktionary as missing as Invalid.

On https://en.wikipedia.org/wiki/Special:SiteMatrix the entry for the Cantonese Wiktionary is in the line yue. Is is not missing. Cantonese is just twice in the list.

Mon, Aug 12, 9:45 PM · SiteMatrix
Fomafix created T230387: Special:SiteMatrix shows the Cantonese Wiktionary as missing.
Mon, Aug 12, 9:35 PM · SiteMatrix
Fomafix created T230382: Remove aliases `minnan` and `zh-cfr` for the Min Nan Wikipedia.
Mon, Aug 12, 8:33 PM · Patch-For-Review, Traffic, Operations, Wikimedia-Apache-configuration, DNS
Fomafix updated the task description for T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Mon, Aug 12, 11:55 AM · Wikimedia-Interwiki-links
Fomafix updated the task description for T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Mon, Aug 12, 10:28 AM · Wikimedia-Interwiki-links
Fomafix reopened T167513: Redirect lzh.wikipedia to zh-classical.wikipedia, a subtask of T30443: Rename zh-classical -> lzh, as Open.
Mon, Aug 12, 7:53 AM · Wiki-Setup (Rename), Community-consensus-needed, Wikimedia-Language-setup
Fomafix reopened T167513: Redirect lzh.wikipedia to zh-classical.wikipedia as "Open".

lzh.wikipedia.org works:

$ curl https://lzh.wikipedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="https://zh-classical.wikipedia.org/">here</a>.</p>
</body></html>
Mon, Aug 12, 7:53 AM · Patch-For-Review, Traffic, Wikimedia-Apache-configuration, Operations, DNS

Fri, Aug 9

Fomafix created T230228: Replace `[[cmn:` by `[[:cmn:` in the wikitext.
Fri, Aug 9, 6:46 PM · Wikimedia-Interwiki-links
Fomafix created T230226: Make 'cnm' an interlanguage prefix instead of an interwiki prefix.
Fri, Aug 9, 6:35 PM · Wikimedia-Interwiki-links

Sun, Aug 4

Fomafix updated the task description for T31186: Rename Võro Wikipedia, fiu-vro -> vro.
Sun, Aug 4, 7:37 PM · Patch-For-Review, Wiki-Setup (Rename), Wikimedia-Language-setup

Thu, Aug 1

Fomafix renamed T229311: Remove unnecessary escaping of '<', '>' and '&' in styles and messages from Remove unnecessary escaping of '<', '> and '&' in styles and messages to Remove unnecessary escaping of '<', '>' and '&' in styles and messages.
Thu, Aug 1, 6:29 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Fomafix renamed T229311: Remove unnecessary escaping of '<', '>' and '&' in styles and messages from Remove unnecessary escaping in styles to Remove unnecessary escaping of '<', '> and '&' in styles and messages.
Thu, Aug 1, 6:28 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Fomafix renamed T229301: Remove unnecessary escaping of UTF-8 characters in messages from Remove unnecessary escaping in messages to Remove unnecessary escaping of UTF-8 characters in messages.
Thu, Aug 1, 6:28 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Performance-Team, MediaWiki-ResourceLoader

Tue, Jul 30

Fomafix created T229311: Remove unnecessary escaping of '<', '>' and '&' in styles and messages.
Tue, Jul 30, 8:43 AM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Fomafix created T229301: Remove unnecessary escaping of UTF-8 characters in messages.
Tue, Jul 30, 5:27 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Performance-Team, MediaWiki-ResourceLoader

Thu, Jul 25

Fomafix renamed T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn from Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl to Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.
Thu, Jul 25, 5:37 AM · Patch-For-Review, MediaWiki-Internationalization, I18n

Tue, Jul 23

Fomafix committed rEEJBffcb30c7b82c: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn (authored by Fomafix).
Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn
Tue, Jul 23, 7:01 AM

Jul 18 2019

Fomafix committed rEEJB34a0bc7d62c5: Remove arrays around the strings in languageScripts (authored by Fomafix).
Remove arrays around the strings in languageScripts
Jul 18 2019, 7:00 AM

Jul 13 2019

Fomafix committed rEEJB2118de7f7ba5: Fix languageScripts mapping from language code to file names (authored by Fomafix).
Fix languageScripts mapping from language code to file names
Jul 13 2019, 7:30 PM

Jul 11 2019

Fomafix added a comment to T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration.

An alternative is to drop the mapping from als to gsw completely.

Jul 11 2019, 7:18 PM · MediaWiki-Internationalization, Language-Team, I18n
Fomafix created T227813: Move mapping of WMF specific deprecated language codes from MediaWiki to WMF configuration.
Jul 11 2019, 7:17 PM · MediaWiki-Internationalization, Language-Team, I18n

Jul 4 2019

Fomafix committed rEGTO345954e83098: Simplify by using mw.util.getUrl (authored by Fomafix).
Simplify by using mw.util.getUrl
Jul 4 2019, 7:46 PM
Fomafix added a comment to T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.

No of course not, as the website literally predates the new fangled standard (2009) as well as any sort of 'process' being in place to begin with.

BCP 47 is much older than 2009. sr-ec has even with RFC 1766 from 1995 the meaning Serbian in Ecuador.

Jul 4 2019, 2:36 PM · Patch-For-Review, MediaWiki-Internationalization, I18n
Fomafix committed rSANIb8700271fb26: Remove htmlspecialchars where HTML escaping is already present (authored by Fomafix).
Remove htmlspecialchars where HTML escaping is already present
Jul 4 2019, 2:00 PM
Fomafix added a comment to T117845: Rename the language codes sr-ec and sr-el to the BCP 47 conform codes sr-Cyrl and sr-Latn.
  1. I see no community discussion approving this change across multiple wikis in the task description. I only see a (partial) technical discussion above

Was there a community discussion for introducing the not BCP 47 conform language codes sr-ec and sr-el instead of the BCP 47 conform language codes sr-cyrl and sr-latn? The standard BCP 47 is not made by the community.

Jul 4 2019, 1:56 PM · Patch-For-Review, MediaWiki-Internationalization, I18n

Jul 3 2019

Fomafix committed rSEXAMPLE081c41ee7f07: Remove htmlspecialchars where HTML escaping is already present (authored by Fomafix).
Remove htmlspecialchars where HTML escaping is already present
Jul 3 2019, 7:10 AM

Jun 24 2019

Fomafix claimed T225845: Remove support for automatic 'dir' parameter inference for load.php urls .
Jun 24 2019, 12:05 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 18 2019

Fomafix added a comment to T68598: mw.loader state of module stuck at "loading" if request was aborted.

Maybe the online and offline events are also interesting in this context.

Jun 18 2019, 3:51 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader
Fomafix added a comment to T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.

This change is similar to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

Jun 18 2019, 10:56 AM · Performance-Team, MediaWiki-ResourceLoader
Fomafix added a subtask for T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor: T225899: Set the default parameter for load.php in client-side by a parameter in server-side.
Jun 18 2019, 10:55 AM · Performance-Team, MediaWiki-ResourceLoader
Fomafix added a parent task for T225899: Set the default parameter for load.php in client-side by a parameter in server-side: T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.
Jun 18 2019, 10:55 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Performance-Team (Radar), MediaWiki-ResourceLoader
Fomafix created T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.
Jun 18 2019, 7:55 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 16 2019

Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

I like this one most. It would be very efficient and reduces the amount of information and code required on the client. You can use the existing $VARS that StartupModule and mediawiki.js make use of to very efficiently export these for the current context. I think you can replace reqBase with a $VARS.something assignment to make this work. E.g. skin/lang always, and debug/dir only as needed.

Jun 16 2019, 8:37 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader
Fomafix created T225899: Set the default parameter for load.php in client-side by a parameter in server-side.
Jun 16 2019, 7:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Performance-Team (Radar), MediaWiki-ResourceLoader
Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

A similar dependency is the call of Language::getFallbacksFor. This can avoided in ResourceLoader by transmitting always the whole fallback language chain instead of only the user interface language. By the way this allows an user individual fallback chain.

Jun 16 2019, 6:27 PM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 15 2019

Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

T181684: Add ability to get language directionality from mw.language also requires the language directionality of a language in JavaScript.

Jun 15 2019, 8:23 AM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader
Fomafix added a comment to T225845: Remove support for automatic 'dir' parameter inference for load.php urls .

The server-side part is easy.
The client-side part requires the information of the direction on JavaScript side. I see four possibilities to get this information:

  • Add an addition JavaScript config variable wgUserDirection or wgUserLanguageDirection.
  • Get the information from the existing JavaScript config variable wgUserLanguage via a mapping table. ULS already contains such a table. A complete table is big. Maybe the table can just filled with the used language codes wgUserLanguage and maybe other languages that are used.
  • Get the information from the browser.
  • Add a new JavaScript config variable specific for resource load containing all URL parameters that just reflected to the server. Default values like dir=ltr or debug=false can be omitted in this variable.
Jun 15 2019, 8:04 AM · Patch-For-Review, Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader

Jun 12 2019

Restricted Application added a project to T225589: Load search suggestion for strings typed before initializing JavaScript: Discovery-Search.
Jun 12 2019, 7:37 AM · Discovery-Search, OOUI, MediaWiki-Search
Fomafix added a comment to T224952: On some special pages the search suggestions get shown on browser history back.

I updated the description to match the change. Only the search suggestion field on browser history back is a regression.

Jun 12 2019, 6:00 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search
Fomafix updated the task description for T224952: On some special pages the search suggestions get shown on browser history back.
Jun 12 2019, 5:56 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search

Jun 11 2019

Fomafix closed T220489: Use `data-mw="interface"` instead of `mw-data="interface"` as Resolved.
Jun 11 2019, 8:07 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Maps (Kartographer)
Fomafix added a comment to T224952: On some special pages the search suggestions get shown on browser history back.

@Formatierer: With https://gerrit.wikimedia.org/r/514422 the search suggestion gets only loaded when the input field is focused. This should still hit the case when there are type characters in the input field but avoid the case when the value of the input field is restored by browser history back because then the input field is normally not focused.

Jun 11 2019, 9:50 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search
Fomafix removed a project from T47668: Position of Search result is wrong hardcoded: Patch-For-Review.

Please verify if rMW578c8e6855ca solves the problem in skin Cavendish. As far as I see is skin Cavendish not compatible with the current version of MediaWiki.

Jun 11 2019, 7:17 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search, MediaWiki-Search, MediaWiki-Interface

Jun 10 2019

Fomafix changed the subtype of T68599: Browser window gets black without exit button when the browser is offline from "Task" to "Bug Report".

I still can reproduce the bug as described in the description.

Jun 10 2019, 9:51 AM · Multimedia, MediaViewer
Fomafix added a comment to T71893: MMV: Page is completely blacked out when accessing an invalid file name.

At the moment the URL https://en.wikipedia.org/wiki/Mike_Godwin#mediaviewer/File:T<ess.pdf shows a back screen for a short moment and then shows the article again. In the JavaScript console there is the error message

Error: "Unable to parse title"

I guess the behavior is changed compared to original behavior of this task because now the exception is caught and the black screen is removed.

Jun 10 2019, 9:09 AM · Multimedia, MediaViewer

Jun 6 2019

Fomafix claimed T47668: Position of Search result is wrong hardcoded.

Skin Cavendish uses a margin on the body element https://github.com/DaSchTour/Cavendish/blob/master/resources/cavendish.css#L84

body {
	margin-left: 5%;
	margin-right: 5%;
}

Therefor https://gerrit.wikimedia.org/r/514564 should solve the problem.

Jun 6 2019, 9:04 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search, MediaWiki-Search, MediaWiki-Interface
Fomafix added a comment to T47668: Position of Search result is wrong hardcoded.

Solves https://gerrit.wikimedia.org/r/514564 the problem?

Jun 6 2019, 8:32 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search, MediaWiki-Search, MediaWiki-Interface
Fomafix merged T225174: Add anchor links for each section header into T18691: RFC: Section headings should have a clickable anchor.
Jun 6 2019, 7:42 AM · Patch-For-Review, Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface
Fomafix merged task T225174: Add anchor links for each section header into T18691: RFC: Section headings should have a clickable anchor.
Jun 6 2019, 7:41 AM

Jun 5 2019

Fomafix claimed T224952: On some special pages the search suggestions get shown on browser history back.
Jun 5 2019, 6:07 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search
Fomafix added a project to T224952: On some special pages the search suggestions get shown on browser history back: Browser-Support-Firefox.

This part in OOUI causes the restore of the value in the OOUI search input field on Special:Search: https://gerrit.wikimedia.org/g/oojs/ui/+/98dc3e15db7b699f14a1a6277da0d20c0edc554f/src/widgets/TextInputWidget.js#110

		this.$input.attr( 'autocomplete', 'off' );
		// Turning off autocompletion also disables "form caching" when the user navigates to a
		// different page and then clicks "Back". Re-enable it when leaving.
		// Borrowed from jQuery UI.
		$( window ).on( {
			beforeunload: function () {
				this.$input.removeAttr( 'autocomplete' );
			}.bind( this ),
			pageshow: function () {
				// Browsers don't seem to actually fire this event on "Back", they instead just
				// reload the whole page... it shouldn't hurt, though.
				this.$input.attr( 'autocomplete', 'off' );
			}.bind( this )
		} );
Jun 5 2019, 4:32 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search

Jun 4 2019

Fomafix renamed T224952: On some special pages the search suggestions get shown on browser history back from On some special pages the search suggestions get shown on browser histrory back to On some special pages the search suggestions get shown on browser history back.
Jun 4 2019, 8:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search
Fomafix added a comment to T224952: On some special pages the search suggestions get shown on browser history back.

Hmm, I see. Before rMW72f61f7a5930 on browser history back there was never a search suggestion window but only on some special pages the search input field gets restored and on other special pages not. Now when the search input field gets restored then additionally the search suggestion field gets shown.

Jun 4 2019, 6:42 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search
Fomafix added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

I created T224952 for the problem described in T224524#5228179.

Jun 4 2019, 4:46 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Restricted Application added a project to T224952: On some special pages the search suggestions get shown on browser history back: Discovery-Search.
Jun 4 2019, 4:44 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Browser-Support-Firefox, OOUI, MediaWiki-Special-pages, Discovery-Search, MediaWiki-Search

Jun 3 2019

Fomafix added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

The problem T224524#5228179 happens on all special pages using OOUI. This issue should tracked on a separate task.

Jun 3 2019, 6:36 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Fomafix added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

The problem T224524#5228179 gets triggered by

OO.ui.infuse( $( '#searchText' ) )

I don't know what happens here.

Jun 3 2019, 8:11 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Fomafix added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

On https://de.wiktionary.org/wiki/Spezial:Suche the focus behavior is caused by the JavaScript in https://de.wiktionary.org/wiki/MediaWiki:Common.js.

Jun 3 2019, 6:04 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression

Jun 2 2019

Fomafix added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

I can confirm the problem and it happens since rMW72f61f7a5930: jquery.suggestions: Trigger keypress on initializing and rMWfd5733830383: jquery.suggestions: Do not show suggestions on prefilled values. But it happens only on the general search field on Special:Search, not with the same general search field on other pages and not on other input fields with suggestions. This is strange.

Jun 2 2019, 7:10 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression

May 30 2019

Fomafix closed T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load as Resolved.

Verified with https://www.mediawiki.org/wiki/Special:Contributions/Iniquity

May 30 2019, 1:28 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Fomafix closed T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load, a subtask of T220732: 1.34.0-wmf.7 deployment blockers, as Resolved.
May 30 2019, 1:28 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments

May 29 2019

Amorymeltzer awarded T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load a Piece of Eight token.
May 29 2019, 10:22 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression
Fomafix created T224631: Show only one user exist error message on Special:CreateAccount.
May 29 2019, 9:49 PM · MediaWiki-User-login-and-signup
Fomafix claimed T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.
May 29 2019, 8:31 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression

May 24 2019

Fomafix closed T223422: Load search suggestion for strings typed before initializing JavaScript as Resolved.
May 24 2019, 6:33 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), MediaWiki-Search

May 16 2019

Fomafix created T223422: Load search suggestion for strings typed before initializing JavaScript.
May 16 2019, 7:57 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), MediaWiki-Search

May 15 2019

Fomafix merged T214863: ULS causes JQMIGRATE: jQuery.fn.offset() requires a valid DOM element into T175236: [ULS] jQuery.fn.offset() requires a valid DOM element.
May 15 2019, 8:00 AM · Patch-For-Review, UniversalLanguageSelector, Technical-Debt
Fomafix merged task T214863: ULS causes JQMIGRATE: jQuery.fn.offset() requires a valid DOM element into T175236: [ULS] jQuery.fn.offset() requires a valid DOM element.
May 15 2019, 8:00 AM · UniversalLanguageSelector
Fomafix created T223352: Catch exceptions from mw.hook handlers.
May 15 2019, 5:08 AM · Performance-Team (Radar), patch-welcome, MediaWiki-ResourceLoader, JavaScript

May 11 2019

Fomafix updated the task description for T214863: ULS causes JQMIGRATE: jQuery.fn.offset() requires a valid DOM element.
May 11 2019, 10:48 AM · UniversalLanguageSelector

May 8 2019

Fomafix claimed T175977: Prevent web crawler from indexing buttons in content.
May 8 2019, 6:08 AM · Patch-For-Review, MediaWiki-General

May 2 2019

Fomafix updated the task description for T222329: Special:Search generates "TypeError: this.pushPending is not a function".
May 2 2019, 5:10 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Discovery-Search, MediaWiki-Search, Regression, OOUI
Fomafix created T222329: Special:Search generates "TypeError: this.pushPending is not a function".
May 2 2019, 5:07 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Discovery-Search, MediaWiki-Search, Regression, OOUI

Apr 29 2019

Fomafix committed rETMC650de06c291c: Hook 'SkinEditSectionLinks' does now the HTML escaping (authored by Fomafix).
Hook 'SkinEditSectionLinks' does now the HTML escaping
Apr 29 2019, 9:48 AM

Apr 25 2019

Fomafix added a comment to T174133: Do not catch Ctrl key combinations on focused language selector on Special:PageLanguage.

Yes, the problem was fixed in Firefox 65 by changing the default for dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content from false to true. When I set the config parameter in Firefox to false then the problem is present again.

Apr 25 2019, 4:10 AM · Browser-Support-Firefox, OOUI, MediaWiki-Special-pages

Apr 24 2019

Fomafix closed T174133: Do not catch Ctrl key combinations on focused language selector on Special:PageLanguage as Resolved.

The problem does not exist anymore. Is seams to be fixed.

Apr 24 2019, 8:31 PM · Browser-Support-Firefox, OOUI, MediaWiki-Special-pages

Apr 22 2019

Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

I can not find any JavaScript errors while loading of https://de.wikivoyage.org/wiki/Arnsberg anymore.

Apr 22 2019, 9:43 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree

Apr 20 2019

Fomafix triaged T221439: Static mapframe not clickable in 1.34.0-wmf.1 as Unbreak Now! priority.
Apr 20 2019, 8:36 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Reading-Infrastructure-Team-Backlog (Kanban), Regression, Patch-For-Review, Maps (Kartographer)

Apr 19 2019

Fomafix created T221443: JavaScript click hander for watch/unwatch pages on the watchlist is not attached for items loaded from rcfilters.
Apr 19 2019, 10:14 AM · Growth-Team, MediaWiki-Watchlist
Fomafix claimed T221439: Static mapframe not clickable in 1.34.0-wmf.1 .
Apr 19 2019, 9:04 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Reading-Infrastructure-Team-Backlog (Kanban), Regression, Patch-For-Review, Maps (Kartographer)

Apr 18 2019

Fomafix added a comment to T63115: Drop URL parameter setlang.

T25227 requires a token for logout.

Apr 18 2019, 5:07 PM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector

Apr 17 2019

Restricted Application added a project to T146349: The logout button and the mobile view button contains the markasread parameter: Growth-Team.

The problem still exist. https://www.wikidata.org/wiki/Special:Notifications contains links like https://www.wikidata.org/wiki/Q3938?markasread=123456789&markasreadwiki=wikidatawiki

Apr 17 2019, 7:01 PM · Growth-Team, Collaboration-Team-Triage, Notifications

Apr 9 2019

Fomafix claimed T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

https://gerrit.wikimedia.org/r/502396 is merged. Please test again when it is deployed.

Apr 9 2019, 8:13 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

I found the reason for the race condition:

Apr 9 2019, 5:22 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

Fixed in https://de.wikivoyage.org/w/index.php?title=MediaWiki:ListingEditor.js&diff=1195136&oldid=1195058

Apr 9 2019, 2:14 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

In https://de.wikivoyage.org/wiki/MediaWiki:ListingEditor.js a dependency on module mediawiki.api is missing because it uses mw.Api(). I identified this with a throttled network connection in Firefox.

Apr 9 2019, 1:30 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix created T220489: Use `data-mw="interface"` instead of `mw-data="interface"`.
Apr 9 2019, 10:46 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Maps (Kartographer)
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

With https://gerrit.wikimedia.org/r/502396 I fix an failure in Maps (Kartographer) which causes the exception in T220308#5091821.

Apr 9 2019, 10:32 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix closed T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js as Invalid.

I just got also the error message above. This error come from extension Maps (Kartographer). As visible result the TocTree gets not executed. But this is not a fault of TocTree.

Apr 9 2019, 5:07 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree
Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

There are some missing dependencies in https://de.wikivoyage.org/ that lead to race conditions. But the extension TocTree is not the root cause.

Apr 9 2019, 4:57 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree

Apr 8 2019

Fomafix added a comment to T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js.

TocTree is correct as far as I see. Maybe there is a race-condition somewhere else.

Apr 8 2019, 7:15 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-TocTree

Apr 4 2019

Fomafix added a comment to T57876: Add Hakka (hak) to LanguageConverter.

I just rebased https://gerrit.wikimedia.org/r/116691 and applied the changes from similar files.

Apr 4 2019, 7:23 AM · Patch-For-Review, I18n, MediaWiki-Language-converter
Fomafix removed a project from T35871: Port mediawiki.legacy.protect to modern JavaScript: Patch-For-Review.
Apr 4 2019, 7:02 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix closed T215737: The included enhanced RecentChanges has a different collapsible toggle button as Resolved.
Apr 4 2019, 5:56 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, MediaWiki-Recent-changes

Apr 3 2019

Fomafix closed T35871: Port mediawiki.legacy.protect to modern JavaScript as Resolved.
Apr 3 2019, 8:26 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix changed the subtype of T207981: uselang=/ leads to unhandled exception in installer from "Task" to "Bug Report".
Apr 3 2019, 5:16 AM · Patch-For-Review, MediaWiki-Installer

Apr 2 2019

Fomafix placed T35871: Port mediawiki.legacy.protect to modern JavaScript up for grabs.
Apr 2 2019, 8:22 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript
Fomafix reopened T35871: Port mediawiki.legacy.protect to modern JavaScript as "Open".

Reopen: The JavaScript global variable window.ProtectionForm still gets assigned.

Apr 2 2019, 8:22 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Page-protection, Technical-Debt, JavaScript

Mar 31 2019

Fomafix added a comment to T36514: Language and direction of first heading should depend on page content language instead of user interface language.

The browser and especially the operating systems have a bad support for the Explicit Directional Isolate Formatting Characters (LRI, RLI, FSI, PDI) introduced in Unicode 6.3:

Mar 31 2019, 12:50 PM · Patch-For-Review, RTL, I18n, MediaWiki-Internationalization