Gilles (Gilles Dubuc)
Senior Performance Engineer, WMF

Projects (19)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 8:24 AM (146 w, 3 d)
Availability
Available
IRC Nick
gilles
LDAP User
Gilles
MediaWiki User
Unknown

Recent Activity

Sat, Jul 22

Gilles renamed T170810: Update rsvg to 2.40.18 from Update rsvg to 2.40.17 to Update rsvg to 2.40.18.
Sat, Jul 22, 6:51 AM · Wikimedia-SVG-rendering, Thumbor, Commons, media-storage

Thu, Jul 20

Gilles added a comment to T169565: Performance review of "Explore similar".

@EBernhardson sounds good to me, better chances of combining Varnish hits with another feature is definitely the most important optimization

Thu, Jul 20, 6:59 PM · Patch-For-Review, Discovery-Search (Current work), Discovery, Performance-Team
Deskana awarded T171093: Performance review of VisualEditor a Love token.
Thu, Jul 20, 9:03 AM · VisualEditor-Performance, VisualEditor, Performance-Team

Wed, Jul 19

Gilles created P5767 Vagrant Thumbor sync.
Wed, Jul 19, 9:20 PM
Gilles moved T171093: Performance review of VisualEditor from Inbox to Potential goals on the Performance-Team board.
Wed, Jul 19, 7:11 PM · VisualEditor-Performance, VisualEditor, Performance-Team
Gilles created T171093: Performance review of VisualEditor.
Wed, Jul 19, 7:11 PM · VisualEditor-Performance, VisualEditor, Performance-Team
Gilles moved T170546: Optimize Wikipedia PNG Logo from Inbox to Radar on the Performance-Team board.
Wed, Jul 19, 7:07 PM · Performance-Team, Wikimedia-Site-requests
Gilles moved T170628: HTTP 429 on thumbnail images for specific SVG file on Commons from Inbox to Radar on the Performance-Team board.
Wed, Jul 19, 7:05 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles moved T170817: Upgrade Thumbor servers to Stretch from Inbox to Radar on the Performance-Team board.
Wed, Jul 19, 7:04 PM · Operations, Performance-Team, Thumbor
Gilles moved T169522: Measure separate NavigationTiming metric(s) focused on Asia with higher sampling from Inbox to Next-up on the Performance-Team board.
Wed, Jul 19, 7:04 PM · Patch-For-Review, Performance-Team
Gilles lowered the priority of T169522: Measure separate NavigationTiming metric(s) focused on Asia with higher sampling from High to Normal.
Wed, Jul 19, 7:04 PM · Patch-For-Review, Performance-Team
Gilles moved T170825: Performance review of LoginNotify from Inbox to Doing on the Performance-Team board.
Wed, Jul 19, 7:04 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Community-Tech, Performance-Team, MediaWiki-extensions-LoginNotify
Gilles assigned T169522: Measure separate NavigationTiming metric(s) focused on Asia with higher sampling to Krinkle.
Wed, Jul 19, 6:55 PM · Patch-For-Review, Performance-Team
Gilles claimed T170825: Performance review of LoginNotify.
Wed, Jul 19, 6:54 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Community-Tech, Performance-Team, MediaWiki-extensions-LoginNotify
Gilles added a comment to T163876: Grafana's incorrectly localizes dates (upstream bug).

Fixed upstream: https://github.com/grafana/grafana/commit/af56cc4c281476dc6e87e873e1710819dfa91e4e

Wed, Jul 19, 6:51 PM · Upstream, Performance-Team

Tue, Jul 18

Gilles added a subtask for T170444: On beta commons, thumbnailing of 3D files is broken still: T161719: Add STL support (with 3d2png) to Thumbor.
Tue, Jul 18, 5:13 PM · Multimedia, Thumbor, Beta-Cluster-Infrastructure
Gilles added a parent task for T161719: Add STL support (with 3d2png) to Thumbor: T170444: On beta commons, thumbnailing of 3D files is broken still.
Tue, Jul 18, 5:13 PM · Performance-Team, Thumbor
Gilles changed the status of T161719: Add STL support (with 3d2png) to Thumbor from Stalled to Open.
Tue, Jul 18, 5:13 PM · Performance-Team, Thumbor
Gilles updated subscribers of T161719: Add STL support (with 3d2png) to Thumbor.

@MarkTraceur I'm going on vacation for 2 weeks at the end of this week. But before I leave I have time to walk you through how you would go about writing this, and @fgiunchedi can review your Thumbor plugin for STL.

Tue, Jul 18, 5:13 PM · Performance-Team, Thumbor
Gilles assigned T161719: Add STL support (with 3d2png) to Thumbor to MarkTraceur.
Tue, Jul 18, 5:11 PM · Performance-Team, Thumbor
Gilles added a comment to T170444: On beta commons, thumbnailing of 3D files is broken still.

OK, finally found the right command to invoke it:

Tue, Jul 18, 5:11 PM · Multimedia, Thumbor, Beta-Cluster-Infrastructure
Gilles added a comment to T170444: On beta commons, thumbnailing of 3D files is broken still.

I think I've found the actual command in mediawiki-config, but xvfb-run is missing:

Tue, Jul 18, 5:04 PM · Multimedia, Thumbor, Beta-Cluster-Infrastructure
Gilles closed T170677: Thumbor replies 429 on deleted files as Resolved.
Tue, Jul 18, 4:51 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles added a comment to T170444: On beta commons, thumbnailing of 3D files is broken still.

Thumbor has no support for STL yet, and it can't get it until 3d2png is available. The first step is getting 3d2png to be on the server at all and function properly. I see that the sources are there now:

Tue, Jul 18, 4:49 PM · Multimedia, Thumbor, Beta-Cluster-Infrastructure
Gilles committed rTHMBREXTdbfdf0ebed39: Version bump (authored by Gilles).
Version bump
Tue, Jul 18, 2:12 PM
Gilles committed rTHMBREXTb587a098d749: Make exception for 404 in errorneous file throttling (authored by Gilles).
Make exception for 404 in errorneous file throttling
Tue, Jul 18, 2:12 PM
Gilles added a commit to T170677: Thumbor replies 429 on deleted files: rTHMBREXTb587a098d749: Make exception for 404 in errorneous file throttling.
Tue, Jul 18, 2:12 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles closed D722: Make exception for 404 in errorneous file throttling by committing rTHMBREXTb587a098d749: Make exception for 404 in errorneous file throttling.
Tue, Jul 18, 2:12 PM
Gilles added a comment to T170825: Performance review of LoginNotify.

Yes, I noticed that, it's definitely a great thing that the bulk of the work happens async. There is one caveat to using jobs and I wanted to make sure that your current approach was deliberate.

Tue, Jul 18, 9:05 AM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Community-Tech, Performance-Team, MediaWiki-extensions-LoginNotify
Gilles added a comment to T170878: Audit users and account expiry dates for stat boxes.

I use EL occasionally to investigate performance incidents, I would like to retain access.

Tue, Jul 18, 8:48 AM · Patch-For-Review, Analytics-Kanban, Analytics-Cluster

Mon, Jul 17

Gilles renamed T163876: Grafana's incorrectly localizes dates (upstream bug) from Disable Grafana's client-side localization of dates to Grafana's incorrectly localizes dates (upstream bug).
Mon, Jul 17, 3:49 PM · Upstream, Performance-Team
Gilles added a comment to T163876: Grafana's incorrectly localizes dates (upstream bug).

Thanks for the reminder, done: https://github.com/grafana/grafana/issues/8874

Mon, Jul 17, 3:49 PM · Upstream, Performance-Team
Gilles created T170825: Performance review of LoginNotify.
Mon, Jul 17, 2:24 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Community-Tech, Performance-Team, MediaWiki-extensions-LoginNotify
Gilles removed a project from T169198: File purging should also purge the thumbnails of old versions: Patch-For-Review.
Mon, Jul 17, 2:01 PM · MW-1.30-release-notes, Thumbor, Commons
Gilles moved T169522: Measure separate NavigationTiming metric(s) focused on Asia with higher sampling from Doing to Inbox on the Performance-Team board.
Mon, Jul 17, 1:57 PM · Patch-For-Review, Performance-Team
Gilles placed T169522: Measure separate NavigationTiming metric(s) focused on Asia with higher sampling up for grabs.
Mon, Jul 17, 1:56 PM · Patch-For-Review, Performance-Team
Gilles created T170817: Upgrade Thumbor servers to Stretch.
Mon, Jul 17, 1:55 PM · Operations, Performance-Team, Thumbor
Gilles added a comment to T170628: HTTP 429 on thumbnail images for specific SVG file on Commons.

The Thumbor servers, in this case, but yeah. I guess I can file a task for that...

Mon, Jul 17, 1:54 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles added a project to T170677: Thumbor replies 429 on deleted files: Patch-For-Review.
Mon, Jul 17, 1:53 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles added a revision to T170677: Thumbor replies 429 on deleted files: D722: Make exception for 404 in errorneous file throttling.
Mon, Jul 17, 1:53 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles created D722: Make exception for 404 in errorneous file throttling.
Mon, Jul 17, 1:53 PM
Gilles closed T170810: Update rsvg to 2.40.18 as Declined.
Mon, Jul 17, 1:45 PM · Wikimedia-SVG-rendering, Thumbor, Commons, media-storage
Gilles closed T170810: Update rsvg to 2.40.18, a subtask of T170628: HTTP 429 on thumbnail images for specific SVG file on Commons, as Declined.
Mon, Jul 17, 1:45 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles added a comment to T170810: Update rsvg to 2.40.18.

Doesn't seem to be the source of the problem anyway, after further inspection.

Mon, Jul 17, 1:45 PM · Wikimedia-SVG-rendering, Thumbor, Commons, media-storage
Gilles added a comment to T170628: HTTP 429 on thumbnail images for specific SVG file on Commons.

Trying a stretch machine on labs, which runs 2.40.16-1+b1, works fine. And the source for it looks identical to 2.40.16-1+wmf1

Mon, Jul 17, 1:45 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles triaged T170810: Update rsvg to 2.40.18 as Normal priority.
Mon, Jul 17, 1:19 PM · Wikimedia-SVG-rendering, Thumbor, Commons, media-storage
Gilles changed the status of T170628: HTTP 429 on thumbnail images for specific SVG file on Commons from Open to Stalled.
Mon, Jul 17, 1:19 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles changed the status of T170628: HTTP 429 on thumbnail images for specific SVG file on Commons, a subtask of T43371: Thumbnail/imagescaler (tracking), from Open to Stalled.
Mon, Jul 17, 1:19 PM · media-storage, Commons, Tracking
Gilles added a project to T170628: HTTP 429 on thumbnail images for specific SVG file on Commons: Performance-Team.
Mon, Jul 17, 1:19 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles created T170810: Update rsvg to 2.40.18.
Mon, Jul 17, 1:19 PM · Wikimedia-SVG-rendering, Thumbor, Commons, media-storage
Gilles merged task T137876: Frequent segfaults of rsvg-convert on image scalers into T170628: HTTP 429 on thumbnail images for specific SVG file on Commons.
Mon, Jul 17, 1:17 PM · Operations
Gilles merged T137876: Frequent segfaults of rsvg-convert on image scalers into T170628: HTTP 429 on thumbnail images for specific SVG file on Commons.
Mon, Jul 17, 1:17 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles added a comment to T170628: HTTP 429 on thumbnail images for specific SVG file on Commons.

These county maps show up disproportionately in the failing thumbnail logs. The issue with them predates Thumbor, because it's a problem at the rsvg-convert level (which is also what Mediawiki uses). They make rsvg-convert segfault:

Mon, Jul 17, 1:16 PM · Operations, Performance-Team, Thumbor, Commons, media-storage
Gilles claimed T170677: Thumbor replies 429 on deleted files.
Mon, Jul 17, 1:04 PM · Patch-For-Review, Performance-Team, Thumbor

Thu, Jul 13

Krinkle awarded T166414: Explore NavigationTiming by faceted properties - EventLogging refine a Orange Medal token.
Thu, Jul 13, 7:46 PM · Analytics, Performance-Team
Gilles added a comment to T168949: Proper thumbnails of portrait photos not being generated; serious display issues.

@Jeff_G please create a separate task for this issue with more details (which browser, browser version, a screenshot of the error, etc.). It's unrelated to this task.

Thu, Jul 13, 5:46 AM · Thumbor, Commons
Gilles added a comment to T169683: Thumbor should return informative and nice-looking errors.

It's not more severe, it's exactly the same problem. Lack of body applies to all error responses.

Thu, Jul 13, 5:41 AM · Patch-For-Review, Performance-Team, Thumbor

Wed, Jul 12

TheDJ awarded T170109: Thumbor should support SVG files that start with <svg:svg a Barnstar token.
Wed, Jul 12, 10:48 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles moved T150734: Make Thumbor logs available in ELK from Blocked to Doing on the Performance-Team board.
Wed, Jul 12, 7:21 PM · Patch-For-Review, User-fgiunchedi, Performance-Team, Thumbor
Gilles moved T156924: Allow integration of data from etcd into the MediaWiki configuration from Next-up to Radar on the Performance-Team board.
Wed, Jul 12, 7:19 PM · Availability (Multiple-active-datacenters), MediaWiki-Platform-Team, Services (watching), Performance-Team, discovery-system, User-Joe, User-mobrovac, Operations
Gilles moved T169180: Test user performance from Asia to validate changes when the Asia Cache goes live from Doing to Next-up on the Performance-Team board.
Wed, Jul 12, 7:18 PM · Performance-Team
Gilles moved T146045: Make Performance inspector opt-in (Beta Feature?) from Next-up to Backlog on the Performance-Team board.
Wed, Jul 12, 7:18 PM · PerformanceInspector, Performance-Team
Gilles moved T145123: Correlate image/page weight to cost for users downloading the page from Next-up to Backlog on the Performance-Team board.
Wed, Jul 12, 7:18 PM · Patch-For-Review, PerformanceInspector, Performance-Team
Gilles moved T117411: On-wiki page performance inspector tool from Next-up to Backlog on the Performance-Team board.
Wed, Jul 12, 7:18 PM · PerformanceInspector, Reading-Community-Engagement, Performance-Team
Gilles assigned T169180: Test user performance from Asia to validate changes when the Asia Cache goes live to Peter.
Wed, Jul 12, 7:16 PM · Performance-Team
Gilles claimed T169565: Performance review of "Explore similar".
Wed, Jul 12, 7:15 PM · Patch-For-Review, Discovery-Search (Current work), Discovery, Performance-Team
Gilles closed T153170: Grafana alerts for save timing as Resolved.
Wed, Jul 12, 7:15 PM · Performance-Team
Gilles closed T153170: Grafana alerts for save timing, a subtask of T153166: Set up Grafana alerts for Web Performance metrics, as Resolved.
Wed, Jul 12, 7:15 PM · Epic, Performance-Team
Gilles moved T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis from Inbox to Radar on the Performance-Team board.
Wed, Jul 12, 6:52 PM · Patch-For-Review, Wikidata-Sprint, User-Ladsgroup, MediaWiki-extensions-WikibaseClient, User-Daniel, Wikidata, Traffic, DBA, Performance-Team, Operations
Gilles moved T125735: Warning: timed out after 0.2 seconds when connecting to rdb1001.eqiad.wmnet [110]: Connection timed out from Inbox to Blocked on the Performance-Team board.
Wed, Jul 12, 6:50 PM · Performance-Team, User-Elukey, Operations, Wikimedia-log-errors
Gilles added a comment to T170444: On beta commons, thumbnailing of 3D files is broken still.

Thumbor doesn't support those yet, you guys have to figure out how to deploy 3d2png properly first. There's a change cherry-picked for it on beta, but it keeps generating errors: T166013: deployment-imagescaler01 has no mwdeploy user and the executable is nowhere in sight.

Wed, Jul 12, 6:32 PM · Multimedia, Thumbor, Beta-Cluster-Infrastructure
Gilles closed T170109: Thumbor should support SVG files that start with <svg:svg as Resolved.

All good now. Affected files should just start working once they get out of the 429 throttling.

Wed, Jul 12, 5:27 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles closed T170109: Thumbor should support SVG files that start with <svg:svg, a subtask of T43371: Thumbnail/imagescaler (tracking), as Resolved.
Wed, Jul 12, 5:27 PM · media-storage, Commons, Tracking
Gilles added a comment to T170109: Thumbor should support SVG files that start with <svg:svg.

Works fine on beta: https://commons.wikimedia.beta.wmflabs.org/wiki/File:Westmoreland_Heritage_Trail.svg

Wed, Jul 12, 5:12 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles closed T169445: Thumbtime parameter for videos is broken as Resolved.

Works again: https://upload.wikimedia.org/wikipedia/commons/thumb/a/a3/Aequipotentialflaechen.webm/310px-seek=1-Aequipotentialflaechen.webm.jpg

Wed, Jul 12, 5:07 PM · Patch-For-Review, Performance-Team, Thumbor, Wikimedia-Video, Multimedia, Commons, TimedMediaHandler
Gilles closed T170352: Large SVG files fail to render in Thumbor (due to lack of use of the --unlimited option in librsvg) as Resolved.
Wed, Jul 12, 5:04 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles closed T170352: Large SVG files fail to render in Thumbor (due to lack of use of the --unlimited option in librsvg), a subtask of T43371: Thumbnail/imagescaler (tracking), as Resolved.
Wed, Jul 12, 5:04 PM · media-storage, Commons, Tracking
Gilles closed T169312: Implement poolcounter failover in Thumbor as Resolved.
Wed, Jul 12, 5:03 PM · Patch-For-Review, Operations, Performance-Team, Thumbor
Gilles closed T169312: Implement poolcounter failover in Thumbor, a subtask of T151066: Implement PoolCounter support in Thumbor, as Resolved.
Wed, Jul 12, 5:03 PM · Patch-For-Review, Operations, Performance-Team, Thumbor
Gilles closed T169687: Thumbor can't render some animated GIFs properly as Resolved.
Wed, Jul 12, 5:02 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles committed rTHMBREXTdee720cf41fb: Version bump (authored by Gilles).
Version bump
Wed, Jul 12, 3:16 PM
Gilles committed rTHMBREXT24e0498b8855: Lower sensitivity of SVG test (authored by Gilles).
Lower sensitivity of SVG test
Wed, Jul 12, 3:16 PM
Gilles committed rTHMBREXT1e24f4eab747: Better poolcounter failure management (authored by Gilles).
Better poolcounter failure management
Wed, Jul 12, 3:12 PM
Gilles added a commit to T169312: Implement poolcounter failover in Thumbor: rTHMBREXT1e24f4eab747: Better poolcounter failure management.
Wed, Jul 12, 3:12 PM · Patch-For-Review, Operations, Performance-Team, Thumbor
Gilles closed D710: Better poolcounter failure management by committing rTHMBREXT1e24f4eab747: Better poolcounter failure management.
Wed, Jul 12, 3:12 PM
Gilles added a commit to T170109: Thumbor should support SVG files that start with <svg:svg: rTHMBREXT8586dfc1244b: Add support for SVG files that start with <svg.
Wed, Jul 12, 3:10 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles committed rTHMBREXT8586dfc1244b: Add support for SVG files that start with <svg (authored by Gilles).
Add support for SVG files that start with <svg
Wed, Jul 12, 3:10 PM
Gilles closed D713: Add support for SVG files that start with <svg by committing rTHMBREXT8586dfc1244b: Add support for SVG files that start with <svg.
Wed, Jul 12, 3:10 PM
Gilles committed rTHMBREXT56fb2dc1375c: Accept url-encoded seek parameter (authored by Gilles).
Accept url-encoded seek parameter
Wed, Jul 12, 2:31 PM
Gilles added a commit to T169445: Thumbtime parameter for videos is broken: rTHMBREXT56fb2dc1375c: Accept url-encoded seek parameter.
Wed, Jul 12, 2:31 PM · Patch-For-Review, Performance-Team, Thumbor, Wikimedia-Video, Multimedia, Commons, TimedMediaHandler
Gilles closed D714: Accept url-encoded seek parameter by committing rTHMBREXT56fb2dc1375c: Accept url-encoded seek parameter.
Wed, Jul 12, 2:31 PM
Gilles added a reviewer for D712: Handle SVG files greater than 10MB: TheDJ.
Wed, Jul 12, 2:30 PM
Gilles closed T162875: Write graceful rolling restart script for Thumbor as Invalid.

We can and should just depool a server before restarting all its Thumbor instances.

Wed, Jul 12, 2:19 PM · Operations, Performance-Team, Thumbor
Gilles added a project to T169445: Thumbtime parameter for videos is broken: Patch-For-Review.
Wed, Jul 12, 2:15 PM · Patch-For-Review, Performance-Team, Thumbor, Wikimedia-Video, Multimedia, Commons, TimedMediaHandler
Gilles created D714: Accept url-encoded seek parameter.
Wed, Jul 12, 2:14 PM
Gilles added a revision to T169445: Thumbtime parameter for videos is broken: D714: Accept url-encoded seek parameter.
Wed, Jul 12, 2:14 PM · Patch-For-Review, Performance-Team, Thumbor, Wikimedia-Video, Multimedia, Commons, TimedMediaHandler
Gilles added a comment to T169445: Thumbtime parameter for videos is broken.

As far as I can tell, it has to do with Varnish or Swift URL-encoding the request, where thumbor expects "seek=4" and gets "seek%3D4". All the existing integration tests are Thumbor only, without Swift or Varnish in front of it.

Wed, Jul 12, 1:56 PM · Patch-For-Review, Performance-Team, Thumbor, Wikimedia-Video, Multimedia, Commons, TimedMediaHandler
Gilles added a project to T170109: Thumbor should support SVG files that start with <svg:svg: Patch-For-Review.
Wed, Jul 12, 1:31 PM · Patch-For-Review, Performance-Team, Thumbor
Gilles created D713: Add support for SVG files that start with <svg.
Wed, Jul 12, 1:30 PM
Gilles added a revision to T170109: Thumbor should support SVG files that start with <svg:svg: D713: Add support for SVG files that start with <svg.
Wed, Jul 12, 1:30 PM · Patch-For-Review, Performance-Team, Thumbor