Gilles (Gilles Dubuc)
Senior Performance Engineer, WMF

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 8:24 AM (207 w, 2 h)
Availability
Available
IRC Nick
gilles
LDAP User
Gilles
MediaWiki User
Unknown

Recent Activity

Yesterday

Gilles closed T198370: Transparent background renders as white in PNG thumbnails as Resolved.

Palette PNGs are now fixed as well, I purged those 2 examples you gave @Trlkly and verified the fix. Thanks again for your report.

Mon, Sep 24, 9:36 AM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, Commons, MediaWiki-File-management
Gilles closed T198370: Transparent background renders as white in PNG thumbnails, a subtask of T43371: Thumbnail/imagescaler (tracking), as Resolved.
Mon, Sep 24, 9:36 AM · media-storage, Commons, Tracking
Gilles closed T198370: Transparent background renders as white in PNG thumbnails, a subtask of T108517: PNG thumbnails issues (tracking), as Resolved.
Mon, Sep 24, 9:36 AM · Commons, Tracking, Multimedia, MediaWiki-File-management

Fri, Sep 21

Gilles created T205117: Collect navigator.deviceMemory in navtiming when available.
Fri, Sep 21, 4:27 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles updated subscribers of T205099: Embedded TMH points to incorrect thumbnail URLs.
Fri, Sep 21, 2:37 PM · TimedMediaHandler-Player, TimedMediaHandler, Wikimedia-Video
Gilles created T205099: Embedded TMH points to incorrect thumbnail URLs.
Fri, Sep 21, 2:37 PM · TimedMediaHandler-Player, TimedMediaHandler, Wikimedia-Video
Gilles added a comment to T201124: Provide standard/reproducible way to access a PageToken.

That's correct! I'm in the process of unifying the schema column names to make joins between these tables less confusing: T204921: Rename EventLogging column surveyInstanceToken to pageviewToken in QuickSurveysResponses for consistency

Fri, Sep 21, 11:34 AM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board-Old, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings

Thu, Sep 20

Gilles committed rTHMBREXT9424882d8820: Version bump (authored by Gilles).
Version bump
Thu, Sep 20, 9:30 PM
Gilles added a commit to T20871: Include at least some EXIF metadata in resized pictures: rTHMBREXT9424882d8820: Version bump.
Thu, Sep 20, 9:30 PM · Patch-For-Review, WMF-Legal, Commons, Multimedia, MediaWiki-File-management
Gilles added a commit to T198370: Transparent background renders as white in PNG thumbnails: rTHMBREXT9424882d8820: Version bump.
Thu, Sep 20, 9:30 PM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, Commons, MediaWiki-File-management
Gilles added a commit to T198370: Transparent background renders as white in PNG thumbnails: rTHMBREXTb8dda36d73fd: Apply -background none to palette PNGs.
Thu, Sep 20, 9:23 PM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, Commons, MediaWiki-File-management
Gilles committed rTHMBREXTb8dda36d73fd: Apply -background none to palette PNGs (authored by Gilles).
Apply -background none to palette PNGs
Thu, Sep 20, 9:23 PM
Gilles closed D1113: Apply -background none to palette PNGs.
Thu, Sep 20, 9:23 PM
Gilles moved T195840: Track when a CentralNotice banner was displayed to the user in NavTiming from Blocked to Doing on the Performance-Team board.
Thu, Sep 20, 7:29 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles removed a project from T195840: Track when a CentralNotice banner was displayed to the user in NavTiming: Patch-For-Review.
Thu, Sep 20, 7:28 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles added a comment to T195840: Track when a CentralNotice banner was displayed to the user in NavTiming.

This is now live. From the enwiki main page:

Thu, Sep 20, 7:28 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles added a comment to T204702: Move Thumbor Plugins code review from Differential to Gerrit.

Request added to https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests

Thu, Sep 20, 9:24 AM · Thumbor
Gilles committed rEQS6aa27886c8ac: Rename surveyInstanceToken to pageviewToken (authored by Gilles).
Rename surveyInstanceToken to pageviewToken
Thu, Sep 20, 9:16 AM
Gilles added a subtask for T187299: User-perceived page load performance study: T204922: Rename column on old hive data for a few tables.
Thu, Sep 20, 9:15 AM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles added a parent task for T204922: Rename column on old hive data for a few tables: T187299: User-perceived page load performance study.
Thu, Sep 20, 9:15 AM · Performance-Team (Radar), Analytics
Gilles created T204922: Rename column on old hive data for a few tables.
Thu, Sep 20, 9:15 AM · Performance-Team (Radar), Analytics
Gilles triaged T204921: Rename EventLogging column surveyInstanceToken to pageviewToken in QuickSurveysResponses for consistency as Normal priority.
Thu, Sep 20, 9:03 AM · Readers-Web-Backlog (Tracking), Patch-For-Review, QuickSurveys
Gilles added a comment to T187299: User-perceived page load performance study.

We're now collecting ResourceTiming data about the top article image. You can find that data in the resourcetiming table on hive:

Thu, Sep 20, 9:00 AM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles closed T197609: Collect ResourceTiming data of top article image, a subtask of T187299: User-perceived page load performance study, as Resolved.
Thu, Sep 20, 8:57 AM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles closed T197609: Collect ResourceTiming data of top article image as Resolved.

Data is correctly being recorded in event.resourcetiming on hive.

Thu, Sep 20, 8:57 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team, MediaWiki-extensions-NavigationTiming

Wed, Sep 19

Gilles added a comment to T187299: User-perceived page load performance study.

Trying out undersampling positive responses to have roughly the same amount as negative ones, in order to circumvent the class imbalance in the dumbest possible way. Default RandomForestClassifier:

Wed, Sep 19, 8:34 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles added a comment to T187299: User-perceived page load performance study.

Of course :) I'm just trying to explore as much as I can with my limited knowledge and understanding of ML, in order to have a better informed discussion on Monday.

Wed, Sep 19, 6:57 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles added a comment to T187299: User-perceived page load performance study.

Here's what I get, asking the grid search to optimize for the negative responses' f1 score:

Wed, Sep 19, 8:24 AM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles added a comment to T187299: User-perceived page load performance study.

Optimizing the grid search for 0 (negative response)'s precision, I get:

Wed, Sep 19, 7:44 AM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team

Tue, Sep 18

Gilles added a comment to T187299: User-perceived page load performance study.

Trying random forest classifiers with grid search for the parameters on the whole dataset, extracted with this query:

Tue, Sep 18, 6:57 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles added a comment to D1113: Apply -background none to palette PNGs.

Because of the other things going on that affect the SSIM, it wouldn't really catch the same regression happening, though...

Tue, Sep 18, 1:47 PM
Gilles updated the diff for D1113: Apply -background none to palette PNGs.

Add test case

Tue, Sep 18, 1:45 PM
Gilles claimed T204702: Move Thumbor Plugins code review from Differential to Gerrit.
Tue, Sep 18, 1:08 PM · Thumbor
Gilles reassigned T204245: Run MediaWiki media originals active/active from Gilles to fgiunchedi.
Tue, Sep 18, 9:46 AM · User-fgiunchedi, Availability (MediaWiki-MultiDC), Performance-Team, Epic
Gilles added a comment to T204245: Run MediaWiki media originals active/active.

As far as I can tell, the math extension is serving images through the REST API (Mathoid) and as such doesn't use the "original" urls:

Tue, Sep 18, 9:46 AM · User-fgiunchedi, Availability (MediaWiki-MultiDC), Performance-Team, Epic
Gilles retitled D1113: Apply -background none to palette PNGs from Don't limit -background none to RGBA images to Apply -background none to palette PNGs.
Tue, Sep 18, 9:24 AM
Gilles updated the diff for D1113: Apply -background none to palette PNGs.

Simply add palette PNGs to the rule

Tue, Sep 18, 9:20 AM
Gilles added a comment to D1113: Apply -background none to palette PNGs.

Actually not without consequence, this is turning RGB thumbnails into RGBA, and the extra transparency layer is making the files bigger. Instead I'll try to restrict to RGBA + indexed.

Tue, Sep 18, 9:14 AM
Gilles requested review of D1113: Apply -background none to palette PNGs.
Tue, Sep 18, 9:09 AM
Gilles added a revision to T198370: Transparent background renders as white in PNG thumbnails: D1113: Apply -background none to palette PNGs.
Tue, Sep 18, 9:08 AM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, Commons, MediaWiki-File-management

Mon, Sep 17

Gilles moved T204174: FileOperation error "SwiftFileBackend::addMissingMetadata: {path} was not stored with SHA-1 metadata." from Potential goals to Next-up on the Performance-Team board.
Mon, Sep 17, 8:45 PM · Performance-Team, Thumbor, MediaWiki-File-management, Wikimedia-production-error
Gilles moved T204245: Run MediaWiki media originals active/active from Inbox to Next-up on the Performance-Team board.
Mon, Sep 17, 8:43 PM · User-fgiunchedi, Availability (MediaWiki-MultiDC), Performance-Team, Epic
Gilles claimed T204245: Run MediaWiki media originals active/active.
Mon, Sep 17, 8:43 PM · User-fgiunchedi, Availability (MediaWiki-MultiDC), Performance-Team, Epic
Gilles moved T204266: Backport prometheus haproxy exporter for Jessie from Inbox to Doing on the Performance-Team board.
Mon, Sep 17, 8:11 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles reopened T198370: Transparent background renders as white in PNG thumbnails as "Open".

It's probably relevant that they're using indexed colors, indeed/

Mon, Sep 17, 6:00 PM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, Commons, MediaWiki-File-management
Gilles reopened T198370: Transparent background renders as white in PNG thumbnails, a subtask of T43371: Thumbnail/imagescaler (tracking), as Open.
Mon, Sep 17, 6:00 PM · media-storage, Commons, Tracking
Gilles reopened T198370: Transparent background renders as white in PNG thumbnails, a subtask of T108517: PNG thumbnails issues (tracking), as Open.
Mon, Sep 17, 6:00 PM · Commons, Tracking, Multimedia, MediaWiki-File-management
Gilles closed T204478: ThumbnailRender job fails on private wikis as Resolved.

Seems to have worked, job errors on id_internalwikimedia have stopped.

Mon, Sep 17, 11:32 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles closed T204478: ThumbnailRender job fails on private wikis, a subtask of T203135: ThumbnailRender job fails with 429 errors, as Resolved.
Mon, Sep 17, 11:32 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Thumbor, WMF-Blog-Social-Team, Multimedia, Services (later)
Gilles removed projects from T204478: ThumbnailRender job fails on private wikis: MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), WMF-Blog-Social-Team.
Mon, Sep 17, 9:34 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles renamed T204478: ThumbnailRender job fails on private wikis from ThumbnailRender job failures for id_internalwikimedia to ThumbnailRender job fails on private wikis.
Mon, Sep 17, 9:34 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles added a comment to T204478: ThumbnailRender job fails on private wikis.

Turns out id_internalwikimedia is probably showing up more because it's having a lot of activity, but all private wikis are affected. The prerender job has always failed for them, apparently.

Mon, Sep 17, 9:33 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles added a comment to T204478: ThumbnailRender job fails on private wikis.

At a glance, it might be that it's expecting a URL and instead it's only getting a path?

Mon, Sep 17, 8:56 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles triaged T204478: ThumbnailRender job fails on private wikis as Normal priority.
Mon, Sep 17, 8:50 AM · Wikimedia-production-error, Patch-For-Review, Thumbor, Multimedia, Services (later)
Gilles reassigned T204266: Backport prometheus haproxy exporter for Jessie from Gilles to fgiunchedi.

Tested it on WMCS and it works:

Mon, Sep 17, 8:38 AM · User-fgiunchedi, Performance-Team, Thumbor

Fri, Sep 14

Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

At first glance, I've managed to backport everything. Now I'll need to actually test the program to see if it runs properly...

Fri, Sep 14, 7:32 AM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Nevermind, the source package actually builds both. Back on track...

Fri, Sep 14, 6:58 AM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Now back to trying to backport golang-google-grpc I get:

Fri, Sep 14, 6:43 AM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Undoing the patch that adds the gcc6 option -Wno-error=misleading-indentation worked and allowed me to backport protobuf 3.0.0!

Fri, Sep 14, 6:27 AM · User-fgiunchedi, Performance-Team, Thumbor

Thu, Sep 13

Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

It worked, yay.

Thu, Sep 13, 8:11 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

The list keeps growing:

Thu, Sep 13, 6:59 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Offending line: https://github.com/go-kit/kit/blob/v0.6.0/transport/grpc/client.go#L94

Thu, Sep 13, 6:39 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Currently stuck on golang-github-go-kit-kit-dev. Got all its dependencies backported or installed, and then:

Thu, Sep 13, 6:33 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

For the sid version golang-github-prometheus-common to be backported, the following need backporting as well:

Thu, Sep 13, 6:32 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Sure enough, going back to the Debian version of that library, it explains the error:

Thu, Sep 13, 6:06 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Next option is to fix the actual error, I guess, on that line: https://github.com/prometheus/haproxy_exporter/blob/v0.9.0/haproxy_exporter.go#L485

Thu, Sep 13, 6:03 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

Backported kingpin 2.2.6 and I still get the same error. I have a feeling this might be an issue of Go being too old on jessie-backports... It's 1.7 there and the Travis CI configuration for prometheus-haproxy-exporter uses 1.9

Thu, Sep 13, 5:58 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles added a comment to T204266: Backport prometheus haproxy exporter for Jessie.

After some minor adjustments to the package and what I had installed on my dev machine, I was able to get pretty far, but I'm running into a Go error, probably due to the version of Go itself or of the dependencies:

Thu, Sep 13, 5:24 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles triaged T204266: Backport prometheus haproxy exporter for Jessie as Low priority.
Thu, Sep 13, 5:17 PM · User-fgiunchedi, Performance-Team, Thumbor
Gilles assigned T204174: FileOperation error "SwiftFileBackend::addMissingMetadata: {path} was not stored with SHA-1 metadata." to aaron.

This probably happens for thumbnails generated with thumbor and then accessed via thumb.php. What's the point of that custom x-object-meta-sha1base36 header for thumbnails, though? The code doesn't say. It could be something that's only really useful for originals and thumbnails just happen to get the same treatment.

Thu, Sep 13, 4:44 PM · Performance-Team, Thumbor, MediaWiki-File-management, Wikimedia-production-error
Gilles added a comment to T195840: Track when a CentralNotice banner was displayed to the user in NavTiming.

Yes, next train is totally fine, thanks!

Thu, Sep 13, 4:32 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles reassigned T163438: VisualEditor broken on wikitech when codfw is primary: "Error loading data from server: apierror-visualeditor-docserver-http: HTTP 500." from Gilles to Joe.
Thu, Sep 13, 1:49 PM · Operations, Patch-For-Review, Datacenter-Switchover-2018, Parsing-Team, codfw-rollout, Cloud-Services
Gilles closed T163438: VisualEditor broken on wikitech when codfw is primary: "Error loading data from server: apierror-visualeditor-docserver-http: HTTP 500." as Resolved.

Thanks @Joe

Thu, Sep 13, 1:49 PM · Operations, Patch-For-Review, Datacenter-Switchover-2018, Parsing-Team, codfw-rollout, Cloud-Services
Gilles reassigned T203443: Document how to act on performance alerts from Gilles to Krinkle.

I'm done, passing the torch

Thu, Sep 13, 1:44 PM · Documentation, Performance-Team

Wed, Sep 12

Gilles added a comment to T203443: Document how to act on performance alerts.

FYI editing with VE on wikitech is currently broken because of T163438: VisualEditor broken on wikitech when codfw is primary: "Error loading data from server: apierror-visualeditor-docserver-http: HTTP 500."

Wed, Sep 12, 12:49 PM · Documentation, Performance-Team

Tue, Sep 11

Gilles added a comment to T187299: User-perceived page load performance study.

ISP requests work on stat machines.

Tue, Sep 11, 5:09 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team

Thu, Sep 6

Gilles added a comment to T197609: Collect ResourceTiming data of top article image.

Created the schema to collect the ResourceTiming data: https://meta.wikimedia.org/wiki/Schema:ResourceTiming

Thu, Sep 6, 1:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team, MediaWiki-extensions-NavigationTiming
Gilles added a comment to T197609: Collect ResourceTiming data of top article image.

This seems to do the trick:

Thu, Sep 6, 12:46 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team, MediaWiki-extensions-NavigationTiming
Gilles added a comment to T197609: Collect ResourceTiming data of top article image.

Identifying the top image in the article (from the content meaningfulness perspective) is a bit tricky, because some infoboxes point directly to images, without them being thumbnails in the wikitext semantic way of the terms (which gets those img elements a special class), and those infoboxes also sometimes contain tiny icons. The tiny icons, while not very significant visually, might be before the first large image people pay attention to in the DOM.

Thu, Sep 6, 12:27 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team, MediaWiki-extensions-NavigationTiming
Gilles updated subscribers of T195840: Track when a CentralNotice banner was displayed to the user in NavTiming.

@Ejegg when is the next CentralNotice deployment scheduled? If not scheduled or far in the future, is there any chance this particular change could be backported to production? It's extremely low risk: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/436792/1/resources/subscribing/ext.centralNotice.display.js

Thu, Sep 6, 12:07 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles placed T201199: analytics-privatedata-users access for Flavia Salutari up for grabs.
Thu, Sep 6, 12:04 PM · Patch-For-Review, SRE-Access-Requests, Operations

Wed, Sep 5

Gilles closed T201858: Push thumbnails to both data centers as Resolved.

carltondance

Wed, Sep 5, 7:23 PM · User-fgiunchedi, Patch-For-Review, Thumbor, Performance-Team

Tue, Sep 4

Gilles added a comment to T203485: Revisit Grafana/Icinga notification strategy.

Ops perviously rejected the idea of using the built-in Grafana notification system, as they don't want to maintain another alert/notification/paging system. Which is why we ended up building the Icinga bridge.

Tue, Sep 4, 6:23 PM · Performance-Team (Radar), monitoring, Patch-For-Review, Operations
Gilles renamed T197607: Add ability to oversample specific pages from Add ability to oversample on specific articles to Add ability to oversample specific pages.
Tue, Sep 4, 1:38 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team, MediaWiki-extensions-NavigationTiming

Mon, Sep 3

Gilles moved T201858: Push thumbnails to both data centers from Next-up to Doing on the Performance-Team board.
Mon, Sep 3, 8:29 PM · User-fgiunchedi, Patch-For-Review, Thumbor, Performance-Team
Gilles moved T27611: Support optimized WebP thumbnails as alternative to JPEG, PNG from Doing to Blocked on the Performance-Team board.
Mon, Sep 3, 8:29 PM · Patch-For-Review, Performance-Team, Commons, Multimedia, MediaWiki-File-management
Gilles moved T195840: Track when a CentralNotice banner was displayed to the user in NavTiming from Doing to Blocked on the Performance-Team board.
Mon, Sep 3, 8:28 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles added a comment to T198394: Change viewport for desktop tests (Browsertime and WebPageTest).

Data collected by MediaViewer about viewport dimensions is currently stored in that EventLogging schema: https://meta.wikimedia.org/wiki/Schema:MultimediaViewerDimensions

Mon, Sep 3, 8:25 PM · WebPageReplay, WebPageTest, Performance-Team
Gilles closed D1108: Add test case for ImageDescription EXIF filtering.

This revision has already been merged, see message above in the history

Mon, Sep 3, 6:38 PM
Gilles added a comment to T187299: User-perceived page load performance study.

Now that we have transferSize and that it's been collecting for a couple of months, we can go back and see if there's a correlation between that and survey responses:

Mon, Sep 3, 1:49 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles closed T197974: Record transferSize in Navigation Timing data, a subtask of T187299: User-perceived page load performance study, as Resolved.
Mon, Sep 3, 12:24 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles closed T197974: Record transferSize in Navigation Timing data as Resolved.

This appears to work fine, a lot of data is being collected.

Mon, Sep 3, 12:24 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles added a comment to T195840: Track when a CentralNotice banner was displayed to the user in NavTiming.

My code doesn't seem to be running on enwiki? @AndyRussG Are new versions of CentralNotice not deployed automatically via the train like the rest of MediaWiki extensions? Special:Version on enwiki states "2.6.0 (6492626) 20:21, 6 May 2018".

Mon, Sep 3, 12:20 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles added a comment to T195840: Track when a CentralNotice banner was displayed to the user in NavTiming.

Hmmm I'm targeted by a WLM banner right now and I'm not seeing the performance mark...

Mon, Sep 3, 12:13 PM · Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team
Gilles closed T196775: Record monotonic time of survey impression, a subtask of T187299: User-perceived page load performance study, as Resolved.
Mon, Sep 3, 12:09 PM · Patch-For-Review, User-notice, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Readers-Web-Backlog (Tracking), QuickSurveys, Unplanned-Sprint-Work, Performance-Team
Gilles closed T196775: Record monotonic time of survey impression as Resolved.

The data is making it to EventLogging as expected and I'm seeing large values as I thought was possible when the survey is initially rendered below the fold. This will be a great signal to eliminate filter out that case or factor it into the machine learning.

Mon, Sep 3, 12:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Backlog (Tracking), QuickSurveys, Performance-Team
Gilles added a comment to D1107: Add ability to whitelist IPs for per-IP throttle.

@fgiunchedi as per https://phabricator.wikimedia.org/T203135#4553163 we're going to need this after all.

Mon, Sep 3, 11:33 AM
Gilles added a comment to T203135: ThumbnailRender job fails with 429 errors.

We're still getting from 429s, this time I cross-references them and it's the per-IP (ipv4 and not ipv6 this time):

Mon, Sep 3, 11:33 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Thumbor, WMF-Blog-Social-Team, Multimedia, Services (later)
Gilles committed rTHMBREXTb95d208be172: Add test case for ImageDescription EXIF filtering (authored by Gilles).
Add test case for ImageDescription EXIF filtering
Mon, Sep 3, 9:18 AM
Gilles added a commit to T20871: Include at least some EXIF metadata in resized pictures: rTHMBREXTb95d208be172: Add test case for ImageDescription EXIF filtering.
Mon, Sep 3, 9:18 AM · Patch-For-Review, WMF-Legal, Commons, Multimedia, MediaWiki-File-management