Page MenuHomePhabricator

Glrx
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 18 2016, 9:01 PM (318 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Glrx [ Global Accounts ]

Recent Activity

Thu, Nov 3

Glrx created T322365: Wikitext infobox description parameter has strange paragraph structure that adds break..
Thu, Nov 3, 7:11 PM · MediaWiki-Parser

Oct 11 2022

Glrx added a comment to T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.

I presume you are using --zoom

Oct 11 2022, 7:49 PM · Upstream, Wikimedia-SVG-rendering

Oct 4 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Testing notes

Thanks @dom_walden!


The first case does not have an xmlns: namespace declaration, but the second does.

The tool already adds the missing namespace if there isn't one.

I doubt that adding the namespace declaration changes the SVG file's elements. The document has already been parsed, so all the elements have had their namespace property set. SVG Translate is using a poor namespace model, so it will treat elements in the default namespace the same way as it would treat elements in the SVG namespace. SVG Translate uses getElementsByTagName() rather than getElementsByTagNameNS(). That poor model is also why the code separately checks for "svg:text". It should not be doing that. T316741: Allow svg namespace prefixes other than 'svg'

Oct 4 2022, 3:00 AM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Oct 3 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

I'm looking at tests/Model/Svg/SvgFileTest.php, and I see test cases such as the two starting at line 645

SvgFileTest.php
'CSS too complex' => [
    'svg' => '<svg><style>#foo { stroke:1px; } .bar { color:pink; }</style><text>Foo</text></svg>',
    'message' => 'structure-error-css-too-complex',
    'params' => [0 => ''],
],
'tref' => [
    'svg' => '<svg xmlns="http://www.w3.org/2000/svg" version="1.0" xmlns:xlink="http://www.w3.org/1999/xlink">
        <defs><text id="tref-id">Lorem</text></defs>
        <text id="text"><tref xlink:href="#tref-id" /></text></svg>',
    'message' => 'structure-error-contains-tref',
    'params' => [0 => 'text'],
],

The first case does not have an xmlns: namespace declaration, but the second does.

Oct 3 2022, 6:55 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Sep 22 2022

Glrx added a comment to T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.

Downloaded https://upload.wikimedia.org/wikipedia/commons/archive/b/bd/20220902193021%21Test.svg and replaced
<linearGradient id="lgback" gradientUnits="userSpaceOnUse" x1="0%" x2="100%" y1="0%" y2="0%">
with
<linearGradient id="lgback" gradientUnits="userSpaceOnUse">

The rectangle displays a gradient and no solid red locally in librsvg2-2.52.9. So I assume this got fixed at some point in upstream?

Sep 22 2022, 11:53 PM · Upstream, Wikimedia-SVG-rendering

Sep 8 2022

Glrx added a comment to T241500: Add link to translate the SVG Translate tool itself.

So the main page which a user sees at

Should add a hyper link with text such as "Add or improve the language translations in SVG Translate" that links to

Sep 8 2022, 11:28 PM · SVG Translate Tool, Community-Tech
Glrx added a comment to T248252: SVG Translate: Skip unsupported text pattern and continue with the supported ones.

Given that this issue is generally about forging ahead when problems are discovered rather than particular improvements, I would close as Won't Fix.

Sep 8 2022, 10:26 PM · Community-Tech, SVG Translate Tool
Glrx edited projects for T272133: Make all Postscript core 35 fonts available to SVG by installing some packages, added: Wikimedia-SVG-rendering; removed SVG Translate Tool.
Sep 8 2022, 10:05 PM · Wikimedia-SVG-rendering
Glrx added a comment to T316741: Allow svg namespace prefixes other than 'svg'.

I tried the DOM in Chromium, and it uses the modern definition for getElementsByTagName(). That is, the method will not find prefixed elements such as svg:text.

Sep 8 2022, 9:18 PM · Community-Tech, SVG Translate Tool

Sep 2 2022

Glrx added a comment to T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.

Consider relation to radialGradient in T193942 and T143086.

Sep 2 2022, 10:28 PM · Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T316962: librsvg filter using FillPaint referencing a gradient fill does not work..
Sep 2 2022, 10:25 PM · Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T316962: librsvg filter using FillPaint referencing a gradient fill does not work..

Issue is known at Gnome:

Sep 2 2022, 10:08 PM · Upstream, Wikimedia-SVG-rendering
Glrx created T316962: librsvg filter using FillPaint referencing a gradient fill does not work..
Sep 2 2022, 9:12 PM · Upstream, Wikimedia-SVG-rendering
Glrx renamed T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse from librsvg x, y, width, height not defaulted for userSpaceOnUse to librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.
Sep 2 2022, 8:54 PM · Upstream, Wikimedia-SVG-rendering
Glrx created T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.
Sep 2 2022, 8:45 PM · Upstream, Wikimedia-SVG-rendering

Aug 31 2022

Glrx added a comment to T316741: Allow svg namespace prefixes other than 'svg'.

The issue is a bit more general.

Aug 31 2022, 4:01 PM · Community-Tech, SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

My suspicion is the uncanonized langtags appear when makeTranslationReady() discovers the SVG is too complex to handle, returns false before canonizing zh-Hans, the return value is ignored, and SVG Translate forges ahead believing all the langtags have been fixed.

Aug 31 2022, 3:01 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Aug 30 2022

Glrx added a comment to T313615: <mapframe> has inconsistent handling while crossing the antimeridian.

Repeating symbols every 360 degrees: T195654 T229174

Aug 30 2022, 1:30 AM · Maps (Kartographer)

Aug 25 2022

Glrx added a comment to T316165: librsvg mishandles newlines when xml:space=preserve.

T40010 reevaluate renderer...

Aug 25 2022, 1:30 AM · Upstream, Wikimedia-SVG-rendering

Aug 24 2022

Glrx renamed T316165: librsvg mishandles newlines when xml:space=preserve from librsvg mishandles newlines xml:space=preserve to librsvg mishandles newlines when xml:space=preserve.
Aug 24 2022, 9:48 PM · Upstream, Wikimedia-SVG-rendering
Glrx created T316165: librsvg mishandles newlines when xml:space=preserve.
Aug 24 2022, 9:47 PM · Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Just guessing here... I do not know PHP or phpdoc.

Aug 24 2022, 2:00 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

I've been confused.

Aug 24 2022, 3:19 AM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Aug 22 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Uploaded file to Commons:
https://commons.wikimedia.org/wiki/File:SVG_Translate_test_namespace.svg

Aug 22 2022, 10:36 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

The code at 217 concerns wrapping #text nodes in tspan elements or giving up. In the problem file, the text is already wrapped. An svg:tspan element is not a #text node, so it should return false and give up on translating.

Aug 22 2022, 7:50 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Aug 19 2022

Glrx added a comment to T271595: SVG translate tool replaces all fields with "$1" (style element needs at least one trailing character).

Consider a style element that has an @media rule:

  • @media printer { text { fill: black; } }

That rule is presumably beyond the ad hoc parser, yet the original regex will succeed.

Aug 19 2022, 7:32 PM · Community-Tech, SVG Translate Tool

Aug 18 2022

Glrx added a comment to T279239: XML-Parser fails on <!ENTITY with multiple comands.

I suspect that T151735 introduced an ENTITY filter that rejects this text.

Aug 18 2022, 7:26 PM · Wikimedia-SVG-rendering, MediaWiki-Uploading
Glrx added a comment to T279240: XML-Parser fails on <!ATTLIST bar id ID #REQUIRED>.

In T151735, ATTLIST could be used for script injection attacks by setting default attribute values.

Aug 18 2022, 7:18 PM · Wikimedia-SVG-rendering, MediaWiki-Uploading
Glrx added a comment to T289765: SVG paint-order property doesn't works in SVG renderer.

Agree with JoKalliauer that paint-order is not SVG 1.1 Second Edition.

Aug 18 2022, 5:38 PM · Wikimedia-SVG-rendering, Thumbor

Aug 17 2022

Glrx updated subscribers of T271595: SVG translate tool replaces all fields with "$1" (style element needs at least one trailing character).

This issue has a 1-character fix.

Aug 17 2022, 8:05 PM · Community-Tech, SVG Translate Tool

Aug 11 2022

Glrx added a comment to T216815: Upgrade Thumbor to Bullseye.

I do not know PHP or Python, but here are the changes needed to wiki configuration, SVGHandler.php, and Thumbor's svg.py.

They are breaking changes. They need the Rust version of librsvg/rsvg-convert. If used with the old version of librsvg, I expect the new command line arg would cause an exception.

MediaWiki could be made compatible by having rsvg and rsvglang entries and testing for a "$lang" substring in the conversion string.

Thumbor is hardwired, so making it compatible with both versions would be more complicated. However, it would be good to allow Thumbor to use both rsvg-convert or resvg.

Aug 11 2022, 11:39 PM · User-jijiki, serviceops, SRE, Thumbor
Glrx added a comment to T265549: Update librsvg to > 2.44.10.

I do not know PHP or Python, but here are the changes needed to wiki configuration, SVGHandler.php, and Thumbor's svg.py.

Aug 11 2022, 11:36 PM · Infrastructure-Foundations, Packaging, Wikimedia-SVG-rendering, Thumbor
Glrx updated subscribers of T265549: Update librsvg to > 2.44.10.

I would like to note that this can all easily be implemented for non-wmf wikis. If someone just spent some time on adapting SVGHandler (or created an extension to override SVGHandler).

It just CANNOT easily go to WMF production any time soon because of security reviews, thumbor plugins which would have to be made, and the fact that the thumbor install itself is stuck in old systems that require updating all things for which there currently are no WMF budgets..

Aug 11 2022, 2:18 PM · Infrastructure-Foundations, Packaging, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T265549: Update librsvg to > 2.44.10.

I am… getting impatient enough to ask: how hard is it to, really, just make our own statically-compiled rsvg-convert binary into a deb package and then deploy it? I mean:

  • Rust already builds binaries with rust stuff statically linked in.
  • rustup is available for getting us an installation of rust without going through debian, and without interfering with anything stored in a prefix. Only thing that could stop rustup is the glibc version, but even then we could just build it on a newer distro and do static-crt.
  • System C deps for librsvg feel… reasonably conservative? I am not ruling out the possibility that it’s too new though.
  • deb packages are easily assembled from a DESTDIR structure with dpkg-buildpackage.

We can get this as a stop-gap measure *while* we talk about what else to switch to. The surface for any security review would be minimal compared to anything that requires adding a layer of adaptation to the PHP side (hopefully we just do the language code change).

I think if you wrote a build script for that, and tested it on a stretch container, I would support deploying it.

Aug 11 2022, 2:14 PM · Infrastructure-Foundations, Packaging, Wikimedia-SVG-rendering, Thumbor

Aug 8 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

The header comment for analyse() at line 394 suggests makeTranslationReady() has already been performed. It looks to me like that is called right after loading the file, and it will lowercase the langtags before analyse() is invoked.

Aug 8 2022, 6:25 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Aug 5 2022

Glrx added a comment to T248136: SVG translate Tool ignores inherit group-attributes.

SVG Translate finds translations by looking for text elements. It uses $this->document->getElementsByTagName('text') to find those elements.

Aug 5 2022, 6:37 PM · Community-Tech, SVG Translate Tool
Glrx added a comment to T248136: SVG translate Tool ignores inherit group-attributes.

Describe limitations of the tool.
T250330

Aug 5 2022, 5:56 PM · Community-Tech, SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

I do not know PHP, but is the RegEx pattern starting at line 285 correct?

// Text strings like $1, $2 will cause problems later because
// self::replaceIndicesRecursive() will try to replace them
// with (non-existent) child nodes.
if (preg_match('/$[0-9]/', $text->textContent)) {
    $this->logFileProblem('File {file} has text with $-numbers');
    return false;
}

I'm thinking the $ should be escaped (that is '/\$[0-9]/').

Aug 5 2022, 5:06 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

@dom_walden Thanks for checking.

Aug 5 2022, 4:49 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Aug 4 2022

Glrx added a comment to T270889: In SVG files larger than 256kB with <switch> elements, the translations are not recognized.

When I've run into this problem, I've used two workarounds.

Aug 4 2022, 8:07 PM · I18n, Commons, MediaWiki-File-management
Restricted Application changed the subtype of T213140: [BUG] SVG Translate fails to render some images from "Task" to "Bug Report".

Yes, I believe the problem is the 7207 x 7003 pixel image. If you are trying to display the image at full size, then you are asking for a 50 Mpixel image.

Aug 4 2022, 7:54 PM · SVG Translate Tool
Glrx added a comment to T298811: SVG Translate offers to translate phrases that are already restricted by `systemLanguage`.

Same issue as T248136.

Aug 4 2022, 7:32 PM · SVG Translate Tool
Glrx added a comment to T248136: SVG translate Tool ignores inherit group-attributes.

The file is in a format that SVG Translate does not know how to handle, but SVG Translate does not recognize that problem.

Aug 4 2022, 7:31 PM · Community-Tech, SVG Translate Tool
Glrx added a comment to T248252: SVG Translate: Skip unsupported text pattern and continue with the supported ones.

SVG Translate made a deliberate decision to only work on SVG files with a simple format. It will only handle simple lines of plain text. Handling subscripts, color shifts, and font styling changes are beyond its ability.

Aug 4 2022, 7:01 PM · Community-Tech, SVG Translate Tool

Aug 3 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

MediaWiki uses an old version of librsvg that only matches the first subtag (the zh in zh-hans). That is why zh-hans can "match" zh-hant and produce unexpected results. It is a well-known bug. T154237. Newer versions of librsvg have a different matching algorithm with different problems.

Aug 3 2022, 2:58 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Jul 22 2022

Glrx updated the task description for T313615: <mapframe> has inconsistent handling while crossing the antimeridian.
Jul 22 2022, 7:36 PM · Maps (Kartographer)
Glrx created T313615: <mapframe> has inconsistent handling while crossing the antimeridian.
Jul 22 2022, 7:25 PM · Maps (Kartographer)

Jul 12 2022

Glrx created T312907: SVG Translate should add explicit language for the default so preferred languages will work..
Jul 12 2022, 10:29 PM · SVG Translate Tool
Glrx merged task T280523: Allow to translate text in a <tspan> element into T221382: [BUG] Some CSS selectors break translation input.
Jul 12 2022, 10:00 PM · SVG Translate Tool, Community-Tech
Glrx merged T280523: Allow to translate text in a <tspan> element into T221382: [BUG] Some CSS selectors break translation input.
Jul 12 2022, 9:59 PM · SVG Translate Tool
Glrx renamed T271595: SVG translate tool replaces all fields with "$1" (style element needs at least one trailing character) from SVG translate tool replaces all fields with "$1" to SVG translate tool replaces all fields with "$1" (style element needs at least one trailing character).
Jul 12 2022, 9:54 PM · Community-Tech, SVG Translate Tool
Glrx added a comment to T280523: Allow to translate text in a <tspan> element.

The text element in the description looks acceptable: one text with single-level tspan elements and no #text.

Jul 12 2022, 9:15 PM · SVG Translate Tool, Community-Tech

Jul 8 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

@Samwilson Thanks for working on this problem. It affects many users.

Jul 8 2022, 3:27 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Jul 6 2022

Glrx added a comment to T20936: Hairline / seam in SVG rendering.
Jul 6 2022, 10:22 PM · Upstream, Thumbor, Wikimedia-SVG-rendering

Jul 3 2022

Glrx added a comment to T311965: MediaWiki mishandles hyphenated language tags in SVG files..

Copy text from T279874

Jul 3 2022, 10:05 PM · Wikimedia-SVG-rendering
Glrx created T311965: MediaWiki mishandles hyphenated language tags in SVG files..
Jul 3 2022, 10:02 PM · Wikimedia-SVG-rendering

Jul 1 2022

Glrx merged T231143: [BUG] text element not recognised into T221382: [BUG] Some CSS selectors break translation input.
Jul 1 2022, 6:16 PM · SVG Translate Tool
Glrx merged task T231143: [BUG] text element not recognised into T221382: [BUG] Some CSS selectors break translation input.
Jul 1 2022, 6:16 PM · SVG Translate Tool
Glrx added a comment to T231143: [BUG] text element not recognised.

Problem was traced to using CSS ID selectors.

Jul 1 2022, 6:15 PM · SVG Translate Tool
Glrx updated the task description for T231143: [BUG] text element not recognised.
Jul 1 2022, 6:08 PM · SVG Translate Tool
Glrx added a comment to T271595: SVG translate tool replaces all fields with "$1" (style element needs at least one trailing character).

Working case: the style element has trailing whitespace.

Failing case: the style element has no characters following the last close brace.

It no longer displays $0 strings but rather claims "This file does not have any labels available for translation. Please pick another image."

Jul 1 2022, 6:03 PM · Community-Tech, SVG Translate Tool

Jun 23 2022

Glrx added a comment to T221382: [BUG] Some CSS selectors break translation input.

This behavior is by design. CSS selectors that use identifiers complicate the translation.

Jun 23 2022, 5:47 PM · SVG Translate Tool
Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Not sure if it's worth looking into more, but the --stylesheet option might let us add a font-face (something like FreeSans )?

Jun 23 2022, 3:59 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Jun 22 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

SVG Translate should not output files with underscores.

Jun 22 2022, 2:50 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Jun 20 2022

Glrx removed a subtask for T154237: SVG image wikisyntax can't use "lang=zh-hant": T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 20 2022, 9:56 PM · Thumbor, Upstream, I18n, Wikimedia-SVG-rendering, Chinese-Sites
Glrx removed a parent task for T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl): T154237: SVG image wikisyntax can't use "lang=zh-hant".
Jun 20 2022, 9:56 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx removed a parent task for T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists: T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 20 2022, 9:52 PM · Wikimedia-SVG-rendering, Upstream
Glrx removed a subtask for T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl): T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists.
Jun 20 2022, 9:52 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx merged T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl) into T154237: SVG image wikisyntax can't use "lang=zh-hant".
Jun 20 2022, 9:38 PM · Thumbor, Upstream, I18n, Wikimedia-SVG-rendering, Chinese-Sites
Glrx merged task T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl) into T154237: SVG image wikisyntax can't use "lang=zh-hant".
Jun 20 2022, 9:37 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T154237: SVG image wikisyntax can't use "lang=zh-hant".

T310230 is the same as this bug, so I will close it.

Jun 20 2022, 9:33 PM · Thumbor, Upstream, I18n, Wikimedia-SVG-rendering, Chinese-Sites
Glrx merged task T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists into T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 20 2022, 8:58 PM · Wikimedia-SVG-rendering, Upstream
Glrx merged T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists into T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 20 2022, 8:58 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering

Jun 15 2022

Glrx updated the task description for T310528: Thumbor URLs are too permissive.
Jun 15 2022, 2:20 PM · Traffic, Thumbor

Jun 13 2022

Glrx added a comment to T279874: SVG language tag als reported as Swiss German; gsw is Swiss German..

Thanks for adding more unit tests.

Jun 13 2022, 6:03 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Wikimedia-SVG-rendering
Glrx created T310528: Thumbor URLs are too permissive.
Jun 13 2022, 5:02 PM · Traffic, Thumbor
Glrx added a comment to T310235: When requesting undeterimined language of an SVG, English language is used instead.

Ah! Looking at another patch, and the case insensitive match has been removed. Great.

Jun 13 2022, 4:29 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), User-TheDJ, Commons, MediaWiki-File-management
Glrx added a comment to T310235: When requesting undeterimined language of an SVG, English language is used instead.

In looking at SVGHandler.php around line 570, I see a separate issue

Jun 13 2022, 4:20 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), User-TheDJ, Commons, MediaWiki-File-management

Jun 12 2022

Glrx added a comment to T63649: Multilanguage SVG images should be rendered in the wiki's content language.

Here are five cases of a Serbian wiki referencing a multilingual SVG.

Jun 12 2022, 8:00 PM · Commons, Multimedia, I18n, MediaWiki-File-management
Glrx removed projects from T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl): Commons, MediaWiki-File-management.
Jun 12 2022, 6:56 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx updated the task description for T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 12 2022, 6:54 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx renamed T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl) from Ask SVG rasterizer for Klingon, get Tagalog to Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 12 2022, 6:54 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).

Possibly a dupe of T154237 and old librsvg bad matching.

Jun 12 2022, 6:54 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx edited projects for T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists, added: Upstream, Wikimedia-SVG-rendering; removed Commons, MediaWiki-File-management.
Jun 12 2022, 6:36 PM · Wikimedia-SVG-rendering, Upstream
Glrx added a comment to T310441: Multilingual SVG always unexpectedly use the first 2-letter-match, even the specified language exists.

This is a duplicate of other issues. T310230 (tlh matches 'tl') T154237

Jun 12 2022, 6:34 PM · Wikimedia-SVG-rendering, Upstream
Glrx added a comment to T63649: Multilanguage SVG images should be rendered in the wiki's content language.

@Winston_Sung
This issue is about a wiki page displaying the SVG in the wiki language if that language is available in the SVG. That functionality works.

Jun 12 2022, 4:18 PM · Commons, Multimedia, I18n, MediaWiki-File-management
Glrx added a comment to T60920: lang support for SVG images using SystemLanguageAttribute ill-defined and not properly supported in browsers.

I would close this task as can't fix for won't fix.

Jun 12 2022, 4:00 PM · I18n, Parsoid

Jun 11 2022

Glrx added a comment to T310235: When requesting undeterimined language of an SVG, English language is used instead.

I love this SvgHandler.php change

Jun 11 2022, 5:44 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), User-TheDJ, Commons, MediaWiki-File-management
Glrx added a comment to T279874: SVG language tag als reported as Swiss German; gsw is Swiss German..

@TheDJ
ImagePage.php 1118-1131 seems a little off.

Jun 11 2022, 5:11 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Wikimedia-SVG-rendering
Glrx added a comment to T279874: SVG language tag als reported as Swiss German; gsw is Swiss German..

ImagePage.php has some IETF or SVG-specific code in it.

Jun 11 2022, 3:40 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Wikimedia-SVG-rendering

Jun 10 2022

Glrx added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

Here's what I understand.

Jun 10 2022, 11:59 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering
Glrx added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

I would like WMF to directly serve SVG files. Today's browsers offer reasonable SVG support. Letting the browser render the image also allows for dynamic interaction.

Jun 10 2022, 1:46 AM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering

Jun 9 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Just helped out another user with a failed Chinese translation:

Jun 9 2022, 6:42 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool
Glrx added a comment to T279874: SVG language tag als reported as Swiss German; gsw is Swiss German..

For me, lang and uselang have different types. For example, they should not be treated as the same. They should not be tested for equality without converting one type to the other. Such conversions are not guaranteed; there may not be an isomorphic mapping.

Jun 9 2022, 6:09 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Wikimedia-SVG-rendering
Glrx added a comment to T309426: Small, translated, SVG files do not display the "render this image in $lang" dropdown.

Will be deployed next week

Jun 9 2022, 3:12 PM · MW-1.38-notes, Patch-For-Review, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Regression, User-TheDJ, SVG, I18n, Commons, MediaWiki-File-management

Jun 8 2022

Glrx created T310235: When requesting undeterimined language of an SVG, English language is used instead.
Jun 8 2022, 9:55 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), User-TheDJ, Commons, MediaWiki-File-management
Glrx created T310230: Ask SVG rasterizer for Klingonf (tlh), get Tagalog (tl).
Jun 8 2022, 9:38 PM · User-TheDJ, Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T63649: Multilanguage SVG images should be rendered in the wiki's content language.

I believe this feature has been working for a couple of years now, so I would close this issue. The feature was needed to make SVG Translate work seamlessly.

Jun 8 2022, 9:29 PM · Commons, Multimedia, I18n, MediaWiki-File-management
Glrx added a comment to T60666: SVG files with a fallback language and a specific english translation, should have both options choosable.

I believe this issue has been fixed, but separate issues remain.

Jun 8 2022, 9:24 PM · User-TheDJ, SVG, Commons, Multimedia, MediaWiki-File-management

Jun 6 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Instead of

text[@systemLanguage='$language']
Jun 6 2022, 7:28 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool