Page MenuHomePhabricator

Glrx
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 18 2016, 9:01 PM (362 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Glrx [ Global Accounts ]

Recent Activity

Mon, Sep 25

Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

So i think related to the fix for T310235.

MediaWiki considers english the default, but maybe thumbor does not. So if something is set to english, mediawiki sees it equals the default and does not send the language along. Thumbor sees no language specified and assumes undefined.

Mon, Sep 25, 3:31 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

Thu, Sep 21

Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

Another complaint:

Thu, Sep 21, 4:04 AM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.

Another user complaining about en failing:
*https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&diff=prev&oldid=803253221#Clitoris_Anatomy_labels

Thu, Sep 21, 4:02 AM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

Another user running into this issue:

Thu, Sep 21, 4:00 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

Sun, Sep 17

Glrx added a comment to T64986: librsvg does not support fallback font set (more than one font family).

I see lots of stuff between style tags in the SVG code. Is the problem this?:

<style>@import url(https://ourworldindata.org/fonts.css)</style>

That is something recently added by OWID.

Sun, Sep 17, 11:24 PM · Wikimedia-SVG-rendering

Sat, Sep 16

Glrx updated the task description for T65236: Han characters in SVG files misplaced and clustered.
Sat, Sep 16, 7:31 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering

Wed, Sep 13

Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

Possible fix described at T337199 and T337139

Wed, Sep 13, 1:56 AM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

When a URL does not specify lang, then set env to {'LC_ALL': 'en'} so rsvg-convert` knows the language should be English ("en").

Wed, Sep 13, 12:46 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.

@hnowlan
There is a related problem at T337199.

Wed, Sep 13, 12:41 AM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx updated subscribers of T337199: Multilingual SVG with non-English default language does not display English.
Wed, Sep 13, 12:07 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

Code fix is would be related to T337139 by @hnowlan. Will comment there about the fix.

Wed, Sep 13, 12:06 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

Sun, Sep 10

Glrx triaged T337199: Multilingual SVG with non-English default language does not display English as High priority.
Sun, Sep 10, 12:34 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

Another user has problems:

Sun, Sep 10, 12:33 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

Sat, Sep 9

Glrx updated the task description for T345972: Rillke's SVG converter (convert.toolforge.org/svg2png.php) fails to show image; CORS.
Sat, Sep 9, 4:30 AM · Tools
Glrx created T345972: Rillke's SVG converter (convert.toolforge.org/svg2png.php) fails to show image; CORS.
Sat, Sep 9, 4:26 AM · Tools

Tue, Sep 5

Glrx added a comment to T64986: librsvg does not support fallback font set (more than one font family).

Gnome issue is

Tue, Sep 5, 7:12 PM · Wikimedia-SVG-rendering
Glrx renamed T64986: librsvg does not support fallback font set (more than one font family) from librsvg don't support fallback font set (more than one font family) to librsvg does not support fallback font set (more than one font family).
Tue, Sep 5, 7:05 PM · Wikimedia-SVG-rendering
Glrx added a subtask for T265549: Update librsvg to > 2.44.10: T64986: librsvg does not support fallback font set (more than one font family).
Tue, Sep 5, 1:45 AM · Packaging, Infrastructure-Foundations, Wikimedia-SVG-rendering, Thumbor
Glrx added a parent task for T64986: librsvg does not support fallback font set (more than one font family): T265549: Update librsvg to > 2.44.10.
Tue, Sep 5, 1:45 AM · Wikimedia-SVG-rendering
Glrx reopened T64986: librsvg does not support fallback font set (more than one font family) as "Open".
Tue, Sep 5, 1:43 AM · Wikimedia-SVG-rendering
Glrx added a comment to T64986: librsvg does not support fallback font set (more than one font family).

Reopen. Regression error.

Tue, Sep 5, 1:42 AM · Wikimedia-SVG-rendering
Glrx added a comment to T265549: Update librsvg to > 2.44.10.

To fix T344564 (font fallbacks), we need to upgrade to at least librsvg 2.48.5.

Tue, Sep 5, 1:34 AM · Packaging, Infrastructure-Foundations, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T344564: Font substitution for SVG file to PNG thumbnail replaces serif with sans-serif font.

The font specification is done with

style="font-family:Lato, &#x27;Helvetica Neue&#x27;, Helvetica, Arial, &#x27;Liberation Sans&#x27;, sans-serif;font-size:18px;background-color:white;text-rendering:geometricPrecision;-webkit-font-smoothing:antialiased"
style="font-family:&#x27;Playfair Display&#x27;, Georgia, &#x27;Times New Roman&#x27;, &#x27;Liberation Serif&#x27;, serif"
Tue, Sep 5, 1:32 AM · Thumbor, Wikimedia-SVG-rendering
Glrx added a comment to T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.

Another file is displayed incorrectly.

Tue, Sep 5, 1:26 AM · Thumbor, Upstream, Wikimedia-SVG-rendering

Aug 10 2023

Glrx added a comment to T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.

Another significant file on Commons that has the problem:

Aug 10 2023, 2:56 AM · Thumbor, Upstream, Wikimedia-SVG-rendering

Aug 9 2023

Glrx added a comment to T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.

This issue was fixed in the 2.40 C-version of librsvg.

Aug 9 2023, 3:41 PM · Thumbor, Upstream, Wikimedia-SVG-rendering

Jul 31 2023

Glrx updated the task description for T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.
Jul 31 2023, 2:04 AM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor

Jul 30 2023

Glrx merged T343095: Commons translate failing for image with a lot of elements into T270889: In SVG files larger than 256kB with <switch> elements, the translations are not recognized.
Jul 30 2023, 5:27 PM · I18n, Commons, MediaWiki-File-management
Glrx merged task T343095: Commons translate failing for image with a lot of elements into T270889: In SVG files larger than 256kB with <switch> elements, the translations are not recognized.
Jul 30 2023, 5:27 PM · Wikimedia-SVG-rendering
Glrx added a comment to T343095: Commons translate failing for image with a lot of elements.

It looks like the file does not have a translation in the first 256kB.

Jul 30 2023, 5:26 PM · Wikimedia-SVG-rendering
Glrx added a project to T343095: Commons translate failing for image with a lot of elements: Wikimedia-SVG-rendering.
Jul 30 2023, 5:23 PM · Wikimedia-SVG-rendering

Jul 16 2023

Glrx merged T336915: SVG text tspan anchor bug into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:37 PM · Thumbor, Upstream, Wikimedia-SVG-rendering
Glrx merged task T336915: SVG text tspan anchor bug into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:37 PM · Thumbor, Commons, Upstream, Wikimedia-SVG-rendering
Glrx merged T340379: SVG text rendering problem into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:34 PM · Thumbor, Upstream, Wikimedia-SVG-rendering
Glrx merged task T340379: SVG text rendering problem into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:33 PM · Wikimedia-SVG-rendering
Glrx added a comment to T340379: SVG text rendering problem.

This issue is a dup of T97233.

Jul 16 2023, 7:33 PM · Wikimedia-SVG-rendering
Glrx merged T336894: librsvg 2.44.10 causes a regression: <text> with text-anchor="middle" and multiple <tspan>s is misaligned into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:27 PM · Thumbor, Upstream, Wikimedia-SVG-rendering
Glrx merged task T336894: librsvg 2.44.10 causes a regression: <text> with text-anchor="middle" and multiple <tspan>s is misaligned into T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.
Jul 16 2023, 7:26 PM · Commons, Thumbor, Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T336894: librsvg 2.44.10 causes a regression: <text> with text-anchor="middle" and multiple <tspan>s is misaligned.

Renderer miscalculates the width of a text chunk.

Jul 16 2023, 7:25 PM · Commons, Thumbor, Upstream, Wikimedia-SVG-rendering

Jul 12 2023

Glrx merged T339239: Localized SVG labels stopped being rendered into T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.
Jul 12 2023, 3:30 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx merged task T339239: Localized SVG labels stopped being rendered into T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.
Jul 12 2023, 3:29 PM · Wikimedia-SVG-rendering
Glrx added a comment to T339239: Localized SVG labels stopped being rendered.

The SVG file displays Portuguese:

Jul 12 2023, 3:27 PM · Wikimedia-SVG-rendering
Glrx removed projects from T339239: Localized SVG labels stopped being rendered: Community-Tech, I18n, SVG Translate Tool.
Jul 12 2023, 3:12 PM · Wikimedia-SVG-rendering
Glrx reopened T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead as "Open".

Reopen. Fix not complete.

Jul 12 2023, 3:04 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

For the short term we can hack around this rather than worrying about building a new version which will take time due to the differences in rust build environments in Debian.

Doing the following I see valid images being generated with Window (windowing system).svg:

for i in ar en de ru fr tr; do LC_ALL="$i" /usr/bin/rsvg-convert Window.svg -u -f png -w 800 > $i.png; done

This change should hopefully address this. Thanks for the report and the handy repro cases!

Jul 12 2023, 3:01 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx merged T338472: subscripted numbers in PNG preview of svg files are not subscripted into T35245: Incorrect text positioning/kerning in SVG rendering (text/tspan x/y, dx/dy attribute; upstream).
Jul 12 2023, 5:22 AM · Thumbor, Wikimedia-SVG-rendering, Upstream
Glrx merged task T338472: subscripted numbers in PNG preview of svg files are not subscripted into T35245: Incorrect text positioning/kerning in SVG rendering (text/tspan x/y, dx/dy attribute; upstream).
Jul 12 2023, 5:21 AM · Wikimedia-SVG-rendering
Glrx removed a project from T338472: subscripted numbers in PNG preview of svg files are not subscripted: Thumbor.
Jul 12 2023, 5:20 AM · Wikimedia-SVG-rendering
Glrx added a comment to T338472: subscripted numbers in PNG preview of svg files are not subscripted.

The current version of the file uses Unicode subscripted numbers AND a dy attribute:

Jul 12 2023, 5:19 AM · Wikimedia-SVG-rendering

Jun 29 2023

Glrx added a comment to T336915: SVG text tspan anchor bug.

This appears to be the same bug as T97233. That bug claims to be fixed in librsvg 2.50.2.

Jun 29 2023, 6:30 PM · Thumbor, Commons, Upstream, Wikimedia-SVG-rendering
Glrx added a comment to T97233: Incorrect text positioning in SVG with tspan element and text-anchor attribute.

The problem is computing the width of an SVG "text chunk". If the text chunk consists of multiple XML nodes, then librsvg is using the width of the last node as the width of the entire text chunk. (librsvg is correctly tossing out the initial and final whitespace for the text element.)

Jun 29 2023, 6:20 PM · Thumbor, Upstream, Wikimedia-SVG-rendering

Jun 10 2023

Glrx updated the task description for T65236: Han characters in SVG files misplaced and clustered.
Jun 10 2023, 12:13 AM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

@Glrx: According to T65236#8458679 the SVG-file has been fixed, could you provide an image that currently provides this issue and edit the task-description. (Otherwise I find it unclear&confusing.)

@Dzahn: Could you provide the fc-list as you already did in T280718#7025405 ?

Jun 10 2023, 12:03 AM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering

Jun 6 2023

Glrx created T338196: Main pages of en.Wiki and Commons do not validate.
Jun 6 2023, 1:31 AM · Commons

May 29 2023

Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

I need to change the "File:Moscow metro map multilingual future draft.svg". If you still need it please fill free to revert to yesterday's version.

May 29 2023, 8:05 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

May 26 2023

Glrx added a comment to T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.

The right thing to do is avoid locales entirely and pass the langtag through --accept-languages, but that must wait for next version of the operating system.

Packaging our own librsvg version or backporting from bullseye should be more possible than it was on stretch, since most (all?) of the rust buildchain dependency issues should be solved. I don't know if anyone's looked at the feasibility of doing that recently though.

May 26 2023, 12:58 AM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

May 25 2023

Glrx added a comment to T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.

Thanks for the report and the test cases. This change attempts to build valid locales to fix both of the issues. I am curious as to whether our approach of using these languages in Thumbor when we used LANG rather than LC_ALL would have ever worked for these language tags.

May 25 2023, 6:45 PM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.

This bug affects a rather prominent SVG:

May 25 2023, 4:57 AM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx added a comment to T336917: Maximum execution time of 30 seconds exceeded.

IIRC, SVG Translate has defined the svg prefix

It's added the svg namespace if it's missing, but it hasn't renamed any existing nodes has it?

May 25 2023, 12:20 AM · Community-Tech (CommTech-Kanban), SVG Translate Tool

May 24 2023

Glrx added a comment to T336917: Maximum execution time of 30 seconds exceeded.

Some comments.

May 24 2023, 8:35 PM · Community-Tech (CommTech-Kanban), SVG Translate Tool

May 22 2023

Glrx added a comment to T337199: Multilingual SVG with non-English default language does not display English.

This bug should affect all multilingual SVG that does not use English as the default.

May 22 2023, 1:40 AM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

May 21 2023

Glrx updated the task description for T337199: Multilingual SVG with non-English default language does not display English.
May 21 2023, 3:17 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx updated the task description for T337199: Multilingual SVG with non-English default language does not display English.
May 21 2023, 2:55 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor
Glrx created T337199: Multilingual SVG with non-English default language does not display English.
May 21 2023, 2:48 PM · Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

May 20 2023

Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

T261192

May 20 2023, 6:23 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx created T337139: Hyphenated langtags in Thumbor/7.3.2 and librsvg 2.44.10 do not show any text.
May 20 2023, 6:05 PM · Patch-For-Review, Platform Team Workboards (Platform Engineering Reliability), Wikimedia-SVG-rendering, Thumbor Migration, Thumbor

May 19 2023

Glrx added a comment to T208578: SVG client side rendering for specific SVGs.

The approach is reasonable.

May 19 2023, 8:05 PM · Wikimedia-Hackathon-2023, MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), Performance Issue, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management

May 18 2023

Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

T280718: Re-evaluate whether keeping around https://noc.wikimedia.org/conf/fc-list is a good practive

May 18 2023, 9:24 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

Many Noto fonts are in the fc-list, but NotoSansCJK is not Even "CJK" is not in the fc-list.

May 18 2023, 8:52 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

I do not see NotoSansCJK in the fc-list.

May 18 2023, 7:48 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T336917: Maximum execution time of 30 seconds exceeded.

Duplicate en clauses had already been fixed.

May 18 2023, 7:03 PM · Community-Tech (CommTech-Kanban), SVG Translate Tool
Glrx added a comment to T336917: Maximum execution time of 30 seconds exceeded.

There is/was an issue with duplicate en clauses.
See https://commons.wikimedia.org/wiki/File_talk:2022_Russian_invasion_of_Ukraine.svg/Archive_4#SVG_Translate_trouble

May 18 2023, 6:53 PM · Community-Tech (CommTech-Kanban), SVG Translate Tool

May 15 2023

Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

SimHei and FZYXJW--GB1-0 are not in the font list copied at T280718 or the current https://noc.wikimedia.org/conf/fc-list

May 15 2023, 6:36 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

The file https://commons.wikimedia.org/w/index.php?lang=qct&title=File%3AHistory_of_the_Universe_%28multilingual%29.svg uses the default font and displays the langtags qcs and qct correctly. Says the default font displays Chinese correctly.

May 15 2023, 6:24 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

The file https://commons.wikimedia.org/wiki/File:History_of_the_Universe-zh-hant.svg has font-family="SimHei".

May 15 2023, 6:08 PM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering

May 9 2023

Glrx removed projects from T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead: Commons, MediaWiki-File-management.
May 9 2023, 3:50 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a project to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead: Wikimedia-SVG-rendering.
May 9 2023, 1:00 AM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor

May 8 2023

Glrx added a project to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead: Thumbor.
May 8 2023, 8:25 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

Generating new requests and looking at HTTP response headers suggest Thumbor version correlation:

May 8 2023, 8:19 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

https://commons.wikimedia.org/wiki/File%3AAbdomal_organs_body.svg may have the same problem. It's default language is English, but not all of its translations display. The set of working translations also varies. Right now, German (de) works but Spanish (es) displays English. The corresponding image URLs are

May 8 2023, 8:06 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor

May 1 2023

Glrx created T335654: SVG Translate github repo has paused Dependabot.
May 1 2023, 12:07 AM · SVG Translate Tool, Community-Tech

Apr 25 2023

Glrx added a comment to T335361: [Regression] systemLanguage="en" does not work anymore, it takes default instead.

When MW builds the page, it considers lang=en to be the default, so MW uses the src attribute

That URL does not specify a langtag for the SVG file.

Apr 25 2023, 6:03 PM · Patch-For-Review, Thumbor Migration, Wikimedia-SVG-rendering, Thumbor
Glrx added a comment to T106240: Colorable SVG.

I would decline this task.

Apr 25 2023, 5:42 AM · Structured-Data-Backlog, Structured Data Engineering, Wikimedia-SVG-rendering

Mar 21 2023

Glrx added a comment to T272133: Make all Postscript core 35 fonts available to SVG by installing some packages.

I would decline this feature request.

Mar 21 2023, 7:12 PM · Wikimedia-SVG-rendering

Mar 3 2023

Glrx added a comment to T5593: [Epic] SVG client side rendering.
In T5593#8664865, @Glrx wrote:

Translation is a small issue. Most users will not notice. If a French speaker just visits the fr.Wiki, then she will just see the French translations. It only gets weird when she visits the Japanese Wiki and starts seeing illustrations in French or English rather than Japanese. Technically, the issue can be avoided by localizing the SVG for each language wiki -- that's what is done now, but the localization is done just for the PNG and not for the SVG.

I would not call translation a small issue. Wikimedia sites have better language support than most user agents. Relying solely on browser language selection would prevent translation into all languages.

Mar 3 2023, 11:57 PM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management
Glrx added a comment to T5593: [Epic] SVG client side rendering.

Serving SVG or PNG should be determined by the SVG file size. What is the best way to handle that choice?

Mar 3 2023, 11:50 PM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management
Glrx added a comment to T134415: Provide tools for contributors to optimize SVG files.

I would decline this task. WMF is not in the tool business, and the tool would require enormous/impossible sophistication.

Mar 3 2023, 10:52 PM · Commons, Multimedia, Performance Issue, MediaWiki-File-management, Wikimedia-SVG-rendering
Glrx added a comment to T5593: [Epic] SVG client side rendering.

The only problem left seams to be the fear of security flaws that I still don't understand.

That's not entirely true. There are three main problems:

  1. Security (mostly solved by using <img> instead of direct embeds)
  2. Translation
  3. Fonts (Webfonts are generally unsupported in <img> tags, default font support for many languages is still poor)

There are also differences between browsers on specific element support and spec compliance.

Mar 3 2023, 8:15 PM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management
Glrx added a comment to T5593: [Epic] SVG client side rendering.

Many users want SVG served: https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2023/Multimedia_and_Commons#Native_SVG_support

Mar 3 2023, 7:49 PM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management

Mar 2 2023

Glrx added a comment to T134455: Add experimental option for direct SVG output via srcset.

That's all well and good, in that case, how are we to advance T5593 which has been languishing since 2005? That's nearly twenty years. I would like to see SVG Score output hopefully some time before the sun runs out of hydrogen and engulfs our planet in a fiery apocalypse.

Mar 2 2023, 10:48 PM · Patch-For-Review, MediaWiki-File-management, Commons, Multimedia, Wikimedia-SVG-rendering
Glrx added a comment to T134455: Add experimental option for direct SVG output via srcset.

This option is very clever. It was a way to efficiently offer both PNG and SVG.

Mar 2 2023, 6:15 PM · Patch-For-Review, MediaWiki-File-management, Commons, Multimedia, Wikimedia-SVG-rendering

Feb 9 2023

Glrx added a comment to T134407: Provide a way to reference fonts for client-side SVG rendering.

First, @font-face with src should not be used in the vast majority of SVG files. Most SVG files need only basic fonts that can be fulfilled with the sans-serif or serif generic fonts. Even if a graphic designer has a favorite font, graphics uploaded to Commons should use fallback fonts.

Feb 9 2023, 9:17 PM · Commons, Multimedia, Wikimedia-SVG-rendering, MediaWiki-File-management
Glrx added a comment to T134407: Provide a way to reference fonts for client-side SVG rendering.

In most cases, SVG should use generic fonts and be designed to work with substituted fonts.

Feb 9 2023, 6:12 PM · Commons, Multimedia, Wikimedia-SVG-rendering, MediaWiki-File-management

Jan 21 2023

Glrx created T327573: SVG Translate does not output translated clause..
Jan 21 2023, 3:41 AM · Community-Tech, SVG Translate Tool

Dec 11 2022

Glrx added a comment to T65236: Han characters in SVG files misplaced and clustered.

The SVG file https://commons.wikimedia.org/wiki/File:History_of_the_Universe-zh-hant.svg has been fixed.

Dec 11 2022, 6:49 AM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering

Nov 30 2022

Glrx added a comment to T134410: Evaluate SVG rendering compatibility in browsers.

Is any browser capable of showing png but not capable of showing svg out there left?

Nov 30 2022, 10:20 PM · Commons, Multimedia, MediaWiki-File-management, Wikimedia-SVG-rendering

Nov 3 2022

Glrx created T322365: Wikitext infobox description parameter has strange paragraph structure that adds break..
Nov 3 2022, 7:11 PM · MediaWiki-Parser

Oct 11 2022

Glrx added a comment to T316960: librsvg does not default x1, y1, x2, y2 correctly for userSpaceOnUse.

I presume you are using --zoom

Oct 11 2022, 7:49 PM · Upstream, Wikimedia-SVG-rendering

Oct 4 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

Testing notes

Thanks @dom_walden!


The first case does not have an xmlns: namespace declaration, but the second does.

The tool already adds the missing namespace if there isn't one.

I doubt that adding the namespace declaration changes the SVG file's elements. The document has already been parsed, so all the elements have had their namespace property set. SVG Translate is using a poor namespace model, so it will treat elements in the default namespace the same way as it would treat elements in the SVG namespace. SVG Translate uses getElementsByTagName() rather than getElementsByTagNameNS(). That poor model is also why the code separately checks for "svg:text". It should not be doing that. T316741: Allow svg namespace prefixes other than 'svg'

Oct 4 2022, 3:00 AM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool

Oct 3 2022

Glrx added a comment to T271000: Bad language code: zh_Hans should be zh-Hans.

I'm looking at tests/Model/Svg/SvgFileTest.php, and I see test cases such as the two starting at line 645

SvgFileTest.php
'CSS too complex' => [
    'svg' => '<svg><style>#foo { stroke:1px; } .bar { color:pink; }</style><text>Foo</text></svg>',
    'message' => 'structure-error-css-too-complex',
    'params' => [0 => ''],
],
'tref' => [
    'svg' => '<svg xmlns="http://www.w3.org/2000/svg" version="1.0" xmlns:xlink="http://www.w3.org/1999/xlink">
        <defs><text id="tref-id">Lorem</text></defs>
        <text id="text"><tref xlink:href="#tref-id" /></text></svg>',
    'message' => 'structure-error-contains-tref',
    'params' => [0 => 'text'],
],

The first case does not have an xmlns: namespace declaration, but the second does.

Oct 3 2022, 6:55 PM · Community-Tech (CommTech-Sprint-35), SVG Translate Tool