Page MenuHomePhabricator

GreenReaper (greenreaper)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 29 2014, 9:40 PM (246 w, 3 d)
Availability
Available
LDAP User
GreenReaper
MediaWiki User
GreenReaper [ Global Accounts ]

Recent Activity

Aug 28 2017

GreenReaper added a comment to T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.

Surely you're gonna have to migrate soon to the next beta/release versions?
I'm not sure how that's gonna be much different to just using 7.1 and upgrading to 7.2 later...

Aug 28 2017, 4:50 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser
GreenReaper updated the task description for T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.
Aug 28 2017, 4:45 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser
GreenReaper added a comment to T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.

Mostly because PHP 7.2 is more efficient, and I don't want to do another PHP version migration in a few months!
I have several days to do it, which is why I'm reporting it at all and didn't just put an @ on for now. ;-)

Aug 28 2017, 4:39 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser
GreenReaper added a comment to T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.

I've not used that feature before. I tried running it via the 'tap' method.
Many ParserIntegrationTest tests do not appear to pass with the above change, while they do with the original. So it's possibly not a great patch...

Aug 28 2017, 4:33 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser
GreenReaper updated the task description for T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.
Aug 28 2017, 4:09 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser
GreenReaper created T174354: MagicWordArray::parseMatch() uses each() function deprecated in PHP 7.2.
Aug 28 2017, 4:07 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-Parser

Dec 20 2016

GreenReaper added a comment to T69232: Hovercards: Redirect titles should be bolded in the extract.

Here's another example - mouse over "Camp Feral!" in the second sentence. Or you can create a link to [[Camp Feral!]] on any article in a preview, then mouseover the link. "Feral" is bolded but not the "Camp" before it, even though it is bold in the article.

Dec 20 2016, 6:40 PM · Readers-Web-Backlog (Design), Design, Page-Previews

May 23 2016

GreenReaper added a comment to T125283: Users occasionally logged in as different users after SessionManager deployment.

T125283-REL1_23.patch broke MediaWiki 1.23's raw action because it uses $wgUseXVO in the onView() function where it is not yet declared. This may result in a PHP Notice which breaks things served via Raw action (e.g. the JavaScript we store and serve from MediaWiki).

May 23 2016, 7:27 PM · MediaWiki-User-login-and-signup, Security, MediaWiki-extensions-CentralAuth

Jan 14 2016

GreenReaper added a comment to T122487: String warning appears on Special:Upload.

Unexpected non-MediaWiki exception encountered, of type "Exception"
[cacd8a6c] /wiki/Special:Upload Exception from line 3813 of [...]w/includes/User.php: null user val
Backtrace:
#0 [...]w/includes/specials/SpecialUpload.php(125): User->matchEditToken(NULL)
#1 [...]w/includes/specials/SpecialUpload.php(170): SpecialUpload->loadRequest()
#2 [...]w/includes/specialpage/SpecialPage.php(379): SpecialUpload->execute(NULL)
#3 [...]w/includes/specialpage/SpecialPageFactory.php(503): SpecialPage->run(NULL)
#4 [...]w/includes/Wiki.php(279): SpecialPageFactory::executePath(Title, RequestContext)
#5 [...]w/includes/Wiki.php(647): MediaWiki->performRequest()
#6 [...]w/includes/Wiki.php(506): MediaWiki->main()
#7 [...]w/index.php(46): MediaWiki->run()
#8 {main}

Jan 14 2016, 5:45 PM · MediaWiki-Special-pages, MW-1.23-release

Jan 7 2015

CennoxX awarded T69225: Hovercards: Space before removed parentheses should also be removed in the extract a Like token.
Jan 7 2015, 6:48 PM · Patch-For-Review, Page-Previews