Page MenuHomePhabricator

Hanna_Petruschat_WMDE
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2017, 9:54 AM (114 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Hanna Petruschat (WMDE) [ Global Accounts ]

Recent Activity

Mon, Oct 21

Hanna_Petruschat_WMDE closed T223452: Restyle "more languages" & "all languages" sections as Resolved.

Sweet! Thanks. Looks all good to me now! \o/

Mon, Oct 21, 10:59 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox

Oct 17 2019

Hanna_Petruschat_WMDE added a comment to T232595: Make it possible to collapse the "All entered languages" section when at the end of the section.

I saw that as well already but am hoping that these gaps are filled little by little rather than making things more complicated on our side by trying to hide one of these buttons if there is no entry at all.

Oct 17 2019, 3:48 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
Hanna_Petruschat_WMDE added a comment to T230231: Allow (semi-)automated resolution of edit conflicts on discussion pages.

After reviewing it again I figured that it would be more consistent to use the same interaction behaviour as for the edit conflict. That means:

  • we are showing a pop up the first time this special edit conflict happens.
  • The pop up gives an explanation on what is happening.
  • The user can click "Ok" and optionally set a checkmark to the "never show this again" option.
  • After closing the pop up it only shows the preview and the option to swith to the "general edit conflict resolution page"

This means, the mock above is outdated. I'm working on creating a new one. The new one will not show the explanatory text and illustration but only a short intro to the situation and then directly the proposed resolution in a preview.

Oct 17 2019, 3:20 PM · Patch-For-Review, Two-Column-Edit-Conflict-Merge, TCB-Team, Wikimania-Hackathon-2019
Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

Thanks for the update, @alaa_wmde . I'm afraid the vertical spacing is still not fixed. There is no padding between the last alias of a fingerprint and the following toggle button.
And I can't find the right ticket for this so I comment here: The background of the textboxes is still transparent instead of white.

Oct 17 2019, 3:15 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox

Oct 14 2019

Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

Let's talk about this one on Monday in person, I don't think I get the issue yet. Unless you are referring to the vertical spacing maybe? for which there's a fix in code-review atm.

You are totally right. This was referring to the vertical spacing. Sorry for the confusion.!

Oct 14 2019, 8:56 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE added a comment to T232595: Make it possible to collapse the "All entered languages" section when at the end of the section.

No apologies needed @alaa_wmde
I just like to explain UX decisions so everyone following or stumbling upon this task later has the chance to understand. Thanks for adding it to the AC!

Oct 14 2019, 8:34 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata

Oct 10 2019

Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

I just discovered, that in the real mobile Wikidata the styling of the section "in more languages" already happened but also causes that this section cannot be expanded. See screenshot below.

Oct 10 2019, 3:11 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE added a comment to T232595: Make it possible to collapse the "All entered languages" section when at the end of the section.

@alaa_wmde I would really like to add the "jumping back to the termbox" after collapsing "all entered languages" by clicking on the lower "fewer languages" button as an AC. Otherwise the meaning of the lower button is redundant as it is meant to keep the user from endless scrolling.

Oct 10 2019, 2:48 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata

Oct 7 2019

Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

Cool. Thanks a lot @alaa_wmde

Oct 7 2019, 12:53 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

Hi @alaa_wmde! Thaks for bringing this forward. I have a small remark. In the screenshot, the whole width of the categories have a background color, including the so called interaction column. In the mock up above you can see that the right side has a white strip. This will be important when the edit button will become a sticky button. It kinda gives the termbox editability a frame. To better understand the structure of the page, I put in a mock here.

Oct 7 2019, 10:29 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox

Sep 19 2019

Hanna_Petruschat_WMDE added a comment to T233290: Add temporary, always visible help and/or request for feedback message.

Hi @thiemowmde, Could you provide a screenshot of the site you're talking about. I'm not certain in which state this comes up und therefore it's hard to make a valid suggestion. Thanks!

Sep 19 2019, 1:49 PM · TCB-Team, WMDE-QWERTY-Team, Move-Files-To-Commons
Hanna_Petruschat_WMDE added a comment to T233109: Spike: How should users enable the reference preview feature?.

I agree to Raja. I would also choose option 1 as soon as both is out of beta. And then have the two options underneath each other, so the difference is clear.
I cannot see any other dependencies as of now.

Sep 19 2019, 1:44 PM · WMDE-QWERTY-Sprint-2019-09-25, Reference Previews

Aug 15 2019

Hanna_Petruschat_WMDE added a comment to T167047: Confusion between changes and revisions in visualisation.

Thanks for pointing it out. It definitely looks like it has been implemented incorrectly. I would vote to keep the dots and highlight the bars in a darker grey as well. As the second screenshot with brackt shows, it would be possible to only select one revision which is not really possible, afaik.
I'm happy to look at it together if you like. I'm currently sitting right outside the Rotundan hall at the "I {{}} templates" table.

Aug 15 2019, 9:41 AM · Design, TCB-Team, Revision-Slider

Aug 13 2019

Hanna_Petruschat_WMDE updated the task description for T230231: Allow (semi-)automated resolution of edit conflicts on discussion pages.
Aug 13 2019, 10:41 PM · Patch-For-Review, Two-Column-Edit-Conflict-Merge, TCB-Team, Wikimania-Hackathon-2019

Aug 5 2019

Hanna_Petruschat_WMDE closed T186202: Prepare test set up as Resolved.
Aug 5 2019, 11:29 AM · User-Testing, Design
Hanna_Petruschat_WMDE added a comment to T186202: Prepare test set up.

@Aklapper Thanks for the heads up, sorry for the spam. In the very hidden corner of my brain this shows the unsuccesful attempt of using phabricator as a task manager for individual tasks. Hence: I'll delete it.

Aug 5 2019, 11:27 AM · User-Testing, Design

Jul 25 2019

Pablo-WMDE awarded T217770: [Story] Never show anything from a language that is not currently Wikidata conform a 100 token.
Jul 25 2019, 8:07 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata

Jul 18 2019

Hanna_Petruschat_WMDE added a comment to T222884: Report failed save to users.

@Lea_WMDE I think it is fine. As the error message is that broad and the variations of errors very broad I guess we cannot get any more specific or give further instructions, warnings etc.

Jul 18 2019, 11:02 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Wikibase-Termbox-Iteration-20, Wikidata

Jul 15 2019

Hanna_Petruschat_WMDE closed T222886: Disable interactive elements while saving, a subtask of T219886: Unhappy Editing Paths, as Resolved.
Jul 15 2019, 3:45 PM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE closed T222886: Disable interactive elements while saving as Resolved.

Tested. Looks fine! Now really looking forward for the error message.

Jul 15 2019, 3:45 PM · Wikibase-Termbox-Iteration-20, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Termbox-Iteration-19, Wikidata
Hanna_Petruschat_WMDE added a comment to T222886: Disable interactive elements while saving.

Thanks! Is there a way to produce a failed publish action? @Tarrow (as Jakob is not available)

Jul 15 2019, 7:21 AM · Wikibase-Termbox-Iteration-20, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Termbox-Iteration-19, Wikidata

Jul 2 2019

Hanna_Petruschat_WMDE removed the point value for T222890: Show progress/activity if a save request is still being processed.
Jul 2 2019, 12:47 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikibase-Termbox-Iteration-20, Wikidata

Jul 1 2019

Hanna_Petruschat_WMDE created T227012: Create floating "publish" and "cancel" button.
Jul 1 2019, 4:25 PM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE created T227010: Create a floating edit button.
Jul 1 2019, 4:21 PM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T223452: Restyle "more languages" & "all languages" sections.
Jul 1 2019, 3:56 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox

Jun 17 2019

Hanna_Petruschat_WMDE closed T221831: Add "You are not logged in" overlay popup on termbox editing as Resolved.

Sorry for the long wait but finally \o/

Jun 17 2019, 7:48 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Hanna_Petruschat_WMDE closed T221831: Add "You are not logged in" overlay popup on termbox editing, a subtask of T219158: 'IP visibility' and 'Terms of use' information on termbox editing, as Resolved.
Jun 17 2019, 7:47 AM · Wikidata, Wikidata-Termbox

Jun 14 2019

Hanna_Petruschat_WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

@Pablo-WMDE thanks for documenting this! I was going a bit further with it, trying to create a new account as well. Here is what happened:

  1. click "edit pen"
  2. click "Create an Account" in the overlay
  3. create an account page in desktop version opens
  4. created an account
  5. get redirected to the item page I came from (now also in desktop version)
  6. switch to mobile by clicking the "mobile version" link
  7. checking, if I'm still logged in (I'm not)
Jun 14 2019, 9:26 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

Jun 13 2019

Hanna_Petruschat_WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

Regarding the notice: When logging in I got redirected to the desktop version and needed to switch back to mobile. When doing so, I also got the the notice. I could click it away but got it back when reloading as it stated. @Pablo-WMDE if you like, you can test and reproduce on my machine.

Jun 13 2019, 3:29 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Hanna_Petruschat_WMDE added a comment to T221835: Add CC0 License overlay popup on termbox editing.

I agree @Pablo-WMDE

Jun 13 2019, 3:09 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17, Wikidata

Jun 4 2019

Hanna_Petruschat_WMDE updated the task description for T222884: Report failed save to users.
Jun 4 2019, 9:27 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Wikibase-Termbox-Iteration-20, Wikidata
Hanna_Petruschat_WMDE updated the task description for T222780: Disallow duplicate information in Termbox.
Jun 4 2019, 9:24 AM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T222886: Disable interactive elements while saving.
Jun 4 2019, 9:03 AM · Wikibase-Termbox-Iteration-20, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Termbox-Iteration-19, Wikidata

May 31 2019

Hanna_Petruschat_WMDE added a comment to T222886: Disable interactive elements while saving.

I "messed up" with the IP overlay, not being aware that every other overlay in the Wikiworld works with 50% white and not with 25% black as I initially specified. So we might want to adapt to the white version here and make this small change in the IP and license overlay as well. I post it as a comment an will raise this question in the next team meeting (daily or sprint start?).

May 31 2019, 8:24 AM · Wikibase-Termbox-Iteration-20, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Termbox-Iteration-19, Wikidata

May 28 2019

Hanna_Petruschat_WMDE added a comment to T222891: Inform users if there was no response from the server.

@Tarrow Thanks for the write up!
One more suggestion: Assuming that no one likes to see an error message and we already know, that hitting publish again could solve the issue: Could we automatically hit publish again in the background when we didn't hear back from the server and only if it doesn't work after 3 tries we then let the user know that unfortunately they have to reload because we didn't manage?

May 28 2019, 9:57 AM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T224452: Unable to browse the drop-down menu for new properties on iPhone.
May 28 2019, 8:25 AM · Wikidata

May 27 2019

Hanna_Petruschat_WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

Checking back with other UX peeps I'd suggest having the tab set to the element before the CTA so you would only be one keyboard hit away from focussing it but not distract users by visual differences which are not made use of anywhere elyse.

May 27 2019, 3:04 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 24 2019

Hanna_Petruschat_WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

Hi @Pablo-WMDE , sorry for the late reply. Also: I cannot really get this discussion to a farther point I asssume. If I look at the initial fonts on my machine, they appear all way heavier than the ones represented in the OOUI demos. I played around with the font weight to get to the numbers mentioned above. So maybe it's okay to not see a difference on your device?

May 24 2019, 3:12 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 20 2019

Hanna_Petruschat_WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

Hi Jakob. Thanks a lot for the link. It mostly looks great. I have a few picky remarks.

May 20 2019, 11:03 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Hanna_Petruschat_WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

@Pablo-WMDE Thanks for the input. I was under the assumption, that the input field will be in focus if there is no pop up. I remember discussing it earlier but I do not remember when and under which task. @Lea_WMDE Do you remember if there has been a concious decision made?

May 20 2019, 9:11 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Hanna_Petruschat_WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

It probably does not make T205608: Floating button to collapse „All entered languages“ go away. The design may change, but the sticky element at the bottom of the screen should remain.

May 20 2019, 8:14 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

I wonder how that interacts with the focus of input fields. I would assume, that the first text input field is focused rather than the publish button?

May 20 2019, 7:56 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Hanna_Petruschat_WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

Agreed

May 20 2019, 7:13 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 16 2019

Hanna_Petruschat_WMDE updated the task description for T223452: Restyle "more languages" & "all languages" sections.
May 16 2019, 2:22 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Termbox

May 2 2019

Hanna_Petruschat_WMDE moved T218690: Show each alias in a separate line in edit mode from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-14 board.

looks perfectly fine to me \o/

May 2 2019, 4:04 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata
Hanna_Petruschat_WMDE moved T215951: Cancel edit mode to return to reading mode from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-14 board.

Successfully tested and happy. \o/

May 2 2019, 4:00 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata, Epic

Apr 29 2019

Hanna_Petruschat_WMDE added a comment to T221833: Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice.

Thanks @Pablo-WMDE. This is exactly what I was going for.

Apr 29 2019, 8:18 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata

Apr 26 2019

Hanna_Petruschat_WMDE added a comment to T218690: Show each alias in a separate line in edit mode.

Update to the "publish when clicking cancel" issue: It only shows the entry directly after clicking cancel. When reloading, it's gone...

Apr 26 2019, 2:18 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata
Hanna_Petruschat_WMDE added a comment to T218690: Show each alias in a separate line in edit mode.

Hi @Jakob_WMDE
I tested and found some issues. Some are not 100% related to this task, but I'll note them all here to not forget them.

Apr 26 2019, 2:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata

Apr 25 2019

Hanna_Petruschat_WMDE updated the task description for T221835: Add CC0 License overlay popup on termbox editing.
Apr 25 2019, 4:57 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17, Wikidata
Hanna_Petruschat_WMDE updated the task description for T221836: Add the "I accept these terms for my future edits" checkbox to License popup on mobile termbox editing, and remember the choice.
Apr 25 2019, 4:54 PM · Wikidata-Termbox-Iteration-18, Wikidata-Termbox-Iteration-17, Wikidata
Hanna_Petruschat_WMDE added a comment to T221835: Add CC0 License overlay popup on termbox editing.

Note to myself and you: What happens, if users do not check the accept line? Will the pop up be shown over and over again?
I believe that's what is currently happening on desktop, right?

Apr 25 2019, 4:51 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17, Wikidata
Hanna_Petruschat_WMDE added a comment to T221833: Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice.

Follow up question: Does this action need to be accompanied by a cookie pop up? Do we actually have stuff like that for Wikidata at all?

Apr 25 2019, 4:49 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Hanna_Petruschat_WMDE updated the task description for T221831: Add "You are not logged in" overlay popup on termbox editing.
Apr 25 2019, 4:45 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

Apr 17 2019

Hanna_Petruschat_WMDE added a comment to T218690: Show each alias in a separate line in edit mode.

@Pablo-WMDE I've the following suggestion:
Use the background highlight and define it like this

  • have the background set to Accent90 (#EAF3FF)
  • have the text entry in the focused input set to Base20 (#222)
Apr 17 2019, 10:22 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata
Hanna_Petruschat_WMDE added a comment to T216987: Allow editing of fields.

I will check back with @Hanna_Petruschat_WMDE , but my vague memory tells me she was against newlines, and we wanted to have text wraps anyways, so sounds great to me.

Apr 17 2019, 9:40 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata-Termbox-Iteration-12 ✓, Wikidata-Termbox-Iteration-11

Apr 16 2019

Hanna_Petruschat_WMDE added a comment to T218690: Show each alias in a separate line in edit mode.

@Pablo-WMDE Thanks for the heads up. I totally agree to commit to this especially looking towards accessibility (tab and highlight...)

Apr 16 2019, 3:16 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata

Apr 15 2019

Hanna_Petruschat_WMDE updated the task description for T220970: Upload Cross Asset or determine use of a font cross.
Apr 15 2019, 3:27 PM · Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata
Hanna_Petruschat_WMDE added a comment to T220970: Upload Cross Asset or determine use of a font cross.

Find the asset here. Color to be applied is Base 20. I'll update the description...

Apr 15 2019, 3:26 PM · Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata

Apr 10 2019

Hanna_Petruschat_WMDE added a comment to T220396: Label, Description textarea focus styling.

Yes. That's right, @Tarrow. I try to move over to these "accent50" color codes step by step.

Apr 10 2019, 7:03 PM · Patch-For-Review, Wikidata-Termbox-Iteration-13
Hanna_Petruschat_WMDE added a comment to T220373: Add placeholders to empty labels, descriptions, and aliases in editmode.

I adapted the task description regarding the font-family and the color.
I'm not sure what to think of the position block.

Apr 10 2019, 10:23 AM · Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T220373: Add placeholders to empty labels, descriptions, and aliases in editmode.
Apr 10 2019, 10:19 AM · Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T220381: Color edit/save button according to its state.
Apr 10 2019, 10:13 AM · Patch-For-Review, Wikidata-Termbox-Iteration-13
Hanna_Petruschat_WMDE updated the task description for T218690: Show each alias in a separate line in edit mode.
Apr 10 2019, 10:05 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata
Hanna_Petruschat_WMDE updated the task description for T216987: Allow editing of fields.
Apr 10 2019, 10:02 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata-Termbox-Iteration-12 ✓, Wikidata-Termbox-Iteration-11
Hanna_Petruschat_WMDE added a comment to T220183: prevent newlines in term fields.

@Pablo-WMDE
Nope. This is my missing ability to define this as needed in tech tongue (I was even googling a "correct" term and apparently didn't come across one)

Apr 10 2019, 9:02 AM · Wikidata-Termbox-Iteration-13, Patch-For-Review, Wikidata-Termbox-Iteration-12 ✓

Apr 8 2019

Hanna_Petruschat_WMDE updated the task description for T220396: Label, Description textarea focus styling.
Apr 8 2019, 2:39 PM · Patch-For-Review, Wikidata-Termbox-Iteration-13
Hanna_Petruschat_WMDE updated the task description for T218690: Show each alias in a separate line in edit mode.
Apr 8 2019, 10:44 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata-Termbox-Iteration-14, Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata

Apr 5 2019

Hanna_Petruschat_WMDE updated the task description for T220183: prevent newlines in term fields.
Apr 5 2019, 5:32 PM · Wikidata-Termbox-Iteration-13, Patch-For-Review, Wikidata-Termbox-Iteration-12 ✓
Hanna_Petruschat_WMDE updated the task description for T220185: let term fields grow to initial value height.
Apr 5 2019, 11:00 AM · Wikidata-Termbox-Iteration-13, Patch-For-Review, Wikidata-Termbox-Iteration-12 ✓

Apr 1 2019

Hanna_Petruschat_WMDE added a comment to M241: WikimediaUI: Messages (Errors, Warnings, Successes, Notices).

My 2 cents:
I like the borderless approach. Makes sense to keep the attraction at the content itself.
Feedback I got for the circular ! icon is it looks too similar to an info-i. I could see the stop sign icon showing the significance an error message needs.

Apr 1 2019, 7:18 AM · WMDE-Design, UI-Standardization

Mar 19 2019

Hanna_Petruschat_WMDE added a comment to T218572: Switch to edit mode.

find the specs for Editing fields below:

  • The input filed has the text heights plus 8px padding to each side
  • it is depicte by a 1px inside border in Base50
  • it has 2px radiuses
  • between text fields we have 8px padding
  • it contains placeholder text when no input exists (see specs for that in the parent task)
  • the input field allows line breaks and adjusts in heights according to that
  • the input field spans over the defined width of the "content" column
Mar 19 2019, 5:21 PM · Wikidata-Termbox-Iteration-12 ✓, Patch-For-Review, Wikidata-Termbox-Iteration-11
Hanna_Petruschat_WMDE added a comment to T216720: Research: floating button [1*4h].

Thanks @Tarrow.
From a UX perspective that sounds wonderful!

Mar 19 2019, 1:47 PM · Wikidata-Termbox-Iteration-11
Hanna_Petruschat_WMDE updated the task description for T218573: Add the publish button.
Mar 19 2019, 10:54 AM · Wikidata-Termbox-Iteration-12 ✓, Patch-For-Review, Wikidata-Termbox-Iteration-11
Hanna_Petruschat_WMDE added a comment to T217770: [Story] Never show anything from a language that is not currently Wikidata conform.

Thanks @Pablo-WMDE for the summary. To add a little to the latter...

Mar 19 2019, 8:36 AM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata

Mar 18 2019

Hanna_Petruschat_WMDE created T218540: Blue devider line runs over shadowed box (Layout bug).
Mar 18 2019, 8:33 AM · WMDE-Fundraising-Tech, WMDE-FUN-Team

Mar 15 2019

Hanna_Petruschat_WMDE added a comment to T217770: [Story] Never show anything from a language that is not currently Wikidata conform.

@Pablo-WMDE Thanks for looking into it. There are two things:

Question: what was the language (code) we tried to display in that row? mw.uls.getFrequentLanguageList() executed on this user's browser would make for an interesting read - any chance to get to this?

Mar 15 2019, 10:08 AM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata

Mar 14 2019

Hanna_Petruschat_WMDE added a comment to T216720: Research: floating button [1*4h].

to get a better understanding I could see things work like the following examples
the edit pen could behave like the "Spenden" button on the right side: 1. fixed position, 2. scroll and stick/float, 3. scroll out

Mar 14 2019, 5:09 PM · Wikidata-Termbox-Iteration-11
Hanna_Petruschat_WMDE updated the task description for T216720: Research: floating button [1*4h].
Mar 14 2019, 3:31 PM · Wikidata-Termbox-Iteration-11

Mar 13 2019

Hanna_Petruschat_WMDE added a comment to T215951: Cancel edit mode to return to reading mode.

Does the current termbox always has a focused form field? Therefore will there always be the possibility to cancel by pressing esc?
And for the sake of consistency: If this is a common action to use, I would keep it. I don't see an obvious reason to not have this as "a feature".

Mar 13 2019, 5:56 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata, Epic
Hanna_Petruschat_WMDE added a comment to T217034: Handle multiline text input in editing mode.

I would go with one growing text field, no matter if this is a line or an actual field aka a box. This makes it clear that we are talking about one thing while a lot of lines would make the destinction harder to figure out where an element starts and where it ends...

Mar 13 2019, 2:47 PM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE added a comment to M241: WikimediaUI: Messages (Errors, Warnings, Successes, Notices).

Hi @Volker_E. Thanks a lot for building up on the earlier mocks. My two cents:
WCAG:

  • Checking Color Contrast I think we might be in muddy waters by putting red50 on red90.
  • This also applies to the yellow icon on fff background unfortunately.
Mar 13 2019, 9:55 AM · WMDE-Design, UI-Standardization

Mar 6 2019

Hanna_Petruschat_WMDE created T217770: [Story] Never show anything from a language that is not currently Wikidata conform.
Mar 6 2019, 1:57 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata

Feb 28 2019

Hanna_Petruschat_WMDE added a comment to T204439: new constraint level for suggestions.

As just discussed, here are the adjusted icons:

Feb 28 2019, 4:20 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Design, WMDE-Design, Wikibase-Quality-Constraints, Wikidata

Feb 27 2019

Hanna_Petruschat_WMDE updated the task description for T217000: Show placeholders for label, description and alias.
Feb 27 2019, 4:07 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata
Hanna_Petruschat_WMDE updated the task description for T215951: Cancel edit mode to return to reading mode.
Feb 27 2019, 3:54 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata, Epic
Hanna_Petruschat_WMDE updated the task description for T217000: Show placeholders for label, description and alias.
Feb 27 2019, 3:42 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata

Feb 26 2019

Hanna_Petruschat_WMDE moved T214898: Adjust termbox break points to minerva skin breakpoints from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-10 board.

Thanks @Jakob_WMDE! Looks goood...
I checked of the "no hacks"-acceptance criteria as well.

Feb 26 2019, 7:44 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8
Hanna_Petruschat_WMDE updated the task description for T214898: Adjust termbox break points to minerva skin breakpoints.
Feb 26 2019, 7:43 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8
Hanna_Petruschat_WMDE closed T214898: Adjust termbox break points to minerva skin breakpoints as Resolved.
Feb 26 2019, 7:41 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8

Feb 18 2019

Hanna_Petruschat_WMDE added a comment to T178745: Highlight statement(s) when using "#P" in URL.

Thanks for following up on that @Ivanhercaz and giving input @abian.

Feb 18 2019, 4:21 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Design, patch-welcome, good first bug, WMDE-Design, MediaWiki-extensions-WikibaseRepository, Wikidata
Hanna_Petruschat_WMDE moved T214898: Adjust termbox break points to minerva skin breakpoints from Test (Product Review) to To Do on the Wikidata-Termbox-Iteration-9 board.
Feb 18 2019, 3:18 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8
Hanna_Petruschat_WMDE updated the task description for T214898: Adjust termbox break points to minerva skin breakpoints.
Feb 18 2019, 3:17 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8
Hanna_Petruschat_WMDE added a comment to T214898: Adjust termbox break points to minerva skin breakpoints.

Thanks for sharing. I've one tiny remark, which will make a difference in the future, when more interactive elements will be introduced:
Could you please adjust the minimum width of the content box from 260px (current) to 244px (as defined).

Feb 18 2019, 3:16 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8

Feb 14 2019

Hanna_Petruschat_WMDE updated the task description for T215522: Switch from reading into editing mode.
Feb 14 2019, 5:58 PM · Wikidata, Wikidata-Termbox

Feb 12 2019

Hanna_Petruschat_WMDE created T215951: Cancel edit mode to return to reading mode.
Feb 12 2019, 7:20 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Termbox-Iteration-14, Wikidata-Termbox-Iteration-13, Wikidata, Epic
Hanna_Petruschat_WMDE updated the task description for T215522: Switch from reading into editing mode.
Feb 12 2019, 7:10 PM · Wikidata, Wikidata-Termbox
Hanna_Petruschat_WMDE updated the task description for T215522: Switch from reading into editing mode.
Feb 12 2019, 7:05 PM · Wikidata, Wikidata-Termbox

Feb 11 2019

Hanna_Petruschat_WMDE updated the task description for T214898: Adjust termbox break points to minerva skin breakpoints.
Feb 11 2019, 10:49 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8
Hanna_Petruschat_WMDE added a comment to T214898: Adjust termbox break points to minerva skin breakpoints.

The specs for the "In more languages" Text are the following for

Feb 11 2019, 10:45 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Patch-For-Review, Wikidata-Termbox-Iteration-8