Task Breakdown Notes

• To make sure we understand correctly, we won't update table's breakpoint, because it will be updated in a different task T348271, is it correct @Sarai-WMDE ?
• We need some clarification regarding which tokens are part of the scope of this task. For example; it is not completely clear if Dimensions/Spacing section is part of this task or T348732. May we please have a clear division between the tasks? @Sarai-WMDE

Task Breakdown Notes

• No need to breakdown for now

Task Breakdown Notes
After further discussion, we believe the scope of this task is not reflected in its description. Creating this as language agnostic custom variables system requires more investigation. We are stalling this task until further discussion is possible.

This one is related to multiple PRs:

@Sarai-WMDE Thank you for great feedback! I have addressed your comments in a PR, it'd be great to have your review!

@Sarai-WMDE Great catch, thanks! I have applied your suggestions and they work like a charm :) Now, I will move the task to peer review again and will ping you for the final verification!

PR: https://github.com/wmde/wikidata-mismatch-finder/pull/773

So sorry, I missed this one @noarave

I think we should migrate to Vue@3 first because we are having issues with multiple composition-api instances with current vue@2.6 setup. There are different versions of composition-api, it makes another mess.
Further info: https://github.com/vuejs/composition-api/issues/792

We have added the fix to the most recent code, but it's not on staging right now. Should we proceed anyways? @Arian_Bozorg

PR: #710

It's decided to go with stylelint-stylistic instead of prettier, therefore I'm closing this one.

PR: #6

In T343344#9205949, @noarave wrote:

@HasanAkgun_WMDE gladly, but you need to link the code in the task for us to be able to do that

In T343344#9205608, @noarave wrote:

@HasanAkgun_WMDE I cannot peer review if I don't know what is to be reviewed :)

@Sarai-WMDE I have 2 questions regarding the final design:
1 . How should it look like between breakpoints? I mean, with 550px width, should it look like tablet design or mobile design?

2. How should it look like at breakpoints? For example; at exactly 320px width should it look like tablet design or mobile design?

After some time, it turned out that stylelint doesn't work at all and it finds more than 90 errors after making it work again. Changing the status to stalled until have a decision about whether using stylelint at all or not.

In T295601#9113046, @noarave wrote:

In T295601#7780925, @hashar wrote:

I supposed the code is somewhere in https://github.com/dependabot/dependabot-core/ but I could not find out how ---\n is injected :-\

Could it be somehow coming from Addbot?