See, there are a lot of people authoring on instances of this software, and with every day serious or even subtle bugs are not worked on here, 'creative' workarounds in these instances are written and developed that are hard to impossible to revert later on. Because, just as is here, emotions of the workaround authors do play a role if they are to adopt a (then official) feature that renders the workaround irrelevant.

Ok, no hard feelings. I didn't expect "people" being offended by the comment. I just don't feel this is moving things forward, technically. Some bugs are pending since months with no constructive input which is also a tad frustrating.

@A_smart_kitten Please step back. I did not assault you in any way whatsoever. I have expressed my concerns about the project in general and there is no wrong place to do so. If you feel this has been tailored in any way to you, it was not. I uphold my argument that time spent elsewhere is time better invested.

@A_smart_kitten If you need a consent to close this task, just leave it as is, any string is fine.

In T408401#11318421, @A_smart_kitten wrote:

@Hechtsuppe, how would you prefer to be attributed in the MediaWiki CREDITS file (also visible at Special:Version/Credits)?

The rules are not completely battle tested, hence the bug report. The report is not here to offend anyone, but to fix a problem that has not been noticed at (initial) roll out of the feature. However, the replacement rules do not divert very much from the previous ones, they just work for nested cases too.

The patch does not invert your argument. It still targets the standard case, it just does so in a more predictable and consistent manner. If you ever have authored template styles with the wiki extension, you do appreciate consistent help pages.

This is a follow-up on T391800 with more things done right. The specifity of the CSS was bogus in the past and there is nothing wrong with having images in figcaptions.

Implementation variant

The CSS variable name --skin-invert-saturate has been chosen as to be descriptive and
not hinder future additions to the CSS / less code that might need the term saturate in other context.

The acceptance of the dark-mode usability enhancements, specifically rendering of inverted images, does highly benefit from these changes.

@Pppery: rechecked https://gerrit.wikimedia.org/r/1156449

@Pppery: rechecked https://gerrit.wikimedia.org/r/1156449

The patch original depended on T288498 because it used the each() function of lesscss not yet ported to less.php.
It has been rewritten to cope without each().

The patch relocates some comments.