Page MenuHomePhabricator

HuiZSF (Hui)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 12:12 AM (235 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Hzhaosf [ Global Accounts ]

Recent Activity

Apr 5 2016

HuiZSF added a comment to T97726: Products page has no featured image.
  1. Is the location collections/all public? I mean, I didn't find any handle to set this url in the online store. And I didn't find any link within the online store that points to this url.
  2. Apparently it's not a problem with the theme, but we didn't set up a head image for the products collection all.
Apr 5 2016, 10:34 PM · Wikimedia-Shop

Feb 24 2016

HuiZSF added a comment to T63528: shop switches HTTPS -> HTTP when showing login prompt (on clicking checkout).

Seems shopify only use https for checkout transaction.
Similar report earlier in last year:
https://phabricator.wikimedia.org/T96749

Feb 24 2016, 5:00 AM · Operations, Traffic, HTTPS, Wikimedia-Shop

Jul 1 2015

violetto awarded T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description) a Pterodactyl token.
Jul 1 2015, 9:18 PM · Shop-Theme
HuiZSF added a comment to T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description).

@MNguyen
Updated. Thank you :)

Jul 1 2015, 7:47 PM · Shop-Theme
HuiZSF added a comment to T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description).

Updated.
Now the login form and password recover form will alternatively appear in the exactly same position.

Jul 1 2015, 6:08 PM · Shop-Theme
HuiZSF closed T99031: Provide the ability to view prices in multiple currencies as Resolved.
Jul 1 2015, 5:34 PM · Shop-Theme

Jun 24 2015

HuiZSF added a comment to T96749: Bug: Login page does not default to HTTPS.

@K4-713 @vshchepakina
I have updated login page liquid and added a JS snippet to force all access to be redirected to https.
However, this is not the best solution, it may affect SEO of the website.
Please figure out a way to achieve this request on the server side.

Jun 24 2015, 9:25 PM · Shop-Theme
HuiZSF added a comment to T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description).

@violetto
The 3 forms are actually on the same page now, but visually separated to 2 pages.

Jun 24 2015, 7:28 PM · Shop-Theme

Jun 22 2015

HuiZSF added a comment to T99031: Provide the ability to view prices in multiple currencies.


Updated the preview theme.
The border color is different from the spec as the picker is placed next to the cart button in this preview.
And added the flag for each option. Does it look good? @violetto @goenning

Jun 22 2015, 7:48 PM · Shop-Theme
HuiZSF added a comment to T99031: Provide the ability to view prices in multiple currencies.

@violetto
Got it.
It's able to add flags to the rest of options. And I will unify the appearance with the spec soon when we decide the new locate of the currency picker.

Jun 22 2015, 6:39 PM · Shop-Theme
HuiZSF added a comment to T99031: Provide the ability to view prices in multiple currencies.

New drop-down menu appearance

Jun 22 2015, 5:38 PM · Shop-Theme

Jun 19 2015

HuiZSF closed T98792: Left/Right Margins of Artist Profile Content as Resolved.
Jun 19 2015, 9:54 PM · Wikimedia-Shop
HuiZSF closed T101911: Need a decision to line up Instagram feed with other parts on the home page as Resolved.
Jun 19 2015, 9:53 PM · Shop-Theme

Jun 18 2015

HuiZSF closed T102722: Space issues under artist profile as Resolved.
Jun 18 2015, 4:58 PM · Shop-Theme
HuiZSF added a comment to T102722: Space issues under artist profile .

Double checked with @vshchepakina
No problem :)

Jun 18 2015, 4:58 PM · Shop-Theme

Jun 16 2015

HuiZSF added a comment to T102722: Space issues under artist profile .

@violetto
Um, couldn't reproduce this issue on my phone and responsive testing tools...

Jun 16 2015, 11:45 PM · Shop-Theme
HuiZSF added a comment to T102691: Change the position of arrows closer to the edge. .

Updated...

Jun 16 2015, 8:23 PM · Shop-Theme

Jun 12 2015

HuiZSF closed T102022: Request vector images for social icons as Resolved.
Jun 12 2015, 1:02 AM · Shop-Theme

Jun 11 2015

HuiZSF added a comment to T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description).

Updated new login page.
Click Forgot password? will switch the page content to password recovery form, and stay in the same page.
Click Back to login will switch the login and register forms back.
The reason is, I did not find a way to add a separated sub page for password form under link store.wikimedia.org/account.
Also modified toolbar entrance for login and register as Login.

Jun 11 2015, 5:01 PM · Shop-Theme

Jun 10 2015

HuiZSF added a comment to T99031: Provide the ability to view prices in multiple currencies.

@violetto @vshchepakina
As we will merge login and register pages, so we will get more room in the toolbar. I made a mockup of the currencies picker menu here:

Jun 10 2015, 7:26 PM · Shop-Theme
HuiZSF moved T102022: Request vector images for social icons from Backlog to Next Up on the Shop-Theme board.
Jun 10 2015, 5:39 PM · Shop-Theme
HuiZSF created T102022: Request vector images for social icons.
Jun 10 2015, 5:38 PM · Shop-Theme
HuiZSF closed T86422: [Mobile] Safari: When scrolling down, Search function / All Collections is visible but not accessible as Resolved.
Jun 10 2015, 12:20 AM · Shop-Theme
HuiZSF closed T86384: [Mobile] Page is able to zoom out as Resolved.
Jun 10 2015, 12:13 AM · Shop-Theme
HuiZSF added a comment to T86384: [Mobile] Page is able to zoom out.

This problem has been already resolved :D

Jun 10 2015, 12:13 AM · Shop-Theme

Jun 9 2015

HuiZSF moved T101911: Need a decision to line up Instagram feed with other parts on the home page from Backlog to Next Up on the Shop-Theme board.
Jun 9 2015, 11:57 PM · Shop-Theme
HuiZSF created T101911: Need a decision to line up Instagram feed with other parts on the home page.
Jun 9 2015, 11:33 PM · Shop-Theme

Jun 8 2015

HuiZSF updated subscribers of T86418: [Web] Log-In / Register Pages - Eliminate Register page & combine it with Log-In page, provide link to redirect to separate Forgot Password page, (more in description).

@MNguyen, @violetto, @vshchepakina
Created this page and here is the screenshot.
If no problem I will update the code soon.
Also, in the toolbar, Login / Register is ok?

Jun 8 2015, 10:41 PM · Shop-Theme

Jun 5 2015

violetto awarded T98109: Line and photo don't line up a Pterodactyl token.
Jun 5 2015, 6:03 AM · Shop-Theme

Jun 4 2015

HuiZSF closed T97317: [Mobile] Footer isn't organized properly. as Resolved.
Jun 4 2015, 11:28 PM · Shop-Theme
HuiZSF closed T98250: [Desktop - Safari] "scroll up" shows a secondary menu (see image) as Resolved.
Jun 4 2015, 10:35 PM · Shop-Theme
HuiZSF updated subscribers of T98250: [Desktop - Safari] "scroll up" shows a secondary menu (see image).

I have restricted the off-navigation layer not to show on width > 992px of screen.
Could you please try again on safari @vshchepakina @goenning?

Jun 4 2015, 10:12 PM · Shop-Theme
HuiZSF closed T88607: [Ipad & Mobile] Lapel Pin page description overlaps footer as Resolved.
Jun 4 2015, 9:58 PM · Shop-Theme
HuiZSF closed T88608: [Ipad] "Men" link missing from left slide menu as Resolved.
Jun 4 2015, 9:58 PM · Shop-Theme
HuiZSF added a comment to T88608: [Ipad] "Men" link missing from left slide menu.

This problem has been resolved. It does not exist on the new theme anymore...

Jun 4 2015, 9:58 PM · Shop-Theme
HuiZSF added a comment to T98792: Left/Right Margins of Artist Profile Content.

@MNguyen
Updated padding of .vendor_container to 2em 0.1em to achieve this request.

Jun 4 2015, 9:21 PM · Wikimedia-Shop
HuiZSF closed T97318: [Mobile] Text looks too big on mobile. as Resolved.
Jun 4 2015, 7:52 PM · Shop-Theme
HuiZSF added a comment to T97317: [Mobile] Footer isn't organized properly. .

@MNguyen
Updated CSS. Now it looks better on mobile screen! :D

Jun 4 2015, 7:49 PM · Shop-Theme
HuiZSF added a comment to T97318: [Mobile] Text looks too big on mobile..

Added rule to solve this problem:

Jun 4 2015, 6:28 PM · Shop-Theme
HuiZSF added a comment to T99031: Provide the ability to view prices in multiple currencies.

I'm working on this task currently. @vshchepakina @violetto
I need a decision of that where should we place the currencies menu on the page.

Jun 4 2015, 12:40 AM · Shop-Theme
HuiZSF added a comment to T98250: [Desktop - Safari] "scroll up" shows a secondary menu (see image).

This issue might be caused by this element: <div id="off-navigation">
I will try to add a rule to allow this element only to show at the screen's width less than 768px.

Jun 4 2015, 12:37 AM · Shop-Theme

Jun 3 2015

HuiZSF closed T88184: Add an arrow to scroll through picture. as Resolved.
Jun 3 2015, 9:33 PM · Shop-Theme
HuiZSF added a comment to T88184: Add an arrow to scroll through picture. .

Added two <a> tag to the product_main container and updated related CSS code.
Set arrow's color to dark to adapt different color of photos.

Jun 3 2015, 8:43 PM · Shop-Theme
HuiZSF closed T97656: Menu selection and button are too close to each other. as Resolved.
Jun 3 2015, 5:54 PM · Shop-Theme
HuiZSF added a comment to T97656: Menu selection and button are too close to each other. .

This problem has been resolved by adding:

Jun 3 2015, 5:54 PM · Shop-Theme
HuiZSF closed T96622: Reduce gutter space in gallery as Resolved.
Jun 3 2015, 5:48 PM · Shop-Theme
HuiZSF closed T98109: Line and photo don't line up as Resolved.
Jun 3 2015, 5:19 PM · Shop-Theme
HuiZSF added a comment to T98109: Line and photo don't line up.

This problem has been resolved :D

Jun 3 2015, 5:19 PM · Shop-Theme
HuiZSF closed T96798: Wikipedia shop's responsive layout pads navigation bar layout and truncates searchbox early as Resolved.
Jun 3 2015, 5:16 PM · Shop-Theme, Wikimedia-Shop
HuiZSF added a member for Wikimedia-Shop: HuiZSF.
Jun 3 2015, 5:05 PM
HuiZSF added a member for Shop-Theme: HuiZSF.
Jun 3 2015, 5:04 PM

May 11 2015

HuiZSF added a comment to T97318: [Mobile] Text looks too big on mobile..

@vshchepakina
Reduced font size to 1.6em on screen which has the width less than 768px.

May 11 2015, 9:09 PM · Shop-Theme
HuiZSF added a comment to T97554: Improper Padding for Artist Photos / Text in Mobile View.

Hi @MNguyen, @vshchepakina
I was trying to find the reason, however, this problem might be caused by the editing of the contents of this page.
I checked other pages with artist pictures, they are all find.
The difference between the pages is, there are some <br /> between the title and the body.
Also, the picture are not assigned padding-bottom value.
So can you please try re-edit the content of this page first?

May 11 2015, 9:02 PM · Wikimedia-Shop
HuiZSF added a comment to T97656: Menu selection and button are too close to each other. .

@violetto
Found it, if this is good adding margin-top: 5px; for button area?

May 11 2015, 8:50 PM · Shop-Theme
HuiZSF added a comment to T98109: Line and photo don't line up.

@violetto
Found it, will update soon.

May 11 2015, 8:48 PM · Shop-Theme

Apr 27 2015

HuiZSF added a comment to T97317: [Mobile] Footer isn't organized properly. .

@MNguyen
Yes. I think we can reach it.
Will find time to update soon.

Apr 27 2015, 8:16 PM · Shop-Theme
HuiZSF added a comment to T97317: [Mobile] Footer isn't organized properly. .

Yeah, I will add new rule for the columns, when in Mobile screen size, the width will be 100%
So then help, contact, legal and mail list will be arranged from top to bottom

Apr 27 2015, 6:01 PM · Shop-Theme
HuiZSF added a comment to T97265: Enlarged space between title and content under Instagram section.

fixed...

Apr 27 2015, 4:16 AM · Shop-Theme
violetto awarded T90317: Add arrows for carousel on wikimedia shop a Pterodactyl token.
Apr 27 2015, 4:13 AM · Shop-Theme
HuiZSF added a comment to T88184: Add an arrow to scroll through picture. .

@violetto,
Sorry for the misunderstanding... I will try to add the arrows for it.

Apr 27 2015, 4:12 AM · Shop-Theme
HuiZSF reopened T88184: Add an arrow to scroll through picture. as "Open".
Apr 27 2015, 4:12 AM · Shop-Theme
HuiZSF added a comment to T90317: Add arrows for carousel on wikimedia shop.

@violetto
Sure. Updated...

Apr 27 2015, 4:10 AM · Shop-Theme
HuiZSF added a comment to T96436: Links within vendor/artist profile.

@violetto Hi May thanks for the feedback!
If we use text-decoration, we can not adjust the space.
I will replace this rule with border-bottom soon

Apr 27 2015, 4:07 AM · Shop-Theme

Apr 26 2015

HuiZSF updated subscribers of T90317: Add arrows for carousel on wikimedia shop.
Apr 26 2015, 5:50 PM · Shop-Theme
HuiZSF merged task T88184: Add an arrow to scroll through picture. into T90317: Add arrows for carousel on wikimedia shop.
Apr 26 2015, 5:50 PM · Shop-Theme
HuiZSF added a comment to T88184: Add an arrow to scroll through picture. .

Hi @violetto
Added the slider control buttons to the home page.

  1. Add two a tags to index page, it's the native button of bootstrap
  2. overwrite the appearance of the control buttons of bootstrap by adding rules to style.css

Any problem please let me know.

Apr 26 2015, 5:53 AM · Shop-Theme

Apr 25 2015

HuiZSF closed T96436: Links within vendor/artist profile as Resolved.
Apr 25 2015, 9:57 PM · Shop-Theme
HuiZSF added a comment to T96178: The theme doesn't show sold out products in the product listing. See screenshot..

Hi @vshchepakina could you please explain this problem a bit more detailed? I didn't get it...

Apr 25 2015, 9:56 PM · Shop-Theme
HuiZSF added a comment to T93022: Add a 'Featured Wikipedian' page.

Hi @vshchepakina Is there a design the this page to do mockup?

Apr 25 2015, 9:55 PM · Shop-Theme
HuiZSF closed T96909: [Mobile] The designer images are too big on mobile. as Resolved.
Apr 25 2015, 9:54 PM · Shop-Theme
HuiZSF closed T95915: Navigation buttons disappear in Tablet mode as Resolved.
Apr 25 2015, 9:53 PM · Shop-Theme
HuiZSF added a comment to T96622: Reduce gutter space in gallery.

Hi May (@violetto) and @Prtksxna
Do we have decision now please?

Apr 25 2015, 9:52 PM · Shop-Theme
HuiZSF added a comment to T96798: Wikipedia shop's responsive layout pads navigation bar layout and truncates searchbox early.


The offset problem has been fixed. Thanks :)
Also update the font-size for different nav-bars.

Apr 25 2015, 9:49 PM · Shop-Theme, Wikimedia-Shop

Apr 23 2015

HuiZSF closed T96645: Move the view of photos on banner lower as Resolved.
Apr 23 2015, 6:15 PM · Shop-Theme
HuiZSF added a comment to T96645: Move the view of photos on banner lower.

Thanks @violetto
Will close this task :)

Apr 23 2015, 6:15 PM · Shop-Theme
HuiZSF added a comment to T96645: Move the view of photos on banner lower.

I meant use JavaScript to compute the position for each banner picture. But pictures vary.
Fixed position is easier. If we change the banner pictures in the future, please consider to save some more upper room for the pictures.

Apr 23 2015, 4:19 PM · Shop-Theme
HuiZSF added a comment to T96749: Bug: Login page does not default to HTTPS.

Hi @K4-713, @vshchepakina and @violetto

Apr 23 2015, 6:11 AM · Shop-Theme
HuiZSF closed T96623: Remove bevel on menu as Resolved.
Apr 23 2015, 5:20 AM · Shop-Theme
HuiZSF added a comment to T96645: Move the view of photos on banner lower.

@violetto and @vshchepakina
Are the pictures look good now? Do we need further adjustment please?

Apr 23 2015, 5:17 AM · Shop-Theme
HuiZSF closed T88196: Make instagram photos section fully scrollable as Resolved.
Apr 23 2015, 5:15 AM · Shop-Theme
HuiZSF added a comment to T96798: Wikipedia shop's responsive layout pads navigation bar layout and truncates searchbox early.

Thanks! @Ragesoss
Will add new layout rule to fix this problem.

Apr 23 2015, 5:10 AM · Shop-Theme, Wikimedia-Shop
HuiZSF added a comment to T96909: [Mobile] The designer images are too big on mobile..

Will add above rule for artists pictures compatible with screen 768px - 970px and less than 768px width

Apr 23 2015, 5:02 AM · Shop-Theme

Apr 22 2015

HuiZSF closed T96614: Placeholder on search bar to 1em as Resolved.
Apr 22 2015, 10:04 PM · Shop-Theme
HuiZSF added a comment to T96909: [Mobile] The designer images are too big on mobile..

Will add mobile layout for artist section to solve this problem

Apr 22 2015, 10:01 PM · Shop-Theme
HuiZSF added a comment to T96798: Wikipedia shop's responsive layout pads navigation bar layout and truncates searchbox early.

Search input's width is 300px.
When page area's width < 992px, nav bar will offset down due to no enough room. So it needs to reduce the width of search input on the screen with width < 992px;
However, Search the shop text will be cut off a part. What about reduce the size of text concurrently?

Apr 22 2015, 6:40 AM · Shop-Theme, Wikimedia-Shop

Apr 21 2015

HuiZSF added a comment to T96623: Remove bevel on menu.

Thanks! @vshchepakina

Apr 21 2015, 6:23 PM · Shop-Theme
HuiZSF added a comment to T96623: Remove bevel on menu.

Yes, the appearance of the menu is the OS native appearance. Your screenshot should be a customized appearance.
I don't know why I can only see the native appearance.

Apr 21 2015, 5:57 PM · Shop-Theme
HuiZSF added a comment to T96623: Remove bevel on menu.

Seems different..

Apr 21 2015, 5:42 PM · Shop-Theme
HuiZSF added a comment to T96623: Remove bevel on menu.

Hi @violetto
Which page is this menu in? I didn't meet a menu looks like the screenshot...
Could you please give me a link?

Apr 21 2015, 5:35 PM · Shop-Theme
HuiZSF added a comment to T96436: Links within vendor/artist profile.

Found it.
Going to patch by this:

Apr 21 2015, 5:32 PM · Shop-Theme
HuiZSF added a comment to T96438: Add a link within product info to scroll down to vendor/artist profile.

Need to modify the page code, add id="artist" to the Artist/ventor box.
When add spec for a product, add link to the artist name, use #artist as the link target. When click this link it will scroll down to the artist section.

Apr 21 2015, 5:28 PM · Shop-Theme
HuiZSF added a comment to T96622: Reduce gutter space in gallery.

Is this ok?

Apr 21 2015, 5:24 PM · Shop-Theme
HuiZSF added a comment to T96622: Reduce gutter space in gallery.

I can copy this part of CSS to style.css and overwrite the settings in bootstap.min.css

Apr 21 2015, 4:57 PM · Shop-Theme
HuiZSF added a comment to T96645: Move the view of photos on banner lower.

The picture is demonstrated as a background of the slide box. By default its position is center center.
I'm trying now to fix the position as center -60px, it seems work for the current pictures.
I think it would be better using JS dynamically compute the position and overwrite to the box

Apr 21 2015, 6:38 AM · Shop-Theme
HuiZSF added a comment to T95915: Navigation buttons disappear in Tablet mode.

Found it.
I have added a temporary patch in CSS to resize the search input to be compatible with 992px screen.

Apr 21 2015, 6:09 AM · Shop-Theme
HuiZSF added a comment to T88184: Add an arrow to scroll through picture. .

Hi @vshchepakina
Which page is this picture model on? I couldn't find it. Could you please add a link?

Apr 21 2015, 3:39 AM · Shop-Theme
HuiZSF added a comment to T88196: Make instagram photos section fully scrollable.

I have applied a patch for instagram container in the home page and fixed the first picture cropped problem.
In addition, I'm going to change this container's heigh from 306px to 326px, to make the scroll bar compatible with most of the browsers.

Apr 21 2015, 3:35 AM · Shop-Theme
HuiZSF added a comment to T96622: Reduce gutter space in gallery.

Hi May (@violetto)
For this problem, I need to modified this file : bootstrap.min.css
This file has been minimized. If it's applicable to modify it? Because you may not see which part I am going to change.

Apr 21 2015, 3:28 AM · Shop-Theme

Apr 20 2015

HuiZSF added a comment to T96614: Placeholder on search bar to 1em.

@violetto Got it and fixed.

Apr 20 2015, 8:47 PM · Shop-Theme
HuiZSF added a comment to T90469: Update Footer - Design Attached.


This is what @HuiZSF has now. @MNguyen, can you check if it matches the design?

Apr 20 2015, 6:18 PM · Shop-Theme, Wikimedia-Shop