Page MenuHomePhabricator

IKhitron (Igal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 4 2015, 2:23 PM (299 w, 2 d)
Availability
Available
LDAP User
IKhitron
MediaWiki User
IKhitron [ Global Accounts ]

Recent Activity

Sat, Sep 26

IKhitron added a comment to T262879: Global Preferences can not be saved any more.

Unfortunately, I do not know. I payed attention just before the task creation.
Well, I went to enwiki global preferences, and changed "he" to "en". It still shows he on both sites, but it does work now.

Sat, Sep 26, 2:14 AM · Regression, MediaWiki-extensions-GlobalPreferences, Community-Tech

Tue, Sep 22

IKhitron added a comment to T262879: Global Preferences can not be saved any more.

Hello and thank you for your answer.

  1. No, I do not. I'm actually talking about the button "Set your global preferences".
  2. Indeed.
  3. Indeed.
  4. Indeed.
Tue, Sep 22, 12:58 AM · Regression, MediaWiki-extensions-GlobalPreferences, Community-Tech

Tue, Sep 15

IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

See also T262879.

Tue, Sep 15, 12:23 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
IKhitron changed the subtype of T262879: Global Preferences can not be saved any more from "Task" to "Bug Report".
Tue, Sep 15, 12:22 AM · Regression, MediaWiki-extensions-GlobalPreferences, Community-Tech
IKhitron created T262879: Global Preferences can not be saved any more.
Tue, Sep 15, 12:22 AM · Regression, MediaWiki-extensions-GlobalPreferences, Community-Tech

Mon, Sep 14

IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

Jdlrobson, I'm still not there.

Mon, Sep 14, 9:36 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

Hello, @ovasileva, when it should start to work? It does not now.

Mon, Sep 14, 1:45 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Sun, Sep 13

IKhitron added a comment to T262768: Add permalink for new page creations.

Please do. The current format is very inconvenient.

Sun, Sep 13, 7:11 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T262769: Add link to specific log entry.

Yes, but there is no need to visit the page for logs.

Sun, Sep 13, 7:07 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T262768: Add permalink for new page creations.

I'm talking about using it for new pages too.

Sun, Sep 13, 7:06 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T262769: Add link to specific log entry.

Could you also consider a possibility to add a link mark as read, because for now we should click stop watching and then watch agsin to remove the log entry on-page?

Sun, Sep 13, 6:56 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T262768: Add permalink for new page creations.

Hi, @DannyS712. Please consider a possibility to use special:diff/<page creation revision>, to make the entry format the same for all pages.

Sun, Sep 13, 6:54 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Fri, Sep 11

IKhitron added a comment to T259385: Work with community to fix faulty gadgets triggering JS errors.

Well, I think you can find them using regular wikisearch. And yes, I did fix it once on MediaWiki-extensions-GlobalWatchlist.

Fri, Sep 11, 1:41 AM · Reading-Web-Local-Wiki-Issues

Mon, Sep 7

IKhitron added a comment to T262176: Show timestamps for entries.

Fixed a little to remkve ambiguity.

Mon, Sep 7, 10:35 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated the task description for T262176: Show timestamps for entries.
Mon, Sep 7, 10:35 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Sun, Sep 6

IKhitron updated subscribers of T259385: Work with community to fix faulty gadgets triggering JS errors.

@Bharel?

Sun, Sep 6, 5:13 PM · Reading-Web-Local-Wiki-Issues

Aug 30 2020

IKhitron updated subscribers of T259385: Work with community to fix faulty gadgets triggering JS errors.
Aug 30 2020, 12:07 AM · Reading-Web-Local-Wiki-Issues

Aug 29 2020

IKhitron updated subscribers of T259385: Work with community to fix faulty gadgets triggering JS errors.

@IKhitron I've fixed the citetooltip issue, but I've found another issue with a user script - this one with https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Ori/monobook.js which throws Uncaught ReferenceError: AddTemplateToList is not defined. Would it be possible for you to reach out to User:Ori to get that fixed?

Aug 29 2020, 11:43 PM · Reading-Web-Local-Wiki-Issues

Aug 8 2020

IKhitron renamed T259958: Rename CSS classes to follow conventions from Rename CSS classes to follow convensions to Rename CSS classes to follow conventions.
Aug 8 2020, 10:23 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist, Technical-Debt, CSS

Jul 29 2020

IKhitron added a comment to T259098: Wikibase labels: localize parenthesis.

Is there a typo in the task name?

Jul 29 2020, 10:45 AM · I18n, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Jul 27 2020

IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 6:40 PM · I18n, RTL, Convenient-Discussions
IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 5:11 PM · I18n, RTL, Convenient-Discussions
IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 5:08 PM · I18n, RTL, Convenient-Discussions
IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 5:08 PM · I18n, RTL, Convenient-Discussions
IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 5:08 PM · I18n, RTL, Convenient-Discussions
IKhitron added a comment to T258959: Syntaxhighlight does not honor directionality in preview mode.

@IKhitron I updated the task description a bit, without knowing the exact problem. I may have made things worse. Please edit further as you see fit. The goal is to have very clear specifications on how to reproduce the issue.

Jul 27 2020, 4:51 PM · I18n, RTL, Convenient-Discussions
IKhitron updated the task description for T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 4:50 PM · I18n, RTL, Convenient-Discussions
IKhitron created T258959: Syntaxhighlight does not honor directionality in preview mode.
Jul 27 2020, 3:24 PM · I18n, RTL, Convenient-Discussions

Jul 8 2020

IKhitron added a comment to T255536: Implement preliminary javascript frontend for Special:GlobalWatchlist.

Fine.

Jul 8 2020, 11:43 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T255536: Implement preliminary javascript frontend for Special:GlobalWatchlist.

If on particular wiki some page was created and then edited, the script shows two lines, one for creation diff, and one for all the rest.

Jul 8 2020, 11:38 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Jul 7 2020

IKhitron added a comment to T255536: Implement preliminary javascript frontend for Special:GlobalWatchlist.

Because I'd like to wait until the current development is complete before tackling unexpected work (cf Unplanned-Sprint-Work)

Jul 7 2020, 8:22 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T255536: Implement preliminary javascript frontend for Special:GlobalWatchlist.

Yes, but I'd wait until its more complete - the extension is very much not done yet

Jul 7 2020, 8:12 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T255536: Implement preliminary javascript frontend for Special:GlobalWatchlist.

Hi @DannyS712. Is there a way that I can inform your about some problematic issues in GW, that were irrelevant to the script, but are very relevant to the extension? I ask here, because some of them are a part of the functional frontend.

Jul 7 2020, 7:37 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Jul 1 2020

IKhitron added a comment to T253308: Support for right-to-left languages for Convenient Discussions.

Iniquity, as you asked.

Jul 1 2020, 11:20 PM · RTL, I18n, Convenient-Discussions
IKhitron added a watcher for MediaWiki-extensions-GlobalWatchlist: IKhitron.
Jul 1 2020, 11:44 AM

Jun 15 2020

IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Well, I think it affects all the users, it's just too difficult to pay attention that the displayed data is wrong. A pity.

Jun 15 2020, 2:14 PM · User-DannyS712, DannyS712-Global_watchlist.js

Jun 11 2020

IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Hi, @DannyS712. Congrats. I can understand why you've declined all the future requests. But I do not see why to decline this. The main software engineering rule that I teach my students every year is "Never make red refactoring". If something is broken, you can't convert the script to the extension, you should make the script green first. Only if you're going to forget about the script code and write the extension from scratch. It's possible, but it's a waste of time. Not saying that it will be broken for script users in the four years that will take to write and deploy the extension.

Jun 11 2020, 1:20 PM · User-DannyS712, DannyS712-Global_watchlist.js

Jun 7 2020

IKhitron added a comment to T196501: frame:getParent() should work recursively, not just once.

The hewiki site should use secondary parent in 97.2% articles. Without this feature, we are forced to write very ugly and non-exeptable code in hundreds of templates.

Jun 7 2020, 1:46 PM · MediaWiki-extensions-Scribunto

Jun 4 2020

IKhitron awarded T226697: Make a third click on a sortable header reset the table a Love token.
Jun 4 2020, 3:07 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), User-notice, patch-welcome, MediaWiki-jQuery-Tablesorter--archived

Jun 3 2020

IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

In the last twenty minutes this was happened on many wikis at the same time, thanks @DannyS712 for his global watchlist script. And stopped at the same time, so it is not local.

Jun 3 2020, 4:37 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist

May 16 2020

IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

@IKhitron - as far as I could see the gadgets you mention are not on Special:Preferences#mw-prefsection-gadgets list?

It is there. WLM, the last one in Watchlist subsection.

May 16 2020, 2:05 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist

May 13 2020

IKhitron added a comment to T252633: Show number of edits on Special:Watchlist.

Thanks, but just to know if there are more than 1000 (for example) is not enough. If the number is 100, one should not read them quickly. If it's 900, they should, because it will be 1001 soon. This is why I've asked for a number.

May 13 2020, 11:43 AM · Growth-Team, MediaWiki-Watchlist
IKhitron changed the subtype of T252633: Show number of edits on Special:Watchlist from "Task" to "Feature Request".
May 13 2020, 9:50 AM · Growth-Team, MediaWiki-Watchlist
IKhitron created T252633: Show number of edits on Special:Watchlist.
May 13 2020, 9:50 AM · Growth-Team, MediaWiki-Watchlist

May 7 2020

IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

@IKhitron can you please post detailed steps of what you did, what you expected to see, and what you saw?

May 7 2020, 7:00 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist
IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).
  • About 4,000 pages.
  • A categorization filter only.
  • Sorry, I do not understand. How can one see filters?
May 7 2020, 6:37 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist
IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

... And today.

May 7 2020, 10:56 AM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist
IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

It happened yesterday for the last time.

May 7 2020, 6:21 AM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-kostajh, Regression, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist

May 5 2020

IKhitron created T251871: Ability to emphasize the newborn sections.
May 5 2020, 11:29 AM · Convenient-Discussions

May 1 2020

IKhitron awarded T27400: Software should allow admins to give specific users permission to edit specific pages through blocks a Dislike token.
May 1 2020, 9:29 AM · MediaWiki-Blocks
IKhitron awarded T251584: Allow users to be able to edit certain page(s) in a namespace while being blocked from editing that namespace a Dislike token.
May 1 2020, 12:41 AM · MediaWiki-Blocks, Anti-Harassment

Mar 28 2020

IKhitron added a watcher for Section-Name-Diff: IKhitron.
Mar 28 2020, 1:14 AM

Mar 12 2020

IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

Found the problem, @DannyS712. Forget about it.

Mar 12 2020, 11:14 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245455: 114: Open compound diff in new tab.

Found the problem, @DannyS712. Forget about it.

Mar 12 2020, 11:14 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245455: 114: Open compound diff in new tab.

With html element attribute? Not realistic. Let's see the console later on.

Mar 12 2020, 7:42 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245455: 114: Open compound diff in new tab.

Weird. Well, it's the same Chrome on which my Watchlist Manager new tabs work well...

Mar 12 2020, 7:33 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245455: 114: Open compound diff in new tab.

Done in 8.3.3

Mar 12 2020, 7:29 AM · User-DannyS712, DannyS712-Global_watchlist.js

Mar 10 2020

IKhitron added a comment to T246876: 116: RTL compatibility breaks on Chrome.

Very well. Thanks a lot.

Mar 10 2020, 11:53 PM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T246876: 116: RTL compatibility breaks on Chrome.

Oh, okay. Can this be closed?

Mar 10 2020, 11:50 PM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T246876: 116: RTL compatibility breaks on Chrome.

Indeed. The commas are fine, by rtl syntax rules, if you're talking about the spaces at the left side of the comma.

Mar 10 2020, 9:19 PM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T246876: 116: RTL compatibility breaks on Chrome.

Can you try it now? I've deployed the change

Mar 10 2020, 9:05 PM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T246876: 116: RTL compatibility breaks on Chrome.

@IKhitron sorry about that, forgot I needed to deploy this. Is there a test case I can look at to see the current failure and the new fix? In the future, feel free to post a ping if I forgot to do this

Here you are, the current state:


See 'm' at the middle line.

Mar 10 2020, 8:42 PM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js

Mar 4 2020

IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

I tried with Chrome, and it works for me

Mar 4 2020, 5:09 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

I don't have firefox installed, sorry

Mar 4 2020, 4:54 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

Cannot reproduce

Mar 4 2020, 4:50 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

What skin, and what site?

Vector. Ruwiki.

Mar 4 2020, 4:45 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

Are you using the latest (development) version?

Yes, I do.

Mar 4 2020, 4:43 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

The bottom list of empty sites should be collapsed... is it not?

No, it isn't.

Mar 4 2020, 4:39 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron claimed T246876: 116: RTL compatibility breaks on Chrome.
Mar 4 2020, 10:13 AM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
Restricted Application assigned T246876: 116: RTL compatibility breaks on Chrome to DannyS712.
Mar 4 2020, 10:12 AM · I18n, RTL, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

@DannyS712?

Mar 4 2020, 10:04 AM · User-DannyS712, DannyS712-Global_watchlist.js

Feb 21 2020

IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

{{done}}

Feb 21 2020, 9:54 AM · User-DannyS712, DannyS712-Global_watchlist.js

Feb 20 2020

IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Continuing working. Opened two windows on hewiki with GL on the same wiki, emptied all, waited to a new edit. Clicked Refresh on the first, get nothing. Clicked F5 on the second, get the result. After running a query on both consules, get the same output:

var api = new mw.ForeignApi( 'https://ru.wikipedia.org/w/api.php' );
api.get( {
    action: 'query',
    list: 'watchlist',
    wlshow: 'unread'
} ).done( function ( data ) {
    console.log( data );
} );
Object { abort: abort(), state: state(), always: always(), catch: catch(), pipe: pipe(), then: then(), promise: promise(), progress: add(), done: add(), fail: add()
 }
Feb 20 2020, 3:12 PM · User-DannyS712, DannyS712-Global_watchlist.js

Feb 18 2020

IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Well, working on this in meta:User:IKhitron/Global Watchlist.js. Now I'm certain that the problem is in script, in api usage, and not in api itself. This what I have now on a console, while there is no wikidata in the list:


and this what I have in another tab, after F5:

As you can see, there is the same wikidata item in both, Q9095390, and the same summary, and all the relevant data. So, the script is aware about this edit, it just do not show it. So, the task closing was too soon. Continuing to work on this.

Feb 18 2020, 12:56 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Yes, you can. You can remove the Refresh button, because it can't work as promised. In any case, I'll try to find some time to investigate this. Seems quite impossible that api returns different answers in different tabs at the same time, depends on the screen layout, which this api even does not need to see. Maybe the api just gets wrong parameters from the script in this case - timestamp or something else and as a result of this return wrong answer. Especially when we can see the right answer on the console, and it must come from somewhere, it is new, so couldn't remain from before. @Masumrezarock100, can you help in this investigation, please?

Feb 18 2020, 10:33 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Nevermind why. The result is that the button does not do what it supposed to do.

Feb 18 2020, 2:04 AM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

So it will remain there, but will not work?

Feb 18 2020, 12:35 AM · User-DannyS712, DannyS712-Global_watchlist.js

Feb 17 2020

IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Exactly what I said, you can't use the refresh button, because api does not return the right answer.

Feb 17 2020, 11:51 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

I do not understand. Do you mean that you're going to remove the refresh button entirely, because api does not support its functionality? And there us nothing you can do?

Feb 17 2020, 11:46 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

I understand now. Thanks, I'll think if I can do it.

Feb 17 2020, 11:44 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245455: 114: Open compound diff in new tab.

Funny. Of course, but all I want is avoid doing this hundreds of times every day. Now I run attr in console every time. Unfortunately, I couldn't find a way to catch the moment when all the lists are shown, so javascript could do something.

Feb 17 2020, 10:30 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

Sorry. I meant @DannyS712.

Feb 17 2020, 7:39 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

One more observation. I did a lot of tests in the last couple of hours, and can focus the problem much better.

  1. Open the GW.
  2. Open in other tabs and read all the shown diffs for some wiki.
  3. Click refresh.
  4. See the list is gone to globalWatch-col.
  5. Wait until there will be at least one new edit from that wiki.
  6. Click refresh.
  7. Expected: The list moves from globalWatch-col up and shows the new edits.
  8. Got: The list remains in globalWatch-col without showing edits.
Feb 17 2020, 7:38 PM · User-DannyS712, DannyS712-Global_watchlist.js
Masumrezarock100 awarded T245455: 114: Open compound diff in new tab a Like token.
Feb 17 2020, 7:18 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron changed the subtype of T245455: 114: Open compound diff in new tab from "Task" to "Feature Request".
Feb 17 2020, 7:07 PM · User-DannyS712, DannyS712-Global_watchlist.js
Restricted Application assigned T245455: 114: Open compound diff in new tab to DannyS712.
Feb 17 2020, 7:07 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Thanks a lot.
P10428

Feb 17 2020, 7:03 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron created P10428 T245428 console.
Feb 17 2020, 7:03 PM · DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

OK, but once again, if the user can set the new value in global.js only, why do you need to do something with settings at all? If there is a new value in global.js, it will be used on each browser refresh, otherwise it will not. Why do you need to keep it in user settings if you'll never use this setting?

Feb 17 2020, 6:01 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

For example,

GlobalWatchlist@www.wikidata:getWikidataLabels wdlabels: index.php:195:11
{…}
​
Q17523682: Object { type: "item", id: "Q17523682", labels: {…} }
​
<prototype>: Object { … }
index.php:196:11

About the debugLog, where do you want me to paste it?

Feb 17 2020, 5:58 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

There is no timeout field on the settings page, but you can still manually set one

Feb 17 2020, 5:54 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.
  • If the user has manually set a timeout by previously editing the settings, the timeout should be kept when saving again

The user cannot set a timeout by editing the settings, because there is no timeout field in the settings.

Feb 17 2020, 5:53 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron updated subscribers of T245298: 107: Make empty lists list collapsible and collapsed.

@Danny, we're talking about different things here. Let me try to explain once again. I do not talk about pinning. I talk about the state when all edits lists will start un-collapsed and only the bottom list will start collapsed, because no one needs it, except for special occasions.

Feb 17 2020, 5:51 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245428: 113: The script can't return from empty lists.

Do you mean to spend an hour to open all the objects again, or the new one you've added?

Feb 17 2020, 5:49 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

No apologies are needed. I'm the stupid one here.

Feb 17 2020, 1:47 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

I just quoted the last line. Not meant that my answer is to this line only.

Feb 17 2020, 1:39 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

The meaning of this part should be obvious.

Feb 17 2020, 1:19 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
Restricted Application assigned T245428: 113: The script can't return from empty lists to DannyS712.
Feb 17 2020, 1:02 PM · User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245312: 109: Make setTimeout value for live updates configurable.

It'll be awhile before I'm motivated to do this, because I'm not planning to use it myself, but if anyone wants to submit a patch please do so:

  • Can be submitted as either a git patch/diff, or a fork on enwiki or meta (so that I can use Special:ComparePages)
  • The config setting should not be added to a user's preferences if you are using the default
  • The config setting should be kept when saving new settings
  • No new field should be added to the settings page
Feb 17 2020, 12:32 PM · patch-welcome, User-DannyS712, DannyS712-Global_watchlist.js
IKhitron added a comment to T245298: 107: Make empty lists list collapsible and collapsed.

So, what do you say, @DannyS712?

Feb 17 2020, 10:40 AM · User-DannyS712, DannyS712-Global_watchlist.js