Page MenuHomePhabricator

IKhitron (Igal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 4 2015, 2:23 PM (320 w, 6 d)
Availability
Available
LDAP User
IKhitron
MediaWiki User
IKhitron [ Global Accounts ]

Recent Activity

Wed, Feb 24

IKhitron added a comment to T275636: Use page id for edits grouping.

At least for me, it is. Between the first unseen edit on this page until the last one, both with the same name.

Wed, Feb 24, 5:07 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T275636: Use page id for edits grouping.

I expect not to see Y again, and all the edits of both pages see in X group, as in Special:Watchlist, this is why.
You can check over there how is it implemented.

Wed, Feb 24, 4:51 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated the task description for T275636: Use page id for edits grouping.
Wed, Feb 24, 3:40 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T275636: Use page id for edits grouping.
Wed, Feb 24, 3:38 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Mon, Feb 22

IKhitron added a comment to T275437: Jobs are not getting executed or executed really slowly.

This ticket is not a UBN. We've had issues with mass message before, and there's no indication of widespread jobs failures.

Feel free to deprioritize it. The graphs I linked earlier (and that are outdated, as you noted) scared me, so I preliminarily set the priority to UBN. If you think this is not UBN, no objections for decreasing the priority (or reseting to Needs Triage).

FYI: T218511 is on 3 hours (sic!) delay on Meta now.

Mon, Feb 22, 11:37 PM · SRE, WMF-JobQueue
IKhitron added a comment to T275437: Jobs are not getting executed or executed really slowly.

This ticket is not a UBN. We've had issues with mass message before, and there's no indication of widespread jobs failures.

Feel free to deprioritize it. The graphs I linked earlier (and that are outdated, as you noted) scared me, so I preliminarily set the priority to UBN. If you think this is not UBN, no objections for decreasing the priority (or reseting to Needs Triage).

Mon, Feb 22, 11:32 PM · SRE, WMF-JobQueue

Sun, Feb 21

IKhitron added a comment to T275303: Setting the ordering of the watchlist.

@Iniquity so this should really be documented somewhere, but the order is based on the order edits are made in, and then if there are multiple edits to the same page their are displayed using the timestamp of the latest, but (I'm pretty sure) still sorted using the timestamp of the oldest. Maybe we can add an explicit sort function watchlistUtils...

Sun, Feb 21, 7:37 PM · Patch-For-Review, MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Sat, Feb 20

IKhitron updated the task description for T275278: Site autocomplete.
Sat, Feb 20, 1:45 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron changed the subtype of T275278: Site autocomplete from "Task" to "Feature Request".
Sat, Feb 20, 1:43 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T275278: Site autocomplete.
Sat, Feb 20, 1:43 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Thu, Feb 18

IKhitron added a comment to T274602: Expand/collapse button is in the wrong place when the wiki's use of RTL or LTR is different from the display language.

As you wish. For me, it will look wierd if it "jumps" from side to side on the same page.

Thu, Feb 18, 9:22 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), User-DannyS712, MediaWiki-extensions-GlobalWatchlist, RTL, I18n
IKhitron added a comment to T274602: Expand/collapse button is in the wrong place when the wiki's use of RTL or LTR is different from the display language.

Just a thought. Can you put the collapse button on the line center, nevermind what is the uselang and what is the wiki? It should be much easier.

Thu, Feb 18, 9:17 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), User-DannyS712, MediaWiki-extensions-GlobalWatchlist, RTL, I18n
IKhitron changed the subtype of T275159: Fire a hook after every list rebuild from "Task" to "Feature Request".
Thu, Feb 18, 8:34 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T275159: Fire a hook after every list rebuild.
Thu, Feb 18, 8:33 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Tue, Feb 16

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Well, @DannyS712, it's on 30.

Tue, Feb 16, 3:12 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Sun, Feb 14

IKhitron changed the subtype of T274720: Remove redundant message "sites with changes" from "Task" to "Design".
Sun, Feb 14, 12:10 AM · Patch-For-Review, MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron created T274720: Remove redundant message "sites with changes".
Sun, Feb 14, 12:09 AM · Patch-For-Review, MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Fri, Feb 12

IKhitron added a comment to T274600: Api calls should specify language.

It will work better if you allow to make uselang language permanent in preferences, as I already suggested.

Fri, Feb 12, 2:23 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

But, on the other hand, how can you be sure that the user does not prefer the foreign language preferences. He set them to use these wikis, including reading the diffs and the history pages.

Fri, Feb 12, 1:08 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

I see. You're right.

Fri, Feb 12, 12:57 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

OK. So how is this different from the current state? It does show the wikidata labels on the Meta preferences language, or overrided by uselang, doesn't it?

Fri, Feb 12, 12:51 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

On which wiki? If somebody turns on a computer, opens a browser, opens the GW page on Meta, you do not know what wiki does this user prefer to work on.

Fri, Feb 12, 12:40 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

I mean, how do you know which language you should use to override? How do you now that I prefer Hebrew without me saying this explicitly, for example by using uselang?

Fri, Feb 12, 12:04 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Thu, Feb 11

IKhitron added a comment to T274600: Api calls should specify language.

How can you use the language of local wiki? You do not know what is this language and can't recognize this.

Thu, Feb 11, 11:57 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

Yes, I have all rtl wikis on Hebrew, ruwiki on Russion, and the rest on English. So?

Thu, Feb 11, 11:46 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

As I already said, for my sake uselang is quite enough. Don't know what do you want achidve with this.

Thu, Feb 11, 11:36 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron awarded T274599: Allow uncollapsing grouped results a Love token.
Thu, Feb 11, 10:58 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Confirm that it works on testwiki.

Thu, Feb 11, 10:19 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

If I understand properly, I should see the results on testwiki now?

Thu, Feb 11, 10:13 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

So, unfortunately, there are some errors with the train (T271344: 1.36.0-wmf.30 deployment blockers), specifically T274589: No atomic section is open (got LocalFile::lockingTransaction)
As a result, there is a chance that the train will be rolled back, switching metawiki from wmf.30 back to wmf.27. There are a number of changes to the GlobalWatchlist extension between .27 and .30 that, in my opinion, are necessary before deployment. Accordingly, per discussion in #wikimedia-operations, we won't be deploying the extension today.

However, we are still backporting the fixes for the issues identified to wmf.30, so that once the train blocker is resolved this can proceed as planned

Thu, Feb 11, 10:10 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

Maybe I needed a deep refresh once more. It works fine now in all cases.
On LTR interface:


On RTL interface:

Thu, Feb 11, 8:38 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Are you sure? The jenkins-bot did not leave a comment this time to say it's already there, and nothing changed visually.

Thu, Feb 11, 8:27 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

@DannyS712, I'm here, but where is the jenkins-bot?

Thu, Feb 11, 8:11 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I didn't think about the interaction with CSSJanus flipping stuff, since that wasn't the case for the user script.

Thu, Feb 11, 5:48 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, can you try to change the code to

.ext-globalwatchlist-feed-site {
	/* @noflip */ text-align: left;
	/* @noflip */ direction: ltr;
}
/* Handling of rtl wikis */
div[ id^='ext-globalwatchlist-feed-site-he_' ],
div[ id^='ext-globalwatchlist-feed-site-ar_' ],
div[ id^='ext-globalwatchlist-feed-site-azb_' ],
div[ id^='ext-globalwatchlist-feed-site-ckb_' ],
div[ id^='ext-globalwatchlist-feed-site-dv_' ],
div[ id^='ext-globalwatchlist-feed-site-fa_' ],
div[ id^='ext-globalwatchlist-feed-site-glk_' ],
div[ id^='ext-globalwatchlist-feed-site-ks_' ],
div[ id^='ext-globalwatchlist-feed-site-lrc_' ],
div[ id^='ext-globalwatchlist-feed-site-mzn_' ],
div[ id^='ext-globalwatchlist-feed-site-nqo_' ],
div[ id^='ext-globalwatchlist-feed-site-pnb_' ],
div[ id^='ext-globalwatchlist-feed-site-ps_' ],
div[ id^='ext-globalwatchlist-feed-site-sd_' ],
div[ id^='ext-globalwatchlist-feed-site-ug_' ],
div[ id^='ext-globalwatchlist-feed-site-ur_' ],
div[ id^='ext-globalwatchlist-feed-site-yi_' ] {
	/* @noflip */ text-align: right;
	/* @noflip */ direction: rtl;
}

?

Thu, Feb 11, 2:11 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Found the problem, trying to solve.

Thu, Feb 11, 2:02 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.
Thu, Feb 11, 12:55 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Ack. So I think the CSS solution just isn't going to work, instead I think we should identify whether the remote wiki is LTR or RTL, and then wrap the contents in <div dir="ltr"> or <div dir="rtl"> accordingly.

Now that I typed it, I'm not sure looking at the directionality of the wiki is right, shouldn't we look at the directionality of the user's chosen interface language on that wiki? My interface language is "English", so I would expect my watchlist to be LTR, even on RTL wikis.

Thu, Feb 11, 9:00 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated subscribers of T274313: Need to restore RTL handling.

Thanks @DannyS712 and @Legoktm. It was definitely merged, and it's much better now, but not enough.
See how it looks on LTR wikis:


Looks fine, English on the left, Arabic on the right.
See how it looks on RTL wikis:

Looks wrong, English on the right, Arabic on the left - an opposite from needed.

Thu, Feb 11, 8:05 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Wed, Feb 10

IKhitron added a comment to T274313: Need to restore RTL handling.

See https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix - there are hebrew and arabic testwiki, so it should be possible to test there

Wed, Feb 10, 3:45 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.
Wed, Feb 10, 3:44 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I can't merge it, since its my patch, but once its merged it can be tested on the beta cluster to confirm whether it works, and if it is we backport to testwiki.

Wed, Feb 10, 1:38 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Too late. They are already here.

Wed, Feb 10, 11:19 AM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I still have no normal F12 tools, but try to replace the line 62 selector with

.ext-globalwatchlist-feed-site

Done in patchset 3

Wed, Feb 10, 11:17 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I still have no normal F12 tools, but try to replace the line 62 selector with

.ext-globalwatchlist-feed-site
Wed, Feb 10, 1:25 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Tue, Feb 9

IKhitron added a comment to T274313: Need to restore RTL handling.

I do not know how to do this, never tryed.
The script works fine for both cases, up to now.

Tue, Feb 9, 11:49 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I think the patch will fix the problem of rtl wikis on ltr language page.
But I do not believe it will fix the problem of ltr wikis on rtl language page.
Please open the watchlist with uselang=he. As you can see, all the wikis are aligned to right. It should not happen without the patch. Maybe there is a problem with css selectors on the line 62, thay must align all the text to the left without the patch.

Tue, Feb 9, 11:37 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I see. Well, I haven't +2, of course, so I'll just take a look to the code and wait.

Tue, Feb 9, 11:30 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

You can lie. Wait 5 seconds with the message, it will drop the number or users with irrelevant message from 100% to 1%.

Tue, Feb 9, 11:28 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

I don't. I know it works, it's my code. I just was affraid you can't proceed to the deployment without enough reviews.

Tue, Feb 9, 11:24 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

What exactly would you have it do? That message is shown if the javascript is not loaded. If the message was removed, and users who don't have Javascript enabled tried to visit the page, it would just be blank for them...

Show this message with delay, for example.

Tue, Feb 9, 11:22 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

So, you don't need me for +1? If so, there is no need to call him.

Tue, Feb 9, 11:21 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

@DannyS712, you've asked me to review the code, but I'm not a developer on that level. May I call to a real developer that understands a lot in RTL?

Tue, Feb 9, 11:18 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Congratulations again, @DannyS712! Three little issues that should not disturb to the deployment tomorrow, but should be fixed soon.

  1. There is a second delay between opening the link Special:GlobalWatchlist and the watchlist work start. In this time, we can see an error message that we have no Javascript on this browser. It should be removed or replaced.

The error message is only shown until the javascript is loaded, and there is no delay coded into the extension for that - as soon as your browser downloads and executes the start of the code, the message is replaced.

Still, it's a wrong behavior.

  1. You can add more than five wiki fields on Special:GlobalWatchlistSettings. The settings list should be aware of the wiki variable for maximum number of wikis.

You can add more fields, but you can't save them if there is more than 5 - its allowed to add extra fields because there is no easy way to reorder them

Yes, I know you can't save, but it will be better if you can't add. About an easy way - I suggest to remove the "Add" buttons at all, and always show maximum number of fields, empty or not. On save you read all the fields and filter out the empty ones, in any order.

  1. You've commented out the code I wrote for rtl wikis, because "CSSJanus should handle it", or something like this, but it doesn't. The GW appears wrong for rtl wikis on ltr language page and for ltr wikis on rtl language page.

Okay, I forgot to test that out - handling at T274313

Thanks.

N3: The bug for empty lists fixed, thanks a lot for this.

Tue, Feb 9, 11:14 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Congratulations again, @DannyS712! Three little issues that should not disturb to the deployment tomorrow, but should be fixed soon.

  1. There is a second delay between opening the link Special:GlobalWatchlist and the watchlist work start. In this time, we can see an error message that we have no Javascript on this browser. It should be removed or replaced.
  2. You can add more than five wiki fields on Special:GlobalWatchlistSettings. The settings list should be aware of the wiki variable for maximum number of wikis.
  3. You've commented out the code I wrote for rtl wikis, because "CSSJanus should handle it", or something like this, but it doesn't. The GW appears wrong for rtl wikis on ltr language page and for ltr wikis on rtl language page.

N3: The bug for empty lists fixed, thanks a lot for this.

Tue, Feb 9, 10:46 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Sat, Feb 6

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

since my comment above I actioned the TODO and merged it into ext-globalwatchlist

Sat, Feb 6, 11:22 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Ah, thanks for the explanation. So the group doesn't exist on twn, instead of "it's broken".
Indeed, https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script shows Message group: All > Recent additions.
Maybe https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist was meant which shows Message group: All > Global Watchlist instead.

Sat, Feb 6, 10:04 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

The link is not broken and works here. If you think that something is broken then please always include why you think that something is broken - thanks.

Sat, Feb 6, 9:40 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Yes, ext-globalwatchlist-script should also be translated (TODO they should be merged, its no longer useful to keep them separate) - I'm not sure what you mean by unlock it, you should be able to translate at https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script

Sat, Feb 6, 8:07 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Thu, Feb 4

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@Johan, I suggest to remove the message entirely from 2021/06, because it's already Thursday evening, the issue is closed very soon, and add it, for now, in "Recent changes" of 2021/07. We can move it again, if there will no be deployment next week.

Thu, Feb 4, 7:31 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Also, the message included "You can watch up to five wikis. You can watch more wikis in the future." - as far as I know there are no plans to increase the default limit or override it for WMF config, and any such change would probably need approval from the performance team first.

Thu, Feb 4, 6:37 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Yes, ext-globalwatchlist-script should also be translated (TODO they should be merged, its no longer useful to keep them separate) - I'm not sure what you mean by unlock it, you should be able to translate at https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script

Thanks, done.

In T260862#6798570, Legoktm wrote:

While I understand the grant said Meta only, the extension should be deployed to testwiki first for testing purposes.

Hmm, okay. Once its enabled on meta, is it okay to then disable it on testwiki?

Thu, Feb 4, 2:16 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Wed, Feb 3

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).
Wed, Feb 3, 1:20 AM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Mon, Feb 1

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@DannyS712, do you need us to translate MediaWiki messages on translatewiki toward the deployment?

There is nothing blocking deployment in terms of translations, but any contributions would be welcome, as always.

Mon, Feb 1, 7:16 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@DannyS712, do you need us to translate MediaWiki messages on translatewiki toward the deployment?

Mon, Feb 1, 7:02 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Jan 21 2021

IKhitron added a comment to T268950: Include section name in the revision history visual diff.

Another possible solution: The line above was added for better orientation. Now, when we have section names, the line above the header is not needed any more.

Jan 21 2021, 11:34 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T268950: Include section name in the revision history visual diff.

No. What I'm saying that if you display a part of section from any reason, you should not give her a wrong name. Nkw one can understand the line is the part of the wrong section. You can show both names, it will solve the problem. Or you can find another visualization.

Jan 21 2021, 11:22 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T268950: Include section name in the revision history visual diff.

I do not say if the first name should or should not be here. I do say the second name should be here for sure, the last header before the quoted line, and it's not here at all.

Jan 21 2021, 10:40 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T272607: Add an ability for uselang.

Thanks. I do not think I am able to do it by myself.

Jan 21 2021, 6:47 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T268950: Include section name in the revision history visual diff.

@IKhitron Can you link to a few examples? I just looked at about 20 diffs from my watchlist and didn't see such problems. (I filed T272314 and T272315 though…)

Jan 21 2021, 6:39 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T272607: Add an ability for uselang.

@IKhitron no other special page has handling so that links to it are shown with a uselang parameter, and without the uselang parameter the global watchlist will be shown according to the language set it your preferences, not the page/content language of the wiki. I don't really understand why this is needed or useful

Jan 21 2021, 4:50 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron changed the subtype of T272607: Add an ability for uselang from "Task" to "Feature Request".
Jan 21 2021, 3:21 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron created T272607: Add an ability for uselang.
Jan 21 2021, 3:21 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Jan 18 2021

IKhitron added a comment to T268950: Include section name in the revision history visual diff.

Hello, @Esanders. It looks different now, but has a lot of problems. It shows dozens of irrelevant paragraphs, and also shows empty section names.

Jan 18 2021, 2:17 AM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs

Jan 8 2021

IKhitron added a comment to T29531: Implement link anchors to line numbers on syntax-highlighted pages (e.g. .css, .js).

Thanks s lot, @Esanders, it's very helpful. Hou aboug Lua pages?

Jan 8 2021, 2:27 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, SyntaxHighlight

Dec 16 2020

IKhitron changed the subtype of T270296: The syntaxhighlight highlighting splits the line from "Task" to "Bug Report".
Dec 16 2020, 3:12 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), HtmlFormatter, Regression, SyntaxHighlight
IKhitron created T270296: The syntaxhighlight highlighting splits the line.
Dec 16 2020, 3:12 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), HtmlFormatter, Regression, SyntaxHighlight

Dec 15 2020

IKhitron added a comment to T268950: Include section name in the revision history visual diff.

Hello, @Esanders. I'm keeping eye on this as original proposer. So I've tryed, and I can't see any difference:



If it was merged to 1.36.0-wmf.21, shouldn't it already work?

Dec 15 2020, 5:14 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs

Dec 3 2020

IKhitron added a comment to T268181: [Beta cluster] Deploy GlobalWatchlist extension (Meta only).

As I already explained, I do not know how to do this. Well, I'll wait the real deployment. I only hope there will be enough weeks between it and publishing in Techo News, to find all the bugs before the users start to use it.

Dec 3 2020, 7:17 PM · User-Urbanecm, User-DannyS712, MediaWiki-extensions-GlobalWatchlist, Wikimedia-Extension-setup
IKhitron added a comment to T268181: [Beta cluster] Deploy GlobalWatchlist extension (Meta only).

No, sorry - but you could create such an account yourself :)

Dec 3 2020, 6:30 PM · User-Urbanecm, User-DannyS712, MediaWiki-extensions-GlobalWatchlist, Wikimedia-Extension-setup
IKhitron added a comment to T268181: [Beta cluster] Deploy GlobalWatchlist extension (Meta only).

@DannyS712, is there a chance you'll create a falsificated account on Beta and publish the password, such that it will have a lot of pages in many watchlists, so we could check "for real"? Thank you.

Dec 3 2020, 6:14 PM · User-Urbanecm, User-DannyS712, MediaWiki-extensions-GlobalWatchlist, Wikimedia-Extension-setup

Nov 19 2020

IKhitron added a comment to T268259: Add a way to get back to Special:GlobalWatchlist from Special:GlobalWatchlistSettings.

Return to the state you opened the settings page the last time.

Nov 19 2020, 11:40 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Design, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T268259: Add a way to get back to Special:GlobalWatchlist from Special:GlobalWatchlistSettings.

I can only test so many functionality, because I have no multiple watched pages on beta wikis, of course. I did find many problems and intended to talk with you about them this evening, but as I can see, you've filed tasks for all of them today. For your question, I expected to see autoredirect to Special:GWL as in the script, and was surprised there wasn't. If it was my call, I would have four buttons at the bottom of the settings page: "Save", "Save and go back to the GWL", "Clear", "Clear and go back to the GWL".

Nov 19 2020, 8:01 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Design, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Nov 15 2020

IKhitron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

It's much worse in last week. And there is a partial way to recognize the "wrong" diffs. If you open the Special:Watchlist with the filter "unseen only", all the edits should be bolded by definition. Some of the "wrong" ones are not bolded.

Nov 15 2020, 1:37 PM · Growth-Team, User-kostajh, Regression, Performance-Team (Radar), User-notice, MediaWiki-Watchlist

Nov 3 2020

IKhitron reopened T262879: Global Preferences can not be saved any more as "Open".

Unfortunately, I do not know. I payed attention just before the task creation.
Well, I went to enwiki global preferences, and changed "he" to "en". It still shows he on both sites, but it does work now.

Unfortunately closing this Phabricator task as no further steps to reproduce could be provided.

If this happens again and if you can provide the information asked for, please set the status of this task back to "Open" via the Add Action...Change Status dropdown. Thanks a lot!

Nov 3 2020, 10:36 PM · Regression, Community-Tech, MediaWiki-extensions-GlobalPreferences

Oct 1 2020

IKhitron added a comment to T258935: Add a limit to the number of sites a user can watch.

Hi, Moriel, what's up. Here are my 5 cents. I really don't think that the first option should be implemented. I do not use the global watchlist for my prime wiki. This is because I prefer the regular watchlist there, that has much more functionality (remember WLM (-: ?). I do use the global watchlist on the rest, dozens of times every day, instead of opening all the wikis that I do not reach oftenly.
Also, I use the Global Watchlist for 19 wikis, and I do not think there should be only 5. It works very fast anyway. Moreover, I do not think the new extension will be helpful for me, if it will not show at least 6 wikis - meta, mediawiki, commons, wikidata, enwiki and ruwiki.

Oct 1 2020, 5:08 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Sep 26 2020

IKhitron added a comment to T262879: Global Preferences can not be saved any more.

Unfortunately, I do not know. I payed attention just before the task creation.
Well, I went to enwiki global preferences, and changed "he" to "en". It still shows he on both sites, but it does work now.

Sep 26 2020, 2:14 AM · Regression, Community-Tech, MediaWiki-extensions-GlobalPreferences

Sep 22 2020

IKhitron added a comment to T262879: Global Preferences can not be saved any more.

Hello and thank you for your answer.

  1. No, I do not. I'm actually talking about the button "Set your global preferences".
  2. Indeed.
  3. Indeed.
  4. Indeed.
Sep 22 2020, 12:58 AM · Regression, Community-Tech, MediaWiki-extensions-GlobalPreferences

Sep 15 2020

IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

See also T262879.

Sep 15 2020, 12:23 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
IKhitron changed the subtype of T262879: Global Preferences can not be saved any more from "Task" to "Bug Report".
Sep 15 2020, 12:22 AM · Regression, Community-Tech, MediaWiki-extensions-GlobalPreferences
IKhitron created T262879: Global Preferences can not be saved any more.
Sep 15 2020, 12:22 AM · Regression, Community-Tech, MediaWiki-extensions-GlobalPreferences

Sep 14 2020

IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

Jdlrobson, I'm still not there.

Sep 14 2020, 9:36 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
IKhitron added a comment to T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.

Hello, @ovasileva, when it should start to work? It does not now.

Sep 14 2020, 1:45 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-notice, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Sep 13 2020

IKhitron added a comment to T262768: Add permalink for new page creations.

Please do. The current format is very inconvenient.

Sep 13 2020, 7:11 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T262769: Add link to specific log entry.

Yes, but there is no need to visit the page for logs.

Sep 13 2020, 7:07 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T262768: Add permalink for new page creations.

I'm talking about using it for new pages too.

Sep 13 2020, 7:06 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T262769: Add link to specific log entry.

Could you also consider a possibility to add a link mark as read, because for now we should click stop watching and then watch agsin to remove the log entry on-page?

Sep 13 2020, 6:56 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T262768: Add permalink for new page creations.

Hi, @DannyS712. Please consider a possibility to use special:diff/<page creation revision>, to make the entry format the same for all pages.

Sep 13 2020, 6:54 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Sep 11 2020

IKhitron added a comment to T259385: Work with community to fix faulty gadgets triggering JS errors.

Well, I think you can find them using regular wikisearch. And yes, I did fix it once on MediaWiki-extensions-GlobalWatchlist.

Sep 11 2020, 1:41 AM · Reading-Web-Local-Wiki-Issues

Sep 7 2020

IKhitron added a comment to T262176: Show timestamps for entries.

Fixed a little to remkve ambiguity.

Sep 7 2020, 10:35 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), User-DannyS712, MediaWiki-extensions-GlobalWatchlist