Page MenuHomePhabricator

IijimaYun
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 22 2017, 7:23 PM (289 w, 2 d)
Availability
Available
LDAP User
Iijima Yun
MediaWiki User
IijimaYun [ Global Accounts ]

Recent Activity

Nov 18 2022

IijimaYun added a comment to T285504: CdnCacheUpdate attempts to use HTTPS for purge requests, which fails when the proxy cache is not on HTTPS.

Tangentially related: when $wgUploadBaseUrl/$wgUploadPath are set to an HTTPS location, MediaWiki emits HTTP CONNECT requests to CdnServers for uploaded files' URLs (thumbnails as an example) when a File: page's cache is purged.

Nov 18 2022, 3:23 PM · Performance-Team, MediaWiki-libs-ObjectCache

Jul 21 2022

IijimaYun added a comment to T248925: Make MediaWiki release tarball compatible with PHP 8.0.

I have been running MediaWiki on PHP 8.0 since 1.38 was released, with CirrusSearch+Elastica and a number of other extensions. Using PostgreSQL back-end, to boot.

Jul 21 2022, 8:10 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group

Jul 20 2022

IijimaYun added a comment to T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.

I feel like array_shift() is out of place here: even if the assignment is replaced by a simple call, dropping the first element completely, it obviously makes the supposed later test

switch ( true ) {
                        case count( $propertyDescription ) > 1:
                                // There are multiple page props with the name 'description' present
                                // This shouldn't happen, but we'll try to clean it here
                                $db->delete(
                                        'page_props',
                                        [
                                                'pp_page' => $this->title->getArticleID(),
                                                'pp_propname' => 'description',
                                        ]
                                );
                        // Intentional fall-through, as deleting all 'description' props requires inserting a new row
                        case empty( $propertyDescription ):
                                $shouldInsert = true;
                                break;
Jul 20 2022, 3:56 PM · Patch-For-Review, WikiSEO
IijimaYun renamed T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError from DeferredDescriptionUpdate.php --force: array_shift() converts array into a string leading to a TypeError to DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.
Jul 20 2022, 3:39 PM · Patch-For-Review, WikiSEO
IijimaYun created T313419: DeferredDescriptionUpdate.php --force: use of array_shift() converts array into a string leading to a TypeError.
Jul 20 2022, 3:35 PM · Patch-For-Review, WikiSEO

Jul 14 2022

IijimaYun added a comment to T311092: Sticky header conflicts with Structured Discussions sticky header on board pages.

Note: the addition of this class to the navigation widget results in this shift on MediaWiki 1.38.1 with Vector 2022:

Jul 14 2022, 7:30 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Growth-Team (Current Sprint), StructuredDiscussions, Desktop Improvements (Vector 2022)

Jul 9 2022

IijimaYun created T312698: Echo does not support PostgreSQL.
Jul 9 2022, 3:41 PM · Growth-Team, PostgreSQL, Notifications
IijimaYun updated the task description for T312697: StructuredDiscussions uses MySQL-specific timestamp format.
Jul 9 2022, 3:34 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Growth-Team, PostgreSQL, StructuredDiscussions
IijimaYun created T312697: StructuredDiscussions uses MySQL-specific timestamp format.
Jul 9 2022, 3:33 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Growth-Team, PostgreSQL, StructuredDiscussions

Mar 22 2022

IijimaYun added a comment to T157424: TimedMediaHandler does not support PostgreSQL.

@Aklapper, my apologies, I completely forgot to comment on this. The updated extension requires 1.38 and does not work with 1.37.1.

Mar 22 2022, 2:40 PM · TestMe, PostgreSQL, TimedMediaHandler

Feb 19 2022

IijimaYun added a comment to T248925: Make MediaWiki release tarball compatible with PHP 8.0.

What about PHP 8.1 for MediaWiki 38? Can we expect it to work as well as MW 37 on PHP 8.0?

Feb 19 2022, 2:19 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group

Feb 5 2022

IijimaYun added a comment to T157424: TimedMediaHandler does not support PostgreSQL.

I am planning an upgrade to 1.37.x (still on 1.36.x at the moment) within a few days and this will be a good way to test these changes; will report here on the outcome.

Feb 5 2022, 7:30 AM · TestMe, PostgreSQL, TimedMediaHandler

Jan 31 2022

IijimaYun added a comment to T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.

I assumed HTCP is no longer used by WMF?

Jan 31 2022, 6:47 AM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

Jan 29 2022

IijimaYun added a comment to T248925: Make MediaWiki release tarball compatible with PHP 8.0.

I think this is at least related to T267524.

Jan 29 2022, 9:29 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group

Oct 29 2021

IijimaYun added a comment to T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.

If it is possible to move the current functionality into an extension without losing performance, it would be rather useful since it would be a nice example in ‘how to make a purge client extension’. I wanted to implement a small purge proxy in Rust but got stuck in MW's purge client code and then kind of forgot about it.

Oct 29 2021, 5:58 PM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

Jul 16 2021

IijimaYun created T286779: PostgresUpdater sets watchlist wl_namespace to 0 and is therefore causing duplicated key error.
Jul 16 2021, 11:43 AM · MW-1.36-release, PostgreSQL, MediaWiki-Installer

Jun 16 2021

Lens0021 awarded T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate a Heartbreak token.
Jun 16 2021, 4:53 AM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

May 10 2021

IijimaYun added a comment to T157424: TimedMediaHandler does not support PostgreSQL.

For a quick fix with a local installation, simply ALTER the schema for transcode and use TIMESTAMPTZ.

May 10 2021, 7:46 AM · TestMe, PostgreSQL, TimedMediaHandler

Dec 3 2020

IijimaYun added a comment to T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.

The rationale laid out in this blog post makes sense but I am not sure it is feasible to stay on cURL 7.61 and below forever or backport changes from newer versions.

Dec 3 2020, 7:34 PM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

Nov 9 2020

IijimaYun created T267524: Rename css-sanitizer's ‘Match’ class for PHP 8.
Nov 9 2020, 9:18 AM · PHP 8.0 support, css-sanitizer

Oct 6 2020

IijimaYun updated subscribers of T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.
Oct 6 2020, 11:18 AM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP
IijimaYun created T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.
Oct 6 2020, 11:12 AM · Performance-Team, MW-1.36-notes, MW-1.35-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), MW-1.37-release, MW-1.36-release, MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

Sep 26 2020

IijimaYun updated the task description for T263920: The createaccount permission is not revoked properly when using extension registration.
Sep 26 2020, 7:20 PM · MediaWiki-Configuration, MediaWiki-extensions-ConfirmAccount
IijimaYun created T263920: The createaccount permission is not revoked properly when using extension registration.
Sep 26 2020, 7:00 PM · MediaWiki-Configuration, MediaWiki-extensions-ConfirmAccount

Aug 16 2019

IijimaYun added a comment to T230618: ActiveUsersPager's new query logic breaks PostgreSQL compatibility.

Thank you, the patches seem to fix the issue: the Active Users page is now working as intended on all my MediaWiki instances.

Aug 16 2019, 7:28 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Platform Team Workboards (Clinic Duty Team), MediaWiki-libs-Rdbms, PostgreSQL
IijimaYun created T230618: ActiveUsersPager's new query logic breaks PostgreSQL compatibility.
Aug 16 2019, 3:45 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Platform Team Workboards (Clinic Duty Team), MediaWiki-libs-Rdbms, PostgreSQL

Aug 10 2019

IijimaYun added a comment to T157424: TimedMediaHandler does not support PostgreSQL.

Apologies for the delay, I somehow missed the e-mail notification completely. The 14-character fields are definitely not working as the format of the timestamps being inserted is full YYYY-MM-DD HH:MM:SS+TZ; TIMESTAMPTZ seems to work fine.

Aug 10 2019, 10:27 PM · TestMe, PostgreSQL, TimedMediaHandler
IijimaYun created T230270: $wgMWLoggerDefaultSpi is effectively ignored if log events occur before LocalSettings are loaded.
Aug 10 2019, 2:13 PM · MediaWiki-Debug-Logger

Jun 6 2019

IijimaYun added a comment to T29658: SquidPurgeClient fails on FreeBSD; incorrect constants + MSG_EOR w/ SOCK_STREAM.

Patch (removes EOR flag and uses PHP constants instead of hard-coded ones):

Jun 6 2019, 5:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-General

May 24 2019

IijimaYun added a comment to T222357: Cargo and PostgreSQL: schema problems and code issues.

By the way, I have another bug to report. This one I have not yet traced in the source (it is very hard to get it to actually happen and thus get a stack trace): unquoted column identifier for _pageID, once again.

May 24 2019, 8:04 PM · PostgreSQL, MediaWiki-extensions-Cargo

May 23 2019

Restricted Application added a project to T222385: MediaWiki Resource Loader, upsert(), and PostgreSQL: deadlock issues: Performance-Team.

Update: this seems to trigger DB server overload. Deadlock detection has timeouts and this leads to PostgreSQL reaching its connection limit (my max_connections is set to 1024 and it gets exhausted during massive user influx).
These hanging connections seem to lead to ResourceLoader actually failing to load CSS and JavaScript.

May 23 2019, 7:27 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MW-1.30-release-notes, MW-1.31-release-notes, Performance-Team, MediaWiki-ResourceLoader, PostgreSQL, MediaWiki-libs-Rdbms

May 9 2019

IijimaYun added a comment to T188692: Special:ExtensionDistributor displays an error.

https://www.mediawiki.org/wiki/Special:ExtensionDistributor is broken again.

May 9 2019, 10:53 PM · ExtensionDistributor
IijimaYun reopened T188692: Special:ExtensionDistributor displays an error as "Open".
May 9 2019, 10:53 PM · ExtensionDistributor

May 2 2019

IijimaYun created T222385: MediaWiki Resource Loader, upsert(), and PostgreSQL: deadlock issues.
May 2 2019, 5:39 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MW-1.30-release-notes, MW-1.31-release-notes, Performance-Team, MediaWiki-ResourceLoader, PostgreSQL, MediaWiki-libs-Rdbms
IijimaYun created T222357: Cargo and PostgreSQL: schema problems and code issues.
May 2 2019, 10:45 AM · PostgreSQL, MediaWiki-extensions-Cargo

Apr 20 2019

IijimaYun added projects to T221496: 1.32's update.php is broken for PostgreSQL: PostgreSQL, MediaWiki-Installer.
Apr 20 2019, 10:58 AM · MediaWiki-Installer, PostgreSQL
IijimaYun created T221496: 1.32's update.php is broken for PostgreSQL.
Apr 20 2019, 10:56 AM · MediaWiki-Installer, PostgreSQL
IijimaYun added a comment to T29658: SquidPurgeClient fails on FreeBSD; incorrect constants + MSG_EOR w/ SOCK_STREAM.

Note: this is still not fixed in 1.32.

Apr 20 2019, 10:41 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-General

Jan 10 2019

IijimaYun added a comment to T190343: Prune After Reject.

Pruning is broken for PostgreSQL:

Jan 10 2019, 2:00 PM · MediaWiki-extensions-ConfirmAccount

Jul 17 2018

IijimaYun added a comment to T29658: SquidPurgeClient fails on FreeBSD; incorrect constants + MSG_EOR w/ SOCK_STREAM.

Perhaps there's a better way to detect these platform-specific constants?

Jul 17 2018, 12:52 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-General

Jul 1 2018

IijimaYun renamed T197269: StructuredDiscussions schema doesn't support PostgreSQL from mzaaaaaaaa to StructuredDiscussions schema doesn't support PostgreSQL.
Jul 1 2018, 12:39 PM · Growth-Team-Filtering, Growth-Team, PostgreSQL, StructuredDiscussions

Jun 19 2018

IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

@Ivor your patch fails in the first 4 chunks for REL_1.31 so I tried adapting it. Notably there is now an $ignore check which adds DO NOTHING to the query; I added a check for $set to avoid it if we already have an ON CONFLICT UPDATE added.

Jun 19 2018, 11:37 AM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms

Jun 14 2018

IijimaYun created T197269: StructuredDiscussions schema doesn't support PostgreSQL.
Jun 14 2018, 8:56 PM · Growth-Team-Filtering, Growth-Team, PostgreSQL, StructuredDiscussions

Jan 26 2018

IijimaYun added a comment to T157424: TimedMediaHandler does not support PostgreSQL.

PostgreSQL user here, anything I could help with here? I have TMH installed and with the table/indexes added File pages seem to work so far.

Jan 26 2018, 8:47 PM · TestMe, PostgreSQL, TimedMediaHandler

Nov 8 2017

IijimaYun added a comment to T171390: Exception: Wikimedia\Rdbms\DBUnexpectedError when attempting to move within File: namespace.

It most likely is a duplicate, my apologies — should have searched better prior to creating this one.

Nov 8 2017, 3:15 PM · MediaWiki-libs-Rdbms, PostgreSQL, MediaWiki-File-management, Multimedia

Oct 11 2017

IijimaYun closed T177972: Incompatible with anything that is not MySQL/MariaDB? as Invalid.
Oct 11 2017, 5:31 PM · MediaWiki-extensions-UserMerge
IijimaYun added a comment to T177972: Incompatible with anything that is not MySQL/MariaDB?.

Oops, missed T130634, please ignore.

Oct 11 2017, 5:31 PM · MediaWiki-extensions-UserMerge
IijimaYun created T177972: Incompatible with anything that is not MySQL/MariaDB?.
Oct 11 2017, 5:30 PM · MediaWiki-extensions-UserMerge
IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

Re: the first issue, I checked the documentation and seems like changing in page/WikiPage.php:

Oct 11 2017, 4:34 PM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms
IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

Further testing:

Oct 11 2017, 7:46 AM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms

Oct 5 2017

IijimaYun added a comment to T160910: File moves throw error when using postgres.

File moving is still broken in 1.29.1:

Oct 5 2017, 4:43 PM · Performance-Team, MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-libs-Rdbms, MediaWiki-File-management, PostgreSQL, Multimedia
IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

@Ivor, I applied your patch 2 days ago and no errors so far, thank you. Benchmarks show database query time improvements of around 5% (probably thanks to no error logging going on any more, along with a better query plan).

Oct 5 2017, 11:40 AM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms

Oct 4 2017

IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

this revealed the missing unique index in the mediawiki.redirect table over rd_from (this is a foreign key, but we don't want a page to be redirected to two or more other pages -- this never actually happened, I assume it's handled in the code, but the unique index is required in the ON CONFLICT clause). After creating the unique index, all error messages seem to be gone now.

Oct 4 2017, 12:41 PM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms
IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

Side note: technically there are no problems that could lead to any kind of data loss or corruption (this happens inside a transaction), but I am not sure it is good practice to issue statements that lead to messages flooding the database server's error log.

Oct 4 2017, 12:09 AM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms

Oct 3 2017

IijimaYun added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

I would like to reiterate that this error appears in PostgreSQL error log with a severity of ERROR. Debug log is off at least in my case.

Oct 3 2017, 10:38 PM · MW-1.32-release, PostgreSQL, MediaWiki-libs-Rdbms

Sep 29 2017

IijimaYun added a comment to T177074: Database::upsert: weird behaviour after upgrading to 1.29.x or installing a fresh 1.29.x.

Thank you. I guess this won't ever be fixed, then.

Sep 29 2017, 2:46 PM · MediaWiki-libs-Rdbms
IijimaYun updated the task description for T177074: Database::upsert: weird behaviour after upgrading to 1.29.x or installing a fresh 1.29.x.
Sep 29 2017, 2:22 PM · MediaWiki-libs-Rdbms
IijimaYun created T177074: Database::upsert: weird behaviour after upgrading to 1.29.x or installing a fresh 1.29.x.
Sep 29 2017, 1:57 PM · MediaWiki-libs-Rdbms

Jul 22 2017

IijimaYun created T171390: Exception: Wikimedia\Rdbms\DBUnexpectedError when attempting to move within File: namespace.
Jul 22 2017, 7:36 PM · MediaWiki-libs-Rdbms, PostgreSQL, MediaWiki-File-management, Multimedia