Page MenuHomePhabricator

Isarra (Calimonius the Estrange)
Lobber of Chickens

Projects (31)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 12:10 AM (262 w, 5 d)
Availability
Available
LDAP User
Isarra
MediaWiki User
Isarra [ Global Accounts ]

Recent Activity

Tue, Oct 15

Isarra added a comment to T235459: Timeless treatment of <h2> is somewhat different than Vector.

Vector uses border-bottom directly for h2s and hides all overflow to avoid this intersecting with floats, but it's a very harsh way of handling things. Unfortunately this was basically the only option back when the styles were created years and years ago, back when we also had to support IE6 and crap. Timeless does ::after pseudo-elements to render the border-bottom and thus can put the overflow rules on that alone, and avoid the problems with scripts being cut off, gadget conflicts, overlapping borders, etc. We weren't really sure if this would work in practice and thus didn't push for doing it everywhere, but given that it actually does seem to work and the issues largely just appear to be with pages where people explicitly styled around the existing approach and don't have styles for this variant, it might be worth migrating everything else to do it this way and thus negate the need for all the special language-specific styles in Vector etc...

Tue, Oct 15, 1:02 PM · Timeless

Tue, Oct 8

Isarra added a comment to T234907: RFC: Where to implement Desktop Improvements project.

As always, I highly recommend against forking Vector. Its internals are dated and highly inconsistent after accumulated years of overengineering, and you will waste considerable time trying to clean that up/figure out what's going on, and even then you will undoubtably wind up with quite a bit of unnecessary code in your final product. Better to start from scratch: fork the Example skin, as recommended, and (re)add in the required features there. The result will be much cleaner, and ultimately easier to both make and maintain, following best practices.

Tue, Oct 8, 2:08 PM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC

Fri, Oct 4

Isarra added a comment to T234098: $wgNamespaceLogos sets logos on wrong namespaces.

Thanks. >.<

Fri, Oct 4, 1:02 PM · LogoFunctions

Tue, Oct 1

Isarra added a comment to T234305: WikiLove doesn't have a word in wide mode.

It's because wikilove has an option to use an icon only. Because this option is targeted at desktop (vector, originally), we heed it in timeless desktop layouts too.

Tue, Oct 1, 2:12 PM · Timeless

Sun, Sep 29

Isarra updated the task description for T220765: Create a structured talkpage handler extension consistent with extant user talkpage expectations.
Sun, Sep 29, 7:53 PM · Epic, THICC, Uncyclomedia

Fri, Sep 27

Isarra created T234098: $wgNamespaceLogos sets logos on wrong namespaces.
Fri, Sep 27, 8:01 PM · LogoFunctions
Isarra added a comment to T223185: CreateCollaborationHub: creating pages when user language doesn't match wiki language results in breakages.

Per https://test.wikipedia.org/wiki/Special:PrefixIndex/Wikipedia:Test_collab, 'Announcements' is properly transcluded; 'Membres' is not not. Hub appears to have been created on an english-language project by a french user, hence the issue. In practice, 'Members' should probably just be treated the same as 'Announcements'.

Fri, Sep 27, 7:28 PM · MediaWiki-extensions-CollaborationKit
Isarra added a comment to T234086: Missing detailed license info on enwiki.

Dumb question, but why exactly do we need to manually include the license with every extension when for the most part there are only like five different licenses between the lot of them? Maybe it's just that I'm not really coming from a software background, here, but that just seems needlessly redundant, especially when they all rely on mw to even do anything in the first place.

Fri, Sep 27, 7:24 PM · User-DannyS712, Community-Tech, TCB-Team, Timeless, MediaWiki-extensions-CodeMirror, ConfirmEdit (CAPTCHA extension), QuickSurveys, RelatedArticles, Parsoid, UniversalLanguageSelector, Two-Column-Edit-Conflict-Merge, Revision-Slider

Thu, Sep 26

Pelagic awarded T122924: Merge Extension:Theme into core a 100 token.
Thu, Sep 26, 1:22 PM · TechCom-RFC, Patch-For-Review, Technical-Debt, Theme, Front-end-Standards-Group, MediaWiki-Interface
Isarra added a comment to T232541: Reduce available colour palette for themes and ensure each colour has sufficient (and not excessive) contrast for all uses.

Palette reduced. Should no longer be a blocker as such, and this should require no further schema changed.

Thu, Sep 26, 2:43 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra closed T214121: Consider redesigning subpage ToC as Resolved.

Whatever.

Thu, Sep 26, 2:43 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra closed T214123: Redesign CollaborationHub ToC as Resolved.
Thu, Sep 26, 2:42 AM · MediaWiki-extensions-CollaborationKit

Wed, Sep 25

Isarra closed T231400: GeoHack coordinates are misaligned again as Resolved.

Onwiki fix: https://en.wikipedia.org/w/index.php?title=MediaWiki:Timeless.css&diff=next&oldid=915346348

Wed, Sep 25, 10:49 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra awarded T233359: Replace `inline-block` on boxed messages by `block` a Love token.
Wed, Sep 25, 10:36 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MediaWiki-General, UI-Standardization, Vector, MinervaNeue, UI-Standardization-Kanban
Isarra moved T131803: Options to only use a specific layout/not go bigger - single-column with only dropdown menus, or one sidebar-only from In progress, or perhaps should be to Features on the Timeless board.
Wed, Sep 25, 7:37 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Timeless
Isarra added a comment to T233564: Timeless contains non-standard/deprecated flexbox CSS.

I'm also not actually sure why that was there in the first place, and it may not even be needed in the first place. Might be worth looking into that aspect of it, too...

Wed, Sep 25, 7:29 PM · Timeless

Tue, Sep 24

Isarra committed rELOGe82cb579b712: Check for false on wfFindFile failure, not null... (authored by Isarra).
Check for false on wfFindFile failure, not null...
Tue, Sep 24, 3:11 PM

Sep 15 2019

Isarra committed rELOG2c10022d8997: Reimplement extension using plain CSS smashed onto the page (authored by Isarra).
Reimplement extension using plain CSS smashed onto the page
Sep 15 2019, 4:39 PM
Isarra created T232952: Support using namespace constants for setting namespace logos.
Sep 15 2019, 4:33 PM · LogoFunctions
Isarra closed T232642: Add per-speaker classes to dialogue blocks as Resolved.
Sep 15 2019, 4:31 PM · MediaWiki-extensions-Screenplay
Isarra closed T208342: Extension:LogoFunctions.php doesn't set the page logo as of MediaWiki 1.31.x as Resolved.
Sep 15 2019, 4:31 PM · Uncyclomedia, LogoFunctions
Isarra closed T220058: LogoFunctions: Restore custom functionality for defined logos for namespaces as Resolved.
Sep 15 2019, 4:31 PM · LogoFunctions, Uncyclomedia
Isarra closed T232540: Custom logo handler results in insufficiently high-res logos for mobile devices as Resolved.
Sep 15 2019, 4:31 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Timeless
Isarra closed T232905: LogoFunctions: Restore StampLogo functionality as Resolved.
Sep 15 2019, 4:31 PM · LogoFunctions
Isarra closed T214105: CollaborationKit EditPage styles too strong, a subtask of T192327: Redesign CollaborationKit with more skin-agnostic styles (consistent with mediawiki.skinning.interface styles), as Resolved.
Sep 15 2019, 3:10 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), MediaWiki-extensions-CollaborationKit
Isarra closed T214105: CollaborationKit EditPage styles too strong as Resolved.
Sep 15 2019, 3:10 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit

Sep 14 2019

Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

Okaaaay, the new version of the patch should do it, but will require another update to the above localpage once it goes live...

Sep 14 2019, 1:42 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra closed T232853: Add tracking category to screenplay tag uses as Resolved.
Sep 14 2019, 1:37 AM · MediaWiki-extensions-Screenplay
Isarra created T232905: LogoFunctions: Restore StampLogo functionality.
Sep 14 2019, 1:28 AM · LogoFunctions
Isarra merged T146940: LogoFunctions: Add the possibility to reload logo into T208342: Extension:LogoFunctions.php doesn't set the page logo as of MediaWiki 1.31.x.
Sep 14 2019, 1:25 AM · Uncyclomedia, LogoFunctions
Isarra merged task T146940: LogoFunctions: Add the possibility to reload logo into T208342: Extension:LogoFunctions.php doesn't set the page logo as of MediaWiki 1.31.x.
Sep 14 2019, 1:25 AM · LogoFunctions

Sep 13 2019

Isarra added a comment to T182069: Table of contents code does not show on Timeless on mobile domain in tablet mode.

<3

Sep 13 2019, 8:51 PM · MobileFrontend, Readers-Web-Backlog (Tracking), WMSE-Bug-Reporting-and-Translation-2017, Timeless
Isarra updated the task description for T114030: Add support for missing elements.
Sep 13 2019, 7:45 PM · MediaWiki-extensions-Screenplay
Isarra created T232890: Specifically parse SPEAKER extensions.
Sep 13 2019, 7:43 PM · MediaWiki-extensions-Screenplay
Isarra created T232889: Expand templates before running screenplay parser so they can be parsed as directly inserted content.
Sep 13 2019, 7:31 PM · MediaWiki-extensions-Screenplay
Isarra created T232853: Add tracking category to screenplay tag uses.
Sep 13 2019, 4:13 PM · MediaWiki-extensions-Screenplay

Sep 12 2019

Isarra added a comment to T156130: Responsive styles for CollaborationKit.

This is now a lot simpler and just requires some sane styles. Yippee?

Sep 12 2019, 11:43 PM · Technical-Debt, MediaWiki-extensions-CollaborationKit
Isarra renamed T156130: Responsive styles for CollaborationKit from Make CK work with MobileFrontend to Responsive styles for CollaborationKit.
Sep 12 2019, 11:43 PM · Technical-Debt, MediaWiki-extensions-CollaborationKit
Isarra moved T214113: CollaborationList list columns look kind of silly and should line up better from In Progress to Future Releases on the MediaWiki-extensions-CollaborationKit board.
Sep 12 2019, 11:39 PM · MediaWiki-extensions-CollaborationKit
Isarra moved T214121: Consider redesigning subpage ToC from Release bugs to In Progress on the MediaWiki-extensions-CollaborationKit board.
Sep 12 2019, 11:39 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra moved T214123: Redesign CollaborationHub ToC from Release bugs to In Progress on the MediaWiki-extensions-CollaborationKit board.
Sep 12 2019, 11:39 PM · MediaWiki-extensions-CollaborationKit
Isarra closed T214107: createcollaborationhub/list form input alignment issues as Resolved.
Sep 12 2019, 10:54 PM · MediaWiki-extensions-CollaborationKit
Isarra moved T192327: Redesign CollaborationKit with more skin-agnostic styles (consistent with mediawiki.skinning.interface styles) from In Progress to Future Releases on the MediaWiki-extensions-CollaborationKit board.
Sep 12 2019, 10:34 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), MediaWiki-extensions-CollaborationKit
Isarra added a comment to T232541: Reduce available colour palette for themes and ensure each colour has sufficient (and not excessive) contrast for all uses.

Well, above patch kills most of the 'too much contrast' cases, but what in the world is with that 'pastel yellow'?

Sep 12 2019, 10:33 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra renamed T232541: Reduce available colour palette for themes and ensure each colour has sufficient (and not excessive) contrast for all uses from Reduce available colour palette for themes to Reduce available colour palette for themes and ensure each colour has sufficient (and not excessive) contrast for all uses.
Sep 12 2019, 10:33 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra renamed T231138: VE and other OOUI dialog overlays results in scrollbar disappearing (all skins) and can mess up various relatively positioned styles underneath overlay (timeless desktop-small) from VE dialog overlay results in scrollbar disappearing (all layouts) and non-fixed header being positioned incorrectly (desktop-small) to VE and other OOUI dialog overlays results in scrollbar disappearing (all skins) and can mess up various relatively positioned styles underneath overlay (timeless desktop-small).
Sep 12 2019, 9:01 PM · OOUI, MonoBook, Vector, Timeless
Isarra added projects to T231138: VE and other OOUI dialog overlays results in scrollbar disappearing (all skins) and can mess up various relatively positioned styles underneath overlay (timeless desktop-small): Vector, MonoBook.

The scrollbar thing also looks quite strange in MonoBook and Vector, just doesn't stand out as much.

Sep 12 2019, 8:43 PM · OOUI, MonoBook, Vector, Timeless
Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

Slight problem in that different browsers appear to have wildly different line-heights and I do not know how to account for that with css when the problem is that we are trying to insert content data into a non-content part of the page...

Sep 12 2019, 8:15 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T231246: Collapse sections on small screens on long pages.

Note that this already works fine with MF, and probably belongs in core...

Sep 12 2019, 7:58 PM · Timeless
Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

Note that this will also require the VE-specific styles to be removed entirely once merged/deployed, as they will no longer be needed at that point.

Sep 12 2019, 7:22 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

That should cover the weirdness where https://en.wikipedia.org/w/index.php?title=MediaWiki:Timeless.css&diff=915346348&oldid=853254178 isn't enough.

Sep 12 2019, 7:20 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

Nevermind, looks like it's in mediawiki:Timeless.css... I'll just update that, I guess?!

Sep 12 2019, 5:54 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

All right, ashley found the things:

Sep 12 2019, 5:43 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T232692: Should MediaWiki stop storing sessions on the server?.

So what's the specific problem with regard to MediaWiki? Is this blocking something? Would it enable us to do something of particular value in our contexts here?

Sep 12 2019, 3:52 PM · MediaWiki-Authentication-and-authorization
RogueScholar awarded T231400: GeoHack coordinates are misaligned again a Cup of Joe token.
Sep 12 2019, 6:36 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless

Sep 11 2019

Isarra added a comment to T231400: GeoHack coordinates are misaligned again.

All right, seems to be related to the position:relative on #mw-content-text. That maybe shouldn't even be there (should probably be on a block around/under the firstheading)...

Sep 11 2019, 9:47 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Timeless
Isarra added a comment to T173245: Add jump to bottom and jump to top buttons.

And I could really use a sticky 'edit current section' button, while we're at it...

Sep 11 2019, 9:02 PM · Timeless
Isarra renamed T173245: Add jump to bottom and jump to top buttons from Add jump to bottom and jump to top buttons to the freezed upper menu to Add jump to bottom and jump to top buttons.
Sep 11 2019, 8:54 PM · Timeless
Isarra added a comment to T173245: Add jump to bottom and jump to top buttons.

Mobile:

  • Absolutely needs sticky top/bottom links somehow. I just got trapped on a long page and it sucks.
Sep 11 2019, 8:53 PM · Timeless
Isarra created T232675: Turn sitename in header into navigation dropdown toggle.
Sep 11 2019, 8:49 PM · Timeless
Isarra reopened T131803: Options to only use a specific layout/not go bigger - single-column with only dropdown menus, or one sidebar-only as "Open".

Patch was reverted for reasons. Apparently mw has too many modules and that's bad for js.

Sep 11 2019, 6:29 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Timeless
Isarra closed T232411: Sitetitle overflows in desktop-mid/large as Resolved.
Sep 11 2019, 6:19 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Timeless
Isarra closed T223186: Automatically categorise CollaborationHubs and Lists as Resolved.
Sep 11 2019, 6:18 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra closed T223186: Automatically categorise CollaborationHubs and Lists, a subtask of T214114: General metrics reports for CollaborationKit, as Resolved.
Sep 11 2019, 6:18 PM · MediaWiki-extensions-CollaborationKit
Isarra created T232642: Add per-speaker classes to dialogue blocks.
Sep 11 2019, 5:53 PM · MediaWiki-extensions-Screenplay
Isarra created T232641: Allow setting avatars/tokens for speakers (for non-screenplay uses).
Sep 11 2019, 5:51 PM · MediaWiki-extensions-Screenplay
Isarra closed T159020: Compatibility between Screenplay and Timeless skin as Resolved.

Between the patch for the general mobile support and https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/535273 we should be good.

Sep 11 2019, 5:45 PM · MediaWiki-extensions-Screenplay, Timeless
Isarra closed T150830: Screenplay styles don't work with mobilefrontend as Resolved.

We live in the future now!

Sep 11 2019, 5:45 PM · MediaWiki-extensions-Screenplay
Isarra closed T114027: Allow scalable font size/line width for smaller devices/skins as Resolved.
Sep 11 2019, 5:44 PM · MediaWiki-extensions-Screenplay
Isarra closed T114027: Allow scalable font size/line width for smaller devices/skins, a subtask of T159020: Compatibility between Screenplay and Timeless skin, as Resolved.
Sep 11 2019, 5:44 PM · MediaWiki-extensions-Screenplay, Timeless

Sep 10 2019

Isarra created T232541: Reduce available colour palette for themes and ensure each colour has sufficient (and not excessive) contrast for all uses.
Sep 10 2019, 9:39 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra created T232540: Custom logo handler results in insufficiently high-res logos for mobile devices.
Sep 10 2019, 9:35 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Timeless
Isarra moved T223269: CollaborationKit: Tag logs involving hubs and lists from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.
Sep 10 2019, 9:29 PM · MediaWiki-extensions-CollaborationKit
Isarra moved T223186: Automatically categorise CollaborationHubs and Lists from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.
Sep 10 2019, 9:28 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit
Isarra added a comment to T223186: Automatically categorise CollaborationHubs and Lists.

Turns out because we're manhandling both parser and parseroutput objects this is actually ridiculously easy and I'm a dumbarse.

Sep 10 2019, 9:26 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-CollaborationKit

Sep 9 2019

Isarra added a comment to T232411: Sitetitle overflows in desktop-mid/large.

Should do

Sep 9 2019, 10:55 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Timeless
Isarra created T232411: Sitetitle overflows in desktop-mid/large.
Sep 9 2019, 10:54 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Timeless

Sep 6 2019

Isarra added a comment to T232148: Provide a single-module registration mechanism for skin modules in ResourceLoader.

@Isarra That's an interesting idea. Roan had the same idea a few weeks back. Unfortunately, that's not compatible with how MW works.

Sep 6 2019, 4:14 PM · Performance-Team, Proposal, MediaWiki-ResourceLoader
Isarra closed T175832: Clicking on the "context menu icon" on an alert message shows the message below the alert window as Invalid.

Given that it's been a very long time since I filed this, I don't remember what I actually meant to note as a bug. I should have at least attached a screen shot at that time, my bad. I'll let you know if I do come across this again when I start using the Timeless theme again.

Sep 6 2019, 3:10 PM · Timeless

Sep 5 2019

Isarra added a comment to T131991: Implement theme support and add 'winter' and 'night' variants.

Note: default theme has basically been named 'wikimedia' internally.

Sep 5 2019, 11:34 PM · Timeless
Isarra added a comment to T232012: Logos that aren’t 135px wide don’t scale correctly at 1.5x and 2x resolutions.

Linked image size:

Sep 5 2019, 11:29 PM · CSS, Logos, MediaWiki-Interface
Isarra added a comment to T232167: Section toggle indicators sometimes appear in weird places on mobile Timeless.

Other skins accidentally avoid this issue by setting overflow: hidden (Vector and most other skins)

Sep 5 2019, 11:15 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Timeless, MobileFrontend
Isarra added a comment to T232148: Provide a single-module registration mechanism for skin modules in ResourceLoader.

Why skins? Why not let people just mark modules as 'stylemodules', not worry about what the hell is providing them, and then not add them to the giant js bloat pile and be done with it?

Sep 5 2019, 10:44 PM · Performance-Team, Proposal, MediaWiki-ResourceLoader
Isarra added a comment to T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.

So what Timeless does is you can either specify an array with all the image information (1x, 1.5x, 2x versions, plus nominal size), or just upload a file and it figures the rest out for you, but... yeah, skins will be making different sizes of these - what we should be standardising, however, are the intended dimensions so site admins can just upload one (set) and be done with it. We seem to have two use cases - likely square logos, and generally rectangular wordmarks. So if we settle on this, perhaps we just need to decide how big they should be uploaded up to in order to support all the likely uses different skins will want, and thus what to recommend for rasters?

Sep 5 2019, 7:24 PM · Logos, MediaWiki-Interface
Isarra added a comment to T232012: Logos that aren’t 135px wide don’t scale correctly at 1.5x and 2x resolutions.

In Timeless we basically just threw out the entire thing to roll a new logo handler using img srcsets (and optionally, the core thumb handler to generate the different resolutions for us) - this allows for arbitrarily-sized images to scale correctly regardless of how big they are to begin with.

Sep 5 2019, 7:14 PM · CSS, Logos, MediaWiki-Interface
Isarra updated subscribers of T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.

Basically, Timeless already optionally does this ($wgTimelessWordmark and $wgTimelessLogo). Minerva does part of this (the wordmark), and simply doesn't use a square image logo to begin with. I am suggesting that everything should be doing this and we need to totally rework our logo handling on this assumption.

Sep 5 2019, 6:55 PM · Logos, MediaWiki-Interface
Isarra created T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.
Sep 5 2019, 6:50 PM · Logos, MediaWiki-Interface
Isarra updated subscribers of T232012: Logos that aren’t 135px wide don’t scale correctly at 1.5x and 2x resolutions.
Sep 5 2019, 6:11 PM · CSS, Logos, MediaWiki-Interface
Isarra added a comment to T232012: Logos that aren’t 135px wide don’t scale correctly at 1.5x and 2x resolutions.

There is also a major issue in that a 'recommended size' isn't something we can meaningfully standardise, as what is going to be optimal is also going to vary considerably depending on a site's (main) skin. 135px is a good size for MonoBook. 155px is a better size for Vector (while still almost fitting on MonoBook, which tops out at ~154x155px). Timeless starts looking a bit weird when you go under 150px, and if anything the recommended there would be more like 160px. Greystuff and BlueSky use the same logo, but then scale it down to 66px and 55px respectively, and we don't even need a HiDPI version for that at all.

Sep 5 2019, 5:56 PM · CSS, Logos, MediaWiki-Interface
Isarra added a watcher for Logos: Isarra.
Sep 5 2019, 5:54 PM
Isarra added a comment to T232012: Logos that aren’t 135px wide don’t scale correctly at 1.5x and 2x resolutions.

So the reason for the 135px thing on the higher-resolution versions is because raster background images really aren't intended to scale properly for different viewports.

Sep 5 2019, 5:41 PM · CSS, Logos, MediaWiki-Interface

Sep 3 2019

Isarra added a comment to T231925: Minerva should support skin agnostic mw.util.addPortletLink or similar.

BaseTemplate should probably just come with a default handler for older skins (Vector etc) where it just does the same as the current on in effect so folks can safely migrate and not worry about what skins they're targetting.

Sep 3 2019, 6:09 PM · Readers-Web-Backlog, MinervaNeue, Front-end-Standards-Group
Isarra added a comment to T231925: Minerva should support skin agnostic mw.util.addPortletLink or similar.

(But yeah, tacking it onto the end with a default fallback seems fine to me.)

Sep 3 2019, 6:01 PM · Readers-Web-Backlog, MinervaNeue, Front-end-Standards-Group
Isarra added a comment to T231925: Minerva should support skin agnostic mw.util.addPortletLink or similar.

We may want to consider an approach here that would also be consistent with other skins that use icons for menus and whatnot - for instance as I recall, bluesky had an option to just shove icons into the mediawiki:sidebar that it would parse and use for its main menu. I dunno if that's necessarily indicative of an approach that would actually work here, but it's something to consider - we probably need to establish a consistent way of handling icons for skins that use them regardless.

Sep 3 2019, 5:59 PM · Readers-Web-Backlog, MinervaNeue, Front-end-Standards-Group

Sep 2 2019

Daylen awarded T122924: Merge Extension:Theme into core a Love token.
Sep 2 2019, 3:26 AM · TechCom-RFC, Patch-For-Review, Technical-Debt, Theme, Front-end-Standards-Group, MediaWiki-Interface

Aug 30 2019

Isarra added a comment to T190991: Grey lines appearing while scrolling up the 2010 wikitext editor window with a scroll wheel under Timeless skin in IE11.

It won't actually hit enwp until the third or the fifth, based on the patch notes.

Aug 30 2019, 11:33 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Page-editing, Browser-Support-Internet-Explorer, Timeless
Isarra created P9015 frwp skin stats.
Aug 30 2019, 8:28 PM
Isarra added a comment to T131991: Implement theme support and add 'winter' and 'night' variants.

Not listed is experiment 2, because I forgot to link the task: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/530456

Aug 30 2019, 8:02 PM · Timeless
Isarra moved T181177: Hovered links don't distinguish sufficiently from visited links in Timeless from Bugs to In progress, or perhaps should be on the Timeless board.
Aug 30 2019, 6:47 PM · Accessibility, Timeless
Isarra moved T181192: "External" links hovered over don't have indication of hover in Timeless from Bugs to In progress, or perhaps should be on the Timeless board.
Aug 30 2019, 6:47 PM · Accessibility, Timeless