Page MenuHomePhabricator

Isarra (Calimonius the Estrange)
Lobber of Chickens

Projects (43)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 12:10 AM (355 w, 2 d)
Availability
Available
LDAP User
Isarra
MediaWiki User
Isarra [ Global Accounts ]

Recent Activity

Jun 2 2021

Isarra awarded T899: Unclear what the point of tokens in Phabricator is a Like token.
Jun 2 2021, 3:42 PM · Phabricator

Jun 1 2021

Isarra added a comment to T280285: In in Timeless, Modern, CologneBlue Table of contents now has smaller font size and centered heading.

Several styles previously found in 'interface' or 'elements' or 'content' or something (I'm not really sure which, as I've never really used any of these to begin with) are now in legacy. This includes the toc-style catlist box and thumbnail icons that now override any skin-specific icons (T280292).

The thumbnail issue looks backwards compatible to me in that the content is perfectly readable. The fact that the default styling has changed is expected. The legacy feature contained a few styles for thumbnails and we decided it was important that we applied those styles consistently. If those are not wanted in Timeless, the usage of the legacy feature should be removed, or more explicit overrides should be provided. I don't see this as a problem for 1.36.

Perfectly readable, and very broken:

image.png (692×1 px, 445 KB)

@Isarra which skin is this? I'd like to test the patches on this one to see if it goes far enough.

Jun 1 2021, 10:27 PM · CologneBlue, Patch-For-Review, MediaWiki-Core-Skin-Architecture, Regression, Modern, Timeless

May 30 2021

Isarra added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

And at this point, I would think no skins should be using these modules, as at very least mediawiki.skinning.interface has been deprecated as of... what, 1.35 at least? And the parsoid one probably shouldn't exist either at this point.

May 30 2021, 6:18 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless

May 15 2021

Isarra added a comment to T279951: height=xxx is not respected in timeless.

Oh, if you do want to fix it ahead of the time in the gadget, set the 'width' to an actual value. Make this one do width=20 instead of height=20. Mind you, heights actually totally make sense for indicators anyway, so it might make more sense to just leave it and see if all these patches fix it...

May 15 2021, 3:02 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Timeless
Isarra added a comment to T279951: height=xxx is not respected in timeless.

This really kind of depends on four different patches. Patch 1 and 2, moving the mw-body-content class to what the skin receives, and removing mw-body-content from anything the skin does itself. Patch 3: removing mw-body-content from the indicators. Patch 4: apparently the only one I actually linked here.

May 15 2021, 2:56 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Timeless
Isarra renamed T282943: Wikibase entity view heading 'edit'/toolbar hides random words in various skins due to absolute positioning from Timeless sometimes hides words in Wikidata items to Wikibase entity view heading 'edit'/toolbar hides random words in various skins due to absolute positioning.
May 15 2021, 2:24 PM · Wikidata
Isarra added a comment to T282943: Wikibase entity view heading 'edit'/toolbar hides random words in various skins due to absolute positioning.

That screenshot of vector also has a missing word. Line should be 'must not be violated'. Vector is missing 'be'; timeless is missing 'not'.

May 15 2021, 2:14 PM · Wikidata

May 12 2021

Isarra added a comment to T211564: Printing pages with tables in Timeless-skin gives different result than printing in Vector-skin .

Wait, do we just need to apply some of the weird table js to print, and swap out the css, for this?

May 12 2021, 6:19 PM · Timeless

May 11 2021

Isarra created T282594: Rebranch Timeless for 1.36.
May 11 2021, 6:16 PM · MW-1.36-notes, MW-1.36-release, Timeless
Isarra updated the task description for T282578: Redesign header bar to include avatars, taglines, and support different modes when fixed or not.
May 11 2021, 3:19 PM · Epic, Timeless
Isarra created T282578: Redesign header bar to include avatars, taglines, and support different modes when fixed or not.
May 11 2021, 3:16 PM · Epic, Timeless
Isarra closed T271050: Danglers in the username dropdown are cut off as Resolved.

Looks resolved, patch went through, apparently forgot to close this. Please reopen if I'm wrong.

May 11 2021, 2:38 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Timeless
Isarra created T282571: Account for visually-incompatible features styles in 1.36+.
May 11 2021, 2:33 PM · HasSomeColours, WoOgLeShades, GreyStuff

May 10 2021

Isarra created T282468: Thumb enlarge icon: correctly style for rtl content in ltr overall layout and visa versa.
May 10 2021, 4:38 PM · WoOgLeShades, GreyStuff, Splash, Timeless
Isarra removed projects from T239914: Class "toccolours" not styled: Splash, Timeless.
May 10 2021, 4:27 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), GreyStuff, BlueSky, WoOgLeShades, HasSomeColours, Mask
Isarra added a comment to T282464: Footer icons in the same category should also have separation.

Tagged skins may or may not be affected, but I definitely didn't account for this when styling them, so they should be checked. Unsure about any others.

May 10 2021, 3:31 PM · BlueSky, GreyStuff, Splash, HasSomeColours, Anisa, Timeless, WoOgLeShades
Isarra created T282464: Footer icons in the same category should also have separation.
May 10 2021, 3:30 PM · BlueSky, GreyStuff, Splash, HasSomeColours, Anisa, Timeless, WoOgLeShades

May 6 2021

Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

But I figured it out. I can now die satisfied, having wasted all evening on this, and who knows how many other hours of confusion and frustration, all because I was too lazy to set a copyright on a migration test wiki...

May 6 2021, 1:42 AM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

Nope, nevermind, it's not actually catching the empty copyright array in any current version.

May 6 2021, 1:39 AM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

The logic check should still happening, it's just been abstracted away so skins don't have to worry about it. Skins should not have any need to validate.
Let me know if you have found a bug, by providing a LocalSettings configuration that doesn't work and I'll take a look.

May 6 2021, 12:26 AM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst

May 5 2021

Isarra added a comment to T280292: Timeless thumbnails do not appear as they used to.

So that actually would be a good step toward T280723, at least?

May 5 2021, 11:41 PM · MediaWiki-Core-Skin-Architecture, MW-1.36-notes, MW-1.36-release, Patch-For-Review, Timeless
Isarra added a comment to T280292: Timeless thumbnails do not appear as they used to.

^ Based on your feedback here. @Izno @Isarra does this have the desired effect? If so I can backport to 1.36.

May 5 2021, 11:28 PM · MediaWiki-Core-Skin-Architecture, MW-1.36-notes, MW-1.36-release, Patch-For-Review, Timeless
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

The issue is that previously skins using BaseTemplate::getFooterIcons could assume that what they got back was validated in that it was only icons, and that no empty or non-icon items would be returned. Given the mw installer/standard LocalSettings config also expect this and indirectly set unused default icons to empty arrays (so it's not exactly like sysadmins are likely to figure out some way to work around it on their end, either), this results in problems for any skins styling the footer icons in any way that assumes there actually be an icon there (for example padding, borders, spacers).

May 5 2021, 1:27 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

...yeah there's no way to validate the icons in skin.php without actually moving the whole getFooterIcons function into that instead. 'get' definitely can't do this.

May 5 2021, 12:51 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

So either we need to merge the above (and a followup patch) into 1.35, or we gotta go back and redo all the skins that assumed the footerIcons would actually be validated after getting them (which BaseTemplate did, but 'get' does not)...

May 5 2021, 12:45 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra committed R1893:0ad6616423ac: Add support for i18n messages to sidebar headers to correctly translate (authored by ashley).
Add support for i18n messages to sidebar headers to correctly translate
May 5 2021, 2:48 AM
Isarra added a comment to T239914: Class "toccolours" not styled.

Welp, looks like this was resolved in core by toccolours being set in the toc feature, which means all my skins are going to have to override that back to something that matches too... :P

May 5 2021, 12:13 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), GreyStuff, BlueSky, WoOgLeShades, HasSomeColours, Mask
Isarra added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

Several styles previously found in 'interface' or 'elements' or 'content' or something (I'm not really sure which, as I've never really used any of these to begin with) are now in legacy. This includes the toc-style catlist box and thumbnail icons that now override any skin-specific icons (T280292).

The thumbnail issue looks backwards compatible to me in that the content is perfectly readable. The fact that the default styling has changed is expected. The legacy feature contained a few styles for thumbnails and we decided it was important that we applied those styles consistently. If those are not wanted in Timeless, the usage of the legacy feature should be removed, or more explicit overrides should be provided. I don't see this as a problem for 1.36.

May 5 2021, 12:11 AM · MediaWiki-Core-Skin-Architecture

May 4 2021

Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

Which if anything has been a bit of a regression where it's been implemented, as generally it's better to keep content styles consistent between all pages, whether they're parser output or special pages or whatever.

Agreed, but that's a regression that predates this change, and this change allows us to keep content styles consistent across skins by making mw-body-content a first class citizen provided by core rather than a class that skins must remember to add.

May 4 2021, 9:07 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

Well, based on a very brief look at https://codesearch.wmcloud.org/search/?q=%5C.mw-body-content&i=nope&files=&excludeFiles=&repos= it looks like all of the following will likely be impacted...

These are not impacted. While they use the class, they will not be impacted by the change here as they have no styling rules that will be broken. Skins that are using the class will continue to use that class and the styling rules in each of them will also apply.

May 4 2021, 8:58 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

...

You said: skins (also) use .mw-body-content as the generic parent for selectors that implement general styles for chunks of HTML content that should be styled as "wiki" .
I don't think this is true, and haven't seen evidence for this, but it's possible you have information I don't.

I think this is based on how skins used to do this, but I don't have any evidence suggesting this statement this true. It might have been true in 2015, but over the last few years skins have being using the mw-parser-output class for such things.

May 4 2021, 8:11 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture

May 3 2021

Isarra added a comment to T281634: Table of contents fonts smaller .

Based on how Vector seems to have previously been/normally just has all the text be that tiny at such resolutions, I suspect chrome might be trying to work around whyever that is (likely legacy Vector not being marked as responsive and not having the viewport etc stuff set?) and make it actually legible. And it's just not applying to the toc itself for some reason. So the issue here is probably just a case of 'skin is old and not responsive to begin with'.

May 3 2021, 5:08 PM · Browser-Support-Android-Google-Chrome

May 2 2021

Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.
May 2 2021, 5:00 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.
May 2 2021, 4:56 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

Specifically, how we can avoid triggering this:

May 2 2021, 4:27 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Isarra added a comment to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.

Dumb question, but is there any way to make this replacement work in 1.35 without doing a version compare first?

May 2 2021, 3:05 PM · BlueSpice, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes, MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst

Apr 30 2021

Isarra removed a project from T281542: ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated: Timeless.
Apr 30 2021, 3:38 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T281542: ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated.

I think I'm just going to start including a fork of the 1.34 shared.css with my skins instead.

Apr 30 2021, 3:38 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T281540: External links icons are missing on special pages and various secondary content when using ResourceLoaderSkinModule.

...anything run through some sort of getMessage( 'msg', [params] )->parse()? Lots of special pages begin with some sort of customisable blurb that does that. Other extensions do that various places as well, inside or outside of the content block. And parse() sends it through the parser, so it's basically just parser output without the css class.

Apr 30 2021, 12:43 AM · MediaWiki-Interface, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture

Apr 29 2021

Isarra added a project to T281540: External links icons are missing on special pages and various secondary content when using ResourceLoaderSkinModule: MediaWiki-Interface.
Apr 29 2021, 11:36 PM · MediaWiki-Interface, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

The problem is that there is nowhere obvious for the .visualClear CSS rule to live.

Apr 29 2021, 11:23 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T281540: External links icons are missing on special pages and various secondary content when using ResourceLoaderSkinModule.

But seriously I think maybe we should just start wrapping all parser output in mw-parser-output? This would also allow for other non-content blocks of normally parsed wikitext that extensions may add, such as to the sidebar or footer, to maintain consistent UX with regular content, and consistent UX is, uh, important. Good. Optimal? Maybe.

Apr 29 2021, 11:17 PM · MediaWiki-Interface, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
Isarra created T281540: External links icons are missing on special pages and various secondary content when using ResourceLoaderSkinModule.
Apr 29 2021, 11:16 PM · MediaWiki-Interface, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

This whole thing feels like a regression. I wouldn't even know where to start filing tasks, as the whole approach just seems wrong. I can try to spell it out, but please, please, get an actual designer on this. Learn how to cascade your features, like how css cascades styles. You're separating out particular content components into their own features when you should be separating out particular levels of styles. Every skin should float trights right, and tlefts left, because that's a basic assumption of them being what they are. Every skin has editsection links, and probably wants the sizes standardised regardless of header size. Every skin with a category block in the content block probably wants the category lists inline. Users expect things like .center and .visualClear and .noprint and .nomobile to work regardless of skin, because why in the world would basic content styles and affordances be specific to a particular skin? These are all first-level features, and shouldn't even be separate features at all, aside from the category one, because not only are they common to all skins, aside from the categories, none of them are even placed by the skin.

Apr 29 2021, 11:04 PM · MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

I don't think it matters how you render <div class="visualClear"></div>, whether manually, via BaseTemplate#getClear or some other way, but the class (definition) definitely needs to stay.

Apr 29 2021, 9:51 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture

Apr 27 2021

Isarra added a comment to T280766: Phase out legacy error, warning and success classes for usage outside the parser.

Er, should these even be used inside the parser? Like what are they even for that a successbox wouldn't cover? Why have this variation?

Apr 27 2021, 3:18 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

Some pages do not contain an mw-parser-output element, notably special pages, but work on the invalid assumption that the skin will always clear any floats inside them. This was the case with the RCFilters page. In these cases, I think it certainly justifies adding the responsibility on the special page itself, so @Krinkle I respectfully disagree with you on that. I wouldn't use a component from a component library that floated itself and relied on other components for its layout. Components should work in isolation. I believe we should fix each of these so that they are future-proofed.

Apr 27 2021, 2:43 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

To add on to what I just said, the task description is just wrong.

Apr 27 2021, 2:30 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

This would potentially break floating rules in skins not using mw-body-content but I think that's okay, with the expectation they're likely using something else (likely .visualClear).

Afaik there has never been a float clearing rule that shipped with core for this, so even skins not using mw-body-content would presumably be unaffected by this feature shipping.

Apr 27 2021, 2:15 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

(e.g. external link styles and other "wiki" styles that we sometimes apply to small chunks of user content rendered outside the proper content block, in other words content in all the various places you'll be removing this class from; places that should not themselves be the target of a selector and not have layout, but used for styling their children; Also thinking about rendering a small previews of something within an OOUI/WVUI dialog).

Apr 27 2021, 2:13 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture

Apr 25 2021

Isarra added a comment to T24660: Display the categories on the mobile site for everyone.

WTF is going on here? WMF not able to add one line of code to show the categories for last 10 years since this bug was filled? This really pisses me off...

Apr 25 2021, 5:11 PM · Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Mobile, Regression, Wikimedia-Israel-Hackers, MobileFrontend, Design

Apr 21 2021

Isarra created T280747: Reimplement all the skin module/feature things that have been randomly removed or are no longer usable in core.
Apr 21 2021, 3:36 AM · Timeless
Isarra added a comment to T280285: In in Timeless, Modern, CologneBlue Table of contents now has smaller font size and centered heading.

Okay, this might be the only one of these skin features issues that can actually be fixed in Timeless without just totally reimplementing everything... and it's like the least impactful anyway. And some of the others even made it into 1.36, whereas this doesn't appear to have.

Apr 21 2021, 2:49 AM · CologneBlue, Patch-For-Review, MediaWiki-Core-Skin-Architecture, Regression, Modern, Timeless
Isarra added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

But you should really just be starting with only the stuff that skins probably won't have any visual stylistic reason to override, and should always apply. For the page content, this is stuff like:

  • General positioning - trights float right, tlefts float left, centered stuff is centered
  • Unsetting the default header styles from editlinks so they're not all gigantified (specific skins may need to unset more, but at least the hard work should be done at this point)
  • Hiding stuff like the 'retrieved from' line from screen view
  • Things like .plainlinks, .noprint, .nomobile, .visualClear, and other classes users may expect to be able to apply to control output
  • No bullets on the toc items, why would anyone want that
  • Generic, consistent handling for mobile, if there's some way to actually tell it what the hell the skin's mobile cutoff is - stuff like thumbs going full-width, table overflow handling, collapsible sections, etc. A lot of what MF does, I suppose?
Apr 21 2021, 1:31 AM · MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

Help changing the defaults to more sensible ones is appreciated. The use of % font-sizes for example seems a little odd. Perhaps explicit font-sizes would be better. You can disable the feature if the CSS rules are not helping (that's what Minerva does)

Apr 21 2021, 1:06 AM · MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

The thumbnail issue looks backwards compatible to me in that the content is perfectly readable.

Apr 21 2021, 12:31 AM · MediaWiki-Core-Skin-Architecture

Apr 20 2021

Isarra updated the task description for T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.
Apr 20 2021, 11:44 PM · MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

This isn't for user content. This is for clearing floats within the skin itself?

This was wrong. It's for everything. I just... slightly broke my brain when I first saw this (and a related task that mentioned user use specifically).

Apr 20 2021, 8:16 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

Extensions also use the visualClear class. Yes, they could also define their own versions, but... why?

Apr 20 2021, 8:10 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

But why remove it from core? If skins aren't using it, then this doesn't affect them. If skins are using it, they're often using a combination of getClears and applying the class to specific elements where a full separate clear isn't needed.

Apr 20 2021, 8:04 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.

Given a few of the issues we've been having I suggest we move all deployed Wikimedia skins away from legacy during 1.37 and deprecate it in that release rather than rush it now.

Apr 20 2021, 7:52 PM · Readers-Web-Backlog, MW-1.37-release, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Performance-Team (Radar), MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-Interface
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

Skins should instead copy across the method to their own skin or use the LESS mixin instead

Apr 20 2021, 7:23 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

Or... what? I don't understand. You still need to make an element as a spacer for a lot of this... yes, flexbox is a thing, but we're not gonna all of a sudden convert every skin to it now, why would we do that?

Apr 20 2021, 7:20 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280609: Determine future of BaseTemplate::getClear.

This isn't for user content. This is for clearing floats within the skin itself?

Apr 20 2021, 7:19 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Isarra edited projects for T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had, added: MediaWiki-Core-Skin-Architecture; removed Performance-Team, MediaWiki-ResourceLoader.

Possibly slightly better tag? Not actually an issue with RL in general.

Apr 20 2021, 7:18 PM · MediaWiki-Core-Skin-Architecture
Isarra created T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.
Apr 20 2021, 7:15 PM · MediaWiki-Core-Skin-Architecture
Isarra added a comment to T280285: In in Timeless, Modern, CologneBlue Table of contents now has smaller font size and centered heading.

The problem here appears to be that various things have been added to the 'legacy' feature that were previously part of 'interface' or 'elements', or some other feature that was not previously used. This is a breaking change for all skins that were previously only using legacy and not these other features.

Apr 20 2021, 6:52 PM · CologneBlue, Patch-For-Review, MediaWiki-Core-Skin-Architecture, Regression, Modern, Timeless

Apr 17 2021

Isarra added a comment to T280285: In in Timeless, Modern, CologneBlue Table of contents now has smaller font size and centered heading.

Timeless was not using core styles at all for a lot of this stuff... hopefully it's just specific features we need to (explicitly?) disable here, because if not, overriding this could get very annoying. But if it is, then maybe we can also disable some other things that we were overriding previously? Make things a bit neater overall?

Apr 17 2021, 5:30 AM · CologneBlue, Patch-For-Review, MediaWiki-Core-Skin-Architecture, Regression, Modern, Timeless

Apr 16 2021

Isarra added a comment to T271441: ResourceLoaderSkinModule features are not backwards compatible.

Jon mentioned this on https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/678785/:

According to Timo master versions should only be compatible with the /next/ release and only tarballs should be considered stable. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/673320 and https://phabricator.wikimedia.org/T271441#6764043 which proposes making skins fatal when they use ResourceLoaderSkinModule with non-existent features. I don't think that's great from a skin perspective as I worry that will discourage skin developers from adopting new features that make their lives easier, but feedback from yourself and Jack on your own experiences with skin development there would be helpful.

Apr 16 2021, 8:37 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), MW-1.36-release, Patch-For-Review, MW-1.37-release, Performance-Team (Radar), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), MediaWiki-ResourceLoader, MediaWiki-Core-Skin-Architecture

Apr 15 2021

Isarra added a comment to T279951: height=xxx is not respected in timeless.

Yeah, no, timeless is breaking it, you're spot on.

Apr 15 2021, 11:10 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Timeless
Isarra added a comment to T279951: height=xxx is not respected in timeless.

Ooooooh this is the image overflow stuff crap.

Apr 15 2021, 11:09 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Timeless

Apr 13 2021

Isarra added a comment to T279951: height=xxx is not respected in timeless.

Timeless assumes topicon sizes are set appropriately. Maybe this is a stupid assumption, but are you sure you can't just... do that? Set a specific default size in the script?

Apr 13 2021, 2:55 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Timeless

Apr 12 2021

Isarra added a comment to T279645: Use SVG for Wikipedia logo rather than PNG (wgLogos['icon']). to avoid blurry logo in some displays.

I'll defer to Isarra and co. on the correct way to solve this...it's unclear to me why $wgLogos['icon'] is a single png and not an array with 1x/1.5x/2x/svg options like the main logo does.

Apr 12 2021, 11:50 PM · Desktop Improvements, Logos, Timeless

Apr 10 2021

Isarra added a comment to T279645: Use SVG for Wikipedia logo rather than PNG (wgLogos['icon']). to avoid blurry logo in some displays.

Like why would any project still be using rasters in this day and age?!

Apr 10 2021, 12:00 AM · Desktop Improvements, Logos, Timeless

Apr 9 2021

Isarra added a comment to T279645: Use SVG for Wikipedia logo rather than PNG (wgLogos['icon']). to avoid blurry logo in some displays.

It's because of T273250: $wgLogos['icon'] notext logo set for newvector is too small to use in Timeless, except we went ahead and used it anyway out of pure spite. Or, more likely, laziness/lack of resources?

Apr 9 2021, 11:59 PM · Desktop Improvements, Logos, Timeless

Mar 30 2021

Isarra updated the task description for T273250: $wgLogos['icon'] notext logo set for newvector is too small to use in Timeless.
Mar 30 2021, 5:31 PM · Timeless
Isarra edited projects for T232012: Skins should use wordmark and icon keys instead of 1x, 2x and svg wgLogos keys, added: Metrolook, Nostalgia; removed Timeless.

Technically Timeless has already switched over, just has the old logos as a fallback. Also needs to deprecate its own custom handling, but that's a separate problem entirely...

Mar 30 2021, 5:28 PM · Nostalgia, Metrolook, Wikimedia-Site-requests, MonoBook, Vector, MediaWiki-Core-Skin-Architecture, CSS, Logos, MediaWiki-Interface
Isarra added a comment to T232012: Skins should use wordmark and icon keys instead of 1x, 2x and svg wgLogos keys.

T273250 is also going to pose a problem here for any sites using png notext icons. (Mostly wikipedia, I think?)

Mar 30 2021, 5:23 PM · Nostalgia, Metrolook, Wikimedia-Site-requests, MonoBook, Vector, MediaWiki-Core-Skin-Architecture, CSS, Logos, MediaWiki-Interface
Isarra added a comment to T232012: Skins should use wordmark and icon keys instead of 1x, 2x and svg wgLogos keys.

I've held off on a proof of concept patch for MonoBook for the time being since the WMF config was just nowhere near there yet in terms of having the logos/wordmarks consistently available for all the sites, but once that's a little closer, we should absolutely get on migrating this. (WikiVoyage is a great example why we can't just do it now, though, as some may actually want only a notext logo and thus will only set that, and some do want a wordmark but just don't have one, presently...)

Mar 30 2021, 5:21 PM · Nostalgia, Metrolook, Wikimedia-Site-requests, MonoBook, Vector, MediaWiki-Core-Skin-Architecture, CSS, Logos, MediaWiki-Interface

Mar 21 2021

Isarra added a comment to T132054: mobile/desktop view js inheritance issues.

This is funny because I don't even know what this means.

Mar 21 2021, 5:10 PM · GreyStuff
Isarra closed T115189: Use separate class for mobile views and desktop to avoid weird js overlap as Resolved.

Resolved with some bad css at some point...

Mar 21 2021, 5:09 PM · GreyStuff
Isarra created T278054: Dropdown toggles should be accessible to keyboard navigation and the like.
Mar 21 2021, 4:59 PM · GreyStuff
Isarra created T278053: Links should have visual indicator on hover.
Mar 21 2021, 4:57 PM · GreyStuff
Isarra moved T269892: Hide dropdown menus without removing them from display for screenreader etc support from Bugs to Needs implementing on the GreyStuff board.
Mar 21 2021, 4:56 PM · GreyStuff
Isarra closed T269891: Mobile menus need nojs fallback as Resolved.
Mar 21 2021, 4:55 PM · GreyStuff
Isarra closed T277111: Use icon logo for logo image when enabled as Resolved.
Mar 21 2021, 4:55 PM · GreyStuff
Isarra closed T277112: Use tagline image for banner sitesubtitle if available as Resolved.
Mar 21 2021, 4:55 PM · GreyStuff
Isarra closed T277799: Footer navigation gets messy when there's a lot there/at smaller resolutions as Resolved.
Mar 21 2021, 4:55 PM · GreyStuff
Isarra added a comment to T269626: mediawiki.skinning.content.externallinks is deprecated.

Sorry about that, it turns out some of us are just drunk and sleep deprived and that doesn't result in the most meaningful testing...

Mar 21 2021, 4:23 AM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, WPtouch, Refreshed, Nimbus, Mask, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet
Isarra removed a project from T269626: mediawiki.skinning.content.externallinks is deprecated: Anisa.
Mar 21 2021, 4:22 AM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, WPtouch, Refreshed, Nimbus, Mask, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet

Mar 20 2021

Isarra added a comment to T269626: mediawiki.skinning.content.externallinks is deprecated.

Duuur I'm an idiot, I just need to copy the 1.35 fix out of timeless, huh.

Mar 20 2021, 11:14 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, WPtouch, Refreshed, Nimbus, Mask, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet
Isarra added a comment to T269891: Mobile menus need nojs fallback.

FYI In Vector and Minerva we use a checkbox hack for the menus. We've been meaning to consolidate the associated CSS code as a core module.

Mar 20 2021, 2:09 AM · GreyStuff

Mar 18 2021

Isarra added a comment to T274199: With new Vector skin and Timeless, Meta, Wikimania and Wikitech logos are replaced by the WM Foundation logo.

Thanks for putting up that patch but am I correct in understanding if there's no default icon set then there just won't be any logo shown? What is the correct procedure for putting back the already existing logos? That's really what I don't get.

Mar 18 2021, 11:25 PM · Patch-For-Review, Timeless, Wikimedia-Site-requests, Regression
Isarra added a comment to T274199: With new Vector skin and Timeless, Meta, Wikimania and Wikitech logos are replaced by the WM Foundation logo.

It sounds like you're saying the fix is to not use the new $wgLogos system in Timeless because it's not ready yet - is that correct?

No that's not what I'm saying. I'm saying that every logo needs to be manually created, derived from the old logo and certain projects don't have that yet. I'm saying Timeless can workaround this issue by accumulating technical debt if it wishes.

I think @Isarra's take above is right. Let's do this right for every skin rather than applying more duct tape :).

Mar 18 2021, 10:56 PM · Patch-For-Review, Timeless, Wikimedia-Site-requests, Regression
Isarra added a comment to T274199: With new Vector skin and Timeless, Meta, Wikimania and Wikitech logos are replaced by the WM Foundation logo.
Mar 18 2021, 10:40 PM · Patch-For-Review, Timeless, Wikimedia-Site-requests, Regression
Isarra created T277799: Footer navigation gets messy when there's a lot there/at smaller resolutions.
Mar 18 2021, 8:22 PM · GreyStuff
Isarra added a comment to T276872: Better contrast for link colours.

...I still don't like the colours. HMM.

Mar 18 2021, 6:54 PM · Splash
Isarra closed T269800: Scrollbars for overflowing tables as Resolved.
Mar 18 2021, 6:54 PM · Splash

Mar 17 2021

Isarra added a project to T269626: mediawiki.skinning.content.externallinks is deprecated: Anisa.

Not removing this from Anisa yet after all, as the replacement apparently isn't available in 1.35, and Anisa is still targeting 1.35 and not 1.36... is this still only deprecated as of an unreleased version, or something?

Mar 17 2021, 11:28 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, WPtouch, Refreshed, Nimbus, Mask, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet
Isarra committed rSANIb923330dc172: Use updated/core wodgits and bump required mw version to 1.35 (authored by Isarra).
Use updated/core wodgits and bump required mw version to 1.35
Mar 17 2021, 9:42 PM