Page MenuHomePhabricator

JFolvarcik
User

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Saturday

  • No visible events.

User Details

User Since
Oct 2 2020, 6:12 PM (275 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
JFolvarcik [ Global Accounts ]

Recent Activity

Wed, Jan 7

JFolvarcik added a comment to T413653: Default text of Skin-theme-description is confusing.

I'm with Snorlax on this. Remove it by default but leave a place for a system message.

Wed, Jan 7, 5:51 PM · Reader Experience Team, Vector 2022, dark-mode

Tue, Dec 30

JFolvarcik added a comment to T387583: ReplaceText should validate regexes before sending them to the database.

I would like to add that regexes can fail silently if a user doesn't escape slashes (/). The engine will attempt to treat the following text as a delimiter, which could have wildly unpredictable results. I had to find this out by searching our job queue logs and finding the error there. This is definitely not good, because the software tells the user that there was no issue.

Tue, Dec 30, 2:11 PM · Patch-For-Review, affects-Miraheze, MediaWiki-extensions-ReplaceText

Feb 28 2025

JFolvarcik created T387583: ReplaceText should validate regexes before sending them to the database.
Feb 28 2025, 5:42 PM · Patch-For-Review, affects-Miraheze, MediaWiki-extensions-ReplaceText

Jun 30 2024

JFolvarcik added a comment to T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.

That's a good point; hadn't thought of doing it the other way around. I guess this can be closed appropriately now. Appreciate the advice, thanks!

Jun 30 2024, 1:05 PM · MediaWiki-Core-Preferences
JFolvarcik added a comment to T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.

I guess that makes sense. It just isn't stated anywhere (that I could find) in the manuals that $wgDefaultSkin will override the option.
As for the hook, I would really prefer a way to just set the preference for new users, as we have multiple skins available that are still in use, and if I understand that hook, it will force any logged in user to use the skin listed. Is there really no way to set the user preference when using a default skin?

Jun 30 2024, 12:17 PM · MediaWiki-Core-Preferences
JFolvarcik updated the task description for T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.
Jun 30 2024, 11:43 AM · MediaWiki-Core-Preferences
JFolvarcik added a comment to T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.

Additionally, $wgConditionalUserOptions is only available in 1.42+, and we are on the current LTS (1.39.7 (and yes, I know .8 just released; I'm testing for that update currently)). According to the $wgDefaultUserOptions manual, "skin" should be an accepted parameter, but it isn't being respected for some reason.

Jun 30 2024, 11:41 AM · MediaWiki-Core-Preferences
JFolvarcik added a comment to T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.

Okay, if it isn't supposed to create an entry in the table, that's fine, but it should still actually set the user's default skin. It does not. That fact remains.

Jun 30 2024, 11:35 AM · MediaWiki-Core-Preferences
JFolvarcik updated the task description for T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.
Jun 30 2024, 10:49 AM · MediaWiki-Core-Preferences
JFolvarcik created T368853: $wgDefaultUserOptions['skin'] is not respected on account creation.
Jun 30 2024, 10:46 AM · MediaWiki-Core-Preferences

Feb 14 2024

JFolvarcik updated the task description for T357491: Requesting public documentation for those looking to replace the Mobile Content Service for apps.
Feb 14 2024, 5:48 PM · Essential-Work, Content-Transform-Team-WIP, Page Content Service
JFolvarcik added a project to T357491: Requesting public documentation for those looking to replace the Mobile Content Service for apps: Content-Transform-Team.
Feb 14 2024, 1:15 AM · Essential-Work, Content-Transform-Team-WIP, Page Content Service
JFolvarcik created T357491: Requesting public documentation for those looking to replace the Mobile Content Service for apps.
Feb 14 2024, 1:08 AM · Essential-Work, Content-Transform-Team-WIP, Page Content Service

Sep 8 2022

JFolvarcik added a comment to T317241: wikistats: mediawiki version shown incorrectly in "largest wikis" listing.

Since this hasn't been updated yet, I want to go ahead and add this bit of discussion, as it is relevant to the problem.

Sep 8 2022, 6:23 AM · VPS-project-Wikistats

Feb 14 2022

JFolvarcik added a comment to T298261: MediaWiki core creates error due to changes in method signature for setProvides in Composer 2.2.
Feb 14 2022, 11:39 PM · MW-1.35-notes, MW-1.36-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), MediaWiki-General, Composer

Nov 27 2020

JFolvarcik created T268858: Class structure diagrams are made overly difficult to read by Hooks.
Nov 27 2020, 12:39 AM · Doxygen, MediaWiki-Documentation, Documentation

Oct 4 2020

JFolvarcik added a comment to T264513: updateVarDumps emits PHP notice due to bad serialized data.

Daimona's patch worked, and I was able to continue my upgrade for both of my wiki sites. I ran into this error originally while upgrading from 1.29 to 1.35, and I saw it with both sites. I would like to know if this could potentially introduce database corruption down the line, however.

Oct 4 2020, 12:03 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter

Oct 3 2020

JFolvarcik added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Just like to note that I encountered this error while upgrading from 1.29.1 to 1.35.0, and I was able to work around it by running the maintenance script populateContentTables.php, which failed with a duplicate entry for key "PRIMARY" error but still allowed the update.php script to continue. It seems like the updater tried to work on the "slots" table before it was even populated, hence the slot not found error.

Oct 3 2020, 8:39 PM · Unstewarded-production-error, affects-translatewiki.net, User-brennen, Core Platform Team Initiatives (MCR), MediaWiki-Core-Revision-backend, Multi-Content-Revisions (Reactive), Wikimedia-production-error