JGirault (Julien)
Engineering

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 5 2015, 6:42 PM (114 w, 6 d)
Availability
Available
LDAP User
JGirault
MediaWiki User
Unknown

Recent Activity

Apr 27 2017

JGirault added a comment to T151524: Maps fast preview is broken on 2nd attempt.

The proposed solution using requestAnimationFrame (or L.Util.requestAnimFrame) works, but I am being careful to not break something. It's gonna require me more testing.

Apr 27 2017, 10:23 PM · Maps (Kartographer), Discovery

Apr 26 2017

JGirault added a comment to T152573: Update Kartographer mapPin icon to exact OOjs UI mapPin icon.

For the record, if Kartographer loads the icons from OOui, it will look like that:

Apr 26 2017, 9:33 PM · Design, WMF-Design, Discovery, Maps (Kartographer), UI-Standardization
JGirault moved T152573: Update Kartographer mapPin icon to exact OOjs UI mapPin icon from Needs review to Stalled/Waiting on the Maps-Sprint board.
Apr 26 2017, 9:22 PM · Design, WMF-Design, Discovery, Maps (Kartographer), UI-Standardization
JGirault added a comment to T152573: Update Kartographer mapPin icon to exact OOjs UI mapPin icon.

Waiting for a decision on where should the icons' assets live: in OOui, in core, or bundled with the extension...

Apr 26 2017, 9:22 PM · Design, WMF-Design, Discovery, Maps (Kartographer), UI-Standardization
JGirault added a comment to T162973: Add support for behavior: url(#default#behaviorName).

Excellent
Thanks @Krinkle for the details.

Apr 26 2017, 6:02 PM · Performance-Team, MW-1.30-release-notes, MediaWiki-ResourceLoader

Apr 21 2017

JGirault updated subscribers of T163519: Layout for Special:BlockList and Special:AutoblockList is messy.

A few notes/comments/suggestions:

Apr 21 2017, 10:51 PM · MediaWiki-Special-pages, Design

Apr 18 2017

JGirault added a comment to T151666: Frame has extra vertical space when mapframe is wider than screenwidth.

I'm not sure this is still a valid bug. I tried in preview mode, tried locally, and couldn't reproduce. @Yurik, can you still reproduce?

Apr 18 2017, 12:47 AM · Maps-Sprint, Discovery, Maps (Kartographer)
JGirault claimed T151524: Maps fast preview is broken on 2nd attempt.
Apr 18 2017, 12:41 AM · Maps (Kartographer), Discovery
JGirault moved T151524: Maps fast preview is broken on 2nd attempt from Backlog to Needs review on the Maps-Sprint board.
Apr 18 2017, 12:41 AM · Maps (Kartographer), Discovery

Apr 17 2017

JGirault moved T152573: Update Kartographer mapPin icon to exact OOjs UI mapPin icon from Backlog to Needs review on the Maps-Sprint board.
Apr 17 2017, 11:07 PM · Design, WMF-Design, Discovery, Maps (Kartographer), UI-Standardization
JGirault added a project to T152573: Update Kartographer mapPin icon to exact OOjs UI mapPin icon: Maps-Sprint.
Apr 17 2017, 11:06 PM · Design, WMF-Design, Discovery, Maps (Kartographer), UI-Standardization
JGirault closed T154037: Map scale can be made more prominent as Resolved.

T157720 improved the style of attributions

Apr 17 2017, 10:59 PM · Maps-Sprint, Maps (Kartographer), Discovery
JGirault moved T147347: Migrate Kartographer to Leaflet 1.x from Needs review to Stalled/Waiting on the Maps-Sprint board.
Apr 17 2017, 10:56 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault closed T152069: WV: broken group name in layers for ExternalData as Resolved.

Works now, but I created T163146 to review a couple of things.

Apr 17 2017, 8:17 PM · MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, Discovery, Maps-Sprint, Maps (Kartographer)
JGirault created T163146: WV: incorrect style for ExternalData layers in the layers dropdown.
Apr 17 2017, 8:16 PM · Easy, Maps (Kartographer), Discovery
JGirault closed T152998: Improve tabular data styling as Resolved.

This is how it looks now, I'm gonna mark the ticket as resolved. I think it's gotten much better, it's consistent with the new color palette, and there hasn't been any activity for a while.

Apr 17 2017, 8:07 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, Accessibility, Design, Maps (Kartographer), Maps-Sprint, Discovery
JGirault closed T154582: Data from Commons datasets should appear in map attributions as Resolved.

This works, see example: https://www.mediawiki.org/wiki/Help:Extension:Kartographer#/map/7

Apr 17 2017, 7:56 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, Maps (Kartographer), Maps-Sprint, Discovery
JGirault closed T151929: Implement third phase of map event logging as Resolved.

This phase seems to be done

Apr 17 2017, 7:54 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, Maps-Sprint, Discovery-Analysis, Discovery, Maps
JGirault closed T151929: Implement third phase of map event logging, a subtask of T163139: Review map eventlogging, as Resolved.
Apr 17 2017, 7:54 PM · Discovery-Analysis, Discovery, Maps-Sprint, Maps (Kartographer)
JGirault added a parent task for T151929: Implement third phase of map event logging: T163139: Review map eventlogging.
Apr 17 2017, 7:54 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, Maps-Sprint, Discovery-Analysis, Discovery, Maps
JGirault added a subtask for T163139: Review map eventlogging: T151929: Implement third phase of map event logging.
Apr 17 2017, 7:54 PM · Discovery-Analysis, Discovery, Maps-Sprint, Maps (Kartographer)
JGirault created T163139: Review map eventlogging.
Apr 17 2017, 7:53 PM · Discovery-Analysis, Discovery, Maps-Sprint, Maps (Kartographer)
JGirault closed T152513: Log whether the event is the first interaction of the user with the map as Resolved.
Apr 17 2017, 7:41 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), Patch-For-Review, Discovery-Analysis, Maps-Sprint, Maps (Kartographer), Discovery
JGirault closed T154918: Red links appear in blue as Resolved.

Testable at https://www.mediawiki.org/wiki/User:JGirault_(WMF)/QA/T154918

Apr 17 2017, 7:39 PM · Verified, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, Maps-Sprint, Discovery, Maps (Kartographer)
JGirault closed T154716: OO.ui.WindowManager#addWindows: Windows must have a `name` static property as Resolved.
Apr 17 2017, 7:37 PM · MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T157373: Few technical improvements to Kartographer styles as Resolved.
Apr 17 2017, 7:37 PM · MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault updated the task description for T157373: Few technical improvements to Kartographer styles.
Apr 17 2017, 7:36 PM · MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T157748: <mapframe> should open special map page for non js users as Resolved.
Apr 17 2017, 7:35 PM · MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T155352: Automatically open the panel "More details" at high resolutions as Resolved.
Apr 17 2017, 7:34 PM · MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T155350: There is no way to close the map, when the "More details" panel is open as Resolved.
Apr 17 2017, 7:34 PM · MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T157720: Attributions not visible enough on static snapshots as Resolved.
Apr 17 2017, 7:33 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault closed T158438: Add vertical offset to map center when screen is < 1024px as Resolved.
Apr 17 2017, 7:32 PM · MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), Patch-For-Review, Maps-Sprint, Maps (Kartographer)
JGirault updated the task description for T163094: Frameless buttons should have same click target minimum size as framed buttons.
Apr 17 2017, 7:23 PM · OOjs-UI (OOjs-UI-0.22.0), Design, UI-Standardization-Kanban, UI-Standardization

Apr 14 2017

JGirault added a comment to T147347: Migrate Kartographer to Leaflet 1.x.

Tested after rebase, and it seems to me that all features work . We only need to make CI tests pass.

Apr 14 2017, 12:15 AM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault created T162973: Add support for behavior: url(#default#behaviorName).
Apr 14 2017, 12:14 AM · Performance-Team, MW-1.30-release-notes, MediaWiki-ResourceLoader

Apr 13 2017

JGirault added a comment to T162487: Improve content hierarchy in page title.

@Nirzar Looks good

Apr 13 2017, 6:44 PM · WikimediaUI Style Guide
JGirault added a comment to T153417: Align the style for lists of pages.

Another aspect worth discussing is how to style the "matching part of the title".
I think it is better to use bold (or color contrast) instead of underline, for the following reasons:

  • Simplicity. Avoids adding additional visual elements.
  • It's a common practice in similar contexts such auto-completion lists in search engines.
  • Underline may be associated with links so it may generate some confusion about why part of the result is a link (and another part is not). Although this is a minor concern since, I don't think it would prevent the list from being usable in any case.

    Here are some experiments:
  • Bolding the matching part (or try the approach live at quora)
  • Bolding the unmatched part (or try the approach live at google or bing)
Apr 13 2017, 6:38 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
JGirault added a comment to T162554: Maps don’t show up because of the problem with layers: "HTTP 400 Bad Request".

Maybe you could at least ignore the layer in JavaScript if there’s errors for loading it? Right now it bugs out the whole map, and that’s not the best behaviour even if there’s more underlying problems.

Apr 13 2017, 6:27 PM · Discovery, Maps, Russian-Sites
JGirault moved T157996: Disable VE editing of maplink / mapframe when the editor is not able to from In progress to Needs review on the Maps-Sprint board.
Apr 13 2017, 1:56 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)

Apr 11 2017

JGirault added a comment to T162420: Tile hover in Tilerator UI is broken.

https://github.com/kartotherian/tilerator/pull/10

Apr 11 2017, 11:06 PM · Maps-Sprint, Maps (Tilerator)
JGirault added a comment to T162329: Audiences well addressed?.

@JGirault I agree with your statement about the missing direct shortcut to “Resources” on the homepage. That sounds like a good addition.
Here's a screenshot from your pull request


I don't think this is the right direction as it's a lot of redundant information. I'd rather add a sentence above or below saying if you refer to the colors in code, please use the following naming convention exemplified on white: For CSS --wmui-color-base100, for Less @wmui-color-base100.

Apr 11 2017, 10:16 PM · WMF-Design, WikimediaUI Style Guide, Design
JGirault added a comment to T162420: Tile hover in Tilerator UI is broken.

^ This hack is the way to go.
The issue for disabling the pointer events on tile layers in leaflet.js was https://github.com/Leaflet/Leaflet/issues/2396.

Apr 11 2017, 9:47 PM · Maps-Sprint, Maps (Tilerator)
JGirault updated the task description for T162717: Improve print style on portal.
Apr 11 2017, 5:18 PM · CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
JGirault created T162717: Improve print style on portal.
Apr 11 2017, 5:18 PM · CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Apr 10 2017

JGirault added a comment to T153417: Align the style for lists of pages.

I have added some thoughts to the topic:

Apr 10 2017, 11:59 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Apr 7 2017

JGirault updated subscribers of T162329: Audiences well addressed?.

I see the style guide as the language shared between designers and developers.

Apr 7 2017, 12:39 AM · WMF-Design, WikimediaUI Style Guide, Design

Apr 4 2017

JGirault added a comment to T161985: border-color of standard table.

@Iniquity what colors did you find, and where? This change should have been done already.

Apr 4 2017, 12:56 AM · CSS, Design, UI-Standardization

Apr 3 2017

JGirault added a comment to T157752: Kartographer should display a single node.

I think there are plenty of usecases for Wikipedia when the coordinates will never be allowed in OSM (think mostly historical data but also events in general) but will fit perfectly in a Wikidata object. It would be great to be able to get these with a query and display it in an article (e.g. all the battles in a war or similar).

Apr 3 2017, 11:07 PM · Maps (Kartographer)

Mar 31 2017

JGirault added a comment to T152736: PNGs are sent as 32-bit RGBA.

Done in upstream -- Added special handling for this in @kartotherian/server. Basic test on California coast showed a drop from 1.8MB to 855KB.

Mar 31 2017, 5:44 PM · Maps (Kartotherian), Discovery
JGirault added a comment to T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.

Indentation adds friction to the main scan line when going through the menu. I agree in avoid using them if we can communicate the groups without it.

I am not convinced by this, nor can I find a suitable precedent (examples here would help me). The scan line with indentation makes it easier to spot the grouping. Use of indentation/margins is key in showing hierarchy. Not sure why wouldn't apply such a useful tool for achieving our goal.

Mar 31 2017, 4:58 PM · OOjs-UI (OOjs-UI-0.24.1), Design

Mar 30 2017

JGirault added a comment to T153417: Align the style for lists of pages.
  • In all your examples, applying line-height: 1.6; and making a few adjustments to center the text vertically would make the proposals look even nicer .
Mar 30 2017, 7:03 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
JGirault added a comment to T157996: Disable VE editing of maplink / mapframe when the editor is not able to.

Ok now only the double click on the maplink still opens the dialog. I think I have to extend ve.ui.Command and run mwMaps through this.model.isEditable...

Mar 30 2017, 1:52 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)

Mar 29 2017

JGirault added a comment to T157996: Disable VE editing of maplink / mapframe when the editor is not able to.

With this patch:

Mar 29 2017, 1:06 AM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)

Mar 28 2017

JGirault accepted D612: Tag v0.9.0.

Mar 28 2017, 8:11 PM
JGirault claimed T157996: Disable VE editing of maplink / mapframe when the editor is not able to.
Mar 28 2017, 6:58 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)
JGirault moved T157996: Disable VE editing of maplink / mapframe when the editor is not able to from Backlog to In progress on the Maps-Sprint board.
Mar 28 2017, 6:58 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)
JGirault added a comment to T153417: Align the style for lists of pages.

Another question from a style guide perspective, should the thumbnails feature rounded borders?

Mar 28 2017, 6:38 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Mar 27 2017

JGirault added a comment to T160704: Design better typographic scale for the portal.

Just to reiterate my thoughts on the 1rem=10px idea.

The benefit of this would be to easily translate rems into pixels, but then how is this different than setting 1rem=1px and then using values like font-size=16rem? To me the only difference is the decimal.

Mar 27 2017, 9:56 PM · Discovery-Portal-Backlog, Design, Discovery, Wikimedia-Portals
JGirault added a comment to T157996: Disable VE editing of maplink / mapframe when the editor is not able to.

You'll want to extend the ve.ui.LinearContextItem like in ve.ui.MWReferenceContextItem in the Cite extension. You can disable the edit button by adding an isEditable method to ve.dm.MWMapsNode.

Mar 27 2017, 9:29 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, VisualEditor, Maps-Sprint, Maps (Kartographer)

Mar 22 2017

JGirault updated the task description for T161065: Remove map offset when quitting full screen mode (when screen > 1024px).
Mar 22 2017, 12:34 AM · Maps (Kartographer)
JGirault created T161065: Remove map offset when quitting full screen mode (when screen > 1024px).
Mar 22 2017, 12:34 AM · Maps (Kartographer)
JGirault added a comment to T143877: Kartographer maps are not shown in Wikipedia App.

For 2, yes, it may actually be quite complicated. I think a major blocker for us was that (and forgive if I'm wrong) the map tags and geojson overlays allowed/required the use of absolute pixel offsets. This was a non-starter for scalable mobile support.

Mar 22 2017, 12:26 AM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Android-app-Bugs, iOS-app-Bugs, Discovery, Mobile, Maps (Kartographer)
JGirault moved T161061: Language picker displays label twice in very old Opera 11.5 and below from Backlog to Needs code review on the Discovery-Portal-Sprint board.
Mar 22 2017, 12:05 AM · Browser-Support-Opera, Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
JGirault added a comment to T161062: Language picker dropdown is not readable in very old Opera 10.6.

It seems one way to actually fix it would be:

_:-o-prefocus, .styled-select.js-enabled select {
	background-color: var( --ss-c-grey-hover );
	color: var( --ss-c-grey );
}
_:-o-prefocus, .styled-select.js-enabled select:hover {
	background-color: var( --ss-c-grey-hover );
}
Mar 22 2017, 12:00 AM · Browser-Support-Opera, Discovery, Discovery-Portal-Sprint, Wikimedia-Portals

Mar 21 2017

JGirault created T161062: Language picker dropdown is not readable in very old Opera 10.6.
Mar 21 2017, 11:47 PM · Browser-Support-Opera, Discovery, Discovery-Portal-Sprint, Wikimedia-Portals
JGirault created T161061: Language picker displays label twice in very old Opera 11.5 and below.
Mar 21 2017, 11:41 PM · Browser-Support-Opera, Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
JGirault added a comment to T143877: Kartographer maps are not shown in Wikipedia App.
  • What's the iOS/Android teams plan regarding Kartographer maps?
  • What's needed from the Kartographer developers to enable you?
Mar 21 2017, 10:43 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Android-app-Bugs, iOS-app-Bugs, Discovery, Mobile, Maps (Kartographer)
JGirault updated subscribers of T143877: Kartographer maps are not shown in Wikipedia App.

Moving the discussion from the other ticket to this one:

Mar 21 2017, 10:31 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Android-app-Bugs, iOS-app-Bugs, Discovery, Mobile, Maps (Kartographer)
JGirault added a comment to T160719: don't use space as a thousands separator around the globe on the wikipedia.org portal .

I chose another fix, which is to wrap the number and the symbol + in a DOM element, and force that element to be displayed LTR.

Mar 21 2017, 9:42 PM · Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
JGirault added a comment to T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules.

New patch version features:

  • Display top 10 item LTR or RTL depending on the language
  • Force display of numbers in top 10 in LTR
  • Force display of numbers in language dropdown in LTR
Mar 21 2017, 9:38 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery

Mar 17 2017

JGirault added a comment to T147347: Migrate Kartographer to Leaflet 1.x.

Fix the core or patch Mapbox?

Mar 17 2017, 11:13 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault added a comment to T160782: Incorrect marker coordinates for outer resources.

@IGW We could do something that smart, but it would require to parse the GeoJSON for markers, which isn't necessarily the simplest thing to do.

Mar 17 2017, 11:11 PM · User-notice, MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Maps-Sprint, Patch-For-Review, Maps, Discovery, Russian-Sites
JGirault added a comment to T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules.

Ah, I didn't even notice, thanks a lot @Neil_P._Quinn_WMF ! This will require me a little more work then.

Mar 17 2017, 11:04 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
JGirault updated subscribers of T147347: Migrate Kartographer to Leaflet 1.x.

@MaxSem any idea how to fix the failing phpunit tests?

Mar 17 2017, 10:48 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault claimed T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects.
Mar 17 2017, 10:41 PM · Maps (Kartographer), Discovery
JGirault moved T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects from Needs review to Stalled/Waiting on the Maps-Sprint board.
Mar 17 2017, 10:41 PM · Maps (Kartographer), Discovery
JGirault moved T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects from Backlog to Needs review on the Maps-Sprint board.
Mar 17 2017, 10:41 PM · Maps (Kartographer), Discovery
JGirault moved T147347: Migrate Kartographer to Leaflet 1.x from Backlog to Needs review on the Maps-Sprint board.
Mar 17 2017, 10:40 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault added a project to T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects: Maps-Sprint.
Mar 17 2017, 10:40 PM · Maps (Kartographer), Discovery
JGirault added a comment to T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects.

I have issued an upstream patch to the mapbox.js repository, that would fix the issue:
https://github.com/mapbox/mapbox.js/pull/1217

Mar 17 2017, 10:40 PM · Maps (Kartographer), Discovery
JGirault added a parent task for T147347: Migrate Kartographer to Leaflet 1.x: T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects.
Mar 17 2017, 10:39 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault added a subtask for T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects: T147347: Migrate Kartographer to Leaflet 1.x.
Mar 17 2017, 10:39 PM · Maps (Kartographer), Discovery
JGirault removed a subtask for T147347: Migrate Kartographer to Leaflet 1.x: T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects.
Mar 17 2017, 10:39 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault removed a parent task for T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects: T147347: Migrate Kartographer to Leaflet 1.x.
Mar 17 2017, 10:39 PM · Maps (Kartographer), Discovery
JGirault added a parent task for T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects: T147347: Migrate Kartographer to Leaflet 1.x.
Mar 17 2017, 10:38 PM · Maps (Kartographer), Discovery
JGirault added a subtask for T147347: Migrate Kartographer to Leaflet 1.x: T140209: SimpleStyle should not show "hand" mouse icon on unclickable objects.
Mar 17 2017, 10:38 PM · Wikimania-Hackathon-2017, Maps-Sprint, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Maps (Kartographer), Discovery
JGirault added a comment to T160767: Inconsistent coordinates with different page widths.

I answered it in the other ticket T160782: Incorrect marker coordinates for outer resources

Mar 17 2017, 8:43 PM · Russian-Sites, Maps (Kartographer)
JGirault added a comment to T160782: Incorrect marker coordinates for outer resources.
Mar 17 2017, 8:41 PM · User-notice, MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Maps-Sprint, Patch-For-Review, Maps, Discovery, Russian-Sites
JGirault moved T160598: Split “Visual Style” page into several sub-pages from Backlog to Needs Review/Feedback on the WikimediaUI Style Guide board.
Mar 17 2017, 1:10 AM · WikimediaUI Style Guide
JGirault added a comment to T160598: Split “Visual Style” page into several sub-pages.

Small PR fixing <title> tags, following the real one from @Volker_E, that was merged yesterday.

Mar 17 2017, 1:09 AM · WikimediaUI Style Guide

Mar 16 2017

JGirault moved T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Mar 16 2017, 11:41 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
JGirault added a comment to T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules.

Simulation with preferred languages = arabic, french, spanish, hebrew

Mar 16 2017, 11:40 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
Volker_E awarded T160704: Design better typographic scale for the portal a 100 token.
Mar 16 2017, 11:24 PM · Discovery-Portal-Backlog, Design, Discovery, Wikimedia-Portals
JGirault moved T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules from What's Next to In Progress on the Discovery-Portal-Sprint board.
Mar 16 2017, 10:36 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
JGirault claimed T122053: Wikipedia.org Portal: links around globe need to respect right-to-left language rules.
Mar 16 2017, 10:36 PM · Patch-For-Review, Discovery-Portal-Sprint, I18n, RTL, Wikimedia-Portals, Discovery
JGirault moved T160217: Clean up portals CSS from Backlog to In Progress on the Discovery-Portal-Sprint board.
Mar 16 2017, 10:30 PM · Performance, Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
JGirault moved T160474: Convert inconsistent font sizes, margins, paddings units... to rem unit from Backlog to Needs code review on the Discovery-Portal-Sprint board.
Mar 16 2017, 10:28 PM · Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
JGirault updated subscribers of T160704: Design better typographic scale for the portal.
  • Define the rem base. rem is a unit relative to the font size of the root element (<html>).
Mar 16 2017, 10:27 PM · Discovery-Portal-Backlog, Design, Discovery, Wikimedia-Portals
JGirault added a project to T160704: Design better typographic scale for the portal: Design.
Mar 16 2017, 10:18 PM · Discovery-Portal-Backlog, Design, Discovery, Wikimedia-Portals
JGirault added a comment to T160474: Convert inconsistent font sizes, margins, paddings units... to rem unit.

After the patch, we can identify 35 occurrences of font-sizes:

Mar 16 2017, 9:55 PM · Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals