@Volker_E I would suggest that the $SubmitDiv should stay as a <div>. I could be misunderstanding the codebase, but I believe that $SubmitDiv creates a container for the SubmitButton and CancelButton (which are both <button> elements). To me, $SubmitDiv is not an interactive element, but a container for two interactive elements that are tagged appropriately. Please let me know if I am misinterpreting this. Thanks.

@Volker_E Yep, I missed that...how should I go about amending? Create a different Gerrit submission with this bug tagged or a sub task or...?

See images below for before(left) and after(right).

Here are screenshots of the buttons that were converted. The top row is before and the bottom row is after.
The buttons that were converted were the copy button in the embed and share dialog, as well as in the download-pane.

@Volker_E So I changed the approach from using msg in aria-label to using text-indent: -9999em & overflow: hidden for the patch set 5 but then I came across this documentation (https://www.mediawiki.org/wiki/Accessibility_guide_for_developers) that says don't it that way. Should I still go this route or do something different? Thanks.

Hey, I've been waiting for a patch review for this issue for about a week. Could someone help me out in trying to get the patch reviewed? Please and thank you in advance.

If a <button> already has a tittle property, is there any reason to add an aria-label as well?

• add a similar mixin to OOUI's common.less,

Hey, I'm Hunter, and I'm one of five senior CS students that are on a team wanting to contribute to MediaWiki accessibility. We are all new to open-source contributing. We have gone through the Vagrant development environment setup and read through the MediaWiki hacking onboarding doc. We were looking through the open tasks to find one to work on and thought this would be an excellent place to start.