Aug 14 2023
Aug 2 2023
Question for front-end standards meeting: how do we distinguish between a close event (the codex x button) and clicking outside the dialog to close?
The biggest chunk of this work is getting the information we need from discussion tools (where was the button clicked, topic or comment) in order to log the button event correctly
Aug 1 2023
Jul 31 2023
Jul 24 2023
Jul 21 2023
Thanks Derek! I've put up a patch that addresses this feedback. One small thing- from what I can tell on the figma, the buttons need to be equal width in mobile but not in desktop, which is what I've done in this patch.
Jul 19 2023
Q: do we validate only on submission, or do we check fields as they navigate the form?
Jul 17 2023
patch demo for QA: https://patchdemo.wmflabs.org/wikis/0a6ae76a64/wiki/User_talk:Patch_Demo (you'll need to log in)
Jul 13 2023
Jul 10 2023
Jul 7 2023
Jul 5 2023
Revisit after: https://phabricator.wikimedia.org/T339991
Can ping #engineering-enablement
Jun 27 2023
Jun 26 2023
Agreed! @Madalina this ticket is in the product sign-off column, what more do you need from me to close?