Page MenuHomePhabricator

Jacek.duszenko (jack)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 21 2019, 3:26 AM (17 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jacek.duszenko [ Global Accounts ]

Recent Activity

Feb 23 2019

Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

All right, I got it now. Getting to work then ;)

Feb 23 2019, 11:33 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

I am not sure what you mean. Could you clarify with an example please? Let's say that we have page test.wikipedia.com/test_page. The script moves it to test2.wikipedia.com/test_page. The summary of this change now is as it was before. And it is correct.
Afterwards, the script moves page test.wikipedia.com/test_page/edithistory to test2.wikipedia.com/test_page/edithistory. And, according to you, what summary should be here in this case?

Feb 23 2019, 11:20 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

@Zoranzoki21 Let me make sure that I understood CR correctly. When moving the /edithistory between wikis you want the entire summary to disappear, right? I thought it would be better if information stayed, but in other form than it was before.

Feb 23 2019, 11:08 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

I though so ;)

Feb 23 2019, 8:19 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

@Dvorapa @Xqt What does 'recheck' mean in gerrit code-reviews ? Does it mean that I should recheck my code again or maybe it triggers a jenkins test build?
Do you guys sit on some particular Zulip channel? I joined irc but it's like nobody's there.

Feb 23 2019, 8:04 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T151540: Enable misspelling for a single misspelling page.

May I claim this task @Ivanhercaz ?

Feb 23 2019, 7:47 PM · good first bug, Pywikibot-Scripts, Pywikibot
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

Thank you @Dvorapa , I have mistakenly deleted the unwanted change-Id, just like you said :) I have uploaded the third patch to a correct change. Now, how do I remove the one that was mistakenly added?

Feb 23 2019, 7:10 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko updated subscribers of T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

Hello again, I've uploaded the change, then I improved the code according to @Xqt review. Can you please look at my second patch commit message? It isn't written anywhere how should it look. The problem is that this second patch message has messages of both my commits (one of them was squashed into another). Should this message look as is now? Or maybe it is to contain only one message. If yes, then which commit message?
Also I'm wondering if the first Jenkins build fail was because of flake8 warnings or something else screwed up?
Also @Xqt I think I added the second patch before you finished your remarks concerning first patch, could you please look at it once again? Can I write you a pm with questions relevant to the code? Or at least please point me to the place where I could write comments that would concern the code. Thanks

Feb 23 2019, 6:37 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts

Feb 22 2019

Jacek.duszenko updated subscribers of T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.
Feb 22 2019, 2:32 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko added a comment to T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.

Hello, I've already fixed the bug in code but I want to make sure it really works. I wanted to set up my local development mediawiki and use transferbot.py in order to transfer a random page to it. How do I issue the transferbot.py command in that case? As this example from the docs:
$ python pwb.py transferbot -family:wikipedia -lang:en -cat:"Query service" -tofamily:wiktionary -tolang:ar -prefix:"Wiktionary:Import enwp/"
is clear to me, I don't know what arguments to use when I'd want to transfer the page to my local development wiki.

Feb 22 2019, 2:32 PM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts
Jacek.duszenko claimed T216455: transferbot.py adds same summary with /edithistory for /edithistory subpage.
Feb 22 2019, 4:34 AM · Patch-For-Review, good first bug, Pywikibot, Pywikibot-Scripts