Page MenuHomePhabricator

Jack_who_built_the_house
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2016, 6:06 PM (420 w, 1 d)
Availability
Available
LDAP User
Jack who built the house
MediaWiki User
Jack who built the house [ Global Accounts ]

Recent Activity

Today

Jack_who_built_the_house committed rMGCD407b2f1f58cc: Fix worker.
Fix worker
Wed, Apr 24, 7:49 AM
Jack_who_built_the_house committed rMGCDaf2615be7b9a: Fix and improve cleaning up signatures.
Fix and improve cleaning up signatures
Wed, Apr 24, 7:45 AM

Yesterday

Jack_who_built_the_house committed rMGCD736012ebde8e: Really delete global preferences instead of setting them to empty string.
Really delete global preferences instead of setting them to empty string
Tue, Apr 23, 10:09 PM
Jack_who_built_the_house committed rMGCD4aa0bb9aa9bc: Apply minor improvements.
Apply minor improvements
Tue, Apr 23, 9:58 PM
Jack_who_built_the_house committed rMGCD5f7c963aa12a: Fix algorithm for removing signature from edited comment.
Fix algorithm for removing signature from edited comment
Tue, Apr 23, 9:58 PM
Jack_who_built_the_house committed rMGCD3ae46f904fb0: i18n: Improve dn-grantpermission-again string.
i18n: Improve dn-grantpermission-again string
Tue, Apr 23, 9:39 PM
Jack_who_built_the_house committed rMGCDd87e2877af81: Fix clearing image in upload dialog.
Fix clearing image in upload dialog
Tue, Apr 23, 9:39 PM
Jack_who_built_the_house committed rMGCDf8fc6c1a2fb1: Fix position of section menu of subsections in Parsoid DOM.
Fix position of section menu of subsections in Parsoid DOM
Tue, Apr 23, 9:39 PM
Jack_who_built_the_house committed rMGCDa3ffb88ac7c6: Fix editing comments following a heading.
Fix editing comments following a heading
Tue, Apr 23, 8:13 PM
Jack_who_built_the_house committed rMGCD8102c3d6da0d: Exclude headings from return value of Comment#getText().
Exclude headings from return value of Comment#getText()
Tue, Apr 23, 8:13 PM
Jack_who_built_the_house committed rMGCDbde6fc936039: Fix expensive calls on every keystroke when replying to section.
Fix expensive calls on every keystroke when replying to section
Tue, Apr 23, 8:13 PM
Jack_who_built_the_house committed rMGCDb57c9e74d626: Fix ' at start of signatures not removed from some when editing.
Fix ' at start of signatures not removed from some when editing
Tue, Apr 23, 8:13 PM
Jack_who_built_the_house committed rMGCDfc54b8dc9726: Support Parsoid.
Support Parsoid
Tue, Apr 23, 8:13 PM
Jack_who_built_the_house committed rMGCD26d9cdce69c9: Fix handling multiple aliases of contributions page.
Fix handling multiple aliases of contributions page
Tue, Apr 23, 1:09 PM
Jack_who_built_the_house committed rMGCD42881caae395: docs: Update docs of specialPageAliases config value.
docs: Update docs of specialPageAliases config value
Tue, Apr 23, 12:51 PM
Jack_who_built_the_house committed rMGCD1bd911dbe7e9: Merge branch 'main' of https://github.com/jwbth/convenient-discussions.
Merge branch 'main' of https://github.com/jwbth/convenient-discussions
Tue, Apr 23, 12:51 PM
Jack_who_built_the_house committed rMGCDee570d3dec2d: Simplify logic for updating thread lines.
Simplify logic for updating thread lines
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD1ce5f5c29565: Don't show "Performance issues?" popup when modifier keys are held.
Don't show "Performance issues?" popup when modifier keys are held
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDf5a9780d9166: Fix threads being collapsed twice.
Fix threads being collapsed twice
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDd514c3b57db4: Fix function signatures and docs.
Fix function signatures and docs
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDc654dac8f6dd: Supplement list of inline/not inline popular elements.
Supplement list of inline/not inline popular elements
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD00ad3de10797: Don't offer to subscribe to topics on own talk page.
Don't offer to subscribe to topics on own talk page
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD3706459355af: Fix scrolling up to parent comment when it is hidden.
Fix scrolling up to parent comment when it is hidden
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD5e60b9cfa17e: Allow multiple aliases of special pages.
Allow multiple aliases of special pages
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDe4224a56e2ba: Don't create multiple "can't scroll to a hidden element" notifications.
Don't create multiple "can't scroll to a hidden element" notifications
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDb1fe5d941f75: Fix wrapping comments in smalldiv templates small tags in comment form.
Fix wrapping comments in smalldiv templates small tags in comment form
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDa1eba56c2408: i18n: Improve ud-preset-projectscreenshot-help string.
i18n: Improve ud-preset-projectscreenshot-help string
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCDa805690f601e: Fix including outdent templates in some comments.
Fix including outdent templates in some comments
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD2b6f306a155f: Fix replying to comments with outdented replies.
Fix replying to comments with outdented replies
Tue, Apr 23, 12:44 PM
Jack_who_built_the_house committed rMGCD95ffdc85ef41: Fix autocollapsing threads.
Fix autocollapsing threads
Tue, Apr 23, 12:44 PM

Sun, Apr 21

Jack_who_built_the_house committed rMGCD9915700df82b: Fix page navigation panel.
Fix page navigation panel
Sun, Apr 21, 10:26 PM
Jack_who_built_the_house added a comment to T249591: Add a new licensing page to the Upload dialog / Cross-wiki media upload tool.

Just so you know, I've tweaked the update dialog, based on @Nardog's prototype, for the needs of Convenient-Discussions, adding the ability to choose a preset for screenshots that autofills the description, source, license, and author fields. It still doesn't have a choice of licenses, but makes them available to be typed in manually.

Sun, Apr 21, 10:02 PM · Convenient-Discussions, DiscussionTools, Editing-team, MediaWiki-Uploading, Commons
Jack_who_built_the_house committed rMGCDf2d482723ebc: i18n: Fix Russian translation.
i18n: Fix Russian translation
Sun, Apr 21, 12:26 PM
Jack_who_built_the_house committed rMGCD0c241c73c8cf: i18n: Fix Russian translation.
i18n: Fix Russian translation
Sun, Apr 21, 12:20 PM
Jack_who_built_the_house committed rMGCDa9c3b9e82b95: i18n: Update Russian translation.
i18n: Update Russian translation
Sun, Apr 21, 12:12 PM
Jack_who_built_the_house committed rMGCD6fb41046560f: Merge branch 'main' of ssh://gerrit.wikimedia.org….
Merge branch 'main' of ssh://gerrit.wikimedia.org…
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCD61fcd66b8df4: Don't show subscribe checkbox for unsubscribable sections.
Don't show subscribe checkbox for unsubscribable sections
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCDbc947678194f: Apply minor improvements.
Apply minor improvements
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCDb3933e6471b0: Emulate native "Add topic" button when there is such button on page.
Emulate native "Add topic" button when there is such button on page
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCD2da5af30938a: Don't fire wikipage.content on unattached content.
Don't fire wikipage.content on unattached content
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCDf10b71184a88: Add link to timezone preferences from settings dialog.
Add link to timezone preferences from settings dialog
Sun, Apr 21, 11:52 AM
Jack_who_built_the_house committed rMGCDc8b1bf419cb1: Add link to timezone preferences from settings dialog.
Add link to timezone preferences from settings dialog
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDde0afcd95ef8: Don't fire wikipage.content on unattached content.
Don't fire wikipage.content on unattached content
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD5820ff1a9453: Fix and improve "Performance issues?" notification.
Fix and improve "Performance issues?" notification
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDb93528dd860a: Emulate native "Add topic" button when there is such button on page.
Emulate native "Add topic" button when there is such button on page
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDdbfbf3812e91: Fix "Topic/comment not found" notifications.
Fix "Topic/comment not found" notifications
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDa7be507319d0: Fix inserting user mention for names containing "(", ",".
Fix inserting user mention for names containing "(", ","
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDb386b26565a5: Fix determining comment boundaries when outdent template is around.
Fix determining comment boundaries when outdent template is around
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD830a93af31b0: Apply minor improvements.
Apply minor improvements
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDf37556d89920: Handle special case of unsigned items in participant lists.
Handle special case of unsigned items in participant lists
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD49089f425ee6: Fix onboarding popups positioning on 404 pages.
Fix onboarding popups positioning on 404 pages
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD346f272ee10b: Make CD compatible with clean MediaWiki installation.
Make CD compatible with clean MediaWiki installation
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD76d310e72390: Fix legacy subscriptions.
Fix legacy subscriptions
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCD791989b92b45: Fix layers positioning issue for stretched comments.
Fix layers positioning issue for stretched comments
Sun, Apr 21, 7:43 AM
Jack_who_built_the_house committed rMGCDe57beb68bb14: Try to fix inability to click elements behind menu on mobile.
Try to fix inability to click elements behind menu on mobile
Sun, Apr 21, 7:43 AM

Sat, Apr 20

Jack_who_built_the_house committed rMGCD66d2043b7db7: Don't replace <br> after inline templates with \n when editing comment.
Don't replace <br> after inline templates with \n when editing comment
Sat, Apr 20, 9:12 AM
Jack_who_built_the_house added a comment to T360917: [Spike 3hrs] Unintended vertical spacing behaviour .

An issue @Jdrewniak pointed out with this approach (and technically any approach that relies on sibling selectors) is that we wont have the correct spacing when elements are floated.

Right, unfortunately p + p will immediately distort the appearance of the majority of articles, and in a noticeable way. Just to be clear: if you apply a fix only to images, something like p + figure + p, you will soon notice that there are also floating tables, floating divs, floating divs preceded by a <link> element from TemplateStyles, groups of floating images, non-floating images, etc. etc. This is volunteers' turf, not developers'; I don't think it's feasible to find any meaningful compromise here and not find yourself (and volunteers) hunting for the endless exceptions for many years to come.

Sat, Apr 20, 7:27 AM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations

Fri, Apr 19

Jack_who_built_the_house committed rMGCDc4f0e1065dbc: Merge branch 'main' of https://github.com/jwbth/convenient-discussions.
Merge branch 'main' of https://github.com/jwbth/convenient-discussions
Fri, Apr 19, 7:57 PM
Jack_who_built_the_house committed rMGCDcf2da9598259: Merge branch 'main' of https://github.com/jwbth/convenient-discussions.
Merge branch 'main' of https://github.com/jwbth/convenient-discussions
Fri, Apr 19, 7:54 PM
Jack_who_built_the_house committed rMGCDb94e5cdaa6c7: Apply minor improvements.
Apply minor improvements
Fri, Apr 19, 7:54 PM
Jack_who_built_the_house committed rMGCD35c91b3fff6e: Fix moving sections.
Fix moving sections
Fri, Apr 19, 7:26 PM
Jack_who_built_the_house committed rMGCDcd52567ff134: chore: Turn off some eslint-plugin-jsdoc warnings as they seem wrong.
chore: Turn off some eslint-plugin-jsdoc warnings as they seem wrong
Fri, Apr 19, 7:26 PM
Jack_who_built_the_house committed rMGCD22f0084b990a: Allow to reply to comments having outdented replies.
Allow to reply to comments having outdented replies
Fri, Apr 19, 7:26 PM
Jack_who_built_the_house added a reverting change for rMGCD317d9bc9c962: chore: Bump Node version in GitHub workflows: rMGCDebac4cbf7bcc: Revert "chore: Bump Node version in GitHub workflows".
Fri, Apr 19, 7:25 PM
Jack_who_built_the_house committed rMGCDc729897991a8: Fix tests.
Fix tests
Fri, Apr 19, 7:25 PM
Jack_who_built_the_house committed rMGCDebac4cbf7bcc: Revert "chore: Bump Node version in GitHub workflows".
Revert "chore: Bump Node version in GitHub workflows"
Fri, Apr 19, 7:25 PM
Jack_who_built_the_house committed rMGCD22bdcd766808: chore: Update JSDoc's ESLint config.
chore: Update JSDoc's ESLint config
Fri, Apr 19, 7:25 PM

Thu, Apr 18

Jack_who_built_the_house committed rMGCD317d9bc9c962: chore: Bump Node version in GitHub workflows.
chore: Bump Node version in GitHub workflows
Thu, Apr 18, 6:48 PM
Jack_who_built_the_house committed rMGCD47d275e261bf: chore: Update eslint-plugin-jsdoc.
chore: Update eslint-plugin-jsdoc
Thu, Apr 18, 6:44 PM
Jack_who_built_the_house committed rMGCD1ecfba3950f3: In upload dialog, replace "/" with "-" In filenames.
In upload dialog, replace "/" with "-" In filenames
Thu, Apr 18, 6:27 PM
Jack_who_built_the_house closed T288409: Blocked user can't write on his talk page (excluded from block) because of using a tool that adds tags to replies as Resolved by committing rMGCD51eb869e8213: Resubmit form without tag if "tags-apply-blocked" error is received.
Thu, Apr 18, 4:44 PM · MediaWiki-Action-API, MediaWiki-Change-tagging, MediaWiki-Blocks, Convenient-Discussions
Jack_who_built_the_house committed rMGCD51eb869e8213: Resubmit form without tag if "tags-apply-blocked" error is received.
Resubmit form without tag if "tags-apply-blocked" error is received
Thu, Apr 18, 4:44 PM
Jack_who_built_the_house added a comment to T360917: [Spike 3hrs] Unintended vertical spacing behaviour .

where I consistently apply 0.5em top and bottom padding to <p> elements, except i increase the top margin for “p + p” elements to 1em

Thu, Apr 18, 3:59 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jack_who_built_the_house reopened T288409: Blocked user can't write on his talk page (excluded from block) because of using a tool that adds tags to replies as "Open".

The task I closed this in favor of doesn't seem like it's going to be fixed in the near term. It's not even clear if this is a bug and not a feature (although it's not clear to me why CD can't set a tag while DiscussionTools can). Instead, I will just resubmit the form without a tag if tags-apply-blocked error it received.

Thu, Apr 18, 2:50 PM · MediaWiki-Action-API, MediaWiki-Change-tagging, MediaWiki-Blocks, Convenient-Discussions

Wed, Apr 17

Jack_who_built_the_house committed rMGCDb49e5f1a091c: Fix how script works for anonymous users.
Fix how script works for anonymous users
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD9a107e3078e8: Don't unhide live-changed comment when it is edited.
Don't unhide live-changed comment when it is edited
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD5430138cd5c9: Fix reloading page at first script run when new formatting is enabled.
Fix reloading page at first script run when new formatting is enabled
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDfdcb745c00a6: Fix reloading page.
Fix reloading page
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD882e0074c410: Fix editing.
Fix editing
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD4d1b443ae130: Continue refactoring.
Continue refactoring
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDcc075545d811: Add and use .query() method to some registries.
Add and use .query() method to some registries
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD3034e6204d7f: Apply many minor improvements.
Apply many minor improvements
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDead27aff69cb: docs: Use default access settings to build docs.
docs: Use default access settings to build docs
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD34cb02cb01af: Use cd.page, cd.user instead of module method calls.
Use cd.page, cd.user instead of module method calls
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD7d31d2ce5c41: Add captcha support.
Add captcha support
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD338d449a1e15: Use flat directory structure for JS and Less files.
Use flat directory structure for JS and Less files
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD07305e5957b4: Fix commentRegistry#addNewCommentsNotes().
Fix commentRegistry#addNewCommentsNotes()
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD85eb3434859d: Use cd.page, cd.user instead of module method calls.
Use cd.page, cd.user instead of module method calls
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD2c27a4f05e27: Allow to quote by pressing comment button when form is open.
Allow to quote by pressing comment button when form is open
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD677b54724ca9: configs: Use inline, not block quote templates.
configs: Use inline, not block quote templates
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD556d43801654: When editing comment, ignore headings inside nowiki.
When editing comment, ignore headings inside nowiki
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDb8aa3d869353: Continue refactoring.
Continue refactoring
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDd5b63f0aa71a: Automatically omit signature when using some subst templates when replying.
Automatically omit signature when using some subst templates when replying
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDc0ec0a03cbf3: Tell about shortcuts for toolbar buttons in help popup.
Tell about shortcuts for toolbar buttons in help popup
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD25a292c9ab58: Fix multiple page roots on IP talk pages.
Fix multiple page roots on IP talk pages
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD4f16f8ebde20: Continue refactoring.
Continue refactoring
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD64060bb87f4f: Restore compatibility with RevisionSlider.
Restore compatibility with RevisionSlider
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCDa6c0ff2c0ce9: Continue refactoring.
Continue refactoring
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD28cfafb86117: Support temporary accounts.
Support temporary accounts
Wed, Apr 17, 10:20 PM
Jack_who_built_the_house committed rMGCD032aaa69cb8b: Implement shortcuts for formatting.
Implement shortcuts for formatting
Wed, Apr 17, 10:20 PM