Page MenuHomePhabricator

Jack_who_built_the_house
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2016, 6:06 PM (167 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jack who built the house [ Global Accounts ]

Recent Activity

Jan 28 2019

Jack_who_built_the_house added a comment to T214836: Renaming the topics.

It can be switched on by var cdAllowEditOthersMsgs = true; ;-)

Jan 28 2019, 11:05 PM · Convenient-Discussions
Jack_who_built_the_house added a comment to T214836: Renaming the topics.

What's wrong with the standard "Edit description" feature? Topic name edit is just like a normal message edit.

Jan 28 2019, 6:02 PM · Convenient-Discussions

Jan 27 2019

Jack_who_built_the_house added a watcher for Convenient-Discussions: Jack_who_built_the_house.
Jan 27 2019, 10:10 PM

Jan 26 2019

Jack_who_built_the_house added a comment to T214676: Auto-sorting for topics.

Theoretically this could be done by a plugin relying on cd.sectionsReady hook. But this may lead to problems with new messages navigation and messages highlight zone redrawal mechanism.

Jan 26 2019, 4:33 PM · Convenient-Discussions
Jack_who_built_the_house closed T214683: Non-breaking space for insert buttons as Resolved.
Jan 26 2019, 3:27 PM · Convenient-Discussions
Jack_who_built_the_house added a comment to T214683: Non-breaking space for insert buttons.

Fixed here and here.

Jan 26 2019, 3:27 PM · Convenient-Discussions
Jack_who_built_the_house closed T214719: 'undefined' date for bots after move the thread as Resolved.
Jan 26 2019, 3:26 PM · Convenient-Discussions
Jack_who_built_the_house added a comment to T214719: 'undefined' date for bots after move the thread.

Fixed here.

Jan 26 2019, 3:25 PM · Convenient-Discussions
Jack_who_built_the_house added a comment to T214683: Non-breaking space for insert buttons.

Thanks for the PR, but I think using CSS would be a better idea. We would have to add a space between items for white-space: nowrap to work properly.

Jan 26 2019, 10:33 AM · Convenient-Discussions

Jan 21 2019

Jack_who_built_the_house added a comment to T214291: Convenient Discussions project.

Hello. @Aklapper, well, it's anything but a small project, its total code size is about 400 KB after Babel, 200 KB with uglification. I plan to spread it to other projects, so interproject communication on Phabricator would be nice. Its github repository is here: https://github.com/jwbth/convenient-discussions. So, do you ask to create a repository on Gerrit too?

Jan 21 2019, 2:07 PM · Project-Admins

Jan 7 2019

Jack_who_built_the_house added a comment to T213049: Enable signature button in toolbar for the "Arbitration" namespace in ruwiki.

Thanks.

Jan 7 2019, 10:09 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests
Jack_who_built_the_house updated the task description for T213049: Enable signature button in toolbar for the "Arbitration" namespace in ruwiki.
Jan 7 2019, 10:09 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests
Jack_who_built_the_house updated the task description for T213049: Enable signature button in toolbar for the "Arbitration" namespace in ruwiki.
Jan 7 2019, 8:14 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests
Jack_who_built_the_house created T213049: Enable signature button in toolbar for the "Arbitration" namespace in ruwiki.
Jan 7 2019, 8:13 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests

Dec 12 2018

Jack_who_built_the_house updated the task description for T211501: Page Previews should take FlaggedRevs' stabilization setting into account.
Dec 12 2018, 12:35 PM · Core Platform Team Backlog (Later), Services (later), Readers-Web-Backlog (Tracking), Page-Previews, MediaWiki-extensions-FlaggedRevs

Dec 9 2018

Jack_who_built_the_house renamed T211501: Page Previews should take FlaggedRevs' stabilization setting into account from Page Previews should take into account FlaggedRevs' stabilization setting to Page Previews should take FlaggedRevs' stabilization setting into account.
Dec 9 2018, 2:37 PM · Core Platform Team Backlog (Later), Services (later), Readers-Web-Backlog (Tracking), Page-Previews, MediaWiki-extensions-FlaggedRevs
Jack_who_built_the_house created T211501: Page Previews should take FlaggedRevs' stabilization setting into account.
Dec 9 2018, 2:34 PM · Core Platform Team Backlog (Later), Services (later), Readers-Web-Backlog (Tracking), Page-Previews, MediaWiki-extensions-FlaggedRevs

Dec 7 2018

Jack_who_built_the_house updated the task description for T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 7 2018, 5:56 PM · User-TheDJ, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 7 2018, 12:40 PM · User-TheDJ, MediaWiki-extensions-CodeMirror

Dec 5 2018

Jack_who_built_the_house renamed T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors from Toolbar/charinsert don't handle CodeMirrors's multiple selections/cursors to Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 5 2018, 2:36 PM · User-TheDJ, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 5 2018, 2:34 PM · User-TheDJ, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 5 2018, 2:31 PM · User-TheDJ, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 5 2018, 2:28 PM · User-TheDJ, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house created T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
Dec 5 2018, 2:28 PM · User-TheDJ, MediaWiki-extensions-CodeMirror

Nov 30 2018

Jack_who_built_the_house added a comment to T210789: Table of contents' hidden state isn't kept after reload.

@Schnark So, what is it based on? Technical unfeasibility? Perceived lack of necessity? There are users who are not happy about it. I think, some would say, there is no need in the hiding/showing functionality at all if the state is not saved in a cookie. The only thing it does when used on one page is saves a small amount of space.

Nov 30 2018, 11:05 AM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface

Nov 29 2018

Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 11:11 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house renamed T210789: Table of contents' hidden state isn't kept after reload from Table of contents' hidden state isn't kept after reload in Chrome to Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 11:10 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:38 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
SerDIDG awarded T210789: Table of contents' hidden state isn't kept after reload a Burninate token.
Nov 29 2018, 9:34 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:25 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:24 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:24 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house updated the task description for T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:23 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
Jack_who_built_the_house created T210789: Table of contents' hidden state isn't kept after reload.
Nov 29 2018, 9:21 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface

Nov 28 2018

Jack_who_built_the_house added a comment to T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.

The problem is that adding the class hatnote doesn't help, I've tried that on https://ru.m.wikipedia.org/w/index.php?title=Истомин,_Константин_Иванович&oldid=96534177.

Nov 28 2018, 8:48 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites

Nov 27 2018

Jack_who_built_the_house updated the task description for T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.
Nov 27 2018, 9:00 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites
Jack_who_built_the_house updated the task description for T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.
Nov 27 2018, 8:15 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites
Jack_who_built_the_house updated the task description for T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.
Nov 27 2018, 8:14 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites
Jack_who_built_the_house created T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.
Nov 27 2018, 8:11 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites

Oct 1 2018

RandomDSdevel awarded T197157: New diffs show lines in the wrong order a Baby Tequila token.
Oct 1 2018, 1:38 AM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Aug 27 2018

Liuxinyu970226 awarded T197157: New diffs show lines in the wrong order a Like token.
Aug 27 2018, 10:07 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Aug 7 2018

Jack_who_built_the_house added a comment to T56029: VisualEditor: Provide support for BLP edit notices on enwiki.

Just to make you know: in ruwiki, we adapted RockMFR's "magic editintros" to work with VisualEditor (although the resultant script is rather hackish), see https://ru.wikipedia.org/wiki/MediaWiki:Gadget-blpEditNotice.js.

Aug 7 2018, 6:09 PM · Patch-For-Review, VisualEditor, VisualEditor-MediaWiki

Aug 2 2018

Jack_who_built_the_house added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

@Krinkle Thanks for the detailed explanation.

Aug 2 2018, 4:41 PM · Performance-Team (Radar), MediaWiki-Interface, MediaWiki-ResourceLoader
Jack_who_built_the_house added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

Right now we have at least 3 widely used gadgets that would need such query, probably there will be more. Having 5–10 additional requests doesn't seem to make negligable difference. Many such gadgets also add elements that shift content on pages which in turn causes misclicks, so the earlier they run the better. Anyway, is it so difficult to implement? I thought splitting large JS files into modules according to the semantics of different code parts and loading them, together with other modules, in one package is exactly what ResourceLoader is for.

Aug 2 2018, 3:20 PM · Performance-Team (Radar), MediaWiki-Interface, MediaWiki-ResourceLoader
Jack_who_built_the_house added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

Right now many people who ask for interface-admin (see T190015) permissions in ruwiki are worried about the ability to edit gadgets data. But with the current state where the integration of JSON with gadgets is poor, the ability to load external JSON for gadgets is very limited. Hence, the efforts to integrate JSON with ResourceLoader as soon as possible are essential from the perspective of the interface-admin flag purpose.

Aug 2 2018, 12:05 PM · Performance-Team (Radar), MediaWiki-Interface, MediaWiki-ResourceLoader

Jul 30 2018

Jack_who_built_the_house updated the task description for T200704: TemplateStyles don't work when the template is inside a link.
Jul 30 2018, 4:23 PM · MediaWiki-Parser, TemplateStyles
Jack_who_built_the_house added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

Can't the <style> tags be moved to some centralized place altogether? Their scattered presence in HTML causes problems like mentioned here, in T186965 and in T200704 (I opened the last task just recently).

Jul 30 2018, 4:20 PM · Performance, MediaWiki-Parser, TemplateStyles
Jack_who_built_the_house updated the task description for T200704: TemplateStyles don't work when the template is inside a link.
Jul 30 2018, 4:10 PM · MediaWiki-Parser, TemplateStyles
SerDIDG awarded T200704: TemplateStyles don't work when the template is inside a link a Burninate token.
Jul 30 2018, 4:07 PM · MediaWiki-Parser, TemplateStyles
Jack_who_built_the_house created T200704: TemplateStyles don't work when the template is inside a link.
Jul 30 2018, 4:05 PM · MediaWiki-Parser, TemplateStyles

Jul 29 2018

Jack_who_built_the_house added a comment to T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.

Moreover, it's true for user JS/CSS as well. As I remember, those used to be updated instantly.

Jul 29 2018, 10:12 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house added a comment to T67114: ReferencePreviews: Implement Citation Previews.
  • The behavior is not consistent: if a reference (the text at the bottom of the page) is visible to the user (i.e. if the citation link's (like [1]) target is visible in the screen), hovering the mouse on the citation link won't show a pop-up with the reference. Instead, the reference at the bottom will just be highlighted. You can see an example here (the citation link is at the right of the screen below the image): try hovering the citation link when the Sources section is visible on the screen or not. Note that this is an intended behavior which can be easily changed in the code and is common to both implementations.
Jul 29 2018, 10:12 PM · Readers-Web-Backlog, User-notice, Reference Previews, German-Community-Wishlist-Main-Wishes, Wikimedia-Israel-Hackers, Design, Page-Previews

Jul 17 2018

Jack_who_built_the_house added a comment to T197157: New diffs show lines in the wrong order.

Yes, pretty much looks like.

Jul 17 2018, 9:43 AM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Jul 15 2018

Jack_who_built_the_house awarded T198370: Transparent background renders as white in PNG thumbnails a The World Burns token.
Jul 15 2018, 10:39 AM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, MediaWiki-File-management, Commons

Jul 14 2018

Jack_who_built_the_house added a comment to T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.

As I can see, the first change is live. How about the second (adding newlines that weren't in the source)?

Jul 14 2018, 11:53 AM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Jul 12 2018

SerDIDG awarded T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour a Yellow Medal token.
Jul 12 2018, 3:55 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
stjn awarded T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour a Burninate token.
Jul 12 2018, 3:36 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house added a comment to T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.

Sure, purge is useless in such cases.

Jul 12 2018, 2:23 PM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house updated the task description for T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.
Jul 12 2018, 8:40 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house updated the task description for T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.
Jul 12 2018, 8:36 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house created T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.
Jul 12 2018, 8:35 AM · MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team-Old, Multi-Content-Revisions, Regression, Performance-Team, MediaWiki-ResourceLoader
Jack_who_built_the_house added a comment to T179544: Some characters in HTML5 fragments mess with wikitext.

I have a silly question: why do we even use reference names in IDs? Because these IDs are also using reference numbers, they're not stable anyway.

Jul 12 2018, 8:02 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Parsoid, MediaWiki-Parser

Jul 11 2018

Jack_who_built_the_house removed a project from T199296: Interactive elements should be hidden on the print page: Readers-Web-Backlog.

No, was just trying to select an appropriate tag.

Jul 11 2018, 12:21 PM · MediaWiki-Interface
Jack_who_built_the_house updated the task description for T199296: Interactive elements should be hidden on the print page.
Jul 11 2018, 6:35 AM · MediaWiki-Interface
Jack_who_built_the_house created T199296: Interactive elements should be hidden on the print page.
Jul 11 2018, 6:34 AM · MediaWiki-Interface
Jack_who_built_the_house updated the task description for T199294: Anchor links from images shouldn't have previews.
Jul 11 2018, 6:30 AM · Page-Previews
Jack_who_built_the_house created T199294: Anchor links from images shouldn't have previews.
Jul 11 2018, 6:29 AM · Page-Previews

Jul 8 2018

Jack_who_built_the_house added a comment to T198370: Transparent background renders as white in PNG thumbnails.

That's very disturbing as many popular images are effectively spoiled after reuploading with minor adjustments.

Jul 8 2018, 1:56 PM · Patch-For-Review, Regression, media-storage, Thumbor, Multimedia, MediaWiki-File-management, Commons

Jun 23 2018

Jack_who_built_the_house updated the task description for T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.
Jun 23 2018, 3:08 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Jack_who_built_the_house added a comment to T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.

Don't really think it depends on that, but added.
BTW, my self-written code (see at the bottom) for 2017 wikitext editor works well in both cases.

Jun 23 2018, 3:06 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Jack_who_built_the_house updated the task description for T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.
Jun 23 2018, 2:56 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Jack_who_built_the_house edited projects for T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor, added: VisualEditor-MediaWiki-2017WikitextEditor; removed VisualEditor-MediaWiki-Links.
Jun 23 2018, 1:29 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Jack_who_built_the_house updated the task description for T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.
Jun 23 2018, 1:00 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Jack_who_built_the_house created T198010: jquery.textSelection methods work incorrectly with 2017 wikitext editor.
Jun 23 2018, 12:59 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Jun 21 2018

Jack_who_built_the_house updated the task description for T197516: pairs() doesn't preserve the order of parameters passed to the module.
Jun 21 2018, 1:35 AM · MediaWiki-extensions-Scribunto

Jun 20 2018

IKhitron awarded T197516: pairs() doesn't preserve the order of parameters passed to the module a Like token.
Jun 20 2018, 9:30 PM · MediaWiki-extensions-Scribunto

Jun 19 2018

Jack_who_built_the_house updated the task description for T197632: CodeMirror doesn't support focus/blur events for the editing area.
Jun 19 2018, 10:26 AM · MediaWiki-extensions-CodeMirror
Jack_who_built_the_house added a comment to T197632: CodeMirror doesn't support focus/blur events for the editing area.

Okay I assume I'm wrong about opt-out (just too many fellow users reported that). The issue still stands though.

Jun 19 2018, 10:22 AM · MediaWiki-extensions-CodeMirror

Jun 18 2018

Jack_who_built_the_house updated the task description for T197632: CodeMirror doesn't support focus/blur events for the editing area.
Jun 18 2018, 9:12 PM · MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T197632: CodeMirror doesn't support focus/blur events for the editing area.
Jun 18 2018, 9:09 PM · MediaWiki-extensions-CodeMirror
Jack_who_built_the_house updated the task description for T197632: CodeMirror doesn't support focus/blur events for the editing area.
Jun 18 2018, 9:08 PM · MediaWiki-extensions-CodeMirror
Jack_who_built_the_house created T197632: CodeMirror doesn't support focus/blur events for the editing area.
Jun 18 2018, 8:56 PM · MediaWiki-extensions-CodeMirror

Jun 16 2018

Jack_who_built_the_house created T197516: pairs() doesn't preserve the order of parameters passed to the module.
Jun 16 2018, 3:06 PM · MediaWiki-extensions-Scribunto

Jun 15 2018

Jack_who_built_the_house renamed T197157: New diffs show lines in the wrong order from New diff engine shows lines in the wrong order to New diffs show lines in the wrong order.
Jun 15 2018, 6:36 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs
Jack_who_built_the_house added a project to T197157: New diffs show lines in the wrong order: wikidiff2.
Jun 15 2018, 6:32 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Jun 13 2018

SerDIDG awarded T197157: New diffs show lines in the wrong order a Like token.
Jun 13 2018, 5:22 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs
Jack_who_built_the_house updated the task description for T197157: New diffs show lines in the wrong order.
Jun 13 2018, 5:20 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs
Jack_who_built_the_house created T197157: New diffs show lines in the wrong order.
Jun 13 2018, 5:20 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Jun 9 2018

Jack_who_built_the_house added a comment to T67114: ReferencePreviews: Implement Citation Previews.

We largely updated Reference Tooltips gadget in ruwiki, and welcome other wikis to update to it. Other suggestion is to create a global gadget based on it.

  • Tooltip style & animations are updated to be consistent with Page Previews' style & animations.
  • Many bugs are fixed (see the list here).
  • Harvard-style citations are now supported.
  • Tooltips inside tooltips are now working properly (they did work before, but there were bugs associated with this behaviour). See the animation.
  • An option is added that allows to convert native browser tooltips for titled <abbr> tags and such into gadget tooltips. It is default on touch devices, allowing users of the desktop version on such devices to see them.
  • The settings dialog is rewritten using OOUI (its modules are loaded on demand) and looks similar to the Page Previews settings dialog.
  • Saving the settings doesn't require page reload anymore.
  • The code is refactored. Tooltips & elements having them are objects now. The script used jQuery and pure JavaScript inconsistently – now it uses the first everywhere where appropriate (performance losses are negligable).
  • Old IE support is removed (JavaScript isn't loaded to them anyway).
  • The coding conventions are applied.

See more details at the gadget's mediawiki.org talk page.

Jun 9 2018, 9:00 PM · Readers-Web-Backlog, User-notice, Reference Previews, German-Community-Wishlist-Main-Wishes, Wikimedia-Israel-Hackers, Design, Page-Previews

Jun 8 2018

Jack_who_built_the_house added a comment to T196375: No right margin is needed for the last child of the save dialog's checkboxes block.

Thank you, @matmarex. Sorry, had to time.

Jun 8 2018, 2:29 PM · Verified, MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor (Current work), good first bug

Jun 4 2018

Jack_who_built_the_house renamed T196375: No right margin is needed for the last child of the save dialog's checkboxes block from No right margin is needed for the last child in the save dialog's checkboxes block to No right margin is needed for the last child of the save dialog's checkboxes block.
Jun 4 2018, 3:04 PM · Verified, MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor (Current work), good first bug
Jack_who_built_the_house created T196375: No right margin is needed for the last child of the save dialog's checkboxes block.
Jun 4 2018, 3:03 PM · Verified, MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor (Current work), good first bug

Jun 2 2018

Jack_who_built_the_house added a comment to T192623: ResourceLoader 2018 Review.

Thanks, I guess that's it.

Jun 2 2018, 2:10 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

Jun 1 2018

Jack_who_built_the_house added a comment to T192623: ResourceLoader 2018 Review.

I guess I'm incorrectly mixing DOMContentLoaded and moments of execution of its handlers here, here's one of my 2016 tests of in which order the hooks/events are fired on the action=edit page:

1480205746966 resourceloader.loadEnd
1480205747184 wikipage.content
1480205747356 wikipage.editform
1480205747566 ext.wikiEditor.toolbar
1480205747569 $
1480205748301 doneInitialSections
Jun 1 2018, 11:37 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Jack_who_built_the_house added a comment to T192623: ResourceLoader 2018 Review.

This internal hook was not supported for use by gadgets. The public interface provides wikipage.content and $().

Well, it was present in the documentation (now it's not). As I remember, it was a good way to catch a very early moment which used to happened even before DOMContentLoaded has fired. Not sure if it was conceptually appropriate for our purposes though; we used it to coordinate loading order of many related scripts & gadgets. Anyway, we now don't need it where we did, since we now do most of the task with gadget dependencies.

Jun 1 2018, 6:11 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Jack_who_built_the_house added a comment to T192623: ResourceLoader 2018 Review.

Scripts dependent on resourceloader.loadEnd hook have broken. Was it planned? Was the hook removed?

Jun 1 2018, 2:35 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

May 26 2018

Jack_who_built_the_house updated the task description for T67255: jquery.client should support detecting Firefox Mobile.
May 26 2018, 6:45 PM · jQuery-Client, JavaScript, Mobile
Jack_who_built_the_house renamed T130011: Support <abbr> in the mobile version (currently the 'mouseover' event is not equal to the 'touch' event) from Support <abbr> in the mobile version (currently the 'mouseover' event does not equal the 'touch' event) to Support <abbr> in the mobile version (currently the 'mouseover' event is not equal to the 'touch' event).
May 26 2018, 3:57 PM · Readers-Web-Backlog (Design)

May 18 2018

Jack_who_built_the_house updated the task description for T192210: Loading animation is over text on Recent Changes.
May 18 2018, 6:19 PM · MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, User-notice-collaboration, good first bug, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

May 11 2018

Jack_who_built_the_house added a comment to T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).

Thanks! I guess the method we use was acquired from some documentation that is now outdated.

May 11 2018, 2:14 PM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Vector, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface