Page MenuHomePhabricator

Jack_who_built_the_house
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2016, 6:06 PM (325 w, 7 h)
Availability
Available
LDAP User
Jack who built the house
MediaWiki User
Jack who built the house [ Global Accounts ]

Recent Activity

Yesterday

Jack_who_built_the_house updated the task description for T311517: {{plural:}} in JavaScript messages API is extraordinarily slow.
Tue, Jun 28, 5:54 PM · Performance Issue, Convenient-Discussions, MediaWiki-Internationalization, I18n, JavaScript
Jack_who_built_the_house updated the task description for T311517: {{plural:}} in JavaScript messages API is extraordinarily slow.
Tue, Jun 28, 2:03 PM · Performance Issue, Convenient-Discussions, MediaWiki-Internationalization, I18n, JavaScript
Jack_who_built_the_house created T311517: {{plural:}} in JavaScript messages API is extraordinarily slow.
Tue, Jun 28, 1:50 PM · Performance Issue, Convenient-Discussions, MediaWiki-Internationalization, I18n, JavaScript

Mon, Jun 27

Jack_who_built_the_house added a comment to T289558: ButtonMenuSelectWidget align incorrectly.

This bug can be easily encountered in a OOUI dialog, even if you place the button to the right.

Mon, Jun 27, 1:18 AM · Editing-team (FY2021-22 Kanban Board), Convenient-Discussions, DiscussionTools, Design, OOUI

Wed, Jun 22

Jack_who_built_the_house added projects to T289558: ButtonMenuSelectWidget align incorrectly: DiscussionTools, Convenient-Discussions.

Fun fact: as far as I understand, in order to implement the section action menu as in this demo (it's hidden behind display: none but is present with the class ext-discussiontools-init-section-actions), you will need this fixed.

Wed, Jun 22, 11:56 AM · Editing-team (FY2021-22 Kanban Board), Convenient-Discussions, DiscussionTools, Design, OOUI
Jack_who_built_the_house closed T253309: Add MediaWiki fallback language scheme for Convenient Discussions as Resolved.
Wed, Jun 22, 1:12 AM · I18n, Convenient-Discussions

Tue, Jun 21

Jack_who_built_the_house added a comment to T307771: Remove custom gradients from new vector sidebar.

If the gradient is kept, a left-to-right gradient would make more sense from the design point of view. A center-to-right gradient, as I said, is leftover from the times when the menu looked like this.

Tue, Jun 21, 10:08 PM · Readers-Web-Backlog, Desktop Improvements, UI-Standardization, Design
Jack_who_built_the_house updated the task description for T307771: Remove custom gradients from new vector sidebar.
Tue, Jun 21, 10:06 PM · Readers-Web-Backlog, Desktop Improvements, UI-Standardization, Design

Mon, Jun 6

Jack_who_built_the_house closed T286232: i18n messages use [[c:]] prefix for links, not supported on external MediaWiki installations as Resolved.
Mon, Jun 6, 12:43 AM · Convenient-Discussions
Jack_who_built_the_house added a comment to T286232: i18n messages use [[c:]] prefix for links, not supported on external MediaWiki installations.

Thanks, fixed in https://github.com/jwbth/convenient-discussions/commit/bd2e64c9bd6f14d6efce4743cc928f9bb9800e10, will be online soon.

Mon, Jun 6, 12:43 AM · Convenient-Discussions
Jack_who_built_the_house moved T286232: i18n messages use [[c:]] prefix for links, not supported on external MediaWiki installations from Backlog to i18n on the Convenient-Discussions board.
Mon, Jun 6, 12:36 AM · Convenient-Discussions
Jack_who_built_the_house closed T277833: Duplicate protocol in links if $wgServer specifies a protocol as Resolved.

Convenient Discussions should probably check whether $wgServer is a protocol-relative or a protocol-absolute URL, and prepend "https:" accordingly.

This is currently done in https://github.com/jwbth/convenient-discussions/blob/1c4beeefd9f97f1ec6b1fbd00b918966eeca7f44/src/js/app.js#L299.

Mon, Jun 6, 12:32 AM · Convenient-Discussions
Jack_who_built_the_house moved T301261: "Edit opening comment" command is harming wiki-table from Backlog to Bugs on the Convenient-Discussions board.
Mon, Jun 6, 12:23 AM · Convenient-Discussions

Sun, Jun 5

Jack_who_built_the_house added a comment to T305673: [[Wikimedia:Convenient-discussions-thread-expand-tooltip/en]]: "Ctrl" key not available on Macs.

If I understood you correctly, you talk about how the actual script behaves? Unfortunately, I didn't have time to update the script; plan to do it soon though.

Sun, Jun 5, 1:35 AM · Convenient-Discussions
Jack_who_built_the_house closed T306289: CD acts abnormal when drag'n'drop strings that end with colon into a pair of tags as Invalid.

@NguoiDungKhongDinhDanh This seems to be a Chrome bug. Works even on google.com. Good catch; wrong place though 😄

Sun, Jun 5, 1:24 AM · Convenient-Discussions
Jack_who_built_the_house added a comment to T300389: On replying: Uncaught TypeError: startMarker is null.

Thanks for the report. This is the result of the conflict with DiscussionTools. You may disable it in the preferences to get rid of this error. In case you want to continue to use them together, this error will be fixed in the next release.

Sun, Jun 5, 12:17 AM · Convenient-Discussions

Sat, Jun 4

Jack_who_built_the_house added a comment to T301261: "Edit opening comment" command is harming wiki-table.

Right, CD's comment editing capability incorrectly handled tables

  1. having ! markup,
  2. having a signature inside (which means the table markup is clipped at the location of the signature).

Thanks, will be fixed in the next release.

Sat, Jun 4, 11:55 PM · Convenient-Discussions

May 29 2022

Jack_who_built_the_house merged T307631: client-side CSS appears to be using LESS syntax, which breaks in web browsers into T300437: Quiet default buttons have invalid hover styles.
May 29 2022, 1:30 AM · Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board), Codex
Jack_who_built_the_house merged task T307631: client-side CSS appears to be using LESS syntax, which breaks in web browsers into T300437: Quiet default buttons have invalid hover styles.
May 29 2022, 1:30 AM · CSS, OOUI

May 26 2022

Jack_who_built_the_house updated the task description for T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 26 2022, 7:45 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements
Jack_who_built_the_house updated the task description for T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 26 2022, 7:45 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements
Iniquity awarded T308688: Ctrl+click doesn't always open a new tab when selecting a language a Burninate token.
May 26 2022, 2:22 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements

May 18 2022

Jack_who_built_the_house updated the task description for T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 18 2022, 4:34 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements
Jack_who_built_the_house updated the task description for T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 18 2022, 4:34 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements
Jack_who_built_the_house updated the task description for T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 18 2022, 4:28 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements
Jack_who_built_the_house created T308688: Ctrl+click doesn't always open a new tab when selecting a language.
May 18 2022, 4:27 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Language-Team (Language-2022-April-June), Design, UniversalLanguageSelector, Desktop Improvements

May 6 2022

Jack_who_built_the_house added a comment to T307771: Remove custom gradients from new vector sidebar.

Right, the center-to-sides gradient (left over from the times when the menu looked like this) doesn't make sense in old Vector as well.

May 6 2022, 12:19 PM · Readers-Web-Backlog, Desktop Improvements, UI-Standardization, Design

Mar 8 2022

Jack_who_built_the_house committed rMGCD5b2f2eb09ada: Don't show topic subscription feature notice second time (authored by Jack_who_built_the_house).
Don't show topic subscription feature notice second time
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD7589db3864b3: Add JSDoc (authored by Jack_who_built_the_house).
Add JSDoc
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD761549aa09b3: Apply minor improvements (authored by Jack_who_built_the_house).
Apply minor improvements
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD7dfade3b178c: Fix console error due to conflict with enabled-by-default DT (authored by Jack_who_built_the_house).
Fix console error due to conflict with enabled-by-default DT
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCDd00ae55ca037: Provide compatibility with new Vector and its sticky header (authored by Jack_who_built_the_house).
Provide compatibility with new Vector and its sticky header
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCDf63a92140ebc: Fix skin issues after new Vector is renamed to vector-2022 (authored by Jack_who_built_the_house).
Fix skin issues after new Vector is renamed to vector-2022
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD7f0a03e056bc: Add Vietnamese language (authored by Jack_who_built_the_house).
Add Vietnamese language
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD89e7c27505b4: Wrap Intl.DateTimeFormat() into try...catch (authored by Jack_who_built_the_house).
Wrap Intl.DateTimeFormat() into try...catch
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCDeb9c46c4b887: Merge branch 'master' of https://github.com/jwbth/convenient-discussions (authored by Jack_who_built_the_house).
Merge branch 'master' of https://github.com/jwbth/convenient-discussions
Mar 8 2022, 2:19 AM
Jack_who_built_the_house committed rMGCD2afe371075a3: Merge branch 'master' of https://github.com/jwbth/convenient-discussions (authored by Jack_who_built_the_house).
Merge branch 'master' of https://github.com/jwbth/convenient-discussions
Mar 8 2022, 2:19 AM

Jan 20 2022

Jack_who_built_the_house added a comment to T259864: Enable Reply Tool to adapt to indentation syntax used at ru.wiki.

If this is too complex at this stage of development, and if the accessibility concern is considered valid (although it may need additional research, and if accessibility really is to be taken seriously, much would need to be rethough), I could suggest falling back to : intentation if the comment has more than one line, as starting each line with * is IMHO much more misleading and potentially annoying than choosing : indentation for a whole comment, since it violates the principle "bullets denote comments". (As a side note, this doesn't affect CD users as they see thread lines on the side of comments, not bullets or plain indentation, see example.)

Jan 20 2022, 12:00 AM · Editing-team, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review, Goal, DiscussionTools

Jan 19 2022

Jack_who_built_the_house added a comment to T259864: Enable Reply Tool to adapt to indentation syntax used at ru.wiki.

Accessibility is actually one reason why some of RuWP users argue for using *, not :, as well, since : are description lists that necessitate the use of <dt> (; in the wiki markup). I haven't conducted research on how <ul>s (*) and <dl>s are actually treated by screen readers and such, and that information is welcome.

Jan 19 2022, 11:40 PM · Editing-team, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review, Goal, DiscussionTools
Jack_who_built_the_house added a comment to T259864: Enable Reply Tool to adapt to indentation syntax used at ru.wiki.

Thanks for implementing this change. The implementation is faulty though. Perhaps I should have mentioned this earlier, but it didn't came to my mind and you didn't ask.

Jan 19 2022, 10:43 PM · Editing-team, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review, Goal, DiscussionTools

Jan 17 2022

Jack_who_built_the_house added a comment to T29766: Allow loading gadget module by URL query parameter.

In any event, making the withgadget feature opt-in is trivial with a boolean option. Something like [allow-impromptu] or [anywhere=allowed], with the documentation mentioning that the option allows the gadget to load by permalink even on accounts that have not chosen to enable it.

Note the patch suggested by @Ammarpad: https://gerrit.wikimedia.org/r/752995.

Jan 17 2022, 5:04 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, Security-Team, MediaWiki-extensions-Gadgets
Jack_who_built_the_house added a comment to T298909: Verify Reply Tool and Convenient Discussions work well together.

Potentially fragile, but if you get in before DT actually does its initialization then you can disable a lot of it by changing the properties on mw.config.get( 'wgDiscussionToolsFeaturesEnabled' ). e.g. mw.config.get( 'wgDiscussionToolsFeaturesEnabled' ).newtopictool = false will stop us from hooking the relevant new-section links in the first place...

Thanks, I'll check it out.

Jan 17 2022, 11:25 AM · Goal, Patch-For-Review, Convenient-Discussions, Editing-team (FY2021-22 Kanban Board), Russian-Sites, DiscussionTools

Jan 12 2022

Jack_who_built_the_house added a comment to T298996: VisualEditor should load gadgets configured for action=edit.

Note that VisualEditor has a plugin interface, which is based on loading RL modules that are listed in mw.libs.ve.targetLoader.addPlugin, or wgVisualEditorPluginModules, or queued via mw.hook( 've.loadModules' ). If a gadget is using this today, then presumably it is already working as intended.

Thanks for sharing this. There was a race condition in the code previously suggested by the docs (or at least this ended up in RuWP's Common.js):

mw.loader.using( 'ext.visualEditor.desktopArticleTarget.init' ).then( function () {
  mw.libs.ve.addPlugin( function () {
    return mw.loader.using( 'ext.gadget.gadgetName' );
  } );
} );

– this had resulted in tools sometimes being loaded, sometimes not when the user opened &action=edit or &veaction=editsource directly instead of clicking "Edit source" on the article page. With the updated code, all gadgets and even user scripts I checked get loaded in time to add their button.

Jan 12 2022, 9:50 PM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki
Jack_who_built_the_house added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

Every useful gadget may be called from an external wiki. In this case, no Gadgets-definition is present, and there is no official support for cross-wiki usage of gadgets via URL yet.

Wouldn't URLs like https://en.wikipedia.org/w/load.php?modules=ext.gadget.Navigation_popups work cross-wiki? (Although I agree, forbidding certain action=raw URLs seems a little extreme.)

Jan 12 2022, 7:54 AM · Patch-For-Review, MediaWiki-extensions-Gadgets
Jack_who_built_the_house added a comment to T259864: Enable Reply Tool to adapt to indentation syntax used at ru.wiki.

I started looking into matching your implementation of indentationCharMode: 'mimic', but then I realized that Russian Wikipedia uses the 'unify' mode, which already matches the behavior of DiscussionTools, as far as I can tell. Am I missing something?

No, that's correct. I just thought you came to a conclusion that mimicking the comment being replied to is better than simple unify from the perspective of the junior-senior contributor dynamic and wanted to clarify the meaning of mimic in CD :-)

Jan 12 2022, 7:30 AM · Editing-team, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review, Goal, DiscussionTools

Jan 11 2022

Jack_who_built_the_house added a comment to T259864: Enable Reply Tool to adapt to indentation syntax used at ru.wiki.

In a meeting the Editing Team had on 15-Dec-2021, we came to think a good first step (see "Thinking" below) would be to implement an approach similar to the mimic mode @Jack_who_built_the_house described in T259864#6931828.

Doing the above would mean all new comments people people using the Reply Tool at ru.wiki would be indented using * EXCEPT in cases where the comment being responded to was indented with an :. In this latter case, the Reply Tool would indent the comment being posted with a colon.

Just want to note that the current behavior of CD's mimic mode is to repeat the indentation of the previous comment when posting a comment at the first level (i.e., replying to a topic), not the indentation of the comment being responded to when replying to a reply. The broad idea behind that is:

  • There can be different indentation styles on the same wiki. For example, you can often see topics at EnWP's Village pump where people use * indentation despite that in most other places, : is the convention.
  • On default settings, at least for the first level comments, the tool should work as users expect on the wiki. So, mimicking the style already used is the safest way.
Jan 11 2022, 9:57 AM · Editing-team, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Patch-For-Review, Goal, DiscussionTools
Jack_who_built_the_house added a comment to T298909: Verify Reply Tool and Convenient Discussions work well together.

Right, CD currently displays a warning notification and offers a link to disable (that performs an option API request), although when Reply Tool gets enabled in Russian Wikipedia by default, I expect a lot of confusion among users about what is DiscussionTools and why they need to disable it, so I was thinking about automatically disabling it on the part of CD and displaying a notification about that.

Jan 11 2022, 8:43 AM · Goal, Patch-For-Review, Convenient-Discussions, Editing-team (FY2021-22 Kanban Board), Russian-Sites, DiscussionTools

Jan 8 2022

Jack_who_built_the_house added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

As per template gadgets, it may be useful a magic word or TemplateStyles-like extension that loads a specific gadget on the page, rather than defining the list of pages/templates it should be loaded on the gadget definition. However, for security, those gadgets should probably be explicitly marked as "safe to be included in pages" in the gadget definition.

A list of pages/templates as a condition seems like a bad idea to me, I explained why. A more reasonable choice is a category that can be hidden. Hard to say whether a magic word/tag or an explicit option in gadgets definition is better. But not all gadgets that should load based on category could be described as "template gadgets". Both English Wikipedia and Russian Wikipedia currently have a universally loaded code for a BLP notice for pages with "Living people" and "Possibly living people" categories. In Russian Wikipedia, these categories are added by templates, but in English Wikipedia, they are placed in every article. So, a magic word will not work in that case.

Jan 8 2022, 11:46 AM · Patch-For-Review, MediaWiki-extensions-Gadgets
Jack_who_built_the_house added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

Until all of this gets ever implemented, it may be a good idea to split those gadgets into 2: Move all the gadget contents and dependencies to a new hidden gadget, and leave on the primary gadget only the logic for activation, and a call to mw.loader.load() that loads the hidden gadget. This would reduce the length of JavaScript code that gets loaded on all pages that don't make use of these. The drawback would be it takes more time to load (probably not critical for most gadgets).

We did exactly that (except that we didn't split each gadget – just included the conditioning code in Common.js) for default gadgets for actions, special pages and namespaces and now, as actions is introduced in Gadgets-definition, starting to remove this code. Hopefully the same happens for special pages soon. Namespaces could be less urgent/relevant.

Jan 8 2022, 11:18 AM · Patch-For-Review, MediaWiki-extensions-Gadgets
Jack_who_built_the_house updated subscribers of T204201: Extend MediaWiki:Gadgets-definition capabilities.

I currently think, after page actions as conditions have been implemented, the next conditioning capabilities worthy of implementation can be special pages and categories. For example, in Russian Wikipedia:

  • We have as many as 7 default gadgets for special pages.
  • We also have a significant number of scripts/gadgets that run depending on the content of the page (generally, inside templates). I see "Transcluded page" is mentioned in the task as a separate condition, but I suspect a (most likely, hidden) category would serve better as a selector. Not too specific; template moves wouldn't affect gadgets; multiple templates can contain the same category.
Jan 8 2022, 4:16 AM · Patch-For-Review, MediaWiki-extensions-Gadgets

Jan 7 2022

Jack_who_built_the_house committed rMGCD434056bd09e1: Fix page navigation position in new Vector in RTL wikis (authored by Jack_who_built_the_house).
Fix page navigation position in new Vector in RTL wikis
Jan 7 2022, 12:02 PM
Jack_who_built_the_house committed rMGCD64b3584ed7e1: Add Vietnamese language (authored by Jack_who_built_the_house).
Add Vietnamese language
Jan 7 2022, 9:06 AM
Jack_who_built_the_house committed rMGCD2c5be514f52f: Provide compatibility with new Vector and its sticky header (authored by Jack_who_built_the_house).
Provide compatibility with new Vector and its sticky header
Jan 7 2022, 6:25 AM

Dec 30 2021

Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.
In T298359#7591899, @Majavah wrote:

the current optimization on most logos is performed using this script. I tested them on this image which produced about 25% savings on the raw file size.

Thank you for showing where to look. So, it's basically zopflipng that worked in this case.

npm install --global zopflipng-bin
zopflipng --lossy_transparent -m Wikipedia-logo-v4-ru-xmas_135px.png --prefix="optimized-"

I too got a 25% (well, 24%) smaller version, and I don't see any visible quality loss (don't look at the previews, click – Phabricator applies its own compression to previews):

OriginalResult
Wikipedia-logo-v4-ru-xmas_135px.png (155×135 px, 36 KB)
optimized-Wikipedia-logo-v4-ru-xmas_135px.png (155×135 px, 27 KB)
Dec 30 2021, 11:26 PM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.

the CSS gadget in ruwiki exists not as an initiative of the interface administrators, but as a will of the community, part of which wants an easy way to opt-out all logo changes

By the way, could there be a technical way to have logos be changed by request and still keep a way to opt out of changes? This way, the gadget could still work. Something like this:

<a class="mw-wiki-logo mw-wiki-logo-temporary" data-original-logo="//ru.wikipedia.org/static/images/project-logos/ruwiki.png"></a>

Then there should be a way to specify in the config that some logo is temporary (if there isn't already).

Dec 30 2021, 6:39 PM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.
In T298359#7591702, @Majavah wrote:

Yes. To clarify, this is a sysadmin-imposed policy that all interface administrators are expected to follow.

Thanks for informing. But there is a problem – the CSS gadget in ruwiki exists not as an initiative of the interface administrators, but as a will of the community, part of which wants an easy way to opt out of all logo changes. Interface administrators also can't override community decisions. Obviously, interface administrators (and me personally) could initiate a discussion where we could describe the official guideline, but it's not 100% that this discussion ends with its adoption.

Dec 30 2021, 5:19 PM · Logos, Timeless
Jack_who_built_the_house added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

Now that this lucky day is near (great credit to SD0001), I want to remind that, with this patch, MediaWiki makes a small step to reduce the attack surface involving Interface admins. After data is moved to .json that is bundled with the gadget, people who hold this flag solely due to a need to edit some data stored in JS will no longer need it and can have their permissions revoked with no worries.

Dec 30 2021, 3:53 AM · User-notice, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Performance-Team, MediaWiki-extensions-Gadgets, MediaWiki-ResourceLoader

Dec 29 2021

Jack_who_built_the_house updated the task description for T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 4:33 PM · Logos, Timeless
Jack_who_built_the_house updated the task description for T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 4:31 PM · Logos, Timeless
Jack_who_built_the_house renamed T298359: Timeless skin should better use the same layout for logo as other skins from Timeless skin should use the same layout for logo as other skins to Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 7:31 AM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.

Look, this task wasn't positioned as "Timeless skin doesn't deliver something that is officially supported by MediaWiki". (I'll rename it so that it better conveys this.)

Dec 29 2021, 7:31 AM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.

Yes. See meta which points to T256295: [[meta:Logo#Temporary logo variants]] should not advertise local CSS overwriting. (I found a couple places on MediaWiki wiki that still advertise this.)

Thanks. The guide for changing a logo is also helpful (which answers my first question – a good timing is probably achievable). But I'm not sure if the community would consider the reason mentioned there (traffic increase) as enough to give up the convenience of disabling the logo (although I know that this could be seen as a manifestation of a bias editors have against readers). The current ruwiki logo size is also quite low, 8KB, so traffic increase is insignificant. And it is cached.

Dec 29 2021, 6:52 AM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.

...I forgot one of the main reasons for the use of gadgets – some users just don't like the logo being changed. So, unless there is a way to have different logos for different users according to their preference, CSS hacks will be used, I believe.

Dec 29 2021, 4:42 AM · Logos, Timeless
Jack_who_built_the_house added a comment to T298359: Timeless skin should better use the same layout for logo as other skins.

@Izno Do you mean a config change should be requested every time a logo is desired to be changed? Is it possible to have a good timing for such logo changes? Also, I know for sure that wikis exist that use custom logos for particular pages. Can you demonstrate how this can be done in a way other than a CSS hack?

Dec 29 2021, 4:25 AM · Logos, Timeless
Jack_who_built_the_house updated the task description for T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 3:59 AM · Logos, Timeless
Jack_who_built_the_house updated the task description for T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 3:46 AM · Logos, Timeless
1234qwer1234qwer4 awarded T298359: Timeless skin should better use the same layout for logo as other skins a Y So Serious token.
Dec 29 2021, 2:55 AM · Logos, Timeless
Jack_who_built_the_house updated the task description for T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 2:55 AM · Logos, Timeless
Jack_who_built_the_house created T298359: Timeless skin should better use the same layout for logo as other skins.
Dec 29 2021, 2:52 AM · Logos, Timeless

Dec 25 2021

Jack_who_built_the_house updated subscribers of T181677: Implement syntax highlight for U+00A0 (no-break space, nbsp).
Dec 25 2021, 4:53 PM · Patch-Needs-Improvement, MediaWiki-extensions-CodeMirror
Jack_who_built_the_house added a comment to T271906: Making non-breaking spaces visible while editing.

If you're talking about the CodeMirror editor, it may be doable (if not done already), and this task would need to be assigned to that project.

Dec 25 2021, 4:47 PM · WikiEditor
Jack_who_built_the_house added a comment to T181677: Implement syntax highlight for U+00A0 (no-break space, nbsp).

This would be extremely helpful for Russian Wikipedia where all &nbsp; are replaced with a symbol by an automatic instrument (Wikificator) that is enabled by default. The lack of such highlighing is the root of many disputes that are easily avoidable. (The most recent is today.)

Dec 25 2021, 4:28 PM · Patch-Needs-Improvement, MediaWiki-extensions-CodeMirror

Dec 7 2021

Jack_who_built_the_house added a comment to T297071: Search query length limit in UI is wrong, short for non-Latin alphabets.

I can also put in 126 4-byte smiley faces (😀😃😄😁😆) or 4-byte CJK characters (丽丸𠄢乁你)

I think you can put 63 of them (tested in Chrome and Firefox), it's just that '😀'.length and '丽'.length returns 2.

Dec 7 2021, 12:55 AM · Discovery-Search, MediaWiki-Search

Dec 6 2021

Jack_who_built_the_house updated the task description for T297071: Search query length limit in UI is wrong, short for non-Latin alphabets.
Dec 6 2021, 4:47 AM · Discovery-Search, MediaWiki-Search
Jack_who_built_the_house updated the task description for T297071: Search query length limit in UI is wrong, short for non-Latin alphabets.
Dec 6 2021, 4:46 AM · Discovery-Search, MediaWiki-Search
Jack_who_built_the_house updated the task description for T297071: Search query length limit in UI is wrong, short for non-Latin alphabets.
Dec 6 2021, 4:45 AM · Discovery-Search, MediaWiki-Search
Jack_who_built_the_house created T297071: Search query length limit in UI is wrong, short for non-Latin alphabets.
Dec 6 2021, 4:32 AM · Discovery-Search, MediaWiki-Search

Dec 4 2021

GKFX awarded T200704: TemplateStyles don't work when the template is inside a link a Like token.
Dec 4 2021, 12:02 AM · MediaWiki-Parser, TemplateStyles

Nov 28 2021

Jack_who_built_the_house committed rMGCD68ead70873a7: Wrap Intl.DateTimeFormat() into try...catch (authored by Jack_who_built_the_house).
Wrap Intl.DateTimeFormat() into try...catch
Nov 28 2021, 3:28 PM

Nov 27 2021

Jack_who_built_the_house added a comment to T207365: URL with % in fragment breaks scripts that use mw.Uri.

DiscussionTools also doesn't work on pages with % in the fragment.

Nov 27 2021, 1:50 PM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), MediaWiki-Interface (active libraries), Wikimedia-production-error, MediaWiki-General, JavaScript

Nov 21 2021

Jack_who_built_the_house added a comment to T296149: After viewing media, "Back" and "Forward" buttons stop working properly.

Thanks.

Nov 21 2021, 8:06 PM · MediaViewer
Jack_who_built_the_house added a comment to T292576: Scroll position is not being preserved when navigating back to the article where image once was opened.

T296149 that I created documented a similar bug except my task was about on-page navigation using the table of contents. But by all appearances they have the same root issue. So, both on-page navigation with "Back" and "Forward" and keeping the scroll position in the case of cross-page navigation are impaired.

Nov 21 2021, 8:05 PM · MediaViewer
Jack_who_built_the_house merged task T296149: After viewing media, "Back" and "Forward" buttons stop working properly into T292576: Scroll position is not being preserved when navigating back to the article where image once was opened.
Nov 21 2021, 7:58 PM · MediaViewer
Jack_who_built_the_house merged T296149: After viewing media, "Back" and "Forward" buttons stop working properly into T292576: Scroll position is not being preserved when navigating back to the article where image once was opened.
Nov 21 2021, 7:58 PM · MediaViewer
Jack_who_built_the_house updated the task description for T296149: After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:57 PM · MediaViewer
Jack_who_built_the_house updated the task description for T296149: After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:56 PM · MediaViewer
Jack_who_built_the_house added a project to T296149: After viewing media, "Back" and "Forward" buttons stop working properly: Readers-Web-Backlog.
Nov 21 2021, 12:55 PM · MediaViewer
Jack_who_built_the_house updated the task description for T296149: After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:51 PM · MediaViewer
Jack_who_built_the_house updated the task description for T296149: After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:48 PM · MediaViewer
Jack_who_built_the_house renamed T296149: After viewing media, "Back" and "Forward" buttons stop working properly from After viewing media, "Back" and "Forward" buttons stopsworking to After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:47 PM · MediaViewer
Jack_who_built_the_house created T296149: After viewing media, "Back" and "Forward" buttons stop working properly.
Nov 21 2021, 12:44 PM · MediaViewer
Jack_who_built_the_house committed rMGCDa4d4f7625585: Extract some submethods in Comment class (authored by Jack_who_built_the_house).
Extract some submethods in Comment class
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD480a328095fa: Make Instant Diffs user script work with CD diff links (authored by Jack_who_built_the_house).
Make Instant Diffs user script work with CD diff links
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCDffc5c7cb86ea: Extract CopyLinkDialog (authored by Jack_who_built_the_house).
Extract CopyLinkDialog
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD0368bb21cbea: Improve subscribe notification when topic subscription is off (authored by Jack_who_built_the_house).
Improve subscribe notification when topic subscription is off
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD7c8cd3207e29: Fix detecting voting sections (authored by Jack_who_built_the_house).
Fix detecting voting sections
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD3cf038e8b078: Rename Comment#isSubscribedTo to subscriptionState (authored by Jack_who_built_the_house).
Rename Comment#isSubscribedTo to subscriptionState
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD623128e548ec: Make comment copy link button into an actual link (authored by Jack_who_built_the_house).
Make comment copy link button into an actual link
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD711759299fc2: Fix finding matches for DT comment IDs (authored by Jack_who_built_the_house).
Fix finding matches for DT comment IDs
Nov 21 2021, 12:08 PM
Jack_who_built_the_house committed rMGCD74755af670f8: Fix JS error in updateChecker~mapComments (authored by Jack_who_built_the_house).
Fix JS error in updateChecker~mapComments
Nov 21 2021, 12:08 PM