Last Visual Change is kind of a shaky metrics for us to use, since it's impacted on when we run banners. Let me talk to @Imarlier so we can setup some sync where also talk about our new dashboards and what we can use there (and why).
@Niedzielski this is currently an active google code in task so I've reverted back to old title/description to avoid confusion there.
I've created T209314 to capture the new concerns and made this a subtask. Trust that's okay with you.
I managed to replicate this on beta cluster on Vector:
Was this replicated on the beta cluster by any chance? I know race conditions are far more likely to occur there.
The bug only exists with tablet. The issue is the paddi ng under reading preferences. Mobile should stay as it is.
No. The padding is different on mobile.
@takidelfin the display is correct on mobile but it should look like this on tablet and desktop (>=720px):
Sat, Nov 10
The border attribute is deprecated in html5 so the fix for this would be to move it into a style/class attribute once this problem has been taken care of.
Thank you @Tgr! :)
Fri, Nov 9
Is there any way to fix this? Because then I can't set padding correctly
A technique that might be worth exploring is adding a bottom border to .ns-special .pre-content e.g. border-bottom: solid 1px transparent;
With this, maybe the margin-top can be added to the element after pre-content ?
Reading up on http://seifi.org/css/understanding-taming-collapsing-margins-in-css.html before your next attempt might give you some context with why this bug is happening!
@pmiazga no rush and patch is incomplete. Estimation and discussion needed. We shouldn't be pulling stuff into sprint without those!
Yup! In terms of the bug fix - you've got the right idea and those screenshots are what we're aiming for, but I've pointed out a few problems on the ticket with other special pages:
There's also a few suggestions there for your 2nd round of implementation! good luck!
^ that. I'm not sure how relevant these slack convos are outside the team but they help us uncover risk and make the team mindful of all the things we are taking on at the same time. I just figured if there's a link understanding the estimate is helpful. Lemme know i appreciate any feedback here even if this is just noise!
Looks like this was an edit gone wrong: https://en.wikipedia.org/w/index.php?title=Jealousy&diff=prev&oldid=867135002
so summary endpoint was behaving as expected by summarising the broken content.
Hey performance team! Just tagging you to request you weigh in on this patchset to add wgWikiID to mw.config as I think that impacts your RL plans. Thanks in advance!
Hey @takidelfin thanks for your first contribution to mobile! Confusingly, the mobile site lives in two repos - MobileFrontend and Minerva. The latter will be needed for this fix!
Thank you @Graham87 for this feeback!