Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (398 w, 2 d)
Availability
Available
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Staff software engineer at WMF

Recent Activity

Yesterday

Jdlrobson added a project to T311319: [Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language": UniversalLanguageSelector.
Sat, Jun 25, 12:27 AM · UniversalLanguageSelector, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Regression, Desktop Improvements
Jdlrobson moved T311319: [Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language" from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Sat, Jun 25, 12:27 AM · UniversalLanguageSelector, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Regression, Desktop Improvements
Jdlrobson triaged T311319: [Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language" as High priority.

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803976 which switched the h3 to a p in legacy Vector. ULS has some JavaScript that overrides this.

Sat, Jun 25, 12:26 AM · UniversalLanguageSelector, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Regression, Desktop Improvements
Jdlrobson added a comment to T303484: Introduce basic grid system to modern Vector.

Lots of small patches and more work to be done. Making this our top priority next week.

Sat, Jun 25, 12:05 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector

Fri, Jun 24

Jdlrobson edited projects for T113101: Images should be responsive in Vector and restrained to a max-size., added: Readers-Web-Backlog; removed Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22).

Moving back to backlog for now due to other priorities.

Fri, Jun 24, 11:55 PM · Readers-Web-Backlog, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Desktop Improvements, Design
Jdlrobson placed T303484: Introduce basic grid system to modern Vector up for grabs.
Fri, Jun 24, 11:55 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector
Jdlrobson triaged T311259: Add collapsible TOC and TOC + sticky header cases to Pixel as Medium priority.
Fri, Jun 24, 11:38 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson moved T311259: Add collapsible TOC and TOC + sticky header cases to Pixel from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Fri, Jun 24, 11:38 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson edited projects for T311259: Add collapsible TOC and TOC + sticky header cases to Pixel, added: Readers-Web-Backlog (Kanbanana-FY-2021-22); removed Readers-Web-Backlog (Needs Prioritization (Tech)).
Fri, Jun 24, 11:38 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson updated subscribers of T311275: Overlapping notification icons in Vector 2022 skin.

I don't think so.

Fri, Jun 24, 8:05 PM · Readers-Web-Backlog, Growth-Team, Notifications, I18n, Accessibility
Jdlrobson added a project to T306862: Chinese Language Converter is not working in the sidebar table of the contents in Vector-2022: Content-Transform-Team.

@JMcLeod_WMF this is an issue in the parser so I believe the content transform team are best to fix this. If not please let me know which team we should talk to.

Fri, Jun 24, 8:00 PM · Content-Transform-Team, Readers-Web-Backlog, MediaWiki-Parser, Vector (Vector (Tracking)), Patch-For-Review, MediaWiki-Language-converter, Chinese-Sites
Jdlrobson updated the task description for T310527: Remove Table of Contents feature flag.
Fri, Jun 24, 7:47 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a comment to T306910: Be explicit about Vector's responsive-support (Was Table of contents on mobile devices (not the same as narrow screens)).

We will take a look next week
https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1094833127
In the meantime editors can workaround this by adding a rule to their user CSS (https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust)

Fri, Jun 24, 7:38 PM · MediaWiki-Core-Skin-Architecture, User-notice, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson added a parent task for T113101: Images should be responsive in Vector and restrained to a max-size.: T106463: [EPIC] Ready responsive Vector for wider deployment.
Fri, Jun 24, 6:59 PM · Readers-Web-Backlog, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Desktop Improvements, Design
Jdlrobson added a subtask for T106463: [EPIC] Ready responsive Vector for wider deployment: T113101: Images should be responsive in Vector and restrained to a max-size..
Fri, Jun 24, 6:59 PM · Patch-For-Review, Desktop Improvements, Epic, Vector
Jdlrobson changed the visibility for F35272347: Screen Shot 2022-06-24 at 10.41.40 AM.png.
Fri, Jun 24, 5:46 PM
Jdlrobson changed the visibility for F35272338: Screen Shot 2022-06-24 at 10.40.36 AM.png.
Fri, Jun 24, 5:46 PM
Jdlrobson added a project to T311319: [Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language": Readers-Web-Backlog (Kanbanana-FY-2021-22).
Fri, Jun 24, 5:46 PM · UniversalLanguageSelector, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Regression, Desktop Improvements
Jdlrobson created T311319: [Regression] Legacy Vector languages sidebar label default has changed from "Languages" to "In other language".
Fri, Jun 24, 5:46 PM · UniversalLanguageSelector, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Regression, Desktop Improvements
Jdlrobson added a comment to T311254: On mobile header icons overlap with search bar in responsive mode.

Hoping to fix this for 1.39 release but can't promise that. I've updated documentation to be more clear on the state of this flag: https://www.mediawiki.org/wiki/Skin:Vector/2022#Configuration_parameters

Fri, Jun 24, 5:05 PM · Readers-Web-Backlog, Desktop Improvements
Jdlrobson placed T306628: Consolidate how classes are generated for Menu data in Vector up for grabs.
Fri, Jun 24, 4:49 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Patch-For-Review, Vector
Jdlrobson moved T311283: [regression] Margining collapse applying to Vector heading when title BELOW tabs from Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Fri, Jun 24, 4:44 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson updated subscribers of T311259: Add collapsible TOC and TOC + sticky header cases to Pixel.

@nray was this fixed by https://github.com/nicholasray/pixel/commit/7afcccc17786f680c0d35692a6392028df07c553 ?

Fri, Jun 24, 4:16 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson moved T311294: A small accessibility review of vector changes from Backlog to Vector template improvements on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.
Fri, Jun 24, 4:16 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Accessibility, Vector, Desktop Improvements
Jdlrobson moved T311316: [Tech debt] Consolidate vector-toc-visible and vector-sidebar-container-no-toc from Backlog to Vector template improvements on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.
Fri, Jun 24, 4:16 PM · Technical-Debt, Desktop Improvements, Readers-Web-Backlog (Needs Prioritization (Tech))
Jdlrobson created T311316: [Tech debt] Consolidate vector-toc-visible and vector-sidebar-container-no-toc.
Fri, Jun 24, 4:12 PM · Technical-Debt, Desktop Improvements, Readers-Web-Backlog (Needs Prioritization (Tech))
Jdlrobson moved T306609: Set up feature flag for article tools menu from Doing to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

Looking to merge this sometime next week.

Fri, Jun 24, 3:53 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson moved T311160: Add indicator that appears when TOC has been hidden from Incoming to Table of Contents on the Desktop Improvements board.
Fri, Jun 24, 3:07 PM · Readers-Web-Backlog, Design-Systems-Team, Desktop Improvements
Jdlrobson moved T311178: Fix top spacing for TOC when sticky header not present from Incoming to Table of Contents on the Desktop Improvements board.
Fri, Jun 24, 3:07 PM · Desktop Improvements, Readers-Web-Backlog
Jdlrobson added a project to T311254: On mobile header icons overlap with search bar in responsive mode: Readers-Web-Backlog.
Fri, Jun 24, 3:06 PM · Readers-Web-Backlog, Desktop Improvements
Jdlrobson moved T311281: Watchlist accesskey focuses watchlist button instead of navigating from Incoming to For Iteration on the Desktop Improvements board.
Fri, Jun 24, 3:05 PM · Readers-Web-Backlog, Accessibility, Desktop Improvements
Jdlrobson added a project to T311281: Watchlist accesskey focuses watchlist button instead of navigating: Readers-Web-Backlog.
Fri, Jun 24, 3:05 PM · Readers-Web-Backlog, Accessibility, Desktop Improvements
Jdlrobson renamed T311277: Request: Make search results show descriptions as two lines rather than one line from Vector 2022 skin fails to show second line of text for short descriptions in search proposals to Request: Make search results show descriptions as two lines rather than one line.
Fri, Jun 24, 3:05 PM · Codex, Desktop Improvements
Jdlrobson moved T311277: Request: Make search results show descriptions as two lines rather than one line from Incoming to Requests on the Desktop Improvements board.
Fri, Jun 24, 3:04 PM · Codex, Desktop Improvements
Jdlrobson updated subscribers of T311294: A small accessibility review of vector changes.

Cc @bwang @Jdrewniak

Fri, Jun 24, 3:03 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Accessibility, Vector, Desktop Improvements
Jdlrobson moved T311294: A small accessibility review of vector changes from Incoming to For Iteration on the Desktop Improvements board.
Fri, Jun 24, 3:03 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Accessibility, Vector, Desktop Improvements
Jdlrobson added a project to T311294: A small accessibility review of vector changes: Readers-Web-Backlog (Needs Prioritization (Tech)).
Fri, Jun 24, 3:02 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Accessibility, Vector, Desktop Improvements
Jdlrobson placed T255319: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal up for grabs.
Fri, Jun 24, 2:37 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), good first task, patch-welcome, Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Growth-Team-Filtering, wdwb-tech, Technical-Debt, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Patch-For-Review, WikiLove, MediaWiki-extensions-Push, MediaWiki-extensions-PageSchemas, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-MintyDocs, MassMessage, MediaWiki-extensions-LiquidThreads, StructuredDiscussions, FileAnnotations, Shape Expressions, MediaWiki-extensions-CollaborationKit, MediaWiki-extensions-Cargo, MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-PdfBook, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, VisualEditor, Wikidata, MediaWiki-Interface, Growth-Team, MediaWiki-Core-Skin-Architecture
Jdlrobson moved T255319: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal from Blocked on Others to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Fri, Jun 24, 2:36 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), good first task, patch-welcome, Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Growth-Team-Filtering, wdwb-tech, Technical-Debt, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Patch-For-Review, WikiLove, MediaWiki-extensions-Push, MediaWiki-extensions-PageSchemas, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-MintyDocs, MassMessage, MediaWiki-extensions-LiquidThreads, StructuredDiscussions, FileAnnotations, Shape Expressions, MediaWiki-extensions-CollaborationKit, MediaWiki-extensions-Cargo, MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-PdfBook, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, VisualEditor, Wikidata, MediaWiki-Interface, Growth-Team, MediaWiki-Core-Skin-Architecture
Jdlrobson changed the status of T311092: Sticky header conflicts with Structured Discussions sticky header on board pages from Stalled to Open.

T311170 should be fixed now so you can add the magic class to fix this one 🤞

Fri, Jun 24, 2:35 PM · StructuredDiscussions, Desktop Improvements, Growth-Team
Jdlrobson renamed T311170: [regression] Communities and extensions should be able to mark up elements so they don't overlap the header from [regression] Communities should be able to mark up elements so they don't overlap the header to [regression] Communities and extensions should be able to mark up elements so they don't overlap the header.
Fri, Jun 24, 2:33 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Thu, Jun 23

Jdlrobson closed T310811: Hide non Echo elements from Echo pixel tests as Resolved.

Merged

Thu, Jun 23, 11:54 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Web Team Visual Regression Framework, Vector
Jdlrobson moved T311259: Add collapsible TOC and TOC + sticky header cases to Pixel from Backlog to UI Regression Testing on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.
Thu, Jun 23, 11:54 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson moved T311283: [regression] Margining collapse applying to Vector heading when title BELOW tabs from Needs Analysis to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 11:50 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson edited projects for T311275: Overlapping notification icons in Vector 2022 skin, added: Notifications; removed Vector.
Thu, Jun 23, 11:46 PM · Readers-Web-Backlog, Growth-Team, Notifications, I18n, Accessibility
Jdlrobson renamed T311283: [regression] Margining collapse applying to Vector heading when title BELOW tabs from Margining collapse applying to Vector heading when title BELOW tabs to [regression] Margining collapse applying to Vector heading when title BELOW tabs.
Thu, Jun 23, 11:34 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a project to T311283: [regression] Margining collapse applying to Vector heading when title BELOW tabs: Regression.
Thu, Jun 23, 11:25 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson created T311283: [regression] Margining collapse applying to Vector heading when title BELOW tabs.
Thu, Jun 23, 11:25 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a comment to T282500: [GOAL] Make desktop and mobile site installable on web browsers as progressive web app (PWA) (add to home screen, web app install prompt).

Nice! Thanks for building this! It's cool to have this feature usable without having to install MobileFrontend!
It's also interesting there is an option that you can edit the JSON locally on MediaWiki:default-manifest.json although it would be nice to also define that in LocalSettings.php

Thu, Jun 23, 10:31 PM · MediaWiki-General, Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog, Product-Infrastructure-Team-Backlog, Goal
Jdlrobson added a comment to T311010: Math image alt text is not useful to screenreaders.

This still does not explain why the title is there.

Thu, Jun 23, 10:12 PM · MobileFrontend, Math
Jdlrobson assigned T307903: Change default skin on next set of pilot wikis to Vector (2022) to Edtadros.
Thu, Jun 23, 9:30 PM · Wikimedia-Site-requests, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson added a comment to T311010: Math image alt text is not useful to screenreaders.

In practice, the content of title is shown as a tooltip on the desktop, and as text at the top of a menu that appears after a long-tap on phones and tablets.

Thu, Jun 23, 9:20 PM · MobileFrontend, Math
Jdlrobson renamed T311010: Math image alt text is not useful to screenreaders from Math title is not displayed after being lazy loaded to Math image alt text is not useful to screenreaders.
Thu, Jun 23, 9:20 PM · MobileFrontend, Math
Jdlrobson added a comment to T303320: Design Table component.

Hey @Volker_E many of our articles contain tables, so if we're adding this to Codex I'm curious to hear about how we plan to keep design consistency between tables in articles and tables in Codex-based UIs and whether web team should collaborate with DST team to update those in parallel (I assume we don't want to load two sets of styles - one for Codex and one that's not Codex). We have a shared stylesheet for tables across all skins (except Minerva) that we could expand on: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.tables.less. Might also be a good time to bring Minerva in line and address the community feedback in T287997 that said they liked the table header hover effect.

Thu, Jun 23, 9:01 PM · Design, Codex, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)
Jdlrobson assigned T311144: Enable sticky header A/B test to ovasileva.
Thu, Jun 23, 8:42 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Wikimedia-Site-requests, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
Jdlrobson placed T311144: Enable sticky header A/B test up for grabs.
Thu, Jun 23, 8:41 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Wikimedia-Site-requests, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
Jdlrobson added a comment to T306910: Be explicit about Vector's responsive-support (Was Table of contents on mobile devices (not the same as narrow screens)).

We pushed a change this morning to tweak the viewport based on feedback. We removed the zoom and relaxed the 1200px width to 1000px
I409194accaf5592772fd70ee5b0005ca4199e282
I've documented the learnings in more detail here: https://phabricator.wikimedia.org/phame/post/view/286/should_vector_be_responsive/#4431

Thu, Jun 23, 8:39 PM · MediaWiki-Core-Skin-Architecture, User-notice, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson added a comment to Blog Post: Should Vector be responsive?.

A learning point since I wrote this blog post.

Thu, Jun 23, 8:35 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson closed T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad. as Resolved.

I've had confirmation from 2 people who reported the issue that the issue is fixed.

Thu, Jun 23, 8:33 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Jdlrobson moved T307903: Change default skin on next set of pilot wikis to Vector (2022) from Doing to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 8:31 PM · Wikimedia-Site-requests, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson updated the task description for T310054: Deploy new toolbar order.
Thu, Jun 23, 8:29 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson updated the task description for T310054: Deploy new toolbar order.
Thu, Jun 23, 8:28 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson moved T307903: Change default skin on next set of pilot wikis to Vector (2022) from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 8:18 PM · Wikimedia-Site-requests, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson updated subscribers of T310054: Deploy new toolbar order.

@ppelberg we think deploying this is unblocked. I just wanted to confirm that you are okay with the plan in the task description before I execute it next week?

Thu, Jun 23, 7:25 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson updated the task description for T310054: Deploy new toolbar order.
Thu, Jun 23, 7:19 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson placed T310054: Deploy new toolbar order up for grabs.
Thu, Jun 23, 7:17 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson moved T306609: Set up feature flag for article tools menu from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 6:26 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson moved T303484: Introduce basic grid system to modern Vector from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 6:26 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector
Jdlrobson placed T310033: [Spike] Define questions that we want to ask experts testing modern Vector with screenreader users up for grabs.
Thu, Jun 23, 6:20 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Accessibility, Vector
Jdlrobson moved T310388: Fix collapsed TOC menu position when site notice is present from Upcoming to Needs Analysis on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 6:19 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector
Jdlrobson added a comment to T310388: Fix collapsed TOC menu position when site notice is present.

@bwang The collapsed TOC does yes, however since banners/site notices are sometimes a JS only feature and are rare ie. not shown on every page view all the time using JS could be an acceptable solution here that's worth considered.

Thu, Jun 23, 6:16 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector
Jdlrobson added a comment to T310839: Do not grey out page title when in edit mode (Vector 2022).

Patch got merged 8 minutes ago, so will hopefully be on the beta cluster shortly.

Thu, Jun 23, 6:13 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a project to T311213: Prevent link-dwell pop-up while selecting text: Readers-Web-Backlog.
Thu, Jun 23, 6:12 PM · Readers-Web-Backlog, Page-Previews
Jdlrobson added a project to T311259: Add collapsible TOC and TOC + sticky header cases to Pixel: Readers-Web-Backlog (Needs Prioritization (Tech)).
Thu, Jun 23, 6:12 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Web Team Visual Regression Framework, Vector
Jdlrobson renamed T311254: On mobile header icons overlap with search bar in responsive mode from Bug at Mobile version of new Vector 2022 skin to On mobile header icons overlap with search bar in responsive mode.
Thu, Jun 23, 6:12 PM · Readers-Web-Backlog, Desktop Improvements
Jdlrobson added a comment to T311254: On mobile header icons overlap with search bar in responsive mode.

Do you have $wgVectorResponsive = true in your LocalSettings.php? If so, this is not production ready yet (see T106463).

Thu, Jun 23, 6:11 PM · Readers-Web-Backlog, Desktop Improvements
Jdlrobson added a parent task for T106463: [EPIC] Ready responsive Vector for wider deployment: T311254: On mobile header icons overlap with search bar in responsive mode.
Thu, Jun 23, 6:11 PM · Patch-For-Review, Desktop Improvements, Epic, Vector
Jdlrobson added a subtask for T311254: On mobile header icons overlap with search bar in responsive mode: T106463: [EPIC] Ready responsive Vector for wider deployment.
Thu, Jun 23, 6:11 PM · Readers-Web-Backlog, Desktop Improvements
Jdlrobson assigned T310839: Do not grey out page title when in edit mode (Vector 2022) to alexhollender_WMF.
Thu, Jun 23, 5:59 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson moved T310839: Do not grey out page title when in edit mode (Vector 2022) from Blocked on Others to Design Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 5:59 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a comment to T310388: Fix collapsed TOC menu position when site notice is present.

Banners are also JavaScript so we could do a banner height calculation to change the top calculation on the menu when a banner is present.

Thu, Jun 23, 5:29 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Vector
Jdlrobson renamed T310033: [Spike] Define questions that we want to ask experts testing modern Vector with screenreader users from Test modern Vector with screenreader users to [Spike] Define questions that we want to ask experts testing modern Vector with screenreader users.
Thu, Jun 23, 5:16 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Accessibility, Vector
Jdlrobson assigned T310033: [Spike] Define questions that we want to ask experts testing modern Vector with screenreader users to Jdrewniak.
Thu, Jun 23, 5:15 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Accessibility, Vector
Jdlrobson moved T310033: [Spike] Define questions that we want to ask experts testing modern Vector with screenreader users from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 5:15 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Accessibility, Vector
Jdlrobson moved T306910: Be explicit about Vector's responsive-support (Was Table of contents on mobile devices (not the same as narrow screens)) from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 5:06 PM · MediaWiki-Core-Skin-Architecture, User-notice, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson moved T310839: Do not grey out page title when in edit mode (Vector 2022) from Code Review to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 5:05 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson moved T310839: Do not grey out page title when in edit mode (Vector 2022) from Needs More Work to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Thu, Jun 23, 5:04 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson edited projects for T311258: Access keys showing on hover on beta cluster, added: Reading-Web-Local-Wiki-Issues; removed Readers-Web-Backlog (Kanbanana-FY-2021-22), Regression, Desktop Improvements.

This seems to be intentionally added by @dmaza here: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki%3ACommon.css&type=revision&diff=551070&oldid=548211

Thu, Jun 23, 4:54 PM · Reading-Web-Local-Wiki-Issues
Jdlrobson added a project to T311258: Access keys showing on hover on beta cluster: Readers-Web-Backlog (Kanbanana-FY-2021-22).
Thu, Jun 23, 4:50 PM · Reading-Web-Local-Wiki-Issues
Jdlrobson lowered the priority of T311258: Access keys showing on hover on beta cluster from Unbreak Now! to Needs Triage.

This feature is not deployed in production anywhere yet so this is not an unbreak now. I can only replicate on beta cluster but not with safe mode ( https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?safemode=1). Will look into the gadget shortly.

Thu, Jun 23, 4:50 PM · Reading-Web-Local-Wiki-Issues
Jdlrobson added a comment to T310197: Move editing toolbar below page toolbar.

Thank you!

Thu, Jun 23, 4:30 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a comment to T310197: Move editing toolbar below page toolbar.

The data attribute should use the protected data-mw prefix as that will prevent it from being generated by user content.

Thu, Jun 23, 2:52 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdlrobson added a comment to T308689: Make collapsed ToC available when scrolled down the page.

@bwang @cjming according to a report we're seeing the toggle icon AND the table of contents in the sidebar on certain mobile devices:

image.png (2×1 px, 684 KB)

Could this relate to the max-width/min-width discussion you were having last week?

Thu, Jun 23, 2:41 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdlrobson added a comment to T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..

@Bluehill395 I am also seeing that and that doesn't look expected thanks for pointing that out.
But, that also does not seem related to this particular issue. I'll raise this in T308689 as this feature is new and being actively developed.

Thu, Jun 23, 2:40 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Jdlrobson removed a parent task for T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad.: T308070: 1.39.0-wmf.17 deployment blockers.
Thu, Jun 23, 2:15 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Jdlrobson removed a subtask for T308070: 1.39.0-wmf.17 deployment blockers: T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..
Thu, Jun 23, 2:15 PM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
Jdlrobson added a comment to T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..

We just synced a change that should improve this situation. Note you may need to apply ?action=purge to the URL if you are viewing anonymously.

Thu, Jun 23, 2:15 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Jdlrobson merged T311195: Wikimedia Commons pages appear very, very small on mobile devices in desktop mode into T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..
Thu, Jun 23, 1:03 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Jdlrobson merged task T311195: Wikimedia Commons pages appear very, very small on mobile devices in desktop mode into T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..
Thu, Jun 23, 1:03 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson added a comment to T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..

The above patch gives the following result on iPad which is how it should be (with table of contents):

Screen Shot 2022-06-22 at 8.07.16 PM.png (1×892 px, 827 KB)

Will look to backport that tomorrow.

Thu, Jun 23, 3:13 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector