Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (307 w, 2 d)
Availability
Available
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Fri, Sep 25

Jdlrobson created T263898: Filter out errors with file_url "undefined".
Fri, Sep 25, 10:10 PM · EventStreams
Jdlrobson created T263897: Uncaught TypeError: $.throttle is not a function.
Fri, Sep 25, 10:03 PM · Wikimedia-production-error, Growth-Team, MediaWiki-extensions-GettingStarted
Jdlrobson added a project to T263773: Uncaught TypeError: Cannot read property 'match' of undefined: Readers-Web-Backlog.
Fri, Sep 25, 7:55 PM · Readers-Web-Backlog, MinervaNeue, Wikimedia-production-error
Jdlrobson added a project to T263770: Make PageImages extension compatible with Parsoid : Readers-Web-Backlog.

Please contact Jazmin or Olga to set expectations and ensure this work gets scheduled. This extension is currently going through a code stewardship review so is unlikely to get worked on by us otherwise.

Fri, Sep 25, 7:54 PM · Readers-Web-Backlog, Product-Infrastructure-Team-Backlog, PageImages, Parsoid-Rendering, Parsoid
Jdlrobson added a project to T263772: Make RelatedArticles extension compatible with Parsoid : Readers-Web-Backlog.

Please contact Jazmin or Olga to set expectations and ensure this work gets scheduled. This extension is currently going through a code stewardship review so is unlikely to get worked on otherwise.

Fri, Sep 25, 7:53 PM · Readers-Web-Backlog, Product-Infrastructure-Team-Backlog, RelatedArticles, Parsoid-Rendering, Parsoid
Jdlrobson closed T263824: Disable annoying auto popup of menu window as Invalid.

The more menu has always worked like this as far as I'm aware and Im not sure what the problem statement is here. Most users do not see this.

Fri, Sep 25, 7:51 PM · Vector
Jdlrobson renamed T263843: Add tests to verify initial collapsing of sections from Add more tests that verifies that sections are rendered as collapsible on server side to Add tests to verify initial collapsing of sections.
Fri, Sep 25, 7:49 PM · Readers-Web-Backlog, Release-Engineering-Team (CI & Testing services), MobileFrontend
Jdlrobson moved T263064: Fix our storybook instances from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Fri, Sep 25, 6:50 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Vector, MobileFrontend, MinervaNeue, Page-Previews, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson moved T263832: Major performance regression on mobile site associated with 1.36.0-wmf.10 from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Fri, Sep 25, 6:05 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MobileFrontend, Performance-Team
Jdlrobson assigned T256100: Add skin version and search version fields to search satisfaction schema to Edtadros.
Fri, Sep 25, 5:43 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Vue.js (Vue.js-Search), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
Jdlrobson added a comment to T263832: Major performance regression on mobile site associated with 1.36.0-wmf.10 .

I don't have deploy rights, but I can be around to test if necessary. Peter should be finished for the day.

Fri, Sep 25, 5:02 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MobileFrontend, Performance-Team
Jdlrobson added a project to T263832: Major performance regression on mobile site associated with 1.36.0-wmf.10 : Readers-Web-Backlog (Kanbanana-2020-21-Q1).

The raw HTML contains an onclick handler and has a collapsible-section class on all sections. Without those there will be a reflow as the section collapsing is applied. The onclick handler accounts for slow connections and connections where JS doesn't fully load. I can confirm our refactors removed those (accidentally) and that the above patch fixes this.

Fri, Sep 25, 3:39 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), MobileFrontend, Performance-Team

Thu, Sep 24

Jdlrobson moved T248493: Lead paragraph transform does not apply in edit preview mode from Doing to Ready for Development on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 7:04 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), patch-welcome, Editing-team (Tracking), MobileFrontend
Jdlrobson moved T255604: Design spec for updated language switching experience from Doing to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 7:04 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
Jdlrobson moved T261334: Use `rem` in modern Vector from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 7:04 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements, Vector
Jdlrobson moved T261334: Use `rem` in modern Vector from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 7:04 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements, Vector
Jdlrobson moved T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Thu, Sep 24, 7:02 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson updated the task description for T253938: Future proof addPortletLink and work towards a standard mw-portlet class for all menus across all skins.
Thu, Sep 24, 6:58 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), MediaWiki-Core-Skin-Architecture, Timeless, Vector
Jdlrobson updated the task description for T253938: Future proof addPortletLink and work towards a standard mw-portlet class for all menus across all skins.
Thu, Sep 24, 6:58 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), MediaWiki-Core-Skin-Architecture, Timeless, Vector
Jdlrobson triaged T262993: UploadWizard should validate bad user input inputted for location (Invalid LatLng object) as High priority.
Thu, Sep 24, 6:09 PM · Maps, JavaScript, Wikimedia-production-error, UploadWizard
Jdlrobson closed T214880: [Bug] On Firefox mobile editor textarea should auto-expand as Resolved.

Confirmed.

Thu, Sep 24, 5:10 PM · Editing-team (FY2020-21 Kanban Board), Editing QA, Readers-Web-Backlog (Tracking), MobileFrontend
Jdlrobson moved T263773: Uncaught TypeError: Cannot read property 'match' of undefined from Untriaged to Old on the Wikimedia-production-error board.
Thu, Sep 24, 4:46 PM · Readers-Web-Backlog, MinervaNeue, Wikimedia-production-error
Jdlrobson created T263773: Uncaught TypeError: Cannot read property 'match' of undefined.
Thu, Sep 24, 4:45 PM · Readers-Web-Backlog, MinervaNeue, Wikimedia-production-error
Jdlrobson triaged T262729: Allow skin developers access to URIs in SkinMustache as Medium priority.
Thu, Sep 24, 3:20 PM · patch-welcome, MediaWiki-Core-Skin-Architecture
Jdlrobson added a comment to T262729: Allow skin developers access to URIs in SkinMustache .

this would be helpful in the new ContentTranslation skin: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/627982

Thu, Sep 24, 3:20 PM · patch-welcome, MediaWiki-Core-Skin-Architecture
Jdlrobson renamed T262617: Minerva Selenium test for talk page creation was disabled (Can't call getText on element with selector ".section-heading" because element wasn't found) from Can't call getText on element with selector ".section-heading" because element wasn't found to Minerva Selenium test for talk page creation was disabled (Can't call getText on element with selector ".section-heading" because element wasn't found).
Thu, Sep 24, 3:00 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Readers-Web-Backlog, ci-test-error, MinervaNeue
Jdlrobson closed T255721: Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined) as Resolved.


Clear tail off with group1 wikis after Wednesday deploy.

Thu, Sep 24, 2:55 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), JavaScript, Kaltura player, Wikimedia-production-error
Jdlrobson committed rSEXAMPLE9d37e474e512: Use portlet data from template (authored by Jdlrobson).
Use portlet data from template
Thu, Sep 24, 1:08 PM
Jdlrobson committed rSEXA9d37e474e512: Use portlet data from template (authored by Jdlrobson).
Use portlet data from template
Thu, Sep 24, 1:02 PM
Jdlrobson added a comment to T210865: Improve the language icon.

This came up on hacker news today
https://news.ycombinator.com/item?id=24570424

Thu, Sep 24, 2:48 AM · Wikimedia-Interwiki-links, Readers-Web-Backlog (Design), MobileFrontend
Jdlrobson edited projects for T263711: Upgrade Mustache version from 3.0.1 to 4.01, added: MediaWiki-HTML-Templating; removed MediaWiki-Templates.
Thu, Sep 24, 2:29 AM · MediaWiki-HTML-Templating, Security, Release-Engineering-Team
Jdlrobson created T263711: Upgrade Mustache version from 3.0.1 to 4.01.
Thu, Sep 24, 2:29 AM · MediaWiki-HTML-Templating, Security, Release-Engineering-Team
Jdlrobson added a comment to T262493: Strategy for avoiding or excluding client side errors from gadgets and user scripts.

Earlier today we had 50k errors in 12hrs about 50% of coming that from gadgets which I've had to since fix to get these numbers down. T263688 is another example of something that's becoming a challenge as we roll out further.

Thu, Sep 24, 12:09 AM · EventStreams, MediaWiki-extensions-Gadgets

Wed, Sep 23

Jdlrobson triaged T262703: Uncaught TypeError: e.on is not a function as Medium priority.
Wed, Sep 23, 10:05 PM · Readers-Web-Backlog, JavaScript, Notifications, MobileFrontend, Wikimedia-production-error, Growth-Team
Jdlrobson updated the task description for T246370: 'TypeError: imeLanguageList.forEach is not a function' when editing Commons pages.
Wed, Sep 23, 10:04 PM · JavaScript, Wikimedia-production-error, UniversalLanguageSelector
Jdlrobson removed a project from T263382: Remove ULS extension hacks from Vector and MobileFrontend: Patch-For-Review.
Wed, Sep 23, 9:47 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson created T263688: Work out strategy for MediaWiki:Wikiminiatlas.js - it is generating lots of errors and we have no way to know how to fix them.
Wed, Sep 23, 7:46 PM · Product-Infrastructure-Data
Jdlrobson added a comment to T263382: Remove ULS extension hacks from Vector and MobileFrontend.

Thanks for working on this! We will need patches for Vector and Monobook removing this code to avoid duplicating the menu item.
I think it's fine to ship this to Modern.

Wed, Sep 23, 7:04 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson added a comment to T262617: Minerva Selenium test for talk page creation was disabled (Can't call getText on element with selector ".section-heading" because element wasn't found).

I think we can just disable this test for now. Was hoping it was just a blip. Is there a way to disable a test so it is only disabled on CI?

Wed, Sep 23, 2:41 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Readers-Web-Backlog, ci-test-error, MinervaNeue
Jdlrobson updated the task description for T259313: Deprecate Skin::subPageSubtitle as a public method.
Wed, Sep 23, 4:53 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Editing-Team-Request, Patch-For-Review, CologneBlue, VisualEditor, Nostalgia, MediaWiki-Core-Skin-Architecture

Tue, Sep 22

Jdlrobson created T263600: Unable to get property 'currentTime' of undefined or null reference.
Tue, Sep 22, 11:09 PM · TimedMediaHandler, Wikimedia-production-error
Jdlrobson moved T263599: Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift from Untriaged to Sep 2020 / 1.36.0-wmf.8+ on the Wikimedia-production-error board.
Tue, Sep 22, 11:05 PM · Performance-Team, Wikimedia-production-error, MediaWiki-extensions-NavigationTiming
Jdlrobson created T263599: Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift .
Tue, Sep 22, 11:05 PM · Performance-Team, Wikimedia-production-error, MediaWiki-extensions-NavigationTiming
Jdlrobson added a comment to T262566: Enable DWIM support for Vue.js search.

Thanks for this information @TJones - it's really useful.

Tue, Sep 22, 9:25 PM · Readers-Web-Backlog, Vue.js (Vue.js-Search)
Jdlrobson awarded T258428: TypeError: element is undefined (from OO.ui.mixin.AccessKeyedElement) a Party Time token.
Tue, Sep 22, 9:18 PM · User-Ryasmeen, JavaScript, Wikimedia-production-error, OOUI
Jdlrobson assigned T263064: Fix our storybook instances to Volker_E.
Tue, Sep 22, 5:57 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Vector, MobileFrontend, MinervaNeue, Page-Previews, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson claimed T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis.

Waiting for Olga but I assume I'll be working on this one

Tue, Sep 22, 5:29 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson moved T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Tue, Sep 22, 5:28 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
alexhollender awarded T261153: Chinese Wikipedia’s wordmark and tagline should change based on variant selection a Love token.
Tue, Sep 22, 5:23 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, MediaWiki-Core-Skin-Architecture, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Wikimedia-Site-requests, Chinese-Sites, Desktop Improvements
Jdlrobson moved T260642: Regression: Collapsible forms stopped working on Mobile special page from Needs QA to Needs QA in Prod on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

I think this is fine. Likely an existing problem.

Tue, Sep 22, 5:12 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Advanced Mobile Contributions, Regression, MinervaNeue
Jdlrobson moved T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Tue, Sep 22, 5:09 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, Desktop Improvements, MediaWiki-General, CSS
Jdlrobson renamed T263558: TypeError: cachedParsers[sortList[i][0]] is undefined in multisort (table sorter) from TypeError: cachedParsers[sortList[i][0]] is undefined to TypeError: cachedParsers[sortList[i][0]] is undefined in multisort (table sorter).
Tue, Sep 22, 3:40 PM · MediaWiki-Interface (jQuery-Tablesorter), Wikimedia-production-error
Jdlrobson created T263558: TypeError: cachedParsers[sortList[i][0]] is undefined in multisort (table sorter).
Tue, Sep 22, 3:40 PM · MediaWiki-Interface (jQuery-Tablesorter), Wikimedia-production-error
Jdlrobson triaged T263554: TypeError: event.target.getAttribute is not a function as Medium priority.
Tue, Sep 22, 3:29 PM · MediaWiki-extensions-WikimediaEvents, Wikimedia-production-error, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson created T263554: TypeError: event.target.getAttribute is not a function .
Tue, Sep 22, 3:29 PM · MediaWiki-extensions-WikimediaEvents, Wikimedia-production-error, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson awarded T261784: TypeError: this.selection.isNull is not a function a Y So Serious token.
Tue, Sep 22, 3:02 PM · User-Ryasmeen, JavaScript, VisualEditor, Wikimedia-production-error
Jdlrobson reopened T255617: TypeError: rects is null (from VE FindAndReplaceDialog) as "Open".

This still seems to be occuring and my understanding is that T261522 is in production now?

Tue, Sep 22, 3:42 AM · Editing-team (FY2020-21 Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor
Jdlrobson updated the task description for T255617: TypeError: rects is null (from VE FindAndReplaceDialog).
Tue, Sep 22, 3:42 AM · Editing-team (FY2020-21 Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor
Jdlrobson updated the task description for T263514: Error: Permission denied to access property "parentNode" on PopupWidget mousedown inside PDF .
Tue, Sep 22, 2:13 AM · Editing-team, Structured-Data-Backlog, Structured Data Engineering, MediaWiki-File-management, Commons, Wikimedia-production-error, OOUI
Jdlrobson created T263514: Error: Permission denied to access property "parentNode" on PopupWidget mousedown inside PDF .
Tue, Sep 22, 2:13 AM · Editing-team, Structured-Data-Backlog, Structured Data Engineering, MediaWiki-File-management, Commons, Wikimedia-production-error, OOUI
Jdlrobson triaged T261887: Uncaught TypeError: closestHandle is undefined when using volume controls on TimedMediaHandler video as High priority.

At 107 errors a day this is one of the more common errors in our production code.

Tue, Sep 22, 2:10 AM · JavaScript, Kaltura player, Wikimedia-production-error

Mon, Sep 21

Jdlrobson added a comment to T249944: WikiEditor records all edits as platform = desktop in EventLogging.

The EditAttemptSchema hardcodes phone for the mobile editor - https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/774c791467ab457c1d41c7328f0240d7e22aa2e6/src/mobile.init/eventLogging/schemaEditAttemptStep.js#38 - until recently that was logging desktop Minerva edit's as 'phone'. I'm not sure how VisualEditor does it, but I imagine it also relies on mobile/desktop domain to determine platform value.

Mon, Sep 21, 11:50 PM · Editing-team (FY2020-21 Kanban Board), Analytics-Radar, Product-Analytics, Mobile, Analytics-Data-Quality, Analytics-EventLogging, WikiEditor
Jdlrobson moved T262947: Uncaught TypeError: Cannot read property 'addClass' of undefined from To sort to In progress on the TimedMediaHandler board.
Mon, Sep 21, 11:36 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), JavaScript, Wikimedia-production-error, TimedMediaHandler
Jdlrobson awarded T263382: Remove ULS extension hacks from Vector and MobileFrontend a Like token.
Mon, Sep 21, 10:26 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson added a comment to T263382: Remove ULS extension hacks from Vector and MobileFrontend.

^ see above comment

Mon, Sep 21, 10:21 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson added a comment to T249944: WikiEditor records all edits as platform = desktop in EventLogging.

Someone is using a phone or tablet to edit with the Wikitext editor on the desktop site (which I do commonly)

Mon, Sep 21, 10:19 PM · Editing-team (FY2020-21 Kanban Board), Analytics-Radar, Product-Analytics, Mobile, Analytics-Data-Quality, Analytics-EventLogging, WikiEditor
Jdlrobson added a comment to T263382: Remove ULS extension hacks from Vector and MobileFrontend.

Sorry my screenshot was confusing. Let me try that again.

Mon, Sep 21, 9:35 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson closed T108877: [EPIC + TRACKING] Adopting recent developments in web standards as Declined.

Not being actively worked on anymore, however see T262936 for progress with push notifications.

Mon, Sep 21, 9:28 PM · Readers-Web-Backlog (Tracking), Epic, Tracking-Neverending
Jdlrobson added a comment to T262952: Story idea for Blog: Diving into Wikipedia's ocean of errors.

That works for me. I'm happy to jump on any editorial/copy-edit fixes this week so let me know!

Mon, Sep 21, 9:21 PM · Technical-blog-posts
Jdlrobson added a comment to T262233: MobileFrontend doesn't work with Vector.

Yes.

Mon, Sep 21, 9:14 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Vector (Vector (Tracking)), MW-1.35-release, MobileFrontend
Jdlrobson added a comment to T263382: Remove ULS extension hacks from Vector and MobileFrontend.
Mon, Sep 21, 9:10 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Jdlrobson moved T262233: MobileFrontend doesn't work with Vector from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 8:46 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Vector (Vector (Tracking)), MW-1.35-release, MobileFrontend
Jdlrobson added a comment to T256086: Deprecate SkinMinervaDefaultModules hook.

It's not possible to remove JS modules in extensions. Extensions can only add. Minerva's hook does allow modification but I think that's an anti-pattern as it creates unnecessary fragmentation in the code that runs on Minerva.

Mon, Sep 21, 8:41 PM · VisualEditor, StructuredDiscussions, ProofreadPage, MinervaNeue (Tracking), Growth-Team, MediaWiki-Core-Skin-Architecture
Jdlrobson closed T257995: Deprecate Skin::makeVariablesScript as Resolved.
Mon, Sep 21, 8:32 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Platform Team Workboards (Clinic Duty Team), MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
Jdlrobson moved T261153: Chinese Wikipedia’s wordmark and tagline should change based on variant selection from Blocked on Others to Needs QA on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

This should be fixed now on the beta cluster. The variants https://zh.wikipedia.beta.wmflabs.org/zh-hk/Main_Page and https://zh.wikipedia.beta.wmflabs.org/zh-sg/Main_Page for example show different logos.

Mon, Sep 21, 8:12 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, MediaWiki-Core-Skin-Architecture, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Wikimedia-Site-requests, Chinese-Sites, Desktop Improvements
Jdlrobson moved T261153: Chinese Wikipedia’s wordmark and tagline should change based on variant selection from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 7:02 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, MediaWiki-Core-Skin-Architecture, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Wikimedia-Site-requests, Chinese-Sites, Desktop Improvements
Jdlrobson moved T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 7:01 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Spike
Jdlrobson moved T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis from Upcoming to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 7:01 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson moved T257247: Prototype a custom logo treatment in new vector from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.

These are all pretty easy, as they decorate the existing logo rather than replace it entirely.
The most interesting one is this one, which does seem to substitute the globe and this can be achieved by using a pseudo element that overlaps the existing logo:

Mon, Sep 21, 7:01 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
Jdlrobson added a comment to T251664: Disable auto-capitalization on mobile Wiktionary search bar.

Presumably this needs to be done in SkinMustache::buildSearchProps in core, yes as part of the making of html-input

Mon, Sep 21, 6:26 PM · patch-welcome, MinervaNeue (Tracking), Readers-Web-Backlog, Wiktionary
Jdlrobson closed T252467: Notify editors and users to update their Vector gadgets and user scripts/styles on portal CSS selector simplification, a subtask of T66477: Vector: Use semantic HTML5 elements where applicable, as Resolved.
Mon, Sep 21, 6:19 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Readers-Web-Backlog (Kanbanana-2019-20-Q4), Desktop Improvements, Vector, Accessibility
Jdlrobson closed T252467: Notify editors and users to update their Vector gadgets and user scripts/styles on portal CSS selector simplification as Resolved.
Mon, Sep 21, 6:19 PM · CommRel-Specialists-Support (Jul-Sep-2020), Readers-Web-Backlog (Tracking), User-notice, Desktop Improvements, Vector
Jdlrobson updated the task description for T263064: Fix our storybook instances.
Mon, Sep 21, 6:12 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Vector, MobileFrontend, MinervaNeue, Page-Previews, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson moved T263064: Fix our storybook instances from Upcoming to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 6:12 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Vector, MobileFrontend, MinervaNeue, Page-Previews, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson added a comment to T261784: TypeError: this.selection.isNull is not a function.

Is there some guidance we can give the gadget developers? I hadn't noticed the WeaselWords script being involved here. I'm also happy to push a fix to the wiki page if it's a relatively easy one.

Mon, Sep 21, 5:44 PM · User-Ryasmeen, JavaScript, VisualEditor, Wikimedia-production-error
Jdlrobson removed a project from T249826: Feed Vue.js run time errors to error intake system: Spike.

All errors go through the global.error event. if Vue is swallowing these errors

Mon, Sep 21, 5:40 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
Jdlrobson set the point value for T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis to 3.

Possible risks:

  • Rollback will require ops
  • It's not just search in header - it's also DOM changes
  • We're a little concerned 2 weeks won't be enough data.
Mon, Sep 21, 5:23 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)
Jdlrobson moved T262233: MobileFrontend doesn't work with Vector from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 5:11 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Vector (Vector (Tracking)), MW-1.35-release, MobileFrontend
Jdlrobson placed T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class up for grabs.
Mon, Sep 21, 4:29 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, Desktop Improvements, MediaWiki-General, CSS
Jdlrobson moved T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 4:29 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, Desktop Improvements, MediaWiki-General, CSS
Jdlrobson moved T261153: Chinese Wikipedia’s wordmark and tagline should change based on variant selection from Needs More Work to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 4:08 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, MediaWiki-Core-Skin-Architecture, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Wikimedia-Site-requests, Chinese-Sites, Desktop Improvements
Jdlrobson moved T252774: Merge mediawiki.toc.styles styles into ResourceLoaderSkinModule from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 21, 4:08 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Performance-Team (Radar), Technical-Debt
Jdlrobson reassigned T262703: Uncaught TypeError: e.on is not a function from Jdlrobson to ovasileva.
Mon, Sep 21, 4:06 PM · Readers-Web-Backlog, JavaScript, Notifications, MobileFrontend, Wikimedia-production-error, Growth-Team
Jdlrobson committed rSMNBadf982583fbc: Monobook should use opt-in policy for ResourceLoaderSkinModule features (authored by Jdlrobson).
Monobook should use opt-in policy for ResourceLoaderSkinModule features
Mon, Sep 21, 10:09 AM

Sun, Sep 20

Jdlrobson committed rSEXA8eae077b3126: Use data-logos for generation of logo (authored by Jdlrobson).
Use data-logos for generation of logo
Sun, Sep 20, 11:40 AM
Jdlrobson committed rSEXAMPLE8eae077b3126: Use data-logos for generation of logo (authored by Jdlrobson).
Use data-logos for generation of logo
Sun, Sep 20, 11:37 AM

Sat, Sep 19

Jdlrobson added a comment to T263041: OperationError: The operation failed for an operation-specific reason in generateRandomSessionId .

There were 37 errors in last 12hrs from 4 IPs While 4 of those came from Firefox 67 and 52, 33 came from 2 IPs using Firefox 79 a much more modern browser [1]. That said the errors are still low (for now) but I think it's wrong to dismiss this just on age.

Sat, Sep 19, 4:12 PM · JavaScript, Analytics, Analytics-EventLogging, Wikimedia-production-error
Jdlrobson updated subscribers of T263306: MobileFrontend displays second paragraph as first paragraph on dewiki (Moving article lead is broken).
Sat, Sep 19, 3:41 PM · MobileFrontend, Mobile

Fri, Sep 18

Jdlrobson added a comment to T255721: Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined).

This bug was pretty easy to replicate and fix using debugger and breaking and the fix seemed pretty obvious to me.

Fri, Sep 18, 10:01 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), JavaScript, Kaltura player, Wikimedia-production-error
Jdlrobson updated the task description for T255721: Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined).
Fri, Sep 18, 9:53 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), JavaScript, Kaltura player, Wikimedia-production-error