Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (236 w, 2 d)
Availability
Busy Busy until 10:00 PM.
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Today

Jdlrobson updated subscribers of T223824: Hide skin from preferences .
Sun, May 19, 1:34 PM · Patch-For-Review, MediaWiki-Configuration
Jdlrobson created T223824: Hide skin from preferences .
Sun, May 19, 1:27 PM · Patch-For-Review, MediaWiki-Configuration
Jdlrobson closed T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese as Resolved.

Please reopen if the problem still exists :) Thanks for taking care of this!

Sun, May 19, 1:08 PM · Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Language-Team, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Wikidata-Page-Banner, Chinese-Sites
Jdlrobson updated subscribers of T222297: Wiki meets iNaturalist in Prague.
Sun, May 19, 1:05 PM · Wikimedia-Hackathon-2019 (Newcomer friendly), User-Jdlrobson
Jdlrobson added a comment to T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese.

Thanks for checking! Shall we resolve or do we want to wait until this hits production?

Sun, May 19, 1:00 PM · Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Language-Team, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Wikidata-Page-Banner, Chinese-Sites
Jdlrobson added a comment to T222297: Wiki meets iNaturalist in Prague.

I made a fun little and practical app and have used it to fix 2 articles:
https://wikilovesinat.netlify.com

Sun, May 19, 12:58 PM · Wikimedia-Hackathon-2019 (Newcomer friendly), User-Jdlrobson
Jdlrobson awarded T223770: Please create beta zhwikivoyage a Mountain of Wealth token.
Sun, May 19, 8:09 AM · Wikimedia-Hackathon-2019, Patch-For-Review, Beta-Cluster-Infrastructure

Yesterday

Jdlrobson added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

What page is that? Can you open a new task with the URL and project you are seeing it on? Thanks in advance!

Sat, May 18, 6:41 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Jdlrobson added a comment to T222297: Wiki meets iNaturalist in Prague.

API: https://api.inaturalist.org/v1/docs/#!/Taxa/get_taxa_id

Sat, May 18, 12:40 PM · Wikimedia-Hackathon-2019 (Newcomer friendly), User-Jdlrobson
Jdlrobson added a comment to T181108: Reconsider loading icon packs in enableOOUI for optimising critical rendering path.

This came up again today when changing 5 icons on the FlaggedRevisions extension (which pulled in OOjs UI). The critical path CSS on desktop for my local instance has jumped from 13.5kb to 32.7kb (after gzip). Without the icon packs (only oojs-ui-core styles) this drops to 21.3kb. All to render 2 icon (4 of the icons are interchangeable and never show at same time)

Sat, May 18, 11:59 AM · Performance, Readers-Web-Backlog (Tracking), OOUI
Jdlrobson added a comment to T212521: RFC: Let's stop running QUnit unit tests as integration tests.

I looked into using Karma to run tests with the existing MobileFrontend setup for people that want to have test support in real browsers. We need to use Karma 3.1.4 (4 won't work with our current node 6). POC is here: POC: Show how Karma can be used to run node-qunit tests. I don't think it's something that my team would use but it shows that if running unit tests in real browsers is important to you it can be done.

Sat, May 18, 9:45 AM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
Jdlrobson added a comment to T173527: Give users the ability to choose skin for mobile domain in Special:Preferences.

@Geertivp I made two attempts in https://gerrit.wikimedia.org/r/451807 but both got reverted as I did something majorly wrong which broke production. I've not had time to look into the problem and fix it. You're welcome to take a look. Note when that does eventually get fixed this would apply to your account on mobile as well as tablet (although you could create separate accounts to work around that).

Sat, May 18, 8:13 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, MediaWiki-User-preferences, MobileFrontend
Jdlrobson created T223676: Minerva Node.js browser tests failing and not running against commits.
Sat, May 18, 7:55 AM · Patch-For-Review
Jdlrobson added a comment to T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese.

Hey @zhuyifei1999 we should see what we need to do to get a Chinese Wikivoyage up on the beta cluster today: https://zh.wikivoyage.beta.wmflabs.org/
I was hoping we could use Special:Preferences to change the interface language.

Sat, May 18, 7:44 AM · Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Language-Team, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Wikidata-Page-Banner, Chinese-Sites
Jdlrobson added a comment to T223528: Get the images of the National Library of Aruba from the internet archive into OpenRefine (or CSV file).

I reached out to some friends there.
https://gist.github.com/bnewbold/629cf2568a61a9da5f387eec46ee6aa4 should give you some pointers!

Sat, May 18, 5:58 AM · Internet-Archive, Wikimedia-Hackathon-2019 (Newcomer friendly), Wikistorm, Wiki-goes-Caribbean

Fri, May 17

Jdlrobson added a comment to T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese.

You can try testing this out on https://en.wikivoyage.beta.wmflabs.org/?uselang=zh !

Fri, May 17, 7:06 PM · Wikimedia-Hackathon-2019, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Language-Team, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Wikidata-Page-Banner, Chinese-Sites
Jdlrobson created T223649: Remove SVG checks.
Fri, May 17, 5:50 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikimedia-Hackathon-2019, Multimedia, Technical-Debt, MediaWiki-extensions-MultimediaViewer
Jdlrobson merged T223547: Allow a logged-in MediaWiki user to choose for default desktop interface on a tablet into T173527: Give users the ability to choose skin for mobile domain in Special:Preferences.
Fri, May 17, 4:43 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, MediaWiki-User-preferences, MobileFrontend
Jdlrobson merged task T223547: Allow a logged-in MediaWiki user to choose for default desktop interface on a tablet into T173527: Give users the ability to choose skin for mobile domain in Special:Preferences.
Fri, May 17, 4:43 PM · Readers-Web-Backlog, Mobile-Web-Settings, Wikimedia-Hackathon-2019
Jdlrobson renamed T173527: Give users the ability to choose skin for mobile domain in Special:Preferences from Give 3rd party users the ability to choose skin for mobile domain in Special:Preferences to Give users the ability to choose skin for mobile domain in Special:Preferences.
Fri, May 17, 4:42 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, MediaWiki-User-preferences, MobileFrontend
Jdlrobson removed a project from T54165: Links to talk pages in mobile view for all anonymous users: good first bug.
Fri, May 17, 8:03 AM · Readers-Web-Backlog (Design), Community-Wishlist-Survey-2015, WMF-deploy-2015-06-16_(1.26wmf10), MobileFrontend, User-notice, Notice

Thu, May 16

Jdlrobson added a comment to T209295: [EPIC] Enable WebClientError on production.

@phuedx was wondering about the state of this today and whether we can remove the EventLogging code ($wgMinervaErrorLogSamplingRate) given recent developments.

Thu, May 16, 3:21 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
Jdlrobson moved T223204: History page filter revisions cannot be expanded on Minerva skin from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, May 16, 3:17 PM · Patch-For-Review, Readers-Web-Backlog
Jdlrobson assigned T218206: AMC Navigation - make main menu scrollable to pmiazga.

@pmiazga leaving this one with you to determine if more work needed.

Thu, May 16, 3:15 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson merged task T65419: no path to Special:SpecialPages into T214537: [EPIC] AMC Navigation - changes to main menu.
Thu, May 16, 3:14 PM · Readers-Web-Backlog, MobileFrontend
Jdlrobson merged T65419: no path to Special:SpecialPages into T214537: [EPIC] AMC Navigation - changes to main menu.
Thu, May 16, 3:14 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdlrobson added a comment to T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution.

A CSS solution would be great, but I remember we did consider this back in the early days and there were quite a few of edge cases that were considered deal breakers, browser support (its much better now though) and concerns around performance (potentially unfounded) .

Thu, May 16, 2:54 PM · VisualEditor-MediaWiki-Mobile, MobileFrontend, VisualEditor
Jdlrobson changed the status of T64266: MultimediaViewer should not leave so many history entries when closed from Stalled to Open.

@Tgr is also here so hopefully we can grab him too and work out a way forward.

Thu, May 16, 2:48 PM · Wikimedia-Hackathon-2019, Multimedia, Google-Code-in-2014, Design, MediaWiki-extensions-MultimediaViewer
Jdlrobson changed the status of T64266: MultimediaViewer should not leave so many history entries when closed, a subtask of T78224: MediaViewer URL and history issues (tracking), from Stalled to Open.
Thu, May 16, 2:48 PM · Multimedia, Tracking-Neverending, MediaWiki-extensions-MultimediaViewer
Jdlrobson added a comment to T64266: MultimediaViewer should not leave so many history entries when closed.

@simon04 I'll be wearing an internet archive hoodie and wikipedia t-shirt to help me be more findable if you want to look at this together. :)

Thu, May 16, 2:42 PM · Wikimedia-Hackathon-2019, Multimedia, Google-Code-in-2014, Design, MediaWiki-extensions-MultimediaViewer
Jdlrobson added a comment to T64266: MultimediaViewer should not leave so many history entries when closed.

The mobile web site has solved this problem so multimedia viewer just needs to follow the example given by it's code. We use mediawiki.router - making use of it is really not hard. The library needs to be imported and used. The fix is really simple.

Thu, May 16, 8:00 AM · Wikimedia-Hackathon-2019, Multimedia, Google-Code-in-2014, Design, MediaWiki-extensions-MultimediaViewer

Wed, May 15

Jdlrobson moved T217814: Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList. from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

I've made steps for 2 clearer.
For 3 you'll need to create a page located near you on the beta cluster (this will be helpful for future):

  • Find a geolocation near you
  • Create a new article on the beta cluster with wikitext substituting 50 and 14 with your location or something near your location (you don't want to share your house!):
{{Coord|50.0|N|14.4|W|display=title|name=random location}}
  • go make a coffee (might take a few minutes for it to propagate)
Wed, May 15, 8:13 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T217814: Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList..
Wed, May 15, 8:06 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T222437: Regression: SpecialMobileDiff does not display proper text for version link in several Wikipedias since 1.34.0-wmf.3 from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, May 15, 8:02 AM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Regression, Advanced Mobile Contributions, MobileFrontend
Jdlrobson moved T221860: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, May 15, 8:02 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-zeljkofilipin, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Release-Engineering-Team, Browser-Tests, Wikimedia-production-error (Shared Build Failure), MobileFrontend
Jdlrobson created T223363: Cleanup Recent changes presentation on Minerva (mobile).
Wed, May 15, 7:45 AM · Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page

Tue, May 14

Jdlrobson removed a project from T222889: [subtask] Remove remaining 'reset.less': Patch-For-Review.
Tue, May 14, 3:15 PM · Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson updated the task description for T220620: Switch Hogan for Mustache.
Tue, May 14, 2:14 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MobileFrontend (MobileFrontend and MinervaNeue architecture), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdlrobson added a project to T223181: German Infoboxes parsed into TextExtract: Readers-Web-Backlog (Tracking).

To set expectations, TextExtracts is in maintenance mode so this is unlikely to get fixed by reading web team.

Tue, May 14, 1:00 PM · Readers-Web-Backlog (Tracking), TextExtracts
Jdlrobson closed T220620: Switch Hogan for Mustache as Resolved.

Hogan is no more 🦑🦑🦑🐳🎉🎉🎉

Tue, May 14, 12:55 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MobileFrontend (MobileFrontend and MinervaNeue architecture), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdlrobson closed T220620: Switch Hogan for Mustache, a subtask of T94086: [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates, as Resolved.
Tue, May 14, 12:55 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic
Jdlrobson created T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile.
Tue, May 14, 11:25 AM · Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdlrobson created T223230: Enable Recent Changes modules on mobile.
Tue, May 14, 11:20 AM · Patch-For-Review, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdlrobson updated the task description for T223204: History page filter revisions cannot be expanded on Minerva skin.
Tue, May 14, 8:32 AM · Patch-For-Review, Readers-Web-Backlog
Jdlrobson updated the task description for T223204: History page filter revisions cannot be expanded on Minerva skin.
Tue, May 14, 8:23 AM · Patch-For-Review, Readers-Web-Backlog
Jdlrobson created T223204: History page filter revisions cannot be expanded on Minerva skin.
Tue, May 14, 8:16 AM · Patch-For-Review, Readers-Web-Backlog

Fri, May 10

Jdlrobson added a comment to T205341: Split up reset.css rules to specific element selectors only where needed and remove file altogether.

Doh, I missed two things :/



https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/509178 Additional icon resets for button elements fixes those.

Fri, May 10, 2:21 AM · Patch-For-Review, Readers-Web-Backlog, Front-end-Standards-Group, CSS, MinervaNeue

Thu, May 9

Jdlrobson edited projects for T222681: WikidataPageBanner uses a blacklist of skin names to decide 'prebodyhtml' support instead of sane feature detection, added: User-Jdlrobson, Readers-Web-Backlog (Tracking), patch-welcome; removed Readers-Web-Backlog.

Patches welcome. Extension was a GSoc project and right now I'm the only one who reviews patches and patches I submit to the repo don't get code reviewed so I don't submit them myself (and I prefer to avoid self merging if I can). I've been trying to find a maintainer to mentor/code review for, but sadly nothing has come about in that area yet.

Thu, May 9, 6:11 PM · patch-welcome, Readers-Web-Backlog (Tracking), User-Jdlrobson, Technical-Debt, Wikidata-Page-Banner, Wikidata, Timeless
Jdlrobson moved T222877: [subtask] Remove `body` `line-height` from reset.less and ui.less from Needs Analysis to Tracking on the Readers-Web-Backlog board.
Thu, May 9, 5:51 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Front-end-Standards-Group, CSS, MinervaNeue
Jdlrobson moved T222877: [subtask] Remove `body` `line-height` from reset.less and ui.less from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, May 9, 5:50 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, Front-end-Standards-Group, CSS, MinervaNeue
Jdlrobson moved T222881: [subtask] Move list specific rules to 'ui.less'/'lists.less' from To Triage to Tracking on the Readers-Web-Backlog board.
Thu, May 9, 5:50 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, CSS, MinervaNeue
Jdlrobson moved T222889: [subtask] Remove remaining 'reset.less' from To Triage to Tracking on the Readers-Web-Backlog board.
Thu, May 9, 5:50 PM · Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson raised the priority of T220558: Remove cache from ImageGateway from Normal to High.
Thu, May 9, 5:50 PM · Patch-For-Review, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Jdlrobson moved T222517: Flaky failure related to skin Minerva selenium tests from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, May 9, 5:48 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson updated the task description for T222911: Should red links to user pages link to "view" mode rather than "edit" mode?.
Thu, May 9, 5:43 PM · Front-end-Standards-Group, MediaWiki-Parser
Jdlrobson updated the task description for T222911: Should red links to user pages link to "view" mode rather than "edit" mode?.
Thu, May 9, 5:42 PM · Front-end-Standards-Group, MediaWiki-Parser
Jdlrobson renamed T222911: Should red links to user pages link to "view" mode rather than "edit" mode? from Cannot access user contributions/talk when following a red link to a user's page from old page version on mobile to Should red links to user pages link to "view" mode rather than "edit" mode?.
Thu, May 9, 5:37 PM · Front-end-Standards-Group, MediaWiki-Parser
Jdlrobson edited projects for T222911: Should red links to user pages link to "view" mode rather than "edit" mode?, added: MediaWiki-Parser, Front-end-Standards-Group; removed MobileFrontend.

@Cirdan honestly I feel this is a problem with mediawiki core and red link behaviour. It seems to me that user links should always link to view mode rather than action=edit. I guess we'd need to fix this in the MediaWiki parser.

Thu, May 9, 5:37 PM · Front-end-Standards-Group, MediaWiki-Parser

Wed, May 8

Jdlrobson updated the task description for T217814: Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList..
Wed, May 8, 11:41 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson reassigned T217814: Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList. from Jdlrobson to Edtadros.
Wed, May 8, 11:40 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a comment to T191868: OOUI in HTMLForm on Special:Pages – evaluate collapsible main forms.

Volker this is done right?

Wed, May 8, 9:36 PM · User-Jdlrobson, Patch-For-Review, MediaWiki-Special-pages, UI-Standardization, UI-Standardization-Kanban
Jdlrobson reassigned T220620: Switch Hogan for Mustache from alexhollender to Edtadros.

I think the edits to the description in https://phabricator.wikimedia.org/transactions/detail/PHID-XACT-TASK-ccksmfyydwihpcu/ should help with the remaining 2. IM me if not!

Wed, May 8, 6:48 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MobileFrontend (MobileFrontend and MinervaNeue architecture), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdlrobson updated the task description for T220620: Switch Hogan for Mustache.
Wed, May 8, 6:47 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MobileFrontend (MobileFrontend and MinervaNeue architecture), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdlrobson added a comment to T217718: MinveraNeue: Evaluate using MW core shared.css in styles coverage and performance.

The module is 2.9kb of CSS after gzipping. Given the mobile site currently is 7.33kb of critical CSS, this is a large amount of CSS to add. We need to work out which bits of this are actually critical.

Wed, May 8, 6:24 PM · Readers-Web-Backlog, MinervaNeue
Jdlrobson moved T221860: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs from Blocked on Others to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, May 8, 5:10 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-zeljkofilipin, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Release-Engineering-Team, Browser-Tests, Wikimedia-production-error (Shared Build Failure), MobileFrontend
Jdlrobson moved T222517: Flaky failure related to skin Minerva selenium tests from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, May 8, 5:06 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson updated the task description for T220847: BetaOptInPanel should use ES6 classes NOT mfExtend.
Wed, May 8, 4:49 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Jdlrobson updated the task description for T220847: BetaOptInPanel should use ES6 classes NOT mfExtend.
Wed, May 8, 4:49 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Jdlrobson updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:35 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:28 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:26 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Wed, May 8, 4:25 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson updated the task description for T222437: Regression: SpecialMobileDiff does not display proper text for version link in several Wikipedias since 1.34.0-wmf.3.
Wed, May 8, 4:21 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Regression, Advanced Mobile Contributions, MobileFrontend
Jdlrobson updated the task description for T222437: Regression: SpecialMobileDiff does not display proper text for version link in several Wikipedias since 1.34.0-wmf.3.
Wed, May 8, 4:21 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Regression, Advanced Mobile Contributions, MobileFrontend
Jdlrobson updated the task description for T222437: Regression: SpecialMobileDiff does not display proper text for version link in several Wikipedias since 1.34.0-wmf.3.
Wed, May 8, 4:20 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Regression, Advanced Mobile Contributions, MobileFrontend

Tue, May 7

Jdlrobson added a comment to T205341: Split up reset.css rules to specific element selectors only where needed and remove file altogether.

Im not following. The current branch causes UI regressions - small icons and badly styled buttons. These are caused by the reset cleanup that has been merged so far so will have to be fixed before we merge to master and QA. Im keen to merge this too and share your goals but I can't do that while these regressions exist.

Tue, May 7, 11:02 PM · Patch-For-Review, Readers-Web-Backlog, Front-end-Standards-Group, CSS, MinervaNeue
Jdlrobson closed T222475: Minerva Selenium ReferenceDrawer tests failing as Resolved.

Resolved.

Tue, May 7, 8:46 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, MinervaNeue, Technical-Debt
Jdlrobson edited projects for T222604: Kartographer maps with "type": "Feature" and a image in the description is not shown in mobile view, added: Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.

(Web team do not maintain this extension)

Tue, May 7, 8:45 PM · Readers-Web-Backlog (Tracking), Maps (Kartographer), Mobile
Jdlrobson lowered the priority of T222517: Flaky failure related to skin Minerva selenium tests from Unbreak Now! to High.
Tue, May 7, 8:15 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson removed a project from T217629: [subtask] Move `audio` and `video` styles out of 'reset.less': Patch-For-Review.
Tue, May 7, 6:46 PM · Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson removed a project from T217626: [subtask] Move headings specific styles to 'headings.less': Patch-For-Review.
Tue, May 7, 6:45 PM · Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson removed a project from T217622: [subtask] Move form specific selectors to their own LESS file: Patch-For-Review.
Tue, May 7, 6:45 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson removed a project from T217631: [subtask] Remove unnecessary reset text rules: Patch-For-Review.
Tue, May 7, 6:45 PM · Readers-Web-Backlog (Tracking), CSS, MinervaNeue
Jdlrobson removed a project from T205341: Split up reset.css rules to specific element selectors only where needed and remove file altogether: Patch-For-Review.

The comments in T205341#5134218 still stand and will need to be resolved before we can prepare the patch for QA/ merge to master.

Tue, May 7, 6:45 PM · Patch-For-Review, Readers-Web-Backlog, Front-end-Standards-Group, CSS, MinervaNeue
Jdlrobson moved T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 7, 5:28 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdlrobson reassigned T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip from Jdrewniak to Edtadros.
Tue, May 7, 5:28 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdlrobson added a comment to T222394: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist".

The new fixing do fixed some brackets. But, unfortunately, the edit summary, the page size changing and the edit tag should be covered with brackets too.

Tue, May 7, 5:23 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, MediaWiki-Recent-changes, Regression, MinervaNeue
Jdlrobson added a comment to T222517: Flaky failure related to skin Minerva selenium tests.

Hmm, this one is strange. The test that is failing ("Clicking on a watchstar toggles the watchstar") looks like it actually passes as clearly the watch star it is looking for is in the screenshot:

Tue, May 7, 4:18 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson moved T222517: Flaky failure related to skin Minerva selenium tests from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 7, 3:46 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson updated the task description for T222394: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist".
Tue, May 7, 3:46 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, MediaWiki-Recent-changes, Regression, MinervaNeue
Jdlrobson moved T222394: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 7, 3:45 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, MediaWiki-Recent-changes, Regression, MinervaNeue
Jdlrobson moved T221004: Simplify MainMenu building in Minerva skin from To Triage to Triaged but Future on the Readers-Web-Backlog board.
Tue, May 7, 3:44 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdlrobson moved T220848: Remove context.js from Upcoming to Triaged but Future on the Readers-Web-Backlog board.
Tue, May 7, 3:44 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Jdlrobson moved T220848: Remove context.js from To Triage to Upcoming on the Readers-Web-Backlog board.
Tue, May 7, 3:42 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Jdlrobson moved T220849: Separate View code from SearchOverlay from To Triage to Triaged but Future on the Readers-Web-Backlog board.
Tue, May 7, 3:42 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Jdlrobson renamed T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless from Search proposals dropdown in search box not shown on mobile to Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.
Tue, May 7, 3:28 PM · MediaWiki-Interface, jQuery-Client, Mobile, CirrusSearch, Discovery-Search
Jdlrobson claimed T222517: Flaky failure related to skin Minerva selenium tests.
Tue, May 7, 3:27 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson added projects to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless: jQuery-Client, MediaWiki-Interface.

I can replicate in Timeless and Vector but not Minerva on a Samsung galaxy . More than likely a bug in jquery autocomplete which Minerva doesn't use

Tue, May 7, 3:12 PM · MediaWiki-Interface, jQuery-Client, Mobile, CirrusSearch, Discovery-Search
Jdlrobson added a comment to T222517: Flaky failure related to skin Minerva selenium tests.

All the errors Ive seen are related to the mwbot library and token errors. The existing set of selenium tests do not seem to be exercising this library too much so my concern is that these bugs are going to continue as we add new tests due to a problem with using the mwbot library. It seems the methods in https://github.com/wikimedia/mediawiki/blob/135718b90478b94052a2575e60f38406366055e7/tests/selenium/wdio-mediawiki/Api.js were only being used in core before Minerva and MobileFrontend used and other extensions such as Cirrus use mwbot library directly without indirection.

Tue, May 7, 5:11 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue
Jdlrobson edited projects for T222517: Flaky failure related to skin Minerva selenium tests, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Readers-Web-Backlog.
Tue, May 7, 12:11 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue