Tue, Jan 21
Mon, Jan 20
To me it seems easier to read when the background color covers the entire paragraph, rather than leaving white gaps between each line.
The patch above should take care of this.
TIL about being able to overlay visual metrics screenshots (and documented on https://grafana.wikimedia.org/d/000000205/mobile-2g?orgId=1). Really helpful ! thanks @Krinkle
+1 to a center aligned logo!!
Note we don't support the new diff type officially on desktop. That's blocked on T240608.
@alexhollender please can you take a look on http://readingwebstaging.wmflabs.org/wiki/Seoul?useskin=minerva&useformat=mobile and then move this back to code review
Thanks this matches what I see. For completeness @matmarex fixed this when as part of Bug: T232237 he moved the schema into mobile.init. The mobile.init module only ever loads on mobile. It should never run on desktop (see I72799083e31bc6dad5d6e5b2a2437ea5a7300497)
Sat, Jan 18
The above three patches should take care of this problem for the last remaining overlay and then prevent it from every happening again.
Fri, Jan 17
This project is no longer being worked on. The epic T195482: [EPIC] Review and refactor MobileFrontend components used by Minerva more than captures the remaining work here.
At this point if we want we can publish MobileFrontend's library to npm, but I'm not sure if there are any benefits to doing so.
We never answered this in the MobileFrotnend architecture project but seems even more important now as we build out Vector.
This is now resolved. Minerva will work without MobileFrontend 🎉
Is this still an issue in Safari 13?
We are breaking ResourceLoaderSkinModule into chunks that a skin can choose to pick up. A solution for T217616 now exists.
Haven't seen this flake in a long time.
This has nothing to do with mobile or Minerva. The template in the talk page is what's causing the rendering issue. This is precisely why the "read as wiki page" button exists. When clicking it you are risking these sorts of changes. Please fix on wiki.
If this task is still relevant the URI in the description should be updated so we have a frame of reference.
No subtasks exist anymore.
Good to think about as we go into the desktop refresh where there's a hamburger given @Nirzar's suggestion that "The hamburger menu UI pattern is not meant for desktops or tablets"