Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (261 w, 5 d)
Availability
Available
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Yesterday

Jdlrobson moved T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Nov 12, 11:37 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

completely outside of the "mobile user" UX here, if this was contained to mobile most of this discussion wouldn't be ongoing.

Tue, Nov 12, 10:02 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).
Tue, Nov 12, 7:06 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), Performance-Team (Radar), MediaWiki-General
Jdlrobson added a comment to T230657: Thanks extension is not shown on Minerva history page (AMC mode).

Per T230657#5438248 maybe we want to decline this and document the decision?

Tue, Nov 12, 7:01 PM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Design), MinervaNeue, Growth Design, Growth-Team, Thanks, Advanced Mobile Contributions
Jdlrobson reassigned T237230: Long edit summary/titles/user breaking AMC special pages from Edtadros to alexhollender.
Tue, Nov 12, 6:22 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson moved T220627: QuickSurveys EventLogging missing ~10% of interactions from Blocked on Others to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Nov 12, 6:13 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, Analytics-EventLogging, QuickSurveys
Jdlrobson assigned T237677: Regression: Notification Overlay can't be closed via mask to nray.

Nick will take a look

Tue, Nov 12, 6:08 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson assigned T226562: AMC - display labels for toolbar actions on larger screens to Edtadros.
Tue, Nov 12, 6:07 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdlrobson assigned T237230: Long edit summary/titles/user breaking AMC special pages to Edtadros.
Tue, Nov 12, 6:06 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson claimed T218960: Bug: Talk overlay renders for talk sections that do not exist.

I will add some QA steps.

Tue, Nov 12, 6:06 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

And the QA steps 1&2 appear to contradict:

Thanks for pointing this out. The URL was correct but not the link label.

Tue, Nov 12, 2:25 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Tue, Nov 12, 2:22 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes

Mon, Nov 11

Jdlrobson closed T118134: Create an extremely bare-bones RL module, containing basic, simple styles for skins to consume, a subtask of T89981: Split the mediawiki.legacy.shared module into non-legacy manageable parts, as Resolved.
Mon, Nov 11, 9:41 PM · MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MW-1.28-release-notes, MediaWiki-Interface
Jdlrobson closed T118134: Create an extremely bare-bones RL module, containing basic, simple styles for skins to consume as Resolved.

This is now provided. A skin should make use of the ResourceLoaderSkinModule class and define the set of features it wants to include.
We can create specific tasks for pulling out the remaining baggage, but that's for another task :)

Mon, Nov 11, 9:41 PM · MediaWiki-Interface
Jdlrobson closed T114695: Split mediawiki.skinning.interface css files into separate modules as Resolved.

This is now done. The mediawiki.skinning.interface module is now an instance of ResourceLoaderSkinModule::class - any extension or skin (although I heavily recommend the latter) is now able to define it's own module with the ResourceLoaderSkinModule class and pick and choose which "features" it wants to support.

Mon, Nov 11, 9:19 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-Interface
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Mon, Nov 11, 8:52 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a project to T237677: Regression: Notification Overlay can't be closed via mask: Growth-Team.

cc Growth team

Mon, Nov 11, 5:16 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson triaged T237677: Regression: Notification Overlay can't be closed via mask as High priority.
Mon, Nov 11, 5:16 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson raised the priority of T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from Normal to High.
Mon, Nov 11, 5:16 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

I've tested https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/549919 pretty extensively and I'm pretty sure this covers all the edge cases we've highlighted. I've updated the QA steps and have been relying on these to confirm the new patch works as expected - please let me know if any edge cases are missing from those QA steps.

Mon, Nov 11, 5:13 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

@matmarex I can't find where you said this but I noticed your comment (whereever it was!) about semicolon-separator in some cases having an extraneous trailing space. I think having the space in the message is a symptom of bad separation between the presentation and content.

What there is presentation? Japanese and Chinese don't use space after (full-width) semicolon, and French seems to want space also before: https://translatewiki.net/wiki/Special:Translations?message=Semicolon-separator&namespace=8

Mon, Nov 11, 5:12 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Mon, Nov 11, 5:08 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Mon, Nov 11, 5:04 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Mon, Nov 11, 4:41 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes

Sat, Nov 9

Jdlrobson created T237827: Incorrect longitude/latitude handling on anything that is not a city/town etc in summary endpoint.
Sat, Nov 9, 8:03 PM · Product-Infrastructure-Team-Backlog, RESTBase-API, Mobile-Content-Service

Fri, Nov 8

Jdlrobson moved T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

We'll need to run through the QA again once this latest patch has been merged so I've unchecked the boxes in the description.

Fri, Nov 8, 7:37 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 7:36 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 7:35 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

@matmarex I can't where you said this but I noticed your comment about semicolon-separator in some cases having an extraneous trailing space. I think having the space in the message is a symptom of bad separation between the presentation and content.
Special:LinksHere seems to be the only other user of the semicolon-separator. I'd like this page to also use pseudo elements in future, so I think the extraneous space needs to be removed in translations rather than from the CSS. It should not be part of this message.

Fri, Nov 8, 7:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T237712: There is an extra semicolon in every history entry.

@Dvorapa I only see one semicolon on the history page but your bug report suggests there may be more than one per row. Can you confirm that your bug report is identical to T237705 ?

Fri, Nov 8, 7:12 PM · MediaWiki-Page-History, Growth-Team
Jdlrobson added a parent task for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface: T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements.
Fri, Nov 8, 5:38 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a subtask for T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements: T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 5:38 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, UI-Standardization, MediaWiki-Recent-changes, User-Jdlrobson
Jdlrobson merged task T237611: RC: strange format of [sichten] link in recent changes into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 3:30 PM · Wiktionary, Growth-Team, MediaWiki-Recent-changes
Jdlrobson merged T237611: RC: strange format of [sichten] link in recent changes into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 3:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:44 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:44 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

Im actually on the bus home and am finished for the day. I will check in on this tomorrow but I wanted to make sure the conversation stayed centralised to this ticket.

Fri, Nov 8, 1:42 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson renamed T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from [AMC] Stray semicolon in RecentChanges Watchlist and history interface to [AMC] Stray semicolon in RecentChanges and Watchlist interface.
Fri, Nov 8, 1:41 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:36 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson reopened T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface as "Open".

I guess we should qa the specific problems in the above bugs too but let's not have multiple bugs for the same issue.

Fri, Nov 8, 1:31 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson merged task T237685: extraneous semicolon appearing in watchlist view into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:30 AM · User-Zoranzoki21, Regression, MediaWiki-Watchlist, Growth-Team
Jdlrobson merged task T237705: extraneous semicolon appearing in history view into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:30 AM · User-Zoranzoki21, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MediaWiki-Page-History, Regression
Jdlrobson merged tasks T237685: extraneous semicolon appearing in watchlist view, T237705: extraneous semicolon appearing in history view into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 1:30 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson awarded T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date a Barnstar token.
Fri, Nov 8, 1:14 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes
Jdlrobson added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

See qa in https://phabricator.wikimedia.org/T237500
I think we just need to verify no semicolon on mobile

Fri, Nov 8, 1:13 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson moved T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Fri, Nov 8, 1:13 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.

Thank you so much for the QA and the swat @Zoranzoki21

Fri, Nov 8, 1:12 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes
Jdlrobson merged T237701: Vector skin injects a semicolon to the watchlist which is not localized into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 12:37 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson merged task T237701: Vector skin injects a semicolon to the watchlist which is not localized into T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 12:37 AM · Patch-For-Review, I18n, Vector
Jdlrobson updated the task description for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.
Fri, Nov 8, 12:37 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson moved T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Instead of using a hardcoded semi colon, let's use
.mw-title:after { content: '; '; }

Let's not! There was a reason the original code was calling $this->message['semicolon-separator']: not every language uses the same semicolon as Latin-script languages like English (e.g. compare ; for English versus ؛ for Persian). I think this change needs to be redone or undone.

Fri, Nov 8, 12:33 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a comment to T237701: Vector skin injects a semicolon to the watchlist which is not localized.

I hadn't clicked that was an actually a message because it's non-standard use of message display. New patch fixes it. In mean time you'll need to ship a site style to translate that.

Fri, Nov 8, 12:21 AM · Patch-For-Review, I18n, Vector

Thu, Nov 7

Jdlrobson moved T237677: Regression: Notification Overlay can't be closed via mask from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Nov 7, 10:03 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson updated the task description for T237677: Regression: Notification Overlay can't be closed via mask.
Thu, Nov 7, 8:01 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

The issue with the notifications menu is also happening on master, so I've spun out https://phabricator.wikimedia.org/T237677 to look at that separately. My initial guess is that it might relate to recent changes to the OverlayManager.

Thu, Nov 7, 7:41 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Nov 7, 7:41 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T237677: Regression: Notification Overlay can't be closed via mask from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Nov 7, 7:39 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson created T237677: Regression: Notification Overlay can't be closed via mask.
Thu, Nov 7, 7:39 PM · Notifications, Growth-Team, Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson added a comment to T237589: [Bug] Add discussion button and confusing message appears on Flow Talk Pages on Beta.

The client side check for this would be:

mw.config.get('wgPageContentModel') ==== "wikitext"

In PHP

$title->getContentModel()

The value for Flow is flow-board, but that doesn't matter as we'd only ever want to do this on wikitext pages.

Thu, Nov 7, 6:54 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue
Jdlrobson moved T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup from Incoming to Tracking on the Readers-Web-Backlog board.
Thu, Nov 7, 4:40 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Needs More Work to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Nov 7, 12:01 AM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Wed, Nov 6

Jdlrobson moved T226125: Updates to notifications container on mobile to make it more consistent with desktop from Blocked to OKR Backlog on the User-Jdlrobson board.
Wed, Nov 6, 11:56 PM · User-Jdlrobson, Growth-Team, Notifications, Readers-Web-Backlog (Design), Patch-For-Review
Jdlrobson moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Blocked to Doing on the User-Jdlrobson board.
Wed, Nov 6, 11:56 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T234650: [subtask] Server side render the MainMenu to improve the main menu experience from Doing to Done on the User-Jdlrobson board.
Wed, Nov 6, 11:56 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), User-Jdlrobson, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T237050: The `site` and `site.styles` module should be explictly disabled on mobile rather than abuse the targets system from OKR Backlog to Doing on the User-Jdlrobson board.
Wed, Nov 6, 11:56 PM · User-Jdlrobson, Patch-For-Review, Performance-Team (Radar), MediaWiki-Interface, Readers-Web-Backlog (Tracking), MediaWiki-General
Jdlrobson added a comment to T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup.

@matmarex true - this probably could be moved into the show method for completeness - I think the reason it's not is that some Drawer's get added to the DOM and don't call the show method (ideally we are trying to get rid of the show method as part of https://phabricator.wikimedia.org/T214647 but I don't know if that will ever be prioritised :(

Wed, Nov 6, 9:26 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson updated subscribers of T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup.

The code at fault is src/mobile.init/editor.js - @JTannerWMF let me know if this is editing team or web responsibility. Until then I'll assume the former.

Wed, Nov 6, 7:55 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson renamed T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup from Gray Screen to Gray Screen shows for wikis that require login to edit due to problem in editor setup.
Wed, Nov 6, 7:53 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson added a comment to T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup.

Ok I can replicate here: https://wiki.lavinya.net/?useformat=mobile
but I can't seem to replicate locally with the same versions of MobileFrontend and Minerva :(

Wed, Nov 6, 7:37 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson added a comment to T216533: Mobile web "you are blocked" notice should truncate long block reasons.

The web team doesn't really have the right expertise here to work on this :(.

Wed, Nov 6, 7:21 PM · Readers-Web-Backlog (Tracking), Anti-Harassment, MobileFrontend, MediaWiki-User-management
Jdlrobson added a comment to T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup.

Hmm I can't seem to replicate this issue. Does the issue occur in an incognito (private) browser window?

Wed, Nov 6, 7:19 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson moved T210428: Review "about this page" page issues treatment of boxes at the top of talk pages from Needs analysis to Designing/discussing right now on the Readers-Web-Backlog (Design) board.

@nray @alexhollender seems relevant given our current work on talk pages
Compare https://en.wikipedia.org/wiki/Talk:Torridincolidae with https://en.m.wikipedia.org/wiki/Talk:Torridincolidae
Should we turn off the page issues code on talk pages so that the content is revealed when you click "read as wiki page? "

Wed, Nov 6, 7:16 PM · Readers-Web-Backlog (Design), MinervaNeue
Jdlrobson merged task T174995: Link to talk / discussion page should indicate if page exists or not into T236608: [AMC] Minerva talk tabs give confusing experience when they are red links.
Wed, Nov 6, 7:14 PM · Readers-Web-Backlog (Design), Regression, MobileFrontend
Jdlrobson merged T174995: Link to talk / discussion page should indicate if page exists or not into T236608: [AMC] Minerva talk tabs give confusing experience when they are red links.
Wed, Nov 6, 7:13 PM · Advanced Mobile Contributions, MinervaNeue, Readers-Web-Backlog (Design)
Jdlrobson renamed T116686: Very long discussions (horizontal axis) on talk pages become unreadable from Very long talk pages unreadable to Very long discussions (horizontal axis) on talk pages become unreadable.
Wed, Nov 6, 7:12 PM · Growth-Team, Readers-Web-Backlog (Design), Design, MobileFrontend
Jdlrobson updated subscribers of T229725: Discussions with no headline aren't displayed in the talk page interface.

@nray @alexhollender seems relevant given our current sprint work.

Wed, Nov 6, 7:10 PM · OWC2020, Readers-Web-Backlog (Design), MobileFrontend, MinervaNeue
Jdlrobson lowered the priority of T217810: TalkSectionOverlay should use the Overlay.make pattern from High to Normal.
Wed, Nov 6, 7:04 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson reopened T217810: TalkSectionOverlay should use the Overlay.make pattern, a subtask of T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance, as Open.
Wed, Nov 6, 7:03 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic, MinervaNeue
Jdlrobson reopened T217810: TalkSectionOverlay should use the Overlay.make pattern, a subtask of T219388: Flash of page in talk modal transition, as Open.
Wed, Nov 6, 7:03 PM · Readers-Web-Backlog
Jdlrobson reopened T217810: TalkSectionOverlay should use the Overlay.make pattern as "Open".

Whoops. This overlay is still around - my bad :)

Wed, Nov 6, 7:03 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson closed T217810: TalkSectionOverlay should use the Overlay.make pattern, a subtask of T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance, as Declined.
Wed, Nov 6, 7:03 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic, MinervaNeue
Jdlrobson closed T217810: TalkSectionOverlay should use the Overlay.make pattern, a subtask of T219388: Flash of page in talk modal transition, as Declined.
Wed, Nov 6, 7:03 PM · Readers-Web-Backlog
Jdlrobson closed T217810: TalkSectionOverlay should use the Overlay.make pattern as Declined.

This overlay has been removed from the codebase.

Wed, Nov 6, 7:03 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T218960: Bug: Talk overlay renders for talk sections that do not exist from Needs Analysis to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 6, 7:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdlrobson edited projects for T218960: Bug: Talk overlay renders for talk sections that do not exist, added: Readers-Web-Backlog (Kanbanana-2019-20-Q2); removed Readers-Web-Backlog (Design).

This now looks fixed thanks to @nray work on T230695 so moving for QA

Wed, Nov 6, 7:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdlrobson closed T208152: [Bug] Back to top intercepts gallery details button click as Declined.

Per the plan to replace the need for this button in T151115 and remove beta (T237290) we will be removing this feature.

Wed, Nov 6, 7:00 PM · Readers-Web-Backlog, good first bug, MinervaNeue
Jdlrobson closed T196641: 'Jump to top' beta feature doesn't work at random times in Chrome, a subtask of T151115: [EPIC] Improve in-article navigation, as Declined.
Wed, Nov 6, 6:59 PM · Readers-Web-Backlog, Epic, MinervaNeue, Design
Jdlrobson closed T196641: 'Jump to top' beta feature doesn't work at random times in Chrome as Declined.

Per the plan to replace the need for this button in T151115 and remove beta (T237290) we will be removing this feature.

Wed, Nov 6, 6:59 PM · Browser-Support-Google-Chrome, Readers-Web-Backlog (Tracking), MobileFrontend
Jdlrobson closed T187804: Jump to top is purposely hidden on iPhone, a subtask of T151115: [EPIC] Improve in-article navigation, as Declined.
Wed, Nov 6, 6:59 PM · Readers-Web-Backlog, Epic, MinervaNeue, Design
Jdlrobson closed T187804: Jump to top is purposely hidden on iPhone as Declined.

Per the plan to replace the need for this button in T151115 and remove beta (T237290) we will be removing this feature.

Wed, Nov 6, 6:59 PM · Readers-Web-Backlog (Needs Product Owner Decisions), MinervaNeue
Jdlrobson moved T232577: Wikidata Bridge random browser test failure “Errors-Init-Value-Switch shows the current targetValue” (Failed to wait for wikibase.client.data-bridge.app to be ready after 2000 ms) from Epics/Goals to Tracking on the Readers-Web-Backlog board.
Wed, Nov 6, 6:53 PM · Readers-Web-Backlog (Tracking), Wikimedia-production-error (Shared Build Failure), Wikidata-Bridge, Wikidata
Jdlrobson moved T232577: Wikidata Bridge random browser test failure “Errors-Init-Value-Switch shows the current targetValue” (Failed to wait for wikibase.client.data-bridge.app to be ready after 2000 ms) from Incoming to Epics/Goals on the Readers-Web-Backlog board.
Wed, Nov 6, 6:52 PM · Readers-Web-Backlog (Tracking), Wikimedia-production-error (Shared Build Failure), Wikidata-Bridge, Wikidata
Jdlrobson moved T236328: Username should be on its own line (Recent changes & Watchlist) from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 6, 6:33 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Jdlrobson updated the task description for T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.
Wed, Nov 6, 6:13 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes
Jdlrobson added a comment to T237552: Gray Screen shows for wikis that require login to edit due to problem in editor setup.

Is this a third party wiki or a wikimedia-hosted wiki? it looks like the mediawiki instance might be running incompatible Minerva and MobileFrontend versions. Is there a public URI you can share?

Wed, Nov 6, 5:54 PM · Readers-Web-Backlog (Tracking), Skipped QA, VisualEditor (Current work), Patch-For-Review, MinervaNeue
Jdlrobson closed T233037: [Regression] Not possible for logged in users to disable page previews as Resolved.

That did it! Thanks!

Wed, Nov 6, 5:52 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
Jdlrobson moved T237230: Long edit summary/titles/user breaking AMC special pages from Needs Design Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 6, 5:48 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdlrobson moved T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date from Needs Analysis to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 6, 5:48 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes
Jdlrobson added a comment to T191706: It's not possible to undo/rollback edits from diff on Mobile.

@alexhollender The button is destructive, and primary or just only destructive. I am fine with either way. The design looks good. But as a mobile user, a lazy one at that, I don't wish to go through a confirmation screen like in the desktop version to undo a diff. Are you planning to make it automatic?

Wed, Nov 6, 4:49 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), patch-welcome, Advanced Mobile Contributions, MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Design), MediaWiki-Page-Diffs
Jdlrobson added a comment to T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.

Okay, I got this. I was misunderstanding your bug report. I thought you were talking about a different element on the page.

Wed, Nov 6, 4:44 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes