Sat, Mar 23
m.define( 'mobile.mediaViewer/ImageOverlay', ImageOverlay );
I noticed this line in src/mobile.mediaViewer/mobile.mediaViewer.js but the method is deprecated. We should officially deprecate this
m.deprecate( 'mobile.mediaViewer/ImageOverlay', ImageOverlay );
and update Minerva to use the new factory method.
Unable to get to page in Arabic.
For future reference, this is actually possible via https://ar.m.wikipedia.beta.wmflabs.org/w/index.php?title=%D8%B1%D9%82%D9%85_%D8%B3%D9%88%D8%B1%D8%A9&mobileaction=toggle_view_mobile URL
Fri, Mar 22
I just realised there was scope creep here and have spun out the remaining two patches to T219036
Given the struggles we've been having I don't think code coverage is useful right now so I descoped that (let's cut a new task to do that).
If a page does not have a history page, do not display history icon: ❌ Fail
This one should pass now @Edtadros please test on https://en.m.wikipedia.beta.wmflabs.org/wiki/Spainsasasaassa
reseting story points
Moving back to sprint for more analysis/reflection on how these changes can be made more effortlessly. I certainly have learned a lot about the challenges from this task about dissecting our current code.
Thu, Mar 21
@alexhollender this came up during our refactoring efforts. Given we are refactoring this soon it would be helpful to have some guidance on what to do with this case.
QA Blocked on T218807
@Esanders I assume your team wants to QA? Can I leave this with you to either resolve or do that?
In Beta the button appears to bleed into the right edge of the screen. The expectation is that it is right aligned.
Yeh your screenshot definitely looks better but right now i'm seeing bleeding on enwiki too.
Wed, Mar 20
The download button is by design and blocked on being able to point to Proton (T181079). As a result I've descoped this to history as I think that distinction is helpful.
Confirm you stay in the overlay, the URL remains #/editor/0 ❌
Moved this out into T218809 since it requires significantly more work to fix. This task is ready for sign off now.
I don't think we should take on more of these tasks until the existing ones in flight have been done
I think that this patch should be merged as it makes the experience usable.
Can you clarify what "this patch" is?
Can you add a comment here why the Math.min( thumbnail.width - SIZES.portraitImage.w, 0 ) logic isn't necessary for RTL?
Tue, Mar 19
I'm looking for an assignee on Add the AddTopicForm component
To summarise what I'm hearing:
- Unlike we'll get rid of all browser QUnit tests.
- Selenium is slow
- Easier to debug certain problems in browser
Closing per discussion with Alex. All subtasks are complete.
Use promisedView pattern for dealing with async wrapperWidget and Remove loading checks are next in the review queue.
@JoeWalsh are we okay to merge the Minerva patch now (knowing that it won't go out until next Thursday (28th)) ?
Olga to think about this
We estimated this as a Large/Medium. Right now quick surveys checks if the mobile beta opt in panel is displayed. If it is, the survey doesn't show.