Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (254 w, 4 d)
Availability
Available
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Yesterday

Jdlrobson added a comment to T233095: Significant mobile web performance regression observed at deployment of 1.34.0-wmf.22.

Can we see the scrollbar in the screenshots? If so that also might confirm that theory about sections not collapsing. In which case something went wrong with our patches that we thought were caching safe and disabled section collapsing on the site which may have caused undesired performance regressions that are worth understanding (and possibly justifying the fact we collapse content by default on mobile).

Mon, Sep 23, 10:17 PM · Performance-Team-publish, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Performance-Team
Jdlrobson moved T232685: Update MobileFrontend for changes in AbuseFilter and SpamBlacklist API error responses from Incoming to Tracking on the Readers-Web-Backlog board.
Mon, Sep 23, 10:16 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend
Jdlrobson moved T231613: Replace 24x24px SVGs in MF/Minerva from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 10:14 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 10:02 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson renamed T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" / "invalidtitle" error for extracts API error for title in Pashto Wikipedia from "invalidtitle" error for extracts API error for title in Pashto Wikipedia to Fatal exception of type "Wikimedia\Assert\PostconditionException" / "invalidtitle" error for extracts API error for title in Pashto Wikipedia .
Mon, Sep 23, 9:36 PM · Readers-Web-Backlog (Tracking), Wikimedia-General-or-Unknown, TextExtracts
Jdlrobson updated the task description for T233663: Remove Minerva's EventLogging error tracking.
Mon, Sep 23, 8:53 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson triaged T233663: Remove Minerva's EventLogging error tracking as Normal priority.
Mon, Sep 23, 8:53 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson moved T233663: Remove Minerva's EventLogging error tracking from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 8:52 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson created T233663: Remove Minerva's EventLogging error tracking.
Mon, Sep 23, 8:52 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson moved T230033: [ICONS] Increase touch targets from 40x40 to 44x44 from Upcoming to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@ovasileva this should be in blocked on others. We talked about this during last estimation meeting (wednesday) and said all the other icon patches should be done before we consider bumping the size of the icons

Mon, Sep 23, 7:20 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Accessibility, Advanced Mobile Contributions
Jdlrobson removed a project from T233050: ICONS menu alignment and list item spacing: Patch-For-Review.
Mon, Sep 23, 7:18 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson claimed T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts.
Mon, Sep 23, 7:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Jdlrobson moved T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 7:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Jdlrobson added a comment to T231613: Replace 24x24px SVGs in MF/Minerva.

@alexhollender blue watchstar should be live on the beta cluster shortly. It will ride train early tomorrow so please let me know today if there are any problems.
https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

Mon, Sep 23, 7:17 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson reassigned T117736: Convert Special:Contributions to OOUI from Jdlrobson to Volker_E.
Mon, Sep 23, 7:14 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, Patch-For-Review, UI-Standardization
Jdlrobson moved T117736: Convert Special:Contributions to OOUI from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 7:14 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, Patch-For-Review, UI-Standardization
Jdlrobson moved T233104: Add localized Wikipedia wordmark to the Silesian (szl) mobile frontend from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 6:47 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, Wikimedia-Site-requests
Jdlrobson added a comment to T233373: Sections on some mobile pages are not collabsable.

I'd expect no reports after the end of this week. If so I think we can safely assume caching and close these tickets. Thanks for letting me know and please do feedback any new OTRS tickets about this issue.

Mon, Sep 23, 6:43 PM · Readers-Web-Backlog (Tracking), Operations, Traffic, MobileFrontend
Jdlrobson added a project to T233649: Stray semicolon in RecentChanges interface: patch-welcome.
Mon, Sep 23, 6:42 PM · patch-welcome, Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a project to T222903: Some dot-separators in recent changes and watchlist are missing surrounding whitespace: Advanced Mobile Contributions.
Mon, Sep 23, 6:41 PM · Advanced Mobile Contributions, patch-welcome, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), good first bug, Regression, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team
Jdlrobson added a project to T233649: Stray semicolon in RecentChanges interface: Advanced Mobile Contributions.
Mon, Sep 23, 6:41 PM · patch-welcome, Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson reassigned T231613: Replace 24x24px SVGs in MF/Minerva from Jdlrobson to alexhollender.
Mon, Sep 23, 6:40 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson closed T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements as Resolved.

Am closing this bug as most of the issues are solved. The remaining issues are documented in bugs:
T222903, T194453, T233649
Thanks all with the help here in making mediawiki a little more responsive.

Mon, Sep 23, 6:39 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, UI-Standardization, MediaWiki-Recent-changes, User-Jdlrobson
Jdlrobson created T233649: Stray semicolon in RecentChanges interface.
Mon, Sep 23, 6:39 PM · patch-welcome, Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Jdlrobson added a project to T219707: Improve default colour contrast between visited and unvisited links: Readers-Web-Backlog (Design).
Mon, Sep 23, 6:27 PM · Readers-Web-Backlog (Design), Accessibility, Vector
Jdlrobson added a project to T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" / "invalidtitle" error for extracts API error for title in Pashto Wikipedia : Readers-Web-Backlog (Tracking).

@Ebonetti90
What is the URI of the page with that pageid?
Are you able to use the REST_v1 summary endpoint (which is better supported): https://pt.wikipedia.org/api/rest_v1/#/Page%20content/get_page_summary__title_

Mon, Sep 23, 6:27 PM · Readers-Web-Backlog (Tracking), Wikimedia-General-or-Unknown, TextExtracts
Jdlrobson added a project to T233373: Sections on some mobile pages are not collabsable: Readers-Web-Backlog (Tracking).

This is likely a caching issue. We recently moved some code around and had reports that this might not have gone as smoothly as expected.

Mon, Sep 23, 6:22 PM · Readers-Web-Backlog (Tracking), Operations, Traffic, MobileFrontend
Jdlrobson added a comment to T233095: Significant mobile web performance regression observed at deployment of 1.34.0-wmf.22.

this bug T233373 may also be relevant - a potential hypothesis is that if sections are not collapsed it causes time to first interactive issues. It's not possible to see in the runs if section collapsing is being enabled or not but the timing would fit.

Mon, Sep 23, 6:21 PM · Performance-Team-publish, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Performance-Team
Jdlrobson moved T233104: Add localized Wikipedia wordmark to the Silesian (szl) mobile frontend from Upcoming to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 23, 5:51 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, Wikimedia-Site-requests
Jdlrobson added a project to T233430: selenium-QuickSurveys browser test went from 20 seconds to 1+ minute: Readers-Web-Backlog (Tracking).
Mon, Sep 23, 4:53 PM · Readers-Web-Backlog (Tracking), Release-Engineering-Team-TODO, Release-Engineering-Team (Unit & Int & System Tooling), Ruby, Browser-Tests, QuickSurveys

Fri, Sep 20

Jdlrobson reassigned T233167: [ICON] language label in overflow menu should look disabled matching icon (AMC user pages) from alexhollender to Edtadros.
Fri, Sep 20, 6:44 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T232514: [subtask] Add 'userGroup' icon to OOUI from Ready for Development to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Fri, Sep 20, 5:46 PM · OOUI (OOUI-0.34.1), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Thu, Sep 19

Jdlrobson added a project to T233340: Add sortability to sortable tables for readers of the mobile web site: Readers-Web-Backlog.
Thu, Sep 19, 9:04 PM · Readers-Web-Backlog, Advanced Mobile Contributions, MinervaNeue, MobileFrontend, Mobile
Jdlrobson closed T175082: mobile.startup should be only dependency of Minerva and Minerva should be able to define it itself, a subtask of T171000: [EPIC] Minerva works independently of MobileFrontend, as Resolved.
Thu, Sep 19, 8:58 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, Epic, MinervaNeue (Desktop)
Jdlrobson closed T175082: mobile.startup should be only dependency of Minerva and Minerva should be able to define it itself as Resolved.

The only module used by Minerva from MobileFrontend now is mobile.startup so this is done.

Thu, Sep 19, 8:58 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue (Desktop)
Jdlrobson placed T233046: ICONS: tap/active state remains after tapping button up for grabs.
Thu, Sep 19, 7:57 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
kaldari awarded T231925: Minerva should support skin agnostic mw.util.addPortletLink or similar a Love token.
Thu, Sep 19, 7:46 PM · Readers-Web-Backlog, MinervaNeue, Front-end-Standards-Group
Jdlrobson reassigned T233171: [ICONS] editor-loading header from alexhollender to Esanders.

waiting on some feedback from Ed.

Thu, Sep 19, 7:01 PM · VisualEditor, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T230941: [Spike, 8hrs] Investigate using display locking when expanding/collapsing sections from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Sep 19, 7:01 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdlrobson assigned T233037: [Regression] Not possible for logged in users to disable page previews to pmiazga.

Piotr said he'd take a look

Thu, Sep 19, 7:00 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Regression, Page-Previews
Jdlrobson moved T233167: [ICON] language label in overflow menu should look disabled matching icon (AMC user pages) from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Sep 19, 6:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson assigned T233167: [ICON] language label in overflow menu should look disabled matching icon (AMC user pages) to alexhollender.
Thu, Sep 19, 6:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson added a project to T233104: Add localized Wikipedia wordmark to the Silesian (szl) mobile frontend: patch-welcome.

Config only change via a SWAT window. Patch welcomed.

$wgMinervaCustomLogos = [
        'copyright' => 'https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg',
        'copyright-width' => 100,
         'copyright-height' => 18,
];
Thu, Sep 19, 6:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, Wikimedia-Site-requests
Jdlrobson added a comment to T233037: [Regression] Not possible for logged in users to disable page previews.

This only seems to impact beta cluster not production (it works fine on English Wikipedia)

Thu, Sep 19, 6:18 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Regression, Page-Previews
Jdlrobson added a project to T233037: [Regression] Not possible for logged in users to disable page previews: Reference Previews.

Is this related to recent changes to references preview?

Thu, Sep 19, 6:16 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Regression, Page-Previews
Jdlrobson updated the task description for T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts.
Thu, Sep 19, 6:13 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Jdlrobson updated the task description for T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts.
Thu, Sep 19, 6:13 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Jdlrobson added a project to T233340: Add sortability to sortable tables for readers of the mobile web site: Advanced Mobile Contributions.

The mw-collapsible code and the sortable code are currently tightly coupled - so enabling sortable requires enabling the other as well. We could modify core to make it possible to do one without the other.

Thu, Sep 19, 5:51 PM · Readers-Web-Backlog, Advanced Mobile Contributions, MinervaNeue, MobileFrontend, Mobile
Jdlrobson added a subtask for T111565: Enable mediawiki.page.ready on Minerva (collapsible templates (including infoboxes): T233340: Add sortability to sortable tables for readers of the mobile web site.
Thu, Sep 19, 5:49 PM · Advanced Mobile Contributions, patch-welcome, Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), MinervaNeue, Design
Jdlrobson added a parent task for T233340: Add sortability to sortable tables for readers of the mobile web site: T111565: Enable mediawiki.page.ready on Minerva (collapsible templates (including infoboxes).
Thu, Sep 19, 5:49 PM · Readers-Web-Backlog, Advanced Mobile Contributions, MinervaNeue, MobileFrontend, Mobile
Jdlrobson updated the task description for T233151: Remove mobile diff page drawer margin.
Thu, Sep 19, 5:45 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233151: Remove mobile diff page drawer margin.
Thu, Sep 19, 5:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T231613: Replace 24x24px SVGs in MF/Minerva from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Sep 19, 5:13 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson claimed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons.
Thu, Sep 19, 5:11 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Needs Code Review to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Sep 19, 5:11 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson renamed T233193: MobileFrontend and Minerva Selenium tests failing with "Promise timeout" from MF Selenium tests failing with "Promise timeout" to MF and Minerva Selenium tests failing with "Promise timeout".
Thu, Sep 19, 5:04 PM · Release-Engineering-Team-TODO (201909), User-zeljkofilipin, MobileFrontend, Readers-Web-Backlog
Jdlrobson added a comment to T231925: Minerva should support skin agnostic mw.util.addPortletLink or similar.

@matmarex looking into this some more the following code in Minerva gets portlet links added where they need to be:

$('.minerva-user-menu .toggle-list__list--drop-down').attr( 'id', 'p-personal' );
$( '#mw-mf-page-left .menu:first-child' ).attr( 'id', 'p-navigation');
$('#page-actions-overflow .toggle-list__list--drop-down').attr( 'id', 'p-tb' );

However Minerva uses a different template for these items, so the do not render properly:

Thu, Sep 19, 4:15 PM · Readers-Web-Backlog, MinervaNeue, Front-end-Standards-Group

Wed, Sep 18

Jdlrobson closed T233260: Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page as Resolved.

No longer seeing the JS errors.

Wed, Sep 18, 11:33 PM · MobileFrontend, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson added a comment to T233046: ICONS: tap/active state remains after tapping button.

I don't know how to fix this. iOS seems to remember where you last clicked and focus any element in that area. Possibly a browser bug?

Wed, Sep 18, 10:37 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T232284: Rollback link on mobile should be styled from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 10:36 PM · good first bug, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Jdlrobson added a project to T232284: Rollback link on mobile should be styled: good first bug.
Wed, Sep 18, 10:36 PM · good first bug, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Jdlrobson updated the task description for T232284: Rollback link on mobile should be styled.
Wed, Sep 18, 10:31 PM · good first bug, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Jdlrobson moved T232955: [AMC] Summary in recent changes misaligned from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 10:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, MobileFrontend
Jdlrobson updated the task description for T232955: [AMC] Summary in recent changes misaligned.
Wed, Sep 18, 10:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, MobileFrontend
Jdlrobson moved T233260: Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page from Ready for Development to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Possibly need to swat this

Wed, Sep 18, 9:47 PM · MobileFrontend, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson added a comment to T232260: Hamburger and notifications menu icons arehidden in mobile view of RTL languages in Chrome.

I've opened an upstream issue https://bugs.chromium.org/p/chromium/issues/detail?id=1005433 cc @Amire80

Wed, Sep 18, 8:50 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Browser-Support-Android-Google-Chrome, Browser-Support-Google-Chrome, Mobile, RTL, I18n, MobileFrontend
Jdlrobson added a project to T233260: Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page: Regression.
Wed, Sep 18, 8:30 PM · MobileFrontend, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson renamed T233260: Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page from `Cannot read property 'route' of undefined` JS error on all mobile main page to Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page.
Wed, Sep 18, 8:28 PM · MobileFrontend, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson created T233260: Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page.
Wed, Sep 18, 8:28 PM · MobileFrontend, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdlrobson added a comment to T232653: Updates to user pages for all logged-in users.

I'm giving you 2 options - remove if it's not useful or change the link to something more useful. For this particular task, however I'm saying remove the link to simplify the change (dropping those blue links).

Wed, Sep 18, 8:11 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdlrobson added a comment to T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons.

The page issues one is a little tricker - as page issues has a line height of 1.65 so I can't see a way to adjust this icon's position without an arbitrary non-variable based value. Pausing working on this until the other icons are taken care of.

Wed, Sep 18, 7:09 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Ready for Development to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 6:02 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Upcoming to Ready for Development on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 5:18 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson set the point value for T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons to 3.
Wed, Sep 18, 5:18 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson moved T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias from Upcoming to Ready for Development on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 5:17 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
Jdlrobson moved T233156: [ICONS] clear search icon alignment from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 4:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233156: [ICONS] clear search icon alignment.
Wed, Sep 18, 4:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233151: Remove mobile diff page drawer margin.
Wed, Sep 18, 3:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T233166: [ICONS] logout icon horizontal centering from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 3:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson added a comment to T233166: [ICONS] logout icon horizontal centering.

@alexhollender question for you in developer notes

Wed, Sep 18, 3:40 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233166: [ICONS] logout icon horizontal centering.
Wed, Sep 18, 3:39 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233172: [ICONS] last edited element alignment.
Wed, Sep 18, 3:36 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233167: [ICON] language label in overflow menu should look disabled matching icon (AMC user pages).
Wed, Sep 18, 3:32 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson renamed T233167: [ICON] language label in overflow menu should look disabled matching icon (AMC user pages) from [ICON] language label in overflow menu (AMC user pages) to [ICON] language label in overflow menu should look disabled matching icon (AMC user pages).
Wed, Sep 18, 3:31 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233050: ICONS menu alignment and list item spacing.
Wed, Sep 18, 3:28 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson added a comment to T233193: MobileFrontend and Minerva Selenium tests failing with "Promise timeout".

I noted this issue here -T232708#5488613 - for which i've requested RelEng's help as I'm unable to work out what's happened.

Wed, Sep 18, 3:21 PM · Release-Engineering-Team-TODO (201909), User-zeljkofilipin, MobileFrontend, Readers-Web-Backlog
Jdlrobson added a comment to T233095: Significant mobile web performance regression observed at deployment of 1.34.0-wmf.22.

There were lots of reports today of the mobile site blanking out - just mentioning this in case there's any relation to this issue (I don't know what could have caused this):
https://twitter.com/AdaMcVean/status/1174133105818570752
https://twitter.com/finalfantasy420/status/1173956372968247298
https://twitter.com/VulpesOkamis/status/1174042412190195712

Wed, Sep 18, 4:57 AM · Performance-Team-publish, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Performance-Team

Tue, Sep 17

Jdlrobson moved T231613: Replace 24x24px SVGs in MF/Minerva from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 17, 11:10 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson updated the task description for T233171: [ICONS] editor-loading header.
Tue, Sep 17, 10:48 PM · VisualEditor, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson added a project to T233171: [ICONS] editor-loading header: VisualEditor.
Tue, Sep 17, 10:46 PM · VisualEditor, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T233152: [ICONS] reference drawer icon and alignment from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 17, 10:37 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Needs Analysis to Upcoming on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 17, 10:37 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson renamed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Use mw-ui-icon-flush- classes on various icons to fix alignment: clear search, page issues, block drawer icons to Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons.
Tue, Sep 17, 10:36 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson renamed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Page issues and block drawer icons misaligned vertically and horizontally (use mw-ui-icon-flush- classes) to Use mw-ui-icon-flush- classes on various icons to fix alignment: clear search, page issues, block drawer icons.
Tue, Sep 17, 10:35 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson merged task T233157: [ICONS] search within page button alignment into T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons.
Tue, Sep 17, 10:35 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson merged T233157: [ICONS] search within page button alignment into T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons.
Tue, Sep 17, 10:35 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson renamed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Page issues and block drawer icons misaligned vertically to Page issues and block drawer icons misaligned vertically and horizontally (use mw-ui-icon-flush- classes).
Tue, Sep 17, 10:35 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson updated the task description for T233152: [ICONS] reference drawer icon and alignment.
Tue, Sep 17, 10:31 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdlrobson renamed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages, page issues, block drawer icons from Page issues, references, block drawer icons misaligned vertically to Page issues and block drawer icons misaligned vertically.
Tue, Sep 17, 10:31 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Page-Issue-Warnings, Regression
Jdlrobson updated the task description for T233152: [ICONS] reference drawer icon and alignment.
Tue, Sep 17, 10:30 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions