Page MenuHomePhabricator

Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (228 w, 3 d)
Availability
Available
IRC Nick
jdlrobson
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Sat, Mar 23

Jdlrobson moved T216198: MFA: ImageOverlay should be an Overlay Composed of Components from Doing to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

m.define( 'mobile.mediaViewer/ImageOverlay', ImageOverlay );

I noticed this line in src/mobile.mediaViewer/mobile.mediaViewer.js but the method is deprecated. We should officially deprecate this

m.deprecate( 'mobile.mediaViewer/ImageOverlay', ImageOverlay );

and update Minerva to use the new factory method.

Sat, Mar 23, 12:57 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T216198: MFA: ImageOverlay should be an Overlay Composed of Components.
Sat, Mar 23, 12:56 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T216198: MFA: ImageOverlay should be an Overlay Composed of Components.
Sat, Mar 23, 12:54 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a comment to T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.

Unable to get to page in Arabic.

For future reference, this is actually possible via https://ar.m.wikipedia.beta.wmflabs.org/w/index.php?title=%D8%B1%D9%82%D9%85_%D8%B3%D9%88%D8%B1%D8%A9&mobileaction=toggle_view_mobile URL

Sat, Mar 23, 12:10 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Fri, Mar 22

Jdlrobson added a comment to T217296: Use the Overlay.make pattern for notification feature.

I just realised there was scope creep here and have spun out the remaining two patches to T219036
Given the struggles we've been having I don't think code coverage is useful right now so I descoped that (let's cut a new task to do that).

Fri, Mar 22, 9:07 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T217296: Use the Overlay.make pattern for notification feature.
Fri, Mar 22, 9:07 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson reassigned T217296: Use the Overlay.make pattern for notification feature from Jdlrobson to Edtadros.
Fri, Mar 22, 9:04 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a parent task for T219036: MFA: Create Notifications filter overlay using modern techniques: T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance.
Fri, Mar 22, 9:03 PM · Patch-For-Review, Readers-Web-Backlog
Jdlrobson added a subtask for T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance: T219036: MFA: Create Notifications filter overlay using modern techniques.
Fri, Mar 22, 9:03 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MinervaNeue
Jdlrobson created T219036: MFA: Create Notifications filter overlay using modern techniques.
Fri, Mar 22, 9:02 PM · Patch-For-Review, Readers-Web-Backlog
Jdlrobson updated the task description for T217296: Use the Overlay.make pattern for notification feature.
Fri, Mar 22, 9:02 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T217810: TalkSectionOverlay should use the Overlay.make pattern from Upcoming to Needs Analysis on the Readers-Web-Backlog board.
Fri, Mar 22, 8:41 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson assigned T213352: AMC: add history link to actions menu to Edtadros.

If a page does not have a history page, do not display history icon: ❌ Fail

This one should pass now @Edtadros please test on https://en.m.wikipedia.beta.wmflabs.org/wiki/Spainsasasaassa
ttps://phabricator.wikimedia.org/T213352#5028939

Fri, Mar 22, 8:16 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson moved T213352: AMC: add history link to actions menu from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Mar 22, 8:15 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Mar 22, 8:14 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson moved T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern from Upcoming to Needs Analysis on the Readers-Web-Backlog board.
Fri, Mar 22, 8:12 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson removed the point value for T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern.

reseting story points

Fri, Mar 22, 8:12 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson edited projects for T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern, added: Readers-Web-Backlog; removed Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).

Moving back to sprint for more analysis/reflection on how these changes can be made more effortlessly. I certainly have learned a lot about the challenges from this task about dissecting our current code.

Fri, Mar 22, 8:12 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T218606: Poor rendering on tools.wmflabs.org from Needs triage to Triaged on the Mobile board.
Fri, Mar 22, 12:38 AM · cloud-services-team (Kanban), Mobile, Tools
Jdlrobson moved T176095: Some shift symbols delete the last word on Android from Needs triage to Apps on the Mobile board.
Fri, Mar 22, 12:38 AM · Mobile, MediaWiki-extensions-CodeMirror
Jdlrobson moved T213818: Misplaced (i) icon on all skins, causing scrollbars on MobileFrontend from Needs triage to Triaged on the Mobile board.
Fri, Mar 22, 12:38 AM · Mobile, Readers-Web-Backlog (Tracking), Patch-For-Review, Regression, Need-volunteer, ImageMap
Jdlrobson moved T218428: Mobile diff is not clear about move direction from Needs triage to MobileFrontend specific on the Mobile board.
Fri, Mar 22, 12:38 AM · Readers-Web-Backlog (Design), MinervaNeue, MobileFrontend, Mobile, MediaWiki-History-and-Diffs

Thu, Mar 21

Jdlrobson added a project to T218960: Bug: Talk overlay renders for talk sections that do not exist: MobileFrontend (MobileFrontend and MinervaNeue architecture).

@alexhollender this came up during our refactoring efforts. Given we are refactoring this soon it would be helpful to have some guidance on what to do with this case.

Thu, Mar 21, 10:11 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Design)
Jdlrobson renamed T218960: Bug: Talk overlay renders for talk sections that do not exist from Talk overlay renders for talk sections that do not exist to Bug: Talk overlay renders for talk sections that do not exist.
Thu, Mar 21, 10:10 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Design)
Jdlrobson created T218960: Bug: Talk overlay renders for talk sections that do not exist.
Thu, Mar 21, 10:10 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Design)
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Mar 21, 9:06 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Mar 21, 8:59 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson added a comment to T213352: AMC: add history link to actions menu.

QA Blocked on T218807

Thu, Mar 21, 5:01 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson moved T213352: AMC: add history link to actions menu from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Mar 21, 5:00 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson moved T191104: Reword post edit notification to reflect save->publish change on mobile from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Thu, Mar 21, 4:57 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), User-D3r1ck01, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing Design , VisualEditor-MediaWiki-Mobile, MobileFrontend, WikiEditor, MediaWiki-Page-editing, Mobile
Jdlrobson edited projects for T191104: Reword post edit notification to reflect save->publish change on mobile, added: VisualEditor (Current work); removed VisualEditor.
Thu, Mar 21, 4:57 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), User-D3r1ck01, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing Design , VisualEditor-MediaWiki-Mobile, MobileFrontend, WikiEditor, MediaWiki-Page-editing, Mobile
Jdlrobson edited projects for T191104: Reword post edit notification to reflect save->publish change on mobile, added: Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog (Design).

@Esanders I assume your team wants to QA? Can I leave this with you to either resolve or do that?

Thu, Mar 21, 4:57 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), User-D3r1ck01, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing Design , VisualEditor-MediaWiki-Mobile, MobileFrontend, WikiEditor, MediaWiki-Page-editing, Mobile
Jdlrobson moved T218731: Regression: Mark all as read button in notifications overlay larger than header from Needs More Work to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
In Beta the button appears to bleed into the right edge of the screen. The expectation is that it is right aligned.

Yeh your screenshot definitely looks better but right now i'm seeing bleeding on enwiki too.

Thu, Mar 21, 3:26 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson reassigned T218731: Regression: Mark all as read button in notifications overlay larger than header from Jdlrobson to alexhollender.
Thu, Mar 21, 3:26 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from To Do to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Mar 21, 3:26 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson moved T218809: Mobile editor updates browser URL incorrectly if you click back with unsaved edits from Triaged but Future to Upcoming on the Readers-Web-Backlog board.
Thu, Mar 21, 3:03 PM · VisualEditor, Patch-For-Review, Readers-Web-Backlog

Wed, Mar 20

Jdlrobson renamed T117279: [EPIC] Move InlineDifferenceEngine into core / remove MobileDiff from Move InlineDifferenceEngine into core / remove MobileDiff to [EPIC] Move InlineDifferenceEngine into core / remove MobileDiff.
Wed, Mar 20, 11:38 PM · MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)
Jdlrobson raised the priority of T117279: [EPIC] Move InlineDifferenceEngine into core / remove MobileDiff from Low to Normal.
Wed, Mar 20, 11:37 PM · MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)
Jdlrobson updated the task description for T186737: Let me choose whether to present a survey to logged-in or logged-out editors.
Wed, Mar 20, 8:03 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Research, QuickSurveys, Surveys
Jdlrobson updated the task description for T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby.
Wed, Mar 20, 6:31 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson triaged T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby as High priority.
Wed, Mar 20, 6:30 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby from To Triage to Upcoming on the Readers-Web-Backlog board.
Wed, Mar 20, 6:30 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson created T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby.
Wed, Mar 20, 6:30 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a project to T218809: Mobile editor updates browser URL incorrectly if you click back with unsaved edits: VisualEditor.
Wed, Mar 20, 6:22 PM · VisualEditor, Patch-For-Review, Readers-Web-Backlog
Jdlrobson added a comment to T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.

Wow, that's super complicated. Have y'all considered just using a PNG pokey like the Echo overlay?

Wed, Mar 20, 6:19 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Audiences-QA, Design, Page-Previews
Jdlrobson added a parent task for T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file: T216495: [EPIC] Diversity quicksurveys.
Wed, Mar 20, 6:17 PM · Readers-Web-Backlog, QuickSurveys
Jdlrobson added a subtask for T216495: [EPIC] Diversity quicksurveys: T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file.
Wed, Mar 20, 6:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Surveys
Jdlrobson moved T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.
Wed, Mar 20, 6:17 PM · Readers-Web-Backlog, QuickSurveys
Jdlrobson renamed T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file from Bump QuickSurveys version to 1.3.0 and decide what to do with HISTORY file to Bump QuickSurveys version to 1.3.0 and remove HISTORY file.
Wed, Mar 20, 6:16 PM · Readers-Web-Backlog, QuickSurveys
Jdlrobson triaged T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file as Normal priority.
Wed, Mar 20, 6:16 PM · Readers-Web-Backlog, QuickSurveys
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.
Wed, Mar 20, 6:16 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson updated the task description for T218807: [Bug] No history button shown on server rendered page (grade C browsers).
Wed, Mar 20, 6:16 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson renamed T218807: [Bug] No history button shown on server rendered page (grade C browsers) from [Bug] No history button shown on server rendered page to [Bug] No history button shown on server rendered page (grade C browsers).
Wed, Mar 20, 6:14 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson added a comment to T218807: [Bug] No history button shown on server rendered page (grade C browsers).

The download button is by design and blocked on being able to point to Proton (T181079). As a result I've descoped this to history as I think that distinction is helpful.

Wed, Mar 20, 6:12 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson renamed T218807: [Bug] No history button shown on server rendered page (grade C browsers) from [Bug] No history or download button shown on server rendered page to [Bug] No history button shown on server rendered page.
Wed, Mar 20, 6:12 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Mar 20, 6:10 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend
Jdlrobson moved T218173: [Bug/Regression] New talk topic edits are lost when I click browser back button from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Confirm you stay in the overlay, the URL remains #/editor/0 ❌

Moved this out into T218809 since it requires significantly more work to fix. This task is ready for sign off now.

Wed, Mar 20, 5:20 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T218173: [Bug/Regression] New talk topic edits are lost when I click browser back button.
Wed, Mar 20, 5:19 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson created T218809: Mobile editor updates browser URL incorrectly if you click back with unsaved edits.
Wed, Mar 20, 5:18 PM · VisualEditor, Patch-For-Review, Readers-Web-Backlog
Jdlrobson moved T217616: Ordered lists per default receive `decimal` list style type, which causes issues in non-arabic numeral scripts from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Mar 20, 4:08 PM · Readers-Web-Backlog, Patch-For-Review, UI-Standardization, UI-Standardization-Kanban, Regression, I18n, MinervaNeue
Jdlrobson moved T218741: Simplify URL to mw.Title heuristic to consume only Parsoid links from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Mar 20, 4:07 PM · Internet-Archive, MinervaNeue, Page-Previews, Technical-Debt, Readers-Web-Backlog
Jdlrobson edited projects for T217810: TalkSectionOverlay should use the Overlay.make pattern, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).

I don't think we should take on more of these tasks until the existing ones in flight have been done

Wed, Mar 20, 4:07 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a comment to T218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOS.
I think that this patch should be merged as it makes the experience usable.

Can you clarify what "this patch" is?

Wed, Mar 20, 4:02 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, MobileFrontend
Jdlrobson moved T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Mar 20, 1:00 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Audiences-QA, Design, Page-Previews
Jdlrobson added a comment to T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.

@Niedzielski wrote:
Can you add a comment here why the Math.min( thumbnail.width - SIZES.portraitImage.w, 0 ) logic isn't necessary for RTL?

Wed, Mar 20, 12:58 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Audiences-QA, Design, Page-Previews
Jdlrobson added a comment to T217296: Use the Overlay.make pattern for notification feature.

All patches are now up with the following next in line for reviews (neither blocking each other):
All events handlers are not part of the prototype
Make filters overlay using more modern techniques

Wed, Mar 20, 12:09 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Tue, Mar 19

Jdlrobson moved T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 10:05 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson added a comment to T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern.

I'm looking for an assignee on Add the AddTopicForm component

Tue, Mar 19, 10:05 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson assigned T218731: Regression: Mark all as read button in notifications overlay larger than header to Edtadros.
Tue, Mar 19, 10:04 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson moved T218731: Regression: Mark all as read button in notifications overlay larger than header from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 10:03 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson added a comment to T217296: Use the Overlay.make pattern for notification feature.

Next up: All events handlers are not part of the prototype

Tue, Mar 19, 9:56 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson added a comment to T212521: RFC: Let's stop using QUnit as a mechanism for integration tests.

To summarise what I'm hearing:

  • Unlike we'll get rid of all browser QUnit tests.
  • Selenium is slow
  • Easier to debug certain problems in browser
Tue, Mar 19, 9:42 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
Jdlrobson closed T143535: [EPIC] Improve article notes as Resolved.

Closing per discussion with Alex. All subtasks are complete.

Tue, Mar 19, 9:30 PM · Readers-Web-Backlog (Design), Epic, Design
Jdlrobson closed T143535: [EPIC] Improve article notes , a subtask of T147641: [EPIC] Improve top of the article user experience - mobile, as Resolved.
Tue, Mar 19, 9:30 PM · Readers-Web-Backlog (Design), Epic
Jdlrobson added a comment to T217296: Use the Overlay.make pattern for notification feature.

Use promisedView pattern for dealing with async wrapperWidget and Remove loading checks are next in the review queue.

Tue, Mar 19, 7:55 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson moved T218731: Regression: Mark all as read button in notifications overlay larger than header from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 7:51 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson created T218731: Regression: Mark all as read button in notifications overlay larger than header.
Tue, Mar 19, 7:42 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Growth-Team, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression
Jdlrobson moved T218653: Delete unneeded page-actions menu CSS/JS from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.
Tue, Mar 19, 7:26 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
Jdlrobson updated the task description for T218653: Delete unneeded page-actions menu CSS/JS.
Tue, Mar 19, 7:26 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
Jdlrobson moved T201339: Cannot access user contributions when following red link to user page on mobile from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 7:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, MobileFrontend
Jdlrobson added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

@JoeWalsh are we okay to merge the Minerva patch now (knowing that it won't go out until next Thursday (28th)) ?

Tue, Mar 19, 6:33 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
Jdlrobson assigned T186737: Let me choose whether to present a survey to logged-in or logged-out editors to Edtadros.
Tue, Mar 19, 5:12 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Research, QuickSurveys, Surveys
Jdlrobson reassigned T139317: Allow quicksurvey to target based on edit count from Jdlrobson to ovasileva.
Tue, Mar 19, 5:11 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), QuickSurveys
Jdlrobson assigned T218243: QuickSurveys will sometimes not show on mobile to ovasileva.

Olga to think about this

Tue, Mar 19, 5:01 PM · Mobile, QuickSurveys, Readers-Web-Backlog
Jdlrobson added a comment to T218243: QuickSurveys will sometimes not show on mobile.

We estimated this as a Large/Medium. Right now quick surveys checks if the mobile beta opt in panel is displayed. If it is, the survey doesn't show.

Tue, Mar 19, 5:00 PM · Mobile, QuickSurveys, Readers-Web-Backlog
Jdlrobson moved T218454: Mobile form for forced password change (due to new password requirements) has no label for the "Retype password" field from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Tue, Mar 19, 4:49 PM · Readers-Web-Backlog, MobileFrontend
Jdlrobson moved T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Tue, Mar 19, 4:49 PM · Readers-Web-Backlog, QuickSurveys
Jdlrobson updated the task description for T218243: QuickSurveys will sometimes not show on mobile.
Tue, Mar 19, 4:49 PM · Mobile, QuickSurveys, Readers-Web-Backlog
Jdlrobson updated the task description for T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field.
Tue, Mar 19, 4:42 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson moved T218627: Upgrade MobileWebMainMenuClickTracking to have an AMC field from Needs Analysis to Upcoming on the Readers-Web-Backlog board.
Tue, Mar 19, 3:16 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdlrobson moved T218653: Delete unneeded page-actions menu CSS/JS from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Tue, Mar 19, 3:16 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
Ammarpad awarded Blog Post: Migrating code from MediaWiki's ResourceLoader to Webpack a Love token.
Tue, Mar 19, 10:44 AM
Jdlrobson moved T211078: [Bug] Arrow in the "Jump to Top" circle is not centered on RTL wikis (βeta) from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 4:33 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Need-volunteer, good first bug, Mobile, MinervaNeue, RTL, I18n
Jdlrobson moved T218172: Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 4:32 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Wikimedia-production-error (Shared Build Failure), Multimedia, SDC Engineering, MobileFrontend, UploadWizard
Jdlrobson moved T213599: Clean up beta cluster mobile configuration from To Do to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 19, 4:32 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Wikimedia-Site-requests, Technical-Debt, Beta-Cluster-Infrastructure, MobileFrontend
Jdlrobson assigned T218173: [Bug/Regression] New talk topic edits are lost when I click browser back button to Edtadros.
Tue, Mar 19, 1:57 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson updated the task description for T218173: [Bug/Regression] New talk topic edits are lost when I click browser back button.
Tue, Mar 19, 1:23 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Technical-Debt, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson reassigned T213352: AMC: add history link to actions menu from Jdlrobson to Edtadros.
Tue, Mar 19, 1:22 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdlrobson added a comment to T217296: Use the Overlay.make pattern for notification feature.

Next up: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/495270

Tue, Mar 19, 1:20 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdlrobson assigned T215477: Tag Thanks actions with AMC tag to Edtadros.
Tue, Mar 19, 1:14 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team