Please reopen if the problem still exists :) Thanks for taking care of this!
Thanks for checking! Shall we resolve or do we want to wait until this hits production?
I made a fun little and practical app and have used it to fix 2 articles:
What page is that? Can you open a new task with the URL and project you are seeing it on? Thanks in advance!
This came up again today when changing 5 icons on the FlaggedRevisions extension (which pulled in OOjs UI). The critical path CSS on desktop for my local instance has jumped from 13.5kb to 32.7kb (after gzip). Without the icon packs (only oojs-ui-core styles) this drops to 21.3kb. All to render 2 icon (4 of the icons are interchangeable and never show at same time)
I looked into using Karma to run tests with the existing MobileFrontend setup for people that want to have test support in real browsers. We need to use Karma 3.1.4 (4 won't work with our current node 6). POC is here: POC: Show how Karma can be used to run node-qunit tests. I don't think it's something that my team would use but it shows that if running unit tests in real browsers is important to you it can be done.
@Geertivp I made two attempts in https://gerrit.wikimedia.org/r/451807 but both got reverted as I did something majorly wrong which broke production. I've not had time to look into the problem and fix it. You're welcome to take a look. Note when that does eventually get fixed this would apply to your account on mobile as well as tablet (although you could create separate accounts to work around that).
Hey @zhuyifei1999 we should see what we need to do to get a Chinese Wikivoyage up on the beta cluster today: https://zh.wikivoyage.beta.wmflabs.org/
I was hoping we could use Special:Preferences to change the interface language.
I reached out to some friends there.
https://gist.github.com/bnewbold/629cf2568a61a9da5f387eec46ee6aa4 should give you some pointers!
Fri, May 17
You can try testing this out on https://en.wikivoyage.beta.wmflabs.org/?uselang=zh !
Thu, May 16
@phuedx was wondering about the state of this today and whether we can remove the EventLogging code ($wgMinervaErrorLogSamplingRate) given recent developments.
@pmiazga leaving this one with you to determine if more work needed.
A CSS solution would be great, but I remember we did consider this back in the early days and there were quite a few of edge cases that were considered deal breakers, browser support (its much better now though) and concerns around performance (potentially unfounded) .
@Tgr is also here so hopefully we can grab him too and work out a way forward.
@simon04 I'll be wearing an internet archive hoodie and wikipedia t-shirt to help me be more findable if you want to look at this together. :)
The mobile web site has solved this problem so multimedia viewer just needs to follow the example given by it's code. We use mediawiki.router - making use of it is really not hard. The library needs to be imported and used. The fix is really simple.
Wed, May 15
I've made steps for 2 clearer.
For 3 you'll need to create a page located near you on the beta cluster (this will be helpful for future):
- Find a geolocation near you
- Go to Special:Nearby in production, visit a page near you and copy and paste the wikitext of that article to the beta cluster
- You can visit special:nearby and click button and get your location from the URL hash fragment (after # #/coord/50.0,14.4)
- Visit google maps and find a spot near you and find it in the URL there ( e.g. a URL https://www.google.com/maps/place/Pho+Originalfirstname.lastname@example.org,14.4300708,16z/data=!4m5!3m4!1s0x0:0x7049962427680a16!8m2!3d50.0721892!4d14.4371972 - the coordinates are 50.0718247,14.4300708 )
- Create a new article on the beta cluster with wikitext substituting 50 and 14 with your location or something near your location (you don't want to share your house!):
- go make a coffee (might take a few minutes for it to propagate)
Tue, May 14
To set expectations, TextExtracts is in maintenance mode so this is unlikely to get fixed by reading web team.
Hogan is no more 🦑🦑🦑🐳🎉🎉🎉
Fri, May 10
Doh, I missed two things :/
https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/509178 Additional icon resets for button elements fixes those.
Thu, May 9
Patches welcome. Extension was a GSoc project and right now I'm the only one who reviews patches and patches I submit to the repo don't get code reviewed so I don't submit them myself (and I prefer to avoid self merging if I can). I've been trying to find a maintainer to mentor/code review for, but sadly nothing has come about in that area yet.
@Cirdan honestly I feel this is a problem with mediawiki core and red link behaviour. It seems to me that user links should always link to view mode rather than action=edit. I guess we'd need to fix this in the MediaWiki parser.
Wed, May 8
Volker this is done right?
I think the edits to the description in https://phabricator.wikimedia.org/transactions/detail/PHID-XACT-TASK-ccksmfyydwihpcu/ should help with the remaining 2. IM me if not!
The module is 2.9kb of CSS after gzipping. Given the mobile site currently is 7.33kb of critical CSS, this is a large amount of CSS to add. We need to work out which bits of this are actually critical.
Tue, May 7
Im not following. The current branch causes UI regressions - small icons and badly styled buttons. These are caused by the reset cleanup that has been merged so far so will have to be fixed before we merge to master and QA. Im keen to merge this too and share your goals but I can't do that while these regressions exist.
(Web team do not maintain this extension)
The comments in T205341#5134218 still stand and will need to be resolved before we can prepare the patch for QA/ merge to master.
Hmm, this one is strange. The test that is failing ("Clicking on a watchstar toggles the watchstar") looks like it actually passes as clearly the watch star it is looking for is in the screenshot:
I can replicate in Timeless and Vector but not Minerva on a Samsung galaxy . More than likely a bug in jquery autocomplete which Minerva doesn't use
All the errors Ive seen are related to the mwbot library and token errors. The existing set of selenium tests do not seem to be exercising this library too much so my concern is that these bugs are going to continue as we add new tests due to a problem with using the mwbot library. It seems the methods in https://github.com/wikimedia/mediawiki/blob/135718b90478b94052a2575e60f38406366055e7/tests/selenium/wdio-mediawiki/Api.js were only being used in core before Minerva and MobileFrontend used and other extensions such as Cirrus use mwbot library directly without indirection.