Jdlrobson (Jon Robson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2014, 11:05 PM (193 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jdlrobson [ Global Accounts ]

Recent Activity

Today

Jdlrobson added a comment to T190549: Differentiate between internal, interwiki and external links visually.

Do we want to do a partial rollback or full rollback? Old icons for external links are pretty outdated in respect to the rest of our UI and it would be good to keep those at least. It seems the problem is only with the interwiki links? Is there a reason to roll back those as well?

Mon, Jul 23, 2:49 AM · User-notice, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog, UI-Standardization, Design
Jdlrobson moved T199157: [Spike 8hrs] Sticky header instrumentation from Upcoming to Current Sprint (and resolved 2018-19 Q1) on the Readers-Web-Backlog board.
Mon, Jul 23, 2:33 AM · Readers-Web-Kanbanana-Board, Analytics, Readers-Web-Backlog, MinervaNeue, Design
Jdlrobson moved T199964: Missing image or connection issues causes ImageOverlay to display unusable details bar from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:33 AM · MobileFrontend, Readers-Web-Backlog
Jdlrobson moved T199854: Remove use of deprecated $wgResourceLoaderLESSVars in MobileFrontend from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:33 AM · Readers-Web-Backlog, Technical-Debt (RW-Tech-Debt), MobileFrontend
Jdlrobson moved T198759: Vector menu tabs animates in-and-out twice instead of once before settling from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:33 AM · Readers-Web-Backlog, Performance-Team (Radar), Regression, Vector
Jdlrobson moved T200093: Use Paint Timing API instead of deprecated chrome.loadTimes() from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:31 AM · MediaWiki-extensions-WikimediaEvents, Technical-Debt, Readers-Web-Backlog
Jdlrobson merged task T199820: Contents of MediaWiki:Mobile.css don't get loaded if JavaScript is disabled into T190083: Make MediaWiki:Mobile.css render-blocking.
Mon, Jul 23, 2:31 AM · Readers-Web-Backlog, MobileFrontend
Jdlrobson merged T199820: Contents of MediaWiki:Mobile.css don't get loaded if JavaScript is disabled into T190083: Make MediaWiki:Mobile.css render-blocking.
Mon, Jul 23, 2:31 AM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Performance-Team (Radar), MobileFrontend
Jdlrobson updated the task description for T190083: Make MediaWiki:Mobile.css render-blocking.
Mon, Jul 23, 2:31 AM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Performance-Team (Radar), MobileFrontend
Jdlrobson triaged T199855: WikidataPageBanner breaks Vector page subtitle as Low priority.

This feels like an incorrectly configured WikidataPageBanner setup. Will look at setup on test wiki shortly.

Mon, Jul 23, 2:29 AM · User-Jdlrobson, Readers-Web-Backlog, Regression, Wikidata, Wikidata-Page-Banner
Jdlrobson moved T195880: Problems with external referrals? from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:26 AM · Readers-Web-Backlog, Analytics
Jdlrobson moved T199855: WikidataPageBanner breaks Vector page subtitle from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:26 AM · User-Jdlrobson, Readers-Web-Backlog, Regression, Wikidata, Wikidata-Page-Banner
Jdlrobson moved T198579: Popups triggers "deprecated ResourceLoader module jquery.hidpi" on several pages from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Jul 23, 2:26 AM · Readers-Web-Backlog, Page-Previews
Jdlrobson added a comment to T63737: Thank notification on mobile should support click to undo.

Note, it is not necessary to use the toast component. It's just a wrapper for mw.notify which has Minerva specific styling.

Mon, Jul 23, 2:12 AM · Growth-Team, Patch-For-Review, Readers-Web-Backlog, Mobile, Thanks

Fri, Jul 20

Niedzielski awarded T156186: MobileFrontend should not have a global event emitter a Like token.
Fri, Jul 20, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), MobileFrontend (MobileFrontend.js), Technical-Debt (RW-Tech-Debt), Readers-Web-Backlog

Mon, Jul 16

Jhernandez awarded T199004: RFC: Add a language agnostic build step to skins/extensions to our deploy process a Like token.
Mon, Jul 16, 2:22 PM · TechCom-RFC, RfC, User-Jdlrobson

Fri, Jul 13

Jdlrobson updated subscribers of T197932: Display section issues modal.

@Alex @Stephen i looked into the section issue. Looks like it's going to be very tricky to show subsection issues separately.
https://gerrit.wikimedia.org/r/445667 adds some consistency between editor sections and issues sections but doesn't resolve the subsection issues. I'm not sure whether that's worth pursuing.

Fri, Jul 13, 9:15 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
pmiazga awarded T199004: RFC: Add a language agnostic build step to skins/extensions to our deploy process a Yellow Medal token.
Fri, Jul 13, 8:05 PM · TechCom-RFC, RfC, User-Jdlrobson
Jdlrobson placed T197932: Display section issues modal up for grabs.

@Niedzielski has pointed out that the implementation is wrong. http://readers-web-master.wmflabs.org/w/index.php?title=Pharmacovigilance&mobileaction=toggle_view_mobile#/issues/5 shows all issues in subsections as well
Also the url suggests the issues are in section 5, but actually they are in section 27 (note the url when you click the edit icon)

.

Fri, Jul 13, 6:33 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson moved T197932: Display section issues modal from Needs Design Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Fri, Jul 13, 6:31 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson added projects to T199004: RFC: Add a language agnostic build step to skins/extensions to our deploy process: RfC, TechCom-RFC.

I'm adding these tags to get more eyeballs and hear concerns. Note, I'll be traveling for some of July (like many others) so it may be best to delay any conversations until August. Looking forward to some async/sync conversation!

Fri, Jul 13, 6:10 PM · TechCom-RFC, RfC, User-Jdlrobson
Jdlrobson updated the task description for T199004: RFC: Add a language agnostic build step to skins/extensions to our deploy process.
Fri, Jul 13, 6:07 PM · TechCom-RFC, RfC, User-Jdlrobson
Jdlrobson reassigned T199482: Properly handle the networking errors and aborted requests from pmiazga to ABorbaWMF.

Skipping design review. @Ryasmeen @ABorbaWMF could we do a generic page previews QA for error handling? We'll want to check that page previews do not show when the user's connection drops and continue to show when the connection is live. I've added some QA notes, let me know if I can help with anything more.

Fri, Jul 13, 5:33 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson updated the task description for T199482: Properly handle the networking errors and aborted requests.
Fri, Jul 13, 5:33 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson moved T199482: Properly handle the networking errors and aborted requests from Ready for Signoff to Needs QA on the Readers-Web-Kanbanana-Board board.
Fri, Jul 13, 5:29 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson moved T199482: Properly handle the networking errors and aborted requests from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Fri, Jul 13, 5:28 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson assigned T197932: Display section issues modal to alexhollender.

On staging for design review!

Fri, Jul 13, 5:28 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson moved T197932: Display section issues modal from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Fri, Jul 13, 5:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson added a comment to T198990: It should be possible to delete an entry by title from a reading list.

This gets dropped when you use a generator... another bug? https://en.wikipedia.org/w/api.php?action=query&format=json&generator=readinglistentries&prop=pageimages&piprop=thumbnail&pithumbsize=200&formatversion=2&grlelists=363635

Fri, Jul 13, 5:04 PM · Reading List Service, Reading-Infrastructure-Team-Backlog, User-Jdlrobson

Thu, Jul 12

Jdlrobson triaged T195053: Reduce page jumps in table of contents as Normal priority.
Thu, Jul 12, 11:03 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson moved T199482: Properly handle the networking errors and aborted requests from To Do to Needs More Work on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 11:02 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson triaged T199482: Properly handle the networking errors and aborted requests as Normal priority.
Thu, Jul 12, 11:02 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson moved T199482: Properly handle the networking errors and aborted requests from Needs Analysis to Current Sprint (and resolved 2018-19 Q1) on the Readers-Web-Backlog board.
Thu, Jul 12, 11:02 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson triaged T199452: Introduce webpack config/node-qunit and port ModuleLoader as Normal priority.
Thu, Jul 12, 11:02 PM · Readers-Web-Backlog
Jdlrobson moved T199004: RFC: Add a language agnostic build step to skins/extensions to our deploy process from Inbox to Next up on the User-Jdlrobson board.
Thu, Jul 12, 10:57 PM · TechCom-RFC, RfC, User-Jdlrobson
Jdlrobson moved T191528: Mobile page issues - allow page issues to display different severity levels from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 10:13 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Jdlrobson moved T199482: Properly handle the networking errors and aborted requests from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, Jul 12, 10:13 PM · Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog, Page-Previews
Jdlrobson added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

mw-ui-icon-minerva-issue-severity-medium-mediumColor looks blurry to me when rendered as a small icon


Is that intentional?

Thu, Jul 12, 10:03 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Jdlrobson assigned T198663: Page preview margins should be consistent to alexhollender.
Thu, Jul 12, 9:39 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson added a comment to T198663: Page preview margins should be consistent.

@Jdlrobson is there extra space getting added somewhere? I'm measuring 30px instead of 25px.

Thu, Jul 12, 9:38 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson updated the task description for T198663: Page preview margins should be consistent.
Thu, Jul 12, 9:30 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson added a comment to T197700: Do not fire/abort AJAX request when it is not necessary.

@phuedx: I expect this number to go down and these numbers to all increase.

It looks like this happened..

Thu, Jul 12, 7:29 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson added a comment to T199005: Talk overlay "issues" are not visible in A/B test.

@alexhollender ideally yes although Olga has already said this is all out of scope for the issues project. We would want to do a similar Jan style audit of all the templates before starting that adventure.

Thu, Jul 12, 3:44 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson moved T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva from To Do to Quarterly Goals on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 3:18 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson moved T195478: [EPIC] Speed up unit test execution and increase code coverage from To Do to Quarterly Goals on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 3:18 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson moved T195478: [EPIC] Speed up unit test execution and increase code coverage from Epics/Goals to Current Sprint (and resolved 2018-19 Q1) on the Readers-Web-Backlog board.
Thu, Jul 12, 3:18 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson moved T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva from Epics/Goals to Current Sprint (and resolved 2018-19 Q1) on the Readers-Web-Backlog board.
Thu, Jul 12, 3:18 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson added a project to T195478: [EPIC] Speed up unit test execution and increase code coverage: Readers-Web-Kanbanana-Board.
Thu, Jul 12, 3:18 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson added a project to T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva: Readers-Web-Kanbanana-Board.
Thu, Jul 12, 3:17 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson added a subtask for T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva: T199452: Introduce webpack config/node-qunit and port ModuleLoader.
Thu, Jul 12, 3:17 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson added a parent task for T199452: Introduce webpack config/node-qunit and port ModuleLoader: T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva.
Thu, Jul 12, 3:17 PM · Readers-Web-Backlog
Jdlrobson added a subtask for T195478: [EPIC] Speed up unit test execution and increase code coverage: T199452: Introduce webpack config/node-qunit and port ModuleLoader.
Thu, Jul 12, 3:17 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Epic, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Jdlrobson added a parent task for T199452: Introduce webpack config/node-qunit and port ModuleLoader: T195478: [EPIC] Speed up unit test execution and increase code coverage.
Thu, Jul 12, 3:17 PM · Readers-Web-Backlog
Jdlrobson updated subscribers of T111329: [GOAL] Page previews on mobileweb.

@ovasileva is this really high priority...?

Thu, Jul 12, 3:17 PM · Readers-Web-Backlog, Reading Epics (Page Previews), Goal, Page-Previews
Jdlrobson created T199452: Introduce webpack config/node-qunit and port ModuleLoader.
Thu, Jul 12, 3:16 PM · Readers-Web-Backlog
Jdlrobson added a comment to T186760: Provide a feature flagged way for logged in users to disable mobile optimisations.

https://gerrit.wikimedia.org/r/445301 needs review.

Thu, Jul 12, 3:06 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, MobileFrontend
Jdlrobson moved T198663: Page preview margins should be consistent from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Jul 12, 3:05 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson moved T199351: [Bug] Lazily loaded inline images cause reflow - should retain thumbborder from Needs Analysis to Triaged but Future on the Readers-Web-Backlog board.
Thu, Jul 12, 3:04 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson renamed T199351: [Bug] Lazily loaded inline images cause reflow - should retain thumbborder from [Bug] Lazily loaded images cause reflow to [Bug] Lazily loaded inline images cause reflow - should retain thumbborder.
Thu, Jul 12, 3:04 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson added a project to T199429: Special:Contributions&target= fails on mobile: Readers-Web-Backlog (Tracking).

Known issue. The mobile substitution was only meant to be temporary. A big overhaul of the special page in core is needed (see T122305) but that's a big time investment (which might happen this year). We are not planning to invest any more time in this alternate version of the page.

Thu, Jul 12, 2:55 PM · Readers-Web-Backlog (Tracking), MediaWiki-Special-pages, MobileFrontend
Jdlrobson added a subtask for T122305: [EPIC] Make Special:Contributions in core mobile friendly: T199429: Special:Contributions&target= fails on mobile.
Thu, Jul 12, 2:53 PM · Readers-Web-Backlog (Tracking), Category, Epic, MediaWiki-Special-pages
Jdlrobson added a parent task for T199429: Special:Contributions&target= fails on mobile: T122305: [EPIC] Make Special:Contributions in core mobile friendly.
Thu, Jul 12, 2:53 PM · Readers-Web-Backlog (Tracking), MediaWiki-Special-pages, MobileFrontend
Jdlrobson added a comment to T198990: It should be possible to delete an entry by title from a reading list.

Nope. There is no mention of read list entries ids in response:

Thu, Jul 12, 2:37 PM · Reading List Service, Reading-Infrastructure-Team-Backlog, User-Jdlrobson
Jdlrobson added a comment to T193505: Remove MobileWebMainMenuClickTracking schema from mobile.

Thanks for checking @Tbayer ! So it looks like this is working as it's returning results for all the things I'd expect it to be. Note, schema is quite flexible so it could also be used in future for logging any new items we add to the menu.

Thu, Jul 12, 2:33 PM · Readers-Web-Backlog, MinervaNeue (Desktop)
Jdlrobson updated the task description for T193505: Remove MobileWebMainMenuClickTracking schema from mobile.
Thu, Jul 12, 2:32 PM · Readers-Web-Backlog, MinervaNeue (Desktop)
Jdlrobson updated the task description for T193505: Remove MobileWebMainMenuClickTracking schema from mobile.
Thu, Jul 12, 2:31 PM · Readers-Web-Backlog, MinervaNeue (Desktop)
Jdlrobson added a comment to T197931: Truncate page issues.

Also agree. We could however limit the effect and truncation to below the tablet threshold if that makes sense...

Thu, Jul 12, 2:20 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson closed T198818: Pagebanner positioning doesn't work on RTL wikis as Resolved.

Thanks for confirming! This will be deployed in 1.32.wmf.13 currently planned for July 17th (https://wikitech.wikimedia.org/wiki/Deployments)

Thu, Jul 12, 2:18 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Wikidata, Wikidata-Page-Banner, Readers-Web-Backlog, I18n, RTL, Mobile
Jdlrobson added a comment to T199349: [Bug] Small images should be eagerly loaded.

Okay got it. Is there some way in the code/project page we can document this so it's more obvious? It has come up a few times before as unexpected.

Thu, Jul 12, 2:16 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson added a comment to T198115: Links should not be clickable in mobile page issue element.

In page previews we have a cached api with lots of complexity and corresponding tests. Regarding links we traverse the DOM and replace them with spans copying over all the elements on them. We could add similar code in to mobile web and in javascript rewrite the banner DOM. Note there may be edge cases that are not obvious so we would expect/ need to do some further QA. Would you like me to create a task for doing all that?

Thu, Jul 12, 2:13 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson added a comment to T193505: Remove MobileWebMainMenuClickTracking schema from mobile.

How likely is it that the instrumentation is broken at this point?

I dont seem to have access to it but we would be able to determine if it's still working quite quickly by checking if new entries are coming in for every single item in the main menu.

Thu, Jul 12, 2:13 AM · Readers-Web-Backlog, MinervaNeue (Desktop)

Wed, Jul 11

Jdlrobson added a comment to T197931: Truncate page issues.

A few bits of feedback on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/445143/
The fade looks a bit large to me


Especially for italin wikipedia:

Wed, Jul 11, 11:55 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson added a comment to T199349: [Bug] Small images should be eagerly loaded.

What does "eagerly loaded" mean in this context? I'm not understanding the bug here.
Right now images will be lazily load as soon as they are scrolled into view. Are you saying that they should be loaded by some other heuristic?

Wed, Jul 11, 11:44 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson closed T185835: Lazy loading images causes performance issues with section uncollapsing on Firefox for Android as Resolved.

Seems like the solution here was to use wgMFLazyLoadSkipSmallImages = true;

Wed, Jul 11, 11:42 PM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, Performance-Team (Radar), Performance, MinervaNeue
Jdlrobson added a comment to T199351: [Bug] Lazily loaded inline images cause reflow - should retain thumbborder.

It may also relate to T162623, T159100, T160527, T159477. We should investigate precisely what's going on here to work out whether any of those are related.

Wed, Jul 11, 11:23 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson added a comment to T199351: [Bug] Lazily loaded inline images cause reflow - should retain thumbborder.

Duplicate of T197188?

Wed, Jul 11, 11:20 PM · MobileFrontend, Readers-Web-Backlog
Jdlrobson moved T195053: Reduce page jumps in table of contents from Needs Reproduction to Current Sprint (and resolved 2018-19 Q1) on the Readers-Web-Backlog board.
Wed, Jul 11, 11:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson moved T195053: Reduce page jumps in table of contents from Needs Analysis to Needs Reproduction on the Readers-Web-Backlog board.
Wed, Jul 11, 11:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson moved T195053: Reduce page jumps in table of contents from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Jul 11, 11:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson added a comment to T198818: Pagebanner positioning doesn't work on RTL wikis.

@Baloch007 could you please confirm this is working as expected on our test server?:
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en
https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=ps

Wed, Jul 11, 11:11 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Wikidata, Wikidata-Page-Banner, Readers-Web-Backlog, I18n, RTL, Mobile
Jdlrobson added a comment to T195053: Reduce page jumps in table of contents.

Is CSS-based solution entirely accessible? Here it says that IE11 doesn’t read CSS content.

If we wanted to, I could see us addressing this by only using the CSS temporarily and disabling the pseudo selector of toctogglelabel and adding the text to the label in JS.

Wed, Jul 11, 11:00 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson updated the task description for T197719: Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects.
Wed, Jul 11, 9:27 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Page-Previews, Readers-Web-Backlog
Jdlrobson moved T197719: Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Wed, Jul 11, 9:27 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Page-Previews, Readers-Web-Backlog
Jdlrobson awarded T198974: Rate-limit is too harsh and affects human users a Love token.
Wed, Jul 11, 9:26 PM · Patch-For-Review, Phabricator
Jdlrobson added a comment to T198115: Links should not be clickable in mobile page issue element.

The real problem here is the content we are printing has links (whether we like it or not). This is not going to change unless we talk to editors about that. If we don't talk, any solution we come up with is going to involve accessibility or performance problems or tech debt or all three of those things.

Wed, Jul 11, 9:24 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson assigned T197719: Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects to alexhollender.
Wed, Jul 11, 9:17 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Page-Previews, Readers-Web-Backlog
Jdlrobson placed T198663: Page preview margins should be consistent up for grabs.
Wed, Jul 11, 9:15 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jdlrobson placed T197932: Display section issues modal up for grabs.
Wed, Jul 11, 9:15 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson moved T197932: Display section issues modal from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Jul 11, 9:15 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson moved T195053: Reduce page jumps in table of contents from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Wed, Jul 11, 9:07 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson assigned T195053: Reduce page jumps in table of contents to alexhollender.
Wed, Jul 11, 9:07 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson updated the task description for T195053: Reduce page jumps in table of contents.
Wed, Jul 11, 9:05 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson added a comment to T195053: Reduce page jumps in table of contents.

^ @Fomafix @matmarex not sure if this is necessary as cannot replicate but might want to merge this to be safe.

Wed, Jul 11, 9:04 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson added a comment to T195053: Reduce page jumps in table of contents.

Patch got merged from a volunteer so this should go through some QA.
Note, momentarily I saw two toggles:


That said I haven't been able to reproduce this.

Wed, Jul 11, 9:02 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson added a project to T195053: Reduce page jumps in table of contents: Readers-Web-Kanbanana-Board.
Wed, Jul 11, 8:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Jdlrobson added a comment to T197932: Display section issues modal.
Would it be possible to have the title of the modal be "Section issues" for section issues? My apologies for not thinking of that earlier.

Note certain templates in the lead section do not apply to the entire page e.g. https://en.m.wikipedia.org/wiki/Template:Lead_rewrite
This is technical a "Section issue", no?
e.g. http://reading-web-staging.wmflabs.org/wiki/Politics_of_Ethiopia#/issues/0
How to handle these? Would "Page issues" be confusing here?

Wed, Jul 11, 8:54 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson added a comment to T192033: Older skins no longer bold Self links.

@Ahecht this is how Minerva displays selflinks. Skins are free to style things differently :) The bold is a Vector/Monobook thing.
This bug is about skins that are display selflinks the same as normal links.

Wed, Jul 11, 8:48 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Modern, Patch-For-Review, Timeless
Jdlrobson updated the task description for T198619: Send the Accept-Language header with RESTBase API request for page preview requests.
Wed, Jul 11, 8:33 PM · Chinese-Sites, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Services (blocked), Readers-Web-Backlog, Page-Previews
Jdlrobson added a comment to T198115: Links should not be clickable in mobile page issue element.

I'm inclined to say that we should strip the links entirely. Hiding/disabling them (as we're currently doing) seems a bit hacky to me in the first place. I'm weary of adding more cost here. Unplanned edge cases are obviously hard to identify in advance, but any inclinations of what we'd potentially have to deal with if we flattened them?

Wed, Jul 11, 8:05 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdlrobson updated the task description for T198818: Pagebanner positioning doesn't work on RTL wikis.
Wed, Jul 11, 7:42 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Wikidata, Wikidata-Page-Banner, Readers-Web-Backlog, I18n, RTL, Mobile