User Details
User Details
- User Since
- Nov 6 2014, 11:05 PM (272 w, 18 h)
- Availability
- Available
- IRC Nick
- jdlrobson
- LDAP User
- Unknown
- MediaWiki User
- Jdlrobson [ Global Accounts ]
Tue, Jan 21
Tue, Jan 21
Mon, Jan 20
Mon, Jan 20
Jdlrobson added a comment to T242310: Regression: issues with MobileDiff.
To me it seems easier to read when the background color covers the entire paragraph, rather than leaving white gaps between each line.
The patch above should take care of this.
TIL about being able to overlay visual metrics screenshots (and documented on https://grafana.wikimedia.org/d/000000205/mobile-2g?orgId=1). Really helpful ! thanks @Krinkle
Jdlrobson added a comment to T171701: Use better site navigation on large screens for Minerva.
+1 to a center aligned logo!!
Jdlrobson removed a project from T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff): Structured-Data-Backlog.
Note we don't support the new diff type officially on desktop. That's blocked on T240608.
Jdlrobson updated the task description for T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile.
Jdlrobson renamed T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile from Possible Regression(?): Move paragraph diff doesn't seem to be rendering correctly. to Regression: Desktop diff styles for moved paragraphs load alongside mobile.
Jdlrobson updated subscribers of T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile.
FYI @alexhollender
Jdlrobson updated the task description for T240608: Standardise a control for switching diff types from side by side to inline/visual.
Jdlrobson updated the task description for T242784: Regression: Watchstar CTA fails to display properly 2nd and 3rd time.
Jdlrobson moved T237019: Spacing between icons and labels is too large in tablet mode from Needs Code Review to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
@alexhollender please can you take a look on http://readingwebstaging.wmflabs.org/wiki/Seoul?useskin=minerva&useformat=mobile and then move this back to code review
Jdlrobson added projects to T191156: Convert FlaggedRevisions to OOUI: Mobile, MinervaNeue (Tracking).
Thanks this matches what I see. For completeness @matmarex fixed this when as part of Bug: T232237 he moved the schema into mobile.init. The mobile.init module only ever loads on mobile. It should never run on desktop (see I72799083e31bc6dad5d6e5b2a2437ea5a7300497)
Sat, Jan 18
Sat, Jan 18
Kaartic awarded T117736: Convert Special:Contributions to OOUI a Love token.
Jdlrobson added a comment to T236097: Dev: Popups modules should set targets to mobile and desktop.
Jdlrobson edited projects for T214641: The LoadingOverlay and src/mobile.startup/rlModuleLoader.js pattern should be removed - it results in overlay flashes during switches, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking).
The above three patches should take care of this problem for the last remaining overlay and then prevent it from every happening again.
Fri, Jan 17
Fri, Jan 17
Jdlrobson edited projects for T212542: Deprecate use of M.require( 'mobile.startup/toast' ), added: Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking).
Jdlrobson closed T195473: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture as Resolved.
This project is no longer being worked on. The epic T195482: [EPIC] Review and refactor MobileFrontend components used by Minerva more than captures the remaining work here.
Jdlrobson closed T144402: Extract MobileFrontend UI components to an external well documented library as Declined.
At this point if we want we can publish MobileFrontend's library to npm, but I'm not sure if there are any benefits to doing so.
Jdlrobson edited projects for T153473: [Spike] How should we organize and manage our ResourceLoader modules?, added: Desktop Improvements, Vector, Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking).
We never answered this in the MobileFrotnend architecture project but seems even more important now as we build out Vector.
Jdlrobson updated the task description for T162196: Use standardised ajax loader and refresh icon in ConfirmEdit.
This is now resolved. Minerva will work without MobileFrontend 🎉
Jdlrobson edited projects for T216182: Make CategoryTabs a dumb component, added: MobileFrontend; removed MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue.
Jdlrobson moved T222881: [subtask] Move list specific rules to 'ui.less'/'lists.less' from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T206774: iOS Universal Links banner pushes toasts partially off-screen from Backlog to Blocked on Discussion on the MinervaNeue board.
Jdlrobson added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.
Is this still an issue in Safari 13?
Jdlrobson moved T198011: Transcluded section edit links are broken in Minerva from Backlog to Tracking on the MinervaNeue board.
Jdlrobson moved T202070: [Bug] Only one loading indicator is needed when saving an edit from Backlog to Tracking on the MinervaNeue board.
Jdlrobson edited projects for T207789: [Bug] Fix <header> & #heading-holder design elements from breaking at large default font sizes, added: Readers-Web-Backlog (Design); removed Readers-Web-Backlog.
Jdlrobson closed T217718: MinveraNeue: Evaluate using MW core shared.css in styles coverage and performance as Resolved.
We are breaking ResourceLoaderSkinModule into chunks that a skin can choose to pick up. A solution for T217616 now exists.
Jdlrobson moved T208827: It should be possible to view source on protected pages in MobileFrontend Minerva from Backlog to Bugs on the MinervaNeue board.
Jdlrobson moved T208828: Link with other language from mobile view from Backlog to Tracking on the MinervaNeue board.
Jdlrobson moved T209015: VisualEditor on mobile: Toolbar should be reduced in height from Backlog to Tracking on the MinervaNeue board.
Jdlrobson moved T209917: Re-evaluate `-webkit-text-size-adjust` value `none` from Backlog to Blocked on Discussion on the MinervaNeue board.
Jdlrobson moved T217620: [subtask] Remove table and table elements default font-size setting from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217622: [subtask] Move form specific selectors to their own LESS file from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217626: [subtask] Move headings specific styles to 'headings.less' from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217630: [subtask] Move sensitive `img` styles to 'images.less' from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217629: [subtask] Move `audio` and `video` styles out of 'reset.less' from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217631: [subtask] Remove unnecessary reset text rules from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson moved T217875: [subtask] Move ul selector out of reset and evaluate removing list bullet from Backlog to Code organisation on the MinervaNeue board.
Jdlrobson edited projects for T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers., added: MobileFrontend; removed MinervaNeue.
Jdlrobson moved T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers. from Backlog to Bugs on the MinervaNeue board.
Jdlrobson moved T221194: Search input of overlay is not tab-able, inaccessible by alternative input users from Backlog to Bugs on the MinervaNeue board.
Jdlrobson moved T222889: [subtask] Remove remaining 'reset.less' from Tech debt to Code organisation on the MinervaNeue board.
Jdlrobson moved T227073: Inventory MobileFrontend/MinervaNeue browser tests from Tech debt to Code organisation on the MinervaNeue board.
Jdlrobson moved T226490: Remove MinervaPageActions config flag? from Backlog to Tech debt on the MinervaNeue board.
Jdlrobson moved T222889: [subtask] Remove remaining 'reset.less' from Bugs to Tech debt on the MinervaNeue board.
Jdlrobson moved T222889: [subtask] Remove remaining 'reset.less' from Backlog to Bugs on the MinervaNeue board.
Jdlrobson renamed T226490: Remove MinervaPageActions config flag? from Minerva Discussion tab do not respect MinervaPageActions config flag to Remove MinervaPageActions config flag?.
Jdlrobson closed T229031: Flaky wdio test: MinervaNeue/history_steps "Page diff Added and removed content" as Resolved.
Haven't seen this flake in a long time.
Jdlrobson moved T229568: Apply consistent small font-sizes in MobileFrontend/MinervaNeue from Backlog to Blocked on Discussion on the MinervaNeue board.
Jdlrobson added a project to T232229: PageList descriptions too small font and line height: Readers-Web-Backlog (Design).
Guidance needed.
Jdlrobson moved T232383: Consolidate MinervaNeue's ToC icon with OOUI's from Backlog to Blocked on Discussion on the MinervaNeue board.
Jdlrobson renamed T237603: Add an Edit section button in MobileFrontend's TalkSectionOverlay component from Add an Edit section button in sections in the rendered talk page in mobile view to Add an Edit section button in MobileFrontend's TalkSectionOverlay component.
Jdlrobson moved T240624: Style desktop Minerva diff page to look like Special:MobileDiff from Backlog to Tech debt on the MinervaNeue board.
Jdlrobson moved T240757: Visual Editor in Desktop Minerva: Text and icon overlaid from Backlog to Tracking on the MinervaNeue board.
Jdlrobson moved T240807: Change footer of mobile from Backlog to Blocked on Discussion on the MinervaNeue board.
Jdlrobson moved T240910: Link for PageTriage in tool menu looks broken in MinervaNeue from Backlog to Tracking on the MinervaNeue board.
Jdlrobson renamed T241402: Minerva talk pages show no discussions if certain elements are present from mobile web talk pages show no discussions if certain elements are present to Minerva talk pages show no discussions if certain elements are present.
Jdlrobson removed a project from T241402: Minerva talk pages show no discussions if certain elements are present: Mobile-Web-Settings.
Jdlrobson added a project to T219210: Move the "Publish" button in mobile the Talk > Reply UI to the header: Talk Pages.
cc @ppelberg
Jdlrobson edited projects for T235253: Tags on article talk shift the page in Mobile Read as wiki page, added: Reading-Web-Local-Wiki-Issues; removed Readers-Web-Backlog (Design).
This has nothing to do with mobile or Minerva. The template in the talk page is what's causing the rendering issue. This is precisely why the "read as wiki page" button exists. When clicking it you are risking these sorts of changes. Please fix on wiki.
Jdlrobson edited projects for T241402: Minerva talk pages show no discussions if certain elements are present, added: Readers-Web-Backlog (Design); removed Readers-Web-Backlog.
Jdlrobson moved T190569: Most images are not centered at mobile screen widths in Parsoid HTML from Blocked on design to Tracking on the MinervaNeue board.
Jdlrobson added a comment to T190569: Most images are not centered at mobile screen widths in Parsoid HTML.
If this task is still relevant the URI in the description should be updated so we have a frame of reference.
Jdlrobson moved T172626: Minerva skin styles conflict with content using CSS class "header" from Blocked on design to Tech debt on the MinervaNeue board.
Jdlrobson moved T241402: Minerva talk pages show no discussions if certain elements are present from Backlog to Blocked on design on the MinervaNeue board.
No subtasks exist anymore.
Jdlrobson moved T177053: Optimize Minerva for iPhone X viewport from Tracking to Blocked on design on the MinervaNeue board.
Jdlrobson edited projects for T171701: Use better site navigation on large screens for Minerva, added: Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements; removed Readers-Web-Backlog (Design).
Good to think about as we go into the desktop refresh where there's a hamburger given @Nirzar's suggestion that "The hamburger menu UI pattern is not meant for desktops or tablets"