Do we want to do a partial rollback or full rollback? Old icons for external links are pretty outdated in respect to the rest of our UI and it would be good to keep those at least. It seems the problem is only with the interwiki links? Is there a reason to roll back those as well?
This feels like an incorrectly configured WikidataPageBanner setup. Will look at setup on test wiki shortly.
Note, it is not necessary to use the toast component. It's just a wrapper for mw.notify which has Minerva specific styling.
Fri, Jul 20
Mon, Jul 16
Fri, Jul 13
@Alex @Stephen i looked into the section issue. Looks like it's going to be very tricky to show subsection issues separately.
https://gerrit.wikimedia.org/r/445667 adds some consistency between editor sections and issues sections but doesn't resolve the subsection issues. I'm not sure whether that's worth pursuing.
@Niedzielski has pointed out that the implementation is wrong. http://readers-web-master.wmflabs.org/w/index.php?title=Pharmacovigilance&mobileaction=toggle_view_mobile#/issues/5 shows all issues in subsections as well
Also the url suggests the issues are in section 5, but actually they are in section 27 (note the url when you click the edit icon)
I'm adding these tags to get more eyeballs and hear concerns. Note, I'll be traveling for some of July (like many others) so it may be best to delay any conversations until August. Looking forward to some async/sync conversation!
Skipping design review. @Ryasmeen @ABorbaWMF could we do a generic page previews QA for error handling? We'll want to check that page previews do not show when the user's connection drops and continue to show when the connection is live. I've added some QA notes, let me know if I can help with anything more.
On staging for design review!
This gets dropped when you use a generator... another bug? https://en.wikipedia.org/w/api.php?action=query&format=json&generator=readinglistentries&prop=pageimages&piprop=thumbnail&pithumbsize=200&formatversion=2&grlelists=363635
Thu, Jul 12
mw-ui-icon-minerva-issue-severity-medium-mediumColor looks blurry to me when rendered as a small icon
Is that intentional?
@phuedx: I expect this number to go down and these numbers to all increase.
It looks like this happened..
@alexhollender ideally yes although Olga has already said this is all out of scope for the issues project. We would want to do a similar Jan style audit of all the templates before starting that adventure.
@ovasileva is this really high priority...?
https://gerrit.wikimedia.org/r/445301 needs review.
Known issue. The mobile substitution was only meant to be temporary. A big overhaul of the special page in core is needed (see T122305) but that's a big time investment (which might happen this year). We are not planning to invest any more time in this alternate version of the page.
Nope. There is no mention of read list entries ids in response:
Thanks for checking @Tbayer ! So it looks like this is working as it's returning results for all the things I'd expect it to be. Note, schema is quite flexible so it could also be used in future for logging any new items we add to the menu.
Also agree. We could however limit the effect and truncation to below the tablet threshold if that makes sense...
Thanks for confirming! This will be deployed in 1.32.wmf.13 currently planned for July 17th (https://wikitech.wikimedia.org/wiki/Deployments)
Okay got it. Is there some way in the code/project page we can document this so it's more obvious? It has come up a few times before as unexpected.
How likely is it that the instrumentation is broken at this point?
I dont seem to have access to it but we would be able to determine if it's still working quite quickly by checking if new entries are coming in for every single item in the main menu.
Wed, Jul 11
A few bits of feedback on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/445143/
The fade looks a bit large to me
Especially for italin wikipedia:
What does "eagerly loaded" mean in this context? I'm not understanding the bug here.
Right now images will be lazily load as soon as they are scrolled into view. Are you saying that they should be loaded by some other heuristic?
Seems like the solution here was to use wgMFLazyLoadSkipSmallImages = true;
Duplicate of T197188?
@Baloch007 could you please confirm this is working as expected on our test server?:
Is CSS-based solution entirely accessible? Here it says that IE11 doesn’t read CSS content.
If we wanted to, I could see us addressing this by only using the CSS temporarily and disabling the pseudo selector of toctogglelabel and adding the text to the label in JS.
The real problem here is the content we are printing has links (whether we like it or not). This is not going to change unless we talk to editors about that. If we don't talk, any solution we come up with is going to involve accessibility or performance problems or tech debt or all three of those things.
Patch got merged from a volunteer so this should go through some QA.
Note, momentarily I saw two toggles:
That said I haven't been able to reproduce this.
Would it be possible to have the title of the modal be "Section issues" for section issues? My apologies for not thinking of that earlier.
Note certain templates in the lead section do not apply to the entire page e.g. https://en.m.wikipedia.org/wiki/Template:Lead_rewrite
This is technical a "Section issue", no?
How to handle these? Would "Page issues" be confusing here?
@Ahecht this is how Minerva displays selflinks. Skins are free to style things differently :) The bold is a Vector/Monobook thing.
This bug is about skins that are display selflinks the same as normal links.
I'm inclined to say that we should strip the links entirely. Hiding/disabling them (as we're currently doing) seems a bit hacky to me in the first place. I'm weary of adding more cost here. Unplanned edge cases are obviously hard to identify in advance, but any inclinations of what we'd potentially have to deal with if we flattened them?