Staff software engineer at WMF
- User Since
- Nov 6 2014, 11:05 PM (438 w, 19 h)
- IRC Nick
- LDAP User
- MediaWiki User
- Jdlrobson [ Global Accounts ]
The skin has been simplified so that it's easier to maintain as MediaWiki evolves as Monobook still runs on Wikimedia servers. , It seems irresponsible to add a feature to production in Wikimedia projects that isn't used.
. Is there a way to tell whether a MediaWiki message allows wikitext without trying it on a live installation or diving into MediaWiki's source code?
Jan: Could you please sign this off? In particular, checking we didn't miss anything.
The limited width feature works on https://en.wikipedia.org/wiki/Category:Astronomical_objects_known_since_antiquity and other pages where maximum width is disabled by default (see screencast below). Before the community request of T326887 this button would have been hidden at lower resolutions where it wasn't applicable. Perhaps you are have a gadget enabled that is interfering with its functionality or are using a browser window size which is causing you confusion?
From the commit message that introduced it (I8a309eedd70b9a82fcca91c2cf9a30beea602b6b), See Bug: T213778 and Bug: T315321 for more context.
FYI: This is actually pretty tricky. Would likely require a refactor of Echo and would involve coordinating with the Growth team or getting permission to do that. We originally considered it for the sticky header but descoped it because of technical feasibility.
Hi @DMburugu this task is not complete. Echo and Thanks (and maybe others) still need updating.
It can be resolved when https://codesearch.wmcloud.org/deployed/?q=%22mobile%22&files=%28extension%7Cskin%29.json&excludeFiles=&repos= returns no search results relating to Growth team maintained code.
This is intentional. This was discussed in https://phabricator.wikimedia.org/T319449#8336068.
With the latest Codex, our storybook is now causing CI issues that is blocking the content moderator tool team as well as other Gerrit patches from being merged.
Hey, I think we can just route it to open the languages from the dropdown directly if we click on the "go to top" link so that it would be more accurate rather than hiding it.
Looks related to one of our storybook instances (08:15:20 ERR! '../../lib/codex/mixins/codex-public-mixins.less' wasn't found. Tried - /src/lib/codex/mixins/codex-public-mixins.less,/src/lib/codex/mixins/codex-public-mixins.less,../../lib/codex/mixins/codex-public-mixins.less
08:15:20 ERR! in /src/.storybook/resolve-less-imports/mediawiki.skin.defaults.less (line 29, column 0))
Looks like this was added in T310259 @Michael and @LucasWerkmeister could you help us clarify what this is for, as this is problematic for our first input delay metrics and we'll like to see how we could optimize it. Could you help us prioritize this higher within WMDE?
Looks like this work may have blocked merging on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/890898 - I haven't checked to see if this is wider, but might be UBN if so.
Looked at IE11 today and the situation is much improved. The table of contents is still not accessible, but Since we are dropping support for IE11 in T178356 it might be worth waiting until then.
@email@example.com has now been released.
Wed, Mar 29
Would it work if RelatedArticlesUseCirrusSearchApiUrl is default to null?
I've prepared the patch. Anyone should feel free to backport it, otherwise I can do that sometime within the next 2 weeks.
@Mabualruz can we update the default value of the new VectorZebraDesign configuration to use the same format as VectorStickyHeader with logged_in and logged_out keys? We'll need to be able to define these in production.
This is working for me as expected as well. Please feel free to reopen if something got missed.
We are ending Q3 now so assuming this is done.
I don't think it's unreasonable to expect reconfiguration with a new release. This happens quite frequently from my experience with MediaWiki and I do not see any guidance in https://www.mediawiki.org/wiki/Stable_interface_policy prohibiting it.
This should be testable shortly on the beta cluster.
@Nux you can make the switch as soon as today if you are ready.
@ovasileva so I guess it's a question of whether we want to keep "beta" in the menu for Vector 2022. To be honest I've always found that a really odd menu link given we don't show any of the other preference links so prominently and users seldom need to go to the beta features page (I'd much rather we ran some kind of notification when that page is removed).
Working as advertised on https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
Note: it currently still shows for Modern Vector given isResponsive is declared dynamically which will be fixed as part of T106463.
Tue, Mar 28
I think "Indexing by robots" refers to whether the page presents a noindex property or not after all other parsing and processing. That seems like the most intuitive reading of it to me. If this is for some reason ambiguous or unclear, perhaps it should be renamed.