Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (443 w, 3 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
JDrewniak (WMF) [ Global Accounts ]

Recent Activity

Today

Jdrewniak added a comment to T361325: Consider providing experimental CSS variables in Less mixin form.

@CCiufo-WMF yes, a light-mode-palette mixin would still be relevant if the experimental build is folded into the main build.
It's really a matter of deciding which of the following two options is preferable:

Fri, Apr 19, 4:35 PM · Design-System-Team, Codex

Yesterday

Jdrewniak added a comment to T361158: Exception handling for appearance settings - Vector.

The patch for this task only added a notice for the night mode setting. I've created a task to add this functionality for the remaining Appearance menu settings here: https://phabricator.wikimedia.org/T362911.

Thu, Apr 18, 5:27 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak attached a referenced file: F43552917: image.png.
Thu, Apr 18, 5:24 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)
Jdrewniak created T362911: Exception handling for appearance settings (font-size and width) - Vector.
Thu, Apr 18, 5:24 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)
Jdrewniak added a comment to T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form.

@JScherer-WMF although the patch above seeks to make the spacing around the icons more consistent, this doesn't mean there is 16px from glyph to glyph because sometimes the alert and notification icons can have a count beside them that sticks out beyond the original image. Instead, the patch targets spacing around the icon containers as shown below.

Thu, Apr 18, 3:38 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak placed T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form up for grabs.
Thu, Apr 18, 3:38 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak moved T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.
Thu, Apr 18, 3:38 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak claimed T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form.
Thu, Apr 18, 2:47 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak moved T353987: "Theme" (Accessibility for Reading) button in Vector 2022 should have consistent padding in button form from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.
Thu, Apr 18, 2:47 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

@Edtadros the "new" user is determined by the date the account was created. This date is set in the configuration (below). Currently beta has the date set to April 9th 2024, so anyone registered after that date is considered a new user. This value will change in production based on when we deploy this feature, so I think prod QA should be tied to the eventual deployment task.

Thu, Apr 18, 3:47 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)

Tue, Apr 16

Jdrewniak added a comment to T361586: Make appearance menu persist.

Just some technical follow-up notes:
Previously we were rendering pinned containers in the correct location server-side, now, due to the browser-based nature of client-preferences, we're moving the pinned container to either the pinned/unpinned container in the browser. With this update, I didn't notice any flash of unstyled content (because the appearance menu is rendered in the browser anyway) but there are still $this->isPinned properties in PHP that we should remove, and also rename the appearance menu to 'appearance menu' in the code instead of 'client preference menu' (the class .vector-feature-client-prefs-pinned-clientpref-1 is not great :P )

Tue, Apr 16, 5:16 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations

Mon, Apr 15

Jdrewniak added a comment to T361325: Consider providing experimental CSS variables in Less mixin form.

Just to clarify the rationale for this request:
For the night-mode feature, the skins modify the :root selector quite heavily. We support night-mode via media-query as well as a user-preference, requiring us to redeclare the night-mode color palette in two place. We duplicate the day-mode color palette in the same way, but instead of using a mixin, we use the Less :extends feature: i.e: :root:extend( .skin-invert ) {...}

Mon, Apr 15, 7:13 PM · Design-System-Team, Codex
Jdrewniak added a comment to T362553: time/bytes (when including sections) overlaps history rows.

Just digging into this a bit, some context: the watchlist and history pages look similar, but they actually have totally different markup. The history page has html taken from core and made to look like the watchlist page, whereas the watchlist page has html tailored for mobile.
Regardless, it looks like the overlap is actually caused by the different time format used by ptwiki. If using that same format on enwiki, the overlap would appear there too:

Screenshot 2024-04-15 at 2.37.45 PM.png (1×1 px, 268 KB)

Mon, Apr 15, 6:42 PM · Moderator-Tools-Team, Web-Team-Backlog, MediaWiki-Page-history, MinervaNeue
Jdrewniak added a comment to T362553: time/bytes (when including sections) overlaps history rows.

Oh your right, I guess that column has had a static 70px width before.

Mon, Apr 15, 5:22 PM · Moderator-Tools-Team, Web-Team-Backlog, MediaWiki-Page-history, MinervaNeue
Jdrewniak added a comment to T362553: time/bytes (when including sections) overlaps history rows.

This is largely the same issue as T362297 introduced in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1015636.
that patch modifies the thumbnail styles to add a grey background and a fixed width. The watchlist table uses the thumbnail class for the +/- column.
Hopefully this is address in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1019178.

Mon, Apr 15, 4:56 PM · Moderator-Tools-Team, Web-Team-Backlog, MediaWiki-Page-history, MinervaNeue
Jdrewniak added a comment to T359997: The GenerateFileList function in data/site-stats.js seems to be breaking .

@Punith.nyk, @Tacsipacsi is right, we shouldn't be blindly calling response.json() in httpGet, but converting the response to JSON when necessary is still a nice convenience to have. We can make the following edit to httpGet() to wrap the JSON.parse() in a try catch statement:

Mon, Apr 15, 3:35 PM · Wikimedia-Portals

Fri, Apr 12

Jdrewniak updated subscribers of T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit".

Just sharing what we've learned so far. It turns out this behaviour is somewhat intentional and has been implemented by design as a solution to T88270.
Basically the behaviour (as implemented) checks the users edit count, and if it is less than 10, redirects them from Special:Watchlist to Special:EditWatchlist. (thank you @SToyofuku-WMF for tracking down this codepath!).

Fri, Apr 12, 3:14 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)

Thu, Apr 11

Jdrewniak added a comment to T362297: [Bug] Mobile watchlist broken.

it looks like the overlay issue was an existing bug that was made visible by the addition of a grey background. The screenshot below shows the positioning of the elements *before* the patch. By adding a grey background to the element, as the patch did, the text beside it overlaps. The offending patch did not change the positioning of the elements. Instead of reverting this patch, I think it would be simpler to remove this grey background. As a follow-up, we should fix the positioning and re-introduce this grey background (which was intended for thumbnails).

Screenshot 2024-04-11 at 10.28.26 AM.png (891×589 px, 69 KB)

Thu, Apr 11, 2:33 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)
Jdrewniak added a comment to T362297: [Bug] Mobile watchlist broken.

Using git bisect and testing locally, I can verify that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1015636 is the offending commit.
Regarding the redirect, I'm able to reproduce that too, and I see that it's a separate issue, not produced by the offending patch :/
On my local, I can see that the redirect from Special:Watchlist to Special:EditWatchlist only happens for non-admin users.
admin users are still able to visit Special:Watchlist.

Thu, Apr 11, 2:20 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q4 Sprint 1)

Wed, Apr 10

Jdrewniak claimed T360388: Upstream thumbnail and table rules from Minerva to ResourceLoader/SkinModule.
Wed, Apr 10, 8:07 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MinervaNeue, MediaWiki-Core-Skin-Architecture, FY2023-24-WE 2.1 Typography and palette customizations

Tue, Apr 9

Jdrewniak placed T354889: Vector 2022 should use the experimental Codex build up for grabs.
Tue, Apr 9, 4:00 PM · Web-Team-Backlog ( FY2023-24 Q4 Sprint 3), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak updated the task description for T362099: [Bug] Vector TOC should use hyphens instead of break-word.
Tue, Apr 9, 3:43 PM · Desktop Improvements (Vector 2022), Web-Team-Backlog (FY2023-24 Q4 Sprint 2)
Jdrewniak claimed T361158: Exception handling for appearance settings - Vector.
Tue, Apr 9, 3:14 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak moved T361158: Exception handling for appearance settings - Vector from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 1) board.
Tue, Apr 9, 3:14 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations

Fri, Apr 5

Jdrewniak placed T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop up for grabs.
Fri, Apr 5, 7:44 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

✅ We must have the ability to set a different default size for new accounts vs existing accounts

Fri, Apr 5, 7:38 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T360098: Allow reading accessibility settings menu to have different defaults for logged-in and logged-out users on desktop.

✅ The accessibility settings menu must have the ability to set different defaults for logged-in and logged-out users on desktop

Fri, Apr 5, 7:26 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T361158: Exception handling for appearance settings - Vector.

@JScherer-WMF could you clarify, on pages where the settings are overridden, should the radio buttons still be active or should they be disabled?

Fri, Apr 5, 5:29 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T356532: Consider word-breaks as a way to improve readability in languages with long words.

@JScherer-WMF thanks for raising this issue. There's one place in Vector where we're not using hyphens but we really should: the TOC. We're using word-break: break-word; instead of hyphens: auto; which breaks words without hyphens. I'd consider this a bug.

Fri, Apr 5, 3:25 PM · Web-Team-Backlog
Jdrewniak updated subscribers of T356532: Consider word-breaks as a way to improve readability in languages with long words.
Fri, Apr 5, 3:11 PM · Web-Team-Backlog

Thu, Apr 4

Jdrewniak added a project to T361767: Don't use padding-bottom for paragraphs: Web-Team-Backlog.
Thu, Apr 4, 5:39 PM · Web-Team-Backlog, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T361586: Make appearance menu persist.

We didn't estimate this one as currently written since the engineers felt we needed more documentation around the current behaviour/design for this menu. (Does it currently work for logged out users? are we putting it in the "..." menu for anons? )

Thu, Apr 4, 5:15 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T360092: Determine which pages should have a small default content area.

Justin just needs list of pages

Generally, I'd say that all Special pages fall into to the category of being "table-based". These pages are not all technically tables, but I'd group them into the following categories:

  • page-list based
  • change-list based
  • table based
  • form based
Thu, Apr 4, 3:30 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak placed T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() up for grabs.
Thu, Apr 4, 2:16 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak moved T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() from QA to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.

Sorry @Edtadros there's still one patch that needs to be merged, so I'm putting this back into code review.

Thu, Apr 4, 1:50 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue

Tue, Apr 2

Jdrewniak placed T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() up for grabs.
Tue, Apr 2, 7:10 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak renamed T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() from [MinervaNeue] Guard against undefined in initMediaViewer() to [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().
Tue, Apr 2, 7:09 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak updated the task description for T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().
Tue, Apr 2, 7:08 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak added a comment to T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().

hi @MusikAnimal I've tried to get some clarity on the expected usage of wikipage.content but I wasn't able to come to any definite conclusions. As you point out though, the defacto usage suggests that passing in just the changed html is OK.

Tue, Apr 2, 6:24 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak added a comment to T358406: [Design needed] Bytes added on history, contribute, watchlist and recent changes have color contrast issues and is inconsistent with colors on diff pages.

I'm still a little confused about what we're doing for recent changes

Tue, Apr 2, 4:33 PM · Design-System-Team, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), good first task, patch-welcome, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T360343: Tokens: Produce a "dark mode" build of Codex design tokens.

Right now, no, but we can work on that next. I have filed T361325 for this. It's a little tentative because I'd first like to discuss whether the other DST engineers think it's a good idea, and if so, where this mixin would live. In the meantime, it's my understanding that this isn't a blocker, because the :extend( :root ) hack works for now, is that right?

Tue, Apr 2, 3:19 PM · CSS, Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex

Thu, Mar 28

Jdrewniak added a comment to T360628: Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias.

@Seb_az86556 I went ahead and made the change to common.js. It looks like it fixed the heading issue. It still works on legacy Vector. Regarding common.js, it seems to be working for me, e.g changing "C" to "Ch'":

Thu, Mar 28, 7:12 PM · Patch-For-Review, Desktop Improvements (Vector 2022), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Jdrewniak added a comment to T360628: Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias.

hi @Seb_az86556 I've looked into it and I know what the font issue is. Vector 2022 has slightly different HTML markup than legacy Vector.

Thu, Mar 28, 6:46 PM · Patch-For-Review, Desktop Improvements (Vector 2022), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Jdrewniak added a comment to T361157: Change "Night" to "Dark" in Appearance settings.

We talked about this during estimation but determined that this is not ready to estimate because it needs some more conversation. The labels in the menu are easy enough to change but the underlying technical naming would require an extensive refactor. We recently completed a task T359983 that changed the classes to the following:

Thu, Mar 28, 6:06 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T358406: [Design needed] Bytes added on history, contribute, watchlist and recent changes have color contrast issues and is inconsistent with colors on diff pages.

moving to sign off assuming the design portion of this ticket is sufficient. @Jdlrobson feel free to move back to doing or design review if this is not the case. Needs implementation tickets for sign-off.

Thu, Mar 28, 5:48 PM · Design-System-Team, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), good first task, patch-welcome, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak moved T358406: [Design needed] Bytes added on history, contribute, watchlist and recent changes have color contrast issues and is inconsistent with colors on diff pages from Incoming to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Thu, Mar 28, 5:45 PM · Design-System-Team, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), good first task, patch-welcome, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T360793: Linter help link for night-mode-unaware-background-color goes to empty page.

@KSarabia-WMF to followup with Content transform team to see if there's any work needed from our end.

Thu, Mar 28, 5:41 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Content-Transform-Team-WIP, Essential-Work, Patch-For-Review, MediaWiki-extensions-Linter
Jdrewniak renamed T361158: Exception handling for appearance settings - Vector from Exception handling for appearance settings to Exception handling for appearance settings - Vector.
Thu, Mar 28, 5:28 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T361158: Exception handling for appearance settings - Vector.

Per conversation, the team agreed to scope this task to the Appearance menu in Vector and create a new task for Minerva.

Thu, Mar 28, 5:27 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak triaged T361158: Exception handling for appearance settings - Vector as High priority.
Thu, Mar 28, 5:27 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak set the point value for T361158: Exception handling for appearance settings - Vector to 3.
Thu, Mar 28, 5:26 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak set the point value for T358904: Update mobile search overlay for night mode to 2.
Thu, Mar 28, 5:16 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T360628: Deploy Vector 2022 skin to Wikisource wikis, internal wikis, and wikipedias.

hi @Dzahn, could you ask the user to elaborate on the headline/font issues on nv.wikipedia.org? If there's special consideration required for that wiki we'd like to know about it. On my computer, I can't see the issue: " ę́ doe not work... neither does į́" or how "all the headlines are a mess" . If possible, a screenshot would be great (below is what I see).

Thu, Mar 28, 5:06 PM · Patch-For-Review, Desktop Improvements (Vector 2022), Web Team Essential Work 2024, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Jdrewniak moved T360099: Accessibility settings menu should default to open for all logged-in and logged-out users from Doing to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 6) board.
Thu, Mar 28, 4:47 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022)
Jdrewniak claimed T356678: Migrate uses of codex-search in MinervaNeue to use CodexModule.
Thu, Mar 28, 4:45 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Web-Team-Backlog (FY2023-24 Q3 Sprint 6), Patch-For-Review, Web Team Essential Work 2024, MinervaNeue
Jdrewniak assigned T360387: Remove styles in hacks.less that no longer apply to Edtadros.
Thu, Mar 28, 4:42 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
Jdrewniak assigned T360386: Create a WikimediaMessages module for sharing styles between Vector 2022 and Minerva to SToyofuku-WMF.
Thu, Mar 28, 4:42 PM · Verified, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations, WikimediaMessages
Jdrewniak assigned T357486: Expand all sections should show on resize to Mabualruz.
Thu, Mar 28, 4:38 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Patch-For-Review, good first task, MobileFrontend, patch-welcome
Jdrewniak claimed T359183: Exclude non-functional pages from night mode.
Thu, Mar 28, 4:36 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Wed, Mar 27

Jdrewniak added a comment to T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().

@MusikAnimal just looking at the logs again, and it looks like this hook is causes errors in more than one place in Minerva and MobileFrontend. I don't see anything wrong with making it compatible with Minerva 👍
but, given the error rate, I think we should disable the gadget for this skin until that happens.

Wed, Mar 27, 6:45 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak added a comment to T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().

@MusikAnimal I agree that it should only return a jQuery object for an HTMLElement. I added guards in Minerva to check for $content && $content[ 0 ] but it looks like that's not enough. Maybe it's because the lines
$result = $('#xtools_result'); returns undefined in Minerva because #contentSub doesn't exist, but that should still have been caught by $content[ 0 ]. I might add an additional check in Minerva for $content[0] instanceof HTMLElement .

Wed, Mar 27, 6:11 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak added a comment to T360856: MultimediaViewer in mobile should use patterned background as on desktop.

@Lofhi thanks for raising this, @Jdlrobson is out this week.
Images in night mode are hard, and the issue isn't limited to multimedia viewer either. Images can appear black on black in the content as well.

Wed, Mar 27, 2:54 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T360343: Tokens: Produce a "dark mode" build of Codex design tokens.

hi @Catrope, the following sounds good:
✅ Less variables and CSS variables in separate files
✅ A dedicated night mode mixin
✅ Only includes tokens required for night mode

Wed, Mar 27, 1:33 PM · CSS, Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex

Tue, Mar 26

Jdrewniak added a project to T360856: MultimediaViewer in mobile should use patterned background as on desktop: FY2023-24-WE 2.1 Typography and palette customizations.
Tue, Mar 26, 6:14 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak updated subscribers of T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().

It looks like the error suppression was ineffective, which means that checking for $container && $container[ 0 ] was insufficient.
The following error: TypeError: Cannot read properties of undefined (reading 'addEventListener') is still thrown when attaching an eventHandler, i.e $container[ 0 ].addEventHandler(...)
Which means that maybe $container it's not a typeof HTMLElement.

Tue, Mar 26, 5:46 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue

Fri, Mar 22

Jdrewniak added a comment to T353663: [SPIKE] Investigate Effort of Integrating CSS Variables with OOUI for dark mode.

After several conversations I've documented the different options in the following google doc

Fri, Mar 22, 4:45 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, Spike, FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak renamed T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() from [MinervaNeue] Guard against null in initMediaViewer() to [MinervaNeue] Guard against undefined in initMediaViewer().
Fri, Mar 22, 3:35 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak triaged T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer() as Medium priority.
Fri, Mar 22, 3:13 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak updated the task description for T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().
Fri, Mar 22, 3:11 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue
Jdrewniak created T360781: [MinervaNeue/MobileFrontend] Guard against undefined in initMediaViewer().
Fri, Mar 22, 3:10 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Verified, Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MinervaNeue

Thu, Mar 21

Jdrewniak created T360644: [Spike] Investigate alternatives to Storybooks.js.
Thu, Mar 21, 3:09 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2)

Mar 20 2024

Jdrewniak added a comment to T358528: Mobile editor inconsistently renders both night mode and light mode elements.

@Edtadros thanks for catching this

Mar 20 2024, 1:58 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations

Mar 19 2024

Jdrewniak added a comment to T328732: Expanding the ToC via its button should not cause a separate scroll bar.

@ThurnerRupert I see how having multiple scrollbars can be an inconvenience. You scroll the page expecting the ToC to scroll, but then it doesn't.
@Jdlrobson pointed out that the ToC in the header needs a separate scrollbar because it sticks to the top of the page, but, the same is true for the ToC in the sidebar.

Mar 19 2024, 3:13 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)

Mar 11 2024

Jdrewniak placed T359488: Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode up for grabs.
Mar 11 2024, 8:22 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q3 Sprint 5)
Jdrewniak moved T359488: Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Mar 11 2024, 8:22 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q3 Sprint 5)
Jdrewniak claimed T359488: Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode.
Mar 11 2024, 8:02 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q3 Sprint 5)
Jdrewniak moved T359488: Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Mar 11 2024, 8:02 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q3 Sprint 5)
Jdrewniak added a comment to T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode.

As part of this ticket, I wanted to leave a comment documenting any edge-cases or workarounds I ran into with the initial implementation.

Mar 11 2024, 3:42 PM · Verified, Design-System-Team, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MinervaNeue

Mar 8 2024

Jdrewniak added a comment to T359662: Improve Wikimedia portals JS linting.

Hi @Punith.nyk would you like to work on this task? I started a Work in progress patch with an updated configuration:
https://gerrit.wikimedia.org/r/c/wikimedia/portals/+/1009785
There's a handy gerrit shortcut for pulling down someone else's patches
git review -d 1009785 .
You can then amend the patch and push updates to it.
I think most of the linting errors can be auto-fixed with npm run lint:fix but there might be some that need attention. If you want to push a patch but git commit --amend fails, you can add git commit --no-verify to skip the pre-commit hook.

Mar 8 2024, 7:10 PM · Patch-For-Review, Wikimedia-Portals
Jdrewniak assigned T359662: Improve Wikimedia portals JS linting to Punith.nyk.
Mar 8 2024, 7:05 PM · Patch-For-Review, Wikimedia-Portals
Jdrewniak created T359662: Improve Wikimedia portals JS linting.
Mar 8 2024, 7:01 PM · Patch-For-Review, Wikimedia-Portals
Jdrewniak added a comment to T358528: Mobile editor inconsistently renders both night mode and light mode elements.

@Edtadros thanks for pointing out that scrollbar issue. That seems to be caused by the following rule in OOUI:

Mar 8 2024, 3:41 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations

Mar 7 2024

Jdrewniak added a comment to T358528: Mobile editor inconsistently renders both night mode and light mode elements.

I've posted an alternative patch to the one @Jdlrobson originally wrote. This second approach adds the .notheme class to the teleportTarget element that VE uses for menus and overlays. This results in a state where the mobile editors are in light-mode but the content remains in night-mode. I might be overlooking some usecases here, but if it works, I think this produces a less jarring experience than switching the entire content to light mode.

Mar 7 2024, 3:34 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak claimed T358528: Mobile editor inconsistently renders both night mode and light mode elements.
Mar 7 2024, 2:59 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak moved T358528: Mobile editor inconsistently renders both night mode and light mode elements from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Mar 7 2024, 2:59 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), FY2023-24-WE 2.1 Typography and palette customizations
Jdrewniak added a comment to T358392: Prepare for Design System Gap Analysis with Design System Team .

I've started a spreadsheet with the tasks in the description:
https://docs.google.com/spreadsheets/d/1POmYm3VtPiOYBxDT95dcRun83GD2QPfD2eKyk94CHjs/edit#gid=0

Mar 7 2024, 4:51 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4)
Jdrewniak claimed T358392: Prepare for Design System Gap Analysis with Design System Team .
Mar 7 2024, 12:36 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4)

Mar 6 2024

Jdrewniak moved T358392: Prepare for Design System Gap Analysis with Design System Team from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Mar 6 2024, 10:05 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4)

Mar 4 2024

Jdrewniak added a project to T358921: Excessive space after p tags is causing new spacing issues: MediaWiki-Templates.
Mar 4 2024, 10:22 PM · MediaWiki-Templates, Desktop Improvements (Vector 2022)
Jdrewniak moved T358052: Basque Wikipedia is missing from Wikipedia.org main page from Blocked on Others to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Mar 4 2024, 5:07 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4), Wikimedia-Portals
Jdrewniak reassigned T358053: "Ingelesa" appears instead of "euskara" at Wikipedia.org Main Page from Jdrewniak to Edtadros.
Mar 4 2024, 5:07 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4), Wikimedia-Portals
Jdrewniak placed T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode up for grabs.
Mar 4 2024, 5:05 PM · Verified, Design-System-Team, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MinervaNeue
Jdrewniak moved T354975: [carryover] ResourceLoaderSkinModule should load core styles before skin styles from Blocked on Others to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Mar 4 2024, 4:46 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MediaWiki-ResourceLoader, MediaWiki-Platform-Team, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022), MediaWiki-Core-Skin-Architecture
Jdrewniak moved T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
Mar 4 2024, 4:44 PM · Verified, Design-System-Team, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MinervaNeue
Jdrewniak updated the task description for T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode.
Mar 4 2024, 4:43 PM · Verified, Design-System-Team, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MinervaNeue

Mar 1 2024

Jdrewniak added a comment to T358885: GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization.

@Maryann-Onyinye thanks, I just added a second mentor the the project :)

Mar 1 2024, 6:54 PM · Patch-For-Review, Google-Summer-of-Code (2024), Wikimedia-Portals, Outreach-Programs-Projects
Jdrewniak updated the task description for T358885: GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization.
Mar 1 2024, 6:50 PM · Patch-For-Review, Google-Summer-of-Code (2024), Wikimedia-Portals, Outreach-Programs-Projects
Jdrewniak updated the task description for T358885: GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization.
Mar 1 2024, 6:44 PM · Patch-For-Review, Google-Summer-of-Code (2024), Wikimedia-Portals, Outreach-Programs-Projects
Jdrewniak edited projects for T358885: GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization, added: Google-Summer-of-Code (2024); removed Google-Summer-of-Code.
Mar 1 2024, 5:36 PM · Patch-For-Review, Google-Summer-of-Code (2024), Wikimedia-Portals, Outreach-Programs-Projects
Jdrewniak renamed T358885: GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization from www.wikipedia.org Wikimedia portals: Codebase modernization to GSoC '24 Proposal: www.wikipedia.org Wikimedia portals - codebase modernization.
Mar 1 2024, 5:35 PM · Patch-For-Review, Google-Summer-of-Code (2024), Wikimedia-Portals, Outreach-Programs-Projects