Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (173 w, 5 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Thu, Feb 14

Jdrewniak added a comment to T213352: AMC: add history link to actions menu.

One question raised during estimation was how much we want to change the existing HTML to accommodate the new design. It is probably possible to achieve the "equidistant" design (equally spaced menu items) without changes to the markup, but the effort involved in that in probably substantial. Currently one item is floated right, with the new design we might have to use display:table and maintain an entirely separate stylesheet for this that overrides the current layout.

Thu, Feb 14, 6:01 PM · Readers-Web-Backlog, Advanced Mobile Contributions

Tue, Feb 12

Jdrewniak added a comment to T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.

@Niedzielski It might be an issue with the storybook implementation, that specific preview looks fine in production...

Tue, Feb 12, 7:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Audiences-QA, Design, Page-Previews
Jdrewniak added a comment to T215370: TalkOverlay should not extend Overlay.

We discussed in grooming today that having a promisedView component would have some significant benefits and make this work easier, so we should create a task to document that work and consider that a dependency for this task.

Tue, Feb 12, 5:41 PM · Patch-For-Review, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak added a comment to T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.

Following up from yesterdays discussion, one thing we talked about is when it's appropriate to use and event bus and when it's not.

Tue, Feb 12, 12:24 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

@Edtadros yup that's a feature.

Tue, Feb 12, 11:54 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Jdrewniak added a comment to T202374: [EPIC] Cleanup Mobile editor error handling.

a LOT of things have changed since I last looked at the editing codebase, for the better!

  • The editing code has been migrated to webpack T213340!
  • The error parsing logic is now separated into a parseSaveError.js file, no longer mixed in EditorOverlay.js, hurra!
  • Unit tests have been improved.
  • Deferred .fails have been replaced with .rejects.
  • The bugs with conflict errors have been resolved
Tue, Feb 12, 11:31 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak updated the task description for T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 11:09 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a subtask for T202374: [EPIC] Cleanup Mobile editor error handling: T215886: Merge conflict error broken on mobile.
Tue, Feb 12, 11:00 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a parent task for T215886: Merge conflict error broken on mobile: T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 11:00 AM · MobileFrontend
Jdrewniak updated the task description for T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 11:00 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak closed T215886: Merge conflict error broken on mobile as Resolved.
Tue, Feb 12, 10:40 AM · MobileFrontend
Jdrewniak created T215886: Merge conflict error broken on mobile.
Tue, Feb 12, 10:40 AM · MobileFrontend
Jdrewniak renamed T202374: [EPIC] Cleanup Mobile editor error handling from [EPIC] Cleanup Wikitext editor error handling to [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 10:27 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a parent task for T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead: T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 10:17 AM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend
Jdrewniak added a subtask for T202374: [EPIC] Cleanup Mobile editor error handling: T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead.
Tue, Feb 12, 10:17 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a subtask for T202374: [EPIC] Cleanup Mobile editor error handling: T206050: Mobile visual editor does not log saveFailure events.
Tue, Feb 12, 10:16 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a parent task for T206050: Mobile visual editor does not log saveFailure events: T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 10:16 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
Jdrewniak added a parent task for T202460: AbuseFilter warnings and errors are handled badly by the editor: T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 10:12 AM · Readers-Web-Backlog (Tracking), VisualEditor, MobileFrontend
Jdrewniak added a subtask for T202374: [EPIC] Cleanup Mobile editor error handling: T202460: AbuseFilter warnings and errors are handled badly by the editor.
Tue, Feb 12, 10:12 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a subtask for T202374: [EPIC] Cleanup Mobile editor error handling: T197499: Wikitext editor error handling broken in read only mode.
Tue, Feb 12, 10:12 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a parent task for T197499: Wikitext editor error handling broken in read only mode: T202374: [EPIC] Cleanup Mobile editor error handling.
Tue, Feb 12, 10:12 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
Jdrewniak renamed T202374: [EPIC] Cleanup Mobile editor error handling from Cleanup Wikitext editor error handling to [EPIC] Cleanup Wikitext editor error handling.
Tue, Feb 12, 10:12 AM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team
Jdrewniak added a comment to T215148: On Phabricator workboard, show status of associated Gerrit patches.

@greg there are a few problems that I know of that could prevent it from working:

  1. The patch has multiple tasks associated with it (i.e. Bug: T1234, T12345 in the commit message)- currently the link will only show up for the first task (this can be fixed).
  2. The board has hundreds of tasks - Gerrit limits the query length to 50 terms, so work board with more than 50 tasks won't work :/ I could potentially split the queries into multiple chunks though.
Tue, Feb 12, 9:49 AM · Phabricator

Mon, Feb 11

Jdrewniak moved T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event) from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 11, 3:05 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Jdrewniak moved T214444: Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event) from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 11, 2:53 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Performance-Team (Radar)
Jdrewniak placed T214195: Design updates to Settings page & AMC opt-in toggle up for grabs.
Mon, Feb 11, 1:36 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak updated the task description for T214195: Design updates to Settings page & AMC opt-in toggle.
Mon, Feb 11, 1:35 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

@alexhollender I'm not sure what changed but I'm unable to see the bug with the blue read-more text being clickable, either on staging or locally on master, so I'm handing this over to QA :)

Mon, Feb 11, 1:26 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings

Fri, Feb 8

Jdrewniak added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

It'd be good to put this on staging to double check, but I think the simple fix works.

Fri, Feb 8, 1:29 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings

Thu, Feb 7

Jdrewniak added a comment to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation.

as far as I can tell, setting this line to z-index:0; (or @z-indexBase) seems to fix the issue...

Thu, Feb 7, 11:58 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Jdrewniak moved T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Feb 7, 8:02 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Jdrewniak added a comment to T202374: [EPIC] Cleanup Mobile editor error handling.

It looks like the scope of this task has expanded from "Wikitext editor error handling broken for edit-conflicts" to "everything wrong with edit error-handling on mobile". I'll see if I can track down the work already done in this area and break this up into smaller tasks.

Thu, Feb 7, 7:57 PM · Epic, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Editing-team

Wed, Feb 6

Jdrewniak added a comment to T214195: Design updates to Settings page & AMC opt-in toggle.

@alexhollender I've updated readers-web-staging with the following patches, there was an error checking the Minvera patch out the last time. The spacing below the title should be ok now.

Wed, Feb 6, 8:13 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak moved T213336: Regression: Mobile gallery loading spinner appears on left instead of centered from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Feb 6, 6:59 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend

Tue, Feb 5

alexhollender awarded T213336: Regression: Mobile gallery loading spinner appears on left instead of centered a Love token.
Tue, Feb 5, 5:40 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend

Mon, Feb 4

Jdrewniak moved T213336: Regression: Mobile gallery loading spinner appears on left instead of centered from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 4, 6:11 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Jdrewniak claimed T213336: Regression: Mobile gallery loading spinner appears on left instead of centered.
Mon, Feb 4, 6:10 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Jdrewniak updated subscribers of T213336: Regression: Mobile gallery loading spinner appears on left instead of centered.

thanks for spotting that @Edtadros!

Mon, Feb 4, 4:47 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend

Fri, Jan 25

Jdrewniak added a comment to T214195: Design updates to Settings page & AMC opt-in toggle.

@phuedx yes! meant to do that..
alrighty, and for part two of this two pointer, the text width.

Fri, Jan 25, 1:58 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak moved T214195: Design updates to Settings page & AMC opt-in toggle from Doing to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Jan 25, 1:47 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak added a comment to T214195: Design updates to Settings page & AMC opt-in toggle.

@alexhollender part one of this two part two-pointer, the headings.

Fri, Jan 25, 12:29 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Thu, Jan 24

Jdrewniak claimed T214195: Design updates to Settings page & AMC opt-in toggle.
Thu, Jan 24, 1:13 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak moved T214195: Design updates to Settings page & AMC opt-in toggle from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 24, 1:13 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak added a comment to T211691: [Regression] Menu panel has black background when another drawer is first opened.

I don't think the minHideDelay is used for animation. I think that's a hack to get around attaching the window.click event in the onShowDrawer method. In a previous patch (which I just slowly walked away from... ) I attempted to add another timer for the hide method. It's kind of brittle because I hard-coded the duration at 250ms, which is a value that's actually changed in CSS.

Thu, Jan 24, 1:07 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
Jdrewniak moved T214451: [Bug] A large amount of our errors are occurring in iOS Safari from Needs Analysis to Epics/Goals on the Readers-Web-Backlog board.
Thu, Jan 24, 9:43 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak added a project to T214526: [EPIC] Mobile page issues banner: CSS/styling cleanup: Page-Issue-Warnings.
Thu, Jan 24, 9:38 AM · Epic, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a project to T214550: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation: Page-Issue-Warnings.
Thu, Jan 24, 9:37 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Page-Issue-Warnings
Jdrewniak added a project to T214549: Reduce height of mobile page issues banner and offset of learn more: Page-Issue-Warnings.
Thu, Jan 24, 9:37 AM · Readers-Web-Backlog, Page-Issue-Warnings
Jdrewniak triaged T214548: Fix offset of "Learn more" link as Normal priority.
Thu, Jan 24, 9:36 AM · Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a project to T214548: Fix offset of "Learn more" link: Page-Issue-Warnings.
Thu, Jan 24, 9:36 AM · Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a project to T212376: Extract pageIssues.js view code: Readers-Web-Backlog.
Thu, Jan 24, 9:22 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Jdrewniak added a subtask for T178194: Enable new RC on mobile: T214531: History links on mobile Special:RecentChanges link to article page instead of Special:History.
Thu, Jan 24, 9:17 AM · Advanced Mobile Contributions, User-notice, Growth-Team, Readers-Web-Backlog (Design), Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Jdrewniak added a parent task for T214531: History links on mobile Special:RecentChanges link to article page instead of Special:History: T178194: Enable new RC on mobile.
Thu, Jan 24, 9:17 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Mobile
Jdrewniak moved T214531: History links on mobile Special:RecentChanges link to article page instead of Special:History from Needs triage to Triaged on the Mobile board.
Thu, Jan 24, 9:16 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Mobile
Jdrewniak added a comment to T214531: History links on mobile Special:RecentChanges link to article page instead of Special:History.

Thanks for the bug report. We currently don't officially support the Recent Changes page on mobile, but we have an project Advanced Mobile Contributions to do so this year, so we'll fix this when we expose the Recent Changes page on mobile, tracked in T178194.

Thu, Jan 24, 9:15 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Mobile
Jdrewniak renamed T214531: History links on mobile Special:RecentChanges link to article page instead of Special:History from History links on recent changes do not work correctly on mobile to History links on mobile Special:RecentChanges link to article page instead of Special:History.
Thu, Jan 24, 9:11 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, Mobile

Wed, Jan 23

Jdrewniak closed T213472: Port categories code to webpack as Resolved.
Wed, Jan 23, 9:28 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213472: Port categories code to webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Wed, Jan 23, 9:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213299: Special:Nearby is built in webpack as Resolved.
Wed, Jan 23, 9:27 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213299: Special:Nearby is built in webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Wed, Jan 23, 9:27 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T213299: Special:Nearby is built in webpack.
Wed, Jan 23, 9:27 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T211691: [Regression] Menu panel has black background when another drawer is first opened.

I really think we should also be updating Drawer.prototype.onHideDrawer to also remove the class has-drawer it adds in postRender. Patch to follow.

Wed, Jan 23, 2:06 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
Jdrewniak closed T213474: Port talk code to webpack as Resolved.
Wed, Jan 23, 11:45 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213474: Port talk code to webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Wed, Jan 23, 11:45 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T213474: Port talk code to webpack.
Wed, Jan 23, 11:45 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T214451: [Bug] A large amount of our errors are occurring in iOS Safari.
Wed, Jan 23, 10:06 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak moved T214451: [Bug] A large amount of our errors are occurring in iOS Safari from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 9:06 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak moved T212961: Add X-Analytics tag for AMC webrequests from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 9:05 AM · Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak moved T212961: Add X-Analytics tag for AMC webrequests from Blocked on Others to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 9:05 AM · Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Jdrewniak triaged T214451: [Bug] A large amount of our errors are occurring in iOS Safari as High priority.
Wed, Jan 23, 9:05 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak edited projects for T214451: [Bug] A large amount of our errors are occurring in iOS Safari, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.
Wed, Jan 23, 9:05 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak updated the task description for T214451: [Bug] A large amount of our errors are occurring in iOS Safari.
Wed, Jan 23, 8:01 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog
Jdrewniak updated the task description for T214451: [Bug] A large amount of our errors are occurring in iOS Safari.
Wed, Jan 23, 7:57 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Performance-Team (Radar), Epic, Readers-Web-Backlog

Tue, Jan 22

Jdrewniak added a comment to T200927: Enable smooth/animated scrolling between links on pages.

Oh, when I saw an anchor tag with href="#movedpara_3_10_rhs" I assumed there was an element with that same ID on the page. Nope.

Tue, Jan 22, 2:07 PM · Readers-Web-Backlog, Audiences-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)
Jdrewniak added a comment to T200927: Enable smooth/animated scrolling between links on pages.

So it seems to work when I put the scroll-behavior: smooth; rule on the <html> element instead of the <body>... kinda.
It only starts scrolling after the second tap. I have no idea why that is. I haven't found anything intercepting the click events (yet?).

Tue, Jan 22, 1:46 PM · Readers-Web-Backlog, Audiences-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)
Jdrewniak claimed T213299: Special:Nearby is built in webpack.
Tue, Jan 22, 12:47 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak claimed T213472: Port categories code to webpack.
Tue, Jan 22, 12:47 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak claimed T213474: Port talk code to webpack.
Tue, Jan 22, 12:47 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T199830: Running gulp results in uncommited changes as Resolved.
Tue, Jan 22, 10:53 AM · Discovery, Wikimedia-Portals
Jdrewniak closed T194137: Remove dev-build artifacts from repo as Resolved.
Tue, Jan 22, 10:52 AM · Patch-For-Review, Discovery, Wikimedia-Portals
Jdrewniak moved T210745: Regression: Page history divider is too narrow from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 5:18 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), good first bug, Regression, MobileFrontend
Jdrewniak moved T213336: Regression: Mobile gallery loading spinner appears on left instead of centered from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 4:33 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend

Fri, Jan 18

Jdrewniak triaged T213818: Misplaced (i) icon on all skins, causing scrollbars on MobileFrontend as Normal priority.
Fri, Jan 18, 9:20 PM · Readers-Web-Backlog, Patch-For-Review, MobileFrontend, Regression, Need-volunteer, ImageMap
Jdrewniak added a comment to T213938: When watching specific kinds of history on mobile devices, it returns a fatal error. .

This error also occurs on desktop:
https://zh.wikipedia.org/w/index.php?diff=52813452

Fri, Jan 18, 9:18 PM · Wikimedia-production-error, MediaWiki-History-and-Diffs

Jan 17 2019

Jdrewniak closed T212823: MFA: mobile.special.watchlist.scripts is built via Webpack as Resolved.
Jan 17 2019, 11:37 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Jdrewniak closed T212823: MFA: mobile.special.watchlist.scripts is built via Webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Jan 17 2019, 11:37 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T212823: MFA: mobile.special.watchlist.scripts is built via Webpack.
Jan 17 2019, 11:37 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Jdrewniak closed T213111: MFA: notifications feature is ported to webpack as Resolved.
Jan 17 2019, 11:34 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213111: MFA: notifications feature is ported to webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Jan 17 2019, 11:34 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T213111: MFA: notifications feature is ported to webpack.
Jan 17 2019, 11:34 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213112: Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack as Resolved.
Jan 17 2019, 11:28 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T213112: Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Jan 17 2019, 11:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T213112: Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack.
Jan 17 2019, 11:27 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak created T214051: Reference Drawers execute events for previously closed Drawers.
Jan 17 2019, 2:58 PM · Patch-For-Review, MobileFrontend, Readers-Web-Backlog
Jdrewniak created T214049: Every Drawer has a shield for catching clicks.
Jan 17 2019, 2:40 PM · MobileFrontend, Readers-Web-Backlog
Jdrewniak created T214045: Drawers should be removed from DOM after close.
Jan 17 2019, 2:33 PM · MobileFrontend, Readers-Web-Backlog

Jan 16 2019

Jdrewniak moved T211691: [Regression] Menu panel has black background when another drawer is first opened from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 16 2019, 10:04 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
Jdrewniak added a comment to T211691: [Regression] Menu panel has black background when another drawer is first opened.

After looking through the code, I think the regression might have been caused by use moving modules around during the refactor, and causing some CSS files to be loaded in a different order.

Jan 16 2019, 10:03 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, Regression, MobileFrontend
Jdrewniak added a comment to T209129: MFA: Drawers and Overlays should not auto-append it self to the body element.

This task has proven difficult as I’ve learned more about how Overlays and Drawers work, and how they interact with OverlayManager.

Jan 16 2019, 8:48 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak claimed T213112: Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack.
Jan 16 2019, 6:08 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)