Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (208 w, 3 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Yesterday

Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

we (the Reader’s Web team) have been giving a lot more thought to the new-skin & update-vector proposals recently.

Thu, Oct 17, 11:05 PM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC

Wed, Oct 16

Jdrewniak claimed T203137: Dev: Standardising our use of headless node qunit tests across Popups and MobileFrontend.
Wed, Oct 16, 5:06 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak placed T233614: [SPIKE 8hrs] How does search work? up for grabs.
Wed, Oct 16, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T233614: [SPIKE 8hrs] How does search work? from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Oct 16, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak updated the task description for T233614: [SPIKE 8hrs] How does search work?.
Wed, Oct 16, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T233614: [SPIKE 8hrs] How does search work?.

Thanks for confirming @EBernhardson, one of the key learning from this task is that if we're to change the search experience on desktop as part of the Desktop Refresh project, we should consult the Search Platform team beforehand because changes to the UI can impact your key metrics, that and any new UI should maintain compatibility with the SearchSatisfaction schema.

Wed, Oct 16, 12:17 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak closed T234344: MinervaClientError sends malformed events as Declined.

If our statsv client is producing request urls with multiple query strings, that's a bug indeed.

Wed, Oct 16, 11:53 AM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

Thank you @Jdlrobson and @Isarra for the additional proposal of starting a new skin from scratch (and everyone who’s chimed in so far). During previous conversations with the web team, the option of a brand new skin was disregarded off-hand as being impractical. However, when considering the startup cost of fixing Vector vs. Building a Vector-like skin from scratch, I can see how the two might be comparable (having never written a skin myself though, it’s hard for me to judge).

Wed, Oct 16, 8:34 AM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC

Tue, Oct 15

Jdrewniak added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

Also, please thing about different languages. English looks really nice, but I'm afraid that in other languages those labels can be pretty long. For example in Polish language "unwatch" would become "przestań obserwować" or "usuń z obserwowanych".

Tue, Oct 15, 3:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak claimed T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.
Tue, Oct 15, 1:13 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak moved T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Oct 15, 10:14 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Mon, Oct 14

Jdrewniak updated subscribers of T233614: [SPIKE 8hrs] How does search work?.

@Jdlrobson , @phuedx thank you for further investigating the instrumentation aspects! I added some more details to the instrumentation section in the document.

Mon, Oct 14, 11:42 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Thu, Oct 10

Jdrewniak added a comment to T233614: [SPIKE 8hrs] How does search work?.

HI all, so tldr;

Thu, Oct 10, 4:49 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Wed, Oct 9

Jdrewniak claimed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons.
Wed, Oct 9, 5:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression
Jdrewniak claimed T234254: Page issues icon is misaligned vertically.
Wed, Oct 9, 5:06 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2)

Tue, Oct 8

Jdrewniak updated the task description for T234907: RFC: Where to implement Desktop Improvements project.
Tue, Oct 8, 4:59 PM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC
Jdrewniak claimed T233614: [SPIKE 8hrs] How does search work?.
Tue, Oct 8, 12:59 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T233614: [SPIKE 8hrs] How does search work? from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Oct 8, 12:59 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak created T234907: RFC: Where to implement Desktop Improvements project.
Tue, Oct 8, 11:44 AM · Desktop Improvements, Readers-Web-Backlog (Tracking), TechCom-RFC

Mon, Oct 7

Jdrewniak claimed T233521: Language selector and edit button icon not displayed on first load in iOS 13.
Mon, Oct 7, 5:24 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile
Jdrewniak moved T233521: Language selector and edit button icon not displayed on first load in iOS 13 from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Mon, Oct 7, 5:17 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile

Wed, Oct 2

Jdrewniak added a comment to T233521: Language selector and edit button icon not displayed on first load in iOS 13.

I think adding a min-width/min-height to .mw-ui-icon:before can fix this.

Wed, Oct 2, 8:18 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile
Jdrewniak added a comment to T233521: Language selector and edit button icon not displayed on first load in iOS 13.

I've tried debugging this issue and I was able to locate an affected page (GW501516 in my case) and inspect it from my iPhone using the Safari inspector.

Wed, Oct 2, 8:13 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile

Tue, Oct 1

Jdrewniak created T234344: MinervaClientError sends malformed events.
Tue, Oct 1, 4:20 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
Jdrewniak updated Jdrewniak.
Tue, Oct 1, 8:56 AM
Jdrewniak added a member for Desktop Improvements: Jdrewniak.
Tue, Oct 1, 8:56 AM

Mon, Sep 30

Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

after syncing with Jon, realized we can align this be removing the .flush-top and adding 10px top-padding to the container instead of 20px

Mon, Sep 30, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

@alexhollender @Volker_E Sorry I didn't get back on that, but yeah I think some of the positioning combined with fact the icons don't go edge to edge make it look a bit weird, but I don't see an easy fix here :/

Mon, Sep 30, 2:13 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Thu, Sep 26

Jdrewniak added a comment to T233172: [ICONS] last edited element alignment.

@Jdlrobson thank you! 🙏

Thu, Sep 26, 11:37 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Wed, Sep 25

Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

The patch above aligns the header as such that the "x" is in the corner, inside the padding and the word "citation" is vertically middle-aligned with the bookmark icon. The bookmark icon however, isn't perfectly aligned with the edge of the padding because the SVG doesn't touch the edges of its canvas.

Wed, Sep 25, 11:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak claimed T225127: Display core version of watchlist page for AMC users.
Wed, Sep 25, 5:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Needs Design Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 25, 5:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

@Jdlrobson that seems fixable, will do!

Wed, Sep 25, 5:18 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Tue, Sep 24

Jdrewniak moved T233152: [ICONS] reference drawer icon and alignment from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 24, 11:24 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak moved T233050: ICONS menu alignment and list item spacing from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 24, 10:14 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak claimed T233050: ICONS menu alignment and list item spacing.
Tue, Sep 24, 9:29 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak moved T233050: ICONS menu alignment and list item spacing from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 24, 9:29 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak placed T225127: Display core version of watchlist page for AMC users up for grabs.
Tue, Sep 24, 9:29 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Sep 24, 9:29 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

There's a minor style issue with the top portion of the page where the description and "edit your list of watched pages" button is.

Tue, Sep 24, 9:12 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 18 2019

Jdrewniak created T233193: MobileFrontend and Minerva Selenium tests failing with "Promise timeout".
Sep 18 2019, 9:06 AM · Release-Engineering-Team-TODO (201909), User-zeljkofilipin, MobileFrontend, Readers-Web-Backlog
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

We've tried enabling this change on the beta cluster, but for unknown reasons it doesn't appear to work there (works locally :/). This requires further investigation, the fault might be with the beta cluster or with the change itself.

Sep 18 2019, 8:38 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Doing to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 18 2019, 8:36 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 17 2019

Masumrezarock100 awarded T225127: Display core version of watchlist page for AMC users a Like token.
Sep 17 2019, 7:51 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak closed T225648: Improve presentation of apps on portal as Resolved.

This has been on production fro a couple of weeks with no issue, so I 'm signing it off.

Sep 17 2019, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

That's a screenshot from the deletion log page. @Zoranzoki21 , the recent changes does look wrong. (sorry but it's easier for me to spot the problem on enwiki)
I think this summarizes it:

Sep 17 2019, 10:31 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

@Zoranzoki21 is this the correct order of the words?
(summary) is deleted page (name of page).


please correct me if it is not.

Sep 17 2019, 10:18 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

@Zoranzoki21 I' trying to understand what the problem is. Is it

  1. that the summary is not aligned with the rest of the text, like in this screenshot:

Sep 17 2019, 10:01 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend

Sep 16 2019

Jdrewniak claimed T225127: Display core version of watchlist page for AMC users.
Sep 16 2019, 11:49 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 16 2019, 11:49 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 13 2019

Jdrewniak added a comment to T230034: [AMC] Menu handle has no active state.

after icon changes you get a square, hurraz.

Sep 13 2019, 2:09 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
Jdrewniak moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 13 2019, 1:49 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression
Jdrewniak moved T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 13 2019, 1:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression
Jdrewniak added a project to T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons: Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1).
Sep 13 2019, 1:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression
Jdrewniak created T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons.
Sep 13 2019, 1:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression

Sep 12 2019

Jdrewniak added a comment to T232792: [Regression] ICONS: Not compatible with truncated text (last modified and logout button).

Since this following is also last-modified-bar related, I'm just gonna tack this on here.

Sep 12 2019, 11:34 PM · Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Sep 5 2019

Jdrewniak moved T231683: Remove concept of "large" icon in MF/Minerva from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 5 2019, 5:12 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak closed T226068: AMC Outreach - Modal, a subtask of T226067: [EPIC] AMC Outreach, as Resolved.
Sep 5 2019, 5:09 PM · Epic, Readers-Web-Backlog, Advanced Mobile Contributions
Jdrewniak closed T226068: AMC Outreach - Modal, a subtask of T226069: AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows), as Resolved.
Sep 5 2019, 5:09 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak closed T226068: AMC Outreach - Modal, a subtask of T231206: Turn on AMC outreach modal, as Resolved.
Sep 5 2019, 5:09 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdrewniak closed T226068: AMC Outreach - Modal as Resolved.
Sep 5 2019, 5:09 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak claimed T231683: Remove concept of "large" icon in MF/Minerva.
Sep 5 2019, 9:30 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak moved T231683: Remove concept of "large" icon in MF/Minerva from Needs Design Review to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 5 2019, 9:30 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak reassigned T231683: Remove concept of "large" icon in MF/Minerva from Jdrewniak to alexhollender.
Sep 5 2019, 9:30 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Sep 4 2019

Jdrewniak added a comment to T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

@alexhollender, @Jdlrobson regarding the icon spec noted above (T229440#5452894), I've sketched out an implementation that I think meets the requirements and (hopefully) is compatible with the current CSS classes we're using. This implementation affords for small/medium icons with/without padding, as well as with padding flush left/right. In the instance where the icons are flush, the glyph sits at the edge of the touch area. @alexhollender you mention this in your last point, but I think overflowing the container is a bit risky as it could cause horizontal scrolling.

Sep 4 2019, 3:36 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Sep 3 2019

Jdrewniak added a comment to T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

☝️I agree with this plan of action :)

Sep 3 2019, 8:04 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak added a comment to T231839: Run fundraising messages on portal in Japan.

@Pcoombe yup! no problem :)

Sep 3 2019, 12:02 PM · Wikimedia-Fundraising-Banners, Wikimedia-Portals

Sep 2 2019

Jdrewniak moved T231054: Disabling the recent changes highlighting feature on Minerva from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 2 2019, 11:36 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Aug 29 2019

Jdrewniak added a comment to T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

@alexhollender I merged the updated icon SVGs today. The change affects the sizing of a lot of the old icons, makes many of the sidebar ones bigger (the new ones remain the same size).

Aug 29 2019, 4:56 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Aug 28 2019

Jdrewniak claimed T231054: Disabling the recent changes highlighting feature on Minerva.
Aug 28 2019, 1:22 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak moved T231054: Disabling the recent changes highlighting feature on Minerva from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 28 2019, 1:22 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak added a comment to T225648: Improve presentation of apps on portal.

hello @Charlotte, @schoenbaechler . Good news, this went out on the EU swat deploy today!

Aug 28 2019, 11:50 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 26 2019

Jdrewniak assigned T229295: Cleanup AMC feature flagging to Edtadros.
Aug 26 2019, 11:14 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Jdrewniak placed T229295: Cleanup AMC feature flagging up for grabs.
Aug 26 2019, 11:14 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Jdrewniak placed T225648: Improve presentation of apps on portal up for grabs.
Aug 26 2019, 11:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak placed T230656: Minerva styles the wrong selector for rollback link up for grabs.
Aug 26 2019, 10:55 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Confirmation prompt for rollback action, UI-Standardization, Advanced Mobile Contributions
Jdrewniak moved T230656: Minerva styles the wrong selector for rollback link from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 26 2019, 10:55 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Confirmation prompt for rollback action, UI-Standardization, Advanced Mobile Contributions
Jdrewniak added a comment to T230656: Minerva styles the wrong selector for rollback link.

Per AQ steps: this looks good on beta.

Aug 26 2019, 10:55 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Confirmation prompt for rollback action, UI-Standardization, Advanced Mobile Contributions
Jdrewniak moved T225648: Improve presentation of apps on portal from Blocked on Others to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 26 2019, 1:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 21 2019

Jdrewniak added a comment to T230656: Minerva styles the wrong selector for rollback link.

@Niedzielski 👍

Aug 21 2019, 5:14 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Confirmation prompt for rollback action, UI-Standardization, Advanced Mobile Contributions
Jdrewniak moved T225648: Improve presentation of apps on portal from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 21 2019, 12:38 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 20 2019

cmadeo awarded T225648: Improve presentation of apps on portal a Love token.
Aug 20 2019, 3:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 19 2019

Jdrewniak moved T230445: JS Error occurs when cancelling writing a comment on mobile structured talk pages from Needs Analysis to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 19 2019, 10:50 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug, MobileFrontend

Aug 16 2019

Iniquity awarded T225648: Improve presentation of apps on portal a Love token.
Aug 16 2019, 12:46 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 13 2019

Jdrewniak placed T225535: Notifications tray (mobile) - design refinements up for grabs.
Aug 13 2019, 5:18 PM · Readers-Web-Backlog, Growth-Team, Notifications
Jdrewniak moved T225535: Notifications tray (mobile) - design refinements from Doing to Needs Analysis on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 13 2019, 5:18 PM · Readers-Web-Backlog, Growth-Team, Notifications
Jdrewniak moved T225648: Improve presentation of apps on portal from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 13 2019, 11:15 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak claimed T225648: Improve presentation of apps on portal.
Aug 13 2019, 11:15 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Aug 9 2019

Jdrewniak claimed T225535: Notifications tray (mobile) - design refinements.
Aug 9 2019, 9:36 AM · Readers-Web-Backlog, Growth-Team, Notifications
Jdrewniak moved T225535: Notifications tray (mobile) - design refinements from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 9 2019, 9:36 AM · Readers-Web-Backlog, Growth-Team, Notifications

Aug 8 2019

Jdrewniak closed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs, a subtask of T198313: [GOAL] Advanced mobile contributions, as Resolved.
Aug 8 2019, 1:44 PM · Advanced Mobile Contributions, Goal, Readers-Web-Backlog
Jdrewniak closed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs as Resolved.
Aug 8 2019, 1:44 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak closed T221012: Extract $skinOptions from SkinMinerva class, a subtask of T221022: [EPIC] Divide MobileFrontend component concerns, as Resolved.
Aug 8 2019, 1:41 PM · Readers-Web-Backlog, Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Jdrewniak closed T221012: Extract $skinOptions from SkinMinerva class as Resolved.
Aug 8 2019, 1:41 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Aug 7 2019

Jdrewniak added a comment to T225213: Main Menu should work without javascript.

the browser support for these features is practically universal.

I guess, in theory... http://timpietrusky.com/advanced-checkbox-hack

Aug 7 2019, 10:55 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Jdrewniak added a comment to T229360: [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience.

@alexhollender
bugs: 1, 2, 3 & "Display issues with log entries T229360#5394174"
enhancements: 1, 3, 5
are live on beta.

Aug 7 2019, 10:06 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Advanced Mobile Contributions
Jdrewniak added a comment to T225213: Main Menu should work without javascript.

In terms of browser support, the mechanism employed in the overflow menu & user menu is called the checkbox hack.
It was pioneered in 2010 and it depends on a few CCS level 3 features:

Aug 7 2019, 9:37 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Aug 6 2019

Jdrewniak claimed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs.
Aug 6 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak claimed T221012: Extract $skinOptions from SkinMinerva class.
Aug 6 2019, 5:05 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak added a comment to T229360: [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience.

@Jdlrobson I didn't realize the work here should be split off into separate tasks, so I attached the last patch to this task instead (it's small though). The patch I submitted above https://gerrit.wikimedia.org/r/528438 addresses refinements 1, 3, 5.

Aug 6 2019, 12:41 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Advanced Mobile Contributions