Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (266 w, 2 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Yesterday

Jdrewniak closed T268229: Make WVUI export compatible with ResourceLoader, a subtask of T264355: Integrate wvui-search-form into Vector, as Resolved.
Wed, Nov 25, 6:05 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak closed T268229: Make WVUI export compatible with ResourceLoader as Resolved.
Wed, Nov 25, 6:05 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Thu, Nov 19

Jdrewniak added a comment to T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .

Given the low effort of implementing the positive tabindex approach (changing a few lines in the Mustache templates), I recommend we move forward with that approach because although it's considered an anti-pattern, it effectively solves this issue for mobile as well as non-JS users. If it becomes a maintenance concern in the future, then we can re-evaluate a JS based focus-looping technique.

Thu, Nov 19, 5:51 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike
Jdrewniak updated the task description for T268229: Make WVUI export compatible with ResourceLoader.
Thu, Nov 19, 5:05 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
phuedx awarded T268229: Make WVUI export compatible with ResourceLoader a Mountain of Wealth token.
Thu, Nov 19, 1:22 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak updated subscribers of T268229: Make WVUI export compatible with ResourceLoader.
Thu, Nov 19, 12:52 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak created T268229: Make WVUI export compatible with ResourceLoader.
Thu, Nov 19, 12:52 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Tue, Nov 17

Jdrewniak claimed T264355: Integrate wvui-search-form into Vector.
Tue, Nov 17, 6:23 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak moved T264355: Integrate wvui-search-form into Vector from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Nov 17, 6:22 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Wed, Nov 4

Jdrewniak added a comment to T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .

I've been exploring the feasibility of solving this via the DOM order change, i.e. moving the sidebar back inside the header element.

Wed, Nov 4, 4:42 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike
Jdrewniak committed rWVUIc7af5d6d091f: [components][button] Normalize button appearance (authored by Volker E <volker.e@wikimedia.org>).
[components][button] Normalize button appearance
Wed, Nov 4, 12:36 PM

Tue, Nov 3

Jdrewniak committed rWVUIefe7fd6c7f8d: [components][input] Use standard 'clear' icon (authored by Volker E <volker.e@wikimedia.org>).
[components][input] Use standard 'clear' icon
Tue, Nov 3, 12:25 PM
Jdrewniak committed rWVUIc072d60a544e: [components][input][styles] Fix end icon position (authored by Volker E <volker.e@wikimedia.org>).
[components][input][styles] Fix end icon position
Tue, Nov 3, 12:25 PM

Wed, Oct 28

Jdrewniak claimed T256043: Build the wvui-typeahead-search component for Vue.js search.
Wed, Oct 28, 5:03 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak claimed T256041: Build the wvui-search-form component for Vue.js search.
Wed, Oct 28, 5:03 PM · WVUI, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Tue, Oct 27

Jdrewniak added a comment to T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .

Besides the two approaches considered above, which can be summarized as:

Tue, Oct 27, 4:42 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike

Oct 19 2020

Jdrewniak placed T244287: Build the Vue.js search component network client up for grabs.
Oct 19 2020, 5:15 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements

Oct 14 2020

Jdrewniak added a comment to T240489: [Epic] Determine the optimum Vector DOM structure for a11y and performance.

Just to recap the work done in this task: In accordance with the arguments presented above, the DOM order in modern Vector has been changed to reflect the visual flow of the page.
These changes will let us: shed a significant portion of the legacy CSS, improve the presentation on smaller screens, improve the loading experience, and bring Vector in line with more common accessibility patterns on the web.

Oct 14 2020, 8:59 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Performance-Team (Radar), Accessibility, Desktop Improvements

Oct 7 2020

Jdrewniak claimed T244287: Build the Vue.js search component network client.
Oct 7 2020, 5:12 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements

Oct 6 2020

Jdrewniak added a comment to T264309: Reorganize Vector CSS folder structure.

Looking at the link @Volker_E mentioned, https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#File_organization

Oct 6 2020, 4:29 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak updated the task description for T264309: Reorganize Vector CSS folder structure.
Oct 6 2020, 4:14 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak edited projects for T261334: Use `rem` in modern Vector, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Kanbanana-FY-2020-21).
Oct 6 2020, 4:07 PM · Readers-Web-Backlog, Patch-For-Review, Desktop Improvements, Vector
Jdrewniak added a parent task for T261334: Use `rem` in modern Vector: T264309: Reorganize Vector CSS folder structure.
Oct 6 2020, 4:07 PM · Readers-Web-Backlog, Patch-For-Review, Desktop Improvements, Vector
Jdrewniak added a subtask for T264309: Reorganize Vector CSS folder structure: T261334: Use `rem` in modern Vector.
Oct 6 2020, 4:07 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak added a comment to T261334: Use `rem` in modern Vector.

I'm moving this back to the backlog. because as discussed in the gerrit patch here I think we should create a separate variables file for modern Vector if we're going to have different font-related variables (at least at first) in modern and legacy Vector.

Oct 6 2020, 4:06 PM · Readers-Web-Backlog, Patch-For-Review, Desktop Improvements, Vector

Oct 5 2020

Jdrewniak closed T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class as Resolved.
Oct 5 2020, 3:05 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Desktop Improvements, MediaWiki-General, CSS
Jdrewniak closed T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class, a subtask of T240489: [Epic] Determine the optimum Vector DOM structure for a11y and performance, as Resolved.
Oct 5 2020, 3:05 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Performance-Team (Radar), Accessibility, Desktop Improvements

Oct 1 2020

Jdrewniak added a comment to T264309: Reorganize Vector CSS folder structure.

Regarding the entry files: skin.less and skin-legacy.less, I was thinking about naming both skin.less since they'd be in different folders. This is similar to the convention in Node of using index.js in multiple places. The downside of that however is that searching for those files in an IDE is difficult because they both have the same names (maybe not a big deal though). Another approach we could use for these entry files is to name them after their ResourceLoader module, so
skin.lessskins.vector.styles.less
skin-legacy.lessskins.vector.styles.legacy.less
That might be overthinking it though...

Oct 1 2020, 9:13 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak added a comment to T264309: Reorganize Vector CSS folder structure.

@Volker_E I like skins.vector.styles.common/ for consistency. I've updated the description with that, also including where layout folders could go.

Oct 1 2020, 9:01 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak updated the task description for T264309: Reorganize Vector CSS folder structure.
Oct 1 2020, 8:51 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

+1. As a reader & as an editor, I also appreciate the subtle hint that a link is going offwiki but within Wikimedia, e.g. from Wikipedia to Wiktionary, such as in the link to "toponym" in the (featured-class) article https://en.wikipedia.org/wiki/Nahuatl#Vocabulary

Oct 1 2020, 4:55 PM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector
Jdrewniak updated subscribers of T264309: Reorganize Vector CSS folder structure.
Oct 1 2020, 2:21 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak created T264309: Reorganize Vector CSS folder structure.
Oct 1 2020, 12:58 PM · Vector, Desktop Improvements, Readers-Web-Backlog
Jdrewniak added a comment to T264173: A better CSS content class naming structure (for Vector).

I definitely agree with removing the term "body" from these classes. That's certainly confusing.

Oct 1 2020, 9:38 AM · Readers-Web-Backlog, MediaWiki-Core-Skin-Architecture, Vector, CSS

Sep 30 2020

Jdrewniak added a comment to T263633: Mobile Special:EditWatchlist displays item IDs instead of labels.

@Bouzinac Although this is certainly a bug, given that switching to "advanced" mode is a workable solution, this isn't likely to be given high priority.

Sep 30 2020, 10:09 AM · MobileFrontend (MobileFrontend Special Pages), MinervaNeue (Tracking), Wikidata, Mobile
Jdrewniak renamed T263633: Mobile Special:EditWatchlist displays item IDs instead of labels from Mobile watchlist of Wikidata shows opaque names for Q items to Mobile Special:EditWatchlist displays item IDs instead of labels.
Sep 30 2020, 10:02 AM · MobileFrontend (MobileFrontend Special Pages), MinervaNeue (Tracking), Wikidata, Mobile

Sep 29 2020

Jdrewniak claimed T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen.
Sep 29 2020, 5:07 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak moved T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 29 2020, 5:07 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak claimed T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .
Sep 29 2020, 4:25 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike
Jdrewniak moved T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 29 2020, 4:25 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike
Jdrewniak added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

I love the chart on https://www.mediawiki.org/wiki/Design/Link_colors, can we mirror that in the description?
I think what we want from this task is:

Sep 29 2020, 12:54 PM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector
Ladsgroup awarded T213778: Update link colors in Vector for improved UX (and consistency) a Like token.
Sep 29 2020, 10:48 AM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector

Sep 28 2020

Jdforrester-WMF awarded T213778: Update link colors in Vector for improved UX (and consistency) a Yellow Medal token.
Sep 28 2020, 9:57 PM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector
Jdrewniak added a comment to T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .

The technique of modifying focused elements with JS is typically called focus trapping (or looping). There's a good writeup on medium of the general implementation here: Focus Trapping for Accessibility (A11Y) . It generally involves checking which element is focused and changing the next focused element during a keydown event.

Sep 28 2020, 11:34 AM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21), Spike
Jdrewniak moved T254695: Build a pre-library loading indicator for Vue.js search from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 28 2020, 10:16 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak placed T254695: Build a pre-library loading indicator for Vue.js search up for grabs.
Sep 28 2020, 10:16 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Sep 23 2020

Jdrewniak added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

We refrained from estimating this today for the following reasons:

  1. We weren't sure where these link colors are defined, and if this change will require a change in core,
  2. If it's just in Vector, we weren't sure how to separate the color variables for legacy and modern vector
  3. We weren't sure how to change the colors of the related "external link" icon (or any similar icon that appears as part of a link).
  4. We think this change requires some community consultations.
Sep 23 2020, 7:23 PM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector
Jdrewniak claimed T213778: Update link colors in Vector for improved UX (and consistency).
Sep 23 2020, 4:30 PM · User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector

Sep 21 2020

Jdrewniak placed T254695: Build a pre-library loading indicator for Vue.js search up for grabs.
Sep 21 2020, 7:55 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak moved T254695: Build a pre-library loading indicator for Vue.js search from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 21 2020, 7:55 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Sep 17 2020

Jdrewniak added a comment to T258643: Upload wordmark and tagline SVG files to Commons.

@Iniquity thanks for mentioning the CC attribution. The individual files we're uploading are actually split into workmarks/tagline e.g. frwiki-wordmark frwiki-tagline. I was thinking these files, since they are just text in an open-source font, might actually be public domain as they might not meet the Threshold of originality to have any license at all.

Sep 17 2020, 5:35 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Logos
Jdrewniak assigned T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen to Volker_E.
Sep 17 2020, 5:07 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak placed T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen up for grabs.
Sep 17 2020, 5:07 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Sep 16 2020

Jdrewniak moved T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 16 2020, 5:16 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Sep 14 2020

Jdrewniak claimed T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen.
Sep 14 2020, 8:00 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak moved T257395: Horizontal misalignment of open sidebar on Wikipedias on widescreen from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 14 2020, 8:00 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Sep 7 2020

Jdrewniak added a comment to T258643: Upload wordmark and tagline SVG files to Commons.

I've been thinking of doing this for a while now, here are my thoughts.

Sep 7 2020, 3:42 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Logos

Sep 3 2020

Jdrewniak placed T259761: Reduce space between sidebar and content up for grabs.
Sep 3 2020, 4:16 PM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak moved T259761: Reduce space between sidebar and content from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Sep 3 2020, 11:21 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Sep 2 2020

Jdrewniak claimed T258096: Regression: Nested references do not open if user clicks on [ or ] (which are wrapped in span).
Sep 2 2020, 5:11 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MobileFrontend, Regression, Readers-Web-Backlog (Kanbanana-FY-2020-21), MinervaNeue

Aug 31 2020

Jdrewniak claimed T249363: Move the existing search to the header in preparation for Vue.js search development.
Aug 31 2020, 5:07 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, Vue.js (Vue.js-Search), Patch-For-Review
Jdrewniak added a comment to T255603: Design spec for new Vue.js search experience.

was just noticing that it's common for the search term to remain in the search box once the search has been submitted. I think this makes sense for search experiences where search leads you to a list of results. I'm not sure if it still makes sense in our case where you land on a specific result (rather than a list).

Aug 31 2020, 7:51 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements

Aug 27 2020

Jdrewniak claimed T259761: Reduce space between sidebar and content.
Aug 27 2020, 1:44 PM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak moved T259761: Reduce space between sidebar and content from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Aug 27 2020, 1:43 PM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak updated the task description for T260406: Lazy loaded images: Load styles for .lazy-image-placeholder only if 'MobileFrontend' is loaded.
Aug 27 2020, 1:24 PM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdrewniak closed T260406: Lazy loaded images: Load styles for .lazy-image-placeholder only if 'MobileFrontend' is loaded as Resolved.
Aug 27 2020, 1:24 PM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Readers-Web-Backlog (Kanbanana-FY-2020-21)

Aug 26 2020

Jdrewniak moved T254695: Build a pre-library loading indicator for Vue.js search from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Aug 26 2020, 5:11 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak updated the task description for T261174: Review and summarize research on line-length + readability.
Aug 26 2020, 4:05 PM · Readers-Web-Backlog (Tracking), Desktop Improvements

Aug 20 2020

Jdrewniak claimed T254695: Build a pre-library loading indicator for Vue.js search.
Aug 20 2020, 5:18 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Aug 18 2020

Jdrewniak claimed T260406: Lazy loaded images: Load styles for .lazy-image-placeholder only if 'MobileFrontend' is loaded.
Aug 18 2020, 5:12 PM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdrewniak claimed T207929: Lazy loaded images: Styles are not copied across from img tags when an image is lazy loaded.
Aug 18 2020, 5:12 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Readers-Web-Backlog (Kanbanana-FY-2020-21), MobileFrontend, Math
Jdrewniak claimed T252025: Lazy loading code should not run on talk pages (currently not showing any images in overlays).
Aug 18 2020, 5:11 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Talk Pages, MobileFrontend

Aug 17 2020

Jdrewniak placed T254695: Build a pre-library loading indicator for Vue.js search up for grabs.
Aug 17 2020, 1:05 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)
Jdrewniak moved T254695: Build a pre-library loading indicator for Vue.js search from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Aug 17 2020, 1:05 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Aug 12 2020

Jdrewniak added a comment to T259203: Clarify CSS naming scheme on combined components.

Is this mainly a question of vocabulary? I think the usage itself is consistent with the BEM concept of modifiers.

Aug 12 2020, 1:20 PM · WVUI

Aug 10 2020

Jdrewniak closed T259080: Minerva bundle checks are broken as Resolved.
Aug 10 2020, 12:08 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MinervaNeue, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Aug 7 2020

Jdrewniak moved T254695: Build a pre-library loading indicator for Vue.js search from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Aug 7 2020, 12:08 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Aug 4 2020

Jdrewniak moved T254227: Switch test wikis to new version of vector by default from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Aug 4 2020, 5:11 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak claimed T259080: Minerva bundle checks are broken.
Aug 4 2020, 5:06 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MinervaNeue, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Jul 28 2020

Jdrewniak claimed T253842: Fix the printable versions of modern Vector.
Jul 28 2020, 5:12 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Vector, Desktop Improvements
Jdrewniak added a comment to T254695: Build a pre-library loading indicator for Vue.js search.

The implementation can live within WVUI if potentially useful to any search consumer or directly within Vector if not.

I assumed since this loader should kick in before the Vue library loads, that it should live in Vector.

Jul 28 2020, 12:15 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Jul 27 2020

Jdrewniak closed T249304: Configure ESLint and stylelint for Vue.js search development ahead of it being done for all repos, a subtask of T249298: [Epic] Establish initial project scaffolding for Vue.js search iterations, as Resolved.
Jul 27 2020, 11:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Epic, Desktop Improvements
Jdrewniak closed T249304: Configure ESLint and stylelint for Vue.js search development ahead of it being done for all repos as Resolved.
Jul 27 2020, 11:08 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Code-Health, Continuous-Integration-Config
Jdrewniak added a comment to T258588: Sidebar collapsed by default on desktop improvements.

Are we receiving feedback that this behavior is problematic? If we know this is the eventual final state, I wonder if we need to do anything here?

Jul 27 2020, 11:06 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)

Jul 21 2020

Jdrewniak updated the task description for T254227: Switch test wikis to new version of vector by default.
Jul 21 2020, 11:04 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdrewniak added a comment to T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action.

in terms of testing before the javascript has loaded, the Chrome devtools provide a neat network throttling capability

Jul 21 2020, 6:30 PM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility

Jul 20 2020

Jdrewniak added a comment to T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action.
Jul 20 2020, 10:42 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility
Jdrewniak added a comment to T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action.

I did a bit of research as to why this happens. I wasn't aware of this browser behaviour, but apparently, when you click on an internal link <a href="#target">menu link</a> the target element <h2 id="target">over here</h2> actually gets the keyup event if it's focusable. Since our menu button uses tabindex=0 to force focus, it receives the keyup event that originates from pressing the "skip to navigation" skip link.

Jul 20 2020, 10:23 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility

Jul 16 2020

Jdrewniak placed T255727: Make collapsible sidebar persistent for logged-in users up for grabs.
Jul 16 2020, 9:15 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Demian, Patch-For-Review, Desktop Improvements
Jdrewniak placed T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action up for grabs.
Jul 16 2020, 9:14 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility
Jdrewniak moved T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action from Needs QA to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jul 16 2020, 9:14 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility
Jdrewniak added a comment to T254851: Current checkbox hack doesn't provide <Enter> or <Space> as toggle action.

I found a bug with this implementation. When clicking the "jump to navigation" skip link, the sidebar changes state. The patch above provides a fix by removing the keyup event binding on the checkbox hack. I'm not 100% sure why that event binding causes this to happen, but removing it prevents this behaviour.

Jul 16 2020, 9:13 AM · RW-Feature-DI-Collapsible-Sidebar (Passed QA), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), User-Demian, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Desktop Improvements, MediaWiki-Interface, Accessibility

Jul 15 2020

Jdrewniak moved T255727: Make collapsible sidebar persistent for logged-in users from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jul 15 2020, 9:29 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Demian, Patch-For-Review, Desktop Improvements
Jdrewniak added a comment to T254695: Build a pre-library loading indicator for Vue.js search.

... and promise that results will be presented as quickly as possible.

Jul 15 2020, 11:28 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search)

Jul 14 2020

Jdrewniak added a comment to T255603: Design spec for new Vue.js search experience.

Also re:Loading indicator, I think we have to take into account when we exactly we want that to appear, and how likely it is that someone will see it.
I don't know if we've settled on the loading strategy for the widget, but if we load the code for the widget lazily, e.g. we wait until someone focuses or hovers on the search input before we initiate the search-suggestion code, then it's likely that the initial search suggestions will be delayed (for the benefit of loading less code upfront). In this scenario it might be good to notify the users that some results are on the way, but if we show some sort of loading indicator on subsequent API requests, while users are typing, in between keypresses, I think that might be distracting.

Jul 14 2020, 6:01 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements
Jdrewniak claimed T255727: Make collapsible sidebar persistent for logged-in users.
Jul 14 2020, 5:24 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Demian, Patch-For-Review, Desktop Improvements
Jdrewniak moved T246977: Run baseline quicksurvey on test wikis from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jul 14 2020, 5:16 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Surveys
Jdrewniak updated subscribers of T255603: Design spec for new Vue.js search experience.

Re: Namespace search. The search API only searches the main namespace unless the beginning of the query matches the namespace name exactly.

Jul 14 2020, 4:55 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js (Vue.js-Search), Desktop Improvements

Jul 13 2020

Jdrewniak updated the task description for T255727: Make collapsible sidebar persistent for logged-in users.
Jul 13 2020, 12:05 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Demian, Patch-For-Review, Desktop Improvements
Jdrewniak updated the task description for T255727: Make collapsible sidebar persistent for logged-in users.
Jul 13 2020, 12:04 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Demian, Patch-For-Review, Desktop Improvements