Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (227 w, 22 h)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Today

Jdrewniak claimed T242895: Safari crashes on some click handling events for banners that move the centralNotice element outside of the the main body.
Tue, Feb 25, 6:23 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team (Radar), MinervaNeue (Tracking), Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Yesterday

Jdrewniak claimed T242781: Transition Vector Gruntfile.js tasks to NPM scripts.
Mon, Feb 24, 9:05 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Technical-Debt

Wed, Feb 12

Jdrewniak added a comment to T236711: It should be possible to customise the implementation of mw.util.addPortletLink function on a skin basis.

It should be possible to customise the implementation of mw.util.addPortletLink function on a skin basis

This sounds like a sensible idea to me. A skins major responsibility is customizing DOM output, so why should skins have to conform to an html structure that might not be suitable for them?
Here's an idea: could we pass mw.util.addPortletLink a mustache template on a per-skin/per-menu basis?

Wed, Feb 12, 3:37 PM · Readers-Web-Backlog, Performance-Team (Radar), Patch-For-Review, Desktop Improvements, MinervaNeue (3rd party support), MediaWiki-General

Mon, Feb 3

Jdrewniak created T244181: [print] Article title hidden with mobile print styles.
Mon, Feb 3, 9:25 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Readers-Web-Backlog (Kanbanana-2019-20-Q3), MinervaNeue
Jdrewniak created T244179: [print] Mangled characters when printing from Chrome on Mac.
Mon, Feb 3, 9:13 PM · Upstream, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Browser-support-print-media, MinervaNeue

Jan 14 2020

Jdrewniak claimed T236328: Username should be on its own line (Recent changes & Watchlist).
Jan 14 2020, 6:15 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak claimed T242505: Upgrade MinervaNeue skin.json schema to manifest_version 2.
Jan 14 2020, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), MinervaNeue
Jdrewniak added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I'm very excited about this proposal and eager to adopt a modern framework like Vue!
I think there's still a lot of infrastructure that needs to be put in place to take advantage of single-file components, and I'm wondering what the developer experience is like without them.

Jan 14 2020, 11:51 AM · Security-Team, TechCom-RFC

Jan 8 2020

Jdrewniak added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

🤷‍♂️ oh well...

Jan 8 2020, 4:31 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 8 2020, 2:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 7 2020

Jdrewniak closed T234907: RFC: Where to implement Desktop Improvements project as Resolved.

@pmiazga , @Bawolff thanks for the warnings about the SkinVector class, we will take heed.
As mentioned above, the proposal was on Last Call until December 11, so I'm closing it out now and we're go ahead with the proposal (building desktop improvements inside Vector).
Lots of exciting work ahead!

Jan 7 2020, 6:00 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Jdrewniak updated the task description for T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts.
Jan 7 2020, 2:48 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak claimed T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts.
Jan 7 2020, 1:42 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 7 2020, 1:42 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts from Ready for Development to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 7 2020, 1:42 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T206069: Transition MobileFrontend Gruntfile.js tasks to NPM scripts.

Maybe we can even run the npm scripts in parallel to get them over with faster? I don't think the linters are interdependent.
NPM packages like concurrently can parallelize npm scripts (so can &, but this does it cross-platform) and that one has a --kill-others-on-fail option which returns a non-zero exit code if any of the tasks fail.

Jan 7 2020, 1:01 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Google-Code-in-2019, patch-welcome, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

@nray @Jdlrobson Yeah, I don't see how we can avoid this bug without adding a class on page load. Removing the animation check & tests is fine, but we'll still have to add a class to the body.

Jan 7 2020, 12:35 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 6 2020

Jdlrobson awarded T225213: Main Menu should work without JavaScript to be more accessible and a better user experience a Like token.
Jan 6 2020, 6:16 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak closed T214051: Reference Drawers execute events for previously closed Drawers as Resolved.

yippee! looks fixed.

Jan 6 2020, 2:35 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend
Jdrewniak placed T236328: Username should be on its own line (Recent changes & Watchlist) up for grabs.
Jan 6 2020, 2:02 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak assigned T225213: Main Menu should work without JavaScript to be more accessible and a better user experience to alexhollender.
Jan 6 2020, 2:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak placed T225213: Main Menu should work without JavaScript to be more accessible and a better user experience up for grabs.
Jan 6 2020, 2:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak moved T236328: Username should be on its own line (Recent changes & Watchlist) from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Jan 6 2020, 2:01 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

@alexhollender the change is live on the beta cluster. It'll go live whenever the train rolls around (I think it's this week).
https://drive.google.com/file/d/1GqQ8ZeXyxFoJP1SlfLrj0Py4e7E1Iyhr/view?usp=sharing
I think it looks pretty nice myself :D

Jan 6 2020, 12:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Dec 23 2019

Volker_E awarded T234907: RFC: Where to implement Desktop Improvements project a Mountain of Wealth token.
Dec 23 2019, 12:49 AM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 19 2019

Volker_E awarded T225213: Main Menu should work without JavaScript to be more accessible and a better user experience a Grey Medal token.
Dec 19 2019, 10:11 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Dec 16 2019

Jdrewniak placed T235750: [20hrs] Prototype first few feature ideas for desktop improvements up for grabs.
Dec 16 2019, 2:44 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T235750: [20hrs] Prototype first few feature ideas for desktop improvements from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 16 2019, 2:44 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak placed T237636: [SPIKE 10hrs] Build new header within the Vector skin up for grabs.
Dec 16 2019, 2:42 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T237636: [SPIKE 10hrs] Build new header within the Vector skin from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 16 2019, 2:42 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T240489: [SPIKE] Determine the optimum Vector DOM structure for a11y and performance.

@Volker_E Currently below every article title on Vector there's the tagline "From Wikipedia, the free encyclopedia". If we maintain that tagline, I don't think it's useful to basically repeat that line above the content as well.
We should consider whether we still want the tagline there, and if we do, whether we need alt-text on the logo or not.

Dec 16 2019, 2:33 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team (Radar), Accessibility, Desktop Improvements
Jdrewniak added a parent task for T232140: Separate out logo handling into square image logos and long text/wordmark banner logos: T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:21 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
Jdrewniak added a parent task for T114695: Split mediawiki.skinning.interface css files into separate modules: T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:21 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-Interface
Jdrewniak added a parent task for T239248: [EPIC] Divide VectorTemplate into components: T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:21 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector
Jdrewniak added a parent task for T240489: [SPIKE] Determine the optimum Vector DOM structure for a11y and performance: T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:21 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team (Radar), Accessibility, Desktop Improvements
Jdrewniak added subtasks for T240856: [EPIC] New header for desktop improvements project: T240489: [SPIKE] Determine the optimum Vector DOM structure for a11y and performance, T239248: [EPIC] Divide VectorTemplate into components, T232140: Separate out logo handling into square image logos and long text/wordmark banner logos, T114695: Split mediawiki.skinning.interface css files into separate modules.
Dec 16 2019, 2:21 PM · Performance-Team (Radar), Desktop Improvements, Epic
Jdrewniak added a comment to T237636: [SPIKE 10hrs] Build new header within the Vector skin.

I've created an epic to encompass the work needed for the new header: T240856

Dec 16 2019, 2:18 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak updated subscribers of T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:12 PM · Performance-Team (Radar), Desktop Improvements, Epic
Jdrewniak updated the task description for T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 2:12 PM · Performance-Team (Radar), Desktop Improvements, Epic
Jdrewniak created T240856: [EPIC] New header for desktop improvements project.
Dec 16 2019, 1:13 PM · Performance-Team (Radar), Desktop Improvements, Epic

Dec 13 2019

Jdrewniak updated the task description for T235750: [20hrs] Prototype first few feature ideas for desktop improvements.
Dec 13 2019, 6:16 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak updated the task description for T235750: [20hrs] Prototype first few feature ideas for desktop improvements.
Dec 13 2019, 6:15 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Dec 7 2019

thiemowmde awarded T234907: RFC: Where to implement Desktop Improvements project a Love token.
Dec 7 2019, 4:33 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 5 2019

Jdrewniak updated the task description for T238681: History icon not completely visible in smaller screen devices.
Dec 5 2019, 10:42 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue
Jdrewniak moved T238681: History icon not completely visible in smaller screen devices from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 5 2019, 10:33 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue

Dec 4 2019

Jdrewniak added a project to T239609: The N'Ko language cannot be looked up in the languages search box on Mobile web: Readers-Web-Backlog.
Dec 4 2019, 10:59 AM · Readers-Web-Backlog, MobileFrontend
Jdrewniak added a comment to T237636: [SPIKE 10hrs] Build new header within the Vector skin.

Although this task sets out to actually try and build a new "throwaway" header, I've identified some ground-work that has to happen before we can even begin building a new header:

Dec 4 2019, 10:42 AM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T239304: MinervaNeue: Desktop mode has invisible menu button from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 4 2019, 9:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak moved T239304: MinervaNeue: Desktop mode has invisible menu button from Incoming to Kanbanana-2019-20-Q2 on the Readers-Web-Backlog board.
Dec 4 2019, 9:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak added a comment to T239304: MinervaNeue: Desktop mode has invisible menu button.

I'm unable to reproduce on Chrome on Windows, but we have gotten reports of this issue sporadically.
Currently I'm seeing a disappearing icon on Mac Safari on the Wikimedia beta cluster. https://en.m.wikipedia.beta.wmflabs.org/wiki/TemplateUsageArticle392#
I also noticed this issue when using the VoiceOver screen-reader on iOS, in which icons disappear after the focus has been placed on them.

Dec 4 2019, 9:58 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak placed T238681: History icon not completely visible in smaller screen devices up for grabs.
Dec 4 2019, 12:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue
Jdrewniak moved T238681: History icon not completely visible in smaller screen devices from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Hope that does it.

Dec 4 2019, 12:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue

Dec 3 2019

Jdrewniak moved T236328: Username should be on its own line (Recent changes & Watchlist) from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 3 2019, 10:55 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak placed T236328: Username should be on its own line (Recent changes & Watchlist) up for grabs.
Dec 3 2019, 10:53 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak added a comment to T239183: Enable 'selector-max-id' stylelint rule on MinervaNeue/MobileFrontend.

Since this is only a linting change and only adds comments, I figured it's ok to skip QA.

Dec 3 2019, 10:52 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, MinervaNeue
Jdrewniak moved T239183: Enable 'selector-max-id' stylelint rule on MinervaNeue/MobileFrontend from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 3 2019, 10:50 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, MinervaNeue
Jdrewniak added a comment to T235750: [20hrs] Prototype first few feature ideas for desktop improvements.

@Quiddity mentioned that the prototype doesn't do a good job of loading certain language specific templates, such as the French Wikipedia's infoboxes

Dec 3 2019, 10:15 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T237636: [SPIKE 10hrs] Build new header within the Vector skin.
Dec 3 2019, 1:48 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T237636: [SPIKE 10hrs] Build new header within the Vector skin from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 3 2019, 11:48 AM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Dec 2 2019

Jdrewniak added a comment to T239304: MinervaNeue: Desktop mode has invisible menu button.

@SpookyGhost8 what browser/OS is this occurring on?

Dec 2 2019, 11:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)

Nov 27 2019

Jdrewniak moved T235750: [20hrs] Prototype first few feature ideas for desktop improvements from Doing to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 27 2019, 6:18 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak placed T235750: [20hrs] Prototype first few feature ideas for desktop improvements up for grabs.
Nov 27 2019, 6:18 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Nov 26 2019

Jdrewniak added a comment to T237636: [SPIKE 10hrs] Build new header within the Vector skin.

We also had a conversation about DOM order during our offsite in regards to accessibility. My intuition says that rendering the content first, as Vector currently does, makes life easier for screen-readers & assistive tech, since they don't have to skip through the navigation to get to the content.

Nov 26 2019, 10:28 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T236328: Username should be on its own line (Recent changes & Watchlist).
Nov 26 2019, 6:16 PM · Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Advanced Mobile Contributions
Jdrewniak updated subscribers of T237636: [SPIKE 10hrs] Build new header within the Vector skin.

Currently in the Vector skin, the header HTML, (along with the sidebar & other navigation) are placed below the content. (The header is made to look like it is above the content with CSS).
My understanding is that this was done for performance purposes - so that page content loads first, as well as for accessibility reasons - so that page content is the first thing presented to screen-readers.

Nov 26 2019, 5:31 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T238563: portals/deploy build broken due to a syntax error in stylelint npm module.

I tried to update the peer dependencies, but this led to the following error when building a binary with node-gyp :/ so I think a revert is in order here.

Nov 26 2019, 11:00 AM · Release-Engineering-Team-TODO (201911), ci-test-error, Wikimedia-Portals

Nov 25 2019

Jdrewniak claimed T238563: portals/deploy build broken due to a syntax error in stylelint npm module.
Nov 25 2019, 1:24 PM · Release-Engineering-Team-TODO (201911), ci-test-error, Wikimedia-Portals

Nov 19 2019

Jdrewniak committed R2668:d73818ae7e6a: “Components”: Add designing images to checkboxes and radio buttons (#302) (authored by Volker E <Volker-E@users.noreply.github.com>).
“Components”: Add designing images to checkboxes and radio buttons (#302)
Nov 19 2019, 4:40 PM

Nov 14 2019

Jdrewniak moved T236589: Page Previews Storybook not available on doc.wikimedia.org and documentation a bit broken from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Since there's already a patch up for this task (thank you @Jdlrobson!) I think this can be estimated and moved to the code-review column.

Nov 14 2019, 10:28 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Documentation, Page-Previews

Nov 13 2019

Jdrewniak closed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements, a subtask of T235111: GOAL: Determine scope of Desktop Improvements begin technical setup, as Resolved.
Nov 13 2019, 10:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Desktop Improvements
Jdrewniak closed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements as Resolved.

Looks like this task has been thoroughly analyzed and followup conversations are planned, so this task can be resolved. Looking forward to the Modern Event Platform!

Nov 13 2019, 10:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, Event-Platform, Desktop Improvements

Nov 12 2019

Jdrewniak claimed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements.
Nov 12 2019, 6:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, Event-Platform, Desktop Improvements
Jdrewniak moved T183105: Bump running text size up slightly on print stylesheets from Ready for Signoff to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 12 2019, 11:32 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak moved T183105: Bump running text size up slightly on print stylesheets from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 12 2019, 11:31 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak added a comment to T183105: Bump running text size up slightly on print stylesheets.

As this just affects print styles, I didn't see the harm in merging the proposed patch. Moving to design review in case @alexhollender has any comments on this. (Merged patch should be visible on the beta cluster).

Nov 12 2019, 11:30 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak renamed T183105: Bump running text size up slightly on print stylesheets from Bump running text size up slightly to Bump running text size up slightly on print stylesheets.
Nov 12 2019, 10:28 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)

Nov 6 2019

Jdrewniak assigned T225213: Main Menu should work without JavaScript to be more accessible and a better user experience to Jdlrobson.
Nov 6 2019, 1:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak placed T225213: Main Menu should work without JavaScript to be more accessible and a better user experience up for grabs.
Nov 6 2019, 1:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 6 2019, 1:00 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Nov 5 2019

Jdrewniak added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

@Jdlrobson yes that issue was addressed just after the branch cut last week, so it should appear solved soon.

Nov 5 2019, 6:49 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak claimed T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
Nov 5 2019, 6:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Nov 4 2019

Jdrewniak closed T203137: Dev: Standardising our use of headless node qunit tests across Popups and MobileFrontend as Resolved.
Nov 4 2019, 6:04 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Nov 1 2019

Esanders awarded T234907: RFC: Where to implement Desktop Improvements project a Party Time token.
Nov 1 2019, 5:28 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

As @Jdlrobson mentioned earlier, the Web Team intended to make a decision on this by October 31 🎃.
I've updated the task description with our decision under the heading "RFC Outcome". Instead of forking Vector as originally proposed, we will be implementing the Desktop Improvements project inside Vector. Every option has it's trade-offs, and after considering the points made in this discussion, we felt that working in Vector was the most pragmatic way forward.
Thanks to everyone who contributed to this discussion!

Nov 1 2019, 4:08 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Jdrewniak updated the task description for T234907: RFC: Where to implement Desktop Improvements project.
Nov 1 2019, 3:53 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

@Bawolff thanks for your comment. I agree that in an ideal world, a new skin would be the most sensible option. However, given the state of the skinning system, extension compatibility, gadget compatibility, community buy-in, etc. I don't think the ecosystem is in a state where an additional skin is maintainable. As you mention, the "current experience maintained in parallel" line in Proposal 2 recognizes that realistically, we can't get rid of the current Vector "experience" anytime soon.

Nov 1 2019, 2:37 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Oct 30 2019

Jdrewniak claimed T235750: [20hrs] Prototype first few feature ideas for desktop improvements.
Oct 30 2019, 5:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T226562: AMC - display labels for toolbar actions on larger screens.
Oct 30 2019, 5:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 29 2019

Jdrewniak moved T226562: AMC - display labels for toolbar actions on larger screens from Needs QA to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 29 2019, 11:14 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

I made one followup patch to fix an issue in non-amc mode with the labels.

Oct 29 2019, 11:14 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 28 2019

Jdrewniak updated subscribers of T235750: [20hrs] Prototype first few feature ideas for desktop improvements.

A couple of weeks ago @santhosh reached out to me to show his side-project https://wikivue.netlify.com
(source code at https://gitlab.com/santhoshtr/wikivue/tree/master/src)

Oct 28 2019, 12:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Oct 23 2019

Jdrewniak changed the subtype of T226562: AMC - display labels for toolbar actions on larger screens from "Spike" to "Task".
Oct 23 2019, 5:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak renamed T226562: AMC - display labels for toolbar actions on larger screens from [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens to AMC - display labels for toolbar actions on larger screens.
Oct 23 2019, 5:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak moved T226562: AMC - display labels for toolbar actions on larger screens from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 23 2019, 5:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 17 2019

Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

we (the Reader’s Web team) have been giving a lot more thought to the new-skin & update-vector proposals recently.

Oct 17 2019, 11:05 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Oct 16 2019

Jdrewniak claimed T203137: Dev: Standardising our use of headless node qunit tests across Popups and MobileFrontend.
Oct 16 2019, 5:06 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak placed T233614: [SPIKE 8hrs] How does search work? up for grabs.
Oct 16 2019, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T233614: [SPIKE 8hrs] How does search work? from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 16 2019, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak updated the task description for T233614: [SPIKE 8hrs] How does search work?.
Oct 16 2019, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T233614: [SPIKE 8hrs] How does search work?.

Thanks for confirming @EBernhardson, one of the key learning from this task is that if we're to change the search experience on desktop as part of the Desktop Refresh project, we should consult the Search Platform team beforehand because changes to the UI can impact your key metrics, that and any new UI should maintain compatibility with the SearchSatisfaction schema.

Oct 16 2019, 12:17 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements