Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (190 w, 6 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Fri, Jun 14

Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Fri, Jun 14, 7:15 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions

Thu, Jun 13

Jdrewniak moved T224947: Daily Minerva Selenium test job failing from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Jun 13, 5:08 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

@ovasileva nope, it's available for all. e.g. an IP userpage: https://en.m.wikipedia.org/wiki/User:66.87.68.6

Thu, Jun 13, 2:54 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

@matmarex thanks for the insight. I see it's a tricky issue because a fixed or min width is sometimes desirable. What I did to work around this issue in this case is set a max-width:100% on the container element, which offsets the min-width value.

Thu, Jun 13, 12:58 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions

Wed, Jun 12

Jdrewniak moved T225648: Improve presentation of apps on portal from Untriaged to Design on the Wikimedia-Portals board.
Wed, Jun 12, 6:23 PM · Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak claimed T225499: Fix Special:RecentChanges dropdown widget on mobile.
Wed, Jun 12, 10:25 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Jun 12, 10:24 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions

Tue, Jun 11

Jdrewniak claimed T224432: [SPIKE] Allow recent changes to display list items in AMC mode.
Tue, Jun 11, 12:56 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

I've created T225499 and updated T223363 (that one could probably use more detail though) to reflect what I think are the two bigs chunks of work in this spike.

  1. Make the filter dropdown work on mobile
  2. Make the filters look good :)
Tue, Jun 11, 12:49 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog
Jdrewniak updated the task description for T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).
Tue, Jun 11, 12:33 PM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak renamed T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile) from Cleanup Special:RecentChanges appearance on Minerva (mobile) to Cleanup Special:RecentChanges filters appearance on Minerva (mobile).
Tue, Jun 11, 12:26 PM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak renamed T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile) from Cleanup Recent changes presentation on Minerva (mobile) to Cleanup Special:RecentChanges appearance on Minerva (mobile).
Tue, Jun 11, 12:26 PM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak added a comment to T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile.

I've closed this task because while analyzing T224655 I discovered this can be fixed with OneLineOfCSS™️, so I bundled that change with a few other that would make this dropdown widget adequately function on mobile: T225499.

Tue, Jun 11, 11:51 AM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak merged T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile into T225499: Fix Special:RecentChanges dropdown widget on mobile.
Tue, Jun 11, 11:46 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak merged task T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile into T225499: Fix Special:RecentChanges dropdown widget on mobile.
Tue, Jun 11, 11:46 AM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak added a subtask for T223922: [EPIC] Display core version of recent changes page for AMC users: T225499: Fix Special:RecentChanges dropdown widget on mobile.
Tue, Jun 11, 11:46 AM · Epic, Advanced Mobile Contributions, Readers-Web-Backlog
Jdrewniak added a parent task for T225499: Fix Special:RecentChanges dropdown widget on mobile: T223922: [EPIC] Display core version of recent changes page for AMC users.
Tue, Jun 11, 11:46 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak created T225499: Fix Special:RecentChanges dropdown widget on mobile.
Tue, Jun 11, 11:44 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

@alexhollender, yes, all three filters use the same dropdown, and are thus equally broken :)

Tue, Jun 11, 9:41 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog

Mon, Jun 10

Jdrewniak moved T224947: Daily Minerva Selenium test job failing from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Jun 10, 5:08 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

When looking at this task, it occurred to me that a lot of the features work to an acceptable degree on mobile (IMO).

Mon, Jun 10, 1:57 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog

Thu, Jun 6

Jdrewniak added a comment to T221628: [Bug] Scrolled search results cannot be followed on Wikimedia portal.

I dug into this a bit today, and this bug is interesting. It's not a problem with the CSS or positioning of the search suggestions, but it's tied to how Android handles blur events.

Thu, Jun 6, 10:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-Portals
Jdrewniak updated the task description for T224947: Daily Minerva Selenium test job failing.
Thu, Jun 6, 1:04 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak placed T222228: Update icons in AMC up for grabs.
Thu, Jun 6, 12:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Jdrewniak moved T224947: Daily Minerva Selenium test job failing from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Jun 6, 12:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak edited projects for T224947: Daily Minerva Selenium test job failing, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Readers-Web-Backlog.
Thu, Jun 6, 12:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak added a comment to T223676: Minerva Node.js browser tests failing and not running against commits.

This task seems to want 2 things:

Thu, Jun 6, 12:53 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, Browser-Tests, Wikimedia-Hackathon-2019, MinervaNeue
Jdrewniak moved T222228: Update icons in AMC from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Jun 6, 12:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Jdrewniak added a comment to T224947: Daily Minerva Selenium test job failing.

Wrong token error
I've tracked down our special Minerva token error (I hope). It comes from the World.js file exporting an instance of MWBot, which holds on to its edit token. The wdio-mediawiki library requests new edit tokens for each api action, and so when we try to use that first instance, it's edit token has already been invalidated.

Thu, Jun 6, 11:44 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak updated subscribers of T224947: Daily Minerva Selenium test job failing.
Thu, Jun 6, 9:00 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak added a comment to T224947: Daily Minerva Selenium test job failing.

Error setting beta mode

Thu, Jun 6, 8:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak added a comment to T224947: Daily Minerva Selenium test job failing.

Wrong token error

Thu, Jun 6, 8:18 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue

Wed, Jun 5

Jdrewniak merged task T223676: Minerva Node.js browser tests failing and not running against commits into T224947: Daily Minerva Selenium test job failing.
Wed, Jun 5, 9:52 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, Browser-Tests, Wikimedia-Hackathon-2019, MinervaNeue
Jdrewniak merged T223676: Minerva Node.js browser tests failing and not running against commits into T224947: Daily Minerva Selenium test job failing.
Wed, Jun 5, 9:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak renamed T224947: Daily Minerva Selenium test job failing from editor_wikitext_saving.js selenium tests are failing to Daily Minerva Selenium test job failing.
Wed, Jun 5, 9:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
Jdrewniak claimed T221628: [Bug] Scrolled search results cannot be followed on Wikimedia portal.
Wed, Jun 5, 8:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-Portals
Jdrewniak claimed T222228: Update icons in AMC.
Wed, Jun 5, 8:58 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Jdrewniak moved T221628: [Bug] Scrolled search results cannot be followed on Wikimedia portal from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Jun 5, 8:54 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-Portals
Jdrewniak moved T222228: Update icons in AMC from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Jun 5, 8:43 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Jdrewniak added a comment to T219793: Mobile web donate link.

The online fundraising team can probably deploy this via CentralNotice for the purpose of initial testing

Regarding the implementation details. it's worth noting that the main menu is generated client-side, so if CentralNotice were to add a menu item, it would have to do so after the menu is generated.

Wed, Jun 5, 8:32 PM · Readers-Web-Backlog (Design), Design, WMF-Design
Jdrewniak added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

@Edtadros this is live on the beta cluster right now.
e.g:
https://en.m.wikipedia.beta.wmflabs.org/wiki/User:192.178.9.23
vs.
https://en.m.wikipedia.org/wiki/User:192.178.9.23

Wed, Jun 5, 5:29 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

this change is visible on the beta cluster right now: https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
(the .reflist element has a column-gap: 2em; rule).

Wed, Jun 5, 5:27 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
Jdrewniak moved T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Jun 5, 5:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design

Mon, Jun 3

Jdrewniak added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

@alexhollender the patch above adds a column-gap: 2em to the references list (instead of padding-right: 1em). Due to the difference in font size between Vector and Minerva, it's hard to judge if this is enough, but it's more it was before.

Mon, Jun 3, 12:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design

Thu, May 30

Jdrewniak placed T219895: Style the history page for AMC users up for grabs.
Thu, May 30, 10:05 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak moved T219895: Style the history page for AMC users from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, May 30, 10:04 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak updated the task description for T219895: Style the history page for AMC users.
Thu, May 30, 3:40 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak updated the task description for T219895: Style the history page for AMC users.
Thu, May 30, 2:58 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak updated the task description for T220114: Updates to user page treatment (apply for IP address and always show toolbar).
Thu, May 30, 2:56 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)

Wed, May 29

Jdrewniak closed T223914: New sitelink not shown on mobile as Resolved.

Probably caching. The links show up now.


Wed, May 29, 10:26 PM · MobileFrontend
Jdrewniak added a comment to T223761: Tags surrounding header tags causes them to become uncollapsible on the mobile skin.

This is something that a user on the MediaWiki Support Desk commented, so I'm not sure if this is actually a bug or not.

Wed, May 29, 10:22 PM · MobileFrontend
Jdrewniak moved T223928: Category viewer truncates category titles with a period from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, May 29, 9:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak added a project to T223928: Category viewer truncates category titles with a period: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4).
Wed, May 29, 9:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak edited projects for T224379: mobile app is killing tabs to force article of the day, added: Mobile; removed MobileFrontend.

@Dyingfromhorribledesign could you please specify which app you're referring to? (Android or iOS)

Wed, May 29, 9:33 PM · Mobile
Jdrewniak closed T222517: Flaky failure related to skin Minerva selenium tests as Resolved.
Wed, May 29, 8:31 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue

Tue, May 28

Jdrewniak moved T223676: Minerva Node.js browser tests failing and not running against commits from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 28, 2:03 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, Browser-Tests, Wikimedia-Hackathon-2019, MinervaNeue
Jdrewniak added a project to T223676: Minerva Node.js browser tests failing and not running against commits: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4).
Tue, May 28, 2:03 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, Browser-Tests, Wikimedia-Hackathon-2019, MinervaNeue

Mon, May 27

Jdrewniak added a comment to T219895: Style the history page for AMC users.

The patch above fixes the z-index issue.

Mon, May 27, 3:10 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

The workflow for when to display the stylized pages and when not was a little confusing to me at first, so I made this chart to help me step through each scenario. Maybe it'll helpful for QA or something.

Mon, May 27, 1:37 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak added a comment to T219392: AMC: add "In other projects" action to page actions overflow menu.

Armchair designer here:
Since the "In other projects" menu link behaves differently than the other menu links, could we differentiate its bit more?
My suggestion would be to add an ">" forward arrow after the text, so it reads "[icon] In other projects [>]" .
Has that already been considered?

Mon, May 27, 10:07 AM · Readers-Web-Backlog (Design), User-Jdlrobson, Advanced Mobile Contributions

Thu, May 23

Jdrewniak moved T220114: Updates to user page treatment (apply for IP address and always show toolbar) from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, May 23, 8:41 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

user pages that exist on a different wiki

Good point. I'm not sure how those kinds of pages will work. My guess is that they will show up as an "existing" page, and not as a red-link page. I think it has a "create" button on desktop because you might be able to override that page by creating a local version of it. I'm not sure how to test this behaviour locally though, so I'll need to dig into it a little more to see what happens.

Thu, May 23, 12:19 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)

Tue, May 21

Jdrewniak claimed T220114: Updates to user page treatment (apply for IP address and always show toolbar).
Tue, May 21, 1:16 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak moved T220114: Updates to user page treatment (apply for IP address and always show toolbar) from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 21, 1:15 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak moved T219895: Style the history page for AMC users from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, May 21, 9:42 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

Mon, May 20

Jdrewniak claimed T222517: Flaky failure related to skin Minerva selenium tests.
Mon, May 20, 5:09 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Wikimedia-production-error (Shared Build Failure), MinervaNeue

May 9 2019

Jdrewniak added a comment to T220998: Native spelling of Pali on www.wikipedia.org is wrong.

@Nikerabbit yeah, that sounds like a good idea :)

May 9 2019, 7:12 AM · Patch-For-Review, translatewiki.net, User-DannyS712, Wikimedia-Portals

May 7 2019

Jdrewniak moved T222394: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
May 7 2019, 1:20 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, MediaWiki-Recent-changes, Regression, MinervaNeue
Jdrewniak added a comment to T219895: Style the history page for AMC users.

you can call the mediawiki.ui mixin from whereever

Unfortunately that's not the case :( Only files in resources/src/mediawiki.less/ get that global magic, whereas the button styles are in resources/src/mediawiki.ui/.

May 7 2019, 11:35 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

May 6 2019

Jdrewniak added a comment to T219895: Style the history page for AMC users.

@Volker_E, for this task, we don't want to change the look these buttons on desktop, so we're not placing the css classes mw-ui-button mw-ui-primary mw-ui-progressive in the button HTML. Instead, we have to add these styles to the existing classes. To achieve this, we have to create a mixin that contains all the button styles we want to use on this element. The core patch above moves one button mixin into the mediawiki.less folder, making it available in Minerva.

May 6 2019, 10:57 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak added a comment to T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.

This just needs QA steps, but I'm having a hard time tracking down similar references other than the exact one in the description.

May 6 2019, 2:14 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak added a comment to T219895: Style the history page for AMC users.

@alexhollender

should we ditch the "Compare selected revisions" button at the bottom of the page?

May 6 2019, 1:38 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak added a comment to T219895: Style the history page for AMC users.

@alexhollender re: radio button functionality & grey background: Yeah, it looks like the Javascript that's responsible for changing the visibility of the radio buttons, as well as the background color of the selected revision, isn't being run on mobile. I'm not sure if there's an easy way to enable this, but I'll look into it.

May 6 2019, 11:10 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

May 2 2019

Jdrewniak added a comment to T222394: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist".

@Jdlrobson it could. We would just have to pull out the following rule from being history-page specific and place it somewhere more generic.

May 2 2019, 9:14 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Growth-Team, MediaWiki-Recent-changes, Regression, MinervaNeue
Jdrewniak moved T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
May 2 2019, 8:46 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak claimed T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.
May 2 2019, 5:08 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak updated subscribers of T219895: Style the history page for AMC users.

Just a note on the radio buttons. That effect on iOS is actually due to some overly broad rules in the Minerva reset.less file:

input {
border: 0; 
background: none;
}
May 2 2019, 11:39 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

May 1 2019

Jdrewniak moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
May 1 2019, 8:43 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
Jdrewniak added a comment to T200969: No way to reach the editable version of a page when viewing the most recent mobile diff.

At first, I thought the verification was step 6, but I'm not sure based on the Expected and Actual. Please confirm what the validation should be.

May 1 2019, 8:42 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
Jdrewniak moved T219846: Remove "mediawiki.template.muhogan" from RelatedArticles from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
May 1 2019, 11:06 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Apr 26 2019

Jdrewniak added a project to T218451: MinervaNeue icons standardization: Readers-Web-Backlog (Design).
Apr 26 2019, 5:30 PM · Readers-Web-Backlog (Design), UI-Standardization
Jdrewniak updated subscribers of T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..

@Volker_E I took a look at this approach today, essentially making the text "screen-reader only" when a section is in the collapsed state.
This works pretty well, simply by removing the aria attributes, keeping tabindex=0 on the headings, and using the following CSS to show/hide the sections instead of display: none;

Apr 26 2019, 1:26 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak added a comment to T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.

@Jdlrobson I hope that's an issue with my setup and not a change I made, since it appears that way for me on master (images might be cached though) and I don't think I touched any code that would change that icon.

Apr 26 2019, 10:54 AM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend

Apr 25 2019

Jdrewniak added a comment to T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.

I think those two patches fix this nicely :)

Apr 25 2019, 2:13 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak added a comment to T221425: Design studies for dark mode styles/color scheme.

Just out of curiosity, recent MacOS versions have added dark-mode as an OS level feature, and a new CSS media query has been devised to response to that setting: prefers-color-scheme. The spec is only a draft at this point, but it's already been implemented in Safari and Firefox on MacOS. It would be pretty cool if our solution responded to that OS-level setting, so I'm just wondering if that's been considered.

Apr 25 2019, 7:12 AM · Dark-Mode

Apr 24 2019

Jdrewniak moved T220659: Enable a MobileFrontend daily Selenium build from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 24 2019, 4:53 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson
Jdrewniak reassigned T219895: Style the history page for AMC users from Jdrewniak to alexhollender.
Apr 24 2019, 3:49 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak moved T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 24 2019, 3:26 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak moved T219895: Style the history page for AMC users from Doing to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 24 2019, 3:23 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak added a comment to T221194: Search input of overlay is not tab-able, inaccessible by alternative input users.

When we estimates this bug yesterday I think our understand may have been incomplete. Reading over the comments in T218154, it appears that this might not be an issue with the focus state being invisible: As @Volker_E wrote:

Apr 24 2019, 9:47 AM · Readers-Web-Backlog, Accessibility, MinervaNeue

Apr 18 2019

Jdrewniak moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 18 2019, 11:57 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend

Apr 17 2019

Jdrewniak moved T220777: Extended testing of Page Previews referenced by `aria-describedby` from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Apr 17 2019, 8:07 PM · Readers-Web-Backlog, Accessibility, Page-Previews
Jdrewniak added a project to T220777: Extended testing of Page Previews referenced by `aria-describedby`: Readers-Web-Backlog.
Apr 17 2019, 8:07 PM · Readers-Web-Backlog, Accessibility, Page-Previews
Jdrewniak moved T221203: __NEWSECTIONLINK__ doesn't work on mobile web version (can only add new topic by editing last section) from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Apr 17 2019, 7:59 PM · patch-welcome, MinervaNeue (Tracking)
Jdrewniak added a project to T221203: __NEWSECTIONLINK__ doesn't work on mobile web version (can only add new topic by editing last section): Readers-Web-Backlog.
Apr 17 2019, 7:59 PM · patch-welcome, MinervaNeue (Tracking)
Jdrewniak claimed T219895: Style the history page for AMC users.
Apr 17 2019, 5:04 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak moved T219895: Style the history page for AMC users from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 17 2019, 3:33 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

Apr 16 2019

Jdrewniak added a comment to T220659: Enable a MobileFrontend daily Selenium build.

Thanks to @zeljkofilipin 's work today we got a daily job running the Mobile Frontend tests on the beta cluster today. Hurray!
However, I still want to edit/write/find a MobileFrontend test that works properly on the beta cluster so that this job doesn't just fail every day.

Apr 16 2019, 5:19 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson
Jdrewniak claimed T220659: Enable a MobileFrontend daily Selenium build.
Apr 16 2019, 5:14 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson
Jdrewniak moved T220659: Enable a MobileFrontend daily Selenium build from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Apr 16 2019, 5:14 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson