Jdrewniak (Jan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (96 w, 1 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Fri, Aug 18

Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

@mpopov regarding the event logging for this test, I'd like to go over some details of how information about these thumbnails can be collected.
I have an idea that I think integrates nicely with the existing SearchSatisfaction schema.

Fri, Aug 18, 9:34 AM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Thu, Aug 17

Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

A demo of this feature is available for testing by adding the following line to a users common.js file on english wikipedia:
importScript( 'User:JDrewniak_(WMF)/searchThumbs.js' );

Thu, Aug 17, 7:07 PM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery
Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

@Nemo_bis In this context, thumbnails serve just as a visual cue for the search result, and don't have any intrinsic value on their own. This is why on mobile search (typeahead) and on other search engines, clicking on the image acts just like clicking on the text. The thumbnail + search result are perceived as one unit, so it would be confusing if the text led you to one page but the image to another.

Thu, Aug 17, 7:01 PM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery
Jdrewniak updated subscribers of T160491: Update Wikiversity logos.

@mxn can you take a look at updating the wikiversity logo on the portals from meta?

Thu, Aug 17, 6:21 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests

Mon, Aug 14

Jdrewniak added a comment to T171804: Update to UI display of the sister project snippets .

Link colors and title text are no problem(1 & 2), but it looks like footer link text (3 & 4) is being overridden for english wikipedia and maybe others by this text:
https://en.wikipedia.org/wiki/MediaWiki:Search-interwiki-custom
That page hasn't been updated since 2012, and since the feature has changed considerably since then, it might be a good idea to remove this override.

Mon, Aug 14, 6:10 PM · Patch-For-Review, Discovery-Search (Current work), Discovery

Mon, Jul 24

Jdrewniak updated subscribers of T171488: Desktop Minerva accidentally enables section collapsing on certain sections.
Mon, Jul 24, 4:31 PM · MinervaNeue (Desktop)
Jdrewniak created T171488: Desktop Minerva accidentally enables section collapsing on certain sections.
Mon, Jul 24, 4:30 PM · MinervaNeue (Desktop)

Jul 18 2017

Jdrewniak added a watcher for MinervaNeue (Desktop): Jdrewniak.
Jul 18 2017, 6:45 PM

Jul 17 2017

Jdrewniak added a comment to T170183: Investigate mobile/desktop disparity on sister search numbers.

I've looked at this from the event logging side to see if we're accidentally logging clicks that come from the community developed sidebars, but given that the CSS selectors we use to trigger the events are different than those used in the other sidebars (and testing this myself to be sure), this doesn't seem to be the case either.

Jul 17 2017, 12:03 PM · Patch-For-Review, Discovery-Analysis (Current work), Discovery

Jul 10 2017

Jdrewniak added a comment to T164856: A/B Test: explore similar - verify data coming in is good.

the no esclick events is certainly strange. I've checked the kafka logs, and I can see esclick events at least making it into there. Maybe they're not valid? could be an invalid param or something. I'm attaching a video and event output. We should check the logstash error logs to see if any errors are being generated.

Jul 10 2017, 8:46 PM · Patch-For-Review, Discovery-Analysis (Current work), Discovery
Jdrewniak added a comment to T169565: Performance review of "Explore similar".

@Gilles that API wizardry is impressive. I was unaware that API calls could be combined like that, but since they can, it seems like a good idea to me. The thinking behind making these calls separately though, was to avoid sending down data that the user might never see (in the case that they hover over 'languages' but not 'categories' for example). The cost to this approach though, like you mention, is having to wait for each response separately.

Jul 10 2017, 4:46 PM · Patch-For-Review, Discovery-Search (Current work), Discovery, Performance-Team

Jun 30 2017

Jdrewniak added a comment to T169302: Explain or modify the message "Not available in local languages" for the search results page.

Also, a preview of this feature is available on labs:
http://sistersearch.wmflabs.org/w/index.php?search=~rainbow&title=Special:Search

Jun 30 2017, 5:15 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Discovery-Search (Current work), Patch-For-Review, I18n, Design, Discovery, CirrusSearch
Jdrewniak added a comment to T169302: Explain or modify the message "Not available in local languages" for the search results page.

@Amire80 thank you for your insight. Like you mention this issue was raised in the gerrit patch
https://gerrit.wikimedia.org/r/#/c/356169/16/i18n/en.json
but postponed because the AB test we're running is only on english wikipedia (and we don't plan to release until we have l10n coverage). However your right that "local languages" is confusing and should be changed. I was unsure whether "suggested" or "other" languages is preferable, because we're only showing results in "suggested" languages ( basically whatever is exposed via mw.uls.getFrequentLanguageList() ). From your comment it seems "other languages" is preferable, so I'll change it to that.

Jun 30 2017, 4:48 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Discovery-Search (Current work), Patch-For-Review, I18n, Design, Discovery, CirrusSearch

Jun 27 2017

Jdrewniak claimed T168916: Sister search result clicks missing from search event logging.
Jun 27 2017, 4:19 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Discovery-Analysis (Current work), Discovery-Search (Current work), Discovery

Jun 22 2017

Jdrewniak added a comment to T149809: [A/B Test] Add 'explore similar' pages, categories and suggested languages in search results.

@mpopov those events sound good to me. In regards to the wprov we'll be using a modified version of the serp:N format (as discussed on IRC) with just _es appended to the end.

Jun 22 2017, 3:00 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Jun 17 2017

RandomDSdevel awarded T149806: [A/B/C Test] Add cross-wiki search results in a right sidebar a Doubloon token.
Jun 17 2017, 10:15 PM · Chinese-Sites, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery
RandomDSdevel awarded T151344: Create labs instance for cross-wiki search results testing a 100 token.
Jun 17 2017, 10:15 PM · Discovery-Search (Current work), Discovery

Jun 8 2017

Jdrewniak added a comment to T167301: The new crossproject search results sidebar does not work on non-wikipedias.

Also, the reason this was breaking no wikisource specifically, and not wikipedia,
was that someone somewhere added a CSS class that adds extra margins to all the <ul>'s on the site.

Jun 8 2017, 10:05 AM · MW-1.30-release-notes, Discovery, Discovery-Search (Current work), Patch-For-Review

Jun 7 2017

Jdrewniak added a comment to T167301: The new crossproject search results sidebar does not work on non-wikipedias.

I think this was a CSS issue due to me using display:inline-block to vertically position the top of the sidebar with the top of the search results. Reducing the margin from 10% to 8% seems to fix it.

Jun 7 2017, 3:31 PM · MW-1.30-release-notes, Discovery, Discovery-Search (Current work), Patch-For-Review

May 24 2017

Jdrewniak accepted D660: Unify color variables reference and fix `@background-color-primary`.
May 24 2017, 3:23 PM

May 22 2017

Jdrewniak accepted D649: Remove 'grunt-jsonlint' from Gruntfile.
May 22 2017, 1:41 PM

May 21 2017

Jdrewniak accepted D648: build: Remove npm grunt-jsonlint package & update others.
May 21 2017, 11:49 AM
Jdrewniak requested changes to D648: build: Remove npm grunt-jsonlint package & update others.
May 21 2017, 11:37 AM

May 11 2017

Jdrewniak added a comment to T164929: Search icon of Wikipedia homepage looks a little odd.

The monitor might be very high res like 4K, or it might be a resolution in between 1 and 2x, in which case it would still receive the 1x image. In any case, replacing the icons with SVG's T129634 would fix this

May 11 2017, 9:03 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery

Apr 28 2017

Jdrewniak added a comment to T160004: [A/B Test] Add sister project search results in a right sidebar (test #2).

Regarding the UI concerns

Based on the screenshot in figure 1, it seems that only one interface was being tested, without any of the suggested tweaks of https://lists.wikimedia.org/pipermail/discovery/2017-March/001464.html. Correct?

Apr 28 2017, 11:26 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Discovery-Search (Current work), Discovery

Apr 18 2017

Jdrewniak added a comment to T163189: Make build process with automatic SVG creation out of resources.

The grunt-sketch npm module caught my eye once, is that what you have in mind with this task?

Apr 18 2017, 2:35 PM · WMF-Design, Design, WikimediaUI Style Guide

Apr 13 2017

Jdrewniak moved T160474: Convert inconsistent font sizes, margins, paddings units... to rem unit from Needs code review to Done on the Discovery-Portal-Sprint board.
Apr 13 2017, 3:24 PM · Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Apr 11 2017

Jdrewniak added a comment to T153417: Align the style for lists of pages.

Multiline text

Apr 11 2017, 9:22 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Mar 30 2017

Jdrewniak added a comment to T153417: Align the style for lists of pages.

Initially I preferred the 'full-bleed' thumbnails, but now I see how the rounded corners (and necessary margin/padding) add finesse to the design.

Mar 30 2017, 6:01 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Mar 27 2017

Jdrewniak added a comment to T160704: Design better typographic scale for the portal.

Just to reiterate my thoughts on the 1rem=10px idea.

Mar 27 2017, 11:19 AM · Design, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery

Mar 23 2017

Jdrewniak added a comment to T161062: Language picker dropdown is not readable in very old Opera 10.6.

Recently the WMF has discontinued JS support for IE8, meaning we only serve JS to ES5 compatible browsers. Opera 10.6 doesn't have full ES5 support, so if we serve the non-js version to Opera 10.6, that might fix this issue (off the top of my head I don't know how we'd target ES5 browsers only... right now we only target IE specifically as non-js...)

Mar 23 2017, 12:13 PM · Browser-Support-Opera, Discovery, Discovery-Portal-Sprint, Wikimedia-Portals

Mar 21 2017

Jdrewniak added a comment to T160724: Use project specific icons in sister search results.

The icons we originally made to represent generic 'content types' such as quotations, definitions, textbooks etc. This was meant to help readers who might not know what the sister projects are. However, it turns out that it's hard to make icons that clearly represent these concepts (like a book icon vs textbook icon vs definition icon, they're all book-ish in the end) and an icon alone without any other visual distinctions doesn't convey this meaning. So I think moving away from these generic icons and using the project icons is the right move here. Then at least then, like @Gryllida says, users will be able to distinguish the project names easier.

Mar 21 2017, 10:41 AM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review, Discovery-Search (Current work), Discovery

Mar 20 2017

Jdrewniak added a comment to T158809: Prevent javascript from hiding page content indefinitely.

@Dzahn we monitor the performance of the wikipedia portal carefully here:
https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?from=1458474417000&to=1490010417359

Mar 20 2017, 11:53 AM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak added a comment to T160704: Design better typographic scale for the portal.

Why focus on pixel output values when using rems? Personally, when using ems & rems I tend to set measurements like 0.75rem, 0.25rem etc, because those are much easier to calculate relative to 1rem.

Mar 20 2017, 10:29 AM · Design, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery

Mar 16 2017

Jdrewniak renamed T160622: Disable formatting tool when selecting non-text elements from Odd text-style selection behaviour on non-text elements to Odd text-format selection behaviour on non-text elements.
Mar 16 2017, 10:21 AM · VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
Jdrewniak created T160622: Disable formatting tool when selecting non-text elements.
Mar 16 2017, 10:20 AM · VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
Jdrewniak added a comment to T153417: Align the style for lists of pages.

A recent patch by @JGirault https://gerrit.wikimedia.org/r/#/c/342296/ changes the highlight color on the portal typeahead to light blue instead of grey. The patch would change the portal typeahead from this to this:

Mar 16 2017, 9:57 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Mar 14 2017

Jdrewniak updated subscribers of T153417: Align the style for lists of pages.
Mar 14 2017, 6:10 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak moved T158809: Prevent javascript from hiding page content indefinitely from Done to Needs code review on the Discovery-Portal-Sprint board.
Mar 14 2017, 3:48 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from Needs code review to Done on the Discovery-Portal-Sprint board.
Mar 14 2017, 3:22 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak moved T158809: Prevent javascript from hiding page content indefinitely from Needs code review to Done on the Discovery-Portal-Sprint board.
Mar 14 2017, 3:22 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak moved T158782: https://www.wikipedia.org/ portal doesn't have any text from Needs code review to Done on the Discovery-Portal-Sprint board.
Mar 14 2017, 3:21 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

With the changes to the server config and the full list of URLs in the urls-to-purge.txt, I think we can mark this issue as done.

Mar 14 2017, 3:21 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery
Jdrewniak moved T153764: Wikipedia.org: translations for legal language footer on portal from In Progress to Done on the Discovery-Portal-Sprint board.
Mar 14 2017, 3:17 PM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T153764: Wikipedia.org: translations for legal language footer on portal.

This issue should be resolved now.

Mar 14 2017, 3:17 PM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T159601: Portal set to RTL language: project icons are placed confusingly.

With this patch https://gerrit.wikimedia.org/r/#/c/339631/ (deployed March 14)
the sister project icons for RTL have been improved.

Mar 14 2017, 3:13 PM · Discovery-Portal-Sprint, Discovery, I18n, RTL, Wikimedia-Portals

Mar 11 2017

Jdrewniak added a comment to T160222: Remove unused CSS classes.

I think there's a lot more CSS that can be removed here.
There's a nifty chrome devtools feature that highlights what it thinks is unused CSS. These results need manual review because it picks up things like the 'no-js' and typeahead styles as unused, but I think it provides a good starting point.

Mar 11 2017, 11:36 AM · CSS, Technical-Debt, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Mar 8 2017

Jdrewniak added a comment to T158810: Add full list of URL to purge to urls-to-purge.txt.

@MaxSem @demon
That's the idea :)
https://gerrit.wikimedia.org/r/#/c/341379/1/gulpfile.js

Mar 8 2017, 9:52 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak updated subscribers of T159596: Let the user change the interface language of the wikipedia.org portal.

This seems like a useful feature, especially on mobile where language features are often buried in some OS settings.

Mar 8 2017, 9:45 PM · Discovery-Portal-Backlog, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T157920: Search using a collection of pre-set project, namespaces, or languages.

This seems related to the work WMDE is insterested in doing related to the advanced search UI
https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Advanced_Search_Workshop

Mar 8 2017, 8:31 PM · Discovery-Search, CirrusSearch, Discovery
Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

@JGirault the above patch should fix that

Mar 8 2017, 12:04 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery

Mar 7 2017

Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Mar 7 2017, 12:14 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak updated the task description for T159806: Search results set to percentage width (bug introduced in Sistersearch A/B test).
Mar 7 2017, 8:59 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Discovery, Patch-For-Review, Mobile, Discovery-Search (Current work)
Jdrewniak created T159806: Search results set to percentage width (bug introduced in Sistersearch A/B test).
Mar 7 2017, 8:58 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Discovery, Patch-For-Review, Mobile, Discovery-Search (Current work)

Mar 6 2017

Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from What's Next to In Progress on the Discovery-Portal-Sprint board.
Mar 6 2017, 6:19 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

oh weird I guess https://www.wikipedia.org/portal/wikipedia.org/assets/js/index-non-existing.js is also cached...
A different fake URL like https://www.wikipedia.org/portal/wikipedia.org/assets/js/index-non-existingX.js does produce a 404 like intended.

Mar 6 2017, 9:38 AM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

before the patch the following answers are expected:

Mar 6 2017, 9:20 AM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery

Feb 27 2017

Jdrewniak renamed T158938: Scope the CSS of the interwiki results widget from Create a better way to not show the existing project display (as applicable) when also showing the new sister search results display to Scope the CSS of the interwiki results widget.
Feb 27 2017, 12:45 PM · Discovery-Search (Current work), Discovery
Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

Patch https://gerrit.wikimedia.org/r/#/c/339631/ is by no means a complete RTL solution, but rather addresses the most basic readability issues.

Feb 27 2017, 11:48 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery

Feb 24 2017

Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

Since the page has been localized and text-direction has been set on the HTML element (although at the moment l10n is slightly broken as we work out some caching issues), I've started work on some minor changes that should improve RTL readability

  • correcting the direction of the search suggestions
  • placement of the icons in the sister project links.
Feb 24 2017, 2:14 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak moved T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions from To Discuss to In Progress on the Discovery-Portal-Sprint board.
Feb 24 2017, 1:56 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak edited projects for T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions , added: Discovery-Portal-Sprint; removed Discovery-Portal-Backlog.
Feb 24 2017, 1:53 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak added a comment to T158808: Use a query param for cache-busting instead of suffixing the filename.

Given all the rationale above, it seems best to leave the cache-busting filenames as is, therefore marking this task declined.

Feb 24 2017, 12:36 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak closed T158808: Use a query param for cache-busting instead of suffixing the filename as Declined.
Feb 24 2017, 12:35 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak closed T158808: Use a query param for cache-busting instead of suffixing the filename, a subtask of T128546: [Recurring Task] Update Wikipedia and sister projects portals statistics, as Declined.
Feb 24 2017, 12:35 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint

Feb 23 2017

Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

@greg there was no updates to the portal today. This brief error today must have happened because the portal was rolled back yesterday, but the HTML page remained cached on our end for 24h (we didn't purge that url). In general the updates are done during SWAT, and should be visible in SAL (not sure why it says the last deploy was last week though).

Feb 23 2017, 7:38 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery
Jdrewniak updated subscribers of T158782: https://www.wikipedia.org/ portal doesn't have any text.
Feb 23 2017, 6:44 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Wikimedia-Portals, Discovery

Feb 22 2017

Jdrewniak created T158810: Add full list of URL to purge to urls-to-purge.txt.
Feb 22 2017, 8:59 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak created T158809: Prevent javascript from hiding page content indefinitely.
Feb 22 2017, 8:56 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak created T158808: Use a query param for cache-busting instead of suffixing the filename.
Feb 22 2017, 8:49 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak moved T152616: Fix eslint warnings from Backlog to Needs code review on the Discovery-Portal-Sprint board.
Feb 22 2017, 12:58 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak triaged T152616: Fix eslint warnings as Normal priority.
Feb 22 2017, 12:57 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak claimed T152616: Fix eslint warnings.
Feb 22 2017, 12:56 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery

Feb 21 2017

Jdrewniak added a watcher for Discovery-Search (Current work): Jdrewniak.
Feb 21 2017, 11:14 AM
Jdrewniak moved T153764: Wikipedia.org: translations for legal language footer on portal from Needs code review to Done on the Discovery-Portal-Sprint board.
Feb 21 2017, 10:41 AM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Backlog to Done on the Discovery-Portal-Sprint board.
Feb 21 2017, 10:41 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n
Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Needs code review to Backlog on the Discovery-Portal-Sprint board.
Feb 21 2017, 10:41 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n

Feb 14 2017

Jdrewniak added a comment to T157854: Is “chrome” a sufficient metaphor/descriptor?.

I think the term chrome can be useful if we define it (Pau's option #1).

Feb 14 2017, 10:21 AM · WikimediaUI Style Guide

Feb 8 2017

Jdrewniak closed T157506: Lists are bulleted on sister search results on mobile as Resolved.
Feb 8 2017, 6:39 PM · Discovery-Search (Current work), Mobile, Discovery
Jdrewniak added a comment to T157506: Lists are bulleted on sister search results on mobile.

yup fixed

Feb 8 2017, 6:38 PM · Discovery-Search (Current work), Mobile, Discovery
Jdrewniak added a comment to T149809: [A/B Test] Add 'explore similar' pages, categories and suggested languages in search results.

A static prototype of the 'explore similar' feature is available at this URL
https://people.wikimedia.org/~jdrewniak/SERP-sidebar/index.htm

Feb 8 2017, 5:08 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery
debt awarded T149806: [A/B/C Test] Add cross-wiki search results in a right sidebar a Like token.
Feb 8 2017, 4:14 PM · Chinese-Sites, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Feb 1 2017

Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Needs code review to Done on the Discovery-Portal-Sprint board.
Feb 1 2017, 10:01 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n

Jan 25 2017

Jdrewniak added a comment to T156150: Install ES 5.x to relforge100[12].

We want to share the sistersearch demo (http://sistersearch.wmflabs.org/) on a few mailing lists to get feedback, so I wouldn't break it just yet. Once we run the A/B test on a few production wikis we won't need the labs instance, so then it should be fine to break then :)

Jan 25 2017, 4:41 PM · Patch-For-Review, Discovery-Search (Current work), Discovery

Jan 19 2017

Jdrewniak added a comment to T151344: Create labs instance for cross-wiki search results testing.

The labs instance with relforge indices has been setup and is available at: http://sistersearch.wmflabs.org/

Jan 19 2017, 12:55 PM · Discovery-Search (Current work), Discovery

Jan 10 2017

Jdrewniak raised the priority of T154349: language and direction are not set at the wikimedia.org portal from Normal to High.
Jan 10 2017, 11:55 PM · Patch-For-Review, Discovery-Portal-Sprint, Discovery, I18n, Wikimedia-Portals, RTL
Jdrewniak updated the task description for T153417: Align the style for lists of pages.
Jan 10 2017, 11:31 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak added a comment to T153417: Align the style for lists of pages.

@Volker_E good point. Given how the related articles stack on mobile, I think they can be certainly be considered the same UI pattern (although they serve a different function )

Jan 10 2017, 11:22 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Dec 16 2016

Jdrewniak added a comment to T153417: Align the style for lists of pages.

I added a column for mobile front-end, because the usage of this UI pattern is very prominent on mobile. To be honest, when creating the portal typeahead, we based the style on mobilefrontend because that was the primary usage of this pattern (that we could find). I knew visualEditor was capable of this pattern, but wasn't sure where it was being used.

Dec 16 2016, 4:09 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak updated the task description for T153417: Align the style for lists of pages.
Dec 16 2016, 4:03 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Dec 13 2016

Jdrewniak created T153051: Search page duplicates result.
Dec 13 2016, 10:05 AM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Dec 7 2016

Jdrewniak added a comment to T152386: CI tests on wikimedia/portals repo: cache node_modules to save time.

As @hashar mentioned in his comment:

Dec 7 2016, 12:14 PM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, Continuous-Integration-Config
Jdrewniak added a comment to T152386: CI tests on wikimedia/portals repo: cache node_modules to save time.
Dec 7 2016, 10:51 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, Continuous-Integration-Config
Jdrewniak updated subscribers of T151685: Recursive URLs, available in the Wikipedia.org portal.

@Reedy I don't know much about the server setup of the Portals repo, maybe @MaxSem can shed some light on why the symlink is necessary in the first place? (or knows who might know?)

Dec 7 2016, 10:08 AM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Dec 5 2016

Jdrewniak added a comment to T152351: wikimedia/portals repo might be using outdated and or deprecated tests in jenkins.

@MarcoAurelio this looks like an error compiling lwip - the node image processor & optimizer we use to optimize the images (this thing has been a pain with Node 6 - and it cause CI to run for 15 min :/ ). The error your getting seems to be around node-gyp and the version of Python. Node-gyp documentation says to install it globally:
https://github.com/nodejs/node-gyp#installation
so first npm install --global --production windows-build-tools
and then you need to install Python 2.7 on your system, it looks like you have version 3.5.2 (I don't know much about Python version management, so I hope managing multiple python versions on one system isn't a nightmare).
After that, npm install -g node-gyp should work, as well as the local npm install

Dec 5 2016, 6:23 PM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Nov 28 2016

Jdrewniak updated subscribers of T151685: Recursive URLs, available in the Wikipedia.org portal.

@abian I agree that this is a weird setup. But just removing the symlinks would break the page in production, and cleaning up the apache config has the potential of breaking a lot of things. I don't know enough about apache to say if the recursion can be limited in any way, @Gehel do you?

Nov 28 2016, 10:40 AM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Nov 10 2016

Jdrewniak added a comment to T138107: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display.

wow that looks great!

Nov 10 2016, 12:50 PM · Patch-For-Review, Discovery-Analysis (Current work), Wikimedia-Portals, Discovery, Epic
Jdrewniak added a comment to T146231: Align Wikimedia Portal UI elements to improved color palette.

@Volker_E The patch mentioned above changes the language icon color to the M82 blue (#3366cc).
https://gerrit.wikimedia.org/r/#/c/320761/1/prod/wikipedia.org/assets/img/sprite-bookshelf_icons%25402x.png,unified

Nov 10 2016, 12:39 PM · Discovery-Portal-Sprint, Wikimedia-Portals, WMF-Design, UI-Standardization, Design, UI-Standardization-Kanban, Discovery
RandomDSdevel awarded T144640: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" a Piece of Eight token.
Nov 10 2016, 12:49 AM · User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, Discovery-Search (Current work), Discovery, MediaWiki-Search

Nov 9 2016

Jdrewniak updated the task description for T150190: Add node 6 compatibility to Portal build tasks.
Nov 9 2016, 12:08 PM · Offline-Working-Group, Patch-For-Review, Discovery-Portal-Sprint