Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (397 w, 18 h)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
JDrewniak (WMF) [ Global Accounts ]

Recent Activity

Today

Jdrewniak renamed T336969: [Zebra AB test] Fix the mixing of global and user IDs for AB Test Enrollment Bucketing from Fix the mixing of global and user IDs for AB Test Enrollment Bucketing to [Zebra AB test] Fix the mixing of global and user IDs for AB Test Enrollment Bucketing.
Tue, May 30, 1:43 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Patch-For-Review, Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Desktop Improvements (Vector 2022)
Jdrewniak moved T336969: [Zebra AB test] Fix the mixing of global and user IDs for AB Test Enrollment Bucketing from Code Review to QA on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.
Tue, May 30, 1:43 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Patch-For-Review, Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Desktop Improvements (Vector 2022)

Yesterday

Jdrewniak added a comment to T337580: Vector 2022 full width toggle appears without an icon with JavaScript disabled.

I'm not actually sure what the intended behavior is supposed to be. I'm assuming that the full-width toggle is supposed to be hidden when JavaScript is disabled because that's what happens if you just visit other pages (like article pages, or user preferences), unless that is also a bug.

Mon, May 29, 2:22 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), Desktop Improvements (Vector 2022)
Jdrewniak removed a project from T337675: Commons have wrong CSS on single file page: Desktop Improvements (Vector 2022).
Mon, May 29, 2:02 PM · Commons, WikibaseMediaInfo, Structured-Data-Backlog
Jdrewniak added a project to T337675: Commons have wrong CSS on single file page: Commons.
Mon, May 29, 2:02 PM · Commons, WikibaseMediaInfo, Structured-Data-Backlog
Jdrewniak added a comment to T337675: Commons have wrong CSS on single file page.

@Jcubic hi, thanks for filing this bug. The CSS you point to lives in the WikibaseMediaInfo extension in the mediainfo-filepage.less file. Since I can see this whitespace on both legacy Vector and Vector 2022, I don't think it's related to Desktop Improvements (Vector 2022).

Mon, May 29, 2:01 PM · Commons, WikibaseMediaInfo, Structured-Data-Backlog
Jdrewniak added a project to T337675: Commons have wrong CSS on single file page: WikibaseMediaInfo.
Mon, May 29, 1:58 PM · Commons, WikibaseMediaInfo, Structured-Data-Backlog

Thu, May 25

Jdrewniak added a comment to T337123: vector 2022 z-index issue for wide images that overlap the right menu.

This issue is more complex than that it might seem at first, but I think we could investigate possible solutions.

Thu, May 25, 7:16 PM · Readers-Web-Backlog, Desktop Improvements (Vector 2022)

Wed, May 24

Jdrewniak closed T334770: Create a proposal around basic web team centric performance SLOs as Resolved.
Wed, May 24, 4:27 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)

Tue, May 23

Jdrewniak reassigned T333030: Vector 2022 search handles text overflow inconsistently from Jdrewniak to Edtadros.
Tue, May 23, 5:57 PM · Verified, Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Design-Systems-Team, Desktop Improvements (Vector 2022)

Thu, May 18

Jdrewniak set the point value for T329397: [Bug] Certain logged-in pages have too much space between the top of TOC, Page Tools and top of the viewport to 3.
Thu, May 18, 6:07 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), Desktop Improvements (Vector 2022)
Jdrewniak set the point value for T331038: [SPIKE] Review sticky header scrolling data to 3.
Thu, May 18, 5:59 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5)
Jdrewniak edited projects for T331069: [Spike] What is the best way for our analyst to visualize active schemas?, added: Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4).
Thu, May 18, 5:52 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5)
Jdrewniak set the point value for T336548: [Spike] Try using the default WikimediaUI Codex theme in Vector to 5.
Thu, May 18, 5:48 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Design-Systems-Team, Codex
Jdrewniak renamed T336548: [Spike] Try using the default WikimediaUI Codex theme in Vector from Try using the default WikimediaUI Codex theme in Vector to [Spike] Try using the default WikimediaUI Codex theme in Vector.
Thu, May 18, 5:48 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Design-Systems-Team, Codex
Jdrewniak set the point value for T330805: Update (vector-language-redirect-to-top) to be shorter and more accurate to 1.
Thu, May 18, 5:38 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), MediaWiki-Interface, MediaWiki-Internationalization
Jdrewniak created T336936: Make ABRequirement aware of URL params.
Thu, May 18, 2:06 PM · Readers-Web-Backlog, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T336777: [Zebra] ToC in sidebar overlaps footer area.

This issue can be solved by implementing the solution proposed in T323141 - Combine mainMenu and toc grid areas into columnStart grid areas. That would provide this sidebar area with a more semantic wrapper element and provide the "sticky container" for the TOC. We can probably remove the .vector-sticky-pinned-container element when we do this too.

Thu, May 18, 1:54 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5)

Wed, May 17

Jdrewniak triaged T336880: [Zebra] creates horizontal scrollbar in table of contents as Medium priority.
Wed, May 17, 8:39 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T336880: [Zebra] creates horizontal scrollbar in table of contents.

@Xaosflux thanks for raising this issue, there was a fix for this merged last week https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/917887 so it should be rolling out to all major wikis by this thursday.

Wed, May 17, 8:38 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4), Desktop Improvements (Vector 2022)
Jdrewniak renamed T336048: [Zebra] You have new message toolbar is too small and too close to the toolbar in zebra design from You have new message toolbar is too small and too close to the toolbar in zebra design to [Zebra] You have new message toolbar is too small and too close to the toolbar in zebra design.
Wed, May 17, 3:57 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), Desktop Improvements (Vector 2022)
Jdrewniak placed T335907: Exploratory testing of Zebra update up for grabs.
Wed, May 17, 3:52 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak moved T335907: Exploratory testing of Zebra update from QA to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.

Thanks @Edtadros I've made a ticket for the coordinates issue https://phabricator.wikimedia.org/T336876 other than that, the following are non-issues so I think this ticket can be signed off.

  • The very wide TOC is intentional. We made the dropdown TOC able to be very wide to accommodate talk-page better (which typically have longer headings).
  • The Village pump template is also a non-issue. It looks like the template on beta is outdated, and the village pump template in production is actually quite responsive.
Wed, May 17, 3:52 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak created T336876: [Zebra] Coordinates appear (slightly more) broken with Zebra update.
Wed, May 17, 3:21 PM · Readers-Web-Backlog

Tue, May 16

Jdrewniak moved T336640: Vector sticky header watch/unwatch button disappears when clicked from Doing to Code Review on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Tue, May 16, 4:42 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Desktop Improvements (Vector 2022)
Jdrewniak created T336777: [Zebra] ToC in sidebar overlaps footer area.
Tue, May 16, 3:27 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5)
Jdrewniak added a comment to T336048: [Zebra] You have new message toolbar is too small and too close to the toolbar in zebra design.

Regarding the banner looking too small, it does have a 12px font-size (which is inherited from legacy Vector) which looks tiny in certain scripts like Arabic:

Tue, May 16, 2:49 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T336048: [Zebra] You have new message toolbar is too small and too close to the toolbar in zebra design.

The awkwardness is due to the new gray background in Zebra. The yellow banners position has not changed, and the font-size is the same as in pre-zebra and Legacy Vector:

Tue, May 16, 2:37 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), Desktop Improvements (Vector 2022)

Thu, May 11

Jdrewniak placed T335155: [Follow-up] Zebra update design review & adjustments up for grabs.
Thu, May 11, 6:17 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak moved T335155: [Follow-up] Zebra update design review & adjustments from QA to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.

Given we've done testing with Zebra via T335907, I think this can skip QA and go into signoff.

Thu, May 11, 6:17 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Wed, May 10

Jdrewniak placed T334770: Create a proposal around basic web team centric performance SLOs up for grabs.
Wed, May 10, 6:09 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)
Jdrewniak moved T334770: Create a proposal around basic web team centric performance SLOs from Doing to Ready for Development on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Wed, May 10, 6:09 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)
Jdrewniak claimed T334770: Create a proposal around basic web team centric performance SLOs.
Wed, May 10, 6:08 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)
Jdrewniak moved T334770: Create a proposal around basic web team centric performance SLOs from Ready for Development to Doing on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Wed, May 10, 6:07 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)
Jdrewniak reassigned T336274: Limited-width toggle close button overlaps with text from Jdrewniak to Edtadros.
Wed, May 10, 3:41 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak moved T336274: Limited-width toggle close button overlaps with text from Doing to QA on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Wed, May 10, 3:40 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)

Tue, May 9

Sj awarded T328073: Sticky header for anonymous users a 100 token.
Tue, May 9, 9:29 PM · Readers-Web-Backlog, Desktop Improvements (Vector 2022)
Jdrewniak merged task T336159: Vector-2022 sticky header causes "clickjacking" into T325083: Sticky user menu is invisible but still clickable after scrolling to top.
Tue, May 9, 5:01 PM · Readers-Web-Backlog, Desktop Improvements (Vector 2022)
Jdrewniak merged T336159: Vector-2022 sticky header causes "clickjacking" into T325083: Sticky user menu is invisible but still clickable after scrolling to top.
Tue, May 9, 5:01 PM · Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 5), Desktop Improvements (Vector 2022)
Jdrewniak assigned T333877: Preference persistence, TDMP Phase 3: Gather, Summarize, and Create Tickets for Technical Decision Forum Feedback to nray.
Tue, May 9, 4:41 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4)
Jdrewniak moved T336274: Limited-width toggle close button overlaps with text from Code Review to Doing on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Tue, May 9, 4:40 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak updated subscribers of T336274: Limited-width toggle close button overlaps with text.
Tue, May 9, 3:20 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak assigned T336274: Limited-width toggle close button overlaps with text to Edtadros.
Tue, May 9, 3:16 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak created T336274: Limited-width toggle close button overlaps with text.
Tue, May 9, 3:14 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Desktop Improvements (Vector 2022), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)
Jdrewniak added a comment to T328720: Decrease vertical spacing between menu items (main menu, toc, page tools, personal tools).

This is relatively safe, single line CSS change, but I've changed the description to note that padding between menu items is different than the line-height between lines of text.

Tue, May 9, 2:23 PM · Community Feedback (Web), Desktop Improvements (Vector 2022)
Jdrewniak renamed T328720: Decrease vertical spacing between menu items (main menu, toc, page tools, personal tools) from Decrease line-height of menus (main menu, toc, page tools, personal tools) to Decrease vertical spacing between menu items (main menu, toc, page tools, personal tools).
Tue, May 9, 2:07 PM · Community Feedback (Web), Desktop Improvements (Vector 2022)
Jdrewniak updated subscribers of T335907: Exploratory testing of Zebra update.

Just FYI I'm attaching any bug fixes related to newly found Zebra bugs to this ticket. The patch above resolved a horizontal scrolling issue found by @Jdlrobson on the Zebra ToC.

Tue, May 9, 1:42 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)

Mon, May 8

Jdrewniak moved T335883: Page scrolling not disabled by OOUI modal dialog in Vector 2022 from Ready for Development to Code Review on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Mon, May 8, 7:14 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Regression, OOUI, Desktop Improvements (Vector 2022)
Jdrewniak updated the task description for T335883: Page scrolling not disabled by OOUI modal dialog in Vector 2022.
Mon, May 8, 7:14 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Regression, OOUI, Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T335883: Page scrolling not disabled by OOUI modal dialog in Vector 2022.

@Esanders thanks for filing this issue. I certainly underestimated the risk of changing specificity when structuring the Zebra module in this way. These unconventional scoped imports were designed to let us ship both the new Zebra update alongside the existing styles to production, allowing us to debug the new design as well as run an AB test. We'll explore different ways of achieving that next time.

Mon, May 8, 7:06 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Regression, OOUI, Desktop Improvements (Vector 2022)
Jdrewniak edited projects for T335883: Page scrolling not disabled by OOUI modal dialog in Vector 2022, added: Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Readers-Web-Backlog.
Mon, May 8, 4:26 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Regression, OOUI, Desktop Improvements (Vector 2022)
Jdrewniak added a project to T335883: Page scrolling not disabled by OOUI modal dialog in Vector 2022: Readers-Web-Backlog.
Mon, May 8, 4:23 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3), Regression, OOUI, Desktop Improvements (Vector 2022)
Jdrewniak closed T331304: Remove selenium tests from portals/deploy repo as Resolved.
Mon, May 8, 2:04 PM · User-zeljkofilipin, Browser-Tests, Wikimedia-Portals

Fri, May 5

Jdrewniak updated subscribers of T336078: EventGate Validation error: `session_id` wrong length (multiple schemas).
Fri, May 5, 6:38 PM · Data-Engineering, Metrics-Platform-Planning, Wikimedia-production-error
Jdrewniak created T336078: EventGate Validation error: `session_id` wrong length (multiple schemas).
Fri, May 5, 5:16 PM · Data-Engineering, Metrics-Platform-Planning, Wikimedia-production-error
Jdrewniak moved T336065: The color of the legacy Vector TOC toggle became lighter from Needs triage to Bugs on the Vector (legacy skin) board.
Fri, May 5, 4:29 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Design-Systems-Team, Regression, Vector (legacy skin)
Jdrewniak added a project to T336065: The color of the legacy Vector TOC toggle became lighter: Readers-Web-Backlog.
Fri, May 5, 4:28 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Design-Systems-Team, Regression, Vector (legacy skin)
Jdrewniak updated subscribers of T336065: The color of the legacy Vector TOC toggle became lighter.

@Tacsipacsi this looks like an intentional change coming from mediawiki core in this patch mediawiki.skinning: Use Codex DS tokens for colors & border-colors as such I'm not sure if it should be considered a bug.

Fri, May 5, 4:25 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Design-Systems-Team, Regression, Vector (legacy skin)

Wed, May 3

Jdrewniak created T335907: Exploratory testing of Zebra update.
Wed, May 3, 6:29 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3)

Tue, May 2

Jdrewniak updated the task description for T335686: Deploy Vector 2022 as the default desktop skin on Spanish Wikipedia and French Wikinews.
Tue, May 2, 7:14 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak reassigned T335633: table of contents icon in wrong position on articles with long titles from Jdrewniak to Edtadros.
Tue, May 2, 2:18 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), Regression
Jdrewniak updated the task description for T335633: table of contents icon in wrong position on articles with long titles.
Tue, May 2, 2:17 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), Regression
Jdrewniak added a comment to T335627: Use consistent margin for siteSub and indicators.

Thank you for bringing this to the Web team's attention. I did some digging into this bug and it looks like it was introduced in this patch : Work around browser inconsistencies with 'clear' + 'margin-top'. Previous to that patch, the top margin of the #siteSub element was pushing down the indicators as well. Afterwards it wasn't, and I'm not really sure why. Regardless, adding the same margin to indicators independently seems like a more robust solution.

Tue, May 2, 12:38 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Unplanned-Sprint-Work, Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Mon, May 1

Jdrewniak moved T335311: Deploy Vector 2022 skin as the desktop default on plwiki from Doing to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Mon, May 1, 5:26 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T335633: table of contents icon in wrong position on articles with long titles.

I can confirm that this was introduced in the following patch: Refactor - Prepare existing styles for zebra module.

Mon, May 1, 4:15 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), Regression
Jdrewniak renamed T335633: table of contents icon in wrong position on articles with long titles from table of contents icon does not appear to left of page title on long articles to table of contents icon in wrong position on articles with long titles.
Mon, May 1, 4:08 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), Regression
Jdrewniak added a comment to T307316: [ToC] Enumeration of sections in the new ToC (numbers for ToC items).

Most articles on Wikipedia are not written in a way that require the reader to read each section sequentially (in fact most people don’t read entire articles, they skim to a specific section). In this scenario, I don’t see how the position of a specific section in the article (visualized by enumeration) provides much value to most people.

Mon, May 1, 3:57 PM · Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus .

@Jonesey95 It looks like the conversation in T307316 is still ongoing. Although I see the value in numbering the ToC in certain situations, we're not planning on introducing enumeration in this iteration.

Mon, May 1, 3:19 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 27 2023

Jdrewniak added a comment to T325904: It should not be possible to search when the search input is empty.

Noting that this might be addressable with the required attribute on the input element, <input required/>

Apr 27 2023, 8:20 PM · Readers-Web-Backlog, Design-Systems-Team, Codex, Desktop Improvements (Vector 2022)
Jdrewniak updated subscribers of T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus .
Apr 27 2023, 4:46 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 25 2023

Jdrewniak moved T335311: Deploy Vector 2022 skin as the desktop default on plwiki from Blocked on Others to Doing on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Apr 25 2023, 11:16 PM · Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 24 2023

Jdrewniak claimed T335155: [Follow-up] Zebra update design review & adjustments.
Apr 24 2023, 7:08 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak moved T335155: [Follow-up] Zebra update design review & adjustments from Ready for Development to Doing on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Apr 24 2023, 7:07 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak placed T332600: Prepare content columns for Zebra#9 design update up for grabs.
Apr 24 2023, 3:15 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)
Jdrewniak moved T332600: Prepare content columns for Zebra#9 design update from Design Review to Ready for Signoff on the Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.

@bwang thank you for getting this initial implementation over the finish line!

Apr 24 2023, 3:15 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)

Apr 20 2023

Jdrewniak edited projects for T335155: [Follow-up] Zebra update design review & adjustments, added: Desktop Improvements (Vector 2022); removed Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2).
Apr 20 2023, 5:03 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak created T335155: [Follow-up] Zebra update design review & adjustments.
Apr 20 2023, 4:56 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
Jdrewniak added a comment to T321732: Language links not clickable at narrow viewport widths on desktop.

@Punith.nyk thank you for the contribution, yeah, the phantomjs dependency is pretty bad, it was added to created png fallbacks for the SVG files (7 years ago) and can certainly be removed now, although the SVG output will have to be refactored. There's an epic related to that but no specific task T277404 (I could create one if you're interested).

Apr 20 2023, 2:47 AM · Wikimedia-Portals

Apr 18 2023

Jdrewniak updated subscribers of T332600: Prepare content columns for Zebra#9 design update.

Per design review with @KieranMcCann,

  • Column layout: ToC column & Page tools column should be symmetrical (per the new 24 column grid layout spec, it should be 4 (toc) / 16 (article) / 4 (tools) )
  • Header should have a reduced height
  • grid gap should be 24px
  • ToC height is too big (should have space at bottom equal to grid gap)
  • On lower resolutions, content padding should be reduced, but gray background should still be visible
Apr 18 2023, 5:12 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)

Apr 17 2023

Jdrewniak moved T332600: Prepare content columns for Zebra#9 design update from Doing to Code Review on the Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
Apr 17 2023, 10:52 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)

Apr 11 2023

Jdrewniak closed T310004: Remove storybook from Minerva as Resolved.

I looked through the repo and found no traces of Storybook left.

Apr 11 2023, 9:23 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Unplanned-Sprint-Work, Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Patch-For-Review, MinervaNeue
Jdrewniak closed T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update as Resolved.

Per the A/C I was able to see the new header design on beta with the feature flag turned on:

Screenshot 2023-04-11 at 5.18.54 PM.png (1×1 px, 237 KB)

Apr 11 2023, 9:20 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak updated the task description for T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update.
Apr 11 2023, 9:20 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak closed T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update, a subtask of T333180: [EPIC] A/B test Zebra #9 prototype, as Resolved.
Apr 11 2023, 9:20 PM · Readers-Web-Backlog

Apr 10 2023

Jdrewniak moved T332600: Prepare content columns for Zebra#9 design update from Ready for Development to Doing on the Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
Apr 10 2023, 6:59 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)
Jdrewniak claimed T332600: Prepare content columns for Zebra#9 design update.
Apr 10 2023, 6:59 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Readers-Web-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)

Mar 31 2023

Jdrewniak updated the task description for T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update.
Mar 31 2023, 6:35 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak updated the task description for T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update.
Mar 31 2023, 6:33 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)

Mar 29 2023

Jdrewniak placed T332090: Post page tools cleanup: Remove page tools disabled code up for grabs.
Mar 29 2023, 4:53 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak moved T332090: Post page tools cleanup: Remove page tools disabled code from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.
Mar 29 2023, 4:52 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak moved T332090: Post page tools cleanup: Remove page tools disabled code from Doing to Code Review on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
Mar 29 2023, 4:52 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)

Mar 27 2023

Jdrewniak updated subscribers of T332090: Post page tools cleanup: Remove page tools disabled code.

Out of curiosity (and per @bwang's suggestion) I'm measuring the bytesize of the CSS payload before the excess code is removed.

Mar 27 2023, 7:50 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak claimed T332090: Post page tools cleanup: Remove page tools disabled code.
Mar 27 2023, 6:10 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak moved T332090: Post page tools cleanup: Remove page tools disabled code from Ready for Development to Doing on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
Mar 27 2023, 6:10 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)

Mar 23 2023

Jdrewniak updated the task description for T332449: Prepare Vector 2022 header & sticky header for Zebra#9 design update.
Mar 23 2023, 5:25 PM · MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 6), Desktop Improvements (Vector 2022)
Jdrewniak moved T331563: Layout shift on small viewports from page tools from Ready for Signoff to QA in Production on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
Mar 23 2023, 5:02 PM · Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5), Desktop Improvements (Vector 2022)
Jdrewniak moved T331563: Layout shift on small viewports from page tools from QA in Production to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
Mar 23 2023, 5:01 PM · Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5), Desktop Improvements (Vector 2022)

Mar 22 2023

Jdrewniak closed T319137: Saraiki Wiktionary missing from www.wiktionary.org as Resolved.

This fix (finally) went out last week.

Mar 22 2023, 3:22 PM · Readers-Web-Backlog, translatewiki.net, Wikimedia-Portals

Mar 20 2023

Jdrewniak added a comment to T329333: QA ToC click events under vector skin.

I've tried my best to summarize the issues with the event logging in the following ticket T332612. Changing the section ID values to a static value as @Jdlrobson suggests is right way to go, but I ran into some issues just by changing the HTML, so I think the fix might be more complicated than that.

Mar 20 2023, 5:03 PM · Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5), Product-Analytics
Jdrewniak created T332612: Fix pinnable element instrumentation in desktopWebUIActions.
Mar 20 2023, 4:59 PM · Readers-Web-Backlog, MW-1.41-notes (1.41.0-wmf.4; 2023-04-10), Desktop Improvements (Vector 2022)