Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (343 w, 2 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
JDrewniak (WMF) [ Global Accounts ]

Recent Activity

Tue, May 17

Quiddity awarded T307901: Add link that allows to hide/show the ToC manually on all screen sizes a Like token.
Tue, May 17, 8:14 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak assigned T303102: Normalise PHP namespaces used in Vector to Mabualruz.
Tue, May 17, 2:57 PM · patch-welcome, good first task, Readers-Web-Backlog (Needs Prioritization (Tech)), Technical-Debt, Vector
Jdrewniak assigned T292645: [1.39] Remove SkinTemplate::getPersonalToolsList to Mabualruz.
Tue, May 17, 2:41 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), patch-welcome, good first task, MW-1.39-release, MediaWiki-Core-Skin-Architecture
Jdrewniak added a member for Trusted-Contributors: Mabualruz.
Tue, May 17, 2:36 PM

Mon, May 16

Jdrewniak claimed T301051: Vector 2022’s language button is inaccessible.
Mon, May 16, 5:14 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility

Fri, May 13

Jdrewniak updated subscribers of T307771: Remove custom gradients from new vector.
Fri, May 13, 5:31 PM · Desktop Improvements, UI-Standardization, Design

Thu, May 12

Jdrewniak reassigned T301051: Vector 2022’s language button is inaccessible from Jdrewniak to bwang.

Thanks for bringing this up @Edtadros , I can't replicate the expanded/collapsed being in the wrong state, but the missing label I'm going to call a browser bug.

Thu, May 12, 3:31 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility

Tue, May 10

Jdrewniak placed T303549: Move titlebar above toolbar up for grabs.
Tue, May 10, 5:13 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak moved T303549: Move titlebar above toolbar from Doing to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Tue, May 10, 5:04 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Mon, May 9

Jdrewniak added a comment to T304629: Deploy updated www.wiktionary.org page.

and it's live! Just want to say thank you @Ladsgroup for taking the lead on this deployment, and @Bharatkhatri351, your work is finally live!

Mon, May 9, 5:42 PM · Patch-For-Review, User-notice, Wikimedia-Portals
Jdrewniak added a comment to T304629: Deploy updated www.wiktionary.org page.

Nuts. Unfortunately I spotted an issue with the wiktionary.org portal before deployment today.

Screen Shot 2022-05-09 at 11.38.48 AM.png (986×1 px, 411 KB)

Mon, May 9, 3:47 PM · Patch-For-Review, User-notice, Wikimedia-Portals

Tue, May 3

Jdrewniak claimed T303549: Move titlebar above toolbar.
Tue, May 3, 6:01 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak moved T303549: Move titlebar above toolbar from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Tue, May 3, 6:00 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak reassigned T301051: Vector 2022’s language button is inaccessible from Jdrewniak to Edtadros.
Tue, May 3, 3:43 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility
Jdrewniak reassigned T291304: Simplify and remove extraneous navigation landmark regions from modern Vector from Jdrewniak to Edtadros.
Tue, May 3, 3:43 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Accessibility, Vector
Jdrewniak moved T291304: Simplify and remove extraneous navigation landmark regions from modern Vector from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Tue, May 3, 3:42 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Accessibility, Vector
Jdrewniak updated the task description for T291304: Simplify and remove extraneous navigation landmark regions from modern Vector.
Tue, May 3, 3:41 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Accessibility, Vector
Jdrewniak moved T301051: Vector 2022’s language button is inaccessible from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Tue, May 3, 3:36 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility
Jdrewniak added a comment to T301051: Vector 2022’s language button is inaccessible.

Changes look good, here's a screenshot of what I see after the patch. The languages button doesn't have an aria-label, instead it has an aria-labelledby that points to the <label> element next to it. That label element, (somewhat unconventionally) has an aria-label attribute that should be read by screen-readers. This makes sense because text of the aria-label is more explicit than the it's text content. i.e. whereas visually the languages button says "250 languages", screen readers will hear "Go to an article in another language. Available in 250 languages". 👍

Screen Shot 2022-05-03 at 11.28.51 AM.png (241×901 px, 111 KB)

Tue, May 3, 3:36 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility
Jdrewniak updated the task description for T301051: Vector 2022’s language button is inaccessible.
Tue, May 3, 3:27 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements, Accessibility

Thu, Apr 28

Jdrewniak placed T306606: Deploy ToC A/B test to euwiki, hewiki up for grabs.
Thu, Apr 28, 6:10 PM · Wikimedia-Site-requests, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak added a comment to T291304: Simplify and remove extraneous navigation landmark regions from modern Vector.

@bwang wait is there really one called "Navigation navigation"? 🤔

Thu, Apr 28, 4:30 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Accessibility, Vector
Jdrewniak reassigned T305442: QA ToC Instrumentation from Jdrewniak to jwang.
Thu, Apr 28, 4:22 AM · Product-Analytics (Kanban), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a comment to T305442: QA ToC Instrumentation.

@jwang sorry, I should have been more explicit about that issue. There was a typo in the instrumentation as it was initially deployed (my bad).

Thu, Apr 28, 4:22 AM · Product-Analytics (Kanban), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak closed T299980: Missing accesskeys for user links buttons as Resolved.

Agreed. This is good enough.

Alright, signing this one off then :)

Thu, Apr 28, 3:07 AM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements

Wed, Apr 27

Jdrewniak placed T299846: When searching on en.m.wikipedia.org with iPhone, wrong result gets selected up for grabs.

I tested this today on production and I'm not seeing this issue anymore, so I think the solution looks good :)

Wed, Apr 27, 4:39 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Browser-Support-Apple-Safari, MediaWiki-Search
Jdrewniak closed T306056: Investigate why skin preference is set to empty string for various users as Resolved.

It looks like this answer to "Investigate why skin preference is set to empty string for various users" has been answered, and the answer is captured in T54777 and T54778, so work on this problem can continue on those tickets.

Wed, Apr 27, 4:19 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-User-preferences
Jdrewniak closed T301584: Add rich snippet instrument to WikimediaEvents, a subtask of T299133: [EPIC] A/B test section snippets, as Resolved.
Wed, Apr 27, 4:15 PM · SEO, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T301584: Add rich snippet instrument to WikimediaEvents as Resolved.
Wed, Apr 27, 4:15 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents, SEO
Jdrewniak closed T305442: QA ToC Instrumentation as Resolved.

Thank you @Jdlrobson and @jwang for resolving this issue!

Wed, Apr 27, 4:13 PM · Product-Analytics (Kanban), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak closed T305442: QA ToC Instrumentation, a subtask of T304169: [Goal] Begin table of contents A/B test, as Resolved.
Wed, Apr 27, 4:13 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Epic, Desktop Improvements
Jdrewniak added a comment to T299980: Missing accesskeys for user links buttons.

I can confirm that the accesskeys works :)

Wed, Apr 27, 2:28 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector, Desktop Improvements

Tue, Apr 26

Jdrewniak moved T305563: Deploy visual regression MVP to Wikimedia Cloud VPS from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Tue, Apr 26, 2:04 PM · Web Team Visual Regression Framework, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak added a comment to T305563: Deploy visual regression MVP to Wikimedia Cloud VPS.

Oky doke! I just set up the cron job on the server. With that I think all the AC have been fulfilled :)

Tue, Apr 26, 2:36 AM · Web Team Visual Regression Framework, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Mon, Apr 25

Jdrewniak added a comment to T306246: PageImages ignores MediaWiki:Bad image list, (uses MediaWiki:Pageimages-denylist instead) displaying search results that are inappropriate for some readers.

From my reading of this ticket, it seems that transcluding {{MediaWiki:Bad image list}} into MediaWiki:Pageimages-denylist could be the easiest solution here, as @Ahecht suggests.

Mon, Apr 25, 7:07 PM · Vector, Beta-Cluster-Infrastructure, MinervaNeue (Tracking), Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog, PageImages, MediaWiki-Search
Jdrewniak added a comment to T305442: QA ToC Instrumentation.

I've looked at events per session on frwiki and compared to jawiki, ptwiki and dewiki, (to see if maybe a single session responsible for a large number of events) and there doesn't seem to be any obvious outliers that would suggest that.

Mon, Apr 25, 2:00 PM · Product-Analytics (Kanban), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Thu, Apr 21

Jdrewniak closed T304709: The new vector extension addon ate my edit as Resolved.

Ok. now I get it.

Thu, Apr 21, 5:09 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a comment to T299959: Implement sticky header A/B test bucketing.

Just to note the approach taken here. The patch above depends on enabling the edit button for everybody by default, then hiding it for all users who are not in the treatment bucket.

Thu, Apr 21, 4:57 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Editing-team (Tracking)
Jdrewniak placed T299959: Implement sticky header A/B test bucketing up for grabs.
Thu, Apr 21, 4:53 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Editing-team (Tracking)

Wed, Apr 20

Jdrewniak added a comment to T304709: The new vector extension addon ate my edit.

@Ladsgroup , I took another look at this but unfortunately I was unable to reproduce using your instructions. I created a new page, switched to source editor, then saved the page.

Wed, Apr 20, 4:30 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Apr 12 2022

Jdrewniak updated the task description for T305563: Deploy visual regression MVP to Wikimedia Cloud VPS.
Apr 12 2022, 4:11 PM · Web Team Visual Regression Framework, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Apr 6 2022

Jdlrobson awarded T305563: Deploy visual regression MVP to Wikimedia Cloud VPS a Like token.
Apr 6 2022, 4:54 PM · Web Team Visual Regression Framework, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak claimed T299959: Implement sticky header A/B test bucketing.
Apr 6 2022, 4:30 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Editing-team (Tracking)
Jdrewniak moved T299959: Implement sticky header A/B test bucketing from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Apr 6 2022, 4:30 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Editing-team (Tracking)

Apr 5 2022

Jdrewniak reassigned T303766: Add ARIA attributes to collapsible TOC sections from Jdrewniak to Edtadros.
Apr 5 2022, 5:15 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Accessibility, Desktop Improvements

Mar 31 2022

Jdrewniak closed T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys, a subtask of T273473: [Epic] Improve the table of contents, as Resolved.
Mar 31 2022, 5:05 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Epic, Desktop Improvements
Jdrewniak closed T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys as Resolved.
Mar 31 2022, 5:05 PM · Vector, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T301930: End the Vector skin version migration mode, a subtask of T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys, as Resolved.
Mar 31 2022, 5:00 PM · Vector, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T301930: End the Vector skin version migration mode as Resolved.
Mar 31 2022, 5:00 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Mar 30 2022

Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

hi @Ottomata, I've clicked around Hue and verified that events are being logged successfully at about the volume as before (about 25k per day). Would you like to verify this as well & sign this off?

Mar 30 2022, 5:47 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform

Mar 29 2022

Jdrewniak added a comment to T304709: The new vector extension addon ate my edit.

@Ladsgroup oh no! I hope this wasn't the case, unfortunately I'm having trouble reproducing. I tried on a sandbox production page, here's a video of what I did:
https://drive.google.com/file/d/1mb0ihCh6_TnpATfutdvhKMwiA1Ukdgc5/view?usp=sharing

Mar 29 2022, 3:46 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Mar 28 2022

Jdrewniak changed the subtype of T301391: Update click tracking to take into account screen resolution from "Bug Report" to "Task".
Mar 28 2022, 3:27 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents
Jdrewniak claimed T282012: WikipediaPortal Event Platform Migration.
Mar 28 2022, 3:24 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak reassigned T282012: WikipediaPortal Event Platform Migration from Jdrewniak to Edtadros.
Mar 28 2022, 3:24 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak placed T301391: Update click tracking to take into account screen resolution up for grabs.
Mar 28 2022, 3:07 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents

Mar 25 2022

mxn awarded T304629: Deploy updated www.wiktionary.org page a Love token.
Mar 25 2022, 3:19 AM · Patch-For-Review, User-notice, Wikimedia-Portals

Mar 24 2022

Ladsgroup awarded T304629: Deploy updated www.wiktionary.org page a Like token.
Mar 24 2022, 5:35 PM · Patch-For-Review, User-notice, Wikimedia-Portals
Jdrewniak created T304629: Deploy updated www.wiktionary.org page.
Mar 24 2022, 5:13 PM · Patch-For-Review, User-notice, Wikimedia-Portals
Jdrewniak updated the task description for T282012: WikipediaPortal Event Platform Migration.
Mar 24 2022, 2:16 AM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

@Ottomata I'm planning to deploy the change to the portals repo Thursday March 24, afternoon deploy window. After that, we should start seeing production events :)

Mar 24 2022, 2:14 AM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak moved T282012: WikipediaPortal Event Platform Migration from QA to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Mar 24 2022, 2:11 AM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform

Mar 22 2022

Jdrewniak placed T301391: Update click tracking to take into account screen resolution up for grabs.
Mar 22 2022, 5:52 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents
Jdrewniak closed T299513: Instrumentation needs for ToC as Resolved.

The task related to mediawiki_web_ui_scroll was created as T303297. That and all related AB test tasks are now tracked in "[Goal] Begin table of contents A/B test" T304169.

Mar 22 2022, 4:44 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak closed T299513: Instrumentation needs for ToC, a subtask of T273473: [Epic] Improve the table of contents, as Resolved.
Mar 22 2022, 4:44 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Epic, Desktop Improvements
Jdrewniak closed T299513: Instrumentation needs for ToC, a subtask of T304169: [Goal] Begin table of contents A/B test, as Resolved.
Mar 22 2022, 4:44 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Epic, Desktop Improvements

Mar 21 2022

Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

hi @Ottomata , I've merged the schema to analytics/legacy and have a patch up for the portals repo as well as mediawiki-config. I'm guessing we'll be able to test the new schema once it's been deployed via the train? (that's happening 4 times this week so it shouldn't be long)

Mar 21 2022, 10:34 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak closed T288686: WVUI's TypeaheadSearch should work with a non-default `$wgScriptPath` as Resolved.

lgtm

Mar 21 2022, 4:39 PM · MW-1.38-notes, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), MW-1.38-release, Patch-For-Review, Vector, Readers-Web-Backlog (Kanbanana-FY-2021-22), WVUI
Jdrewniak closed T288686: WVUI's TypeaheadSearch should work with a non-default `$wgScriptPath`, a subtask of T298519: Turn on desktop improvements on new set of pilot wikis, as Resolved.
Mar 21 2022, 4:39 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T288686: WVUI's TypeaheadSearch should work with a non-default `$wgScriptPath`, a subtask of T282473: [GOAL] Use the Codex search widget inside the mobile site, as Resolved.
Mar 21 2022, 4:39 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Goal, MobileFrontend
Jdrewniak closed T288686: WVUI's TypeaheadSearch should work with a non-default `$wgScriptPath`, a subtask of T300081: TypeaheadSearch in Codex (WVUI version), as Resolved.
Mar 21 2022, 4:39 PM · Design-Systems-Team, Codex, Epic

Mar 16 2022

Jdrewniak added a comment to T246299: Add small Wikipedias like Balinese and Sakizaya to Wikipedia portal page.

Does WMF still maintain Wikimedia-Portals?

@Aklapper "maintain" might be to strong a word, perhaps "benignly neglect" would be more precise.

Mar 16 2022, 10:15 PM · Discovery, Wikimedia-Portals
Jdrewniak added a comment to T289972: Santali language is not included in Wikipedia.org Home Page .

@Rocky_734 its like your issue was resolved when I updated the pagecounts.json script related to T300434. The link to the Santali language wikipedia now appears on www.wikipedia.org.

Mar 16 2022, 9:56 PM · Wikimedia-Portals

Mar 8 2022

Jdrewniak claimed T301203: Update skin-specific menu labels to be more predictable, intuitive with better default values.
Mar 8 2022, 6:09 PM · MW-1.38-release, User-notice, MediaWiki-Core-Skin-Architecture (Menus 2.0), Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak moved T299361: ToC: Allow Table of Contents to collapse/expand sections on section click from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

@bwang sorry, that's a bit confusing. From the screenshots @Edtadros posted AC1 is a pass.

  • Only top-level sections should expand and collapse. Subsections should always remain expanded.
  • Clicking the heading of a top-level section will expand it. Clicking it again won't do anything, the section will remain expanded.
  • Only clicking the arrow button beside the section will collapse it.
Mar 8 2022, 5:54 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a comment to T303297: Prepare mediawiki_web_ui_scroll schema for table of contents AB test.

@ovasileva looking over this requirement once more, I have one question. It's clear how this metric should be instrumented for the old table of contents. In the new treatment, where the ToC is pinned, I don't think the scroll-back metric will be attainable (since the new ToC is pinned and therefore not scrollable, unless it overflows the viewport). Do we want to measure this only for the old ToC? Or measure it differently for the new one?

Mar 8 2022, 5:22 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak renamed T303297: Prepare mediawiki_web_ui_scroll schema for table of contents AB test from Prepare mediawiki_web_ui_scroll schema for ToC AB test to Prepare mediawiki_web_ui_scroll schema for table of contents AB test.
Mar 8 2022, 5:17 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak created T303297: Prepare mediawiki_web_ui_scroll schema for table of contents AB test.
Mar 8 2022, 5:09 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Mar 4 2022

Jdrewniak added a comment to T302076: [ToC] Create an indicator that the ToC is scrollable.

Yeah this should be pretty doable with some CSS trickery. Here's a codepen with an example: https://codepen.io/j4n/pen/mdqvzMQ

Mar 4 2022, 4:58 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Mar 2 2022

Jdrewniak added a project to T302753: [Regression, wmf.24-mobile] Search icon is misplaced : Readers-Web-Backlog.
Mar 2 2022, 11:06 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Readers-Web-Backlog (Kanbanana-FY-2021-22), Regression, MinervaNeue, MobileFrontend
Jdrewniak renamed T302046: Build A/B test bucketing infrastructure for the table of contents. from Build A/B test infrastructure for the table of contents. to Build A/B test bucketing infrastructure for the table of contents..
Mar 2 2022, 10:55 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak renamed T302461: Empty TOC in New Vector from New TOC in New Vector to Empty TOC in New Vector.
Mar 2 2022, 10:37 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a comment to T302461: Empty TOC in New Vector.

@IKhitron we're actively working on the table of contents and bugs like this may appear temporarily due to caching. Are you still seeing this issue?

Mar 2 2022, 10:37 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a project to T302461: Empty TOC in New Vector: Readers-Web-Backlog.
Mar 2 2022, 10:29 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak moved T302934: Add data-event attributes to table of content links from Incoming to Table of Contents on the Desktop Improvements board.
Mar 2 2022, 10:25 PM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak created T302934: Add data-event attributes to table of content links.
Mar 2 2022, 10:25 PM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

@Ottomata great, should we merge the schema addition to analytics/legacy before, after, or in tandem with the migrated instrumentation?

Mar 2 2022, 6:47 AM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform

Feb 24 2022

Jdrewniak claimed T301391: Update click tracking to take into account screen resolution.
Feb 24 2022, 6:15 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents
Jdrewniak moved T301391: Update click tracking to take into account screen resolution from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Feb 24 2022, 6:15 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents
Jdrewniak added a comment to T289972: Santali language is not included in Wikipedia.org Home Page .

@Rocky_734 I've looked at this issue and it seems like the problem is related to how the search options are populated.

Feb 24 2022, 5:50 PM · Wikimedia-Portals
Jdrewniak updated subscribers of T300434: Some languages appear in the wrong pagecount section on the Wikipedia.org portal.

@Amire80 yeah this is pretty bad. The fact that I'm just getting around to replying to this ticket two months later speaks to the maintenance status of this tool and the portals repo in general.

Feb 24 2022, 5:25 PM · Wikimedia-Portals

Feb 23 2022

Jdrewniak added a comment to T301391: Update click tracking to take into account screen resolution.

I was curious what this specific bucketing would look like.

Feb 23 2022, 7:25 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-extensions-WikimediaEvents
Jdrewniak closed T299512: Update logos icons and wordmarks for test wikis, a subtask of T290091: Create logos and prepare new set of pilot wikis for deployment, as Resolved.
Feb 23 2022, 4:46 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T299512: Update logos icons and wordmarks for test wikis as Resolved.
Feb 23 2022, 4:46 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Jdrewniak closed T299065: Revise table of contents data format, a subtask of T300210: [subtask] Enable recursive templating on skins, as Resolved.
Feb 23 2022, 4:45 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-Core-Skin-Architecture, Desktop Improvements
Jdrewniak closed T299065: Revise table of contents data format as Resolved.
Feb 23 2022, 4:45 PM · MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), MediaWiki-Core-Skin-Architecture, MW-1.38-release, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Feb 17 2022

Jdrewniak placed T282012: WikipediaPortal Event Platform Migration up for grabs.
Feb 17 2022, 6:11 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform

Feb 16 2022

Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

So I've looked into the event logging migration. The documentation is very good! I think I have everything I need to start work on this task.

Feb 16 2022, 6:00 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak created T301883: Request membership in wikimedia-portals group for Bharatkhatri.
Feb 16 2022, 3:25 PM · Gerrit-Privilege-Requests

Feb 15 2022

Jdrewniak added a comment to T282012: WikipediaPortal Event Platform Migration.

hi @Ottomata, I'm just in the process of scoping out this work this week (I anticipate we'll get started on it shortly after that) and I'll reach out if I have any questions :)

Feb 15 2022, 8:27 PM · Data-Engineering-Kanban, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Analytics, Data-Engineering, Event-Platform
Jdrewniak updated subscribers of T299513: Instrumentation needs for ToC.

Given the requirements from the spreadsheet in the description, we'll be using 4 schemas to track the required events for this test.

Feb 15 2022, 5:55 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements