Jdrewniak (Jan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (112 w, 5 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Tue, Dec 12

Jdrewniak added a comment to T175877: Update fontstack on mobile web to use system typefaces.

A precusory glance reveals few wrinkles in the apple system font.
On Southern Min Wikipedia for example, Safari on Mac OS produces some missing characters. Not so on mobile Safari...

Tue, Dec 12, 4:42 PM · Design, Readers-Web-Backlog
Jdrewniak moved T177763: hi.wikivoyage not appearing in www.wikivoyage.org from Backlog to In Progress on the Discovery-Portal-Sprint board.
Tue, Dec 12, 4:15 PM · Discovery-Portal-Sprint, Hindi-Sites, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T175877: Update fontstack on mobile web to use system typefaces.

As per @Jdlrobson suggestion, I’ve created a spreadsheet that illustrates which fonts would be served to which OS’s with this font stack.

Tue, Dec 12, 3:16 PM · Design, Readers-Web-Backlog

Wed, Dec 6

Jdrewniak closed T182187: Grant jdrewniak access to stat1006 and its eventlogging DB as Resolved.
Wed, Dec 6, 12:08 PM · Operations, Ops-Access-Requests
Jdrewniak added a comment to T182187: Grant jdrewniak access to stat1006 and its eventlogging DB .

oh look at that, I already have access to stat1004/5, closing the ticket then

Wed, Dec 6, 12:07 PM · Operations, Ops-Access-Requests
Jdrewniak created T182187: Grant jdrewniak access to stat1006 and its eventlogging DB .
Wed, Dec 6, 11:55 AM · Operations, Ops-Access-Requests
Jdrewniak renamed T182119: Update technical documentation for portals repository from Document the portal automation process to Update technical documentation for portals repository.
Wed, Dec 6, 8:35 AM · Patch-For-Review, Documentation, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint

Fri, Dec 1

Jdrewniak created T181799: Update Portals page on Beta to reflect head of master branch .
Fri, Dec 1, 12:25 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint

Thu, Nov 30

Jdrewniak added a comment to T181702: Logo is blurry.

Just to summarize my thoughts from IRC. The SVG used in marvin does differ considerably from the one used in production wikipedia.

Thu, Nov 30, 11:32 AM · Patch-For-Review, Marvin

Fri, Nov 24

Jdrewniak updated the task description for T180777: Move portal deployment artifacts into their own repo.
Fri, Nov 24, 4:08 PM · User-zeljkofilipin, Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdrewniak updated the task description for T180777: Move portal deployment artifacts into their own repo.
Fri, Nov 24, 4:02 PM · User-zeljkofilipin, Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Thu, Nov 23

Jdrewniak added a comment to T180401: Create a dedicated deployment window for portal deployments.

looks good to me :)

Thu, Nov 23, 7:07 PM · Release-Engineering-Team (Kanban), Discovery-Portal-Sprint
Jdrewniak added a comment to T180777: Move portal deployment artifacts into their own repo.

Just to be clear about the submodule setup, as I was discussing with @hashar today, I think it should look like this:

Thu, Nov 23, 7:00 PM · User-zeljkofilipin, Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Mon, Nov 20

Jdrewniak moved T144834: Wikipedia.org Portal: update logo for new branding guidelines from Needs code review to Done on the Discovery-Portal-Sprint board.
Mon, Nov 20, 7:50 PM · Patch-For-Review, Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T129634: Discuss SVG usage on wikipedia.org from Needs code review to Done on the Discovery-Portal-Sprint board.
Mon, Nov 20, 7:50 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak moved T152351: wikimedia/portals repo might be using outdated and or deprecated tests in jenkins from Needs code review to Done on the Discovery-Portal-Sprint board.
Mon, Nov 20, 7:50 PM · Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdrewniak moved T160222: Remove unused CSS classes from Needs code review to Done on the Discovery-Portal-Sprint board.
Mon, Nov 20, 7:50 PM · Patch-For-Review, CSS, Technical-Debt, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdrewniak moved T172696: Update WikimediaUI Base to latest and add it as independent file from Needs code review to Done on the Discovery-Portal-Sprint board.
Mon, Nov 20, 7:50 PM · Patch-For-Review, Discovery-Portal-Sprint, UI-Standardization, Discovery, Wikimedia-Portals
debt awarded T180639: Requesting deployment access for jdrewniak a Party Time token.
Mon, Nov 20, 5:57 PM · Patch-For-Review, Discovery, Operations, Wikimedia-Portals, Discovery-Portal-Sprint, Ops-Access-Requests

Fri, Nov 17

Jdrewniak added a comment to T179694: Create a Jenkins Job that builds the portal deployment artifacts in CI.

Really, the account should be owned by the Portals team, not RelEng, right?

@Jdrewniak what would make sense from your side?

Fri, Nov 17, 9:59 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint
Jdrewniak created T180777: Move portal deployment artifacts into their own repo.
Fri, Nov 17, 9:50 AM · User-zeljkofilipin, Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T151685: Recursive URLs, available in the Wikipedia.org portal.

Another insight into why we use the portal symlink for the www portal assets, is that on www.wikipedia.org, search goes through a url like this

https://www.wikipedia.org/search-redirect.php?family=wikipedia&language=en&search=banana&language=en&go=Go

which means the config is basically set up to redirect everything after https://www.wikipedia.org/... to mediawiki, except for the /portal/ path.

Fri, Nov 17, 9:43 AM · Discovery-Portal-Backlog, Discovery, Wikimedia-Portals

Nov 17 2017

Jdrewniak moved T180639: Requesting deployment access for jdrewniak from Backlog to In Progress on the Discovery-Portal-Sprint board.
Nov 17 2017, 9:19 AM · Patch-For-Review, Discovery, Operations, Wikimedia-Portals, Discovery-Portal-Sprint, Ops-Access-Requests

Nov 16 2017

Jdrewniak added a comment to T160217: Clean up portals CSS.

performance changes will be more accurately observed on our dashboard https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?refresh=1m&orgId=1

Nov 16 2017, 9:56 PM · Performance, Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T160222: Remove unused CSS classes.
Nov 16 2017, 9:55 PM · Patch-For-Review, CSS, Technical-Debt, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T160217: Clean up portals CSS.

@Volker_E good point. I ran a build of the portal with the above patch, and on my machine index.html clocks in at about 75kb
Before this patch, index.html clocks in at about 85kb (like you mentioned)

Nov 16 2017, 9:51 PM · Performance, Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery

Nov 15 2017

Jdrewniak created T180639: Requesting deployment access for jdrewniak.
Nov 15 2017, 9:07 PM · Patch-For-Review, Discovery, Operations, Wikimedia-Portals, Discovery-Portal-Sprint, Ops-Access-Requests
Jdrewniak added a comment to T174103: [Epic] Port Selenium tests from Ruby to Node.js for the Search Platform.

@zeljkofilipin There are a few reasons I chose mwbot instead of nodemw:

  • Promises. mwbot does not support promises out of the box, and Cucumber.js, the testing framework used in CirrusSearch, is heavily promise-based, so mwbot worked with it much better than nodemw
  • Batch edit/update convenience functions. Like Erik mentioned, there's a lot of article setup with CirrusSearch, (generating many test articles) so having batch edit functionality was a big plus
  • Generally nicer logging with mwbot (goes well with the batching)
Nov 15 2017, 8:13 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Release-Engineering-Team (Kanban), Discovery-Search (Current work), Discovery

Nov 13 2017

Jdrewniak added a comment to T179694: Create a Jenkins Job that builds the portal deployment artifacts in CI.

@hashar when thinking about splitting the deployment assets into their own repo, I had some concerns regarding developer workflow with a git submodule. Specifically, it seemed confusing to me that the artifacts repo would be updated by the jenkins job, then mediawiki-config would pull to the head of that repo, but the source repo would be stuck at whatever commit the submodule was added at (unless a patch was submitted to update the submodule). Luckily, I discovered that git submodules can also track branches, https://stackoverflow.com/questions/9189575/git-submodule-tracking-latest/9189815#9189815 and that sounds like a pretty good option to me :)

Nov 13 2017, 8:47 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint
Jdrewniak created T180401: Create a dedicated deployment window for portal deployments.
Nov 13 2017, 8:15 PM · Release-Engineering-Team (Kanban), Discovery-Portal-Sprint

Nov 7 2017

Volker_E awarded T129634: Discuss SVG usage on wikipedia.org a Love token.
Nov 7 2017, 8:04 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
CKoerner_WMF awarded T179694: Create a Jenkins Job that builds the portal deployment artifacts in CI a Like token.
Nov 7 2017, 4:37 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint

Nov 3 2017

Jdrewniak added a comment to T178554: Create a Tool on ToolForge for automating www portal builds.

Following up on @debt 's comments. Instead of running the portal build on toolForge, we decided it would be better to run the build in CI with Jenkins, since that wouldn't require maintaining a tool, and CI already has Gerrit permissions (and Jenkin's is kind of designed for building deployment artifacts).

Nov 3 2017, 2:56 PM · Discovery-Portal-Sprint
Jdrewniak added a project to T179694: Create a Jenkins Job that builds the portal deployment artifacts in CI: Wikimedia-Portals.
Nov 3 2017, 2:52 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint
Jdrewniak created T179694: Create a Jenkins Job that builds the portal deployment artifacts in CI.
Nov 3 2017, 2:51 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint
Jdrewniak moved T179273: the logo on www.wikipedia.org is misaligned for RTL languages on very small devices from Backlog to In Progress on the Discovery-Portal-Sprint board.
Nov 3 2017, 2:27 PM · Patch-For-Review, I18n, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint

Nov 1 2017

Krinkle awarded T179223: Cleanup notes for tool-www-portal-builder a Orange Medal token.
Nov 1 2017, 5:16 AM · Discovery, Discovery-Portal-Sprint

Oct 30 2017

Jdrewniak renamed T179273: the logo on www.wikipedia.org is misaligned for RTL languages on very small devices from www.wikipedia.org in Arabic has misaligned logo on mobile to the logo on www.wikipedia.org is misaligned for RTL languages on very small devices.
Oct 30 2017, 4:40 PM · Patch-For-Review, I18n, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint
Jdrewniak added a comment to D859: Correct Toolforge naming.

OOPS. this was just placeholder text... did not mean to commit that

Oct 30 2017, 11:39 AM
Jdrewniak added a comment to T174434: Wikipedia main portal shown in English instead of Arabic language on an Arabic system.

I was able to produce the arabic version of the page on mobile by going to system settings on Android and changing the language to Arabic.
However, in the process I discovered a rendering bug T179273 :(

Oct 30 2017, 11:35 AM · Discovery-Portal-Sprint, Wikimedia-Portals
Jdrewniak created T179273: the logo on www.wikipedia.org is misaligned for RTL languages on very small devices.
Oct 30 2017, 11:33 AM · Patch-For-Review, I18n, Discovery, Wikimedia-Portals, Discovery-Portal-Sprint

Oct 25 2017

Jdrewniak added a comment to T178954: Wikipedia Portal has insecure link to CC license in footer.

I've updated this with a patch that makes the change in the handlebars templates instead of the generated html

Oct 25 2017, 3:11 PM · Discovery-Portal-Sprint, Easy, Patch-For-Review, Discovery, Wikimedia-Portals
Jdrewniak added a project to T178981: The name for Northern Sami should be changed on www.wikipedia.org: Discovery-Portal-Sprint.
Oct 25 2017, 3:10 PM · WMNO-Northern-Sami, Discovery-Portal-Sprint, Patch-For-Review, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T178981: The name for Northern Sami should be changed on www.wikipedia.org.

Thank you for this contribution.

Oct 25 2017, 2:57 PM · WMNO-Northern-Sami, Discovery-Portal-Sprint, Patch-For-Review, Discovery, Wikimedia-Portals
Jdrewniak closed T124092: Research: Rewrite the page to prototype/test/try/ new ideas/features faster as Declined.
Oct 25 2017, 9:41 AM · Discovery-Portal-Backlog, Wikimedia-Portals, Discovery

Oct 24 2017

Jdrewniak updated subscribers of T174002: Measure dwell-time impact of `touch-action: manipulation;`.

This patch went live during SF morning SWAT on October 19th, exact time was 18:36 UTC

Oct 24 2017, 1:56 PM · Front-end-Standards-Group, Patch-For-Review, Discovery, Discovery-Portal-Sprint

Oct 23 2017

Jdrewniak added a comment to T178744: Minor problems with rendering the small print in English and Russian.

The white space, as well as the full-stop in english, is controlled by the templates in the repo, so I can go ahead and fix this.
Would it make more sense if we removed the full stop, and replaced it with a bullet character like the one between использования• Политика конфиденциальности?
So instead of

Эта страница доступна под лицензией Creative Commons Attribution-ShareAlike Условия использования• Политика конфиденциальности

It would read:

Эта страница доступна под лицензией Creative Commons Attribution-ShareAlike •  Условия использования • Политика конфиденциальности
Oct 23 2017, 10:49 AM · Discovery-Portal-Sprint, Patch-For-Review, Discovery, Wikimedia-Portals

Oct 20 2017

Krinkle awarded T178554: Create a Tool on ToolForge for automating www portal builds a Orange Medal token.
Oct 20 2017, 3:43 AM · Discovery-Portal-Sprint

Oct 19 2017

Jdrewniak updated subscribers of T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:52 AM · Discovery-Portal-Sprint
Jdrewniak added a comment to T178554: Create a Tool on ToolForge for automating www portal builds.

So far I've created a node tool on toolforge that is able to pull the repo, run the build, and create a commit (it can create a gerrit commit if it has credentials).

Oct 19 2017, 9:34 AM · Discovery-Portal-Sprint
Jdrewniak added a parent task for T177346: wikipedia.org automation: portal stats automation: T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:25 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a subtask for T178554: Create a Tool on ToolForge for automating www portal builds: T177346: wikipedia.org automation: portal stats automation.
Oct 19 2017, 9:25 AM · Discovery-Portal-Sprint
Jdrewniak added a parent task for T177347: wikipedia.org automation: portal translations automation: T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:24 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a subtask for T178554: Create a Tool on ToolForge for automating www portal builds: T177347: wikipedia.org automation: portal translations automation.
Oct 19 2017, 9:24 AM · Discovery-Portal-Sprint
Jdrewniak added a subtask for T178554: Create a Tool on ToolForge for automating www portal builds: T177348: wikipedia.org automation: gerrit push and CI.
Oct 19 2017, 9:23 AM · Discovery-Portal-Sprint
Jdrewniak added a parent task for T177348: wikipedia.org automation: gerrit push and CI: T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:23 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a parent task for T178554: Create a Tool on ToolForge for automating www portal builds: T177345: [epic] Wikipedia.org portal: creating and pushing updates.
Oct 19 2017, 9:19 AM · Discovery-Portal-Sprint
Jdrewniak added a subtask for T177345: [epic] Wikipedia.org portal: creating and pushing updates: T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:19 AM · Epic, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a parent task for T178554: Create a Tool on ToolForge for automating www portal builds: T140159: [epic] Wikipedia.org Portal: automating updates for the portal.
Oct 19 2017, 9:16 AM · Discovery-Portal-Sprint
Jdrewniak added a subtask for T140159: [epic] Wikipedia.org Portal: automating updates for the portal: T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:16 AM · Epic, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak created T178554: Create a Tool on ToolForge for automating www portal builds.
Oct 19 2017, 9:15 AM · Discovery-Portal-Sprint

Oct 12 2017

Jdrewniak updated subscribers of T171647: Wikipedia portal: adjust the languages used for Chinese translations.
Oct 12 2017, 12:29 PM · Discovery-Portal-Backlog, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T171647: Wikipedia portal: adjust the languages used for Chinese translations.

@mxn good point on lang="nan" I'll revert that back in the patch here.
Also, to your point on yue.json and zh-yue.json, it looks like in this specific instance the translation strings don't collide, so these two files can be merged without much conflict, but in the future, if such a conflict did arise, like with lzh, I suppose the newer file could take precedence?

Oct 12 2017, 12:25 PM · Discovery-Portal-Backlog, Wikimedia-Portals, Discovery

Oct 10 2017

Jdrewniak updated the task description for T177340: [epic] Wikipedia.org portal technical debt: clean up code before automating.
Oct 10 2017, 3:37 PM · Epic, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T174002: Measure dwell-time impact of `touch-action: manipulation;`.

the .mov file shows this without the compression artifacts

Oct 10 2017, 11:48 AM · Front-end-Standards-Group, Patch-For-Review, Discovery, Discovery-Portal-Sprint
Jdrewniak added a comment to T174002: Measure dwell-time impact of `touch-action: manipulation;`.

On an iOS simulator, it looks like this works.
The one on the left has touch-action:manipulation
The one on the right doesn't.

Oct 10 2017, 11:47 AM · Front-end-Standards-Group, Patch-For-Review, Discovery, Discovery-Portal-Sprint

Sep 5 2017

Jdrewniak added a project to T169565: Performance review of "Explore similar": Patch-For-Review.
Sep 5 2017, 11:47 AM · Performance-Team (Radar), Discovery-Search (Current work), Discovery

Aug 30 2017

CKoerner_WMF awarded T171804: Update to UI display of the sister project snippets a Barnstar token.
Aug 30 2017, 8:11 PM · MW-1.30-release-notes, Patch-For-Review, Discovery-Search (Current work), Discovery

Aug 29 2017

Jdrewniak added a comment to T174434: Wikipedia main portal shown in English instead of Arabic language on an Arabic system.

@alanajjar www.wikipedia.org should change languages when you change the language of the browser. This functionality should work in all modern browsers. Below is a video of how I change the browser language in firefox to Arabic and the portal changes. If you can provide any more details about what browsers this doesn't work in (or share the video below to the users having this issue) that would be great. Thanks.

Aug 29 2017, 1:24 PM · Discovery-Portal-Sprint, Wikimedia-Portals
Jdrewniak updated subscribers of T174002: Measure dwell-time impact of `touch-action: manipulation;`.
Aug 29 2017, 10:58 AM · Front-end-Standards-Group, Patch-For-Review, Discovery, Discovery-Portal-Sprint

Aug 24 2017

Jdrewniak created T174002: Measure dwell-time impact of `touch-action: manipulation;`.
Aug 24 2017, 8:08 AM · Front-end-Standards-Group, Patch-For-Review, Discovery, Discovery-Portal-Sprint

Aug 23 2017

mpopov awarded T172345: Sister project snippets display: UI bug on frwiki a 100 token.
Aug 23 2017, 9:49 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review, Discovery-Search (Current work), Discovery

Aug 18 2017

Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

@mpopov regarding the event logging for this test, I'd like to go over some details of how information about these thumbnails can be collected.
I have an idea that I think integrates nicely with the existing SearchSatisfaction schema.

Aug 18 2017, 9:34 AM · Discovery-Search, CirrusSearch, Discovery

Aug 17 2017

Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

A demo of this feature is available for testing by adding the following line to a users common.js file on english wikipedia:
importScript( 'User:JDrewniak_(WMF)/searchThumbs.js' );

Aug 17 2017, 7:07 PM · Discovery-Search, CirrusSearch, Discovery
Jdrewniak added a comment to T149811: [A/B Test] Add thumbnail icons to the search results.

@Nemo_bis In this context, thumbnails serve just as a visual cue for the search result, and don't have any intrinsic value on their own. This is why on mobile search (typeahead) and on other search engines, clicking on the image acts just like clicking on the text. The thumbnail + search result are perceived as one unit, so it would be confusing if the text led you to one page but the image to another.

Aug 17 2017, 7:01 PM · Discovery-Search, CirrusSearch, Discovery
Jdrewniak updated subscribers of T160491: Update Wikiversity logos.

@mxn can you take a look at updating the wikiversity logo on the portals from meta?

Aug 17 2017, 6:21 PM · Discovery-Portal-Sprint, Discovery, Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests

Aug 14 2017

Jdrewniak added a comment to T171804: Update to UI display of the sister project snippets .

Link colors and title text are no problem(1 & 2), but it looks like footer link text (3 & 4) is being overridden for english wikipedia and maybe others by this text:
https://en.wikipedia.org/wiki/MediaWiki:Search-interwiki-custom
That page hasn't been updated since 2012, and since the feature has changed considerably since then, it might be a good idea to remove this override.

Aug 14 2017, 6:10 PM · MW-1.30-release-notes, Patch-For-Review, Discovery-Search (Current work), Discovery

Jul 24 2017

Jdrewniak updated subscribers of T171488: Desktop Minerva accidentally enables section collapsing on certain sections.
Jul 24 2017, 4:31 PM · MinervaNeue (Desktop)
Jdrewniak created T171488: Desktop Minerva accidentally enables section collapsing on certain sections.
Jul 24 2017, 4:30 PM · MinervaNeue (Desktop)

Jul 18 2017

Jdrewniak added a watcher for MinervaNeue (Desktop): Jdrewniak.
Jul 18 2017, 6:45 PM

Jul 17 2017

Jdrewniak added a comment to T170183: Investigate mobile/desktop disparity on sister search numbers.

I've looked at this from the event logging side to see if we're accidentally logging clicks that come from the community developed sidebars, but given that the CSS selectors we use to trigger the events are different than those used in the other sidebars (and testing this myself to be sure), this doesn't seem to be the case either.

Jul 17 2017, 12:03 PM · Patch-For-Review, Discovery-Analysis (Current work), Discovery

Jul 10 2017

Jdrewniak added a comment to T164856: A/B Test: explore similar - verify data coming in is good.

the no esclick events is certainly strange. I've checked the kafka logs, and I can see esclick events at least making it into there. Maybe they're not valid? could be an invalid param or something. I'm attaching a video and event output. We should check the logstash error logs to see if any errors are being generated.

Jul 10 2017, 8:46 PM · Patch-For-Review, Discovery-Analysis (Current work), Discovery
Jdrewniak added a comment to T169565: Performance review of "Explore similar".

@Gilles that API wizardry is impressive. I was unaware that API calls could be combined like that, but since they can, it seems like a good idea to me. The thinking behind making these calls separately though, was to avoid sending down data that the user might never see (in the case that they hover over 'languages' but not 'categories' for example). The cost to this approach though, like you mention, is having to wait for each response separately.

Jul 10 2017, 4:46 PM · Performance-Team (Radar), Discovery-Search (Current work), Discovery

Jun 30 2017

Jdrewniak added a comment to T169302: Explain or modify the message "Not available in local languages" for the search results page.

Also, a preview of this feature is available on labs:
http://sistersearch.wmflabs.org/w/index.php?search=~rainbow&title=Special:Search

Jun 30 2017, 5:15 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Discovery-Search (Current work), Patch-For-Review, I18n, Design, Discovery, CirrusSearch
Jdrewniak added a comment to T169302: Explain or modify the message "Not available in local languages" for the search results page.

@Amire80 thank you for your insight. Like you mention this issue was raised in the gerrit patch
https://gerrit.wikimedia.org/r/#/c/356169/16/i18n/en.json
but postponed because the AB test we're running is only on english wikipedia (and we don't plan to release until we have l10n coverage). However your right that "local languages" is confusing and should be changed. I was unsure whether "suggested" or "other" languages is preferable, because we're only showing results in "suggested" languages ( basically whatever is exposed via mw.uls.getFrequentLanguageList() ). From your comment it seems "other languages" is preferable, so I'll change it to that.

Jun 30 2017, 4:48 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Discovery-Search (Current work), Patch-For-Review, I18n, Design, Discovery, CirrusSearch

Jun 27 2017

Jdrewniak claimed T168916: Sister search result clicks missing from search event logging.
Jun 27 2017, 4:19 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Discovery-Analysis (Current work), Discovery-Search (Current work), Discovery

Jun 22 2017

Jdrewniak added a comment to T149809: [A/B Test] Add 'explore similar' pages, categories and suggested languages in search results.

@mpopov those events sound good to me. In regards to the wprov we'll be using a modified version of the serp:N format (as discussed on IRC) with just _es appended to the end.

Jun 22 2017, 3:00 PM · Discovery-Search (Current work), CirrusSearch, Discovery

Jun 17 2017

RandomDSdevel awarded T149806: [A/B/C Test] Add cross-wiki search results in a right sidebar a Doubloon token.
Jun 17 2017, 10:15 PM · Chinese-Sites, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery
RandomDSdevel awarded T151344: Create labs instance for cross-wiki search results testing a 100 token.
Jun 17 2017, 10:15 PM · Discovery-Search (Current work), Discovery

Jun 8 2017

Jdrewniak added a comment to T167301: The new crossproject search results sidebar does not work on non-wikipedias.

Also, the reason this was breaking no wikisource specifically, and not wikipedia,
was that someone somewhere added a CSS class that adds extra margins to all the <ul>'s on the site.

Jun 8 2017, 10:05 AM · MW-1.30-release-notes, Discovery, Discovery-Search (Current work), Patch-For-Review

Jun 7 2017

Jdrewniak added a comment to T167301: The new crossproject search results sidebar does not work on non-wikipedias.

I think this was a CSS issue due to me using display:inline-block to vertically position the top of the sidebar with the top of the search results. Reducing the margin from 10% to 8% seems to fix it.

Jun 7 2017, 3:31 PM · MW-1.30-release-notes, Discovery, Discovery-Search (Current work), Patch-For-Review

May 24 2017

Jdrewniak accepted D660: Unify color variables reference and fix `@background-color-primary`.
May 24 2017, 3:23 PM

May 22 2017

Jdrewniak accepted D649: Remove 'grunt-jsonlint' from Gruntfile.
May 22 2017, 1:41 PM

May 21 2017

Jdrewniak accepted D648: build: Remove npm grunt-jsonlint package & update others.
May 21 2017, 11:49 AM
Jdrewniak requested changes to D648: build: Remove npm grunt-jsonlint package & update others.
May 21 2017, 11:37 AM

May 11 2017

Jdrewniak added a comment to T164929: Search icon of Wikipedia homepage looks a little odd.

The monitor might be very high res like 4K, or it might be a resolution in between 1 and 2x, in which case it would still receive the 1x image. In any case, replacing the icons with SVG's T129634 would fix this

May 11 2017, 9:03 AM · Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Apr 28 2017

Jdrewniak added a comment to T160004: [A/B Test] Add sister project search results in a right sidebar (test #2).

Regarding the UI concerns

Based on the screenshot in figure 1, it seems that only one interface was being tested, without any of the suggested tweaks of https://lists.wikimedia.org/pipermail/discovery/2017-March/001464.html. Correct?

Apr 28 2017, 11:26 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Discovery-Search (Current work), Discovery

Apr 18 2017

Jdrewniak added a comment to T163189: Make build process with automatic SVG creation out of resources.

The grunt-sketch npm module caught my eye once, is that what you have in mind with this task?

Apr 18 2017, 2:35 PM · WMF-Design, Design, WikimediaUI Style Guide

Apr 13 2017

Jdrewniak moved T160474: Convert inconsistent font sizes, margins, paddings units... to rem unit from Needs code review to Done on the Discovery-Portal-Sprint board.
Apr 13 2017, 3:24 PM · Patch-For-Review, Technical-Debt, CSS, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Apr 11 2017

Jdrewniak added a comment to T153417: Align the style for lists of pages.

Multiline text

Apr 11 2017, 9:22 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization