Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (164 w, 18 h)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Today

Jdrewniak claimed T210208: MFA: mobile.toggle migrated to webpack.
Tue, Dec 11, 11:34 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Yesterday

Jdrewniak moved T210208: MFA: mobile.toggle migrated to webpack from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Dec 10, 10:21 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Dec 10, 10:18 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack.
Mon, Dec 10, 10:18 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/477827/
took care of watchstar.less, thanks @Niedzielski

Mon, Dec 10, 10:15 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T209007: MFA: View: Make isBorderBox and className passable options to the View class to reduce reliance on inheritance from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Dec 10, 9:51 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Thu, Dec 6

Jdrewniak moved T209007: MFA: View: Make isBorderBox and className passable options to the View class to reduce reliance on inheritance from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 6, 3:09 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak awarded T211342: Build: Add image compression to build step a Love token.
Thu, Dec 6, 3:07 PM · Wikimedia Design Style Guide
Jdrewniak added a comment to T211257: Split pageIssues.js into smaller functions.

Unfortunelty, the patch above doesn't only separate out functions into smaller pieces. It also (inadvertently) fixes the icon issues raised T202349. This fix includes modifying the way page-issue banners manipulate the DOM, which means the patch should go through thorough browser QA.

Thu, Dec 6, 12:16 PM · MinervaNeue, Readers-Web-Backlog, Patch-For-Review
Jdrewniak edited projects for T211257: Split pageIssues.js into smaller functions, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).
Thu, Dec 6, 11:56 AM · MinervaNeue, Readers-Web-Backlog, Patch-For-Review
Jdrewniak moved T211257: Split pageIssues.js into smaller functions from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 6, 11:52 AM · MinervaNeue, Readers-Web-Backlog, Patch-For-Review
Jdrewniak edited projects for T211257: Split pageIssues.js into smaller functions, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Thu, Dec 6, 11:51 AM · MinervaNeue, Readers-Web-Backlog, Patch-For-Review
Jdrewniak moved T202349: [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 6, 11:49 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings

Wed, Dec 5

Jdrewniak created T211257: Split pageIssues.js into smaller functions.
Wed, Dec 5, 10:57 PM · MinervaNeue, Readers-Web-Backlog, Patch-For-Review
Jdrewniak added a comment to T202349: [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..

I’ve finally gotten around to looking over @Jdlrobson’s updated patch, but alas, I’ve found another bug, it breaks the overlay for multiple-issues templates. :(

Wed, Dec 5, 10:29 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings

Thu, Nov 29

Jdrewniak added a comment to T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster.

Judging from this stackOverflow issue, this JS selenium implementation, and the GitHub issue below, it does seem that Selenium takes into account the height of an element to determine whether it is "shown".

Thu, Nov 29, 2:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
Jdrewniak added a comment to T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster.

Looking through the previous tasks, as well as the test itself, it seems like lots of stuff has been tried to fix this before. Not sure what would help, but one thing that I've identified is that the notification_area_element is the element is the selector .mw-notification-area. On the page, that element has a fixed position and a height of zero, so I'm not sure if selenium counts that as "visible".

Thu, Nov 29, 2:27 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue

Wed, Nov 28

Jdrewniak updated the task description for T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph.
Wed, Nov 28, 10:55 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites
Jdrewniak added a project to T210540: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph: Readers-Web-Backlog.
Wed, Nov 28, 10:54 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Russian-Sites

Tue, Nov 27

GTirloni awarded T210481: site_stats tables unavailable on Cloud replicas a Party Time token.
Tue, Nov 27, 6:39 PM · Data-Services, cloud-services-team (Kanban), DBA, Wikimedia-Portals
Jdrewniak added a parent task for T210481: site_stats tables unavailable on Cloud replicas: T210401: www.wikipedia.org says 0+ articles for all languages.
Tue, Nov 27, 9:07 AM · Data-Services, cloud-services-team (Kanban), DBA, Wikimedia-Portals
Jdrewniak added a subtask for T210401: www.wikipedia.org says 0+ articles for all languages: T210481: site_stats tables unavailable on Cloud replicas.
Tue, Nov 27, 9:07 AM · Wikimedia-Portals
Jdrewniak created T210481: site_stats tables unavailable on Cloud replicas.
Tue, Nov 27, 9:06 AM · Data-Services, cloud-services-team (Kanban), DBA, Wikimedia-Portals

Mon, Nov 26

Jdrewniak added a comment to T210401: www.wikipedia.org says 0+ articles for all languages.

I reverted this patch as soon as I became aware of this bug. Still have to investigate what error here was.

Mon, Nov 26, 5:46 PM · Wikimedia-Portals
Jdrewniak claimed T210401: www.wikipedia.org says 0+ articles for all languages.
Mon, Nov 26, 5:02 PM · Wikimedia-Portals

Wed, Nov 21

Jdrewniak claimed T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack.
Wed, Nov 21, 2:39 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Nov 21, 2:39 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack from To Do to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Nov 21, 2:38 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak updated the task description for T207805: MFA: Port the references feature to webpack: Merge mobile.references and mobile.references.gateway.
Wed, Nov 21, 2:37 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T209007: MFA: View: Make isBorderBox and className passable options to the View class to reduce reliance on inheritance.

Just poking around the Views & Overlays, I discovered the View uses either props.className or this.className in _postInitialize() (View.js#220):

Wed, Nov 21, 12:14 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Oct 22 2018

Jdrewniak moved T206169: Complete webpack migration of mobile.startup from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 22 2018, 7:14 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak claimed T206169: Complete webpack migration of mobile.startup.
Oct 22 2018, 3:21 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T206169: Complete webpack migration of mobile.startup from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 22 2018, 3:20 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T206178: Feature branch: Remove pageIssues A-B test code from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 22 2018, 3:01 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Technical-Debt, Page-Issue-Warnings, Design
Jdrewniak moved T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 22 2018, 2:00 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)

Oct 16 2018

Jdrewniak edited projects for T206027: Collapse mobile.search.util into mobile.startup, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Oct 16 2018, 1:26 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T207104: Reconsider `em` values in CSS with current state browsers.

also related T207038

Oct 16 2018, 1:02 PM · Front-end-Standards-Group
Jdrewniak added a comment to T207104: Reconsider `em` values in CSS with current state browsers.

assistive technology building on top of font size based zooming, although not related, similar things like T204807 comes to my mind

Oct 16 2018, 12:53 PM · Front-end-Standards-Group

Oct 15 2018

Jdrewniak closed T194136: Remove unneeded A/B test code & dependencies from repo as Resolved.
Oct 15 2018, 9:48 PM · Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak closed T114694: Deploy wikimedia/portals with scap3 as Resolved.

@MarcoAurelio this task can certainly be closed out now.

Oct 15 2018, 11:37 AM · Scap (Scap3-Adoption-Phase1), scap2, Discovery
Jdrewniak added a comment to T206762: Remove table.wikitable border property..

The border should not be removed as it breaks displays of tables such as https://en.m.wikipedia.org/wiki/Help:Sorting#Numerical_sorting_problems

Oct 15 2018, 11:21 AM · Readers-Web-Backlog, MinervaNeue

Oct 11 2018

Jdrewniak added a comment to T205128: Bundle Hogan.js.

I've recently run into the question of how to compile templates for unit-tests (for T206226 ). In a Node environment such as node-qunit, we have to import the templates somehow, which led me to discover the mustache-loader for webpack (which uses Hogan under the hood). Have we considered using a loader like this for templates?

Oct 11 2018, 7:36 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

An update (I love to nerd out on this stuff). We're not the only ones to run into this problem. There are long-standing discussions between the relation of schema.org and Wikidata. Reading through this https://www.wikidata.org/wiki/Wikidata:Schema.org led me to this monster GitHub issue, https://github.com/schemaorg/schemaorg/issues/280 where I noticed the use of equivalentClass property. Turns out, in Wikidata, for many entities, the equivalentClass property exists and actually points to a schema.org entity, see https://www.wikidata.org/wiki/Q5398426 . I think where that property exists, we could so something like "get instanceof, and then get equivalentClass of that instanceof", and that might give us the valid schema.org @type for that entity.

Oct 11 2018, 11:27 AM · Patch-For-Review, Performance-Team (Radar), MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Wikidata-Campsite, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Wikidata, MediaWiki-extensions-WikibaseClient, SEO
Jdrewniak added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

@Niedzielski @type is tricky. The @context key refers to the vocabulary used to define the structured data. The problem is that http://schema.org and http://wikidata.org are different vocabularies, so a @type defined by Wikidata may be different than one defined by schema.org. Where schema.org defined "TVSeries", Wikidata defines "Q5398426" (television series). I don't think many search-engines recognize the http://wikidata.org vocabulary, so "@context": "http://wikidata.org", is invalid. Omitting the @context key does validate the markup, but I'm not sure there's much value without it.

Oct 11 2018, 10:36 AM · Patch-For-Review, Performance-Team (Radar), MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Wikidata-Campsite, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Wikidata, MediaWiki-extensions-WikibaseClient, SEO

Oct 10 2018

Jdrewniak added a comment to T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.

@Jdlrobson well I would hate to say that something is impossible.

Oct 10 2018, 8:44 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Oct 9 2018

Jdrewniak claimed T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup.
Oct 9 2018, 9:43 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
Jdrewniak moved T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 9 2018, 9:42 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
Jdrewniak updated the task description for T204835: [Bug] Mobile editor shows empty screen under content.
Oct 9 2018, 9:39 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak placed T204835: [Bug] Mobile editor shows empty screen under content up for grabs.
Oct 9 2018, 9:36 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak moved T204835: [Bug] Mobile editor shows empty screen under content from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 9 2018, 9:35 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
alexhollender awarded T204807: Minerva should respect the system font-size settings on iOS a Love token.
Oct 9 2018, 6:43 PM · User-Ryasmeen, Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Accessibility, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 9 2018, 5:03 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203965: PageImages Maintenance Script finds not all Images as Resolved.
Oct 9 2018, 3:36 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, PageImages
Jdrewniak claimed T204835: [Bug] Mobile editor shows empty screen under content.
Oct 9 2018, 12:34 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak moved T204835: [Bug] Mobile editor shows empty screen under content from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 9 2018, 12:34 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend

Oct 8 2018

Jdrewniak updated the task description for T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Oct 8 2018, 2:00 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Oct 4 2018

Jdrewniak placed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files up for grabs.
Oct 4 2018, 11:29 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak claimed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Oct 4 2018, 11:29 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Oct 3 2018

Jdrewniak removed a project from T204786: Migrate test_View.js to tests/node-qunit/mobile.startup: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).
Oct 3 2018, 8:46 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak edited projects for T204786: Migrate test_View.js to tests/node-qunit/mobile.startup, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Oct 3 2018, 8:33 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Oct 2 2018

Jdrewniak placed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files up for grabs.
Oct 2 2018, 6:51 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Oct 2 2018, 6:51 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Oct 2 2018, 5:16 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Oct 1 2018

MBinder_WMF awarded T181623: Chromium-render doesn't handle browser connection abort well a Yellow Medal token.
Oct 1 2018, 9:40 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak closed T181623: Chromium-render doesn't handle browser connection abort well, a subtask of T186748: [EPIC] New service request: chromium-render/deploy, as Resolved.
Oct 1 2018, 5:02 PM · Epic, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-notice, Services (blocked), Service-deployment-requests, Proton, Operations, Electron-PDFs
Jdrewniak closed T181623: Chromium-render doesn't handle browser connection abort well as Resolved.
Oct 1 2018, 5:02 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 28 2018

Jdrewniak edited projects for T186062: Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Readers-Web-Backlog.
Sep 28 2018, 10:06 AM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MinervaNeue, Performance-Team (Radar), MobileFrontend

Sep 27 2018

Jdrewniak moved T181623: Chromium-render doesn't handle browser connection abort well from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 27 2018, 4:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

I've run the pdf-renderer again, overflown it with lots of request, left it on for an hour, intermittently killed the main chromium processes, killed the child processes, disconnected and reconnected the network, and I'm unable to reproduce my previous bug. Good job!

Sep 27 2018, 4:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 26 2018

Jdrewniak updated the task description for T203817: Continue webpack + test transition of mobile.startup (pt 2).
Sep 26 2018, 11:57 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203817: Continue webpack + test transition of mobile.startup (pt 2) as Resolved.
Sep 26 2018, 11:57 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203817: Continue webpack + test transition of mobile.startup (pt 2), a subtask of T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva, as Resolved.
Sep 26 2018, 11:57 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MobileFrontend, MinervaNeue
Jdrewniak closed T203100: Continue webpack + test transition of mobile.startup as Resolved.
Sep 26 2018, 11:47 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T203100: Continue webpack + test transition of mobile.startup, a subtask of T155802: [EPIC] Build entire mobile.startup module using webpack bundler, as Resolved.
Sep 26 2018, 11:47 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt (RW-Tech-Debt)

Sep 24 2018

Jdrewniak added a comment to T195795: Use a clearly intended height on MinervaNeue header.

Tracking down where the headerHeight actually comes from, it looks like it's just statically defined as 3.35em.

Sep 24 2018, 4:02 PM · Readers-Web-Backlog (Tracking), Front-end-Standards-Group, Design (RW-Design-Debt), MinervaNeue
Jdrewniak added a comment to T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
  • increase utils code coverage
Sep 24 2018, 10:51 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Sep 20 2018

Jdrewniak claimed T204746: It should be possible to opt into new page issues treatment via query string parameter.
Sep 20 2018, 5:19 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Audiences-QA, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MinervaNeue
Jdrewniak reassigned T197884: Respect Readers Web coding convention for test filenames from Jdrewniak to Jdlrobson.
Sep 20 2018, 5:15 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak added a comment to T204839: Page change language icon is useless in disabled state.

I agree with @Jdlrobson that the disabled button is not useless, but I think it could be made much more useful, if it did, as @Niedzielski suggests, it acted as some sort of CTA to lead users to add a translation. That flow however, needs a lot of design consideration. For one, it would be confusing if the same button revealed translations in one state, and led you down a path to add translations in another state.

Sep 20 2018, 12:16 PM · Readers-Web-Backlog (Design), MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 20 2018, 11:45 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Jdrewniak claimed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Sep 20 2018, 11:45 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Sep 19 2018

Jdrewniak moved T204876: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi from To Triage to Upcoming on the Readers-Web-Backlog board.
Sep 19 2018, 8:59 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, goodfirstbug, MobileFrontend
Jdrewniak added a project to T204698: cloudvps: wikidata-page-banner project trusty deprecation: Readers-Web-Backlog.
Sep 19 2018, 8:50 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Readers-Web-Backlog (Tracking), Wikidata, Wikidata-Page-Banner
Jdrewniak committed rEQSb0682a719936: Renaming QUnit test files from "test_" to "test.js" (authored by Jdrewniak).
Renaming QUnit test files from "test_" to "test.js"
Sep 19 2018, 1:08 PM
Jdrewniak claimed T197884: Respect Readers Web coding convention for test filenames.
Sep 19 2018, 11:48 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak moved T197884: Respect Readers Web coding convention for test filenames from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 19 2018, 11:48 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak created T204807: Minerva should respect the system font-size settings on iOS.
Sep 19 2018, 7:22 AM · User-Ryasmeen, Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Accessibility, MinervaNeue
Jdrewniak added a comment to T195795: Use a clearly intended height on MinervaNeue header.

^ just to elaborate on my thoughts there...
My feeling was that the items inside the header should define its height, and that a statically defined height might break when the items inside are resized or changed.
Looking at the code though, I noticed the header is defined with display: table-cell. This property actually ensures that the height is never smaller than the contents inside it (see here for example video) so, that's pretty cool.

Sep 19 2018, 6:54 AM · Readers-Web-Backlog (Tracking), Front-end-Standards-Group, Design (RW-Design-Debt), MinervaNeue

Sep 18 2018

Jdrewniak renamed T191987: Simplify CategoryOverlay code for readability from Simplify CategoryOverlay for readability to Simplify CategoryOverlay code for readability.
Sep 18 2018, 11:37 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Jdrewniak placed T181623: Chromium-render doesn't handle browser connection abort well up for grabs.
Sep 18 2018, 10:50 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak added a comment to T201954: Add the print button to mobile browsers other than Chrome.

The Share API in an interesting feature to consider. It looks like it only has Android Chrome support, but it's a widely understood feature of mobile apps, and the native Android and iOS Wikipedia apps have it as well.

Sep 18 2018, 10:05 AM · Readers-Web-Backlog (Design), Proton, New-Readers

Sep 17 2018

Jdrewniak added a comment to T193061: [Bug] No page margins for 1000px viewports.

we could also define a width + a max-width, let's say

max-width: 993.3px;
width: 90%;
margin-left: auto;
margin-right: auto;

That way the content will be never be bigger than 993.3px, and on smaller screens it'll be 90% width.

Sep 17 2018, 7:39 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Audiences-QA, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Google-Code-in-2018, Need-volunteer, goodfirstbug, MinervaNeue (Desktop)
Jdrewniak added a comment to T200927: Enable smooth/animated scrolling between links on pages.

We could do smooth scrolling with one line of CSS:

scroll-behavior: smooth;

If we're OK with it working only in Firefox, Chrome, and Chrome for Android (right now).

Sep 17 2018, 7:22 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug
Jdrewniak added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

I've tested this on my local with Siege, and it appears to kill the chromium instances correctly, and the queue management seems to be working well.

Sep 17 2018, 12:36 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 13 2018

Jdrewniak updated subscribers of T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.

Out of curiosity, I've tried to debug this behaviour myself.
On my local machine, I've tested on Android 7 / Chrome 58, Chrome desktop, and latest Safari desktop, and seems to work there.

Sep 13 2018, 11:09 AM · Readers-Web-Backlog (Tracking), Product-Analytics, Reading-analysis

Sep 12 2018

Jdrewniak added a comment to T164449: Consider a static site generator for Wikimedia Design Style Guide.

@dbarratt good points. As you mention, there is a distinction between interface translations and content translations.

Sep 12 2018, 9:08 PM · Wikimedia Design Style Guide
Jdrewniak claimed T181623: Chromium-render doesn't handle browser connection abort well.
Sep 12 2018, 5:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 11 2018

Jdrewniak closed T199452: Introduce webpack config/node-qunit and port ModuleLoader as Resolved.
Sep 11 2018, 5:04 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak closed T199452: Introduce webpack config/node-qunit and port ModuleLoader, a subtask of T155802: [EPIC] Build entire mobile.startup module using webpack bundler, as Resolved.
Sep 11 2018, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt (RW-Tech-Debt)

Sep 7 2018

Jdrewniak moved T203725: Icon correct but issuesSeverity in instrumentation is wrong from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 7 2018, 9:26 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)