Jdrewniak (Jan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (74 w, 2 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Tue, Mar 21

Jdrewniak added a comment to T160724: Add color to icons in sister search results.

The icons we originally made to represent generic 'content types' such as quotations, definitions, textbooks etc. This was meant to help readers who might not know what the sister projects are. However, it turns out that it's hard to make icons that clearly represent these concepts (like a book icon vs textbook icon vs definition icon, they're all book-ish in the end) and an icon alone without any other visual distinctions doesn't convey this meaning. So I think moving away from these generic icons and using the project icons is the right move here. Then at least then, like @Gryllida says, users will be able to distinguish the project names easier.

Tue, Mar 21, 10:41 AM · Discovery-Search (Current work), Discovery

Mon, Mar 20

Jdrewniak added a comment to T158809: Prevent javascript from hiding page content indefinitely.

@Dzahn we monitor the performance of the wikipedia portal carefully here:
https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?from=1458474417000&to=1490010417359

Mon, Mar 20, 11:53 AM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak added a comment to T160704: Design better typographic scale for the portal.

Why focus on pixel output values when using rems? Personally, when using ems & rems I tend to set measurements like 0.75rem, 0.25rem etc, because those are much easier to calculate relative to 1rem.

Mon, Mar 20, 10:29 AM · Design, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery

Thu, Mar 16

Jdrewniak renamed T160622: Disable formatting tool when selecting non-text elements from "Odd text-style selection behaviour on non-text elements" to "Odd text-format selection behaviour on non-text elements".
Thu, Mar 16, 10:21 AM · VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
Jdrewniak created T160622: Disable formatting tool when selecting non-text elements.
Thu, Mar 16, 10:20 AM · VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
Jdrewniak added a comment to T153417: Align the style for lists of pages.

A recent patch by @JGirault https://gerrit.wikimedia.org/r/#/c/342296/ changes the highlight color on the portal typeahead to light blue instead of grey. The patch would change the portal typeahead from this to this:

Thu, Mar 16, 9:57 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Tue, Mar 14

Jdrewniak updated subscribers of T153417: Align the style for lists of pages.
Tue, Mar 14, 6:10 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak moved T158809: Prevent javascript from hiding page content indefinitely from Done to Needs code review on the Discovery-Portal-Sprint board.
Tue, Mar 14, 3:48 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from Needs code review to Done on the Discovery-Portal-Sprint board.
Tue, Mar 14, 3:22 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak moved T158809: Prevent javascript from hiding page content indefinitely from Needs code review to Done on the Discovery-Portal-Sprint board.
Tue, Mar 14, 3:22 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak moved T158782: https://www.wikipedia.org/ portal doesn't have any text from Needs code review to Done on the Discovery-Portal-Sprint board.
Tue, Mar 14, 3:21 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

With the changes to the server config and the full list of URLs in the urls-to-purge.txt, I think we can mark this issue as done.

Tue, Mar 14, 3:21 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals
Jdrewniak moved T153764: Wikipedia.org: translations for legal language footer on portal from In Progress to Done on the Discovery-Portal-Sprint board.
Tue, Mar 14, 3:17 PM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T153764: Wikipedia.org: translations for legal language footer on portal.

This issue should be resolved now.

Tue, Mar 14, 3:17 PM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T159601: Portal set to RTL language: project icons are placed confusingly.

With this patch https://gerrit.wikimedia.org/r/#/c/339631/ (deployed March 14)
the sister project icons for RTL have been improved.

Tue, Mar 14, 3:13 PM · Discovery-Portal-Sprint, Discovery, I18n, RTL, Wikimedia-Portals

Sat, Mar 11

Jdrewniak added a comment to T160222: Remove unused CSS classes.

I think there's a lot more CSS that can be removed here.
There's a nifty chrome devtools feature that highlights what it thinks is unused CSS. These results need manual review because it picks up things like the 'no-js' and typeahead styles as unused, but I think it provides a good starting point.

Sat, Mar 11, 11:36 AM · CSS, Technical-Debt, Patch-For-Review, Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Wed, Mar 8

Jdrewniak added a comment to T158810: Add full list of URL to purge to urls-to-purge.txt.

@MaxSem @demon
That's the idea :)
https://gerrit.wikimedia.org/r/#/c/341379/1/gulpfile.js

Wed, Mar 8, 9:52 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak updated subscribers of T159596: Let the user change the interface language of the wikipedia.org portal.

This seems like a useful feature, especially on mobile where language features are often buried in some OS settings.

Wed, Mar 8, 9:45 PM · Discovery-Portal-Backlog, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T157920: Search using a collection of pre-set project, namespaces, or languages.

This seems related to the work WMDE is insterested in doing related to the advanced search UI
https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Advanced_Search_Workshop

Wed, Mar 8, 8:31 PM · Discovery-Search, CirrusSearch, Discovery
Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

@JGirault the above patch should fix that

Wed, Mar 8, 12:04 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery

Tue, Mar 7

Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Tue, Mar 7, 12:14 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak edited the description of T159806: Search results set to percentage width (bug introduced in Sistersearch A/B test).
Tue, Mar 7, 8:59 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Discovery, Patch-For-Review, Mobile, Discovery-Search (Current work)
Jdrewniak created T159806: Search results set to percentage width (bug introduced in Sistersearch A/B test).
Tue, Mar 7, 8:58 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Discovery, Patch-For-Review, Mobile, Discovery-Search (Current work)

Mon, Mar 6

Jdrewniak moved T158810: Add full list of URL to purge to urls-to-purge.txt from What's Next to In Progress on the Discovery-Portal-Sprint board.
Mon, Mar 6, 6:19 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

oh weird I guess https://www.wikipedia.org/portal/wikipedia.org/assets/js/index-non-existing.js is also cached...
A different fake URL like https://www.wikipedia.org/portal/wikipedia.org/assets/js/index-non-existingX.js does produce a 404 like intended.

Mon, Mar 6, 9:38 AM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals
Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

before the patch the following answers are expected:

Mon, Mar 6, 9:20 AM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals

Mon, Feb 27

Jdrewniak renamed T158938: Scope the CSS of the interwiki results widget from "Create a better way to not show the existing project display (as applicable) when also showing the new sister search results display" to "Scope the CSS of the interwiki results widget".
Mon, Feb 27, 12:45 PM · Discovery-Search (Current work), Discovery
Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

Patch https://gerrit.wikimedia.org/r/#/c/339631/ is by no means a complete RTL solution, but rather addresses the most basic readability issues.

Mon, Feb 27, 11:48 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery

Fri, Feb 24

Jdrewniak added a comment to T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions .

Since the page has been localized and text-direction has been set on the HTML element (although at the moment l10n is slightly broken as we work out some caching issues), I've started work on some minor changes that should improve RTL readability

  • correcting the direction of the search suggestions
  • placement of the icons in the sister project links.
Fri, Feb 24, 2:14 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak moved T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions from To Discuss to In Progress on the Discovery-Portal-Sprint board.
Fri, Feb 24, 1:56 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak edited projects for T129771: Wikipedia.org portal searchbox metadata display: allow for RTL article titles and descriptions , added: Discovery-Portal-Sprint; removed Discovery-Portal-Backlog.
Fri, Feb 24, 1:53 PM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, RTL, Design, I18n, Discovery
Jdrewniak added a comment to T158808: Use a query param for cache-busting instead of suffixing the filename.

Given all the rationale above, it seems best to leave the cache-busting filenames as is, therefore marking this task declined.

Fri, Feb 24, 12:36 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak closed T158808: Use a query param for cache-busting instead of suffixing the filename as "Declined".
Fri, Feb 24, 12:35 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak closed T158808: Use a query param for cache-busting instead of suffixing the filename, a subtask of T128546: [Recurring Task] Update Wikipedia.org Portal and sister Wiki's statistics , as "Declined".
Fri, Feb 24, 12:35 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint

Thu, Feb 23

Jdrewniak added a comment to T158782: https://www.wikipedia.org/ portal doesn't have any text.

@greg there was no updates to the portal today. This brief error today must have happened because the portal was rolled back yesterday, but the HTML page remained cached on our end for 24h (we didn't purge that url). In general the updates are done during SWAT, and should be visible in SAL (not sure why it says the last deploy was last week though).

Thu, Feb 23, 7:38 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals
Jdrewniak updated subscribers of T158782: https://www.wikipedia.org/ portal doesn't have any text.
Thu, Feb 23, 6:44 PM · Wikimedia-Incident, Patch-For-Review, Discovery-Portal-Sprint, Operations, Discovery, Wikimedia-Portals

Wed, Feb 22

Jdrewniak created T158810: Add full list of URL to purge to urls-to-purge.txt.
Wed, Feb 22, 8:59 PM · Patch-For-Review, Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak created T158809: Prevent javascript from hiding page content indefinitely.
Wed, Feb 22, 8:56 PM · Discovery, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak created T158808: Use a query param for cache-busting instead of suffixing the filename.
Wed, Feb 22, 8:49 PM · Wikimedia-Portals, Discovery, Discovery-Portal-Sprint
Jdrewniak moved T152616: Fix eslint warnings from Backlog to Needs code review on the Discovery-Portal-Sprint board.
Wed, Feb 22, 12:58 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak triaged T152616: Fix eslint warnings as "Normal" priority.
Wed, Feb 22, 12:57 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak claimed T152616: Fix eslint warnings.
Wed, Feb 22, 12:56 PM · Discovery-Portal-Sprint, Patch-For-Review, Wikimedia-Portals, Discovery

Tue, Feb 21

Jdrewniak added a watcher for Discovery-Search (Current work): Jdrewniak.
Tue, Feb 21, 11:14 AM
Jdrewniak moved T153764: Wikipedia.org: translations for legal language footer on portal from Needs code review to Done on the Discovery-Portal-Sprint board.
Tue, Feb 21, 10:41 AM · I18n, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Backlog to Done on the Discovery-Portal-Sprint board.
Tue, Feb 21, 10:41 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n
Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Needs code review to Backlog on the Discovery-Portal-Sprint board.
Tue, Feb 21, 10:41 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n

Feb 14 2017

Jdrewniak added a comment to T157854: Is “chrome” a sufficient metaphor/descriptor?.

I think the term chrome can be useful if we define it (Pau's option #1).

Feb 14 2017, 10:21 AM · WikimediaUI Style Guide

Feb 8 2017

Jdrewniak closed T157506: Lists are bulleted on sister search results on mobile as "Resolved".
Feb 8 2017, 6:39 PM · Discovery-Search (Current work), Mobile, Discovery
Jdrewniak added a comment to T157506: Lists are bulleted on sister search results on mobile.

yup fixed

Feb 8 2017, 6:38 PM · Discovery-Search (Current work), Mobile, Discovery
Jdrewniak added a comment to T149809: [A/B Test] Add 'explore similar' pages and categories for search results.

A static prototype of the 'explore similar' feature is available at this URL
https://people.wikimedia.org/~jdrewniak/SERP-sidebar/index.htm

Feb 8 2017, 5:08 PM · Discovery-Search (Current work), CirrusSearch, Discovery
debt awarded T149806: [A/B/C Test] Add cross-wiki search results in a right sidebar a Like token.
Feb 8 2017, 4:14 PM · MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Feb 1 2017

Jdrewniak moved T154350: Add text for "Wikipedia apps are now available" to translatewiki from Needs code review to Done on the Discovery-Portal-Sprint board.
Feb 1 2017, 10:01 AM · Patch-For-Review, Discovery-Portal-Sprint, Wikimedia-Portals, Discovery, I18n

Jan 25 2017

Jdrewniak added a comment to T156150: Install ES 5.x to relforge100[12].

We want to share the sistersearch demo (http://sistersearch.wmflabs.org/) on a few mailing lists to get feedback, so I wouldn't break it just yet. Once we run the A/B test on a few production wikis we won't need the labs instance, so then it should be fine to break then :)

Jan 25 2017, 4:41 PM · Patch-For-Review, Discovery-Search (Current work), Discovery

Jan 19 2017

Jdrewniak added a comment to T151344: Create labs instance for cross-wiki search results testing.

The labs instance with relforge indices has been setup and is available at: http://sistersearch.wmflabs.org/

Jan 19 2017, 12:55 PM · Discovery-Search (Current work), Discovery

Jan 10 2017

Jdrewniak raised the priority of T154349: language and direction are not set at the wikimedia.org portal from "Normal" to "High".
Jan 10 2017, 11:55 PM · Patch-For-Review, Discovery-Portal-Sprint, Discovery, I18n, Wikimedia-Portals, RTL
Jdrewniak edited the description of T153417: Align the style for lists of pages.
Jan 10 2017, 11:31 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak added a comment to T153417: Align the style for lists of pages.

@Volker_E good point. Given how the related articles stack on mobile, I think they can be certainly be considered the same UI pattern (although they serve a different function )

Jan 10 2017, 11:22 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Dec 16 2016

Jdrewniak added a comment to T153417: Align the style for lists of pages.

I added a column for mobile front-end, because the usage of this UI pattern is very prominent on mobile. To be honest, when creating the portal typeahead, we based the style on mobilefrontend because that was the primary usage of this pattern (that we could find). I knew visualEditor was capable of this pattern, but wasn't sure where it was being used.

Dec 16 2016, 4:09 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Jdrewniak edited the description of T153417: Align the style for lists of pages.
Dec 16 2016, 4:03 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Dec 13 2016

Jdrewniak created T153051: Search page duplicates result.
Dec 13 2016, 10:05 AM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.27-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery

Dec 7 2016

Jdrewniak added a comment to T152386: CI tests on wikimedia/portals repo: cache node_modules to save time.

As @hashar mentioned in his comment:

Dec 7 2016, 12:14 PM · Discovery-Portal-Sprint, Wikimedia-Portals, Continuous-Integration-Config, Discovery
Jdrewniak added a comment to T152386: CI tests on wikimedia/portals repo: cache node_modules to save time.
Dec 7 2016, 10:51 AM · Discovery-Portal-Sprint, Wikimedia-Portals, Continuous-Integration-Config, Discovery
Jdrewniak updated subscribers of T151685: Recursive URLs, available in the Wikipedia.org portal.

@Reedy I don't know much about the server setup of the Portals repo, maybe @MaxSem can shed some light on why the symlink is necessary in the first place? (or knows who might know?)

Dec 7 2016, 10:08 AM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Dec 5 2016

Jdrewniak added a comment to T152351: wikimedia/portals repo might be using outdated and or deprecated tests in jenkins.

@MarcoAurelio this looks like an error compiling lwip - the node image processor & optimizer we use to optimize the images (this thing has been a pain with Node 6 - and it cause CI to run for 15 min :/ ). The error your getting seems to be around node-gyp and the version of Python. Node-gyp documentation says to install it globally:
https://github.com/nodejs/node-gyp#installation
so first npm install --global --production windows-build-tools
and then you need to install Python 2.7 on your system, it looks like you have version 3.5.2 (I don't know much about Python version management, so I hope managing multiple python versions on one system isn't a nightmare).
After that, npm install -g node-gyp should work, as well as the local npm install

Dec 5 2016, 6:23 PM · Discovery-Portal-Sprint, Continuous-Integration-Config, Wikimedia-Portals, Discovery

Nov 28 2016

Jdrewniak updated subscribers of T151685: Recursive URLs, available in the Wikipedia.org portal.

@abian I agree that this is a weird setup. But just removing the symlinks would break the page in production, and cleaning up the apache config has the potential of breaking a lot of things. I don't know enough about apache to say if the recursion can be limited in any way, @Gehel do you?

Nov 28 2016, 10:40 AM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Nov 10 2016

Jdrewniak added a comment to T138107: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display.

wow that looks great!

Nov 10 2016, 12:50 PM · Patch-For-Review, Discovery-Analysis (Current work), Wikimedia-Portals, Discovery, Epic
Jdrewniak added a comment to T146231: Align Wikimedia Portal UI elements to improved color palette.

@Volker_E The patch mentioned above changes the language icon color to the M82 blue (#3366cc).
https://gerrit.wikimedia.org/r/#/c/320761/1/prod/wikipedia.org/assets/img/sprite-bookshelf_icons%25402x.png,unified

Nov 10 2016, 12:39 PM · Discovery-Portal-Sprint, Wikimedia-Portals, WMF-Design, UI-Standardization, Design, Discovery, UI-Standardization-Kanban
RandomDSdevel awarded T144640: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" a Piece of Eight token.
Nov 10 2016, 12:49 AM · User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, Discovery-Search (Current work), Discovery, MediaWiki-Search

Nov 9 2016

Jdrewniak edited the description of T150190: Add node 6 compatibility to Portal build tasks.
Nov 9 2016, 12:08 PM · Offline-Working-Group, Patch-For-Review, Discovery-Portal-Sprint

Nov 7 2016

Jdrewniak edited the description of T150190: Add node 6 compatibility to Portal build tasks.
Nov 7 2016, 5:26 PM · Offline-Working-Group, Patch-For-Review, Discovery-Portal-Sprint
Jdrewniak created T150190: Add node 6 compatibility to Portal build tasks.
Nov 7 2016, 5:20 PM · Offline-Working-Group, Patch-For-Review, Discovery-Portal-Sprint

Nov 2 2016

Jdrewniak added a comment to T146807: Wikipedia/Wikimedia apps availability test: analyze results.

I think that was literally a matter of no one clicking on these links 😢

Nov 2 2016, 12:22 PM · Patch-For-Review, Discovery-Analysis (Current work), Wikimedia-Portals, Discovery-Portal-Sprint, Discovery

Oct 29 2016

Liuxinyu970226 awarded T144640: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" a The World Burns token.
Oct 29 2016, 2:17 PM · User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, Discovery-Search (Current work), Discovery, MediaWiki-Search

Oct 14 2016

Jdrewniak added a comment to T148010: Review and fix the description of autocomplete profiles (completion suggester) in the Search preference tab.

@Deskana that's certainly miles better than the current settings :). Design wise I don't see anything wrong with sticking to simple form elements for these setting. I like how the bullet points can help group the options together, maybe putting them in the same order could work, like the "No typo correction" point first maybe?

Oct 14 2016, 7:59 PM · User-notice, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch

Oct 11 2016

Jdrewniak updated subscribers of T144834: Wikipedia.org Portal: update logo for new branding guidelines.
Oct 11 2016, 2:48 PM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak updated subscribers of T144834: Wikipedia.org Portal: update logo for new branding guidelines.
Oct 11 2016, 2:43 PM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T144834: Wikipedia.org Portal: update logo for new branding guidelines.

@JGirault your right that 'pure' black should be reconsidered for text. This'll be discussed with the design team because wikipedia itself gives little guidance ( headers for example, are #000, but body text is #252525 ) and M101 currently suggests #222 as a 'text black'.

Oct 11 2016, 10:46 AM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery

Oct 10 2016

Jdrewniak moved T147794: VisualEditor icons misaligned since v0.17.7 from Unsorted to Icons standardization on the UI-Standardization board.
Oct 10 2016, 2:28 PM · OOjs-UI (OOjs-UI-0.18.0), VisualEditor
Jdrewniak created T147794: VisualEditor icons misaligned since v0.17.7.
Oct 10 2016, 2:27 PM · OOjs-UI (OOjs-UI-0.18.0), VisualEditor

Oct 5 2016

Jdrewniak added a comment to T141442: lvwiki description on www.wikipedia.org portal misses word.

@Silraks, our repo shows that we received this translation on August 15th, and when I change my browser language to Latvian (in chrome, on mac) I do see the correct tranlsation.

Oct 5 2016, 6:35 PM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals
Jdlrobson awarded T147404: Search results page too wide on mobile a Like token.
Oct 5 2016, 5:43 PM · Patch-For-Review, Discovery-Search, Mobile, MediaWiki-Special-pages
Jdrewniak added a comment to T135441: [EPIC] Wikipedia.org Portal: add app download badge.

thank you @RHo! that mobile design looks great!

Oct 5 2016, 9:29 AM · Patch-For-Review, Wikimedia-Portals, Wikipedia-iOS-App-Backlog, Epic, Design, Reading-UX-Research, Discovery-Portal-Sprint, Discovery
Jdrewniak created T147404: Search results page too wide on mobile.
Oct 5 2016, 9:08 AM · Patch-For-Review, Discovery-Search, Mobile, MediaWiki-Special-pages

Oct 3 2016

Jdrewniak added a comment to T135441: [EPIC] Wikipedia.org Portal: add app download badge.

@debt I've implemented you mock with links to the apps in all platforms (and third-party apps).

Oct 3 2016, 5:30 PM · Patch-For-Review, Wikimedia-Portals, Wikipedia-iOS-App-Backlog, Epic, Design, Reading-UX-Research, Discovery-Portal-Sprint, Discovery

Sep 29 2016

Jdrewniak moved T137495: Wikipedia.org Portal Test: add information for Wikipedia / Wikimedia apps availablity from What's Next to In Progress on the Discovery-Portal-Sprint board.
Sep 29 2016, 5:22 PM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T143241: Wikipedia.org Portal: center 'the free encyclopedia' phrase on mobile from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Sep 29 2016, 10:31 AM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T144834: Wikipedia.org Portal: update logo for new branding guidelines from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Sep 29 2016, 10:11 AM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak added a comment to T144834: Wikipedia.org Portal: update logo for new branding guidelines.

I suppose if we change the logo to black we should change the text in the footer from grey to black as well

Sep 29 2016, 10:08 AM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T144007: Wikipedia.org Portal: ceb.wp language link is on two lines from In Progress to Needs code review on the Discovery-Portal-Sprint board.
Sep 29 2016, 9:11 AM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T135441: [EPIC] Wikipedia.org Portal: add app download badge from Backlog to In Progress on the Discovery-Portal-Sprint board.
Sep 29 2016, 8:59 AM · Patch-For-Review, Wikimedia-Portals, Wikipedia-iOS-App-Backlog, Epic, Design, Reading-UX-Research, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T143241: Wikipedia.org Portal: center 'the free encyclopedia' phrase on mobile from What's Next to In Progress on the Discovery-Portal-Sprint board.
Sep 29 2016, 8:59 AM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T144834: Wikipedia.org Portal: update logo for new branding guidelines from What's Next to In Progress on the Discovery-Portal-Sprint board.
Sep 29 2016, 8:59 AM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery
Jdrewniak moved T144007: Wikipedia.org Portal: ceb.wp language link is on two lines from What's Next to In Progress on the Discovery-Portal-Sprint board.
Sep 29 2016, 8:58 AM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery

Sep 27 2016

Jdrewniak moved T143127: `.lang-list-button` doesn't feature focus state from Backlog to Done on the Discovery-Portal-Sprint board.
Sep 27 2016, 3:31 PM · UI-Standardization-Kanban, UI-Standardization, Discovery-Portal-Sprint, Accessibility, Wikimedia-Portals, Discovery
Jdrewniak moved T143127: `.lang-list-button` doesn't feature focus state from Needs code review to Backlog on the Discovery-Portal-Sprint board.
Sep 27 2016, 3:31 PM · UI-Standardization-Kanban, UI-Standardization, Discovery-Portal-Sprint, Accessibility, Wikimedia-Portals, Discovery

Sep 23 2016

Jdrewniak added a comment to T146408: Portal sister project icons are inconsistent sizes.

The project logos are different sizes because they all have slightly different shapes. The sizes have been adjusted by hand to make them appear to be similar sizes (this probably happened years ago). They are different sizes, but they are constrained to a maximum width of 50px.

Sep 23 2016, 1:58 PM · Design, Discovery-Portal-Backlog, Wikimedia-Portals, UI-Standardization, Discovery
Jdrewniak added a comment to T144834: Wikipedia.org Portal: update logo for new branding guidelines.

I hope it's enough to replace the grey logo with a black logo, without the wordmark 'Wikimedia Foundation'. Currently the design doesn't leave much space for the logo + words.

Sep 23 2016, 12:45 PM · Design, Wikimedia-Portals, Discovery-Portal-Sprint, Discovery

Sep 14 2016

Jdrewniak added a comment to T143127: `.lang-list-button` doesn't feature focus state.

The latest patch adds a focus state that has a double outline, similar to that of the search button focus state.

Sep 14 2016, 10:10 AM · UI-Standardization-Kanban, UI-Standardization, Discovery-Portal-Sprint, Accessibility, Wikimedia-Portals, Discovery
Jdrewniak added a comment to T143904: [Recurring task] Monitor translations for incorrect portal language names.

For even easier monitoring, I've added these pages:
https://translatewiki.net/wiki/Special:Translations/Wikimedia:Portals-language-name-romanized-sorted
https://translatewiki.net/wiki/Special:Translations/Wikimedia:Portals-language-name
https://translatewiki.net/wiki/Special:Translations/Wikimedia:Portals-language-name-romanized

Sep 14 2016, 8:33 AM · Discovery-Portal-Sprint, Discovery, Wikimedia-Portals

Sep 1 2016

Jdrewniak added a watcher for Wikimedia-Portals: Jdrewniak.
Sep 1 2016, 8:48 PM