Jdrewniak (Jan Drewniak)
UX Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (147 w, 4 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Thu, Aug 16

Jdrewniak added a comment to T164449: Consider a static site generator for Wikimedia Design Style Guide.

This task hasn't seen much movement recently, but I'd like to point out that it's still something I'm very interested in.

Thu, Aug 16, 9:10 AM · WikimediaUI Style Guide

Wed, Aug 15

Jdrewniak added a comment to T201932: Wikimedia Portals Update and European Mid-day SWAT windows at the same time on Mondays.

@zeljkofilipin yup, I think moving the portals deploy 30 minutes earlier would be good.

Wed, Aug 15, 12:15 PM · User-greg, Release-Engineering-Team (Kanban), User-zeljkofilipin

Tue, Aug 14

Jdrewniak claimed T197499: Wikitext editor error handling broken in read only mode.
Tue, Aug 14, 10:52 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Jdrewniak moved T197499: Wikitext editor error handling broken in read only mode from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Tue, Aug 14, 10:51 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Jdrewniak moved T197497: In readonly mode edit icon should show as locked from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Tue, Aug 14, 10:51 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, Patch-For-Review, Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Easy

Mon, Aug 13

Jdrewniak claimed T197497: In readonly mode edit icon should show as locked.
Mon, Aug 13, 5:11 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, Patch-For-Review, Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Easy
Jdrewniak moved T197497: In readonly mode edit icon should show as locked from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Mon, Aug 13, 11:54 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, Patch-For-Review, Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Easy

Thu, Aug 9

Jdrewniak updated subscribers of T191532: Mobile page issues - instrument page issues.

An update on this weeks changes to the patch sets:

  • WikimediaEvents -creates the hook for pageIssues AB
    • There was some confusion with me and @Niedzielski regarding how the hook is executed, causing us to question @Jdlrobson's solution in PS21 (the problem being, that the pageLoaded event only set one sample group in certain situations). After looking in-depth at how the hook works, we realized this was the correct approach and reintroduced a similar solution in PS26.
    • There are no outstanding (known) bugs with this patch
  • MinervaNeue - creates the events & event-bus PageIssues AB logging
    • Fixed to only run the AB on pages that have issues PS32
    • Only run on main namespace PS24
    • light refactoring in PS26, removing the onABStart method, as it looked like an async callback, which it wasn't.
    • updating the pageIssues schema in PS28
    • this patch depends on 449432 which needs a rebase.
  • MinervaNeue - adds events to page issues overlay
    • just needs a rebase
Thu, Aug 9, 9:40 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings

Wed, Aug 8

Jdrewniak added a comment to T136693: Make lazy loading images resilient.

I noticed recently that the placeholder images on mobile tend to "flicker" a bit before they load. They appear grey, then white, then the image fades in.

Wed, Aug 8, 9:44 PM · Readers-Web-Backlog (Design), MobileFrontend
Jdrewniak updated subscribers of T201369: Getting back to article from permanent URL of current revision on mobile.

ah, I see this issue has already been brought up, thanks @Jdlrobson :)

Wed, Aug 8, 8:52 PM · Readers-Web-Backlog, MobileFrontend
Jdrewniak updated subscribers of T201369: Getting back to article from permanent URL of current revision on mobile.
Wed, Aug 8, 8:50 PM · Readers-Web-Backlog, MobileFrontend
Jdrewniak added a project to T201369: Getting back to article from permanent URL of current revision on mobile: Readers-Web-Backlog.
Wed, Aug 8, 8:50 PM · Readers-Web-Backlog, MobileFrontend
Jdrewniak added a comment to T201369: Getting back to article from permanent URL of current revision on mobile.

I don't think this problem is limited to mobile, the desktop site doesn't provide a link to the current "normal" version of the page as well.

Wed, Aug 8, 8:49 PM · Readers-Web-Backlog, MobileFrontend
Jdrewniak moved T185596: Bring SVGO-based automated optimization to all products from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Wed, Aug 8, 11:26 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Front-end-Standards-Group, UI-Standardization
Jdrewniak updated the task description for T185596: Bring SVGO-based automated optimization to all products.
Wed, Aug 8, 11:25 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Front-end-Standards-Group, UI-Standardization

Mon, Aug 6

Jdrewniak added a comment to T191532: Mobile page issues - instrument page issues.

@Tbayer I think #3 is the most accurate description.

Mon, Aug 6, 1:53 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings

Fri, Aug 3

Jdrewniak moved T197931: Truncate page issues from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 2:30 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak moved T197932: Display section issues modal from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 2:22 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a comment to T200867: Uncaught TypeError: Cannot read property 'getLeadSectionElement' of undefined.

LGTM. https://gerrit.wikimedia.org/r/449645 has been merged so I've merged the patch for this ticket https://gerrit.wikimedia.org/r/449646 and moving this to sign-off.

Fri, Aug 3, 1:44 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Backlog, Regression, Readers-Web-Kanbanana-Board
Jdrewniak moved T200867: Uncaught TypeError: Cannot read property 'getLeadSectionElement' of undefined from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 1:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Backlog, Regression, Readers-Web-Kanbanana-Board
Jdrewniak added a comment to T197931: Truncate page issues.

I don't think there's a great way to handle super short descriptions. One thing that I was thinking of doing was increasing the right padding from 8 to 16px, which I was hoping would push an extra word down to the second line. Typographically speaking, having just one word on a line is considered bad practice, but on the web this should be considered unavoidable.

Fri, Aug 3, 11:37 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Fri, Jul 20

Jdrewniak added a comment to T191532: Mobile page issues - instrument page issues.

Some minor schema updates:

  1. I've pluralized the issueSeverity field to issuesSeverity since more than one issue can be present.
  2. After merging @Niedzielski's icon severity patch, I've changed the issuesSeverity values to one of HIGH, MEDIUM, LOW, DEFAULT instead of severe, high, low, notice. The reason for this is Stephen's patch goes a long way in parsing page-issues, and using the same parsing logic for the instrumentation will give us a consistent concept of a "page issue" across the instrumentation and the feature itself.
Fri, Jul 20, 11:33 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings

Jul 19 2018

Jdrewniak added a comment to T63737: Thank notification on mobile should support click to undo.

After briefly discussing this task with the readers web team, a concern was raised that it might be difficult to coordinate the "Thanks" button with the "toast" component because the button lives in it's own extension, and the "toast" notification lives in mobilefrontend. Coordinating these two elements would mean creating a dependency between them, which might lead to breakage if one is not update updated without the other.

Jul 19 2018, 1:51 PM · Growth-Team, Readers-Web-Backlog, Mobile, Thanks
Jdrewniak moved T191528: Mobile page issues - allow page issues to display different severity levels from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board board.
Jul 19 2018, 12:05 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Jdrewniak moved T197931: Truncate page issues from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jul 19 2018, 11:27 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a comment to T197931: Truncate page issues.

Just a quick update on this task. I think it's lookin' classy. @alexhollender I took your advice of using a media query on larger widths, while still truncating to two lines. I think that works pretty nicely!
I used the same breakpoint we use for tablets, (720px) . Here's a video of how it looks with short and long text.

Jul 19 2018, 11:23 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Jul 18 2018

Jdrewniak added a comment to T199830: Running gulp results in uncommited changes.

@Reedy from the looks of it, I think three things should change here.

  1. The compiled assets sprite.css, style.css, suffixed image files, png fallbacks, -- these files should not be committed to the repo.
  2. These compiled files should live in their own build directory, separate from the source files (and gitignore that directory).
  3. the package.json dependencies should be locked to specific versions, since changes might arise when different versions are used ( I see from T199825 that these could use an update).
Jul 18 2018, 8:41 PM · Discovery, Wikimedia-Portals
Jdrewniak closed T193609: www.wikipedia.org search box should use the 'description' API instead of 'pageterms' as Resolved.
Jul 18 2018, 8:32 PM · Patch-For-Review, Discovery, Wikimedia-Portals
Jdrewniak closed T193609: www.wikipedia.org search box should use the 'description' API instead of 'pageterms', a subtask of T192838: Magic word on English WP, as Resolved.
Jul 18 2018, 8:32 PM · Reading-Infrastructure-Team-Backlog, Wikimedia-General-or-Unknown, Epic
Jdrewniak claimed T199825: Portals using deprecated packages/versions.
Jul 18 2018, 8:28 PM · Discovery, Wikimedia-Portals

Jul 12 2018

Jdrewniak reassigned T196904: Some VirtualPageView are too long and fail EventLogging processing from Ottomata to phuedx.
Jul 12 2018, 5:07 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak added a comment to T197931: Truncate page issues.

yeah the fade shouldn't be x times wide as the text, it should 100% wide + some constant. I've updated the patch to achieve this. The fade is now 4em's longer than the text, and it turns Into solid grey 1em before the text "learn more" starts. Here's a GIF of the resizing behaviour now.

Jul 12 2018, 2:17 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak moved T197931: Truncate page issues from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Jul 12 2018, 2:02 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak moved T199337: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox from Untriaged to Bugs on the Wikimedia-Portals board.
Jul 12 2018, 11:26 AM · Wikimedia-Portals, Discovery

Jul 11 2018

Jdrewniak added a comment to T199337: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox.

Yeah this looks like a bug, both the spacing and the word not showing up in Firefox. I've updated the description to reflect that. I'll look at this issue soon.

Jul 11 2018, 10:11 PM · Wikimedia-Portals, Discovery
Jdrewniak renamed T199337: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox from Number typography on Wikipedia's main page to Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox.
Jul 11 2018, 10:10 PM · Wikimedia-Portals, Discovery
Jdrewniak moved T191532: Mobile page issues - instrument page issues from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jul 11 2018, 7:28 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Jdrewniak added a comment to T191532: Mobile page issues - instrument page issues.

...and also updated the Page Issues schema with an issueSeverity field. From my local testing it seems like the data validates, so I'm moving this monster into the code-review column.

Jul 11 2018, 7:28 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Jdrewniak added a comment to T191532: Mobile page issues - instrument page issues.

I've updated the readingDepth schema to add the option sample group fields. @Tbayer https://meta.wikimedia.org/wiki/Schema:ReadingDepth

Jul 11 2018, 4:00 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Jdrewniak added a comment to T197931: Truncate page issues.

Alrighty I think I got something nice. 2 lines of text with the "learn more" link placed on the last line of text. I think it's OK for basic text - tested in a few languages and I haven't come across situations where the line-height was thrown off for some reason* (yet).

Jul 11 2018, 12:13 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak moved T197931: Truncate page issues from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jul 11 2018, 12:04 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Jul 4 2018

Jdrewniak added a comment to T197931: Truncate page issues.

Not sure if we need more discussion on this task, but as mentioned here https://phabricator.wikimedia.org/T191303#4282504
I have a POC patch that places the "read-more" link on the same line as the content here https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/440556/
I've put this up on http://readers-web-stephen.wmflabs.org for non-technical folks to check out ( ping @alexhollender )

Jul 4 2018, 9:59 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

@Volker_E The initial patch with screen-reader support has been posted on http://a11y.wmflabs.org/
Currently it just features the initial patch that enables screen-readers to read the previews.
Does not yet feature:

  • closing popups via keyboard
  • accessing popups settings via keyboard
  • monobook skin
Jul 4 2018, 3:03 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

Correction. This fix is deployed everywhere now, so the changes are correct and caused by this patch. I was just confused because of the timestamps on Special:Version...

Jul 4 2018, 2:20 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

@alexhollender I don't know 🤷‍♂️ The change doesn't seem to be deployed on enwiki, but even the previews that were broken for me last week seem to be fixed now* ...

Jul 4 2018, 1:05 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews

Jul 3 2018

Jdrewniak added a comment to T191532: Mobile page issues - instrument page issues.

Just uploaded two patches that work on syncing the readingDepth & page issues test. From the page-issues test, the hooks sends an additional parameter with the name of the bucket to readingDepth. In readingDepth, an additional boolean parameter is set for every test/bucket that triggers the readingDepth test.

Jul 3 2018, 8:43 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings

Jul 2 2018

Jdrewniak added a comment to T197034: [Spike] Find how to fix print styles for wide tables both for mobile and desktop.

From the outset I don't see an easy fix here, at least not a CSS only one. CSS columns allow content to wrap up and down from column to column, but unfortunately content can't wrap from row to row.

Jul 2 2018, 9:29 PM · Readers-Web-Backlog (Design), MinervaNeue, Proton
Jdrewniak created T198632: Small instances on reading-web-staging have low disk-space on the vagrant volume.
Jul 2 2018, 3:58 PM · cloud-services-team, Cloud-VPS
Jdrewniak claimed T191532: Mobile page issues - instrument page issues.
Jul 2 2018, 1:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Jdrewniak moved T191532: Mobile page issues - instrument page issues from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Jul 2 2018, 1:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings

Jun 29 2018

Jdrewniak added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

@alexhollender thanks!

Jun 29 2018, 4:51 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Jdrewniak added a comment to T190104: [Spike, 4hrs] Explore adding protection for using forbidden methods.

Bummer! I guess it basically just greps for keywords. I don't think defining functions as "polyfills" is a good approach because we might define a function named 'fetch' in one place, but then we might try using the native fetch function in another place, it won't spot that second error.

Jun 29 2018, 12:54 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Technical-Debt, Spike, Readers-Web-Backlog

Jun 27 2018

Jdrewniak added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.
'http://url...ウィキペディア'.split('').reduce( (url, x) => {
    return (url.length < 1000) ? url += encodeURIComponent(x) : url;  
}, '' )

Do I get a gold star for using reduce?

Jun 27 2018, 7:30 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak added a comment to T196904: Some VirtualPageView are too long and fail EventLogging processing.
URIError can be avoided by searching for the last % character and trimming, no?
Jun 27 2018, 7:05 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak updated subscribers of T196904: Some VirtualPageView are too long and fail EventLogging processing.

Looking over the task description

Inside the Popups code, before sending a VirtualPageView event, ensure the source_url field is limited to 1400 characters.

I assume the length, 1400 characters (or 1000, from the conversation) refers to the uri encoded length of the source_url.

Jun 27 2018, 3:10 PM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak claimed T196904: Some VirtualPageView are too long and fail EventLogging processing.
Jun 27 2018, 11:33 AM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak moved T196904: Some VirtualPageView are too long and fail EventLogging processing from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Jun 27 2018, 11:33 AM · User-Ryasmeen, Readers-Web-Kanbanana-Board, Page-Previews, Analytics, Readers-Web-Backlog, Analytics-EventLogging
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

however out of all those, the only broken thumbnails showing up for me are

Jun 27 2018, 6:59 AM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

just to follow up on that comment, here are the articles with non-standard page_images that I could query from the data dumps:

Jun 27 2018, 6:33 AM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews

Jun 26 2018

Jdrewniak closed T193519: [Bug] Code coverage doesn't generate a report as Resolved.
Jun 26 2018, 7:35 PM · Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Previews, Technical-Debt, Readers-Web-Backlog
Jdrewniak added a comment to T193519: [Bug] Code coverage doesn't generate a report.

Just tested the new code coverage tool, and the report works.
Signing off.

Jun 26 2018, 7:33 PM · Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Previews, Technical-Debt, Readers-Web-Backlog
Jdrewniak closed T196952: [Spike][4hrs] Investigate replacing Istanbul with nyc, a subtask of T193519: [Bug] Code coverage doesn't generate a report, as Resolved.
Jun 26 2018, 7:20 PM · Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Previews, Technical-Debt, Readers-Web-Backlog
Jdrewniak closed T196952: [Spike][4hrs] Investigate replacing Istanbul with nyc as Resolved.
Jun 26 2018, 7:20 PM · Readers-Web-Kanbanana-Board, Spike, Page-Previews, Technical-Debt, Readers-Web-Backlog
Jdrewniak added a comment to T196952: [Spike][4hrs] Investigate replacing Istanbul with nyc.

Yup. Just ran the test and the coverage report works :)
Signing off

Jun 26 2018, 7:20 PM · Readers-Web-Kanbanana-Board, Spike, Page-Previews, Technical-Debt, Readers-Web-Backlog

Jun 25 2018

Jdrewniak added a comment to T198096: Changes to the Www.wikivoyage.org template are not showing in production.

apologies, changes to this page follow the WMF deployment schedule now (deployed once a week through Git and Gerrit) and last week was a "no-deploy" week. The changes are live now though :)

Jun 25 2018, 6:52 PM · Discovery, Wikimedia-Portals
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

@alexhollender yeah I don't really have a list of pages that have videos as the page-image of an article... I'll see what I can do...

Jun 25 2018, 5:39 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak added a comment to T197932: Display section issues modal.

I agree, I think sections issues should remain visible. With the work done on T191303 I think they look pretty on-par with the top-level issues.

Jun 25 2018, 4:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

@alexhollender in the description, could you add links to the image assets pls?

Jun 25 2018, 4:01 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Jdrewniak added a comment to T192928: Popups leave a large margin between thumbnail and description when thumbnail is narrow.

@alexhollender Originally, in this task description, making the the entire preview more narrow was half of a (my) two part solution:

  1. make the entire preview narrow when necessary (this task).
  2. add some sort of css border. (discussed in this task T191267).

With @Jdlrobson's approach however (placing a polyline element inside the svg) and per my comment here, we don't have to make the entire preview more narrow to achieve the desired effect. With this approach we can instead position the polyline element to same x value as the edge of the thumbnail. From an engineering perspective, I think this might be easier than fiddling with the CSS.

Jun 25 2018, 2:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Previews, Readers-Web-Backlog
Jdrewniak moved T192725: "Add discussion" plus habitual talk page workflow can result in a duplicate signature from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Jun 25 2018, 1:53 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), User-notice, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend

Jun 21 2018

Jdrewniak moved T197491: Implement new design for moved paragraphs in diffs on mobile from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Jun 21 2018, 11:18 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Readers-Web-Backlog
Jdrewniak moved T192725: "Add discussion" plus habitual talk page workflow can result in a duplicate signature from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Jun 21 2018, 11:15 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), User-notice, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Jdrewniak added a comment to T192928: Popups leave a large margin between thumbnail and description when thumbnail is narrow.

@Jdlrobson This looks promising! The patch doesn't yet account for thumbnails that are narrower than the maximum width (i.e. the Holy Roman Emperor example), but that use-case is easily addressed because we can position the line at the same x value as the thumbnail. II haven't tested in RTL yet, but in general I think we can move forward with this polyline solution ( I don't think their should be any browser-compatiliby issues either).

Jun 21 2018, 10:45 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board, Patch-For-Review, Page-Previews, Readers-Web-Backlog

Jun 20 2018

Jdrewniak moved T193792: Do not show a broken thumbnail for small video thumbnails from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jun 20 2018, 11:08 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews

Jun 15 2018

Jdrewniak added a comment to T191303: Mobile page issues - visual styling changes.

stripping all HTML from the content

@alexhollender that is not the case! we are leaving the HTML as is, and bending it to our will with CSS 🏋️‍♀️
I'll paste a link to the "read me" + fade shortly.

Jun 15 2018, 4:24 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design

Jun 14 2018

Jdrewniak claimed T193792: Do not show a broken thumbnail for small video thumbnails.
Jun 14 2018, 5:33 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak moved T193792: Do not show a broken thumbnail for small video thumbnails from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Jun 14 2018, 5:32 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

After poking around the summery endpoint, I realized that if we were to fix this issue there, I'm not sure what the correct response should be. The endpoint proxies the value from pageImages api, which, as seen here: https://en.wikipedia.org/w/api.php?action=query&format=json&prop=pageimages&titles=Completing_the_square&redirects=1&converttitles=1&piprop=thumbnail%7Cname%7Coriginal
returns the same non-image for "original".

Jun 14 2018, 1:47 PM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Jdrewniak added a comment to T178665: [Spike, 8hrs] Grave kerning issues and spacing issues in PDFs generated by Chromium (and previous Electron) via "Download as PDF".

from @ABorbaWMF 's screenshots, it looks like mobile and desktop use different fonts. Is that intentional?

Jun 14 2018, 11:54 AM · Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Spike, Design, Proton, Electron-PDFs
Jdrewniak added a comment to T191303: Mobile page issues - visual styling changes.

late loading of icon and 'read me' - I know the usual way of placing an icon is generating it via JS with mw-icon, but man... can't it just be a css background image? what would the downsides be to that?

Jun 14 2018, 10:37 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design

Jun 13 2018

phuedx awarded T189132: [Spike 8 hours] Take an inventory of page issues that are mobile friendly a 100 token.
Jun 13 2018, 12:58 PM · Readers-Web-Kanbanana-Board, Spike, Readers-Web-Backlog

Jun 12 2018

Jdrewniak added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

To my delight, I think this approach -- i.e. adding aria-describedby dynamically -- actually works, at least for VoiceOver on a Mac.
https://drive.google.com/file/d/1dEwRbzQfGtDaDos15s8MngJTROsGr-ZR/view?usp=sharing

Jun 12 2018, 2:55 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews

Jun 11 2018

Jdrewniak moved T193058: [Bug] Fix hover area and placement on settings cog in Page Preview panel from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jun 11 2018, 9:25 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Previews
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUI6bb36c2b7137: Update patch set 1 (authored by Jdrewniak).
Update patch set 1
Jun 11 2018, 7:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUId8bddf40703c: Update patch set 1 (authored by Jdrewniak).
Update patch set 1
Jun 11 2018, 7:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUI99a0dc4fac4a: Update patch set 1 (authored by Jdrewniak).
Update patch set 1
Jun 11 2018, 7:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUI1157700d3c4f: Update patch set 2 (authored by Jdrewniak).
Update patch set 2
Jun 11 2018, 7:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUIf0d9b284a6cd: Update patch set 1 (authored by Jdrewniak).
Update patch set 1
Jun 11 2018, 7:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rWMUIeea38e095b70: Update patch set 1 (authored by Jdrewniak).
Update patch set 1
Jun 11 2018, 7:17 PM

Jun 8 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEASRb455356d86a7: Update patch set 7 (authored by Jdrewniak).
Update patch set 7
Jun 8 2018, 9:44 PM

Jun 7 2018

Jdrewniak moved T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Jun 7 2018, 10:16 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews

Jun 5 2018

Jdrewniak added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

I've created the branch named aria-testing for this feature.

Jun 5 2018, 10:47 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews

Jun 4 2018

Jdrewniak claimed T193595: [Bug] <div class="center">> does not center content.
Jun 4 2018, 10:45 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, MobileFrontend, Readers-Web-Backlog
Jdrewniak moved T193595: [Bug] <div class="center">> does not center content from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Jun 4 2018, 10:45 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, MobileFrontend, Readers-Web-Backlog
Jdrewniak updated the task description for T195915: [Tracking] Trying to saving a page when Mediawiki is on readonly mode shows no message or error.
Jun 4 2018, 9:06 AM · Tracking, MinervaNeue (Tracking), Readers-Web-Backlog, MobileFrontend
Jdrewniak claimed T195915: [Tracking] Trying to saving a page when Mediawiki is on readonly mode shows no message or error.
Jun 4 2018, 8:59 AM · Tracking, MinervaNeue (Tracking), Readers-Web-Backlog, MobileFrontend
Jdrewniak moved T190141: Review promise usage and coalesce unneeded .then blocks from Needs More Work to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Jun 4 2018, 7:27 AM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews

May 30 2018

Jdrewniak moved T190141: Review promise usage and coalesce unneeded .then blocks from Ready for Signoff to Needs More Work on the Readers-Web-Kanbanana-Board board.
May 30 2018, 3:43 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jdrewniak moved T190141: Review promise usage and coalesce unneeded .then blocks from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
May 30 2018, 3:42 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jdrewniak moved T195791: Remove CSS special-casing of mobile VE from Backlog to Tracking on the MobileFrontend board.
May 30 2018, 12:20 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend