Fri, May 7
Thu, May 6
Wed, May 5
Tue, May 4
@alexhollender As of this writing the fixes are live. I've circled them on this screenshot, passing over to you to verify.
One other thing that I changed is that I unwittingly used the "system" font stack in the prototype and forgot about that,
but then someone on the discussion page pointed that out, in all-caps, so I changed it to "sans-serif" as it is in production.
Mon, May 3
Sat, May 1
@Jdlrobson I think a CSS-only approach has some issues. If it were implemented on a per-wiki basis, that would be fine, but as a default for new Vector, without any site styles, the result would look like this:
Thu, Apr 29
Mon, Apr 26
I updated the description. Hope that helps. @Edtadros from the last screenshot you posted
Thu, Apr 22
Wed, Apr 21
That looks good to me :)
I think with that we can mark this task as resolved (reopen if I'm mistaken).
Tue, Apr 20
Fri, Apr 16
I'm noticing a large number of errors related to this function in the the eventgate-validation dashboard.
Using the Way Back Machine, it looks like this change happened around January 2020 (when comparing to December 2019).
Thu, Apr 15
@bwang yeah, I moved this into QA to quickly...
Wed, Apr 14
Tue, Apr 13
Just noting that the remaining work involves updating the version of WVUI in core for this change to take effect.
Mon, Apr 12
I've investigated the visual regression identified by @phuedx , and after consulting with both @alexhollender and @nray, I think the footer padding in the patch related to this task is actually the correct one, which was mistakenly overridden previously and gone unnoticed.
Apr 1 2021
- if you hover over the header area the entire sticky header, with all of its contents, should appear. Currently the header container appears but the header is mostly empty.
- menu position needs to shift right by 10px, right: 0px — both for the one in the site header & the one in the sticky header
- use justify-content: flex-end so the search box moves left and stays anchored on larger screens
- search suggestions menu: increase font-size of page titles to 16px
Mar 29 2021
My comment above about using positive tab-index values was incorrect. We would have to change that attribute for every element on the page for that to work.
Mar 26 2021
^The patch above reorganizes the CSS structure per the description. For the sake of clarity and ease of code-review, it does not touch the Storybook files in Vector. Instead, it creates aliases for them in the webpack config, and disables the url resolving in CSS (issue outlined in the comment above).
Mar 24 2021
Oky doke. I've taken care of all the items on the list above except for
- (logged-in) at the smallest breakpoint can we just ditch the user icon, and add the username as the first menu item?
Mar 22 2021
Mar 21 2021
Nice, I agree this would be a good change :)
Mar 18 2021
@Volker_E the Storybook (specifically Webpack) issue that I've run into so far is the background image URLs that start with url(image/ or img/. Webpack treats those as being a relative path, which would now be different (but not for resourceLoader, because RL just needs to compile the final entry file, which remains in the same place, relative to the images folder).
Alright, I've updated as much as I could so far.
Mar 16 2021
The function you mention can be rewritten in much the same way as other ones:
Mar 15 2021
As well as min-width, something else we can do is add ellipses to the input placeholder:
Mar 14 2021
@Bharatkhatri351 , @Tsiruot , this is a fairly large task, and the description mentions it should be split into multiple patches. So since it would be a good learning experience for both of you, why don't we split the work in half. I assume @Tsiruot is working on the first patch, which is creating the folder and new index.js file, but after that is merged, we can split the creation of the remaining files down the middle (there are more than ten files needing creation here after all).
@Tsiruot unfortunately the node-cmd package won't help much.