Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (200 w, 14 h)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Yesterday

Jdrewniak moved T230445: JS Error occurs when cancelling writing a comment on mobile structured talk pages from Needs Analysis to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Aug 19, 10:50 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, good first bug, MobileFrontend

Fri, Aug 16

Iniquity awarded T225648: Improve presentation of apps on portal a Love token.
Fri, Aug 16, 12:46 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Tue, Aug 13

Jdrewniak placed T225535: Notifications tray (mobile) - design refinements up for grabs.
Tue, Aug 13, 5:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Growth-Team, Notifications
Jdrewniak moved T225535: Notifications tray (mobile) - design refinements from Doing to Needs Analysis on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Aug 13, 5:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Growth-Team, Notifications
Jdrewniak moved T225648: Improve presentation of apps on portal from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Aug 13, 11:15 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak claimed T225648: Improve presentation of apps on portal.
Tue, Aug 13, 11:15 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals

Fri, Aug 9

Jdrewniak claimed T225535: Notifications tray (mobile) - design refinements.
Fri, Aug 9, 9:36 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Growth-Team, Notifications
Jdrewniak moved T225535: Notifications tray (mobile) - design refinements from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Fri, Aug 9, 9:36 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Growth-Team, Notifications

Thu, Aug 8

Jdrewniak closed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs, a subtask of T198313: [GOAL] Advanced mobile contributions, as Resolved.
Thu, Aug 8, 1:44 PM · Advanced Mobile Contributions, Goal, Readers-Web-Backlog
Jdrewniak closed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs as Resolved.
Thu, Aug 8, 1:44 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak closed T221012: Extract $skinOptions from SkinMinerva class, a subtask of T221022: [EPIC] Divide MobileFrontend component concerns, as Resolved.
Thu, Aug 8, 1:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Jdrewniak closed T221012: Extract $skinOptions from SkinMinerva class as Resolved.
Thu, Aug 8, 1:41 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Wed, Aug 7

Jdrewniak added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

the browser support for these features is practically universal.

I guess, in theory... http://timpietrusky.com/advanced-checkbox-hack

Wed, Aug 7, 10:55 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Jdrewniak added a comment to T229360: [EPIC - AMC] Refinements to recent changes.

@alexhollender
bugs: 1, 2, 3 & "Display issues with log entries T229360#5394174"
enhancements: 1, 3, 5
are live on beta.

Wed, Aug 7, 10:06 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog, Advanced Mobile Contributions
Jdrewniak added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

In terms of browser support, the mechanism employed in the overflow menu & user menu is called the checkbox hack.
It was pioneered in 2010 and it depends on a few CCS level 3 features:

Wed, Aug 7, 9:37 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Tue, Aug 6

Jdrewniak claimed T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs.
Tue, Aug 6, 5:06 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak claimed T221012: Extract $skinOptions from SkinMinerva class.
Tue, Aug 6, 5:05 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak added a comment to T229360: [EPIC - AMC] Refinements to recent changes.

@Jdlrobson I didn't realize the work here should be split off into separate tasks, so I attached the last patch to this task instead (it's small though). The patch I submitted above https://gerrit.wikimedia.org/r/528438 addresses refinements 1, 3, 5.

Tue, Aug 6, 12:41 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog, Advanced Mobile Contributions

Mon, Aug 5

Jdrewniak added a comment to T229360: [EPIC - AMC] Refinements to recent changes.

So far:
Bugs:
1 Page should not scroll horizontally
3 When tapping Hide the entire filter box should be hidden.
Are taken care of in this patch:
https://gerrit.wikimedia.org/r/527132

Mon, Aug 5, 6:09 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog, Advanced Mobile Contributions
Jdrewniak moved T229360: [EPIC - AMC] Refinements to recent changes from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Aug 5, 1:19 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog, Advanced Mobile Contributions
Jdrewniak renamed T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal from [Bug] Scrolled search results cannot be followed on Wikimedia portal to [Bug] Scrolled search results cannot be followed on Wikipedia portal.
Mon, Aug 5, 1:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak reassigned T228419: Improve list styles on mobile Special:RecentChanges from Jdrewniak to alexhollender.
Mon, Aug 5, 1:10 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions
Jdrewniak added a comment to T228419: Improve list styles on mobile Special:RecentChanges .

@Edtadros I think @alexhollender pretty much has the QA for this task covered in T229360, so I think I'll reassign this task to him and put it in sign-off.
There has been one bug identified with the list styles in that task, so I think once we take care of that, this task can be signed off.

Mon, Aug 5, 1:09 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions
Jdrewniak closed T183058: Clearly display that other language wiki sites on the portal are categorized by "article count" as Resolved.
Mon, Aug 5, 1:01 PM · Wikimedia-Portals, Discovery
Jdrewniak closed T210401: www.wikipedia.org says 0+ articles for all languages as Resolved.
Mon, Aug 5, 12:59 PM · Wikimedia-Portals
Jdrewniak reassigned T225499: Fix Special:RecentChanges dropdown widget on mobile from Jdrewniak to Edtadros.
Mon, Aug 5, 12:48 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak reassigned T228516: Inform AMC users that grouped results are not available on the recent changes page from Jdrewniak to Edtadros.
Mon, Aug 5, 11:32 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue

Thu, Aug 1

Jdrewniak added a comment to T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).

^ I've attached a followup patch to this ticket. That one enables the loading spinner for the filters like on desktop.

Thu, Aug 1, 11:21 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page

Wed, Jul 31

Jdrewniak added a comment to T229440: Fix icon sizing by updating all 24x24 icons to 20x20 icons.

This is because the icon sizes are determined by the font size of the parent.

Wed, Jul 31, 4:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak placed T229440: Fix icon sizing by updating all 24x24 icons to 20x20 icons up for grabs.
Wed, Jul 31, 4:34 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Tue, Jul 30

Jdrewniak added a comment to T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).

@Jdlrobson good point. I like breaking tasks down into smaller pieces of work, but that was confusing in this case.
There was a lot of uncertainty around how the dropdown menu in the rcfilters was going to be implemented for mobile, which is why T225499 was created.
This task is meant to account for the remaining rcfilters work, i.e: the layout & the remaining buttons.

Tue, Jul 30, 12:48 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page

Mon, Jul 29

Jdrewniak moved T228419: Improve list styles on mobile Special:RecentChanges from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Jul 29, 5:08 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions
Jdrewniak moved T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile) from Needs Analysis to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Jul 29, 5:04 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak updated the task description for T228516: Inform AMC users that grouped results are not available on the recent changes page.
Mon, Jul 29, 1:36 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
Jdrewniak updated the task description for T228516: Inform AMC users that grouped results are not available on the recent changes page.
Mon, Jul 29, 1:35 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
Jdrewniak added a comment to T228516: Inform AMC users that grouped results are not available on the recent changes page.

I'm not Alex, but I'll give my 2 cents on the positioning.

Mon, Jul 29, 1:20 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
Jdrewniak added a comment to T228890: Notification icon should be visible when the notification drawer is open.

It might be a browser bug. I see the notification icon in safari, but not in chrome:

Mon, Jul 29, 11:56 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue

Thu, Jul 25

Jdrewniak reassigned T228280: Disable grouped results on RecentChanges page on mobile from Jdrewniak to Edtadros.
Thu, Jul 25, 11:22 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions
Jdrewniak added a comment to T228280: Disable grouped results on RecentChanges page on mobile.

@Edtadros description updated. This should be live on the beta cluster :)

Thu, Jul 25, 11:21 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions
Jdrewniak updated the task description for T228280: Disable grouped results on RecentChanges page on mobile.
Thu, Jul 25, 11:21 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions
Jdrewniak claimed T228419: Improve list styles on mobile Special:RecentChanges .
Thu, Jul 25, 9:33 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions
Jdrewniak moved T228419: Improve list styles on mobile Special:RecentChanges from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Jul 25, 9:33 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions

Wed, Jul 24

Jdrewniak triaged T228736: [BUG] Drawer does not appear for block messages on mobile as High priority.
Wed, Jul 24, 11:09 AM · Readers-Web-Backlog (Tracking), VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Anti-Harassment, Regression, MediaWiki-User-management, MobileFrontend

Tue, Jul 23

Jdrewniak updated the task description for T228280: Disable grouped results on RecentChanges page on mobile.
Tue, Jul 23, 7:38 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions
Jdrewniak reassigned T228280: Disable grouped results on RecentChanges page on mobile from Jdlrobson to Edtadros.
Tue, Jul 23, 7:34 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions
Jdrewniak placed T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal up for grabs.
Tue, Jul 23, 8:42 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak moved T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Jul 23, 8:41 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals

Mon, Jul 22

Jdrewniak claimed T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal.
Mon, Jul 22, 5:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak moved T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Jul 22, 5:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak moved T225230: [AMC] Reduce margin below Article/Discussion tabs from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Jul 22, 1:45 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Jdrewniak placed T225499: Fix Special:RecentChanges dropdown widget on mobile up for grabs.
Mon, Jul 22, 11:33 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak created T228639: wikimedia-portals-build job failing with "node: command not found".
Mon, Jul 22, 10:32 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (CI & Testing services), Wikimedia-Portals, Jenkins

Jul 18 2019

Jdrewniak added a comment to T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.

wikimedia/portals uses some build step to generate assets which are then deployed as a submodule of operations/mediawiki-config.git.

Yeah – didn't want to break that workflow. @Jdrewniak, are you the expert on this?

Jul 18 2019, 10:40 PM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (CI & Testing services), JavaScript, Continuous-Integration-Config
Jdrewniak closed T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode, a subtask of T223922: [EPIC] Display core version of recent changes page for AMC users, as Resolved.
Jul 18 2019, 1:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Epic, Advanced Mobile Contributions
Jdrewniak closed T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode as Resolved.

Just created T228419 for the styling portion of this task. I think that along with T228280 encompass the work needed for this feature.

Jul 18 2019, 1:06 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, Advanced Mobile Contributions
Jdrewniak created T228419: Improve list styles on mobile Special:RecentChanges .
Jul 18 2019, 12:58 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Mobile, MinervaNeue, Advanced Mobile Contributions
Jdrewniak triaged T228418: Mobile talk overlay not updating with new threads as High priority.
Jul 18 2019, 12:25 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Regression, MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Jdrewniak created T228418: Mobile talk overlay not updating with new threads.
Jul 18 2019, 12:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Regression, MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Jul 17 2019

Jdrewniak created T228280: Disable grouped results on RecentChanges page on mobile.
Jul 17 2019, 1:52 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions

Jul 16 2019

Jdrewniak added a comment to T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode.

Oh, one more thing. The work described above is not blocked on T225499 the advanced filters work for mobile.

Jul 16 2019, 1:13 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, Advanced Mobile Contributions
Jdrewniak added a comment to T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode.

After investigating these list views today, I've come to these conclusions:

Jul 16 2019, 1:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, Advanced Mobile Contributions

Jul 15 2019

Jdrewniak closed T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements as Resolved.
Jul 15 2019, 5:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, MinervaNeue

Jul 11 2019

Jdrewniak added a comment to T227018: EventLogging Schema errors have increased ~6x.

Not sure what happened here but it looks like around July 4 the error rate dropped back down to normal levels.

Jul 11 2019, 12:28 PM · User-Ryasmeen, VisualEditor, Readers-Web-Backlog (Tracking), Analytics, Mobile
Jdrewniak moved T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode from Needs Analysis to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jul 11 2019, 7:49 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, Advanced Mobile Contributions

Jul 8 2019

Jdrewniak closed T227448: wikimedia-portals-build job failing to create castor workspace as Resolved.

yup! thanks @hashar

Jul 8 2019, 10:17 AM · Release-Engineering-Team-TODO (201907), Wikimedia-Portals, Jenkins
Jdrewniak created T227448: wikimedia-portals-build job failing to create castor workspace.
Jul 8 2019, 9:13 AM · Release-Engineering-Team-TODO (201907), Wikimedia-Portals, Jenkins

Jun 27 2019

Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 27 2019, 11:48 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 19 2019

Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

@alexhollender the latest update takes into account a few more of your concerns.
I removed the blue border around the input when the dropdown is open, and I added an "x" icon on the popup menu so that it's easier to close.
The scrolling behaviour is also modified so that the page scrolls to the top of the search input (most of the time) when the menu is opened.

Jun 19 2019, 10:36 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak added a project to T226106: Three clicks required to exit talk overlay: Readers-Web-Backlog.
Jun 19 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, MinervaNeue, Mobile

Jun 18 2019

Jdrewniak moved T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal from Doing to To Do on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 18 2019, 5:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak placed T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal up for grabs.
Jun 18 2019, 5:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 18 2019, 5:03 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

@alexhollender thanks for the feedback!

Jun 18 2019, 3:15 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 17 2019

Jdrewniak added a comment to T224947: Daily Minerva Selenium test job failing.

It looks like the flakiest test is editor_wikitext_saving.js. The error message in the screenshot "Error: Another user had edited this page" suggests some sort of race condition or async error.

Jun 17 2019, 8:45 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MinervaNeue
Jdrewniak added a comment to T224947: Daily Minerva Selenium test job failing.

After looking over the test results over the past couple of days, it seems that the test is now failing intermittently :(

Jun 17 2019, 8:35 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MinervaNeue
Jdrewniak added a comment to T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal.

I was about to decline this ticket because the bug seems to be an Android Chrome issue, but then I thought "how does the mobile wikipedia site handle this issue?" and I discovered that the mobile site triggers a blur event when a user scrolls down. That way, the browser doesn't scroll back up when something is clicked. The same approach can be applied here.

Jun 17 2019, 8:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals
Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

@ovasileva @alexhollender one other thing this patch does, is enable the rcfilters module on mobile.
This means that instead of seeing the current page, users will get the still-unperfect-but-somewhat-useable version of the advanced filters:

Jun 17 2019, 3:55 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

👆Regarding the above patch, it fixes the virtual keyboard issue on the advanced filters form, but it does so in an unconventional way, so I'll explain.
First it uses the OO.ui.isMobile to check if a user is on a mobile device. I believe that method only returns true if mobileFrontend is used, so using Minerva as a desktop skin isn't affected. If isMobile returns true, a readonly attribute is placed on the search input.

Jun 17 2019, 3:22 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 14 2019

Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 14 2019, 7:15 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 13 2019

Jdrewniak moved T224947: Daily Minerva Selenium test job failing from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 13 2019, 5:08 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MinervaNeue
Jdrewniak added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

@ovasileva nope, it's available for all. e.g. an IP userpage: https://en.m.wikipedia.org/wiki/User:66.87.68.6

Jun 13 2019, 2:54 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
Jdrewniak added a comment to T225499: Fix Special:RecentChanges dropdown widget on mobile.

@matmarex thanks for the insight. I see it's a tricky issue because a fixed or min width is sometimes desirable. What I did to work around this issue in this case is set a max-width:100% on the container element, which offsets the min-width value.

Jun 13 2019, 12:58 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 12 2019

Jdrewniak moved T225648: Improve presentation of apps on portal from Untriaged to Design on the Wikimedia-Portals board.
Jun 12 2019, 6:23 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak claimed T225499: Fix Special:RecentChanges dropdown widget on mobile.
Jun 12 2019, 10:25 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak moved T225499: Fix Special:RecentChanges dropdown widget on mobile from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 12 2019, 10:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions

Jun 11 2019

Jdrewniak claimed T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode.
Jun 11 2019, 12:56 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Spike, Advanced Mobile Contributions
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

I've created T225499 and updated T223363 (that one could probably use more detail though) to reflect what I think are the two bigs chunks of work in this spike.

  1. Make the filter dropdown work on mobile
  2. Make the filters look good :)
Jun 11 2019, 12:49 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog
Jdrewniak updated the task description for T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).
Jun 11 2019, 12:33 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak renamed T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile) from Cleanup Special:RecentChanges appearance on Minerva (mobile) to Cleanup Special:RecentChanges filters appearance on Minerva (mobile).
Jun 11 2019, 12:26 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak renamed T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile) from Cleanup Recent changes presentation on Minerva (mobile) to Cleanup Special:RecentChanges appearance on Minerva (mobile).
Jun 11 2019, 12:26 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak added a comment to T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile.

I've closed this task because while analyzing T224655 I discovered this can be fixed with OneLineOfCSS™️, so I bundled that change with a few other that would make this dropdown widget adequately function on mobile: T225499.

Jun 11 2019, 11:51 AM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak merged T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile into T225499: Fix Special:RecentChanges dropdown widget on mobile.
Jun 11 2019, 11:46 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak merged task T223231: mw-rcfilters-ui-menuSelectWidget-group contents disappears on scroll on mobile into T225499: Fix Special:RecentChanges dropdown widget on mobile.
Jun 11 2019, 11:46 AM · Readers-Web-Backlog, Advanced Mobile Contributions, Growth-Team, Mobile, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page
Jdrewniak added a subtask for T223922: [EPIC] Display core version of recent changes page for AMC users: T225499: Fix Special:RecentChanges dropdown widget on mobile.
Jun 11 2019, 11:46 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Epic, Advanced Mobile Contributions
Jdrewniak added a parent task for T225499: Fix Special:RecentChanges dropdown widget on mobile: T223922: [EPIC] Display core version of recent changes page for AMC users.
Jun 11 2019, 11:46 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak created T225499: Fix Special:RecentChanges dropdown widget on mobile.
Jun 11 2019, 11:44 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), OOUI, Mobile, Advanced Mobile Contributions
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

@alexhollender, yes, all three filters use the same dropdown, and are thus equally broken :)

Jun 11 2019, 9:41 AM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog

Jun 10 2019

Jdrewniak moved T224947: Daily Minerva Selenium test job failing from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Jun 10 2019, 5:08 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MinervaNeue
Jdrewniak added a comment to T224655: [SPIKE] Allow recent changes to display filters in AMC mode.

When looking at this task, it occurred to me that a lot of the features work to an acceptable degree on mobile (IMO).

Jun 10 2019, 1:57 PM · Growth-Team, MediaWiki-Recent-changes, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog

Jun 6 2019

Jdrewniak added a comment to T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal.

I dug into this a bit today, and this bug is interesting. It's not a problem with the CSS or positioning of the search suggestions, but it's tied to how Android handles blur events.

Jun 6 2019, 10:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Wikimedia-Portals