Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (183 w, 12 h)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Thu, Apr 18

Jdrewniak moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 18, 11:57 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend

Wed, Apr 17

Jdrewniak moved T220777: Extended testing of Page Previews referenced by `aria-describedby` from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Apr 17, 8:07 PM · Readers-Web-Backlog, Accessibility, Page-Previews
Jdrewniak added a project to T220777: Extended testing of Page Previews referenced by `aria-describedby`: Readers-Web-Backlog.
Wed, Apr 17, 8:07 PM · Readers-Web-Backlog, Accessibility, Page-Previews
Jdrewniak moved T221203: __NEWSECTIONLINK__ doesn't work on mobile web version (can only add new topic by editing last section) from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Wed, Apr 17, 7:59 PM · patch-welcome, MinervaNeue (Tracking)
Jdrewniak added a project to T221203: __NEWSECTIONLINK__ doesn't work on mobile web version (can only add new topic by editing last section): Readers-Web-Backlog.
Wed, Apr 17, 7:59 PM · patch-welcome, MinervaNeue (Tracking)
Jdrewniak claimed T219895: Style the history page for AMC users.
Wed, Apr 17, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions
Jdrewniak moved T219895: Style the history page for AMC users from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Apr 17, 3:33 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend Special Pages), Advanced Mobile Contributions

Tue, Apr 16

Jdrewniak added a comment to T220659: Enable a MobileFrontend daily Selenium build.

Thanks to @zeljkofilipin 's work today we got a daily job running the Mobile Frontend tests on the beta cluster today. Hurray!
However, I still want to edit/write/find a MobileFrontend test that works properly on the beta cluster so that this job doesn't just fail every day.

Tue, Apr 16, 5:19 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson
Jdrewniak claimed T220659: Enable a MobileFrontend daily Selenium build.
Tue, Apr 16, 5:14 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson
Jdrewniak moved T220659: Enable a MobileFrontend daily Selenium build from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 16, 5:14 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Release-Engineering-Team (Kanban), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-zeljkofilipin, User-Jdlrobson

Mon, Apr 15

Jdrewniak added a comment to T220998: Native spelling of Pali on www.wikipedia.org is wrong.

For anyone willing, the string that needs updating on translatewiki is this one:
https://translatewiki.net/wiki/Wikimedia:Portals-language-name/pi

Mon, Apr 15, 7:50 PM · User-DannyS712, Wikimedia-Portals
Jdrewniak created T220969: Move getAndroidVersion() and getChromeVersion() into Browser.js.
Mon, Apr 15, 12:58 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak created T220968: Redefine the responsibilities of Skin.js.
Mon, Apr 15, 12:31 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak created T220965: Decouple Watchstar from Toast and CtaDrawer.
Mon, Apr 15, 11:57 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture)

Fri, Apr 12

Jdrewniak moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Fri, Apr 12, 12:50 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
Jdrewniak placed T218653: Delete unneeded page-actions menu CSS/JS up for grabs.
Fri, Apr 12, 11:05 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend

Wed, Apr 10

Jdrewniak moved T218653: Delete unneeded page-actions menu CSS/JS from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Apr 10, 8:37 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend
Jdrewniak claimed T218653: Delete unneeded page-actions menu CSS/JS.
Wed, Apr 10, 5:10 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend
Jdrewniak moved T218653: Delete unneeded page-actions menu CSS/JS from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Apr 10, 7:55 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend

Tue, Apr 9

Jdrewniak added a watcher for MobileFrontend (MobileFrontend and MinervaNeue architecture): Jdrewniak.
Tue, Apr 9, 6:21 PM
Jdrewniak moved T219846: Remove "mediawiki.template.muhogan" from RelatedArticles from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 9, 5:10 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak moved T219846: Remove "mediawiki.template.muhogan" from RelatedArticles from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 9, 1:03 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), RelatedArticles, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Thu, Apr 4

Jdrewniak claimed T200969: No way to reach the editable version of a page when viewing the most recent mobile diff.
Thu, Apr 4, 1:23 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
Jdrewniak moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 4, 10:31 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend

Wed, Apr 3

Jdrewniak added a project to T219848: MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end: Readers-Web-Backlog.
Wed, Apr 3, 9:11 PM · Readers-Web-Backlog (Tracking), VisualEditor, MediaWiki-Page-protection, MobileFrontend
Jdrewniak triaged T219848: MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end as Normal priority.
Wed, Apr 3, 9:11 PM · Readers-Web-Backlog (Tracking), VisualEditor, MediaWiki-Page-protection, MobileFrontend
Jdrewniak moved T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Apr 3, 8:28 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend

Tue, Apr 2

Jdrewniak added a comment to T218154: Provide a focus state to search box.

To expand on Jon's point, The reason that there's a flicker on the focus event is because when you click the search box in the header, what actually happens is that a new overlay is created that looks like the header (i.e. SearchOverlay) and the focus is shifted from the first search box to the second overlay search box.

Tue, Apr 2, 7:02 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog, UI-Standardization, UI-Standardization-Kanban, Accessibility, MinervaNeue
Jdrewniak added a comment to T189167: How should we deal with events in MobileFrontend's JS?.

And also View.js mixes in OO.EventEmitter, so technically all our components use that :P

Tue, Apr 2, 6:37 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak added a comment to T219841: Unknown dependency: mw.externalguidance.init.

The patch above removes the "targets" from the extension.json file.
I think what was happening is that since the targets were set to "mobile", they weren't being loaded on Minerva desktop.

Tue, Apr 2, 11:55 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Release-Engineering-Team, Analytics, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue (Tracking), ExternalGuidance
Jdrewniak claimed T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen.
Tue, Apr 2, 11:03 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend
Jdrewniak moved T159475: isWideScreen() should only check the width of the device when determining whether a device is wide screen from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 2, 11:03 AM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), patch-welcome, good first bug, MobileFrontend

Mon, Apr 1

Jdrewniak added a comment to T214549: Reduce height of mobile page issues banner and offset of learn more.

@alexhollender it looks like this change is live in production. Do you want to verify this change? ( I ask since it's primarily a design issue).

Mon, Apr 1, 9:55 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak placed T214549: Reduce height of mobile page issues banner and offset of learn more up for grabs.
Mon, Apr 1, 9:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak updated the task description for T214549: Reduce height of mobile page issues banner and offset of learn more.
Mon, Apr 1, 9:53 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak added a comment to T215890: Catch up with minerva header changes (id & star).

@Pablo-WMDE thanks for your interest here. As you probably guessed, the reason downloadPageAction and others do not use an official Minerva API, is because there is none!

Mon, Apr 1, 10:05 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Wikidata, Patch-For-Review, Wikidata-Termbox-Hike

Fri, Mar 29

Jdrewniak moved T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Mar 29, 3:21 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak reassigned T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Jdrewniak to Edtadros.
Fri, Mar 29, 1:15 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak updated the task description for T218807: [Bug] No history button shown on server rendered page (grade C browsers).
Fri, Mar 29, 1:15 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak updated the task description for T219585: Popups' relying on `box-shadow` and `border` combination leads to visual glitches.
Fri, Mar 29, 12:08 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, UI-Standardization, Page-Previews

Wed, Mar 27

Jdrewniak added a comment to T216418: AMC Navigation - overflow menu.

To expand on that a little bit, I did some preliminary research on the front-end implementation of this feature. The parts of this feature that I focused on were: the HTML/CSS & accessibility.

Wed, Mar 27, 11:16 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions

Tue, Mar 26

Jdrewniak updated the task description for T218807: [Bug] No history button shown on server rendered page (grade C browsers).
Tue, Mar 26, 4:44 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak moved T214549: Reduce height of mobile page issues banner and offset of learn more from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 26, 12:51 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak added a comment to T214549: Reduce height of mobile page issues banner and offset of learn more.

I think the patch above solves the issue for the most part.

Tue, Mar 26, 12:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak added a comment to T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..

The best thing here would be not to collapse the sections at all as screen readers take headings as one possible navigational jump target already. But given technical obstacles that seems out of reach.

Tue, Mar 26, 11:05 AM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak claimed T214549: Reduce height of mobile page issues banner and offset of learn more.
Tue, Mar 26, 10:03 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings
Jdrewniak moved T214549: Reduce height of mobile page issues banner and offset of learn more from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Mar 26, 10:02 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Page-Issue-Warnings

Mon, Mar 25

Jdrewniak updated subscribers of T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..
Mon, Mar 25, 6:37 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Volker_E awarded T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers. a Manufacturing Defect? token.
Mon, Mar 25, 6:35 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak reassigned T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail from Jdrewniak to Jdlrobson.
Mon, Mar 25, 12:34 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews
Jdrewniak awarded T171701: Use better site navigation on large screens for Minerva a Like token.
Mon, Mar 25, 9:43 AM · Readers-Web-Backlog (Design), Design (RW-Design-Debt), MinervaNeue (Desktop)

Mar 22 2019

Jdrewniak added a comment to T219028: [Bug] AMC toggle takes two taps to turn off/on.

Same behaviour with the beta toggle.

Mar 22 2019, 7:47 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
Jdrewniak added a comment to T215890: Catch up with minerva header changes (id & star).

@Pablo-WMDE Good point! Adding ID's on the li level seems useful and cleans up that :nth-child in the jQuery, and probably make the CSS more resilient too. This shouldn't be too difficult to add, I'll try to get something out soon.

Mar 22 2019, 3:26 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Wikidata, Patch-For-Review, Wikidata-Termbox-Hike

Mar 21 2019

Jdrewniak claimed T218807: [Bug] No history button shown on server rendered page (grade C browsers).
Mar 21 2019, 3:27 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 21 2019, 3:27 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak moved T218807: [Bug] No history button shown on server rendered page (grade C browsers) from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 21 2019, 3:27 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak placed T213352: AMC: add history link to actions menu up for grabs.
Mar 21 2019, 3:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak moved T213352: AMC: add history link to actions menu from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 21 2019, 3:26 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak added a comment to T218807: [Bug] No history button shown on server rendered page (grade C browsers).

come to think of it, I don't think the profile icon in skins.minerva.icons.images.variants is being used in either it's original black or the white variant.I think if we change the profile icon to grey, we could remove the skins.minerva.icons.images.variants module entirely.

Mar 21 2019, 2:17 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak added a comment to T218807: [Bug] No history button shown on server rendered page (grade C browsers).

I've looked into the clock icon usage, and even though it has a grey variant, I don't think the original black icon is actually used anywhere. However, the black version is still being loaded for the skins.minerva.icons.images.variants module.

Mar 21 2019, 1:56 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MobileFrontend
Jdrewniak updated the task description for T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.
Mar 21 2019, 10:55 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews

Mar 20 2019

Jdrewniak added a comment to T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.

matrix being used: matrix(-1 0 0 1 203 0)
Here we rotate the entire map 180 degrees. This puts the pokey in the bottom left/top left corner and given its a mirror image,

Mar 20 2019, 10:35 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews

Mar 19 2019

Jdrewniak created T218653: Delete unneeded page-actions menu CSS/JS.
Mar 19 2019, 11:52 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend

Mar 18 2019

Jdrewniak added a comment to T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..

You now need 2 (nested) elements if you want to make a h2 a button.

Mar 18 2019, 12:46 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak updated the task description for T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..
Mar 18 2019, 12:29 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak moved T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers. from Unsorted to ARIA on the Accessibility board.
Mar 18 2019, 10:22 AM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak added a project to T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers.: Accessibility.
Mar 18 2019, 10:21 AM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue

Mar 15 2019

Jdrewniak created T218404: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers..
Mar 15 2019, 3:49 PM · Spike, Accessibility, Readers-Web-Backlog, MinervaNeue
Jdrewniak added a comment to T215148: On Phabricator workboard, show status of associated Gerrit patches.

@hashar thanks for the tip about the bug parameter! I didn't fix the issue with the multiple bugs on one patch you mention above, but it did make the queries faster. That issue is caused primarily because I'm mapping the patches to tasks 1:1 here, (Array.find) when it should be mapping to an array of tasks (Array.filter).

Mar 15 2019, 9:59 AM · Phabricator
Jdrewniak renamed T218308: Add gerrit.wikimedia.org to the Phabricator CSP from No longer possible to make CORS requests from Phabricator to Gerrit to Add gerrit.wikimedia.org to the Phabricator CSP.
Mar 15 2019, 7:51 AM · Security-Team, Operations, Phabricator, Gerrit

Mar 14 2019

Jdrewniak updated subscribers of T217887: Modal to create a new page is missing styles.

To be honest I'm surprised the overlay works in Vector at all. It's my understanding that the Overlay component was designed to work with Minerva and MobileFrontEnd, and as far as I know, it's never been used outside of this context.

Mar 14 2019, 8:09 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, ExternalGuidance

Mar 13 2019

Jdrewniak moved T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 13 2019, 1:34 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue
Jdrewniak committed rEQSfa48a1fce907: Removes Muhogan module & templates in favor of jQuery (authored by Jdrewniak).
Removes Muhogan module & templates in favor of jQuery
Mar 13 2019, 12:59 PM
Jdrewniak added a comment to T142527: Page actions should use semantic 'a' rather than 'li' as a button and be tabbable.

@Volker_E I can speak to the button vs link.

Mar 13 2019, 7:51 AM · MinervaNeue, Readers-Web-Backlog, Front-end-Standards-Group, MediaWiki-Interface, Technical-Debt (RW-Tech-Debt), SEO, Accessibility

Mar 12 2019

Jdrewniak committed rEQS318392ccfe7f: Removes Muhogan module & templates in favor of jQuery (authored by Jdrewniak).
Removes Muhogan module & templates in favor of jQuery
Mar 12 2019, 3:24 PM
Jdrewniak claimed T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone.
Mar 12 2019, 3:12 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue
Jdrewniak committed rEQS033b7d6aeff2: Removes Muhogan module & templates in favor of jQuery (authored by Jdrewniak).
Removes Muhogan module & templates in favor of jQuery
Mar 12 2019, 3:12 PM
Jdrewniak moved T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 12 2019, 3:11 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue
Jdrewniak added a comment to T168861: Infobox caption should be properly formatted in the mobile view.

also w. regards to @Volker_E duplicate patch T217632, the example infobox


should look like this with the patch

Mar 12 2019, 12:39 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MinervaNeue
Jdrewniak added a comment to T168861: Infobox caption should be properly formatted in the mobile view.

There also seems to be a case where a caption is rendering with centered text and padding already, e.g. https://en.m.wikipedia.org/wiki/Cam_Weaver. which I do not understand.

Mar 12 2019, 12:32 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MinervaNeue
Jdrewniak moved T168861: Infobox caption should be properly formatted in the mobile view from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 12 2019, 12:24 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Audiences-QA (RW-Test-Cases), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MinervaNeue
Jdrewniak moved T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 12 2019, 11:00 AM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews

Mar 11 2019

Jdrewniak updated the task description for T213352: AMC: add history link to actions menu.
Mar 11 2019, 9:28 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak added a comment to T213352: AMC: add history link to actions menu.

hey @Edtadros , I don't think I know of a simple way to test using cached HTML, but 2, 3, 4:

  1. The map gadget - you have to be logged in to wikipedia, then (on desktop) under preferences -> gadgets -> check "Add map popups to coordinates in the mobile website" - then switch to mobile, and pages with locations should have the gadget.
  2. Yes, right-most :)
  3. I think this can be checked by a developer on a local machine, since it involves changes a MediaWiki config file and seeing if the change takes effect.
Mar 11 2019, 9:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Audiences-QA (RW-Test-Cases), Patch-For-Review, Advanced Mobile Contributions

Mar 7 2019

Jdrewniak updated the task description for T217820: Regression: "Expand all sections" setting in Minerva is broken.
Mar 7 2019, 9:32 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Audiences-QA (RW-Test-Cases), Regression, Patch-For-Review, Unplanned-Sprint-Work, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Jdrewniak moved T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 7 2019, 3:41 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Design, Page-Previews
Jdrewniak moved T217820: Regression: "Expand all sections" setting in Minerva is broken from To Do to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 7 2019, 3:37 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Audiences-QA (RW-Test-Cases), Regression, Patch-For-Review, Unplanned-Sprint-Work, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)

Mar 6 2019

Jdrewniak merged T217660: Links in citation references on mobile lack more contrast (blue on black) into T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.
Mar 6 2019, 11:05 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak merged task T217660: Links in citation references on mobile lack more contrast (blue on black) into T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.
Mar 6 2019, 11:05 AM · Readers-Web-Backlog, MinervaNeue, WCAG-Level-AA, MobileFrontend
Jdrewniak added a comment to T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip.

Since this is in upcoming, maybe we can change the color of the links to a better blue as well while we're at it? T217660
..reads @alexhollender commend above, oh! yeah. I'll mark that task as duplicate...

Mar 6 2019, 11:04 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Jdrewniak moved T217660: Links in citation references on mobile lack more contrast (blue on black) from To Triage to Triaged but Future on the Readers-Web-Backlog board.
Mar 6 2019, 11:00 AM · Readers-Web-Backlog, MinervaNeue, WCAG-Level-AA, MobileFrontend
Jdrewniak triaged T217660: Links in citation references on mobile lack more contrast (blue on black) as Normal priority.
Mar 6 2019, 10:55 AM · Readers-Web-Backlog, MinervaNeue, WCAG-Level-AA, MobileFrontend
Jdrewniak added projects to T217660: Links in citation references on mobile lack more contrast (blue on black): MinervaNeue, Readers-Web-Backlog.

I'm adding the Minerva tag since this change can be made to the reference drawer in Minerva. I think Wikimedia-ui-base has an appropriate blue we could use.

Mar 6 2019, 10:54 AM · Readers-Web-Backlog, MinervaNeue, WCAG-Level-AA, MobileFrontend

Mar 5 2019

Jdrewniak committed rEQSf5b7f62a3331: Remove EventLogging schema module (authored by Jdrewniak).
Remove EventLogging schema module
Mar 5 2019, 3:13 PM
Jdrewniak moved T216746: This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation". from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 5 2019, 3:10 PM · Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Technical-Debt, QuickSurveys

Mar 4 2019

Jdrewniak added a comment to T216547: Make EditorOverlay usable on Firefox by disabling auto-resizing.

I've been poking around this issue today, and it seems like exiting early in _resizeEditor leaves the editor in a wonky looking state (half the screen blank where the keyboard would be)
but that does fix the issue.
Removing the input event-binding in postRender however, does not fix the issue, which seems strange to me, because it suggests that event is still firing, but I'm not sure where (on setContent?, I don't see the event in the logs, so I'm not sure if the root cause is really _resizeEditor).

Mar 4 2019, 2:55 PM · User-Ryasmeen, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), VisualEditor, MobileFrontend
Jdrewniak moved T216547: Make EditorOverlay usable on Firefox by disabling auto-resizing from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 4 2019, 1:49 PM · User-Ryasmeen, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), VisualEditor, MobileFrontend
Jdrewniak added a comment to T216793: Update sans-serif font stack to use system typefaces on www.wikipedia.org portal.

FYI I deployed this change today (Monday, March 4 2019) and IMO I think it looks pretty good!
The font-change on Mac/iOS/Android is very subtle, but I think the changes on Windows (from Arial to Segoe UI) and on Linux is more noticeable.

Mar 4 2019, 12:58 PM · Design, UI-Standardization-Kanban, Wikimedia-Portals, UI-Standardization, Readers-Web-Backlog
Jdrewniak added a comment to T215890: Catch up with minerva header changes (id & star).

Apologies for the breaking change. Didn't realize Wikidata made such significant header modifications.
The changes were made to give more flexibility to the page-actions menu (and potentially the header as well) and fix some of the unintuitive HTML structure.

Mar 4 2019, 12:42 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Wikidata, Patch-For-Review, Wikidata-Termbox-Hike
Jdrewniak renamed T216793: Update sans-serif font stack to use system typefaces on www.wikipedia.org portal from Update sans-serif font stack to use system typefaces to Update sans-serif font stack to use system typefaces on www.wikipedia.org portal.
Mar 4 2019, 12:00 PM · Design, UI-Standardization-Kanban, Wikimedia-Portals, UI-Standardization, Readers-Web-Backlog