Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow Web

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (156 w, 4 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Tue, Oct 16

Jdrewniak edited projects for T206027: Collapse mobile.search.util into mobile.startup, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Tue, Oct 16, 1:26 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend.js)
Jdrewniak added a comment to T207104: Reconsider `em` values in CSS with current state browsers.

also related T207038

Tue, Oct 16, 1:02 PM · Front-end-Standards-Group
Jdrewniak added a comment to T207104: Reconsider `em` values in CSS with current state browsers.

assistive technology building on top of font size based zooming, although not related, similar things like T204807 comes to my mind

Tue, Oct 16, 12:53 PM · Front-end-Standards-Group

Mon, Oct 15

Jdrewniak closed T194136: Remove unneeded A/B test code & dependencies from repo as Resolved.
Mon, Oct 15, 9:48 PM · Patch-For-Review, Wikimedia-Portals, Discovery
Jdrewniak closed T114694: Deploy wikimedia/portals with scap3 as Resolved.

@MarcoAurelio this task can certainly be closed out now.

Mon, Oct 15, 11:37 AM · Scap (Scap3-Adoption-Phase1), scap2, Discovery
Jdrewniak added a comment to T206762: Remove table.wikitable border property..

The border should not be removed as it breaks displays of tables such as https://en.m.wikipedia.org/wiki/Help:Sorting#Numerical_sorting_problems

Mon, Oct 15, 11:21 AM · Readers-Web-Backlog, MinervaNeue

Thu, Oct 11

Jdrewniak added a comment to T205128: Bundle Hogan.js.

I've recently run into the question of how to compile templates for unit-tests (for T206226 ). In a Node environment such as node-qunit, we have to import the templates somehow, which led me to discover the mustache-loader for webpack (which uses Hogan under the hood). Have we considered using a loader like this for templates?

Thu, Oct 11, 7:36 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend.js)
Jdrewniak added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

An update (I love to nerd out on this stuff). We're not the only ones to run into this problem. There are long-standing discussions between the relation of schema.org and Wikidata. Reading through this https://www.wikidata.org/wiki/Wikidata:Schema.org led me to this monster GitHub issue, https://github.com/schemaorg/schemaorg/issues/280 where I noticed the use of equivalentClass property. Turns out, for many entities, the equivalentClass property exists and actually points to a schema.org entity, see https://www.wikidata.org/wiki/Q5398426 . I think where that property exists, we could so something like "get instanceof, and then get equivalentClass of that instanceof", and that might give us the valid schema.org @type for that entity.

Thu, Oct 11, 11:27 AM · Performance-Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Campsite, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Wikidata, MediaWiki-extensions-WikibaseClient, SEO
Jdrewniak added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

@Niedzielski @type is tricky. The @context key refers to the vocabulary used to define the structured data. The problem is that http://schema.org and http://wikidata.org are different vocabularies, so a @type defined by Wikidata may be different than one defined by schema.org. Where schema.org defined "TVSeries", Wikidata defines "Q5398426" (television series). I don't think many search-engines recognize the http://wikidata.org vocabulary, so "@context": "http://wikidata.org", is invalid. Omitting the @context key does validate the markup, but I'm not sure there's much value without it.

Thu, Oct 11, 10:36 AM · Performance-Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Campsite, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Wikidata, MediaWiki-extensions-WikibaseClient, SEO

Wed, Oct 10

Jdrewniak added a comment to T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.

@Jdlrobson well I would hate to say that something is impossible.

Wed, Oct 10, 8:44 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Tue, Oct 9

Jdrewniak claimed T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup.
Tue, Oct 9, 9:43 PM · Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
Jdrewniak moved T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Oct 9, 9:42 PM · Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
Jdrewniak updated the task description for T204835: [Bug] Mobile editor shows empty screen under content.
Tue, Oct 9, 9:39 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak placed T204835: [Bug] Mobile editor shows empty screen under content up for grabs.
Tue, Oct 9, 9:36 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak moved T204835: [Bug] Mobile editor shows empty screen under content from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Oct 9, 9:35 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
alexhollender awarded T204807: Minerva should respect the system font-size settings on iOS a Love token.
Tue, Oct 9, 6:43 PM · Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Accessibility, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Oct 9, 5:03 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203965: PageImages Maintenance Script finds not all Images as Resolved.
Tue, Oct 9, 3:36 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, PageImages
Jdrewniak claimed T204835: [Bug] Mobile editor shows empty screen under content.
Tue, Oct 9, 12:34 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
Jdrewniak moved T204835: [Bug] Mobile editor shows empty screen under content from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Oct 9, 12:34 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend

Mon, Oct 8

Jdrewniak updated the task description for T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Mon, Oct 8, 2:00 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Thu, Oct 4

Jdrewniak placed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files up for grabs.
Thu, Oct 4, 11:29 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak claimed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Thu, Oct 4, 11:29 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Wed, Oct 3

Jdrewniak removed a project from T204786: Migrate test_View.js to tests/node-qunit/mobile.startup: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).
Wed, Oct 3, 8:46 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend.js)
Jdrewniak edited projects for T204786: Migrate test_View.js to tests/node-qunit/mobile.startup, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Wed, Oct 3, 8:33 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend.js)

Tue, Oct 2

Jdrewniak placed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files up for grabs.
Tue, Oct 2, 6:51 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Oct 2, 6:51 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Oct 2, 5:16 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Mon, Oct 1

MBinder_WMF awarded T181623: Chromium-render doesn't handle browser connection abort well a Yellow Medal token.
Mon, Oct 1, 9:40 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak closed T181623: Chromium-render doesn't handle browser connection abort well, a subtask of T186748: [EPIC] New service request: chromium-render/deploy, as Resolved.
Mon, Oct 1, 5:02 PM · Epic, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-notice, Services (blocked), Service-deployment-requests, Proton, Operations, Electron-PDFs
Jdrewniak closed T181623: Chromium-render doesn't handle browser connection abort well as Resolved.
Mon, Oct 1, 5:02 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Fri, Sep 28

Jdrewniak edited projects for T186062: Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Readers-Web-Backlog.
Fri, Sep 28, 10:06 AM · Patch-For-Review, MinervaNeue, Readers-Web-Backlog, Performance-Team (Radar), MobileFrontend

Thu, Sep 27

Jdrewniak moved T181623: Chromium-render doesn't handle browser connection abort well from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Thu, Sep 27, 4:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

I've run the pdf-renderer again, overflown it with lots of request, left it on for an hour, intermittently killed the main chromium processes, killed the child processes, disconnected and reconnected the network, and I'm unable to reproduce my previous bug. Good job!

Thu, Sep 27, 4:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Wed, Sep 26

Jdrewniak updated the task description for T203817: Continue webpack + test transition of mobile.startup (pt 2).
Wed, Sep 26, 11:57 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203817: Continue webpack + test transition of mobile.startup (pt 2) as Resolved.
Wed, Sep 26, 11:57 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak closed T203817: Continue webpack + test transition of mobile.startup (pt 2), a subtask of T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva, as Resolved.
Wed, Sep 26, 11:57 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MobileFrontend, MinervaNeue
Jdrewniak closed T203100: Continue webpack + test transition of mobile.startup as Resolved.
Wed, Sep 26, 11:47 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend.js)
Jdrewniak closed T203100: Continue webpack + test transition of mobile.startup, a subtask of T155802: [EPIC] Build entire mobile.startup module using webpack bundler, as Resolved.
Wed, Sep 26, 11:47 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Epic, MobileFrontend (MobileFrontend.js), Technical-Debt (RW-Tech-Debt)

Mon, Sep 24

Jdrewniak added a comment to T195795: Use a clearly intended height on MinervaNeue header.

Tracking down where the headerHeight actually comes from, it looks like it's just statically defined as 3.35em.

Mon, Sep 24, 4:02 PM · Readers-Web-Backlog (Tracking), Front-end-Standards-Group, Design (RW-Design-Debt), MinervaNeue
Jdrewniak added a comment to T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
  • increase utils code coverage
Mon, Sep 24, 10:51 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Thu, Sep 20

Jdrewniak claimed T204746: It should be possible to opt into new page issues treatment via query string parameter.
Thu, Sep 20, 5:19 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Audiences-QA, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MinervaNeue
Jdrewniak reassigned T197884: Respect Readers Web coding convention for test filenames from Jdrewniak to Jdlrobson.
Thu, Sep 20, 5:15 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak added a comment to T204839: Page change language icon is useless in disabled state.

I agree with @Jdlrobson that the disabled button is not useless, but I think it could be made much more useful, if it did, as @Niedzielski suggests, it acted as some sort of CTA to lead users to add a translation. That flow however, needs a lot of design consideration. For one, it would be confusing if the same button revealed translations in one state, and led you down a path to add translations in another state.

Thu, Sep 20, 12:16 PM · Readers-Web-Backlog (Design), MinervaNeue
Jdrewniak moved T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Thu, Sep 20, 11:45 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
Jdrewniak claimed T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.
Thu, Sep 20, 11:45 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Sep 19 2018

Jdrewniak moved T204876: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi from To Triage to Upcoming on the Readers-Web-Backlog board.
Sep 19 2018, 8:59 PM · Google-Code-in-2018, Need-volunteer, goodfirstbug, MobileFrontend, Readers-Web-Backlog
Jdrewniak added a project to T204698: cloudvps: wikidata-page-banner project trusty deprecation: Readers-Web-Backlog.
Sep 19 2018, 8:50 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Readers-Web-Backlog (Tracking), Wikidata, Wikidata-Page-Banner
Jdrewniak committed rEQSb0682a719936: Renaming QUnit test files from "test_" to "test.js" (authored by Jdrewniak).
Renaming QUnit test files from "test_" to "test.js"
Sep 19 2018, 1:08 PM
Jdrewniak claimed T197884: Respect Readers Web coding convention for test filenames.
Sep 19 2018, 11:48 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak moved T197884: Respect Readers Web coding convention for test filenames from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 19 2018, 11:48 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt
Jdrewniak created T204807: Minerva should respect the system font-size settings on iOS.
Sep 19 2018, 7:22 AM · Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Accessibility, MinervaNeue
Jdrewniak added a comment to T195795: Use a clearly intended height on MinervaNeue header.

^ just to elaborate on my thoughts there...
My feeling was that the items inside the header should define its height, and that a statically defined height might break when the items inside are resized or changed.
Looking at the code though, I noticed the header is defined with display: table-cell. This property actually ensures that the height is never smaller than the contents inside it (see here for example video) so, that's pretty cool.

Sep 19 2018, 6:54 AM · Readers-Web-Backlog (Tracking), Front-end-Standards-Group, Design (RW-Design-Debt), MinervaNeue

Sep 18 2018

Jdrewniak renamed T191987: Simplify CategoryOverlay code for readability from Simplify CategoryOverlay for readability to Simplify CategoryOverlay code for readability.
Sep 18 2018, 11:37 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Technical-Debt
Jdrewniak placed T181623: Chromium-render doesn't handle browser connection abort well up for grabs.
Sep 18 2018, 10:50 AM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
Jdrewniak added a comment to T201954: Add the print button to mobile browsers other than Chrome.

The Share API in an interesting feature to consider. It looks like it only has Android Chrome support, but it's a widely understood feature of mobile apps, and the native Android and iOS Wikipedia apps have it as well.

Sep 18 2018, 10:05 AM · Readers-Web-Backlog (Design), Proton, New-Readers

Sep 17 2018

Jdrewniak added a comment to T193061: [Bug] No page margins for 1000px viewports.

we could also define a width + a max-width, let's say

max-width: 993.3px;
width: 90%;
margin-left: auto;
margin-right: auto;

That way the content will be never be bigger than 993.3px, and on smaller screens it'll be 90% width.

Sep 17 2018, 7:39 PM · Google-Code-in-2018, Readers-Web-Backlog, Need-volunteer, goodfirstbug, MinervaNeue (Desktop)
Jdrewniak added a comment to T200927: Enable smooth/animated scrolling between links on pages.

We could do smooth scrolling with one line of CSS:

scroll-behavior: smooth;

If we're OK with it working only in Firefox, Chrome, and Chrome for Android (right now).

Sep 17 2018, 7:22 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), goodfirstbug
Jdrewniak added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

I've tested this on my local with Siege, and it appears to kill the chromium instances correctly, and the queue management seems to be working well.

Sep 17 2018, 12:36 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 13 2018

Jdrewniak updated subscribers of T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.

Out of curiosity, I've tried to debug this behaviour myself.
On my local machine, I've tested on Android 7 / Chrome 58, Chrome desktop, and latest Safari desktop, and seems to work there.

Sep 13 2018, 11:09 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Product-Analytics, Reading-analysis

Sep 12 2018

Jdrewniak added a comment to T164449: Consider a static site generator for Wikimedia Design Style Guide.

@dbarratt good points. As you mention, there is a distinction between interface translations and content translations.

Sep 12 2018, 9:08 PM · WikimediaUI Style Guide
Jdrewniak claimed T181623: Chromium-render doesn't handle browser connection abort well.
Sep 12 2018, 5:09 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Sep 11 2018

Jdrewniak closed T199452: Introduce webpack config/node-qunit and port ModuleLoader as Resolved.
Sep 11 2018, 5:04 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, MobileFrontend (MobileFrontend.js)
Jdrewniak closed T199452: Introduce webpack config/node-qunit and port ModuleLoader, a subtask of T155802: [EPIC] Build entire mobile.startup module using webpack bundler, as Resolved.
Sep 11 2018, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Epic, MobileFrontend (MobileFrontend.js), Technical-Debt (RW-Tech-Debt)

Sep 7 2018

Jdrewniak moved T203725: Icon correct but issuesSeverity in instrumentation is wrong from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 7 2018, 9:26 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Sep 6 2018

Jdrewniak moved T203386: Multiple-issues templates in page sections don't render in modal from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 6 2018, 11:12 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings

Sep 5 2018

Jdrewniak added a comment to T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..

@Tbayer fortunately, the event-logging actually registers the severity correctly, phew!

Sep 5 2018, 5:37 PM · Page-Issue-Warnings, Readers-Web-Backlog
Jdrewniak updated subscribers of T203527: Beta: Lazy load references with Cyrillic names are not shown in mobile skin (black box at the bottom immediately disappears again).
Sep 5 2018, 1:51 PM · Readers-Web-Backlog, BetaFeatures, MobileFrontend, Mobile, MinervaNeue
Jdrewniak moved T203527: Beta: Lazy load references with Cyrillic names are not shown in mobile skin (black box at the bottom immediately disappears again) from Needs triage to MinervaNeue on the Mobile board.
Sep 5 2018, 1:49 PM · Readers-Web-Backlog, BetaFeatures, MobileFrontend, Mobile, MinervaNeue
Jdrewniak triaged T203527: Beta: Lazy load references with Cyrillic names are not shown in mobile skin (black box at the bottom immediately disappears again) as Normal priority.
Sep 5 2018, 1:47 PM · Readers-Web-Backlog, BetaFeatures, MobileFrontend, Mobile, MinervaNeue
Jdrewniak added a comment to T203527: Beta: Lazy load references with Cyrillic names are not shown in mobile skin (black box at the bottom immediately disappears again).

Yup, I can reproduce this in Safari on a Mac.

Sep 5 2018, 1:46 PM · Readers-Web-Backlog, BetaFeatures, MobileFrontend, Mobile, MinervaNeue
Jdrewniak updated the task description for T203386: Multiple-issues templates in page sections don't render in modal.
Sep 5 2018, 10:28 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings

Sep 4 2018

Jdrewniak moved T203449: page-issues display incorrect icons when multiple issues in section from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 4 2018, 12:28 PM · Patch-For-Review, Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
Jdrewniak created T203449: page-issues display incorrect icons when multiple issues in section.
Sep 4 2018, 9:59 AM · Patch-For-Review, Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Sep 3 2018

Jdrewniak updated the task description for T203386: Multiple-issues templates in page sections don't render in modal.
Sep 3 2018, 9:06 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak updated the task description for T203386: Multiple-issues templates in page sections don't render in modal.
Sep 3 2018, 2:16 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak added a project to T203050: sectionNumbers and issuesSeverity should always be consistent in length: Page-Issue-Warnings.
Sep 3 2018, 12:10 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review
Jdrewniak added a project to T202568: Add margin or white border below page issue banners: Page-Issue-Warnings.
Sep 3 2018, 12:10 PM · Audiences-QA, Page-Issue-Warnings, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
Jdrewniak moved T203386: Multiple-issues templates in page sections don't render in modal from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Sep 3 2018, 11:41 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak created T203386: Multiple-issues templates in page sections don't render in modal.
Sep 3 2018, 11:41 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings

Aug 31 2018

Jdrewniak closed T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment as Resolved.

reviewed this today with @Tbayer and agreed that this can be closed out since the error was not occurring on staging anymore.

Aug 31 2018, 5:50 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak closed T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment, a subtask of T191532: Mobile page issues - instrument page issues, as Resolved.
Aug 31 2018, 5:50 PM · User-Ryasmeen, Audiences-QA, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak closed T202940: [subtask] Various page issues events sending NaN for sectionNumbers in old treatment, a subtask of T202098: Log sectionNumbers in PageIssues schema, as Resolved.
Aug 31 2018, 5:50 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Issue-Warnings
Jdrewniak added a comment to T203050: sectionNumbers and issuesSeverity should always be consistent in length.

After reviewing with @Tbayer today, we noticed one error regarding the multiple issues template.
On the page Politics_of_Cyprus, which has a multiple issues template, the modalClosed event sends

Aug 31 2018, 5:01 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review
Jdrewniak moved T203050: sectionNumbers and issuesSeverity should always be consistent in length from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Aug 31 2018, 5:00 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review
Jdrewniak moved T197195: Combine input and button on portal into one visual element from Untriaged to Design on the Wikimedia-Portals board.
Aug 31 2018, 2:43 PM · UI-Standardization-Kanban, Design, UI-Standardization, Discovery, Wikimedia-Portals
Jdrewniak moved T199830: Running gulp results in uncommited changes from Untriaged to Code Quality / Tech Debt on the Wikimedia-Portals board.
Aug 31 2018, 2:43 PM · Discovery, Wikimedia-Portals
Jdrewniak closed T136185: Establish a merge and deploy workflow for wikimedia/portals repository as Resolved.

Closing this out since in late 2017 we created a "deploy" repo for the Portals project, which contains only the build assets. The builds are generated and deployed weekly. This ensures that each commit represents a new deploy, so rolling back just means reverting the last commit in that repo. More details in T180777 .

Aug 31 2018, 2:38 PM · Wikimedia-Portals, Discovery
Jdrewniak closed T184079: Beta cluster portal reports uncaught JavaScript TypeError as Resolved.
Aug 31 2018, 2:23 PM · Patch-For-Review, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery
Jdrewniak updated the image for Readers-Web-Backlog from F4310663: profile to F25558649: profile.
Aug 31 2018, 2:19 PM
Jdrewniak updated the image for Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) from F25465445: profile to F25558364: profile.
Aug 31 2018, 1:59 PM
Jdrewniak added a comment to T199337: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox.

The issue here was that the page was not rendering the english label for the word "articles". It did appear in other languages, which is probably why I didn't notice this earlier. :/
The patch above should fix the issue.

Aug 31 2018, 12:51 PM · Patch-For-Review, Browser-Support-Firefox, Wikimedia-Portals, Discovery

Aug 30 2018

Jdrewniak moved T202568: Add margin or white border below page issue banners from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Aug 30 2018, 12:18 PM · Audiences-QA, Page-Issue-Warnings, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
Jdrewniak claimed T202568: Add margin or white border below page issue banners.
Aug 30 2018, 10:49 AM · Audiences-QA, Page-Issue-Warnings, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
Jdrewniak moved T202568: Add margin or white border below page issue banners from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Aug 30 2018, 10:47 AM · Audiences-QA, Page-Issue-Warnings, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
Jdrewniak updated subscribers of T202748: [Bug] Popup build synchronization tests are not failing when they ought to.

In addition to @Jdlrobson's patch, @Niedzielski had a similar WIP here
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454566/

Aug 30 2018, 10:39 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Page-Previews
Jdrewniak added a comment to T188937: Replace jQuery.Deferred.done/fail/always().

great job guys!

Aug 30 2018, 8:55 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board-Old, MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Technical-Debt
Jdrewniak closed T188937: Replace jQuery.Deferred.done/fail/always() as Resolved.
Aug 30 2018, 8:55 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board-Old, MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Technical-Debt

Aug 29 2018

Jdrewniak added a comment to T202746: Use ES6 syntax in MobileFrontend.

If we use a transpiler like Babel to convert ES6 to ES5 syntax, that would guarantee that the compiled code would be ES5 compatible wouldn't it?

Aug 29 2018, 4:42 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Backlog, User-Jdlrobson, MinervaNeue
Jdrewniak moved T203050: sectionNumbers and issuesSeverity should always be consistent in length from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Aug 29 2018, 1:11 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Page-Issue-Warnings, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review