Tue, Dec 12
A precusory glance reveals few wrinkles in the apple system font.
On Southern Min Wikipedia for example, Safari on Mac OS produces some missing characters. Not so on mobile Safari...
As per @Jdlrobson suggestion, I’ve created a spreadsheet that illustrates which fonts would be served to which OS’s with this font stack.
Wed, Dec 6
oh look at that, I already have access to stat1004/5, closing the ticket then
Fri, Dec 1
Thu, Nov 30
Just to summarize my thoughts from IRC. The SVG used in marvin does differ considerably from the one used in production wikipedia.
Fri, Nov 24
Thu, Nov 23
looks good to me :)
Just to be clear about the submodule setup, as I was discussing with @hashar today, I think it should look like this:
Mon, Nov 20
Fri, Nov 17
Another insight into why we use the portal symlink for the www portal assets, is that on www.wikipedia.org, search goes through a url like this
which means the config is basically set up to redirect everything after https://www.wikipedia.org/... to mediawiki, except for the /portal/ path.
Nov 17 2017
Nov 16 2017
performance changes will be more accurately observed on our dashboard https://grafana.wikimedia.org/dashboard/db/webpagetest-portals?refresh=1m&orgId=1
@Volker_E good point. I ran a build of the portal with the above patch, and on my machine index.html clocks in at about 75kb
Before this patch, index.html clocks in at about 85kb (like you mentioned)
Nov 15 2017
@zeljkofilipin There are a few reasons I chose mwbot instead of nodemw:
- Promises. mwbot does not support promises out of the box, and Cucumber.js, the testing framework used in CirrusSearch, is heavily promise-based, so mwbot worked with it much better than nodemw
- Batch edit/update convenience functions. Like Erik mentioned, there's a lot of article setup with CirrusSearch, (generating many test articles) so having batch edit functionality was a big plus
- Generally nicer logging with mwbot (goes well with the batching)
Nov 13 2017
@hashar when thinking about splitting the deployment assets into their own repo, I had some concerns regarding developer workflow with a git submodule. Specifically, it seemed confusing to me that the artifacts repo would be updated by the jenkins job, then mediawiki-config would pull to the head of that repo, but the source repo would be stuck at whatever commit the submodule was added at (unless a patch was submitted to update the submodule). Luckily, I discovered that git submodules can also track branches, https://stackoverflow.com/questions/9189575/git-submodule-tracking-latest/9189815#9189815 and that sounds like a pretty good option to me :)
Nov 7 2017
Nov 3 2017
Following up on @debt 's comments. Instead of running the portal build on toolForge, we decided it would be better to run the build in CI with Jenkins, since that wouldn't require maintaining a tool, and CI already has Gerrit permissions (and Jenkin's is kind of designed for building deployment artifacts).
Nov 1 2017
Oct 30 2017
OOPS. this was just placeholder text... did not mean to commit that
I was able to produce the arabic version of the page on mobile by going to system settings on Android and changing the language to Arabic.
However, in the process I discovered a rendering bug T179273 :(
Oct 25 2017
I've updated this with a patch that makes the change in the handlebars templates instead of the generated html
Thank you for this contribution.
Oct 24 2017
This patch went live during SF morning SWAT on October 19th, exact time was 18:36 UTC
Oct 23 2017
The white space, as well as the full-stop in english, is controlled by the templates in the repo, so I can go ahead and fix this.
Would it make more sense if we removed the full stop, and replaced it with a bullet character like the one between использования• Политика конфиденциальности?
So instead of
Эта страница доступна под лицензией Creative Commons Attribution-ShareAlike Условия использования• Политика конфиденциальности
It would read:
Эта страница доступна под лицензией Creative Commons Attribution-ShareAlike • Условия использования • Политика конфиденциальности
Oct 20 2017
Oct 19 2017
So far I've created a node tool on toolforge that is able to pull the repo, run the build, and create a commit (it can create a gerrit commit if it has credentials).
Oct 12 2017
@mxn good point on lang="nan" I'll revert that back in the patch here.
Also, to your point on yue.json and zh-yue.json, it looks like in this specific instance the translation strings don't collide, so these two files can be merged without much conflict, but in the future, if such a conflict did arise, like with lzh, I suppose the newer file could take precedence?
Oct 10 2017
the .mov file shows this without the compression artifacts
On an iOS simulator, it looks like this works.
The one on the left has touch-action:manipulation
The one on the right doesn't.
Sep 5 2017
Aug 30 2017
Aug 29 2017
@alanajjar www.wikipedia.org should change languages when you change the language of the browser. This functionality should work in all modern browsers. Below is a video of how I change the browser language in firefox to Arabic and the portal changes. If you can provide any more details about what browsers this doesn't work in (or share the video below to the users having this issue) that would be great. Thanks.
Aug 24 2017
Aug 23 2017
Aug 18 2017
@mpopov regarding the event logging for this test, I'd like to go over some details of how information about these thumbnails can be collected.
I have an idea that I think integrates nicely with the existing SearchSatisfaction schema.
Aug 17 2017
A demo of this feature is available for testing by adding the following line to a users common.js file on english wikipedia:
importScript( 'User:JDrewniak_(WMF)/searchThumbs.js' );
@Nemo_bis In this context, thumbnails serve just as a visual cue for the search result, and don't have any intrinsic value on their own. This is why on mobile search (typeahead) and on other search engines, clicking on the image acts just like clicking on the text. The thumbnail + search result are perceived as one unit, so it would be confusing if the text led you to one page but the image to another.
@mxn can you take a look at updating the wikiversity logo on the portals from meta?
Aug 14 2017
Link colors and title text are no problem(1 & 2), but it looks like footer link text (3 & 4) is being overridden for english wikipedia and maybe others by this text:
That page hasn't been updated since 2012, and since the feature has changed considerably since then, it might be a good idea to remove this override.
Jul 24 2017
Jul 18 2017
Jul 17 2017
I've looked at this from the event logging side to see if we're accidentally logging clicks that come from the community developed sidebars, but given that the CSS selectors we use to trigger the events are different than those used in the other sidebars (and testing this myself to be sure), this doesn't seem to be the case either.
Jul 10 2017
the no esclick events is certainly strange. I've checked the kafka logs, and I can see esclick events at least making it into there. Maybe they're not valid? could be an invalid param or something. I'm attaching a video and event output. We should check the logstash error logs to see if any errors are being generated.
@Gilles that API wizardry is impressive. I was unaware that API calls could be combined like that, but since they can, it seems like a good idea to me. The thinking behind making these calls separately though, was to avoid sending down data that the user might never see (in the case that they hover over 'languages' but not 'categories' for example). The cost to this approach though, like you mention, is having to wait for each response separately.
Jun 30 2017
Also, a preview of this feature is available on labs:
@Amire80 thank you for your insight. Like you mention this issue was raised in the gerrit patch
but postponed because the AB test we're running is only on english wikipedia (and we don't plan to release until we have l10n coverage). However your right that "local languages" is confusing and should be changed. I was unsure whether "suggested" or "other" languages is preferable, because we're only showing results in "suggested" languages ( basically whatever is exposed via mw.uls.getFrequentLanguageList() ). From your comment it seems "other languages" is preferable, so I'll change it to that.
Jun 27 2017
Jun 22 2017
@mpopov those events sound good to me. In regards to the wprov we'll be using a modified version of the serp:N format (as discussed on IRC) with just _es appended to the end.
Jun 17 2017
Jun 8 2017
Also, the reason this was breaking no wikisource specifically, and not wikipedia,
was that someone somewhere added a CSS class that adds extra margins to all the <ul>'s on the site.
Jun 7 2017
I think this was a CSS issue due to me using display:inline-block to vertically position the top of the sidebar with the top of the search results. Reducing the margin from 10% to 8% seems to fix it.
May 24 2017
May 22 2017
May 21 2017
May 11 2017
The monitor might be very high res like 4K, or it might be a resolution in between 1 and 2x, in which case it would still receive the 1x image. In any case, replacing the icons with SVG's T129634 would fix this
Apr 28 2017
Regarding the UI concerns
Based on the screenshot in figure 1, it seems that only one interface was being tested, without any of the suggested tweaks of https://lists.wikimedia.org/pipermail/discovery/2017-March/001464.html. Correct?
Apr 18 2017
The grunt-sketch npm module caught my eye once, is that what you have in mind with this task?