Page MenuHomePhabricator

Jdrewniak (Jan Drewniak)
UX Engineer - Readers Rainbow

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2015, 9:36 PM (215 w, 2 d)
Availability
Available
IRC Nick
jan_drewniak
LDAP User
Jdrewniak
MediaWiki User
Unknown

Recent Activity

Today

Jdrewniak updated the task description for T238681: History icon not completely visible in smaller screen devices.
Thu, Dec 5, 10:42 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue
Jdrewniak moved T238681: History icon not completely visible in smaller screen devices from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Dec 5, 10:33 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue

Yesterday

Jdrewniak added a project to T239609: The N'Ko language cannot be looked up in the languages search box on Mobile web: Readers-Web-Backlog.
Wed, Dec 4, 10:59 AM · Readers-Web-Backlog, MobileFrontend
Jdrewniak added a comment to T237636: [SPIKE 10hrs] Build new header within the Vector skin.

Although this task sets out to actually try and build a new "throwaway" header, I've identified some ground-work that has to happen before we can even begin building a new header:

Wed, Dec 4, 10:42 AM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T239304: MinervaNeue: Desktop mode has invisible menu button from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Dec 4, 9:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak moved T239304: MinervaNeue: Desktop mode has invisible menu button from Incoming to Kanbanana-2019-20-Q2 on the Readers-Web-Backlog board.
Wed, Dec 4, 9:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak added a comment to T239304: MinervaNeue: Desktop mode has invisible menu button.

I'm unable to reproduce on Chrome on Windows, but we have gotten reports of this issue sporadically.
Currently I'm seeing a disappearing icon on Mac Safari on the Wikimedia beta cluster. https://en.m.wikipedia.beta.wmflabs.org/wiki/TemplateUsageArticle392#
I also noticed this issue when using the VoiceOver screen-reader on iOS, in which icons disappear after the focus has been placed on them.

Wed, Dec 4, 9:58 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)
Jdrewniak placed T238681: History icon not completely visible in smaller screen devices up for grabs.
Wed, Dec 4, 12:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue
Jdrewniak moved T238681: History icon not completely visible in smaller screen devices from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Hope that does it.

Wed, Dec 4, 12:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Mobile, MinervaNeue

Tue, Dec 3

Jdrewniak moved T236328: Username should be on its own line (Recent changes & Watchlist) from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Dec 3, 10:55 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Jdrewniak placed T236328: Username should be on its own line (Recent changes & Watchlist) up for grabs.
Tue, Dec 3, 10:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Jdrewniak added a comment to T239183: Enable 'selector-max-id' stylelint rule on MinervaNeue/MobileFrontend.

Since this is only a linting change and only adds comments, I figured it's ok to skip QA.

Tue, Dec 3, 10:52 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, MinervaNeue
Jdrewniak moved T239183: Enable 'selector-max-id' stylelint rule on MinervaNeue/MobileFrontend from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Dec 3, 10:50 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, MinervaNeue
Jdrewniak added a comment to T235750: [20hrs] Prototype first few feature ideas for desktop improvements.

@Quiddity mentioned that the prototype doesn't do a good job of loading certain language specific templates, such as the French Wikipedia's infoboxes

Tue, Dec 3, 10:15 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T237636: [SPIKE 10hrs] Build new header within the Vector skin.
Tue, Dec 3, 1:48 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T237636: [SPIKE 10hrs] Build new header within the Vector skin from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Dec 3, 11:48 AM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Mon, Dec 2

Jdrewniak added a comment to T239304: MinervaNeue: Desktop mode has invisible menu button.

@SpookyGhost8 what browser/OS is this occurring on?

Mon, Dec 2, 11:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue (Desktop)

Wed, Nov 27

Jdrewniak moved T235750: [20hrs] Prototype first few feature ideas for desktop improvements from Doing to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 27, 6:18 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak placed T235750: [20hrs] Prototype first few feature ideas for desktop improvements up for grabs.
Wed, Nov 27, 6:18 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Tue, Nov 26

Jdrewniak added a comment to T237636: [SPIKE 10hrs] Build new header within the Vector skin.

We also had a conversation about DOM order during our offsite in regards to accessibility. My intuition says that rendering the content first, as Vector currently does, makes life easier for screen-readers & assistive tech, since they don't have to skip through the navigation to get to the content.

Tue, Nov 26, 10:28 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T236328: Username should be on its own line (Recent changes & Watchlist).
Tue, Nov 26, 6:16 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Jdrewniak updated subscribers of T237636: [SPIKE 10hrs] Build new header within the Vector skin.

Currently in the Vector skin, the header HTML, (along with the sidebar & other navigation) are placed below the content. (The header is made to look like it is above the content with CSS).
My understanding is that this was done for performance purposes - so that page content loads first, as well as for accessibility reasons - so that page content is the first thing presented to screen-readers.

Tue, Nov 26, 5:31 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T238563: portals/deploy build broken due to a syntax error in stylelint npm module.

I tried to update the peer dependencies, but this led to the following error when building a binary with node-gyp :/ so I think a revert is in order here.

Tue, Nov 26, 11:00 AM · Release-Engineering-Team-TODO (201911), ci-test-error, Wikimedia-Portals

Mon, Nov 25

Jdrewniak claimed T238563: portals/deploy build broken due to a syntax error in stylelint npm module.
Mon, Nov 25, 1:24 PM · Release-Engineering-Team-TODO (201911), ci-test-error, Wikimedia-Portals

Tue, Nov 19

Jdrewniak committed R2668:d73818ae7e6a: “Components”: Add designing images to checkboxes and radio buttons (#302) (authored by Volker E <Volker-E@users.noreply.github.com>).
“Components”: Add designing images to checkboxes and radio buttons (#302)
Tue, Nov 19, 4:40 PM

Thu, Nov 14

Jdrewniak moved T236589: Page Previews Storybook not available on doc.wikimedia.org and documentation a bit broken from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Since there's already a patch up for this task (thank you @Jdlrobson!) I think this can be estimated and moved to the code-review column.

Thu, Nov 14, 10:28 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Documentation, Page-Previews

Wed, Nov 13

Jdrewniak closed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements, a subtask of T235111: GOAL: Determine scope of Desktop Improvements begin technical setup, as Resolved.
Wed, Nov 13, 10:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, Desktop Improvements
Jdrewniak closed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements as Resolved.

Looks like this task has been thoroughly analyzed and followup conversations are planned, so this task can be resolved. Looking forward to the Modern Event Platform!

Wed, Nov 13, 10:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, Event-Platform, Desktop Improvements

Tue, Nov 12

Jdrewniak claimed T233824: [SPIKE 8hrs] How will the changes to eventlogging affect desktop improvements.
Tue, Nov 12, 6:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, Event-Platform, Desktop Improvements
Jdrewniak moved T183105: Bump running text size up slightly on print stylesheets from Ready for Signoff to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Nov 12, 11:32 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak moved T183105: Bump running text size up slightly on print stylesheets from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Nov 12, 11:31 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak added a comment to T183105: Bump running text size up slightly on print stylesheets.

As this just affects print styles, I didn't see the harm in merging the proposed patch. Moving to design review in case @alexhollender has any comments on this. (Merged patch should be visible on the beta cluster).

Tue, Nov 12, 11:30 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)
Jdrewniak renamed T183105: Bump running text size up slightly on print stylesheets from Bump running text size up slightly to Bump running text size up slightly on print stylesheets.
Tue, Nov 12, 10:28 AM · Vector, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2)

Wed, Nov 6

Jdrewniak assigned T225213: Main Menu should work without JavaScript to be more accessible and a better user experience to Jdlrobson.
Wed, Nov 6, 1:01 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak placed T225213: Main Menu should work without JavaScript to be more accessible and a better user experience up for grabs.
Wed, Nov 6, 1:01 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Jdrewniak moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Nov 6, 1:00 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Nov 5 2019

Jdrewniak added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

@Jdlrobson yes that issue was addressed just after the branch cut last week, so it should appear solved soon.

Nov 5 2019, 6:49 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak claimed T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
Nov 5 2019, 6:19 PM · User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Nov 4 2019

Jdrewniak closed T203137: Dev: Standardising our use of headless node qunit tests across Popups and MobileFrontend as Resolved.
Nov 4 2019, 6:04 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Nov 1 2019

Esanders awarded T234907: RFC: Where to implement Desktop Improvements project a Party Time token.
Nov 1 2019, 5:28 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

As @Jdlrobson mentioned earlier, the Web Team intended to make a decision on this by October 31 🎃.
I've updated the task description with our decision under the heading "RFC Outcome". Instead of forking Vector as originally proposed, we will be implementing the Desktop Improvements project inside Vector. Every option has it's trade-offs, and after considering the points made in this discussion, we felt that working in Vector was the most pragmatic way forward.
Thanks to everyone who contributed to this discussion!

Nov 1 2019, 4:08 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC
Jdrewniak updated the task description for T234907: RFC: Where to implement Desktop Improvements project.
Nov 1 2019, 3:53 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

@Bawolff thanks for your comment. I agree that in an ideal world, a new skin would be the most sensible option. However, given the state of the skinning system, extension compatibility, gadget compatibility, community buy-in, etc. I don't think the ecosystem is in a state where an additional skin is maintainable. As you mention, the "current experience maintained in parallel" line in Proposal 2 recognizes that realistically, we can't get rid of the current Vector "experience" anytime soon.

Nov 1 2019, 2:37 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Oct 30 2019

Jdrewniak claimed T235750: [20hrs] Prototype first few feature ideas for desktop improvements.
Oct 30 2019, 5:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak claimed T226562: AMC - display labels for toolbar actions on larger screens.
Oct 30 2019, 5:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 29 2019

Jdrewniak moved T226562: AMC - display labels for toolbar actions on larger screens from Needs QA to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 29 2019, 11:14 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

I made one followup patch to fix an issue in non-amc mode with the labels.

Oct 29 2019, 11:14 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 28 2019

Jdrewniak updated subscribers of T235750: [20hrs] Prototype first few feature ideas for desktop improvements.

A couple of weeks ago @santhosh reached out to me to show his side-project https://wikivue.netlify.com
(source code at https://gitlab.com/santhoshtr/wikivue/tree/master/src)

Oct 28 2019, 12:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Oct 23 2019

Jdrewniak changed the subtype of T226562: AMC - display labels for toolbar actions on larger screens from "Spike" to "Task".
Oct 23 2019, 5:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak renamed T226562: AMC - display labels for toolbar actions on larger screens from [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens to AMC - display labels for toolbar actions on larger screens.
Oct 23 2019, 5:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak moved T226562: AMC - display labels for toolbar actions on larger screens from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 23 2019, 5:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 17 2019

Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

we (the Reader’s Web team) have been giving a lot more thought to the new-skin & update-vector proposals recently.

Oct 17 2019, 11:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Oct 16 2019

Jdrewniak claimed T203137: Dev: Standardising our use of headless node qunit tests across Popups and MobileFrontend.
Oct 16 2019, 5:06 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Jdrewniak placed T233614: [SPIKE 8hrs] How does search work? up for grabs.
Oct 16 2019, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T233614: [SPIKE 8hrs] How does search work? from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 16 2019, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak updated the task description for T233614: [SPIKE 8hrs] How does search work?.
Oct 16 2019, 12:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak added a comment to T233614: [SPIKE 8hrs] How does search work?.

Thanks for confirming @EBernhardson, one of the key learning from this task is that if we're to change the search experience on desktop as part of the Desktop Refresh project, we should consult the Search Platform team beforehand because changes to the UI can impact your key metrics, that and any new UI should maintain compatibility with the SearchSatisfaction schema.

Oct 16 2019, 12:17 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak closed T234344: MinervaClientError sends malformed events as Declined.

If our statsv client is producing request urls with multiple query strings, that's a bug indeed.

Oct 16 2019, 11:53 AM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
Jdrewniak added a comment to T234907: RFC: Where to implement Desktop Improvements project.

Thank you @Jdlrobson and @Isarra for the additional proposal of starting a new skin from scratch (and everyone who’s chimed in so far). During previous conversations with the web team, the option of a brand new skin was disregarded off-hand as being impractical. However, when considering the startup cost of fixing Vector vs. Building a Vector-like skin from scratch, I can see how the two might be comparable (having never written a skin myself though, it’s hard for me to judge).

Oct 16 2019, 8:34 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Oct 15 2019

Jdrewniak added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

Also, please thing about different languages. English looks really nice, but I'm afraid that in other languages those labels can be pretty long. For example in Polish language "unwatch" would become "przestań obserwować" or "usuń z obserwowanych".

Oct 15 2019, 3:19 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak claimed T226562: AMC - display labels for toolbar actions on larger screens.
Oct 15 2019, 1:13 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Jdrewniak moved T226562: AMC - display labels for toolbar actions on larger screens from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 15 2019, 10:14 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions

Oct 14 2019

Jdrewniak updated subscribers of T233614: [SPIKE 8hrs] How does search work?.

@Jdlrobson , @phuedx thank you for further investigating the instrumentation aspects! I added some more details to the instrumentation section in the document.

Oct 14 2019, 11:42 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Oct 10 2019

Jdrewniak added a comment to T233614: [SPIKE 8hrs] How does search work?.

HI all, so tldr;

Oct 10 2019, 4:49 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Oct 9 2019

Jdrewniak claimed T232837: Use mw-ui-icon-flush- classes on various icons to fix alignment: search within pages and block drawer icons.
Oct 9 2019, 5:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Page-Issue-Warnings, Regression
Jdrewniak claimed T234254: Page issues icon is misaligned vertically.
Oct 9 2019, 5:06 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2)

Oct 8 2019

Jdrewniak updated the task description for T234907: RFC: Where to implement Desktop Improvements project.
Oct 8 2019, 4:59 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC
Jdrewniak claimed T233614: [SPIKE 8hrs] How does search work?.
Oct 8 2019, 12:59 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak moved T233614: [SPIKE 8hrs] How does search work? from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 8 2019, 12:59 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Jdrewniak created T234907: RFC: Where to implement Desktop Improvements project.
Oct 8 2019, 11:44 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Oct 7 2019

Jdrewniak claimed T233521: Language selector and edit button icon not displayed on first load in iOS 13.
Oct 7 2019, 5:24 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile
Jdrewniak moved T233521: Language selector and edit button icon not displayed on first load in iOS 13 from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 7 2019, 5:17 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile

Oct 2 2019

Jdrewniak added a comment to T233521: Language selector and edit button icon not displayed on first load in iOS 13.

I think adding a min-width/min-height to .mw-ui-icon:before can fix this.

Oct 2 2019, 8:18 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile
Jdrewniak added a comment to T233521: Language selector and edit button icon not displayed on first load in iOS 13.

I've tried debugging this issue and I was able to locate an affected page (GW501516 in my case) and inspect it from my iPhone using the Safari inspector.

Oct 2 2019, 8:13 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Editing-team, Language-Team, Mobile

Oct 1 2019

Jdrewniak created T234344: MinervaClientError sends malformed events.
Oct 1 2019, 4:20 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
Jdrewniak updated Jdrewniak.
Oct 1 2019, 8:56 AM
Jdrewniak added a member for Desktop Improvements: Jdrewniak.
Oct 1 2019, 8:56 AM

Sep 30 2019

Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

after syncing with Jon, realized we can align this be removing the .flush-top and adding 10px top-padding to the container instead of 20px

Sep 30 2019, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

@alexhollender @Volker_E Sorry I didn't get back on that, but yeah I think some of the negative margins used to position the icon flush-right and flush-top, combined with fact the icons don't go edge to edge make it look a bit weird, but I don't see an easy fix here :/

Sep 30 2019, 2:13 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Sep 26 2019

Jdrewniak added a comment to T233172: [ICONS] last edited element alignment.

@Jdlrobson thank you! 🙏

Sep 26 2019, 11:37 PM · Readers-Web-Backlog, MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Sep 25 2019

Jdrewniak added a comment to T233152: [ICONS] reference drawer icon and alignment.

The patch above aligns the header as such that the "x" is in the corner, inside the padding and the word "citation" is vertically middle-aligned with the bookmark icon. The bookmark icon however, isn't perfectly aligned with the edge of the padding because the SVG doesn't touch the edges of its canvas.

Sep 25 2019, 11:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak claimed T225127: Display core version of watchlist page for AMC users.
Sep 25 2019, 5:19 PM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Needs Design Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 25 2019, 5:19 PM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

@Jdlrobson that seems fixable, will do!

Sep 25 2019, 5:18 PM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 24 2019

Jdrewniak moved T233152: [ICONS] reference drawer icon and alignment from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 24 2019, 11:24 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak moved T233050: ICONS menu alignment and list item spacing from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 24 2019, 10:14 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak claimed T233050: ICONS menu alignment and list item spacing.
Sep 24 2019, 9:29 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak moved T233050: ICONS menu alignment and list item spacing from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 24 2019, 9:29 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Jdrewniak placed T225127: Display core version of watchlist page for AMC users up for grabs.
Sep 24 2019, 9:29 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 24 2019, 9:29 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

There's a minor style issue with the top portion of the page where the description and "edit your list of watched pages" button is.

Sep 24 2019, 9:12 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 18 2019

Jdrewniak created T233193: MobileFrontend and Minerva Selenium tests failing with "Promise timeout".
Sep 18 2019, 9:06 AM · Release-Engineering-Team-TODO (201909), User-zeljkofilipin, MobileFrontend, Readers-Web-Backlog
Jdrewniak added a comment to T225127: Display core version of watchlist page for AMC users.

We've tried enabling this change on the beta cluster, but for unknown reasons it doesn't appear to work there (works locally :/). This requires further investigation, the fault might be with the beta cluster or with the change itself.

Sep 18 2019, 8:38 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak moved T225127: Display core version of watchlist page for AMC users from Doing to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 18 2019, 8:36 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions

Sep 17 2019

Masumrezarock100 awarded T225127: Display core version of watchlist page for AMC users a Like token.
Sep 17 2019, 7:51 PM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions
Jdrewniak closed T225648: Improve presentation of apps on portal as Resolved.

This has been on production fro a couple of weeks with no issue, so I 'm signing it off.

Sep 17 2019, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Design, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Wikimedia-Portals
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

That's a screenshot from the deletion log page. @Zoranzoki21 , the recent changes does look wrong. (sorry but it's easier for me to spot the problem on enwiki)
I think this summarizes it:

Sep 17 2019, 10:31 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

@Zoranzoki21 is this the correct order of the words?
(summary) is deleted page (name of page).


please correct me if it is not.

Sep 17 2019, 10:18 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend
Jdrewniak added a comment to T232955: [AMC] Summary in recent changes misaligned.

@Zoranzoki21 I' trying to understand what the problem is. Is it

  1. that the summary is not aligned with the rest of the text, like in this screenshot:

Sep 17 2019, 10:01 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions, MobileFrontend

Sep 16 2019

Jdrewniak claimed T225127: Display core version of watchlist page for AMC users.
Sep 16 2019, 11:49 AM · User-notice, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Advanced Mobile Contributions