we (the Reader’s Web team) have been giving a lot more thought to the new-skin & update-vector proposals recently.
Wed, Oct 16
Thanks for confirming @EBernhardson, one of the key learning from this task is that if we're to change the search experience on desktop as part of the Desktop Refresh project, we should consult the Search Platform team beforehand because changes to the UI can impact your key metrics, that and any new UI should maintain compatibility with the SearchSatisfaction schema.
If our statsv client is producing request urls with multiple query strings, that's a bug indeed.
Thank you @Jdlrobson and @Isarra for the additional proposal of starting a new skin from scratch (and everyone who’s chimed in so far). During previous conversations with the web team, the option of a brand new skin was disregarded off-hand as being impractical. However, when considering the startup cost of fixing Vector vs. Building a Vector-like skin from scratch, I can see how the two might be comparable (having never written a skin myself though, it’s hard for me to judge).
Tue, Oct 15
Also, please thing about different languages. English looks really nice, but I'm afraid that in other languages those labels can be pretty long. For example in Polish language "unwatch" would become "przestań obserwować" or "usuń z obserwowanych".
Mon, Oct 14
Thu, Oct 10
HI all, so tldr;
Wed, Oct 9
Tue, Oct 8
Mon, Oct 7
Wed, Oct 2
I think adding a min-width/min-height to .mw-ui-icon:before can fix this.
I've tried debugging this issue and I was able to locate an affected page (GW501516 in my case) and inspect it from my iPhone using the Safari inspector.
Tue, Oct 1
Mon, Sep 30
after syncing with Jon, realized we can align this be removing the .flush-top and adding 10px top-padding to the container instead of 20px
@alexhollender @Volker_E Sorry I didn't get back on that, but yeah I think some of the positioning combined with fact the icons don't go edge to edge make it look a bit weird, but I don't see an easy fix here :/
Thu, Sep 26
@Jdlrobson thank you! 🙏
Wed, Sep 25
The patch above aligns the header as such that the "x" is in the corner, inside the padding and the word "citation" is vertically middle-aligned with the bookmark icon. The bookmark icon however, isn't perfectly aligned with the edge of the padding because the SVG doesn't touch the edges of its canvas.
@Jdlrobson that seems fixable, will do!
Tue, Sep 24
There's a minor style issue with the top portion of the page where the description and "edit your list of watched pages" button is.
Sep 18 2019
We've tried enabling this change on the beta cluster, but for unknown reasons it doesn't appear to work there (works locally :/). This requires further investigation, the fault might be with the beta cluster or with the change itself.
Sep 17 2019
This has been on production fro a couple of weeks with no issue, so I 'm signing it off.
That's a screenshot from the deletion log page. @Zoranzoki21 , the recent changes does look wrong. (sorry but it's easier for me to spot the problem on enwiki)
I think this summarizes it:
@Zoranzoki21 is this the correct order of the words?
(summary) is deleted page (name of page).
please correct me if it is not.
@Zoranzoki21 I' trying to understand what the problem is. Is it
- that the summary is not aligned with the rest of the text, like in this screenshot:
Sep 16 2019
Sep 13 2019
after icon changes you get a square, hurraz.
Sep 12 2019
Since this following is also last-modified-bar related, I'm just gonna tack this on here.
Sep 5 2019
Sep 4 2019
@alexhollender, @Jdlrobson regarding the icon spec noted above (T229440#5452894), I've sketched out an implementation that I think meets the requirements and (hopefully) is compatible with the current CSS classes we're using. This implementation affords for small/medium icons with/without padding, as well as with padding flush left/right. In the instance where the icons are flush, the glyph sits at the edge of the touch area. @alexhollender you mention this in your last point, but I think overflowing the container is a bit risky as it could cause horizontal scrolling.
Sep 3 2019
☝️I agree with this plan of action :)
@Pcoombe yup! no problem :)
Sep 2 2019
Aug 29 2019
@alexhollender I merged the updated icon SVGs today. The change affects the sizing of a lot of the old icons, makes many of the sidebar ones bigger (the new ones remain the same size).
Aug 28 2019
Aug 26 2019
Per AQ steps: this looks good on beta.
Aug 21 2019
Aug 20 2019
Aug 19 2019
Aug 16 2019
Aug 13 2019
Aug 9 2019
Aug 8 2019
Aug 7 2019
the browser support for these features is practically universal.
I guess, in theory... http://timpietrusky.com/advanced-checkbox-hack
Aug 6 2019
@Jdlrobson I didn't realize the work here should be split off into separate tasks, so I attached the last patch to this task instead (it's small though). The patch I submitted above https://gerrit.wikimedia.org/r/528438 addresses refinements 1, 3, 5.