JeanFred (Jean-Frédéric)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:01 PM (211 w, 22 h)
Availability
Available
IRC Nick
JeanFred
LDAP User
Jean-Frédéric
MediaWiki User
Jean-Frédéric [ Global Accounts ]

Recent Activity

Fri, Oct 19

JeanFred edited projects for T207067: Add Scotland Scheduled Monuments in English to monuments database, added: Wiki-Loves-Monuments-Sources; removed Wiki-Loves-Monuments-Database.
Fri, Oct 19, 3:10 PM · Wiki-Loves-Monuments-Sources
JeanFred moved T206146: investigate aborted labs-tools-heritage-tox-dockerjob in jenkins from Backlog to Infrastructure on the Wiki-Loves-Monuments-Database board.
Fri, Oct 19, 3:09 PM · Wiki-Loves-Monuments-Database
JeanFred closed T206146: investigate aborted labs-tools-heritage-tox-dockerjob in jenkins as Resolved.

T206913 was an appropriate fix :)

Fri, Oct 19, 3:09 PM · Wiki-Loves-Monuments-Database
JeanFred closed T200337: populate_adm_tree.php runs out of memory as Resolved.

This has not failed us in a while, closing as Resolved.

Fri, Oct 19, 3:06 PM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred merged T141516: Heritage populate_adm_tree.php fails with memory exhaustion into T200337: populate_adm_tree.php runs out of memory.
Fri, Oct 19, 3:05 PM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred merged task T141516: Heritage populate_adm_tree.php fails with memory exhaustion into T200337: populate_adm_tree.php runs out of memory.
Fri, Oct 19, 3:05 PM · Wiki-Loves-Monuments
JeanFred closed T141982: ErfgoedBot categorisation is broken for ir (fa) as Resolved.

I’ll close this as Resolved since we tackled this with T153746: ErfgoedBot categorisation process should ignore hidden categories.

Fri, Oct 19, 3:04 PM · Wiki-Loves-Monuments
JeanFred added a subtask for T141982: ErfgoedBot categorisation is broken for ir (fa): T153746: ErfgoedBot categorisation process should ignore hidden categories.
Fri, Oct 19, 3:04 PM · Wiki-Loves-Monuments
JeanFred added a parent task for T153746: ErfgoedBot categorisation process should ignore hidden categories: T141982: ErfgoedBot categorisation is broken for ir (fa).
Fri, Oct 19, 3:04 PM · Wiki-Loves-Monuments-Database
JeanFred added a comment to T139308: Floating footer on heritage landing page.

I actually (tried to) did that on purpose... except for the on top of other content ^__^

Fri, Oct 19, 3:02 PM · Wiki-Loves-Monuments
JeanFred moved T57643: Sort "Missing commons category links" by source page from Backlog to Done - in July on the Wiki-Loves-Monuments (2018) board.
Fri, Oct 19, 3:01 PM · Wiki-Loves-Monuments (2018)
JeanFred closed T57643: Sort "Missing commons category links" by source page as Resolved.

It is now grouped by source page. I believe this was done in ac7ab3688b (deployed in July 2018).

Fri, Oct 19, 3:00 PM · Wiki-Loves-Monuments (2018)
JeanFred added a comment to T135605: Undefined offset: 3 in /data/project/heritage/heritage/api/includes/Statistics.php on line 112 .

This looks like fixed in https://tools.wmflabs.org/heritage/api/api.php?action=statistics&stcountry=ua&format=html ?

Fri, Oct 19, 1:44 PM · Wiki-Loves-Monuments

Wed, Oct 17

JeanFred added a comment to T207051: Create Legalpad for WLM permission form.

In the initial discussions with @Effeietsanders and @m.hekmat the form was supposed to be year specific. Shall I rename the form accordingly to WLM 2018, or shall we leave it as is ?

Wed, Oct 17, 8:03 AM · Wiki-Loves-Monuments (2018), Legalpad
JeanFred updated the task description for T207051: Create Legalpad for WLM permission form.
Wed, Oct 17, 7:54 AM · Wiki-Loves-Monuments (2018), Legalpad

Tue, Oct 16

JeanFred moved T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit) from Backlog to Infrastructure on the Wiki-Loves-Monuments-Database board.
Tue, Oct 16, 9:08 AM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database
JeanFred added a comment to T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit).

Thanks for your guidance @hashar !

Tue, Oct 16, 8:46 AM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database

Mon, Oct 15

JeanFred triaged T207051: Create Legalpad for WLM permission form as Normal priority.

@Aklapper Would you be able to provide guidance on the proper process to either have permission to do this, or request to someone who does?

Mon, Oct 15, 4:19 PM · Wiki-Loves-Monuments (2018), Legalpad
JeanFred created T207051: Create Legalpad for WLM permission form.
Mon, Oct 15, 4:18 PM · Wiki-Loves-Monuments (2018), Legalpad
JeanFred added a comment to T200339: Investigate gb-sct disappearing.
Mon, Oct 15, 4:06 PM · Wiki-Loves-Monuments (2018), Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred triaged T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit) as High priority.
Mon, Oct 15, 11:17 AM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database
JeanFred added a comment to T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit).

@hashar @Legoktm Would you be able to provide guidance on how to do this? I tried understanding by going through rCICF but failed :-(

Mon, Oct 15, 11:17 AM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database

Sat, Oct 13

JeanFred claimed T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit).
Sat, Oct 13, 1:30 PM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database
JeanFred edited projects for T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit), added: Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.
Sat, Oct 13, 1:23 PM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database
JeanFred created T206913: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit).
Sat, Oct 13, 1:22 PM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database

Fri, Oct 12

JeanFred added a comment to T206885: Output monuments database statistics per admin level.

Work in progress output : https://commons.wikimedia.org/wiki/User:Jean-Fr%C3%A9d%C3%A9ric/Monuments_database_Statistics_fr_fr

Fri, Oct 12, 10:01 PM · Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred created T206885: Output monuments database statistics per admin level.
Fri, Oct 12, 9:44 PM · Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred added a watcher for Map-of-monuments: JeanFred.
Fri, Oct 12, 9:39 PM

Tue, Oct 2

JeanFred updated subscribers of T204036: populate_image_table job crashes with ImportError: No module named builtins.

Although looking in the logs I see <type 'exceptions.KeyboardInterrupt'> which suggests a similar problem to T203417: update_database crashing due to KeyboardInterrupt

Tue, Oct 2, 9:45 PM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database

Thu, Sep 27

JeanFred updated subscribers of T205598: Stop CommonsDelinker.
Thu, Sep 27, 10:55 AM · Commons, Security, Tools
JeanFred added a comment to T205598: Stop CommonsDelinker.

If CommonsDelinker edits are problematic on Wikidata, can’t it just be blocked there until the bugs are fixed?

Thu, Sep 27, 9:04 AM · Commons, Security, Tools

Mon, Sep 24

JeanFred added a comment to T194996: Build a Docker container providing proxy access to Wiki Replicas.

@JeanFred We actually found that most developers didn't want to remove the password from their ssh keys (which was required for running it in a container)

Mon, Sep 24, 2:45 PM · Wikimedia-Hackathon-2018

Sep 21 2018

JeanFred added a comment to T203349: Expand Commons:Monuments database/Statistics to also include empty sources.

Latest report has some 17 empty sources :) https://commons.wikimedia.org/wiki/Commons:Monuments_database/Statistics

Sep 21 2018, 7:03 PM · Wiki-Loves-Monuments (2018), Patch-For-Review, Wiki-Loves-Monuments-Database

Sep 20 2018

JeanFred added a comment to T204939: UploadWizard: 'Continue' button is not working: "Unable to set property 'licenseMaps' of undefined or null reference".

Confirmed too.

Sep 20 2018, 12:10 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), MediaWiki-extensions-Campaigns, Wiki-Loves-Monuments, Multimedia, UploadWizard
JeanFred triaged T174503: Statistics for Canada give errors monuments database as Normal priority.
Sep 20 2018, 7:05 AM · Wiki-Loves-Monuments (2018), Wikimania-Hackathon-2018, Wiki-Loves-Monuments-Database

Sep 18 2018

JeanFred added a comment to T200339: Investigate gb-sct disappearing.

The WP lists of UK sites are unmaintained by us, and have no connection whatsoever with the WLM-UK campaigns. They also omit the vast majority of grade II buildings. Of course the WP lists may receive odd edits from individual editors but those aren't reflected back to Wikidata.

Sep 18 2018, 10:05 AM · Wiki-Loves-Monuments (2018), Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred added a comment to T175354: list of uploaders in WikiLoves tool does not work if country has multiple words.

Resolved this at the same time as T204427.

Sep 18 2018, 7:08 AM · Tool-wikiloves
JeanFred merged T175354: list of uploaders in WikiLoves tool does not work if country has multiple words into T204427: country names in links on wikiloves stats-tool not always consistent.
Sep 18 2018, 7:07 AM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred merged task T175354: list of uploaders in WikiLoves tool does not work if country has multiple words into T204427: country names in links on wikiloves stats-tool not always consistent.
Sep 18 2018, 7:07 AM · Tool-wikiloves

Sep 17 2018

JeanFred awarded T204550: cloudvps: petscan project trusty deprecation a Party Time token.
Sep 17 2018, 5:27 PM · Cloud-VPS (Ubuntu Trusty Deprecation)
JeanFred added a comment to T204427: country names in links on wikiloves stats-tool not always consistent.
The country name is not consistently used across links, pages etc
Sep 17 2018, 4:51 PM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred committed R1969:46c54c41507f: Fix variables in `users` route (authored by JeanFred).
Fix variables in `users` route
Sep 17 2018, 4:32 PM
JeanFred committed R1969:aafe4188bb9e: Ensure country names are normalized from the URL in images.py (authored by JeanFred).
Ensure country names are normalized from the URL in images.py
Sep 17 2018, 4:32 PM
JeanFred committed R1969:d2e89930a2f9: Ensure country names are normalized from the URL (authored by JeanFred).
Ensure country names are normalized from the URL
Sep 17 2018, 4:32 PM
JeanFred triaged T204427: country names in links on wikiloves stats-tool not always consistent as Normal priority.
Sep 17 2018, 3:46 PM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred added a comment to T204427: country names in links on wikiloves stats-tool not always consistent.

Good catch.

Sep 17 2018, 3:46 PM · Tool-wikiloves, Wiki-Loves-Monuments (2018)

Sep 16 2018

JeanFred added a project to T204427: country names in links on wikiloves stats-tool not always consistent: Tool-wikiloves.
Sep 16 2018, 9:45 PM · Tool-wikiloves, Wiki-Loves-Monuments (2018)

Sep 13 2018

JeanFred moved T144724: [Daily Uploads] Add parameters to url from Backlog to Done - in September on the Wiki-Loves-Monuments (2018) board.
Sep 13 2018, 10:26 PM · Wiki-Loves-Monuments (2018), Patch-For-Review
JeanFred triaged T144724: [Daily Uploads] Add parameters to url as Normal priority.
Sep 13 2018, 10:26 PM · Wiki-Loves-Monuments (2018), Patch-For-Review

Sep 12 2018

JeanFred claimed T144724: [Daily Uploads] Add parameters to url.
Sep 12 2018, 2:42 PM · Wiki-Loves-Monuments (2018), Patch-For-Review
JeanFred added a comment to T137881: Set-up Sentry for ErfgoedBot.

I have been thinking about how to go about that for a while now (took me quite a while too as I was confused by all the wrapping that pywikibot does on top of logging...)

Sep 12 2018, 10:56 AM · Wiki-Loves-Monuments
JeanFred added a comment to T97136: Phabricator integration for Sentry.

FYI, they recently revamped the Phabricator extension for Sentry (cf. https://github.com/getsentry/sentry-plugins/pull/373) − should make it to the next Sentry release (unscheduled yet).

Sep 12 2018, 10:51 AM · Patch-For-Review, Sentry

Sep 11 2018

JeanFred added a comment to T200339: Investigate gb-sct disappearing.

We tried running harvesting just on gb-sct, and it crashed again (so it’s not due to some weird timing linked to full harvest).

Sep 11 2018, 10:59 PM · Wiki-Loves-Monuments (2018), Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred added a comment to T200339: Investigate gb-sct disappearing.

We noticed a lot of warnings for missing prim keys.

Sep 11 2018, 10:34 PM · Wiki-Loves-Monuments (2018), Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred claimed T204036: populate_image_table job crashes with ImportError: No module named builtins.
Sep 11 2018, 11:52 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred added a comment to T204036: populate_image_table job crashes with ImportError: No module named builtins.

Oh, of course, this does not make use of the virtual environment >_>

Sep 11 2018, 11:09 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred added a comment to T204036: populate_image_table job crashes with ImportError: No module named builtins.

Can’t reproduce locally…

$ docker-compose run --rm bot python erfgoedbot/populate_image_table.py
Starting labs-tools-heritage_db_1 ... done
Working on all countrycodes
Found 96 countries with monument tracker templates to work on
Sep 11 2018, 11:07 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred created T204036: populate_image_table job crashes with ImportError: No module named builtins.
Sep 11 2018, 11:07 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred added a comment to T176982: ErfgoedBot categorize_images locks `monuments_all` table, preventing the atomic replace.

Been thinking about this. If we have diagnosed this properly, the issue is that categorize_images locks the table for its entire run. Indeed the code is:

Sep 11 2018, 10:26 AM · Wiki-Loves-Monuments-Database
JeanFred added a comment to T176982: ErfgoedBot categorize_images locks `monuments_all` table, preventing the atomic replace.

The workaround solution is now now working per T202281: no jstop command available in a GridEngine job

Sep 11 2018, 10:21 AM · Wiki-Loves-Monuments-Database
JeanFred added a comment to T203251: Allow report page tests to run offline.

I would have hoped the tests would run faster after this, but a time tox -e py27 still yields ~30s :-(

Sep 11 2018, 10:18 AM · Wiki-Loves-Monuments (2018), Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Database

Sep 10 2018

JeanFred added a comment to T202677: Help organisers repair broken coordinates.

I'm sure we had some other mechanism for finding and highlighting these but cannot find it.

Sep 10 2018, 12:11 PM · Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Sources

Sep 9 2018

JeanFred added a comment to T203428: Erfgoedbot categorisation statistics always indicate 0.

Confirmed in later categorisation job: https://commons.wikimedia.org/wiki/Special:Diff/319422336

Sep 9 2018, 10:46 PM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database

Sep 8 2018

JeanFred moved T203816: Compute (cumulative) count of 'new' uploaders per day from Backlog to A fazer on the Tool-wikiloves board.
Sep 8 2018, 9:25 AM · Wiki-Loves-Monuments (2018), Tool-wikiloves
JeanFred moved T203702: Allow to update some events with higher frequency from Backlog to Feito on the Tool-wikiloves board.
$ crontab -l
*/15 * * * * jsub -l release=trusty -mem 1000m -once -j y -o /data/project/wikiloves/logs/update-database.log -N update_database_high /data/project/wikiloves/wikiloves/bin/update_database.sh monuments2018 >> /data/project/wikiloves/logs/crontab.log
Sep 8 2018, 9:23 AM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred moved T203702: Allow to update some events with higher frequency from Backlog to Done - in September on the Wiki-Loves-Monuments (2018) board.
Sep 8 2018, 9:21 AM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred moved T203428: Erfgoedbot categorisation statistics always indicate 0 from Backlog to In-progress on the Wiki-Loves-Monuments (2018) board.
Sep 8 2018, 9:08 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred added a comment to T203816: Compute (cumulative) count of 'new' uploaders per day.

The numbers given for the UK at https://tools.wmflabs.org/wikiloves/monuments/2018/United%20Kingdom don't match the actual daily uploads which we categorise as they happen in Commons cats Category:WLM-UK 2018 unfiltered 09-xx where xx is the day of the month. You can see the numbers in those cats here: https://commons.wikimedia.org/wiki/Category:Images_from_Wiki_Loves_Monuments_2018_in_the_United_Kingdom.

I suspect the tool may be incorrectly working to UTC rather than the local midnight-to-midnight times.

Sep 8 2018, 9:05 AM · Wiki-Loves-Monuments (2018), Tool-wikiloves
JeanFred committed R1969:3f0dde38ae4e: Add precision that all times are UTC. (authored by JeanFred).
Add precision that all times are UTC.
Sep 8 2018, 8:30 AM

Sep 7 2018

JeanFred added a comment to T203816: Compute (cumulative) count of 'new' uploaders per day.

Ok, smth must be off, because it’s fairly unlikely that on https://tools.wmflabs.org/wikiloves/monuments/2017/Germany, 39 images could be uploaded on the first day by 0 joiners :p

Sep 7 2018, 10:52 PM · Wiki-Loves-Monuments (2018), Tool-wikiloves
JeanFred added a comment to T203816: Compute (cumulative) count of 'new' uploaders per day.

Daily data is now exposed at https://tools.wmflabs.org/wikiloves/monuments/2018/France

Sep 7 2018, 10:19 PM · Wiki-Loves-Monuments (2018), Tool-wikiloves
JeanFred committed R1969:c97a3d52ac04: Expose daily data on joiner count in the application (authored by JeanFred).
Expose daily data on joiner count in the application
Sep 7 2018, 9:14 PM
JeanFred committed R1969:b5b279933276: Enrich daily data with joiner count (authored by JeanFred).
Enrich daily data with joiner count
Sep 7 2018, 9:14 PM
JeanFred committed R1969:8c1b86420dd7: Extract method get_instance_name (authored by JeanFred).
Extract method get_instance_name
Sep 7 2018, 9:14 PM
JeanFred committed R1969:3a26a2faa433: Extract method get_edition_name (authored by JeanFred).
Extract method get_edition_name
Sep 7 2018, 9:14 PM
JeanFred committed R1969:d06c1e1d21b9: Extract method get_instance_users_data (authored by JeanFred).
Extract method get_instance_users_data
Sep 7 2018, 9:14 PM
JeanFred committed R1969:9cd7806a907a: Extract method get_edition_data (authored by JeanFred).
Extract method get_edition_data
Sep 7 2018, 9:14 PM
JeanFred committed R1969:0eede7822672: Extend test data for more meaningful tests (authored by JeanFred).
Extend test data for more meaningful tests
Sep 7 2018, 9:14 PM
JeanFred committed R1969:7f2be57e0cef: Rename method for clarity (authored by JeanFred).
Rename method for clarity
Sep 7 2018, 9:13 PM
JeanFred committed R1969:740bc47c47c3: Extract expected test results to TestGetDataMixin (authored by JeanFred).
Extract expected test results to TestGetDataMixin
Sep 7 2018, 6:33 PM
JeanFred committed R1969:3be329b1a129: Extract expected_timestamp_data to TestGetDataMixin (authored by JeanFred).
Extract expected_timestamp_data to TestGetDataMixin
Sep 7 2018, 6:22 PM
JeanFred created T203816: Compute (cumulative) count of 'new' uploaders per day.
Sep 7 2018, 4:58 PM · Wiki-Loves-Monuments (2018), Tool-wikiloves
JeanFred committed R1969:dcdcc6ebc6b0: Add category exception for United Arab Emirates (authored by JeanFred).
Add category exception for United Arab Emirates
Sep 7 2018, 3:38 PM

Sep 6 2018

JeanFred added a comment to T175906: Add Shell linting to heritage repo.

Yeah, I did not find how to integrate Shellcheck but bashate is good enough for now :) Thanks!

Sep 6 2018, 7:32 PM · Patch-For-Review, Continuous-Integration-Config, Wiki-Loves-Monuments-Database
JeanFred committed R1969:407e2a94fa99: Update source of the tool in the footer (authored by JeanFred).
Update source of the tool in the footer
Sep 6 2018, 7:18 PM
JeanFred committed R1969:5cf595313103: Pass through arguments in Shell script `update_monuments` (authored by JeanFred).
Pass through arguments in Shell script `update_monuments`
Sep 6 2018, 7:09 PM
JeanFred committed R1969:f75bc8531107: Allow to update database for a given list of events (authored by JeanFred).
Allow to update database for a given list of events
Sep 6 2018, 6:57 PM
JeanFred committed R1969:353e948d11b1: Allow to update database for a given list of events (authored by JeanFred).
Allow to update database for a given list of events
Sep 6 2018, 6:53 PM
JeanFred created T203702: Allow to update some events with higher frequency.
Sep 6 2018, 6:42 PM · Tool-wikiloves, Wiki-Loves-Monuments (2018)
JeanFred committed R1969:1df570ced581: Add unit tests for update_event_data (authored by JeanFred).
Add unit tests for update_event_data
Sep 6 2018, 3:52 PM
JeanFred committed R1969:9a572c87a8c4: Extract method write_database_as_json (authored by JeanFred).
Extract method write_database_as_json
Sep 6 2018, 3:52 PM
JeanFred committed R1969:c7d304bbc53e: Extract method update_event_data from main() (authored by JeanFred).
Extract method update_event_data from main()
Sep 6 2018, 3:52 PM
JeanFred committed R1969:2f06f964b0e4: Extract method update_event_data from main() (authored by JeanFred).
Extract method update_event_data from main()
Sep 6 2018, 2:52 PM
JeanFred committed R1969:b82eeb9a3c04: Ensure all tox environments use Python 2.7 (authored by JeanFred).
Ensure all tox environments use Python 2.7
Sep 6 2018, 2:52 PM
JeanFred committed R1969:3d327cc08ea7: Remove unused imports from images.py (authored by JeanFred).
Remove unused imports from images.py
Sep 6 2018, 2:52 PM
JeanFred committed R1969:720ba09e4523: Fix Jsonlint bash command in tox environment (authored by JeanFred).
Fix Jsonlint bash command in tox environment
Sep 6 2018, 2:52 PM
JeanFred committed R1969:686c39b54800: Whitelist bash external in tox file (authored by JeanFred).
Whitelist bash external in tox file
Sep 6 2018, 2:34 PM
JeanFred committed R1969:3e8252762f5a: Use Pipenv to manage dev requirements (authored by JeanFred).
Use Pipenv to manage dev requirements
Sep 6 2018, 2:26 PM
JeanFred committed R1969:87ae7f0e50cd: Add unit tests for configuration parsing (authored by JeanFred).
Add unit tests for configuration parsing
Sep 6 2018, 2:26 PM
JeanFred added a comment to T203428: Erfgoedbot categorisation statistics always indicate 0.

Is the cause as simple as forgetting a return statement on categorizeImage() when categorisation is successful?

Sep 6 2018, 8:22 AM · Patch-For-Review, Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database