Page MenuHomePhabricator

JeffreyWang (Jeffrey Wang)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 3 2020, 12:08 AM (46 w, 2 d)
Availability
Available
LDAP User
JeffreyWang
MediaWiki User
Unknown

Recent Activity

Fri, Oct 8

JeffreyWang added a comment to T278406: "Request account" Link.

Would it perhaps be better to say to upgrade to the latest version of the branch? REL1_35 users should stay on REL1_35, and this works just fine on the latest version of the REL1_35 branch.

Fri, Oct 8, 2:02 AM · Documentation, MediaWiki-extensions-ConfirmAccount

Jul 14 2021

JeffreyWang added a comment to T286368: Including scary transclusion contents in search results in CirrusSearch.

Huh, I have no idea why this didn't work before (job queue was empty) but I guess that resolves it. Very surprised, as I haven't changed anything since then, and I guess now it works. Maybe my search query was an edge case, no idea, can't remember it now. I'll try my best to be more descriptive in the future with the repro steps, appreciate your diligent help!

Jul 14 2021, 1:45 PM · Discovery-Search, CirrusSearch
JeffreyWang updated the task description for T286368: Including scary transclusion contents in search results in CirrusSearch.
Jul 14 2021, 1:06 PM · Discovery-Search, CirrusSearch
JeffreyWang added a comment to T286368: Including scary transclusion contents in search results in CirrusSearch.

@dcausse Hi, thanks for looking into this! I should've been more clear with my reproduction steps, and I'll update these. I can confirm that both are enabled, otherwise I think it would be obvious that the page with the transclusion doesn't render properly. Did you try with a template or with a regular wiki page like my example?

Jul 14 2021, 1:05 PM · Discovery-Search, CirrusSearch

Jul 9 2021

JeffreyWang updated the task description for T286368: Including scary transclusion contents in search results in CirrusSearch.
Jul 9 2021, 5:58 PM · Discovery-Search, CirrusSearch
JeffreyWang updated the task description for T286368: Including scary transclusion contents in search results in CirrusSearch.
Jul 9 2021, 5:58 PM · Discovery-Search, CirrusSearch
JeffreyWang added a comment to T286368: Including scary transclusion contents in search results in CirrusSearch.

Sorry, I read too fast. I'll update the description with the template.

Jul 9 2021, 5:54 PM · Discovery-Search, CirrusSearch
JeffreyWang created T286368: Including scary transclusion contents in search results in CirrusSearch.
Jul 9 2021, 8:09 AM · Discovery-Search, CirrusSearch

Jul 3 2021

JeffreyWang added a comment to T281977: Reconsidering of eligibility criteria for technical contributions in elections.

@KTC That's all I needed to hear. I would've appreciated if the comment were addressed back in May rather than now when the new criteria have already been promulgated.

Jul 3 2021, 6:35 PM · User-brennen, Elections, User-Jayprakash12345
JeffreyWang added a comment to T281977: Reconsidering of eligibility criteria for technical contributions in elections.

@Carlojoseph14 Hello, thanks for the response. Please see my comment at https://meta.wikimedia.org/wiki/Talk:Wikimedia_Foundation_elections/2021#Reconsideration_of_eligibility_criteria_for_technical_contributions_in_election that I made on May 7.

Jul 3 2021, 5:06 AM · User-brennen, Elections, User-Jayprakash12345

Jul 2 2021

JeffreyWang added a comment to T194746: Bundle StopForumSpam extension with the next MediaWiki release.

What kind of data will be shared with StopForumSpam if someone were to install it? Would it send PII?

Jul 2 2021, 6:31 PM · MW-1.38-release, MediaWiki-extensions-StopForumSpam
JeffreyWang added a comment to T281977: Reconsidering of eligibility criteria for technical contributions in elections.

@KCVelaga, under these new rules, they still would not satisfy cases like me where I have contributed several MediaWiki extensions but still do not meet any of the requirements. I am disappointed that my comment was overlooked and nobody had at least followed up with me, explaining why my proposal might've been too broad.

Jul 2 2021, 3:40 PM · User-brennen, Elections, User-Jayprakash12345

Jun 29 2021

JeffreyWang added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

Thank you for clarifying what I meant to say, but I would like for someone to actually confirm this problem has been fixed on MediaWiki. I cannot do so because I am still not able to get CirrusSearch working on AWS Elasticsearch.

Jun 29 2021, 7:21 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, Discovery-Search, CirrusSearch
JeffreyWang added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

Is this fixed now, since 6.8.1 has been released?

Jun 29 2021, 3:09 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, Discovery-Search, CirrusSearch

Jun 21 2021

JeffreyWang added a comment to T220719: Standardize return type hint spacing.

Am I eligible to vote?

Jun 21 2021, 7:11 AM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer

Jun 17 2021

JeffreyWang added a comment to T285107: ConfirmAccount does not show "Request account" link in top-right corner when read-only in MW 1.35.

Actually, this was already fixed. Was looking at an out-of-date version of the code, my apologies. https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/blob/master/includes/frontend/ConfirmAccountUI.hooks.php#L31

Jun 17 2021, 9:03 PM · MediaWiki-extensions-ConfirmAccount
JeffreyWang closed T278406: "Request account" Link as Resolved.
Jun 17 2021, 6:33 PM · Documentation, MediaWiki-extensions-ConfirmAccount
JeffreyWang added a comment to T278406: "Request account" Link.

Ok, I've removed it https://www.mediawiki.org/w/index.php?title=Extension%3AConfirmAccount&type=revision&diff=4645599

Jun 17 2021, 6:33 PM · Documentation, MediaWiki-extensions-ConfirmAccount
JeffreyWang updated the task description for T285107: ConfirmAccount does not show "Request account" link in top-right corner when read-only in MW 1.35.
Jun 17 2021, 6:30 PM · MediaWiki-extensions-ConfirmAccount
JeffreyWang created T285107: ConfirmAccount does not show "Request account" link in top-right corner when read-only in MW 1.35.
Jun 17 2021, 6:29 PM · MediaWiki-extensions-ConfirmAccount
JeffreyWang added a comment to T278406: "Request account" Link.

That's correct. It can be removed.

Jun 17 2021, 6:25 PM · Documentation, MediaWiki-extensions-ConfirmAccount

Jun 10 2021

JeffreyWang added a comment to T267106: PHP fatal error while searching index: Declaration of Elasticsearch\Endpoints\Indices\Exists::getParamWhitelist() must be compatible with Elasticsearch\Endpoints\AbstractEndpoint::getParamWhitelist(): .

This error might occur on 1.35, see T276854 for more details

Jun 10 2021, 12:40 AM · Discovery-Search, CirrusSearch, Elasticsearch
JeffreyWang added a comment to T267106: PHP fatal error while searching index: Declaration of Elasticsearch\Endpoints\Indices\Exists::getParamWhitelist() must be compatible with Elasticsearch\Endpoints\AbstractEndpoint::getParamWhitelist(): .
Jun 10 2021, 12:39 AM · Discovery-Search, CirrusSearch, Elasticsearch

May 7 2021

JeffreyWang added a comment to T277987: Address Voice and Tone issues in MediaWiki Core.

Sorry if this is the wrong venue to voice this: so, for $wgWhitelistRead, what will be the phase-out process look like? Is there a proposed name for it like $wgAllowlistRead? And I would assume $wgWhitelistRead would be deprecated for a few versions of MediaWiki too. Same question goes for the rest of the LocalSettings.php config options which aren't simple internal core fixes.

May 7 2021, 3:57 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MediaWiki-General, Voice & Tone

Apr 27 2021

JeffreyWang added a comment to T64469: MultimediaViewer should work (or at least fail more gracefully) on wikis where the images have no CORS headers.

One of the problems is that the request is sending withCredentials marked true in the actual XHR. Is there a way to disable it?

Apr 27 2021, 8:45 PM · Multimedia, MediaViewer
JeffreyWang added a comment to T64469: MultimediaViewer should work (or at least fail more gracefully) on wikis where the images have no CORS headers.

This issue still hasn't been resolved. The fallback to img tag is a very reasonable request.

Apr 27 2021, 8:23 PM · Multimedia, MediaViewer
JeffreyWang added a comment to T136207: MultimediaViewer failed to load images protected by img_auth.php.

This remains an issue today. Is there any progress made on this?

Apr 27 2021, 8:22 PM · Multimedia, patch-welcome, MediaViewer

Feb 26 2021

JeffreyWang added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

Since this is a priority for MyWikis, I have written the first (very temporary) patch fixes for hCaptcha only (since it is the most effective captcha currently publicly available). It's not pretty but it'll do the job for anyone who needs to secure their wiki immediately.

Feb 26 2021, 4:00 AM · MediaWiki-extensions-ConfirmAccount
JeffreyWang added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

Looks like there's no code in Special:RequestAccount to even handle the checking of captchas. Furthermore ConfirmAccount doesn't expose any hooks, so it's difficult for ConfirmEdit to extend ConfirmAccount. I'm working on a temporary stopgap solution for hCaptcha since that is our priority need right now at MyWikis, but hope this is some useful food for thought.

Feb 26 2021, 1:32 AM · MediaWiki-extensions-ConfirmAccount

Feb 25 2021

JeffreyWang added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

I understand this has been a bug for 4 years. It's kind of alarming because this makes wikis still susceptible to spambot attacks that target Special:RequestAccount. Some spambots on our wikis have already started to take advantage of this. Before they do, this needs to be fixed or lots of wikis relying on this extension will fall prey to spambots. I understand that humans can filter through the spam accounts, but this extension doesn't offer a mass-reject tool. Furthermore, for those using SES for email on their wikis, this can drive up bounce rates to a dangerous point where they might risk being booted off of SES. Has any other work been done on this so far?

Feb 25 2021, 5:56 PM · MediaWiki-extensions-ConfirmAccount

Jan 10 2021

JeffreyWang added a comment to T269967: TextExtracts returns "..." on some pages but not others.

Interesting, thanks @Porplemontage for the insight. Notwithstanding the confusing implementation of TextExtracts, I removed the line exintro: true from Popups/src/gateway/mediawiki.js and since I do not know how to compile the frontend JS into the resources/dist/index.js file, I manually removed it from there and it fixed this issue. Now the only issue is it won't stop at the intro (like in this API call it includes the headers and stuff: https://learn.winona.edu/w/api.php?action=query&format=json&prop=info%7Cextracts%7Cpageimages%7Crevisions%7Cinfo&formatversion=2&redirects=true&exchars=525&explaintext=true&piprop=thumbnail&pithumbsize=320&pilicense=any&rvprop=timestamp&inprop=url&titles=Join_a_Zoom_meeting_as_a_participant&smaxage=300&maxage=300&uselang=content), but that's better than nondeterministic "..." and should satisfy our client enough at this point. Hopefully someone can do some more detailed debugging and see why this is the case.

Jan 10 2021, 5:00 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), TextExtracts

Dec 15 2020

JeffreyWang added a comment to T270013: Keybindings for strikethrough and computer code collide with system's screenshot functionality on macOS.

Thank you @ppelberg!

Dec 15 2020, 7:33 PM · VisualEditor-EditingTools, VisualEditor, Growth-Team, StructuredDiscussions

Dec 14 2020

JeffreyWang added a project to T270013: Keybindings for strikethrough and computer code collide with system's screenshot functionality on macOS: VisualEditor-EditingTools.

Adding appropriate subproject.

Dec 14 2020, 10:37 PM · VisualEditor-EditingTools, VisualEditor, Growth-Team, StructuredDiscussions

Dec 13 2020

JeffreyWang added a project to T270013: Keybindings for strikethrough and computer code collide with system's screenshot functionality on macOS: VisualEditor.

Upon further inspection, this seems to be an aspect of StructuredDiscussions taken from VisualEditor. Adding VisualEditor to this bug.

Dec 13 2020, 9:41 PM · VisualEditor-EditingTools, VisualEditor, Growth-Team, StructuredDiscussions
JeffreyWang created T270013: Keybindings for strikethrough and computer code collide with system's screenshot functionality on macOS.
Dec 13 2020, 2:03 AM · VisualEditor-EditingTools, VisualEditor, Growth-Team, StructuredDiscussions

Dec 11 2020

JeffreyWang created T269967: TextExtracts returns "..." on some pages but not others.
Dec 11 2020, 8:42 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), TextExtracts