Page MenuHomePhabricator

JeroenDeDauw (Jeroen De Dauw)
~=[,,_,,]:3

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:56 PM (237 w, 1 d)
Availability
Available
IRC Nick
JeroenDeDauw
LDAP User
Unknown
MediaWiki User
Jeroen De Dauw [ Global Accounts ]

Opinions posted here are my own, unless stated otherwise

Recent Activity

Yesterday

JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

I think something along these lines makes sense, please comment here: https://github.com/wmde/doctrine-term-store/pull/8/files

Wed, Apr 24, 12:36 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T221703: add a job to wikibase to invoke clean up logic.

I am also not happy with this task, as again it specifies a solution, not an outcome. I much rather have "avoid expensive cleanup during the request to the degree this is possible" as acceptance criteria in the story.

Wed, Apr 24, 12:20 AM · Wikidata, Wikidata wb_terms Trailblazing

Tue, Apr 23

JeroenDeDauw added a comment to T221699: Introduce appropriate abstraction for clean up invocation in wikibase-term-store.

We talked about this (two weeks ago?) and concluded there likely is no need to introduce anything in wikibase/term-store. I'm pretty annoyed with this task now since it specifies a solution rather than a problem that needs to be solved.

Tue, Apr 23, 11:14 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220210: Create a script to generate lots of Items/Properties with lots of Terms.

WikibaseImport contains a limited number of items and properties

Tue, Apr 23, 10:24 PM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

https://www.mediawiki.org/wiki/Manual:Job_queue

Tue, Apr 23, 8:10 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

This means we have to go with the "smart update using diff" approach, since otherwise we do not know which terms have been removed. Not clear to me it will make sense to do the cleanup in post-request, we might end up only delaying a few % of the cost. I suggest to first make it work on write and then see if we can gain a lot by moving stuff to a job.

Tue, Apr 23, 2:27 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

I'm calling it a day. Current guess is that the tables are not created right because we are not using this setting in mediawiki/doctrine-connection.

Tue, Apr 23, 1:03 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

There is some issues though. Some properties result in an error, and on re-run many of them do.

Tue, Apr 23, 12:53 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/501992/ the rebuilding works using the Doctrine Term Store.

Tue, Apr 23, 12:39 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing

Mon, Apr 22

JeroenDeDauw moved T221568: Improve MW connection access from Backlog to Stalled on the Wikidata wb_terms Trailblazing board.
Mon, Apr 22, 11:13 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T221568: Improve MW connection access.

@alaa_wmde what is the status of this?

Mon, Apr 22, 11:13 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw created T221568: Improve MW connection access.
Mon, Apr 22, 11:13 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

AFAIK the script we currently have (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/505670) is sufficient for this task. It has continuation based on page id rather than property id. I figure that won't fly for items but likely is OK for properties. Do we need continuation at all for properties?

Mon, Apr 22, 11:07 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219894: Create maintenance script for migrating property terms to new schema from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Mon, Apr 22, 10:58 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220210: Create a script to generate lots of Items/Properties with lots of Terms from In Review to In Progress on the Wikidata wb_terms Trailblazing board.
Mon, Apr 22, 10:58 PM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220210: Create a script to generate lots of Items/Properties with lots of Terms from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Mon, Apr 22, 10:58 PM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

https://github.com/wmde/WikibaseDataModelServices/pull/216

Mon, Apr 22, 9:14 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T221564: Create maintenance script for populating new item term persistence.

We already did some of this while working on the property script: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/505679

Mon, Apr 22, 8:44 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw created T221564: Create maintenance script for populating new item term persistence.
Mon, Apr 22, 8:43 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220210: Create a script to generate lots of Items/Properties with lots of Terms.

Mon, Apr 22, 8:32 PM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing

Sun, Apr 21

JeroenDeDauw added a comment to T220210: Create a script to generate lots of Items/Properties with lots of Terms.

Yesterday while thinking about design stuff I randomly realized that we might not need a script like this. Can't we just use https://github.com/Wikidata/WikibaseImport to important a bunch of real entities? If that is too slow, then perhaps we can use https://github.com/JeroenDeDauw/Replicator to import JSON dumps.

Sun, Apr 21, 9:26 PM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing

Tue, Apr 16

JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

https://github.com/wmde/WikibaseDataModelServices/pull/214

Tue, Apr 16, 3:42 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing

Sun, Apr 14

JeroenDeDauw updated the task description for T219894: Create maintenance script for migrating property terms to new schema.
Sun, Apr 14, 5:39 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T219894: Create maintenance script for migrating property terms to new schema up for grabs.
Sun, Apr 14, 5:39 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing

Fri, Apr 12

JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/503331

Fri, Apr 12, 12:26 PM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219894: Create maintenance script for migrating property terms to new schema.

Don't think it is a good idea to modify the existing RebuildTermSqlIndex code. We can just create a new script. The existing code has things in there we don't need, and still having the wb_terms specific thing around might be useful to various users.

Fri, Apr 12, 11:22 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw claimed T219894: Create maintenance script for migrating property terms to new schema.
Fri, Apr 12, 11:20 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220230: Tailor a migration plan.

@alaa_wmde is this done?

Fri, Apr 12, 11:20 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219296: Update TermSqlStore to comply with EntityTermStoreWriter interface as Resolved.
Fri, Apr 12, 11:19 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-Ladsgroup, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219296: Update TermSqlStore to comply with EntityTermStoreWriter interface, a subtask of T219894: Create maintenance script for migrating property terms to new schema, as Resolved.
Fri, Apr 12, 11:19 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220157: Update schema in wikibase-term-store to match original schema as Resolved.
Fri, Apr 12, 11:18 AM · Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220597: Release new term store interface and add it to MW vendor as Resolved.
Fri, Apr 12, 11:18 AM · Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection, a subtask of T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection , as Resolved.
Fri, Apr 12, 11:18 AM · Wikidata, Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection as Resolved.
Fri, Apr 12, 11:18 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219295: Create service for writing property terms as Resolved.
Fri, Apr 12, 11:17 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219295: Create service for writing property terms, a subtask of T219121: [Checkpoint 2] Refactor Write & Migration code for Properties, as Resolved.
Fri, Apr 12, 11:17 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219295: Create service for writing property terms from Ready to go [prioritized] to Done on the Wikidata wb_terms Trailblazing board.
Fri, Apr 12, 11:17 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a parent task for T220150: [Story] Clean up unused records: T219121: [Checkpoint 2] Refactor Write & Migration code for Properties.
Fri, Apr 12, 11:17 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a subtask for T219121: [Checkpoint 2] Refactor Write & Migration code for Properties: T220150: [Story] Clean up unused records.
Fri, Apr 12, 11:17 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw removed a subtask for T219295: Create service for writing property terms: T220150: [Story] Clean up unused records.
Fri, Apr 12, 11:16 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw removed a parent task for T220150: [Story] Clean up unused records: T219295: Create service for writing property terms.
Fri, Apr 12, 11:16 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219894: Create maintenance script for migrating property terms to new schema from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Fri, Apr 12, 11:15 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219296: Update TermSqlStore to comply with EntityTermStoreWriter interface from In Review to Done on the Wikidata wb_terms Trailblazing board.
Fri, Apr 12, 11:07 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-Ladsgroup, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection from In Review to Done on the Wikidata wb_terms Trailblazing board.
Fri, Apr 12, 11:06 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219297: Adjust current write logic to write property terms to new schema from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Fri, Apr 12, 11:05 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata, Wikidata wb_terms Trailblazing

Thu, Apr 11

JeroenDeDauw committed rEWLE19cc6c205bbd: Use createMock (authored by JeroenDeDauw).
Use createMock
Thu, Apr 11, 7:39 AM

Wed, Apr 10

JeroenDeDauw moved T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Wed, Apr 10, 11:55 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219297: Adjust current write logic to write property terms to new schema from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Wed, Apr 10, 11:55 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219297: Adjust current write logic to write property terms to new schema.

First step: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/502781

Wed, Apr 10, 11:55 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated subscribers of T220597: Release new term store interface and add it to MW vendor.

@alaa_wmde @Ladsgroup please to do the review. I can do the MW vendor bit but can't do the review myself of course.

Wed, Apr 10, 11:25 AM · Wikidata wb_terms Trailblazing
JeroenDeDauw created T220597: Release new term store interface and add it to MW vendor.
Wed, Apr 10, 11:22 AM · Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T219894: Create maintenance script for migrating property terms to new schema.
Wed, Apr 10, 7:30 AM · Wikidata, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw committed rEWLE6002c7509c79: Use createMock (authored by JeroenDeDauw).
Use createMock
Wed, Apr 10, 7:28 AM
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

"delete everything" means deleting all terms for an item/property in the item/property_terms table, rather than just those that actually need to be removed.

Wed, Apr 10, 6:31 AM · Wikidata, Wikidata wb_terms Trailblazing

Tue, Apr 9

JeroenDeDauw moved T219144: Register schema schanges with MW update mechanism from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 10:08 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219295: Create service for writing property terms from Stalled to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 10:08 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220150: [Story] Clean up unused records from Stalled to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 10:07 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220169: Optimize term updating as Declined.

We won't be doing this as per https://phabricator.wikimedia.org/T220150

Tue, Apr 9, 10:07 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T220169: Optimize term updating, a subtask of T219295: Create service for writing property terms, as Declined.
Tue, Apr 9, 10:07 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

We figured we go with delete and insert everything. Task description updated to reflect this.

Tue, Apr 9, 10:06 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T220150: [Story] Clean up unused records from Decide on initial cleanup strategy to Clean up unused records.
Tue, Apr 9, 10:06 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219295: Create service for writing property terms from In Progress to Stalled on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 2:16 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220169: Optimize term updating from Ready to go [prioritized] to Stalled on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 2:16 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220210: Create a script to generate lots of Items/Properties with lots of Terms.

While not the best fro a design or flexibility perspective, I suspect the most pragmatic approach here is to just create a MW maintenance script in Wikibase (Repo?).

Tue, Apr 9, 1:59 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220210: Create a script to generate lots of Items/Properties with lots of Terms.

@alaa_wmde are you working on this? If so, please link the stuff you have so far.

Tue, Apr 9, 1:57 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220150: [Story] Clean up unused records from In Progress to Stalled on the Wikidata wb_terms Trailblazing board.
Tue, Apr 9, 1:55 AM · Wikidata, Wikidata wb_terms Trailblazing

Mon, Apr 8

JeroenDeDauw added a watcher for Wikidata wb_terms Trailblazing: JeroenDeDauw.
Mon, Apr 8, 10:36 AM

Sun, Apr 7

JeroenDeDauw added a comment to T219144: Register schema schanges with MW update mechanism.

Also part of this: https://github.com/wmde/wikibase-term-store/pull/7

Sun, Apr 7, 9:21 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219144: Register schema schanges with MW update mechanism.

First step https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/501992

Sun, Apr 7, 8:07 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219144: Register schema schanges with MW update mechanism from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Sun, Apr 7, 8:06 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

Setting this up turned out to be easier than expected. The library has running tests on TravisCI and can transform Mysqli and SQLite (PDO) based MW Database objects.

Sun, Apr 7, 3:27 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Sun, Apr 7, 3:22 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

Started at https://github.com/wmde/mediawiki-doctrine-connection

Sun, Apr 7, 1:31 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw claimed T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.
Sun, Apr 7, 1:25 AM · Patch-For-Review, Wikidata wb_terms Trailblazing

Sat, Apr 6

JeroenDeDauw updated the task description for T219805: Investigate Doctrine DBAL usage possibility.
Sat, Apr 6, 8:59 AM · Wikidata, TechCom, Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

The updating optimization ticket is relevant for this cleanup. We now have two main approaches:

Sat, Apr 6, 8:28 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220169: Optimize term updating.

I came to a similar conclusion after trying to write some code without looking at this ticket first :) It might still be worth it to do the diff because it helps https://phabricator.wikimedia.org/T220150. I'll comment more there.

Sat, Apr 6, 8:16 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

@alaa_wmde seems to have a different idea of how the maintenance script would work then I do.

Sat, Apr 6, 8:05 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T219805: Investigate Doctrine DBAL usage possibility up for grabs.
Sat, Apr 6, 7:57 AM · Wikidata, TechCom, Patch-For-Review, Wikidata wb_terms Trailblazing

Fri, Apr 5

JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

After a bunch of consideration I moderately prefer "2. Create dedicated library". That approach does not clutter anything and it gives us a building block we can use in other projects, which I think is worth the small initial investment.

Fri, Apr 5, 6:49 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

So this is semi-blocked on figuring out what we do for labs, since that impacts the reasons for immediate cleanup.

Fri, Apr 5, 5:53 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220169: Optimize term updating from Backlog to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
Fri, Apr 5, 5:50 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Fri, Apr 5, 5:49 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Fri, Apr 5, 5:49 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Fri, Apr 5, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Fri, Apr 5, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

I was wondering about how much extra complexity the post request approach (4) would bring. In particular, which info do we need to give to the job. Giving the property id is not sufficient. You could give the ids of the text records and then in the job check if they are still unused and do the same for the higher level records that point to those text records. Thing is, if you already need to find the unused records in the request, then you can just as well delete them right away. Either way you have a performance penalty. So I think the simpler approach (immediate cleanup (3)) makes more sense as a starting point. Does that make sense to you?

Fri, Apr 5, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T219295: Create service for writing property terms up for grabs.
Fri, Apr 5, 5:23 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T220169: Optimize term updating up for grabs.
Fri, Apr 5, 5:22 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw created T220169: Optimize term updating.
Fri, Apr 5, 5:22 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219295: Create service for writing property terms.

I renamed this back to an implementation agnostic task, since else we don't have anything to track the completion of the service implementation, and a parent task for more detailed things such as the cleanup logic.

Fri, Apr 5, 5:19 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .

huh. Why is the DBAL connection part of this checkpoint and not checkpoint 2? I was expecting it to be part of checkpoint 2

Fri, Apr 5, 5:17 AM · Wikidata, Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T219297: Adjust current write logic to write property terms to new schema from Adjust current write logic to write proerty terms to new schema to Adjust current write logic to write property terms to new schema.
Fri, Apr 5, 5:15 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a subtask for T219295: Create service for writing property terms: T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.
Fri, Apr 5, 5:13 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a parent task for T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection: T219295: Create service for writing property terms.
Fri, Apr 5, 5:13 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219295: Create service for writing property terms from Stalled to In Progress on the Wikidata wb_terms Trailblazing board.
Fri, Apr 5, 5:12 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T219295: Create service for writing property terms from [MW DBAL] Implement the new interface for writing property terms to Create service for writing property terms.
Fri, Apr 5, 5:12 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219294: Create interface for writing and deleting entity terms as Resolved.
Fri, Apr 5, 5:10 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Ladsgroup, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219294: Create interface for writing and deleting entity terms, a subtask of T219121: [Checkpoint 2] Refactor Write & Migration code for Properties, as Resolved.
Fri, Apr 5, 5:09 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

Wikibase Client also uses the TermIndex stuff, so I'm afraid we can't just put this into Wikibase Repository. Some options:

Fri, Apr 5, 5:07 AM · Patch-For-Review, Wikidata wb_terms Trailblazing