The initial pass over the structure is done. Having a single mostly-sane UC is almost done. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/472159 and dependent commits. After that the tests will also need to be reorganized. I do not need this ticket to keep track of that, so it can be closed if you want.

Thu, Nov 22, 1:20 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Lexicographical data

Mon, Nov 19

JeroenDeDauw committed rEWLEec08a9ce89cd: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).

Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector

Mon, Nov 19, 11:31 PM

JeroenDeDauw committed rEWLEf1b1cba08668: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).

Move last trace of $isBot out of MergeLexeme interactor

Mon, Nov 19, 11:31 PM

Nov 9 2018

JeroenDeDauw added a comment to T204066: Make Lexemes appear in global usage of Commons files.

I made two commits simplifying the involved code in preparation of implementing the behavior change:

Nov 9 2018, 9:23 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Lexicographical data

Nov 7 2018

JeroenDeDauw committed rEWLEfbaabb0b60bf: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).

Create request model for MergeLexemesInteractor

Nov 7 2018, 4:18 PM

JeroenDeDauw committed rEWLE18261379bf84: Disable UnusedUse rule (authored by JeroenDeDauw).

Disable UnusedUse rule

Nov 7 2018, 4:14 PM

JeroenDeDauw committed rEWLEb120889a47df: Disable UnusedUse rule (authored by JeroenDeDauw).

Disable UnusedUse rule

Nov 7 2018, 4:14 PM

JeroenDeDauw committed rEWLE940e3072536e: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).

Create request model for MergeLexemesInteractor

Nov 7 2018, 3:57 PM

JeroenDeDauw committed rEWLE38ecffd404d1: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).

Create request model for MergeLexemesInteractor

Nov 7 2018, 3:49 PM

JeroenDeDauw committed rEWLE7dc97fa8f85e: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).

Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector

Nov 7 2018, 3:49 PM

JeroenDeDauw committed rEWLE332d59082de8: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).

Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector

Nov 7 2018, 3:29 PM

JeroenDeDauw committed rEWLE93c6346161fa: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).

Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector

Nov 7 2018, 3:29 PM

JeroenDeDauw committed rEWLEe20976b63230: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).

Move last trace of $isBot out of MergeLexeme interactor

Nov 7 2018, 3:29 PM

JeroenDeDauw committed rEWLEccfed96fb94f: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).

Move last trace of $isBot out of MergeLexeme interactor

Nov 7 2018, 3:07 PM

JeroenDeDauw committed rEWLE23eac5f79ef9: Specify compat with DM 9.x (authored by JeroenDeDauw).

Specify compat with DM 9.x

Nov 7 2018, 2:29 PM

Nov 6 2018

JeroenDeDauw committed rEWLEfdc418af0a93: Remove accidental complexity (authored by JeroenDeDauw).

Remove accidental complexity

Nov 6 2018, 9:10 PM

JeroenDeDauw committed rEWLE7be46466f453: Remove accidental complexity (authored by JeroenDeDauw).

Remove accidental complexity

Nov 6 2018, 8:45 PM

JeroenDeDauw committed rEWLEe68454f2e120: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).

Reduce complexity of service construction in ChangeOpLexicalCategoryTest

Nov 6 2018, 8:24 PM

JeroenDeDauw committed rEWLEc0a653d263b5: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).

Reduce complexity of service construction in ChangeOpLexicalCategoryTest

Nov 6 2018, 8:24 PM

Nov 5 2018

JeroenDeDauw committed rEWLE504341d223cb: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).

Reduce complexity of service construction in ChangeOpLexicalCategoryTest

Nov 5 2018, 11:42 PM

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLE569903f8b43c: Merge "Remove dead method" (authored by JeroenDeDauw).

Merge "Remove dead method"

Nov 5 2018, 11:42 PM

JeroenDeDauw committed rEWLE8866aad5c71d: Rename WikibaseLexemeServices.php::newInstance -> newTestInstance (authored by JeroenDeDauw).

Rename WikibaseLexemeServices.php::newInstance -> newTestInstance

Nov 5 2018, 7:28 PM

JeroenDeDauw committed rEWLE74da61458daf: Remove dead method (authored by JeroenDeDauw).

Remove dead method

Nov 5 2018, 7:28 PM

JeroenDeDauw committed rEWLE97c84013b71f: Remove dead method (authored by JeroenDeDauw).

Remove dead method

Nov 5 2018, 3:45 PM

JeroenDeDauw committed rEWLEcf4b2f1429dc: Rename method (authored by JeroenDeDauw).

Rename method

Nov 5 2018, 3:45 PM

JeroenDeDauw committed rEWLE3be4ac6414f0: Explicitly require isBot info when constructing global WikibaseLexemeServices (authored by JeroenDeDauw).

Explicitly require isBot info when constructing global WikibaseLexemeServices

Nov 5 2018, 3:45 PM

JeroenDeDauw committed rEWLE01c4472c6e83: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).

Reduce complexity of service construction in ChangeOpLexicalCategoryTest

Nov 5 2018, 3:31 PM

JeroenDeDauw committed rEWLEa38195f2fdd7: Move ChangeOp Deserialization stuff into Presentation/ (authored by JeroenDeDauw).

Move ChangeOp Deserialization stuff into Presentation/

Nov 5 2018, 3:11 PM

JeroenDeDauw committed rEWLEeb5bb69b4c91: Prevent modification of stored Lexeme in FakeLexemeRepository (authored by JeroenDeDauw).

Prevent modification of stored Lexeme in FakeLexemeRepository

Nov 5 2018, 2:21 PM

JeroenDeDauw committed rEWLE15015057dee7: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).

Break EntityRevisionLookup out of merge interactor

Nov 5 2018, 2:21 PM

JeroenDeDauw committed rEWLE80fe0ca04299: Move LexemeRepository construction out of the merge interactor (authored by JeroenDeDauw).

Move LexemeRepository construction out of the merge interactor

Nov 5 2018, 2:21 PM

JeroenDeDauw committed rEWLE972b8f459446: Store isBot state in global factory (authored by JeroenDeDauw).

Store isBot state in global factory

Nov 5 2018, 2:21 PM

JeroenDeDauw committed rEWLEe6d0806f4147: Move interactor construction into normal function (authored by JeroenDeDauw).

Move interactor construction into normal function

Nov 5 2018, 2:21 PM

JeroenDeDauw committed rEWLEea875df2244b: Split interactor construction code (authored by JeroenDeDauw).

Split interactor construction code

Nov 5 2018, 2:21 PM

Nov 1 2018

JeroenDeDauw closed T208534: Outdated version of CS cause failures on Gerrit as Resolved.

Already fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/471046

Nov 1 2018, 7:11 PM · Wikidata, Wikibase-Quality-Constraints

JeroenDeDauw renamed T208534: Outdated version of CS cause failures on Gerrit from Outdated version of CS used on Gerrit to Outdated version of CS cause failures on Gerrit.

Nov 1 2018, 7:06 PM · Wikidata, Wikibase-Quality-Constraints

JeroenDeDauw created T208534: Outdated version of CS cause failures on Gerrit.

Nov 1 2018, 7:06 PM · Wikidata, Wikibase-Quality-Constraints

JeroenDeDauw added a comment to T206325: Use wikibase/data-model 9.0 everywhere.

Release PR: https://github.com/wmde/WikibaseDataModel/pull/801

Nov 1 2018, 2:58 PM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MediaWiki-Vendor, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, wikidata-tech-focus, Wikibase-DataModel, Wikidata

JeroenDeDauw added a comment to T208500: Wikidata role on vagrant not working locally (unclear why).

As @Addshore said, that composer info does not look right. You'll get the error you are getting when the code is not loaded. So my guess is that you do not have it loaded.

Nov 1 2018, 2:53 PM · MediaWiki-Vagrant, DataValues, Wikibase-Quality-Constraints, Wikidata

JeroenDeDauw added a comment to T208500: Wikidata role on vagrant not working locally (unclear why).

AFAIK Wikibase does not use Geo 4.x, since Geo 4.x requires PHP 7.1. So it is not clear to me how the 4.1 release could affect Wikibase.

Nov 1 2018, 2:51 PM · MediaWiki-Vagrant, DataValues, Wikibase-Quality-Constraints, Wikidata

Oct 30 2018

JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

Ready for review : https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/463740

Oct 30 2018, 12:54 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

I'll amend the change

Oct 30 2018, 12:47 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

Someone will need to follow up on Jonas his PR

Oct 30 2018, 12:34 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Oct 29 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEfeab042093aa: Merge "Fix type in comment" (authored by JeroenDeDauw).

Merge "Fix type in comment"

Oct 29 2018, 12:02 PM

JeroenDeDauw added a comment to T206325: Use wikibase/data-model 9.0 everywhere.

One thing we could do is revert the change causing all the pain. EntityDocument extending ClearableEntity might be nice, though likely not worth all this effort.

Oct 29 2018, 10:26 AM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MediaWiki-Vendor, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, wikidata-tech-focus, Wikibase-DataModel, Wikidata

JeroenDeDauw committed rEWLE056a8c251815: Move ChangeOp Deserialization stuff into Presentation/ (authored by JeroenDeDauw).

Move ChangeOp Deserialization stuff into Presentation/

Oct 29 2018, 9:44 AM

JeroenDeDauw committed rEWLE7f65b92e1c0b: Prevent modification of stored Lexeme in FakeLexemeRepository (authored by JeroenDeDauw).

Prevent modification of stored Lexeme in FakeLexemeRepository

Oct 29 2018, 8:45 AM

Oct 27 2018

JeroenDeDauw committed rEWLE4dcc4b8f29fe: Fix type in comment (authored by JeroenDeDauw).

Fix type in comment

Oct 27 2018, 8:57 AM

JeroenDeDauw committed rEWLEfa02ee6e0024: Prevent modification of stored Lexeme in FakeLexemeRepository (authored by JeroenDeDauw).

Prevent modification of stored Lexeme in FakeLexemeRepository

Oct 27 2018, 8:57 AM

JeroenDeDauw committed rEWLE6d40e5ecfb05: Use return type hints in Lexeme (authored by JeroenDeDauw).

Use return type hints in Lexeme

Oct 27 2018, 8:53 AM

JeroenDeDauw committed rEWLEcc3e1f85ebdb: Prevent modification of stored Lexeme in FakeLexemeRepository (authored by JeroenDeDauw).

Prevent modification of stored Lexeme in FakeLexemeRepository

Oct 27 2018, 8:50 AM

JeroenDeDauw committed rEWLEf90e767568b5: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).

Break EntityRevisionLookup out of merge interactor

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLE5b9987f041e9: Store isBot state in global factory (authored by JeroenDeDauw).

Store isBot state in global factory

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLE6a4cef879c89: Split interactor construction code (authored by JeroenDeDauw).

Split interactor construction code

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEd152969c0d33: Move LexemeRepository construction out of the merge interactor (authored by JeroenDeDauw).

Move LexemeRepository construction out of the merge interactor

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEe216e94966af: Move interactor construction into normal function (authored by JeroenDeDauw).

Move interactor construction into normal function

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLE82f161afbbe1: Break auth details (inc MW bind) out of LexemeMerge interactor (authored by JeroenDeDauw).

Break auth details (inc MW bind) out of LexemeMerge interactor

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEfac2caf53f1a: Split method in MediaWikiLexemeRepository (authored by JeroenDeDauw).

Split method in MediaWikiLexemeRepository

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEde276968bc37: Break persistance details out of MergeLexemesInteractor (initial step) (authored by JeroenDeDauw).

Break persistance details out of MergeLexemesInteractor (initial step)

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEc08583e8ae6f: Rename Domain/Lookups to Domain/Storage (authored by JeroenDeDauw).

Rename Domain/Lookups to Domain/Storage

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLE7af41066fdea: Remove not needed vars (authored by JeroenDeDauw).

Remove not needed vars

Oct 27 2018, 8:31 AM

JeroenDeDauw committed rEWLEb3eb5615f50e: Add TODO (authored by JeroenDeDauw).

Add TODO

Oct 27 2018, 8:31 AM

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEaac1466f0189: Merge "Inline not needed vars" (authored by JeroenDeDauw).

Merge "Inline not needed vars"

Oct 27 2018, 7:40 AM

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEd623f234b547: Merge "Remove dead code from MergeLexemesInteractor" (authored by JeroenDeDauw).

Merge "Remove dead code from MergeLexemesInteractor"

Oct 27 2018, 7:40 AM

Oct 26 2018

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

I've started cleaning up the existing interactor to correspond to what an interactor normally is and to respect architectural boundaries. This is mostly done. Chain of commits starting with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/469373

Oct 26 2018, 7:55 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Lexicographical data

JeroenDeDauw committed rEWLE60c42ce3ff7d: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).

Break EntityRevisionLookup out of merge interactor

Oct 26 2018, 7:46 AM

JeroenDeDauw committed rEWLEbb5247e5c178: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).

Break EntityRevisionLookup out of merge interactor

Oct 26 2018, 7:32 AM

JeroenDeDauw committed rEWLE7b9b56d1ce38: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).

Break EntityRevisionLookup out of merge interactor

Oct 26 2018, 7:21 AM

JeroenDeDauw committed rEWLEb5223273f6ed: Add to DIRECTORIES.md (authored by JeroenDeDauw).

Add to DIRECTORIES.md