JeroenDeDauw (Jeroen De Dauw)
~=[,,_,,]:3

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:56 PM (172 w, 45 m)
Availability
Available
IRC Nick
JeroenDeDauw
LDAP User
Unknown
MediaWiki User
Jeroen De Dauw

Opinions posted here are my own, unless stated otherwise

Recent Activity

Yesterday

JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

I am not planning to do this

Mon, Jan 22, 6:03 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2

Fri, Jan 12

JeroenDeDauw updated subscribers of T184798: UX: Such Diagram for the Jeroen.
Fri, Jan 12, 1:03 PM · Design, WMDE-Design
JeroenDeDauw created T184798: UX: Such Diagram for the Jeroen.
Fri, Jan 12, 1:02 PM · Design, WMDE-Design

Mon, Jan 8

JeroenDeDauw moved T183447: Membership application confirmation with wrong access token causes fatal error from Review to Deploy to Test on the WMDE-Fundraising-Funban-2 board.
Mon, Jan 8, 4:02 AM · WMDE-Fundraising-Sprint-14, WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

What is still missing is the UI for the "your info was anonimized but everything is OK" and "a technical error occurred" cases. For both of these it would be nice to have some kind of specification for that the page should look like. Is it fine to use a simple template that just takes a message and looks like the "access denied" one for both, or do things such as the links on the "success case" page also need to be shown?

Mon, Jan 8, 2:14 AM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2

Mon, Jan 1

JeroenDeDauw added a comment to T182966: Abstract "donation access".

First step https://github.com/wmde/fundraising-donations/pull/34

Mon, Jan 1, 10:13 PM · WMDE-Fundraising-Sprint-14, WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2

Tue, Dec 26

JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

WIP PR at https://github.com/wmde/FundraisingFrontend/pull/1159

Tue, Dec 26, 2:30 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw placed T183221: Membership application confirmation page after anonymization up for grabs.
Tue, Dec 26, 2:29 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2

Dec 22 2017

JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

PS: such a review feedbacks https://github.com/wmde/FundraisingStore/pull/90

Dec 22 2017, 4:21 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

Talked to Kai and this is the plan for now: have the Doctrine repo throw an (ApplicationPurged) exception when the data was purged. This forces the 4 UCs retrieving an Application to add a try catch which will fix their current error out in case of purged data. It is not entirely clear if this solution will remain viable as we add more UCs, but since it is low effort to implement we decided to try it out for now and adjust if it turns out to not work well later.

Dec 22 2017, 4:17 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

@gabriel-wmde I'm not sure how to make the Null Object pattern work here. We'd need a null object for both Applicant and PaymentMethod. These Value Objects do not follow Tell Don't Ask at all, which is something I think you kinda need to make the Null Object Pattern work. If we simply create such an object with empty values we'll still going to need special handling for most access happening to the data, which is not good. Perhaps you thought of something I did not...

Dec 22 2017, 3:41 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T183221: Membership application confirmation page after anonymization.

DB fields that get purged for memberships:

Dec 22 2017, 3:18 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw moved T183221: Membership application confirmation page after anonymization from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Dec 22 2017, 2:40 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
JeroenDeDauw claimed T183221: Membership application confirmation page after anonymization.
Dec 22 2017, 2:40 PM · WMDE-Fundraising-Sprint-15, WMDE-Fundraising-Sprint-14, WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2

Dec 20 2017

JeroenDeDauw placed T182415: explanation for the error when entering to small amounts up for grabs.
Dec 20 2017, 9:41 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 18 2017

JeroenDeDauw claimed T182415: explanation for the error when entering to small amounts.
Dec 18 2017, 11:37 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T182415: explanation for the error when entering to small amounts from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Dec 18 2017, 11:37 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 17 2017

JeroenDeDauw added a comment to T182966: Abstract "donation access".

What is currently done looks structurally sane enough to me. Please outline your concerns if you have a different view. (Though better read the below first.)

Dec 17 2017, 7:27 AM · WMDE-Fundraising-Sprint-14, WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T182415: explanation for the error when entering to small amounts.

Where should the error message go?

Dec 17 2017, 7:00 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 15 2017

JeroenDeDauw moved T180344: Comment donation - Integrate layout from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Dec 15 2017, 6:55 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

Error and success message style improvement: https://github.com/wmde/FundraisingFrontend/pull/1119

Dec 15 2017, 6:51 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team

Dec 14 2017

JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

I did:

Dec 14 2017, 3:29 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team

Dec 13 2017

JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

The comment form is now "working": https://github.com/wmde/FundraisingFrontend/pull/1096 & https://github.com/wmde/fundraising-frontend-content/pull/72

Dec 13 2017, 1:05 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team

Dec 11 2017

JeroenDeDauw added a comment to T182126: Review cat17 donation comment form UI.

There still is some random blank space above the form, though this is not on the thing you linked, so presumably just some CSS issue we need to fix. Beyond that, is this what the form is expected to look like?

Dec 11 2017, 10:47 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T182405: Different handling postcode field.

No validation of the field appears to happen on either the donation or membership form until all required fields are filled. With current master (61901bb290ef2092e3f62746bcf75b619ee48e1b) the donation form does show some error once all fields are filled:

Dec 11 2017, 12:42 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

Question: is it fine to just show "anonymous" and "using my name" as options in the comment form? In the old skin we show the name that will be used. In the new skin we do not have as easy access to this info, so it is slightly more work to show it.

Dec 11 2017, 12:23 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw updated the task description for T182476: Remaining issues for cat17 layout.
Dec 11 2017, 12:17 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T182435: Process for membership cancellations not working yet from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 11 2017, 12:17 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T182434: Process for donation cancellations not working yet from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 11 2017, 12:17 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 10 2017

JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

The HTML that was delivered by the third party seems rather incomplete. It's just some form fields, some of which where not even inside the form, and no behavior. Some UX review would be nice. I created https://phabricator.wikimedia.org/T182126 for that.

Dec 10 2017, 9:18 PM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw renamed T182126: Review cat17 donation comment form UI from cat17 donation comment form has a scrollbar to Review cat17 donation comment form UI.
Dec 10 2017, 7:48 PM · WMDE-Fundraising-Funban-2

Dec 5 2017

JeroenDeDauw created T182126: Review cat17 donation comment form UI.
Dec 5 2017, 4:55 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

users can (depending on the payment type they used) leave a comment

Dec 5 2017, 2:40 PM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T182081: Make membership cancellation a POST route.

I take it this is not as simple as changing $app->get() into $app->post() ?

Dec 5 2017, 1:06 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 4 2017

JeroenDeDauw claimed T180344: Comment donation - Integrate layout.
Dec 4 2017, 7:20 PM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T180344: Comment donation - Integrate layout from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Dec 4 2017, 7:20 PM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T180431: Opt out of receiving donation receipts - Integrate new layout.

Should this not be on Doing?

Dec 4 2017, 6:46 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T181277: when choosing Privat and “Sofort-Überweisung” or “Kreditkarte” the “Spende abschließen” button does not work.

The linked PR has been merged

Dec 4 2017, 4:07 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T180109: "System Message" page - Integrate new layout from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 4 2017, 3:36 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T180106: "Not found" page - Integrate new layout from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 4 2017, 3:36 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T180107: "Access denied" page - Integrate new layout from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 4 2017, 3:36 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T180108: "Error" page - Integrate new layout from Review to Test on the WMDE-Fundraising-Funban-2 board.
Dec 4 2017, 3:36 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T179929: ITZ logo.

PRs merged. Can this be moved out of review?

Dec 4 2017, 1:02 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T180042: Add house number validation to cat17.

This is the form with the warning in the (presumably) wrong color (and still bad positioning):

Dec 4 2017, 1:01 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T181497: overlapped text at donation confirmation page.

PR merged. Can this be moved to done?

Dec 4 2017, 12:59 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Dec 3 2017

JeroenDeDauw created T181931: MediaWiki PHPUnit fails with PHP 7.2.
Dec 3 2017, 1:15 PM · Patch-For-Review, NewPHP, MediaWiki-General-or-Unknown, MediaWiki-Core-Tests

Nov 30 2017

JeroenDeDauw added a comment to T180042: Add house number validation to cat17.

Donation form: https://github.com/wmde/FundraisingFrontend/pull/1060

Nov 30 2017, 2:40 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T180042: Add house number validation to cat17 from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 30 2017, 12:55 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Nov 28 2017

JeroenDeDauw added a comment to T180690: Show summarizing sentence after entering the donation form from a deep-link.

A banner is displayed above the respective section header

Nov 28 2017, 9:59 AM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Nov 27 2017

JeroenDeDauw moved T181392: Fix double output of academic title on membership application confirmation page from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Nov 27 2017, 1:58 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T181392: Fix double output of academic title on membership application confirmation page.

Fix in https://github.com/wmde/FundraisingFrontend/pull/1044

Nov 27 2017, 1:55 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T181392: Fix double output of academic title on membership application confirmation page from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 27 2017, 1:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T181065: Send German-formatted amount to /validate-payment-data.

Oh this is already on doing :)

Nov 27 2017, 7:39 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T181065: Send German-formatted amount to /validate-payment-data.

so the construction of the parser construction would have to be moved somewhere else

Nov 27 2017, 7:29 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Nov 26 2017

JeroenDeDauw moved T180936: AJAX Address validation zip code from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Nov 26 2017, 6:04 AM · WMDE-Fundraising-Funban-2

Nov 23 2017

JeroenDeDauw moved T180936: AJAX Address validation zip code from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 23 2017, 5:21 AM · WMDE-Fundraising-Funban-2

Nov 22 2017

JeroenDeDauw added a comment to T180344: Comment donation - Integrate layout.

Is this just an issue with the new layout? Seems fine using the old one:

Nov 22 2017, 6:28 AM · WMDE-Design (WMDE-Design-Workboard Doing), WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T180936: AJAX Address validation zip code.

moving the donation validation out of the use case in into the handler, like we did for memberships

Nov 22 2017, 2:10 AM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180936: AJAX Address validation zip code.

I moved this back to "Ready" as apparently I did another task.

Nov 22 2017, 2:08 AM · WMDE-Fundraising-Funban-2
JeroenDeDauw moved T180936: AJAX Address validation zip code from Review to Ready on the WMDE-Fundraising-Funban-2 board.
Nov 22 2017, 2:05 AM · WMDE-Fundraising-Funban-2

Nov 21 2017

JeroenDeDauw added a comment to T180711: Donate as company.

What validation fails? Client side or server side? (Just tried to find out myself but cannot get the new skin to work)

Nov 21 2017, 4:24 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw updated the task description for T181023: Donation form validation error shows for wrong field.
Nov 21 2017, 4:14 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw created T181023: Donation form validation error shows for wrong field.
Nov 21 2017, 4:13 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team

Nov 20 2017

JeroenDeDauw moved T180936: AJAX Address validation zip code from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Nov 20 2017, 11:51 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180936: AJAX Address validation zip code.

This probably "sufficiently fixes" the issue: https://github.com/wmde/FundraisingFrontend/pull/1027

Nov 20 2017, 11:51 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180936: AJAX Address validation zip code.

The AddDonationValidator has this extra stuff:

Nov 20 2017, 11:34 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180936: AJAX Address validation zip code.
Nov 20 2017, 11:20 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw moved T180936: AJAX Address validation zip code from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 20 2017, 10:41 PM · WMDE-Fundraising-Funban-2
JeroenDeDauw added a comment to T180716: Donation amounts with "commas" fail validation.

What is the issue/task? Should no validation violation be shown?

Nov 20 2017, 1:56 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw renamed T180708: Remove some default values from cat17 skin donation form from Default values when reaching donation form to Remove some default values from cat17 skin donation form.
Nov 20 2017, 12:27 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T180339: Auto-fill correction error message.

So the issue is that using auto-fill does not trigger re-validation?

Nov 20 2017, 12:24 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Tech, WMDE-Fun-Team

Nov 17 2017

JeroenDeDauw added a comment to T180456: Move git repository of data-values/data-types PHP library out of mediawiki/extensions.

If I'm not mistaken we talked about moving the PHP code of that package directly into Wikibase.git two years ago or so. I can't remember if there was a reason to not do that, or if simply no one got to it.

Nov 17 2017, 12:12 AM · User-Addshore, Gerrit, Wikidata
JeroenDeDauw added a comment to T180456: Move git repository of data-values/data-types PHP library out of mediawiki/extensions.

How about wikibase/data-types instead? Same for the package name.

Nov 17 2017, 12:09 AM · User-Addshore, Gerrit, Wikidata

Nov 7 2017

JeroenDeDauw committed rEASRd7a23356714c: Replace kittens by boxes (authored by JeroenDeDauw).
Replace kittens by boxes
Nov 7 2017, 2:10 PM

Nov 6 2017

JeroenDeDauw added a comment to T174669: House number validation in address forms.

Nov 6 2017, 2:28 PM · WMDE-Fundraising-Funban-2, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw added a comment to T174669: House number validation in address forms.

https://github.com/wmde/FundraisingFrontend/pull/984

Nov 6 2017, 2:28 PM · WMDE-Fundraising-Funban-2, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T174669: House number validation in address forms from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Nov 6 2017, 2:26 PM · WMDE-Fundraising-Funban-2, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T174669: House number validation in address forms from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 6 2017, 11:39 AM · WMDE-Fundraising-Funban-2, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T179468: SUB moderation in backend does not work from Review to Test on the WMDE-Fundraising-Funban-2 board.
Nov 6 2017, 9:57 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Nov 5 2017

JeroenDeDauw moved T179468: SUB moderation in backend does not work from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Nov 5 2017, 12:28 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw added a comment to T179468: SUB moderation in backend does not work .

I'm working on this: https://github.com/wmde/fundraising-backend/pull/343

Nov 5 2017, 10:07 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
JeroenDeDauw moved T179468: SUB moderation in backend does not work from Review to Doing on the WMDE-Fundraising-Funban-2 board.
Nov 5 2017, 10:05 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Nov 1 2017

JeroenDeDauw added a comment to T174669: House number validation in address forms.

I was looking at what stuff to modify to tackle this task and then it occurred to me this might conflict with the new layout work. Does it? I don't want to implement this now for the old layout and then have to re-implement it for the new one before the first stuff even gets deployed.

Nov 1 2017, 4:06 AM · WMDE-Fundraising-Funban-2, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team

Oct 30 2017

JeroenDeDauw added a comment to T173563: Understand commas as search term separators.

Some more tests in https://gerrit.wikimedia.org/r/387159

Oct 30 2017, 2:16 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search
JeroenDeDauw committed rEASR4e5d7fe0915c: Added extra tests (authored by JeroenDeDauw).
Added extra tests
Oct 30 2017, 2:14 AM
JeroenDeDauw added a comment to T177416: Opt out of receiving donation receipts.

All linked PRs are merged except the DNM one

Oct 30 2017, 1:35 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, Story, WMDE-Fundraising-Tech, WMDE-Fun-Team

Oct 27 2017

JeroenDeDauw added a comment to T173563: Understand commas as search term separators.

So what still needs to be done? Adding more tests?

Oct 27 2017, 10:59 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search
JeroenDeDauw added a comment to T173563: Understand commas as search term separators.

Merged https://gerrit.wikimedia.org/r/#/c/385991/ and https://gerrit.wikimedia.org/r/#/c/385983/

Oct 27 2017, 7:17 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search

Oct 19 2017

JeroenDeDauw placed T173572: Add code for tracking the usage of keywords and the overall usage of the extension up for grabs.
Oct 19 2017, 11:45 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), User-Addshore, WMDE-QWERTY-XMAS-Sprint-2017-12-20, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, Patch-For-Review, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search

Oct 17 2017

JeroenDeDauw added a comment to T173563: Understand commas as search term separators.

Are we following the Gerrit/Commit message guidelines to, amongst other benefits, link change sets here automatically?

Oct 17 2017, 1:03 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search
JeroenDeDauw committed rEASR941a593caa55: Recalculate input size when placeholder is changed (authored by JeroenDeDauw).
Recalculate input size when placeholder is changed
Oct 17 2017, 10:32 AM
JeroenDeDauw committed rEASR556d1751a56b: Fixed placeholder text not showing properly (authored by JeroenDeDauw).
Fixed placeholder text not showing properly
Oct 17 2017, 10:03 AM
JeroenDeDauw committed rEASRe8fa23a94ca6: CS changes in ArbitraryWordInput (authored by JeroenDeDauw).
CS changes in ArbitraryWordInput
Oct 17 2017, 10:03 AM
JeroenDeDauw committed rEASR46c621acc44e: Automawtically mawk boxes when a comma is input (authored by JeroenDeDauw).
Automawtically mawk boxes when a comma is input
Oct 17 2017, 10:03 AM
JeroenDeDauw committed rEASR8f90d6d034f2: Add placeholder text for comma fields (authored by JeroenDeDauw).
Add placeholder text for comma fields
Oct 17 2017, 10:03 AM
JeroenDeDauw claimed T173572: Add code for tracking the usage of keywords and the overall usage of the extension.
Oct 17 2017, 9:43 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), User-Addshore, WMDE-QWERTY-XMAS-Sprint-2017-12-20, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, Patch-For-Review, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search
JeroenDeDauw moved T173572: Add code for tracking the usage of keywords and the overall usage of the extension from Todo to Doing on the WMDE-Fundraising-Sprint-13 board.
Oct 17 2017, 9:43 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), User-Addshore, WMDE-QWERTY-XMAS-Sprint-2017-12-20, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, Patch-For-Review, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search
JeroenDeDauw placed T173563: Understand commas as search term separators up for grabs.
Oct 17 2017, 9:40 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, TCB-Team, Advanced-Search

Oct 16 2017

JeroenDeDauw placed T176720: Mobile 02 - Sofort Überweisung up for grabs.
Oct 16 2017, 12:28 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fundraising-Sprint-12, WMDE-Fundraising-Tech, WMDE-Fun-Team
JeroenDeDauw moved T176720: Mobile 02 - Sofort Überweisung from Doing to Review on the WMDE-Fundraising-Sprint-13 board.
Oct 16 2017, 12:26 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fundraising-Sprint-12, WMDE-Fundraising-Tech, WMDE-Fun-Team