Opinions posted here are my own, unless stated otherwise
User Details
User Details
- User Since
- Oct 7 2014, 4:56 PM (209 w, 6 d)
- Availability
- Available
- IRC Nick
- JeroenDeDauw
- LDAP User
- Unknown
- MediaWiki User
- Jeroen De Dauw [ Global Accounts ]
Sat, Oct 13
Sat, Oct 13
JeroenDeDauw committed rEWLE80e7cc72e04e: Break line to reduce line lenght (authored by JeroenDeDauw).
Break line to reduce line lenght
JeroenDeDauw committed rEWLE0a1ea3894167: Move LemmaTermValidator to where other ChangeOp validation code is (authored by JeroenDeDauw).
Move LemmaTermValidator to where other ChangeOp validation code is
JeroenDeDauw committed rEWLE4f92c51db76d: Move ChangeOps/ into DataAccess/ (authored by JeroenDeDauw).
Move ChangeOps/ into DataAccess/
Move Diff/ into Presentation/
JeroenDeDauw committed rEWLE4ed4a6418ab6: Move DummyObjects/ into Domain/ (authored by JeroenDeDauw).
Move DummyObjects/ into Domain/
JeroenDeDauw committed rEWLE694f0c2796a8: Move Store/ and Search/ into DataAccess/ (authored by JeroenDeDauw).
Move Store/ and Search/ into DataAccess/
JeroenDeDauw committed rEWLE2e64b30fa41d: Move contents of Validators/ elsewhere (authored by JeroenDeDauw).
Move contents of Validators/ elsewhere
Move View/ into Presentation/
JeroenDeDauw committed rEWLE3a2f51e429c2: Move Formatters/ and Rdf/ into Presentation/ (authored by JeroenDeDauw).
Move Formatters/ and Rdf/ into Presentation/
JeroenDeDauw committed rEWLE8d4a9acf6e50: Move EntityReferenceExtractors/ and Merge/ into Domain/ (authored by JeroenDeDauw).
Move EntityReferenceExtractors/ and Merge/ into Domain/
JeroenDeDauw committed rEWLE12e241d44911: Reorganize contents of DataModel and rename to Model (authored by JeroenDeDauw).
Reorganize contents of DataModel and rename to Model
JeroenDeDauw committed rEWLE98f2f40c7c47: Move DataModel to Domain/DataModel (authored by JeroenDeDauw).
Move DataModel to Domain/DataModel
JeroenDeDauw committed rEWLE891258f7aef0: Move EntityLinkFormatters to MW NS (authored by JeroenDeDauw).
Move EntityLinkFormatters to MW NS
Fri, Oct 12
Fri, Oct 12
JeroenDeDauw committed rEWLEf71127b7287e: Move LexemeLanguageCodePropertyIdConfig to MW NS (authored by JeroenDeDauw).
Move LexemeLanguageCodePropertyIdConfig to MW NS
JeroenDeDauw committed rEWLE242dd703dca0: Break line to reduce line lenght (authored by JeroenDeDauw).
Break line to reduce line lenght
Thu, Oct 11
Thu, Oct 11
JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.
Initial moving is done, ending with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466691
JeroenDeDauw committed rEWLE02128f0fee0e: Move ChangeOps/ into DataAccess/ (authored by JeroenDeDauw).
Move ChangeOps/ into DataAccess/
JeroenDeDauw committed rEWLEb85dae5f18be: Break line to reduce line lenght (authored by JeroenDeDauw).
Break line to reduce line lenght
JeroenDeDauw committed rEWLE99784362d7cf: Move LemmaTermValidator to where other ChangeOp validation code is (authored by JeroenDeDauw).
Move LemmaTermValidator to where other ChangeOp validation code is
JeroenDeDauw committed rEWLEd147d9f20435: Move DummyObjects/ into Domain/ (authored by JeroenDeDauw).
Move DummyObjects/ into Domain/
Move Diff/ into Presentation/
JeroenDeDauw committed rEWLE06ded4beb779: Move contents of Validators/ elsewhere (authored by JeroenDeDauw).
Move contents of Validators/ elsewhere
JeroenDeDauw committed rEWLE26e6948a7b01: Move Store/ and Search/ into DataAccess/ (authored by JeroenDeDauw).
Move Store/ and Search/ into DataAccess/
Move View/ into Presentation/
JeroenDeDauw committed rEWLE00126f5ead41: Move Formatters/ and Rdf/ into Presentation/ (authored by JeroenDeDauw).
Move Formatters/ and Rdf/ into Presentation/
JeroenDeDauw committed rEWLE83a1fa4f3b54: Move EntityReferenceExtractors/ and Merge/ into Domain/ (authored by JeroenDeDauw).
Move EntityReferenceExtractors/ and Merge/ into Domain/
JeroenDeDauw committed rEWLE260d894d8ee7: Reorganize contents of DataModel and rename to Model (authored by JeroenDeDauw).
Reorganize contents of DataModel and rename to Model
JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.
JeroenDeDauw committed rEWLE1b3f95f5fb58: Move DataModel to Domain/DataModel (authored by JeroenDeDauw).
Move DataModel to Domain/DataModel
JeroenDeDauw committed rEWLE43fffea1a528: Move EntityLinkFormatters to MW NS (authored by JeroenDeDauw).
Move EntityLinkFormatters to MW NS
JeroenDeDauw committed rEWLE6b70124c6799: Move LexemeLanguageCodePropertyIdConfig to MW NS (authored by JeroenDeDauw).
Move LexemeLanguageCodePropertyIdConfig to MW NS
JeroenDeDauw committed rEWLE6872d89d47b8: Update MergeLexemes interactor name (authored by JeroenDeDauw).
Update MergeLexemes interactor name
JeroenDeDauw committed rEWLEef405a2cf542: Move MW hook points into MW NS (authored by JeroenDeDauw).
Move MW hook points into MW NS
JeroenDeDauw committed rEWLE1b5484037c7b: Move LexemeMerge into dedicated Interactors folder (authored by JeroenDeDauw).
Move LexemeMerge into dedicated Interactors folder
JeroenDeDauw committed rEWLE7875063e7720: Move LexemeMerge into dedicated Interactors folder (authored by JeroenDeDauw).
Move LexemeMerge into dedicated Interactors folder
JeroenDeDauw updated the task description for T206325: Use wikibase/data-model 8.0 everywhere.
Wed, Oct 10
Wed, Oct 10
Tue, Oct 9
Tue, Oct 9
JeroenDeDauw added a comment to T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`.
The original setup was as follows:
- composer ci: runs all ci checks
- composer test: runs all tests
- composer cs: runs all style checks
Mon, Oct 8
Mon, Oct 8
JeroenDeDauw added a comment to T204541: Drop EntityId from statement GUID.
Right ok, that makes sense.
Fri, Oct 5
Fri, Oct 5
JeroenDeDauw added a comment to T204541: Drop EntityId from statement GUID.
I don’t see the benefit of removing the entity ID from the statement GUID.
Thu, Sep 27
Thu, Sep 27
JeroenDeDauw committed rEWLE399e4f5e4545: Upgrade to serialization/serialization 4.0 (authored by Ladsgroup).
Upgrade to serialization/serialization 4.0
Mon, Sep 24
Mon, Sep 24
JeroenDeDauw committed rEWLE4d20c4780330: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
Fri, Sep 21
Fri, Sep 21
JeroenDeDauw committed rEWLE83cf6afcb3b1: Special:NewLexeme - Language code box visible after failed submit (authored by Tarrow).
Special:NewLexeme - Language code box visible after failed submit
Thu, Sep 20
Thu, Sep 20
JeroenDeDauw committed rEWLEda2b750552db: Reduce inheritance code sharing in SpecialNewLexeme: step 3 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 3
JeroenDeDauw committed rEWLE445a6f2a4a1d: Reduce inheritance code sharing in SpecialNewLexeme: step 3 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 3
Wed, Sep 19
Wed, Sep 19
JeroenDeDauw committed rEWLE685aa4ac7459: Reduce inheritance code sharing in SpecialNewLexeme: step 3 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 3
JeroenDeDauw committed rEWLEea41d9e7a127: Reduce inheritance code sharing in SpecialNewLexeme: step 3 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 3
JeroenDeDauw committed rEWLE510e0e951bf9: Reduce inheritance code sharing in SpecialNewLexeme: step 2 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 2
JeroenDeDauw committed rEWLEf29341ecfc4b: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
JeroenDeDauw committed rEWLE8aff9288f89d: Reduce inheritance code sharing in SpecialNewLexeme: step 2 (authored by JeroenDeDauw).
Reduce inheritance code sharing in SpecialNewLexeme: step 2
JeroenDeDauw committed rEWLEba133280bb29: Reduce visibility in SpecialNewLexeme (authored by JeroenDeDauw).
Reduce visibility in SpecialNewLexeme
JeroenDeDauw committed rEWLE15a1de9493c1: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
JeroenDeDauw committed rEWLE147a487f513d: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
Remove not needed else
JeroenDeDauw committed rEWLE22b7c43273e2: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
Specify constant visibility
Tue, Sep 18
Tue, Sep 18
JeroenDeDauw committed rEWLE439f1fa1f981: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
Mon, Sep 17
Mon, Sep 17
Undeprecate FormDiffer::diff
JeroenDeDauw committed rEWLEe9b0a0f8462a: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
JeroenDeDauw committed rEWLEa765ef0e52db: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
Undeprecate FormDiffer::diff
JeroenDeDauw committed rEWLEd586cdff654c: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
JeroenDeDauw committed rEWLE7bc0cc4290f8: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEcfa05d889375: Merge "Add return type hints to SpecialNewLexeme" (authored by JeroenDeDauw).
Merge "Add return type hints to SpecialNewLexeme"
Sun, Sep 16
Sun, Sep 16
Specify constant visibility
JeroenDeDauw committed rEWLEc7ec0aaa5b42: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
Undeprecate FormDiffer::diff
JeroenDeDauw committed rEWLE0945384802f8: Add return type hints to SpecialNewLexeme (authored by JeroenDeDauw).
Add return type hints to SpecialNewLexeme
Sep 14 2018
Sep 14 2018
JeroenDeDauw committed rEWLE633becd35f4e: Add return type hints to SpecialNewLexeme (authored by JeroenDeDauw).
Add return type hints to SpecialNewLexeme
wtfff
Sep 13 2018
Sep 13 2018
JeroenDeDauw committed rEWLE4af3bbfbe335: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
JeroenDeDauw committed rEWLEa0a80ff62812: Remove inheritance abuse in SpecialNewLexeme: step 1 (authored by JeroenDeDauw).
Remove inheritance abuse in SpecialNewLexeme: step 1
Specify constant visibility
JeroenDeDauw committed rEWLEd670e91c1146: Add return type hints to SpecialNewLexeme (authored by JeroenDeDauw).
Add return type hints to SpecialNewLexeme
Undeprecate FormDiffer::diff
JeroenDeDauw committed rEWLEad3700ceab9c: Allow installation with DataModel 8.x (authored by JeroenDeDauw).
Allow installation with DataModel 8.x
JeroenDeDauw committed rEWLE70ba143ae63c: Add return type hints to SpecialNewLexeme (authored by JeroenDeDauw).
Add return type hints to SpecialNewLexeme
JeroenDeDauw committed rEWLE9f49c291bbaf: Add return type hints to SpecialNewLexeme (authored by JeroenDeDauw).
Add return type hints to SpecialNewLexeme
JeroenDeDauw committed rEWLEb945750adeef: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
JeroenDeDauw committed rEWLE027dfba8b432: Allow installation with DataModel 8.x (authored by JeroenDeDauw).
Allow installation with DataModel 8.x
Sep 12 2018
Sep 12 2018
JeroenDeDauw committed rEWLEd63a1c03ff0b: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
JeroenDeDauw committed rEWLEd21facddee7a: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
JeroenDeDauw committed rEWLE501f13767d4e: Rename DataTransfer to DummyObjects (authored by JeroenDeDauw).
Rename DataTransfer to DummyObjects
JeroenDeDauw committed rEWLE96626dd5121f: Do not use WB special page base class in SpecialMergeLexemes (authored by JeroenDeDauw).
Do not use WB special page base class in SpecialMergeLexemes
JeroenDeDauw committed rEWLE9e0719ffd0ac: Add missing catch to formatEntityId (authored by JeroenDeDauw).
Add missing catch to formatEntityId
JeroenDeDauw committed rEWLE260dddb0143a: Allow installation with DataModel 8.x (authored by JeroenDeDauw).
Allow installation with DataModel 8.x
JeroenDeDauw committed rEWLE6faa1e4cbbb0: Add missing catch to formatEntityId (authored by JeroenDeDauw).
Add missing catch to formatEntityId
JeroenDeDauw committed rEWLEdc3e6f3e6d82: Remove not needed docs from api request objects (authored by JeroenDeDauw).
Remove not needed docs from api request objects
JeroenDeDauw committed rEWLE61676a1ec4b1: Remove not needed doc from AddFormRequest (authored by JeroenDeDauw).
Remove not needed doc from AddFormRequest
JeroenDeDauw committed rEWLEc2f10546abe5: Remove dead code from FormTermResult (authored by JeroenDeDauw).
Remove dead code from FormTermResult
JeroenDeDauw committed rEWLE6509d6860722: Add return type hint in AddFormRequestParser (authored by JeroenDeDauw).
Add return type hint in AddFormRequestParser
Undeprecate FormDiffer::diff
JeroenDeDauw committed rEWLE6604b5461c69: Add missing field to LexemeDiffer (authored by JeroenDeDauw).
Add missing field to LexemeDiffer
JeroenDeDauw committed rEWLEceb856e19def: Remove dead code from EditSenseChangeOpDeserializerTest (authored by JeroenDeDauw).
Remove dead code from EditSenseChangeOpDeserializerTest
JeroenDeDauw committed rEWLE748e3dc3a482: Remove dead code from LexemeSensesMergerTest (authored by JeroenDeDauw).
Remove dead code from LexemeSensesMergerTest
JeroenDeDauw committed rEWLE4d94cd779c3c: Add WikibaseLexemeExtensionRegistrationTest to group Database (authored by Addshore).
Add WikibaseLexemeExtensionRegistrationTest to group Database
JeroenDeDauw committed rEWLE5d159901d87a: LexemeEnableSenses true by default. (authored by Addshore).
LexemeEnableSenses true by default.
JeroenDeDauw committed rEWLE4ed756001805: Remove dead code from EditSenseChangeOpDeserializerTest (authored by JeroenDeDauw).
Remove dead code from EditSenseChangeOpDeserializerTest