Jhernandez (Joaquin Oltra Hernandez)
Senior Software Engineer, Reading Web Team

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 24 2014, 11:57 PM (173 w, 6 d)
Availability
Available
IRC Nick
joakino
LDAP User
Jhernandez
MediaWiki User
Unknown

Recent Activity

Today

phuedx awarded T188081: Spike: Is it possible to get source maps for Extension:Popups in RL production mode? a Like token.
Fri, Feb 23, 11:11 AM · Readers-Web-Backlog, Page-Previews
Jhernandez reassigned T187173: Mobile diff warnings do not wrap properly from Jhernandez to Jdrewniak.

Saved by the bell! Back to the owner to reflect reality

Fri, Feb 23, 10:39 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog
Jhernandez created T188081: Spike: Is it possible to get source maps for Extension:Popups in RL production mode?.
Fri, Feb 23, 10:30 AM · Readers-Web-Backlog, Page-Previews
Jhernandez awarded T187801: Set up test server that fakes backend moved paragraph changes a Mountain of Wealth token.
Fri, Feb 23, 10:13 AM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2018-02-20

Yesterday

Jhernandez removed a project from T186284: MobileFrontend npm-run-lint-modules occassionally fails with message "Failed to walk": Patch-For-Review.

Checked the logs for the job runs from the 16th to the 22nd, didn't see any exceptions logged for now.

Thu, Feb 22, 7:11 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Readers-Web-Backlog, MobileFrontend
Jhernandez added a comment to T187916: Improve Page Issue modal.

Wow, sad news then... From the description changes proposed:

Thu, Feb 22, 7:01 PM · MinervaNeue, MobileFrontend, Design (RW-Design-Debt), Readers-Web-Backlog
Jhernandez added a comment to T166610: Page previews shouldn't be shown when user switches back to a tab.

I've updated the description with the proposed solution.

Thu, Feb 22, 6:42 PM · Readers-Web-Backlog, Page-Previews
Jhernandez updated the task description for T166610: Page previews shouldn't be shown when user switches back to a tab.
Thu, Feb 22, 6:41 PM · Readers-Web-Backlog, Page-Previews

Wed, Feb 21

Jhernandez added a comment to T187916: Improve Page Issue modal.

We should be very strict and gracefully bail out when parsing / changing the HTML as the issue template HTML can change at any point or in any wiki and could have very bad consequences if we have an exception in this view (unresponsive JS, so can't get out of modal, etc).

Wed, Feb 21, 6:45 PM · MinervaNeue, MobileFrontend, Design (RW-Design-Debt), Readers-Web-Backlog
Jhernandez added a comment to T187916: Improve Page Issue modal.

The link Learn more about fixing this issues comes from the inside of the issue template HTML.

Wed, Feb 21, 6:43 PM · MinervaNeue, MobileFrontend, Design (RW-Design-Debt), Readers-Web-Backlog
Jhernandez added a comment to T177219: [Spike 3hr] Determine how to store PDFs in order to get file size.

Assigned to @phuedx to clarify on the Services sync meeting about this task (@Niedzielski & @pmiazga will be there too)

Wed, Feb 21, 6:18 PM · Readers-Web-Kanbanana-Board, Spike, Readers-Web-Backlog, Proton, New-Readers
Jhernandez created T187920: Duplicate content when saving after joining a line.
Wed, Feb 21, 6:06 PM · VisualEditor

Fri, Feb 16

Jhernandez added a comment to T186284: MobileFrontend npm-run-lint-modules occassionally fails with message "Failed to walk".

I'll keep an eye on:

Fri, Feb 16, 5:54 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Readers-Web-Backlog, MobileFrontend
Jhernandez added a comment to T186284: MobileFrontend npm-run-lint-modules occassionally fails with message "Failed to walk".

Relevant commits:

Fri, Feb 16, 5:38 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Readers-Web-Backlog, MobileFrontend
Jhernandez added a comment to T186284: MobileFrontend npm-run-lint-modules occassionally fails with message "Failed to walk".

I'm not sure why this is happening. It should walk hogan as it is defined in the scripts field on extension.json, but for some reason the walking is failing.

Fri, Feb 16, 5:26 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Readers-Web-Backlog, MobileFrontend
Jhernandez claimed T186284: MobileFrontend npm-run-lint-modules occassionally fails with message "Failed to walk".
Fri, Feb 16, 4:40 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Readers-Web-Backlog, MobileFrontend
Jhernandez moved T170807: Return promises from action thunks from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.

Patch for review up. I've locally QAd it didn't see any issues. I've also checked the AC from what I've seen done in the sources, and sent an email about the jQuery version to the team list.

Fri, Feb 16, 1:17 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez updated the task description for T170807: Return promises from action thunks.
Fri, Feb 16, 1:16 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez updated the task description for T170807: Return promises from action thunks.
Fri, Feb 16, 1:11 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Krinkle awarded T149317: Merge bootstrap and render code in RelatedArticles a Orange Medal token.
Fri, Feb 16, 8:39 AM · Need-volunteer, Technical-Debt (RW-Tech-Debt), Readers-Web-Backlog, RelatedArticles

Thu, Feb 15

Jhernandez updated the task description for T170807: Return promises from action thunks.
Thu, Feb 15, 5:21 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez moved T170807: Return promises from action thunks from Needs QA to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Feb 15, 2:04 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez added a comment to T170807: Return promises from action thunks.

There are also a couple of wait( 0 ) in the integration.test.js that are probably not necessary.

Thu, Feb 15, 1:52 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez added a comment to T170807: Return promises from action thunks.

What are the QA steps here? Just a general "check that page previews still work"? Please specify.

Thu, Feb 15, 1:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews

Wed, Feb 14

Jhernandez added a comment to T184172: Header spacing is broken in the mobile web.

🎉

Wed, Feb 14, 5:40 PM · Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, Wikimedia-Portals, Discovery
Jhernandez added a comment to T187173: Mobile diff warnings do not wrap properly.

Should we make the current selector more specific to the diff lines only instead of applying to the general div?

Wed, Feb 14, 5:14 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog
Jhernandez moved T184793: Instrument page interactions from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 10:52 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jhernandez closed T180255: Tests broken under sinon 4.x as Resolved.

Checked locally, couldn't see any warnings anywhere on the test run (node tests/node-qunit/run.js 'tests/node-qunit/**/*.test.js') and the latest mw-node-qunit 👍

Wed, Feb 14, 10:09 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews

Tue, Feb 13

Jhernandez added a comment to T180255: Tests broken under sinon 4.x.

Looking good in principle, I'll try it out tomorrow and see if there is anything weird and sign this off

Tue, Feb 13, 7:45 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jhernandez added a comment to T170807: Return promises from action thunks.

As you found out, the jQuery 3 migration is complete so the answer to

Tue, Feb 13, 7:36 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez added a comment to T182314: Analyze results of enwiki and dewiki page previews a/b test.

Also, if we do reach out and get more info, it would be super interesting to do a blog post about this stuff, it isn't something that you can find online easily.

Tue, Feb 13, 1:13 PM · Readers-Web-Backlog, Reading-analysis, Page-Previews
Jhernandez added a comment to T182314: Analyze results of enwiki and dewiki page previews a/b test.

I'm inclined to believe that this is not a bug but an artefact of the resolution of JS timers, which apparently varies by browser and OS.

Tue, Feb 13, 1:11 PM · Readers-Web-Backlog, Reading-analysis, Page-Previews
Jhernandez added a comment to T184172: Header spacing is broken in the mobile web.

Isn't the wordmark too close to the globe? The "T" is basically touching the globe.

Tue, Feb 13, 11:16 AM · Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, Wikimedia-Portals, Discovery
Jhernandez awarded T165036: Refactor rendering code in src/renderer.js for readability and testability a Love token.
Tue, Feb 13, 11:11 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog

Fri, Feb 9

Niedzielski awarded T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions a Mountain of Wealth token.
Fri, Feb 9, 2:40 PM · Readers-Web-Backlog, RelatedArticles, MobileFrontend, Epic

Wed, Jan 31

Jhernandez updated subscribers of T186129: Set up Extension:Popups to support multiple preview types.

@ovasileva This is a technical task to adapt the base so that WMDE can start working on their references part, as we discussed on the meeting before all hands.

Wed, Jan 31, 5:50 PM · Readers-Web-Backlog, Page-Previews
Jhernandez added a project to T186129: Set up Extension:Popups to support multiple preview types: Readers-Web-Backlog.
Wed, Jan 31, 5:45 PM · Readers-Web-Backlog, Page-Previews
Jhernandez created T186129: Set up Extension:Popups to support multiple preview types.
Wed, Jan 31, 5:42 PM · Readers-Web-Backlog, Page-Previews
Jhernandez added a comment to T180255: Tests broken under sinon 4.x.

For seeing the sinon warnings right now, edit the npm run test:node script and remove the | tap-dot part to see the raw TAP output, you should be able to see the deprecation warnings from sinon.

Wed, Jan 31, 5:21 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jhernandez added a project to T180255: Tests broken under sinon 4.x: Technical-Debt.
Wed, Jan 31, 5:19 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jhernandez updated the task description for T170807: Return promises from action thunks.
Wed, Jan 31, 5:16 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez updated the task description for T170807: Return promises from action thunks.
Wed, Jan 31, 5:15 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews

Tue, Jan 30

Jhernandez committed rMARV532587bd70d5: Update: add grid (authored by Niedzielski).
Update: add grid
Tue, Jan 30, 11:20 PM
Jhernandez committed rMARV27c763ee5c7b: Update: make Paper full-bleed (authored by Niedzielski).
Update: make Paper full-bleed
Tue, Jan 30, 11:20 PM
Jhernandez closed T177012: Add postcss with autoprefixer for CSS styles as Resolved.
Tue, Jan 30, 10:36 PM · Patch-For-Review, Marvin
Jhernandez closed T177012: Add postcss with autoprefixer for CSS styles, a subtask of T176961: EOQ1 house cleaning, as Resolved.
Tue, Jan 30, 10:36 PM · Epic, Marvin
Jhernandez added a comment to T185835: Lazy loading images causes performance issues with section uncollapsing on Firefox for Android.

@Ciencia_Al_Poder Those two pages are not showing the same images:

Tue, Jan 30, 10:11 PM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, Performance-Team (Radar), Performance, MinervaNeue
Jhernandez added a comment to T185835: Lazy loading images causes performance issues with section uncollapsing on Firefox for Android.

I've done some testing on that page to see if the lazy loading scripts were the culprit.

Tue, Jan 30, 6:06 PM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, Performance-Team (Radar), Performance, MinervaNeue
Jhernandez added a comment to T185973: [Config] Disable Page Previews EventLogging instrumentation.

Setting PopupsEventLogging to false seems to be what's needed

Tue, Jan 30, 5:20 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Readers-Web-Backlog, Page-Previews
Jhernandez added a comment to T185973: [Config] Disable Page Previews EventLogging instrumentation.

We have enough data, so it is up to us when to disable. Next week would be good, for example.

Tue, Jan 30, 5:19 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Readers-Web-Backlog, Page-Previews
Jhernandez added a project to T182018: In the microsurvey tool, prevent highly active users from being spammed by multiple surveys: Readers-Web-Backlog (Tracking).
Tue, Jan 30, 5:13 PM · Readers-Web-Backlog (Tracking), QuickSurveys, Surveys
Jhernandez added a project to T182815: Make it possible to survey specific groups of registered editors: Readers-Web-Backlog (Tracking).
Tue, Jan 30, 5:12 PM · Readers-Web-Backlog (Tracking), MediaWiki-extensions-CentralNotice, QuickSurveys, Surveys, Community-Liaisons
Jhernandez added a project to T185973: [Config] Disable Page Previews EventLogging instrumentation: Readers-Web-Backlog.

Ping @ovasileva for prio

Tue, Jan 30, 5:06 PM · Readers-Web-Kanbanana-Board, Wikimedia-Site-requests, Readers-Web-Backlog, Page-Previews

Mon, Jan 29

Jhernandez added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

Indeed! Looks pretty good overall. Noticed one other issue, which is that @property seems to be meant for sub-sub-properties somehow. Documenting /** @property {jQuery} */ this.$overlay = $(); results in the system documenting a member named $overlay that has a sub-property named jQuery. Something didn't go right there.

Mon, Jan 29, 7:14 PM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
Jhernandez added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.
  1. Mark each mixin with @mixin
  2. There is no support for @cfg, so, using @param {Type} [config.option] instead.
Mon, Jan 29, 7:11 PM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
Jhernandez added a comment to T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.

I personally don't have any preference. It is a subjective decision.

Mon, Jan 29, 5:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript

Jan 23 2018

Jhernandez added a comment to T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.

Made an initial PR: https://github.com/wikimedia/eslint-config-wikimedia/pull/63 to show how this could look like.

Jan 23 2018, 6:20 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Jhernandez awarded T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config a Like token.
Jan 23 2018, 5:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript

Jan 19 2018

Jhernandez added a project to T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config: Front-end-Standards-Group.
Jan 19 2018, 10:08 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Jhernandez added a comment to T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.

POC patch in Page-Previews https://gerrit.wikimedia.org/r/#/c/405037

Jan 19 2018, 10:08 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Jhernandez added a comment to T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.

I wasn't sure how to tag this so I just added JavaScript.

Jan 19 2018, 10:05 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Jhernandez renamed T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config from Enforce 80 characters line length with eslint in eslint-wikimedia-config to Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.
Jan 19 2018, 10:04 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Jhernandez created T185295: Enforce 80-100 characters line length with eslint in eslint-wikimedia-config.
Jan 19 2018, 10:04 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Front-end-Standards-Group, JavaScript
Volker_E awarded T184172: Header spacing is broken in the mobile web a Like token.
Jan 19 2018, 1:18 AM · Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, Wikimedia-Portals, Discovery

Jan 16 2018

Jhernandez committed rMARVf52ae5a01fc3: Chore: add size test for bundled client CSS (authored by Niedzielski).
Chore: add size test for bundled client CSS
Jan 16 2018, 7:30 PM
Jhernandez closed T179432: Add hatnote support as Resolved.
Jan 16 2018, 6:02 PM · Patch-For-Review, Marvin
Jhernandez closed T179432: Add hatnote support, a subtask of T176958: Display article content within article namespace, as Resolved.
Jan 16 2018, 6:02 PM · Epic, Marvin
Jhernandez closed T178616: Move wiki revision path parameter to query parameter as Resolved.
Jan 16 2018, 5:44 PM · Patch-For-Review, Marvin
Jhernandez closed T178616: Move wiki revision path parameter to query parameter, a subtask of T173317: Initial version of article rendering, as Resolved.
Jan 16 2018, 5:44 PM · Patch-For-Review, Marvin, Epic

Jan 15 2018

Jhernandez moved T183151: Change copy on empty preview from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Jan 15 2018, 12:20 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Previews
Jhernandez added a comment to T107561: MediaWiki support for Composer equivalent for JavaScript packages.

That is a nice article. The points and dangers are generally applicable to using any package managers and running/serving untrusted code, and deep dependency chains.

Jan 15 2018, 10:36 AM · Performance-Team, MediaWiki-ResourceLoader, Developer-Wishlist (2017), TechCom-RFC, Front-end-Standards-Group

Jan 12 2018

Jhernandez added a comment to T184681: Document how to run performance tests on real phones.

Cool, thanks. I'll have a look this next week!

Jan 12 2018, 11:07 AM · Readers-Web-Backlog (Tracking), Mobile, Documentation, Performance-Team
Jhernandez added a comment to T123328: [GOAL] Lazy load references in mobile skin.

@Volker_E FYI @Peter has been doing on-device tests at T184527: Test performance win with lazy references on a real mobile phone, and has also improved docs, see T184681: Document how to run performance tests on real phones. He has documented his steps and methods up until now, in case you are interested 👍.

Jan 12 2018, 11:07 AM · Readers-Web-Backlog (Tracking), Epic, Goal, Reading-Web-Planning, Reading-Admin
Jhernandez added a comment to T184527: Test performance win with lazy references on a real mobile phone.

Looks consistent with the other test 👍

Jan 12 2018, 11:03 AM · Performance-Team

Jan 10 2018

Jhernandez closed T178615: Add query parameter typing as Resolved.
Jan 10 2018, 6:35 PM · Patch-For-Review, Marvin
Jhernandez closed T178615: Add query parameter typing, a subtask of T173317: Initial version of article rendering, as Resolved.
Jan 10 2018, 6:35 PM · Patch-For-Review, Marvin, Epic
Jhernandez closed T178615: Add query parameter typing, a subtask of T178616: Move wiki revision path parameter to query parameter, as Resolved.
Jan 10 2018, 6:35 PM · Patch-For-Review, Marvin
Jhernandez closed T178617: Add query parameter parser, a subtask of T178616: Move wiki revision path parameter to query parameter, as Resolved.
Jan 10 2018, 6:34 PM · Patch-For-Review, Marvin
Jhernandez closed T178617: Add query parameter parser as Resolved.
Jan 10 2018, 6:34 PM · Patch-For-Review, Marvin
Jhernandez closed T180465: Changing pages should update window title as Resolved.
Jan 10 2018, 5:22 PM · Patch-For-Review, Marvin
Jhernandez closed T180465: Changing pages should update window title, a subtask of T177367: Initial version of Marvin user interface chrome, as Resolved.
Jan 10 2018, 5:22 PM · Epic, Marvin
Jhernandez closed T182420: Scroll state should be reset when visiting a new page and restored when revisiting a prior page as Resolved.
Jan 10 2018, 5:05 PM · Patch-For-Review, Marvin
Jhernandez closed T182420: Scroll state should be reset when visiting a new page and restored when revisiting a prior page, a subtask of T177367: Initial version of Marvin user interface chrome, as Resolved.
Jan 10 2018, 5:05 PM · Epic, Marvin
Jhernandez added a comment to T184527: Test performance win with lazy references on a real mobile phone.

Very cool, thanks @Peter.

Jan 10 2018, 11:29 AM · Performance-Team

Jan 8 2018

Jhernandez added a comment to T123328: [GOAL] Lazy load references in mobile skin.

It is a hard topic to check, I'm guessing real device testing would be needed, as the devtools can only go so far with the network and CPU throttling (no memory constraints, and other real device troubles).

Jan 8 2018, 10:52 AM · Readers-Web-Backlog (Tracking), Epic, Goal, Reading-Web-Planning, Reading-Admin
Jhernandez added a comment to T182414: [Spike] How can we measure seen page previews with as high a degree of accuracy as possible?.

...but I'm personally not sure what they would entail on the backend (regarding extra work or collaborations).

Jan 8 2018, 10:10 AM · Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Jhernandez added a comment to T182414: [Spike] How can we measure seen page previews with as high a degree of accuracy as possible?.

Notes

  • #2 and #4 could and should include simplifying and/or removing the existing EventLogging instrumentation and A/B test code.
Jan 8 2018, 10:08 AM · Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog

Jan 5 2018

Jhernandez added a comment to T123328: [GOAL] Lazy load references in mobile skin.

The advantages of doing so are bytes savings on all articles (by up to 50% of HTML) but given HTML is smaller than images they are less significant than the lazy loaded images initiative (which got all the attention).

Jan 5 2018, 11:41 AM · Readers-Web-Backlog (Tracking), Epic, Goal, Reading-Web-Planning, Reading-Admin
Jhernandez awarded T184172: Header spacing is broken in the mobile web a Love token.
Jan 5 2018, 9:47 AM · Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, Wikimedia-Portals, Discovery

Jan 4 2018

Jhernandez added a comment to T173317: Initial version of article rendering.

Sounds good, I'll keep it in mind 👍

Jan 4 2018, 3:35 PM · Patch-For-Review, Marvin, Epic
Jhernandez awarded T170807: Return promises from action thunks a Like token.
Jan 4 2018, 3:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Jhernandez created T184172: Header spacing is broken in the mobile web.
Jan 4 2018, 11:36 AM · Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, Wikimedia-Portals, Discovery

Jan 3 2018

Jhernandez added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

I did my best to summarize the information at hand when I wrote https://www.mediawiki.org/wiki/User:JHernandez_(WMF)/JS_documentation_tools#Which_documentation_format_to_use_(spec_on_comment_syntax_and_tags_for_documenting_code) and https://www.mediawiki.org/wiki/User:JHernandez_(WMF)/JS_documentation_tools#Which_tool_and/or_template_to_use_to_generate_readable_HTML_docs

Jan 3 2018, 11:00 AM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation

Dec 7 2017

Jhernandez committed rMARV2c4cc70d8da8: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Dec 7 2017, 6:12 PM
Jhernandez committed rMARVb7bc3b92fbcc: Chore: add router tests for fetch errors (authored by Niedzielski).
Chore: add router tests for fetch errors
Dec 7 2017, 6:12 PM
Jhernandez committed rMARVb95705556d29: Fix: visiting a missing wiki page causes a server error (authored by Niedzielski).
Fix: visiting a missing wiki page causes a server error
Dec 7 2017, 6:12 PM
Jhernandez committed rMARVf8842fc02109: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Dec 7 2017, 5:41 PM
Jhernandez committed rMARVd5fe0e979570: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Dec 7 2017, 12:53 PM
Jhernandez committed rMARVdc599aba273e: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Dec 7 2017, 12:53 PM
Jhernandez committed rMARV09251fef92ea: Fix: gracefully handle redirects to external sites (authored by Niedzielski).
Fix: gracefully handle redirects to external sites
Dec 7 2017, 12:37 PM