Jhernandez (Joaquin Oltra Hernandez)
Senior Software Engineer, Reading Web Team

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 24 2014, 11:57 PM (151 w, 6 d)
Availability
Available
IRC Nick
joakino
LDAP User
Jhernandez
MediaWiki User
Unknown

Recent Activity

Today

Jhernandez committed rMARVcff47d81c127: Chore: Use Content in PageSummary for HTML content (authored by joakin <joaquin@chimeces.com>).
Chore: Use Content in PageSummary for HTML content
Fri, Sep 22, 9:52 AM

Yesterday

Jhernandez committed rMARV39f70df8a6e9: Update: increase the page title font size (authored by Niedzielski).
Update: increase the page title font size
Thu, Sep 21, 11:59 AM
Jhernandez updated the task description for T175806: Implement grid.
Thu, Sep 21, 10:58 AM · Marvin
Jhernandez changed the status of T175806: Implement grid from Open to Stalled.

This is postponed until demo is over and we reprioritize tasks based on the roadmap.

Thu, Sep 21, 10:56 AM · Marvin
Jhernandez changed the status of T175806: Implement grid, a subtask of T173022: Add the header & wordmark, from Open to Stalled.
Thu, Sep 21, 10:56 AM · Marvin
Jhernandez updated the task description for T175804: Add the base lower layer to the UI and font settings.
Thu, Sep 21, 10:46 AM · Patch-For-Review, Marvin
Jhernandez closed T173320: Add about page as Resolved.
Thu, Sep 21, 10:46 AM · Patch-For-Review, Marvin
Jhernandez closed T173320: Add about page, a subtask of T175838: Add a /_style route to show the a live style guide, as Resolved.
Thu, Sep 21, 10:46 AM · Marvin

Mon, Sep 18

Jhernandez added a comment to T173320: Add about page.

Thanks @Nirzar !

Mon, Sep 18, 4:38 PM · Patch-For-Review, Marvin
Jhernandez updated the task description for T170878: Audit users and account expiry dates for stat boxes.
Mon, Sep 18, 9:31 AM · User-Elukey, Patch-For-Review, Analytics-Kanban, Analytics-Cluster
Jhernandez updated the task description for T175877: Update fontstack on mobile web to use system typefaces.
Mon, Sep 18, 9:29 AM · Patch-For-Review, Readers-Web-Backlog (Design)
Jhernandez added a comment to T175877: Update fontstack on mobile web to use system typefaces.

@Volker_E on Mobile ~1% of traffic is from Windows OS (Windows Phone), so it seems like Segoe could be useful there.

Mon, Sep 18, 9:25 AM · Patch-For-Review, Readers-Web-Backlog (Design)
Jhernandez added a comment to T173323: Add Preact libraries.

@Niedzielski would you mind closing this task and moving the pending patches under T173317 or subtasks there?

Mon, Sep 18, 8:55 AM · Patch-For-Review, Marvin

Fri, Sep 15

Jhernandez added a project to T175863: Minerva causes Special:JavaScriptTest to fail in debug mode: Readers-Web-Backlog.
Fri, Sep 15, 11:28 AM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Readers-Web-Backlog, MinervaNeue
Jhernandez updated subscribers of T173320: Add about page.

@Nirzar do you think you could provide the (special)page spec for us to implement?

Fri, Sep 15, 10:06 AM · Patch-For-Review, Marvin
Jhernandez added a comment to T173821: Investigate exposing content styles needed via API vs as HTML tags.

Yeah it is a complicated topic. Besides the style in the codebases, there are also styles in "content", the common.css, or the skin css (Vector.css or Minerva.css), and soon there will be styles in templates...

Fri, Sep 15, 10:03 AM · RESTBase-API, Services (watching), Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service

Thu, Sep 14

Jhernandez added a comment to T173821: Investigate exposing content styles needed via API vs as HTML tags.

[...]

So I'm thinking of how much we can offload to the PCS here… going off what you are saying, here is my first idea for the "common" styles:

  1. We manually decide what the "common" styles are (we can start with what is bundled in the apps and modify that based on your current work)
Thu, Sep 14, 2:40 PM · RESTBase-API, Services (watching), Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Jhernandez added a comment to T175804: Add the base lower layer to the UI and font settings.

Sent a patch to it ^

Thu, Sep 14, 12:18 PM · Patch-For-Review, Marvin
Jhernandez added a comment to T175838: Add a /_style route to show the a live style guide.

In any case, a change of route should be super easy :D

Thu, Sep 14, 10:02 AM · Marvin
Jhernandez added a comment to T175838: Add a /_style route to show the a live style guide.

Sure! What other dev pages would be useful?

Thu, Sep 14, 10:02 AM · Marvin
Jhernandez added a comment to T175804: Add the base lower layer to the UI and font settings.

@Nirzar Should we update it in the base library?

Thu, Sep 14, 10:00 AM · Patch-For-Review, Marvin

Wed, Sep 13

Jhernandez added a parent task for T175838: Add a /_style route to show the a live style guide: T173021: UI: Initial application chrome.
Wed, Sep 13, 4:43 PM · Marvin
Jhernandez added a subtask for T173021: UI: Initial application chrome: T175838: Add a /_style route to show the a live style guide.
Wed, Sep 13, 4:43 PM · Epic, Marvin
Jhernandez edited parent tasks for T173320: Add about page, added: T175838: Add a /_style route to show the a live style guide; removed: T173021: UI: Initial application chrome.
Wed, Sep 13, 4:43 PM · Patch-For-Review, Marvin
Jhernandez removed a subtask for T173021: UI: Initial application chrome: T173320: Add about page.
Wed, Sep 13, 4:43 PM · Epic, Marvin
Jhernandez added a subtask for T175838: Add a /_style route to show the a live style guide: T173320: Add about page.
Wed, Sep 13, 4:43 PM · Marvin
Jhernandez created T175838: Add a /_style route to show the a live style guide.
Wed, Sep 13, 4:42 PM · Marvin
Jhernandez changed the point value for T174105: Update article actions icons to match wikimedia styleguide from 3 to 2.
Wed, Sep 13, 4:32 PM · Readers-Web-Kanban-Board, Readers-Web-Backlog, Design (RW-Design-Debt)
Jhernandez updated the task description for T174105: Update article actions icons to match wikimedia styleguide.
Wed, Sep 13, 4:25 PM · Readers-Web-Kanban-Board, Readers-Web-Backlog, Design (RW-Design-Debt)
Jhernandez added a comment to T175806: Implement grid.
  1. Tech notes
Wed, Sep 13, 3:29 PM · Marvin
Jhernandez added a comment to T175804: Add the base lower layer to the UI and font settings.
  1. Tech details
Wed, Sep 13, 3:18 PM · Patch-For-Review, Marvin
Jhernandez edited parent tasks for T173323: Add Preact libraries, added: T175804: Add the base lower layer to the UI and font settings; removed: T173022: Add the header & wordmark, T173025: Add dummy search box, T173320: Add about page, T173021: UI: Initial application chrome.
Wed, Sep 13, 9:50 AM · Patch-For-Review, Marvin
Jhernandez removed a subtask for T173021: UI: Initial application chrome: T173323: Add Preact libraries.
Wed, Sep 13, 9:50 AM · Epic, Marvin
Jhernandez removed a subtask for T173022: Add the header & wordmark: T173323: Add Preact libraries.
Wed, Sep 13, 9:50 AM · Marvin
Jhernandez removed a parent task for T175804: Add the base lower layer to the UI and font settings: T173021: UI: Initial application chrome.
Wed, Sep 13, 9:49 AM · Patch-For-Review, Marvin
Jhernandez removed a subtask for T173021: UI: Initial application chrome: T175804: Add the base lower layer to the UI and font settings.
Wed, Sep 13, 9:49 AM · Epic, Marvin
Jhernandez edited parent tasks for T173022: Add the header & wordmark, added: T173320: Add about page; removed: T173021: UI: Initial application chrome.
Wed, Sep 13, 9:48 AM · Marvin
Jhernandez removed a subtask for T173021: UI: Initial application chrome: T173022: Add the header & wordmark.
Wed, Sep 13, 9:48 AM · Epic, Marvin
Jhernandez added a subtask for T173320: Add about page: T173022: Add the header & wordmark.
Wed, Sep 13, 9:48 AM · Patch-For-Review, Marvin
Jhernandez removed a subtask for T173021: UI: Initial application chrome: T175806: Implement grid.
Wed, Sep 13, 9:47 AM · Epic, Marvin
Jhernandez added a subtask for T173022: Add the header & wordmark: T175806: Implement grid.
Wed, Sep 13, 9:47 AM · Marvin
Jhernandez edited parent tasks for T175806: Implement grid, added: T173022: Add the header & wordmark; removed: T173021: UI: Initial application chrome.
Wed, Sep 13, 9:47 AM · Marvin
Jhernandez added a parent task for T175804: Add the base lower layer to the UI and font settings: T175806: Implement grid.
Wed, Sep 13, 9:47 AM · Patch-For-Review, Marvin
Jhernandez added a subtask for T175806: Implement grid: T175804: Add the base lower layer to the UI and font settings.
Wed, Sep 13, 9:47 AM · Marvin
Jhernandez closed T173025: Add dummy search box as Declined.

I'm declining this until we need to implement search. We have more important things on our plates for now.

Wed, Sep 13, 9:44 AM · Marvin
Jhernandez closed T173025: Add dummy search box, a subtask of T173021: UI: Initial application chrome, as Declined.
Wed, Sep 13, 9:44 AM · Epic, Marvin
Jhernandez renamed T173022: Add the header & wordmark from Add wordmark to page to Add the header & wordmark.
Wed, Sep 13, 9:43 AM · Marvin
Jhernandez updated the task description for T173320: Add about page.
Wed, Sep 13, 9:41 AM · Patch-For-Review, Marvin
Jhernandez created T175806: Implement grid.
Wed, Sep 13, 9:39 AM · Marvin
Jhernandez created T175804: Add the base lower layer to the UI and font settings.
Wed, Sep 13, 9:34 AM · Patch-For-Review, Marvin

Tue, Sep 12

Jhernandez closed T175255: Fix production build step as Resolved.
Tue, Sep 12, 4:22 PM · Patch-For-Review, Marvin
Jhernandez added a comment to T175526: Fully loaded time regression on 3G Barack Obama en.wiki.

Thanks for the answer @Peter !

Tue, Sep 12, 4:20 PM · Performance-Team, Regression, Performance, Readers-Web-Backlog

Mon, Sep 11

Jhernandez added a comment to T175255: Fix production build step.

Staging seems to be stuck because of npm modifying the lock file.

Mon, Sep 11, 5:40 PM · Patch-For-Review, Marvin
Jhernandez updated the task description for T175255: Fix production build step.
Mon, Sep 11, 5:17 PM · Patch-For-Review, Marvin
Jhernandez added a comment to T175255: Fix production build step.
/home/marvin/sources/.git/hooks/post-merge#11
# Temporary hack until we fix CSS requires in PROD
 12 cd src/ && find . -name '*.css' -exec cp -v --parents \{\} ../dist \; && cd ..
Mon, Sep 11, 5:17 PM · Patch-For-Review, Marvin
Jhernandez added a comment to T175255: Fix production build step.

Going to review the staging hook and the docs next.

Mon, Sep 11, 1:34 PM · Patch-For-Review, Marvin
Jhernandez updated the task description for T175255: Fix production build step.
Mon, Sep 11, 1:33 PM · Patch-For-Review, Marvin
Jhernandez moved T175526: Fully loaded time regression on 3G Barack Obama en.wiki from To Triage to Needs Analysis on the Readers-Web-Backlog board.

Ping Performance-Team, maybe you have looked into this already?

Mon, Sep 11, 9:32 AM · Performance-Team, Regression, Performance, Readers-Web-Backlog
Jhernandez created T175526: Fully loaded time regression on 3G Barack Obama en.wiki.
Mon, Sep 11, 9:30 AM · Performance-Team, Regression, Performance, Readers-Web-Backlog
Jhernandez added a project to T175442: Empty branches: Readers-Web-Backlog.
Mon, Sep 11, 9:09 AM · Readers-Web-Backlog, MinervaNeue

Thu, Sep 7

Jhernandez updated subscribers of T173021: UI: Initial application chrome.

I'll be adding some more detailed subtasks like creating the Layout or Header component after we have a sync with Design's @Nirzar

Thu, Sep 7, 5:43 PM · Epic, Marvin
Jhernandez created T175255: Fix production build step.
Thu, Sep 7, 11:53 AM · Patch-For-Review, Marvin
Jhernandez added a comment to T173821: Investigate exposing content styles needed via API vs as HTML tags.

Can you clarify why this doesn't work with an API driven web app? (I assumed this would work with the native apps just fine, so maybe this will be a problem with them, too)

Thu, Sep 7, 11:40 AM · RESTBase-API, Services (watching), Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Jhernandez updated subscribers of T175092: Determine if .navboxes should be stripped from the page content delivered by the Mobile Content Service and Page Content Service.

In mobile web, neither navboxes nor vertical-navboxes are shown, because of the size they have and their usage of tables, making them unsuitable for mobile viewport sizes.

Thu, Sep 7, 11:07 AM · Page Content Service, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog (Kanban)
Jhernandez moved T174570: Put safety checks in place to prevent ES6 syntax from accidentally ending up in production. from Needs Code Review to Ready for Signoff on the Readers-Web-Kanban-Board board.

Needs technical sign off.

Thu, Sep 7, 10:39 AM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, Readers-Web-Backlog, Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, JavaScript, Page-Previews

Wed, Sep 6

Jhernandez added a comment to T175064: RelatedArticles not displaying on desktop wikivoyage: Cannot read property 'getBucket' of undefined console error.

...it theoretically could show up elsewhere.

Wed, Sep 6, 6:57 PM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, Readers-Web-Backlog, RelatedArticles
Jhernandez added a comment to T175193: Define MVP scope and deployment strategy.

We are these days meeting and discussing the objectives so that we can come up with a proper scope and deployment strategy.

Wed, Sep 6, 6:03 PM · Epic, Marvin
Jhernandez moved T175193: Define MVP scope and deployment strategy from Backlog to Epics on the Marvin board.
Wed, Sep 6, 6:01 PM · Epic, Marvin
Jhernandez created T175193: Define MVP scope and deployment strategy.
Wed, Sep 6, 6:01 PM · Epic, Marvin
Jhernandez closed T173740: POC for universal page component with data fetching as Resolved.
Wed, Sep 6, 5:59 PM · Spike, Marvin
Jhernandez closed T173740: POC for universal page component with data fetching, a subtask of T173317: Initial version of article rendering, as Resolved.
Wed, Sep 6, 5:59 PM · Marvin, Epic
Jhernandez closed T172442: Setup integration testing tooling as Declined.

Declined until we need this.

Wed, Sep 6, 5:56 PM · Marvin

Tue, Sep 5

Jhernandez added a comment to T173331: Inform PCS development efforts.

This is going to be an ongoing Epic

Tue, Sep 5, 10:47 AM · Marvin, Epic
Jhernandez closed T172908: Set up staging environment & deployment process as Resolved.

Re-open if tackling the previous items.

Tue, Sep 5, 10:43 AM · Marvin, Epic
Jhernandez added a comment to T172908: Set up staging environment & deployment process.

For an initial setup, this is done. There are a few things we could do, but we can tackle them once they hurt:

Tue, Sep 5, 10:42 AM · Marvin, Epic
Jhernandez closed T172913: Implement staging deployment process, a subtask of T172908: Set up staging environment & deployment process, as Resolved.
Tue, Sep 5, 10:41 AM · Marvin, Epic
Jhernandez closed T172913: Implement staging deployment process as Resolved.
Tue, Sep 5, 10:41 AM · Patch-For-Review, Marvin
Jhernandez added a comment to T172913: Implement staging deployment process.

I'm considering this done for now. There are a few things that could be improved, but we'll tackle them when they hurt. (cron.log rotation/cleanup, server auto restart, clustering, auto start on reboot).

Tue, Sep 5, 10:40 AM · Patch-For-Review, Marvin
Jhernandez closed T172912: Define deployment process, a subtask of T172913: Implement staging deployment process, as Resolved.
Tue, Sep 5, 10:39 AM · Patch-For-Review, Marvin
Jhernandez closed T172912: Define deployment process as Resolved.
Tue, Sep 5, 10:39 AM · Spike, Marvin
Jhernandez added a comment to T173821: Investigate exposing content styles needed via API vs as HTML tags.

Thanks for the summary @Jdlrobson.

Tue, Sep 5, 10:14 AM · RESTBase-API, Services (watching), Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Jhernandez closed T173491: Change the extension of source-map files in webpack.config.js as Resolved.

Indeed. The reason is that in debug the file is loaded individually:

Tue, Sep 5, 10:08 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews

Fri, Sep 1

Jhernandez assigned T174724: [Regression] Page previews stopped working on wikis where jQuery 3 is not available to ovasileva.

Excellent, just verified on https://ca.wikipedia.org/wiki/Portada, all working well!

Fri, Sep 1, 3:13 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Readers-Web-Kanban-Board, Readers-Web-Backlog, Regression, Page-Previews
Jhernandez added a comment to T174724: [Regression] Page previews stopped working on wikis where jQuery 3 is not available.

This seems to have been introduced here https://gerrit.wikimedia.org/r/#/c/373327/ where I upgraded a promise usage to the jQuery 3 version, as @TheDJ mentions. I incorrectly understood that it was available already and migrated the code. As specified in T124742: Upgrade to jQuery 3 we are just starting to roll it out, so the code should be using the old promise behavior that works on v2 and v3 until rollout is complete.

Fri, Sep 1, 10:06 AM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Readers-Web-Kanban-Board, Readers-Web-Backlog, Regression, Page-Previews

Thu, Aug 31

Jhernandez added a comment to T173821: Investigate exposing content styles needed via API vs as HTML tags.

That is a good question indeed.

Thu, Aug 31, 4:58 PM · RESTBase-API, Services (watching), Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Jhernandez added a comment to T172913: Implement staging deployment process.

You can see it working here: http://marvin.wmflabs.org/

Thu, Aug 31, 11:49 AM · Patch-For-Review, Marvin
Jhernandez moved T173491: Change the extension of source-map files in webpack.config.js from Needs Code Review to Ready for Signoff on the Readers-Web-Kanban-Board board.

Needs tech signoff. Steps are on the description.

Thu, Aug 31, 11:41 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Technical-Debt, Readers-Web-Backlog, Page-Previews
Jhernandez added a comment to T167699: Enable JS error reporting in the mobile website.

I don't think so sadly, and you are totally right.

Thu, Aug 31, 9:13 AM · Readers-Web-Backlog, MobileFrontend
Jhernandez added a comment to T174570: Put safety checks in place to prevent ES6 syntax from accidentally ending up in production..

We can migrate to common.js back but after we made the explicit move to ES modules that would suck.

Thu, Aug 31, 9:06 AM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, Readers-Web-Backlog, Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, JavaScript, Page-Previews

Wed, Aug 30

Jhernandez added a comment to T172913: Implement staging deployment process.

Initial work of setting up repo and git hook to install/build/re-run on git pull done, see patch above, and https://marvin.wmflabs.org running the repo code now.

Wed, Aug 30, 5:54 PM · Patch-For-Review, Marvin
Jhernandez added a comment to T174570: Put safety checks in place to prevent ES6 syntax from accidentally ending up in production..

Apparently that patch was a NOOP. sourceType module will not honor the parser ecmaVersion and const and let will parse just fine... :( Which is normal, since let and const are valid JS tokens.

Wed, Aug 30, 5:19 PM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, Readers-Web-Backlog, Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, JavaScript, Page-Previews

Tue, Aug 29

Jhernandez closed T172195: Initial git repository setup as Resolved.

Indeed! Thanks!

Tue, Aug 29, 6:02 PM · Epic, Marvin
Jhernandez added a comment to T153473: [Spike] How should we organize and manage our ResourceLoader modules?.

I personally don't see a problem with conditionally loading tablet modules. Optimizing for the constrained mobile experience seems like the best idea, and there are certain devices that when rotating from portrait to landscape become tablet, so loading tablet modules on resize is a great idea. What we don't do right now that we should is disable the tablet enhancements when the screen is resized back to mobile again.

Tue, Aug 29, 8:34 AM · Technical-Debt (RW-Tech-Debt), Readers-Web-Backlog, MobileFrontend

Mon, Aug 28

Jhernandez added a comment to T172904: Enable CI Jenkins job test voting.

Thanks @hashar ! We're aware of those warnings, the fsevents one is optional depending on OS, the eslint one is being fixed on eslint-config-node-services but it works fine with eslint v4 which we use, and the last one is a config warning that is a NOOP that we need to fix.

Mon, Aug 28, 5:14 PM · Patch-For-Review, Continuous-Integration-Config, Marvin
Jhernandez added a comment to T172454: mw.template and mw.msg should be wrapped by local methods in View.js.

In my opinion that isn't a big win and I wouldn't do it, but I'm not against it if others want to do it. If we do it, let's be sure that all the code base is consistent so that we can reliably grep for message or template usages.

Mon, Aug 28, 11:43 AM · Need-volunteer, Technical-Debt, Readers-Web-Backlog
Jhernandez updated subscribers of T172912: Define deployment process.

Here's what I'm thinking:

Mon, Aug 28, 11:36 AM · Spike, Marvin
Jhernandez moved T174301: Adaptive Icons for Android app from Needs triage to Triaged on the Mobile board.
Mon, Aug 28, 10:18 AM · Design, Wikipedia-Android-App-Backlog, Mobile, Android-app-Bugs
Jhernandez moved T174308: App Shortcuts homescreen support for Wikipedia Android app from Needs triage to Triaged on the Mobile board.
Mon, Aug 28, 10:18 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Design, Mobile
Jhernandez added a project to T174310: The Hebrew dual plural form in mobile-frontend-joined-years is parsed incorrectly: Readers-Web-Backlog.
Mon, Aug 28, 10:16 AM · Readers-Web-Backlog (Tracking), MediaWiki-Internationalization, I18n, MobileFrontend
Jhernandez added a project to T174194: Display user account blocks in mobile view on Special:Contributions: Readers-Web-Backlog.
Mon, Aug 28, 10:15 AM · Readers-Web-Backlog (Tracking), MediaWiki-Special-pages, MobileFrontend