Wed, Jul 12
Wed, Jul 5
And if it is smaller than what the team agreed, then all the better!
I'm fine with the task as it is, if we agree on points. We can have big tasks.
Tue, Jul 4
Mon, Jul 3
Sent an email to discuss.
By using runtime it shaves 1/3rd of the size :)
@Aleksey_WMDE I didn't know that was the case, I see now in https://vuejs.org/v2/guide/installation.html#Runtime-Compiler-vs-Runtime-only
Fri, Jun 30
The examples from T167041#3394034 but reformatted and + preact and preact(no-jsx):
Seems like a topic for a different card.
Thu, Jun 29
Tested it on a patch, seems to work well and fast. Let's see how it serves us, maybe we can revisit in a few weeks to see if we've been using it.
Nice, consistent and clear.
Wed, Jun 28
Will signoff soon.
@ovasileva @Nirzar For what is worth (I'm a terrible user), I did go through both prototypes, and in the second one I 100% missed the settings cog, and thought we were getting rid of it, and asked myself where would we put the settings like the font size stuff if we got rid of it once things came to stable, and them moved on.
@ovasileva Any html can be there theoretically. Practically probably not much more.
Re: Developer notes 2, from an irc chat w/ @phuedx, if this ends up being a REST service, we could consume the parsoid HTML or MCS which have well formed html and sectioning logic already done, instead of using textextracts.
Ping @ovasileva, you have a question in the description.
Coverage is a vanity metric. Please don't use it to justify priority or imply the code is well tested. It isn't.
I've clarified title and description, removed the experiment word from the description.
T144622: Add exparagraphs parameter to API has been declined in favor of this task. That one was High prio, so I'm setting this one as High. Feel free to back it down if it isn't.
I'm going to go ahead and decline this one given the proposed use case is being tackled in T168625: Make the Page Summary API return an "intro" for a page.
@bmansurov For the data about hypothesis 3 (browsers), is there any way we could identify if the duplicate events are sent by a few clients, or many of them? Any anon client token we could group by?
Tue, Jun 27
I'd appreciate review
Mon, Jun 26
Very interesting. Seems in line with previous research 👍
Thanks a lot @Jdlrobson 👏 . Great work
IMO sorting the preferred languages by number of previous clicks, would be preferable. Or even showing an (x) to the right of the item to remove it from the list of clicked languages.
Jun 23 2017
I've started work here. I'll bring the summary table back when I'm finished.
Jun 22 2017
Jun 21 2017
Not necessarily undefined I guess, maybe it is being called with NaN or 'NaN' or something like that.
Thanks @Tbayer, good to know.
To be clear, the approach listed on WikimediaEvents is per schema.
I'm closing this declined as I haven't experienced this exact behavior for some time and the task is old enough.
I don't have any particular opinions on the design of the tracking and the test, but just wanted to point out that Hygiene: SamplingRate -> BucketSize is just a name change for the variables, from sampling to bucketing, given that the they are used for bucketing with mw.experiments.
Jun 20 2017
@pmiazga Nice catch!, but unrelated to this task, and affects probably other events like the settings cog one.
To be fixed in the service:
I've listed a proposal as an example. It may suck so comment or add other proposals to it.
I've reviewed but not merged to get @Jdlrobson to have a look at it. LGTM.
Found when testing T167273: pageLoaded events are logged infrequently, if at all
Needs technical signoff.
@Jdlrobson Nice, great job with the docs!
Jun 19 2017
Jun 16 2017
Jun 15 2017
Added info to description
I've submitted some hygiene changes related to this patch. No change in functionality should occur.
Discussed in the reading/services sync,
Jun 14 2017
@Nirzar says: Subtitle should be aligned with the title of the checkbox.
I see this, is it broken? (Chrome)
For the record, I sent an email to wikitech-l asking how does a build process look like for extensions to gather feedback: https://lists.wikimedia.org/pipermail/wikitech-l/2017-June/088264.html
Jun 13 2017
Isn't this too big to be just one task?
@phuedx I've clarified the item to mention both approaches. I believe mobilefrontend heavily uses eventlogging.Schema instances so we should probably follow suit here. What do you think?
Jun 12 2017
Tested locally with beta cluster as the api and yorkshire terrier as the sample.