Saved by the bell! Back to the owner to reflect reality
Checked the logs for the job runs from the 16th to the 22nd, didn't see any exceptions logged for now.
Wow, sad news then... From the description changes proposed:
I've updated the description with the proposed solution.
Wed, Feb 21
We should be very strict and gracefully bail out when parsing / changing the HTML as the issue template HTML can change at any point or in any wiki and could have very bad consequences if we have an exception in this view (unresponsive JS, so can't get out of modal, etc).
The link Learn more about fixing this issues comes from the inside of the issue template HTML.
Fri, Feb 16
I'll keep an eye on:
I'm not sure why this is happening. It should walk hogan as it is defined in the scripts field on extension.json, but for some reason the walking is failing.
Patch for review up. I've locally QAd it didn't see any issues. I've also checked the AC from what I've seen done in the sources, and sent an email about the jQuery version to the team list.
Thu, Feb 15
There are also a couple of wait( 0 ) in the integration.test.js that are probably not necessary.
What are the QA steps here? Just a general "check that page previews still work"? Please specify.
Wed, Feb 14
Should we make the current selector more specific to the diff lines only instead of applying to the general div?
Checked locally, couldn't see any warnings anywhere on the test run (node tests/node-qunit/run.js 'tests/node-qunit/**/*.test.js') and the latest mw-node-qunit 👍
Tue, Feb 13
Looking good in principle, I'll try it out tomorrow and see if there is anything weird and sign this off
As you found out, the jQuery 3 migration is complete so the answer to
Also, if we do reach out and get more info, it would be super interesting to do a blog post about this stuff, it isn't something that you can find online easily.
Isn't the wordmark too close to the globe? The "T" is basically touching the globe.
Fri, Feb 9
Wed, Jan 31
@ovasileva This is a technical task to adapt the base so that WMDE can start working on their references part, as we discussed on the meeting before all hands.
For seeing the sinon warnings right now, edit the npm run test:node script and remove the | tap-dot part to see the raw TAP output, you should be able to see the deprecation warnings from sinon.
Tue, Jan 30
@Ciencia_Al_Poder Those two pages are not showing the same images:
I've done some testing on that page to see if the lazy loading scripts were the culprit.
Setting PopupsEventLogging to false seems to be what's needed
We have enough data, so it is up to us when to disable. Next week would be good, for example.
Ping @ovasileva for prio
Mon, Jan 29
I personally don't have any preference. It is a subjective decision.
Jan 23 2018
Made an initial PR: https://github.com/wikimedia/eslint-config-wikimedia/pull/63 to show how this could look like.
Jan 19 2018
Jan 16 2018
Jan 15 2018
That is a nice article. The points and dangers are generally applicable to using any package managers and running/serving untrusted code, and deep dependency chains.
Jan 12 2018
Cool, thanks. I'll have a look this next week!
@Volker_E FYI @Peter has been doing on-device tests at T184527: Test performance win with lazy references on a real mobile phone, and has also improved docs, see T184681: Document how to run performance tests on real phones. He has documented his steps and methods up until now, in case you are interested 👍.
Looks consistent with the other test 👍
Jan 10 2018
Very cool, thanks @Peter.
Jan 8 2018
It is a hard topic to check, I'm guessing real device testing would be needed, as the devtools can only go so far with the network and CPU throttling (no memory constraints, and other real device troubles).
Jan 5 2018
Jan 4 2018
Sounds good, I'll keep it in mind 👍
Jan 3 2018
I did my best to summarize the information at hand when I wrote https://www.mediawiki.org/wiki/User:JHernandez_(WMF)/JS_documentation_tools#Which_documentation_format_to_use_(spec_on_comment_syntax_and_tags_for_documenting_code) and https://www.mediawiki.org/wiki/User:JHernandez_(WMF)/JS_documentation_tools#Which_tool_and/or_template_to_use_to_generate_readable_HTML_docs