Page MenuHomePhabricator

Jjanes (Jeff Janes)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 30 2014, 9:28 PM (255 w, 3 d)
Availability
Available
LDAP User
Jjanes
MediaWiki User
Unknown

Recent Activity

Jan 18 2019

Jjanes added a watcher for PostgreSQL: Jjanes.
Jan 18 2019, 12:27 AM
Jjanes added a member for PostgreSQL: Jjanes.
Jan 18 2019, 12:27 AM

Oct 6 2016

Jjanes created T147599: Cannot install 1.28 alpha with PostgreSQL database.
Oct 6 2016, 10:08 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, Wikimedia-Rdbms, MediaWiki-Installer

Sep 6 2016

Jjanes added a comment to T144535: 1.27.1 Installer does not connect to custom port on PostgreSQL, uses default wrong port.

This was broken by change I880d4299566beaf99ed1fc21c690cdda64149b0e. It looks like PostgreSQL gets the port directly from wgDBport, by passing the Factory. Am I right that PostgreSQL is the only database that even has wiki support for non-default ports?

Sep 6 2016, 9:44 PM · PostgreSQL, MediaWiki-Installer

Sep 1 2016

Jjanes created T144535: 1.27.1 Installer does not connect to custom port on PostgreSQL, uses default wrong port.
Sep 1 2016, 8:07 PM · PostgreSQL, MediaWiki-Installer
Jjanes created T144531: Don't warn about absense of APC on PHP7 .
Sep 1 2016, 7:51 PM · [DO NOT USE] NewPHP, MediaWiki-Installer

May 20 2016

Jjanes reopened T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition as "Open".
May 20 2016, 9:58 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), PostgreSQL, AbuseFilter
Jjanes reopened T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Open.
May 20 2016, 9:58 PM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms

May 15 2016

Jjanes closed T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition as Resolved by committing rEABF3288cb3fc7ba: PostgreSQL: Add missing columns for AbuseFilter.
May 15 2016, 9:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), PostgreSQL, AbuseFilter
Jjanes closed T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Resolved.
May 15 2016, 9:50 PM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms

May 14 2016

Jjanes added a comment to T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition.

Why does this say it was closed by me? I didn't do anything to close it, and the commit it says I made to close it has not been merged, so the issue remains as far as I can tell.

May 14 2016, 9:19 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), PostgreSQL, AbuseFilter
Jjanes added a comment to T135216: Database error on Special:Protected_Pages when using PostgreSQL.

I think my approach is more modular (it doesn't embed the database type into the general code, but rather calls out to inherited methods) and it also comes closer to preserving the semantics of MySQL comparison. For example, in MySQL,

May 14 2016, 8:28 PM · PostgreSQL, Patch-For-Review, Wikimedia-Rdbms, MediaWiki-Special-pages

May 11 2016

Jjanes added a comment to T110655: Extension HitCounters: Add PostgreSQL support.

The dropping of column page.page_counter was added to all the database updater scripts for 1.25, but then the dropping was taken out just for MySQL and put back in for 1.26.

May 11 2016, 11:02 PM · PostgreSQL, Regression, Patch-For-Review, MediaWiki-extensions-HitCounters

Apr 28 2016

Jjanes closed T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition as Resolved by committing rEABF1e4ba08a85c3: PostgreSQL: Add missing columns for AbuseFilter.
Apr 28 2016, 1:08 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), PostgreSQL, AbuseFilter
Jjanes closed T89514: Issues with abusefilter + MW 1.24 + postgresql: Doesn't define af_group, af_id definition, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Resolved.
Apr 28 2016, 1:08 AM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms

Apr 3 2016

Jjanes claimed T130634: DB failure with PostgreSQL: relation "ignore" does not exist.

To answer my own question, the problem does not exist in 1.23 but does in all later versions.

Apr 3 2016, 12:59 AM · PostgreSQL, Patch-For-Review, MediaWiki-extensions-UserMerge

Apr 2 2016

Jjanes added a comment to T130634: DB failure with PostgreSQL: relation "ignore" does not exist.

Do we know if this bug has always existed, or is new?

Apr 2 2016, 9:42 PM · PostgreSQL, Patch-For-Review, MediaWiki-extensions-UserMerge

Dec 18 2015

Jjanes created T121902: Make phpunit more resilient to failures under PostgreSQL.
Dec 18 2015, 6:48 PM · MediaWiki-Core-Testing
Jjanes added a comment to T121837: 1.23.12 fails "make phpunit".

With 1.23.11, the test suite ran to completion for me. Some of the tests within it fail, but the at least you could look at the list of those failures to see how important they are.

Dec 18 2015, 4:42 PM · MediaWiki-Core-Testing
Jjanes created T121837: 1.23.12 fails "make phpunit".
Dec 18 2015, 5:03 AM · MediaWiki-Core-Testing

Dec 17 2015

Jjanes created T121743: Quotes needed for timestamps in PostgreSQL.
Dec 17 2015, 5:16 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, Patch-For-Review, Wikimedia-Rdbms

Aug 28 2015

Jjanes added a comment to T110655: Extension HitCounters: Add PostgreSQL support.

It seems like every extension has implemented database-depend table creation in a different way.

Aug 28 2015, 11:14 PM · PostgreSQL, Regression, Patch-For-Review, MediaWiki-extensions-HitCounters

Jul 20 2015

Jjanes committed rMWc1371e7f54e0: PostgreSQL: Fix text search on moved pages (authored by Jjanes).
PostgreSQL: Fix text search on moved pages
Jul 20 2015, 11:04 PM

Jul 6 2015

Jjanes added a comment to T66043: change in default schema for MSSQL complicates installation with PostgreSQL.

It is fixed in 1.25.1 and 1.26alpha

Jul 6 2015, 6:14 AM · PostgreSQL, MediaWiki-Installer, MW-1.23-release

Jun 11 2015

Jjanes closed T88097: Possible bug in DatabasePostgres.php: Check if rights for "standard_conforming_strings" are available, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Invalid.
Jun 11 2015, 9:53 PM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms
Jjanes closed T88097: Possible bug in DatabasePostgres.php: Check if rights for "standard_conforming_strings" are available as Invalid.
Jun 11 2015, 9:53 PM · PostgreSQL, Wikimedia-Rdbms

Apr 14 2015

Jjanes added a comment to T48640: Add proper email bounce handling to MediaWiki (with VERP).

The patch is this one, https://gerrit.wikimedia.org/r/#/c/138655/

Apr 14 2015, 5:56 PM · Patch-For-Review, MediaWiki-extension-requests

Apr 13 2015

Jjanes added a comment to T48640: Add proper email bounce handling to MediaWiki (with VERP).

In 1.23 branch, the $wgPasswordSender setting seems to be ignored. In 1.24, it is honored, and this change is the one that fixes it.

Apr 13 2015, 9:59 PM · Patch-For-Review, MediaWiki-extension-requests

Apr 8 2015

Jjanes closed T89171: Postgres SQL error comparing text and integer in getRangeCond() from includes/Block.php, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Invalid.
Apr 8 2015, 5:09 PM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms
Jjanes closed T89171: Postgres SQL error comparing text and integer in getRangeCond() from includes/Block.php as Invalid.
Apr 8 2015, 5:09 PM · PostgreSQL, Wikimedia-Rdbms

Mar 25 2015

RandomDSdevel awarded T70087: "ORDER BY" clause in query for Special:ActiveUsers throws PostgreSQL error: column "mwuser.user_name" must appear a Like token.
Mar 25 2015, 8:36 PM · PostgreSQL, MediaWiki-Tarball-Backports, Patch-For-Review, Wikimedia-Rdbms

Mar 11 2015

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT7b34ca67487a: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard… (authored by Jjanes).
Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard…
Mar 11 2015, 6:05 AM

Feb 23 2015

Jjanes closed T72030: PostgreSQL: undefined method Status::clearFlag(), a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Resolved.
Feb 23 2015, 5:27 PM · PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms
Jjanes closed T72030: PostgreSQL: undefined method Status::clearFlag() as Resolved.
Feb 23 2015, 5:27 PM · MediaWiki-Installer, PostgreSQL

Feb 20 2015

Jjanes added a comment to T89171: Postgres SQL error comparing text and integer in getRangeCond() from includes/Block.php.

Also, could you show the versions of mediawiki, php, an postresql from the Special:Version page?

Feb 20 2015, 4:46 PM · PostgreSQL, Wikimedia-Rdbms

Feb 18 2015

Jjanes added a comment to T89171: Postgres SQL error comparing text and integer in getRangeCond() from includes/Block.php.

Can you describe what actions I must take from the Web UI to get this code to be invoked? I've blocked a single IPv4, blocked a IPv4 /24 range, queried for blocked users after doing so, and tried to create an account from a blocked IP, and couldn't get the problem to appear.

Feb 18 2015, 8:42 PM · PostgreSQL, Wikimedia-Rdbms
Jjanes committed rMW13fafa519207: PostgreSQL: Improve dropping of foreign key constraint (authored by Jjanes).
PostgreSQL: Improve dropping of foreign key constraint
Feb 18 2015, 5:03 PM

Feb 4 2015

Jjanes added a comment to T76254: Can't delete a page on 1.24.0 with postgresql 8.4 on CentOS 6.6.

Now I see why this problem was not caught by the unit test includes/EditPageTest.php

Feb 4 2015, 12:21 AM · PostgreSQL, MediaWiki-Tarball-Backports, Regression, Wikimedia-Rdbms

Jan 31 2015

Jjanes added a comment to T88097: Possible bug in DatabasePostgres.php: Check if rights for "standard_conforming_strings" are available.

Elsewhere it says that the minimum supported version is 8.3 (https://www.mediawiki.org/wiki/Manual:PostgreSQL). Perhaps we should increase it 9.0, as both 8.3 and 8.4 are now EOL.

Jan 31 2015, 9:39 PM · PostgreSQL, Wikimedia-Rdbms

Jan 28 2015

Jjanes committed rMWa9074bef8169: Import: Fix error reporting (authored by Jjanes).
Import: Fix error reporting
Jan 28 2015, 1:39 PM

Jan 13 2015

Jjanes committed rMW0d304c1bcacc: PostgreSQL: Fix Special:ActiveUsers GROUP BY query (authored by Jjanes).
PostgreSQL: Fix Special:ActiveUsers GROUP BY query
Jan 13 2015, 8:57 PM

Jan 7 2015

Jjanes committed rMW52328f043c3f: PostgreSQL: Fix Special:ActiveUsers GROUP BY query (authored by Jjanes).
PostgreSQL: Fix Special:ActiveUsers GROUP BY query
Jan 7 2015, 8:33 PM

Jan 6 2015

Jjanes updated subscribers of T70087: "ORDER BY" clause in query for Special:ActiveUsers throws PostgreSQL error: column "mwuser.user_name" must appear.
Jan 6 2015, 8:51 PM · PostgreSQL, MediaWiki-Tarball-Backports, Patch-For-Review, Wikimedia-Rdbms
Jjanes merged task T75568: column "mwuser.user_name" must appear in the GROUP BY clause or be used in an aggregate function into T70087: "ORDER BY" clause in query for Special:ActiveUsers throws PostgreSQL error: column "mwuser.user_name" must appear.
Jan 6 2015, 8:51 PM · PostgreSQL, Wikimedia-Rdbms

Dec 10 2014

Jjanes committed rEUWIe0a2a56482c4: UploadWizard: Add support for PostgreSQL (authored by Jjanes).
UploadWizard: Add support for PostgreSQL
Dec 10 2014, 6:36 PM
Jjanes committed rEMFRfe61a99e18e8: Fix watchlist query to work with PostgreSQL (authored by Jjanes).
Fix watchlist query to work with PostgreSQL
Dec 10 2014, 5:26 PM
Jjanes committed rEDPLc07df03b1e29: DynamicPageList: Use more standard LIMIT syntax (authored by Jjanes).
DynamicPageList: Use more standard LIMIT syntax
Dec 10 2014, 4:37 PM

Dec 8 2014

Jjanes added a comment to T74834: PostgreSQL install fails on INSERT IGNORE INTO "mediawiki"."updatelog" in update_keys.sql.

@saper, is there documentation or examples on how LoggedUpdateMaintenance is supposed to work? It has me completely baffled.

Dec 8 2014, 11:50 PM · PostgreSQL, Patch-For-Review, Wikimedia-Rdbms
Jjanes added a comment to T76254: Can't delete a page on 1.24.0 with postgresql 8.4 on CentOS 6.6.

What do you mean about us not testing against "a database that uses foreign key constraints"?

Dec 8 2014, 8:21 PM · PostgreSQL, MediaWiki-Tarball-Backports, Regression, Wikimedia-Rdbms

Dec 3 2014

Jjanes committed rMWb361796d07f7: PostgreSQL: Port update-keys.sql to PostgreSQL (authored by Jjanes).
PostgreSQL: Port update-keys.sql to PostgreSQL
Dec 3 2014, 7:54 PM

Dec 1 2014

Jjanes added a comment to T75568: column "mwuser.user_name" must appear in the GROUP BY clause or be used in an aggregate function.

A duplicate of T70087 (which has a stalled patch waiting for review/merge)

Dec 1 2014, 10:25 PM · PostgreSQL, Wikimedia-Rdbms
Jjanes added a comment to T76254: Can't delete a page on 1.24.0 with postgresql 8.4 on CentOS 6.6.

bug was introduced by change I1c7f3a84f10df05d6b37dccbad4c8232edf51580

Dec 1 2014, 9:16 PM · PostgreSQL, MediaWiki-Tarball-Backports, Regression, Wikimedia-Rdbms

Nov 27 2014

Jjanes committed rMW44b4b45bfa49: PostgreSQL: Port update-keys.sql to PostgreSQL (authored by Jjanes).
PostgreSQL: Port update-keys.sql to PostgreSQL
Nov 27 2014, 4:49 PM