Page MenuHomePhabricator

Joehoyle (Joe Hoyle)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 21 2018, 10:32 PM (321 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Joehoyle1 [ Global Accounts ]

Recent Activity

Feb 6 2024

Joehoyle added a comment to T351245: Memory exhaustion fatal causes PHP to segfault with Excimer.

It looks like this specific test case is causing a stack-overflow due to the call depth, via the recursive call in excimer_log_find_or_add_frame which tries to traverse the prev_execute_data. There is a guard for the depth, but only when maxDepth is set, which is default 0. I don't believe there's a simple way to detect the max call depth. I wonder if it would be better to just add a default depth, of say, 1000, and allow people to set it to 0 if for some reason they _really_ need to do that.

Feb 6 2024, 6:58 AM · MediaWiki-Platform-Team, Excimer

Feb 5 2024

Joehoyle added a comment to T351245: Memory exhaustion fatal causes PHP to segfault with Excimer.

This is the backtrace in the core dump:

Feb 5 2024, 3:43 PM · MediaWiki-Platform-Team, Excimer

Nov 26 2018

Joehoyle added a comment to T205059: Excimer: new profiler for PHP.

FYI I've been following along here, and I checked out the excimer build - super cool, worked well for me! I just had a question around the scope. When I tried it I noticed inbuilt PHP functions were not part of the sample, so if I have a function that calls sleep or curl_exec, I don't see this as part of the sample. I assumed this is because inbuilt functions use a different API. Is there plan to include inbuilt php functions in the samples?

Nov 26 2018, 4:05 PM · Platform Team Workboards (Done with CPT), serviceops, Platform Engineering (PHP7 (TEC4)), Excimer, Performance-Team (Radar), PHP 7.1 support

Mar 7 2018

Joehoyle added a comment to T176916: Set up sampling profiler for PHP 7 (alternative to HHVM Xenon).

If I understand the above numbers correctly, this is using xhprof_enable, which is orders of magnitude slower than xhprof_sample_enable. We're only using the latter. I'd recommend testing xhprof_sample_enable before looking at an out-of-process approach (incidentally I have tries this in the past with dtrace or similar to use os level markers, but never made good progress.)

Mar 7 2018, 2:01 AM · Platform Team Workboards (Done with CPT), PHP 7.1 support, Platform Engineering (PHP7 (TEC4)), Performance-Team

Feb 21 2018

Joehoyle added a comment to T176916: Set up sampling profiler for PHP 7 (alternative to HHVM Xenon).

I thought it would be good to share an update as I've been working on our XHProf rollout this week.

Feb 21 2018, 10:38 PM · Platform Team Workboards (Done with CPT), PHP 7.1 support, Platform Engineering (PHP7 (TEC4)), Performance-Team