Page MenuHomePhabricator

Jonathanischoice (Jonathan Harker)
Musician

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 27 2016, 12:25 AM (393 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jonathanischoice [ Global Accounts ]

Recent Activity

Fri, Mar 22

Jonathanischoice added a comment to T49578: Score should output SVG.

... have I gone mad, or have the Debian packages of lilypond 2.24 left out libcairo support? Is this some sort of torture?

Fri, Mar 22, 9:41 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Feb 4 2024

Jonathanischoice added a comment to T134455: Add experimental option for direct SVG output via srcset.

Should we close this ticket, given we now have wgSVGNativeRendering and related settings merged to master on T208578?

Feb 4 2024, 11:34 PM · Patch-For-Review, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering, Multimedia
Jonathanischoice added a comment to T257652: Add support for AVIF: serve AVIF thumbnails where possible.

Using the ImageMagick 6.9.11 implementation of encoding AVIF and HEIF (libavif 0.9.3, libheif 1.12.0) is still painfully slow, using a typical large photograph (extracted PNG from a Canon CR3 raw file):

$ file IMG_0652.png
IMG_0652.png: PNG image data, 6984 x 4660, 8-bit/color RGB, non-interlaced
$ time convert IMG_0652.png IMG_0652.avif
real    0m10.608s
user    0m29.370s
sys     0m2.031s
$ time convert IMG_0652.png IMG_0652.heif
real    0m17.438s
user    0m17.694s
sys     0m0.148s
$ time convert IMG_0652.png IMG_0652.jpg
real    0m0.756s
user    0m0.648s
sys     0m0.092s
Feb 4 2024, 10:06 PM · Thumbor, Commons, MediaWiki-File-management
Jonathanischoice added a comment to T257652: Add support for AVIF: serve AVIF thumbnails where possible.

I agree with @Trougnouf that this issue (use AVIF for thumbnails) shouldn't block progress on being able to upload AVIF files.

Feb 4 2024, 9:55 PM · Thumbor, Commons, MediaWiki-File-management

Nov 27 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

@Legoktm @TheDJ - is this likely to happen soon? I'm not sure I can help further other than annoy you by pinging... :-/

Nov 27 2023, 2:28 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Aug 22 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

Lilypond packages are now built with 2.24 in bookworm and trixie (and sid).

Aug 22 2023, 12:04 PM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

May 25 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

Given the patch on T208578, should we adjust Score's behaviour around serving SVG? So, rather than use srcset (see T134455) to provide SVG with a PNG fallback, we look for the new $wgSVGNativeRendering setting and just serve SVG directly. We'll still need Lilypond to generate PNG, but it is only served for older versions of Mediawiki (using the current srcset behaviour) or where the SVG generated by Lilypond exceeds the new $wgSVGNativeRenderingSizeLimit setting. Another possibility (useful for older versions of Mediawiki) is to detect the presence of the NativeSVGHandler extension and serve SVG directly if enabled. Thoughts?

May 25 2023, 12:25 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Mar 19 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

Fair enough. there seems to be promising recent activity on 1026200 anyway

Mar 19 2023, 11:20 PM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

Surely we can just pull the official upstream binary tarball from GitLab, extract it somewhere, and point LocalSettings.php variables at it? No Debian package required.

Mar 19 2023, 10:13 PM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Mar 17 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

You'll have to forgive my total lack of knowledge of Wikipedia internals and toolchains since I'm not an employee, I'm just a Wikipedia editor with an overinflated sense of enthusiasm and can code in PHP, so I offered to help with the Score extension. I'm not sure I'd be much use for most of that?

Mar 17 2023, 9:49 PM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T257652: Add support for AVIF: serve AVIF thumbnails where possible.

As it turned out, GIMP added AVIF support to version 2.10.22 in September 2020, see #2668.

Mar 17 2023, 9:30 PM · Thumbor, Commons, MediaWiki-File-management

Mar 16 2023

Jonathanischoice added a comment to T5593: [Epic] SVG client side rendering.

I've already done that. How do we get the new version of the Score extension deployed out to Wikipedia so we can enjoy our new SVG output?

Mar 16 2023, 9:36 AM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management
Jonathanischoice added a comment to T5593: [Epic] SVG client side rendering.

This ticket was opened in 2005, nearly twenty years ago. I would like to see T49578 Score SVG output on Wikipedia, hopefully some time before the sun runs out of hydrogen and engulfs our planet in a fiery apocalypse. What can I do to help?

Mar 16 2023, 7:51 AM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management

Mar 5 2023

Jonathanischoice added a comment to T259210: LilyPond safe mode escape due to output-def-lookup and output-def-scope (CVE-2020-17354).

I can reproduce this now... sorry about the noise :)

Mar 5 2023, 11:16 PM · MediaWiki-extensions-Score, Security, Security-Team

Mar 2 2023

Jonathanischoice added a comment to T134455: Add experimental option for direct SVG output via srcset.

That's all well and good, in that case, how are we to advance T5593 which has been languishing since 2005? That's nearly twenty years. I would like to see SVG Score output hopefully some time before the sun runs out of hydrogen and engulfs our planet in a fiery apocalypse.

Mar 2 2023, 9:53 PM · Patch-For-Review, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering, Multimedia
Jonathanischoice added a comment to T134455: Add experimental option for direct SVG output via srcset.

@TheDJ - regarding Score SVG output, T49578 has been merged, but is still open. Not sure what happens now, but this would be a good test for using img srcset, since that's what we implemented in Score.

Mar 2 2023, 9:36 AM · Patch-For-Review, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering, Multimedia
Jonathanischoice added a comment to T49578: Score should output SVG.

This was merged over 2 months ago, what happens next? I'd like to get T134455 advanced so we can get on with SVG Score output somehow.

Mar 2 2023, 9:33 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Feb 3 2023

Jonathanischoice added a comment to T134407: Provide a way to reference fonts for client-side SVG rendering.

+1 for @Glrx's answer to close; if you want exact PDF-like font rendering, convert it to curves and use parallel hidden text elements if you need the SVG to be indexed in full-text search data. If you want exact rendering and have big walls of text, perhaps you want a PDF file...?

Feb 3 2023, 4:42 AM · Commons, Multimedia, Wikimedia-SVG-rendering, MediaWiki-File-management
Jonathanischoice added a comment to T134410: Evaluate SVG rendering compatibility in browsers.

Shall we close this, then?

Feb 3 2023, 4:36 AM · Commons, Multimedia, MediaWiki-File-management, Wikimedia-SVG-rendering

Jan 21 2023

Jonathanischoice added a comment to T259210: LilyPond safe mode escape due to output-def-lookup and output-def-scope (CVE-2020-17354).

Don't ask me, I didn't write these PoCs, and I don't know much about Lilypond's use of Scheme, or anything at all about Scheme. I'm just trying to get some PHP code to render music using LilyPond. So does that mean I should see spurious id output in logging?

Jan 21 2023, 11:07 AM · MediaWiki-extensions-Score, Security, Security-Team

Jan 20 2023

Jonathanischoice added a comment to T259210: LilyPond safe mode escape due to output-def-lookup and output-def-scope (CVE-2020-17354).

Debian packaging request for 2.24 in bookworm: 1026200

Jan 20 2023, 3:03 AM · MediaWiki-extensions-Score, Security, Security-Team
Jonathanischoice added a comment to T259210: LilyPond safe mode escape due to output-def-lookup and output-def-scope (CVE-2020-17354).

After a bit of testing, and assuming I should be seeing the system id in the rendered music if this is still vulnerable, I can't reproduce Tim's original PoC or the Notehead hack in Han-Wen's above comment on the following:

Jan 20 2023, 2:38 AM · MediaWiki-extensions-Score, Security, Security-Team

Jan 19 2023

Jonathanischoice added a comment to T259210: LilyPond safe mode escape due to output-def-lookup and output-def-scope (CVE-2020-17354).

Forgive me for wading in from the sidelines with very little dev context as a lowly Wikipedia editor, but I can't reproduce this on 1.39 LTS with Score on the latest master using LilyPond 2.24.
Since the Score extension requires LilyPond 2.24 for supporting SVG output (T49578) which is blocking T181322, T259208, and possibly others, would it be the case that if we upgrade the Score shellbox instances to use LilyPond 2.24 instead, this issue can be resolved? Upstream LilyPond have changed their release process and now issue (64-bit only) binary tarball releases from their GitLab repository directly, which may or may not be helpful.

Jan 19 2023, 4:05 AM · MediaWiki-extensions-Score, Security, Security-Team
Jonathanischoice added a comment to T181322: Improve Score's HTML output so PDF export can render music scores natively, i.e. not as images.

Update: support for SVG output using LilyPond 2.24 has been added to the master and REL1_39 branches of the Score extension (T49578).

Jan 19 2023, 2:20 AM · Product-Infrastructure-Team-Backlog-Deprecated, Proton, All-and-every-Wikisource, Multimedia, OCG-PDFRenderer, MediaWiki-extensions-Score
Jonathanischoice added a comment to T259208: PDF export should render music scores natively, i.e. not as images.

Support for SVG output (with LilyPond 2.24) is now in the Score extension, in REL1_39 and master branches. Not sure what needs to happen before it gets deployed to Wikipedia/media anywhere, though.

Jan 19 2023, 1:53 AM · MediaWiki-extensions-Score, WS Export

Jan 9 2023

Jonathanischoice added a comment to T49578: Score should output SVG.

Noting here that LilyPond 2.24.0 was released 16 December 2022 - changes. Shall we boldly create an "Update LilyPond in Shellbox container to 2.24" task, similar to the previous one?

Jan 9 2023, 11:11 PM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T60688: (Piano)Staff.instrumentName=#"Clarinet" returns only the 4 or 5 last characters.

Just confirming that I cannot reproduce this (bug?) with LilyPond 2.23.82 and the Score extension from recent master (commit adee410, 14 December 2022) using SVG output.

Jan 9 2023, 11:00 PM · MediaWiki-extensions-Score

Dec 15 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

Hooray :) Now I have a thought about what to do with the existing PNG renders that are being used on pages until they are next edited. Is it possible to create some sort of maintenance task that can process the image store in the background, generating any missing SVG files using the preserved LilyPond file?

Dec 15 2022, 4:36 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Dec 7 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

Ok, so it turns out we don't even need to get the page size at all, because that was only being used by GhostScript to generate the PNG from the PS output, which we're not doing in this patch. Have pushed an all-in-one commit to Gerrit. I can't see how to easily add a comment to a Gerrit MR, hence the chattiness here (sorry?)

Dec 7 2022, 6:44 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Dec 6 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

I've pushed two commits ready for review - @TheDJ and @tstarling. Still not sure what the procedure is here; it's been ages since I've had to use Gerrit. Test instance here.
Also: is it worth smooshing them together into one commit?

Dec 6 2022, 2:51 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Dec 5 2022

Jonathanischoice added a comment to T198363: Consider ways to integrate with federated social networks.

Also, putting a star on a Wikimedia Commons file would be nice.

Dec 5 2022, 7:03 AM · MediaWiki-extension-requests

Dec 4 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

I've resolved several things, and pushed an update to Gerrit. I've also found that we don't even need the --ps output and GhostScript any more, because we can fetch the same page size information from the <svg> attributes.

Dec 4 2022, 3:11 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Dec 1 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

Thanks @TheDJ !

Dec 1 2022, 10:15 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

This is still a WIP:

  • after the rebase to master, I followed my nose and removed the shell trim code that uses convert, and thus also the ImageMagick dependency altogether.
  • I'm still working on paginated output, which is also trimmed correctly in both the SVG and PNG, but it is not currently adding the SVG page images.
  • I haven't even looked at the tests yet, so I guess they'll be failing; so much for TDD :)
  • I suspect that just using --png instead of deriving them from --ps will also make a bunch more code redundant, and even remove the GhostScript dependency, but I haven't tried that yet.
Dec 1 2022, 4:11 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

Ah yes... I remember now. It's been years since I used gerrit... oh, and I need to rebase to master, which will take a while because change

Dec 1 2022, 2:53 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

@Aklapper - I get this, and I'm not sure where/who to post or contact:

remote: error: branch refs/heads/generate-svg:
remote: You need 'Create' rights to create new references.
remote: User: jonathanischoice
remote: Contact an administrator to fix the permissions
remote: Processing changes: refs: 1, done    
To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score
 ! [remote rejected] generate-svg -> generate-svg (prohibited by Gerrit: not permitted: create)
error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score'
Dec 1 2022, 2:41 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T5593: [Epic] SVG client side rendering.

I guess I'm only talking about the rendering of an uploaded SVG image, that would be used by [[File:some_image.svg | thumb | etc.]] - which is what $wgSVGConverter is dealing with. It would be up to the uploader to ensure they embedded their fonts or converted their glyphs to paths properly. I'm not sure what impact translation would have. Perhaps we do need to split this task into "support native uploaded SVG image rendering without PNG thumbs" which is basically emulating the behaviour of the NativeSvgHandler extension (I haven't looked at the code to see how it works), and keep this bug as "support embedded SVG in the markup"? Seems to me they are two separate problems, with different concerns applying to each.

Dec 1 2022, 2:12 AM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management

Nov 30 2022

Jonathanischoice added a comment to T5593: [Epic] SVG client side rendering.

Forgive me if I'm posting on the wrong bug, or if this seems naïve, but SVG images (as a src for <img> tags at least) are supported by basically all of the things now (even IE 11 is passable as long as it's not animated):
https://caniuse.com/?search=svg

Nov 30 2022, 9:31 PM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management
Jonathanischoice added a comment to T49578: Score should output SVG.

Here's a 1.35 instance with the 1.35 SVG patch installed:
https://rel1-35.home.jon.geek.nz/wiki/Score_examples

Nov 30 2022, 5:59 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

I can't seem to be able to push to Gerrit; in the meantime, the very basic diff is displayed here on GitLab. This should work as long as you have a 2.24 RC version of Lilypond; I have been testing with the 2.23.82 release.

Nov 30 2022, 3:55 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score
Jonathanischoice added a comment to T49578: Score should output SVG.

I have a sneaking suspicion that unless we are really still wanting to support really old unsupported browsers, like Internet Explorer 11, we really don't need a PNG fallback. SVG images are supported by basically all of the things, and even IE 11 is passable as long as the SVG is not animated:
https://caniuse.com/?search=svg

Nov 30 2022, 3:45 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Sep 23 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

Noting here the upstream progress on including the Cairo backend in Lilypond by default: merge request 1610, and lilypond-devel discussion thread.

Sep 23 2022, 4:06 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Aug 16 2022

Jonathanischoice added a comment to T49578: Score should output SVG.

Is there anything I can do to help this along? I'm a PHP dev with a little time on my hands currently, but it seems as if this is more to do with aligning SVG rendering libs on container OSes? Let me know if I can help in some way. Is this changeset still useful, or has it been superceded by more recent work?

Aug 16 2022, 12:28 AM · Upstream, Wikimedia-SVG-rendering, MediaWiki-extensions-Score

Apr 9 2022

Jonathanischoice updated Jonathanischoice.
Apr 9 2022, 3:14 AM
Jonathanischoice updated Jonathanischoice.
Apr 9 2022, 3:13 AM

Oct 14 2016

Jonathanischoice created T148113: Missing wikimedia/base-convert dependency.
Oct 14 2016, 3:26 AM · MediaWiki-extensions-Score