Page MenuHomePhabricator

Jongfeli (Felipe de Jong)
User

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Sunday

  • No visible events.

User Details

User Since
Oct 25 2014, 5:39 AM (586 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jongfeli [ Global Accounts ]

Recent Activity

Nov 12 2024

Jongfeli closed T379228: Wikieditor layout broken in a form under MW-1.43.0 as Invalid.

Okay, I was trying to figure out what was causing this when the problem suddenly disappeared!

Nov 12 2024, 2:34 PM · MediaWiki-extensions-Page_Forms

Nov 11 2024

Jongfeli added a comment to T379228: Wikieditor layout broken in a form under MW-1.43.0.

It is coming from the WikiEditor extension, in ...\extensions\WikiEditor\modules\jquery.wikiEditor.toolbar.less

Nov 11 2024, 11:44 AM · MediaWiki-extensions-Page_Forms

Nov 8 2024

Jongfeli added a comment to T379228: Wikieditor layout broken in a form under MW-1.43.0.

Okay, I think I found the "problem". Another form on our wiki was working just fine with Wikeditor. The reason was that it was wrapped inside a table with the formtable class.

Nov 8 2024, 10:06 AM · MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T379228: Wikieditor layout broken in a form under MW-1.43.0.

Hi Yaron, we use Vector legacy but it also happens in the 2022 version of the Vector skin. After some investigation I do see that when Wikieditor is used in a form the "Preview" and "Switch editor" options are not loaded with <div class="group group-default empty" rel="default"></div>. As of there the height: 100%; is "causing" this issue. When you set it to height: 0%; it works.

Nov 8 2024, 8:05 AM · MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T379226: Visual Editor not loading in a form under MW-1.43.0.

Hello Yaron, my mistake, we did not have $wgDefaultUserOptions['visualeditor-enable'] = 1; in LocalsSettings.php, we never did but when it is in there it works just fine. Case of reading the manual again after upgrading because things can change, and did back in February. That said, why does VeForAll use this flag, is it not the same or enough if a user enables Visual editor in their preferences? I assume that this is a VisualEditor and not a VeForAll parameter that is now used to enable VeForAll in forms. Logic tells me that if I use VeForAll I have the intention of using it in forms when needed. Why the extra on off switch?

Nov 8 2024, 6:43 AM · MediaWiki-extensions-Page_Forms

Nov 7 2024

Jongfeli created T379228: Wikieditor layout broken in a form under MW-1.43.0.
Nov 7 2024, 8:16 AM · MediaWiki-extensions-Page_Forms
Jongfeli renamed T379226: Visual Editor not loading in a form under MW-1.43.0 from Visual Editor not loading in 1.43.0 to Visual Editor not loading in a form under MW-1.43.0.
Nov 7 2024, 8:11 AM · MediaWiki-extensions-Page_Forms
Jongfeli updated the task description for T379226: Visual Editor not loading in a form under MW-1.43.0.
Nov 7 2024, 8:10 AM · MediaWiki-extensions-Page_Forms
Jongfeli created T379226: Visual Editor not loading in a form under MW-1.43.0.
Nov 7 2024, 8:07 AM · MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T377307: No newline before {{{for template}}} or {{{end template}}} tags leads to PHP warning.

As for the tags, to prevent any unintended linefeeds or white space from appearing on a page or a form I always put wiki code inline in templates and forms, when possible.

Nov 7 2024, 7:23 AM · MediaWiki-extensions-Page_Forms

Nov 6 2024

Jongfeli added a comment to T377307: No newline before {{{for template}}} or {{{end template}}} tags leads to PHP warning.

To answer your question, with the below two examples there are no offset messages.

Nov 6 2024, 7:15 AM · MediaWiki-extensions-Page_Forms

Nov 5 2024

Jongfeli added a comment to T377307: No newline before {{{for template}}} or {{{end template}}} tags leads to PHP warning.

Hello @Yaron_Koren, no problem there is no hurry. Just trying to be better prepared for the next LTS version of MW.

Nov 5 2024, 8:02 AM · MediaWiki-extensions-Page_Forms

Oct 16 2024

Jongfeli created T377307: No newline before {{{for template}}} or {{{end template}}} tags leads to PHP warning.
Oct 16 2024, 6:54 AM · MediaWiki-extensions-Page_Forms

Oct 11 2024

Jongfeli added a comment to T376778: __NOEDITSECTION__ breaks tabs in MW 1.43.

That solved the problem, thanks for the fix. For the next MW LTS version we want to be better prepared and check what is working and what is not. Thanks again :-)

Oct 11 2024, 5:21 AM · MediaWiki-extensions-HeaderTabs

Oct 9 2024

Jongfeli created T376778: __NOEDITSECTION__ breaks tabs in MW 1.43.
Oct 9 2024, 8:15 AM · MediaWiki-extensions-HeaderTabs

Oct 3 2024

Jongfeli placed T375993: EDConnectorDb::processField(): Return value must be of type string, null returned up for grabs.
Oct 3 2024, 5:24 AM · MediaWiki-extensions-ExternalData
Jongfeli closed T375993: EDConnectorDb::processField(): Return value must be of type string, null returned as Resolved.

This is now fixed, thank you Alexander

Oct 3 2024, 5:12 AM · MediaWiki-extensions-ExternalData

Sep 30 2024

Jongfeli added a watcher for MediaWiki-extensions-ExternalData: Jongfeli.
Sep 30 2024, 6:23 AM
Jongfeli created T375993: EDConnectorDb::processField(): Return value must be of type string, null returned.
Sep 30 2024, 6:13 AM · MediaWiki-extensions-ExternalData

Nov 24 2022

Jongfeli closed T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows as Resolved.
Nov 24 2022, 12:30 PM · MediaWiki-Core-AuthManager, MediaWiki-Configuration
Jongfeli closed T58987: importImages.php does not actually upload previously deleted files. as Resolved.
Nov 24 2022, 12:30 PM · MediaWiki-Maintenance-system

Dec 9 2020

Jongfeli added a comment to T250862: PageForms with 1.34 and editor=wikieditor does not work.

@Nikerabbit, thanks for the fix. This also works in MW-1.35.0

Dec 9 2020, 8:00 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), WikiEditor (2010), MediaWiki-extensions-Page_Forms

Oct 22 2020

Jongfeli added a comment to T250862: PageForms with 1.34 and editor=wikieditor does not work.

Please see: https://www.mediawiki.org/wiki/Topic:Vpc33mge6vajhi3s

Oct 22 2020, 8:01 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), WikiEditor (2010), MediaWiki-extensions-Page_Forms

Oct 20 2020

Jongfeli added a comment to T250862: PageForms with 1.34 and editor=wikieditor does not work.

I am a little confused. I remembered this problem but back then (in 2018) it seemed to be fixed by adding the following to a form:

Oct 20 2020, 12:54 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), WikiEditor (2010), MediaWiki-extensions-Page_Forms

Jun 30 2017

Jongfeli added a comment to T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.

A short update for the people interested. After some testing we found out that when using mod_fcgid.so instead of php7apache2_4.dll to handle PHP it works just fine and more important it keeps working fine.

Jun 30 2017, 11:54 AM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Feb 28 2017

Jongfeli added a comment to T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.

@smkent could you be more specific on your configuration, which linux distro are you using and which version?

Feb 28 2017, 1:01 PM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Jan 24 2017

Jongfeli added a comment to T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.

Ok, did some digging again. I tested this on:

Jan 24 2017, 7:19 AM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Dec 30 2016

Jongfeli added a comment to T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.

Hello @Paladox, thanks for your fix. I understand that restarting Apache helps but only for a short while. After x time the same things happens again.

Dec 30 2016, 7:17 PM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Dec 23 2016

Jongfeli added a project to T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows: MediaWiki-libs-BagOStuff.

Ok, I have spend some time trying to debug this one and found out that I can reproduce the above error only when Zend OPcache is enabled. The fault pops up after x time.

Dec 23 2016, 10:11 AM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Dec 7 2016

Jongfeli updated the task description for T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.
Dec 7 2016, 9:17 AM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Dec 6 2016

Jongfeli updated the task description for T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.
Dec 6 2016, 2:51 PM · MediaWiki-Core-AuthManager, MediaWiki-Configuration
Jongfeli created T152502: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows.
Dec 6 2016, 2:49 PM · MediaWiki-Core-AuthManager, MediaWiki-Configuration

Oct 11 2016

Jongfeli created T147840: Use of "wgWikiEditorEnabledModules" is deprecated. Use mw.config instead. (in SF_wikieditor.js).
Oct 11 2016, 11:41 AM · MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, MediaWiki-extensions-Page_Forms

Sep 8 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

When you wrote "most wiki's using SF work exactly as you describe", do you mean that most wikis use default values when editing existing pages?

Sep 8 2016, 2:31 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Hello Yaron, a comment:

Sep 8 2016, 11:49 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Sep 2 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Jongfeli: I really don't think it's true that default values were added when editing existing pages, in all SF versions before 2.4.1. In any case, as I've said before, it doesn't matter what SF used to do. (I thought you agreed with me on that, but I guess you changed your mind.)

Sep 2 2016, 8:35 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Aug 31 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

My work with SMWikis would not be possible and the acceptance in my department for such wikis would not be there without Semantic Forms. Therefore, I am immensly grateful, that this powerful extension exists and that Yaron and others spend so much time maintaining and developing it.

Aug 31 2016, 9:33 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Well you are making it very hard for me here :) The saveblank option was merely a suggestion.

Aug 31 2016, 6:27 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Aug 30 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Hello Yaron, are there any plans to get the default value fixed for all pages, new and existing like discussed here?

Aug 30 2016, 8:49 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 20 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

I understand but in my opinion it is the right behavior because that is where the default value is for. However you are right, in your example Bob will be working in the "wrong" department after Charlie edited his page :) Which is probably incorrect. An SMW wiki is as good as the people who build it:

Jun 20 2016, 6:49 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 17 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Ok , you are right, the past is the past :)

Jun 17 2016, 3:00 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Yes that is possible but the feature is to be able to alter the parameters in the field tag including the default in a form and that these changes apply to existing and new pages. This feature has always been part of SF before 2.7, you where always able to alter forms anyway you wanted and this also applied to the defaults.

Jun 17 2016, 1:59 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Ok, well initially the blank value will not be replaced by the default when the page is edited. Only when the page is edited again the default will be used because, by that time, the field is not on the page anymore. Any empty field that is stored on the page will disappear anyway when pages are edited with SF 2.7 and higher.

Jun 17 2016, 1:26 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

No I don't think so. Fact is that empty fields are not saved on the page anymore since SF 2.7. To me this seems to be the correct behavior.

Jun 17 2016, 10:21 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 16 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

No, I do not think it is wise to change this empty field behavior back to he way it was years ago. The default values in the field tag used to work just fine on new and existing pages, it is not a new feature I am merely trying to fix it :)

Jun 16 2016, 1:25 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 15 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

No, the field is not in the page source when it has a blank value. you can test this in the SMW sandbox by entering a value for Defaultvalue1 saving the page and then blanking the value in the next edit.

Jun 15 2016, 7:38 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 14 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Yes I did but I think it is the story of the chicken or the egg. If your example page was created with SF without a value for ABC then it is not saved on the page like ABC= (no value). You can not check something that is not there. If you would manually add ABC= (no value) to the page in the template call and the field has a default value in the form then it will be shown in the form as soon as you edit the page with SF. If you then delete the default value again and save the page with no value for ABC it will be deleted from the template call. I must say that we always use parameters with an empty default on its own like: {{{parameter|}}}.

Jun 14 2016, 7:30 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

#1. I don't understand. With the patch applied I tried to replicate this but on our wiki the default values used in the form are showing up in the actual form and on the saved page. The patch seems to be working fine. It works with the edit with form tab (for existing pages) or {{#forminput:... for new and existing pages. I tried this on a blank wiki with the following extensions (installed with composer).

Jun 14 2016, 1:48 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms

Jun 13 2016

Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Yes you are right but in the past I tried this under windows but did not succeed but now it seems to have worked, I hope :)

Jun 13 2016, 3:25 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli updated the task description for T137701: Fix default value for field tag, for existing and new pages..
Jun 13 2016, 12:11 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a comment to T137701: Fix default value for field tag, for existing and new pages..

Changes from line 1031 till 1066.

Jun 13 2016, 11:55 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli created T137701: Fix default value for field tag, for existing and new pages..
Jun 13 2016, 11:53 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
Jongfeli added a watcher for MediaWiki-extensions-Page_Forms: Jongfeli.
Jun 13 2016, 11:46 AM

Nov 12 2015

Jongfeli updated subscribers of T97023: "Regular expression filter" not working anymore in MW-1.24.2.
Nov 12 2015, 8:51 AM · MediaWiki-extensions-SemanticFormsInputs

Oct 23 2015

Jongfeli closed T113724: Deprecated : Methods with the same name as their class when used with PHP 7 as Resolved.
Oct 23 2015, 7:24 AM · Technical-Debt, MediaWiki-extensions-DataTransfer
Jongfeli added a comment to T113724: Deprecated : Methods with the same name as their class when used with PHP 7.

It has been fixed with this commit. Thanks Yaron.

Oct 23 2015, 7:23 AM · Technical-Debt, MediaWiki-extensions-DataTransfer

Sep 25 2015

Jongfeli updated subscribers of T113724: Deprecated : Methods with the same name as their class when used with PHP 7.
Sep 25 2015, 1:08 PM · Technical-Debt, MediaWiki-extensions-DataTransfer
Jongfeli created T113724: Deprecated : Methods with the same name as their class when used with PHP 7.
Sep 25 2015, 12:58 PM · Technical-Debt, MediaWiki-extensions-DataTransfer

Apr 23 2015

Jongfeli added a comment to T97023: "Regular expression filter" not working anymore in MW-1.24.2.

No, no Javascript errors. I do see a difference in the HTML code, maybe that can be of help.

Apr 23 2015, 1:29 PM · MediaWiki-extensions-SemanticFormsInputs
Jongfeli created T97023: "Regular expression filter" not working anymore in MW-1.24.2.
Apr 23 2015, 12:44 PM · MediaWiki-extensions-SemanticFormsInputs

Feb 17 2015

Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

@ori yes I am OK with that, no problem. The problem was that the latest version was in the tar download for MW 1.24.1 but that does not seem to be the case anymore.

Feb 17 2015, 10:39 AM · HHVM, Performance Issue, SyntaxHighlight

Jan 27 2015

Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

See: T85794

Jan 27 2015, 7:47 PM · HHVM, Performance Issue, SyntaxHighlight
Jongfeli updated the task description for T87544: Performance issues with SyntaxHighlight under HHVM.
Jan 27 2015, 7:45 PM · HHVM, Performance Issue, SyntaxHighlight
Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

SyntaxHighlight version from April 2014 works like expected, it has basically no impact on performance. Below that version compared to Master without any caching enabled. It adds +/- 600 ms to loading times.

Jan 27 2015, 7:49 AM · HHVM, Performance Issue, SyntaxHighlight

Jan 26 2015

Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

Added one more test on the same hardware comparing the same setups but with and without SytaxHighlight enabled on an otherwise "empty" wiki (see: sandbox). It is not a specific HHVM "problem", it affects all solutions except XCache with object caching enabled. It seems that the "cause" is javascript that takes a relatively long time to load (see below).

Jan 26 2015, 6:51 PM · HHVM, Performance Issue, SyntaxHighlight
Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

Small update. What triggered me was the fact that HHVM is faster then any other caching solution we used before. We are running our wiki on a windows server so HHVM is not happening at the moment. To compare and build a case to switch to a Linux OS I compared the different solutions to show what an impact it can have. On a clean wiki HHVM is faster then XCache with object caching enabled but when SyntaxHighlight is enabled this changes dramatically. Posted the results from yesterday in my sandbox.

Jan 26 2015, 11:53 AM · HHVM, Performance Issue, SyntaxHighlight

Jan 25 2015

Jongfeli added a comment to T87544: Performance issues with SyntaxHighlight under HHVM.

It has not been brought op on the talk page as far as I know. I have access to our production wiki tomorrow and will do the same test and post the result here, when time permits. But when this is really happening it should be relatively easy to reproduce on any "test" wiki. It would be a good thing if somebody else can confirm the same behaviour.

Jan 25 2015, 9:15 PM · HHVM, Performance Issue, SyntaxHighlight
Jongfeli created T87544: Performance issues with SyntaxHighlight under HHVM.
Jan 25 2015, 8:22 PM · HHVM, Performance Issue, SyntaxHighlight

Jan 8 2015

Jongfeli updated the task description for T86156: maintenance/updateSearchIndex.php gives Error: 1100 Table 'page_restrictions' was not locked with LOCK TABLES.
Jan 8 2015, 12:24 PM · MW-1.25-release, Patch-For-Review, MediaWiki-Maintenance-system
Jongfeli created T86156: maintenance/updateSearchIndex.php gives Error: 1100 Table 'page_restrictions' was not locked with LOCK TABLES.
Jan 8 2015, 12:20 PM · MW-1.25-release, Patch-For-Review, MediaWiki-Maintenance-system