Mon, Oct 12
Sun, Oct 11
Thu, Oct 8
@Pginer-WMF what should happen on smaller phones?
I think shrinking the image is the easiest approach instead of touching the text
still being cut on iphone 5/SE
putting back into dev, @ngkountas let me know if that's ok
waiting for feedback on https://github.com/wikimedia/wikipedia-preview/pull/70#issuecomment-705742535
waiting for a comment reply on github
Wed, Oct 7
That’s not mentioned anywhere in the task.
And we’re talking about real problems that happened to our teams so not an experiment, something really needed
My main concerns with this is (something that happened in both my teams):
Mon, Oct 5
Fri, Oct 2
@SGautam_WMF is the font type the same in 1 and 2? It seems a bit different to me
Can we ping someone from that team to check if they have any unit or integration tests?
Make 0 sense to me for us to be creating tests for other teams work
Thu, Oct 1
What's the purpose of this?
Who's the tester in the api team? or a better question, who's the team owner of this api endpoints?
saving process adds blank paragraphs.
(had to upload to google drive because the file was too big for phab)
is this something to:
- fix on our side on this task
- other task
- VE team
I'm sure there must be but it's the first time I'm using this so no idea how to do that.
I'll try a few more things but since you're able to do it with that software I think we're good.
Is this what's supposed to show?
(the text inside the grey box is the text spoken out loud by the voice over software on mac)
Wed, Sep 30
I see this query parameter but don't see the x-analytics part
Should Neil test this?
merging the code but leaving it in QA to check IE11 once deployed
Tue, Sep 29
Mon, Sep 28
moving back to QA since this wasn't deployed correctly before
moving back to QA for testing since before wasn't correctly deployed
waiting for feedback on https://github.com/wikimedia/wikipedia-preview/pull/70#issuecomment-700316653
I accessed the URL and checked logstash for logs and couldn't find anything around the time I used the URL.
The URL leads to a new translation and there's one user with a translation started already so I can't load the translation .
I can replicate the issue:
there's a white space after the "next" button that is not in the designs.
Fri, Sep 25
- edit translation button is not blue
- previous action doesn't select the previous sentence, just unselects the sentence
Thu, Sep 24
@ngkountas where can I find this panel?
moving this to done since it's being fixed on T263584
moving back to dev because there's still a race condition issue as shown here
closing because is a duplicate of T259490
I have a feeling this will appear more times throughout the app, can @ngkountas or @santhosh tell us why this is happening?
Is it like a default state for the component that then gets updated? if that's the case we should think about setting the default to a loading gif or something so that doesn't happen
Wed, Sep 23
@ngkountas can you give me some more info about the error?
I'm trying to get more info from the code but it's minified
Should I create a task for the VE team?
Tue, Sep 22
So the inspector being cropped in the first example is more an artifact of viewing the desktop version on a narrow viewport. I think this is more for the Editing team to consider whether to make use of the mobile format on narrow screens (not only based on device). If we found the issue affecting our users in any way we can ping the Editing team or explore alternatives. For now, I don't think we need to do anything in this front.
this is tested and merged, can I move it to done?
Mon, Sep 21
1- when we select "Start with an empty sentence, it seems that VE is going to show up but it doesn't
2- VE shows up cut when we select a link to edit
on mobile VE shows up like this (at the bottom of the page) when we select a link
3- I don't understand this part right now I don't see any difference when I select a word or put the cursor somewhere
4- no warning shows after I do changes and click cancel
5- I fixed the description and the designs image so only what is to be done and tested on this task is in the task
Sep 20 2020
Sep 19 2020
This has broken the image selection: when selected, the image moves, sometimes to a different page.
I can't reach this screen on mobile devices because I can't skip the tutorial screens T262665.
On chrome devtools the "edit translation" button shows black instead of blue as is defined in the designs
@ngkountas can you point me to where I can see this "new section" banner?
I can't find it
@ngkountas how do I arrive at that screen?
the "Edit translation" button does nothing and the "Start with an empty sentence" doesn't as well
Sep 18 2020
Most may be aspects to support later as follow-up tickets (some left out intentionally by developers for future iterations), but I think it is worth flagging and capturing in tickets to avoid those falling to the cracks.
In T259503#6470374 I reported some issue I found on first sight that were not flagged during QA but I had not looked into all details of the spec for the ticket (spacing, functionality, transitions). So I thought it would be good for you to check in QA since I'm not sure how deeply that was reviewed the first time (notes about that would be helpful in general to facilitate coordination).
can't add the test right now, everything explained in the PR
Firefox 81 1280x800 gets cut on the bottom
You should able to scroll down to see the content, no?
Sep 17 2020
that fixed it, I can now have all images up and running.
now I'm able to reach 0.0.0.0:8090.
on 0.0.0.0:8080 I still get this
note the url, there's a double / , not sure that's the cause.
we're getting close though!