Fri, Jan 17
Wed, Jan 15
the fix won't come for this task
Tue, Jan 14
waiting for a fix for this case
@KartikMistry how can I know when this is going to be deployed?
the tag on the tag (wmf11) doesn't have the latest code
@abi_ is this now deployed on language-translate.wmflabs?
Mon, Jan 13
In order to prevent future regressions, it would be great to apply some automatic testing.
Sun, Jan 12
Fri, Jan 10
@hueitan moving this to dev to accommodate Angie's request
@hueitan when the phone doesn't have an internet connection and we try to go to a new article, the gif shows and doesn't disappear.
Although this is not entirely bad, maybe in this case we should put a different message?
The default size is the smallest size.
Shouldn't we allow to make it smaller, like the default being a middle ground?
From the code I see we can change it from 0 to 6, 0 being the default.
Maybe we can do from 0 to 10, 5 being the default (equivalent to 0 now) so we can decrease the current size.
These 2 links don't get translated
They don't seem to be present on the translation files
<div class='article-actions'> <div class='article-actions-button' data-action='sections'> <img src='images/sections.svg' /><br /> <label>Sections</label> </div> <div class='article-actions-button' data-action='quickfacts'> <img src='images/quickfacts.svg' /><br /> <label>Quick Facts</label> </div> </div>
Thu, Jan 9
I just tried with a brand new user, not changing the language and going to https://jv.wikipedia.org/w/index.php?title=Paneer&action=edit and the special invite is showing.
I believe this is not supposed to be happening.
the results of your query are:
mw.config.get( 'wgContentTranslationExistingTranslator' ) false mw.config.get( 'wgContentTranslationNewByTranslationShown' ) "true"
I forgot to change the text of the 2nd case links, updated the comment now.
On the 2nd case the article does not exist in another language
Wed, Jan 8
@santhosh currently, if I
@KartikMistry can u deploy this on language-translate.wmflabs.org so I can test it please?
Fri, Jan 3
waiting for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/559795/ to be merged to move this task to DONE
Thu, Jan 2
When I change the language of the article the language in the app doesn't change.
Is this expected?
can be confusing for the user to have 2 different places to change the language and only one of them changes the actual language of the app (specially since when we go back to the search it is in the previous language).
Tue, Dec 31
yes, I checked your branch now and it is ok.
we need to discuss with @SBisson the right flow for us:
Dev->CR->Merge PR->QA in master
Dev->CR->QA->Merge PR->QA in master.
@hueitan this is still not working, if you don't understand the expected behaviour feel free to reach out for more details.
Updating steps with new button:
Mon, Dec 30
the preview shows the text but the actual page does not load
Dec 20 2019
@hueitan can you see if this is fixable within this task?
The screen shifts right a few pixels when we enter this section (one page down after the section title page) and then the images creeps through on the left side.
T241148 was created to solve the issue of the last comment, moving this to done
Dec 19 2019
I'm not sure this is something related or not.
Here I see the same image twice, once as the background (which I think you mentioned this is how it's supposed to look like) and then as the image on the article.
It's nice that we're showing an image as the background for the section, but in this case it looks a bit weird.
UPDATE: I was checking now on android and they don't show any image on the background, they put the title and subtitle and then the first image from the section. IMO it looks cleaner and if we push the title and subtitle to the top of the page we can a bit of space and we can put the image in (maybe decrease the size of the text a bit?)
Dec 18 2019
minor improvement to be done on T240992, moving this to done
@SBisson this is a parent task, correct?
should be the last one to be moved into QA / done only when all the child tasks are done?
if so I'll move to in progress before all the others are done
Dec 17 2019
@AMuigai is it ok that the articles go back to the beginning when we reach the end (and continue scrolling down after that)?
Dec 12 2019
@santhosh @Petar.petkovic the 2 references show up correctly on cx but once we publish, the second reference doesn't show.
Dec 11 2019
Dec 10 2019
Dec 2 2019
added a cypress test for this https://github.com/wikimedia/wikipedia-kaios/pull/17
Nov 28 2019
Nov 19 2019
Nov 18 2019
Nov 15 2019
@Petar.petkovic I no longer see it happening in production
Nov 14 2019
@SBisson anything i can check here before moving it to done?
Nov 11 2019
Nov 8 2019
moving to Done after creating T237607 to continue the missing work from this ticket
Nov 7 2019
it seems to be cutting the article in a weird way, like the bottom part of the screen above the buttons is not being used
Nov 6 2019
Nov 5 2019
Oct 30 2019
on a separate note, the search results are different from other platforms, is this something we need to fix right now or not important?
@SBisson it's looking a bit weird now, I'm assuming we want the images to be aligned on the right?
Oct 29 2019
@SBisson do we need to do an api call on every single key press?
Maybe a small delay (or cancel the previous call on new keypress like we do on cx) here would be nice so we just do a call when we write a word or a minimum number of letters.