Page MenuHomePhabricator

Justin-Leung (Justin Leung)
Full Stack Developer

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Saturday

  • No visible events.

User Details

User Since
Dec 9 2015, 5:09 AM (518 w, 1 d)
Availability
Available
IRC Nick
Justin-Leung
LDAP User
Unknown
MediaWiki User
Justin Ryan Leung [ Global Accounts ]

17 Year Old Coder & Entrepreneur.

Recent Activity

Dec 25 2015

Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

@Florian @violetto thank you!

Dec 25 2015, 9:44 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

@violetto ok I'll add the changes and submit the patch set. Have a great christmas!

Dec 25 2015, 7:35 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

So the changes we want set will be the ones listed below. Also with the additions of new classes.

Dec 25 2015, 5:09 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design

Dec 24 2015

Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

Should I make these revisions and create a new patch.
I can create new classes following the guidelines then work from there.

Dec 24 2015, 6:13 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design

Dec 22 2015

Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

Like said above an image is worth a thousand words. I removed the margin and added the mw-ui-input to the input and text-area. This was the final result. Would this be acceptable for the change?

Dec 22 2015, 7:40 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

@bmansurov thanks for the link, also wasn't able to find it. @violetto Sorry, I didn't have an account for IRC yet. Should be good now.

Dec 22 2015, 7:20 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Justin-Leung added a comment to T104836: Talk overlay inputs don't have borders.

Wondering if this would be fine to make the additions as requested. Possibly by following the style guides linked above.

Dec 22 2015, 12:59 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design

Dec 15 2015

Justin-Leung added a comment to T119453: On transparency.wikimedia.org, add IDs to <h2>.

Occasionally I would get this error in the console:
Uncaught Error: Syntax error, unrecognized expression: a[name=standards.]

Dec 15 2015, 3:10 PM · WMF-General-or-Unknown, good first task, Google-Code-In-2015