Page MenuHomePhabricator

Khr2003
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 13 2021, 3:11 AM (23 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Khr2003 [ Global Accounts ]

Recent Activity

Jun 1 2021

Khr2003 added a comment to T237998: Co-maintainers needed for VideoCutTool..

@Gopavasanth I am happy to a co-maintainer as I have worked with the tool in past few months and I have good experience with the stack it uses.

Jun 1 2021, 10:19 AM · VideoCutTool, Toolforge-standards-committee (Maintainer needed)

Apr 15 2021

Khr2003 added a comment to T278669: Improve trimming UI.

@Gopavasanth I tried to deploy it but received this error:

Apr 15 2021, 3:24 AM · Patch-For-Review, VideoCutTool

Apr 6 2021

Khr2003 added a comment to T278669: Improve trimming UI.

@Gopavasanth
I updated the code. I tested the code on Node 10.19.0 and it worked fine with no issues. (I tested it on windows because I could not install version 10.19 on linux).

Apr 6 2021, 12:31 PM · Patch-For-Review, VideoCutTool

Mar 29 2021

Khr2003 added a comment to T278669: Improve trimming UI.
  • Fixing the overlap issue with the player.

I will work on that.

Mar 29 2021, 12:37 PM · Patch-For-Review, VideoCutTool
Khr2003 added a comment to T278669: Improve trimming UI.

Nah nah what I what was meaning is, Adding the trim section just below the video player such that trim section width and player width will be equal. But yeah I don't think doing this way will be very visible to users as per your comments above, yeah.

Mar 29 2021, 10:22 AM · Patch-For-Review, VideoCutTool
Khr2003 added a comment to T278669: Improve trimming UI.

Thanks for the comment. I am glad it was useful :)

Mar 29 2021, 9:47 AM · Patch-For-Review, VideoCutTool
Khr2003 renamed T278669: Improve trimming UI from Improve trim UI to Improve trimming UI.
Mar 29 2021, 7:38 AM · Patch-For-Review, VideoCutTool
Khr2003 created T278669: Improve trimming UI.
Mar 29 2021, 7:07 AM · Patch-For-Review, VideoCutTool

Mar 26 2021

Khr2003 added a comment to T264878: Progress bar while uploading video to tool and then to commons.

Hi @Gopavasanth am happy to look at it. I am currently working on improving trim UI. Once I am done I can look into that. If it has more priority I can drop the trim UI and start looking into it.

Mar 26 2021, 1:09 PM · Wikimedia-Hackathon-2021, VideoCutTool

Mar 23 2021

Khr2003 committed rLTVTfff151bb6890: Added support for drag and crop touch events (authored by Khr2003).
Added support for drag and crop touch events
Mar 23 2021, 12:22 PM

Mar 21 2021

Khr2003 added a comment to T277369: Format and refactor VideoCutTools worker and add progress bar.

thanks for you help to fix the remainder of the issues. It is awesome to see live after all that work :)

Mar 21 2021, 12:10 PM · VideoCutTool
Gopavasanth awarded T277369: Format and refactor VideoCutTools worker and add progress bar a Love token.
Mar 21 2021, 11:56 AM · VideoCutTool
Khr2003 added a watcher for MediaWiki-extensions-DoubleWiki: Khr2003.
Mar 21 2021, 4:18 AM
Khr2003 added a comment to T277369: Format and refactor VideoCutTools worker and add progress bar.

Ah I was meaning these are really nice and stunning updates xD. Also, sorry I didn't go through the all files in your code changes before, super excited to try out the first so tested the tool locally, just going through your code comments in the code. those are damn great. thank you!

Mar 21 2021, 4:17 AM · VideoCutTool

Mar 20 2021

Khr2003 removed a watcher for MediaWiki-General: Khr2003.
Mar 20 2021, 11:27 PM
Khr2003 added a watcher for MediaWiki-General: Khr2003.
Mar 20 2021, 2:43 PM
Khr2003 added a comment to T252524: Replace inline CSS style attributes with a proper CSS module in DoubleWiki.

@Aklapper No problem.

Mar 20 2021, 1:26 PM · Patch-For-Review, CSS, good first task, MediaWiki-extensions-DoubleWiki
Khr2003 added a comment to T252524: Replace inline CSS style attributes with a proper CSS module in DoubleWiki.

@Aklapper Will it be fine to also change table container to flex layout since it is more modern and the data presented is not tabular.

Mar 20 2021, 11:12 AM · Patch-For-Review, CSS, good first task, MediaWiki-extensions-DoubleWiki
Khr2003 claimed T252524: Replace inline CSS style attributes with a proper CSS module in DoubleWiki.
Mar 20 2021, 8:45 AM · Patch-For-Review, CSS, good first task, MediaWiki-extensions-DoubleWiki
Khr2003 added a comment to T277369: Format and refactor VideoCutTools worker and add progress bar.

Ah yeah, Is it being shown currently when you tried locally?

Mar 20 2021, 4:19 AM · VideoCutTool
Khr2003 added a comment to T277369: Format and refactor VideoCutTools worker and add progress bar.

@Gopavasanth Thanks.

Mar 20 2021, 3:53 AM · VideoCutTool
Khr2003 added a comment to T259961: Undo/redo after paste only works once in Firefox.

This issue does not seem related to the wiki editor but to how Firefox handles undo stack. You can reproduce the same issue here: https://jsfiddle.net/4n7s8p19/

Mar 20 2021, 2:41 AM · Browser-Support-Firefox, WikiEditor, MediaWiki-Page-editing

Mar 19 2021

Khr2003 renamed T277369: Format and refactor VideoCutTools worker and add progress bar from Format and refactor VideoCutTools worker to Format and refactor VideoCutTools worker and add progress bar.
Mar 19 2021, 1:36 PM · VideoCutTool

Mar 17 2021

Khr2003 committed rLTVT7eddb5bc3fd3: Fixed responsive design (authored by Khr2003).
Fixed responsive design
Mar 17 2021, 5:37 PM
Khr2003 added a comment to T272401: Adjust the mobile view of the tool.

@Gopavasanth
I can either hide the overflowing text using ellipses

1615975769484.png (375×461 px, 17 KB)

Mar 17 2021, 10:12 AM · Mobile, CSS, good first task, VideoCutTool

Mar 14 2021

Khr2003 added a comment to T262892: Quality degrading while editing videos.

@Gopavasanth I just tried it on local machine and did not see any quality loss.

Mar 14 2021, 9:59 AM · good first task, VideoCutTool

Mar 13 2021

Khr2003 created T277369: Format and refactor VideoCutTools worker and add progress bar.
Mar 13 2021, 12:55 PM · VideoCutTool
Khr2003 added a comment to T252320: Improve video cropping + rotating experience..

@Gopavasanth Yes. I realized that an hour ago. I will send a commit shortly to fix this issue.

Mar 13 2021, 10:47 AM · Patch-For-Review, VideoCutTool

Mar 3 2021

Khr2003 added a comment to T252320: Improve video cropping + rotating experience..

The .env file is missing socket_io_url in development object. I added: "socket_io_url: 'https://videocuttool.wmflabs.org'" and everything is working now :)

Mar 3 2021, 12:46 PM · Patch-For-Review, VideoCutTool
Khr2003 added a comment to T252320: Improve video cropping + rotating experience..

Thanks for the reply. I just tried it but received the same error.

Mar 3 2021, 12:36 PM · Patch-For-Review, VideoCutTool
Khr2003 added a comment to T252320: Improve video cropping + rotating experience..

@Gopavasanth I am trying to run the tool on my machine. I replaced backend_url in env.js with "https://videocuttool.wmflabs.org" but I keep getting this error: "http://localhost:3000/socket.io/?EIO=3&transport=polling&t=NVtn-ck 404 (Not Found)".

Mar 3 2021, 11:11 AM · Patch-For-Review, VideoCutTool

Feb 23 2021

Khr2003 added a comment to T272240: Add more languages in the tool's drop-down list.

@Uditdesai2206 Are you still working on this. I can help if you want.

Feb 23 2021, 1:42 PM · Patch-For-Review, good first task, I18n, VideoCutTool
Khr2003 claimed T275023: Investigate and Fix the text on dropdown.
Feb 23 2021, 7:47 AM · good first task, VideoCutTool

Feb 22 2021

Khr2003 added a comment to T272401: Adjust the mobile view of the tool.

View of the latest change:

Feb 22 2021, 12:05 PM · Mobile, CSS, good first task, VideoCutTool

Feb 21 2021

Khr2003 added a watcher for Utilities-mwdumper: Khr2003.
Feb 21 2021, 7:40 AM

Feb 20 2021

Khr2003 added a comment to T272401: Adjust the mobile view of the tool.

@Gopavasanth I think the main issue is styling header with float instead of flex. Since bootstrap is included already I though I make few changes to header section with few bootstrap classes. Also, bootstrap includes hamburger menu icon so no need to import another library.

Feb 20 2021, 12:26 PM · Mobile, CSS, good first task, VideoCutTool

Feb 18 2021

Khr2003 added a comment to T275022: Extend the main div height to remove the empty space.

@Gopavasanth No problem. Happy to help :)

Feb 18 2021, 10:03 AM · VideoCutTool
Khr2003 added a comment to T275022: Extend the main div height to remove the empty space.

@Gopavasanth I am getting this issue in both Chrome and Firefox. I think I can see because of my screen dimensions. The viewport height is 977px in Chrome and 1006px in Firefox.

Feb 18 2021, 9:05 AM · VideoCutTool
Khr2003 added a comment to T275022: Extend the main div height to remove the empty space.

@Gopavasanth I was not able to post photo on Gerrit. That's why I am posting it here.

Feb 18 2021, 7:54 AM · VideoCutTool

Feb 17 2021

Khr2003 added a comment to T275022: Extend the main div height to remove the empty space.

@Gopavasanth Done.

Feb 17 2021, 1:54 PM · VideoCutTool

Feb 14 2021

Khr2003 added a comment to T270832: Implement Dark mode in the tool.

@Gopavasanth Thanks. It nice to see it live :)

Feb 14 2021, 10:30 PM · CSS, good first task, VideoCutTool
Khr2003 added a comment to T270832: Implement Dark mode in the tool.

@Gopavasanth It was mostly CSS and that a strong area for me. There is no text in textarea and that is why nothing is shwoing.

Feb 14 2021, 8:57 AM · CSS, good first task, VideoCutTool
Khr2003 added a comment to T270832: Implement Dark mode in the tool.

Hi @Gopavasanth
Thanks. I completed the design and I will add tasks later for the other issues.
Here are the screenshots. If they look ok I will push the commit.

Feb 14 2021, 5:13 AM · CSS, good first task, VideoCutTool

Feb 13 2021

Khr2003 claimed T270832: Implement Dark mode in the tool.

I have few questions:
1- Prettier config was rejected in this commit: https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/569593. Is there a possibly to revisit this as it will help with consistent coding style and auto format in vscode.
2- This what I have so far. I chose dark blue. I was wondering if you have any input on the colors.

screenshot.png (956×1 px, 47 KB)

3- There is an empty space at the bottom. I can fix this by making the main div full height. This will be universal not just part of dark theme. Should I add in this change (with a separate commit) or create a separate task for it?

Feb 13 2021, 9:34 AM · CSS, good first task, VideoCutTool
Khr2003 added a comment to T270832: Implement Dark mode in the tool.

Hi,
I am happy to work on this.

Feb 13 2021, 8:48 AM · CSS, good first task, VideoCutTool