Page MenuHomePhabricator

KieranMcCann (Kieran McCann)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2021, 9:24 AM (177 w, 3 d)
Roles
Disabled
LDAP User
Unknown
MediaWiki User
KMcCann (WMF) [ Global Accounts ]

Recent Activity

May 12 2023

KieranMcCann reassigned T301328: Document how to use icons in our projects from KieranMcCann to bmartinezcalvo.
May 12 2023, 9:21 AM · Codex, Design-System-Team, Design
KieranMcCann moved T323244: Remove extra spacing from username/create account link from Design Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
May 12 2023, 8:15 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3), Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T323244: Remove extra spacing from username/create account link.

Looks good to me from design QA perspective

May 12 2023, 8:10 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3), Desktop Improvements (Vector 2022)

May 11 2023

KieranMcCann placed T280847: [EPIC] Define and add data visualisation guidelines and a set of library components to Codex up for grabs.
May 11 2023, 10:18 AM · Design, Design-System-Team (Design-System-Product-Roadmap), Epic, Codex
KieranMcCann added a comment to T298198: [EPIC] Define a responsive column grid system.

Here is the latest proposal for the grid with particular reference to how it behaves with Vector 2022. This proposal takes into account:

May 11 2023, 9:51 AM · Design, Epic, Design-System-Team (Design-System-Product-Roadmap), Codex

Apr 27 2023

KieranMcCann renamed T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus from [Design spike] Refine typographic styling of ToC, Tools and Main menus to [Design spike] Refine visual styling of ToC, Tools and Main menus .
Apr 27 2023, 4:23 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus .

Proposed visual design of menus in Vector 2022:

Apr 27 2023, 4:23 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 25 2023

KieranMcCann added a comment to T326323: Full-width toggle button should be opaque.

This might be fixed in the future through a different solution. cc @KieranMcCann - let us know if you have concerns with this one.

Apr 25 2023, 9:38 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 24 2023

KieranMcCann added a comment to T332600: Prepare content columns for Zebra#9 design update.

Some small issues I noticed:

  • The fade indicator needs to be updated, its not really visible currently F36955647
  • The scrollbar on pinned elements is inside the padding (F36955648), ideally it covers the entire height of the element like so: F36955650
  • The subsection toggle buttons in the TOC are smaller than original, they should be 22px but instead are 19.25. Looks like the font size was decreased F36955657

Questions for @KieranMcCann

  • The prototype removes the borders that separate menus inside dropdowns and pinnable elements (Before: F36955664 After: F36955660). I feel like the border was helpful for separating groups of content, would it be worth considering adding back some sort of affordance, maybe spacing if not the border?
  • I noticed the dropdown styles are updated in this patch, if we are changing them could we match the OOUI styles (i.e. F36955706)? They didnt match prior to Zebra either, but I think this is a good opportunity to make it consistent and up to spec
Apr 24 2023, 8:47 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)
KieranMcCann moved T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus from Incoming to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Apr 24 2023, 5:46 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Apr 20 2023

KieranMcCann added a comment to T332767: OnboardingDialog: Add OnboardingDialog component pattern to Codex.

Thanks @bmartinezcalvo. Comments below:

Apr 20 2023, 10:46 AM · Design-System-Team, Design, Codex

Apr 17 2023

KieranMcCann moved T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus from Design Review to Doing on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
Apr 17 2023, 5:06 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T333601: Inform logged-out users of their ability to select page density.

@bwang Sorry just catching up after being on leave. I would be tempted to still include the close button.

Apr 17 2023, 3:43 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Patch-For-Review, Desktop Improvements (Vector 2022), Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1)

Apr 4 2023

KieranMcCann updated the task description for T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus .
Apr 4 2023, 2:15 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann changed the status of T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus from Open to In Progress.
Apr 4 2023, 1:46 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann edited projects for T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus , added: Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6); removed Web-Team-Backlog.
Apr 4 2023, 1:46 PM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T332085: Page tools have long labels in certain languages.

@Jdlrobson @ovasileva Two potential solutions to this issue:

Apr 4 2023, 10:13 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1), Desktop Improvements (Vector 2022)
KieranMcCann updated the task description for T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus .
Apr 4 2023, 10:10 AM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann triaged T333927: [Design spike] Refine visual styling of ToC, Tools and Main menus as Medium priority.
Apr 4 2023, 10:01 AM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)
KieranMcCann updated subscribers of T333601: Inform logged-out users of their ability to select page density.

@Jdlrobson @ovasileva The only behaviour I found odd in the demo was after toggling to full width and getting the “You have switched your layout to full width. To go back to limited width, press this button” message, and then toggling back to limited width, the message still remains.

Apr 4 2023, 9:27 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Patch-For-Review, Desktop Improvements (Vector 2022), Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1)

Apr 3 2023

KieranMcCann added a comment to T333589: Link the text of headings in the toc instead of areas around them.

@KieranMcCann - similar to what you were pointing out - limiting the width of the ToC slighly could help with this potentially

Apr 3 2023, 4:27 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022), Community Feedback (Web)
KieranMcCann added a comment to T332925: Add a suggested section-level image: Onboarding illustrations .

Hi @RHo @JFernandez-WMF. Updated illustrations below. I’ve only made small adjustments to the original illustrations to indicate that the image is part way through an article and not in the lead. Just let me know if you need more work done on these.

Apr 3 2023, 11:10 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), Section-Level-Image-Suggestions, Growth Design, Growth-Team (Sprint 0 (Growth Team))

Mar 31 2023

KieranMcCann added a comment to T333353: Handle the popup notification when the TOC is auto unpinned at lower resolutions.

@KieranMcCann - wonder what you think of this one? I feel like it could be unexpected and distracting to show the indicator when resizing, but at the same time it would be nice if we show it consistently every time we collapse the menus

Mar 31 2023, 10:06 AM · Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022)

Mar 30 2023

KieranMcCann added a comment to T332171: Replace `line-height-heading`'s 1.3 by 1.375.

Looks good to me.

Mar 30 2023, 5:08 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6), Design-System-Team (Design-System-Sprint), Design, Desktop Improvements (Vector 2022), Vector (legacy skin), WikimediaUI-Base, Codex

Mar 28 2023

KieranMcCann added a comment to T298198: [EPIC] Define a responsive column grid system.

Hey @KieranMcCann thank you for sharing this. I've updated the layout proposal applying your feedback related with the content full-width. We could use 4col for the tools panel and then expand the article content when the tools panel is hidden. With this new layout, we would solve the user's full-width request for the article content.

Captura de Pantalla 2023-03-27 a las 13.40.35.png (1×2 px, 1 MB)

This layout proposal uses the same grid solution we proposed some time ago (24col grid on desktop) so there is no problem with implementing one or another layout using this grid. In any case, I think it's worth implementing a grid so we can unify the margins and visual structure in all our projects.

Mar 28 2023, 5:47 PM · Design, Epic, Design-System-Team (Design-System-Product-Roadmap), Codex

Mar 24 2023

KieranMcCann added a comment to T311160: Add indicator that appears when TOC & page tools menu have been hidden.

@Jdlrobson In terms of design review I can confirm all looks good to me.

Mar 24 2023, 3:42 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Design-System-Team, Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T309239: Add Field component to Codex.

Thanks @bmartinezcalvo. Following on from my comments in the Figma file I can confirm all looks good to me now.

Mar 24 2023, 3:30 PM · Design-System-Team (Design-Systems-Sprint-1), Patch-For-Review, Codex
KieranMcCann added a comment to T298198: [EPIC] Define a responsive column grid system.

@RHo @bmartinezcalvo I do agree with having a dynamic grid which allows for the article to expand to the right when the tools panel is hidden. There are, however, a couple things in the way of us moving forward with this at the moment. These being:

Mar 24 2023, 3:16 PM · Design, Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
KieranMcCann added a comment to T332925: Add a suggested section-level image: Onboarding illustrations .

Hi @RHo. Sure no problem. In terms of timeframe is early next week okay?

Mar 24 2023, 9:27 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), Section-Level-Image-Suggestions, Growth Design, Growth-Team (Sprint 0 (Growth Team))

Mar 23 2023

KieranMcCann closed T316950: [Visual refinements] Reduce height of article toolbar, a subtask of T317632: [EPIC] Visual refinements pt2, as Resolved.
Mar 23 2023, 4:41 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022), Epic
KieranMcCann closed T316950: [Visual refinements] Reduce height of article toolbar as Resolved.
Mar 23 2023, 4:41 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Patch-For-Review, patch-welcome, good first task, Desktop Improvements (Vector 2022)

Mar 21 2023

KieranMcCann added a comment to T311160: Add indicator that appears when TOC & page tools menu have been hidden.

@ovasileva @KieranMcCann Should this happen everytime a pinnable element is unpinned? Or just the first time?

Mar 21 2023, 12:19 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Design-System-Team, Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T316950: [Visual refinements] Reduce height of article toolbar.

Thanks @Jdlrobson, that makes sense.

Mar 21 2023, 12:05 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Patch-For-Review, patch-welcome, good first task, Desktop Improvements (Vector 2022)

Mar 20 2023

KieranMcCann added a comment to T316950: [Visual refinements] Reduce height of article toolbar.

Thanks @Jdlrobson for the added information. In that case I wonder if there may be other scripts in addition to Burmese that have a similar issue?

Mar 20 2023, 9:17 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Patch-For-Review, patch-welcome, good first task, Desktop Improvements (Vector 2022)

Mar 17 2023

KieranMcCann added a comment to T316950: [Visual refinements] Reduce height of article toolbar.

Thank @Jdlrobson. On comparison the Burmese spacing looks different. There us both a larger space between the H1 and the line below it, and above the article toolbar items. Is this expected behaviour due to the properties of different scripts?

Mar 17 2023, 11:32 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Patch-For-Review, patch-welcome, good first task, Desktop Improvements (Vector 2022)

Mar 16 2023

KieranMcCann added a comment to T316950: [Visual refinements] Reduce height of article toolbar.

Hi @Jdlrobson. Looks good to me but is there an easy way for me to check how it looks in other scripts? I’m thinking of something like Burmese where the type ascenders and descenders will be longer than Latin script.

Mar 16 2023, 6:30 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), Patch-For-Review, patch-welcome, good first task, Desktop Improvements (Vector 2022)
KieranMcCann moved T331905: Make languages available to index crawlers in BODY of mobile version of article pages from Design Review to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
Mar 16 2023, 5:01 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), MinervaNeue
KieranMcCann updated subscribers of T331905: Make languages available to index crawlers in BODY of mobile version of article pages.

Thanks for making those changes @Jdlrobson

Mar 16 2023, 4:57 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), MinervaNeue
KieranMcCann moved T326571: [For editing team] "Add languages" button in sticky header is inconsistent with other font sizes from Design Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
Mar 16 2023, 9:51 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), UniversalLanguageSelector, Desktop Improvements (Vector 2022)
KieranMcCann added a comment to T326571: [For editing team] "Add languages" button in sticky header is inconsistent with other font sizes.

Looks good to me

Mar 16 2023, 9:51 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5), UniversalLanguageSelector, Desktop Improvements (Vector 2022)

Mar 7 2023

KieranMcCann added a comment to T330532: [Design] Re-evaluate breakpoint for hiding page tools/toc to keep content width more consistent.

@ovasileva I agree that the content width does get very narrow when the two sidebars are visible, so hiding one of them sooner would make the article more readable within that zone of 1200–1000px.

Mar 7 2023, 12:04 PM · Desktop Improvements (Vector 2022), Web-Team-Backlog, task-needs-improvement

Feb 20 2023

KieranMcCann added a comment to T309239: Add Field component to Codex.

@KieranMcCann I don't think we will have too many tooltips in the same form, so I hope it's not a strong problem to solve. If you know any real use case with too many tooltips please add it in the inventory so we can explore the solution.

Feb 20 2023, 3:12 PM · Design-System-Team (Design-Systems-Sprint-1), Patch-For-Review, Codex
KieranMcCann added a comment to T284272: TextArea: Add TextArea component to Codex.

Looks good to me @bmartinezcalvo

Feb 20 2023, 12:52 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
KieranMcCann added a comment to T309239: Add Field component to Codex.

If we add the info icon at the end of the row (Op.2) we would have cases like this, where the form item is too long and the info icon is too separated from the label and it seems to be more connected to the next form item:

Captura de Pantalla 2023-02-20 a las 12.10.21.png (412×2 px, 258 KB)

I recommend to use the Option1 instead, adding the info icon next to the label. @KieranMcCann what do you think?

Captura de Pantalla 2023-02-20 a las 12.09.01.png (378×2 px, 241 KB)

Feb 20 2023, 12:41 PM · Design-System-Team (Design-Systems-Sprint-1), Patch-For-Review, Codex
KieranMcCann moved T326665: Design and build Accordion component (MVP) from Design Review to Ready for Development on the Design-System-Team (Design-System-Sprint) board.

@KieranMcCann let me know if this last iteration it's ok and move the task to Ready for Development accordingly.

Feb 20 2023, 11:27 AM · Design-System-Team (Design-Systems-Sprint-3), Wikimedia-Hackathon-2023, Design, Codex

Feb 14 2023

KieranMcCann added a comment to T329383: Wikifunctions specific icons for the mode selector.

Look good to me @bmartinezcalvo @AAlhazwani-WMF!

Feb 14 2023, 5:30 PM · Design-System-Team (Design-System-Sprint), Design, OOUI, Codex
KieranMcCann added a comment to T326665: Design and build Accordion component (MVP).

@bmartinezcalvo Some comments after reviewing the the visual aspects of the component.

Feb 14 2023, 1:05 PM · Design-System-Team (Design-Systems-Sprint-3), Wikimedia-Hackathon-2023, Design, Codex
KieranMcCann reassigned T284272: TextArea: Add TextArea component to Codex from KieranMcCann to bmartinezcalvo.
Feb 14 2023, 12:27 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
KieranMcCann added a comment to T327822: Add governance model to mediawiki.

I’ve reviewed the digram from a visual design perspective and think it looks good. I think removing the background colours has definitely made it simpler and clearer looking.

Feb 14 2023, 10:27 AM · Design-System-Team (Design-System-Sprint), Codex, Documentation

Feb 9 2023

KieranMcCann added a comment to T327822: Add governance model to mediawiki.

All good with me. Apologies if I confused things by suggesting it in the meeting the other day. I wasn’t advocating for doing it, it was more just general design feedback on ways we could simplify the diagram. Very happy just to go with the static option as it is.

Feb 9 2023, 1:05 PM · Design-System-Team (Design-System-Sprint), Codex, Documentation
KieranMcCann added a comment to T327822: Add governance model to mediawiki.

Just to clarify that I was suggesting turning it into a Figma prototype which should be shareable without people needing Figma. But appreciate this is added work which is probably not a priority. Will proofread and check visual design shortly.

Feb 9 2023, 11:39 AM · Design-System-Team (Design-System-Sprint), Codex, Documentation
KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Looks good to me too

Feb 9 2023, 10:59 AM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex
KieranMcCann added a comment to T284272: TextArea: Add TextArea component to Codex.

Looks good to me @bmartinezcalvo.

Feb 9 2023, 10:52 AM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex

Feb 7 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

@bmartinezcalvo I added comments in Figma but just putting them here too for visibility.

Feb 7 2023, 10:24 AM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Feb 6 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Thanks @KieranMcCann, looks good to me. Could you also apply the same spacing treatment to the header when there is a subtitle as well for completion?

That’s done.

dialog-no-dividers-suggested-spacing.png (672×3 px, 93 KB)

Feb 6 2023, 10:26 AM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Feb 2 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Here’s an updated version where I’ve increased spacing below the header and above the footer by 8px. I think this does enough to separate the elements without the need for dividers. Let me know your thoughts @RHo and @bmartinezcalvo.

Feb 2 2023, 12:18 PM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex
KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

I agree with avoiding the use of dividers as much as possible. But there are some specific cases where dividers are useful to visually separate the content blocks in the dialog, specially when the footer has text or permanent actions. In this case, the dialog without divider seems too crowded.

Captura de Pantalla 2023-02-01 a las 13.57.06.png (686×2 px, 655 KB)
Captura de Pantalla 2023-02-01 a las 13.56.49.png (678×2 px, 650 KB)
With dividersWithout dividers
Feb 2 2023, 11:15 AM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Jan 31 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Thanks @bmartinezcalvo. I lean towards only showing the dividers when the content is too long to be contained within the dialog and it requires scrolling. I’m not sure it’s visually necessary to divide header and footer from the content with a divider. Also, doing it this way would make the dividers a clearer affordance that scrolling is required.

Jan 31 2023, 5:59 PM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex
KieranMcCann renamed T280847: [EPIC] Define and add data visualisation guidelines and a set of library components to Codex from Define and add a set of data visualisation library components to the DSG to Define and add data visualisation guidelines and a set of library components to the DSG.
Jan 31 2023, 11:18 AM · Design, Design-System-Team (Design-System-Product-Roadmap), Epic, Codex
KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

@bmartinezcalvo That’s great. I think having those guidelines in the spec sheets will be useful. Are there plans to add this type of documentation onto the Codex site too at some point. I think it would be helpful here too.

Jan 31 2023, 10:43 AM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Jan 27 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Thanks @bmartinezcalvo. Just reviewed the video and comments from Design Review and have a few comments myself.

Jan 27 2023, 12:49 PM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Jan 24 2023

KieranMcCann added a comment to T324708: Dialog: support header and footer customization.

Agree with @RHo’s comments on both the placement of disclaimers and checkboxes. i.e. disclaimers always above actions, but having flexibility of placement for checkboxes, depending on how it makes sense structurally, would be advantageous.

Jan 24 2023, 5:34 PM · Patch-For-Review, Design-System-Team (Design-System-Sprint), Design, Codex

Jan 19 2023

KieranMcCann claimed T301328: Document how to use icons in our projects.
Jan 19 2023, 6:18 PM · Codex, Design-System-Team, Design
KieranMcCann added a comment to T260617: Evaluate and decide on customizable icon sizes for Codex.

Thanks for pinging me here @RHo. I agree that it makes sense for the larger icon sizes to be explored in units that are dividable by 4.

Jan 19 2023, 11:28 AM · Design-System-Team (Design-System-Sprint), Codex, Design
KieranMcCann added a comment to T324165: NewImpact: Visual design improvements to the "sparkline" style graph that shows pageviews over time.

These look great to me @Etonkovidova and much more in line with the expected visuals.

Jan 19 2023, 11:16 AM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-ImpactModule

Jan 10 2023

KieranMcCann added a comment to T322850: Add thanks and longest streak scorecards to the unactivated state.

Ambassadors discussed about this dash during their weekly meeting. A dash would be understood for all cultures represented in the meeting. However, two questions arose:

  • understanding would be easier if we have a descriptive term instead of a dash, like "0 days" or "n/a"
  • what about screen readers? A dash has multiple meanings and might not be well understood.
Jan 10 2023, 6:41 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), GrowthExperiments-ImpactModule, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Dec 15 2022

KieranMcCann added a comment to T310661: Impact module: scorecards.

@KStoller-WMF Ideally we would adjust the alignment of the ‘i’ icons. I think the issue is more obvious because they are in close vicinity to the other text + icon pairing where the alignment looks correct. If it is proving to be a major blocker then I guess it could be filed as a big to fix later?

Dec 15 2022, 6:59 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

@KStoller-WMF Yes looks good to me. Can confirm it passes design review.

Dec 15 2022, 6:56 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Dec 9 2022

KieranMcCann added a comment to T322443: Personalized praise: new mentor dashboard module.

@KStoller-WMF Here’s the SVG of the empty state illustration.

Dec 9 2022, 9:45 AM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), GrowthExperiments-PersonalizedPraise, GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Dec 7 2022

KieranMcCann added a comment to T313310: Impact module: Implement table list component.

All looks good to me! Thanks @Etonkovidova

Dec 7 2022, 10:33 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann closed T313310: Impact module: Implement table list component, a subtask of T222310: [EPIC] Positive reinforcement: New Impact Module, as Resolved.
Dec 7 2022, 10:33 AM · Growth-Team, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule
KieranMcCann closed T313310: Impact module: Implement table list component as Resolved.
Dec 7 2022, 10:33 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Nov 29 2022

KieranMcCann added a comment to T323785: Positive Reinforcement: Leveling Up Post-edit dialog illustrations.

@RHo RTL versions...

Nov 29 2022, 11:44 AM · Growth-Positive-Reinforcement, Growth-Team (Sprint 0 (Growth Team))
KieranMcCann added a comment to T323785: Positive Reinforcement: Leveling Up Post-edit dialog illustrations.

@RHo Thanks for clarifying. Apologies for the confusion.

Nov 29 2022, 10:21 AM · Growth-Positive-Reinforcement, Growth-Team (Sprint 0 (Growth Team))

Nov 28 2022

KieranMcCann added a comment to T323785: Positive Reinforcement: Leveling Up Post-edit dialog illustrations.

Thanks for creating this task @RHo. Just wanted to double check the image size specs as 360x128px seems very short and wide. Looking at the previous illustrations I estimate it to be more like 360x216px but just wanted to check in case I’m not understanding correctly.

Nov 28 2022, 4:57 PM · Growth-Positive-Reinforcement, Growth-Team (Sprint 0 (Growth Team))

Nov 22 2022

KieranMcCann claimed T280847: [EPIC] Define and add data visualisation guidelines and a set of library components to Codex.
Nov 22 2022, 9:12 AM · Design, Design-System-Team (Design-System-Product-Roadmap), Epic, Codex

Nov 10 2022

KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

(1) The zeroes (and the blank value for "Longest streak") are displayed to a newcomer. In the comments above (for the edge case #3 in https://phabricator.wikimedia.org/T310666#8275248) there was a suggestion (https://phabricator.wikimedia.org/T310666#8275325) to display the existing Impact module for newcomers with zero edits. Would it be done or we go with zeroes?

In this edge case I think it’s okay to show the new impact module with zeroes, rather than the existing impact module – but I think @RHo .should probably make the final call on this The only small detail that I think looks a bit odd is the lack of any value for the longest streak. Maybe we could simply add a dash ‘–’ when there is nothing to show here?

My understanding is that we're going to implement the old Impact module's unactiviated state for the new impact module, T321963: NewImpact module: Implement unactivated state code from Impact.php , and that work is in progress.

Nov 10 2022, 11:52 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

Looks good to me @Etonkovidova. In response to your questions:

Nov 10 2022, 11:38 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Nov 8 2022

KieranMcCann added a comment to T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button.

@Volker_E +1 to @RHo’s comments.

Nov 8 2022, 12:01 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Sprint 0 (Growth Team))
KieranMcCann added a comment to T322428: Update Message component colors.

+1 for option 3 from me too

Nov 8 2022, 9:07 AM · Design-System-Team (Design-System-Sprint), WikimediaUI-Base, OOUI, Codex

Nov 7 2022

KieranMcCann added a comment to T310661: Impact module: scorecards.

These look good to me @Etonkovidova. The only thing I noticed is that we decided to change the icon used for the Thanks data point. Would it be possible to change this from the heart icon to the speech bubble with the smile? (Figma)

Nov 7 2022, 5:08 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Nov 4 2022

KieranMcCann added a comment to T280847: [EPIC] Define and add data visualisation guidelines and a set of library components to Codex.

We might also want to add a dataviz-specific color palette to provide additional colors beside our base UI colors. This article for example shares great examples of color blindness-friendly palettes. There's also this website about color palettes for cartography.

+1 to this suggestion. Currently we pretty much only use the blue Accent colour, which is the same colour for buttons, links, etc which can be quite limiting for datavis (eg, pie , stacked bar charts, comparison charts), and potentially may get distracting if half a page is in this colour.

Nov 4 2022, 9:21 AM · Design, Design-System-Team (Design-System-Product-Roadmap), Epic, Codex

Oct 21 2022

KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

@kostajh Sorry I’ve been off for a few days so just catching up on this now. I’d agree with what has been said so far by @RHo:

Oct 21 2022, 9:16 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Oct 17 2022

KieranMcCann updated subscribers of T318542: Impact module: Create mobile summary view.

@KStoller-WMF I noticed this last week and had considered updating the design to the new summary style but decided against it as it would likely involve the copy being truncated. I think the current design with the simple text styling works better as a summary view personally, so happy to go with the current design for this.

Oct 17 2022, 9:56 AM · MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Sprint 0 (Growth Team))

Oct 13 2022

KieranMcCann added a comment to T317821: Add a link to Recent changes made by mentees from the Mentor dashboard.

My only suggestion is that we might want to consider differentiating that text slightly in some way. Perhaps in a similar way to how we separate "Claim mentee" in Settings. But I'm in no way attached to that idea, it just seems like "Recent changes by your mentees" is logically a subsection of "Your mentees", but it's also somewhat separate from the main table view, so it might be nice to visually separate it in some way. But feel free to disagree!

Oct 13 2022, 9:45 AM · MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard

Oct 11 2022

KieranMcCann added a comment to T310665: Impact module: summary panel.

Noting here that after discussion on T310666 it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel. Figma designs have been updated to reflect this.

Oct 11 2022, 4:30 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310665: Impact module: summary panel.

@Sgs Thanks for sending those. My preference would be to use the ‘mentor dashboard dropdown style’ you mentioned.

Oct 11 2022, 4:29 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310661: Impact module: scorecards.

Just noting here that after discussion on T310666 it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel. Figma designs have been updated to reflect this.

Oct 11 2022, 4:27 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann updated subscribers of T310666: Impact Module: Recent Editing Activity.

Update on my previous post. After discussion with @RHo we decided it would be a better solution to put the streak dates in the info dialog, as this informartion is secondary to the number of days in the streak and probably doesn’t need to be visible.

Oct 11 2022, 4:12 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Oct 10 2022

KieranMcCann added a comment to T317821: Add a link to Recent changes made by mentees from the Mentor dashboard.

Thanks for the suggestion @kostajh. I mocked it up but it doesn’t feel right to me for a few of reasons:

  • the items in that space feel like they should directly relate to or affect the table below
  • I think it will be challenging to make the text in the button both clear and concise
  • I don’t think it should be a button as it is technically a link rather than an action
Oct 10 2022, 11:44 AM · MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard
KieranMcCann added a comment to T317821: Add a link to Recent changes made by mentees from the Mentor dashboard.

@KStoller-WMF I think the simplest solution to this would be to add a line of copy at the bottom of the module with a link to the filtered recent changes page:

Oct 10 2022, 11:05 AM · MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard

Oct 3 2022

KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

@KStoller-WMF Yes I agree that this change simplifies the number of styles on the page and feels like a visual improvement too.

Oct 3 2022, 9:42 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Sep 30 2022

KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

Thanks for these edge cases @Sgs and apologies it seems like these indicate a bit of an oversight on how this would work exactly.

Sep 30 2022, 4:26 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Sep 29 2022

KieranMcCann added a comment to T310660: Impact module: Cumulative pageviews trendchart.

Does the "trendchart" conceptually belong to the articles section, the recent activity or the it's a section on its own? cc @KieranMcCann @KStoller-WMF

Sep 29 2022, 5:36 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310665: Impact module: summary panel.

@Sgs could you send me a screenshot of what you mean by ‘Mentor dashboard dropdown style component’ as I’m not entirely clear on what that is. Thanks

Sep 29 2022, 5:30 PM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

@KieranMcCann @BKots-WMF @KStoller-WMF is the minimum unit for a streak 1 day? E.g. if a user creates their account and makes an edit on day one, we should show "Best streak: 1 day" ? or should that only show up once they've edited for more than one day in a row?

Sep 29 2022, 9:48 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement
KieranMcCann added a comment to T310666: Impact Module: Recent Editing Activity.

@KieranMcCann - how can we make it more clear in the current design which time scale is being viewed (given that we won't have the "Last x days" drop down in this first iteration)?

Sep 29 2022, 9:47 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Patch-For-Review, Growth-Team (Sprint 0 (Growth Team)), Growth-Positive-Reinforcement

Sep 26 2022

KieranMcCann added a comment to T305408: Newcomer tasks: deploy AND selection to all wikis.

In terms of the icon I don’t think we should create an additional icon for ANY. As this works in the way you would expect normal filtering to work I would use the standard filter icon for it and then create the modified ‘+’ version for ANY, as this is non-standard filtering. Also would suggest to me that it meant filter all the terms that do not equal the ones I have selected (i.e. the opposite to what it does).

Sep 26 2022, 4:49 PM · GrowthExperiments-NewcomerTasks, Growth-Team (Sprint 0 (Growth Team))
KieranMcCann renamed T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button from Create icon to Create icon for new ‘Match ALL’ filtering method.
Sep 26 2022, 4:47 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Sprint 0 (Growth Team))
KieranMcCann triaged T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button as Medium priority.
Sep 26 2022, 4:47 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Sprint 0 (Growth Team))