Mar 20 2022
Mar 15 2022
Feb 19 2022
Feb 10 2022
Jan 18 2022
IMO, the exploit should not be exposed, to avoid causing more pain to sites running vulnerable versions.
Jan 12 2022
Jan 10 2022
just to clarify: the issue is that this was allowed until last version, which means there are already "live" templates which violate the assertion.
this caused significant disruption: specifically, one of these templates was the hewiki equivalent of "Cite journal" - as a result, editors could not create automatic citations of articles using DOI, and could not even create manual such citations using VE (and thanks to mediawiki devs, many editors don't even know how to use source editor - kudos!).
we went and amended those templates on hewiki (can't be sure we found them all - see below :) ), but it's more than likely similar issue still exists on other projects.
Jan 8 2022
we should distinguish between visualeditor and templatedata.
templatedata provides a syntax to describe the template behavior, and is used not just by visualeditor, but other tools too.
Jan 7 2022
just realized that this error does not add the template to any tracking category. make it 2 demerits.
Dec 19 2021
beg to differ.
when ply is not defined, the final state of the game may or may not be useful to readers not using the interactivity, but the opening board is guaranteed to have zero value.
if you are 100% against showing the last ply, it would be better to declare ply= "mandatory" parameter, and show error when not defined, rather than defaulting to absolutely useless real estate on the page.
Dec 3 2021
no need, thanks.
your explanation clarified it, and the comment is junk.
Dec 1 2021
@4nn1l2 - please see update to story and consensus, and my comment on gerrit.
Nov 30 2021
Oct 30 2021
speaking of the algebraic notation, i would like to suggest some css tweaks to make it clearer that the plys are clickable.
cursor:pointer comes to mind.
another css change i request: please replace the bike and ped icons for fast/slow with dear/snail, as in the prototype. turtle would be even better.
Oct 25 2021
description should be expanded to cover ply and swap.
i think you should obtain a simpler PGN with NAGs and test it with it.
the game on my user page was copied from one of the test cases in the extension's repo, but i do not know that it's valid.
Sep 14 2021
Sep 3 2021
@Wugapodes : can you see why 3rd game in https://en.wikipedia.beta.wmflabs.org/wiki/User:%D7%A7%D7%99%D7%A4%D7%95%D7%93%D7%A0%D7%97%D7%A91/ChessBrowser_test_cases still fails to parse?
i copied it from one of the test cases in the repo.
Aug 26 2021
(critique based on the screenshot only)
Aug 9 2021
now it seems that it does not like the question mark in the doc, and complains about
@param array? $fenParts The ....
on lines 149 and 214 of includes/ChessParser.php
Jul 29 2021
Jul 15 2021
Jul 1 2021
Jun 1 2021
May 24 2021
looked at the beta.
saw for the first time how "flip" also rotates the board itself, not just the button. super cute.
interestingly, the first implementation of the standalone introducing speed control used slider.
never got it to be satisfactory.
if i may, i think it will be better and more useful to have a single "speed control" button, which will allow the reader to enter the delay numerically.
May 8 2021
lichess is not the model.
look for any site which holds large library of games in PGN format, and look at the interactive game interface. first i stumbled on (from enwiki article) https://www.chessgames.com/perl/chessgame?gid=1129672
autoplay is useful feature. talk with chess aficionados. at the very least we should consult the authors. i asked on their talk page. (see enwiki:Wikipedia talk:WikiProject Chess ).
May 6 2021
Apr 27 2021
@sbassett : currently, the beta deployment task, T244075 depends on this task.
iiuc, there is kind of agreement that the extension can be deployed to test wiki, maybe under some conditions.
can you please update the beta task, and clarify if it can progress despite declining this task, and if so, what needs to be done?
maybe it's clear to everyone but me...
Feb 25 2021
(not very useful comment):
Jan 1 2021
Dec 31 2020
Dec 1 2020
I added a wishlist item to add this extension to wmf wikis.
Aug 13 2020
Apr 10 2020
fwiw, i added to mediawiki:minerva.js on hewiki the following line, and the pencils are visible again.
Feb 18 2020
Feb 13 2020
first of all, this is different than the error i see in the console when adding debug=1, which is
Jan 24 2020
can someone please explain
Jan 5 2020
on further examination, it's a bit more complicated than than.
Jan 2 2020
i would add specific chess cases, to verify correct pgn parsing:
- en passant
Nov 8 2019
Aug 8 2019
Jul 29 2019
currently, on wikimedia sites, the parsing _is_ lax, despite what the documentation says.
Jun 13 2019
May 25 2019
Apr 13 2019
another user have copied the whole content of her console:
Apr 12 2019
user reports that on enwiki, and on hewiki with "uselang=en", she _does_ sees the "Save" button, but not with hebrew ui.
Apr 11 2019
Apr 10 2019
legit maps on many wikis are still broken. i believe this story should be reopened - i could not understand the status of the patch, but in production sites (wikipedias of all languages), this is still borked.
Apr 9 2019
Mar 30 2019
Mar 26 2019
this seems to be duplicate of T216318
Mar 25 2019
Mar 15 2019
Mar 14 2019
@IKhitron - if it's not chrome, then can you ask them for browser+version? you sure it's the same report?
so it's not necessarily related to mw update - more likely chrome change.
the url in devtools is:
indeed, it does not happen on the page you linked (i thought it has something to do with debug=true, but no, it does not happen even without).
- further experiments point to section edit (updated repro instructions). i did not see this happen on full page edit.
- with (beta preference) code editor 2017 ("New wikitext mode"), i did not see the issue
- seems to be reliably reproducible with section edit, wikieditor, when beta option turned off.
this happens with any page save/publish, including null edit.
and yes, "eikieditor" is typo, i meant wikieditor. i specified it explicitly b/c we have "visual editor", and "wikieditor 2017".
TBH, i did not try with those - maybe same issue there too. will report if i have more info.
Dec 14 2018
Dec 8 2018
thanks. i find the documentation confusing. it would be nice to mention that "titles" work with this query, and nicer if it will explain what's the diff between lltitles and titles, and when to use each.