Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Performance)Administrator

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (236 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photography by Niek Hidding.)

Recent Activity

Yesterday

Krinkle updated subscribers of Blog Post: Production Excellence: March 2019.
Sun, Apr 21, 6:57 PM
Krinkle updated the post content for Blog Post: Production Excellence: March 2019.
Sun, Apr 21, 6:57 PM
Krinkle added a comment to T133548: Create a secure redirect service for large count of non-canonical / junk domains.

@Krenair I was referring to this bit:

Sun, Apr 21, 6:55 PM · Goal, Patch-For-Review, HTTPS, Operations, Traffic
Krinkle updated the post content for Blog Post: Production Excellence: March 2019.
Sun, Apr 21, 6:51 PM
Krinkle renamed T200471: LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name from [regression] LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name to LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name.
Sun, Apr 21, 4:23 PM · Patch-For-Review, MW-1.33-release, Performance-Team, Regression, MW-1.31-release, MediaWiki-Database
Krinkle removed a project from T200471: LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name: Patch-For-Review.
Sun, Apr 21, 4:23 PM · Patch-For-Review, MW-1.33-release, Performance-Team, Regression, MW-1.31-release, MediaWiki-Database
Krinkle edited projects for T200471: LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name, added: MW-1.33-release; removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes.
Sun, Apr 21, 4:23 PM · Patch-For-Review, MW-1.33-release, Performance-Team, Regression, MW-1.31-release, MediaWiki-Database
Krinkle updated subscribers of T36266: Support substitution of localisation in edit summaries when saving.
Sun, Apr 21, 3:50 PM · MediaWiki-Page-editing
Krinkle closed T71939: Deprecate direct access to class variables as Declined.
Sun, Apr 21, 3:45 PM · Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
Krinkle added a comment to T71939: Deprecate direct access to class variables.

There exists a helper for this purpose now in core (DeprecationHelper triat). It uses __get and I assume that the concern with that for "old PHP versions" no longer applies, given we now require PHP 5.6+/HHVM.

Sun, Apr 21, 3:45 PM · Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
Krinkle added a comment to T200471: LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name.

@Ciencia_Al_Poder From a quick glance, the referenced patch adds a condition for params['wiki'], however I do not see this being set in your configuration. If the configuration has changed or wasn't as described, please provide an updated overview of your DB and ES-related settings.

Sun, Apr 21, 3:35 PM · Patch-For-Review, MW-1.33-release, Performance-Team, Regression, MW-1.31-release, MediaWiki-Database
Krinkle moved T63115: Drop URL parameter setlang from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Sun, Apr 21, 3:25 PM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector
Krinkle added a project to T63115: Drop URL parameter setlang: Performance-Team (Radar).
Sun, Apr 21, 3:25 PM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector
Krinkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

See also T217846 which is making this harder to test.

Sun, Apr 21, 3:23 PM · PHP 7.2 support, Core Platform Team Backlog (Next), Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)
Krinkle added a comment to T221508: webperf2001 is running out of disk space.

There seem to be several major points in time where something significant happened on webperf2001 in the last 7 days.

Sun, Apr 21, 3:17 PM · Operations, Performance-Team
Krinkle added a comment to T221508: webperf2001 is running out of disk space.

There should be only one instance of each on a given webperfx001 instance:

Sun, Apr 21, 3:07 PM · Operations, Performance-Team
Krinkle moved T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach from Backlog to Other on the MediaWiki-User-management board.
Sun, Apr 21, 2:36 PM · MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Krinkle moved T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach from To triage to Files related on the MediaWiki-Special-pages board.
Sun, Apr 21, 2:35 PM · MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Krinkle edited projects for T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach, added: MediaWiki-Special-pages, MediaWiki-User-management; removed MediaWiki-General-or-Unknown.
Sun, Apr 21, 2:35 PM · MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Krinkle added a hashtag to MediaWiki-User-management: #mediawiki-actor-migration.
Sun, Apr 21, 2:35 PM

Sat, Apr 20

Krinkle added a comment to T172480: Add jobrunner servers to Scap canary process.

This task was referenced as actionable for aa recent incident.

Sat, Apr 20, 7:43 PM · Core Platform Team Backlog (Watching / External), Services (watching), WMF-JobQueue, Wikimedia-Incident, Release-Engineering-Team (Next), Scap
Krinkle added a comment to T221295: Wikidata changes doesn't appear in recent changes.

For the record, the issue with the job queue only affected test wikis and mediawiki.org. As a precaution we paused the job queue for all wikis (including Wikidata and Wikipedia).

Sat, Apr 20, 7:23 PM · Wikidata-Campsite, Regression, Wikidata, Growth-Team, MediaWiki-Recent-changes, MediaWiki-extensions-WikibaseClient
Krinkle added a comment to T221281: Remove deprecated EventLogging schema modules.

@Milimetric Yep. I believe there's also a number of such tasks in Phabricator already (from people finding the warnings), which we can attach as sub tasks as well. Thanks!

Sat, Apr 20, 12:53 AM · MW-1.34-release, Technical-Debt (Deprecation), Analytics-EventLogging, Analytics
Krinkle removed projects from T221269: Reduce module registrations from PageTriage: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review.
Sat, Apr 20, 12:52 AM · Growth-Team, MediaWiki-extensions-PageCuration, Performance-Team (Radar)
Krinkle closed T220662: Beta cluster: MassMessage fails with PHP fatal error because of Declaration of JobQueueEventBus::doAck() must be compatible with that of JobQueue::doAck() as Resolved.
  • The task description describes a fatal error with the general logic of running jobs. It was caused by fc5d51f1293 9 days ago, and was fixed the same day with 0091dde3b.
  • A later comment refers to a separate issue specific to Beta Cluster, where jobs were silently disabled for a while. Details at T215339, since then resolved.
  • Comment T220662#5126444 refers to another issue relating to title corruption. This was also reported at T221368 and fixed yesterday.
Sat, Apr 20, 12:02 AM · WMF-JobQueue, MediaWiki-JobQueue, Analytics, EventBus, Beta-Cluster-reproducible, User-DannyS712

Fri, Apr 19

Krinkle added a comment to T208895: Ensure that anywhere BlockDisablesLogin is used, it does not affect partial blocks.

BlockDisablesLogin is used on private and fishbowl wikis (otrswiki, officewiki, …). They grant no rights to anons (except for fishbowls chapter wikis and foundationwiki, which do allow reading). In particular, they disallow signup. Blocks are meant to approximate account removal there. For example, after the term for a role like CheckUser or Steward expires, or after a chapter member leaves.

Fri, Apr 19, 11:21 PM · MediaWiki-User-management
Krinkle added a project to T217136: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException): Core Platform Team.

@Daimona Thanks, I didn't realise that regular Page deletion already does this. That makes a good case for handling this here as well, and also means we may have an existing pattern that we can apply with relative easy (being optimistic).

Fri, Apr 19, 8:16 PM · Core Platform Team, MediaWiki-Special-pages, MediaWiki-Page-deletion, User-Daimona, User-revi, Wikimedia-production-error
Krinkle moved T217136: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException) from To triage to Move/Merge on the MediaWiki-Special-pages board.
Fri, Apr 19, 8:13 PM · Core Platform Team, MediaWiki-Special-pages, MediaWiki-Page-deletion, User-Daimona, User-revi, Wikimedia-production-error
Krinkle renamed T217136: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException) from Fatal exception of type "MWException" when trying to move a page on thwiki to Unhandled internal error from page deletion during Special:MovePage (Fatal MWException).
Fri, Apr 19, 8:13 PM · Core Platform Team, MediaWiki-Special-pages, MediaWiki-Page-deletion, User-Daimona, User-revi, Wikimedia-production-error
Krinkle added a project to T219816: Fatal IncompleteRevisionException when restoring an article (undelete page): Growth-Team.

(Tagging steward per mw:Maintainers for initial triage.)

Fri, Apr 19, 7:40 PM · Growth-Team, Wikimedia-production-error, MediaWiki-Page-deletion
Krinkle edited projects for T219702: Database query errors occurring when importing, added: MediaWiki-Revision-backend; removed MediaWiki-Database.

I'm not seeing a specific thing for Core Platform to do at the moment, but if the issue still exists we are happy to take a look.

Fri, Apr 19, 7:38 PM · MediaWiki-Revision-backend, Core Platform Team Backlog (Watching / External), MediaWiki-Export-or-Import, Wikimedia-production-error, Chinese-Sites
Krinkle renamed T221347: Investigate why a string literal changed in opcache (Fatal exception of type "ConfigException") from Fatal exception of type "ConfigException" to Investigate why a string literal changed in opcache (Fatal exception of type "ConfigException").
Fri, Apr 19, 7:15 PM · PHP 7.2 support, Operations, Wikimedia-production-error
Krinkle added a comment to T218692: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error".

So there are two issues here:

Fri, Apr 19, 7:08 PM · Core Platform Team Backlog (Watching / External), WMF-JobQueue, Wikimedia-production-error, MediaWiki-Database
Krinkle removed a project from T219234: Job runner request timeouts in Elastica\Task: Patch-For-Review.
Fri, Apr 19, 6:57 PM · Discovery-Search (Current work), CirrusSearch, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikimedia-production-error
Krinkle added a hashtag to CirrusSearch: #mediawiki-extensions-elastica.
Fri, Apr 19, 6:57 PM
Krinkle added a project to T219234: Job runner request timeouts in Elastica\Task: CirrusSearch.
Fri, Apr 19, 6:55 PM · Discovery-Search (Current work), CirrusSearch, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikimedia-production-error
Krinkle moved T67336: EchoTalkPageFunctionalTest::testAddCommentsToTalkPage is broken from Untriaged to Resolved on the Wikimedia-production-error (Shared Build Failure) board.
Fri, Apr 19, 6:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikimedia-production-error (Shared Build Failure), Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt, Notifications
Krinkle added a project to T67336: EchoTalkPageFunctionalTest::testAddCommentsToTalkPage is broken: Wikimedia-production-error (Shared Build Failure).
Fri, Apr 19, 6:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikimedia-production-error (Shared Build Failure), Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt, Notifications
Krinkle added a project to T216664: MWException when viewing or comparing certain pages with Preprocessor_DOM (PHP7 beta feature): Core Platform Team.
Fri, Apr 19, 5:58 PM · Core Platform Team, Patch-For-Review, PHP 7.2 support, MediaWiki-History-and-Diffs, MediaWiki-Parser, Wikimedia-production-error
Krinkle removed a project from T221058: Fatal error when submitting "insource" query on mediawiki.org: Patch-For-Review.
Fri, Apr 19, 5:41 PM · Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
Krinkle changed the subtype of T217953: When installer fails to connect to a database, let user know if wgDBadminpassword was used from "Bug Report" to "Task".
Fri, Apr 19, 5:31 PM · MediaWiki-Installer
Krinkle edited projects for T217953: When installer fails to connect to a database, let user know if wgDBadminpassword was used, added: MediaWiki-Installer; removed MediaWiki-Database.
Fri, Apr 19, 5:31 PM · MediaWiki-Installer
Krinkle renamed T217953: When installer fails to connect to a database, let user know if wgDBadminpassword was used from 1.32.0 installed on host A cannot authenticate to MySQL on host B with password when $wgDBadminpassword is blank in LocalSettings.php to When installer fails to connect to a database, let user know if wgDBadminpassword was used.
Fri, Apr 19, 5:31 PM · MediaWiki-Installer
Krinkle added a comment to T217953: When installer fails to connect to a database, let user know if wgDBadminpassword was used.

I guess there may be legitimate reasons for having different $wgDBadminuser and $wgDBadminpassword, but perhaps if $wgDBadminuser == $wgDBuser the above info message could be printed.

Fri, Apr 19, 5:29 PM · MediaWiki-Installer
Krinkle moved T217720: Investigate rare "DBConnectionError: No working replica DB server" from wfGetDB (in load.php) from Found during 1.33-wmf.19 to Found longer ago on the Wikimedia-production-error board.
Fri, Apr 19, 5:18 PM · Wikimedia-production-error, Performance-Team, MediaWiki-Database, MediaWiki-ResourceLoader
Krinkle triaged T212284: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki') as Normal priority.
Fri, Apr 19, 5:04 PM · Performance-Team, Core Platform Team Backlog (Later), Services (next), MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Krinkle removed projects from T212284: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki'): MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review.
Fri, Apr 19, 5:00 PM · Performance-Team, Core Platform Team Backlog (Later), Services (next), MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Krinkle added a comment to T212284: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki').

The above patch made the error message different. It can now be found by searching for DatabaseMysqlBase::doSelectDomain or for ("USE centralauth" OR "USE metawiki").

Fri, Apr 19, 5:00 PM · Performance-Team, Core Platform Team Backlog (Later), Services (next), MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Krinkle closed T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported) as Resolved.
Fri, Apr 19, 3:45 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Krinkle added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

@Krinkle we load the MediaWiki:Portal-url, and then verify if title exists -> if the page doesn't exist we do not show the link.

Fri, Apr 19, 3:12 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Krinkle renamed T221201: Prepare and check storage layer for initiativeswiki from Prepare and check storage layer for iniciativeswiki to Prepare and check storage layer for initiativeswiki.
Fri, Apr 19, 2:40 PM · Cloud-Services, DBA
Krinkle added a comment to T105683: scap should be LCStore-agnostic.

I recall seeing at some point changeset(s) for Scap that did some work toward this end, but can't find them now.

Fri, Apr 19, 1:00 AM · Release-Engineering-Team, Scap
Krinkle added a project to T105683: scap should be LCStore-agnostic: Release-Engineering-Team.
Fri, Apr 19, 1:00 AM · Release-Engineering-Team, Scap

Thu, Apr 18

Krinkle added a subtask for T203695: Drastically reduce the number of ResourceLoader modules that CX creates: T221361: mw.cx.widgets.ProgressBarWidget.js is not used anywhere.
Thu, Apr 18, 11:24 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Language-Team (Language-2019-April-June), Performance-Team (Radar), ContentTranslation
Krinkle added a parent task for T221361: mw.cx.widgets.ProgressBarWidget.js is not used anywhere: T203695: Drastically reduce the number of ResourceLoader modules that CX creates.
Thu, Apr 18, 11:24 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), ContentTranslation
Krinkle edited projects for T218207: Use disk-based LCStore by default in MediaWiki 1.34, added: Performance-Team; removed Performance-Team (Radar).
Thu, Apr 18, 11:23 PM · Performance-Team, Core Platform Team Backlog (Later), Core Platform Team (Security, stability, performance and scalability (TEC1)), Language-Team, MediaWiki-Internationalization, MW-1.34-release
Krinkle claimed T218207: Use disk-based LCStore by default in MediaWiki 1.34.

Assigning to self, to do perf comparison for page view reads with a local install. Comparing the stock default of a db table on sqlite, vs cdb vs static-array. This is an interesting comparison because unlike for MySQL, sqlite would technically be a local disk read just as a file-based l10n cache would be. I would imagine the static array read to be far more efficient (which is the one we proposed). I can still compare cdb file open-read perf between sqlite3 file open-read performance, though.

Thu, Apr 18, 11:23 PM · Performance-Team, Core Platform Team Backlog (Later), Core Platform Team (Security, stability, performance and scalability (TEC1)), Language-Team, MediaWiki-Internationalization, MW-1.34-release
Krinkle added a project to T212550: Implement support for ChronologyProtection in RDF export: Performance-Team.

Another question for @aaron as well - If we start storing this chronologyprotector field in kafka etc. that means it can survive longer and no longer has an expiry like we do for cookies. I vaguely recall an issue in the past where clients that kept the value too long caused subsequent requests to stall for many seconds as MW mistook the unknown value for a value that hasn't appeared yet.

Thu, Apr 18, 10:28 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Performance-Team, Patch-For-Review, User-Smalyshev, Wikidata, Wikidata-Query-Service
Krinkle created T221410: Disable Jenkins jobs for php70/php71 in for wmf branches.
Thu, Apr 18, 9:08 PM · Release-Engineering-Team, Continuous-Integration-Config
Krinkle closed T221368: cdnPurge and other jobs fail completely to execute as Resolved.

Confirmed to work again on mediawiki.org by making an edit on a template, and confirming from Incognito (cached enabled) that pages using it got the update propagated. Also confirmed via logged-in, and via Translate extension.

Thu, Apr 18, 8:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle closed T221368: cdnPurge and other jobs fail completely to execute, a subtask of T220726: 1.34.0-wmf.1 deployment blockers, as Resolved.
Thu, Apr 18, 8:46 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Krinkle created T221401: Repopulate missing coal data in Graphite for 2019-04-17 outage.
Thu, Apr 18, 7:20 PM · Performance-Team
Krinkle moved T221152: DBPerformance warning from SiteStatsUpdate for unexpected writes on GET from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Thu, Apr 18, 7:07 PM · MediaWiki-General-or-Unknown, Wikimedia-production-error, Performance-Team
Krinkle moved T221179: Measure time spent in rIC and $.ready with mw.loader.profiler. from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Thu, Apr 18, 7:07 PM · Fresnel, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T221347: Investigate why a string literal changed in opcache (Fatal exception of type "ConfigException") from Found during 1.34-wmf.1 to Found during 1.33-wmf.23 on the Wikimedia-production-error board.
Thu, Apr 18, 7:05 PM · PHP 7.2 support, Operations, Wikimedia-production-error
Krinkle added a comment to T221368: cdnPurge and other jobs fail completely to execute.

@mobrovac Okay, I've looked it over a few more times and am now confident that with this second EventBus patch, we can proceed without the core patch.

Thu, Apr 18, 6:47 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.
From the Task description:
  • The community portal URL is customisable. It should be loaded from the message MediaWiki:Portal-url. If the message doesn't exist, do not show it.
Thu, Apr 18, 6:39 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Krinkle added a comment to T219001: Doxygen doesn't handle `@inheritDoc` by default, only `@inheritdoc`.

At glance, it seems to be like the simplest option would be to standardise on @inheritdoc (option 1) – at least in the short-term.

Thu, Apr 18, 6:00 PM · Upstream, Patch-For-Review, MediaWiki-Codesniffer, Documentation, MediaWiki-Documentation
Krinkle moved T221368: cdnPurge and other jobs fail completely to execute from Untriaged to Found during 1.34-wmf.1 on the Wikimedia-production-error board.
Thu, Apr 18, 4:32 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle reassigned T221368: cdnPurge and other jobs fail completely to execute from Krinkle to aaron.
Thu, Apr 18, 4:32 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle added a comment to T221368: cdnPurge and other jobs fail completely to execute.

@Pchelolo Yeah, I also see a few other pre-existing problems here that we're lucky haven't caused problems before.

Thu, Apr 18, 3:45 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle added a comment to T221368: cdnPurge and other jobs fail completely to execute.

Assigning to self to start investigating. May need to transfer to Aaron once his day starts :)

Thu, Apr 18, 3:01 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle claimed T221368: cdnPurge and other jobs fail completely to execute.
Thu, Apr 18, 3:01 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle added a comment to T221368: cdnPurge and other jobs fail completely to execute.

In Kafka queue upon deserialization we try to create a Title from that using newFromPrefixedDBKey and it obviously fails.
First, the core probably shouldn't assign invalid title as a default, and secondly, kafka job queue should be prepared to deal with new title-less jobs.

Thu, Apr 18, 2:59 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Krinkle moved T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release from Not yet to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation) board.
Thu, Apr 18, 2:52 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MediaWiki-General-or-Unknown, Technical-Debt (Deprecation), MW-1.34-release
Krinkle added a comment to T220926: Deprecate and remove mw.config wgMainPageTitle.

That's right. For Wikimedia wikis I found. I usage and do not think it worth announcing via Tech News.

Thu, Apr 18, 12:26 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-ResourceLoader, Technical-Debt (Deprecation), MW-1.34-release, Performance-Team

Wed, Apr 17

Krinkle added a comment to T216308: RFC Process: 2019 amendments.

@Tgr In your example "closing an RFC" is not the same as "closing a task tagged TechCom-RFC". If the task represents only an RFC, then closing it would mean closing the task, there is no reason not to. If the task in question tracks other work, or tracks a general intent for a product or feature, then closing it would mean removing the tag probably. In both cases, it can always be re-tagged or re-opened.

Wed, Apr 17, 11:02 PM · TechCom-RFC, TechCom
Krinkle added a comment to T133548: Create a secure redirect service for large count of non-canonical / junk domains.

@Dzahn Assuming that with Let's Encrypt, HTTPS will work in modern browsers for all redirects - do we need any of the redirect domains in SAN? Perhaps we don't need any. Afaik all redirect-like domains used in official branding or advertising are actually considered "canonical" for the purposes of this ticket, and would not go to the redirect service (e.g. w.wiki and jobs.wikimedia.org). Is that right?

Wed, Apr 17, 10:31 PM · Goal, Patch-For-Review, HTTPS, Operations, Traffic
Krinkle added a comment to T167375: Creation of a "Campaign" Wiki - initiatives.wikimedia.org.

@Jseddon Will this mean fixcopyright.wikimedia.org gets sunset and redirects to something within this new wiki?

Wed, Apr 17, 10:23 PM · Patch-For-Review, Wiki-Setup, User-Urbanecm, Fundraising-Backlog
Krinkle added a comment to T221294: VisualEditorDesktopArticleTargetInitModule::getMessages runs expensive checks for startup hashing.

[mediawiki/extensions/VisualEditor@master] DesktopArticleTargetInitModule: Remove expensive $msg->exists check
https://gerrit.wikimedia.org/r/504788

Wed, Apr 17, 10:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor, Performance-Team (Radar)
Krinkle moved T221269: Reduce module registrations from PageTriage from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Wed, Apr 17, 9:21 PM · Growth-Team, MediaWiki-extensions-PageCuration, Performance-Team (Radar)
Krinkle moved T221294: VisualEditorDesktopArticleTargetInitModule::getMessages runs expensive checks for startup hashing from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Wed, Apr 17, 9:21 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor, Performance-Team (Radar)
Krinkle created T221294: VisualEditorDesktopArticleTargetInitModule::getMessages runs expensive checks for startup hashing.
Wed, Apr 17, 9:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor, Performance-Team (Radar)
Krinkle updated subscribers of T216308: RFC Process: 2019 amendments.

Another note based on a comment from @Milimetric in today's TC meeting.

Wed, Apr 17, 8:56 PM · TechCom-RFC, TechCom
Krinkle claimed T220723: Install extension require-dev dependencies in wmf-quibble-vendor-mysql-hhvm-docker.
Wed, Apr 17, 8:46 PM · TechCom, Librarization, Quibble
Krinkle moved T188689: Finalise addModuleStyles() and addModuleScripts() legacy behaviours from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-release, Technical-Debt (Deprecation), Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T209699: Deprecate then remove jquery.async module from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-release, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
Krinkle moved T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-release, Technical-Debt (Deprecation), JavaScript, MediaWiki-General-or-Unknown
Krinkle moved T220996: Deprecate and remove ExtensionRegistry::load() from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-D3r1ck01, Technical-Debt (Deprecation), Patch-For-Review, good first bug, MW-1.34-release, MediaWiki-Configuration
Krinkle moved T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MediaWiki-General-or-Unknown, Technical-Debt (Deprecation), MW-1.34-release
Krinkle moved T221281: Remove deprecated EventLogging schema modules from Backlog to Deprecate/Remove on the MW-1.34-release board.
Wed, Apr 17, 7:50 PM · MW-1.34-release, Technical-Debt (Deprecation), Analytics-EventLogging, Analytics
Krinkle moved T221281: Remove deprecated EventLogging schema modules from Not yet to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation) board.
Wed, Apr 17, 7:44 PM · MW-1.34-release, Technical-Debt (Deprecation), Analytics-EventLogging, Analytics
Krinkle added a subtask for T219342: Pageview performance timeline analysis (March 2019): T221281: Remove deprecated EventLogging schema modules.
Wed, Apr 17, 7:44 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Performance-Team
Krinkle added a parent task for T221281: Remove deprecated EventLogging schema modules: T219342: Pageview performance timeline analysis (March 2019).
Wed, Apr 17, 7:44 PM · MW-1.34-release, Technical-Debt (Deprecation), Analytics-EventLogging, Analytics
Krinkle created T221281: Remove deprecated EventLogging schema modules.
Wed, Apr 17, 7:43 PM · MW-1.34-release, Technical-Debt (Deprecation), Analytics-EventLogging, Analytics
Krinkle created T221279: patch-coverage HTML report is missing details of new file coverage.
Wed, Apr 17, 7:40 PM · phpunit-patch-coverage
Krinkle added a project to T221273: Consider adding .mw-wiki-logo {margin-top: 0.5em} to skin CSS: Vector.
Wed, Apr 17, 7:04 PM · Vector
Krinkle added a comment to T37174: Add shortcut for linking to templates in edit summaries (e.g. {{foo}} -> [[Template:Foo]]).

@daniel No, there are no substitutions on the edit summary apart from link syntax. All other text is preserved as is. I imagine it's not unlikely to have edit summaries like "Fix bug with ~~~" or "Forgot to add ~~~~". example.

Wed, Apr 17, 7:02 PM · Core Platform Team, MediaWiki-History-and-Diffs
Krinkle created T221269: Reduce module registrations from PageTriage.
Wed, Apr 17, 6:40 PM · Growth-Team, MediaWiki-extensions-PageCuration, Performance-Team (Radar)
Krinkle updated the task description for T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers.
Wed, Apr 17, 6:28 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata