Krinkle (Timo Tijhof)
Principal Performance Engineer, Wikimedia Foundation

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (192 w, 6 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Yesterday

Krinkle added a comment to T180183: Profiling for X-Wikimedia-Debug seems to start fairly late.

Sounds good to me.

Mon, Jun 18, 9:19 AM · User-Joe, Patch-For-Review, Performance-Team-notice, MediaWiki-Debug-Logger, Performance-Team
Krinkle updated the task description for T116948: CodeReview extension: Code stewardship review.
Mon, Jun 18, 12:20 AM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests
Krinkle raised the priority of T116948: CodeReview extension: Code stewardship review from Low to Needs Triage.
Mon, Jun 18, 12:17 AM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests
Krinkle renamed T116948: CodeReview extension: Code stewardship review from Undeploy CodeReview to CodeReview extension: Code stewardship review.
Mon, Jun 18, 12:17 AM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests
Krinkle updated the task description for T116948: CodeReview extension: Code stewardship review.
Mon, Jun 18, 12:17 AM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests

Sun, Jun 17

Krinkle added a hashtag to Code-Stewardship-Reviews: #sunsetting-process.
Sun, Jun 17, 11:23 PM
Krinkle removed a project from T116948: CodeReview extension: Code stewardship review: Patch-For-Review.
Sun, Jun 17, 11:23 PM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests
Krinkle edited projects for T116948: CodeReview extension: Code stewardship review, added: Code-Stewardship-Reviews; removed Cleanup.
Sun, Jun 17, 11:23 PM · Code-Stewardship-Reviews, Technical-Debt, MediaWiki-extensions-CodeReview, Wikimedia-Site-requests
Krinkle moved T179610: Investigate and clean up deprecated ORES repos from Backlog to Archive other on the Cleanup board.
Sun, Jun 17, 11:20 PM · Release-Engineering-Team (Watching / External), Cleanup, Repository-Admins, Scoring-platform-team, Gerrit
Krinkle moved T197503: Archive operations/puppet/varnishkafka repository from Backlog to Archive other on the Cleanup board.
Sun, Jun 17, 11:19 PM · Analytics, Patch-For-Review, Operations, Cleanup
Krinkle closed T196617: Archive the ClientSide extension as Resolved.

Thanks @MarcoAurelio !

Sun, Jun 17, 11:19 PM · MediaWiki-extensions-Other, User-MarcoAurelio, GitHub-Mirrors, Repository-Admins, Cleanup
Krinkle updated the task description for T196617: Archive the ClientSide extension.
Sun, Jun 17, 11:19 PM · MediaWiki-extensions-Other, User-MarcoAurelio, GitHub-Mirrors, Repository-Admins, Cleanup
Krinkle renamed T173228: Rethink font stack for Timeless skin from Font stack is dumb to Rethink font stack for Timeless skin.
Sun, Jun 17, 9:26 PM · Timeless

Sat, Jun 16

Krinkle edited projects for T160910: File moves throw error when using postgres, added: Performance-Team; removed Patch-For-Review.
Sat, Jun 16, 10:38 PM · Performance-Team, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-Database, MediaWiki-File-management, Multimedia, PostgreSQL
Krinkle edited projects for T184525: Explicitly providing a database index to LoadBalancer::getConnection() should return the selected connection., added: Performance-Team; removed Patch-For-Review.
Sat, Jun 16, 10:38 PM · Performance-Team, MediaWiki-Database
Krinkle added a project to T97562: WANObjectCache relay daemon or mcrouter support: Performance-Team.
Sat, Jun 16, 10:37 PM · Performance-Team, Services (watching), Availability (MediaWiki-MultiDC)
Krinkle renamed T196773: Add sniff to disallow use of "[optional]" in places that break Phan (e.g. among @param type hints) from remove [optional] from parameter docs to Add sniff to disallow use of "[optional]" in places that break Phan (e.g. among @param type hints).
Sat, Jun 16, 6:30 PM · MediaWiki-Codesniffer
Krinkle updated subscribers of T196773: Add sniff to disallow use of "[optional]" in places that break Phan (e.g. among @param type hints).

Indeed. It is a purely textual convention with no run-time impact on any of the tooling involved. Within the objectcache and rdbms libs, @aaron and I have been (loosely) following the convention of using [optional] Description. Default: "x".

Sat, Jun 16, 6:29 PM · MediaWiki-Codesniffer
Krinkle added a comment to T196185: Drop $wgDBmysql5 from MediaWiki.

Most likely, you will not have to do anything. [..]
However, to be sure, let us know, what value do you have for $wgDBTableOptions?

Currently set as
$wgDBTableOptions = "ENGINE=InnoDB, DEFAULT CHARSET=binary";

Sat, Jun 16, 6:25 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, MW-1.32-release, Performance-Team (Radar), MediaWiki-Installer, Technical-Debt, MediaWiki-Database
Krinkle moved T197273: resource-modules linter fails because mw.track is defined twice from Limbo to Ours done on the Performance-Team (Radar) board.
Sat, Jun 16, 6:02 PM · Performance-Team (Radar), Patch-For-Review, Readers-Web-Backlog, Readers-Web-Kanbanana-Board
Krinkle edited projects for T197273: resource-modules linter fails because mw.track is defined twice, added: Performance-Team (Radar); removed Performance-Team.
Sat, Jun 16, 6:02 PM · Performance-Team (Radar), Patch-For-Review, Readers-Web-Backlog, Readers-Web-Kanbanana-Board
Krinkle moved T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded from External to Ours done on the Performance-Team (Radar) board.
Sat, Jun 16, 6:01 PM · MediaWiki-Cache, wikiba.se, Internet-Archive, Readers-Web-Backlog, Wikidata, Parsing-Team, Performance-Team (Radar), MediaWiki-Parser, Math
Krinkle renamed T196412: Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php from ErrorException from line 58 of /srv/mediawiki/w/extensions/FlaggedRevs/backend/FRUserActivity.php: PHP Warning: count(): Parameter must be an array or an object that implements Countable to Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php.
Sat, Jun 16, 5:43 PM · Patch-For-Review, PHP 7.2 support, MediaWiki-extensions-FlaggedRevs
Krinkle triaged T191941: Gadget CSS should be applied after Site styles as High priority.
Sat, Jun 16, 3:39 PM · Regression, MediaWiki-ResourceLoader, Performance-Team, Gadgets
Krinkle changed the status of T191941: Gadget CSS should be applied after Site styles from Stalled to Open.
Sat, Jun 16, 3:39 PM · Regression, MediaWiki-ResourceLoader, Performance-Team, Gadgets
Krinkle added projects to T191941: Gadget CSS should be applied after Site styles: Performance-Team, MediaWiki-ResourceLoader.

@Dispenser Please specify the wiki+page and/or full url at which you can consistently see this, and whether it applies to logged-in, logged-out, or both. If logged-in only, does this require specific user preferences to be set?

Sat, Jun 16, 3:39 PM · Regression, MediaWiki-ResourceLoader, Performance-Team, Gadgets
Krinkle added a project to T197503: Archive operations/puppet/varnishkafka repository: Operations.
Sat, Jun 16, 12:04 AM · Analytics, Patch-For-Review, Operations, Cleanup
Krinkle created T197503: Archive operations/puppet/varnishkafka repository.
Sat, Jun 16, 12:04 AM · Analytics, Patch-For-Review, Operations, Cleanup

Fri, Jun 15

Krinkle changed the status of T191934: Add support for HTTP 307 and 308 to OutputPage::redirect from Open to Stalled.
Fri, Jun 15, 10:02 PM · MediaWiki-Interface, Patch-For-Review
Krinkle added a comment to T191934: Add support for HTTP 307 and 308 to OutputPage::redirect.

@Alexia Reminder about the CR at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/425439/3/includes/OutputPage.php

Fri, Jun 15, 10:02 PM · MediaWiki-Interface, Patch-For-Review
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Fri, Jun 15, 8:56 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Fri, Jun 15, 8:56 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Fri, Jun 15, 8:36 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle added a parent task for T187207: Spin out a tiny EventLogging RL module for lightweight logging: T192862: Reduce overhead of navtiming beacon.
Fri, Jun 15, 6:57 PM · Performance-Team (Radar), Analytics-EventLogging, Analytics
Krinkle added a subtask for T192862: Reduce overhead of navtiming beacon: T187207: Spin out a tiny EventLogging RL module for lightweight logging.
Fri, Jun 15, 6:57 PM · Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle added a project to T163141: dbtree: make wasat a working backend and become active-active : Availability.
Fri, Jun 15, 6:51 PM · Availability, Traffic, DBA, Operations
Krinkle updated the task description for T163141: dbtree: make wasat a working backend and become active-active .
Fri, Jun 15, 6:50 PM · Availability, Traffic, DBA, Operations
Krinkle added a comment to T176916: Find PHP7 alternative for HHVM's Xenon.

Measured the overhead of xhprof's sample mode.

Fri, Jun 15, 6:30 PM · Patch-For-Review, PHP 7.0 support, Performance-Team, MediaWiki-Platform-Team
Krinkle removed a project from T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded: Performance.
Fri, Jun 15, 5:05 PM · MediaWiki-Cache, wikiba.se, Internet-Archive, Readers-Web-Backlog, Wikidata, Parsing-Team, Performance-Team (Radar), MediaWiki-Parser, Math
Krinkle added a comment to T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded.

@Jdlrobson It does indeed appear to be a bug somewhere relating to cache pollution, in particular it seems a cache key somewhere is being shared between mobile and desktop that shouldn't be.

Fri, Jun 15, 5:05 PM · MediaWiki-Cache, wikiba.se, Internet-Archive, Readers-Web-Backlog, Wikidata, Parsing-Team, Performance-Team (Radar), MediaWiki-Parser, Math
Krinkle removed a project from T186680: Inconsistent success using PerformanceInspector: Patch-For-Review.
Fri, Jun 15, 4:01 PM · Performance-Team, PerformanceInspector
Krinkle triaged T186680: Inconsistent success using PerformanceInspector as Normal priority.

Is this resolved now?

Fri, Jun 15, 4:00 PM · Performance-Team, PerformanceInspector
Krinkle removed projects from T188689: Finalise addModuleStyles() and addModuleScripts() legacy behaviours: MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review.
Fri, Jun 15, 3:51 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), MW-1.33-release, Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle renamed T25122: Clean up $wgUseSharedUploads defaults from Deprecate $wgUseSharedUploads and friends to Clean up $wgUseSharedUploads defaults.
Fri, Jun 15, 3:51 PM · Commons, Technical-Debt, Multimedia, MediaWiki-File-management
Krinkle updated the task description for T7176: Remove use of `@access`, `@protected` and `@private` on public methods in MediaWiki.
Fri, Jun 15, 3:44 PM · Technical-Debt, MediaWiki-General-or-Unknown
Krinkle renamed T7176: Remove use of `@access`, `@protected` and `@private` on public methods in MediaWiki from Make access declarations private protected and public really mean it to Remove use of `@access`, `@protected` and `@private` on public methods in MediaWiki.
Fri, Jun 15, 3:43 PM · Technical-Debt, MediaWiki-General-or-Unknown
Krinkle closed T193263: PHP BadMethodCallException exception on load.php as Declined.

Closing report of exception that has been inactive for several months. Feel free to re-open once you have more information. Alternatively, you can also look for support on https://discourse-mediawiki.wmflabs.org/.

Fri, Jun 15, 3:40 PM · Performance-Team, MediaWiki-ResourceLoader, JavaScript, MediaWiki-General-or-Unknown
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Fri, Jun 15, 3:33 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle added a comment to T184216: Figure out how to implement dynamic @covers tags.

Ah, I assumed it was a base class test that subclasses extend and override a utility method controlling the subject class. But I see it's actually all in a single test. Yeah, that's a tough one.

Fri, Jun 15, 1:13 PM · Test-Coverage, MediaWiki-Core-Tests
Krinkle moved T179632: Jenkins-bot should remind users to add documentation for new functions from Inbox to Linters on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:57 PM · MediaWiki-Codesniffer, Continuous-Integration-Config, Documentation, MediaWiki-Core-Tests
Krinkle moved T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files) from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:57 PM · Easy, MediaWiki-General-or-Unknown, Test-Coverage, MediaWiki-Core-Tests
Krinkle moved T114846: Enable PhanUndeclaredVariable rule in MediaWiki core from Inbox to Linters on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:57 PM · MediaWiki-Core-Tests
Krinkle moved T193943: Selenium test job should install local dependencies before starting tests from Inbox to Selenium on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:57 PM · User-zeljkofilipin, Release-Engineering-Team, MediaWiki-Core-Tests
Krinkle moved T181842: ChangesListSpecialPageTest uses many protected functions/members from ChangesListSpecialPage from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page, MediaWiki-Special-pages, MediaWiki-Core-Tests
Krinkle moved T182382: ParserIntegrationTest failures on PHP 7.2 from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · PHP 7.2 support, MediaWiki-Core-Tests, MediaWiki-Parser
Krinkle moved T183885: ApiDisabled and ApiQueryDisabled should have PHPUnit tests from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · Easy, MediaWiki-API, MediaWiki-Core-Tests
Krinkle moved T183798: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · Multi-Content-Revisions, MediaWiki-Core-Tests
Krinkle moved T183897: ProxyLookup class does not have PHPUnit tests from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · Google-Code-in-2017, MediaWiki-Core-Tests
Krinkle moved T184216: Figure out how to implement dynamic @covers tags from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:56 PM · Test-Coverage, MediaWiki-Core-Tests
Krinkle added a comment to T184216: Figure out how to implement dynamic @covers tags.

Would it work to add a @covers MyClassName to the doc block for the test case subclass?

Fri, Jun 15, 12:56 PM · Test-Coverage, MediaWiki-Core-Tests
Krinkle added a project to T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files): Easy.
Fri, Jun 15, 12:55 PM · Easy, MediaWiki-General-or-Unknown, Test-Coverage, MediaWiki-Core-Tests
Krinkle awarded T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files) a Orange Medal token.
Fri, Jun 15, 12:54 PM · Easy, MediaWiki-General-or-Unknown, Test-Coverage, MediaWiki-Core-Tests
Krinkle triaged T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files) as Normal priority.
Fri, Jun 15, 12:54 PM · Easy, MediaWiki-General-or-Unknown, Test-Coverage, MediaWiki-Core-Tests
Krinkle renamed T184782: Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files) from PHPUnit is not reporting test coverage for *.inc maintenance scripts to Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files).
Fri, Jun 15, 12:54 PM · Easy, MediaWiki-General-or-Unknown, Test-Coverage, MediaWiki-Core-Tests
Krinkle moved T188773: Test to validate deletion log entries and ArticleDeleteComplete hook performers from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:54 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MediaWiki-Core-Tests, Patch-For-Review, Wikimedia-Incident, MediaWiki-Logging
Krinkle moved T191771: [REL1_30] Some parserTests fail on debian stretch using Tidy, because of a new version of libtidy from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Quibble, Tidy, MediaWiki-Core-Tests, MediaWiki-Parser
Krinkle moved T190898: CentralAuth makes phpunit.php crash with an exception from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Core-Tests
Krinkle moved T191960: MediaWikiTestCase::hideDeprecated() does not reset between tests from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · MediaWiki-Core-Tests
Krinkle moved T191982: Blog posts about new Selenium framework features from Inbox to Selenium on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · Documentation, JavaScript, MediaWiki-Core-Tests, Release-Engineering-Team (Kanban), User-zeljkofilipin
Krinkle moved T192167: Drop support for PHPUnit 4.x from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · Patch-For-Review, PHP 7.0 support, MediaWiki-Core-Tests
Krinkle moved T192078: Figure out some way to not use addUncoveredFilesFromWhitelist="true" when running only some PHPUnit tests from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:53 PM · Test-Coverage, Continuous-Integration-Config, MediaWiki-Core-Tests
Krinkle added a project to T193995: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::patchPath(): Performance-Team.
Fri, Jun 15, 12:53 PM · Performance-Team, MediaWiki-Installer, MediaWiki-Core-Tests
Krinkle removed a project from T193995: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::patchPath(): MediaWiki-Database.
Fri, Jun 15, 12:52 PM · Performance-Team, MediaWiki-Installer, MediaWiki-Core-Tests
Krinkle moved T193995: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::patchPath() from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:51 PM · Performance-Team, MediaWiki-Installer, MediaWiki-Core-Tests
Krinkle triaged T193995: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::patchPath() as High priority.

C:\xampp\htdocs\Dev\core\tests\parser\DbTestRecorder.php: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::patchPath()

That's weird because in ./includes/installer/DatabaseUpdater.php you have public function patchPath( IDatabase $db, $patch ) defined.

Fri, Jun 15, 12:51 PM · Performance-Team, MediaWiki-Installer, MediaWiki-Core-Tests
Krinkle moved T195807: Fix failing MediaWiki core tests on Postgres database backend from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, PostgreSQL, MediaWiki-Core-Tests
Krinkle moved T196456: [Lingo] tests are failling when run with MediaWiki structure tests from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-extensions-Lingo
Krinkle moved T196323: PHPUnit entry point 'PHPUnit_TextUI_Command' not found during mediawiki-phpunit-coverage-patch job from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · Continuous-Integration-Config, MediaWiki-Core-Tests
Krinkle moved T196792: MediaWiki\Session\PHPSessionHandler::open: Wrong instance called from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · MediaWiki-General-or-Unknown, PHP 7.2 support, MediaWiki-Core-Tests
Krinkle moved T182383: ExifRotationTest test fails on PHP 7.2 from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · Multimedia, MediaWiki-Core-Tests, PHP 7.2 support, MediaWiki-File-management
Krinkle moved T196791: UserTest::testIsLocallyBlockedProxy calling hideDeprecated is ineffective from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · MediaWiki-Core-Tests
Krinkle moved T196794: JpegTest::testGetIndependentMetaArray fails on PHP 7.2 from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · PHP 7.2 support, Multimedia, MediaWiki-Core-Tests, MediaWiki-File-management
Krinkle moved T196795: UploadStashTest::testExceptionWhenStoreTempFails Unexpected exception class PHPUnit\Framework\Error\Notice from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · PHP 7.2 support, Multimedia, MediaWiki-Core-Tests, MediaWiki-File-management
Krinkle moved T196977: @runInSeparateProcess causes an infite loop preventing test from running from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Jun 15, 12:48 PM · MediaWiki-Core-Tests
Krinkle updated subscribers of T197450: test.wp is using test2.wp's message cache.
Fri, Jun 15, 12:31 PM · Patch-For-Review, Performance-Team, Gadgets, MediaWiki-Cache, Operations
Krinkle added projects to T197450: test.wp is using test2.wp's message cache: Gadgets, Performance-Team.
Fri, Jun 15, 12:30 PM · Patch-For-Review, Performance-Team, Gadgets, MediaWiki-Cache, Operations
Krinkle closed T123219: Figure out whether we can get rid of IE8 scrolling hack from WikiEditor, a subtask of T123218: Remove IE8 hacks/workarounds/etc. from extensions, as Resolved.
Fri, Jun 15, 12:28 PM · Easy, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), MediaWiki-extensions-General, Developer-Wishlist (2017), Goal, Browser-Support-Internet-Explorer, Technical-Debt
Krinkle closed T123219: Figure out whether we can get rid of IE8 scrolling hack from WikiEditor as Resolved.
Fri, Jun 15, 12:28 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review, WikiEditor, Technical-Debt
Krinkle updated subscribers of T123221: [Task] Remove IE8 workarounds from Wikibase.

[mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js)
https://gerrit.wikimedia.org/r/392663

Fri, Jun 15, 12:27 PM · Browser-Support-Internet-Explorer, Need-volunteer, ValueView, DataValues-JavaScript, MediaWiki-extensions-WikibaseView, Wikidata, Technical-Debt
Krinkle closed T197271: PHPUnit fails on PHP 7.1 and HHVM 3.18 (1 failure: McrRevisionStoreDbTest) as Resolved.

Confirmed. Thanks :)

Fri, Jun 15, 12:20 PM · Patch-For-Review, Wikimedia-log-errors (Shared Build Failure), MW-1.32-release, PHP 7.1 support, Multi-Content-Revisions, MediaWiki-Core-Tests
Krinkle added a comment to T196185: Drop $wgDBmysql5 from MediaWiki.

I have this option set in my LocalSettings.php. How do I migrate away from it before the setting is removed?

Fri, Jun 15, 1:34 AM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, MW-1.32-release, Performance-Team (Radar), MediaWiki-Installer, Technical-Debt, MediaWiki-Database
Krinkle added a comment to T91289: Cannot disable "Notify" for token award in phabricator.
Fri, Jun 15, 1:24 AM · Developer-Wishlist (2017), Upstream, Phabricator (Upstream)
Krinkle added a comment to T193792: Do not show a broken thumbnail for small video thumbnails.

For instance if we request a 320px thumbnail of a video that's actually 200px by 200px the video URI is returned.

Fri, Jun 15, 1:11 AM · Readers-Web-Kanbanana-Board, Reading-Infrastructure-Team-Backlog, Readers-Web-Backlog, Patch-For-Review, Page-Previews
Krinkle added a comment to T196773: Add sniff to disallow use of "[optional]" in places that break Phan (e.g. among @param type hints).

I believe we either need to write a PHPCS sniff that is able to fully understand even edge-cases like the one above

Fri, Jun 15, 12:28 AM · MediaWiki-Codesniffer
Krinkle removed a project from T107289: Use "&" instead of "\u0026" for urls in JS redirect pages (for easier copy/paste): Easy.
Fri, Jun 15, 12:07 AM · JavaScript, MediaWiki-ContentHandler
Krinkle removed a project from T107289: Use "&" instead of "\u0026" for urls in JS redirect pages (for easier copy/paste): Patch-For-Review.
Fri, Jun 15, 12:07 AM · JavaScript, MediaWiki-ContentHandler
Krinkle edited Description on Wikimedia-log-errors (Shared Build Failure).
Fri, Jun 15, 12:02 AM
Krinkle removed a project from T195906: Phan fails for Wikibase on wmf.x branches: Wikimedia-log-errors (Shared Build Failure).
Fri, Jun 15, 12:00 AM · Wikidata

Thu, Jun 14

Krinkle removed a project from T182266: Composer\Downloader\TransportException in jobs with mediawiki or composer: Patch-For-Review.
Thu, Jun 14, 11:59 PM · Upstream, Wikimedia-log-errors (Shared Build Failure), RelEng-Archive-FY201718-Q2, Continuous-Integration-Config, Composer
Krinkle closed T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure as Resolved.
Thu, Jun 14, 11:58 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Shared Build Failure)