It looks like Aaron responded and addressed the CR feedback in Oct 2019. The patch is awaiting re-review.
Fri, Feb 21
Merging testwiki and group0 phase. Injecting a perf testing phase for a full host (mwdebug) where I can do basic perf testing regardless of wiki.
Declining in favour of T245835: Remove 'profileoutput' debug channel from MediaWiki.
@Esanders I understand the feature hasn't launched "for real" yet (it's behind an opt-in gesture), but as part this week's deployment to several Wikipedias the side-wide costs are now in affect, ahead of the perf review. E.g. server-side setup and client-side startup costs on page views, and any backend pressures from it or core that it exposes can become risk factors.
Recued subtasks from merged task T240470.
@ovasileva This was nearly done, I think. Would it be possible to finish this off while we still have it fresh in mind? It's nearly done and shouldn't take more than half an hour to look over and finalise – however it could easily cost half a day or more (for multiple people) next time.
Confirmed via XWD/logstash-beta:
Thu, Feb 20
mwdebug1002$ jq -r '.|keys|join("\n")' php/extensions/*/extension.json > ~/ext-json-keys mwdebug1002$ sort ext-json-keys | uniq -c | sort -nr | head -n50 186 url 186 name 186 manifest_version 186 MessagesDirs 185 descriptionmsg 184 author 183 license-name 176 type 169 Hooks 161 requires 147 config 141 AutoloadClasses 117 version 117 ResourceModules 111 ResourceFileModulePaths 97 ExtensionMessagesFiles 76 SpecialPages 53 AutoloadNamespaces 50 APIModules 37 AvailableRights 32 GroupPermissions 27 DefaultUserOptions 27 ConfigRegistry 25 callback 25 JobClasses 24 load_composer_autoloader 23 attributes 22 TestAutoloadClasses 22 LogActionsHandlers 22 APIListModules 20 LogTypes 19 ServiceWiringFiles 15 namespaces 15 TrackingCategories 15 GrantPermissions 14 TestAutoloadNamespaces 14 ExtensionFunctions 14 APIMetaModules 13 namemsg 13 ContentHandlers 13 APIPropModules 12 VisualEditorPluginModules 12 QUnitTestModule 9 EventLoggingSchemas 9 AuthManagerAutoConfig 8 LogNames 8 LogHeaders 7 ActionFilteredLogs 6 RawHtmlMessages 5 RateLimits
This means that currently a small subset of the unit tests don't run during local development if your local wiki has wgResourceLoaderStorageEnabled turned off.
Thx, Ive updated the documentation page. I'll close this now then.
Continuing at T187154 with any additional attributes for lazy loading.
Wed, Feb 19
I don't have an immediate answer on the perf impact of doing this client-side. At glance, it does seem worrying that one would have to fully load the mobile site in the KaiOS browser on and then be taken away to the app where it then boots and loads the same page again. That could be a non-start in terms of performance, especially considering how resource-constrained KaiOS devices generally are. That's irrespective of the impact on other users of the mobile site.
Tim mentioned in today's meeting we can use this Phab template as inspiration:
@Jhernandez If you've determined that there is no chance for data leak or data corruption as result of this silent error, and determined there is no user-visible impact or that it doesn't matter right now from a product perspective, then I would recommend patching the code to simply tolerate this error as-is.