Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (WMF Performance Team)Administrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (468 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photo by Niek Hidding.)

Recent Activity

Today

Krinkle created T347538: Editor crashes when removing selected words to join two paragraphs.
Thu, Sep 28, 3:08 AM · Regression, VisualEditor, Editing-team

Yesterday

Krinkle awarded T253380: Make taint-check understand all QueryBuilders a Orange Medal token.
Wed, Sep 27, 5:23 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), phan-taint-check-plugin
Krinkle updated the task description for T25625: use B and I as icons for Bold and Italic in the Hebrew Wikipedia in the enhanced toolbar in Vector.
Wed, Sep 27, 2:05 AM · WikiEditor, MediaWiki-extensions-UsabilityInitiative
Krinkle updated the task description for T53314: VisualEditor: Create toolbar icons for bold/italic/underline/superscript/subscript/etc. for scripts/languages as appropriate.
Wed, Sep 27, 2:04 AM · Goal, VisualEditor, I18n, VisualEditor-EditingTools
Krinkle updated the task description for T25625: use B and I as icons for Bold and Italic in the Hebrew Wikipedia in the enhanced toolbar in Vector.
Wed, Sep 27, 1:25 AM · WikiEditor, MediaWiki-extensions-UsabilityInitiative

Tue, Sep 26

Krinkle created T347439: wikimediafoundation.org has "an issue while displaying this preview".
Tue, Sep 26, 10:36 PM · wikimediafoundation.org
Krinkle awarded T201038: Link to RSS feeds missing on main page a Orange Medal token.
Tue, Sep 26, 10:34 PM · wikimediafoundation.org
Bawolff awarded T347347: Make "Quick" MW install a thing a Love token.
Tue, Sep 26, 8:53 AM · MediaWiki-Platform-Team, MediaWiki-Documentation
Krinkle added a comment to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .

@matej_suchanek Profiling action=history shows a similar cost from ChangeTags::tagDescription that's still there via ChangeTags::formatSummaryRow and HistoryPager.

Tue, Sep 26, 4:16 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle created T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.
Tue, Sep 26, 12:04 AM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team

Mon, Sep 25

Krinkle updated subscribers of T347347: Make "Quick" MW install a thing.
Mon, Sep 25, 7:55 PM · MediaWiki-Platform-Team, MediaWiki-Documentation
Krinkle created T347347: Make "Quick" MW install a thing.
Mon, Sep 25, 7:55 PM · MediaWiki-Platform-Team, MediaWiki-Documentation
Krinkle added a comment to T47514: ResourceLoader: Implement support for Source Maps.

Do you plan on supporting package files modules when in resource loader debug mode?

Mon, Sep 25, 6:57 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Patch-For-Review, MediaWiki-Platform-Team, Front-end-Standards-Group, MediaWiki-ResourceLoader
Krinkle moved T344386: Decide how to implement code splitting in Codex, and how to integrate it in ResourceLoader from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Mon, Sep 25, 3:32 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Design-Systems-Team, Codex
Krinkle reassigned T347116: Address MediaWiki\Auth\AuthManager::autoCreateUser Logstash PHP error from Tgr to KSarabia-WMF.
channel=authentication
level=INFO

MediaWiki\Auth\AuthManager::autoCreateUser: creating new user ({username}) - from: {from}
Mon, Sep 25, 2:23 PM · MediaWiki-Platform-Team (Radar), Web-Team-Backlog
Krinkle edited Description on Wikimedia-production-error.
Mon, Sep 25, 2:18 PM
Krinkle closed T346832: Limited width doesn't persist for IP masked users as Resolved.

Change 959364 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] OutputPage: Client preferences should work for IP masked users

https://gerrit.wikimedia.org/r/959364

Mon, Sep 25, 2:02 PM · Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Platform-Team, IP Masking
Krinkle updated the task description for T347116: Address MediaWiki\Auth\AuthManager::autoCreateUser Logstash PHP error.
Mon, Sep 25, 1:34 PM · MediaWiki-Platform-Team (Radar), Web-Team-Backlog
Krinkle renamed T346669: PHP Notice: Trying to access array offset on value of type bool (in MobileContext.php) from PHP Notice: Trying to access array offset on value of type bool to PHP Notice: Trying to access array offset on value of type bool (in MobileContext.php).
Mon, Sep 25, 1:28 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Web-Team-Backlog, MobileFrontend, Wikimedia-production-error
Krinkle moved T347223: Exception: Key contains invalid characters: centralauth:central-login-complete-token:1�À§À¢%2527%2522 from Untriaged to Sep 2023 on the Wikimedia-production-error board.
Mon, Sep 25, 1:17 PM · Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Krinkle renamed MediaWiki-Engineering-Group-onboarding from MediaWiki-Services-Group-onboarding to MediaWiki-Engineering-Group-onboarding.
Mon, Sep 25, 1:16 PM
Krinkle moved T346980: Avoid primary connection for read-only check during read requests from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Mon, Sep 25, 1:14 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-libs-Rdbms
Krinkle moved T347112: Evaluate zstd for php-memcached at WMF from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Mon, Sep 25, 1:14 PM · MediaWiki-Platform-Team (Radar), MediaWiki-libs-ObjectCache, Wikimedia-Performance-recommendation
Krinkle moved T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later from Inbox, needs triage to Sprint +2 on the MediaWiki-Platform-Team board.
Mon, Sep 25, 1:14 PM · MediaWiki-Platform-Team, Patch-For-Review, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Design-Systems-Team, Performance-Team, MediaWiki-ResourceLoader
Krinkle claimed T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later.
Mon, Sep 25, 1:14 PM · MediaWiki-Platform-Team, Patch-For-Review, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Design-Systems-Team, Performance-Team, MediaWiki-ResourceLoader
Krinkle committed rMLIPa689a6605a97: Import IPSet class into IPUtils library (authored by Krinkle).
Import IPSet class into IPUtils library
Mon, Sep 25, 8:46 AM

Sun, Sep 24

Krinkle committed rMLIP5f6d1c7fde21: IPSet: Remove AtEase overhead from hot code path (authored by Krinkle).
IPSet: Remove AtEase overhead from hot code path
Sun, Sep 24, 3:31 AM
Krinkle committed rMLIPf5e37fa6b34b: tests: Complete code coverage to 100 (authored by Krinkle).
tests: Complete code coverage to 100
Sun, Sep 24, 3:30 AM
Krinkle committed rMLIP1eaad3a4e120: tests: Set name for data provider data sets (authored by Krinkle).
tests: Set name for data provider data sets
Sun, Sep 24, 3:30 AM
Krinkle added a comment to T342201: MediaWiki\Extension\Notifications\Api\ApiEchoUnreadNotificationPages::getUnreadNotificationPagesFromForeign: Unexpected API response from {wiki}.

Why is Echo making internal HTTP requests in the first place? For the badge, it afaik reads the global database directly.

Sun, Sep 24, 12:54 AM · MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), Growth-Team (Current Sprint), MediaWiki-extensions-CentralAuth, MW-on-K8s, Notifications, Wikimedia-production-error
Krinkle added a comment to T342201: MediaWiki\Extension\Notifications\Api\ApiEchoUnreadNotificationPages::getUnreadNotificationPagesFromForeign: Unexpected API response from {wiki}.

[…] A race condition between writing the CentralAuth token to the memcached cluster of the other DC and making the followup request? Shouldn't memcached be much faster?

Sun, Sep 24, 12:49 AM · MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), Growth-Team (Current Sprint), MediaWiki-extensions-CentralAuth, MW-on-K8s, Notifications, Wikimedia-production-error
Krinkle changed the status of T346853: Unable to copy inline template from table cell to list item (produces ☢ symbol) from Declined to Invalid.
Sun, Sep 24, 12:26 AM · Editing-team, VisualEditor, VisualEditor-CopyPaste
Krinkle closed T346853: Unable to copy inline template from table cell to list item (produces ☢ symbol) as Declined.

I can't reproduce this. I have tried in Chrome and in Firefox 117.0.1 (both on mac).

Sun, Sep 24, 12:26 AM · Editing-team, VisualEditor, VisualEditor-CopyPaste
Krinkle added a project to T347235: Copy template onto self throws "Cannot add a child to mwTransclusionBlock": VisualEditor.
Sun, Sep 24, 12:24 AM · VisualEditor, Editing-team, VisualEditor-CopyPaste
Krinkle created T347235: Copy template onto self throws "Cannot add a child to mwTransclusionBlock".
Sun, Sep 24, 12:24 AM · VisualEditor, Editing-team, VisualEditor-CopyPaste

Sat, Sep 23

Krinkle added a project to T297300: PageProps doesn't cache result when it is false: Wikimedia-Performance-recommendation.
Sat, Sep 23, 11:47 PM · Wikimedia-Performance-recommendation, Performance Issue, MediaWiki-General
Krinkle committed rMLIP6100e76a7e1b: [BREAKING CHANGE] Require PHP 7.4 or later (authored by Krinkle).
[BREAKING CHANGE] Require PHP 7.4 or later
Sat, Sep 23, 8:54 PM
Krinkle closed T323187: Disallow cloning of RequestContext objects as Resolved.
Sat, Sep 23, 4:44 AM · MediaWiki-Platform-Team, good first task, Developer Productivity, MediaWiki-General
Krinkle created T347221: Grafana alerts unreliable since 29 August 2023 due to DatasourceError.
Sat, Sep 23, 2:05 AM · Observability-Alerting, MediaWiki-Platform-Team (Radar)

Fri, Sep 22

Krinkle added a comment to T63007: Allow specifying when a gadget should load (conditional category, action, or namespace).

[…] you could narrow your gadget to actions=edit,specials. […]

[…] but |namespace=-1 also would fit how special pages are dealt with (if that isn't already supported).[…]

Fri, Sep 22, 11:00 PM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets
Krinkle edited projects for T318306: Evaluate igbinary for php-memcached at WMF, added: MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team, Performance-Team.
Fri, Sep 22, 10:21 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-libs-ObjectCache
Krinkle closed T346365: PHP Notice: Undefined index: DEFAULT as Resolved.
Fri, Sep 22, 10:19 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, DBA, MediaWiki-libs-Rdbms, Wikimedia-production-error
Krinkle edited projects for T226644: WikiPage::isRedirect and WikiPage::getRedirectTarget() seemingly disagree, added: MediaWiki-Redirects, MediaWiki-Platform-Team; removed Platform Engineering (Icebox).
Fri, Sep 22, 8:45 PM · MediaWiki-Platform-Team, MediaWiki-Redirects, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Core-Revision-backend
Krinkle added a comment to T63007: Allow specifying when a gadget should load (conditional category, action, or namespace).

In T204201#9127376 I describe a use case that needs OR semantics for conditions; specifically to load a charinsert-ish Gadget on all pages with contentmodel wikitext and on Special:Upload […] I think it's important to keep in mind for those with their fingers (and minds) deep in this area.

Fri, Sep 22, 8:26 PM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets
Krinkle added a comment to T344733: Migrate metrics-platform repo to GitLab.

I've reconfigured the wikimedia/metrics-platform package back from GitLab to github.com because it seems one of GitLab and Composer doesn'tt support the other to produce a dist package, and thus rebuilding mediawiki-bendor became a mess even for older versions.

Fri, Sep 22, 7:45 PM · Patch-For-Review, Data Products (Sprint 01), GitLab (Pipeline Services Migration🐤), Metrics Platform Backlog
Lucas_Werkmeister_WMDE awarded T347123: Reduce database queries on parsercached logged-out page views (Sep 2023) a Mountain of Wealth token.
Fri, Sep 22, 11:19 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Krinkle committed rMLIPb79fd7bd8b74: Release 4.0.1 (authored by Krinkle).
Release 4.0.1
Fri, Sep 22, 9:59 AM
Krinkle committed rMLIP9e5c93a6c631: build: Add support for IPSet 4.x (authored by Krinkle).
build: Add support for IPSet 4.x
Fri, Sep 22, 9:59 AM
jcrespo awarded T347123: Reduce database queries on parsercached logged-out page views (Sep 2023) a Yellow Medal token.
Fri, Sep 22, 9:42 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Ladsgroup awarded T347123: Reduce database queries on parsercached logged-out page views (Sep 2023) a Yellow Medal token.
Fri, Sep 22, 7:42 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Mainframe98 awarded T347123: Reduce database queries on parsercached logged-out page views (Sep 2023) a Mountain of Wealth token.
Fri, Sep 22, 6:24 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Krinkle renamed T347123: Reduce database queries on parsercached logged-out page views (Sep 2023) from Reduce database queries on cached logged-out page views (Sep 2023) to Reduce database queries on parsercached logged-out page views (Sep 2023).
Fri, Sep 22, 3:13 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Krinkle renamed T322528: Reduce db queries from parsercached logged-in pageview (Nov 2022) from Audit and reduce db queries from parsercached page views (Nov 2022) to Reduce db queries from parsercached logged-in pageview (Nov 2022).
Fri, Sep 22, 3:11 AM · Wikimedia-Performance-recommendation, MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), DBA
Krinkle added a comment to T322528: Reduce db queries from parsercached logged-in pageview (Nov 2022).

I see 58 queries:

Fri, Sep 22, 3:11 AM · Wikimedia-Performance-recommendation, MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), DBA
Krinkle added a parent task for T347123: Reduce database queries on parsercached logged-out page views (Sep 2023): Unknown Object (Task).
Fri, Sep 22, 3:06 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation
Krinkle renamed T322528: Reduce db queries from parsercached logged-in pageview (Nov 2022) from Audit and reduce db queries from parsercached page views (late 2022) to Audit and reduce db queries from parsercached page views (Nov 2022).
Fri, Sep 22, 3:05 AM · Wikimedia-Performance-recommendation, MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), DBA
Krinkle created T347123: Reduce database queries on parsercached logged-out page views (Sep 2023).
Fri, Sep 22, 3:05 AM · MediaWiki-Platform-Team (Radar), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), VisualEditor, MediaWiki-extensions-Disambiguator, DiscussionTools, TemplateData, RelatedArticles, Wikimedia-Performance-recommendation

Thu, Sep 21

Sophivorus awarded T325480: defer javascript instead of async for better performance a Barnstar token.
Thu, Sep 21, 10:20 PM · MediaWiki-Platform-Team, Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle created T347114: NetworkProbeLimit cookie for Probenet overwritten on every link hover event.
Thu, Sep 21, 9:31 PM · MediaWiki-extensions-WikimediaEvents, Infrastructure-Foundations, Wikimedia-Performance-recommendation
Krinkle closed T295619: Cookie value sent in HTTP requests changes too frequently, a subtask of T302623: FY2022-2023: Improve Backend Pageview Timing, as Resolved.
Thu, Sep 21, 9:17 PM · Wikimedia-Performance-recommendation, MediaWiki-Platform-Team, Patch-For-Review
Krinkle closed T295619: Cookie value sent in HTTP requests changes too frequently as Resolved.
Thu, Sep 21, 9:17 PM · Wikimedia-Performance-recommendation, Metrics Platform Backlog, MediaWiki-Platform-Team (Radar), Product-Analytics, MediaWiki-extensions-WikimediaEvents
Krinkle added a subtask for T302623: FY2022-2023: Improve Backend Pageview Timing: T347112: Evaluate zstd for php-memcached at WMF.
Thu, Sep 21, 9:10 PM · Wikimedia-Performance-recommendation, MediaWiki-Platform-Team, Patch-For-Review
Krinkle added a parent task for T347112: Evaluate zstd for php-memcached at WMF: T302623: FY2022-2023: Improve Backend Pageview Timing.
Thu, Sep 21, 9:10 PM · MediaWiki-Platform-Team (Radar), MediaWiki-libs-ObjectCache, Wikimedia-Performance-recommendation
Krinkle created T347112: Evaluate zstd for php-memcached at WMF.
Thu, Sep 21, 9:10 PM · MediaWiki-Platform-Team (Radar), MediaWiki-libs-ObjectCache, Wikimedia-Performance-recommendation
Krinkle added a project to T318306: Evaluate igbinary for php-memcached at WMF: Wikimedia-Performance-recommendation.
Thu, Sep 21, 8:52 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-libs-ObjectCache
Krinkle claimed T346365: PHP Notice: Undefined index: DEFAULT.
Thu, Sep 21, 7:23 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, DBA, MediaWiki-libs-Rdbms, Wikimedia-production-error
Krinkle moved T346365: PHP Notice: Undefined index: DEFAULT from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Thu, Sep 21, 7:23 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, DBA, MediaWiki-libs-Rdbms, Wikimedia-production-error
Krinkle updated subscribers of T346365: PHP Notice: Undefined index: DEFAULT.

But! The constructor does mutate groupLoadsBySection. It adds a subkey under section for "generic" with the equivalent sectionLoads data. And that implicitly also does something else. It implicitly creates the $section if it didn't exist yet.
[…]
In reconfigure, we first read a specific cluster key (thus assuming it exists) and then add sectionLoads to it.

Thu, Sep 21, 7:16 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, DBA, MediaWiki-libs-Rdbms, Wikimedia-production-error
Krinkle added a comment to T346365: PHP Notice: Undefined index: DEFAULT.

Looking at this more closely...

Thu, Sep 21, 6:51 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, DBA, MediaWiki-libs-Rdbms, Wikimedia-production-error
Krinkle added a comment to T151002: Expose tool-labs service names via environment variables.

We have a static floating name redis.svc.tools.eqiad1.wikimedia.cloud for the shared redis, I think that should address the concerns here […]

Resolving it but feel free to reopen if that does not address the issue.

Thu, Sep 21, 5:43 PM · Toolforge (Toolforge iteration 00)
Krinkle removed projects from T63007: Allow specifying when a gadget should load (conditional category, action, or namespace): Patch-For-Review, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).
Thu, Sep 21, 4:07 PM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets
Krinkle added a project to T346690: mcrouter daemonset on mw-on-k8s: MediaWiki-Platform-Team.

Make the $wgObjectCaches['mcrouter']['servers'] an environmental variable we can define in values.yaml.

Thu, Sep 21, 1:57 PM · MediaWiki-Platform-Team (Radar), serviceops, MW-on-K8s
Restricted Application added a project to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later: MediaWiki-Platform-Team.

@Legoktm pointed out that page properties are an artifact of parsing and should only be modified within the parse, so instead of validating post-save we'd have to validate synchronously during the save – which I suppose is just about fine. The other option would be to do it post-save but store the result in some cache or a new db table.

Thu, Sep 21, 1:57 AM · MediaWiki-Platform-Team, Patch-For-Review, MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Design-Systems-Team, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T346178: Remove hardcoded message paths in banana-checker configuration.

Are there more than 10 repos in all of Wikimedia Gerrit that don't simply use i18n/ as the directory for all localisation files? I don't have the data, but it seems likely to me that it would be true. Adding complexity to all 1000+ extensions for that edge case is worth weighing the pros and cons over.

Thu, Sep 21, 1:02 AM · Continuous-Integration-Config, good first task

Wed, Sep 20

Krinkle removed projects from T214734: Post-send work sometimes fatals at "Error: The UdpSocket to 127.0.0.1:10514 has been closed" (esp. mwdebug hosts): MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), MediaWiki-General, Developer Productivity.
Wed, Sep 20, 11:17 PM · Wikimedia-production-error, MediaWiki-Debug-Logger, Release-Engineering-Team (Radar)
Krinkle added a comment to T214734: Post-send work sometimes fatals at "Error: The UdpSocket to 127.0.0.1:10514 has been closed" (esp. mwdebug hosts).

There's a possible related issue in T288624: PHP Warning: curl_multi_remove_handle(): supplied resource is not a valid cURL Multi Handle resource, which @tstarling investigated at Gerrit change 957894, and made an upstream PR:

Wed, Sep 20, 11:17 PM · Wikimedia-production-error, MediaWiki-Debug-Logger, Release-Engineering-Team (Radar)
Krinkle edited projects for T344638: Abilty to load compacted versions of javascript and css pages, added: MediaWiki-General, MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team, MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets.

Untagging MediaWiki-extensions-Gadgets, since Gadgets already leverage ResourceLoader and its caching/compression features. This task is about user scripts which are in MediaWiki core.

Wed, Sep 20, 10:57 PM · MediaWiki-Platform-Team (Radar), MediaWiki-General
Krinkle reassigned T324910: Slot-aware action 'raw' from Krinkle to Simontaurus.
Wed, Sep 20, 10:43 PM · MW-1.39-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Patch-For-Review, Multi-Content-Revisions, MediaWiki-Interface (actions)
Krinkle closed T324910: Slot-aware action 'raw' as Resolved.
Wed, Sep 20, 10:43 PM · MW-1.39-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Patch-For-Review, Multi-Content-Revisions, MediaWiki-Interface (actions)
Krinkle closed T324910: Slot-aware action 'raw', a subtask of T174022: Implement multi-content revisions, as Resolved.
Wed, Sep 20, 10:43 PM · Platform Team Workboards (Epics), Structured-Data-Backlog, Platform Team Initiatives (MCR), Multi-Content-Revisions (New Features), Structured Data Engineering, SDC General, Epic, Wikidata
Krinkle moved T345190: Update RL alerts from performance-team-alerts@ to mediawiki-platform-team@ from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Wed, Sep 20, 9:55 PM · Patch-For-Review, MediaWiki-Engineering-Group-onboarding, MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle updated the task description for T346984: Chaining abortable API promises is very unpleasant – introduce abort signals to mw.Api.
Wed, Sep 20, 9:55 PM · Patch-For-Review, MediaWiki-General
Krinkle moved T346971: Uncaught ConfigException: Failed to load configuration from etcd from Untriaged to Sep 2023 on the Wikimedia-production-error board.
Wed, Sep 20, 9:05 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), MediaWiki-Platform-Team (Radar), MW-on-K8s, serviceops, MediaWiki-Configuration, User-brennen, Wikimedia-production-error
Krinkle added a project to T346971: Uncaught ConfigException: Failed to load configuration from etcd: MediaWiki-Platform-Team (Radar).

Untagging MediaWiki-Platform-Team since MediaWiki-Configuration does not have an owner today (mw:Maintainers).

Wed, Sep 20, 9:02 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), MediaWiki-Platform-Team (Radar), MW-on-K8s, serviceops, MediaWiki-Configuration, User-brennen, Wikimedia-production-error
Krinkle edited projects for T346971: Uncaught ConfigException: Failed to load configuration from etcd, added: serviceops, MW-on-K8s; removed MediaWiki-Platform-Team.
Wed, Sep 20, 8:56 PM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), MediaWiki-Platform-Team (Radar), MW-on-K8s, serviceops, MediaWiki-Configuration, User-brennen, Wikimedia-production-error
Krinkle added a subtask for T302623: FY2022-2023: Improve Backend Pageview Timing: T346980: Avoid primary connection for read-only check during read requests.
Wed, Sep 20, 8:48 PM · Wikimedia-Performance-recommendation, MediaWiki-Platform-Team, Patch-For-Review
Krinkle added a parent task for T346980: Avoid primary connection for read-only check during read requests: T302623: FY2022-2023: Improve Backend Pageview Timing.
Wed, Sep 20, 8:48 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-libs-Rdbms
Krinkle created T346980: Avoid primary connection for read-only check during read requests.
Wed, Sep 20, 8:48 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, MediaWiki-libs-Rdbms
Krinkle updated the task description for T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.).
Wed, Sep 20, 5:03 PM · Patch-For-Review, Platform Engineering (Icebox), MediaWiki-libs-Rdbms
Krinkle awarded T342347: Allow users to always enable safemode a Orange Medal token.
Wed, Sep 20, 3:38 PM · User-notice, MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), affects-Miraheze, MediaWiki-Core-Preferences
Krinkle created T346859: Finish transition from 'xenon' directory and user to 'arclamp'.
Wed, Sep 20, 3:16 AM · Arc-Lamp
Krinkle closed T93049: Same MassMessage is being sent more than once as Resolved.
Wed, Sep 20, 2:56 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Mail, Infrastructure-Foundations, Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, MassMessage
Krinkle closed T93049: Same MassMessage is being sent more than once, a subtask of T90820: Run MassMessage to contact user talk pages of all affected accounts, as Resolved.
Wed, Sep 20, 2:56 AM · MediaWiki-Core-Team, SUL-Finalization
Krinkle added a comment to T267067: Make language variant a parser option.

See also:

Wed, Sep 20, 1:56 AM · MediaWiki-Language-converter, Parsoid, MediaWiki-General, MediaWiki-Parser
Krinkle updated the task description for T346853: Unable to copy inline template from table cell to list item (produces ☢ symbol).
Wed, Sep 20, 12:34 AM · Editing-team, VisualEditor, VisualEditor-CopyPaste
Krinkle created T346853: Unable to copy inline template from table cell to list item (produces ☢ symbol).
Wed, Sep 20, 12:33 AM · Editing-team, VisualEditor, VisualEditor-CopyPaste

Tue, Sep 19

Krinkle added a comment to T346811: Stop adding Platform Engineering to new wiki creation tasks.
def _create_ticket(self):
    result = client.createParentTask(
        self.post_ticket_text,
        [
            'PHID-PROJ-2fuv7mxzjnpjfuojdnfd', # wiki-setup
            'PHID-PROJ-2b7oz62ylk3jk4aus262', # platform-engineering
            'PHID-PROJ-flkea3bsbxquupwv5g2s', # countervandalism-network
        ],
Tue, Sep 19, 7:33 PM · MediaWiki-Platform-Team, Platform Engineering, Phabricator maintenance bot
Krinkle closed T274041: Reduce performance impact of HookRunner.php loading 500+ interfaces as Resolved.
Tue, Sep 19, 1:50 AM · Performance-Team-publish, Wikimedia-Performance-recommendation, Performance-Team, Platform Engineering Code Jam-2021, Platform Engineering Roadmap Decision Making, Patch-For-Review, MediaWiki-Core-Hooks
Krinkle moved T274041: Reduce performance impact of HookRunner.php loading 500+ interfaces from Untriaged to Ready for write-up on the Performance-Team-publish board.
Tue, Sep 19, 1:50 AM · Performance-Team-publish, Wikimedia-Performance-recommendation, Performance-Team, Platform Engineering Code Jam-2021, Platform Engineering Roadmap Decision Making, Patch-For-Review, MediaWiki-Core-Hooks
Krinkle added a subtask for T302623: FY2022-2023: Improve Backend Pageview Timing: T274041: Reduce performance impact of HookRunner.php loading 500+ interfaces.
Tue, Sep 19, 1:50 AM · Wikimedia-Performance-recommendation, MediaWiki-Platform-Team, Patch-For-Review