Krinkle (Timo Tijhof)
Wikimedia Foundation

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (145 w, 6 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Today

Krinkle added a comment to T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown.

@Krinkle definitely. Will probably want to limit it to the master branch for a while.

Would it be all about asserting the log files are empty and if not fail the build? If so that sounds easy to implement.

Mon, Jul 24, 8:14 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure
Krinkle added a comment to T171371: Investigate 30x increase in Jobrunner errors.

It was deployed by @demon:

2017-06-27T23:05 <demon@tin> Synchronized dblists/: ukwikimedia swapped from closed to deleted (duration: 00m 46s)
Mon, Jul 24, 8:13 PM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle closed T162973: Add support for behavior: url(#default#behaviorName) as Resolved.

@TheDJ Thanks!

Mon, Jul 24, 7:37 PM · MW-1.30-release-notes, MediaWiki-ResourceLoader
Krinkle closed T162973: Add support for behavior: url(#default#behaviorName), a subtask of T147347: Migrate Kartographer to Leaflet 1.x, as Resolved.
Mon, Jul 24, 7:37 PM · Discovery, Maps (Kartographer)

Sat, Jul 22

Krinkle awarded T150079: Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer a Orange Medal token.
Sat, Jul 22, 11:46 PM · Patch-For-Review, Design, MediaWiki-Special-pages, Easy, MediaWiki-HTMLForm
Krinkle updated the task description for T150079: Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer.
Sat, Jul 22, 11:45 PM · Patch-For-Review, Design, MediaWiki-Special-pages, Easy, MediaWiki-HTMLForm
Krinkle merged T128336: UI: Special:BotPasswords: Too much space between labels and checkboxes into T150079: Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer.
Sat, Jul 22, 11:44 PM · Patch-For-Review, Design, MediaWiki-Special-pages, Easy, MediaWiki-HTMLForm
Krinkle merged task T128336: UI: Special:BotPasswords: Too much space between labels and checkboxes into T150079: Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer.
Sat, Jul 22, 11:44 PM · MediaWiki-User-login-and-signup
Krinkle added a comment to T128336: UI: Special:BotPasswords: Too much space between labels and checkboxes.

See also:

Sat, Jul 22, 11:44 PM · MediaWiki-User-login-and-signup
Krinkle updated subscribers of T161278: Add default gadget styling to Parsoid's output.
Sat, Jul 22, 10:34 PM · Parsoid
Krinkle added a comment to T161278: Add default gadget styling to Parsoid's output.

However, it seems gadgets are still not included. Not sure why..

Sat, Jul 22, 10:33 PM · Parsoid
Krinkle added a comment to T161278: Add default gadget styling to Parsoid's output.

The Parse API by design only exposes modules added through Parser/ParserOutput. Modules added by OutputPage, Skin, or extensions are not exposed.

Sat, Jul 22, 10:17 PM · Parsoid
Krinkle triaged T171307: "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null) as Normal priority.
Sat, Jul 22, 10:10 PM · MediaWiki-ResourceLoader
Krinkle renamed T171307: "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null) from Mismatching defaults for RL target in OutputPage and ResourceLoaderStartUpModule to "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null).
Sat, Jul 22, 10:10 PM · MediaWiki-ResourceLoader
Krinkle added a comment to T171307: "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null).

Ok, if this is by design that's fine (although some documentation about this would be nice… is this documented somewhere?). I would expect OutputPage to scream at me, and not client side RL, though.

Sat, Jul 22, 10:08 PM · MediaWiki-ResourceLoader
Krinkle removed projects from T114777: Add Flow contributions to GUC: Flow, Collaboration-Team-Triage.

Reducing it further. This task is to track the end result in GUC. The Flow-side of things is T114777: Add Flow contributions to GUC.

Sat, Jul 22, 9:59 PM · Tool-Global-user-contributions
Krinkle renamed T171371: Investigate 30x increase in Jobrunner errors from Investigate 100x increase in Jobrunner errors to Investigate 30x increase in Jobrunner errors.
Sat, Jul 22, 4:30 AM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle renamed T171371: Investigate 30x increase in Jobrunner errors from Investigate Jobrunner error increase to Investigate 100x increase in Jobrunner errors.
Sat, Jul 22, 4:15 AM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle updated subscribers of T171371: Investigate 30x increase in Jobrunner errors.

Checking the local logs on one of the servers (mw1303), the error is quite easily found. The last two log files are 1000x bigger (19G instead of 8M).

Sat, Jul 22, 4:11 AM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle updated the task description for T171371: Investigate 30x increase in Jobrunner errors.
Sat, Jul 22, 4:03 AM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle created T171371: Investigate 30x increase in Jobrunner errors.
Sat, Jul 22, 4:02 AM · Performance-Team, Operations, MediaWiki-JobRunner
Krinkle moved T160315: Investigate the big difference in mwLoadStart from Backlog to Next-up on the Performance-Team board.
Sat, Jul 22, 2:52 AM · Performance-Team, WebPageTest
Krinkle added a comment to T160315: Investigate the big difference in mwLoadStart .

Looking at it again:

Sat, Jul 22, 2:51 AM · Performance-Team, WebPageTest
Krinkle removed a project from T170825: Performance review of LoginNotify: Patch-For-Review.
Sat, Jul 22, 2:35 AM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Community-Tech, Performance-Team, MediaWiki-extensions-LoginNotify
Krinkle closed T63694: Reduce Flow page time to first byte as Resolved.

Browsing to https://www.mediawiki.org/wiki/Project:Support_desk when logged-in seems no longer than loading any other page logged-in. Marking this as resolved.

Sat, Jul 22, 2:34 AM · Performance-Team, Collaboration-Team-Triage, Flow
Krinkle updated the task description for T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope".
Sat, Jul 22, 2:32 AM · Patch-For-Review, MediaWiki-extensions-WikibaseClient, Wikimedia-log-errors, Wikidata
Krinkle added a parent task for T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope": T168050: MW 1.30.0-wmf.10 deployment blockers.
Sat, Jul 22, 2:31 AM · Patch-For-Review, MediaWiki-extensions-WikibaseClient, Wikimedia-log-errors, Wikidata
Krinkle added a subtask for T168050: MW 1.30.0-wmf.10 deployment blockers: T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope".
Sat, Jul 22, 2:31 AM · Release-Engineering-Team (Kanban), Train Deployments, Release
Krinkle created T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope".
Sat, Jul 22, 2:30 AM · Patch-For-Review, MediaWiki-extensions-WikibaseClient, Wikimedia-log-errors, Wikidata
Krinkle added a comment to T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis.

Change 364094 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wait for replication after adding RC entries in WikiPageUpdater

https://gerrit.wikimedia.org/r/364094

Sat, Jul 22, 2:28 AM · Patch-For-Review, Wikidata-Sprint, MediaWiki-extensions-WikibaseClient, User-Ladsgroup, User-Daniel, Wikidata, Traffic, DBA, Performance-Team, Operations
Krinkle committed rEXFAd4e64cc836c0: Avoid deprecated ResourceLoaderGetLessVars hook (authored by Krinkle).
Avoid deprecated ResourceLoaderGetLessVars hook
Sat, Jul 22, 2:19 AM
Krinkle committed rEXFA248f49e4f632: Avoid deprecated ResourceLoaderGetLessVars hook (authored by Krinkle).
Avoid deprecated ResourceLoaderGetLessVars hook
Sat, Jul 22, 2:19 AM
Krinkle closed T104225: enwiki Main_Page timeouts as Resolved.

Closing. Contrary to my previous comment, at least from tailing Varnish for a while, and from looking at slowparse.log, we no longer have any timeouts. We do still have Main_Page parses that take between 3-10 seconds, but that's not causing a timeout.

Sat, Jul 22, 2:12 AM · Operations, Performance-Team, Traffic
Krinkle moved T67478: Graph User::pingLimiter() actions in Grafana from Inbox to Radar on the Performance-Team board.
Sat, Jul 22, 2:10 AM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle added a subtask for T127268: Dismantle ResourceLoader's "targets" system: T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).
Sat, Jul 22, 2:08 AM · Reading-Web-Backlog (Tracking), Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MediaWiki-ResourceLoader
Krinkle added a parent task for T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load): T127268: Dismantle ResourceLoader's "targets" system.
Sat, Jul 22, 2:08 AM · Gadgets, MediaWiki-ResourceLoader
Krinkle updated the task description for T127268: Dismantle ResourceLoader's "targets" system.
Sat, Jul 22, 2:08 AM · Reading-Web-Backlog (Tracking), Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MediaWiki-ResourceLoader
Krinkle renamed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) from Error: Unknown dependency in desktop, when using mobile only gadgets to Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).
Sat, Jul 22, 2:06 AM · Gadgets, MediaWiki-ResourceLoader
Krinkle triaged T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) as High priority.

@TheDJ Thanks. This is actually an issue in the Gadgets extension. I always enqueues the enabled gadgets, even if they are not intended for the current target.

Sat, Jul 22, 2:06 AM · Gadgets, MediaWiki-ResourceLoader
Krinkle updated the task description for T124742: Upgrade to jQuery 3.
Sat, Jul 22, 1:40 AM · Patch-For-Review, Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a commit to T124742: Upgrade to jQuery 3: rOMWC3dce3fccfdeb: Enable wgUsejQueryThree on the Beta Cluster.
Sat, Jul 22, 1:38 AM · Patch-For-Review, Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle created T171367: Avoid ResourceLoaderGetLessVars hook in MinervaNeue.
Sat, Jul 22, 1:21 AM · Reading-Web-Backlog, MinervaNeue
Krinkle created T171365: Avoid ResourceLoaderGetLessVars hook in MobileFrontend.
Sat, Jul 22, 12:45 AM · Reading-Web-Backlog, MobileFrontend
Krinkle reopened T169574: On diff pages, ?visualdiff=1 doesn't work if diff=prev rather than an revid as "Open".
Sat, Jul 22, 12:35 AM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor
Krinkle added a comment to T169574: On diff pages, ?visualdiff=1 doesn't work if diff=prev rather than an revid.

Change 365704 merged by jenkins-bot:
[mediawiki/core@master] Export revision IDs to JS config on diff pages

https://gerrit.wikimedia.org/r/365704

Sat, Jul 22, 12:35 AM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor

Fri, Jul 21

Krinkle updated the task description for T171073: Roundup of FLOSS libraries developed by the Foundation/movement.
Fri, Jul 21, 11:39 PM · Librarization, Wikimedia-Blog-Content
Krinkle changed the status of T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook from Stalled to Open.
Fri, Jul 21, 11:17 PM · Patch-For-Review, MediaWiki-Interface, MediaWiki-ResourceLoader, Technical-Debt
Krinkle moved T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook from Backlog to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Fri, Jul 21, 11:17 PM · Patch-For-Review, MediaWiki-Interface, MediaWiki-ResourceLoader, Technical-Debt
Krinkle awarded T126827: When viewing pages for non-Incubator pages on Incubator, the link to the page on the new wiki is broken a Orange Medal token.
Fri, Jul 21, 11:17 PM · MediaWiki-extensions-WikimediaIncubator
Krinkle edited projects for T67478: Graph User::pingLimiter() actions in Grafana, added: monitoring; removed Wikimedia-General-or-Unknown.
Fri, Jul 21, 10:55 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle renamed T67478: Graph User::pingLimiter() actions in Grafana from Graph User::pingLimiter() actions in Graphana to Graph User::pingLimiter() actions in Grafana.
Fri, Jul 21, 10:55 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle added a comment to T67478: Graph User::pingLimiter() actions in Grafana.

I filled this task in the hope someone could figure out the links to be added in Gdash. Nowadays that can be done via Grafana hence I reopened this task and rephrased the topic.

@Krinkle do you know whether we still send to statsd profiling of the MediaWiki function calls. statsd metric MediaWiki.User.pingLimiter used to be populated by wfProfileIn() or something similar. Apparently the metrics are no more emitted.

Fri, Jul 21, 10:55 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle updated the task description for T67478: Graph User::pingLimiter() actions in Grafana.
Fri, Jul 21, 10:45 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle moved T67478: Graph User::pingLimiter() actions in Grafana from To Triage to Follow-up/Actionables on the Wikimedia-Incident board.
Fri, Jul 21, 10:45 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle added a project to T67478: Graph User::pingLimiter() actions in Grafana: Wikimedia-Incident.
Fri, Jul 21, 10:45 PM · monitoring, Wikimedia-Incident, Performance-Team
Krinkle updated the task description for T113114: Make all wiki-facing error pages consistent.
Fri, Jul 21, 10:43 PM · Wikimedia-General-or-Unknown, Patch-For-Review, Voice & Tone, Design
Krinkle renamed T37053: upload.wikimedia.org should serve a Wikimedia 404 error page when file not found in Swift from upload.wikimedia.org needs a Wikimedia 404 error page to upload.wikimedia.org should serve a Wikimedia 404 error page when file not found in Swift.
Fri, Jul 21, 10:43 PM · Operations, media-storage
Krinkle added a comment to T37053: upload.wikimedia.org should serve a Wikimedia 404 error page when file not found in Swift.

Previously:

  • 404 Not Found for an original: Swift
  • 404 Not Found for a thumbnail: MediaWiki /w/thumb.php (proxied by Swift)
Fri, Jul 21, 10:42 PM · Operations, media-storage
Krinkle updated the task description for T113114: Make all wiki-facing error pages consistent.
Fri, Jul 21, 10:40 PM · Wikimedia-General-or-Unknown, Patch-For-Review, Voice & Tone, Design
Krinkle updated the task description for T113114: Make all wiki-facing error pages consistent.
Fri, Jul 21, 10:35 PM · Wikimedia-General-or-Unknown, Patch-For-Review, Voice & Tone, Design
Krinkle added a comment to T157750: mw-tools-codesniffer-mwcore-testrun test fails with php is not hhvm.

@hashar It seems the set-phpflavor macro is also still used (in addition the Zuul setting the environment). Is it now safe to also land https://gerrit.wikimedia.org/r/351701?

Fri, Jul 21, 1:55 AM · Release-Engineering-Team (Kanban), Patch-For-Review, MediaWiki-Codesniffer, Continuous-Integration-Config, Continuous-Integration-Infrastructure
Krinkle added a comment to T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure.

@Reedy I believe the sniff is meant to enforce @return if the author already decided to document the method at least to some degree. This is plausible with the example in this tasks' description, but the one in T171254 about wmfStaticRespond, that function has no documentation comment at all, and it still failed?

Fri, Jul 21, 1:50 AM · Patch-For-Review, MediaWiki-Codesniffer

Thu, Jul 20

Krinkle updated subscribers of T170053: Drop "position: absolute" on p-logo element.

The z-index removal may have caused div#column-content to cover #p-logo.

Thu, Jul 20, 9:46 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), MonoBook, Technical-Debt, Vector

Wed, Jul 19

Krinkle added a comment to T169826: Add project wordmark to print styles.

The ResourceLoaderSkinModule.php does exactly this, but it's not done in a very generic way. We'll either have to extend this or adjust the implementation in core.

A generic way to generate CSS depending on config options is to subclass ResourceLoaderFileModule and override the getLessVars() method. You can then write your styles as Less like you normally would, and use the extra magically generated variables in it. See ResourceLoaderEditToolbarModule for an example.

Wed, Jul 19, 11:36 PM · Patch-For-Review, Reading-Web-Kanban-Board, Vector, Reading-Web-Backlog
Krinkle renamed T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook from Remove $wgResourceLoaderLESSVars to Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook.
Wed, Jul 19, 11:36 PM · Patch-For-Review, MediaWiki-Interface, MediaWiki-ResourceLoader, Technical-Debt
Krinkle merged T56617: Replace Tidy with a library that doesn't suck into T89331: Replace Tidy in MW parser with HTML 5 parse/reserialize.
Wed, Jul 19, 8:35 PM · Services (watching), User-notice, Tidy, RfC, Parsing-Team, ArchCom-RfC, Parsoid
Krinkle merged task T56617: Replace Tidy with a library that doesn't suck into T89331: Replace Tidy in MW parser with HTML 5 parse/reserialize.
Wed, Jul 19, 8:35 PM · Tidy, MediaWiki-Parser
Krinkle removed a parent task for T89331: Replace Tidy in MW parser with HTML 5 parse/reserialize: T56617: Replace Tidy with a library that doesn't suck.
Wed, Jul 19, 8:34 PM · Services (watching), User-notice, Tidy, RfC, Parsing-Team, ArchCom-RfC, Parsoid
Krinkle removed a subtask for T56617: Replace Tidy with a library that doesn't suck: T89331: Replace Tidy in MW parser with HTML 5 parse/reserialize.
Wed, Jul 19, 8:34 PM · Tidy, MediaWiki-Parser
Krinkle moved T163876: Grafana's incorrectly localizes dates (upstream bug) from Reported Upstream to Patch merged upstream on the Upstream board.
Wed, Jul 19, 7:13 PM · Upstream, Performance-Team
Krinkle moved T164299: Preload base modules request from Next-up to Doing on the Performance-Team board.
Wed, Jul 19, 6:44 PM · Patch-For-Review, Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T158837: Consolidate performance website and related software.

(Draft / brain dump)

Wed, Jul 19, 5:33 PM · monitoring, Performance-Team, Operations
Krinkle closed T170986: Add MediaWikiInstallPingback to EventLogging purging white-list as Declined.

This schema is and was never in use. The MediaWikiInstallPingback schema was a draft version of the schema for the mw:Pingback feature in MediaWiki – introduced in https://gerrit.wikimedia.org/r/296699.

Wed, Jul 19, 5:57 AM · Performance-Team, Analytics
Krinkle added a comment to T129148: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner).

Just now I tried to deploy an update to mediawiki/services/jobrunner. Given the Trebuchet entry point still exists on tin:/srv/deployment/jobrunner/jobrunner, and the documentation still mentions Trebuchet on https://wikitech.wikimedia.org/wiki/Jobrunner, and this task wasn't closed, I assumed it was still on Trebuchet. However, I see now that it was actually already converted to Scap3.

The deployment failed at the git deploy sync step ("0/44 minions completed fetch"). So probably nothing happened.

Wed, Jul 19, 1:55 AM · Performance-Team, Release-Engineering-Team (Kanban), MediaWiki-JobRunner, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2
Krinkle closed T70528: stream.wikimedia.org - redirect http(s) to docs as Resolved.

http://stream.wikimedia.org and https://stream.wikimedia.org all redirect to https://stream.wikimedia.org/?doc now.

Wed, Jul 19, 12:42 AM · Operations, Traffic, Wikimedia-Stream
Krinkle closed T69957: stream.wikimedia.org: Uneven distribution of client connections on backends as Declined.

Per T170157.

Wed, Jul 19, 12:41 AM · Operations, Wikimedia-Stream
Krinkle moved T170157: decommission rcs100[12] from Next up to Assigned on the Wikimedia-Stream board.
Wed, Jul 19, 12:35 AM · Patch-For-Review, hardware-requests, Operations, Analytics-Kanban, Wikimedia-Stream
Krinkle moved T170157: decommission rcs100[12] from Inbox to Next up on the Wikimedia-Stream board.
Wed, Jul 19, 12:35 AM · Patch-For-Review, hardware-requests, Operations, Analytics-Kanban, Wikimedia-Stream

Tue, Jul 18

Krinkle created P5759 T129148 - screen-jobrunner-deploy.
Tue, Jul 18, 11:08 PM
Krinkle added a comment to T129148: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner).

Just now I tried to deploy an update to mediawiki/services/jobrunner. Given the Trebuchet entry point still exists on tin:/srv/deployment/jobrunner/jobrunner, and the documentation still mentions Trebuchet on https://wikitech.wikimedia.org/wiki/Jobrunner, and this task wasn't closed, I assumed it was still on Trebuchet. However, I see now that it was actually already converted to Scap3.

Tue, Jul 18, 9:51 PM · Performance-Team, Release-Engineering-Team (Kanban), MediaWiki-JobRunner, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2
Krinkle moved T129148: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) from Inbox to Radar on the Performance-Team board.
Tue, Jul 18, 9:47 PM · Performance-Team, Release-Engineering-Team (Kanban), MediaWiki-JobRunner, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2
Krinkle edited projects for T129148: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner), added: Performance-Team; removed Patch-For-Review.
Tue, Jul 18, 9:47 PM · Performance-Team, Release-Engineering-Team (Kanban), MediaWiki-JobRunner, Deployment-Systems, Scap (Scap3-Adoption-Phase1), scap2
Krinkle committed rEBOPe3adfed844a6: build: bump npm dependencies (authored by hashar).
build: bump npm dependencies
Tue, Jul 18, 7:01 PM
Krinkle added a comment to T164299: Preload base modules request.

Confirmed with an isolated example that browsers will use the Link headers from their cached response when receiving a 304 Not Modified response without re-sending the Link headers on the 304 response. Test case: https://gist.github.com/Krinkle/d39cd3d4bd30a10fad5e1ae7f60b4c11

Tue, Jul 18, 2:10 AM · Patch-For-Review, Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle removed a project from T170880: Parser tests fail if default Skin for unit tests makes use of doEditSectionLink: Patch-For-Review.
Tue, Jul 18, 12:31 AM · Parsing-Team, MediaWiki-Parser, MediaWiki-Core-Tests, Mobile App Sprint 52 - Android, Patch-For-Review, Reading-Web-Backlog, MW-1.30-release-notes, Release-Engineering-Team, Continuous-Integration-Config
Krinkle added a project to T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown: Release-Engineering-Team.
Tue, Jul 18, 12:30 AM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure
Krinkle removed a project from T130434: Break up TextInputWidget: Patch-For-Review.
Tue, Jul 18, 12:27 AM · Technical-Debt, OOjs-UI
Krinkle moved T163876: Grafana's incorrectly localizes dates (upstream bug) from Backlog to Reported Upstream on the Upstream board.
Tue, Jul 18, 12:16 AM · Upstream, Performance-Team

Mon, Jul 17

Krinkle updated the task description for T170515: Upgrade MediaWiki core to QUnit 2.
Mon, Jul 17, 8:44 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, MediaWiki-Core-Tests
Krinkle created T170879: Make MobileFrontend compatible with QUnit 2.
Mon, Jul 17, 8:38 PM · Technical-Debt, Reading-Web-Backlog, MobileFrontend
Krinkle triaged T170515: Upgrade MediaWiki core to QUnit 2 as Normal priority.
Mon, Jul 17, 8:24 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, MediaWiki-Core-Tests
Krinkle updated the task description for T117411: On-wiki page performance inspector tool.
Mon, Jul 17, 6:40 PM · PerformanceInspector, Reading-Community-Engagement, Performance-Team
Krinkle added a subtask for T117411: On-wiki page performance inspector tool: T146045: Make Performance inspector opt-in (Beta Feature?).
Mon, Jul 17, 6:39 PM · PerformanceInspector, Reading-Community-Engagement, Performance-Team
Krinkle added a parent task for T146045: Make Performance inspector opt-in (Beta Feature?): T117411: On-wiki page performance inspector tool.
Mon, Jul 17, 6:39 PM · PerformanceInspector, Performance-Team
Krinkle claimed T104902: Refactor Navigation Timing gathering to produce reliable stackable measures.
Mon, Jul 17, 6:23 PM · Performance-Team
Krinkle moved T104902: Refactor Navigation Timing gathering to produce reliable stackable measures from Potential goals to Next-up on the Performance-Team board.
Mon, Jul 17, 6:23 PM · Performance-Team
Krinkle awarded T97536: GlobalRename is moving over existing pages, causing revisions to go missing (tracking) a Orange Medal token.
Mon, Jul 17, 2:13 AM · GlobalRename, Tracking, MediaWiki-extensions-CentralAuth

Sat, Jul 15

Krinkle updated the task description for T42618: jquery.tablesorter: Add support for a "fixed" column of row numbers..
Sat, Jul 15, 7:13 PM · Patch-For-Review, MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
Krinkle added a commit to T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown: rCIJEf65721e16c00: mediawiki: Configure 'error' and 'exception' log groups.
Sat, Jul 15, 7:03 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure
Krinkle removed projects from T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review.

OK. mw-error.log and mw-exception.log are empty again for phpunit and qunit jobs. Let's stay on top of this and enforce it soon? (@hashar, @greg)

Sat, Jul 15, 7:02 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure