Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Performance)Administrator

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (269 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

Twitter: @TimoTijhof
Website: https://timotijhof.net

(Photo by Niek Hidding.)

Recent Activity

Today

Krinkle updated the task description for T196558: Evaluate alternate means to send X-Analytics information from Varnish to Hadoop..
Mon, Dec 9, 9:03 PM · Performance-Team (Radar), Analytics
Krinkle moved T225578: EventLogging needs to enque events to avoid draining users' battery on mobile from Doing to Backlog: Future Goals on the Performance-Team board.

Quarter has rolled over once or twice since, not currently in my goals any more and likely won't have time for this in what's left of December. Putting up first thing for FY2019–20 Q3 in January.

Mon, Dec 9, 6:07 PM · Performance-Team, Patch-For-Review, Analytics-Kanban, Analytics-EventLogging, Analytics

Sat, Dec 7

Krinkle updated subscribers of T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS).

@Nikerabbit @Addshore When your respective teams are investigating this and if you need help with how the constraint works and how it is typically dealt with, you'll probably want to tag Core Platform Team as they know this code fairly well (and better than me).

Sat, Dec 7, 8:36 PM · Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikimedia-production-error, Wikidata
Krinkle created T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS).
Sat, Dec 7, 8:34 PM · Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikimedia-production-error, Wikidata

Thu, Dec 5

Krinkle moved T234847: Step 1: Performance review for Wikidata Bridge from Backlog: Small & Maintenance to Backlog: Future Goals on the Performance-Team board.
Thu, Dec 5, 2:00 PM · Performance-Team, Wikidata, Wikidata-Bridge
Krinkle renamed T158617: npm install fails for changeprop service in MW-Vagrant (cp rdkafka: permission denied) from npm install fails for changeprop service in MW-Vagrant jessie-migration to npm install fails for changeprop service in MW-Vagrant (cp rdkafka: permission denied).
Thu, Dec 5, 12:46 PM · Core Platform Team Legacy (Watching / External), Services (watching), MediaWiki-Vagrant
Krinkle added a comment to T206283: Failed deferred updates should be queued as jobs if possible (Deadlock from LinksUpdate in WikiPage::updateCategoryCounts).

@Krinkle @aaron Gerrit 522234 has been merged. As for Gerrit 497537, two things are missing:
(i) Amir had a concern on the PS that went unaddressed;

Thu, Dec 5, 12:35 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Page-derived-data, Performance-Team, Wikimedia-production-error
Krinkle renamed T236800: Ensure apcu incr/decr are atomic (Upgrade php-apcu) from Ensure apcu incr/decr are atomic to Ensure apcu incr/decr are atomic (Upgrade php-apcu).
Thu, Dec 5, 12:32 PM · Performance-Team (Radar), MediaWiki-Cache, Core Platform Team, serviceops
Krinkle moved T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Thu, Dec 5, 12:16 PM · Performance-Team (Radar), Parsing-Team, MediaWiki-Parser, TemplateStyles
Krinkle removed a project from T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML: Performance Issue.
Thu, Dec 5, 12:16 PM · Performance-Team (Radar), Parsing-Team, MediaWiki-Parser, TemplateStyles
Krinkle added projects to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML: Parsing-Team, Performance-Team (Radar).
Thu, Dec 5, 12:15 PM · Performance-Team (Radar), Parsing-Team, MediaWiki-Parser, TemplateStyles
Krinkle updated the task description for T239901: Disallow 'weight: 0' for MW db config in dbctl.
Thu, Dec 5, 11:49 AM · Operations, DBA, Wikimedia-Incident
jcrespo awarded T239901: Disallow 'weight: 0' for MW db config in dbctl a Dislike token.
Thu, Dec 5, 11:49 AM · Operations, DBA, Wikimedia-Incident
Krinkle updated the task description for T239901: Disallow 'weight: 0' for MW db config in dbctl.
Thu, Dec 5, 11:47 AM · Operations, DBA, Wikimedia-Incident
Krinkle added projects to T239901: Disallow 'weight: 0' for MW db config in dbctl: DBA, Operations.
Thu, Dec 5, 11:44 AM · Operations, DBA, Wikimedia-Incident
Krinkle created T239901: Disallow 'weight: 0' for MW db config in dbctl.
Thu, Dec 5, 11:44 AM · Operations, DBA, Wikimedia-Incident
Krinkle created T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs.
Thu, Dec 5, 11:41 AM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms
Krinkle added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

Note that s7 is metawiki + centralauth which are involved on requests for all wikis pretty much all the time. That includes group0 but their traffic may be too small to cause issues and/or to notice them. So the simple volume of group1 (commons, wikidata) switching to the new branch seems like a possible trigger, regardless of whether s7 wikis and group1 intersect.

Thu, Dec 5, 11:06 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Krinkle added a project to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error": DBA.
Thu, Dec 5, 12:56 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Krinkle closed T239874: MediaWiki: "host db1062 is unreachable" (Connection refused) as Resolved.

Thanks. Continuing at T239877 about the other two, which seems unrelated at this point (they are still "normal" replica dbs afaik).

Thu, Dec 5, 12:55 AM · DBA, Wikimedia-production-error
Krinkle updated subscribers of T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

The related issue at T239874 about db1062 (10.64.48.15, s7 wikis + centralauth) was much loader than the one reported here and turned out to be unrelated to the train. The s7 host was decom'ed but forgotten to be depooled, which @colewhite has now done. I've close that task now.

Thu, Dec 5, 12:55 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Krinkle added a comment to T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).

Two hosts that both claim to be the master / have 0 read load assigned. The first one is correct but the second one presumably isn't meant to be there. I don't actually know if it's valid to have a slave with 0 load. I guess that's for a follow-up to reject in the dbctl schema to prevent future issues so that one is forced to either remove it or assign at least 1 load (which is effectively the same as 0 given that 0 doesn't mean no interaction at all per the current issue). Having said that, I also don't know under which circumstances (aside from replag wait) a 0-load slave would be used. Perhaps if others are lagged / unused, which is quite likely given it is the only host with no other read queries so it might win regularly when weighing load against least-lagged meta data. To be continued :)

Thu, Dec 5, 12:48 AM · DBA, Wikimedia-production-error
Krinkle updated the task description for T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).
Thu, Dec 5, 12:28 AM · DBA, Wikimedia-production-error
Krinkle updated the task description for T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).
Thu, Dec 5, 12:27 AM · DBA, Wikimedia-production-error
Krinkle added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

I'm not sure but I don't think the db host being unreachable is caused by the train. I spotted it during the first train attempt today and reported it earlier at T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).

Thu, Dec 5, 12:23 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Krinkle added a comment to T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).

According to https://noc.wikimedia.org/db.php, db1062 is still part of s7.

Thu, Dec 5, 12:19 AM · DBA, Wikimedia-production-error
Krinkle created T239878: Fatal error: "Call to a member function clear() on null" from TemplateStylesHooks.
Thu, Dec 5, 12:13 AM · Product-Infrastructure-Team-Backlog, TemplateStyles, Wikimedia-production-error
Krinkle assigned T239724: Fatal error: "Object does not support method calls" (from MemcachedPeclBagOStuff) to aaron.

(Following from IRC). Feel free to pass back to me after initial investigation if you have other work (I can patch it).

Thu, Dec 5, 12:01 AM · Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle triaged T233342: Standardise on Logstash field for exceptions with back traces as Medium priority.
Thu, Dec 5, 12:00 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Performance-Team (Radar), Core Platform Team, MediaWiki-Debug-Logger

Wed, Dec 4

Krinkle triaged T239286: [testwiki] Transparency issue with Search drop down suggestions as Medium priority.
Wed, Dec 4, 11:59 PM · MediaWiki-ResourceLoader, Performance-Team, VisualEditor
Krinkle moved T239874: MediaWiki: "host db1062 is unreachable" (Connection refused) from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board.
Wed, Dec 4, 11:29 PM · DBA, Wikimedia-production-error
Krinkle added a comment to T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).

Mentioned in SAL (#wikimedia-operations) [2019-12-03T08:29:15Z] <marostegui@deploy1001> Synchronized wmf-config/db-eqiad.php: Remove db1062 from config T239188 (duration: 01m 08s)

Wed, Dec 4, 11:27 PM · DBA, Wikimedia-production-error
Krinkle created T239874: MediaWiki: "host db1062 is unreachable" (Connection refused).
Wed, Dec 4, 11:27 PM · DBA, Wikimedia-production-error
Krinkle added a comment to T233134: logstash-beta.wmflabs.org does not receive any mediawiki events.

seeing rsyslog complaining about "omkafka: kafka delivery FAIL" on deployment-prep hosts.

Wed, Dec 4, 10:14 PM · Release-Engineering-Team-TODO, observability, Wikimedia-Logstash, Beta-Cluster-Infrastructure
Krinkle merged task T239868: Logstash in Beta Cluster stopped ingesting messages from MediaWiki into T233134: logstash-beta.wmflabs.org does not receive any mediawiki events.
Wed, Dec 4, 10:14 PM · Operations, Beta-Cluster-Infrastructure, Wikimedia-Logstash
Krinkle merged T239868: Logstash in Beta Cluster stopped ingesting messages from MediaWiki into T233134: logstash-beta.wmflabs.org does not receive any mediawiki events.
Wed, Dec 4, 10:14 PM · Release-Engineering-Team-TODO, observability, Wikimedia-Logstash, Beta-Cluster-Infrastructure
Krinkle added a comment to T239868: Logstash in Beta Cluster stopped ingesting messages from MediaWiki.

seeing rsyslog complaining about "omkafka: kafka delivery FAIL" on deployment-prep hosts.

Wed, Dec 4, 10:13 PM · Operations, Beta-Cluster-Infrastructure, Wikimedia-Logstash
Krinkle created T239868: Logstash in Beta Cluster stopped ingesting messages from MediaWiki.
Wed, Dec 4, 10:12 PM · Operations, Beta-Cluster-Infrastructure, Wikimedia-Logstash
Krinkle moved T237477: Redis: Add support for TLS from Limbo to Watching on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Patch-For-Review, Performance-Team (Radar), Core Platform Team, MediaWiki-Cache
Krinkle moved T237636: [SPIKE 10hrs] Build new header within the Vector skin from Limbo to Watching on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Krinkle moved T238442: CSS fails to load on specific article when logged in, using Safari from Limbo to Watching on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Performance-Team (Radar), Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, CSS
Krinkle moved T239095: Undeleting pages with many revision results in DB exceptions from Limbo to Watching on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Performance-Team (Radar), Growth-Team, Core Platform Team, MediaWiki-Page-deletion
Krinkle moved T239451: DBPerformance: Unexpected masterConns on GET from ApiQueryInfo via BlockManager.php from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-API, Core Platform Team, MediaWiki-User-management, Anti-Harassment, Performance-Team (Radar)
Krinkle moved T239862: unwind the Puppetized /etc/hosts override of statsd.eqiad.wmnet from Limbo to Watching on the Performance-Team (Radar) board.
Wed, Dec 4, 9:29 PM · Performance-Team (Radar), Operations
Krinkle added a project to T239862: unwind the Puppetized /etc/hosts override of statsd.eqiad.wmnet: Performance-Team (Radar).
Wed, Dec 4, 9:29 PM · Performance-Team (Radar), Operations
Krinkle added a comment to T239862: unwind the Puppetized /etc/hosts override of statsd.eqiad.wmnet.

If I recall correctly, HHVM had a dns cache. This is among the reasons that, over the years, we gradually adopted more use of hostnames in wmf-config for services instead of hardcoding IP addresses. I guess we lost that in the PHP7 transition. Does the OS not cache this at all? Does PHP7 do something to bypass it?

Wed, Dec 4, 9:28 PM · Performance-Team (Radar), Operations
Krinkle added a comment to T239594: Unexpected general module "jquery.ui.core.styles" in styles queue..

Deployments happen once a week through the train. This is expected to roll out later this week, unless backported sooner which I proposed with the above cherry pick, but not sure it'll happen. Is this a volume risk currently? In terms of MW functionality the message is harmless and the fix didn't change behavior.

Wed, Dec 4, 1:38 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Performance-Team, Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository
Krinkle closed T227461: PHPRedis module >= 5.0.0 throws deprecation warnings for delete(). as Resolved.

Usage within MediaWiki (eg. libs/objectcache), which this task was for, has been resolved in master, deployed, and and backported.

Wed, Dec 4, 2:23 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Patch-For-Review, MediaWiki-Cache
Krinkle moved T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange) from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board.
Wed, Dec 4, 2:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Krinkle renamed T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via SpecialNewFiles) from ActorMigration.php: PHP Warning: Invalid argument supplied for foreach to ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via SpecialNewFiles).
Wed, Dec 4, 1:56 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Krinkle added a comment to T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange).

See also T207217 which triggers the same bug in ActorMigration.php from SpecialNewFiles.

Wed, Dec 4, 1:56 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Krinkle moved T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php] from Untriaged to Nov 2019 / 1.35.wmf.5+ on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
Krinkle created T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange).
Wed, Dec 4, 1:56 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Krinkle moved T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException from Untriaged to Nov 2019 / 1.35.wmf.5+ on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
Krinkle added a project to T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException: Wikidata-Campsite.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
Krinkle added a comment to T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException.

Likely related to T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job).

Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
Krinkle renamed T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed" from Internal error while undoing file captions: "Unsaved revision passed" to Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".
Wed, Dec 4, 1:56 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
Krinkle merged T238228: Internal error when undoing caption edit by IP: "Unsaved old revision passed" into T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".
Wed, Dec 4, 1:56 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
Krinkle moved T236833: wt2html: Out of memory crashers from Untriaged to Meta on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Wikimedia-production-error, serviceops, Operations, Parsoid-PHP
Krinkle merged task T238228: Internal error when undoing caption edit by IP: "Unsaved old revision passed" into T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".
Wed, Dec 4, 1:56 AM · Wikimedia-production-error, MediaWiki-Revision-backend, StructuredDataOnCommons
Krinkle moved T238228: Internal error when undoing caption edit by IP: "Unsaved old revision passed" from Untriaged to Nov 2019 / 1.35.wmf.5+ on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Wikimedia-production-error, MediaWiki-Revision-backend, StructuredDataOnCommons
Krinkle added a comment to T239083: Combo of bugs when restoring deleted pages with many revisions.

Not tracking as prod-error given it is too generic / tracking other issues.

Wed, Dec 4, 1:56 AM · MediaWiki-Page-deletion
Krinkle removed a project from T239083: Combo of bugs when restoring deleted pages with many revisions: Wikimedia-production-error.
Wed, Dec 4, 1:56 AM · MediaWiki-Page-deletion
Krinkle updated the task description for T239192: WMFTimeoutException in Wikidata recentchanges.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Performance Issue, Wikidata, MediaWiki-Recent-changes, User-DannyS712, Growth-Team, Wikimedia-production-error
Krinkle added a project to T239192: WMFTimeoutException in Wikidata recentchanges: Wikidata-Campsite.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Performance Issue, Wikidata, MediaWiki-Recent-changes, User-DannyS712, Growth-Team, Wikimedia-production-error
Krinkle moved T239192: WMFTimeoutException in Wikidata recentchanges from Untriaged to Nov 2019 / 1.35.wmf.5+ on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Wikidata-Campsite, Performance Issue, Wikidata, MediaWiki-Recent-changes, User-DannyS712, Growth-Team, Wikimedia-production-error
Krinkle moved T239724: Fatal error: "Object does not support method calls" (from MemcachedPeclBagOStuff) from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board.
Wed, Dec 4, 1:56 AM · Performance-Team, MediaWiki-Cache, Wikimedia-production-error

Tue, Dec 3

Krinkle added a comment to T213505: RfC: OpenGraph descriptions in wiki pages.

Some notes from an informal discussion about this task in TechCom:

Tue, Dec 3, 11:23 PM · Core Platform Team, Product-Infrastructure-Team-Backlog, MediaWiki-General, TechCom-RFC
Krinkle updated the task description for T220056: MediaWiki database policy and/or guidelines (2019).
Tue, Dec 3, 11:14 PM · DBA, TechCom-RFC
Krinkle merged T237229: Schema change procedure documentation blanked, no alternative given for 8 months into T220056: MediaWiki database policy and/or guidelines (2019).
Tue, Dec 3, 11:07 PM · DBA, TechCom-RFC
Krinkle merged task T237229: Schema change procedure documentation blanked, no alternative given for 8 months into T220056: MediaWiki database policy and/or guidelines (2019).
Tue, Dec 3, 11:07 PM · TechCom, MediaWiki-General, Documentation
Krinkle added a comment to T237229: Schema change procedure documentation blanked, no alternative given for 8 months.

I'm merging this into T220056 for now given both are about the same issue and have the same outcome as far as TechCom territory goes.

Tue, Dec 3, 11:07 PM · TechCom, MediaWiki-General, Documentation
Krinkle added a comment to T238426: Creating a file description page with a redirect to an existing image, doesn't purge pages using the recently created redirect.

Other issues related to the (lack of) purging for HTTP caches for File description pages:

Tue, Dec 3, 10:53 PM · MediaWiki-File-management, Commons, MediaWiki-Cache
Krinkle renamed T104711: File description page should be purged after deleting file from File page not purged after deletion to File description page should be purged after deleting file.
Tue, Dec 3, 10:50 PM · Commons, MediaWiki-Cache
Krinkle renamed T26575: Purge Category and File description pages from HTTP/File cache when members/usage changes via LinkUpdate from Purge Category and File description pages from file cache or squid cache on link update to Purge Category and File description pages from HTTP/File cache when members/usage changes via LinkUpdate.
Tue, Dec 3, 10:49 PM · Core Platform Team, MediaWiki-Cache, MediaWiki-Page-editing
Krinkle moved T238426: Creating a file description page with a redirect to an existing image, doesn't purge pages using the recently created redirect from Untriaged to HTTP Cache proxy on the MediaWiki-Cache board.
Tue, Dec 3, 10:48 PM · MediaWiki-File-management, Commons, MediaWiki-Cache
Krinkle moved T239724: Fatal error: "Object does not support method calls" (from MemcachedPeclBagOStuff) from Untriaged to libs/objectcache on the MediaWiki-Cache board.
Tue, Dec 3, 10:47 PM · Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle closed T236222: Jenkins console section matching breaks output HTML rendering as Resolved.

LGTM. Thanks!

Tue, Dec 3, 10:34 PM · Upstream, Performance-Team, Fresnel, Continuous-Integration-Infrastructure, Release-Engineering-Team (CI & Testing services), Jenkins
Krinkle renamed T239724: Fatal error: "Object does not support method calls" (from MemcachedPeclBagOStuff) from Object does not support method calls to Fatal error: "Object does not support method calls" (from MemcachedPeclBagOStuff).
Tue, Dec 3, 10:32 PM · Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle added a project to T137926: Support running MediaWiki without 'curl' PHP extension: Patch-For-Review.
Tue, Dec 3, 10:31 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), TechCom-RFC (TechCom-Approved), MediaWiki-Installer
Krinkle removed projects from T137926: Support running MediaWiki without 'curl' PHP extension: Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).
Tue, Dec 3, 10:31 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), TechCom-RFC (TechCom-Approved), MediaWiki-Installer
Krinkle moved T221177: REST route handler extension interface RFC from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Tue, Dec 3, 10:30 PM · Core Platform Team Workboards (Team 1), TechCom-RFC (TechCom-Approved), Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))
Krinkle moved T232485: RFC: Core REST API namespace and version from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Tue, Dec 3, 10:30 PM · TechCom-RFC (TechCom-Approved), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Krinkle moved T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts from Untriaged to In progress on the TechCom-RFC (TechCom-Approved) board.
Tue, Dec 3, 10:30 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, MediaWiki-Maintenance-scripts
Krinkle moved T190379: RFC: Re-establish the development policies from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Tue, Dec 3, 10:30 PM · DBA, Performance-Team, TechCom-RFC (TechCom-Approved), TechCom
Krinkle moved T384: RfC: Dependency Injection for MediaWiki core from Untriaged to Implemented on the TechCom-RFC (TechCom-Approved) board.
Tue, Dec 3, 10:29 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Wikidata, Wikimedia-Developer-Summit-2016
Krinkle edited projects for T384: RfC: Dependency Injection for MediaWiki core, added: TechCom-RFC (TechCom-Approved); removed TechCom-RFC.
Tue, Dec 3, 10:29 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Wikidata, Wikimedia-Developer-Summit-2016
Krinkle closed T237707: doc1001 permission problems, a subtask of T137890: Relocate CI generated docs and coverage reports, as Resolved.
Tue, Dec 3, 9:17 PM · serviceops, Release-Engineering-Team (Kanban), Patch-For-Review, Test-Coverage, Developer-Wishlist (2017), Technical-Debt, Continuous-Integration-Infrastructure
Krinkle closed T237707: doc1001 permission problems, a subtask of T235715: Add Design Style Guide link to doc.wikimedia.org, as Resolved.
Tue, Dec 3, 9:17 PM · Wikimedia Design Style Guide (Wikimedia Design Style Guide v1.1), Design
Krinkle closed T237707: doc1001 permission problems as Resolved.

Looks like it. I'll find out next time but git-pull works fine now, but that already worked when there were no changes.

Tue, Dec 3, 9:17 PM · Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
Krinkle renamed T143037: Stop using jquery.tipsy in Wikimedia-maintained code from Stop using jquery.effects in Wikimedia-maintained code to Stop using jquery.tipsy in Wikimedia-maintained code.
Tue, Dec 3, 6:51 PM · Technical-Debt, JavaScript, MediaWiki-General
Krinkle updated the task description for T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech).
Tue, Dec 3, 6:50 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Krinkle updated the task description for T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech).
Tue, Dec 3, 6:48 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Krinkle created T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech).
Tue, Dec 3, 6:47 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Krinkle added a comment to T195807: Fix failing MediaWiki core tests on Postgres database backend.

Note that mediawiki-quibble-vendor-postgres-php72-docker is passing and enforced on every commit, so those are presumably disabled tests of which we have many outside Postgres as well. Fixing the disabled ones is a new goal post. Moving that seems fine, but perhaps we can list the ones currently known to be disabled for that reason so that there is a clear endpoint for this task (therefore not including new tests that may be disabled for similar reasons after today).

Tue, Dec 3, 4:49 PM · Core Platform Team, MediaWiki-Revision-backend, Wikimedia-production-error (Shared Build Failure), PostgreSQL
Krinkle added a comment to T143037: Stop using jquery.tipsy in Wikimedia-maintained code.

jquery.tipsy does not have jquery.effects.* modules as dependencies. Is this task meant to be about "jquery.tipsy" instead of "jquery.effects" or is it meant to be about jquery (ui) effects and is Tipsy and unrelated subtask?

Tue, Dec 3, 4:45 PM · Technical-Debt, JavaScript, MediaWiki-General
Krinkle added a project to T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.: Performance-Team.
Tue, Dec 3, 4:42 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Performance-Team, Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository
Krinkle closed T239594: Unexpected general module "jquery.ui.core.styles" in styles queue. as Resolved.

Change 553525 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove no-op 'jquery.ui.core.styles' from FullEntityParserOutputGenerator
https://gerrit.wikimedia.org/r/553525

Tue, Dec 3, 4:42 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Performance-Team, Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository
Krinkle moved T239540: Inconsistencies in flaggedrevs table: page id not updated (on restore?) from Query to Bad data & Corruption on the Wikimedia-database-error board.
Tue, Dec 3, 4:41 PM · Wikimedia-database-error, MediaWiki-extensions-FlaggedRevs
Krinkle added a project to T239540: Inconsistencies in flaggedrevs table: page id not updated (on restore?): Wikimedia-database-error.
Tue, Dec 3, 4:41 PM · Wikimedia-database-error, MediaWiki-extensions-FlaggedRevs