Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Performance)Administrator

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (254 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photography by Niek Hidding.)

Recent Activity

Today

Richard_Nevell_WMUK awarded T210313: Statistics for views of individual Wikimedia images a Stroopwafel token.
Thu, Aug 22, 1:02 PM · Multimedia, Analytics, Tool-Pageviews

Yesterday

Krinkle renamed T193613: Strategy for handling PHP interface changes from Come up with a strategy for handling PHP interface changes to Strategy for handling PHP interface changes.
Wed, Aug 21, 7:42 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
Pppery awarded T120085: Serve Main Page of WMF wikis from a consistent URL a Dislike token.
Wed, Aug 21, 7:20 PM · Core Platform Team, Patch-For-Review, Performance-Team, Operations, Traffic, TechCom-RFC, SEO, Wikimedia-Site-requests
Krinkle added a comment to T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.

@Daimona Great :) All looks good to me.

Wed, Aug 21, 7:04 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Performance-Team, AbuseFilter
Krinkle added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Ok, the VE engineers have now examined many different possible VE-level fixes to this. Unfortunately, all seem to worsen the codebase.
Below are evaluations of different possible VE-level fixes we've examined:
[..]

Wed, Aug 21, 5:50 PM · VisualEditor (Current work), Patch-For-Review, OOjs, VisualEditor-DataModel
Krinkle added a comment to T230601: Groups 'oversight'/'suppress' should be reconciled.

Hey, before I look further, does this change have consensus on the wikis? E.g. from stewards or something like that?

Wed, Aug 21, 3:08 PM · Core Platform Team, Patch-For-Review, User-Urbanecm, AbuseFilter
Krinkle closed T63710: Jenkins: Consistently getting 503 Varnish in response to succesful login as Resolved.

Nope.

Wed, Aug 21, 2:57 PM · Jenkins, Continuous-Integration-Infrastructure
Krinkle added a comment to T148047: Desktop MediaWiki should be able to lazy load images.

One thing we'll need to test is the browser's print feature (which we now promote prominently from the sidebar as well). In particular, to figure a way to force-load them (as mobile currently does), or to block on upstream browsers fixing this on their end if they haven't already.

Wed, Aug 21, 2:41 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking), MediaWiki-Parser, Epic
Krinkle added a project to T230932: RedirectSpecialArticle.php: PHP Notice: Undefined index: action: MediaWiki-Special-pages.
Wed, Aug 21, 2:19 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), MediaWiki-Redirects, MediaWiki-Special-pages, Wikimedia-production-error

Tue, Aug 20

Krinkle updated the task description for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Tue, Aug 20, 7:18 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Performance-Team, AbuseFilter
Krinkle reopened T228360: Narrow scope of MediaWiki-Database workboard as "Open".
Tue, Aug 20, 6:37 PM · Project-Admins, Performance-Team, Core Platform Team
Krinkle added a comment to T228360: Narrow scope of MediaWiki-Database workboard.

@Aklapper I noticed you renamed the workboard from Wikimedia-Rdbms to Mediawiki-Rdbms. I can speculate about reasons, but could you briefly explain the reason here for the record?

Tue, Aug 20, 6:37 PM · Project-Admins, Performance-Team, Core Platform Team
Krinkle renamed MediaWiki-Rdbms from Mediawiki-Rdbms to MediaWiki-Rdbms.
Tue, Aug 20, 6:34 PM
Krinkle closed T230780: vendor/bin/phpunit tests/phpunit/integration fails as Resolved.
Tue, Aug 20, 6:33 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-Rdbms, MediaWiki-Core-Testing
Krinkle moved T230780: vendor/bin/phpunit tests/phpunit/integration fails from Inbox to PHPUnit on the MediaWiki-Core-Testing board.
Tue, Aug 20, 6:33 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-Rdbms, MediaWiki-Core-Testing
Krinkle updated the task description for T230780: vendor/bin/phpunit tests/phpunit/integration fails.
Tue, Aug 20, 6:33 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-Rdbms, MediaWiki-Core-Testing
Krinkle moved T229245: Reduce size of module version hash from Doing to Blocked or Needs-CR on the Performance-Team board.
Tue, Aug 20, 6:05 PM · Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle moved T230260: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage) from Doing to Blocked or Needs-CR on the Performance-Team board.
Tue, Aug 20, 6:05 PM · Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Cache, Gadgets
Krinkle committed rEHIEf09683076ad6: Merge 'ext.wikihiero.special.css' module into 'ext.wikihiero' (authored by Krinkle).
Merge 'ext.wikihiero.special.css' module into 'ext.wikihiero'
Tue, Aug 20, 4:30 PM
Krinkle moved T199219: WDQS should use internal endpoint to communicate to Wikidata from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Aug 20, 3:03 PM · Performance-Team (Radar), Wikidata, Wikidata-Query-Service
Krinkle moved T230515: Grafana dashboards for sessionstore, k8s staging, are not working from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Aug 20, 3:03 PM · Operations, Core Platform Team Workboards (Green), Performance-Team (Radar)
Krinkle moved T230560: User script should start working when renamed to the correct name from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Aug 20, 3:02 PM · Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle moved T160993: MysqlUpdater::doWatchlistUpdate is very slow from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Aug 20, 3:02 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Growth-Team, MediaWiki-Watchlist, Patch-For-Review, MediaWiki-Installer
Krinkle added a project to T160993: MysqlUpdater::doWatchlistUpdate is very slow: Core Platform Team.

Tagging CPT for potential CR via their clinic duty (based on Tim's earlier interest).

Tue, Aug 20, 2:02 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Growth-Team, MediaWiki-Watchlist, Patch-For-Review, MediaWiki-Installer
Krinkle edited projects for T160993: MysqlUpdater::doWatchlistUpdate is very slow, added: Performance-Team (Radar); removed Performance.
Tue, Aug 20, 2:00 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Growth-Team, MediaWiki-Watchlist, Patch-For-Review, MediaWiki-Installer
Krinkle moved T230800: Improve Rdbms/LoadBalance and its LoadMonitor logic from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Aug 20, 1:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-Rdbms
Krinkle created T230800: Improve Rdbms/LoadBalance and its LoadMonitor logic.
Tue, Aug 20, 1:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-Rdbms
Krinkle moved T229456: Enable MYSQLI_CLIENT_FOUND_ROWS option for consistency with other RDBMS backends from Untriaged to General library on the MediaWiki-Rdbms board.
Tue, Aug 20, 1:03 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Performance-Team (Radar), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Rdbms

Sun, Aug 18

Krinkle added a comment to T211160: HostBot-AI study coordination with NotConfusing.

@notconfusing (After Wikimania lightning demo) The results look really nice, and it's great to see more success out of the Teahouse.

Sun, Aug 18, 1:10 PM · Research
Krinkle added a comment to T230680: punjabi.wikimedia.org: Change site language code from fake 'punjabi' to 'pa'.

We should probably do the same for all special wikis listed in the SiteMatrix if it's doable.

Sun, Aug 18, 12:00 PM · User-MarcoAurelio, Patch-For-Review, I18n, Wikimedia-Site-requests
Krinkle renamed T230680: punjabi.wikimedia.org: Change site language code from fake 'punjabi' to 'pa' from punjabi.wikipedia: change fake language 'punjabi' to 'pa' to punjabi.wikimedia.org: Change site language code from fake 'punjabi' to 'pa'.
Sun, Aug 18, 11:55 AM · User-MarcoAurelio, Patch-For-Review, I18n, Wikimedia-Site-requests

Sat, Aug 17

Krinkle updated subscribers of T113114: Make all wiki-facing error pages consistent.
Sat, Aug 17, 10:19 PM · Performance-Team, Patch-For-Review, Wikimedia-General-or-Unknown, Voice & Tone, Design
Krinkle added a comment to T222224: Normalize MediaWiki link tables.

@TK-999 Interesting correlation. Having to maintain fewer concepts would certainly be a win.

Sat, Aug 17, 3:43 PM · Core Platform Team, MediaWiki-Page-derived-data, Schema-change, Patch-For-Review, TechCom-RFC
Krinkle added a comment to T219725: Setup Fresnel to work with timeless.

See T220162.

Sat, Aug 17, 3:24 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Timeless
Krinkle closed T230487: Argon2PasswordTest failing on PHP 7.2.21+ (works upto PHP 7.2.16) as Resolved.

Sat, Aug 17, 3:19 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error (Shared Build Failure)
Krinkle closed T208897: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array as Resolved.
Sat, Aug 17, 3:14 PM · MW-1.32-notes, MW-1.33-notes, Patch-For-Review, Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Prod awarded T208897: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array a Love token.
Sat, Aug 17, 1:32 AM · MW-1.32-notes, MW-1.33-notes, Patch-For-Review, Performance-Team, MediaWiki-Cache, Wikimedia-production-error

Fri, Aug 16

Krinkle added a comment to T230604: Uncaught TypeError: imeLanguageList.forEach is not a function.

Can you reproduce this issue on a public wiki?

Fri, Aug 16, 11:35 AM · Wikimedia-production-error, UniversalLanguageSelector
Krinkle triaged T230260: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage) as Normal priority.
Fri, Aug 16, 11:32 AM · Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Cache, Gadgets
Krinkle removed a project from T208897: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).
Fri, Aug 16, 11:32 AM · MW-1.32-notes, MW-1.33-notes, Patch-For-Review, Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle reopened T208897: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array as "Open".
Fri, Aug 16, 11:32 AM · MW-1.32-notes, MW-1.33-notes, Patch-For-Review, Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle added a comment to T208897: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array.

I'm having this issue on 1.32. Can it be backported?

Fri, Aug 16, 11:31 AM · MW-1.32-notes, MW-1.33-notes, Patch-For-Review, Performance-Team, MediaWiki-Cache, Wikimedia-production-error
Krinkle moved T230065: 'Wikimedia\Rdbms\DBQueryError' with message 'A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:14 AM · Patch-For-Review, Performance-Team, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Rdbms, Wikimedia-production-error
Krinkle triaged T230152: TwoColConflictHooks: setDisabled() on a non-object (null) / Undefined index: preview as High priority.
Fri, Aug 16, 11:13 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-08-08, Two-Column-Edit-Conflict-Merge, Wikimedia-production-error, TCB-Team
Krinkle moved T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:12 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, Commons, Wikimedia-production-error
Krinkle moved T230158: OggHandler: Undefined index: 1 from Since Aug 2019 / 1.34.wmf17–20 to Resolved on the Wikimedia-production-error board.
Fri, Aug 16, 11:11 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Commons, TimedMediaHandler, Wikimedia-production-error
Krinkle moved T230158: OggHandler: Undefined index: 1 from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:09 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Commons, TimedMediaHandler, Wikimedia-production-error
Krinkle moved T230239: apifeedcontributions: Call to a member function getText() on a non-object (null) from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:08 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-API, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Krinkle moved T230290: Fatal DBQueryError exception: Lock wait timeout exceeded in MessageGroups::setPriority from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:07 AM · MediaWiki-extensions-Translate, Wikimedia-production-error
Krinkle renamed T230290: Fatal DBQueryError exception: Lock wait timeout exceeded in MessageGroups::setPriority from Fatal exception type Wikimedia\Rdbms\DBQueryError to Fatal DBQueryError exception: Lock wait timeout exceeded in MessageGroups::setPriority.
Fri, Aug 16, 11:07 AM · MediaWiki-extensions-Translate, Wikimedia-production-error
Krinkle moved T230604: Uncaught TypeError: imeLanguageList.forEach is not a function from Untriaged to Since Aug 2019 / 1.34.wmf17–20 on the Wikimedia-production-error board.
Fri, Aug 16, 11:06 AM · Wikimedia-production-error, UniversalLanguageSelector
Krinkle added a comment to T230604: Uncaught TypeError: imeLanguageList.forEach is not a function.

getIMELanguageList is from ULS's JavaScript module.

Fri, Aug 16, 11:06 AM · Wikimedia-production-error, UniversalLanguageSelector
Krinkle edited projects for T230604: Uncaught TypeError: imeLanguageList.forEach is not a function, added: UniversalLanguageSelector, Wikimedia-production-error; removed MediaWiki-General.
Fri, Aug 16, 11:05 AM · Wikimedia-production-error, UniversalLanguageSelector

Thu, Aug 15

Krinkle closed T191668: Define varargs in \IDatabase::buildLike() in a way phan can understand it as Resolved.

Looks like the Jade repo is no longer affected. And gated extensions are also fine. Closing for now.

Thu, Aug 15, 4:38 PM · Patch-For-Review, phan, Performance-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Rdbms
Krinkle moved T230487: Argon2PasswordTest failing on PHP 7.2.21+ (works upto PHP 7.2.16) from Untriaged to In progress on the Wikimedia-production-error (Shared Build Failure) board.
Thu, Aug 15, 4:09 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error (Shared Build Failure)
Krinkle added a project to T229566: BagOStuff InvalidArgumentException from line 710: Performance-Team.
Thu, Aug 15, 3:16 PM · Performance-Team, MediaWiki-Cache
Krinkle created T230560: User script should start working when renamed to the correct name.
Thu, Aug 15, 2:13 PM · Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle added a comment to T228342: Set explicit PHP support target for MediaWiki.

[..] Here are a few of my insights: [..]

Thu, Aug 15, 12:10 PM · MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support, TechCom-RFC
Krinkle added a comment to T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019.

Template migrations (Coordinaten2, Coordinate, Coordinaten, Coordinaten hemel, Geen coordinaten, Etalage, Coord Woordenboek), and Common.css removal (diff). The remaining bit is for Spoken Wikipedia which is blocked on T230471.

Thu, Aug 15, 10:05 AM · Bengali-Sites, Performance, TemplateStyles, Wikimania-Hackathon-2019
Krinkle placed T230472: Search index not updated for nl.wikipedia.org up for grabs.
Thu, Aug 15, 9:06 AM · Discovery-Search (Current work)
Krinkle closed T230472: Search index not updated for nl.wikipedia.org as Resolved.

Thanks. nl.wikipedia.org seems caught up now. Feel free to re-open, but I'd be fine with this being tracked further on the existing task(s).

Thu, Aug 15, 9:06 AM · Discovery-Search (Current work)
Krinkle added a comment to T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019.

where should I ask for help to avoid clogging this task?

Thu, Aug 15, 8:21 AM · Bengali-Sites, Performance, TemplateStyles, Wikimania-Hackathon-2019

Wed, Aug 14

Krinkle renamed T230516: offboard-user.py: do not hardcode Phabricator project names, use PHID instead from offobard-user.py: do not hardcode Phabricator project names, use PHID instead to offboard-user.py: do not hardcode Phabricator project names, use PHID instead.
Wed, Aug 14, 10:04 PM · Puppet, Operations
Krinkle added a comment to T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019.

Removed treeview CSS from nl.wikipedia.org's MediaWiki:Common.css (move, migrate, remove)

Wed, Aug 14, 6:14 PM · Bengali-Sites, Performance, TemplateStyles, Wikimania-Hackathon-2019
Krinkle renamed T230472: Search index not updated for nl.wikipedia.org from Search index not updated for nl.wikipedia.oorg to Search index not updated for nl.wikipedia.org.
Wed, Aug 14, 6:06 PM · Discovery-Search (Current work)
Krinkle renamed T230472: Search index not updated for nl.wikipedia.org from Search index not updated for nl.w.o to Search index not updated for nl.wikipedia.oorg.
Wed, Aug 14, 6:05 PM · Discovery-Search (Current work)
Krinkle claimed T230260: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage).
Wed, Aug 14, 2:49 PM · Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Cache, Gadgets
Krinkle renamed T230260: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage) from Strange database queries for each enabled gadget to Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage).
Wed, Aug 14, 2:49 PM · Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Cache, Gadgets
Krinkle added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Yeah, I think on the whole, I'd be okay with video.js going ahead as-is (from a perf perspective). With lazy-loading being something we'll get to later (as soon as possible, but not blocking).

Wed, Aug 14, 2:47 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
Krinkle awarded T230482: Disable HHVM test on BlueSpice* repos (advice needed) a Orange Medal token.
Wed, Aug 14, 2:43 PM · Release-Engineering-Team-TODO (201908), Continuous-Integration-Config
Krinkle updated the task description for T230487: Argon2PasswordTest failing on PHP 7.2.21+ (works upto PHP 7.2.16).
Wed, Aug 14, 2:41 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error (Shared Build Failure)
Krinkle created T230487: Argon2PasswordTest failing on PHP 7.2.21+ (works upto PHP 7.2.16).
Wed, Aug 14, 2:41 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error (Shared Build Failure)
Krinkle added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Aye, that's the underlying issue indeed. Affects other indicator content and other hook-triggered enhancements as well (such as sortable and collapsible tables), albeit TMH is probably the only enhanced feature one would realistically use in an indicator. (But never say never...)

Wed, Aug 14, 2:32 PM · MediaWiki-Parser, TimedMediaHandler
Krinkle committed rEASR79896dbca612: phpunit: Use FauxRequest($data) instead of FauxRequest::setVal (authored by Krinkle).
phpunit: Use FauxRequest($data) instead of FauxRequest::setVal
Wed, Aug 14, 12:32 PM
Krinkle added a comment to T230472: Search index not updated for nl.wikipedia.org.

I'm looking at some plain searches as well (not just insource) for other people's edits made in the past two hours, e.g. nlwiki rev 54376623, and it also still isn't indexed at https://nl.wikipedia.org/w/index.php?search=%22speelde+de+rol+van+DDT%22&title=Speciaal%3AZoeken&go=Artikel&ns0=1.

Wed, Aug 14, 12:08 PM · Discovery-Search (Current work)
Krinkle edited projects for T230471: TMH audio player missing for clips inside <indicator> , added: MediaWiki-Parser; removed ParserFunctions.
Wed, Aug 14, 11:07 AM · MediaWiki-Parser, TimedMediaHandler
Krinkle created T230471: TMH audio player missing for clips inside <indicator> .
Wed, Aug 14, 11:07 AM · MediaWiki-Parser, TimedMediaHandler
Restricted Application updated subscribers of T107332: Parsoid-native implementation for <indicator> (page status indicators).
Wed, Aug 14, 11:02 AM · Parsoid-Read-Views
Krinkle awarded T107332: Parsoid-native implementation for <indicator> (page status indicators) a Orange Medal token.
Wed, Aug 14, 11:02 AM · Parsoid-Read-Views
Krinkle closed T75599: indicator can't add class as Invalid.

The only allowed attribute on <indicator> is name, which informs the parser internally about which indicator this is (there can be multiple).

Wed, Aug 14, 11:02 AM · MediaWiki-Parser
Krinkle updated the task description for T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019.
Wed, Aug 14, 8:11 AM · Bengali-Sites, Performance, TemplateStyles, Wikimania-Hackathon-2019
Krinkle added a comment to T162379: Decide which non-standard CSS properties to support in TemplateStyles.

As part of T228604, ran into several things using zoom: 1; which is preventing me from saving the edit in an AbuseFilter-like fashion.

Wed, Aug 14, 8:05 AM · Core Platform Team, Patch-For-Review, css-sanitizer, TemplateStyles

Tue, Aug 13

Krinkle added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Quick fly-by note from talking about this with @Ladsgroup at the hackathon....

Tue, Aug 13, 10:21 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
Krinkle updated subscribers of T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.
Tue, Aug 13, 10:17 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
Krinkle updated subscribers of T99740: Use static php array files for l10n cache instead of CDB.
Tue, Aug 13, 9:53 PM · Patch-For-Review, Performance-Team (Radar), Deployments, MediaWiki-Internationalization
Krinkle updated subscribers of T226210: Fix conditional presence of 'sitenotice' data and #siteNotice element.
Tue, Aug 13, 9:23 PM · User-Ladsgroup, MediaWiki-Interface, patch-welcome, Technical-Debt, MediaWiki-extensions-CentralNotice, Performance-Team (Radar)
Krinkle assigned T226210: Fix conditional presence of 'sitenotice' data and #siteNotice element to Ladsgroup.
Tue, Aug 13, 9:23 PM · User-Ladsgroup, MediaWiki-Interface, patch-welcome, Technical-Debt, MediaWiki-extensions-CentralNotice, Performance-Team (Radar)
Krinkle moved T229836: Track module registry size over time from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Aug 13, 8:41 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Performance-Team (Radar), User-Ladsgroup
Krinkle moved T170567: Support TLSv1.3 from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Aug 13, 8:41 PM · Performance-Team (Radar), Goal, Patch-For-Review, Traffic, Operations
Krinkle moved T230425: Page creation log should not display the content of deleted pages from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Aug 13, 3:42 PM · Performance-Team (Radar), Anti-Harassment, MediaWiki-Logging
Krinkle added a project to T230425: Page creation log should not display the content of deleted pages: Performance-Team (Radar).
Tue, Aug 13, 3:42 PM · Performance-Team (Radar), Anti-Harassment, MediaWiki-Logging

Mon, Aug 12

Krinkle added a comment to T230260: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage).

Is the query from page views (OutputPage), from the startup module (load.php), or from the gadget module response (load.php)?

Mon, Aug 12, 11:43 PM · Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Cache, Gadgets
Krinkle moved T228339: VideoJS needs to be lazy-loaded on click before we can release it by default from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Mon, Aug 12, 7:07 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
Krinkle edited projects for T228339: VideoJS needs to be lazy-loaded on click before we can release it by default, added: Performance-Team (Radar); removed Performance.
Mon, Aug 12, 7:07 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler

Thu, Aug 8

Krinkle awarded T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019 a Orange Medal token.
Thu, Aug 8, 11:40 AM · Bengali-Sites, Performance, TemplateStyles, Wikimania-Hackathon-2019

Wed, Aug 7

Krinkle triaged T225252: mediawiki-config (and others?) should ride gate-and-submit-swat not gate-and-submit as Low priority.
Wed, Aug 7, 8:29 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure
Krinkle added a comment to T225252: mediawiki-config (and others?) should ride gate-and-submit-swat not gate-and-submit.

FWIW, gate-and-submit and gate-and-submit-swat have the same priority.
Zuul is currently limited by gearman WRT priorities; there's only low, normal, and high and these are set per pipeline. Both of these pipelines are have high priority: [..]

Wed, Aug 7, 8:29 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure
Krinkle closed T229986: Group-xxx.css is intermittently not loading as Invalid.

I'd recommend Tech forum, Wikitech or #wikimedia-tech (on Freenode IRC) for support with templates and gadgets.

Wed, Aug 7, 8:00 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle awarded T230060: Make mediawiki-config use swat gate and submit a Orange Medal token.
Wed, Aug 7, 7:06 PM · Release-Engineering-Team, Continuous-Integration-Config
Krinkle added a comment to T229986: Group-xxx.css is intermittently not loading.

When it is missing, it is not anywhere in the HTML elements tree? If so, then the issue is likely not related to ResourceLoader or CSS. But rather it could mean that the editnotice wikitext or template is sometimes not producing the element.

Wed, Aug 7, 6:08 PM · MediaWiki-ResourceLoader, Performance-Team