Krinkle (Timo Tijhof)
Principal Performance Engineer, Wikimedia Foundation

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (185 w, 22 h)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Today

Krinkle awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Orange Medal token.
Wed, Apr 25, 1:41 AM · Design, VisualEditor-MediaWiki-Links, VisualEditor-Links, VisualEditor
Krinkle added a comment to T159354: Move coal from graphite#001 nodes to webperf#001.

@Imarlier I landed it as-is.

Wed, Apr 25, 1:14 AM · Patch-For-Review, Performance-Team, Operations
Krinkle added a comment to T188958: Zuul Clone frequently fails in php70-phan-docker job.

Recent examples from that log:

Wed, Apr 25, 12:55 AM · Release-Engineering-Team, Continuous-Integration-Infrastructure

Yesterday

Krinkle edited projects for T181056: Use package 'qunit' instead of 'qunitjs' in package.json, added: Performance-Team; removed MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).
Tue, Apr 24, 7:51 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Performance-Team, MediaWiki-General-or-Unknown, JavaScript
Krinkle removed projects from T192862: Reduce overhead of navtiming beacon: MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review.
Tue, Apr 24, 7:48 PM · Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle added a comment to T190015: Create separate user group for editing sitewide JavaScript that does not include administrators by default.

I'd recommend to not separate editsitejs from editsitecss but keep them together. They're both equally capable of security compromise (e.g. reading values from the DOM, sending it somewhere). It's a bit harder in CSS but not impossible. It seems to me most arguments apply to both:

  • security (the level and type of trust).
  • domain knowledge (knowing community policies vs knowing software).
  • group purpose (administrating content and users vs reviewing and deploying code).
Tue, Apr 24, 7:08 PM · TechCom, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Krinkle added a project to T190015: Create separate user group for editing sitewide JavaScript that does not include administrators by default: TechCom.
Tue, Apr 24, 6:56 PM · TechCom, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Krinkle added a comment to T192855: Remex enabled on all wikis in MW 1.30-wmf.30 exposing corruption (signatures coloring unrelated follow-up sections, etc.) on unfixed content.
mwscript eval.php --wiki arwiki
> var_dump($wgTidyConfig);
array(1) {
  ["driver"]=>
  string(9) "RemexHtml"
}
Tue, Apr 24, 5:12 PM · User-notice, Patch-For-Review, Tidy, RemexHtml
Krinkle updated the task description for T159354: Move coal from graphite#001 nodes to webperf#001.
Tue, Apr 24, 4:19 PM · Patch-For-Review, Performance-Team, Operations
Krinkle closed T163932: Add links to recent performance posts on performance.wikimedia.org as Resolved.
Tue, Apr 24, 4:17 PM · Performance-Team
Krinkle renamed T159354: Move coal from graphite#001 nodes to webperf#001 from Move coal from graphite machine(s) to Move coal from graphite#001 nodes to webperf#001.
Tue, Apr 24, 4:16 PM · Patch-For-Review, Performance-Team, Operations
Krinkle updated the task description for T158837: Consolidate performance website and related software.
Tue, Apr 24, 4:11 PM · Patch-For-Review, monitoring, Performance-Team, Operations
Krinkle moved T192931: Technical debt: jquery.tablesorter hardcodes exclude for span.references from Unsorted to Refactor / Rewrite on the Technical-Debt board.
Tue, Apr 24, 3:57 PM · Cite, MediaWiki-jQuery-Tablesorter, Technical-Debt
Krinkle created T192931: Technical debt: jquery.tablesorter hardcodes exclude for span.references.
Tue, Apr 24, 3:57 PM · Cite, MediaWiki-jQuery-Tablesorter, Technical-Debt
zeljkofilipin awarded T187761: Proposal: Effective immediately, disallow multi-sync patch deployment a Goat token.
Tue, Apr 24, 9:06 AM · User-zeljkofilipin, Release-Engineering-Team (Kanban), MediaWiki-SWAT-deployments
Krinkle updated the task description for T127328: Optimise critical rendering path.
Tue, Apr 24, 3:11 AM · Epic, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Tue, Apr 24, 3:10 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle assigned T191596: Regression: Module mobile.site.styles is not being loaded with mobile.site module to Jdlrobson.
Tue, Apr 24, 2:43 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Readers-Web-Kanbanana-Board, Performance-Team (Radar), Readers-Web-Backlog, MediaWiki-ResourceLoader, Regression, MobileFrontend
Krinkle moved T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) from Inbox to Accepted: Bugs on the MediaWiki-ResourceLoader board.
Tue, Apr 24, 2:38 AM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle closed T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) as Resolved.
Tue, Apr 24, 2:38 AM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle removed a project from T188689: Finalise addModuleStyles() and addModuleScripts() legacy behaviours: MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).
Tue, Apr 24, 2:37 AM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Krinkle placed T192826: Global user contributions: Support CIDR up for grabs.
Tue, Apr 24, 2:36 AM · Tool-Global-user-contributions
Krinkle moved T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure from Resolved to In progress on the Wikimedia-log-errors (Jenkins Failure) board.
Tue, Apr 24, 2:36 AM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)
Krinkle added a comment to T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure.

This job still fails very rarely with an assertion error from testClear(). Both that method and testGetBlobCached deal with caching. Both of them use a HashBagOStuff to store a key and essentially assert that it still exists 1 line later. The Hash cache uses a plain PHP array. It is a mystery to me how a key can disappear there. And I am still unable to reproduce it locally, including with quibble.

Tue, Apr 24, 2:36 AM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)
Krinkle removed projects from T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure: MW-1.31-release-notes, Patch-For-Review.
Tue, Apr 24, 2:32 AM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)
Krinkle created T192862: Reduce overhead of navtiming beacon.
Tue, Apr 24, 2:12 AM · Performance-Team, MediaWiki-extensions-NavigationTiming

Mon, Apr 23

Krinkle closed T184339: Deprecate wfShellWikiCmd() as Resolved.

[mediawiki/core@master] Deprecate wfShellWikiCmd()
https://gerrit.wikimedia.org/r/405974

Mon, Apr 23, 8:55 PM · MW-1.31-release, MediaWiki-Shell
Krinkle removed a project from T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature: Patch-For-Review.
Mon, Apr 23, 8:54 PM · MW-1.31-release, MW-1.27-release, MediaWiki-General-or-Unknown
Krinkle closed T191800: Restore CSS/JS cache clearing hint as Resolved.
Mon, Apr 23, 8:51 PM · MW-1.30-release-notes, MW-1.31-release-notes, MW-1.30-release, MW-1.31-release, Regression, Easy, MediaWiki-General-or-Unknown
Krinkle moved T180817: Review TemplateStyles patches related to previewing site CSS changes from Blocked to Doing on the Performance-Team board.
Mon, Apr 23, 8:22 PM · MediaWiki-ResourceLoader, Reading-Infrastructure-Team-Backlog, Performance-Team, Patch-For-Review, TemplateStyles
Krinkle moved T112474: Allow previewing a specific page when editing site JS/CSS (e.g. Common.css, Vector.js) from Backlog to Radar on the Performance-Team board.
Mon, Apr 23, 8:21 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Performance-Team (Radar), Patch-For-Review, MediaWiki-extensions-TemplateSandbox, MediaWiki-Interface, MediaWiki-ResourceLoader
Krinkle assigned T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) to aaron.
Mon, Apr 23, 8:20 PM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle claimed T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure.
Mon, Apr 23, 8:19 PM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)
Krinkle moved T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure from Inbox to Doing on the Performance-Team board.
Mon, Apr 23, 8:19 PM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)
Krinkle removed a project from T192663: Barack Obama desktop lastVisualChange prod is fluctuating rapidly by 1.5s: Performance.
Mon, Apr 23, 8:14 PM · Upstream, Performance-Team, Readers-Web-Backlog
Krinkle triaged T192826: Global user contributions: Support CIDR as Normal priority.
Mon, Apr 23, 8:05 PM · Tool-Global-user-contributions
Krinkle moved T192826: Global user contributions: Support CIDR from Backlog to Accepted-Feature on the Tool-Global-user-contributions board.
Mon, Apr 23, 8:04 PM · Tool-Global-user-contributions
MarcoAurelio awarded T192826: Global user contributions: Support CIDR a Like token.
Mon, Apr 23, 7:55 PM · Tool-Global-user-contributions
Krinkle updated the task description for T178862: Revisit different color of links for internal (inner-domain) and interwiki/external links.
Mon, Apr 23, 7:30 PM · Readers-Web-Backlog (Design), MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, WikimediaUI Style Guide, UI-Standardization
Krinkle added a comment to T191405: Mark interwiki links as external links when they fall outside the WMF family.

The interwiki database already has the notion of "local" links, which for example, triggers whether or not it can be a language link, whether it can be redirected to, and whether to display an interstitial page if entered in the search field (example).

Mon, Apr 23, 7:29 PM · MediaWiki-Parser, MediaWiki-Interface, MediaWiki-extensions-Interwiki
Krinkle awarded T178862: Revisit different color of links for internal (inner-domain) and interwiki/external links a Orange Medal token.
Mon, Apr 23, 7:15 PM · Readers-Web-Backlog (Design), MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, WikimediaUI Style Guide, UI-Standardization
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Mon, Apr 23, 7:01 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle added a comment to T160315: Remove mwLoadStart and track mwLoadEnd relative to fetchStart.

The other bucket start to render at 2.5 seconds and mwLoadStarts happens earlier 800-900 ms and block the rendering. It's seems to correlate for the other pages two where we have the two bucket scenarios: Early mwLoadStarts gives us a slow first paint on Firefox.

Without the mwLoadStart I've wouldn't been able to see that, the other metrics gives me no idea what's going on (missing HAR doesn't help either).

Mon, Apr 23, 5:55 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-NavigationTiming, MediaWiki-ResourceLoader, Performance-Team, WebPageTest
Krinkle added a comment to T189375: MediaWiki:Common.css does not allow starting and trailing space inside url().

I'm a little bit confused here. This bug is about quoted URLs, and that's also what the commit message in https://gerrit.wikimedia.org/r/428371 says. However, RELEASE-NOTES-1.31 says unquoted URLs. Have you actually fixed two different issues here, or is the wording the release notes a mistake?

Mon, Apr 23, 5:33 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Mon, Apr 23, 4:53 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle moved T159354: Move coal from graphite#001 nodes to webperf#001 from Blocked to Potential goals on the Performance-Team board.
Mon, Apr 23, 4:41 PM · Patch-For-Review, Performance-Team, Operations
Krinkle changed the status of T159354: Move coal from graphite#001 nodes to webperf#001 from Stalled to Open.
Mon, Apr 23, 4:41 PM · Patch-For-Review, Performance-Team, Operations
Krinkle changed the status of T159354: Move coal from graphite#001 nodes to webperf#001, a subtask of T158837: Consolidate performance website and related software, from Stalled to Open.
Mon, Apr 23, 4:41 PM · Patch-For-Review, monitoring, Performance-Team, Operations
Krinkle removed a parent task for T175087: Consider replacing Coal with use of Prometheus: T159354: Move coal from graphite#001 nodes to webperf#001.
Mon, Apr 23, 4:40 PM · Patch-For-Review, Performance-Team
Krinkle removed a subtask for T159354: Move coal from graphite#001 nodes to webperf#001: T175087: Consider replacing Coal with use of Prometheus.
Mon, Apr 23, 4:40 PM · Patch-For-Review, Performance-Team, Operations
Krinkle moved T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) from Low/No Production Impact to Production Impact on the Wikimedia-log-errors board.
Mon, Apr 23, 3:47 PM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle renamed T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) from Understand impact of LoadBalancer::doWait() warning in load.php code to Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) .
Mon, Apr 23, 3:47 PM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle raised the priority of T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) from Low to High.
Mon, Apr 23, 3:47 PM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle edited projects for T192611: Unexpected LoadBalancer::doWait() in load.php (ChronologyProtector not disabled) , added: MediaWiki-Database; removed MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review.
Mon, Apr 23, 3:46 PM · MW-1.31-release-notes, MediaWiki-Database, Wikimedia-log-errors, Performance-Team, MediaWiki-ResourceLoader
Krinkle updated the task description for T160315: Remove mwLoadStart and track mwLoadEnd relative to fetchStart.
Mon, Apr 23, 2:54 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-NavigationTiming, MediaWiki-ResourceLoader, Performance-Team, WebPageTest
Krinkle updated the task description for T192775: Set up phpunit coverage job for TemplateData.
Mon, Apr 23, 12:56 PM · User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, TemplateData, VisualEditor
Krinkle updated the task description for T192775: Set up phpunit coverage job for TemplateData.
Mon, Apr 23, 12:55 PM · User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, TemplateData, VisualEditor
Krinkle created T192775: Set up phpunit coverage job for TemplateData.
Mon, Apr 23, 12:55 PM · User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, TemplateData, VisualEditor

Sun, Apr 22

stjn awarded T30856: Remove classic edit toolbar from core a Like token.
Sun, Apr 22, 1:13 PM · MW-1.31-release, User-notice, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Krinkle committed rEASR929b0fd85074: Remove all QUnit assert.expect() (authored by thiemowmde).
Remove all QUnit assert.expect()
Sun, Apr 22, 12:49 AM

Sat, Apr 21

Krinkle added a comment to T189215: Array to string conversion errors with BagOStuff.php.

Stack comes from extensions/CentralNotice/includes/ChoiceDataProvider.php, not VisualEditor.

Sat, Apr 21, 3:54 AM · MediaWiki-extensions-CentralNotice, MediaWiki-Cache
Krinkle edited projects for T189215: Array to string conversion errors with BagOStuff.php, added: MediaWiki-extensions-CentralNotice; removed VisualEditor.
Sat, Apr 21, 3:54 AM · MediaWiki-extensions-CentralNotice, MediaWiki-Cache
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Sat, Apr 21, 2:09 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Sat, Apr 21, 2:08 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Sat, Apr 21, 1:53 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle committed rEASRddb6f850e774: Remove preset labels from tests (authored by thiemowmde).
Remove preset labels from tests
Sat, Apr 21, 12:30 AM

Fri, Apr 20

Krinkle added a comment to T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.

@thcipriani Hm.. these are seconds though, as opposed to minutes. Is there something different about these commands? I'm asking because on a short-lived process, JIT indeed adds more overhead than is worth. But if we're talking about a 40min process, JIT has got to speed things up. I'd be confused if it doesn't.

Fri, Apr 20, 10:55 PM · Operations, Release-Engineering-Team (Kanban), Scap
Krinkle moved T192576: Broken quibble jobs fail all mediawiki commits from Backlog to Resolved on the Wikimedia-log-errors (Jenkins Failure) board.
Fri, Apr 20, 9:29 PM · Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), Continuous-Integration-Infrastructure, Release-Engineering-Team
Krinkle reassigned T192576: Broken quibble jobs fail all mediawiki commits from Krinkle to hashar.
Fri, Apr 20, 9:29 PM · Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), Continuous-Integration-Infrastructure, Release-Engineering-Team
Krinkle closed T192576: Broken quibble jobs fail all mediawiki commits as Resolved.
Fri, Apr 20, 9:28 PM · Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), Continuous-Integration-Infrastructure, Release-Engineering-Team
Krinkle removed projects from T192467: Remove unused configuration global $wgSiteSupportPage: MW-1.31-release, Patch-For-Review.

I was planning to, but there's not much value in doing so at this point, and we've already merged the release notes.

Fri, Apr 20, 9:23 PM · Patch-For-Review, Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-Configuration, Technical-Debt
Framawiki awarded T192686: Beta Cluster sends password reset mails with prod address a Love token.
Fri, Apr 20, 9:20 PM · User-MarcoAurelio, MediaWiki-Configuration, Operations, Release-Engineering-Team, Beta-Cluster-Infrastructure
Krinkle closed T175834: TranslatablePageMoveJob commit while in atomic sections as Resolved.
Fri, Apr 20, 9:19 PM · Patch-For-Review, Language-2018-Apr-June, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-Team, MediaWiki-extensions-Translate, Wikimedia-log-errors
Krinkle closed T175834: TranslatablePageMoveJob commit while in atomic sections, a subtask of T170636: 1.30.0-wmf.18 deployment blockers, as Resolved.
Fri, Apr 20, 9:18 PM · RelEng-Archive-FY201718-Q1, Train Deployments, Release
Krinkle added a comment to T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.

@thcipriani Is this with or without translation cache (TC) and JIT?

Fri, Apr 20, 9:18 PM · Operations, Release-Engineering-Team (Kanban), Scap
Krinkle edited projects for T186090: Deprecate and remove MediaWikiI18N class from Skin system, added: Performance-Team; removed MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).
Fri, Apr 20, 9:16 PM · Performance-Team, MW-1.32-release, MediaWiki-HTML-Templating, MediaWiki-Interface
Krinkle closed T186090: Deprecate and remove MediaWikiI18N class from Skin system as Resolved.
Fri, Apr 20, 9:16 PM · Performance-Team, MW-1.32-release, MediaWiki-HTML-Templating, MediaWiki-Interface
Krinkle closed T186090: Deprecate and remove MediaWikiI18N class from Skin system, a subtask of T140664: Prepare MediaWiki for API-driven frontend, as Resolved.
Fri, Apr 20, 9:15 PM · Performance-Team, MediaWiki-Platform-Team, MediaWiki-Interface, Epic, MediaWiki-General-or-Unknown
Krinkle added a comment to T186090: Deprecate and remove MediaWikiI18N class from Skin system.

Perhaps, but note that the checklist in the task description is not a list of result that use MediaWikiI18N (via QuickTemplate->translate). Rather, it's a list of results where QuickTemplate is extended directly, rather than extending the BaseTemplate class (which extends QuickTemplate and adds the "normal" msg function instead).

Fri, Apr 20, 9:15 PM · Performance-Team, MW-1.32-release, MediaWiki-HTML-Templating, MediaWiki-Interface
Krinkle added a comment to T178629: Last-Modified header makes pages uncacheable in frontend caches when it was modified after $wgSquidMaxage.

@Ciencia_Al_Poder The idea of spreading out the expiry, based on either randomness or based on the page's last modified timestamp, makes sense. However, I don't see how changing the Last-Modified timestamp would change the fact that the 100 objects will still expire after 5 hours due to the s-maxage set, and if those 100 objects are requested again after that, they will still result in 100 requests to MW.

Fri, Apr 20, 9:10 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-Cache
Krinkle added a project to T192686: Beta Cluster sends password reset mails with prod address: Operations.
Fri, Apr 20, 8:40 PM · User-MarcoAurelio, MediaWiki-Configuration, Operations, Release-Engineering-Team, Beta-Cluster-Infrastructure
Krinkle added a project to T192686: Beta Cluster sends password reset mails with prod address: Release-Engineering-Team.
Fri, Apr 20, 8:40 PM · User-MarcoAurelio, MediaWiki-Configuration, Operations, Release-Engineering-Team, Beta-Cluster-Infrastructure
Krinkle created T192686: Beta Cluster sends password reset mails with prod address.
Fri, Apr 20, 8:39 PM · User-MarcoAurelio, MediaWiki-Configuration, Operations, Release-Engineering-Team, Beta-Cluster-Infrastructure
Krinkle edited projects for T187207: Spin out a tiny EventLogging RL module for lightweight logging, added: Performance-Team; removed Performance.
Fri, Apr 20, 7:53 PM · Performance-Team (Radar), Analytics-EventLogging, Analytics
Krinkle added a comment to T187207: Spin out a tiny EventLogging RL module for lightweight logging.

The "mini module" is essentially ext.eventLogging.subscriber. Currently, it has no dependencies besides mediawiki.user from core which means it shouldn't add anything on regular pages.

Fri, Apr 20, 7:53 PM · Performance-Team (Radar), Analytics-EventLogging, Analytics
Krinkle closed T189375: MediaWiki:Common.css does not allow starting and trailing space inside url() as Resolved.
Fri, Apr 20, 7:11 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Krinkle updated the task description for T160315: Remove mwLoadStart and track mwLoadEnd relative to fetchStart.
Fri, Apr 20, 5:51 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-NavigationTiming, MediaWiki-ResourceLoader, Performance-Team, WebPageTest
Krinkle claimed T160315: Remove mwLoadStart and track mwLoadEnd relative to fetchStart.

@Peter This has been in the backlog for a while, but to get metric in-place for T192623, I've written the patches for now. Was quite straight-forward because you already did most of the work in 2015 when we first introduced the mediaWikiLoadEnd metric :)

Fri, Apr 20, 5:51 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-NavigationTiming, MediaWiki-ResourceLoader, Performance-Team, WebPageTest
Krinkle moved T6740: thead, tbody, tfoot for wikitable syntax from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:20 PM · Accessibility, MediaWiki-Parser
Krinkle moved T8104: Wrap each wiki page section contents in a container from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:20 PM · Accessibility, CSS, MediaWiki-Interface
Krinkle moved T17491: ins or del 1st occurrence in blockquote causes bogus newline from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:19 PM · Accessibility, MediaWiki-Parser
Krinkle moved T18190: Relate section anchors to section headings in HTML from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:19 PM · Accessibility, MediaWiki-Parser
Krinkle moved T66478: Implement a Web standards-compliant solution for citation references from Unsorted to General / Epic / Umbrella on the Accessibility board.
Fri, Apr 20, 4:19 PM · Accessibility, Cite
Krinkle moved T38755: gallery should not use ul/li from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:19 PM · Accessibility, Multimedia, MediaWiki-Gallery, MediaWiki-Interface
Krinkle moved T118517: [RFC] Use <figure> for media from Unsorted to Semantic HTML on the Accessibility board.
Fri, Apr 20, 4:19 PM · Accessibility, Parsing-Team, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, MediaWiki-Parser, TechCom-RFC
Krinkle closed T12467: Use semantic HTML (tracking) as Resolved.

I've tagged the remaining open tags with Accessibility and its workboard column "Semantic HTML". Beyond tracking for discovery by experts in accessibility, tracking general issues with some form or another relating to HTML isn't useful.

Fri, Apr 20, 4:18 PM · Accessibility, Tracking, MediaWiki-Interface
Krinkle closed T12467: Use semantic HTML (tracking), a subtask of T2367: Markup accessibility issues (tracking), as Resolved.
Fri, Apr 20, 4:18 PM · Tracking, Accessibility, MediaWiki-Interface
Krinkle added a project to T6740: thead, tbody, tfoot for wikitable syntax: Accessibility.
Fri, Apr 20, 4:17 PM · Accessibility, MediaWiki-Parser
Krinkle added a project to T8104: Wrap each wiki page section contents in a container: Accessibility.
Fri, Apr 20, 4:17 PM · Accessibility, CSS, MediaWiki-Interface
Krinkle added a project to T18190: Relate section anchors to section headings in HTML: Accessibility.
Fri, Apr 20, 4:17 PM · Accessibility, MediaWiki-Parser