Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Performance)Administrator

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (262 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photography by Niek Hidding.)

Recent Activity

Yesterday

Ladsgroup awarded T215465: Development policy: Require use of common storage abstractions a Like token.
Thu, Oct 17, 10:42 PM · TechCom-RFC, Performance-Team (Radar), User-mobrovac, Services (watching), Core Platform Team Legacy (Watching / External), TechCom
Krinkle updated the task description for T235455: Resolve arclamp disk exhaustion problem (Oct 2019).
Thu, Oct 17, 8:59 PM · Patch-For-Review, serviceops, Performance-Team, Arc-Lamp
Krinkle added a project to T235787: Missing annotations for sync-wikiversions: Scap.
Thu, Oct 17, 8:56 PM · Scap, serviceops, Release-Engineering-Team
Krinkle updated the task description for T233676: Audit default page modules payload (2019).
Thu, Oct 17, 8:54 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team
Krinkle added a comment to T235797: We should not need 178kb of JS and 10.8kb of CSS to render a blank page.

My next Q goal starting soon: T233676: Audit default page modules payload (2019).
We should collaborate.

Thu, Oct 17, 8:51 PM · Spike, Performance-Team, Desktop Improvements, Readers-Web-Backlog
Krinkle awarded T235214: Allow URL query param for tab name a Orange Medal token.
Thu, Oct 17, 8:32 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, Machine vision, SDC-Statements (Machine-vision-depicts)
Krinkle added a comment to T66721: mw.loader.store should not occupy all of localStorage.

Thank you, would you mind creating a new task for that?

Thu, Oct 17, 6:47 PM · MW-1.27-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle closed T231029: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code as Declined.

No longer seen. Most certainly not fixed, but also not actionable until it happens. Closing for now and removing from the exclusion list of tolerated prod errors in the Logstash filters.

Thu, Oct 17, 6:29 PM · MediaWiki-extensions-WikimediaIncubator, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-User-preferences, Wikimedia-production-error
Krinkle added a comment to T226337: SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php.

This instance of "CAS update failed" from SpecialChangeEmail currently means that during train deployments we will not catch new instances of this error from anywhere else in core or extensions because it is currently filtered out on the mediawiki-new-errors Logstash dashboard and there isn't a feasible way to filter it out just for this code path with the limitations of Kibana and the amount of time we can justify maintainers of that dashboard spend on creating such filters.

Thu, Oct 17, 6:27 PM · Core Platform Team, Availability, Wikimedia-production-error, MediaWiki-User-preferences
Krinkle added a project to T226337: SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php: Core Platform Team.
Thu, Oct 17, 6:25 PM · Core Platform Team, Availability, Wikimedia-production-error, MediaWiki-User-preferences
Krinkle renamed T226337: SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php from User.php: CAS update failed on user_touched. The version of the user to be saved is older than the current version to SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php.
Thu, Oct 17, 6:20 PM · Core Platform Team, Availability, Wikimedia-production-error, MediaWiki-User-preferences
Krinkle edited projects for T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties', added: Wikidata-Campsite; removed MediaWiki-REST-API.
Thu, Oct 17, 6:19 PM · Wikidata-Campsite, MediaWiki-extensions-PropertySuggester, Wikidata, Wikimedia-production-error
Krinkle added a comment to T235392: I09a178e5c6938954edb2949f13660227d6a01fbc breaks extension Semantic MediaWiki.

Sounds good to me. Sorry about the confusion.

Thu, Oct 17, 6:12 PM · Parsing-Team, MW-1.34-release, Patch-For-Review, MediaWiki-Parser
Krinkle added a comment to T235610: Register license on GitHub mirror (use LICENSE and not only COPYING file) so source code can be queried with BigQuery.

GitHub use this library to parse the repo: < https://github.com/licensee/licensee>.

Thu, Oct 17, 4:35 PM · GitHub-Mirrors
thiemowmde awarded T218339: Deprecate and remove mediawiki.RegExp a Burninate token.
Thu, Oct 17, 8:24 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.35-release, MediaWiki-General, Performance-Team, Technical-Debt (Deprecation process)
Krinkle added a comment to T235214: Allow URL query param for tab name.

If the interface in question is not server-side rendered or if the query param otherwise does not varies the server response, and if sharing a link to the current tab is not yet possible (per the above comment). Then perhaps this might make more sense as a hash fragment? We could use something like #!/tab/foo for this purpose, although given it is a special page you might not need to worry about ambiguity with headings from user-generated content and could thus also use something simpler like #foo or #tab-foo. See Special:Preferences for an example of this.

Thu, Oct 17, 3:20 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, Machine vision, SDC-Statements (Machine-vision-depicts)
Krinkle updated subscribers of T229792: Remove HHVM from production.

Change 539128 had a related patch set uploaded (by Effie Mouzeli; owner: Giuseppe Lavagetto):
[mediawiki/extensions/WikimediaEvents@master] Remove the cookie extraction for sending users to PHP7
https://gerrit.wikimedia.org/r/539128

Thu, Oct 17, 3:04 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Performance-Team (Radar), serviceops, Operations, HHVM
Krinkle updated the task description for T235724: Remove old pcache metric compat from ParserCache.php.
Thu, Oct 17, 2:30 AM · User-Addshore, Wikidata-Campsite, Wikidata, Technical-Debt
Krinkle created T235724: Remove old pcache metric compat from ParserCache.php.
Thu, Oct 17, 2:28 AM · User-Addshore, Wikidata-Campsite, Wikidata, Technical-Debt
Krinkle added a comment to T219604: Remove unused jquery.ui.* and jquery.effects.* modules.

I've uploaded a Tourbot pattern for the migration at https://github.com/Krinkle/mw-tool-tourbot/commit/fdfb13a95. After the above backport is deployed and wmf.2 has reached group2, then it can be used to start migrating usage.

Thu, Oct 17, 1:20 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Performance-Team, Patch-For-Review, MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation process), JavaScript
Krinkle updated the task description for T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file.
Thu, Oct 17, 1:17 AM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons
Krinkle added a comment to T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file.

Looks like a regression. Tagging CPT and SDT, not sure where this falls under. I suppose it depends on where the culprit lies, which itself first needs to be determined.

Thu, Oct 17, 1:15 AM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons
Krinkle added projects to T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file: Core Platform Team, Regression, Structured Data Engineering, Structured-Data-Backlog.
Thu, Oct 17, 1:14 AM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons
Krinkle renamed T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file from Image page on Wikipedia displays content from Commons instead to File page for local Wikipedia image wrongly shows thumbnail for remote Commons file.
Thu, Oct 17, 1:12 AM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons

Wed, Oct 16

Krinkle moved T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null) from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

10 days have passed.

Wed, Oct 16, 11:07 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
Krinkle added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

The master patch was backported to wmf.1 and +2'ed in master before wmf.2 was cut, but it got lost in Zuul land somehow. This must be deployed before group2.

Wed, Oct 16, 11:04 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Krinkle added a subtask for T233850: 1.35.0-wmf.2 deployment blockers: T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.
Wed, Oct 16, 11:03 PM · Patch-For-Review, Release, Train Deployments
Krinkle added a parent task for T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs: T233850: 1.35.0-wmf.2 deployment blockers.
Wed, Oct 16, 11:03 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Krinkle triaged T235455: Resolve arclamp disk exhaustion problem (Oct 2019) as High priority.
Wed, Oct 16, 11:02 PM · Patch-For-Review, serviceops, Performance-Team, Arc-Lamp
Krinkle claimed T219604: Remove unused jquery.ui.* and jquery.effects.* modules.
Wed, Oct 16, 10:51 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Performance-Team, Patch-For-Review, MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation process), JavaScript
Krinkle edited projects for T219604: Remove unused jquery.ui.* and jquery.effects.* modules, added: Performance-Team; removed patch-welcome, Performance-Team (Radar).
Wed, Oct 16, 10:51 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Performance-Team, Patch-For-Review, MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation process), JavaScript
Krinkle removed a project from T233442: Remove use of deprecated 'editToken' in mw.user.tokens (replace with 'csrfToken'): MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).
Wed, Oct 16, 10:42 PM · Performance-Team (Radar), Technical-Debt, MediaWiki-extensions-General, User-TheSandDoctor
Krinkle removed a project from T229311: Avoid unnecessary encoding of '<', '>' and '&' in output of load.php: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).
Wed, Oct 16, 10:42 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Krinkle removed a project from T231107: Improve MediaWiki logging of errors uploading files to Swift: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).
Wed, Oct 16, 10:42 PM · Performance-Team, Commons, MediaWiki-File-management, media-storage
Krinkle updated the task description for T234361: Add debug() PSR messages to cache-related service wiring.
Wed, Oct 16, 10:40 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-release, MediaWiki-Cache, Performance-Team
Krinkle added a comment to T231366: Remove ProfilerOutputDb feature from MediaWiki core.

Next step: In master (1.35):

  • Remove the ProfilerOutputDb class,
  • Remove the profileinfo.php entry point.
  • Remove the profiling table schema definitions. (Document in the release notes that given it is mainly a developer feature, and the schema wasn't auto-created, it will also not be auto-removed. Anyone wishing to remove their old profiles can do so by running the DROP TABLE profiling; statement through sql.)
  • Remove anything else internal that solely for making ProfilerOutputDb possible.
Wed, Oct 16, 10:38 PM · MW-1.34-notes, MW-1.35-release, Core Platform Team Workboards (Clinic Duty Team), Performance-Team, MediaWiki-Debug-Logger
Krinkle added a comment to T235551: InstantCommons should cache remote images.

Performance has no opposition to enabling caching here for third parties. Makes sense to me. I've tagged CPT to further look at what the InstantCommons feature's needs are and whether it is functionally safe to re-enable, and what other (not perf-related) reasons there may be for keeping it off.

Wed, Oct 16, 10:24 PM · Performance-Team (Radar), Core Platform Team, MediaWiki-File-management, Multimedia, Commons
Krinkle closed T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader, a subtask of T233850: 1.35.0-wmf.2 deployment blockers, as Resolved.
Wed, Oct 16, 10:21 PM · Patch-For-Review, Release, Train Deployments
Krinkle closed T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader as Resolved.
Wed, Oct 16, 10:21 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Operations, MediaWiki-ResourceLoader
Krinkle moved T44085: Wikimedia needs a URL shortener (tracking) from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:19 PM · User-Ladsgroup, Proposal, TechCom-RFC (TechCom-Approved), Tracking-Neverending, WorkType-NewFunctionality, Wikimedia-General-or-Unknown
Krinkle moved T161647: RFC: Deprecate using php serialization inside MediaWiki from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:19 PM · TechCom, Core Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-Approved), Services (watching), Security
Krinkle moved T176370: Migrate to PHP 7 in WMF production from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:19 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), CPT Initiatives (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
Krinkle moved T198256: RFC: Modern Event Platform - Choose Schema Tech from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:19 PM · Core Platform Team Workboards (Done with CPT), TechCom-RFC (TechCom-Approved), Operations, Services (designing), Analytics-EventLogging, Event-Platform, Analytics
Krinkle moved T206010: RfC: Session storage service interface from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Core Platform Team Workboards (Done with CPT), TechCom-RFC (TechCom-Approved), User-Clarakosi, Core Platform Team (Session Management Service (CDP2)), User-Eevans
Krinkle moved T201963: RFC: Modern Event Platform: Stream Intake Service from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Core Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-Approved), Services (watching), Analytics-EventLogging, Event-Platform, Analytics
Krinkle moved T201643: RFC: Modern Event Platform: Schema Registry from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Core Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-Approved), Services (watching), Analytics-EventLogging, Event-Platform, Analytics
Krinkle moved T208524: RfC: Standards for external services in the Wikimedia infrastructure. from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · TechCom-RFC (TechCom-Approved), serviceops
Krinkle moved T228342: Define criteria for setting explicit PHP support target for MediaWiki from In progress to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
Krinkle moved T114596: [RFC] Method for bare page retrieval (e.g. render only / no skin) from Backlog to Cancelled on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Core Platform Team Legacy (Later), Offline-Working-Group, Services (later), TechCom-RFC (TechCom-Approved)
Krinkle moved T166010: The Great Namespaceization and Reorg from Backlog to In progress on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Core Platform Team, Wikimania-Hackathon-2019, TechCom-RFC (TechCom-Approved), TechCom, Epic
Krinkle moved T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) from Untriaged to Backlog on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016
Krinkle moved T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks from Untriaged to Backlog on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · Outreachy (Round 19), Core Platform Team, TechCom-RFC (TechCom-Approved), MediaWiki-Maintenance-scripts
Krinkle moved T200297: Review Jade data storage and architecture proposal [RFC] from Untriaged to In progress on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · TechCom-RFC (TechCom-Approved), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Scoring-platform-team (Current), DBA, Operations, Jade
Krinkle moved T191231: RFC: Abstract schemas and schema changes from Untriaged to In progress on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · CPT Initiatives (Abstract Schema), TechCom-RFC (TechCom-Approved), MediaWiki-Installer, Patch-For-Review, User-Addshore, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Krinkle moved T204142: Establish guiding principles for software and system architecture from Untriaged to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:18 PM · TechCom-RFC (TechCom-Approved), User-Daniel, TechCom
Krinkle moved T221177: REST route handler extension interface RFC from Untriaged to In progress on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:17 PM · Core Platform Team Workboards (Team 1), TechCom-RFC (TechCom-Approved), Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))
Krinkle moved T220657: Establish Architecture Principles as a policy from Untriaged to Implemented on the TechCom-RFC (TechCom-Approved) board.
Wed, Oct 16, 10:17 PM · TechCom-RFC (TechCom-Approved), TechCom
Krinkle moved T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts from Under discussion to Inbox on the TechCom-RFC board.

Looks like this has had an IRC meeting. Problem statement is clear. Proposal has been formed. No objections from TechCom and no stakeholders were identified beyond CPT and the various developers that have already participated so far.

Wed, Oct 16, 10:11 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
Krinkle updated the task description for T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).
Wed, Oct 16, 9:33 PM · Readers-Web-Backlog, Performance-Team (Radar), MediaWiki-General
Krinkle created T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).
Wed, Oct 16, 9:33 PM · Readers-Web-Backlog, Performance-Team (Radar), MediaWiki-General
Krinkle closed T171307: "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null), a subtask of T127268: Dismantle ResourceLoader's "targets" system, as Resolved.
Wed, Oct 16, 9:19 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Readers-Web-Backlog (Tracking), Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MediaWiki-ResourceLoader
Krinkle closed T171307: "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null) as Resolved.

Per T213242.

Wed, Oct 16, 9:19 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle claimed T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader.
Wed, Oct 16, 9:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Operations, MediaWiki-ResourceLoader
Krinkle renamed T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader from MW 1.35.0-wmf.2 has excessive logging from ResourceLoader to [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader.
Wed, Oct 16, 9:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Operations, MediaWiki-ResourceLoader
Krinkle added a comment to T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader.
Wed, Oct 16, 9:11 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Operations, MediaWiki-ResourceLoader
Krinkle added a subtask for T233850: 1.35.0-wmf.2 deployment blockers: T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader.
Wed, Oct 16, 9:11 PM · Patch-For-Review, Release, Train Deployments
Krinkle added a parent task for T235711: [1.35.0-wmf.2] Excessive "Module {name} not loadable on target mobile " logging from ResourceLoader: T233850: 1.35.0-wmf.2 deployment blockers.
Wed, Oct 16, 9:11 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Operations, MediaWiki-ResourceLoader
Krinkle moved T235512: Invalid magic word error on updating to MediaWiki 1.33.1 from Untriaged to MessageCache on the MediaWiki-Cache board.
Wed, Oct 16, 9:07 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Parser, MediaWiki-Cache
Krinkle moved T235705: Add BagOStuff metrics for read/write operations (bytes, key "class") grouped by type/ID from Untriaged to libs/objectcache on the MediaWiki-Cache board.
Wed, Oct 16, 9:07 PM · MediaWiki-Cache, Performance-Team
Krinkle closed T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error, a subtask of T233850: 1.35.0-wmf.2 deployment blockers, as Resolved.
Wed, Oct 16, 9:05 PM · Patch-For-Review, Release, Train Deployments
Krinkle closed T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error as Resolved.
Wed, Oct 16, 9:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Editing-team, WikiEditor
Krinkle claimed T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error.
Wed, Oct 16, 8:59 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Editing-team, WikiEditor
Krinkle added a project to T235160: Decide whether extensions should set a PHP version requirement in composer.json: MediaWiki-General.
Wed, Oct 16, 8:13 PM · MediaWiki-General, PHP 7.0 support, TechCom
Krinkle added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Sorry about that. I missed that Will had just untagged CPT.

Wed, Oct 16, 8:05 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Krinkle removed projects from T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs: Core Platform Team Workboards (Clinic Duty Team), Core Platform Team.
Wed, Oct 16, 8:05 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Krinkle added projects to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs: Core Platform Team, Core Platform Team Workboards (Clinic Duty Team).
Wed, Oct 16, 8:04 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Krinkle added a subtask for T233850: 1.35.0-wmf.2 deployment blockers: T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error.
Wed, Oct 16, 7:43 PM · Patch-For-Review, Release, Train Deployments
Krinkle added a parent task for T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error: T233850: 1.35.0-wmf.2 deployment blockers.
Wed, Oct 16, 7:43 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Editing-team, WikiEditor
Krinkle edited projects for T235701: Opening a dialog (f.e. link dialog) in 2010 wikitext editor results in JS “setTabindexes is not a function” error, added: WikiEditor, Editing-team; removed MediaWiki-General.
Wed, Oct 16, 7:43 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Performance-Team, Editing-team, WikiEditor
Krinkle added a comment to T235672: ResourceLoader: Don't add a version hash param in debug mode.

Can you check whether it works in latest Chrome when setting a breakpoint in a raw core file (with its version hash), and whether it remains after changing its content? I suspect this might work actually, and that the issue is with packageFiles having "load.php" as its filename which is ambiguous in this context (vs raw files having each their own url where the parameter can be ignored). In particular because a similar issue mentioned at T90983#2083366 was fixed upstream in Chromium.

Wed, Oct 16, 6:00 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T235142: Clean up mediawiki-config from HHVM-related configuration.

Moving from tracked under "Stuff part of deploying PHP 7 properly" to instead above "Stuff unblocked by not having HHVM".

Wed, Oct 16, 4:59 PM · Patch-For-Review, Wikimedia-Site-requests, HHVM
Krinkle removed a subtask for T176370: Migrate to PHP 7 in WMF production: T235142: Clean up mediawiki-config from HHVM-related configuration.
Wed, Oct 16, 4:58 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), CPT Initiatives (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
Krinkle removed a parent task for T235142: Clean up mediawiki-config from HHVM-related configuration: T176370: Migrate to PHP 7 in WMF production.
Wed, Oct 16, 4:57 PM · Patch-For-Review, Wikimedia-Site-requests, HHVM
Krinkle added a parent task for T192166: Drop HHVM support from MediaWiki: T235142: Clean up mediawiki-config from HHVM-related configuration.
Wed, Oct 16, 4:57 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Krinkle added a subtask for T235142: Clean up mediawiki-config from HHVM-related configuration: T192166: Drop HHVM support from MediaWiki.
Wed, Oct 16, 4:57 PM · Patch-For-Review, Wikimedia-Site-requests, HHVM
Krinkle reopened T231866: Circular dependency when creating service! ContentLanguage as "Open".

Formatted top-down:

Wed, Oct 16, 4:49 PM · Core Platform Team, Performance-Team (Radar), Language-Team, MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets, MediaWiki-ServiceContainer
Krinkle renamed MediaWiki-extensions-Gadgets from mediawiki-extensions-gadgets to MediaWiki-extensions-Gadgets.
Wed, Oct 16, 4:49 PM
Krinkle removed a project from T90983: ResourceLoader debug urls should bypass cache when they change: Patch-For-Review.
Wed, Oct 16, 4:43 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T235667: ResourceLoader: Implement source map support for package files.

Interesting, that seems like a bug. Possibly configuration related.

Wed, Oct 16, 4:27 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle added a comment to T235667: ResourceLoader: Implement source map support for package files.

Raw files in debug mode don't get a version param [..]

Wed, Oct 16, 4:13 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle added a comment to T235338: "Currently active MediaWiki versions:" broken on noc/conf.

I thought maybe it was user-permission or working-directory related. But, looks like not.. As www-data and from a different directory, it also works fine via CLI:

Wed, Oct 16, 3:26 PM · User-jijiki, serviceops, Operations, Release-Engineering-Team, Scap, Wikimedia-General-or-Unknown
Krinkle updated the task description for T226044: Prepare Phame to support heavy traffic for a Tech Department blog.
Wed, Oct 16, 1:53 AM · Release-Engineering-Team-TODO, User-greg, Release-Engineering-Team (Development services), Operations, Traffic, Phabricator
Krinkle added a comment to T87796: Add includes/filebackend/README as generated documentation page.

I fiddled around a bit and found something that might work. First, the outcome:

Wed, Oct 16, 12:48 AM · Patch-For-Review, MediaWiki-File-management, Documentation, MediaWiki-Documentation
Restricted Application updated subscribers of T208180: "Related articles" appears too late and displaces footer links (FOUC; content jump).
Wed, Oct 16, 12:36 AM · Performance-Team (Radar), Readers-Web-Backlog (Design), MinervaNeue
Krinkle added a comment to T217616: Ordered lists per default receive `decimal` list style type, which causes issues in non-arabic numeral scripts.

@Jdlrobson Can you clarify what problem this is meant to solve? The example link works as expected in Vector, by having 5 lines of CSS instead of 1. Not a huge cost, but I guess the intent is to reduce this somehow. The proposed core involves `1 line of CSS instead of 5, however it doesn't solve the same problem.

Wed, Oct 16, 12:24 AM · Performance-Team, MediaWiki-ResourceLoader, Front-end-Standards-Group, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization-Kanban, UI-Standardization, Regression, I18n, MinervaNeue
Krinkle added a project to T217616: Ordered lists per default receive `decimal` list style type, which causes issues in non-arabic numeral scripts: MediaWiki-ResourceLoader.
Wed, Oct 16, 12:13 AM · Performance-Team, MediaWiki-ResourceLoader, Front-end-Standards-Group, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization-Kanban, UI-Standardization, Regression, I18n, MinervaNeue

Tue, Oct 15

Krinkle moved T223602: Define variant Wikimedia production config in compiled, static files from Backlog: Future Goals to Next In This Quarter on the Performance-Team board.

Review of overall approach on using YAML perf restrictions/flexibilities (e.g. what should def be cached, and what would be fine to do at run-time) now pencilled in for Q3, maybe Q2. Not expecting to involve TechCom or CPT right now, but depending on how ambitious we want to me, might make sense to involve or or both at some point, but hoping right now to keep it isolated enough to not be cross-cutting

Tue, Oct 15, 9:38 PM · Release-Engineering-Team-TODO (201910), Core Platform Team, Scap, Performance-Team, Patch-For-Review, Release-Engineering-Team (Pipeline), Epic, serviceops, Continuous-Integration-Config
Krinkle removed a project from T231366: Remove ProfilerOutputDb feature from MediaWiki core: MW-1.34-release.
Tue, Oct 15, 9:25 PM · MW-1.34-notes, MW-1.35-release, Core Platform Team Workboards (Clinic Duty Team), Performance-Team, MediaWiki-Debug-Logger
Krinkle moved T235455: Resolve arclamp disk exhaustion problem (Oct 2019) from Inbox to Doing on the Performance-Team board.
Tue, Oct 15, 9:24 PM · Patch-For-Review, serviceops, Performance-Team, Arc-Lamp
Krinkle claimed T235455: Resolve arclamp disk exhaustion problem (Oct 2019).

Short-term decision based on today's meeting: Temporarily reduce retention from 90 days to 45 days. Hopefully only for a few weeks.

Tue, Oct 15, 9:24 PM · Patch-For-Review, serviceops, Performance-Team, Arc-Lamp