Krinkle (Timo Tijhof)
Wikimedia Foundation

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.
User Since
Oct 7 2014, 4:41 AM (123 w, 6 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Sat, Feb 18

Krinkle added a comment to T135420: Determine cause of intermittent WebPageTest "error code 99999".

Batch test URLs/scripts from ./scripts/batch/login-desktop.txt
..
Add job to the WebPageTest server [us-east-1:Firefox 5 time(s)] for ./scripts/wptscripts/login-desktop-enwiki-facebook.txt
..
Tested URL https://en.wikipedia.org/wiki/Facebook for us-east-1:Firefox with connectivity Cable result: http://wpt.wmftest.org/results.php?test=170218_YN_15&medianRun=fastest&medianMetric=SpeedIndex
..
Tested using Firefox 51.0.0.6227
..
Failing test: We got error code 99999 for URL https://en.wikipedia.org/wiki/Facebook result http://wpt.wmftest.org/results.php?test=170218_YN_15

Sat, Feb 18, 2:08 AM · Upstream, Performance-Team, WebPageTest
Krinkle added a comment to T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago.

Reminder: Cherry-pick on Monday or Tuesday to all wikis and then run a script for each wiki to clear the module_deps tables.

Sat, Feb 18, 2:00 AM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle closed T157835: Create QUnit tests for NavigationTiming extension as "Resolved".
Sat, Feb 18, 1:59 AM · Continuous-Integration-Config, Performance-Team, MediaWiki-extensions-NavigationTiming

Fri, Feb 17

Krinkle assigned T157210: Gadget dependencies sometimes don't update to aaron.
Fri, Feb 17, 10:52 PM · Performance-Team, MediaWiki-Cache, Gadgets
Krinkle closed T153819: Fix mediaWikiLoadComplete accuracy as "Resolved".

No significant impact on graphs for mediaWikiLoadComplete. Compared with timeShift(-7d) and movingAverage(30min). 1.29.0-wmf.12 was deployed to all wikis between 7PM and 10PM on Thursday, 16 February.

Fri, Feb 17, 10:50 PM · MediaWiki-ResourceLoader, MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle created T158376: Unexpected general module 'ext.math.scripts' in styles queue..
Fri, Feb 17, 1:02 AM · Patch-For-Review, Math, Technical-Debt
Krinkle edited Description on Performance-Team.
Fri, Feb 17, 12:16 AM
Krinkle archived Performance-Metrics.
Fri, Feb 17, 12:15 AM
Krinkle removed projects from T115597: Measure edit intent → edit interaction and edit interaction → edit end: Performance-Metrics, Performance-Team.
Fri, Feb 17, 12:15 AM · Editing-Department
Krinkle removed a project from T115598: Track count of task abandonment / completion in MediaWiki: Performance-Team.
Fri, Feb 17, 12:15 AM · Editing-Department
Krinkle removed a project from T115598: Track count of task abandonment / completion in MediaWiki: Performance-Metrics.
Fri, Feb 17, 12:14 AM · Editing-Department
Krinkle removed a project from T115606: Measure time to first possible smooth scroll: Performance-Metrics.
Fri, Feb 17, 12:14 AM · Performance-Team
Krinkle removed a project from T131253: Report ok / broken metrics from service_checker: Performance-Metrics.
Fri, Feb 17, 12:14 AM · Monitoring, Services
Krinkle removed a project from T154017: compile number of http uses for http://www.wikidata.org/entity : Performance-Metrics.
Fri, Feb 17, 12:14 AM · Discovery, Operations, HTTPS, Traffic, Wikidata, Wikidata-Query-Service
Krinkle added a subtask for T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles: T42284: The CSS of each gadget is included two times.
Fri, Feb 17, 12:13 AM · Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a parent task for T42284: The CSS of each gadget is included two times: T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles.
Fri, Feb 17, 12:13 AM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets
Krinkle added a subtask for T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles: T87871: Loading with addModuleStyles() should set module state to "ready".
Fri, Feb 17, 12:12 AM · Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a parent task for T87871: Loading with addModuleStyles() should set module state to "ready": T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles.
Fri, Feb 17, 12:12 AM · WMF-deploy-2016-08-23_(1.28.0-wmf.16), MW-1.28-release-notes, WMF-deploy-2016-08-16_(1.28.0-wmf.15), Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle removed a parent task for T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles: T87871: Loading with addModuleStyles() should set module state to "ready".
Fri, Feb 17, 12:12 AM · Performance-Team-notice, Performance-Team, MediaWiki-ResourceLoader
Krinkle removed a subtask for T87871: Loading with addModuleStyles() should set module state to "ready": T92459: ResourceLoader should restrict addModuleStyles() to modules that only provide styles.
Fri, Feb 17, 12:12 AM · WMF-deploy-2016-08-23_(1.28.0-wmf.16), MW-1.28-release-notes, WMF-deploy-2016-08-16_(1.28.0-wmf.15), Performance-Team, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle closed T42284: The CSS of each gadget is included two times as "Resolved".
Fri, Feb 17, 12:10 AM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets

Thu, Feb 16

Quiddity awarded T42284: The CSS of each gadget is included two times a Love token.
Thu, Feb 16, 9:39 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets
Krinkle added a comment to T156922: Prepare a reasonably performant warmup tool for MediaWiki caches (memcached/apc).

Next steps:

  • Put node-warmup script in puppet.
  • Have it ensured on at least one host in eqiad and one in codfw.
    • Decide where to host this. I'm proposing terbium/wasat (maintenance script hosts).
    • We'll also need to ensure nodejs is installed on these hosts (no dependencies, just core nodejs v4 or later).
Thu, Feb 16, 6:20 PM · Performance-Team, DC-Switchover-Prep-Q3-2016-17, Epic, Wikimedia-Multiple-active-datacenters, Operations

Wed, Feb 15

Krinkle renamed T158127: Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in ChronologyProtector.php from "Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in /srv/mediawiki/php-1.29.0-wmf.12/includes/libs/rdbms/ChronologyProtector.php on line 124" to "Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in ChronologyProtector.php".
Wed, Feb 15, 9:55 PM · WMF-deploy-2017-02-07_(1.29.0-wmf.11), WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Performance-Team, MediaWiki-Database, Wikimedia-log-errors
Krinkle added a comment to T42284: The CSS of each gadget is included two times.

Draft message for Tech News (User-notice):

Wed, Feb 15, 9:48 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets
Krinkle moved T42284: The CSS of each gadget is included two times from Not ready to announce to Announce in next Tech/News on the User-notice board.
Wed, Feb 15, 9:47 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets
Krinkle added a comment to T42284: The CSS of each gadget is included two times.

probably not (but it looks weird at first).

Here's a sketch: https://gerrit.wikimedia.org/r/322234. Let me know what you think.

Wed, Feb 15, 9:25 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), Patch-For-Review, User-notice, Gadgets
Krinkle moved T121144: Add detection for unused @embed data uris in mw.loader.inspect from Backlog to Next-up on the Performance-Team board.
Wed, Feb 15, 8:53 PM · PerformanceInspector, Performance-Team
Krinkle moved T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago from Accepted: Bugs to Assigned on the MediaWiki-ResourceLoader board.
Wed, Feb 15, 8:52 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle moved T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago from Inbox to Accepted: Bugs on the MediaWiki-ResourceLoader board.
Wed, Feb 15, 8:52 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle triaged T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago as "Low" priority.
Wed, Feb 15, 8:52 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle closed T140675: Log modules enqueued with invalid module target as "Resolved".
Wed, Feb 15, 8:29 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Performance-Team, Front-end-Standards-Group, Reading-Web-Backlog, MediaWiki-ResourceLoader
Krinkle closed T140675: Log modules enqueued with invalid module target, a subtask of T127268: Dismantle ResourceLoader's "targets" system, as "Resolved".
Wed, Feb 15, 8:29 PM · Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Reading-Web-Backlog, MediaWiki-ResourceLoader
Krinkle moved T156922: Prepare a reasonably performant warmup tool for MediaWiki caches (memcached/apc) from Doing to Backlog on the Performance-Team board.
Wed, Feb 15, 8:29 PM · Performance-Team, DC-Switchover-Prep-Q3-2016-17, Epic, Wikimedia-Multiple-active-datacenters, Operations
Krinkle claimed T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago.
Wed, Feb 15, 8:28 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle assigned T158217: Fatal error: Call to undefined method __PHP_Incomplete_Class::asOfTime() in /srv/mediawiki/php-1.29.0-wmf.11/includes/libs/rdbms/ChronologyProtector.php on line 327 to aaron.
Wed, Feb 15, 8:28 PM · MW-1.29-release-notes, WMF-deploy-2017-02-21_(1.29.0-wmf.13), WMF-deploy-2017-02-14_(1.29.0-wmf.12), Patch-For-Review, MediaWiki-Database, Performance-Team, Wikimedia-log-errors

Tue, Feb 14

Krinkle removed projects from T153819: Fix mediaWikiLoadComplete accuracy: WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review.
Tue, Feb 14, 10:12 PM · MediaWiki-ResourceLoader, MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle added a comment to T153819: Fix mediaWikiLoadComplete accuracy.

Keeping this open until the end of the week to see if we observe any notable changes in the metric measures.

Tue, Feb 14, 10:12 PM · MediaWiki-ResourceLoader, MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle added a project to T157831: Fatal error: Call to undefined method __PHP_Incomplete_Class::hasReached() in /srv/mediawiki/php-master/includes/libs/rdbms/loadbalancer/LoadBalancer.php on line 494: Performance-Team.
Tue, Feb 14, 10:11 PM · Performance-Team, MediaWiki-Database
Krinkle assigned T158127: Catchable fatal error: Object of class __PHP_Incomplete_Class could not be converted to string in ChronologyProtector.php to aaron.
Tue, Feb 14, 10:11 PM · WMF-deploy-2017-02-07_(1.29.0-wmf.11), WMF-deploy-2017-02-14_(1.29.0-wmf.12), WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Performance-Team, MediaWiki-Database, Wikimedia-log-errors
Krinkle created T158120: EchoDiscussionParserTest is slow.
Tue, Feb 14, 9:09 PM · Technical-Debt, Collaboration-Team-Triage, Notifications
Krinkle moved T157835: Create QUnit tests for NavigationTiming extension from Inbox to Doing on the Performance-Team board.
Tue, Feb 14, 9:01 PM · Continuous-Integration-Config, Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle added a comment to T156699: Newly parsed/inserted template content should honour parse data (especially style modules).

After saving, the text is styled.

When I try this, I don't see styled text immediately after the save. Unstyled text persists after the save until I reload the page.

Tue, Feb 14, 8:38 PM · VisualEditor-MediaWiki-Templates, VisualEditor, VisualEditor-MediaWiki
Krinkle added a comment to T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago.

The only source of information in ResourceLoaderFileModule::getFileHashes() that does not directly come from a file on disk (or from a compilation cache that is trusted, short-lived, and uses verifiable keys; such as the LESS cache in APC) - is the module_deps table used for caching references to images from a CSS file - which is lazily populated when the module is first requested after a cache miss triggered by the new hash in the startup module.

Tue, Feb 14, 8:25 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle renamed T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago from ""PHP Warning: filemtime(): No such file or directory" from a mobile RL module" to ""PHP Warning: filemtime(): No such file or directory" about files removed over a year ago".
Tue, Feb 14, 8:11 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle edited projects for T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago, added: MediaWiki-ResourceLoader; removed MediaWiki-Interface.
Tue, Feb 14, 8:06 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle added a comment to T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago.

The gif files have not existed since January 2016 (over a year ago; 9080b6f763a). A Wikimedia Git search didn't turn up any results or references.

Tue, Feb 14, 7:54 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle edited projects for T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago, added: MediaWiki-jQuery-Tablesorter, MediaWiki-Interface; removed MobileFrontend.

Added some instrumentation on mwdebug1001 and found the following:

Tue, Feb 14, 7:46 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle created T158105: "PHP Warning: filemtime(): No such file or directory" about files removed over a year ago.
Tue, Feb 14, 7:32 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors
Krinkle awarded T70113: Alert when Zuul/Gearman queue is stalled a Orange Medal token.
Tue, Feb 14, 7:08 PM · Patch-For-Review, Monitoring, Continuous-Integration-Infrastructure
Krinkle awarded T98617: Make page moves patrollable a Orange Medal token.
Tue, Feb 14, 7:06 PM · Patch-For-Review, MediaWiki-Patrolling
Krinkle edited projects for T147667: Gadget CSS overwritten by default skin CSS ("Use a black background with green text" gadget on Monobook broken), added: MediaWiki-ResourceLoader; removed Wikimedia-General-or-Unknown.
Tue, Feb 14, 3:40 AM · MediaWiki-ResourceLoader, Gadgets, Regression
Krinkle closed T147667: Gadget CSS overwritten by default skin CSS ("Use a black background with green text" gadget on Monobook broken) as "Declined".

https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=ext.gadget.Blackskin&only=styles&skin=monobook is ignored as the page uses the default Monobook CSS definitions instead.

This is a regression triggered by T42284#2698823

Tue, Feb 14, 3:40 AM · MediaWiki-ResourceLoader, Gadgets, Regression

Sat, Feb 11

Krinkle edited projects for T104048: Publish AhoCorasick documentation on docs.wikimedia.org, added: Continuous-Integration-Config; removed Patch-For-Review.
Sat, Feb 11, 1:51 AM · Continuous-Integration-Config, AhoCorasick
Krinkle closed T144888: Composer package ? as "Resolved".

Tagged v1.0.0 at current master.

Sat, Feb 11, 1:50 AM · AhoCorasick

Fri, Feb 10

Krinkle triaged T157835: Create QUnit tests for NavigationTiming extension as "Normal" priority.
Fri, Feb 10, 10:41 PM · Continuous-Integration-Config, Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle created T157835: Create QUnit tests for NavigationTiming extension.
Fri, Feb 10, 8:37 PM · Continuous-Integration-Config, Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle added a comment to T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory.

The upload directory is actually exposed to the web as (wiki1|wiki2).example.org/images. Depending on the host, one of the two source directories is aliased by Apache (e.g. Alias /images /var/www/wiki1/images)

Fri, Feb 10, 12:12 AM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle moved T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory from Backlog to Accepted: Bugs on the MediaWiki-ResourceLoader board.
Fri, Feb 10, 12:03 AM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader

Thu, Feb 9

Krinkle added a comment to T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory.

I'm aware of 1., though these wikis have been running for almost a decade without any trouble.
I don't quite understand the second point though. Do you mean that having $wgUploadPath set to e.g. {$wgScriptPath}/images-wiki1/ and {$wgScriptPath}/images-wiki2/ respectively would help here, because the path is no longer named images/?

Thu, Feb 9, 11:46 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle added a comment to T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory.

I observed the variable values at the end of LocalSettings.php. Would that be the correct point or is it too early?
$wgResourceBasePath and $wgScript are empty, $wgLogo is /images/logo.png (as can be deducted from the provided example config - $wgScriptPath is empty as I run the wiki at the root directory of the domain).

Thu, Feb 9, 10:52 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle added a comment to T127903: Projects should have an "Open Tasks" view by default.

A recent Phabricator upgrade changed the "Manage project" to have an easy way to add a link to "Open Tasks". While this is a step in the right direction, it seems flawed in two ways:

  • It defaults to grouping and sorting by priority, which is not very useful (should probably default to no grouping and sorting by creation date or last updated or some such).
  • The link destination can't be changed (its edit page is blank).
Thu, Feb 9, 10:31 PM · Phabricator, Developer-Wishlist (2017)
Krinkle set the image for MediaWiki-extensions-LdapAuthentication to F5577949: fa-briefcase-blue.png.
Thu, Feb 9, 10:28 PM
Krinkle removed a project from T157293: LDAP Authentication updating tables on load.php entry point: MediaWiki-ResourceLoader.

The trigger is wfSetupFormMailer , which isn't defined anywhere in Wikimedia Git.
https://www.mediawiki.org/wiki/Extension:FormMailer

Thu, Feb 9, 10:26 PM · MediaWiki-extensions-LdapAuthentication
Krinkle renamed T149837: Consider using 'Cache-Control: immutable' in versioned load.php response from "Use 'Cache-Control: immutable' in versioned load.php response" to "Consider using 'Cache-Control: immutable' in versioned load.php response".
Thu, Feb 9, 10:22 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T149837: Consider using 'Cache-Control: immutable' in versioned load.php response from Backlog to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Thu, Feb 9, 10:22 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T152169: URL parameter to temporarily disable user scripts/gadgets from Inbox to Backlog on the MediaWiki-ResourceLoader board.
Thu, Feb 9, 10:22 PM · MediaWiki-ResourceLoader
Krinkle triaged T152169: URL parameter to temporarily disable user scripts/gadgets as "Low" priority.
Thu, Feb 9, 10:22 PM · MediaWiki-ResourceLoader
Krinkle moved T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory from Inbox to Backlog on the MediaWiki-ResourceLoader board.
Thu, Feb 9, 10:22 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle triaged T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory as "Normal" priority.
Thu, Feb 9, 10:21 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle added a comment to T155146: OutputPage::transformFilePath creates wrong path for logo placed in image upload directory.

@Moejoe1337 What are the values of $wgResourceBasePath (default: $wgScript), $wgScript and $wgLogo?

Thu, Feb 9, 10:21 PM · WMF-deploy-2017-02-14_(1.29.0-wmf.12), MW-1.29-release-notes, Patch-For-Review, MediaWiki-ResourceLoader
Krinkle moved T124742: Upgrade to jQuery 3 from Backlog to Assigned on the MediaWiki-ResourceLoader board.
Thu, Feb 9, 10:16 PM · Patch-For-Review, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle moved T153819: Fix mediaWikiLoadComplete accuracy from Inbox to Assigned on the MediaWiki-ResourceLoader board.
Thu, Feb 9, 10:15 PM · MediaWiki-ResourceLoader, MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle added a project to T153819: Fix mediaWikiLoadComplete accuracy: MediaWiki-ResourceLoader.
Thu, Feb 9, 10:15 PM · MediaWiki-ResourceLoader, MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle moved T156760: Update webperf EventLogging consumers for userAgent schema change from Inbox to Next-up on the Performance-Team board.
Thu, Feb 9, 7:36 PM · Patch-For-Review, Analytics-Kanban, Performance-Team
Krinkle renamed T156760: Update webperf EventLogging consumers for userAgent schema change from "Check if the EventLogging User Agent schema upgrade breaks any performance tool/metric" to "Update webperf EventLogging consumers for userAgent schema change".
Thu, Feb 9, 7:36 PM · Patch-For-Review, Analytics-Kanban, Performance-Team
Krinkle added a comment to T156760: Update webperf EventLogging consumers for userAgent schema change.

@Nuria Okay, makes sense! I assumed the DB consumer would automatically store those as separate columns (e.g. "obj_subkey" or "obj.subkey") or as JSON-string in a single column. I'm glad this restriction is on the way out, and I suppose we'll migrate to an object sometime after.

Thu, Feb 9, 7:35 PM · Patch-For-Review, Analytics-Kanban, Performance-Team
Krinkle added a comment to T127328: Optimise critical rendering path.

Following a conversation with @Peter today, I believe it may be worth reconsidering whether we actually want to create a disparate "critical styles" concept in ResourceLoader.

Thu, Feb 9, 2:33 AM · Goal, Performance, MW-1.27-release-notes, Performance-Team
Krinkle edited the description of T120984: Evaluate alternatives for @embed.
Thu, Feb 9, 2:24 AM · Performance-Team, MediaWiki-ResourceLoader

Wed, Feb 8

Krinkle moved T156922: Prepare a reasonably performant warmup tool for MediaWiki caches (memcached/apc) from Next-up to Doing on the Performance-Team board.
Wed, Feb 8, 8:12 PM · Performance-Team, DC-Switchover-Prep-Q3-2016-17, Epic, Wikimedia-Multiple-active-datacenters, Operations
Krinkle removed a project from T124742: Upgrade to jQuery 3: Patch-For-Review.
Wed, Feb 8, 7:50 PM · Patch-For-Review, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle moved T121646: Provide featureful Local Storage abstraction in MediaWiki core from Backlog to Accepted on the Front-end-Standards-Group board.
Wed, Feb 8, 7:20 PM · MediaWiki-General-or-Unknown, Performance-Team, Front-end-Standards-Group
Krinkle moved T140675: Log modules enqueued with invalid module target from Backlog to Needs code review on the Front-end-Standards-Group board.
Wed, Feb 8, 7:20 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Performance-Team, Front-end-Standards-Group, Reading-Web-Backlog, MediaWiki-ResourceLoader
Krinkle placed T113916: Redesign ResourceLoader's file dependency tracking (module_deps) up for grabs.
Wed, Feb 8, 6:08 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T140675: Log modules enqueued with invalid module target from Next-up to Doing on the Performance-Team board.
Wed, Feb 8, 6:04 PM · WMF-deploy-2017-02-21_(1.29.0-wmf.13), MW-1.29-release-notes, Performance-Team, Front-end-Standards-Group, Reading-Web-Backlog, MediaWiki-ResourceLoader
Krinkle removed projects from T121646: Provide featureful Local Storage abstraction in MediaWiki core: WMF-deploy-2016-12-06_(1.29.0-wmf.5), MW-1.29-release-notes.
Wed, Feb 8, 5:37 PM · MediaWiki-General-or-Unknown, Performance-Team, Front-end-Standards-Group
Krinkle edited the description of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision).
Wed, Feb 8, 5:36 PM · Commons, Multimedia, Schema-change, MediaWiki-File-management
Krinkle edited the description of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision).
Wed, Feb 8, 5:36 PM · Commons, Multimedia, Schema-change, MediaWiki-File-management
Krinkle added a comment to T589: RFC: image and oldimage tables.

With this RFC resolved, the implementation may proceed (filed as T28741).

Wed, Feb 8, 5:35 PM · ArchCom-RfC (ArchCom-Approved), ArchCom-Has-shepherd, RfC
Krinkle renamed T589: RFC: image and oldimage tables from "Schema change: image and oldimage tables" to "RFC: image and oldimage tables".
Wed, Feb 8, 5:34 PM · ArchCom-RfC (ArchCom-Approved), ArchCom-Has-shepherd, RfC
Krinkle closed T589: RFC: image and oldimage tables, a subtask of T17441: Some tables lack unique or primary keys, may allow confusing duplicate data, as "Resolved".
Wed, Feb 8, 5:34 PM · PostgreSQL, Patch-For-Review, DBA, Schema-change, MediaWiki-Database
Krinkle closed T589: RFC: image and oldimage tables, a subtask of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision), as "Resolved".
Wed, Feb 8, 5:34 PM · Commons, Multimedia, Schema-change, MediaWiki-File-management
Krinkle renamed T589: RFC: image and oldimage tables from "RfC: image and oldimage tables" to "Schema change: image and oldimage tables".
Wed, Feb 8, 5:34 PM · ArchCom-RfC (ArchCom-Approved), ArchCom-Has-shepherd, RfC
Krinkle reopened T589: RFC: image and oldimage tables, a subtask of T17441: Some tables lack unique or primary keys, may allow confusing duplicate data, as "Open".
Wed, Feb 8, 5:34 PM · PostgreSQL, Patch-For-Review, DBA, Schema-change, MediaWiki-Database
Krinkle reopened T589: RFC: image and oldimage tables, a subtask of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision), as "Open".
Wed, Feb 8, 5:34 PM · Commons, Multimedia, Schema-change, MediaWiki-File-management
Krinkle closed T589: RFC: image and oldimage tables as "Resolved".
Wed, Feb 8, 5:32 PM · ArchCom-RfC (ArchCom-Approved), ArchCom-Has-shepherd, RfC
Krinkle closed T589: RFC: image and oldimage tables, a subtask of T17441: Some tables lack unique or primary keys, may allow confusing duplicate data, as "Resolved".
Wed, Feb 8, 5:32 PM · PostgreSQL, Patch-For-Review, DBA, Schema-change, MediaWiki-Database
Krinkle closed T589: RFC: image and oldimage tables, a subtask of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision), as "Resolved".
Wed, Feb 8, 5:32 PM · Commons, Multimedia, Schema-change, MediaWiki-File-management

Tue, Feb 7

Krinkle added a comment to T156760: Update webperf EventLogging consumers for userAgent schema change.

Why keep it as a string, though?

It is a breaking change, not disputing that. Keeping it as a string makes things simple for the database consumer

Tue, Feb 7, 2:04 AM · Patch-For-Review, Analytics-Kanban, Performance-Team

Mon, Feb 6

Krinkle closed T105208: Undebianify morebots as "Declined".

Per T156929, Adminbot has been transitioned to Stashbot. Stashbot doesn't have a Debian package afaik.

Mon, Feb 6, 11:49 PM · Stashbot