Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (WMF Performance Team)Administrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (403 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

Blog: https://timotijhof.net
Fediverse: @krinkle@mastodon.technology

(Photo by Niek Hidding.)

Recent Activity

Yesterday

Krinkle added a comment to T311788: MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off).

[…]

With the above information, and the knowledge that "turning off live opcache revalidation" means setting revalidate_freq = 0, it becomes logical then that we are now computing and storing indefinitely, an outdated version of the config right after a sync.

Thu, Jun 30, 11:44 PM · serviceops, Performance-Team, Scap
Krinkle added a comment to T311788: MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off).

Okay, let's consider the following timeline for a typical config change as it was prior to last week. This means prior to doing php restarts and prior to turning off live opcache revalidation.

Thu, Jun 30, 11:42 PM · serviceops, Performance-Team, Scap
Krinkle claimed T311788: MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off).
Thu, Jun 30, 11:42 PM · serviceops, Performance-Team, Scap
Krinkle renamed T311788: MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off) from MW wmf-config tmp cache stays outdated after Scap deploy to MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off).
Thu, Jun 30, 11:41 PM · serviceops, Performance-Team, Scap
Krinkle renamed T311788: MW wmf-config tmp cache stays outdated after Scap deploy (opcache revalidation is off) from scap does not fully deploy MW code in some cases to MW wmf-config tmp cache stays outdated after Scap deploy.
Thu, Jun 30, 11:40 PM · serviceops, Performance-Team, Scap
Krinkle closed T245183: PHP7 corruption reports in 2020-2022 (Call on wrong object, etc.) as Resolved.

Any remaining "smells like opcache" problems we see can't be the cause of php-opcache revalidation mode since that mode is now disabled on production web servers as per T266055 and T253673.

Thu, Jun 30, 8:33 PM · Wikimedia-production-error, serviceops, SRE
Krinkle renamed T254209: Spike of impossible "Cannot declare class" fatal errors from Brief spikes of fatals "Cannot declare class" to Spike of impossible "Cannot declare class" fatal errors.
Thu, Jun 30, 8:31 PM · serviceops, Wikimedia-production-error
Krinkle attached a referenced file: F35290931: Screenshot 2022-06-30 at 13.12.53.png.
Thu, Jun 30, 8:31 PM · serviceops, Wikimedia-production-error
Krinkle added a comment to T254209: Spike of impossible "Cannot declare class" fatal errors.

It's not an opcache revalidation issue afaik. For two reasons.

Thu, Jun 30, 8:30 PM · serviceops, Wikimedia-production-error
Krinkle renamed T254209: Spike of impossible "Cannot declare class" fatal errors from Spike of fatal error "Cannot declare class Wikimedia\MWConfig" on mw1379 (2020-06-01) to Brief spikes of fatals "Cannot declare class".
Thu, Jun 30, 8:29 PM · serviceops, Wikimedia-production-error
Krinkle merged task T311731: Cannot declare class Wikimedia\MWConfig\Profiler, because the name is already in use in Profiler.php into T254209: Spike of impossible "Cannot declare class" fatal errors.
Thu, Jun 30, 8:28 PM · Parsoid, Wikimedia-production-error
Krinkle added a comment to T254209: Spike of impossible "Cannot declare class" fatal errors.

It's not an opcache revalidation issue afaik. For two reasons.

Thu, Jun 30, 8:28 PM · serviceops, Wikimedia-production-error
Krinkle merged T311731: Cannot declare class Wikimedia\MWConfig\Profiler, because the name is already in use in Profiler.php into T254209: Spike of impossible "Cannot declare class" fatal errors.
Thu, Jun 30, 8:28 PM · serviceops, Wikimedia-production-error
Krinkle reopened T254209: Spike of impossible "Cannot declare class" fatal errors as "Open".
Thu, Jun 30, 8:27 PM · serviceops, Wikimedia-production-error
Krinkle reopened T311731: Cannot declare class Wikimedia\MWConfig\Profiler, because the name is already in use in Profiler.php as "Open".
Thu, Jun 30, 8:26 PM · Parsoid, Wikimedia-production-error
Krinkle updated the task description for T311682: Publish June 2022 dataset to performance.wikimedia.org.
Thu, Jun 30, 4:11 AM · good first task, Performance-Team
Krinkle renamed T311680: Get performance/asoranking upto snuff from Add performance/asoranking to Codesearch to Get performance/asoranking upto snuff.
Thu, Jun 30, 4:11 AM · Developer Productivity, VPS-project-Codesearch, Performance-Team
Krinkle added a hashtag to Performance-Team: #asoranking.
Thu, Jun 30, 4:05 AM
Krinkle assigned T311565: Deprecated: Automatic conversion of false to array is deprecated in Hooks.php on line 56 to Reedy.

Source: https://gerrit.wikimedia.org/g/mediawiki/extensions/PageViewInfo/+/235b0d2343e06c33b65e73782db71e9cf252814c/includes/Hooks.php#56

Thu, Jun 30, 4:02 AM · Patch-For-Review, Performance-Team, PHP 8.1 support, PageViewInfo
Krinkle updated the task description for T311565: Deprecated: Automatic conversion of false to array is deprecated in Hooks.php on line 56.
Thu, Jun 30, 4:00 AM · Patch-For-Review, Performance-Team, PHP 8.1 support, PageViewInfo
Krinkle created T311682: Publish June 2022 dataset to performance.wikimedia.org.
Thu, Jun 30, 3:56 AM · good first task, Performance-Team
Krinkle added a project to T311680: Get performance/asoranking upto snuff: Developer Productivity.
Thu, Jun 30, 12:44 AM · Developer Productivity, VPS-project-Codesearch, Performance-Team
Krinkle created T311680: Get performance/asoranking upto snuff.
Thu, Jun 30, 12:44 AM · Developer Productivity, VPS-project-Codesearch, Performance-Team

Wed, Jun 29

Esanders awarded T289957: SonarQube is unhelpfully suggesting ES6 features in ES5 code a Like token.
Wed, Jun 29, 10:46 AM · Quality-and-Test-Engineering-Team (QTE), Developer Productivity, Continuous-Integration-Config, Sonarqubebot
Krinkle committed rEPIa7a022d281fd: CachedPageViewService: Ensure $prefix is a string (authored by Krinkle).
CachedPageViewService: Ensure $prefix is a string
Wed, Jun 29, 1:27 AM
Krinkle added a comment to T311566: Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in MemcachedBagOStuff.php on line 68.
		foreach ( $titles as $title ) {
			$titleToCacheKey[$title->getPrefixedDBkey()] = $this->cache->makeKey( 'pvi', $this->prefix,
				$this->cachedDays, $metric, self::SCOPE_ARTICLE, md5( $title->getPrefixedDBkey() ) );
		}

$this->prefix is null...

Do we want to just swap it to $this->prefix ?? '' or do we need to fix where it's being set? […]

Wed, Jun 29, 12:55 AM · Patch-For-Review, MW-1.38-release, MW-1.37-release, MW-1.35-release, PageViewInfo, PHP 8.1 support
Krinkle updated the task description for T311566: Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in MemcachedBagOStuff.php on line 68.
Wed, Jun 29, 12:50 AM · Patch-For-Review, MW-1.38-release, MW-1.37-release, MW-1.35-release, PageViewInfo, PHP 8.1 support
Krinkle triaged T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js as High priority.

Shall we also add a site dependency to the user module?

Wed, Jun 29, 12:12 AM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript
Krinkle added a comment to T311564: Content sub unreadable in Vector 22.

The sub is hardcoded to 2px height for some reason, so this seems unconditional on presence of indicators. The linked examples don't have indicators, and in one case is a redlink page that doesn't even exist and is also affected.

Wed, Jun 29, 12:07 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Regression, Vector

Tue, Jun 28

Krinkle updated the task description for T311564: Content sub unreadable in Vector 22.
Tue, Jun 28, 10:34 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Regression, Vector
Krinkle created T311564: Content sub unreadable in Vector 22.
Tue, Jun 28, 10:31 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Regression, Vector
Krinkle closed T311367: Implicit conversion from float 11.139 to int loses precision in APCUBagOStuff.php on line 91 as Resolved.
Tue, Jun 28, 9:52 PM · MediaWiki-extensions-Gadgets, PHP 8.1 support, MediaWiki-libs-ObjectCache, Performance-Team
Krinkle closed T311191: Add `mediawiki.special.import` to `mediawiki.misc-authed-ooui` as Resolved.
Tue, Jun 28, 7:14 PM · Performance-Team (Radar), MediaWiki-Core-Snapshots, User-DannyS712
Krinkle updated subscribers of T311473: TypeError: Argument 3 passed to MediaWiki\Page\PageCommandFactory::newRollbackPage() with rollbackEdits.php.

Seems likely a regression from the Page Command refactor. \cc @Simetrical @daniel

Tue, Jun 28, 6:25 AM · MW-1.37-release, MW-1.38-release, MediaWiki-Core-Revision-backend
Krinkle added projects to T311473: TypeError: Argument 3 passed to MediaWiki\Page\PageCommandFactory::newRollbackPage() with rollbackEdits.php: MediaWiki-Core-Revision-backend, MW-1.38-release.
Tue, Jun 28, 6:24 AM · MW-1.37-release, MW-1.38-release, MediaWiki-Core-Revision-backend
Krinkle moved T311194: Remove unused module `jquery.hoverIntent` from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Jun 28, 4:27 AM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712
Krinkle triaged T311194: Remove unused module `jquery.hoverIntent` as Medium priority.
Tue, Jun 28, 4:27 AM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712
Krinkle edited projects for T311194: Remove unused module `jquery.hoverIntent`, added: Performance-Team (Radar); removed Performance-Team.
Tue, Jun 28, 4:27 AM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712
Krinkle added a comment to T311194: Remove unused module `jquery.hoverIntent`.

@DannyS712 Thanks. I propose the following:

Tue, Jun 28, 4:26 AM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712

Mon, Jun 27

Krinkle triaged T311090: Warn about changing DBO_TRX via DBConnRef as Medium priority.
Mon, Jun 27, 8:04 PM · Wikimedia-Rdbms, Performance-Team
Krinkle moved T311090: Warn about changing DBO_TRX via DBConnRef from Untriaged to Rdbms library on the Wikimedia-Rdbms board.

Was this connected to a recent incident, or just a general defense in-depth idea?

Mon, Jun 27, 6:27 PM · Wikimedia-Rdbms, Performance-Team
Krinkle moved T311090: Warn about changing DBO_TRX via DBConnRef from Inbox to Backlog: Maintenance on the Performance-Team board.
Mon, Jun 27, 6:27 PM · Wikimedia-Rdbms, Performance-Team
Krinkle moved T308798: Error: Unknown widget type: id: namespace, class: mw.widgets.NamespaceInputWidget from Inbox to Doing: Prio Interrupt on the Performance-Team board.
Mon, Jun 27, 6:25 PM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
Krinkle claimed T308798: Error: Unknown widget type: id: namespace, class: mw.widgets.NamespaceInputWidget.
Mon, Jun 27, 6:25 PM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
Krinkle moved T311120: Performance review for new Metrics Platform PHP library from Inbox to Doing: Prio Interrupt on the Performance-Team board.
Mon, Jun 27, 6:24 PM · Performance-Team, Metrics-Platform
Krinkle claimed T311120: Performance review for new Metrics Platform PHP library.
Mon, Jun 27, 6:23 PM · Performance-Team, Metrics-Platform
Krinkle renamed T309656: Performance review for new Metrics Plaform JS library from Performance review for new Metrics Plaform library to Performance review for new Metrics Plaform JS library.
Mon, Jun 27, 6:23 PM · Performance-Team, Product-Data-Infrastructure, Metrics-Platform
Krinkle added a comment to T311079: Deploy GDI Safety Survey Wave 2 on EN, ES, FA, FR, and PT wikis - BETA.

This is good to go from perf perspective, we did an analysis just last week (ref T311015). Please let us know if there are major differences (e.g. custom UI, or no sampling) but otherwise good to go.

Mon, Jun 27, 6:23 PM · Performance-Team, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
Krinkle edited projects for T311194: Remove unused module `jquery.hoverIntent`, added: MediaWiki-ResourceLoader; removed MediaWiki-Interface.
Mon, Jun 27, 6:20 PM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712
Krinkle moved T311367: Implicit conversion from float 11.139 to int loses precision in APCUBagOStuff.php on line 91 from Inbox to Backlog: Maintenance on the Performance-Team board.
Mon, Jun 27, 6:16 PM · MediaWiki-extensions-Gadgets, PHP 8.1 support, MediaWiki-libs-ObjectCache, Performance-Team
Krinkle added a comment to T311194: Remove unused module `jquery.hoverIntent`.

There is on-wiki use however, so we should at least allow for some migration and possibly deprecation.

Mon, Jun 27, 6:15 PM · Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, Patch-For-Review, User-DannyS712
Krinkle moved T311191: Add `mediawiki.special.import` to `mediawiki.misc-authed-ooui` from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Mon, Jun 27, 6:12 PM · Performance-Team (Radar), MediaWiki-Core-Snapshots, User-DannyS712
Krinkle edited projects for T311191: Add `mediawiki.special.import` to `mediawiki.misc-authed-ooui`, added: MediaWiki-Core-Snapshots, Performance-Team (Radar); removed MediaWiki-General, Performance-Team.
Mon, Jun 27, 6:12 PM · Performance-Team (Radar), MediaWiki-Core-Snapshots, User-DannyS712
Krinkle moved T311192: Add module bundle `mediawiki.misc-authed-non-ooui` from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Mon, Jun 27, 6:11 PM · Performance-Team (Radar), Patch-For-Review, MediaWiki-Watchlist, MediaWiki-Revision-deletion, User-DannyS712, Growth-Team
Krinkle edited projects for T311192: Add module bundle `mediawiki.misc-authed-non-ooui`, added: Performance-Team (Radar); removed Performance-Team.
Mon, Jun 27, 6:11 PM · Performance-Team (Radar), Patch-For-Review, MediaWiki-Watchlist, MediaWiki-Revision-deletion, User-DannyS712, Growth-Team
Krinkle moved T310241: Migrate QuickSurveys from WVUI to Codex from Limbo to Watching on the Performance-Team (Radar) board.
Mon, Jun 27, 5:20 PM · Performance-Team (Radar), Patch-For-Review, QuickSurveys
Krinkle added a project to T310241: Migrate QuickSurveys from WVUI to Codex: Performance-Team (Radar).
Mon, Jun 27, 5:20 PM · Performance-Team (Radar), Patch-For-Review, QuickSurveys
Krinkle added a comment to T310241: Migrate QuickSurveys from WVUI to Codex.

The folllowing is from a routine perf analysis of a running survey. Perhaps some of it is of use here:

Mon, Jun 27, 5:20 PM · Performance-Team (Radar), Patch-For-Review, QuickSurveys
Krinkle added a comment to T311015: Deploy QuickSurvey on Japanese Wikipedia.

@DDeSouza I apologize if the following is not open to changes, but the former designer in me could not leave unsaid to share a a minor thing about what I noticed in the survey itself.

Mon, Jun 27, 5:16 PM · Design-Research, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikimedia-Site-requests, WikimediaMessages, Patch-For-Review, Performance-Team
Krinkle added a comment to T311015: Deploy QuickSurvey on Japanese Wikipedia.

@DDeSouza I left a suggestion on change 808017. The above perf analysis found a regression (or previously missed issue for QuickSurveys maintainers to evaluate for next time. I do not consider it urgent for your needs.

Mon, Jun 27, 6:38 AM · Design-Research, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikimedia-Site-requests, WikimediaMessages, Patch-For-Review, Performance-Team
Krinkle added a comment to T311015: Deploy QuickSurvey on Japanese Wikipedia.

Notes from comparing these two (logged-out, after 1 warmup and dismissing CentralNotice, Chrome, 3G Fast, CPU unthrottled):

Mon, Jun 27, 6:35 AM · Design-Research, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikimedia-Site-requests, WikimediaMessages, Patch-For-Review, Performance-Team
Krinkle added a comment to T311367: Implicit conversion from float 11.139 to int loses precision in APCUBagOStuff.php on line 91.

Got a stack trace? We could cast it, but it's not obvious from the current interfaces that float is actually meant to be passed here. Depending on where the float came from, it might be a one-off issue in a specific caller.

Mon, Jun 27, 4:17 AM · MediaWiki-extensions-Gadgets, PHP 8.1 support, MediaWiki-libs-ObjectCache, Performance-Team
Krinkle created P30247 bench mediawiki/core change 808106.
Mon, Jun 27, 12:21 AM

Thu, Jun 23

Krinkle awarded T278644: “Preview page with this template” broken with translatable templates a Orange Medal token.
Thu, Jun 23, 4:10 PM · MediaWiki-extensions-TemplateSandbox, MediaWiki-extensions-Translate
Krinkle moved T276720: User::loadFromSession called before the end of Setup.php from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error
Krinkle moved T276825: International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined) from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration, JavaScript, Wikimedia-production-error
Krinkle moved T277229: UserOptionsManager: Argument 1 passed to MediaWiki\User\UserOptionsManager::setOption() must implement interface MediaWiki\User\UserIdentity, null given from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), User-brennen, MobileFrontend, Mobile-Web-Settings, Wikimedia-production-error
Krinkle moved T277332: Uncaught Error: Widget not found / Call to a member function getNsIndex() on null on CirrusSearch result page with internal error from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
Krinkle moved T277689: LanguageKk_cyrl->lastLetter: PHP Notice: Undefined offset: -1 from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Engineering, ParserFunctions, Wikimedia-production-error
Krinkle moved T277722: TypeError: this._languageCodes is undefined at getLanguageNameMap from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Thu, Jun 23, 4:06 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), wdwb-tech, Wikidata, Wikimedia-production-error, Wikidata-Termbox
Krinkle moved T307295: Bot contributions page in Catalan wikipedia not displayed from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), DBA, Wikimedia-production-error, Slow-DB-Query, MediaWiki-Logevents
Krinkle moved T307513: MediaWiki\Extension\TitleBlacklist\TitleBlacklist::load(): The script tried to execute a method or access a property of an incomplete object. from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, User-brennen, TitleBlacklist, Wikimedia-production-error
Krinkle moved T307552: enwikinews: FlaggedRev hook triggers: Error: Class 'GoogleNewsSitemap' not found from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), MediaWiki-extensions-GoogleNewsSitemap, MediaWiki-extensions-FlaggedRevs, Wikimedia-production-error
Krinkle moved T307586: wbsearchentities produces no results on 1.39.0-wmf.10 from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), User-notice, Discovery-Search, Wikidata, wdwb-tech, Wikimedia-production-error
Krinkle moved T307671: High rate of 5XX errors from maps.wikimedia.org since 2022-05-05 ~03:20 from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · Patch-For-Review, Wikimedia-production-error, Content-Transform-Team, Maps
Krinkle moved T307748: Error: Call to undefined method MediaWiki\User\TempUser\RealTempUserConfig::isEnabled() from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:05 PM · IP Masking, Growth-Team, GrowthExperiments, Wikimedia-production-error
Krinkle updated the task description for T307748: Error: Call to undefined method MediaWiki\User\TempUser\RealTempUserConfig::isEnabled().
Thu, Jun 23, 4:04 PM · IP Masking, Growth-Team, GrowthExperiments, Wikimedia-production-error
Krinkle moved T308626: TypeError: Cannot read properties of undefined (reading 'nodeType') from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:04 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), MediaWiki-HTMLForm, Growth-Team, Wikimedia-production-error
Krinkle moved T308640: Error: Call to undefined method CirrusSearch\Connection::getPageType() from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:04 PM · GeoData, Discovery-Search, Wikimedia-production-error
Krinkle moved T308663: LogicException: This ParserOutput contains no text! from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:04 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Platform Engineering, CommonsMetadata, MediaWiki-Parser, Wikimedia-production-error
Krinkle moved T308691: Fatal exception of type "CannotCreateActorException" when trying to export file from zhwikibooks to commons from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:04 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, WMDE-TechWish-Maintenance, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-05-11, Platform Engineering, Move-Files-To-Commons, Wikimedia-production-error
Krinkle moved T308795: InvalidArgumentException: Missing field: page_restrictions from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:04 PM · Release-Engineering-Team, Growth-Team, Wikimedia-production-error
Krinkle moved T309148: Wikimedia\Rdbms\DBQueryError: Error 1048: Column 'cuc_actor' cannot be nullFunction: MediaWiki\CheckUser\Hooks::updateCheckUserDataQuery: INSERT INTO `cu_changes` (cuc_namespace,cuc_title,cuc_minor,cuc_user,cuc_user_text,cuc_ from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:03 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), CheckUser, Wikimedia-production-error
Krinkle moved T309151: MediaWiki\Revision\RevisionAccessException: Could not determine title for page ID {page_id} and revision ID {rev_id} from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:03 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Data-Persistence (Consultation), Language-Team (Language-2022-April-June), Patch-For-Review, MediaWiki-extensions-Translate, Wikimedia-production-error
Krinkle moved T309460: PHP Notice: Undefined property: stdClass::$page_restrictions from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:03 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, MediaWiki-extensions-LiquidThreads, Wikimedia-production-error
Krinkle moved T309570: quarry is unable to access enwiki_p.page table from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:03 PM · Quarry, Wikimedia-production-error
Krinkle moved T309616: Cross-wiki session loss on Wikimedia wikis from Untriaged to May 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:02 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Wikimedia-production-error, MediaWiki-Authentication-and-authorization
Krinkle moved T309677: Error on Special:SpecialPages: GlobalVarConfig::get: undefined option: 'EnableLocalTimedText' from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:02 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Wikimedia-production-error, TimedMediaHandler
Krinkle moved T309901: TypeError: trim() expects parameter 1 to be string, null given from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:02 PM · Parsoid, Wikimedia-production-error
Krinkle moved T310155: Error: Class 'Wikimedia\MWConfig\Wikimedia\MWConfig\ServiceConfig' not found from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:02 PM · Performance-Team, Arc-Lamp, Wikimedia-production-error
Krinkle moved T310225: mw1415 fatals due to serving responses from 1.39.0-wmf.10 (was DBQueryError: Unknown column page_restrictions) from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:01 PM · serviceops, Deployments, Wikimedia-production-error
Krinkle moved T310440: Attempting to delete a translation page using Special:PageTranslationDeletePage shows an internal error from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:01 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Unplanned-Sprint-Work, Language-Team (Language-2022-April-June), Wikimedia-production-error, MediaWiki-extensions-Translate
Krinkle moved T311037: PHP Notice: Uninitialized string offset: 0 from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 4:01 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), WMDE-TechWish-Sprint-2022-06-08, Unplanned-Sprint-Work, WMDE-TechWish-Maintenance, Maps (Kartographer), Wikimedia-production-error
Krinkle renamed T310673: TypeError: Cannot read properties of undefined reading 'length' (from MwCXInitTranslation) from TypeError: Cannot read properties of undefined (reading 'length') to TypeError: Cannot read properties of undefined reading 'length' (from MwCXInitTranslation).
Thu, Jun 23, 4:00 PM · JavaScript, Wikimedia-production-error, ContentTranslation
Krinkle awarded T310833: Uploaded files via the drag-and-drop are defaulting to private-access a Love token.
Thu, Jun 23, 3:58 PM · Upstream, Phabricator (Upstream), User-brennen, Release-Engineering-Team
Krinkle added a comment to T310809: "MWException: CAS update failed on user_touched" from VisualEditor hook.

@matmarex The issue with this general pattern is the delay between the setOption and saveSettings. Likely there was something else in-between for the same user (possibly something we script that changes a hidden preference), and thus the token is no longer valid by then.

Thu, Jun 23, 3:57 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), User-brennen, VisualEditor, Wikimedia-production-error
Krinkle renamed T310809: "MWException: CAS update failed on user_touched" from VisualEditor hook from "MWException: CAS update failed on user_touched. The version of the user to be saved is older than the current version." from VisualEditor hook to "MWException: CAS update failed on user_touched" from VisualEditor hook.
Thu, Jun 23, 3:50 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), User-brennen, VisualEditor, Wikimedia-production-error
Krinkle moved T310401: [MediaSearch] 'ownKeys' on proxy: trap result did not include 'length' from Untriaged to Jun 2022 on the Wikimedia-production-error board.
Thu, Jun 23, 3:44 PM · Structured-Data-Backlog (Current Work), JavaScript, Patch-For-Review, SDAW-MediaSearch, Wikimedia-production-error
Krinkle added a comment to T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad..

I don't know if this is relevant, but for the past week and a half, every page view has had the following warning in the console:

Thu, Jun 23, 3:25 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Vector
Krinkle triaged T311193: Merge `mediawiki.special.version` styles into `mediawiki.special` bundle as Medium priority.
Thu, Jun 23, 3:44 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Performance-Team (Radar), MediaWiki-Special-pages, User-DannyS712