Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (WMF Performance Team)Administrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (442 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photo by Niek Hidding.)

Recent Activity

Today

Krinkle removed a project from T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal: Patch-For-Review.
Fri, Mar 31, 6:45 AM · Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error

Yesterday

Krinkle committed rEDIS5e2efecc7e9a: build: Updating npm dependencies (authored by Umherirrender).
build: Updating npm dependencies
Thu, Mar 30, 9:30 PM
Krinkle added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

I'm recording here the result of feature testing in older browsers, based on the demo page at https://people.wikimedia.org/~krinkle/T178356.html.

Thu, Mar 30, 1:16 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader

Wed, Mar 29

Krinkle added a project to T331602: Make $wgHooks a regular configuration variable: ci-test-error.

This has caused CI jobs to fail, in for example, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MathSearch/+/902490/ with:

Wed, Mar 29, 10:51 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), ci-test-error, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.40-release, MediaWiki-Core-Hooks
Krinkle added a comment to T332817: Improve awareness of sensitive content in helmfile output.

I don't know the specific context here, but, I want to add that it is possible to wrap a command under the same name. Typically this is done by referencing the full path of the provisioned and executable from another shell PATH entry that has higher more local precedence.

Wed, Mar 29, 10:16 PM · Security, Prod-Kubernetes
Krinkle closed T333276: Add flip for shorthand properties that contain calc() expressions as Resolved.
Wed, Mar 29, 3:24 AM · Performance-Team, CSSJanus
Krinkle reassigned T333276: Add flip for shorthand properties that contain calc() expressions from Krinkle to Mabualruz.
Wed, Mar 29, 3:24 AM · Performance-Team, CSSJanus
Krinkle added a comment to T180121: Provide way to configure or purge cache of VCS data on Special:Version or simply remove caching..

This issue also happens with MediaWiki 1.34 (the lockdown extension still shows the old version number after uploading new files).

Wed, Mar 29, 12:22 AM · Patch-Needs-Improvement, Performance-Team (Radar), MediaWiki-Special-pages, User-Addshore
Krinkle updated subscribers of T333412: mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure.

With the help of @tstarling, we determined the cause of these two separate issues.

Wed, Mar 29, 12:09 AM · ci-test-error, MediaWiki-Vendor
Krinkle updated the task description for T333412: mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure.
Wed, Mar 29, 12:06 AM · ci-test-error, MediaWiki-Vendor
Krinkle created T333412: mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure.
Wed, Mar 29, 12:02 AM · ci-test-error, MediaWiki-Vendor

Tue, Mar 28

Krinkle reopened T203694: Run ForeignResourceManager verification on MediaWiki core commits as "Open".

Change 850151 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Run standalone jobs

https://gerrit.wikimedia.org/r/850151

Tue, Mar 28, 11:55 PM · MW-1.40-notes, Patch-For-Review, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Performance-Team-publish, MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Developer Productivity, MediaWiki-Core-Tests, Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

Opera Mini is a "proxy" browser, which is essentially an app that displays data from a remote cloud server where the real browser runs. As such, the JS interactions there are quite different and not as user friendly. We disabled our JavaScript layer in Opera Mini in 2013 (change).

Tue, Mar 28, 10:40 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

@Tacsipacsi The announcement is not about browser support in the abstract. It is about the specific set of browsers we are removing support for in this task. I agree that people on certain operating system versions cannot migrate to a newer browser, IE6 being an important historical example.

Tue, Mar 28, 8:05 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle added a comment to T311194: Remove unused module `jquery.hoverIntent`.

@Quiddity This will go out next week. I suggest something like this:

Tue, Mar 28, 5:48 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Performance-Team (Radar), User-notice, MediaWiki-ResourceLoader, User-DannyS712
Krinkle moved T333276: Add flip for shorthand properties that contain calc() expressions from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Tue, Mar 28, 3:30 AM · Performance-Team, CSSJanus
Krinkle moved T333120: Migrate internal traffic to k8s from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · Patch-For-Review, Performance-Team (Radar), Release-Engineering-Team (Seen), SRE, Traffic, serviceops, MW-on-K8s
Krinkle edited projects for T333276: Add flip for shorthand properties that contain calc() expressions, added: Performance-Team; removed Performance-Team (Radar).
Tue, Mar 28, 3:30 AM · Performance-Team, CSSJanus
Krinkle moved T331760: "mw.config.values.wbSiteDetails" module downloads 27.3 kB of compressed JavaScript on Vector-22 page load from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · wmde-wikidata-tech, Performance-Team (Radar), Wikidata, Desktop Improvements (Vector 2022), Wikidata-Campsite, Readers-Web-Backlog
Krinkle moved T332101: determine whether https://sitemaps.wikimedia.org still serves a purpose from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · Performance-Team (Radar), serviceops-collab
Krinkle moved T252593: More robust timing reporting in client-side EditAttemptStep instrumentation from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · Performance-Team (Radar), Editing-team, Product-Analytics
Krinkle moved T332329: UpdateQueryBuilder does not support IDatabase::ALL_ROWS updates from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Krinkle moved T332371: RedisBagOStuff multi-operations unnecessarily creates new connections from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Performance-Team (Radar), MediaWiki-libs-ObjectCache, Performance Issue
Krinkle moved T332650: Frequent OAuth failures on Wikimedia wikis since eqiad was repooled due to db-mainstash replication lag from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · Performance-Team (Radar), SRE, Datacenter-Switchover, MediaWiki-extensions-OAuth
Krinkle moved T332902: InvalidArgumentException: SQLPlatform::makeList: empty input for field rc_id (from RollbackPage.php) from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:30 AM · MW-1.39-notes, MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Growth-Team, Performance-Team (Radar), MediaWiki-Recent-changes, Wikimedia-production-error
Krinkle moved T332923: `@supports` ruleset doesn't include the selector from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · Performance-Team (Radar), Design-Systems-Team (Design-Systems-Sprint), Less.php
Krinkle moved T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions) from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MediaWiki-Action-API, Performance-Team (Radar)
Krinkle moved T332964: Upgrade php-excimer package from 1.0.4 to 1.1.1 from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · Infrastructure-Foundations, serviceops, WikimediaDebug, Performance-Team (Radar)
Krinkle moved T333267: Limit flipping of "left" or "right" values to known properties from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · Performance-Team (Radar), CSSJanus
Krinkle moved T333273: CSSJanus should not change gradient percentage in background property from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle moved T333275: Avoid flipping "ltr" or "left" in a data URI from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle moved T333277: Fix inconsistent flipping of CSS variables from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Mar 28, 3:29 AM · Performance-Team (Radar), CSSJanus
Krinkle triaged T333277: Fix inconsistent flipping of CSS variables as Medium priority.
Tue, Mar 28, 3:28 AM · Performance-Team (Radar), CSSJanus
Krinkle created T333277: Fix inconsistent flipping of CSS variables.
Tue, Mar 28, 3:28 AM · Performance-Team (Radar), CSSJanus
Krinkle triaged T333276: Add flip for shorthand properties that contain calc() expressions as Medium priority.
Tue, Mar 28, 3:26 AM · Performance-Team, CSSJanus
Krinkle claimed T333276: Add flip for shorthand properties that contain calc() expressions.

Note to self: Import @Mabualruz 's patch to Gerrit and review/test accordingly.

Tue, Mar 28, 3:18 AM · Performance-Team, CSSJanus
Krinkle created T333276: Add flip for shorthand properties that contain calc() expressions.
Tue, Mar 28, 3:17 AM · Performance-Team, CSSJanus
Krinkle moved T62805: Support flipping mutiple values under a text-shadow or border-shadow rule from Backlog to Accepted Enhancement on the CSSJanus board.
Tue, Mar 28, 3:09 AM · CSSJanus, Performance-Team (Radar)
Krinkle updated the task description for T62805: Support flipping mutiple values under a text-shadow or border-shadow rule.
Tue, Mar 28, 3:09 AM · CSSJanus, Performance-Team (Radar)
Krinkle renamed T62805: Support flipping mutiple values under a text-shadow or border-shadow rule from CSSJanus only supports flipping one text-shadow or border-shadow in RTL languages while the CSS syntax allows multiple to Support flipping mutiple values under a text-shadow or border-shadow rule.
Tue, Mar 28, 3:09 AM · CSSJanus, Performance-Team (Radar)
Krinkle reopened T62805: Support flipping mutiple values under a text-shadow or border-shadow rule as "Open".
Tue, Mar 28, 3:05 AM · CSSJanus, Performance-Team (Radar)
Krinkle triaged T333275: Avoid flipping "ltr" or "left" in a data URI as Low priority.
Tue, Mar 28, 2:57 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle created T333275: Avoid flipping "ltr" or "left" in a data URI.
Tue, Mar 28, 2:57 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle moved T333267: Limit flipping of "left" or "right" values to known properties from Backlog to Accepted Enhancement on the CSSJanus board.
Tue, Mar 28, 2:54 AM · Performance-Team (Radar), CSSJanus
Krinkle moved T106735: CSSJanus should flip background-position even if it was not explicitly specified from Backlog to Confirmed Problem on the CSSJanus board.
Tue, Mar 28, 2:54 AM · CSSJanus, Performance-Team (Radar), MediaWiki-ResourceLoader, RTL
Krinkle moved T333273: CSSJanus should not change gradient percentage in background property from Backlog to Confirmed Problem on the CSSJanus board.
Tue, Mar 28, 2:54 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle added a project to T333273: CSSJanus should not change gradient percentage in background property: patch-welcome.
Tue, Mar 28, 2:50 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle triaged T333273: CSSJanus should not change gradient percentage in background property as Medium priority.
Tue, Mar 28, 2:49 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle created T333273: CSSJanus should not change gradient percentage in background property.
Tue, Mar 28, 2:49 AM · patch-welcome, Performance-Team (Radar), CSSJanus
Krinkle created T333269: Benchmark baremetal vs k8s mediawiki perf (2023).
Tue, Mar 28, 2:36 AM · Performance-Team
Krinkle renamed T331318: Find a sensible way to direct traffic to mw-on-k8s from Find a sensible way to redirect traffic to mw-on-k8s to Find a sensible way to direct traffic to mw-on-k8s.
Tue, Mar 28, 2:25 AM · SRE, serviceops, Traffic, MW-on-K8s
Krinkle moved T333267: Limit flipping of "left" or "right" values to known properties from node-cssjanus to Backlog on the CSSJanus board.
Tue, Mar 28, 1:57 AM · Performance-Team (Radar), CSSJanus
Krinkle triaged T333267: Limit flipping of "left" or "right" values to known properties as Low priority.
Tue, Mar 28, 1:57 AM · Performance-Team (Radar), CSSJanus
Krinkle moved T333267: Limit flipping of "left" or "right" values to known properties from Confirmed Problem to node-cssjanus on the CSSJanus board.
Tue, Mar 28, 1:57 AM · Performance-Team (Radar), CSSJanus
Krinkle created T333267: Limit flipping of "left" or "right" values to known properties.
Tue, Mar 28, 1:56 AM · Performance-Team (Radar), CSSJanus
Krinkle renamed T329680: Reduce WANObjectCache configurability from Remove WANObjectCache configurability to Reduce WANObjectCache configurability.
Tue, Mar 28, 1:43 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MediaWiki-libs-ObjectCache, Performance-Team
Krinkle added hashtags to CSSJanus: #node-cssjanus, #grunt-cssjanus..
Tue, Mar 28, 1:42 AM

Mon, Mar 27

Krinkle removed a project from T332902: InvalidArgumentException: SQLPlatform::makeList: empty input for field rc_id (from RollbackPage.php): Confirmation prompt for rollback action.
Mon, Mar 27, 6:36 PM · MW-1.39-notes, MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Growth-Team, Performance-Team (Radar), MediaWiki-Recent-changes, Wikimedia-production-error
Krinkle edited projects for T332902: InvalidArgumentException: SQLPlatform::makeList: empty input for field rc_id (from RollbackPage.php), added: Confirmation prompt for rollback action, MediaWiki-Recent-changes, Performance-Team (Radar); removed Performance-Team, MediaWiki-libs-Rdbms.
Mon, Mar 27, 6:34 PM · MW-1.39-notes, MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Growth-Team, Performance-Team (Radar), MediaWiki-Recent-changes, Wikimedia-production-error
Krinkle renamed T332902: InvalidArgumentException: SQLPlatform::makeList: empty input for field rc_id (from RollbackPage.php) from InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field rc_id to InvalidArgumentException: SQLPlatform::makeList: empty input for field rc_id (from RollbackPage.php).
Mon, Mar 27, 6:34 PM · MW-1.39-notes, MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Growth-Team, Performance-Team (Radar), MediaWiki-Recent-changes, Wikimedia-production-error
Krinkle edited projects for T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions), added: MediaWiki-Action-API; removed MediaWiki-libs-Rdbms.
Mon, Mar 27, 6:26 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MediaWiki-Action-API, Performance-Team (Radar)
Krinkle awarded T206049: Gitiles project landing pages should have an anonymous clone URL a Orange Medal token.
Mon, Mar 27, 6:10 PM · Developer-Advocacy, Gerrit (Gerrit 3.6), Release-Engineering-Team (Seen), Upstream
Krinkle closed T48098: Disable miser mode ($wgMiserMode) on small wikis (wikis in small.dblist) as Declined.

Declining per the above. Instead re-opened T45668: Re-enable disabled Special pages on small wikis (wikis in small.dblist).

Mon, Mar 27, 6:35 AM · Performance-Team, Wikimedia-Site-requests
Krinkle reopened T45668: Re-enable disabled Special pages on small wikis (wikis in small.dblist), a subtask of T17434: Periodical run of currently disabled special pages, as Open.
Mon, Mar 27, 6:34 AM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Krinkle reopened T45668: Re-enable disabled Special pages on small wikis (wikis in small.dblist) as "Open".

Based on my analysis T48098#8602507, I appears this change either no longer works or never worked. Re-opening as I believe it still makes sense to enable these on small wikis.

Mon, Mar 27, 6:34 AM · Shell, Performance Issue, WMF-General-or-Unknown
Krinkle closed T331641: Context::encodeJson partially failed (invalid modules parameter) as Resolved.
Mon, Mar 27, 6:30 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MediaWiki-ResourceLoader, Performance-Team, Wikimedia-production-error
Krinkle triaged T330377: Wikimedia\Rdbms\DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transactionFunction: SqlBagOStuff::deleteServerObjectsExpiringBeforeQuery: DELETE FROM `objectstash` WHERE (exptime < '202302230 as High priority.
Mon, Mar 27, 6:29 AM · MediaWiki-libs-ObjectCache, Performance-Team, Wikimedia-production-error

Sun, Mar 26

Krinkle closed T332328: Restore hidden codesearch backends as Resolved.
Sun, Mar 26, 2:57 AM · VPS-project-Codesearch
Krinkle closed T193447: Index @wikimedia source repos from GitHub as Declined.

There's not much left, and what's there should arguably be moved off to Gerrit (or GitLab). There's a few things listed at https://www.mediawiki.org/wiki/Gerrit/GitHub. Anything not included can be added on a one-off basis, not worth the automation. I recently tried to fix the automation behind making that on-wiki list and it takes quite a lot of complexity to run and still has both false negatives and false positives because there are 1000s of repos under the org which all sorts of edge cases from different things we mirrored from Gerrit in different ways.

Sun, Mar 26, 12:17 AM · VPS-project-Codesearch
Krinkle moved T333073: Please add patchdemo to codesearch index from Backlog to Index requests on the VPS-project-Codesearch board.
Sun, Mar 26, 12:15 AM · VPS-project-Codesearch

Sat, Mar 25

Krinkle moved T333065: SelectQueryBuilder::fetchRowCount() always returns 1 for DISTINCT queries from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Sat, Mar 25, 10:57 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Patch-For-Review, Regression, Performance-Team, MediaWiki-libs-Rdbms
Krinkle added projects to T333065: SelectQueryBuilder::fetchRowCount() always returns 1 for DISTINCT queries: Regression, DBA.
Sat, Mar 25, 10:13 PM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Patch-For-Review, Regression, Performance-Team, MediaWiki-libs-Rdbms
Krinkle renamed T288287: Remove IE11 from Basic support ("Grade C") from Remove IE11 from basic support to Remove IE11 from Basic support ("Grade C").
Sat, Mar 25, 12:51 AM · Front-end Modernization, CSS, MediaWiki-General, MediaWiki-extensions-General, Browser-Support-Internet-Explorer
Krinkle added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

@CCiufo-WMF Sounds good to me. Note that this task is for dropping Modern support ("Grade A"). Basic support ("Grade C") is a next step and we'll make sure to wait with that until DST are ready for it. I see no rush on that one. That work is tracked under T288287, which is already marked as requiring the DST spike to complete first (T332716).

Sat, Mar 25, 12:51 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader

Fri, Mar 24

Krinkle added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

From a ResourceLoader perspective, I delegate largely to product teams to indicate readiness. I indentified stakeholders in this comment a few weeks ago:

Fri, Mar 24, 6:45 AM · MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), User-notice, Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle added a comment to T214068: Display Zuul status of jobs for a change on Gerrit UI.

Very nice!

Fri, Mar 24, 5:52 AM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure
Krinkle moved T298720: DatabaseIntegrationTest should test for unwanted BOOL database type in abstract schema from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Fri, Mar 24, 3:35 AM · MediaWiki-Core-Tests, Platform Team Initiatives (Abstract Schema)
Krinkle added a subtask for T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min: T332865: PHPUnit data providers should be simple static functions that return plain data.
Fri, Mar 24, 2:52 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Release-Engineering-Team (Priority Backlog 📥), MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Tests, Continuous-Integration-Config
Krinkle added a parent task for T332865: PHPUnit data providers should be simple static functions that return plain data: T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.
Fri, Mar 24, 2:52 AM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-General
Krinkle updated the task description for T291015: Add per-request flamegraph option to WikimediaDebug.
Fri, Mar 24, 2:35 AM · WikimediaDebug, Patch-For-Review, Arc-Lamp, Performance-Team
Krinkle added a parent task for T325460: Release Excimer 1.1.0: T291015: Add per-request flamegraph option to WikimediaDebug.
Fri, Mar 24, 2:34 AM · Patch-For-Review, Performance-Team, Excimer
Krinkle added a subtask for T291015: Add per-request flamegraph option to WikimediaDebug: T325460: Release Excimer 1.1.0.
Fri, Mar 24, 2:34 AM · WikimediaDebug, Patch-For-Review, Arc-Lamp, Performance-Team
Krinkle added projects to T332964: Upgrade php-excimer package from 1.0.4 to 1.1.1: serviceops, Infrastructure-Foundations.

@MoritzMuehlenhoff I believe this is something your team usually do, but not 100% sure. Feel free to re-route as needed!

Fri, Mar 24, 2:33 AM · Infrastructure-Foundations, serviceops, WikimediaDebug, Performance-Team (Radar)
Krinkle created T332964: Upgrade php-excimer package from 1.0.4 to 1.1.1.
Fri, Mar 24, 2:33 AM · Infrastructure-Foundations, serviceops, WikimediaDebug, Performance-Team (Radar)
Krinkle added a project to T291015: Add per-request flamegraph option to WikimediaDebug: WikimediaDebug.
Fri, Mar 24, 2:32 AM · WikimediaDebug, Patch-For-Review, Arc-Lamp, Performance-Team
Krinkle added a comment to T291015: Add per-request flamegraph option to WikimediaDebug.

Added to the task description:

Fri, Mar 24, 2:28 AM · WikimediaDebug, Patch-For-Review, Arc-Lamp, Performance-Team
Krinkle updated the task description for T291015: Add per-request flamegraph option to WikimediaDebug.
Fri, Mar 24, 2:28 AM · WikimediaDebug, Patch-For-Review, Arc-Lamp, Performance-Team

Thu, Mar 23

Krinkle added a comment to T332243: NOTOC causing API action=parse prop=sections to return nothing.

As I understand it, this property is meant to expose headings that exist in the content. Similar to how e.g. edit section and other mechanisms work by section. It seems the tool in question is using this to find and validate a particular portion of the page. Both the API property and the tool in question are not documented or named in relation to a graphical interface for a table of contents. If we retroactively treat it as such, I expect a feature request will be filed to introduce support for exposing "section" information, in which case the property sections would seem like a natural fit, bringing us back to where we are.

Thu, Mar 23, 8:32 PM · MW-1.40-release, Patch-For-Review, MediaWiki-Action-API, Ultraviolet, MediaWiki-Parser
Krinkle added a comment to T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable).

The Wikibase code is using IDatabase::unionQueries(). It seems the Rdbms library currently doesn't offer any other way to run union queries.

Thu, Mar 23, 8:11 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)
Krinkle created T332942: Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions).
Thu, Mar 23, 8:11 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MediaWiki-Action-API, Performance-Team (Radar)
Krinkle added a subtask for T326181: Stop doing regex on SQL in Database: T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable).
Thu, Mar 23, 8:07 PM · Performance-Team, MediaWiki-libs-Rdbms
Krinkle added a parent task for T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable): T326181: Stop doing regex on SQL in Database.
Thu, Mar 23, 8:07 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)
Krinkle created T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable).
Thu, Mar 23, 8:05 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)
Krinkle added a subtask for T288498: Update less.php to support Less.js 3.13 behaviours: T332923: `@supports` ruleset doesn't include the selector.
Thu, Mar 23, 7:11 PM · Less.php, Design-Systems-Team, Technical-Debt, Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle added a parent task for T332923: `@supports` ruleset doesn't include the selector: T288498: Update less.php to support Less.js 3.13 behaviours.
Thu, Mar 23, 7:11 PM · Performance-Team (Radar), Design-Systems-Team (Design-Systems-Sprint), Less.php
Krinkle added a comment to T332923: `@supports` ruleset doesn't include the selector.

Using http://ecomfe.github.io/est/fiddle/#version=2.4.0&autoprefix=false&est=false&autorun=false, it seems this was upstream less.js behaviour in 2.4.0 and changed to the current behaviour in 2.5.0, though seemingly without coverage by upstream's test specification, hence it was likely missed by less.php maintainers until now (noting that Wikimedia took over less.php maintenance in 2019).

Thu, Mar 23, 7:10 PM · Performance-Team (Radar), Design-Systems-Team (Design-Systems-Sprint), Less.php
Krinkle added a comment to T288498: Update less.php to support Less.js 3.13 behaviours.

Task description:

  • Rescoped to not be never-ending but rather a specific major upgrade.
  • Added a acceptance critera instead of "we did the task", which is undefined. Proposing to use the upstream test suite, like we do now.
Thu, Mar 23, 7:06 PM · Less.php, Design-Systems-Team, Technical-Debt, Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle renamed T288498: Update less.php to support Less.js 3.13 behaviours from Update less.php to latest Less version to Update less.php to support Less.js 3.13 behaviours.
Thu, Mar 23, 7:04 PM · Less.php, Design-Systems-Team, Technical-Debt, Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle triaged T331641: Context::encodeJson partially failed (invalid modules parameter) as Medium priority.
Thu, Mar 23, 6:24 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MediaWiki-ResourceLoader, Performance-Team, Wikimedia-production-error

Wed, Mar 22

Krinkle added a comment to T235796: The ext.3d.styles module should not be added unconditionally to every page and should set target mobile.
From the task description:

[…] which is both good (no performance penalty) and bad (no 3d styling capability).

Wed, Mar 22, 11:28 PM · Performance-Team (Radar), 3D