Krinkle (Timo Tijhof)Administrator
Principal Engineer (Performance)

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (210 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photography by Niek Hidding.)

Recent Activity

Today

Krinkle moved T202199: Systematically identify all extensions that use deprecated functions from Unsorted to Migrate / Replace on the Technical-Debt board.
Fri, Oct 19, 3:42 AM · Technical-Debt, Code-Health, MediaWiki-extensions-General
Krinkle edited projects for T202199: Systematically identify all extensions that use deprecated functions, added: Technical-Debt; removed Technical-Debt (Deprecation).
Fri, Oct 19, 3:41 AM · Technical-Debt, Code-Health, MediaWiki-extensions-General
Krinkle moved T202198: ApiQueryGlobalBlocks is using deprecated ApiBase::dieUsage from Unsorted to Migrate / Replace on the Technical-Debt board.
Fri, Oct 19, 3:41 AM · Technical-Debt, GlobalBlocking
Krinkle edited projects for T202198: ApiQueryGlobalBlocks is using deprecated ApiBase::dieUsage, added: Technical-Debt; removed Technical-Debt (Deprecation).
Fri, Oct 19, 3:41 AM · Technical-Debt, GlobalBlocking
Krinkle moved T204945: Deprecate one of the Preprocessor implementations for 1.33 from Not yet to 2019 | MW 1.33 on the Technical-Debt (Deprecation) board.
Fri, Oct 19, 3:40 AM · Technical-Debt (Deprecation), MediaWiki-Parser, Patch-For-Review
Krinkle added a project to T204945: Deprecate one of the Preprocessor implementations for 1.33: Technical-Debt (Deprecation).
Fri, Oct 19, 3:40 AM · Technical-Debt (Deprecation), MediaWiki-Parser, Patch-For-Review
Krinkle added a comment to T207115: Determine solution for logging clicks to external links.
@Legoktm wrote:

Have the privacy aspects of this been considered? Tracking full URLs feels pretty icky, and I think we generally try to avoid collecting data that link users to what they're reading.

Yes. We want to understand common pathways for accounts younger than 24 hours to try to improve retention and growth. Understanding when users go off-wiki (for example, to view social media links that a wiki has provided on their help desk) is helpful to improving our understanding. [..]

Fri, Oct 19, 2:53 AM · Privacy, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team (Current Sprint)

Wed, Oct 17

Krinkle created T207340: Determine cause of upload.wikimedia.org requests routed to text-lb (404 Not Found).
Wed, Oct 17, 10:29 PM · Performance-Team (Radar), Traffic, Operations
Krinkle added a comment to T204577: JsonConfig emits PHP error "Cannot access property on non-object" in JCApi::addStatusConf.

(Still seen on 1.32-wmf.24)

Wed, Oct 17, 7:03 PM · MediaWiki-extensions-JsonConfig, Wikimedia-production-error
Krinkle added a project to T88997: Improve graphite failover: Performance-Team (Radar).
Wed, Oct 17, 6:57 PM · Performance-Team (Radar), Patch-For-Review, Zuul, Operations, Graphite
Krinkle moved T206878: One page on ar.wikipedia.org is unviewable due to fatal error (execution time out) from Parser/LanguageConverter from Regressed 1.32-wmf.20 to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Wed, Oct 17, 6:45 PM · MediaWiki-Parser, Wikimedia-production-error
Krinkle moved T204010: Timeouts in wikidiff2 from Regressed 1.32-wmf.20 to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Wed, Oct 17, 6:45 PM · Wikimedia-production-error, wikidiff2
Krinkle moved T207313: Some administrative and log actions on Wikidata take longer than 60 seconds and time out from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.

(Triaging as "Not new" from a production branch perspective (the timeout configuration is separate from that). I'll let the Wikidata team triage and decide how to handle the issue itself.)

Wed, Oct 17, 6:44 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
Krinkle added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

(Still seen on 1.32-wmf.24)

Wed, Oct 17, 6:42 PM · VisualEditor, MediaWiki-Uploading, Multimedia, Wikimedia-production-error
Krinkle closed T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article as Resolved.
Wed, Oct 17, 6:33 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), AbuseFilter, Wikimedia-production-error
Krinkle closed T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article, a subtask of T191072: 1.32.0-wmf.26 deployment blockers, as Resolved.
Wed, Oct 17, 6:33 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Krinkle moved T201781: Undefined property: stdClass::$actor_rev_user.actor_name in /includes/libs/rdbms/database/Database.php on line 1513 from Backlog to libs/rdbms on the MediaWiki-Database board.
Wed, Oct 17, 6:28 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-Database
Krinkle created T207315: Investigate 200-300ms increase in responseStart.p75.
Wed, Oct 17, 6:27 PM · Operations, Traffic, Performance-Team
Krinkle added a comment to T202720: Consider pre-loading VE code into memory to improve performance and speed.

@Esanders That seems like a good way to implement the feature in ResourceLoader.

Wed, Oct 17, 3:59 PM · VisualEditor (Current work), Performance-Team (Radar), Editing Q1 2018-19 mobile improvements
Krinkle added a comment to T205127: Memory leak from Popups on Wikipedia pages.

@JFG To confirm - The leak remains when bringing focus to the background window and making it the foreground window and scrolling. It stops when you mouse over a link, even when the mousing over doesn't do anything (when previews is disabled).

Wed, Oct 17, 3:23 PM · Readers-Web-Backlog, Performance-Team (Radar), Page-Previews, Growth-Team
Krinkle updated the task description for T75714: ResourceLoader JavaScript parser should allow ES6 syntax features .
Wed, Oct 17, 3:15 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T75714: ResourceLoader JavaScript parser should allow ES6 syntax features .

Under MW 1.29.1, if I insert a template literal (surrounded by backticks) into a script in the MediaWiki namespace, the ResourceLoader gives a parse
error.

Wed, Oct 17, 3:15 PM · Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article.

I'm sorry but I cannot send a patch right no. However, this can be simply fixed by removing the recently added typehinting.

Wed, Oct 17, 2:51 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), AbuseFilter, Wikimedia-production-error
Krinkle added a comment to T205128: Bundle Hogan.js.

Okay, sounds good. It's unfortunate that the differences are that significant, but nothing we can do about that now. Thanks for explaining.

Wed, Oct 17, 2:48 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend.js)
Krinkle moved T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash from Inbox to Potential goals on the Performance-Team board.

Pushing back. But would be nice to finish up at some point, but not now. To anyone else that happens to run into it: feel free to take it.

Wed, Oct 17, 2:41 AM · Performance-Team, User-Tgr, MediaWiki-Debug-Logger, Deployments
Krinkle added a comment to T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash.

Last remaining check box:

Wed, Oct 17, 2:39 AM · Performance-Team, User-Tgr, MediaWiki-Debug-Logger, Deployments
Krinkle added a project to T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash: Performance-Team.
Wed, Oct 17, 2:39 AM · Performance-Team, User-Tgr, MediaWiki-Debug-Logger, Deployments
Krinkle removed a project from T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash: Patch-For-Review.
Wed, Oct 17, 2:39 AM · Performance-Team, User-Tgr, MediaWiki-Debug-Logger, Deployments

Tue, Oct 16

Krinkle moved T206253: Some ApiParse reqs fatal due to contentformat from Regressed 1.32-wmf.20 to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Tue, Oct 16, 11:30 PM · MediaWiki-ContentHandler, MediaWiki-API, Wikimedia-production-error
Krinkle added a comment to T206253: Some ApiParse reqs fatal due to contentformat.

Recently triggered via urls such as https://en.wikipedia.org/w/api.php?action=parse&page=Example&contentformat=application/json&prop=wikitext&section=2.

Tue, Oct 16, 11:27 PM · MediaWiki-ContentHandler, MediaWiki-API, Wikimedia-production-error
Krinkle created T207240: PHP error on Special:Log from CentralAuthHooks::onHandleGrouprenameLogEntry.
Tue, Oct 16, 11:24 PM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Krinkle removed a project from T193565: Foreign query for metawiki fails with "Table 'centralauth.page' doesn't exist" (DBConnRef mixup?): Patch-For-Review.
Tue, Oct 16, 11:06 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Performance-Team, Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-production-error, MediaWiki-Database
Krinkle moved T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.
Tue, Oct 16, 11:01 PM · Wikimedia-production-error, MediaWiki-Special-pages
Krinkle moved T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.

Raising priority because unlike most cases of "this is broken and it isn't meant to work" (where by it should still be fixed to not spam the logs, but at least it's not going to make a difference for uses), unlike those, fatal exceptions are particularly painful due to them bypassing caching, and triggering the highest severity of alarms that we monitor ("mw fatals").

Tue, Oct 16, 11:00 PM · Wikimedia-production-error, MediaWiki-Special-pages
Krinkle renamed T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number from Mediawiki fatals if namespace is negative to Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number.
Tue, Oct 16, 10:58 PM · Wikimedia-production-error, MediaWiki-Special-pages
Krinkle moved T207235: PHP error from ArticlePlaceholder hook on SpecialSearch from Regressed 1.32-wmf.24 to Meta on the Wikimedia-production-error board.

Was first seen on 1.32.0-wmf.24, but may've been older due to limited log retention. Impact currently unknown. Unhandled/Implicit code conditions are sometimes innocent, other times it may be cause for cascading problems that themselves might not be logged due to being "the wrong thing, but succeeding at being wrong without errors" - type of code paths being invoked.

Tue, Oct 16, 10:49 PM · wikidata-tech-focus, ArticlePlaceholder, Wikidata, Wikimedia-production-error
Krinkle created T207235: PHP error from ArticlePlaceholder hook on SpecialSearch.
Tue, Oct 16, 10:46 PM · wikidata-tech-focus, ArticlePlaceholder, Wikidata, Wikimedia-production-error
Krinkle added a comment to T142017: LangLinkHandler hook error on page views: "getEntityLinks could not load item Q7082645 for Okstad School".

And another message from a similar code path, likely related:

Tue, Oct 16, 10:38 PM · Wikimedia-production-error, Wikidata
Krinkle added a comment to T207231: Deprecate wfLogWarning/MWDebug::warning.

CC-ing a few folks that may have views/opinions on this. Thanks!

Tue, Oct 16, 10:32 PM · Technical-Debt (Deprecation), MediaWiki-Debug-Logger
Krinkle updated subscribers of T207231: Deprecate wfLogWarning/MWDebug::warning.
Tue, Oct 16, 10:32 PM · Technical-Debt (Deprecation), MediaWiki-Debug-Logger
Krinkle edited projects for T207231: Deprecate wfLogWarning/MWDebug::warning, added: Technical-Debt (Deprecation); removed Technical-Debt.
Tue, Oct 16, 10:32 PM · Technical-Debt (Deprecation), MediaWiki-Debug-Logger
Krinkle created T207231: Deprecate wfLogWarning/MWDebug::warning.
Tue, Oct 16, 10:31 PM · Technical-Debt (Deprecation), MediaWiki-Debug-Logger
Krinkle moved T142017: LangLinkHandler hook error on page views: "getEntityLinks could not load item Q7082645 for Okstad School" from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.

Still seen on 1.32-wmf.24.

Tue, Oct 16, 10:27 PM · Wikimedia-production-error, Wikidata
Krinkle renamed T142017: LangLinkHandler hook error on page views: "getEntityLinks could not load item Q7082645 for Okstad School" from LangLinkHandler::getEntityLinks: Could not load item Q7082645 for Okstad School to LangLinkHandler hook error on page views: "getEntityLinks could not load item Q7082645 for Okstad School".
Tue, Oct 16, 10:22 PM · Wikimedia-production-error, Wikidata
Krinkle added a comment to T191072: 1.32.0-wmf.26 deployment blockers.

@mmodell Hm.. the "create one" link seems to use form 47 (create release) instead of 46 (report error). Removing the template parameter and keeping only parent would also ensure #Patch-for-Review`, #Train, Assigned To, Subscribers, etc. don't get copied, and allows the forms' placeholder to show instead.

Tue, Oct 16, 10:18 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Krinkle added hashtags to MediaWiki-Cache: #mediawiki-parsercache, #mediawiki-messagecache.
Tue, Oct 16, 10:02 PM
Krinkle moved T206740: parsercache used disk space increase from Backlog to ParserCache on the MediaWiki-Cache board.
Tue, Oct 16, 10:01 PM · MediaWiki-Cache, Performance-Team (Radar), User-Banyek, Performance-Team-notice, Datacenter-Switchover-2018, Operations, DBA
Krinkle edited projects for T206740: parsercache used disk space increase, added: MediaWiki-Cache; removed MediaWiki-Database.
Tue, Oct 16, 10:01 PM · MediaWiki-Cache, Performance-Team (Radar), User-Banyek, Performance-Team-notice, Datacenter-Switchover-2018, Operations, DBA
Krinkle moved T206740: parsercache used disk space increase from Backlog to Usage problem on the MediaWiki-Database board.
Tue, Oct 16, 10:01 PM · MediaWiki-Cache, Performance-Team (Radar), User-Banyek, Performance-Team-notice, Datacenter-Switchover-2018, Operations, DBA
Krinkle moved T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database. from Backlog to libs/rdbms on the MediaWiki-Database board.
Tue, Oct 16, 10:01 PM · Performance-Team, MW-1.32-release, MW-1.31-release, MediaWiki-Database
Krinkle moved T206878: One page on ar.wikipedia.org is unviewable due to fatal error (execution time out) from Parser/LanguageConverter from Untriaged to Regressed 1.32-wmf.20 on the Wikimedia-production-error board.
Tue, Oct 16, 9:59 PM · MediaWiki-Parser, Wikimedia-production-error
Krinkle renamed T206878: One page on ar.wikipedia.org is unviewable due to fatal error (execution time out) from Parser/LanguageConverter from arwiki page giving "entire web request took longer than 60 seconds and timed out" to One page on ar.wikipedia.org is unviewable due to fatal error (execution time out) from Parser/LanguageConverter.
Tue, Oct 16, 9:59 PM · MediaWiki-Parser, Wikimedia-production-error
Krinkle added a subtask for T191072: 1.32.0-wmf.26 deployment blockers: T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article.
Tue, Oct 16, 9:53 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Krinkle added a parent task for T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article: T191072: 1.32.0-wmf.26 deployment blockers.
Tue, Oct 16, 9:53 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), AbuseFilter, Wikimedia-production-error
Krinkle triaged T207220: AFComputedVariable.php: Argument to getLinksFromDB() must be an instance of Article as Unbreak Now! priority.
Tue, Oct 16, 9:49 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), AbuseFilter, Wikimedia-production-error
Krinkle moved T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Tue, Oct 16, 9:28 PM · MediaWiki-General-or-Unknown, Wikimedia-production-error
Krinkle updated the task description for T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach.
Tue, Oct 16, 9:28 PM · MediaWiki-General-or-Unknown, Wikimedia-production-error
Krinkle created T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach.
Tue, Oct 16, 9:22 PM · MediaWiki-General-or-Unknown, Wikimedia-production-error
Krinkle added a comment to T205128: Bundle Hogan.js.

I'm curious if and how this relates to T194684. I understand that the switch away from HTML templates and its feature set toward simple string templates is deferred to later, but a fairly significant investment in Hogan is still surprising.

Tue, Oct 16, 8:11 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend.js)
Krinkle added a comment to T205129: Upgrade Hogan.js.

I know we've popularised mw.inspect() and I'm sorry about the confusion, but it's not a good metric to use for this purpose. As part of T194684, we'll improve its documentation and capabilities, including clarifying the meaning of some of its reports.

Tue, Oct 16, 7:56 PM · Security-Reviews, MobileFrontend, Readers-Web-Backlog
Krinkle added a comment to T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.

Jon and I talked about this some days ago, but some of what we determined isn't reflected here yet. a couple of quick thoughts and some additional analysis follows to hopefully move this forward:

Tue, Oct 16, 7:19 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Product-Analytics, Reading-analysis
Krinkle added a comment to T205127: Memory leak from Popups on Wikipedia pages.

See T205127#4613124 and T205127#4613193 for a recently written summary. What I know is that users of several different communities have reported through various channels over the past 2-3 months about memory leaks, after several years of having virtually heard nothing about the subject. They could be unrelated reports, but so far they had in common:

Tue, Oct 16, 6:27 PM · Readers-Web-Backlog, Performance-Team (Radar), Page-Previews, Growth-Team
Krinkle added projects to T207088: Remex double-decodes HTML entities on PHP (not HHVM): PHP 7.0 support, PHP 7.3 support.
Tue, Oct 16, 4:55 PM · PHP 7.3 support, PHP 7.0 support, Patch-For-Review, RemexHtml
Krinkle moved T135991: Automated service restarts for common low-level system services from Limbo to Watching on the Performance-Team (Radar) board.
Tue, Oct 16, 2:37 AM · Performance-Team (Radar), Patch-For-Review, Operations
Krinkle added a project to T135991: Automated service restarts for common low-level system services: Performance-Team (Radar).
Tue, Oct 16, 2:37 AM · Performance-Team (Radar), Patch-For-Review, Operations

Mon, Oct 15

Krinkle added a comment to T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3.

See https://github.com/oyejorge/less.php/pull/367.

Mon, Oct 15, 10:32 PM · Patch-For-Review, PHP 7.3 support, Upstream, MediaWiki-Vendor
Krinkle moved T206988: MediaWiki 1.31.x should be compatible with PHP 7.3 from Backlog to MediaWiki core on the PHP 7.3 support board.
Mon, Oct 15, 10:14 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Krinkle added a comment to T206825: Get libraryupgrader's "npm audit fix" mode to a level where we feel comfortable letting it auto +2.

I agree that we rarely use npm to initialise or edit meta-data fields like version, author, license etc.

Mon, Oct 15, 8:59 PM · VPS-project-libraryupgrader
Krinkle added a subtask for T206963: Perform a statsd and Graphite switch: T206964: hhvm-fatal-error failing to send statsd packet in Beta Cluster.
Mon, Oct 15, 7:59 PM · Performance-Team (Radar), monitoring, Patch-For-Review, Operations, Availability
Krinkle added a parent task for T206964: hhvm-fatal-error failing to send statsd packet in Beta Cluster: T206963: Perform a statsd and Graphite switch.
Mon, Oct 15, 7:59 PM · Patch-For-Review, Beta-Cluster-Infrastructure, Performance-Team
Krinkle awarded T206816: Move extension "npm test" out of quibble jobs a Orange Medal token.
Mon, Oct 15, 7:56 PM · Patch-For-Review, Continuous-Integration-Config, Quibble
Krinkle closed T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address" as Resolved.

Looks its fixed itself now. Presumably by the scap command that @Addshore ran in the same minute for /wmf-config/Wikibase-production, which also had scap touch InitialiseSettings.php.

Mon, Oct 15, 7:30 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle awarded T207056: Some logos added to wgLogoHD aren't uploaded to the server a Orange Medal token.
Mon, Oct 15, 5:34 PM · Patch-For-Review, Wikimedia-Site-requests, User-Urbanecm
Krinkle added a comment to T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address".

A third error popped up at 15,000 hits per minute. Again from the same server (mw1331) and code path (ViewAction/PoolWorkArticleView/../RevisionStorage), so I'll map it to the same task for now until we know otherwise.

Mon, Oct 15, 5:28 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle moved T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Mon, Oct 15, 5:25 PM · User-Daimona, Wikimedia-production-error, AbuseFilter
Krinkle added a comment to T206940: Quote marks in "alt" text break media attribute parsing.

@cscott Hm.. so it's not the new lines. I assume that means its the quote marks that trigger it?

Mon, Oct 15, 5:23 PM · Patch-For-Review, Parsoid, VisualEditor
Krinkle renamed T206940: Quote marks in "alt" text break media attribute parsing from Newlines in "alt" text between double-quotes breaks media attribute parsing to Quote marks in "alt" text break media attribute parsing.
Mon, Oct 15, 5:23 PM · Patch-For-Review, Parsoid, VisualEditor
Krinkle added a comment to T124196: Notice: Unable to unserialize job_params in some CirrusSearch jobs (when using JobQueueDB).

Oops, used the wrong tag. Thanks!

Mon, Oct 15, 5:16 PM · MediaWiki-JobQueue, User-aude, Discovery-Search, Wikidata, Discovery, CirrusSearch
Krinkle added a project to T124196: Notice: Unable to unserialize job_params in some CirrusSearch jobs (when using JobQueueDB): MediaWiki-JobQueue.
Mon, Oct 15, 5:15 PM · MediaWiki-JobQueue, User-aude, Discovery-Search, Wikidata, Discovery, CirrusSearch
Krinkle added a comment to T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content.

Seen still/again on 1.32.0-wmf.24:

SpecialUpload
PHP Fatal Error: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content, null given
Mon, Oct 15, 5:14 PM · User-Daimona, Wikimedia-production-error, AbuseFilter
Krinkle moved T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content from Resolved/Invalid/Legacy/Declined to Backlog on the AbuseFilter board.
Mon, Oct 15, 5:10 PM · User-Daimona, Wikimedia-production-error, AbuseFilter
Krinkle added a project to T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content: Wikimedia-production-error.
Mon, Oct 15, 5:09 PM · User-Daimona, Wikimedia-production-error, AbuseFilter
Krinkle moved T207063: AbuseFilterViewEdit.php: PHP Warning: Invalid operand type was used: loadRequest expects array(s) from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Mon, Oct 15, 5:08 PM · AbuseFilter, Wikimedia-production-error
Krinkle created T207063: AbuseFilterViewEdit.php: PHP Warning: Invalid operand type was used: loadRequest expects array(s).
Mon, Oct 15, 5:08 PM · AbuseFilter, Wikimedia-production-error
Krinkle added a project to T124196: Notice: Unable to unserialize job_params in some CirrusSearch jobs (when using JobQueueDB): WMF-JobQueue.

Is this still an issue?

Mon, Oct 15, 4:54 PM · MediaWiki-JobQueue, User-aude, Discovery-Search, Wikidata, Discovery, CirrusSearch
Krinkle added a project to T100259: PHP Warning: implode(): Invalid arguments passed in ApiTranslateSandbox.php on line 170: translatewiki.net.

Has this been seen recently since 2016? (the recently merged issue was also a report from 2016).

Mon, Oct 15, 4:53 PM · MediaWiki-extensions-Translate
Krinkle added a comment to T87857: Notice/Warning for TranslationHelpers.php on line 629 is unhelpful.

Is this still an issue?

Mon, Oct 15, 4:53 PM · MediaWiki-extensions-Translate
Krinkle closed T147968: [BUG] FATAL: Invalid operand type in Language.php as Resolved.

Closing for now because:

  • Report has no stack trace, steps to reproduce, or known impact.
  • Not found in last 30 days in Logstash.
  • 2 years old.
Mon, Oct 15, 4:52 PM · Wikimedia-production-error, MediaWiki-General-or-Unknown
Krinkle moved T206939: "Workers" data from prometheus for mw app servers alternates strangely from Limbo to Watching on the Performance-Team (Radar) board.
Mon, Oct 15, 4:41 PM · Performance-Team (Radar), monitoring, Operations
Krinkle added a project to T207055: Replace CDB with JSON: Performance-Team (Radar).
Mon, Oct 15, 4:41 PM · Performance-Team (Radar), MediaWiki-extensions-Babel
Krinkle added a comment to T204894: Exception executing job: EchoNotificationJob "No EchoEvent found with ID ...".

(Still seen on 1.32.0-wmf.24)

Mon, Oct 15, 4:39 PM · Notifications, Wikimedia-production-error, Growth-Team
Krinkle moved T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address" from Accepted: Bugs to External on the MediaWiki-ResourceLoader board.
Mon, Oct 15, 4:35 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle moved T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address" from Inbox to Accepted: Bugs on the MediaWiki-ResourceLoader board.
Mon, Oct 15, 4:35 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle added a project to T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address": MediaWiki-ResourceLoader.

The following error while seemingly unrelated, also started around the same time, and is coming from the same server-wiki combinations. Will track under the same task for now.

Mon, Oct 15, 4:35 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle created T207054: Some Commons pages fatal with IncompleteRevisionException: "Uninitialized field: content_address".
Mon, Oct 15, 4:29 PM · Performance-Team, MediaWiki-ResourceLoader, Core Platform Team, Multi-Content-Revisions, Wikimedia-production-error
Krinkle moved T206283: Deadlock exception from LinksUpdate in WikiPage::updateCategoryCounts from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.
Mon, Oct 15, 1:08 AM · Performance-Team, MediaWiki-Database, Wikimedia-production-error
Krinkle added a comment to T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).

@daniel I suspect this might (also) identify a problem or regression with the RevisionRecord/DerivedDataUpdater refactors.

Mon, Oct 15, 1:05 AM · User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Krinkle moved T206610: Can't mark article as flagged (Internal Error) from Untriaged to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.

Seen since at least 1.32.0-wmf.20, likely earlier.

Mon, Oct 15, 12:53 AM · Wikimedia-production-error, MediaWiki-extensions-FlaggedRevs, Russian-Sites
Krinkle added a comment to T206610: Can't mark article as flagged (Internal Error).

Couldn't find the reporters instance on ruwiki in the logs, but did find about a dozen others. Here's one:

Mon, Oct 15, 12:52 AM · Wikimedia-production-error, MediaWiki-extensions-FlaggedRevs, Russian-Sites
Krinkle added a project to T206283: Deadlock exception from LinksUpdate in WikiPage::updateCategoryCounts: Performance-Team.
Mon, Oct 15, 12:46 AM · Performance-Team, MediaWiki-Database, Wikimedia-production-error