Krinkle (Timo Tijhof)
Principal Performance Engineer, Wikimedia Foundation

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (176 w, 3 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Today

Krinkle edited projects for T176211: Page Previews could load less JS on pageload, added: Performance-Team; removed Performance-Team (Radar).
Fri, Feb 23, 9:17 AM · Performance-Team, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Backlog, Page-Previews
Krinkle added a project to T180817: Review outstanding TemplateStyles patches: Performance-Team.
Fri, Feb 23, 9:16 AM · Performance-Team, Reading-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, TemplateStyles
Krinkle triaged T188076: Versioned load.php url for long caching gets short-cached instead as High priority.
Fri, Feb 23, 8:37 AM · Performance-Team, MediaWiki-ResourceLoader
Krinkle created T188076: Versioned load.php url for long caching gets short-cached instead.
Fri, Feb 23, 8:37 AM · Performance-Team, MediaWiki-ResourceLoader
Krinkle closed T46310: Thumbnail cache should be automatically discarded after 6 months, a subtask of T43371: Thumbnail/imagescaler (tracking), as Declined.
Fri, Feb 23, 1:45 AM · media-storage, Commons, Tracking
Krinkle closed T46310: Thumbnail cache should be automatically discarded after 6 months as Declined.
Fri, Feb 23, 1:45 AM · media-storage
Krinkle added a comment to T46310: Thumbnail cache should be automatically discarded after 6 months.

Per Ops feedback on T356, it seems this is no longer needed and/or being handled routinely by other means now.

Fri, Feb 23, 1:45 AM · media-storage
Krinkle edited projects for T46310: Thumbnail cache should be automatically discarded after 6 months, added: media-storage; removed WorkType-NewFunctionality, Wikimedia-General-or-Unknown.
Fri, Feb 23, 1:44 AM · media-storage
Krinkle updated the task description for T188062: Remove imagescaler cluster (aka 'rendering').
Fri, Feb 23, 1:43 AM · Operations
Krinkle updated the task description for T188062: Remove imagescaler cluster (aka 'rendering').
Fri, Feb 23, 1:43 AM · Operations
Krinkle added a subtask for T188062: Remove imagescaler cluster (aka 'rendering'): T187899: Stop routing Varnish thumb.php traffic to image scalers.
Fri, Feb 23, 1:36 AM · Operations
Krinkle added a parent task for T187899: Stop routing Varnish thumb.php traffic to image scalers: T188062: Remove imagescaler cluster (aka 'rendering').
Fri, Feb 23, 1:36 AM · Patch-For-Review, Performance-Team, Thumbor
Krinkle created T188062: Remove imagescaler cluster (aka 'rendering').
Fri, Feb 23, 1:36 AM · Operations
Krinkle updated the task description for T84950: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking).
Fri, Feb 23, 1:31 AM · Tracking, Commons, Multimedia, Beta-Cluster-Infrastructure, MediaWiki-File-management
Krinkle removed a project from T91104: PHP thumbnailer as a service: Commons.
Fri, Feb 23, 1:30 AM · MediaWiki-File-management, Multimedia
Restricted Application added a project to T91104: PHP thumbnailer as a service: Commons.

@cscott MediaWiki now supports deferring the thumbnail/image scaling effort to a separate service (as of rMWa9213ccb4c77: Add ability to proxy thumbnail requests to a service). Although even before this, one could set up rewrites to bypass MediaWiki entirely for thumbnail urls.

Fri, Feb 23, 1:30 AM · MediaWiki-File-management, Multimedia
Krinkle closed T130299: PHP Fatal: "Call to toHtml() on a non-object in includes/specials/SpecialListfiles.php" as Resolved.

Fixed in 2016 by @matmarex in rMWcd94b626e98c: ImageListPager: Don't fatal when unable to thumbnail a file (https://gerrit.wikimedia.org/r/302064).

Fri, Feb 23, 1:20 AM · MW-1.28-release-notes, MediaWiki-Special-pages
Krinkle renamed T130299: PHP Fatal: "Call to toHtml() on a non-object in includes/specials/SpecialListfiles.php" from php fatal error when listing files to PHP Fatal: "Call to toHtml() on a non-object in includes/specials/SpecialListfiles.php".
Fri, Feb 23, 1:17 AM · MW-1.28-release-notes, MediaWiki-Special-pages
Krinkle updated the task description for T130299: PHP Fatal: "Call to toHtml() on a non-object in includes/specials/SpecialListfiles.php".
Fri, Feb 23, 1:16 AM · MW-1.28-release-notes, MediaWiki-Special-pages
Krinkle renamed T170605: Unable to render file from upload.wikimedia.org "Error 349 ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION" from Android unable to render file from upload.wikimedia.org "Error 349 ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION" to Unable to render file from upload.wikimedia.org "Error 349 ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION".
Fri, Feb 23, 1:15 AM · Thumbor, media-storage, Traffic, Operations, Commons
Krinkle renamed T170605: Unable to render file from upload.wikimedia.org "Error 349 ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION" from ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION to Android unable to render file from upload.wikimedia.org "Error 349 ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION".
Fri, Feb 23, 1:14 AM · Thumbor, media-storage, Traffic, Operations, Commons
Krinkle moved T115414: Remove the ability to disable the API with $wgEnableAPI from Needs Code to Blocked on the MediaWiki-API board.

Blocked per comments on https://gerrit.wikimedia.org/r/#/c/392542/, on:

  • Remove use from tarball-bundled and WMF-maintained extensions.
  • Wait until the next release cycle (MediaWiki 1.32).
Fri, Feb 23, 1:10 AM · MediaWiki-API
Krinkle removed projects from T115414: Remove the ability to disable the API with $wgEnableAPI: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review.
Fri, Feb 23, 1:09 AM · MediaWiki-API
Krinkle closed T77453: RFC for blocking arbitrary thumbnail sizes over a certain size as Declined.

Withdrawn per T356.

Fri, Feb 23, 1:03 AM · RfC, Commons, MediaWiki-File-management, Multimedia
Krinkle removed a parent task for T43371: Thumbnail/imagescaler (tracking): T39883: Bug and feature requests related to Wikimedia Commons (tracking).
Fri, Feb 23, 12:50 AM · media-storage, Commons, Tracking
Krinkle removed a subtask for T39883: Bug and feature requests related to Wikimedia Commons (tracking): T43371: Thumbnail/imagescaler (tracking).
Fri, Feb 23, 12:50 AM · Commons, Tracking, Wikimedia-General-or-Unknown
Krinkle updated the task description for T50479: Change default favicon in InitialiseSettings.php.
Fri, Feb 23, 12:48 AM · Shell, Wikimedia-Site-requests

Yesterday

Krinkle added a comment to T187980: Memcached error "A TIMEOUT OCCURRED" for key "WANCache:v:enwiki:sidebar:en".

Thanks!

Thu, Feb 22, 11:57 PM · Performance-Team, Wikimedia-log-errors, MediaWiki-Cache, MediaWiki-Interface
Krinkle added a comment to T187973: Find all uses of deprecated AbuseFilter variable names on WMF wikis.

I've narrowed the task to the WFM sysadmin request appropriate for Wikimedia-Site-requests. Per the description of Wikimedia-General-or-Unknown, the task of a global sysop performing on-wiki changes is outside the scope for any Phabricator task (unless the task is e.g. executed by Community-Tech in which case Community-Tech-fixes could be used).

Thu, Feb 22, 10:50 PM · Wikimedia-Site-requests, AbuseFilter
Krinkle renamed T187973: Find all uses of deprecated AbuseFilter variable names on WMF wikis from Find and correct all uses of deprecated AbuseFilter variable names on WMF wikis to Find all uses of deprecated AbuseFilter variable names on WMF wikis.
Thu, Feb 22, 10:49 PM · Wikimedia-Site-requests, AbuseFilter
Krinkle added a comment to T173889: Rename AbuseFilter var article_text to article_title.

For the record, yes: Renaming article_ to page_ should also be done. Thanks for spotting that.

Thu, Feb 22, 10:37 PM · Patch-For-Review, AbuseFilter
Krinkle added a comment to T186774: Migrate webperf from hafnium to webperf1001.

Also, reminds me, we need to make sure that the parameters for kafka_brokers and statsd destination are injected through Puppet in such a way that automatically notifies/restarts the service when they change. As far as I know, Puppet doesn't track Hiera variables over time, so there's no detection there, but as long as they're written to disk somewhere, change detection (notify) should work. Given we invoke the service via systemd unit files, I'd assume this all just works as intended, but would be good to verify at least once after we've got both servers up and running (maybe by making a no-op change to the kafka_brokers list at some point).

Thu, Feb 22, 8:02 PM · Performance-Team
Krinkle added a comment to T186774: Migrate webperf from hafnium to webperf1001.

[..] So, we'd have a consumer running in each DC, both connected to the same Kafka topic, which receives all messages. Presuming that one consumer is able to keep up with the rate of messages coming in, two consumers won't be slower, regardless of the cross-DC latency.

Thu, Feb 22, 7:38 PM · Performance-Team
Krinkle added a comment to T187980: Memcached error "A TIMEOUT OCCURRED" for key "WANCache:v:enwiki:sidebar:en".

@aaron What is the impact currently on this Memcached error happening during a web request? Is there a fallback? Do we show a stale sidebar? Empty sidebar? Complete error page?

Thu, Feb 22, 7:22 PM · Performance-Team, Wikimedia-log-errors, MediaWiki-Cache, MediaWiki-Interface
Krinkle added a comment to T150011: Fresh Mediawiki + Math install gives Restbase URL error.

[..] Because we don't have a strategy to remove either A or B from the defaults?

Thu, Feb 22, 7:20 PM · Patch-For-Review, Math
Krinkle added a subtask for T127328: Optimise critical rendering path: T175866: Wikipedia triggers multiple 20ms+ browser hangs for restyles for separate "addEmbeddedCSS" calls.
Thu, Feb 22, 9:12 AM · Epic, Performance-Team
Krinkle added a parent task for T175866: Wikipedia triggers multiple 20ms+ browser hangs for restyles for separate "addEmbeddedCSS" calls: T127328: Optimise critical rendering path.
Thu, Feb 22, 9:12 AM · Performance-Team, MediaWiki-ResourceLoader
Krinkle added a comment to T175866: Wikipedia triggers multiple 20ms+ browser hangs for restyles for separate "addEmbeddedCSS" calls.

Ran into two problems:

  1. It changed the order of stylesheets, making it FIFO instead of based on dependency tree. This broke cascading expectations (makes sense, solvable problem).
  2. Modules that result in failure can no longer propagate their error in a preventive manner, because the depending module's styles were already inserted and shown to the user.
Thu, Feb 22, 9:12 AM · Performance-Team, MediaWiki-ResourceLoader
Krinkle merged task T182353: FlaggedRevs / invalid file timestamps? into T155090: passing invalid timestamp in url for a file returns fatal.
Thu, Feb 22, 8:22 AM · MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors
Krinkle merged T182353: FlaggedRevs / invalid file timestamps? into T155090: passing invalid timestamp in url for a file returns fatal.
Thu, Feb 22, 8:22 AM · MediaWiki-File-management, Multimedia, MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors
Krinkle merged task T187982: File page lookup for oldimage causes fatal if timestamp is invalid into T155090: passing invalid timestamp in url for a file returns fatal.
Thu, Feb 22, 8:22 AM · MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors, Multimedia, MediaWiki-File-management, Commons
Krinkle merged T187982: File page lookup for oldimage causes fatal if timestamp is invalid into T155090: passing invalid timestamp in url for a file returns fatal.
Thu, Feb 22, 8:22 AM · MediaWiki-File-management, Multimedia, MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors
Krinkle edited projects for T155090: passing invalid timestamp in url for a file returns fatal, added: MediaWiki-File-management; removed Commons.
Thu, Feb 22, 8:22 AM · MediaWiki-File-management, Multimedia, MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors
Krinkle added a project to T187982: File page lookup for oldimage causes fatal if timestamp is invalid: MediaWiki-extensions-FlaggedRevs.
Thu, Feb 22, 8:21 AM · MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors, Multimedia, MediaWiki-File-management, Commons
Krinkle created T187982: File page lookup for oldimage causes fatal if timestamp is invalid.
Thu, Feb 22, 8:20 AM · MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors, Multimedia, MediaWiki-File-management, Commons
Krinkle created T187980: Memcached error "A TIMEOUT OCCURRED" for key "WANCache:v:enwiki:sidebar:en".
Thu, Feb 22, 8:12 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-Cache, MediaWiki-Interface
Krinkle closed T121187: Memcached error "SERVER ERROR" from nutcracker as Declined.

Closing for now in favour more recent and more specific tasks about memcached/nutcracker issues in wmf-production.

Thu, Feb 22, 8:00 AM · MediaWiki-Cache, Wikimedia-log-errors
Krinkle updated the task description for T64913: Global user contributions: Implement "Show blocks" feature.
Thu, Feb 22, 7:39 AM · Tool-Global-user-contributions
Krinkle added a comment to T150011: Fresh Mediawiki + Math install gives Restbase URL error.

What we typically do [to avoid this problem] is:

$wgMathValidModes['png'] = true;

In extension.json we'd default everything set to true in an assoc array, and if people want to disable it in LocalSettings.php, they'd set it to false. We did a similar transition in VisualEditor where we introduced a new config setting in the assoc array form [..]

Thu, Feb 22, 7:16 AM · Patch-For-Review, Math
Krinkle added a comment to T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis.

[..] maintenance script that runs in a loop and at the end of each iteration waits for replication to catch up. The decision whether to continue with the next iteration or exit the script would be done after waiting for lag to settle, [..] all maintenance scripts should work that way. But probably not all do, it seems more realistic to have this solved in foreachwiki(indblist) than to find and fix all maintenance scripts.

Thu, Feb 22, 4:41 AM · MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
Krinkle added a comment to T114700: Monolog added "ip" is REMOTE_ADDR and does not honor XFF headers.

There have been various conversations about this on IRC and Gerrit but just writing back here for the record:

Thu, Feb 22, 2:03 AM · MediaWiki-Debug-Logger

Wed, Feb 21

Krinkle added a project to T164860: Update Echo's caching strategy for multi-dc compatibility: Availability (Multiple-active-datacenters).
Wed, Feb 21, 11:25 PM · Availability (Multiple-active-datacenters), Collaboration-Team-Triage, Notifications
Krinkle renamed T164504: Tracking: Cleanup x1 database connection patterns from Cleanup x1 database connection patterns to Tracking: Cleanup x1 database connection patterns.
Wed, Feb 21, 11:25 PM · Availability (Multiple-active-datacenters), DBA
Krinkle moved T185303: safemode parameter doesn't work with VE from Backlog to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Wed, Feb 21, 10:43 PM · MediaWiki-ResourceLoader, Performance-Team, VisualEditor-MediaWiki, Patch-For-Review, VisualEditor
Krinkle moved T187869: Drop Grade A support for IE10 from Inbox to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Wed, Feb 21, 10:43 PM · VisualEditor (Current work), MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), User-notice, Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle added a project to T187942: Replication lag detection broken in wmf.22: Performance-Team.
Wed, Feb 21, 10:41 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), User-notice, Patch-For-Review, Performance-Team, MediaWiki-Database, Wikimedia-log-errors
Krinkle renamed T187334: Use Paint Timing API instead of deprecated chrome.loadTimes() where possible from Stop using deprecated method, switch to standard API to Use Paint Timing API instead of deprecated chrome.loadTimes() where possible.
Wed, Feb 21, 10:06 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle closed T179619: Consider aligning Chrome firstPaint with navStart (or fetchStart) as Declined.

Closing this in favour of T187334 and T104902.

Wed, Feb 21, 10:05 PM · Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle added a comment to T181636: Content service incorrectly reports article as "deleted".

@Pchelolo Do you think this could be the case of T184556, as well?

Wed, Feb 21, 9:57 PM · Services (done), Reading-Infrastructure-Team-Backlog
Krinkle closed T184653: Create "Declined" column on TechCom-RFC as Resolved.
Wed, Feb 21, 9:37 PM · TechCom
Krinkle triaged T184791: Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits as Normal priority.
Wed, Feb 21, 9:15 PM · MediaWiki-API, MediaWiki-Recent-changes, MediaWiki-Patrolling
Krinkle closed T180630: Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures as Resolved.
Wed, Feb 21, 8:51 PM · Performance-Team, Continuous-Integration-Config
Krinkle renamed T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars from MWDebugTest::testAppendDebugInfoToApiResultXmlFormat failing when using DevelopmentSettings.php to MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.
Wed, Feb 21, 7:57 PM · NewPHP, MediaWiki-Core-Tests
Krinkle placed T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars up for grabs.
Wed, Feb 21, 7:55 PM · NewPHP, MediaWiki-Core-Tests
Krinkle closed T50739: JS & Display Issues on Preferences page on IE 10 on Windows 8 64bit in Compatibility mode (1920*1080px) as Declined.

The wiki at http://giprs.org/en/index.php/Main_Page now uses MediaWiki 1.21 which has been unsupported since 2014 (3 years ago). Even in Chrome there are numerous JavaScript issues, some due to running old MediaWiki on new browsers which no longer work the same way, and also possibly due to site scripts and/or extensions interfering.

Wed, Feb 21, 7:21 PM · TestMe, MediaWiki-General-or-Unknown, Browser-Support-Internet-Explorer
Krinkle added a project to T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis: MediaWiki-Maintenance-scripts.
Wed, Feb 21, 9:01 AM · MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
Krinkle added a comment to T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis.

@demon As far as I know, individual maintenance scripts (even if run via foreachwiki) already take care of wait-for-replag, and in case of major writes, they typically also have a configurable sleep cycle, which can be passed down from foreachwiki. Is this not working well and/or what are you looking for specifically?

Wed, Feb 21, 9:01 AM · MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
Krinkle updated the task description for T185952: EventLogging broken in beta.
Wed, Feb 21, 8:45 AM · Analytics-Kanban, User-Elukey, Beta-Cluster-Infrastructure, Analytics-EventLogging
Krinkle added a comment to T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.

@Anomie Can we adapt the test to not absorb this global state? E.g. by mocking or disabling those debug logs for the purpose of this unit test?

Wed, Feb 21, 8:44 AM · NewPHP, MediaWiki-Core-Tests
Krinkle added a comment to T143791: Enable RecentChanges patrolling on English Wikipedia.

Is there a permission that will prevent a user's edits from being flagged by ORES? I would guess autopatrol but I recall seeing an autopatrolled user showing up in red, I think.

I'm just wondering that if there is a new user right, we'll need to create and monitor a new "requests for permissions" page. If there's an existing user right we'll need to rethink criteria for granting it. E.g. autopatrolled is currently only for mainspace articles.

Wed, Feb 21, 8:43 AM · Scoring-platform-team, Wikimedia-Site-requests, Community-consensus-needed
Krinkle edited projects for T154552: ApiLogin should not open master connection to centralauth DB, added: Availability (Multiple-active-datacenters); removed Availability.
Wed, Feb 21, 5:49 AM · Availability (Multiple-active-datacenters), MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth
Krinkle updated the task description for T154552: ApiLogin should not open master connection to centralauth DB.
Wed, Feb 21, 5:48 AM · Availability (Multiple-active-datacenters), MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth

Tue, Feb 20

Krinkle added a comment to T180630: Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures.

I thought this was about a distinction between "errors" and "warnings". The CheckStyle report talks about "0 warnings" where the console output includes <error> tags. However, it seems unlikely that "errors" would be considered less important than "warnings".

Tue, Feb 20, 10:33 PM · Performance-Team, Continuous-Integration-Config
Krinkle renamed T180630: Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures from Jenkins isn't showing mediawiki-core-php70-phan-docker failure output to Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures.
Tue, Feb 20, 10:31 PM · Performance-Team, Continuous-Integration-Config
mmodell awarded T187761: Proposal: Effective immediately, disallow multi-sync patch deployment a Like token.
Tue, Feb 20, 4:06 PM · MediaWiki-SWAT-deployments, Release-Engineering-Team
Krinkle awarded T185383: iabot flagged as a malicious agent by external sites a Orange Medal token.
Tue, Feb 20, 5:13 AM · InternetArchiveBot (v1.6), cloud-services-team, Tools
Krinkle moved T185303: safemode parameter doesn't work with VE from Next-up to Doing on the Performance-Team board.
Tue, Feb 20, 5:09 AM · MediaWiki-ResourceLoader, Performance-Team, VisualEditor-MediaWiki, Patch-For-Review, VisualEditor
Krinkle removed a parent task for T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7): T150912: Class 'Memcached' not found when running mwscript eval.php on debug servers.
Tue, Feb 20, 5:02 AM · Release-Engineering-Team (Someday), Deployments, User-Joe, Beta-Cluster-reproducible, HHVM, Operations
Krinkle removed a subtask for T150912: Class 'Memcached' not found when running mwscript eval.php on debug servers: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7).
Tue, Feb 20, 5:02 AM · Wikimedia-General-or-Unknown, Operations
Krinkle closed T150912: Class 'Memcached' not found when running mwscript eval.php on debug servers as Declined.

Closing in favour of T146285. Any hosts on which mwscript is meant to be used (maintenance hosts, deployment hosts, dump hosts) have php5 packages enabled so that things like Memcached works. If there are any other uses of php5 in production that interact with MediaWiki and are missing these packages, they would break very early on with a fatal for undefined class. There is no further action item for this task, other than: Remember to install php5 packages before using php5 on a server - which we have now done all all known cases.

Tue, Feb 20, 5:02 AM · Wikimedia-General-or-Unknown, Operations
Krinkle updated the task description for T161598: Monitor HHVM bytecode cache depletion on mediawiki app servers.
Tue, Feb 20, 4:57 AM · Patch-For-Review, monitoring, HHVM, Operations
Krinkle updated subscribers of T187761: Proposal: Effective immediately, disallow multi-sync patch deployment.
Tue, Feb 20, 4:22 AM · MediaWiki-SWAT-deployments, Release-Engineering-Team
Krinkle added a comment to T54542: User preferences are inconsistently stored (bool/int as default, string for overrides).

@Samwilson I'd recommend tracking that as a separate task because it involves explicitly changing the format of a preference key, and none of the array-like use cases you mentioned are subject to normalisation inconsistencies.

Tue, Feb 20, 4:21 AM · JavaScript, MediaWiki-User-preferences
Krinkle renamed T187761: Proposal: Effective immediately, disallow multi-sync patch deployment from Proposal: Effective immediately, disallow multi-file or multi-dir patch deployment to Proposal: Effective immediately, disallow multi-sync patch deployment.
Tue, Feb 20, 4:17 AM · MediaWiki-SWAT-deployments, Release-Engineering-Team
Krinkle created T187761: Proposal: Effective immediately, disallow multi-sync patch deployment.
Tue, Feb 20, 4:16 AM · MediaWiki-SWAT-deployments, Release-Engineering-Team
Krinkle added a comment to T186680: Inconsistent success using PerformanceInspector.

@Peter At least one thing to address is that we currently have a logic mismatch between adding a link to the sidebar (onBaseTemplateToolbox) and loading the modules which add the click handler (onBeforePageDisplay). In one we only check the user preference, in the other we also check the page title namespace. We should use the same logic in both.

Tue, Feb 20, 12:10 AM · Performance-Team, PerformanceInspector

Mon, Feb 19

Krinkle placed T187754: Figure out why HHVM isn't using error_document404 setting up for grabs.
Mon, Feb 19, 11:58 PM · Operations, Wikimedia-General-or-Unknown
Krinkle updated the task description for T187754: Figure out why HHVM isn't using error_document404 setting.
Mon, Feb 19, 11:58 PM · Operations, Wikimedia-General-or-Unknown
Krinkle created T187754: Figure out why HHVM isn't using error_document404 setting.
Mon, Feb 19, 11:54 PM · Operations, Wikimedia-General-or-Unknown
Krinkle moved T180183: Profiling for X-Wikimedia-Debug seems to start fairly late from Next-up to Doing on the Performance-Team board.
Mon, Feb 19, 11:24 PM · Patch-For-Review, MediaWiki-General-or-Unknown, Performance-Team
Krinkle added a comment to T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.

Change 412823 merged by jenkins-bot:
[mediawiki/core@master] tests: Remove verbose logging settings from DevelopmentSettings.php

https://gerrit.wikimedia.org/r/412823

Mon, Feb 19, 10:53 PM · NewPHP, MediaWiki-Core-Tests
Krinkle claimed T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.
Mon, Feb 19, 10:16 PM · NewPHP, MediaWiki-Core-Tests
Krinkle added a comment to T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.

The only difference between the two implementations of dev settings are these lines, which were added to DevelopmentSettings.php after the initial import from integration/jenkins.git

Mon, Feb 19, 10:16 PM · NewPHP, MediaWiki-Core-Tests
Krinkle awarded T39230: Provide standard way to create/run QUnit tests for Gadgets and user scripts a Orange Medal token.
Mon, Feb 19, 10:14 PM · JavaScript, Gadgets
Krinkle awarded T53651: Auto-generated gadget code documentation a Orange Medal token.
Mon, Feb 19, 10:14 PM · Documentation, JavaScript, Wikimedia-General-or-Unknown
Krinkle added a comment to T185234: Create boilerplate and shared infra for service instrumentation.

So, given Python isn't super easy to instrument it seems (no support for creating a perf-map). Let's keep looking for another relatively simple service to instrument. Perhaps one of the Node.js services. Or maybe even on MediaWiki itself using HHVM on a subset of servers (e.g. mwdebug, or the canary servers).

Mon, Feb 19, 10:12 PM · Performance-Team
Krinkle removed a parent task for T185234: Create boilerplate and shared infra for service instrumentation: T185235: Add profiling for webperf/navtiming.
Mon, Feb 19, 10:11 PM · Performance-Team
Krinkle removed a subtask for T185235: Add profiling for webperf/navtiming: T185234: Create boilerplate and shared infra for service instrumentation.
Mon, Feb 19, 10:11 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle closed T185235: Add profiling for webperf/navtiming as Declined.

Per @Imarlier, seems Python doesn't have a good production-level (sampled) profiling story right now. If really needed, we could make this work for a different Python service, but the purpose of this task was to do it for a simple service first, to validate the bootstrapping work of T185234. Given navtiming won't be the "simple and perf-compatible service" we were looking for, closing this in favour of a to-be-determined other service to instrument.

Mon, Feb 19, 10:11 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Krinkle closed T185235: Add profiling for webperf/navtiming, a subtask of T147101: Uniform performance insight for different services (tracking), as Declined.
Mon, Feb 19, 10:11 PM · Epic, Performance-Team