Krinkle (Timo Tijhof)
Principal Performance Engineer, Wikimedia Foundation

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (201 w, 3 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

Recent Activity

Today

Krinkle removed projects from T107377: Change load.php to minify per-module instead of per-request: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)).
Sat, Aug 18, 1:22 AM · Performance-Team, MW-1.27-release-notes, WMF-deploy-2015-09-22_(1.26wmf24), MediaWiki-ResourceLoader

Yesterday

Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 11:54 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 11:51 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle removed a project from T201606: Bad newline after return statement by JavaScript minifier: Patch-For-Review.
Fri, Aug 17, 7:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Performance-Team, MediaWiki-ResourceLoader
Krinkle closed T201606: Bad newline after return statement by JavaScript minifier as Resolved.

The unreachable code after return statement warning no longer appears for me in Firefox at https://en.wikipedia.beta.wmflabs.org/wiki/Sandbox. Marking as resolved.

Fri, Aug 17, 7:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Performance-Team, MediaWiki-ResourceLoader
Krinkle closed T201606: Bad newline after return statement by JavaScript minifier, a subtask of T191064: 1.32.0-wmf.18 deployment blockers, as Resolved.
Fri, Aug 17, 7:32 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Krinkle added a comment to T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken, but the problem is rare and intermittent.

When both of these modules are loaded as style-only modules (using addModuleStyles() in PHP), everything works fine [..]. But when they are loaded as dependencies from JS code, the order is unspecified.

Fri, Aug 17, 7:29 PM · Patch-For-Review, User-Ryasmeen, VisualEditor (Current work)
Krinkle added a comment to T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken, but the problem is rare and intermittent.

Is there a task about supporting dependencies for style-only modules?

Fri, Aug 17, 7:25 PM · Patch-For-Review, User-Ryasmeen, VisualEditor (Current work)
Krinkle closed T195430: mwgate-composer-hhvm-docker times out on medawiki-vendor as Resolved.

Yeah, let's assume that for now. Anyone re-open if it pops up again.

Fri, Aug 17, 6:42 PM · Continuous-Integration-Config, Wikimedia-log-errors (Shared Build Failure)
Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 6:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 6:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T159911: Audit modules (2017).
Fri, Aug 17, 6:29 PM · MW-1.29-release-notes, Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T202154: Audit modules (2018) from Inbox to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Fri, Aug 17, 6:27 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 6:27 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T202154: Audit modules (2018).
Fri, Aug 17, 6:21 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle added commits to T202154: Audit modules (2018): rMW15eac4c27939: mediawiki.special: Combine various tiny specialpage style modules, rMWb07b326476ef: mediawiki.special.watchlist: Combine visitedstatus module, rEUWI1b9ff2f90847: Merge most of UploadWizard's modules into one, rMW5bf64e7f7231: Remove the unused 'jquery.farbtastic' module, rMW20a0be5ed552: Remove deprecated 'dom-level2-shim' module, rMWf1d815f528e9: Remove deprecated 'json' module, rMWe61f2628beff: mediawiki.debug: Move internal footHovzer to the same module.
Fri, Aug 17, 6:19 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T192623: ResourceLoader 2018 Review.
Fri, Aug 17, 6:18 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle updated the task description for T127328: Optimise critical rendering path.
Fri, Aug 17, 6:18 PM · Epic, Performance-Team
Krinkle created T202154: Audit modules (2018).
Fri, Aug 17, 6:17 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team
Krinkle edited projects for T115890: Reduce and clarify ObjectCache entry points, added: Technical-Debt (Deprecation); removed Technical-Debt.
Fri, Aug 17, 5:56 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Technical-Debt (Deprecation), Core-Platform-Team, Performance-Team (Radar), MediaWiki-Configuration, MediaWiki-Cache
Krinkle triaged T202151: Avoid jquery.accessKeyLabel computation in addPortletLink() when possible as High priority.
Fri, Aug 17, 5:20 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-Interface, Performance-Team
Krinkle moved T202149: Exception thrown for failure to save settings appears ~ 1000 times/day from Backlog to Production Impact on the Wikimedia-log-errors board.
Fri, Aug 17, 4:31 PM · Patch-For-Review, BetaFeatures, Wikimedia-log-errors, MediaWiki-Authentication-and-authorization
Krinkle edited projects for T202149: Exception thrown for failure to save settings appears ~ 1000 times/day, added: BetaFeatures; removed MediaWiki-API.
Fri, Aug 17, 4:31 PM · Patch-For-Review, BetaFeatures, Wikimedia-log-errors, MediaWiki-Authentication-and-authorization
Krinkle added a project to T202149: Exception thrown for failure to save settings appears ~ 1000 times/day: Wikimedia-log-errors.
Fri, Aug 17, 4:30 PM · Patch-For-Review, BetaFeatures, Wikimedia-log-errors, MediaWiki-Authentication-and-authorization
Krinkle added a comment to T202149: Exception thrown for failure to save settings appears ~ 1000 times/day.

Here's that same error but as reported to the exception log, which is a bit easier to read (no json).

Fri, Aug 17, 4:30 PM · Patch-For-Review, BetaFeatures, Wikimedia-log-errors, MediaWiki-Authentication-and-authorization
Krinkle moved T202129: Use MediaWiki JavaScript API instead of custom code from Unsorted to Migrate / Replace on the Technical-Debt board.
Fri, Aug 17, 4:25 PM · Patch-For-Review, JavaScript, Technical-Debt, MediaWiki-extensions-PageCuration, Growth-Team (Current Sprint)
Krinkle added a comment to T201686: Cache issue in load.php.

Can you try it on https://test.wikipedia.org? I've just granted you sysop there for 1 year.

Fri, Aug 17, 4:05 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle closed T201782: Remove use of StartProfiler.php in wmf production as Resolved.
Fri, Aug 17, 3:24 AM · Technical-Debt (Deprecation), Performance-Team
Krinkle closed T201782: Remove use of StartProfiler.php in wmf production, a subtask of T189966: Audit and simplify MediaWiki initialisation code (Spring 2018), as Resolved.
Fri, Aug 17, 3:24 AM · Core-Platform-Team, Technical-Debt, MediaWiki-General-or-Unknown, Performance-Team
Krinkle removed projects from T187207: Spin out a tiny EventLogging RL module for lightweight logging: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
Fri, Aug 17, 3:24 AM · Patch-For-Review, Analytics-Kanban, Performance-Team (Radar), Analytics-EventLogging, Analytics
Krinkle added a comment to T201974: Deprecation of API "action=query&prop=revisions&!rvslots".

Leaving open until the RESTBase change is deployed and we've confirmed at https://logstash.wikimedia.org/app/kibana#/dashboard/api-feature-usage that the !rvslots pattern no longer has WMF user-agent hits.

Fri, Aug 17, 3:23 AM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team
Krinkle awarded T187207: Spin out a tiny EventLogging RL module for lightweight logging a Orange Medal token.
Fri, Aug 17, 1:29 AM · Patch-For-Review, Analytics-Kanban, Performance-Team (Radar), Analytics-EventLogging, Analytics

Thu, Aug 16

Krinkle added a comment to T201686: Cache issue in load.php.

I suspect this may've been due to T199416 which is now fixed.

Thu, Aug 16, 10:06 PM · MediaWiki-ResourceLoader, Performance-Team
Krinkle removed a member for Wikimedia-Stream: Krinkle.
Thu, Aug 16, 9:58 PM
Krinkle removed a member for JavaScript: Krinkle.
Thu, Aug 16, 9:58 PM
Krinkle updated the task description for T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook.
Thu, Aug 16, 9:54 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Wikidata-Campsite, Patch-For-Review, User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team
Krinkle updated the task description for T202017: Remove indirection of TimedMediaHandler module registration.
Thu, Aug 16, 8:35 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TimedMediaHandler, Performance-Team
Krinkle closed T202017: Remove indirection of TimedMediaHandler module registration as Resolved.

Yes! Thank you.

Thu, Aug 16, 8:33 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TimedMediaHandler, Performance-Team
Krinkle closed T202017: Remove indirection of TimedMediaHandler module registration, a subtask of T189966: Audit and simplify MediaWiki initialisation code (Spring 2018), as Resolved.
Thu, Aug 16, 8:33 PM · Core-Platform-Team, Technical-Debt, MediaWiki-General-or-Unknown, Performance-Team
Krinkle added a comment to T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook.

I'd recommend considering Message::text() instead of Message::parse(). This would disallow templates and parser functions, which aren't currently used in those messages.

Thu, Aug 16, 8:31 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Wikidata-Campsite, Patch-For-Review, User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team
Krinkle created T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook.
Thu, Aug 16, 8:29 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Wikidata-Campsite, Patch-For-Review, User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team
Krinkle updated the task description for T201974: Deprecation of API "action=query&prop=revisions&!rvslots".
Thu, Aug 16, 8:26 PM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team
Krinkle updated the task description for T201974: Deprecation of API "action=query&prop=revisions&!rvslots".
Thu, Aug 16, 8:24 PM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team
Krinkle updated the task description for T201974: Deprecation of API "action=query&prop=revisions&!rvslots".
Thu, Aug 16, 8:16 PM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team
Krinkle added a comment to T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).

The nice things about DIY output compression are:

  • It's on by default, so it helps site admins who would never think to tweak their web server settings
Thu, Aug 16, 7:08 PM · Core-Platform-Team, Technical-Debt, MediaWiki-General-or-Unknown, Performance-Team
Krinkle added a comment to T201124: Provide standard/reproducible way to access a PageToken.

@Tbayer If I understand correctly, you're stating that the current token is unique enough for our purposes. That's good to hear and obsoletes most of my other questions.

Thu, Aug 16, 7:02 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Krinkle closed T28243: $wgUseGzip is not working as Resolved.

Seems to work on currently supported versions.

Thu, Aug 16, 6:41 PM · TestMe, MediaWiki-General-or-Unknown
Krinkle claimed T202017: Remove indirection of TimedMediaHandler module registration.
Thu, Aug 16, 6:27 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TimedMediaHandler, Performance-Team
Krinkle closed T28306: Cleanup extensions that include jquery (and common plugins) themselves as Resolved.

Per T28307.

Thu, Aug 16, 6:24 PM · WorkType-NewFunctionality, JavaScript, Technical-Debt, MediaWiki-extensions-General
Krinkle closed T28307: Upgrade old versions of jquery (and plugins) as Resolved.

Looks resolved.

Thu, Aug 16, 6:24 PM · JavaScript, WorkType-NewFunctionality, MediaWiki-extensions-General
Krinkle closed T28307: Upgrade old versions of jquery (and plugins), a subtask of T28306: Cleanup extensions that include jquery (and common plugins) themselves, as Resolved.
Thu, Aug 16, 6:24 PM · WorkType-NewFunctionality, JavaScript, Technical-Debt, MediaWiki-extensions-General
Krinkle closed T201453: Flaky test case in SimpleCacheWithBagOStuffTest as Resolved.
Thu, Aug 16, 5:59 PM · Wikimedia-log-errors (Shared Build Failure), Wikidata, MediaWiki-extensions-WikibaseClient
Krinkle removed projects from T195807: Fix failing MediaWiki core tests on Postgres database backend: MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review.
Thu, Aug 16, 5:58 PM · Wikimedia-log-errors (Shared Build Failure), PostgreSQL, MediaWiki-Core-Tests
Krinkle moved T195807: Fix failing MediaWiki core tests on Postgres database backend from In progress to Resolved on the Wikimedia-log-errors (Shared Build Failure) board.
Thu, Aug 16, 5:58 PM · Wikimedia-log-errors (Shared Build Failure), PostgreSQL, MediaWiki-Core-Tests
Krinkle moved T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion from In progress to Resolved on the Wikimedia-log-errors (Shared Build Failure) board.
Thu, Aug 16, 5:58 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Wikimedia-log-errors (Shared Build Failure), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Core-Tests
Krinkle closed T201976: Flaky unit test MergeHistoryTest::testIsValidMerge as Resolved.
Thu, Aug 16, 5:58 PM · Performance-Team, MediaWiki-Core-Tests, MediaWiki-Special-pages, Wikimedia-log-errors (Shared Build Failure)
Krinkle added a project to T193628: tungsten disk 1 and 8 SMART failure: Performance-Team.
Thu, Aug 16, 5:55 PM · Performance-Team, ops-eqiad, Operations
Krinkle moved T195312: Move flame graphs hosting from mwlog1001 to webperf-2 and enable in Beta Cluster from Blocked to Doing on the Performance-Team board.
Thu, Aug 16, 5:55 PM · Performance-Team
Krinkle added projects to T202059: Bug in Chrome with Cyrillic strings in CodeEditor, cursor position shows on the wrong place: CodeEditor, VisualEditor.
Thu, Aug 16, 5:42 PM · Browser-Support-Google-Chrome, CodeEditor
Krinkle closed T31606: Error in LinkHolderArray::replaceInternal function as Declined.

Closing as this isn't actionable. The report is from 2011, imported from BugZilla for a user who does not have a Phabricator account, and the original report does not contain enough details to act on.

Thu, Aug 16, 5:33 PM · MediaWiki-Database
Krinkle updated the task description for T29300: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field.
Thu, Aug 16, 5:31 PM · Multimedia, Commons, MediaWiki-File-management, MediaWiki-Database
Krinkle moved T29300: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field from Backlog to Usage problem on the MediaWiki-Database board.
Thu, Aug 16, 5:31 PM · Multimedia, Commons, MediaWiki-File-management, MediaWiki-Database
Krinkle added a comment to T29300: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field.

Note that the "search" feature of Special:ListFiles is disabled on wikis hosted by the Wikimedia Foundation, via the wgMiserMode setting. As such, this problem does not apply to Wikimedia Commons, Wikipedia, their sister projects, including test wikis and beta cluster.

Thu, Aug 16, 5:31 PM · Multimedia, Commons, MediaWiki-File-management, MediaWiki-Database
Krinkle renamed T29300: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field from FileSearch does not work with MySQL due to "LOWER(img_name)" to Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field.
Thu, Aug 16, 5:28 PM · Multimedia, Commons, MediaWiki-File-management, MediaWiki-Database
Krinkle edited Description on MediaWiki-File-management.
Thu, Aug 16, 5:28 PM
Krinkle moved T202057: BadMethodCallException from line 98 of ApiCategoryTree.php: Call to a member function getDBkey() on a non-object from Backlog to Production Impact on the Wikimedia-log-errors board.
Thu, Aug 16, 5:16 PM · Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-CategoryTree
Krinkle added a comment to T202073: Flaky unit test AbuseFilterConsequencesTest.

@Daimona @Huji Could you re-review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/444442/ to see if there's anything that stands out that could explain the test sometimes failing? If not, it is also possible that the failure is caused by a change in core or another extension.

Thu, Aug 16, 4:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Technical-Debt, AbuseFilter, Wikimedia-log-errors (Shared Build Failure)
Krinkle updated subscribers of T202073: Flaky unit test AbuseFilterConsequencesTest.
Thu, Aug 16, 4:40 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Technical-Debt, AbuseFilter, Wikimedia-log-errors (Shared Build Failure)
Krinkle created T202073: Flaky unit test AbuseFilterConsequencesTest.
Thu, Aug 16, 4:40 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Technical-Debt, AbuseFilter, Wikimedia-log-errors (Shared Build Failure)

Wed, Aug 15

Krinkle added a comment to T201719: Tracking blocks: Log when the mobile web editor block notice is displayed.

One thing to note about Graphite [..] is that over time the completeness and and correctness of the data it has degrades. [..] trying to use Graphite data to compare time periods across months and the data is just never comparable. [..]

Wed, Aug 15, 11:51 PM · Anti-Harassment
Krinkle added a comment to T188937: Replace jQuery.Deferred.done/fail/always().

Given we support IE11, we cannot do this right?
https://caniuse.com/#feat=promises

Wed, Aug 15, 11:11 PM · Patch-For-Review, MobileFrontend (MobileFrontend.js), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Readers-Web-Kanbanana-Board, MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Technical-Debt, Readers-Web-Backlog
Krinkle added a comment to T201124: Provide standard/reproducible way to access a PageToken.

@Tbayer Is it important for the consumption of the Popups schema and other event data that the timestamp is included in the token? It might be easier, as well as simpler and more secure, if this is done during the consuming of the data.

Wed, Aug 15, 10:52 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Krinkle awarded T197110: [Bug] Changing gallery images causes an abrupt and jarring white flash a Orange Medal token.
Wed, Aug 15, 10:29 PM · MinervaNeue, Readers-Web-Backlog
Krinkle closed T194396: Create a hook like AfterFinalPageOutput with the cacheability of the page as Resolved.
Wed, Aug 15, 8:18 PM · MediaWiki-Interface, TechCom
Krinkle added a comment to T202026: Report client-side JavaScript errors in MobileFrontend practically.

Two quick notes:

Wed, Aug 15, 8:14 PM · Readers-Web-Backlog
Krinkle added a comment to T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook.

Why was this not picked up in CI?

Wed, Aug 15, 7:47 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Technical-Debt (Deprecation), Performance-Team, MediaWiki-ResourceLoader
Krinkle triaged T202017: Remove indirection of TimedMediaHandler module registration as Normal priority.
Wed, Aug 15, 6:07 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), TimedMediaHandler, Performance-Team
Krinkle added a comment to T187207: Spin out a tiny EventLogging RL module for lightweight logging.

[..] would it make sense to [..] log an event when an event fails validation on the client?

Wed, Aug 15, 5:35 PM · Patch-For-Review, Analytics-Kanban, Performance-Team (Radar), Analytics-EventLogging, Analytics
Krinkle added a comment to T201992: Benchmarker should support per-iteration non-counted setup.

Most benchmarkers I've used do not have this option. It might be worth considering whether the iterated code can be changed in a way to produce the expected results "within" the current model. I don't have many ideas off-hand, but one thing might be to have a way to disable the (static?) caches. Would that suffice?

Wed, Aug 15, 2:49 PM · MediaWiki-Maintenance-scripts
Krinkle added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

[...] or you could change the style rule to .navbox + link + .navbox.

Wed, Aug 15, 2:47 PM · Performance, MediaWiki-Parser, TemplateStyles
Krinkle awarded T188767: jQuery.ime performs two DOM queries on every keydown a Orange Medal token.
Wed, Aug 15, 2:45 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Language-2018-July-September, Performance-Team (Radar), Performance, UniversalLanguageSelector
Krinkle added a project to T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array.: VisualEditor.
Wed, Aug 15, 5:21 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-log-errors, ProofreadPage
Krinkle added a project to T196684: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380: VisualEditor.
Wed, Aug 15, 5:20 AM · VisualEditor, Editing-team, MediaWiki-extensions-Quiz, Wikimedia-log-errors
Krinkle added a comment to T201972: Add some more m4executor docker slaves for Jenkins.

In numbers:

Wed, Aug 15, 4:04 AM · Release-Engineering-Team, Continuous-Integration-Infrastructure
Krinkle awarded T201972: Add some more m4executor docker slaves for Jenkins a Orange Medal token.
Wed, Aug 15, 3:57 AM · Release-Engineering-Team, Continuous-Integration-Infrastructure
Krinkle closed T140804: Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook as Resolved.
Wed, Aug 15, 2:08 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Technical-Debt (Deprecation), Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T201976: Flaky unit test MergeHistoryTest::testIsValidMerge from Backlog to In progress on the Wikimedia-log-errors (Shared Build Failure) board.
Wed, Aug 15, 12:18 AM · Performance-Team, MediaWiki-Core-Tests, MediaWiki-Special-pages, Wikimedia-log-errors (Shared Build Failure)
Krinkle moved T201976: Flaky unit test MergeHistoryTest::testIsValidMerge from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Wed, Aug 15, 12:18 AM · Performance-Team, MediaWiki-Core-Tests, MediaWiki-Special-pages, Wikimedia-log-errors (Shared Build Failure)
Krinkle moved T201976: Flaky unit test MergeHistoryTest::testIsValidMerge from To triage to Move/Merge on the MediaWiki-Special-pages board.
Wed, Aug 15, 12:10 AM · Performance-Team, MediaWiki-Core-Tests, MediaWiki-Special-pages, Wikimedia-log-errors (Shared Build Failure)
Krinkle created T201976: Flaky unit test MergeHistoryTest::testIsValidMerge.
Wed, Aug 15, 12:08 AM · Performance-Team, MediaWiki-Core-Tests, MediaWiki-Special-pages, Wikimedia-log-errors (Shared Build Failure)
Krinkle removed projects from T127328: Optimise critical rendering path: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
Wed, Aug 15, 12:06 AM · Epic, Performance-Team
Krinkle removed projects from T192623: ResourceLoader 2018 Review: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
Wed, Aug 15, 12:05 AM · MediaWiki-ResourceLoader, Performance-Team
Krinkle triaged T201802: Performance review for Assert library as Normal priority.
Wed, Aug 15, 12:05 AM · Performance-Team (Radar), MediaWiki-General-or-Unknown
Krinkle updated subscribers of T201974: Deprecation of API "action=query&prop=revisions&!rvslots".
Wed, Aug 15, 12:02 AM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team
Krinkle created T201974: Deprecation of API "action=query&prop=revisions&!rvslots".
Wed, Aug 15, 12:01 AM · Services (doing), Parsoid, ChangeProp, Reading-Infrastructure-Team-Backlog, MediaWiki-API, Core-Platform-Team

Tue, Aug 14

Krinkle added a comment to T201971: Shorten logstash retention temporarily.

Could we maybe dump by channel type? api-feature-usage is by far the majority of logstash events, [..]

Tue, Aug 14, 11:59 PM · Wikimedia-Logstash, User-fgiunchedi, User-herron, Goal, Operations
Krinkle removed projects from T192862: Reduce overhead of navtiming beacon: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
Tue, Aug 14, 10:45 PM · Performance-Team, MediaWiki-extensions-NavigationTiming
Krinkle edited projects for T201900: PHP Notice: Trying to get property 'num_rows' of non-object in /home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/DatabaseMysqli.php on line 233 on PHP 7.2 travis builds, added: Performance-Team; removed Patch-For-Review.
Tue, Aug 14, 10:09 PM · Performance-Team, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-Database, Wikimedia-log-errors (Shared Build Failure)
Krinkle added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

@Legoktm @Simetrical Is there a commit we can revert meanwhile to unbreak the build? The lack of visibility has already allowed one regression to be lost in the noise - T201900.

Tue, Aug 14, 9:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Wikimedia-log-errors (Shared Build Failure), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Core-Tests
Krinkle closed T201900: PHP Notice: Trying to get property 'num_rows' of non-object in /home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/DatabaseMysqli.php on line 233 on PHP 7.2 travis builds as Resolved.
Tue, Aug 14, 9:40 PM · Performance-Team, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-Database, Wikimedia-log-errors (Shared Build Failure)