Krinkle (Timo Tijhof)
Wikimedia Foundation

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (141 w, 2 d)
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle

Recent Activity

Today

Krinkle added a comment to T168086: jQuery 3 catches all exceptions within promises.

I suggest we start by updating jQuery Migrate to at least re-enable the default logger.

Thu, Jun 22, 10:45 PM · Patch-For-Review, JavaScript, MediaWiki-ResourceLoader
Krinkle added a comment to T168086: jQuery 3 catches all exceptions within promises.

@Nikerabbit I wrote about the promise changes at T124742#3373541.

Thu, Jun 22, 10:41 PM · Patch-For-Review, JavaScript, MediaWiki-ResourceLoader
Krinkle added a comment to T124742: Upgrade to jQuery 3.

The changes to how promises work is causing quite a bit of headache to us,

Thu, Jun 22, 10:09 PM · Patch-For-Review, MW-1.29-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Krinkle closed T116721: RCStream: Investigate source of invalid JSON data as Declined.

Declining per RCStream being deprecated and scheduled to be shut down on July 7th.

Thu, Jun 22, 8:38 PM · Wikimedia-Stream
Krinkle closed T126313: occasional 502 from rcstream seen by pybal as Declined.

Declining per RCStream being deprecated and scheduled to be shut down on July 7th.

Thu, Jun 22, 8:38 PM · Wikimedia-Stream, Operations
Krinkle closed T106636: Verify that health check from rcstream load balancer actually fails if Redis backend is unavailable as Declined.

Declining per RCStream being deprecated and scheduled to be shut down on July 7th.

Thu, Jun 22, 8:37 PM · Wikimedia-Stream
Krinkle closed T86771: RCStream should remember subscriptions after socket.io re-connects as Declined.

Declining per RCStream being deprecated and scheduled to be shut down on July 7th.

Thu, Jun 22, 8:36 PM · Wikimedia-Stream
Krinkle moved T158106: Update EventBus RCFeed config to use newly refactored settings from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:35 PM · Analytics, Wikimedia-Stream
Krinkle moved T161027: Puppetize event schema topic configuration from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:35 PM · Services (designing), User-mobrovac, EventBus, Analytics, Wikimedia-Stream
Krinkle moved T167670: Expose revision-create in EventStreams from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · Analytics, Services (watching), EventBus, Wikimedia-Stream
Krinkle moved T161731: Create reliable change stream for specific wiki from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · EventBus, Wikimedia-Stream, Epic, Analytics, Wikidata-Query-Service, Discovery, Wikidata
Krinkle moved T160748: Create /v2/schema/:schema_uri endpoint for eventstreams that proxies schemas from eventbus from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · Patch-For-Review, Analytics-Kanban, Wikimedia-Stream
Krinkle moved T149736: Bikeshed what events should be exposed in public EventStreams API from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · Analytics, Services (watching), User-mobrovac, EventBus, Wikimedia-Stream
Krinkle moved T150439: Tests for swagger spec stream routes in EventStreams from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · service-template-node, Services (watching), Analytics, EventBus, Wikimedia-Stream
Krinkle moved T152731: Implement server side filtering (if we should) from Inbox to Backlog on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · Analytics, Patch-For-Review, EventBus, Wikimedia-Stream
Krinkle moved T156919: Port RCStream clients to EventStreams from Inbox to Backlog-RCStream on the Wikimedia-Stream board.
Thu, Jun 22, 8:34 PM · Analytics-Kanban, Wikimedia-Stream
Krinkle removed a parent task for T157642: Provide RC Filters to all users: T7560: Make Special:RecentChanges auto-updating.
Thu, Jun 22, 8:32 PM · Edit-Review-Improvements-RC-Page, Epic, Collaboration-Team-Triage
Krinkle removed a subtask for T7560: Make Special:RecentChanges auto-updating: T157642: Provide RC Filters to all users.
Thu, Jun 22, 8:32 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page, JavaScript, Contributors-Team, MediaWiki-Recent-changes
Krinkle added projects to T167743: Implement 'Live Updates' feature for RC page filters: Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes.
Thu, Jun 22, 8:31 PM · MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Krinkle merged task T7560: Make Special:RecentChanges auto-updating into T167743: Implement 'Live Updates' feature for RC page filters.
Thu, Jun 22, 8:31 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page, JavaScript, Contributors-Team, MediaWiki-Recent-changes
Krinkle merged T7560: Make Special:RecentChanges auto-updating into T167743: Implement 'Live Updates' feature for RC page filters.
Thu, Jun 22, 8:31 PM · MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Krinkle updated the task description for T156919: Port RCStream clients to EventStreams.
Thu, Jun 22, 8:27 PM · Analytics-Kanban, Wikimedia-Stream
Krinkle awarded T167743: Implement 'Live Updates' feature for RC page filters a Orange Medal token.
Thu, Jun 22, 7:45 PM · MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Dispenser awarded T147667: Site and Gadget CSS should apply after core and skin CSS a Yellow Medal token.
Thu, Jun 22, 3:12 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), MediaWiki-ResourceLoader, Performance-Team, Gadgets, Regression

Yesterday

Krinkle closed T147667: Site and Gadget CSS should apply after core and skin CSS as Resolved.

Indeed. Verified on the beta cluster.

Wed, Jun 21, 9:35 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), MediaWiki-ResourceLoader, Performance-Team, Gadgets, Regression
Krinkle awarded T168012: Internal server error when accessing change a Orange Medal token.
Wed, Jun 21, 7:55 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Gerrit
Krinkle added a comment to T151524: Maps fast preview is broken on 2nd attempt.

The problem is most likely that Kartographer JS code is trying to do something to the page before the dialog finishes loading.

Wed, Jun 21, 7:04 PM · Maps (Kartographer), Discovery
Krinkle raised the priority of T168086: jQuery 3 catches all exceptions within promises from Normal to High.
Wed, Jun 21, 6:56 PM · Patch-For-Review, JavaScript, MediaWiki-ResourceLoader
Krinkle removed a project from T147667: Site and Gadget CSS should apply after core and skin CSS: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).
Wed, Jun 21, 6:56 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), MediaWiki-ResourceLoader, Performance-Team, Gadgets, Regression
Krinkle closed T167465: "Key contains invalid characters" when using MultiWriteBagOStuff as Resolved.

Fixed. Error count for this dropped to 0 on 2017-06-15 when wmf.5 rolled out to all wikis:

Wed, Jun 21, 6:54 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
Krinkle added a comment to T168479: Undefined index: showDimensions in /srv/mediawiki/php-1.30.0-wmf.6/includes/gallery/ImageGalleryBase.php on line 144.

Most likely wmf-config sets the array in its entirely instead of just changing individual array keys. Depending on what we've encouraged in the past for this configuration setting, we may need to support this by moving the defaults to Setup.php or TraditionalImageGallery.php. e.g. by merging (adding) the defaults at run-time instead. We do this for several other settings already and tends to scale better as a result. Less error prone, and easier to extend in the future, for precisely this reason.

Wed, Jun 21, 5:20 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, Wikimedia-log-errors, MediaWiki-General-or-Unknown
Krinkle updated the task description for T158837: Consolidate performance website and related software.
Wed, Jun 21, 5:11 PM · Performance-Team, Operations
Krinkle added a comment to T158837: Consolidate performance website and related software.

From Ops/Perf syncup meeting today, got an overview of the current hardware used by our team:

Wed, Jun 21, 5:10 PM · Performance-Team, Operations
Krinkle updated the task description for T158837: Consolidate performance website and related software.
Wed, Jun 21, 4:51 PM · Performance-Team, Operations
Krinkle updated the task description for T158837: Consolidate performance website and related software.
Wed, Jun 21, 4:45 PM · Performance-Team, Operations
Krinkle added a comment to T167885: Regression: Backend Save Timing raised by about 50%.

I don't think this is related to HHVM 3.18; about half of the app servers and API servers in eqiad were running 3.18 since May already

Wed, Jun 21, 4:20 PM · Performance-Team
Krinkle created T168540: Understand APC size increase after HHVM upgrade/restart.
Wed, Jun 21, 4:20 PM · Operations, Performance-Team
Krinkle created T168533: Unexpected loading of VisualEditor after Special:RevisionDelete submission .
Wed, Jun 21, 3:05 PM · VisualEditor, VisualEditor-MediaWiki
Krinkle reopened T139859: Vagrant and NFS are not always the best of friends [tracking] as "Open".
Wed, Jun 21, 1:36 PM · Tracking, MediaWiki-Vagrant
Krinkle closed T139859: Vagrant and NFS are not always the best of friends [tracking] as Resolved.
Wed, Jun 21, 1:35 PM · Tracking, MediaWiki-Vagrant

Mon, Jun 19

Krinkle created T168309: Silent switch to "External link" mode disrupts cursor position.
Mon, Jun 19, 3:44 PM · VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki, VisualEditor
Krinkle updated the task description for T161588: Rework https://performance.wikimedia.org.
Mon, Jun 19, 3:15 PM · Patch-For-Review, Performance-Team
Krinkle updated the task description for T161588: Rework https://performance.wikimedia.org.
Mon, Jun 19, 3:14 PM · Patch-For-Review, Performance-Team
Krinkle added a comment to T168306: TimedMediaHandler: Embed mode should handle case of file not existing.

I noticed this particularly on Phabricator since T64270. When pasting a broken link (typo, incomplete url, etc.) or when the file was deleted mean-while, the embed is quite confusing. Especially because it renders with my personal toolbar etc.

Mon, Jun 19, 3:02 PM · TimedMediaHandler
Krinkle created T168306: TimedMediaHandler: Embed mode should handle case of file not existing.
Mon, Jun 19, 3:00 PM · TimedMediaHandler

Sun, Jun 18

Krinkle added a comment to T168040: Table of contents (TOC) missing sporadically without apparent reason.
Sun, Jun 18, 6:31 PM · MediaWiki-Parser, Regression, MediaWiki-Interface, MediaWiki-General-or-Unknown
Krinkle added a comment to T148648: False date in Category:Requests for Unblock.

Cyberbot is getting the data from the API. It probably got a null response at some point and just defaulted to unix epoch 0. I haven't seen it happen since.

Sun, Jun 18, 6:25 PM · MediaWiki-User-management

Fri, Jun 16

Krinkle triaged T166949: Homedir/UID info breaks after a while in Tools Kubernetes (can't read replica.my.cnf) as High priority.
Fri, Jun 16, 2:29 PM · Labs-Infrastructure, Labs, Tools-Kubernetes
Krinkle renamed T166949: Homedir/UID info breaks after a while in Tools Kubernetes (can't read replica.my.cnf) from multidesc: cannot connect to database due to reading wrong replica.my.cnf file to Homedir/UID info breaks after a while in Tools Kubernetes (can't read replica.my.cnf).
Fri, Jun 16, 2:29 PM · Labs-Infrastructure, Labs, Tools-Kubernetes
Krinkle added a comment to T166949: Homedir/UID info breaks after a while in Tools Kubernetes (can't read replica.my.cnf).

I ran into the same problem with tools.orphantalk. https://tools.wmflabs.org/orphantalk/ was consistently failing for over a week (according to user reports) with the following error:

Fri, Jun 16, 2:28 PM · Labs-Infrastructure, Labs, Tools-Kubernetes

Thu, Jun 15

Krinkle closed T143549: Test performance for lazy loading images as Declined.
Thu, Jun 15, 10:21 PM · Performance-Team, WebPageTest
Krinkle added a comment to T143663: According to our instrumentation Opera Mini page size increased with lazy loading of images.

The slight increase in HTML (image+placeholder+noscript, + NORLQ/Grade C loader) is imho diminishable and not a problem in this context.

Thu, Jun 15, 10:17 PM · Performance-Team, Performance
Krinkle added a comment to T148047: Desktop MediaWiki should be able to lazy load images.

It's basically a trade-off in terms of experience: do you want to sit through a somewhat longer download process at the start, but then have everything right there, or do you want to have to wait constantly every time you scroll down?

Thu, Jun 15, 9:43 PM · MediaWiki-Parser, Epic, Reading-Web-Backlog
Krinkle added a commit to T160497: Reduce column width to 25em for mobile skin - Unify responsive reference list styling of mobile and desktop: rECIT490e193f7f61: Reduce column width from 35em to 30em.
Thu, Jun 15, 9:29 PM · Editing-team, Patch-For-Review, Reading-Web-Backlog, Cite
Krinkle merged task T161788: Please reduce column width from 35 to 30em into T160497: Reduce column width to 25em for mobile skin - Unify responsive reference list styling of mobile and desktop.
Thu, Jun 15, 9:29 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), User-Ryasmeen, Community-Liaisons, VisualEditor-MediaWiki-References, VisualEditor, Cite
Krinkle merged T161788: Please reduce column width from 35 to 30em into T160497: Reduce column width to 25em for mobile skin - Unify responsive reference list styling of mobile and desktop.
Thu, Jun 15, 9:29 PM · Editing-team, Patch-For-Review, Reading-Web-Backlog, Cite
Krinkle updated the task description for T167452: Undeploy and archive Cards extension.
Thu, Jun 15, 9:08 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, MediaWiki-extensions-Cards, Wikimedia-Site-requests, Reading-Web-Backlog
Krinkle awarded T143464: "Memcached::touch(): touch is only supported with binary protocol" from wikitech as it's not running HHVM a Orange Medal token.
Thu, Jun 15, 6:24 PM · wikitech.wikimedia.org, Labs, Wikimedia-log-errors, MW-1.28-release-notes, MediaWiki-Cache
Krinkle added a comment to T31784: ResourceLoader: JsMinPlus is too memory hungry (memory leaks?).

[mediawiki/core@master] benchmarks: Add benchmark for JSMinPlus

https://gerrit.wikimedia.org/r/359191

Thu, Jun 15, 5:58 PM · Patch-For-Review, Performance, MediaWiki-ResourceLoader
Krinkle added a comment to T167616: Edit notice renders behind content instead of on top (FOUC).

I'm not sure why transforms are breaking z-index

Thu, Jun 15, 2:49 PM · Patch-For-Review, VisualEditor-MediaWiki, Regression, VisualEditor
Krinkle removed a parent task for T36876: jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements: T53749: jquery.makeCollapsible() on enhanced watchlist/recentchanges annoyingly slow.
Thu, Jun 15, 2:46 PM · JavaScript, MediaWiki-Interface, Performance
Krinkle removed a subtask for T53749: jquery.makeCollapsible() on enhanced watchlist/recentchanges annoyingly slow: T36876: jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements.
Thu, Jun 15, 2:46 PM · MediaWiki-JavaScript
Krinkle renamed T40048: Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random) from Root article paths allow bypassing of nofollow and attacks on Special:Random to Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random).
Thu, Jun 15, 2:42 PM · MediaWiki-Parser
Krinkle updated the task description for T40048: Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random).
Thu, Jun 15, 2:40 PM · MediaWiki-Parser
Krinkle edited projects for T40048: Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random), added: MediaWiki-Parser; removed MediaWiki-General-or-Unknown.
Thu, Jun 15, 2:40 PM · MediaWiki-Parser
Krinkle updated the task description for T40048: Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random).
Thu, Jun 15, 2:40 PM · MediaWiki-Parser
Krinkle merged task T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti into T154424: TransactionProfiler should not apply to SqlBagOStuff.
Thu, Jun 15, 2:39 PM · MediaWiki-Cache, MediaWiki-Database
Krinkle merged T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti into T154424: TransactionProfiler should not apply to SqlBagOStuff.
Thu, Jun 15, 2:39 PM · MediaWiki-Cache, MediaWiki-Database
Krinkle added a comment to T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

Also nothing is thrown here, there is no PHP "exception". Rather it's a debug log message (severity=INFO) that is hidden by default and (for easier debugging) includes a manually created stack trace.

That might be true in the actual sense of an exception but unfortunately this has a significant cost and it appears on each save action and therefore no longer is something to ignore as it impacts editing practice (surely not WMF related) by a constant and unnecessary log output.

Thu, Jun 15, 2:38 PM · MediaWiki-Cache, MediaWiki-Database
Krinkle renamed T154424: TransactionProfiler should not apply to SqlBagOStuff from TransactionProfiler throws a "Expectation (masterConns <= 0)" on SqlBagOStuff::doGet to TransactionProfiler should not apply to SqlBagOStuff.
Thu, Jun 15, 2:19 PM · MediaWiki-Cache, MediaWiki-Database
Krinkle added a comment to T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

@mwjames It seems you omitted the main warning message. The one that says "Expectation .. by .. not met ..".

Thu, Jun 15, 2:18 PM · MediaWiki-Cache, MediaWiki-Database
Krinkle added a comment to T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).

In addition to only collapsing things when JavaScript is enabled, it is still important that the collapsible elements and the toggle button will be discoverable and understandable by screen readers. Since they usually run in a context where JavaScript is disabled. (E.g. role and aria attributes as needed.)

Thu, Jun 15, 2:09 PM · Performance, JavaScript, MediaWiki-Interface

Wed, Jun 14

Krinkle closed T62025: Support Link tags with media attributes as Declined.

Browser download it unconditionally. And they have to in order to provide a continuous experience when states change (e.g. device orientation or window size) - instead of one stylesheet no longer applying and in the middle of a render update being blocked on a network fetch and major style recalculation. As such, browsers don't actually do that.

Wed, Jun 14, 9:49 PM · MediaWiki-ResourceLoader
Krinkle closed T27575: JavaScriptMinifier should preserve IE's "Conditional compilation" statements as Declined.

Use of /*@cc_on @*/ is mainly for old IE. As of writing, we no longer support Grade A JavaScript run-time in IE6, IE7, IE8 or IE9. Support for /*@cc_on @*/ was removed in IE 11. IE 10 still support it for back-compat, but I don't think it makes sense to introduce support for this deprecated feature at this point in time.

Wed, Jun 14, 9:47 PM · MediaWiki-ResourceLoader
Krinkle closed T57642: Support loading ResourceLoader modules into Web Workers as Declined.

ResourceLoader now supports a raw=1 parameter. Together with only=scripts this can be used to produce a ResourceLoader responds without dependency on mw.loader.implement or mw.loader.state.

Wed, Jun 14, 9:45 PM · MediaWiki-ResourceLoader
Krinkle triaged T167478: SkinStyles registered via ResourceModuleSkinStyles do not work on classes other than ResourceLoaderFileModule as High priority.
Wed, Jun 14, 9:35 PM · MediaWiki-ResourceLoader, Reading-Web-Backlog
Krinkle moved T167478: SkinStyles registered via ResourceModuleSkinStyles do not work on classes other than ResourceLoaderFileModule from Inbox to Accepted: Bugs on the MediaWiki-ResourceLoader board.
Wed, Jun 14, 9:35 PM · MediaWiki-ResourceLoader, Reading-Web-Backlog
Krinkle renamed T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page from FOUC caused by collapsible message box on start of page to jquery.makeCollapsible: FOUC caused by collapsible message box on start of page.
Wed, Jun 14, 9:35 PM · MediaWiki-Interface, Performance
Krinkle added a comment to T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page.

Regarding jQuery 1.11, we've already begun preparations for upgrading to jQuery 3. Most blockers have been resolved.

Wed, Jun 14, 9:34 PM · MediaWiki-Interface, Performance
Krinkle merged task T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page into T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).
Wed, Jun 14, 9:31 PM · MediaWiki-Interface, Performance
Krinkle merged T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page into T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).
Wed, Jun 14, 9:31 PM · Performance, JavaScript, MediaWiki-Interface
Krinkle reopened T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state), a subtask of T36876: jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements, as Open.
Wed, Jun 14, 9:31 PM · JavaScript, MediaWiki-Interface, Performance
Krinkle reopened T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) as "Open".
Wed, Jun 14, 9:31 PM · Performance, JavaScript, MediaWiki-Interface
Krinkle reopened T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state), a subtask of T42792: jquery.makeCollapsible should avoid page scroll when collapsing elements, as Open.
Wed, Jun 14, 9:31 PM · JavaScript, MediaWiki-Interface
Krinkle merged T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) into T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page.
Wed, Jun 14, 9:31 PM · MediaWiki-Interface, Performance
Krinkle merged task T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) into T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page.
Wed, Jun 14, 9:31 PM · Performance, JavaScript, MediaWiki-Interface
Krinkle added a comment to T167847: jquery.makeCollapsible: FOUC caused by collapsible message box on start of page.

I can reproduce the FOUC, which has been around for years. However I'm fairly certain that we do correctly trigger this and all other domready-scheduled work at DOMContentLoaded. We've got plenty of early calls to $.ready. And once that promise starts, it is resolved and remembered.

Wed, Jun 14, 9:30 PM · MediaWiki-Interface, Performance
Krinkle added a comment to T153613: Error code -2 for 320px-Paypal-USD-color.svg.png in IE 11.

@Peter Have you seen this recently? If not, perhaps we should we close this.

Wed, Jun 14, 8:28 PM · Performance-Team, WebPageTest
Krinkle added a comment to T148009: Log the URL when we get an error.

@Peter Is this done? Last I checked our errors are pretty good, we can now associate the error with the run, is that right?

Wed, Jun 14, 8:28 PM · Performance-Team, WebPageTest
Krinkle updated the task description for T164551: [WIP] RfC: Adopt governance guidelines for Special Interest Groups (SIG).
Wed, Jun 14, 8:27 PM · ArchCom-RfC, Developer-Relations, RfC
Krinkle updated the task description for T164551: [WIP] RfC: Adopt governance guidelines for Special Interest Groups (SIG).
Wed, Jun 14, 8:27 PM · ArchCom-RfC, Developer-Relations, RfC
Krinkle awarded T118024: When deleting Flow topic or post, contributions should appear in DeletedContributions a Orange Medal token.
Wed, Jun 14, 8:02 PM · Collaboration-Team-Triage, Flow
Krinkle moved T153170: Grafana alerts for save timing from Next-up to Doing on the Performance-Team board.
Wed, Jun 14, 7:41 PM · Patch-For-Review, Performance-Team
Krinkle moved T159911: Audit modules (2017) from Doing to Next-up on the Performance-Team board.
Wed, Jun 14, 7:34 PM · MW-1.29-release-notes, Performance-Team, MediaWiki-ResourceLoader
Krinkle moved T127328: Optimise critical rendering path from Doing to Next-up on the Performance-Team board.
Wed, Jun 14, 7:34 PM · Goal, Performance-Team
Krinkle moved T127628: Create a bot that automatically optimizes PNGs from Backlog to Radar on the Performance-Team board.
Wed, Jun 14, 7:33 PM · Performance-Team, Gerrit, Release-Engineering-Team (Watching / External)
Krinkle lowered the priority of T167382: Use Jekyll to static generate performance.wikimedia.org from High to Normal.
Wed, Jun 14, 7:33 PM · Patch-For-Review, Performance-Team
Krinkle moved T106770: Rewrite asset-check on top of the Chromium (instead of PhantomJS) from Backlog to Potential goals on the Performance-Team board.
Wed, Jun 14, 7:31 PM · Performance-Team
Krinkle moved T110125: Yearly site performance reports (blog post) from Backlog to Potential goals on the Performance-Team board.
Wed, Jun 14, 7:31 PM · Performance-Team
Krinkle renamed T110125: Yearly site performance reports (blog post) from Quarterly performance reports (blog post) to Yearly site performance reports (blog post).
Wed, Jun 14, 7:31 PM · Performance-Team