@Cstone This was resolved, right? I think @Ejegg fixed it with this patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1324783

The patch is in final review and it does fetch the data and stores it where it needs it to be for now. Plus it sends the contribution-tracking message to the queue. I created follow-up tasks to address any outstanding, but out of scope, issue with the goal of either improving the code or validating edge cases or improve known wrong behaviors.

@AnnWF I personally think is fine to do introduce the country based conditions later on (I don't want this to be a blocker). But since I didn't have the context on the employer field (I didn't see it in payments) I wasn't sure I was understanding enough for a code review. I approved the patch, since anyway I assume the introduction of geo based settings / options will be introduced at some point in ComboWiki.

@Cstone thanks, now it's clear. Should we then isolate this employer field to US even in ComboWiki? It'd be a shame to add this visual "noise" if we don't need it for any non US country. What do you think @AnnWF ?

@AnnWF @Cstone I currently don't see the employer field in the donate->payment flow (e.g. here: https://payments.wikimedia.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote&country=IT&currency=EUR&payment_method=cc&recurring=0&gateway=gravy&uselang=en&amount=10&opt_in=0&wmf_medium=spontaneous&wmf_campaign=spontaneous&wmf_source=fr-redir.default%7Edefault%7Edefault%7Edefault%7Econtrol.cc&wmf_key=vw_1728%7Evh_873%7EotherAmt_0%7EvalidateError_1%7Etime_46)

@Damilare @Cstone @Ejegg I have pushed my branch and the work I have done so far with the input I got.

gravy docs about MOTO: https://docs.gr4vy.com/guides/features/recurring-payments/scenarios#moto

Jobs have been running on scheduled and double opt-ins get cancelled as expected. With all the information gathered during this task we updated the wiki process control page: https://wikitech.wikimedia.org/wiki/Fundraising/Cluster/Process_control

The job is now deployed 🎉

To monitor after the first manual run and after deployment you can use these:

@Lars I updated the yaml file with all the changes you suggested to make, can you please have a last look?

@Lars Good catch on the limit, thanks! I definitely forgot to remove it. About the activity tables my concern was for the initial setup (the pre-requisite data) to being able to run the command against the expected scenarios. When trying to create test data, I wasn't sure why my activity tables were empty but this was fixed with Dami earlier today. Now I can easily and confidently setup up starting scenarios for then running the command. By now I have tested the command against a few scenarios outlined in the comment above and I am personally confident in moving to the next steps.

Update: after jumping on a call with @Damilare we managed to improve my local testing flow and I can now validate that the command appears to be cover all basis. I tested these scenarios in localhost:

The first approach was aborted due to performance issues and not having access to the geo location inside the pre hook event. The task should be executed now by running a daily cron job using process control.

@Lars I pushed a patch that implements the basic functionality of the task with basic test coverage. Could you review that for now? I marked it as work-in-progress since it is not optimized.

@Dzahn thanks, I already have wmf access from that flow granted. I was pointed here from my colleagues since at some point I tried to create a phab task clicking on Fundraising Access Request from the instructions page and then on create an access request and then I saw an error "Access Denied: restricted edit configuration"

@krobinson This change has been deployed

My public YubiKey: