I'm not sure how I can test the CRS part of it. I did see the beautiful babel box magic in a ticket I was testing earlier this week, but I understand it right that this ticket is specifically about having it rendered in CSR, not SSR? If yet, how can I produce such a situation?
Wed, Mar 20
@Matthias_Geisler_WMDE thanks for the pointer! I now see a beautifully aligned icon, the order of icons is now changed though, which creates an inconsistency with e.g. Wikipedia mobile:
Tue, Mar 19
The header looks indeed beautiful, but I'm struggling a bit to accept this story, because I don't see any icon except the ones we expect. Do I maybe need to follow a different link to see the download icon, too?
@Lea_WMDE In addition to the icons immediately visible we also use messages to explain what buttons do (e.g. screenreaders). As of T161367 there are two "competing" messages for the action of persisting, "save" & "publish". Which one is chosen is configurable per installation. Does this configurability have to be reflected in termbox or can we favor one over the other (i.e. always use "publish" implying that termbox will only every be used on Wikimedia projects)?
Just publish sounds best to me, even when it is not configurable I would assume other project could live with the "publish" wording as well :)
Thu, Mar 14
The fact that adding this only has a real impact on desktop (where there is an ESC key) maybe makes it even more obvious that it should be a dedicated feature story (that could be added later in the game), I just wanted to scribble down the observation.
Making it an extra story sounds great to me :)
Wed, Mar 13
If possible also come to a conclusion whether a "floating bar" would be possible as well.
Users with specialized data are not cached. If we need to reduce the number of requests, not ever sending SSR requests in those cases (i.e. showing nothing), but forcing users to wait for the client side action to kick in would be an option.
If we don't have this, and run into problems with the number of requests, the only way to reduce the number of requests would be disabling the new termbox functionality completely, falling back to the current state.
This should be rewritten to log all failed requests in the central logging instance and not just the there mentioned requests. The ticket is about making it more convenient to not dig through existing logging, and it would also be able to log requests that never made it back out to mediawiki.
It would probably make sense to have the same time out for both directions.
At this stage we would be introducing logging that is not being read by anyone. This ticket is only about adding a line of meta data to the requests we send.
Estimation happened under the assumption that no other ticket in that regard was done
The estimation is based on having separate caches per instance (if there even is more than one instance)
Tue, Mar 12
Mon, Mar 11
Wed, Mar 6
We discussed this, and thanks does not have one. So staying consistent we are not having one either :) (Especially since you can cancel by using the back button, closing the tab or not doing anything)
Mon, Mar 4
FYI: This still needs to go out with the next wikidiff2 release. For the release please see T203069: Deploy wikidiff2 v1.8.1 with changed signature
Oh my... thanks Fisch!
Fri, Mar 1
@WMDE-Fisch can this be closed?