Legoktm (Legoktm)Administrator
User

Projects (88)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (148 w, 1 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Today

Legoktm added a comment to T152578: Add tests for integration/uprightdiff repository.

There are a few dependencies mentioned in the README file: build-essential g++ libopencv-highgui-dev libboost-program-options-dev. We would need them in CI to compile I can see two ways of solving it:

Packages are listed in the puppet class visualdiff. We could move the list of packages to a new visualdiff::packages that we can include on CI. Similar to service::packages that defines runtime and build dependencies. Then create a Jenkins job that runs make.

Sun, Jul 23, 6:00 AM · uprightdiff, Continuous-Integration-Config
Legoktm added subtasks for T171397: Prepare uprightdiff for inclusion in Debian: T152740: Add "make test" to uprightdiff, T171396: Write man page for uprightdiff.
Sun, Jul 23, 5:54 AM · uprightdiff
Legoktm added a parent task for T152740: Add "make test" to uprightdiff: T171397: Prepare uprightdiff for inclusion in Debian.
Sun, Jul 23, 5:54 AM · uprightdiff
Legoktm added a parent task for T171396: Write man page for uprightdiff: T171397: Prepare uprightdiff for inclusion in Debian.
Sun, Jul 23, 5:54 AM · uprightdiff
Legoktm created T171397: Prepare uprightdiff for inclusion in Debian.
Sun, Jul 23, 5:53 AM · uprightdiff
Legoktm created T171396: Write man page for uprightdiff.
Sun, Jul 23, 5:50 AM · uprightdiff
Legoktm closed T170316: MediaWiki.Usage.ReferenceThis to strict as Resolved.
Sun, Jul 23, 12:48 AM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm closed T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure as Resolved.
Sun, Jul 23, 12:47 AM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm closed T171125: phpcbf doesn't remove space before ; after removing () from require call as Resolved.
Sun, Jul 23, 12:47 AM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm added a comment to T129664: phpcs not running on all files.

Once repositories update to the latest version, we can remove the per-repository <exclude-pattern> rules since they'll inherit from the centrally maintained one.

Sun, Jul 23, 12:28 AM · MW-1.30-release-notes, Patch-For-Review, MediaWiki-Codesniffer, MediaWiki-General-or-Unknown
Legoktm claimed T129664: phpcs not running on all files.

@Reedy ran into this last week as well. Our pattern for ignoring .git directories was just .git, where the period matched anything. So you have ChangeTagsLogItem.php and RevDelLogItem.php.

Sun, Jul 23, 12:26 AM · MW-1.30-release-notes, Patch-For-Review, MediaWiki-Codesniffer, MediaWiki-General-or-Unknown

Yesterday

Legoktm moved T171125: phpcbf doesn't remove space before ; after removing () from require call from Untriaged to In progress on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:56 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T145162: Provide a Codesniffer rule to enforce "short" type definitions: int and bool, not integer and boolean from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:56 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170316: MediaWiki.Usage.ReferenceThis to strict from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:56 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:55 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170442: Always use leading zeros in php files from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:55 PM · MediaWiki-Codesniffer
Legoktm added a comment to T171125: phpcbf doesn't remove space before ; after removing () from require call.

I can't reproduce this on master, but that would mean d83c7005d652d3a6aedd10be90e2251de28b929b somehow fixed it, which I find doubtful?

Sat, Jul 22, 11:54 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170332: Avoid assigment in return statements from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:49 PM · MediaWiki-Codesniffer
Legoktm claimed T170316: MediaWiki.Usage.ReferenceThis to strict.
Sat, Jul 22, 11:47 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170316: MediaWiki.Usage.ReferenceThis to strict from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:47 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:47 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm moved T171335: Add Sniff to forbid PHP 7+ type hints from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Sat, Jul 22, 11:47 PM · MediaWiki-Codesniffer
Legoktm claimed T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure.
Sat, Jul 22, 11:46 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm merged T171383: Allow global IP contributions to be tracked accross wikis into T28957: Write extension to retrieve global (Wikimedia wiki-wide) contributions for an IP or username.
Sat, Jul 22, 10:22 PM · Stewards-and-global-tools, MediaWiki-extension-requests
Legoktm merged task T171383: Allow global IP contributions to be tracked accross wikis into T28957: Write extension to retrieve global (Wikimedia wiki-wide) contributions for an IP or username.
Sat, Jul 22, 10:21 PM · MediaWiki-extensions-CentralAuth

Fri, Jul 21

Legoktm created T171335: Add Sniff to forbid PHP 7+ type hints.
Fri, Jul 21, 6:17 PM · MediaWiki-Codesniffer
MarcoAurelio awarded T171253: +2 request for Matěj Suchánek in mediawiki/extensions/AbuseFilter a Like token.
Fri, Jul 21, 4:46 PM · Repository-Ownership-Requests
Legoktm added a comment to T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure.

Regardless of whether there's already a documentation comment or not, the sniff will check that if there is a return token, there should also be a @return documentation. Except the sniff is a bit naive and doesn't exclude return tokens in closures.

Fri, Jul 21, 1:56 AM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm added a comment to T171254: MediaWiki.Commenting.FunctionComment.MissingReturn doesn't like static.php's wmfStaticRespond.

Dupe of T170765: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure?

Fri, Jul 21, 1:31 AM · MediaWiki-Codesniffer
matmarex awarded T171253: +2 request for Matěj Suchánek in mediawiki/extensions/AbuseFilter a Like token.
Fri, Jul 21, 1:15 AM · Repository-Ownership-Requests
Legoktm created T171253: +2 request for Matěj Suchánek in mediawiki/extensions/AbuseFilter.
Fri, Jul 21, 1:10 AM · Repository-Ownership-Requests
Legoktm closed T171234: MediaWiki.ExtraCharacters.CharacterBeforePHPOpeningTag.Found broken on hhvm-fatal-error.php as Declined.

On master the error comes from Generic.PHP.CharacterBeforePHPOpeningTag.Found, but the thing is, this is exactly what the sniff is designed to prevent - any content before the opening php tag (except for a hashbang) is bad (e.g. https://gerrit.wikimedia.org/r/#/c/196279/).

Fri, Jul 21, 12:37 AM · MediaWiki-Codesniffer

Thu, Jul 20

Legoktm reopened T170053: Drop "position: absolute" on p-logo element as "Open".

This was reverted in MonoBook, see T171195: Site logo is no longer clickable in monobook.

Thu, Jul 20, 8:52 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), MonoBook, Technical-Debt, Vector
Legoktm added a comment to T160430: Have statistics which allow measuring success of a potential "Onboarding new developers" program.

I'm pretty late here, but just to clarify, the 3 KPIs are the ones listed in T160430#3275660, and it's just about contributing patches, and no measurement on whether those patches were merged or even reviewed?

Thu, Jul 20, 4:15 AM · Developer-Relations (Jul-Sep 2017)
Legoktm committed R2044:b6bc2e16c2d2: Update linter categories (authored by Legoktm).
Update linter categories
Thu, Jul 20, 4:05 AM
Legoktm added a comment to T170880: Parser tests fail if default Skin for unit tests makes use of doEditSectionLink.

(Also whenever I would try testing it with php parserTests.php I'd get fatal exceptions about $this->getTitle() not being set which is a bit weird, but it made it obvious whether MinervaNeue was being used to parse or not.

Thu, Jul 20, 1:47 AM · Parsing-Team, MediaWiki-Parser, MediaWiki-Core-Tests, Mobile App Sprint 52 - Android, Patch-For-Review, Reading-Web-Backlog, MW-1.30-release-notes, Release-Engineering-Team, Continuous-Integration-Config
Legoktm added a comment to T170880: Parser tests fail if default Skin for unit tests makes use of doEditSectionLink.

@Jdlrobson I basically did the same concept as you, but left it configurable since we probably do want to have parser tests to verify the output of MinervaNeue's edit section links.

Thu, Jul 20, 1:46 AM · Parsing-Team, MediaWiki-Parser, MediaWiki-Core-Tests, Mobile App Sprint 52 - Android, Patch-For-Review, Reading-Web-Backlog, MW-1.30-release-notes, Release-Engineering-Team, Continuous-Integration-Config

Wed, Jul 19

Legoktm added a comment to T170222: Investigation: Global preferences.

The integration is pretty hacky though, it would probably do better to be part of core itself. I'm not sure what that would look like exactly though. Either way I think some refactoring of the Preferences stuff is necessary.

What is hacky about it? It seems to me that loading global prefs for a given user when loading their local prefs is about as efficient as it can get. Or do you mean the editing interface?

Wed, Jul 19, 7:24 PM · GlobalPreferences, Community-Tech-Sprint
Legoktm committed rECKT2a236f9c0357: Avoid unncessary RequestContext::getMain() (authored by Legoktm).
Avoid unncessary RequestContext::getMain()
Wed, Jul 19, 5:58 PM
Legoktm added a comment to T169928: Evaluate how hard would be to get aa(wikibooks|wiktionary) and howiki databases deleted.

What exactly is the purpose of deleting wikis? It provides no benefit and is more likely to break things.

Wed, Jul 19, 1:55 AM · Operations, DBA
Legoktm added a comment to T171003: MassMessage not working for delivery to Suwikiquote or Mlwikiquote: "CAS update failed on user_touched".

Hmm.

2017-07-18 22:55:57 [WW6R2wpAME4AAGJWDeEAAABN] mw1299 mlwikiquote 1.30.0-wmf.9 exception ERROR: [WW6R2wpAME4AAGJWDeEAAABN] [no req]   MWException from line 4057 of /srv/mediawiki/php-1.30.0-wmf.9/includes/user/User.php: CAS update failed on user_touched for user ID '2110' (read from replica); the version of the user to be saved is older than the current version. {"exception_id":"WW6R2wpAME4AAGJWDeEAAABN","caught_by":"mwe_handler"} 
[Exception MWException] (/srv/mediawiki/php-1.30.0-wmf.9/includes/user/User.php:4057) CAS update failed on user_touched for user ID '2110' (read from replica); the version of the user to be saved is older than the current version.
  #0 /srv/mediawiki/php-1.30.0-wmf.9/includes/user/User.php(737): User->saveSettings()
  #1 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/MassMessage.php(45): User::newSystemUser(string, array)
  #2 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/job/MassMessageJob.php(64): MassMessage::getMessengerUser()
  #3 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/job/MassMessageJob.php(289): MassMessageJob->getUser()
  #4 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/job/MassMessageJob.php(208): MassMessageJob->makeAPIRequest(array)
  #5 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/job/MassMessageJob.php(186): MassMessageJob->editPage()
  #6 /srv/mediawiki/php-1.30.0-wmf.9/extensions/MassMessage/includes/job/MassMessageJob.php(41): MassMessageJob->sendMessage()
  #7 /srv/mediawiki/php-1.30.0-wmf.9/includes/jobqueue/JobRunner.php(293): MassMessageJob->run()
  #8 /srv/mediawiki/php-1.30.0-wmf.9/includes/jobqueue/JobRunner.php(193): JobRunner->executeJob(MassMessageJob, Wikimedia\Rdbms\LBFactoryMulti, BufferingStatsdDataFactory, integer)
  #9 /srv/mediawiki/rpc/RunJobs.php(47): JobRunner->run(array)
  #10 {main}
Wed, Jul 19, 1:02 AM · Malayalam-Sites, MassMessage
Legoktm added a comment to T170986: Add MediaWikiInstallPingback to EventLogging purging white-list.

What does the whitelist control? The schema should be receiving events already.

Wed, Jul 19, 12:52 AM · Performance-Team, Analytics

Tue, Jul 18

Legoktm added a comment to T170951: Please create new maillist named : code-health@lists.wikimedia.org..

Is the current qa@ list not suitable?

Tue, Jul 18, 6:25 PM · Wikimedia-Mailing-lists
Legoktm added a project to T162044: Check minimum supported DBMS version when running update.php (and web updater): MW-1.30-release.
Tue, Jul 18, 4:55 PM · MW-1.30-release, MediaWiki-Database, MediaWiki-Maintenance-scripts, MediaWiki-Installer
Legoktm closed T167168: PHP_CodeSniffer 3.x breaks when prepend-autoloader: false is set (like it is in MediaWiki core) as Resolved.

We should be good now. I'm planning to do a bugfix release at the end of the week.

Tue, Jul 18, 2:53 AM · Patch-For-Review, Upstream, MediaWiki-Codesniffer
Legoktm claimed T167168: PHP_CodeSniffer 3.x breaks when prepend-autoloader: false is set (like it is in MediaWiki core).

This has been fixed in 3.0.2. Patch incoming.

Tue, Jul 18, 1:50 AM · Patch-For-Review, Upstream, MediaWiki-Codesniffer
Legoktm added a comment to T161232: Bump MediaWiki's minimum supported MySQL Version to 5.5.8.

This may require multiple changes on the official wiki documentation, you will need help to change all (which I offer).

Indeed. I wonder if we can get away with just changing it everywhere onwiki to say 5.5... OR we need the mw version caveat.

Tue, Jul 18, 12:04 AM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), MediaWiki-Documentation, Documentation, ArchCom-RfC (ArchCom-Approved), RfC, DBA, MediaWiki-Database

Mon, Jul 17

Legoktm added a comment to T170222: Investigation: Global preferences.

@Legoktm What do you think of having a dedicated special page for handling global prefs as part of GlobalPreferences extension instead of the checkboxes we have right now?

Mon, Jul 17, 11:38 PM · GlobalPreferences, Community-Tech-Sprint
Legoktm closed T93010: validateRegistrationFile.php fails on protocol-relative URLs as Resolved.
Mon, Jul 17, 5:31 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, Upstream, MediaWiki-Configuration
Legoktm added a comment to T167329: PageAssessments has Invalid composer.json.

I mean at a minimum I think the name and type should be correct so the extension can be installed with composer, the other fields are not important, but a licensee and description is helpful.

Mon, Jul 17, 5:25 PM · Patch-For-Review, Africa-Wikimedia-Developers, Easy, Composer, MediaWiki-extensions-PageAssessments
Legoktm added a comment to T167329: PageAssessments has Invalid composer.json.

The premise here is invalid, it validates just fine if you provide the --no-check-publish option. Adding those fields just make it publishable on packagist, which is not something that's recommended.

Mon, Jul 17, 5:19 PM · Patch-For-Review, Africa-Wikimedia-Developers, Easy, Composer, MediaWiki-extensions-PageAssessments
Legoktm added a comment to T170222: Investigation: Global preferences.
  • Would this be a change to the Preferences interface, or an external tool?
Mon, Jul 17, 4:52 PM · GlobalPreferences, Community-Tech-Sprint
Legoktm added a comment to T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor.

@Addshore and I have been discussing this lately and he uploaded a giant proof of concept to add the Wikidata dependencies to mediawiki/vendor: https://gerrit.wikimedia.org/r/#/c/364712/2

Mon, Jul 17, 4:42 PM · Release-Engineering-Team (Watching / External), Story, Wikidata
Krinkle awarded T97536: GlobalRename is moving over existing pages, causing revisions to go missing (tracking) a Orange Medal token.
Mon, Jul 17, 2:13 AM · GlobalRename, Tracking, MediaWiki-extensions-CentralAuth

Sun, Jul 16

Legoktm added subtasks for T20654: EditPage.php needs rewrite: T170184: Refactor anti-spam/vandalism checks out of EditPage.php, T157658: Factor out a backend from EditPage.
Sun, Jul 16, 11:08 PM · Technical-Debt, MediaWiki-Page-editing
Legoktm added a parent task for T157658: Factor out a backend from EditPage: T20654: EditPage.php needs rewrite.
Sun, Jul 16, 11:08 PM · MediaWiki-Platform-Team, MediaWiki-Page-editing
Legoktm added a parent task for T170184: Refactor anti-spam/vandalism checks out of EditPage.php: T20654: EditPage.php needs rewrite.
Sun, Jul 16, 11:08 PM · Patch-For-Review, Technical-Debt, MediaWiki-Platform-Team, MediaWiki-Page-editing
Legoktm added a comment to T170184: Refactor anti-spam/vandalism checks out of EditPage.php.

Duplicate of T20654: EditPage.php needs rewrite? There's a lot more technical debt there than just anti-spam checks.

Sun, Jul 16, 11:03 PM · Patch-For-Review, Technical-Debt, MediaWiki-Platform-Team, MediaWiki-Page-editing
Legoktm added a comment to T170759: Archive of the Listadmins mailing list isn't restricted to members.

The "listadmins" list has been public ever since it was created, and is open to subscription by anyone. The latter was announced in https://lists.wikimedia.org/pipermail/listadmins/2015-May/000002.html.

Sun, Jul 16, 12:03 AM · Security

Fri, Jul 14

Legoktm changed the visibility for T170601: Massive spam to -owner mailing lists from *@qq.com emails.
Fri, Jul 14, 4:08 PM · Wikimedia-Mailing-lists, Security

Thu, Jul 13

Legoktm added a comment to T170476: Inconsistent interface of "Select all / none / invert" for lists of checkboxes..

Which interface do you think we should use?

Thu, Jul 13, 6:53 AM · Easy, MediaWiki-General-or-Unknown
Legoktm updated subscribers of T170476: Inconsistent interface of "Select all / none / invert" for lists of checkboxes..
Thu, Jul 13, 6:53 AM · Easy, MediaWiki-General-or-Unknown
Legoktm added projects to T170513: Feature request/enhancement: more clear user-rights log messages (lists all old rights and all new rights currently): MediaWiki-User-management, MediaWiki-Logging.
Thu, Jul 13, 6:52 AM · MediaWiki-Logging, MediaWiki-User-management
Legoktm added a project to T170507: CheckUser "contributions" link should be a red link for non-existent accounts: Easy.

This behavior would match AbuseFilter, which also uses red contribs to indicate the user has no edits. Marking as Easy accordingly.

Thu, Jul 13, 6:38 AM · Africa-Wikimedia-Developers, Easy, CheckUser

Wed, Jul 12

Prtksxna awarded T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications) a Cookie token.
Wed, Jul 12, 4:45 AM · Push-Notification-Service, Reading-Infrastructure-Team-Backlog, Notifications, Collaboration-Team-Triage
Legoktm added a comment to T145604: [RfC] Future of magic links.

Besides, localization has been the worst idea WP developpers implemented so far.

Wed, Jul 12, 12:58 AM · ArchCom-Has-shepherd, MediaWiki-Parser, ArchCom-RfC
Legoktm updated subscribers of T102081: Provide an easy way for Tool Labs tools to expose their source code.

Well the original premise of this task that @yuvipanda created was "A way that does not require using git". @yuvipanda, could you describe what kind of system you were imagining?

Wed, Jul 12, 12:02 AM · Toolforge, Developer-Relations

Tue, Jul 11

Legoktm added a comment to T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications).

Gotcha. But I don't think we'll be using GCM here. When I use Chromium and register a push notification handler I get an endpoint URL like https://fcm.googleapis.com/fcm/send/<long_hash> (and Firefox gives a URL like https://updates.push.services.mozilla.com/wpush/v2/<longhash>).

Tue, Jul 11, 10:45 PM · Push-Notification-Service, Reading-Infrastructure-Team-Backlog, Notifications, Collaboration-Team-Triage
Legoktm added a comment to T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications).

The storage requirements are the main thing that was blocking reading from doing anything here. Note you'd need to store a key for every service using push notifications (we'd not want to limit exclusively to Echo as that would limit us considerably to logged in users) and yes a new database would be ideal.

Tue, Jul 11, 10:25 PM · Push-Notification-Service, Reading-Infrastructure-Team-Backlog, Notifications, Collaboration-Team-Triage
Legoktm closed T169539: Wikidata extension hasn't been updated since 2017-06-19 as Resolved.
Tue, Jul 11, 10:15 PM · User-Addshore, Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseRepository
Legoktm committed R1907:4467d315d8d0: Add .gitattributes file to slim down what composer installs (authored by Legoktm).
Add .gitattributes file to slim down what composer installs
Tue, Jul 11, 10:10 PM
Legoktm added a comment to T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications).

I played with push notifications over the past week in a non-MediaWiki related project, and was surprised at how powerful and easy to use they were.

Tue, Jul 11, 9:58 PM · Push-Notification-Service, Reading-Infrastructure-Team-Backlog, Notifications, Collaboration-Team-Triage
Legoktm updated subscribers of T170052: Access rights for HDFS on stat100* for Sqoop tasks.

@dpatrick did you mean to triage this as Unbreak Now!? If so, why?

Tue, Jul 11, 9:04 PM · Analytics-Kanban, User-Addshore, Security, Analytics-Cluster
Legoktm created T170330: Replace Flow DI (pimple) with MediaWikiServices.
Tue, Jul 11, 8:37 PM · Technical-Debt, Flow, Collaboration-Team-Triage
Legoktm closed T67289: Use semantic versioning scheme for WMF (all) releases as Resolved.

This was implemented a while back.

Tue, Jul 11, 8:27 PM · WorkType-NewFunctionality, MediaWiki-General-or-Unknown
Legoktm updated subscribers of T169539: Wikidata extension hasn't been updated since 2017-06-19.

@Addshore and I looked into this in #wikidata and noticed that @aude updated the build for the wmf.7 branch, but not master. Addshore tried to copy over wmf.7 into master but that caused CI failures: https://gerrit.wikimedia.org/r/#/c/364520/

Tue, Jul 11, 8:21 PM · User-Addshore, Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseRepository
Legoktm merged task T169598: Beta Cluster Wikidata Build is (a week) older than production into T169539: Wikidata extension hasn't been updated since 2017-06-19.
Tue, Jul 11, 8:17 PM · Wikidata
Legoktm merged T169598: Beta Cluster Wikidata Build is (a week) older than production into T169539: Wikidata extension hasn't been updated since 2017-06-19.
Tue, Jul 11, 8:17 PM · User-Addshore, Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseRepository
Legoktm removed a project from T170052: Access rights for HDFS on stat100* for Sqoop tasks: Security.
Tue, Jul 11, 7:43 PM · Analytics-Kanban, User-Addshore, Security, Analytics-Cluster
Legoktm removed a project from T170066: MySQL password for research@analytics-store.eqiad.wmnet publicly revealed: Security.
Tue, Jul 11, 7:43 PM · Security, Wikimedia-Incident, Analytics, DBA
Legoktm closed T170066: MySQL password for research@analytics-store.eqiad.wmnet publicly revealed as Resolved.
Tue, Jul 11, 7:43 PM · Security, Wikimedia-Incident, Analytics, DBA
Legoktm added a comment to T170066: MySQL password for research@analytics-store.eqiad.wmnet publicly revealed.

Is there anything else left to do here?

Tue, Jul 11, 6:24 PM · Security, Wikimedia-Incident, Analytics, DBA
Liuxinyu970226 awarded T55619: API module to copy a claim from one item to another a Yellow Medal token.
Tue, Jul 11, 6:31 AM · Wikidata, MediaWiki-extensions-WikibaseRepository
Legoktm added a comment to T169122: Create a function for AbuseFilter that can normalize HTML entities to their respective UTF-8 characters.
>>> Sanitizer::decodeCharReferences('&#1662;&#1585;&#1608;&#1606;&#1583;&#1607;');
=> "پرونده"
Tue, Jul 11, 4:15 AM · AbuseFilter
Liuxinyu970226 awarded T95877: [Story] Setting languages with Babel boxes does not work for global user page a Heartbreak token.
Tue, Jul 11, 2:43 AM · MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, I18n, GlobalUserPage, Story, MediaWiki-extensions-Babel, MediaWiki-extensions-WikibaseRepository, Wikidata
Legoktm added a comment to T167168: PHP_CodeSniffer 3.x breaks when prepend-autoloader: false is set (like it is in MediaWiki core).

At this point if we don't see progress on my upstream PR, I'll create a temporary PHP_CodeSniffer fork with my patch on top of it so we can update MediaWiki core to use the latest and greatest MW-CS versions. I'll do that on Friday if it comes to that :(

Tue, Jul 11, 12:34 AM · Patch-For-Review, Upstream, MediaWiki-Codesniffer
Legoktm added a comment to T95877: [Story] Setting languages with Babel boxes does not work for global user page.
Tue, Jul 11, 12:05 AM · MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, I18n, GlobalUserPage, Story, MediaWiki-extensions-Babel, MediaWiki-extensions-WikibaseRepository, Wikidata

Mon, Jul 10

Legoktm claimed T159214: store normalized language codes in the babel database table.
Mon, Jul 10, 11:58 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Easy, MediaWiki-extensions-Babel
Legoktm closed T169907: user_wpzero doesn't always work as Invalid.

I looked up the IPs the users used in the database and according to @Bawolff, they're not Wikipedia Zero IP's.

Mon, Jul 10, 11:43 PM · Operations, Traffic, AbuseFilter, Zero
Legoktm added a project to T169907: user_wpzero doesn't always work: Traffic.

The code is as simple as:

		$vars->setVar(
			'user_wpzero',
			$wgRequest->getHeader( 'X-Carrier' ) !== false
		);
Mon, Jul 10, 11:15 PM · Operations, Traffic, AbuseFilter, Zero
Legoktm created T170215: Assess how well developers are doing at updating extension.json's "requires" field for MediaWiki core versions.
Mon, Jul 10, 10:33 PM · MediaWiki-Configuration
Legoktm added a comment to T120414: RFC: MediaWiki should provide a pluggable registry for editor interfaces.

I'd also like to see how spam filitering extensions integrate improved (this is a giant part of EditPage.php right now). The arbitrary hook and somehow output an error message (that the API may or may not get) is pretty terrible. Flow has a very primitive SpamFilter interface, which I think is a good direction to go in. This could be something that is potentially tackled beforehand, but I think will be necessary before we can have pluggable editors.

Mon, Jul 10, 6:46 PM · User-Daniel, ArchCom-Has-shepherd, RfC, MediaWiki-Page-editing, CodeEditor, WikiEditor, VisualEditor, Epic, Contributors-Team, ArchCom-RfC
Legoktm added a comment to T170173: Simulate API calls.

Wouldn't it be much easier to just make sure the responses are clearly documented on mediawiki.org? (I know its definitely lacking).

Mon, Jul 10, 6:45 PM · User-Samtar, MediaWiki-API
Legoktm created T170184: Refactor anti-spam/vandalism checks out of EditPage.php.
Mon, Jul 10, 6:44 PM · Patch-For-Review, Technical-Debt, MediaWiki-Platform-Team, MediaWiki-Page-editing
Legoktm added a comment to T170173: Simulate API calls.

I don't really understand how this would work, do you just want to see what the API response will be?

Mon, Jul 10, 5:57 PM · User-Samtar, MediaWiki-API
Legoktm committed R2044:74d8927ae626: Update to use new API module (authored by Legoktm).
Update to use new API module
Mon, Jul 10, 5:06 AM
Legoktm added a comment to T170056: Exception in module-execute in module ext.CodeMirror.

Sounds like a missing dependency upon jquery.wikiEditor or something?

Mon, Jul 10, 4:17 AM · MediaWiki-extensions-CodeMirror
Legoktm added a comment to T170052: Access rights for HDFS on stat100* for Sqoop tasks.

The password is still being changed since it was published publicly, please be patient.

Mon, Jul 10, 12:33 AM · Analytics-Kanban, User-Addshore, Security, Analytics-Cluster

Sun, Jul 9

Legoktm updated the task description for T170066: MySQL password for research@analytics-store.eqiad.wmnet publicly revealed.
Sun, Jul 9, 3:28 AM · Security, Wikimedia-Incident, Analytics, DBA
Legoktm renamed T170005: ukwikimedia_p needs to be removed from meta_p table and production CentralAuth tables from ukwikimedia_p needs to be removed from meta_p table to ukwikimedia_p needs to be removed from meta_p table and production CentralAuth tables.
Sun, Jul 9, 3:24 AM · Community-Tech, cloud-services-team (Kanban), Data-Services, XTools