Legoktm (Legoktm)Administrator
User

Projects (97)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (212 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Yesterday

Legoktm added projects to T206442: security.sensiolabs.org is shutting down at the end of October: Continuous-Integration-Infrastructure, MediaWiki-Vendor.

Where exactly in which Wikimedia codebase can security.sensiolabs.org be found?

Thu, Oct 18, 9:24 PM · MediaWiki-Vendor, Continuous-Integration-Infrastructure, Composer, Security
Legoktm added a comment to T207281: REL1_32 branch didn't get cut for some extensions.

The following extensions are missing REL1_32 branches:

mediawiki/extensions/AccountInfo
mediawiki/extensions/ApprovedRevs
mediawiki/extensions/ArticleRatings
mediawiki/extensions/BlueSpiceAbout
mediawiki/extensions/BlueSpiceAvatars
mediawiki/extensions/BlueSpiceBlog
mediawiki/extensions/BlueSpiceCategoryManager
mediawiki/extensions/BlueSpiceConfigManager
mediawiki/extensions/BlueSpiceDashboards
mediawiki/extensions/BlueSpiceEmoticons
mediawiki/extensions/BlueSpiceExtendedFilelist
mediawiki/extensions/BlueSpiceExtendedStatistics
mediawiki/extensions/BlueSpiceFoundation
mediawiki/extensions/BlueSpiceGroupManager
mediawiki/extensions/BlueSpiceInterWikiLinks
mediawiki/extensions/BlueSpiceMultiUpload
mediawiki/extensions/BlueSpiceNamespaceCSS
mediawiki/extensions/BlueSpiceNamespaceManager
mediawiki/extensions/BlueSpicePageAccess
mediawiki/extensions/BlueSpicePageAssignments
mediawiki/extensions/BlueSpicePageTemplates
mediawiki/extensions/BlueSpiceRSSFeeder
mediawiki/extensions/BlueSpiceReaders
mediawiki/extensions/BlueSpiceUniversalExport
mediawiki/extensions/BlueSpiceUsageTracker
mediawiki/extensions/BlueSpiceUserManager
mediawiki/extensions/Convert2Wiki
mediawiki/extensions/CountDownClock
mediawiki/extensions/DebugMode
mediawiki/extensions/Echo
mediawiki/extensions/EmailDiff
mediawiki/extensions/Farmer
mediawiki/extensions/GlobalUserPage
mediawiki/extensions/HashTables
mediawiki/extensions/Ids
mediawiki/extensions/ImageMetrics
mediawiki/extensions/LinkSuggest2
mediawiki/extensions/LinkTarget
mediawiki/extensions/Listings
mediawiki/extensions/MassAction
mediawiki/extensions/MobileFrontend
mediawiki/extensions/NavigationTiming
mediawiki/extensions/OfflineImportLexicon
mediawiki/extensions/PCRGUIInserts
mediawiki/extensions/ParentPage
mediawiki/extensions/PhpTags
mediawiki/extensions/PhpTagsMaps
mediawiki/extensions/PhpTagsSMW
mediawiki/extensions/PluggableAuth
mediawiki/extensions/Push
mediawiki/extensions/QuizGame
mediawiki/extensions/SideBarMenu
mediawiki/extensions/SkinPerNamespace
mediawiki/extensions/SphinxSearch
mediawiki/extensions/UserAgreement
mediawiki/extensions/UserOptionStats
mediawiki/extensions/WebPlatformAuth
mediawiki/extensions/WhiteSpace
mediawiki/extensions/WikiForum
mediawiki/extensions/WikibaseQualityConstraints
mediawiki/extensions/WikimediaMessages
mediawiki/extensions/YouTube
Thu, Oct 18, 8:44 PM · MediaWiki-Releasing, Release-Engineering-Team, MW-1.32-release
Legoktm added a comment to T207115: Determine solution for logging clicks to external links.

There are additional security issues with this patch - it entirely bypasses SpamBlacklist as well as nofollow.

Thu, Oct 18, 4:29 PM · Privacy, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team (Current Sprint)
Legoktm added a comment to T207115: Determine solution for logging clicks to external links.

Have the privacy aspects of this been considered? Tracking full URLs feels pretty icky, and I think we generally try to avoid collecting data that link users to what they're reading.

Thu, Oct 18, 4:52 AM · Privacy, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team (Current Sprint)

Wed, Oct 17

Legoktm created T207255: Notice: compact(): Undefined variable: ... in /workspace/src/extensions/LabeledSectionTransclusion/LabeledSectionTransclusion.class.php.
Wed, Oct 17, 6:59 AM · PHP 7.3 support, MediaWiki-extensions-LabeledSectionTransclusion
Legoktm added a comment to T206460: MediaWiki 1.31 and earlier can't use LocalisationUpdate with GitHub now.

Krinkle: to clarify, release of MediaWiki core or MLEB?

Wed, Oct 17, 6:45 AM · MW-1.27-release, MW-1.30-release, MW-1.31-release, MediaWiki-extensions-LocalisationUpdate
Legoktm added a comment to T176370: Migrate to PHP 7 in WMF production.

After discussion in our meeting and on IRC, we're deciding to stick with PHP 7.2 for the initial migration, and will upgrade to 7.3 at some later point. Concerns were related to timing - we want to be using PHP 7 in production before 7.3 will actually be released, as well as stability, wanting to wait for a few point releases first.

Wed, Oct 17, 6:37 AM · Patch-For-Review, Core Platform Team Backlog (Watching / External), TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
Legoktm closed T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 as Resolved.
Wed, Oct 17, 5:26 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, Growth-Team, StructuredDiscussions
Legoktm closed T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3, a subtask of T204884: Run MediaWiki tests on PHP 7.3, as Resolved.
Wed, Oct 17, 5:25 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a comment to T204884: Run MediaWiki tests on PHP 7.3.

Are we planning to add PHP 7.3 to our travis CI?

Wed, Oct 17, 4:06 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm created T207250: Backport codesniffer update to 19.x for PHP 7.3 compatibility.
Wed, Oct 17, 3:56 AM · PHP 7.3 support, MediaWiki-Codesniffer
Legoktm added a comment to T207204: Delete wikimedia/kraken repository from github.

If the repository is obsolete, it should go through the Cleanup process.

Wed, Oct 17, 2:30 AM · GitHub-Mirrors, Cleanup, Analytics, Analytics-Kanban
Legoktm updated the task description for T207247: WANObjectCacheTest::testGetWithSeveralCheckKeys is flaky.
Wed, Oct 17, 12:48 AM · MediaWiki-Cache, MediaWiki-Core-Tests
Legoktm created T207247: WANObjectCacheTest::testGetWithSeveralCheckKeys is flaky.
Wed, Oct 17, 12:48 AM · MediaWiki-Cache, MediaWiki-Core-Tests

Tue, Oct 16

Legoktm added a comment to T180278: Expand our usage of FriendsOfPHP/security-advisories.
Tue, Oct 16, 9:53 PM · Patch-For-Review, Security-team-backlog, Composer, Librarization, Security-General, Continuous-Integration-Config, Security
Legoktm added a comment to T30856: Remove classic edit toolbar from core.

Also other places. And last year. And, yes, everyone who has offered to help is ready to do their bit on the schedule that we agreed to two months ago.

Tue, Oct 16, 7:04 PM · User-notice, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Legoktm closed T135600: After an error, ExtensionJsonValidationTest claims everything is invalid as Declined.

I don't think there's anything we can fix here with our current JSON schema validation infrastructure.

Tue, Oct 16, 6:48 PM · MediaWiki-Configuration, MediaWiki-Core-Tests
Legoktm moved T152263: Loading dependency from within another extension from Backlog to In Progress on the MediaWiki-Configuration board.
Tue, Oct 16, 6:44 PM · Patch-For-Review, MediaWiki-Configuration
Legoktm added a comment to T30856: Remove classic edit toolbar from core.

Uhh, is someone planning to work on this in that timeline?

Tue, Oct 16, 6:41 PM · User-notice, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Legoktm closed T111700: Extension Registration conversion script wont convert code that explicitly says $GLOBALS as Declined.

Per T142265#2882409.

Tue, Oct 16, 6:35 PM · MediaWiki-Configuration
Legoktm added a comment to T140851: Un-comment the wfWarn deprecations in all PHP entry points from all Wikimedia-deployed extensions and skins.

I think we should be able to do this given that we've switched everything over to wfLoadExtension already.

Tue, Oct 16, 6:23 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, MediaWiki-Configuration
Legoktm added a comment to T88567: [Task] Remove support for old extension registration/loading endpoint.

Uh yeah, this task should probably stay relevant to Wikibase. It's unlikely that the old style will ever go away entirely because it's just globals. Removing globals will happen though...

Tue, Oct 16, 6:22 PM · MediaWiki-Configuration, MediaWiki-extensions-General
Legoktm closed T131978: Composer support dosen't work as Resolved.

I think this was resolved by T131978#2185044. Please re-open with clear reproduction steps if not.

Tue, Oct 16, 6:12 PM · MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-Configuration
Legoktm added a comment to T30856: Remove classic edit toolbar from core.

I don't think this is ready for announcing yet - what I asked in T30856#3629674 is still unresolved. If we're going to tell people to just copy/fork the code into a gadget, we haven't really fixed the maintenance problem - we've just pushed it onto other people and given them less resources to do it well by moving it out of MediaWiki.

Tue, Oct 16, 6:10 PM · User-notice, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Legoktm added a comment to T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.

I backported everything that I could find with "7.2" and "7.3" in the commit message - 7.2 tests pass now on 1.31.

Tue, Oct 16, 5:31 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Legoktm closed T187287: CliInstaller: Allow turning off auto-enabling of skins and extensions as Resolved.

Tim fixed this in rMW5e9ada58821e: install.php: Allow extensions and skins to be specified.

Tue, Oct 16, 5:12 PM · MediaWiki-Installer
Legoktm added a watcher for Core Platform Team (Extension Management (TEC13)): Legoktm.
Tue, Oct 16, 4:59 PM
Legoktm closed T88596: Improving extension management as Declined.

This was focusing on the old 2015 RfC that I wrote. I need to go through this feedback, and the 2018 feedback and submit more, smaller and better scoped RfCs as necessary for the specific features we want to implement.

Tue, Oct 16, 4:54 PM · Wikimedia-Hackathon-2018, MediaWiki-Configuration, TechCom-RFC
Legoktm changed the status of T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()" from Open to Stalled.

Per Gerrit discussion and maybe a little on IRC, we're going to wait to drop HHVM / PHPUnit 4 support before adding a third PHPUnit runtime.

Tue, Oct 16, 4:48 PM · PHP 7.3 support, Patch-For-Review, MediaWiki-Core-Tests
Legoktm added a project to T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3: Core Platform Team (PHP7 (TEC4)).
Tue, Oct 16, 4:29 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
Legoktm closed T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3 as Resolved.
Tue, Oct 16, 4:12 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes, Core Platform Team (PHP7 (TEC4)), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), PHP 7.3 support, MediaWiki-Authentication-and-authorization
Legoktm closed T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3, a subtask of T204884: Run MediaWiki tests on PHP 7.3, as Resolved.
Tue, Oct 16, 4:12 PM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a comment to T207047: Can we simplify generating and ingesting code coverage reports for developers?.

Your first complaint is T192078: Figure out some way to not use addUncoveredFilesFromWhitelist="true" when running only some PHPUnit tests, and the second is T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file. Just needs time for people to sit down and work on it :)

Tue, Oct 16, 3:57 PM · Code-Health-Metrics
Legoktm added projects to T206013: importDump.php --uploads crashes on wikitech-static: MediaWiki-Export-or-Import, MW-1.31-release.
Tue, Oct 16, 3:53 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release, MediaWiki-Export-or-Import, Patch-For-Review, cloud-services-team (Kanban), wikitech.wikimedia.org
Legoktm added a comment to T207123: [AzharAuth] AzharAuth/AzharAuth.class.php triggers warnings on PHP 7.3.

This extension is considering for archival per T198601, still need patch for this?

Tue, Oct 16, 3:44 PM · PHP 7.3 support, MediaWiki-extensions-Other
Legoktm added a comment to T207127: Publish wikimedia/less.php on Packagist.

It's not being auto-updated because I'm not sure how to set up the new packagist hook.

Tue, Oct 16, 6:45 AM · PHP 7.3 support, Composer
Legoktm added a comment to T180278: Expand our usage of FriendsOfPHP/security-advisories.

Outside of MediaWiki extensions/skins (which I have a different plan for), what other repositories should we be checking for vulnerabilities on a regular basis?

Tue, Oct 16, 6:37 AM · Patch-For-Review, Security-team-backlog, Composer, Librarization, Security-General, Continuous-Integration-Config, Security
Legoktm added a comment to T194164: Start reading from change_tag_def in production.

Going to revert because of:

2018-10-16 06:26:29 [W8WElQpAMFcAAKy-ox4AAAIY] mw1252 hewiki 1.32.0-wmf.24 exception ERROR: [W8WElQpAMFcAAKy-ox4AAAIY] /w/index.php?namespace=lWCq&invert=1%27%3BSELECT%20%28CASE%20WHEN%20%285897%3D5897%29%20THEN%205897%20ELSE%201%2
F%28SELECT%200%29%20END%29--&associated=1&tagfilter=Uvhq&target=%D7%A2%D7%9E%D7%95%D7%93%20%D7%A8%D7%90%D7%A9%D7%99&showlinkedto=1&title=%D7%9E%D7%99%D7%95%D7%97%D7%93%3A%D7%A9%D7%99%D7%A0%D7%95%D7%99%D7%99%D7%9D%20%D7%91%D7%93%D7%
A4%D7%99%D7%9D%20%D7%94%D7%9E%D7%A7%D7%95%D7%A9%D7%A8%D7%99%D7%9D   InvalidArgumentException from line 2139 of /srv/mediawiki/php-1.32.0-wmf.24/includes/libs/rdbms/database/Database.php: Wikimedia\Rdbms\Database::makeList: empty in
put for field ct_tag_id {"exception_id":"W8WElQpAMFcAAKy-ox4AAAIY","exception_url":"/w/index.php?namespace=lWCq&invert=1%27%3BSELECT%20%28CASE%20WHEN%20%285897%3D5897%29%20THEN%205897%20E
LSE%201%2F%28SELECT%200%29%20END%29--&associated=1&tagfilter=Uvhq&target=%D7%A2%D7%9E%D7%95%D7%93%20%D7%A8%D7%90%D7%A9%D7%99&showlinkedto=1&title=%D7%9E%D7%99%D7%95%D7%97%D7%93%3A%D7%A9%D7%99%D7%A0%D7%95%D7%99%D7%99%D7%9D%20%D7%91%D7%93%D7%A4%D7%99%D7%9D%20%D7%94%D7%9E%D7%A7%D7%95%D7%A9%D7%A8%D7%99%D7%9D","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.32.0-wmf.24/includes/libs/rdbms/database/Database.php:2139) Wikimedia\Rdbms\Database::makeList: empty input for field ct_tag_id
  #0 /srv/mediawiki/php-1.32.0-wmf.24/includes/libs/rdbms/database/Database.php(1732): Wikimedia\Rdbms\Database->makeList(array, integer)
  #1 /srv/mediawiki/php-1.32.0-wmf.24/includes/specials/SpecialRecentchangeslinked.php(211): Wikimedia\Rdbms\Database->selectSQLText(array, array, array, string, array, array)
  #2 /srv/mediawiki/php-1.32.0-wmf.24/includes/specialpage/ChangesListSpecialPage.php(934): SpecialRecentChangesLinked->doMainQuery(array, array, array, array, array, FormOptions)
  #3 /srv/mediawiki/php-1.32.0-wmf.24/includes/specialpage/ChangesListSpecialPage.php(629): ChangesListSpecialPage->getRows()
  #4 /srv/mediawiki/php-1.32.0-wmf.24/includes/specials/SpecialRecentchanges.php(167): ChangesListSpecialPage->execute(NULL)
  #5 /srv/mediawiki/php-1.32.0-wmf.24/includes/specialpage/SpecialPage.php(569): SpecialRecentChanges->execute(NULL)
  #6 /srv/mediawiki/php-1.32.0-wmf.24/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
  #7 /srv/mediawiki/php-1.32.0-wmf.24/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #8 /srv/mediawiki/php-1.32.0-wmf.24/includes/MediaWiki.php(868): MediaWiki->performRequest()
  #9 /srv/mediawiki/php-1.32.0-wmf.24/includes/MediaWiki.php(525): MediaWiki->main()
  #10 /srv/mediawiki/php-1.32.0-wmf.24/index.php(42): MediaWiki->run()
  #11 /srv/mediawiki/w/index.php(3): include(string)
  #12 {main}
Tue, Oct 16, 6:27 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, Wikidata-Campsite, MediaWiki-Change-tagging
Legoktm updated subscribers of T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.

I wonder if this is caused by some of the mbstring changes? https://github.com/php/php-src/blob/php-7.3.0RC3/UPGRADING#L186

Tue, Oct 16, 6:21 AM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
Legoktm added a subtask for T204884: Run MediaWiki tests on PHP 7.3: T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3.
Tue, Oct 16, 6:08 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a parent task for T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3: T204884: Run MediaWiki tests on PHP 7.3.
Tue, Oct 16, 6:07 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes, Core Platform Team (PHP7 (TEC4)), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), PHP 7.3 support, MediaWiki-Authentication-and-authorization
Legoktm closed T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each(), a subtask of T204884: Run MediaWiki tests on PHP 7.3, as Resolved.
Tue, Oct 16, 6:05 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm closed T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each() as Resolved.
Tue, Oct 16, 6:05 AM · PHP 7.2 support, Discovery-Search, CirrusSearch
Legoktm closed T190024: Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2 as Resolved.

No backport to 1.31 needed because elastica isn't bundled.

Tue, Oct 16, 6:05 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, PHP 7.2 support, Discovery-Search, CirrusSearch, Discovery
Legoktm closed T190024: Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2 , a subtask of T183282: [epic] Search cluster upgrade to 6.x, as Resolved.
Tue, Oct 16, 6:05 AM · Epic, Discovery-Search
Legoktm closed T190024: Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2 , a subtask of T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each(), as Resolved.
Tue, Oct 16, 6:05 AM · PHP 7.2 support, Discovery-Search, CirrusSearch
Legoktm added a comment to T180278: Expand our usage of FriendsOfPHP/security-advisories.

Tue, Oct 16, 4:54 AM · Patch-For-Review, Security-team-backlog, Composer, Librarization, Security-General, Continuous-Integration-Config, Security
Legoktm added a comment to T206586: Write LuaSandbox DocBook manual.

I found https://svn.php.net/viewvc/phpdoc/en/trunk/reference/, and after skimming a few extensions, I think it'll be easier to just fork some other extension's documentation (that we like) and modify it as necessary.

Tue, Oct 16, 3:21 AM · Patch-For-Review, Documentation, Core Platform Team, LuaSandbox
Legoktm moved T207120: [MassEditRegex] MassEditRegex/MassEditRegex.special.php triggers warnings on PHP 7.3 from Backlog to Other on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, MediaWiki-extensions-Other
Legoktm moved T207119: BlueSpiceFoundation maintenance scripts trigger warnings on PHP 7.3 from Backlog to Other on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, BlueSpice
Legoktm moved T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 from Backlog to MediaWiki core on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
Legoktm moved T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3 from Backlog to MediaWiki core on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes, Core Platform Team (PHP7 (TEC4)), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), PHP 7.3 support, MediaWiki-Authentication-and-authorization
Legoktm moved T207116: CentralAuth/maintenance/migrateAccount.php triggers warnings on PHP 7.3 from Backlog to Wikimedia production on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, MediaWiki-extensions-CentralAuth
Legoktm moved T207117: Translate/scripts/magic-export.php triggers warnings on PHP 7.3 from Backlog to Wikimedia production on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, MediaWiki-extensions-Translate
Legoktm moved T207118: intersection/DynamicPageList.hooks.php triggers warnings on PHP 7.3 from Backlog to Wikimedia production on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, DynamicPageList (Wikimedia)
Legoktm moved T207121: DonationInterface/gateway_common/gateway.adapter.php triggers warnings on PHP 7.3 from Backlog to Wikimedia production on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, MediaWiki-extensions-DonationInterface
Legoktm moved T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 from Backlog to Wikimedia production on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, Growth-Team, StructuredDiscussions
Legoktm moved T207123: [AzharAuth] AzharAuth/AzharAuth.class.php triggers warnings on PHP 7.3 from Backlog to Other on the PHP 7.3 support board.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, MediaWiki-extensions-Other
Legoktm added a project to T204884: Run MediaWiki tests on PHP 7.3: PHP 7.3 support.
Tue, Oct 16, 2:56 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a subtask for T204884: Run MediaWiki tests on PHP 7.3: T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:55 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a parent task for T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3: T204884: Run MediaWiki tests on PHP 7.3.
Tue, Oct 16, 2:55 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, Growth-Team, StructuredDiscussions
Legoktm added a comment to T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.

Note, this also triggers test failures \o/

Tue, Oct 16, 2:55 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, Growth-Team, StructuredDiscussions
Legoktm created T207123: [AzharAuth] AzharAuth/AzharAuth.class.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:52 AM · PHP 7.3 support, MediaWiki-extensions-Other
Legoktm created T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:50 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, Growth-Team, StructuredDiscussions
Legoktm created T207121: DonationInterface/gateway_common/gateway.adapter.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:50 AM · PHP 7.3 support, MediaWiki-extensions-DonationInterface
Legoktm created T207120: [MassEditRegex] MassEditRegex/MassEditRegex.special.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:49 AM · PHP 7.3 support, MediaWiki-extensions-Other
Legoktm created T207119: BlueSpiceFoundation maintenance scripts trigger warnings on PHP 7.3.
Tue, Oct 16, 2:48 AM · PHP 7.3 support, BlueSpice
Legoktm created T207118: intersection/DynamicPageList.hooks.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:47 AM · PHP 7.3 support, DynamicPageList (Wikimedia)
Legoktm created T207117: Translate/scripts/magic-export.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:47 AM · PHP 7.3 support, MediaWiki-extensions-Translate
Legoktm created T207116: CentralAuth/maintenance/migrateAccount.php triggers warnings on PHP 7.3.
Tue, Oct 16, 2:46 AM · PHP 7.3 support, MediaWiki-extensions-CentralAuth
Legoktm created T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3.
Tue, Oct 16, 1:37 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes, Core Platform Team (PHP7 (TEC4)), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), PHP 7.3 support, MediaWiki-Authentication-and-authorization
Legoktm added a comment to T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.

@Jdforrester-WMF I removed T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()" as a blocker since so far testing shows that PHPUnit 6 seems to work fine on PHP 7.3.

Tue, Oct 16, 12:27 AM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Legoktm edited subtasks for T206988: MediaWiki 1.31.x should be compatible with PHP 7.3, added: T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3, T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3, T206974: maintenance/storage/checkStorage.php triggers warnings in PHP 7.3, T206977: ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3; removed: T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()".
Tue, Oct 16, 12:25 AM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Legoktm removed a parent task for T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()": T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Tue, Oct 16, 12:25 AM · PHP 7.3 support, Patch-For-Review, MediaWiki-Core-Tests
Legoktm added a parent task for T206974: maintenance/storage/checkStorage.php triggers warnings in PHP 7.3: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Tue, Oct 16, 12:25 AM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, PHP 7.3 support, MediaWiki-Maintenance-scripts
Legoktm added a parent task for T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Tue, Oct 16, 12:25 AM · Patch-For-Review, PHP 7.3 support, Upstream, MediaWiki-Vendor
Legoktm added a parent task for T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Tue, Oct 16, 12:25 AM · PHP 7.3 support, MediaWiki-extensions-LocalisationUpdate
Legoktm added a parent task for T206977: ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Tue, Oct 16, 12:25 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, PHP 7.3 support, MediaWiki-extensions-ParserFunctions

Mon, Oct 15

Legoktm renamed T206636: Provide a way to have test servers on real hardware, isolated from production for Wikidata Query Service from Provide a way to have test servers on real hardware, isolated from production to Provide a way to have test servers on real hardware, isolated from production for Wikidata Query Service.
Mon, Oct 15, 10:58 PM · Wikidata, cloud-services-team, Operations, Wikidata-Query-Service
Legoktm added a subtask for T204884: Run MediaWiki tests on PHP 7.3: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.
Mon, Oct 15, 10:45 PM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm added a parent task for T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3: T204884: Run MediaWiki tests on PHP 7.3.
Mon, Oct 15, 10:45 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
Legoktm created T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.
Mon, Oct 15, 10:44 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
Legoktm added a comment to T206949: Where do we merge non-config globals between extensions?.

Extensions shouldn't be modifying other extensions' config settings. If extensions need to configure something in another extension, they should use attributes instead, which use array_merge_recursive. In practice this works out fine since most attributes are keyed by the registering extension name.

Mon, Oct 15, 10:03 PM · MediaWiki-Configuration
Legoktm added a comment to T206948: Allow deprecating extension configuration settings via extension.json.

I like the idea.

Mon, Oct 15, 10:00 PM · MediaWiki-Configuration
Legoktm renamed T204884: Run MediaWiki tests on PHP 7.3 from Run MediaWiki tests on PHP 7.2 to Run MediaWiki tests on PHP 7.3.
Mon, Oct 15, 9:52 PM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, Continuous-Integration-Infrastructure
Legoktm closed T206816: Move extension "npm test" out of quibble jobs as Resolved.

Should be good now.

Mon, Oct 15, 8:25 PM · Patch-For-Review, Continuous-Integration-Config, Quibble
Legoktm added a comment to T206825: Get libraryupgrader's "npm audit fix" mode to a level where we feel comfortable letting it auto +2.

Thanks @Umherirrender, it'll take me some time to do follow-up but finding all the logs is really helpful.

Mon, Oct 15, 8:25 PM · VPS-project-libraryupgrader
Legoktm created T207087: Consider consolidating npm-test-* variants that install library dependencies.
Mon, Oct 15, 8:12 PM · Continuous-Integration-Config
Krinkle awarded T206816: Move extension "npm test" out of quibble jobs a Orange Medal token.
Mon, Oct 15, 7:56 PM · Patch-For-Review, Continuous-Integration-Config, Quibble
Legoktm merged T206911: mwgate-npm-node-6-docker broken on vendor into T206816: Move extension "npm test" out of quibble jobs.
Mon, Oct 15, 7:30 PM · Patch-For-Review, Continuous-Integration-Config, Quibble
Legoktm merged task T206911: mwgate-npm-node-6-docker broken on vendor into T206816: Move extension "npm test" out of quibble jobs.
Mon, Oct 15, 7:30 PM · Continuous-Integration-Infrastructure
Legoktm merged T207076: All patches to mediawiki/vendor fail CI due to new package.json requirement into T206816: Move extension "npm test" out of quibble jobs.
Mon, Oct 15, 7:29 PM · Patch-For-Review, Continuous-Integration-Config, Quibble
Legoktm merged task T207076: All patches to mediawiki/vendor fail CI due to new package.json requirement into T206816: Move extension "npm test" out of quibble jobs.
Mon, Oct 15, 7:29 PM · Continuous-Integration-Config
Legoktm updated subscribers of T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3.
Mon, Oct 15, 6:03 PM · PHP 7.3 support, MediaWiki-extensions-LocalisationUpdate
Legoktm moved T206979: compact(): Undefined variable in LocalisationCache on PHP 7.3 from Backlog to MediaWiki core on the PHP 7.3 support board.
Mon, Oct 15, 6:03 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, MW-1.31-release, PHP 7.3 support, MediaWiki-Cache
Legoktm closed T206974: maintenance/storage/checkStorage.php triggers warnings in PHP 7.3 as Resolved.
Mon, Oct 15, 6:03 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, PHP 7.3 support, MediaWiki-Maintenance-scripts
Legoktm added a comment to T206970: Investigate using simple grep to check js for raw html messages.

OK, I guess we can do this pretty trivially. Long-term is it possible to implement this with eslint or something?

Mon, Oct 15, 6:02 PM · Security, Security-Team
Legoktm added a comment to T200997: Add raw HTML messages in WMF-deployed extensions to $wgRawHtmlMessages.

[Note i don't have all extensions downloaded]

Mon, Oct 15, 6:00 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Security, Patch-For-Review, Security-General, I18n, MediaWiki-Internationalization
Legoktm changed the status of T203278: Archive Mathoid deploy repo from Open to Stalled.
Mon, Oct 15, 5:37 PM · Mathoid, Core Platform Team Backlog (Watching / External), Services (watching), GitHub-Mirrors, Repository-Admins, Cleanup, Release-Engineering-Team (Kanban), Release Pipeline (Blubber)
Legoktm updated subscribers of T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Mon, Oct 15, 7:27 AM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release