Legoktm (Legoktm)Administrator
User

Projects (92)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (156 w, 4 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Today

Legoktm updated the task description for T144366: De-globalize EditPage.php and use RequestContext instead.
Wed, Sep 20, 4:57 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Technical-Debt, MediaWiki-Page-editing
Legoktm added a comment to T144366: De-globalize EditPage.php and use RequestContext instead.

The last remaining usage of $wgOut will go away with T30856: Remove classic edit toolbar from core so I'm tempted to leave it for now.

Wed, Sep 20, 4:25 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Technical-Debt, MediaWiki-Page-editing

Yesterday

Legoktm added a comment to T176213: Access to deployment-prep for sau226.

@Sau226 I think you currently don't understand what beta cluster is even for. From a quick glance at deletion logs, pages you're deleting and then salting as spam are most definitely not.

Tue, Sep 19, 5:19 PM · Beta-Cluster-Infrastructure
Legoktm claimed T174416: Update library bootstrap creator and have it use a library that's maintained.
Tue, Sep 19, 5:57 AM · Patch-For-Review, Librarization
Legoktm added a comment to T176142: Please add David Chan back to ldap/wmf.

There are two LDAP users here I think...

Tue, Sep 19, 12:40 AM · Patch-For-Review, LDAP-Access-Requests
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

@Legoktm why do we start of from another repo? It clutters the history and makes the files that matter hard to review due to all the noise of deleted files.

Tue, Sep 19, 12:28 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof
Jeff_G awarded T175444: File History: Comments are not displayed all versions a Yellow Medal token.
Tue, Sep 19, 12:20 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Multimedia, MediaWiki-File-management, Commons, Regression

Mon, Sep 18

MGChecker awarded T71445: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites a Like token.
Mon, Sep 18, 9:43 PM · User-Tgr, Developer-Wishlist (2017), Developer-Relations, Gadgets, Security-General, JavaScript, Wikimedia-General-or-Unknown
Offnfopt awarded T175444: File History: Comments are not displayed all versions a Cookie token.
Mon, Sep 18, 8:12 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Multimedia, MediaWiki-File-management, Commons, Regression
Legoktm closed T173174: Composer support as Declined.

The Vector skin doesn't support being installed by composer.

Mon, Sep 18, 3:12 AM · Composer, Vector

Fri, Sep 15

Legoktm added a comment to T91192: Show edits made on WikimediaCommons on the Watchlist.

Yes, I think so. However what I said earlier still applies:

Fri, Sep 15, 7:02 PM · Crosswiki, Commons, Contributors-Team, Multimedia, GlobalUsage, Possible-Tech-Projects, MediaWiki-Watchlist
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

Repo created as mediawiki/libs/Equivset. Mirror on Github: https://github.com/wikimedia/mediawiki-libs-Equivset

Fri, Sep 15, 7:05 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

I'm not sure if it ought to be EquivSet or Equivset (I went with the latter, but I can change it).

Fri, Sep 15, 6:52 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

For PHP libraries that are used by MediaWiki where we're the author, we highly recommend Gerrit. I can create mediawiki/libs/EquivSet for you? There will also be a GitHub mirror that will be used to trigger the packagist hook.

Works for me. you can just create a clone of Abuse Filter

Fri, Sep 15, 6:51 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof
Legoktm added a comment to T174760: Grant libraryupgrader +2 rights for some library bumps.

So are there any remaining issues with giving libraryupgrader +2?

Fri, Sep 15, 6:46 AM · Repository-Ownership-Requests, Gerrit, VPS-project-libraryupgrader
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

For PHP libraries that are used by MediaWiki where we're the author, we highly recommend Gerrit. I can create mediawiki/libs/EquivSet for you? There will also be a GitHub mirror that will be used to trigger the packagist hook.

Fri, Sep 15, 6:45 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof
Legoktm added a comment to T175978: Keep using the 'editmyoptions' user right for GlobalPreferences.

At that time I was thinking of OAuth/BotPasswords. Both of those have editmyoptions as a separate grant, and I wasn't sure if we also needed to have a separate user right plus separate grant for it. I think the current right is good enough though.

Fri, Sep 15, 6:08 AM · Community-Tech, GlobalPreferences
Legoktm added a comment to T174197: Split off AntiSpoof equivset generation and string normalization into its own library.

mediawiki/libs/[something] in Gerrit? Did you file a new repository creation request? We probably want to name the library something other than "AntiSpoof" though since that name is already taken.

Fri, Sep 15, 5:54 AM · Anti-Harassment (AHT Sprint 5), Patch-For-Review, Librarization, AntiSpoof

Thu, Sep 14

Legoktm updated the task description for T9004: PHP iconv() notice on bad password input to Special:Userlogin, with E_ALL enabled..
Thu, Sep 14, 8:03 PM · MediaWiki-Special-pages
Legoktm committed rESCCb0c58d8b9695: Properly unset AlternateEdit hook to avoid recursion (authored by Legoktm).
Properly unset AlternateEdit hook to avoid recursion
Thu, Sep 14, 7:06 PM
Legoktm added a comment to T165520: rack and setup wtp1025-1048.

I think we are done. The new parsoid boxes are up and running. They are running Debian stretch and nodejs 6.11. They are not pooled and do not serve any kind of traffic currently. Icinga is green and seems like all checks are running fine. @ssastry @Arlolra, would you like to test the new boxes and give a thumbs up (or down...) ?

Thu, Sep 14, 5:59 PM · Patch-For-Review, Operations
greg awarded T175794: Add MinusX to MediaWiki extensions and PHP library repos a Goat token.
Thu, Sep 14, 4:57 PM · Continuous-Integration-Config, MinusX
Legoktm moved T174963: Adopt semver for MediaWiki-CodeSniffer future releases from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Thu, Sep 14, 6:47 AM · MediaWiki-Codesniffer
Legoktm added a project to T175866: Wikipedia triggers multiple 20ms+ browser hangs for restyles for separate "addEmbeddedCSS" calls: MediaWiki-ResourceLoader.
Thu, Sep 14, 6:43 AM · Performance-Team, MediaWiki-ResourceLoader
Legoktm added a comment to T175792: HTTP 500 on af:Sjabloon:Omreken/Duaal/KafAafVhEaf.

Also a 500 on https://am.wikipedia.org/wiki/%E1%88%98%E1%88%88%E1%8C%A0%E1%8D%8A%E1%8B%AB%3AIf do you think it could be the same problem?

Thu, Sep 14, 5:49 AM · Parsoid
Legoktm added a comment to T127292: [Task] Move DataTypes repository from Github to gerrit.

Given that there's code in here that extends MediaWiki classes, it's most definitely an extension in its current form. That still leaves us with an option to move the MediaWiki-specific code in to Wikibase and keep it as a library, or treat the entire thing as an extension.

Thu, Sep 14, 3:03 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Sprint-2016-04-12, Wikidata-Sprint-2016-03-01, Gerrit, Wikidata
Legoktm added a comment to T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays.

Okay, I see the rationale for not introducing new flat arrays. I'll just use boolean ones for the task that drove me here then.

But still, we currently need workarounds like this one in the configuration. I'm not convinced that's a good way either.

I understand your comment as a suggestion of declining this task and abandoning the patch (correct me if that's wrong). What's the alternative for dealing with existing flat arrays then? If it is the removal all flat array config variables from all major extensions, is it realistic that all will be refactored in the foreseeable future? If we can't do that, there should probably be a way of dealing with flat arrays - without applying workarounds.

Thu, Sep 14, 2:23 AM · Patch-For-Review, MediaWiki-Configuration

Wed, Sep 13

Legoktm added a comment to T152169: URL parameter to temporarily disable user scripts/gadgets.

Confusingly, EditPage also has a &safemode= parameter which is entirely unrelated (luckily it should be going away soon).

Wed, Sep 13, 11:08 PM · User-notice, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-ResourceLoader
Legoktm added a comment to T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code.

I like Krinkle's idea the most (option #5) for now, mostly because it's probably the easiest, and seems relatively straightforward to move away from in the future.

Wed, Sep 13, 9:41 PM · Release-Engineering-Team (Watching / External), Wikidata
Jdforrester-WMF awarded T175794: Add MinusX to MediaWiki extensions and PHP library repos a Like token.
Wed, Sep 13, 8:27 PM · Continuous-Integration-Config, MinusX
Tgr awarded T175794: Add MinusX to MediaWiki extensions and PHP library repos a Doubloon token.
Wed, Sep 13, 6:53 PM · Continuous-Integration-Config, MinusX
Legoktm added a comment to T175853: [Spike 16hr] Investigate the ability of Python wrapped headless Chromium to render large books.

I assume you mean Chromium? Google Chrome isn't free software.

Wed, Sep 13, 6:38 PM · Proton, Spike, Readers-Web-Kanban-Board, Readers-Web-Backlog
Legoktm added a comment to T175818: Deploy new Wikidiff2 version on beta-cluster.

I tagged 1.5.0, and prepared packaging changes:

Wed, Sep 13, 6:17 PM · Patch-For-Review, Release-Engineering-Team (Watching / External), Beta-Cluster-Infrastructure, User-Addshore, Operations, WMDE-QWERTY-Team-Board, TCB-Team
Legoktm renamed T175794: Add MinusX to MediaWiki extensions and PHP library repos from Add MinusX to MediaWiki extensions and other repositories to Add MinusX to MediaWiki extensions and PHP library repos.
Wed, Sep 13, 5:31 PM · Continuous-Integration-Config, MinusX
Legoktm added a comment to T175794: Add MinusX to MediaWiki extensions and PHP library repos.

Right, that makes sense. I was mostly thinking about PHP library repos at the time, let me reword it to mean that.

Wed, Sep 13, 5:30 PM · Continuous-Integration-Config, MinusX
Addshore awarded T175794: Add MinusX to MediaWiki extensions and PHP library repos a Goat token.
Wed, Sep 13, 7:18 AM · Continuous-Integration-Config, MinusX
Legoktm closed T168659: Reject non-executable files with execute bits with a build check as Resolved.

I've announced the creationg of MinusX to wikitech-l: https://lists.wikimedia.org/pipermail/wikitech-l/2017-September/088736.html

Wed, Sep 13, 7:13 AM · MinusX, Patch-For-Review, Continuous-Integration-Config
Legoktm added a watcher for MinusX: Legoktm.
Wed, Sep 13, 6:56 AM
Legoktm created T175794: Add MinusX to MediaWiki extensions and PHP library repos.
Wed, Sep 13, 6:56 AM · Continuous-Integration-Config, MinusX
Legoktm created T175792: HTTP 500 on af:Sjabloon:Omreken/Duaal/KafAafVhEaf.
Wed, Sep 13, 4:18 AM · Parsoid
Legoktm added a comment to T175757: Store wp10 predictions in page_props table. .

More specifically, page properties are set by calling ParserOutput::setProperty() during the parse process. I'm not sure how we can add ORES scores at that point.

Wed, Sep 13, 4:08 AM · User-Ladsgroup, MediaWiki-extensions-ORES, Scoring-platform-team
Legoktm added a comment to T175757: Store wp10 predictions in page_props table. .

Page props are generally things that are extracted out of wikitext/parsing process. I don't think things generated by ORES fit this pattern...

Wed, Sep 13, 4:06 AM · User-Ladsgroup, MediaWiki-extensions-ORES, Scoring-platform-team

Tue, Sep 12

Legoktm added a comment to T174642: Transcluding a talk page on another page sends mention notifications for all the users on the page being transcluded.

Transcluding a talk page on another page sends mention notifications for all the users on the page being transcluded

Tue, Sep 12, 6:21 PM · Collaboration-Team-Triage, Notifications
Legoktm committed rESCCfea63fa4503c: Use the new EditPage::getSubmitButtonLabel() method (authored by Legoktm).
Use the new EditPage::getSubmitButtonLabel() method
Tue, Sep 12, 6:21 PM
Legoktm committed rESCC19caaea3187d: Drop support for pre-OOUI EditPage (authored by Legoktm).
Drop support for pre-OOUI EditPage
Tue, Sep 12, 6:21 PM
Legoktm added a parent task for T167246: Refactor "user" & "user_text" fields into "actor" reference table: T33863: Fix use of DB schema so RenameUser is trivial.
Tue, Sep 12, 2:50 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
Legoktm added a subtask for T33863: Fix use of DB schema so RenameUser is trivial: T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Tue, Sep 12, 2:50 PM · DBA, MediaWiki-extensions-Renameuser
Legoktm edited projects for T175670: Squeeze some more bytes out of the wordmark SVG, added: Wikimedia-Site-requests; removed MediaWiki-Configuration.
Tue, Sep 12, 2:48 PM · Readers-Web-Backlog, Wikimedia-Site-requests, Patch-For-Review, Performance, MobileFrontend
zhuyifei1999 awarded T174769: Make it less cumbersome to bootstrap and update python webservices a Love token.
Tue, Sep 12, 3:17 AM · Toolforge
Legoktm added a comment to T167246: Refactor "user" & "user_text" fields into "actor" reference table.

Because individual database tables will no longer have copies of the username (just once in user and actor), this should resolve T33863: Fix use of DB schema so RenameUser is trivial right?

Tue, Sep 12, 3:09 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
Legoktm committed R2151:40fcb832595b: Add HISTORY.md (authored by Legoktm).
Add HISTORY.md
Tue, Sep 12, 2:25 AM
Legoktm committed R2151:9b9e2a588fc2: Add "homepage" to composer.json (authored by Legoktm).
Add "homepage" to composer.json
Tue, Sep 12, 2:24 AM
Legoktm updated the task description for T174769: Make it less cumbersome to bootstrap and update python webservices.
Tue, Sep 12, 2:18 AM · Toolforge

Mon, Sep 11

Legoktm added a project to T168659: Reject non-executable files with execute bits with a build check: MinusX.
Mon, Sep 11, 11:54 PM · MinusX, Patch-For-Review, Continuous-Integration-Config
Legoktm created MinusX.
Mon, Sep 11, 11:45 PM
Legoktm added a comment to T175462: Inability to lock via setglobalaccountstatus API in mw 1.29.

With your permission, I'm trying to cherry-pick this to current WMF branch as at least one tool we use from time to time happens to rely on this... zuul volente, as it's currently recovering from downtime and is terribly slow.

Mon, Sep 11, 10:26 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, MediaWiki-extensions-CentralAuth
Legoktm added a comment to T175462: Inability to lock via setglobalaccountstatus API in mw 1.29.

Shall we cherry-pick the above to the current wmf branch & others until at least when the bug appeared, and its releases?

Mon, Sep 11, 6:19 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, MediaWiki-extensions-CentralAuth
Legoktm added a comment to T175536: "Special:ExtensionDistributor" does not include 'vendor/' directory.

ExtensionDistributor's bundling of the vendor directory was really just intended for fetching external dependencies, not for composer autoloading. It's already a hack anyways, so I'd much rather recommend waiting for T99865: Extension registration should support using a PSR-4 autoloader which should be coming soon instead of using composer for autoloading...

Mon, Sep 11, 5:39 PM · ExtensionDistributor
Legoktm added a comment to T175260: As a MediaWiki.org admin or Newsletter publisher, I cannot manage my own newsletter.

In the short-term I'd recommend reverting my commit (https://gerrit.wikimedia.org/r/#/c/329202), which was just supposed to be cleanup and not have any actual effects. Long term we should probably refactor EditPage and make the edit conflict handling pluggable or something, so it doesn't require overriding the whole page (composition not inheritance).

Mon, Sep 11, 5:29 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-09-05, User-Addshore, Two-Column-Edit-Conflict-Merge, TCB-Team, MediaWiki-extensions-Newsletter
MarcoAurelio awarded T175547: Make extension-CheckUser and extension-SecurePoll groups on gerrit visible to all a Goat token.
Mon, Sep 11, 11:46 AM · Gerrit
Legoktm closed T174280: Requesting +2 for Huji on CheckUser as Resolved.

Done.

Mon, Sep 11, 7:56 AM · CheckUser, Repository-Ownership-Requests

Sun, Sep 10

Legoktm created T175504: Figure out how to properly document variadic arguments.
Sun, Sep 10, 10:57 PM · MediaWiki-Codesniffer
Legoktm created T175465: Be aware of extension's minimum MediaWiki version supported.
Sun, Sep 10, 6:39 AM · MediaWiki-Codesniffer
Legoktm updated subscribers of T175462: Inability to lock via setglobalaccountstatus API in mw 1.29.

@MarcoAurelio do you know if any Wikimedia Stewards are using this particular API module to lock accounts? It probably hasn't been working on Wikimedia sites since January 2017.

Sun, Sep 10, 6:11 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, MediaWiki-extensions-CentralAuth
Legoktm claimed T175462: Inability to lock via setglobalaccountstatus API in mw 1.29.

Nice find, this is a regression from rECAU6b4dda7de6a2: Update for API error i18n.

Sun, Sep 10, 6:07 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, MediaWiki-extensions-CentralAuth

Sat, Sep 9

Legoktm closed T174642: Transcluding a talk page on another page sends mention notifications for all the users on the page being transcluded as Declined.

This is intentional. Without it, {{ping}} and co wouldn't work.

Sat, Sep 9, 8:46 PM · Collaboration-Team-Triage, Notifications
Legoktm reopened T169521: blog interview: Administrator at Wkipikedia – Emma as "Open".

Closing this task, please put such requests on Meta, not here.

Sat, Sep 9, 8:45 PM · User-Gitta
Legoktm closed T175444: File History: Comments are not displayed all versions as Resolved.

This should be fixed now.

Sat, Sep 9, 8:45 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Multimedia, MediaWiki-File-management, Commons, Regression
Legoktm closed T175443: [BUG] API:Imageinfo returns null for &iiprop=comment as Resolved.

This should be fixed now. Cached entries for images on Commons might take a while to invalidate though.

Sat, Sep 9, 8:44 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, Multimedia, Commons, MediaWiki-File-management, Patch-For-Review, MediaWiki-API
Legoktm added a comment to T175450: Support suppression (oversight) of newsletters.

Oversighters should already be able to do this. Is that not the case?

Have not tested but there's no change in mediawiki's oversighter group permissions, nor the extension.json file shows any suppress related right.

Sat, Sep 9, 8:17 PM · Stewards-and-global-tools, WorkType-NewFunctionality, MediaWiki-extensions-Newsletter, Security-Extensions, Security
Legoktm merged task T175458: API: Missing comment data for files in query imageinfo with iiprog=comment. into T175443: [BUG] API:Imageinfo returns null for &iiprop=comment.
Sat, Sep 9, 7:46 PM
Legoktm merged T175458: API: Missing comment data for files in query imageinfo with iiprog=comment. into T175443: [BUG] API:Imageinfo returns null for &iiprop=comment.
Sat, Sep 9, 7:46 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, Multimedia, Commons, MediaWiki-File-management, Patch-For-Review, MediaWiki-API
Samwilson awarded T174963: Adopt semver for MediaWiki-CodeSniffer future releases a Like token.
Sat, Sep 9, 12:08 PM · MediaWiki-Codesniffer
Legoktm added projects to T175443: [BUG] API:Imageinfo returns null for &iiprop=comment: MediaWiki-File-management, Regression.
Sat, Sep 9, 10:01 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, Multimedia, Commons, MediaWiki-File-management, Patch-For-Review, MediaWiki-API
Legoktm added a comment to T175443: [BUG] API:Imageinfo returns null for &iiprop=comment.

I put together a patch that fixed the issue for me locally, and passes tests. How impactful is this API regression? Does it require an emergency deploy over the weekend or can it wait until Monday?

Sat, Sep 9, 10:00 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Regression, Multimedia, Commons, MediaWiki-File-management, Patch-For-Review, MediaWiki-API
Legoktm triaged T173399: Support StopForumSpam's IPv6 blocklists as Lowest priority.

SFS barely has any IPv6 addresses for whatever reason.

Sat, Sep 9, 6:12 AM · MediaWiki-extensions-StopForumSpam
Liuxinyu970226 awarded T145604: [RfC] Future of magic links a Like token.
Sat, Sep 9, 2:44 AM · TechCom-Has-shepherd, MediaWiki-Parser, TechCom-RfC
Legoktm added a comment to T174860: Define naming scheme for connecting to new wiki replica cluster.

I'm not fully aware of the technical considerations in this task, but is it possible to do <whatever>.eqiad.wmcloud instead of "wmflabs"? And, would we even want to start doing that?

Sat, Sep 9, 12:03 AM · Patch-For-Review, cloud-services-team (Kanban), Data-Services, User-bd808

Fri, Sep 8

Legoktm added a comment to T175367: Page wikipedia.

I'm sorry, what was the thinking behind creating this task? Could someone please add a description?

Fri, Sep 8, 7:28 PM · Trash
Legoktm renamed T175356: Enable WikidataPageBanner extension on ru.wikimedia.org from PAGEBANNER extension activation on ru.wikiMedia.org to Enable WikidataPageBanner extension on ru.wikimedia.org.
Fri, Sep 8, 7:27 PM · Patch-For-Review, User-MarcoAurelio, Wikimedia-Site-requests
Legoktm edited projects for T175398: Interwiki to page deleted months ago wasn't removed, added: Wikidata; removed Regression, MediaWiki-Interwiki, MediaWiki-Database.

The page was moved and the interwiki wasn't updated on Wikidata, so putting under Wikidata .

Fri, Sep 8, 7:26 PM · Wikidata
Legoktm moved T173175: Add sniff to prefer short is_int over is_integer from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Fri, Sep 8, 5:45 PM · MediaWiki-Codesniffer
Legoktm moved T175374: suggest proper ordering for doxygen tags from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.
Fri, Sep 8, 5:45 PM · MediaWiki-Codesniffer
Legoktm added a comment to T175374: suggest proper ordering for doxygen tags.

Yep, this should be possible to do in our FunctionCommentSniff rules.

Fri, Sep 8, 5:45 PM · MediaWiki-Codesniffer
Legoktm added a comment to T175304: Page status buttons do not appear any more in Wikisource.

Change 376661 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ProofreadPage@master] Restore page status buttons

https://gerrit.wikimedia.org/r/376661

Fri, Sep 8, 5:45 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, ProofreadPage, Wikisource
Legoktm updated subscribers of T175304: Page status buttons do not appear any more in Wikisource.

Hmm, this is probably related to the changes to EditPage::getCheckboxes().

Fri, Sep 8, 5:36 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, ProofreadPage, Wikisource
Legoktm added a comment to T175328: "CategoryAboveAll.js" gadget on enwp: "Place the category box above all other content" affects section anchors.

@Legoktm even when they're built into enwp's preferences panel? It isn't an external gadget—I thought it was part of Mediawiki

Fri, Sep 8, 5:25 AM · Wikimedia-General-or-Unknown
Legoktm closed T175328: "CategoryAboveAll.js" gadget on enwp: "Place the category box above all other content" affects section anchors as Invalid.

We don't track issues with on-wiki gadgets on Phabricator, you could try at https://en.wikipedia.org/wiki/Wikipedia_talk:Gadget or WP:VPT again? Sorry about that.

Fri, Sep 8, 5:22 AM · Wikimedia-General-or-Unknown
Legoktm created T175324: It shouldn't be possible to create WMF branches on master.
Fri, Sep 8, 1:05 AM · Patch-For-Review, Release-Engineering-Team, Deployment-Systems

Thu, Sep 7

Legoktm added a comment to T161882: Migrate PHP5.5 jobs from Trusty to Jessie.

Don't we need xdebug for phpunit coverage?

Thu, Sep 7, 5:23 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (phase-out-trusty)
Legoktm claimed T168659: Reject non-executable files with execute bits with a build check.

I started working on a separate tool that will let us do automated checks as part of CI for this. It'll be a composer installed package, so it could be added to each repo's "composer test" command.

Thu, Sep 7, 7:25 AM · MinusX, Patch-For-Review, Continuous-Integration-Config
Legoktm added a comment to T171392: Some Commons pages transcluding Template:Countries_of_Europe HTTP 500/503 due to OOM in Lua→PHP→Lua calls.

AIUI the fix for this bug is currently being rolled out as part of T173705: HHVM: Unknown exception.

Thu, Sep 7, 5:09 AM · Patch-For-Review, Wikimedia-log-errors, MediaWiki-extensions-Scribunto, Operations, Commons
Nicolas_Raoul awarded T108557: Review and deploy UrlShortener extension to Wikimedia wikis a Like token.
Thu, Sep 7, 3:04 AM · Availability (Multiple-active-datacenters), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup

Wed, Sep 6

Legoktm added a comment to T175090: Blue button to do Verified+2.

Someone ran into this accidentally (meaning to CR+2).

Wed, Sep 6, 11:39 PM · Gerrit
Legoktm closed T129692: [edit] link in WikiLove preview screen causes data loss as Resolved.
Wed, Sep 6, 10:37 PM · Patch-For-Review, WikiLove, Collaboration-Team-Triage
Legoktm added a comment to T174553: Create an extension that allows fetching geolocation and subnet data for IP addresses.

Only the ASN data comes close to solving the subnetting problem, but even then it's not a great solution. ASNs are in many cases larger in scope than the kind of association you're looking for, as many organizations purchase un-portable subnets from upstream providers. For example, there might be thousands of distinct subnets belonging to distinct entities/businesses across the US that would all lookup to the same Comcast ASN, as they've all purchased un-portable ranges from Comcast as their provider. In that same ASN there might also be individual home subscribers hundreds of miles apart from each other in geographic terms.

In any case, it's possible this whole ticket is a victim of an X-Y Problem. Maybe rewind to the initial problems and assumptions and broaden the search for solutions a bit?

Wed, Sep 6, 6:44 PM · MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
Legoktm removed a reviewer for D7: Testing: DO not merge: Legoktm.
Wed, Sep 6, 6:35 PM
Legoktm added a comment to T174553: Create an extension that allows fetching geolocation and subnet data for IP addresses.

Hm, would it be helpful to focus on geolocation and subnet as different problems? Or should we theoretically be getting them from the same data source? I think the geolocation information is still useful to have, even without subnet info.

Wed, Sep 6, 5:45 PM · MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
Legoktm added a comment to T170989: HTTP redirect to TLS-encrypted connection on xtools.wmflabs.org.

The solution outlined in T170989#3575779 seems fine.

Except for the obvious problem that we don't use nginx. We use Apache. Hense my further investigation into this.

Wed, Sep 6, 5:30 AM · User-Matthewrbowker, Security, XTools
Legoktm added a comment to T174553: Create an extension that allows fetching geolocation and subnet data for IP addresses.

See also https://tools.wmflabs.org/whois/gateway.py, which pulls from an array of providers that don't appear to be paid.

Wed, Sep 6, 5:22 AM · MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser