Page MenuHomePhabricator

Legoktm (Legoktm)
UserAdministrator

Projects (100)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (406 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Today

Legoktm added a comment to T36928: Create a user right that allows ignoring the spam blacklist.

I'll remove Anomie's -2 and see what I can do about re-opening their Gerrit account.

Thu, Jul 7, 2:51 AM · Patch-Needs-Improvement, User-DannyS712, MediaWiki-User-management, SpamBlacklist
Legoktm renamed T312318: Ensure adequate debouncing for musical scores to avoid too many expensive shell outs from Ensure adequate debouncing for shellbox queries to Ensure adequate debouncing for musical scores to avoid too many expensive shell outs.
Thu, Jul 7, 2:07 AM · MediaWiki-extensions-Score, Community-Tech, Realtime-Preview-Wish-2021

Tue, Jul 5

Legoktm added a comment to T312059: Wrong version of guzzle shipped with 1.37.3 (breaks update.php).

Ugh, we should probably add a check for this in make-release. I'll work on that later...

Tue, Jul 5, 9:19 PM · MediaWiki-Vendor, MediaWiki-Releasing, MW-1.37-release
Volker_E awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Tue, Jul 5, 12:12 PM · Gerrit-Privilege-Requests, CheckUser
Legoktm triaged T312067: SRE needs a logo as High priority.
Tue, Jul 5, 8:22 AM · Logos, SRE
Legoktm added a project to T312062: Allow Special Pages to have associated Talk Pages: MediaWiki-Special-pages.

The English Wikipedia has set up pages like https://en.wikipedia.org/wiki/Wikipedia_talk:Special:AncientPages. While I think we don't want to introduce a Special_talk namespace, I think it would be interesting for *some* special pages to have a discussion/talk tab that led to a project-space page.

Tue, Jul 5, 7:46 AM · MediaWiki-Special-pages
Legoktm committed rMSPC3b9839ba39b5: Just use plain `pytest` to run tests (authored by Legoktm).
Just use plain `pytest` to run tests
Tue, Jul 5, 6:18 AM

Mon, Jul 4

Legoktm closed T311800: LibUp is down because release-monitoring.org is returning HTTP 500 as Resolved.

This has been fixed upstream.

Mon, Jul 4, 8:57 PM · LibUp, Upstream
Legoktm added a project to T295793: Support services VIPs with not marked as VIP in Netbox: Wikimedia-Mailing-lists.

Any IP (mis)configuration most likely predates Amir's and my involvement with mailman, we never touched that stuff. I can't think of any reason why it was set like that, so fixing it sounds good to me, we should just announce the maintenance window ahead of time since it needs a reboot.

Mon, Jul 4, 8:50 PM · Wikimedia-Mailing-lists, serviceops, Infrastructure-Foundations, SRE-tools

Sun, Jul 3

Legoktm added a comment to T297571: CVE-2022-28201: Title::newMainPage() goes into an infinite recursion loop if it points to a local interwiki.

I published a more detailed write-up about this bug on my blog: https://blog.legoktm.com/2022/07/03/a-belated-writeup-of-cve-2022-28201-in-mediawiki.html

Sun, Jul 3, 7:21 AM · Patch-For-Review, SecTeam-Processed, MediaWiki-General, Vuln-DoS, Security, Security-Team
Legoktm edited projects for T311934: Add "bot" parameter for action=block etc via API request, added: MediaWiki-Action-API; removed MediaWiki-General.

Pretty sure this is a duplicate...the main issue is that logs cannot conditionally be flagged as bot, they're always flagged as bot for bots.

Sun, Jul 3, 3:24 AM · MediaWiki-Action-API
Legoktm closed T311202: Not possible to search ALL results in a namespace on Special:LintErrrors as Resolved.

Will be fixed with the next train deployment. If you'd like this to be backported and fixed faster, please say so :)

Sun, Jul 3, 12:25 AM · Regression, MediaWiki-extensions-Linter

Sat, Jul 2

Legoktm claimed T311202: Not possible to search ALL results in a namespace on Special:LintErrrors.
Sat, Jul 2, 10:01 PM · Regression, MediaWiki-extensions-Linter

Fri, Jul 1

Legoktm created T311800: LibUp is down because release-monitoring.org is returning HTTP 500.
Fri, Jul 1, 4:02 AM · LibUp, Upstream
Legoktm added a comment to T311321: In many extensions, composer.json doesn't validate to spec.

I'm going to re-open this ticket because I do think it is both valid, and separate from T250406

Regarding T250406, I would summarize it as "Create an official public MediaWiki extension registry" (like Hallo Welt does) so Extension authors don't have to bother publishing, and site builders can use Composer.

Fri, Jul 1, 3:58 AM · MediaWiki-extensions-UserMerge, MediaWiki-extensions-TitleKey, Thanks, TextExtracts, TemplateStyles, MediaWiki-extensions-Sudo, Growth-Team, MediaWiki-extensions-ReplaceText, PageImages, MediaWiki-extensions-MyVariables, MediaWiki-extensions-Loops, MediaWiki-extensions-Lockdown, MediaWiki-extensions-LabeledSectionTransclusion, MediaWiki-extensions-DisplayTitle, DismissableSiteNotice, MediaWiki-extensions-DeleteBatch, MediaWiki-extensions-CodeMirror

Thu, Jun 30

Soda awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Thu, Jun 30, 3:45 PM · Gerrit-Privilege-Requests, CheckUser

Wed, Jun 29

Legoktm added a comment to T241280: Configurable listening address for poolcounter service.

Overwriting ExecStart isn't the most trivial thing to do. Why does the debian package have an insecure default?

Wed, Jun 29, 7:24 AM · PoolCounter

Tue, Jun 28

Legoktm closed T241280: Configurable listening address for poolcounter service as Invalid.

Maybe you're using an old version? In 1.1.0 I did rMSPC112a76152ef6: Only listen on localhost by default so it listens on localhost by default. I believe the Debian package systemd unit ships with -l 0.0.0.0, but you can override that however you override systemd units.

Tue, Jun 28, 11:36 PM · PoolCounter
Legoktm added a comment to T311321: In many extensions, composer.json doesn't validate to spec.

But this ticket is not about that. That's the goal of https://phabricator.wikimedia.org/T250406

Tue, Jun 28, 10:24 PM · MediaWiki-extensions-UserMerge, MediaWiki-extensions-TitleKey, Thanks, TextExtracts, TemplateStyles, MediaWiki-extensions-Sudo, Growth-Team, MediaWiki-extensions-ReplaceText, PageImages, MediaWiki-extensions-MyVariables, MediaWiki-extensions-Loops, MediaWiki-extensions-Lockdown, MediaWiki-extensions-LabeledSectionTransclusion, MediaWiki-extensions-DisplayTitle, DismissableSiteNotice, MediaWiki-extensions-DeleteBatch, MediaWiki-extensions-CodeMirror

Mon, Jun 27

L235 awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Mon, Jun 27, 12:28 AM · Gerrit-Privilege-Requests, CheckUser

Sun, Jun 26

Lomrjyo awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Sun, Jun 26, 2:25 PM · Gerrit-Privilege-Requests, CheckUser
Jayprakash12345 awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Sun, Jun 26, 3:39 AM · Gerrit-Privilege-Requests, CheckUser
Legoktm added a comment to T289899: Security Review For Mailman3 / lists.wikimedia.org.

The security assessment is complete and the report review will happen on Wednesday, June 22.

Sun, Jun 26, 2:42 AM · SecTeam-Processed, secscrum, Security, Application Security Reviews
Legoktm closed T311321: In many extensions, composer.json doesn't validate to spec as Declined.

Please use composer validate --no-check-publish.

Sun, Jun 26, 1:07 AM · MediaWiki-extensions-UserMerge, MediaWiki-extensions-TitleKey, Thanks, TextExtracts, TemplateStyles, MediaWiki-extensions-Sudo, Growth-Team, MediaWiki-extensions-ReplaceText, PageImages, MediaWiki-extensions-MyVariables, MediaWiki-extensions-Loops, MediaWiki-extensions-Lockdown, MediaWiki-extensions-LabeledSectionTransclusion, MediaWiki-extensions-DisplayTitle, DismissableSiteNotice, MediaWiki-extensions-DeleteBatch, MediaWiki-extensions-CodeMirror
Legoktm added a comment to T311314: Shell access request for @demon.

Yesssss. Welcome back!!

Sun, Jun 26, 12:59 AM · SRE, SRE-Access-Requests
Legoktm awarded T311314: Shell access request for @demon a Love token.
Sun, Jun 26, 12:58 AM · SRE, SRE-Access-Requests
Legoktm added a comment to T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser.

(@Legoktm: can you send an email to wikitech-l about this, please? While not strictly required by policy since this is not about access to all of mediawiki/*, I think we should ensure that everyone interested has seen this and has had the ability to comment since we're still talking about a WMF deployed extension.)

Sun, Jun 26, 12:57 AM · Gerrit-Privilege-Requests, CheckUser

Sat, Jun 25

TheresNoTime awarded T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser a Like token.
Sat, Jun 25, 1:22 PM · Gerrit-Privilege-Requests, CheckUser
Legoktm added a comment to T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser.

But, that work has been primarily the creation of patches, not reviewing the patches of others. <snip> At this point, I just don't think they have enough experience reviewing other people patches, since that is a slightly different skill than creating your own.

Sat, Jun 25, 5:46 AM · Gerrit-Privilege-Requests, CheckUser
Legoktm updated the task description for T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser.
Sat, Jun 25, 4:11 AM · Gerrit-Privilege-Requests, CheckUser
Legoktm created T311331: +2 for Dreamy_Jazz in mediawiki/extensions/CheckUser.
Sat, Jun 25, 4:09 AM · Gerrit-Privilege-Requests, CheckUser

Sat, Jun 18

Legoktm raised the priority of T226797: Login state not propagated across domains in Safari and in Firefox with strict mode from Medium to High.

I believe the priority of this has increased now that Firefox has rolled out total cookie protection by default for all users: https://blog.mozilla.org/en/products/firefox/firefox-rolls-out-total-cookie-protection-by-default-to-all-users-worldwide/ - supporting Firefox as the last major free software browser should be a priority for us so we're not sending our cross-wiki users into proprietary solutions that offer less protection against malicious tracking...

Sat, Jun 18, 6:22 AM · Platform Engineering Roadmap Decision Making, User-notice, Browser-Support-Firefox, Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth
Legoktm awarded T309375: Requesting access to contint-admins for taavi a Like token.
Sat, Jun 18, 1:10 AM · SRE, SRE-Access-Requests
Legoktm added a comment to T302231: Requesting access to deployment for TheresNoTime.

Just adding my very late support to this, @TheresNoTime has been doing great MW work lately :)

Sat, Jun 18, 12:55 AM · SRE-Access-Requests, SRE
Legoktm added a comment to T67270: Default license for operations/puppet.

Can we clarify what the goal here is? More recently I've been good about throwing a GPL-3.0-or-later header on substantial scripts committed to puppet (e.g. https://codesearch.wmcloud.org/puppet/?q=%5C(C%5C)%20.*%20Kunal%20Mehta&i=nope&files=&excludeFiles=&repos=), do we actually want/need to relicense those to Apache 2.0? My understanding was that we wanted everything to just have a license, defaulting to Apache-2.0 if one wasn't already specified.

Sat, Jun 18, 12:43 AM · Patch-For-Review, SRE, Software-Licensing, Documentation, WMF-Legal, WMF-General-or-Unknown

Fri, Jun 17

Legoktm added a comment to T310887: Add support for specifying the PHP version used?.

MediaWiki's official Docker image uses a PHP version with known vulnerabilities (7.4.28).

Fri, Jun 17, 7:53 PM · Docker-Hub-MediaWiki, SecTeam-Processed, Security

Tue, Jun 14

Legoktm closed T310487: Special:Log/oath: Allow filtering by type of action as Resolved.

Just missed this week's train, will be deployed next week.

Tue, Jun 14, 9:44 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MediaWiki-extensions-OathAuth

Mon, Jun 13

Legoktm added a comment to T310557: Shellbox resource management.

Also, one of the Wikisources has some Lua magic that renders each score like 4 times because they're PNGs. I think if we switched to/enabled SVG rendering (T49578) we could cut that down to just one, which hopefully reduces traffic significantly.

Mon, Jun 13, 11:21 PM · SRE-OnFire, Sustainability (Incident Followup), Shellbox, serviceops, SRE
Legoktm added a comment to T310557: Shellbox resource management.

Did we determine whether the most recent spike was legitimate user traffic or malicious/DoS?

Mon, Jun 13, 11:19 PM · SRE-OnFire, Sustainability (Incident Followup), Shellbox, serviceops, SRE
Legoktm added a comment to T298784: Security Issue Access Request for Zabe.

If this is open for reconsideration, +1 from me on Zabe getting security access.

Mon, Jun 13, 11:18 PM · user-sbassett, Security-Team, SecTeam-Processed, Security
Legoktm added a comment to T310487: Special:Log/oath: Allow filtering by type of action.

Screenshot 2022-06-13 at 14-17-55 Two-factor authentication log - Trunk Test.png (730×1 px, 79 KB)

Mon, Jun 13, 6:19 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MediaWiki-extensions-OathAuth
Legoktm claimed T310487: Special:Log/oath: Allow filtering by type of action.

Of course!

Mon, Jun 13, 6:09 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MediaWiki-extensions-OathAuth
Legoktm claimed T310456: Re-enable daily updates of formerly slow enwiki QueryPages.

Thanks! I'll work on implementing this this week then

Mon, Jun 13, 5:53 AM · Data-Persistence (Consultation), Patch-For-Review, Wikimedia-Site-requests
Legoktm created T310460: updateSpecialPages.php should reload database config in between each query page.
Mon, Jun 13, 5:51 AM · Data-Persistence (Consultation), MediaWiki-Maintenance-system
Legoktm added a comment to T307314: Lag in updating Special Pages?.

My quick skim of that ticket is that reloading config hasn't been implemented in MW yet, unless it was in a patch not linked on that ticket.

Mon, Jun 13, 5:45 AM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown
Legoktm added a comment to T307314: Lag in updating Special Pages?.

@Legoktm this queries would go to the replicas on the slow section for MW right?

Mon, Jun 13, 5:20 AM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown
Legoktm added a parent task for T310456: Re-enable daily updates of formerly slow enwiki QueryPages: T41661: Query pages improvements (tracking).
Mon, Jun 13, 4:51 AM · Data-Persistence (Consultation), Patch-For-Review, Wikimedia-Site-requests
Legoktm added a subtask for T41661: Query pages improvements (tracking): T310456: Re-enable daily updates of formerly slow enwiki QueryPages.
Mon, Jun 13, 4:51 AM · Tracking-Neverending, MediaWiki-Special-pages
Legoktm created T310456: Re-enable daily updates of formerly slow enwiki QueryPages.
Mon, Jun 13, 4:43 AM · Data-Persistence (Consultation), Patch-For-Review, Wikimedia-Site-requests
Legoktm added a comment to T70312: OAuth: Grant "High-volume editing" is confusing (does not provide "edit" right).

Maybe we can put bot in parentheticals, since many wiki users would be looking for that specifically? e.g. "High-volume (bot) access".

Mon, Jun 13, 4:06 AM · Patch-For-Review, User-EpicPupper, Voice & Tone, MediaWiki-extensions-OAuth
Legoktm added a parent task for T307314: Lag in updating Special Pages?: T41661: Query pages improvements (tracking).
Mon, Jun 13, 3:28 AM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown
Legoktm added a subtask for T41661: Query pages improvements (tracking): T307314: Lag in updating Special Pages?.
Mon, Jun 13, 3:28 AM · Tracking-Neverending, MediaWiki-Special-pages
Legoktm created P29631 build-scap.bash.
Mon, Jun 13, 3:05 AM
Legoktm created P29630 disable_list3.py.
Mon, Jun 13, 3:05 AM
Legoktm added a project to T307314: Lag in updating Special Pages?: DBA.

With very aggressive rounding up to nearest minute, the enwiki run takes 42 minutes. commonswiki is 8.8 hours, wikidatawiki is ~50 minutes. I'm tagging DBA for a heads-up and review, since this is mostly going to have an impact on databases.

Mon, Jun 13, 1:01 AM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown

Sun, Jun 12

Legoktm closed T310411: Allow exceptions to the Echo limit as Declined.

50 is both an anti-abuse measure and to prevent accidents when people accidentally transclude pages that would trigger a large number of pings. To notify a large group of users, we have better tools like sitenotices, watchlist notices, MassMessage, etc.

Sun, Jun 12, 10:19 PM · Growth-Team, Notifications
Legoktm added a project to T310411: Allow exceptions to the Echo limit: Notifications.
Sun, Jun 12, 3:34 AM · Growth-Team, Notifications

Sat, Jun 11

Legoktm claimed T307314: Lag in updating Special Pages?.
Sat, Jun 11, 8:24 PM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown
Legoktm reopened T307314: Lag in updating Special Pages? as "Open".

Out of those, the Commons ones are MostGloballyLinkedFiles and GloballyWantedFiles, but those are specially written to only execute on Commons, so they get skipped on all other wikis. Then there's UnconnectedPages for Wikidata, except it is uncached so it doesn't get executed either. So I think we can safely parallelize this by shard.

Sat, Jun 11, 8:08 PM · DBA, Patch-For-Review, serviceops, WMF-General-or-Unknown
Legoktm created P29623 (An Untitled Masterwork).
Sat, Jun 11, 8:02 PM
Legoktm added a comment to T310325: s1 (enwiki) wiki replicas replication has stopped.

The only thing I have to add is that we probably need to make some effort again to turn the more important database reports into proper MediaWiki special pages so they are treated as production quality, since it seems that editors are relying on them that much. I'll start a subthread on VPT about this.

Sat, Jun 11, 7:36 PM · cloud-services-team (Kanban), DBA, Data-Services
Legoktm created P29622 steve adder "-".
Sat, Jun 11, 5:18 AM
Legoktm added a comment to T310325: s1 (enwiki) wiki replicas replication has stopped.

Ladsgroup says "soon" and Legoktm's message says "should recover by Monday". Some clarity would be helpful for those of us who process daily (or more frequent) reports that are not updating. Thanks for anything you can provide.

Sat, Jun 11, 5:04 AM · cloud-services-team (Kanban), DBA, Data-Services
Legoktm added a comment to T310325: s1 (enwiki) wiki replicas replication has stopped.

hmm, there is no need to worry. This is because of a schema change on revision table (T298560) getting propagated to the cloud. It takes twice as the time of the alter (plus some time to recover) and usually the schema changes are fast enough that users don't notice (like five minutes) but revision table of enwiki is ... special. It took 16-ish hours to finish and it's catching up. It'll reach there the current time soon (check orchestrator.wikimedia.org)

Sat, Jun 11, 1:16 AM · cloud-services-team (Kanban), DBA, Data-Services

Fri, Jun 10

Legoktm created T310325: s1 (enwiki) wiki replicas replication has stopped.
Fri, Jun 10, 1:41 AM · cloud-services-team (Kanban), DBA, Data-Services
Legoktm added a comment to T306292: Libraryupgrader reports unchanged dependency versions.
Fri, Jun 10, 12:15 AM · LibUp
Legoktm added a comment to T306292: Libraryupgrader reports unchanged dependency versions.

Sorry about the delay, deploying it now.

Fri, Jun 10, 12:13 AM · LibUp
Legoktm closed T39613: CheckUser records XFF: 0 on PostgreSQL, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Resolved.
Fri, Jun 10, 12:11 AM · Performance-Team, PostgreSQL, Tracking-Neverending, Wikimedia-Rdbms
Legoktm closed T39613: CheckUser records XFF: 0 on PostgreSQL as Resolved.
Fri, Jun 10, 12:11 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), PostgreSQL, CheckUser
Legoktm added a project to T130439: Add an AbuseFilter variable for global edit count of the user: User-notice.

This should get a mention in tech news, like the other new variables/functions have been getting.

Fri, Jun 10, 12:00 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), User-notice, MediaWiki-extensions-CentralAuth, AbuseFilter

Thu, Jun 9

Legoktm closed T310013: PHP exif module is unexpectedly required as Resolved.

This fix will be included in the next MediaWiki 1.38 release, thanks for reporting!

Thu, Jun 9, 11:50 PM · MW-1.38-notes, Patch-For-Review, MW-1.38-release, MediaWiki-General
Legoktm added a comment to T309437: Create deployment-deploy04 as future secondary/upgrade.

What is the goal in building this as bullseye? Shouldn't it aim to match production, which is still buster?

Thu, Jun 9, 11:31 PM · Beta-Cluster-Infrastructure
Legoktm closed T309449: Package 'cgroup-bin' has no installation candidate on Debian 11 (modules/mediawiki/manifests/cgroup.pp) as Resolved.
Thu, Jun 9, 11:31 PM · Infrastructure-Foundations, Puppet
Legoktm awarded T310314: Offboard David Sharpe from Security Team a Heartbreak token.
Thu, Jun 9, 10:48 PM · SecTeam-Processed, user-sbassett, Security-Team
Legoktm added a project to T310298: Shellbox\ShellboxError: Shellbox server returned status code 504: Shellbox.

This is probably the cause and effect of the Shellbox outage yesterday, which @RLazarus was looking into.

Thu, Jun 9, 4:11 PM · Shellbox, Parsoid, Wikimedia-production-error

Wed, Jun 8

Legoktm updated the title for P29487 linttrap.py from fix_font.py to linttrap.py.
Wed, Jun 8, 2:52 AM

Tue, Jun 7

Legoktm edited P29487 linttrap.py.
Tue, Jun 7, 6:59 PM
Legoktm created P29487 linttrap.py.
Tue, Jun 7, 6:59 PM

Jun 7 2022

Legoktm closed T309959: Rewriting HTTP as HTTPS or bad opportunistic TLS in links as Declined.

In an attempt to use TLS with external sites where possible, MW rewrites HTTP to HTTPS for all links to names rooted in those on a certain list maintained by Chromium.org.

Jun 7 2022, 4:50 AM · MediaWiki-General, MediaWiki-extensions-SecureLinkFixer
Legoktm closed T154067: Consider having <big> in wikitext output a styled <span> in HTML as Declined.

If <big> is ever removed by browsers, it would still be in the DOM so all we'd need to do is add some CSS styling to restore it (or choose not to!), so as written this task is declined. But it seems very likely that will never happen, or we'll have significant time to discuss what to do.

Jun 7 2022, 4:36 AM · Parsing-Team--ARCHIVED, MediaWiki-Parser
Legoktm closed T154067: Consider having <big> in wikitext output a styled <span> in HTML, a subtask of T26529: Incrementally remove support for HTML elements removed from or deprecated in HTML5, as Declined.
Jun 7 2022, 4:36 AM · HTML5, MediaWiki-Parser

Jun 6 2022

Legoktm added a comment to T309655: Disable php-composer-security-docker emails to security-admin-feed@lists.

Getting rid of these seems like the wrong solution - if the security team doesn't want to receive these anymore, the alerts should go to the maintainers of projects (please sign me up for shellbox). It's possible we also need a little more configuration than our very naive job to allow disabling alerts we don't care about.

Jun 6 2022, 8:21 PM · Patch-For-Review, user-sbassett, Security-Team, Security
Legoktm added a comment to T106282: action=query list=checkuserlog API response is inconsistent with other action=query responses.

I could ask right now on the list. If you'd like me to get affirmations from everyone that uses it then I would probably need a list. I would keep it private as requested.

Jun 6 2022, 8:18 PM · Patch-For-Review, Stewards-and-global-tools, MediaWiki-Action-API, CheckUser
Legoktm closed T309974: https://codesearch.wmcloud.org/ does not load as Resolved.

The VM OOM'd, which is probably why it was unresponsive for a while, then eventually the oom-killer kicked in and it all recovered by itself. I'm going to close this as resolved, seems like a kind of freak accident.

Jun 6 2022, 4:47 PM · VPS-project-Codesearch
Legoktm added a comment to T106282: action=query list=checkuserlog API response is inconsistent with other action=query responses.

For my reference, the list can be obtained with legoktm@mwlog1002:~$ grep list=checkuserlog culog.txt | awk '{ print $11 }' | sort | uniq

Jun 6 2022, 2:21 AM · Patch-For-Review, Stewards-and-global-tools, MediaWiki-Action-API, CheckUser
Legoktm added a comment to T45956: Rename $wmf* to $wmg* in wmf-config.

Is there also a task for the various global functions wmf*() -> wmg*() ?

Jun 6 2022, 2:18 AM · Technical-Debt, Wikimedia-Site-requests

Jun 5 2022

Legoktm added a comment to T268152: Special:InvestigateBlock error is confusing.

Instead of trying an async JS call, you could have the special page output a mw.config variable like wgCheckUserHasBlockRight or something.

Jun 5 2022, 11:17 PM · Anti-Harassment (AHaT Sprint 9: The Beret), MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), User-DannyS712, CheckUser
Legoktm closed T271027: Update SecureLinkFixer to use the new HookContainer/HookRunner system, a subtask of T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system, as Resolved.
Jun 5 2022, 11:17 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Legoktm closed T271027: Update SecureLinkFixer to use the new HookContainer/HookRunner system, a subtask of T263364: Update all tarballed extensions to use the new HookContainer/HookRunner system, as Resolved.
Jun 5 2022, 11:17 PM · Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Legoktm closed T271027: Update SecureLinkFixer to use the new HookContainer/HookRunner system as Resolved.
Jun 5 2022, 11:17 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), MediaWiki-extensions-SecureLinkFixer, Platform Team Initiatives (New Hook System)
Legoktm added a comment to T106282: action=query list=checkuserlog API response is inconsistent with other action=query responses.

+1 to the change on technical merits, but as noted, this is a breaking change for anyone using this API, which is a non-zero amount of people. @Dreamy_Jazz: if I (privately) gave you a list of all the users who've used the API in the past week, could you reach out via the checkuser mailing list to get their support/consent/etc. for making this breaking change? It's unclear to me if it's just one script that everyone uses which will need updating, or if there are a bunch of scripts that would need updating.

Jun 5 2022, 10:53 PM · Patch-For-Review, Stewards-and-global-tools, MediaWiki-Action-API, CheckUser
Legoktm committed rESLF0509d3422528: Switch to new hook handler format (authored by Legoktm).
Switch to new hook handler format
Jun 5 2022, 4:57 PM
Legoktm added a comment to T271712: Require tools to host a valid toolinfo.json file (e.g. while upgrading from one Debian version to another).

I think we're better off recommending people fill out the toolinfo via striker or toolhub these days, rather than getting each maintainer to add a toolinfo.json to their tool.

Jun 5 2022, 4:23 PM · Toolhub, Toolforge
Legoktm closed T271023: Update PdfHandler to use the new HookContainer/HookRunner system, a subtask of T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system, as Invalid.
Jun 5 2022, 4:16 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Legoktm closed T271023: Update PdfHandler to use the new HookContainer/HookRunner system, a subtask of T263364: Update all tarballed extensions to use the new HookContainer/HookRunner system, as Invalid.
Jun 5 2022, 4:16 PM · Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Legoktm closed T271023: Update PdfHandler to use the new HookContainer/HookRunner system as Invalid.

PdfHandler doesn't have any hooks :)

Jun 5 2022, 4:16 PM · MediaWiki-extensions-PdfHandler, Platform Team Initiatives (New Hook System)
Legoktm claimed T271027: Update SecureLinkFixer to use the new HookContainer/HookRunner system.
Jun 5 2022, 4:06 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), MediaWiki-extensions-SecureLinkFixer, Platform Team Initiatives (New Hook System)
Legoktm closed T309759: Provide arbitrary browser version summation in the browser dashboard as Resolved.

Now documented at https://wikitech.wikimedia.org/wiki/Tool:Steve-adder - additional feature/bug requests can be made on the talk page.

Jun 5 2022, 3:12 PM · Technical-Tool-Request
Legoktm added a comment to T309920: Support automatic translation of MediaWiki talk page comments.

From yesterday in #wikimedia-tech:

16:52:13 <legoktm> related to the discussion about automatic translations in Discourse vs MediaWiki and privacy implications of using Google Translate (or other external providers) - https://blog.mozilla.org/en/mozilla/local-translation-add-on-project-bergamot/ came out today, fully local translations
16:52:39 <AntiComposite> that's cool
16:57:16 <legoktm> it's mostly webassembly, would be interesting if it could be wired into a gadget that lets you translate individual talk page comments or sections
Jun 5 2022, 3:42 AM · MediaWiki-extension-requests, MediaWiki-Internationalization, DiscussionTools

Jun 4 2022

Legoktm claimed T309759: Provide arbitrary browser version summation in the browser dashboard.

Awaiting Izno's feedback if it's satisfactory or not.

Jun 4 2022, 4:17 AM · Technical-Tool-Request