Legoktm (Legoktm)Administrator
User

Projects (99)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (187 w, 17 h)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Thu, Apr 19

Legoktm added a comment to T191746: Bundle LoginNotify extension with MW 1.31.

This one is still waiting on Echo

Thu, Apr 19, 3:04 AM · MediaWiki-extensions-LoginNotify, MW-1.31-release, MediaWiki-Releasing

Wed, Apr 18

Legoktm closed T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM as Resolved.

Should be all good now!

Wed, Apr 18, 5:39 PM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm closed T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM, a subtask of T94149: Get rid of Zend 5.5 tests for wmf branches, as Resolved.
Wed, Apr 18, 5:39 PM · Release-Engineering-Team (Someday), Continuous-Integration-Config, Continuous-Integration-Infrastructure (Little Steps Sprint)
Legoktm closed T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM, a subtask of T172165: Require either PHP 7.0+ or HHVM in MW 1.31, as Resolved.
Wed, Apr 18, 5:39 PM · MW-1.31-release-notes, MW-1.31-release, Patch-For-Review, TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
Legoktm added a comment to T192386: Enable RemexHTML on metawiki.

Hi. Sorry but I object to turn this on until all errors have been fixed. There are +/- 500 k high priority errors. There's no point imho to break such a high number of usages and put the burden later on the editors to fix them. There's no active maintenance on this area either for now. Please wait until we've found a solution to deal with this as I bet it'd be far easier to fix this now than when things break because of this. Thanks.

Wed, Apr 18, 5:31 PM · Patch-For-Review, Parsing-Team, RemexHtml, Tidy
Legoktm added a comment to T190891: Develop canonical/single record of origin, machine readable list of all repos deployed to WMF sites. .

https://phabricator.wikimedia.org/source/tool-ci/browse/master/build_table.py;3ed885277a38ddb5c7c8a6c3c9b666fb7b13ae10$49 is how my tools currently get a list of Wikimedia deployed extensions.

Wed, Apr 18, 4:00 PM · Analytics-Tech-community-metrics, Code-Health, Release-Engineering-Team (Kanban)
Legoktm added projects to T192446: Skins render differently with templates returning an initial asterisk : Timeless, CologneBlue, Modern.
Wed, Apr 18, 3:47 PM · Modern, CologneBlue, Timeless, MediaWiki-Parser
Legoktm added a subtask for T191736: Bundle AntiSpoof extension with MW 1.31: Unknown Object (Task).
Wed, Apr 18, 7:56 AM · AntiSpoof, MW-1.31-release, MediaWiki-Releasing
Legoktm updated subscribers of T191737: Bundle Scribunto extension with MW 1.31.

License review: I talked with @lfaraone (Debian FTP master) and he's concerned about the lua 5.1 binaries that are included with Scribunto. Are the Windows/macOS binaries fully free software (are they linked with any proprietary Windows/macOS library)? I think I read somewhere that @Anomie used centos with an old glibc to build the Linux binaries so that should all be free software.

Wed, Apr 18, 7:52 AM · MediaWiki-extensions-Scribunto, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm added a comment to T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM.

So I think the last thing to do is blacklist php55 jobs from running against master and REL1_31 branches?

Wed, Apr 18, 7:45 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm closed T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM as Resolved.
Wed, Apr 18, 7:44 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm closed T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM, a subtask of T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM, as Resolved.
Wed, Apr 18, 7:44 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm added a comment to T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM.

OK, after https://gerrit.wikimedia.org/r/427316 Apache now runs with PHP 7! Now just need to rebase and merge James's patch.

Wed, Apr 18, 6:25 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm added a comment to T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM.
2018-04-18 04:29:39,669 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: ERROR: Module php5 is enabled - cannot proceed due to conflicts. It needs to be disabled first!
2018-04-18 04:29:39,669 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: Considering dependency mpm_prefork for php7.0:
2018-04-18 04:29:39,669 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: Considering conflict mpm_event for mpm_prefork:
2018-04-18 04:29:39,670 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: Considering conflict mpm_worker for mpm_prefork:
2018-04-18 04:29:39,670 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: Module mpm_prefork already enabled
2018-04-18 04:29:39,670 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Notice: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: Considering conflict php5 for php7.0:
2018-04-18 04:29:39,671 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Error: /usr/sbin/a2enmod php7.0 returned 1 instead of one of [0]
2018-04-18 04:29:39,671 INFO nodepool.image.build.wmflabs-eqiad.snapshot-ci-jessie: Error: /Stage[main]/Apache::Mod::Php7/Apache::Mod_conf[php7.0]/Exec[ensure_present_mod_php7.0]/returns: change from notrun to 0 failed: /usr/sbin/a2enmod php7.0 returned 1 instead of one of [0]
Wed, Apr 18, 4:33 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm added a comment to T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM.

My patch doesn't seem to have worked:

jenkins@ci-jessie-wikimedia-1034457:~$ dpkg -l | grep apache2-mod-php
ii  libapache2-mod-php5                    5.6.33+dfsg-0+deb8u1                                amd64        server-side, HTML-embedded scripting language (Apache 2 module)
Wed, Apr 18, 4:20 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm added a comment to T191746: Bundle LoginNotify extension with MW 1.31.

Is MIT license not acceptable?

Wed, Apr 18, 1:37 AM · MediaWiki-extensions-LoginNotify, MW-1.31-release, MediaWiki-Releasing

Tue, Apr 17

Legoktm added a parent task for T109873: Scribunto uses deprecated SyntaxHighlight_GeSHi methods: T191737: Bundle Scribunto extension with MW 1.31.
Tue, Apr 17, 8:43 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release, Patch-For-Review, SyntaxHighlight, MediaWiki-Vagrant, Technical-Debt, MediaWiki-extensions-Scribunto
Legoktm added a subtask for T191737: Bundle Scribunto extension with MW 1.31: T109873: Scribunto uses deprecated SyntaxHighlight_GeSHi methods.
Tue, Apr 17, 8:43 PM · MediaWiki-extensions-Scribunto, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm removed projects from T192384: PHPCS should not complain about @covers and @dataProvider being used in traits: MediaWiki-Core-Tests, Continuous-Integration-Config.
Tue, Apr 17, 7:35 PM · MediaWiki-Codesniffer
Legoktm closed T55985: Group by topic the checkboxes for enabling of bundled extensions as Resolved.
Tue, Apr 17, 3:21 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, MediaWiki-Installer
Legoktm closed T55985: Group by topic the checkboxes for enabling of bundled extensions, a subtask of T33279: Installer: extensions improvements: descriptions, alternatives, multiselection, configuration (tracking), as Resolved.
Tue, Apr 17, 3:20 PM · Tracking, MediaWiki-Installer
Legoktm closed T31134: installer breaks when extensions depend on each other as Resolved.
Tue, Apr 17, 3:20 PM · MW-1.31-release, Patch-For-Review, MediaWiki-Installer
Legoktm closed T31134: installer breaks when extensions depend on each other, a subtask of T191742: Bundle CodeEditor extension with MW 1.31, as Resolved.
Tue, Apr 17, 3:20 PM · CodeEditor, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm closed T31134: installer breaks when extensions depend on each other, a subtask of T191739: Bundle Thanks extension with MW 1.31, as Resolved.
Tue, Apr 17, 3:20 PM · Collaboration-Team-Triage, Thanks, MW-1.31-release, MediaWiki-Releasing
Legoktm closed T31134: installer breaks when extensions depend on each other, a subtask of T191746: Bundle LoginNotify extension with MW 1.31, as Resolved.
Tue, Apr 17, 3:20 PM · MediaWiki-extensions-LoginNotify, MW-1.31-release, MediaWiki-Releasing
Legoktm renamed T192325: Setup phan for AbuseFilter from Setu phan for AbuseFilter to Setup phan for AbuseFilter.
Tue, Apr 17, 1:37 AM · Patch-For-Review, AbuseFilter
Legoktm closed T191744: Bundle Multimedia Viewer extension with MW 1.31 as Resolved.
Tue, Apr 17, 1:31 AM · MediaWiki-extensions-MultimediaViewer, Multimedia, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm closed T191744: Bundle Multimedia Viewer extension with MW 1.31, a subtask of T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites, as Resolved.
Tue, Apr 17, 1:31 AM · Patch-For-Review, MW-1.31-release, MediaWiki-Releasing, MediaWiki-Installer
Legoktm closed T191742: Bundle CodeEditor extension with MW 1.31 as Resolved.

I'm assuming that T31134: installer breaks when extensions depend on each other will be resolved by the time 1.31 is ready, so this is OK to bundle.

Tue, Apr 17, 1:31 AM · CodeEditor, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm closed T191742: Bundle CodeEditor extension with MW 1.31, a subtask of T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites, as Resolved.
Tue, Apr 17, 1:31 AM · Patch-For-Review, MW-1.31-release, MediaWiki-Releasing, MediaWiki-Installer
Legoktm added a comment to T191991: Allow Parsoid to be run in the browser as a standard JavaScript library.

My last comment wasn't professional of me, so I've removed. My apologies for making it in the first place.

Tue, Apr 17, 1:11 AM · Parsoid
Legoktm closed T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7 as Resolved.

Thanks to @Krinkle for talking through it on IRC and pointing out how easy it was to set a global environment variable for a job. :-)

Tue, Apr 17, 12:35 AM · Patch-For-Review, Test-Coverage, Release-Engineering-Team (Someday), Continuous-Integration-Config
Legoktm closed T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7, a subtask of T190547: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM, as Resolved.
Tue, Apr 17, 12:35 AM · Patch-For-Review, PHP 7.0 support, Continuous-Integration-Config, MediaWiki-General-or-Unknown
Legoktm added a comment to T192322: Find cases where a function argument without a default is used after one with a default.

I don't think phan is setup for AbuseFilter yet.

Tue, Apr 17, 12:29 AM · MediaWiki-Codesniffer

Mon, Apr 16

Legoktm closed T192322: Find cases where a function argument without a default is used after one with a default as Declined.

phan already checks for this, so I don't think it's that valuable to add to CodeSniffer.

Mon, Apr 16, 11:38 PM · MediaWiki-Codesniffer
Legoktm added a comment to T192241: Abuse filters cannot be edited without javascript.

I also think that Javascript is such an integral part to AbuseFilter (and MediaWiki as a whole) that supporting noscript is not the best idea. Some of the other existing functionality in AbuseFilter (such as the form that let's you debug code, the form that let's you re-add "autoconfirmed" status to a user, etc.) already rely on JS. So I am leaning towards declining this request altogether and officially stating that AbuseFilter requires JS.

It makes me wonder if MediaWiki itself officially anounces that it requires JS or not. I couldn't find the answer by a simple search; let me go ahead and ask it on mediawiki-l

Mon, Apr 16, 11:36 PM · Patch-For-Review, CodeEditor, Regression, AbuseFilter
Legoktm updated the task description for T191744: Bundle Multimedia Viewer extension with MW 1.31.
Mon, Apr 16, 10:27 PM · MediaWiki-extensions-MultimediaViewer, Multimedia, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm merged task T192300: Useless, mostly blank stylelint output in Jenkins CI into T190072: stylelint is just outputting dots and number of errors, making it impossible to fix.
Mon, Apr 16, 10:13 PM · Continuous-Integration-Infrastructure, Wikidata Query UI, Wikidata
Legoktm merged T192300: Useless, mostly blank stylelint output in Jenkins CI into T190072: stylelint is just outputting dots and number of errors, making it impossible to fix.
Mon, Apr 16, 10:13 PM · Upstream, AbuseFilter, Continuous-Integration-Config
Legoktm reopened T190072: stylelint is just outputting dots and number of errors, making it impossible to fix as "Open".

Based on above reports, upgrading doesn't seem to help.

Mon, Apr 16, 10:13 PM · Upstream, AbuseFilter, Continuous-Integration-Config
Legoktm closed T188480: Update MediaWiki to use Unicode 8.0.0 (utfnormal, Scribunto, etc.) as Resolved.
Mon, Apr 16, 3:58 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, MediaWiki-extensions-Scribunto, MediaWiki-General-or-Unknown, utfnormal
Legoktm added a comment to T191735: Bundle CategoryTree extension with MW 1.31.

The main thing I'd like to get rid of is CategoryTree::initialize(). The hooks should mostly all be set in extension.json, and the conditionals moved into the hooks instead of conditionally registering the hooks.

Mon, Apr 16, 7:27 AM · MediaWiki-extensions-CategoryTree, MW-1.31-release, MediaWiki-Releasing
Legoktm updated the task description for T191735: Bundle CategoryTree extension with MW 1.31.
Mon, Apr 16, 7:25 AM · MediaWiki-extensions-CategoryTree, MW-1.31-release, MediaWiki-Releasing
Legoktm added a comment to T191931: MailAddress needs to be quoting the name part of the mail headers..

What software requires it to be quoted? I just created "Lego test account number 1" and sent email to and from that account with no issues. The raw headers looked like To: Lego test account number 1 <email> and Reply-To: Lego test account number 1 <email>. Both displayed fine in Thunderbird, and presumably went through Wikimedia's mail setup properly.

Mon, Apr 16, 5:05 AM · MW-1.31-release, MediaWiki-Email, Patch-For-Review
Legoktm added a comment to T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given.

I -2'd the patch because an explicit load order is something we're trying to move away from, and normally it really just hides a different error.

Mon, Apr 16, 4:52 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, MediaWiki-extensions-GlobalPreferences, Collaboration-Team-Triage
Legoktm updated the task description for T191743: Bundle Minerva Neue skin with MW 1.31.
Mon, Apr 16, 12:33 AM · Readers-Web-Backlog (Tracking), MinervaNeue, MW-1.31-release, MediaWiki-Releasing

Sun, Apr 15

Legoktm moved T140: ChemDoodle web components - Licensing issues from Backlog to Unclear/inconsistent license on the Software-Licensing board.
Sun, Apr 15, 10:06 PM · Software-Licensing, MediaWiki-extensions-MolHandler
Legoktm added a project to T174444: Convert to SPDX v3 license identifiers & add GPL*-or-later license variants: Software-Licensing.
Sun, Apr 15, 10:05 PM · Software-Licensing, Striker
Legoktm added a comment to T174444: Convert to SPDX v3 license identifiers & add GPL*-or-later license variants.

Probably it would be best to adopt the SPDX v3 license identifiers of -only and -or-later. Most AGPL projects I've seen use "or later".

Sun, Apr 15, 10:05 PM · Software-Licensing, Striker
Legoktm committed R2328:f0ddb55448e3: Add tox to run flake8 (authored by Legoktm).
Add tox to run flake8
Sun, Apr 15, 9:49 PM
Legoktm committed R2328:c047b3f6bd21: Add source links to footer, and h1 to index (authored by Legoktm).
Add source links to footer, and h1 to index
Sun, Apr 15, 9:49 PM
zhuyifei1999 awarded T192244: Provide a consistent way to identify operation in toolforge (including k8s) a Love token.
Sun, Apr 15, 9:44 PM · Toolforge
Legoktm created T192244: Provide a consistent way to identify operation in toolforge (including k8s).
Sun, Apr 15, 9:32 PM · Toolforge
Legoktm committed R2328:4ca1cd5bc692: Initial commit (authored by Legoktm).
Initial commit
Sun, Apr 15, 9:29 PM
Legoktm added a comment to T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7.

This is still not fixed fully, because the whole install process uses PHP 5, only the last step of running the tests uses PHP 7.

Sun, Apr 15, 7:51 PM · Patch-For-Review, Test-Coverage, Release-Engineering-Team (Someday), Continuous-Integration-Config
Legoktm created T192239: quibble should have a way to populate the git cache.
Sun, Apr 15, 7:16 PM · Quibble
Legoktm created T192224: Elasticsearch credential request for flaky-ci.
Sun, Apr 15, 6:14 AM · Toolforge
Legoktm closed T192222: Lua solution needed in sa.wiki as Invalid.

@NehalDaveND I would suggest asking at either https://meta.wikimedia.org/wiki/Tech or https://en.wikipedia.org/wiki/Wikipedia_talk:Lua for help, they'll be much better suited to help you.

Sun, Apr 15, 5:38 AM · LuaSandbox

Sat, Apr 14

Legoktm added a comment to T192213: Allow the "int" parser function to work in the sidebar for section headers.

Why do you need to use the parser function? From https://www.mediawiki.org/wiki/Manual:Interface/Sidebar#Headings

Sat, Apr 14, 6:52 PM · MediaWiki-Interface, I18n
Legoktm added a project to T192213: Allow the "int" parser function to work in the sidebar for section headers: MediaWiki-Interface.
Sat, Apr 14, 6:51 PM · MediaWiki-Interface, I18n
Legoktm added projects to T192078: Figure out some way to not use addUncoveredFilesFromWhitelist="true" when running only some PHPUnit tests: Continuous-Integration-Config, Test-Coverage.

a simple solution would be to change it to false in the repo and have the bots that do the full coverage report patch it.

Sat, Apr 14, 10:43 AM · Test-Coverage, Continuous-Integration-Config, MediaWiki-Core-Tests
Legoktm closed T192057: Error when getting templatedata of all templates as Resolved.
Sat, Apr 14, 10:42 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Legoktm merged task T192200: TemplateData fails ApiStructureTest::testParameterConsistency into T192057: Error when getting templatedata of all templates.
Sat, Apr 14, 10:41 AM · VisualEditor, TemplateData, Wikimedia-log-errors (Jenkins Failure)
Legoktm merged T192200: TemplateData fails ApiStructureTest::testParameterConsistency into T192057: Error when getting templatedata of all templates.
Sat, Apr 14, 10:41 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Legoktm added a comment to T192057: Error when getting templatedata of all templates.

And at the end (and before any early return), call

$this->setContinuationManager( null );
$continuationManager->setContinuationIntoResult( $this->getResult() );
Sat, Apr 14, 10:22 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Legoktm closed T192201: UploadWizard is failing banana because of blank translations as Resolved.
Sat, Apr 14, 9:03 AM · Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), I18n, UploadWizard, translatewiki.net, Multimedia
Legoktm triaged T192201: UploadWizard is failing banana because of blank translations as High priority.
Sat, Apr 14, 8:17 AM · Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), I18n, UploadWizard, translatewiki.net, Multimedia
Legoktm added a comment to T191744: Bundle Multimedia Viewer extension with MW 1.31.

Cleanup: https://gerrit.wikimedia.org/r/#/q/topic:T191744-cleanup
Phan: https://gerrit.wikimedia.org/r/#/c/426547/

Sat, Apr 14, 8:11 AM · MediaWiki-extensions-MultimediaViewer, Multimedia, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm added a comment to T191744: Bundle Multimedia Viewer extension with MW 1.31.

I tested with the web installer, using both instant commons and a local upload. both worked :)

Sat, Apr 14, 7:59 AM · MediaWiki-extensions-MultimediaViewer, Multimedia, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm updated the task description for T191744: Bundle Multimedia Viewer extension with MW 1.31.
Sat, Apr 14, 7:58 AM · MediaWiki-extensions-MultimediaViewer, Multimedia, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm removed a parent task for T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7: T100294: [EPIC] Encourage developers to increase code coverage.
Sat, Apr 14, 7:32 AM · Patch-For-Review, Test-Coverage, Release-Engineering-Team (Someday), Continuous-Integration-Config
Legoktm removed a subtask for T100294: [EPIC] Encourage developers to increase code coverage: T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7.
Sat, Apr 14, 7:32 AM · Release-Engineering-Team, WMF-deploy-2015-06-30_(1.26wmf12), Epic
Legoktm triaged T192200: TemplateData fails ApiStructureTest::testParameterConsistency as High priority.
Sat, Apr 14, 7:03 AM · VisualEditor, TemplateData, Wikimedia-log-errors (Jenkins Failure)
Legoktm committed rEFLIaf8831a527c9: build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
Sat, Apr 14, 3:42 AM
Legoktm committed rEFLI18ec725428b0: Use PHPUnit 4/6 compat in tests that need it (authored by Legoktm).
Use PHPUnit 4/6 compat in tests that need it
Sat, Apr 14, 3:42 AM
Legoktm committed rEDPTb2169258ba93: build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
Sat, Apr 14, 3:20 AM
Legoktm committed rEDPT799edb2a8624: Fix name of data provider so it's not run as a test (authored by Legoktm).
Fix name of data provider so it's not run as a test
Sat, Apr 14, 3:20 AM
Legoktm added a comment to T191742: Bundle CodeEditor extension with MW 1.31.

https://gerrit.wikimedia.org/r/#/q/topic:T191742-cleanup

Sat, Apr 14, 1:42 AM · CodeEditor, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing
Legoktm updated the task description for T191742: Bundle CodeEditor extension with MW 1.31.
Sat, Apr 14, 1:40 AM · CodeEditor, Patch-For-Review, MW-1.31-release, MediaWiki-Releasing

Fri, Apr 13

Volker_E awarded T185753: MediaWiki should default to using RemexHtml for tidy a Like token.
Fri, Apr 13, 11:45 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MW-1.31-release, MediaWiki-Parser
Legoktm committed rETHR3ede83bef21e: Set extension type to media handler (authored by Legoktm).
Set extension type to media handler
Fri, Apr 13, 10:31 PM
Legoktm committed rLLUP373aa0f2aadf: Bump container cache (authored by Legoktm).
Bump container cache
Fri, Apr 13, 9:44 PM
Legoktm committed rLLUP2f13b656ac52: Include full repository name in logs (authored by Legoktm).
Include full repository name in logs
Fri, Apr 13, 9:44 PM
Legoktm created T192175: ActiveAbstract / AbstractFilter extension tests are incompatible with PHPUnit 6.
Fri, Apr 13, 8:20 PM · ActiveAbstract
Legoktm triaged T192173: MonoBook test failures due to missing OOUI images as High priority.
Fri, Apr 13, 7:45 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), MW-1.31-release, OOUI, MonoBook
Legoktm created T192173: MonoBook test failures due to missing OOUI images.
Fri, Apr 13, 7:26 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), MW-1.31-release, OOUI, MonoBook
Legoktm updated the task description for T192167: Drop support for PHPUnit 4.x.
Fri, Apr 13, 6:34 PM · Patch-For-Review, PHP 7.0 support, MediaWiki-Core-Tests
Legoktm added a comment to T192094: [Bug] Languages shown in language picker on the main page not showing "title".

It's returning exactly what the editors provide - see https://en.wikipedia.org/w/index.php?title=Template:Main_Page_interwikis&action=edit

Fri, Apr 13, 5:16 PM · MobileFrontend, Readers-Web-Backlog
Legoktm added a comment to T192132: quibble doesn't have a license.

GPL v3 is compatible with Apache 2.0, so GPL v3 or later would work?

Fri, Apr 13, 5:02 PM · Patch-For-Review, Quibble, Software-Licensing
Legoktm updated subscribers of T192086: API validation fails if an API param has PARAM_RANGE_ENFORCE set to false.
Fri, Apr 13, 8:07 AM · MediaWiki-API, MediaWiki-Core-Tests
Legoktm added a project to T192086: API validation fails if an API param has PARAM_RANGE_ENFORCE set to false: MediaWiki-API.
Fri, Apr 13, 8:06 AM · MediaWiki-API, MediaWiki-Core-Tests
Legoktm closed T192120: Work around Jenkins's xunit validator being incompatible with PHPUnit 6's extra output in junit.xml as Resolved.

@hashar explained to me the process to fork and build a new plugin. I forked it to Gerrit, uploaded the pull request as patch, rebuild the plugin, and uploaded it to Jenkins. A restart later, and the PHPUnit 6 junit file now passes validation :-)

Fri, Apr 13, 7:38 AM · Jenkins, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
Legoktm closed T192120: Work around Jenkins's xunit validator being incompatible with PHPUnit 6's extra output in junit.xml, a subtask of T177132: Run MediaWiki tests with PHPUnit 6, as Resolved.
Fri, Apr 13, 7:38 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), PHP 7.1 support, MediaWiki-Core-Tests
Legoktm added a comment to T191863: SearchEngineTest fails during PHPUnit coverage job "no such table: unittest_page".

I was able to reproduce using quibble, and here's the bisect result:

395462b7d5e1384f8c8c8df4c1ef7ec6e9fdc573 is the first bad commit
commit 395462b7d5e1384f8c8c8df4c1ef7ec6e9fdc573
Author: Brad Jorsch <bjorsch@wikimedia.org>
Date:   Thu Apr 5 14:16:03 2018 -0400
Fri, Apr 13, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Wikimedia-log-errors (Jenkins Failure), Discovery-Search, MediaWiki-Search, Discovery, MediaWiki-Core-Tests
Legoktm created T192132: quibble doesn't have a license.
Fri, Apr 13, 5:15 AM · Patch-For-Review, Quibble, Software-Licensing
Legoktm added a project to T192120: Work around Jenkins's xunit validator being incompatible with PHPUnit 6's extra output in junit.xml: Jenkins.
Fri, Apr 13, 12:10 AM · Jenkins, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
Legoktm added a comment to T191969: Disallow that folder path contains "/ad/" in mediastorage due to blocking by ad blockers.

What ad blocker are you using?

Fri, Apr 13, 12:08 AM · media-storage
Legoktm updated subscribers of T192120: Work around Jenkins's xunit validator being incompatible with PHPUnit 6's extra output in junit.xml.

I tested out https://github.com/jenkinsci/xunit-plugin/pull/57 and it appears to work:

Fri, Apr 13, 12:07 AM · Jenkins, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests

Thu, Apr 12

Legoktm added a comment to T192120: Work around Jenkins's xunit validator being incompatible with PHPUnit 6's extra output in junit.xml.
>>> schema=etree.XMLSchema(etree.parse(open('xunit-plugin/src/main/resources/org/jenkinsci/plugins/xunit/types/phpunit-2.0.xsd')))
>>> schema.validate(etree.parse(open('phpunit4.xml')))
True
>>> schema.validate(etree.parse(open('phpunit6.xml')))
False
Thu, Apr 12, 11:58 PM · Jenkins, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
Legoktm added a comment to T189762: selenium test for Wikibase is unstable.

It's nearly been a month now - can we make this non-voting until it's fixed? Or move it to post-merge?

Thu, Apr 12, 11:30 PM · Wikimedia-log-errors (Jenkins Failure), MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure, Release-Engineering-Team