Legoktm (Legoktm)
User

Projects (82)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (131 w, 3 d)
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Today

Legoktm added a comment to T161278: Add default gadget styling to Parsoid's output.

If skins is an empty list, then it means all skins. Using formatversion=2 (https://en.wikipedia.org/w/api.php?action=query&list=gadgets&gaprop=id|metadata&formatversion=2) gives real booleans for the default field.

Mon, Mar 27, 9:20 PM · Parsoid
Legoktm added a comment to T160599: Parsoid's linter doesn't know about thumbtime parameter.
mysql:wikiadmin@db1078 [testwiki]> select * from linter where linter_id=418;
+-----------+-------------+------------+--------------+------------+----------------+
| linter_id | linter_page | linter_cat | linter_start | linter_end | linter_params  |
+-----------+-------------+------------+--------------+------------+----------------+
|       418 |       94868 |          3 |            0 |         41 | {"items":[""]} |
+-----------+-------------+------------+--------------+------------+----------------+
1 row in set (0.00 sec)
Mon, Mar 27, 9:15 PM · MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T161558: Parsoid linter request failed with The "revision" parameter must be set.

For comparison, https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2017.03.27/parsoid?id=AVsRRBOlWOR5i8OuPwtp&_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-7d,mode:quick,to:now)) has oldId.

Mon, Mar 27, 8:52 PM · Parsoid, MediaWiki-extensions-Linter
Legoktm added a comment to T161558: Parsoid linter request failed with The "revision" parameter must be set.

These are also coming in from UA: VisualEditor-MediaWiki/1.29.0-wmf.17 o.O

Mon, Mar 27, 8:52 PM · Parsoid, MediaWiki-extensions-Linter
Legoktm created T161558: Parsoid linter request failed with The "revision" parameter must be set.
Mon, Mar 27, 8:46 PM · Parsoid, MediaWiki-extensions-Linter
Legoktm added a comment to T161556: Implement a way to have linter reprocess all pages .

No, the HTML is independent and doesn't change when linter stuff does.

Mon, Mar 27, 8:39 PM · Services (watching), Parsoid, MediaWiki-extensions-Linter
Legoktm created T161556: Implement a way to have linter reprocess all pages .
Mon, Mar 27, 8:26 PM · Services (watching), Parsoid, MediaWiki-extensions-Linter
Legoktm claimed T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors.
Mon, Mar 27, 8:14 PM · MediaWiki-extensions-Linter
Legoktm removed projects from T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors: Patch-For-Review, ChangeProp.
Mon, Mar 27, 8:14 PM · MediaWiki-extensions-Linter
Legoktm added a comment to T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors.

After looking into the parsoid logs, I noticed that wtp2001 wasn't whitelisted, and it turns out that we were dropping events from all of the four canary servers, about 9% of events in total. I'm not closing this yet because I saw a few other errors in the logs that need investigating, but I think this should fix the largest source of issues.

Mon, Mar 27, 8:04 PM · MediaWiki-extensions-Linter

Sat, Mar 25

Legoktm added a comment to T154844: New Wikitext Editor: Previews use the article-view rendering engine. (Consensus this is a blocker issue).

I've corrected the task to inherit from the one it talks about, and re-set the priority. I'm minded to revert the changes made from an accepted task that we would do (make the differences negligible) to one that's invalid (switch over to the legacy system that's being replaced), but I might have missed some nuance. @Alsee, can you clarify?

Sat, Mar 25, 11:49 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Legoktm added a project to T161421: Wikibugs realname should use HTTPS: Easy.

The relevant code that needs to be changed is in the labs/tools/wikibugs2 repository on Gerrit.

Sat, Mar 25, 10:49 PM · Easy, Wikibugs
Legoktm closed T160643: Deploy Timeless to betawiki as "Resolved".

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Version?useskin=timeless

Sat, Mar 25, 10:43 PM · Patch-For-Review, Timeless
Legoktm closed T160643: Deploy Timeless to betawiki, a subtask of T154371: Review and deploy Timeless skin, as "Resolved".
Sat, Mar 25, 10:43 PM · Wikimedia-Extension-setup, Community-consensus-needed, Timeless
Legoktm added a comment to T148609: Review and deploy Linter extension to Wikimedia wikis.

We're mostly blocked on T160573, I'm still investigating that.

Sat, Mar 25, 7:37 PM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup

Thu, Mar 23

Legoktm added a comment to T160692: Use poolcounter to limit number of connections to ores uwsgi.

Yeah, link to the server code is broken (just fixed it). No description of how to build and invoke the daemon (I'd have to dig through puppet code).

Thu, Mar 23, 6:00 PM · ORES, Revision-Scoring-As-A-Service-Backlog
Legoktm added a comment to T106924: Consider using the Badges application for a few special roles to highlight those users' comments.

Userboxes are used in many Wikimedia projects, and they accomplish a similar function. Today anyone can see in @hashar's post above that he is one of several SWAT Deployers. Imagine badges for "Catalan speakers", "Lua lovers", "Possible mentors"...

Thu, Mar 23, 5:40 PM · Phabricator
Legoktm added a comment to T161208: Create a Phabricator badge for persons involved in CI.

Please remove the badge from me, thanks.

Thu, Mar 23, 5:34 PM · Phabricator
Legoktm added a comment to T160692: Use poolcounter to limit number of connections to ores uwsgi.

I think PoolCounter is reasonably well documented at https://wikitech.wikimedia.org/wiki/PoolCounter - is there something specific you see as missing?

Thu, Mar 23, 5:34 PM · ORES, Revision-Scoring-As-A-Service-Backlog
Legoktm added a comment to T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors.

The specific edit that should have fixed this was revid=2427878. If changeprop did process that event, I'm starting to suspect that it might be a race condition when parsoid contacts MW...:

		if ( !$title || !$title->getArticleID()
			|| $title->getLatestRevID() != $params['revision']
		) {
			$this->dieUsage( 'Invalid, non-existent, or outdated title', 'invalid-title' );
		}
Thu, Mar 23, 4:30 AM · MediaWiki-extensions-Linter
Legoktm added a comment to T148609: Review and deploy Linter extension to Wikimedia wikis.

This has been marked for inclusion in Tech News. A few questions:

a) What's the timeline, both for group0 and small wikis (in .17? .18?) and larger wikis?

Thu, Mar 23, 4:25 AM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added a comment to T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors.

Just found another case...

Thu, Mar 23, 4:12 AM · MediaWiki-extensions-Linter
Legoktm committed R2044:66616d1b266b: Get rid of print statement (authored by Legoktm).
Get rid of print statement
Thu, Mar 23, 3:45 AM
Legoktm committed R2044:f3e49370113b: Add Linter support (authored by Legoktm).
Add Linter support
Thu, Mar 23, 3:38 AM
Legoktm closed T160607: Add link to page history on Special:LintErrors as "Resolved".
Thu, Mar 23, 3:34 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Linter

Wed, Mar 22

Legoktm committed R1995:7f17abe39378: Add link to history on Special:LintErrors (authored by Legoktm).
Add link to history on Special:LintErrors
Wed, Mar 22, 8:29 PM
Legoktm committed R1995:3854d54f161e: Fix qqq for linker-page-edit (authored by Legoktm).
Fix qqq for linker-page-edit
Wed, Mar 22, 8:29 PM
Legoktm committed R1995:fedaf76425e0: Fix qqq for linker-page-edit (authored by Legoktm).
Fix qqq for linker-page-edit
Wed, Mar 22, 8:25 PM
Legoktm committed R1995:3a1aca4ea4b9: Add link to history on Special:LintErrors (authored by Legoktm).
Add link to history on Special:LintErrors
Wed, Mar 22, 8:23 PM
Legoktm created T161151: Linter doesn't handle non-absolutely named templates properly.
Wed, Mar 22, 7:44 PM · MediaWiki-extensions-Linter
Legoktm added a comment to T151362: Linter: Display lint errors for a single page.

Maybe we should have https://www.mediawiki.org/w/index.php?title=Category_talk:Extensions&action=info show the full table instead of aggregated counts.

Wed, Mar 22, 7:12 PM · MediaWiki-extensions-Linter
Legoktm added a comment to T43327: Add page views graph(s) to MediaWiki's info action for Wikimedia wikis.
In T43327#3120423, @Tgr wrote:

There is no performance difference whatsoever, it was probably just a design decision (as in: no one gave it too much thought).

Wed, Mar 22, 1:31 AM · PageViewInfo, German-Community-Wishlist, TCB-Team, Community-Tech-fixes, Community-Tech
RandomDSdevel awarded T148609: Review and deploy Linter extension to Wikimedia wikis a 100 token.
Wed, Mar 22, 1:03 AM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup

Tue, Mar 21

Legoktm added a watcher for MediaWiki-extensions-Linter: Legoktm.
Tue, Mar 21, 5:40 PM
Legoktm edited projects for T160985: Create an easy to deploy kill switch for every self-contained mediawiki functionality, added: MediaWiki-Configuration; removed MediaWiki-General-or-Unknown.

Maybe we should have a SpecialDisabledPage class similar to the ApiDisabled module? so to disable a special page something like: $wgSpecialPages['AllPages'] = 'SpecialDisabledPage'; would be used.

Tue, Mar 21, 5:17 PM · MediaWiki-Configuration, MediaWiki-Special-pages, MediaWiki-API
Legoktm added a comment to T157218: Special:Log should display all logs a user has the rights to see (instead of only public logs).

Yes, that. From the description:

For convenience, all logs related to that page, that the user has the rights to see, should be displayed in the same list.

Tue, Mar 21, 5:12 PM · AbuseFilter, SpamBlacklist, TitleBlacklist, MediaWiki-Special-pages
Legoktm renamed T160243: Use non smoothed style for PageViewInfo graph from "Use non smoothed style " to "Use non smoothed style for PageViewInfo graph".
Tue, Mar 21, 1:40 AM · PageViewInfo

Mon, Mar 20

Legoktm created P5088 selflink.
Mon, Mar 20, 9:37 PM
Legoktm created T160954: Linter: provide graphs of error category counts via statsd.
Mon, Mar 20, 9:29 PM · MediaWiki-extensions-Linter
Legoktm committed R1995:45b4bf6382ad: Expose category totals in API response (authored by Legoktm).
Expose category totals in API response
Mon, Mar 20, 9:14 PM
Legoktm committed R1995:f9ca7bbc3c5a: Expose category totals in API response (authored by Legoktm).
Expose category totals in API response
Mon, Mar 20, 9:11 PM

Fri, Mar 17

Liuxinyu970226 awarded T148609: Review and deploy Linter extension to Wikimedia wikis a Like token.
Fri, Mar 17, 11:02 AM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup

Thu, Mar 16

Liuxinyu970226 awarded T43327: Add page views graph(s) to MediaWiki's info action for Wikimedia wikis a Like token.
Thu, Mar 16, 2:54 PM · PageViewInfo, German-Community-Wishlist, TCB-Team, Community-Tech-fixes, Community-Tech
Legoktm added a comment to T141084: Babel definitions for an user should be made available through the api.

some juicy direct SELECTs on the categorylinks table when that flag is false

Thu, Mar 16, 7:28 AM · MediaWiki-extensions-Babel
Legoktm added a comment to T160580: meta=babel query API gives incorrect proficiency information.

This is because meta-wiki is still relying on the categories to extract data and not the database. I'll hopefully have time to make the necesary config changes next week to fix this.

Thu, Mar 16, 7:23 AM · MediaWiki-extensions-Babel
Legoktm added a comment to T160572: Some edit links on the Special:LintErrors page aren't highlighting the affected text.

I'm leaning to thinking that we should just exclude translatable pages altogether. For the most part they should just be copies of the source page in terms of markup right...?

Thu, Mar 16, 7:20 AM · MediaWiki-extensions-Linter
Legoktm closed T153056: Linter: Support API query for getting the list of categories as "Resolved".
Thu, Mar 16, 7:19 AM · MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review, MediaWiki-extensions-Linter
Legoktm created T160611: Make "linter" table available on Labs.
Thu, Mar 16, 7:19 AM · DBA, Labs, MediaWiki-extensions-Linter
Legoktm created T160610: Investigate how Linter works on translatable pages.
Thu, Mar 16, 7:17 AM · Parsoid, MediaWiki-extensions-Linter
Legoktm renamed T160607: Add link to page history on Special:LintErrors from "History link" to "Add link to page history on Special:LintErrors".
Thu, Mar 16, 7:06 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Linter
Legoktm added a comment to T160607: Add link to page history on Special:LintErrors.

We don't keep track of when errors are introduced, but adding a history link is definitely doable.

Thu, Mar 16, 7:06 AM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, MediaWiki-extensions-Linter
Legoktm added a comment to T160599: Parsoid's linter doesn't know about thumbtime parameter.

Put the hack in Linter or Parsoid?

Thu, Mar 16, 5:08 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T125917: Deploy the PageViewInfo extension to production.

\o/ thank you for pushing this forwards @Tgr!

Thu, Mar 16, 4:57 AM · Developer-notice, User-notice, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Editing-Department, PageViewInfo, Wikimedia-Site-requests
Legoktm added a comment to T160572: Some edit links on the Special:LintErrors page aren't highlighting the affected text.

These are because these are translatable pages...ugh.

Thu, Mar 16, 4:41 AM · MediaWiki-extensions-Linter
Legoktm closed T160579: Document meta=babel query API as "Resolved".

https://www.mediawiki.org/w/index.php?diff=2421573&oldid=2329044&title=Extension%3ABabel&type=revision

Thu, Mar 16, 4:39 AM · Documentation, MediaWiki-extensions-Babel
Legoktm closed T160579: Document meta=babel query API, a subtask of T141084: Babel definitions for an user should be made available through the api, as "Resolved".
Thu, Mar 16, 4:39 AM · MediaWiki-extensions-Babel
Legoktm created T160599: Parsoid's linter doesn't know about thumbtime parameter.
Thu, Mar 16, 1:15 AM · MediaWiki-extensions-Linter, Parsoid

Wed, Mar 15

Luke081515 awarded T148609: Review and deploy Linter extension to Wikimedia wikis a Like token.
Wed, Mar 15, 9:54 PM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added a comment to T160462: Allow namespace IDs defined in extension.json to be overwritten in LocalSettings.php.

Anyways, my plan at that time was to see if the constant was already defined, and then use its value and not redefine it. That allows you to continue using the constant in the code correctly without needing to check if it was override. That's also the pattern many extensions already use:

if ( !defined( 'NS_FOO' ) ) {
	define( 'NS_FOO', 2 );
	define( 'NS_FOO_TALK', 3 );
}
Wed, Mar 15, 7:14 PM · MediaWiki-Configuration, User-Ladsgroup, Technical-Debt, Wikidata-Sprint
Legoktm edited projects for T160462: Allow namespace IDs defined in extension.json to be overwritten in LocalSettings.php, added: MediaWiki-Configuration; removed MediaWiki-General-or-Unknown.

I'm fairly sure this is a duplicate but I can't find the other task right now.

Wed, Mar 15, 6:29 PM · MediaWiki-Configuration, User-Ladsgroup, Technical-Debt, Wikidata-Sprint
Legoktm renamed Wikimedia-maintenance-script-run from "WMF-maintenance-script-run" to "Wikimedia-maintenance-script-run".
Wed, Mar 15, 6:02 PM
Legoktm added a comment to T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor.

I don't think there's any need to use the composer-merge-plugin here...if something is a MW extension, it should be under the mw/extensions/ hierarchy in Gerrit, and brought in through the normal deployment process. If it's a library, it should be published on packagist and added to mediawiki/vendor like all other libraries are.

Wed, Mar 15, 12:25 AM · Release-Engineering-Team, Story, Wikidata
Legoktm added a comment to T160480: Selflinks should still be <a> tags with CSS styling via a class, not <strong> tags.

So these would be clickable?

Wed, Mar 15, 12:21 AM · Patch-For-Review, Technical-Debt, MediaWiki-Parser, MediaWiki-General-or-Unknown, Editing-Department, VisualEditor

Tue, Mar 14

Legoktm removed a project from T160464: Investigate global usergroup Cabal: Datasets-General-or-Unknown.

What do you want to investigate? It was presumably created as a joke to exploit a CentralAuth bug.

Tue, Mar 14, 9:03 PM · MediaWiki-extensions-CentralAuth
Legoktm added a comment to T160358: Create a varilable that would control how far back AbuseLog private data can be retrieved.

I think purgeOldLogIPData.php takes care of this right?

Tue, Mar 14, 10:21 AM · audits-data-retention, Stewards-and-global-tools, Security-Team, AbuseFilter
Legoktm added a comment to T140007: Empty PHP entry points where JSON entry points exist.

Well it's up to each maintainer if they want to accept your patches but my opinion is that the PHP shims are harmless to keep around for now.

Tue, Mar 14, 6:19 AM · Technical-Debt, Epic, Patch-For-Review, MediaWiki-Configuration
Legoktm updated subscribers of T140007: Empty PHP entry points where JSON entry points exist.

@SamanthaNguyen I think you might have misinterpreted this task. This one is about removing information that is duplicated in PHP entry points that is also in extension.json, not about removing the PHP shims.

Tue, Mar 14, 6:06 AM · Technical-Debt, Epic, Patch-For-Review, MediaWiki-Configuration

Fri, Mar 10

Legoktm added a comment to T160102: Make Linter edit helper compatible with VisualEditor.

Thanks for the help so far - I got most of it working except the highlight flashes and then immediately goes away. :(

Fri, Mar 10, 10:20 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, VisualEditor, MediaWiki-extensions-Linter
Legoktm committed R1995:de307ccabca2: Support new wikitext editor for edit helper (authored by Legoktm).
Support new wikitext editor for edit helper
Fri, Mar 10, 10:12 PM
Legoktm updated subscribers of T160102: Make Linter edit helper compatible with VisualEditor.

@Esanders any ideas/suggestions on how to make this work for NWE?

Fri, Mar 10, 5:54 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, VisualEditor, MediaWiki-extensions-Linter
Legoktm closed T132454: Some OAuth special pages are not recognized ('no such special page') as "Resolved".
Fri, Mar 10, 2:58 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Easy, MediaWiki-extensions-OAuth

Thu, Mar 9

Legoktm added a comment to T156445: Streamline/automate MW tarball security release process.
[11:48:07] <RainbowSprinkles> So what I really want to do (and I haven't) is rewrite make-release in python instead of that ugly-ass PHP its in now, written in a way that it can be run daily on N branches and spit out tarballs.
[11:48:24] <RainbowSprinkles> *Also* taking a hidden directory of patches and spitting out some hidden tarballs
[11:48:39] <RainbowSprinkles> So we can constantly be *generating* the next security release, aware of conflicts, and only have to decide on a date and sign shit
[11:49:06] <RainbowSprinkles> So basically, "generate list of patches" will be "what patches has security dropped in the build pipeline?"
Thu, Mar 9, 8:12 PM · Security-Team, Release-Engineering-Team, MediaWiki-Releasing
Legoktm created T160102: Make Linter edit helper compatible with VisualEditor.
Thu, Mar 9, 7:33 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), Patch-For-Review, VisualEditor, MediaWiki-extensions-Linter
Legoktm added a project to T160101: Upgrade php5-json .deb to at least 1.3.8: Operations.
Thu, Mar 9, 7:31 PM · Operations, Packaging
Legoktm added a comment to T159753: Concerns about ores_classification table size on enwiki.

Could we run a maint script first to clean out the rows before deploying the job based system?

Thu, Mar 9, 7:10 PM · Revision-Scoring-As-A-Service, Patch-For-Review, Performance, MediaWiki-extensions-ORES
Legoktm added a comment to T160003: Factor the JobQueue into the maxlag value.

Ah, so what I said isn't what you meant. Why are you proposing adding the job queue pseudo-lag to the database lag, instead of using whichever of the two is larger?

Thu, Mar 9, 7:08 PM · MediaWiki-Database, MediaWiki-API, MediaWiki-JobQueue
Legoktm created T160035: Provide systemd unit for runJobs.php .
Thu, Mar 9, 7:01 AM · MediaWiki-Debian

Wed, Mar 8

Legoktm closed T159618: Job queue rising to nearly 3 million jobs as "Resolved".

The edit rate may have been the issue, but we should still utilize the tools we have (maxlag) to notify bots that the server is under high load. If we throw a check in maxlag value calculation checking for the number of JobQueue entries and then raising the maxlag to indicate it, it would prevent bots from causing this issue again. Regardless of whether its one bot or several causing the spike, the existing maxlag checks could be used to notify all bots to back off.

Wed, Mar 8, 10:39 PM · Wikidata, MediaWiki-JobQueue, Operations
Legoktm added a comment to T148609: Review and deploy Linter extension to Wikimedia wikis.

https://test.wikipedia.org/wiki/Special:LintErrors

Wed, Mar 8, 10:00 PM · User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added a comment to T159980: revids + export for action=query api exports the latest revision only, not the revision specified.

Hmm, does https://en.wikipedia.org/w/api.php?modules=query+revisions do what you need?

Wed, Mar 8, 8:00 PM · MediaWiki-API
Legoktm added a comment to T159980: revids + export for action=query api exports the latest revision only, not the revision specified.

On https://en.wikipedia.org/w/api.php?action=help&modules=query, export is documented as "Export the current revisions of all given or generated pages." It's confusing that revids=79 will look up the page and then use the latest revision from that, but is there a reason using Special:Export to generate the XML you want is insufficient?

Wed, Mar 8, 7:52 PM · MediaWiki-API
Legoktm added a comment to T155157: Allow to define a localized description message to be added to extension configs.

@Florian do you want to integrate that into https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#config ?

Wed, Mar 8, 7:15 PM · MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), MW-1.29-release-notes, Patch-For-Review, MediaWiki-Configuration
Legoktm added a comment to T157670: Changes to MediaWiki code related to parsing can leave links tables out of date.

For the record, I started running this on all small wikis last week until I ran into T159618 and had to stop. I'll probably resume it on small wikis again tomorrow.

Wed, Mar 8, 8:05 AM · MediaWiki-Parser, MediaWiki-Page-editing, Parsing-Team
Legoktm added a project to T145541: Make Hovercards work with Special:MyLanguage links: MediaWiki-API.
Wed, Mar 8, 4:32 AM · MediaWiki-API, Patch-For-Review, Reading-Web-Backlog, MediaWiki-extensions-Translate, Page-Previews
Legoktm added a project to T159908: Idea: Make the use of ping more easy for new users (e.g. when a username is prefixed by '@'): Notifications.
Wed, Mar 8, 3:40 AM · Collaboration-Team-Triage, Notifications
Legoktm added a comment to T153817: Notify users when their user group membership is about to expire, or has expired.

The job queue already supports delayed jobs, we could theoretically queue a delayed job to run in a year or so to trigger the expiry notification.

Wed, Mar 8, 1:54 AM · Stewards-and-global-tools (Temporary-UserRights), Collaboration-Team-Triage, Notifications, Community-Tech

Tue, Mar 7

Legoktm added a comment to T159618: Job queue rising to nearly 3 million jobs.

I think it might be worth attempting to determine the factors that lead to the rapid raise.

  • The edit rate didn't seem that high and we could easily have several bots that resulted in the same rate.
Tue, Mar 7, 5:54 PM · Wikidata, MediaWiki-JobQueue, Operations
Legoktm committed rEQS58ea99c20eaa: Fix return phpdoc for Survey::getMessages() (authored by Legoktm).
Fix return phpdoc for Survey::getMessages()
Tue, Mar 7, 7:24 AM
Legoktm claimed T132454: Some OAuth special pages are not recognized ('no such special page').
Tue, Mar 7, 7:01 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Easy, MediaWiki-extensions-OAuth
Legoktm added a comment to T132454: Some OAuth special pages are not recognized ('no such special page').

And it's not necessarily a configuration issue. If an extension like UrlShortner is installed which initializes the SpecialPage list before extension functions are run, it's too late to register more special pages, which is why you need to use the hook.

Tue, Mar 7, 3:54 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Easy, MediaWiki-extensions-OAuth
Legoktm reopened T132454: Some OAuth special pages are not recognized ('no such special page') as "Open".

Anyways, it's an OAuth bug, registering special pages inside a $wgExtensionFunctions is too late. The SpecialPage_initList hook should be used instead.

Tue, Mar 7, 3:53 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, Easy, MediaWiki-extensions-OAuth
Legoktm added a comment to T158730: Automate WMF wiki creation.

Aren't dblists already in a standard format (newline delimited plain text) that we distribute across the cluster via scap?

Tue, Mar 7, 2:31 AM · Services (watching), Patch-For-Review, MediaWiki-Configuration, Release-Engineering-Team

Mon, Mar 6

Legoktm created T159736: "Show preview" when viewing an old revision on Special:Undelete is broken.
Mon, Mar 6, 7:17 PM · Regression, MediaWiki-Special-pages, MediaWiki-Page-deletion
Legoktm added a comment to T158360: RFC: Disabling LocalisationUpdate on WMF wikis.

I only see 10 open issues at the MediaWiki-extensions-LocalisationUpdate , which is not that much, and I don't know how important they are and how do they map to the issues listed at the RFC wiki page, but possibly @KartikMistry or @Nikerabbit do, because they understand Wikmedia deployments far better than I ever would.

The issues at that wiki page sound high level and generic ("LocalisationUpdate and Scap fight", "Routinely breaks", etc.), but if they can be reported as focused Phab tasks, we (the Language team) can certainly attempt to fix them.

Mon, Mar 6, 6:17 PM · ArchCom-Has-shepherd, I18n, Wikimedia-General-or-Unknown, ArchCom-RfC
Legoktm added a comment to T158360: RFC: Disabling LocalisationUpdate on WMF wikis.

Most of the issues listed on the "Problem" section aren't insurmountable, they are just due to a lack of a maintainer and ownership. The sub-bullet of "No one is responsible for the code, those who support it do not understand it" basically sums up all of the problems.

Mon, Mar 6, 10:12 AM · ArchCom-Has-shepherd, I18n, Wikimedia-General-or-Unknown, ArchCom-RfC
Legoktm removed a project from T159664: German TFA FeaturedFeed should be limited to last 7 days: MediaWiki-Configuration.

If this is related to something in the operations/mediawiki-config repository it should be tagged with Wikimedia-Site-requests .

Mon, Mar 6, 1:31 AM · Patch-For-Review, Wikimedia-Site-requests, Mobile-Content-Service, MediaWiki-extensions-FeaturedFeeds

Sun, Mar 5

Legoktm added a comment to T159618: Job queue rising to nearly 3 million jobs.

All my bots follow the maxlag policy, as defined by default in Pywikibot user-config.py.

Sun, Mar 5, 5:34 PM · Wikidata, MediaWiki-JobQueue, Operations
Legoktm lowered the priority of T159618: Job queue rising to nearly 3 million jobs from "Unbreak Now!" to "High".

Going down slowly...

Sun, Mar 5, 6:02 AM · Wikidata, MediaWiki-JobQueue, Operations
Legoktm added a comment to T156626: k8s webservice restart failure with `ValueError: get() more than one object; use filter`.

Sorry, I needed to get the tool back up. I'll remember to check those for next time.

Sun, Mar 5, 4:13 AM · Patch-For-Review, Tools-Kubernetes, Tool-Labs, Labs
Legoktm committed R2060:a8d25d28b310: More explicit (authored by Legoktm).
More explicit
Sun, Mar 5, 3:52 AM