Legoktm (Legoktm)Administrator
User

Projects (98)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (220 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Yesterday

Legoktm updated subscribers of T211653: Release MW 1.32 RC1.

@mmodell FYI I'm on "vacation" this week due to exams. I think @ArielGlenn took care of what you wanted though:

Wed, Dec 12, 7:43 AM · Release-Engineering-Team (Kanban), User-MacFan4000, MW-1.32-release, MW-1.32-notes, MediaWiki-Releasing

Tue, Dec 11

Legoktm added a comment to T210667: Can exfat be used in WMF production?.

Thanks everyone of for their thoughtful consideration. I have no issues nor do I see a conflict with temporarily allowing the use of this so we can complete our work with our 3rd party partners.

Tue, Dec 11, 6:11 AM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations
Legoktm added a comment to T190379: RFC: Re-establish the development policies.

A few general comments:

  • I don't think putting policies under a specific parent page (the propose Development policy/Deprecation) helps. We already have {{policy}} to denote official policies, and that should be enough.
  • Regularly reviewing policies to ensure they still reflect reality is a good thing, but just because it hasn't been updated in a while shouldn't be seen as problematic. E.g. the +2 page is listed as last being majorly updated in 2013, but IMO all of the content is still applicable and relevant. Good policies (ideally) don't require constant review and redrafting/updating.
  • There's been a recent trend I've seen in free software projects where before you submit a patch you're expected to read a giant contributing guide, and I'm not sure it's a direction we should go down. In most cases, someone submitting a patch with a non-ideal commit message or some whitespace error is more valuable than the amount of time we as maintainers would spend fixing those minor things. The parts in this task about building a good entry point for our development policies I'm totally in favor of, but I don't think we should have an expectation that everyone will read all of the policies fully before submitting patches.
  • More tangentially, I would be interested in a survey about what policies people think we're missing (or overly strict on).
Tue, Dec 11, 5:46 AM · Performance-Team (Radar), TechCom-RFC, TechCom

Mon, Dec 10

Legoktm created T211555: Figure out how to inject MediaWiki's mime mapping into Guzzle.
Mon, Dec 10, 8:39 AM · MediaWiki-General-or-Unknown

Thu, Dec 6

Legoktm added a comment to T202110: Create GuzzleHttpRequest class as new default for HttpRequestFactory.

My main question about bringing in Guzzle is how we're going to apply the deprecation policy to this. Typically we've said that extensions can depend upon any library that MediaWiki core depends upon, since we're going to keep back-compat or cautiously update external libraries. But the size of Guzzle is much much larger than any other library that core depends upon to date. If Guzzle makes a breaking change, I'm imagining a mess if we need to update every thing that makes HTTP requests.

Thu, Dec 6, 8:19 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), Patch-For-Review, MediaWiki-General-or-Unknown
Legoktm added a comment to T202143: Security review for Guzzle 6.3.3.

The only minor security thing I noticed was that MediaWiki's HTTP stuff does not follow redirects by default, while Guzzle will follow 5 layers of redirects by default. So as long as everyone continues to use the MediaWiki abstraction layer, the defaults should still be as strict as we want them.

Thu, Dec 6, 8:01 AM · User-Addshore, Security-Reviews, MediaWiki-Vendor
Legoktm added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

Maybe I'm missing something, but how do you intentionally cause PHP to segfault? Shouldn't any code that triggers a segfault be a PHP bug that should/would be reported upstream?

You can trivially cause a segfault with:

function foo() {
   array_map('foo', [0]);
}
foo();

This is well known to the PHP devs. It used to be that any infinite recursion would cause a segfault, and they didn't consider that a bug either. But now there is a virtual stack for the VM so it's necessary to call into C code and then back into PHP e.g. using array_map(). Nikita Popov mentioned this behaviour in http://nikic.github.io/2017/04/14/PHP-7-Virtual-machine.html#function-calls

Thu, Dec 6, 5:52 AM · Core Platform Team Kanban (Doing), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support
Legoktm added a comment to T211272: Cron <root@mw2182> test -x /usr/sbin/anacron || ( cd / && run-parts --report /etc/cron.daily ).

@Mathew.onipe any reason you added MediaWiki-API ? I don't see the relevance.

Thu, Dec 6, 5:27 AM · Operations
Legoktm added a comment to T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.

Just to make sure it wasn't missed, in the other ticket @Jdforrester-WMF raised a concern with using :hover being problematic for people on touch devices in T165189#4790357 but I believe @stjn addressed his concern T165189#4790562 by noting that it's not just hover, it's any active states including :focus and :active.

Thu, Dec 6, 1:43 AM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
Legoktm closed T165189: "→" link to page section on History page can be hard to click, should be larger somehow as Resolved.
Thu, Dec 6, 1:34 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs

Tue, Dec 4

Legoktm closed T210998: CLI installer does not set $wgLanguageCode when passing "--lang" as Resolved.
Tue, Dec 4, 7:41 AM · MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-release, MW-1.31-release, Patch-For-Review, MediaWiki-Installer
Legoktm added projects to T210998: CLI installer does not set $wgLanguageCode when passing "--lang": MW-1.31-release, MW-1.32-release.

It would be cool if this change could be cherry-picked to REL1_31.

Tue, Dec 4, 6:15 AM · MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-release, MW-1.31-release, Patch-For-Review, MediaWiki-Installer
Legoktm renamed T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery from Gray used in .autocomment in RC and watchlist is not accessible against background to Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.
Tue, Dec 4, 3:14 AM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
RandomDSdevel awarded T165189: "→" link to page section on History page can be hard to click, should be larger somehow a Like token.
Tue, Dec 4, 2:49 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
RandomDSdevel awarded T165189: "→" link to page section on History page can be hard to click, should be larger somehow a Like token.
Tue, Dec 4, 2:49 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm added a comment to T165189: "→" link to page section on History page can be hard to click, should be larger somehow.

OK, so all three changes are deployed now. The sea of blue should be gone now, but the full section name will be linked, with similar HTML.

Tue, Dec 4, 12:27 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm updated subscribers of T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery.

In addition to the pre-existing accessibility problem with the specific gray, it's now also a link that isn't super discoverable. Many editors found making the link blue (like normal) excessive, and overwhelming, creating a "sea of blue". The most important argument I was convinced by was:

Tue, Dec 4, 12:25 AM · MediaWiki-Commenting, Growth-Team, UI-Standardization-Kanban, UI-Standardization, MediaWiki-History-or-Diffs, MediaWiki-Recent-changes, MediaWiki-Watchlist, Accessibility
Legoktm renamed T118822: find another way to compile the donor list for the annual report from Dear God - please help us find another way to compile the donor list for the annual report to find another way to compile the donor list for the annual report.
Tue, Dec 4, 12:10 AM · Fundraising Sprint XML ate my homework, Fundraising Sprint Window dressing is mostly olive oil, Fr-backlog-cleanup-Q3_2017-18, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM

Mon, Dec 3

Legoktm added a comment to T165189: "→" link to page section on History page can be hard to click, should be larger somehow.

Please at least add a class to these links. Currently I would like to use a custom css style on them and I don't see how I can.

Mon, Dec 3, 9:07 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm changed the visibility for T210953: Wikidata is editable for blocked users.
Mon, Dec 3, 4:39 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Legoktm committed rLCSH82873fe35cc5: Change "Source code" link to point to Gitiles (authored by Legoktm).
Change "Source code" link to point to Gitiles
Mon, Dec 3, 8:45 AM
Legoktm added a comment to T209083: Come up with a plan for community security reviews of MediaWiki extensions/skins.

So the next step is to get buy in from the Security-Team on this, since it relies on them for bootstrapping, and it doesn't make much sense to do it without their support.

Mon, Dec 3, 6:55 AM · Core Platform Team Kanban, Core Platform Team (Extension Management (TEC13)), Security-Team
Legoktm closed T210372: Delete codesearch3 instance after December 2, 2018 as Resolved.
Mon, Dec 3, 6:18 AM · VPS-project-codesearch
Legoktm closed T210967: Empty rev_comment fields as Invalid.

See https://lists.wikimedia.org/pipermail/cloud/2018-September/000383.html - you'll need to use the new comment table.

Mon, Dec 3, 6:12 AM · cloud-services-team
Legoktm added a comment to T210953: Wikidata is editable for blocked users.

I've reverted https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/471993/ on wmf.6, and confirmed on test.wikidata.org that it fixes the issue. I'd appreciate it if someone could verify on wikidata.org itself before we make this task public.

Mon, Dec 3, 12:37 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Legoktm added a comment to T210953: Wikidata is editable for blocked users.

Might be related to T182983.

I tested but nope.

It looks like reverting https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/471993/ from core fixes the issue

Mon, Dec 3, 12:01 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security

Sun, Dec 2

Legoktm added a comment to T210919: Use of 'oathauth-disable-for-user' must be logged, with reason.

We should use Special:log like normal, but restrict it to people with whatever right (as @MarcoAurelio suggested). We already do it with the suppression log, and used to do it with the spamblacklist log.

Sun, Dec 2, 11:59 PM · MediaWiki-extensions-OATHAuth, Stewards-and-global-tools
Legoktm added a comment to T209998: Possible privacy break when loading font from toolserver.

The Wikimedia Privacy Policy explicitly says that user-agents are "personal information" (see https://meta.wikimedia.org/wiki/Privacy_policy#Definitions). Whether it truly is private information is out of scope - we have to follow the privacy policy here.

Sun, Dec 2, 6:52 PM · Wikimedia-General-or-Unknown, Privacy
matej_suchanek awarded T165189: "→" link to page section on History page can be hard to click, should be larger somehow a Y So Serious token.
Sun, Dec 2, 11:57 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
D3r1ck01 awarded T210936: Add inline diffs to Special:Watchlist a Like token.
Sun, Dec 2, 11:07 AM · Growth-Team, MediaWiki-Watchlist
Aklapper awarded T210087: Requesting +2 for Ebe123 on WikimediaIncubator a Like token.
Sun, Dec 2, 10:43 AM · Repository-Ownership-Requests, MediaWiki-extensions-WikimediaIncubator
Quiddity awarded T210936: Add inline diffs to Special:Watchlist a Like token.
Sun, Dec 2, 5:13 AM · Growth-Team, MediaWiki-Watchlist
Legoktm created T210936: Add inline diffs to Special:Watchlist .
Sun, Dec 2, 2:39 AM · Growth-Team, MediaWiki-Watchlist
Legoktm added a comment to T165189: "→" link to page section on History page can be hard to click, should be larger somehow.

There are a lot of experienced developers and community members participating in this discussion. Rhetoric aside, I think your comments would be significantly more helpful if you backed them up with evidence.

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Something_new_in_our_edit_contributions.

Sun, Dec 2, 2:29 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm closed T210087: Requesting +2 for Ebe123 on WikimediaIncubator as Resolved.

Done!

Sun, Dec 2, 1:55 AM · Repository-Ownership-Requests, MediaWiki-extensions-WikimediaIncubator
Legoktm added a project to T210934: Toolforge: Node.js policy: Toolforge.
Sun, Dec 2, 12:57 AM · Toolforge, cloud-services-team (Kanban)
Legoktm added projects to T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3: MW-1.31-release, MW-1.32-release.
Sun, Dec 2, 12:31 AM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-release, MW-1.31-release, Patch-For-Review, PHP 7.3 support, Upstream, MediaWiki-Vendor

Sat, Dec 1

Nihlus awarded T165189: "→" link to page section on History page can be hard to click, should be larger somehow a Dislike token.
Sat, Dec 1, 11:30 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm raised the priority of T210739: Target deletion during page move fails from Normal to Unbreak Now!.

I'm resetting unbreak now priority based on the following report from IRC:

[22:27:20] <thib> hi there, we can't rename on frwiki, we get the message "Erreur fatale de type « MWException »"
[22:27:46] <thib> some vandals take advantage of this bug
[22:27:55] <thib> and we have to delete pages so we can rename
[22:28:19] <thib> *rename when the page have multiple lines in the history
Sat, Dec 1, 10:33 AM · Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Special-pages, Wikimedia-production-error
Legoktm renamed T210910: Jobs for otrs-wiki are slower than expected to process from increase wgJobRunRate for otrs-wiki to Jobs for otrs-wiki are slower than expected to process.
Sat, Dec 1, 8:21 AM · WMF-JobQueue, Wikimedia-General-or-Unknown
Legoktm added a comment to T165189: "→" link to page section on History page can be hard to click, should be larger somehow.

Sorry, I had a busier day IRL than expected. Will post some patches shortly.

Sat, Dec 1, 8:19 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs

Fri, Nov 30

Legoktm added a comment to T210667: Can exfat be used in WMF production?.

So I think this task raises a few different issues (and @Legoktm correct me if I'm wrong):
<snip>

Fri, Nov 30, 7:54 PM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations
Lofhi awarded T165189: "→" link to page section on History page can be hard to click, should be larger somehow a Like token.
Fri, Nov 30, 7:00 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm added a comment to T210822: Reconsider section heading marker ("→") in edit summaries.

For reference, the arrow is currently generated by $wgLang->getArrow(), which means that different UI languages might do different things (right now it's just a RTL check). I would assume that a symbol like § would also need to be localizable.

Fri, Nov 30, 9:02 AM · MediaWiki-Commenting, MediaWiki-General-or-Unknown
Legoktm reopened T165189: "→" link to page section on History page can be hard to click, should be larger somehow as "Open".

Thanks all for the additional feedback, re-opening since there's still some more work to be done.

Fri, Nov 30, 8:59 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-Commenting, Google-Code-in-2018, MediaWiki-History-or-Diffs
Legoktm added a comment to T203529: Set up a packagist mirror for Wikimedia.

So the mirror creation is done, I installed apache2, and symlinked /var/www/html to /srv/packagist-mirror/public/ and verified that curl localhost works. But I'm unable to reach port 80 from outside of the instance, whether via DNS proxy or from inside another cloud vps (toolforge in this case). Probably an issue with security groups, but I don't see anything obvious. On IRC, arturo offered to take a look <3.

Fri, Nov 30, 8:34 AM · Composer, Wikimedia-General-or-Unknown
Legoktm added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

Maybe I'm missing something, but how do you intentionally cause PHP to segfault? Shouldn't any code that triggers a segfault be a PHP bug that should/would be reported upstream?

Fri, Nov 30, 8:32 AM · Core Platform Team Kanban (Doing), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support
Legoktm added a comment to T210667: Can exfat be used in WMF production?.

If it's not re-distributable by us, then it doesn't meet the definition of free software (freedom #2).

I have absolutely no skin in this game, but this statement is incorrect. Anyone living in a country without enforcement of those specific software patents can freely distribute exfat.

Fri, Nov 30, 8:21 AM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations
Legoktm closed T210812: Remove Generic.PHP.DeprecatedFunctions.Deprecated from 19.x branch as Resolved.
Fri, Nov 30, 1:30 AM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm added a comment to T210667: Can exfat be used in WMF production?.

Hi all, commenting on this from WMF Legal.

As I understand the question and context, the issue is using a proprietary format for some data transfer because an external party isn’t set up to handle other file formats that might more properly meet the definition of free software.

Fri, Nov 30, 12:26 AM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations

Thu, Nov 29

Legoktm added a comment to T210734: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given.
legoktm@mwmaint1002:~$ mwscript eval.php --wiki=incubatorwiki
> var_dump($wgHooks['OutputPageParserOutput']);
array(5) {
  [0]=>
  string(68) "\Wikibase\Client\Hooks\SidebarHookHandlers::onOutputPageParserOutput"
  [1]=>
  string(31) "CategoryTreeHooks::parserOutput"
  [2]=>
  string(45) "MobileFrontendHooks::onOutputPageParserOutput"
  [3]=>
  string(39) "GeoData\Hooks::onOutputPageParserOutput"
  [4]=>
  string(35) "GeoCrumbs::onOutputPageParserOutput"
}
Thu, Nov 29, 8:33 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Editing-team, GeoCrumbs, Wikimedia-production-error
Legoktm added a comment to T210734: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given.

GeoCrumbs is probably not the culprit here. Likely the OutputPageParserOutput hook handler before it is messing with the $parserOutput variable.

Thu, Nov 29, 8:28 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Editing-team, GeoCrumbs, Wikimedia-production-error
Legoktm added a comment to T210685: Depends-On should not work across branches.

This isn't due to Depends-On, it's because gate-and-submit-* uses the dependent queue (AFAICT), which means changes are always forced into dependencies like this, just like the normal gate-and-submit queue. See T94322: Re-evaluate use of "Dependent Pipeline" in Zuul for gate-and-submit.

Thu, Nov 29, 1:21 AM · Zuul, Continuous-Integration-Infrastructure

Wed, Nov 28

Legoktm added a comment to T210667: Can exfat be used in WMF production?.

exfat-fuse itself is free software (GPL) and part of Debian main. Debian's approach on patents is written up at https://www.debian.org/reports/patent-faq (TLDR; unless patents are actively enforced, they're ignored. Debian has been shipping ffmpeg which implements patent-encumbered algorithms for a long time as well).

Other distros (especially Red Hat/Fedora which are operating under US law) have taken a more rigid stance. Given that we're not distributing exfat that should also not pose a risk to WMF, though. (Obviously IANAL).

Wed, Nov 28, 10:51 PM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations
Legoktm triaged T210667: Can exfat be used in WMF production? as Unbreak Now! priority.
Wed, Nov 28, 9:08 PM · Security-Team, Analytics, Software-Licensing, WMF-Legal, Operations
Legoktm updated subscribers of T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias.

We have an explicit indication that this will make a difference for Google, provided by Google: https://developers.google.com/search/mobile-sites/mobile-seo/separate-urls. What we are doing here is implementing Google's recommendation, in order to validate that it actually does improve mobile site results.

Wed, Nov 28, 8:38 PM · Wikimedia-Site-requests, Patch-For-Review, Hindi-Sites, Chinese-Sites, Readers-Web-Backlog (Tracking), SEO
Legoktm added a project to T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias: Wikimedia-Site-requests.

+Wikimedia-Site-requests since this is a request for a configuration change.

Wed, Nov 28, 6:41 AM · Wikimedia-Site-requests, Patch-For-Review, Hindi-Sites, Chinese-Sites, Readers-Web-Backlog (Tracking), SEO
Legoktm renamed T127368: Estimate hardware requirements for Toolforge logging elastic cluster from Estimate hardware requirements for Tool Labs logging elastic cluster to Estimate hardware requirements for Toolforge logging elastic cluster.
Wed, Nov 28, 12:22 AM · Toolforge
Legoktm added a comment to T189641: Service for checking the Pwned Passwords database.

I wrote a simple HTTP API wrapper around sgrep at https://git.legoktm.com/legoktm/PawnedPasswords implementing the same API as the PwnedPasswords one. It's about 50 lines of Python, and only has a framework dependency on flask, that probably could be removed if it matters and use plain CGI instead.

Wed, Nov 28, 12:14 AM · Services (watching), User-Tgr, WMF-Legal, Patch-For-Review, Security, MediaWiki-User-login-and-signup, MediaWiki-Authentication-and-authorization, Security-General

Tue, Nov 27

Legoktm claimed T206485: Set root: true in eslintrc.json.
Tue, Nov 27, 10:47 PM · Front-end-Standards-Group, MediaWiki-extensions-General
Legoktm committed rEQScd973b523a4c: Remove unnecessary // eslint-disable-next-line dot-notation (authored by Legoktm).
Remove unnecessary // eslint-disable-next-line dot-notation
Tue, Nov 27, 10:39 PM
Legoktm updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Tue, Nov 27, 10:06 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, MediaWiki-extensions-General, Google-Code-in-2018
Legoktm added a comment to T203625: mwdebug1001 and mwdebug1002 are reliably the last two hosts to finish scap-cdb-rebuild .

Yeah, that seems sensible unless there's some significant reason (e.g. hardware cost) not to.

Tue, Nov 27, 7:23 PM · Release-Engineering-Team, Scap, Operations
Legoktm claimed T204692: cloudvps: social-tools project trusty deprecation.

I need to double check in the database, but I think gadgets can probably be deleted. social-tools2 and timeless1 we'll want to dump and migrate to a new host.

Tue, Nov 27, 6:58 PM · Cloud-VPS (Ubuntu Trusty Deprecation)
Legoktm added a comment to T210528: PHP/HHVM serialization incompatibility in some situations when using Serializable.

One general fix would be to abandon Serializable entirely.

Tue, Nov 27, 6:46 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Core Platform Team (PHP7 (TEC4))
Legoktm added a comment to T209763: Right 'banner-protect' is missing i18n descriptions.

If it's a Wikimedia-specific thing, then the messages should go in the WikimediaMessages extension. (Of course, if this is useful to other wikis that use CentralNotice, then it would be nice to move it into the extension itself).

Tue, Nov 27, 5:16 AM · Patch-For-Review, Fundraising Sprint XML ate my homework, User-MarcoAurelio, Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, I18n, MediaWiki-extensions-CentralNotice

Mon, Nov 26

Legoktm added a comment to T189641: Service for checking the Pwned Passwords database.

I spent a bit of time looking into this over the weekend, mostly seeing what other people have come up with.

Mon, Nov 26, 11:06 PM · Services (watching), User-Tgr, WMF-Legal, Patch-For-Review, Security, MediaWiki-User-login-and-signup, MediaWiki-Authentication-and-authorization, Security-General
dduvall awarded T210341: beta-update-databases-eqiad is failing with a composer problem a Like token.
Mon, Nov 26, 7:06 PM · Beta-Cluster-Infrastructure
Legoktm claimed T210341: beta-update-databases-eqiad is failing with a composer problem.

Will be fixed shortly by https://gerrit.wikimedia.org/r/475682 - my mistake.

Mon, Nov 26, 6:54 PM · Beta-Cluster-Infrastructure
Daimona awarded T210409: Codesearch not working for "MediaWiki core" section a Like token.
Mon, Nov 26, 6:45 PM · VPS-project-codesearch
Legoktm added a comment to T150826: Remove unblockself right on wikimedia wikis.

With this change, steward intervention will be required only if the vandal admin manages to block every other active admin before they themselves are blocked.

Do we have rate limitations for blocking actions via API?

Mon, Nov 26, 6:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-User-management, User-notice, Patch-For-Review, Community-consensus-needed, Wikimedia-Site-requests
Legoktm closed T210409: Codesearch not working for "MediaWiki core" section as Resolved.

I set up a new codesearch server last night, and something must have gone wrong in the initial bootstrapping. I forced a full clone/rebuild of the "MediaWiki core" filter, and tested all of the other ones to make sure they're returning results.

Mon, Nov 26, 6:34 PM · VPS-project-codesearch
Legoktm claimed T210409: Codesearch not working for "MediaWiki core" section.
Mon, Nov 26, 6:29 PM · VPS-project-codesearch
Legoktm added a comment to T210369: Add @since 1.33 tags to every new public method in BlockRestriction.

FWIW not just the BlockRestriction class, every new function needs it. I noticed this when I was looking for when Block::isSitewide() was introduced actually.

Mon, Nov 26, 9:00 AM · MediaWiki-User-management, Anti-Harassment
Legoktm committed rMSPC8eb8e5d85218: Use pytest's verbose mode when running tests (authored by Legoktm).
Use pytest's verbose mode when running tests
Mon, Nov 26, 8:38 AM
Legoktm committed rMSPCc5c8363f3bae: Fix W605 flake8 issues (authored by Legoktm).
Fix W605 flake8 issues
Mon, Nov 26, 8:38 AM
Legoktm committed rMSPCf18f9ff81892: Improve support for Debian's default compiler flags (authored by Legoktm).
Improve support for Debian's default compiler flags
Mon, Nov 26, 8:38 AM
Legoktm triaged T210372: Delete codesearch3 instance after December 2, 2018 as Lowest priority.
Mon, Nov 26, 6:42 AM · VPS-project-codesearch
Legoktm updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Mon, Nov 26, 2:32 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, MediaWiki-extensions-General, Google-Code-in-2018
Legoktm created T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Mon, Nov 26, 2:31 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, MediaWiki-extensions-General, Google-Code-in-2018
Legoktm closed T206506: Replace usage of csslint with stylelint in CookieWarning extension as Resolved.
Mon, Nov 26, 1:19 AM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-CookieWarning

Sun, Nov 25

Legoktm committed rECWe0d100ca6074: Replaced CSSLint with StyleLint (authored by takidelfin).
Replaced CSSLint with StyleLint
Sun, Nov 25, 11:55 PM

Sat, Nov 24

Legoktm created T210321: Special:PageAssessments project form field autocomplete ends up in the main search box's autocomplete when using Timeless skin.
Sat, Nov 24, 12:27 PM · Timeless, MediaWiki-extensions-PageAssessments
Legoktm updated subscribers of T209236: "&params" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms).

ad80f0bca27c2b0905b2b137977586bfab80db34 is the first bad commit
commit ad80f0bca27c2b0905b2b137977586bfab80db34
Author: C. Scott Ananian <cscott@cscott.net>
Date: Mon Oct 15 16:39:19 2018 -0400

Sat, Nov 24, 10:18 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Regression, MediaWiki-Parser
Legoktm triaged T209236: "&params" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) as Unbreak Now! priority.

Sorry, this bug was not triaged properly, it should have been unbreak now!, given that this is a regression that shouldn't have happened and needs to be reverted.

Sat, Nov 24, 10:13 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Regression, MediaWiki-Parser
Legoktm added a comment to T210280: Migrate CI job labs-tools-wikibugs2-autopull to use a Docker container or phase it out.

In any case, I think it's very important we maintain our current auto deployment mechanism in some way/form, as it's allowed wikibugs' channel listing to really be self-serve.

Sat, Nov 24, 3:01 AM · Patch-For-Review, Wikibugs, Continuous-Integration-Infrastructure (Slipway)
Legoktm added a comment to T210280: Migrate CI job labs-tools-wikibugs2-autopull to use a Docker container or phase it out.

Change 475580 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/tools/wikibugs2@refs/meta/config] Use webhook plugin post-merge for autopull

https://gerrit.wikimedia.org/r/475580

Sat, Nov 24, 3:00 AM · Patch-For-Review, Wikibugs, Continuous-Integration-Infrastructure (Slipway)
Legoktm added a comment to T68985: ExtensionDistributor should not include dot files in the tarball release packages.

We should probably switch to using git archive and somehow? use the .gitattributes file from core, which contains the exclusions..

Sat, Nov 24, 2:38 AM · VPS-project-Extdist, ExtensionDistributor
Legoktm added a comment to T207389: Rename the Certcentral project.

My suggestion would be to base the name off of the ACME protocol and going from there, https://en.wikipedia.org/wiki/Carmen_Sandiego_(character) (main nemesis of the ACME Detective Agency).

Sat, Nov 24, 1:59 AM · Certcentral
Legoktm updated the task description for T207389: Rename the Certcentral project.
Sat, Nov 24, 1:36 AM · Certcentral

Thu, Nov 22

Legoktm added a comment to T205581: Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.

Change 462008 merged by jenkins-bot:
[mediawiki/core@master] Remove hardcoded parentheticals from ChangesList "comments"

https://gerrit.wikimedia.org/r/462008

Thu, Nov 22, 7:18 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Accessibility, MobileFrontend (MobileFrontend Special Pages), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-Special-pages, MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team, Front-end-Standards-Group, Patch-For-Review, UI-Standardization, User-Jdlrobson
Legoktm committed rMSPC0d98c01c7d98: Inherit default CFLAGS in Makefile (authored by Legoktm).
Inherit default CFLAGS in Makefile
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPC562ed3ea8b77: Inherit default CFLAGS in Makefile (authored by Legoktm).
Inherit default CFLAGS in Makefile
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPCfe5d387b9dff: Suppress W605 flake8 warnings for now (authored by Legoktm).
Suppress W605 flake8 warnings for now
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPC748c6f4d6f83: Use pytest's verbose mode when running tests (authored by Legoktm).
Use pytest's verbose mode when running tests
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPC4bc35ea0b093: Use pytest's verbose mode when running tests (authored by Legoktm).
Use pytest's verbose mode when running tests
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPC55e79f922a66: Fix W605 flake8 issues (authored by Legoktm).
Fix W605 flake8 issues
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPCd7b251ffb0b1: Suppress W605 flake8 warnings for now, fix E226 (authored by Legoktm).
Suppress W605 flake8 warnings for now, fix E226
Thu, Nov 22, 3:22 AM
Legoktm committed rMSPCaeab0d915c61: Inherit default CFLAGS in Makefile (authored by Legoktm).
Inherit default CFLAGS in Makefile
Thu, Nov 22, 3:22 AM

Wed, Nov 21

Legoktm added a comment to T201411: Fatal error on Special:Log caused by date input (TimestampException error).

The IP 91.247.38.47 is still in the blacklist filters of the esams network devices, is it safe to remove it? If not, when should I ping you again about it?
Thanks

Wed, Nov 21, 11:05 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018), MediaWiki-Logging, Wikimedia-production-error