Fri, Feb 16
rxy has disabled it for now. Once it's no longer possible for external resources to be loaded without user's consent, it should be fine to renable it.
So, estimateRowCount doesn't appear like it will work:
wikiadmin@db1080(enwiki)>select count(*) from linter inner join page on page_id=linter_page where linter_cat=4 and page_namespace=0; +----------+ | count(*) | +----------+ | 735992 | +----------+ 1 row in set (5.58 sec)
I sent an email to the global renamers list announcing this.
- Use docker-registry.wikimedia.org/releng/composer
Thu, Feb 15
Maybe the use statement doesn't work if its above the namespace block?
PHP Fatal Error: Class undefined: MediaWiki\MassMessage\MediaWikiServices
Theoretically this affects https://codesearch.wmflabs.org/search/?q=%27%5C.%27&i=nope&files=tests%2Fphan%2Fconfig%5C.php&repos= but none of those repositories are failing...
Oh, I see. For example Cite only lints the includes/ directory, so vendor/ won't get picked up. CiteThisPage lints ., so it includes vendor/. Patch incoming.
I don't understand why this only failed for CiteThisPage and not every other phan extension.
I filed this task originally since it was causing problems for libraryupgrader, but that has now switched to gitiles (T187150) so this is no longer a problem for me (assuming gitiles updates instantly).
Wed, Feb 14
Looks great in Gitiles: https://gerrit.wikimedia.org/g/mediawiki/tools/codesniffer
I don't really have any great ideas, including the line in the output seems like an interesting idea, but that would need to be implemented by upstream PHPCS.
We can do this regardless of updating integration/composer, since it'll emit a non-failing warning. But this is blocking making the next MW-CS release.
Also you can just submit a dummy patch against the extensions and jenkins will run the job in the clean CI environment (e.g. https://gerrit.wikimedia.org/r/#/c/410195/ ) - I think my checkout is a few days behind.
Results from running locally using the CI docker container:
- Cite - pass
- CiteThisPage - pass
- ConfirmEdit - pass
- Gadgets - pass
- ImageMap - FAIL
- InputBox - pass
- Interwiki - pass
- LocalisationUpdate - pass
- Nuke - pass
- ParserFunctions - pass
- PdfHandler - pass
- Poem - pass
- Renameuser - FAIL
- SpamBlacklist - FAIL
- SyntaxHighlight_GeSHi - pass
- TitleBlacklist - pass
- WikiEditor - pass