Legoktm (Legoktm)
User

Projects (83)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (135 w, 5 d)
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Wed, Apr 19

Legoktm added a comment to T159021: Wikitech error when adding users to projects.
2017-02-25 00:50:02 [63aa22b668ebe4dde03fc343] silver labswiki 1.29.0-wmf.13 exception ERROR: [63aa22b668ebe4dde03fc343] /wiki/Special:NovaProject   UnexpectedValueExceptio
n from line 196 of /srv/mediawiki/php-1.29.0-wmf.13/includes/user/UserGroupMembership.php: UserGroupMembership::insert() needs a positive user ID. Did you forget to add you
r User object to the database before calling addGroup()? {"exception_id":"63aa22b668ebe4dde03fc343","caught_by":"mwe_handler"} 
[Exception UnexpectedValueException] (/srv/mediawiki/php-1.29.0-wmf.13/includes/user/UserGroupMembership.php:196) UserGroupMembership::insert() needs a positive user ID. Di
d you forget to add your User object to the database before calling addGroup()?
  #0 /srv/mediawiki/php-1.29.0-wmf.13/includes/user/User.php(3412): UserGroupMembership->insert(boolean)
  #1 /srv/mediawiki/php-1.29.0-wmf.13/extensions/OpenStackManager/special/SpecialNovaProject.php(472): User->addGroup(string)
  #2 [internal function]: SpecialNovaProject->tryAddMemberSubmit(array, HTMLForm)
  #3 /srv/mediawiki/php-1.29.0-wmf.13/includes/htmlform/HTMLForm.php(663): call_user_func(array, array, HTMLForm)
  #4 /srv/mediawiki/php-1.29.0-wmf.13/includes/htmlform/HTMLForm.php(555): HTMLForm->trySubmit()
  #5 /srv/mediawiki/php-1.29.0-wmf.13/includes/htmlform/HTMLForm.php(570): HTMLForm->tryAuthorizedSubmit()
  #6 /srv/mediawiki/php-1.29.0-wmf.13/extensions/OpenStackManager/special/SpecialNovaProject.php(90): HTMLForm->show()
  #7 /srv/mediawiki/php-1.29.0-wmf.13/extensions/OpenStackManager/special/SpecialNovaProject.php(41): SpecialNovaProject->addMember()
  #8 /srv/mediawiki/php-1.29.0-wmf.13/includes/specialpage/SpecialPage.php(522): SpecialNovaProject->execute(NULL)
  #9 /srv/mediawiki/php-1.29.0-wmf.13/includes/specialpage/SpecialPageFactory.php(577): SpecialPage->run(NULL)
  #10 /srv/mediawiki/php-1.29.0-wmf.13/includes/MediaWiki.php(285): SpecialPageFactory::executePath(Title, RequestContext)
  #11 /srv/mediawiki/php-1.29.0-wmf.13/includes/MediaWiki.php(860): MediaWiki->performRequest()
  #12 /srv/mediawiki/php-1.29.0-wmf.13/includes/MediaWiki.php(521): MediaWiki->main()
  #13 /srv/mediawiki/php-1.29.0-wmf.13/index.php(43): MediaWiki->run()
  #14 /srv/mediawiki/w/index.php(3): require(string)
  #15 {main}
Wed, Apr 19, 8:05 AM · Labs-Infrastructure, Labs
Legoktm added a comment to T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function.

See also T159021: Wikitech error when adding users to projects.

Wed, Apr 19, 5:23 AM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm added a comment to T159021: Wikitech error when adding users to projects.

The logged exception was:

UnexpectedValueException from line 196 of /srv/mediawiki/php-1.29.0-wmf.13/includes/user/UserGroupMembership.php: UserGroupMembership::insert() needs a positive user ID. Did you forget to add your User object to the database before calling addGroup()?
Wed, Apr 19, 5:22 AM · Labs-Infrastructure, Labs
Legoktm removed projects from T163302: Consider to re-label "Save changes"/"Publish changes" to be "Save & Publish": MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)), MW-1.27-release-notes.
Wed, Apr 19, 5:17 AM · Community-Liaisons, WikiEditor, VisualEditor, Editing-Department, MediaWiki-Internationalization, MediaWiki-Page-editing
Legoktm removed a project from T138370: Backport load_composer_autoloader to prevent breaking compat with mw 1.26 and 1.25: MW-1.27-release.
Wed, Apr 19, 3:28 AM · MediaWiki-Configuration
Legoktm renamed T138370: Backport load_composer_autoloader to prevent breaking compat with mw 1.26 and 1.25 from "Backport load_composer_autoloader to 1.27.x, to prevent breaking compat with 1.26 and 1.25" to "Backport load_composer_autoloader to prevent breaking compat with mw 1.26 and 1.25".
Wed, Apr 19, 3:28 AM · MediaWiki-Configuration
Legoktm closed T138370: Backport load_composer_autoloader to prevent breaking compat with mw 1.26 and 1.25 as "Declined".

Right, the title change by Andre didn't really make sense. Given that 1.25 and 1.26 are EOL now, this is declined.

Wed, Apr 19, 3:28 AM · MediaWiki-Configuration
RandomDSdevel awarded T157670: Changes to MediaWiki code related to parsing can leave links tables out of date a Grey Medal token.
Wed, Apr 19, 12:45 AM · MediaWiki-Parser, MediaWiki-Page-editing, Parsing-Team

Tue, Apr 18

Legoktm added a comment to T163277: Make CentralIdLookup easier to use safely across environments (different providers, part of cluster/not part, etc.).

a) You can get a central ID from LocalIdLookup that could be used incorrectly. This can only be used on that same wiki, or on other wikis using shared user tables (maybe these two cases should even be different providers). If you're expecting (incorrectly) that the wiki is part of a farm, you may not realize you're using LocalIdLookup.

Tue, Apr 18, 10:55 PM · MediaWiki-Authentication-and-authorization
Legoktm added a comment to T163167: Sysops are no longer able to add education extension groups.

I think this is the same issue as T141431: Can't grant "Upload Wizard campaign editor" unless default settings are customized?

Tue, Apr 18, 2:07 AM · Patch-For-Review, Wikimedia-General-or-Unknown, MediaWiki-Configuration, MediaWiki-extensions-EducationProgram

Mon, Apr 17

Legoktm added a comment to T163150: Add native support to selectively load MediaWiki JS or CSS via URL.

I think this would mean revisiting T29766: Allow loading modules by request url query parameter? (which I would be in favor of re-opening)

Mon, Apr 17, 10:00 PM · MediaWiki-ResourceLoader
Legoktm added a comment to T108138: Sysops can undelete pages, although the page is protected against it.

This caused T163144: Restoration of deleted items broken on Wikidata.

Mon, Apr 17, 8:07 PM · MW-1.27-release-notes, MW-1.28-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MW-1.29-release-notes, Patch-For-Review, Security-Team, Security, MediaWiki-Page-deletion, MediaWiki-Page-protection
Legoktm added a comment to T163144: Restoration of deleted items broken on Wikidata.

'create' on Wikidata in the main namespace is blocked by the 'wikibase-no-direct-editing' error. Therefore 'undelete' now fails with 'undelete-cantcreate' which was added in T108138: Sysops can undelete pages, although the page is protected against it.

Mon, Apr 17, 8:07 PM · Wikidata-Sprint, Patch-For-Review, Regression, Wikidata
Legoktm added a comment to T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function.

I'm delighted to report that the patch has fixed the problem. I've successfully managed to have the account block me while not logged-in. Thank you, @Legoktm.

Mon, Apr 17, 6:52 PM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm added a comment to T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function.

I'm not seeing how that patch would fix the bug reported here (although the patch does seem like a good idea on its own).

Mon, Apr 17, 5:36 PM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm committed R1995:f5e43ddb1a02: API: Add pageid/ns to list=linterrors output (authored by Legoktm).
API: Add pageid/ns to list=linterrors output
Mon, Apr 17, 5:27 PM
Legoktm merged task T163092: Linter does not handle "Multi-part-template" well into T162920: In multi-content/template-block scenarios, Linter displays "--" in the "Through a template"? column.
Mon, Apr 17, 4:21 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm merged T163092: Linter does not handle "Multi-part-template" well into T162920: In multi-content/template-block scenarios, Linter displays "--" in the "Through a template"? column.
Mon, Apr 17, 4:21 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T163092: Linter does not handle "Multi-part-template" well.

Probably a dupe yes.

Mon, Apr 17, 4:20 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T163092: Linter does not handle "Multi-part-template" well.

That's from [mediawikiwiki]> select * from linter where linter_id=107;

Mon, Apr 17, 3:23 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm created T163092: Linter does not handle "Multi-part-template" well.
Mon, Apr 17, 3:22 AM · MediaWiki-extensions-Linter, Parsoid
Legoktm created T163091: Parsoid: Add API endpoint to get lint errors for arbitrary wikitext.
Mon, Apr 17, 3:17 AM · Parsoid, MediaWiki-extensions-Linter
Legoktm renamed T153055: Support API query for list of errors for arbitrary wikitext (for pre-save checks) from "Support API query for list of errors for a given page" to "Support API query for list of errors for arbitrary wikitext (for pre-save checks)".
Mon, Apr 17, 3:10 AM · MediaWiki-extensions-Linter
Legoktm added a comment to T153055: Support API query for list of errors for arbitrary wikitext (for pre-save checks).

Ah, understood. OK, I'll rephrase the title.

Mon, Apr 17, 3:09 AM · MediaWiki-extensions-Linter

Sun, Apr 16

Legoktm edited projects for T154361: Add $wgWhitelistSpecialPages option, added: MediaWiki-Configuration; removed MediaWiki-General-or-Unknown.

Unfortunately this only works for english version pages

Sun, Apr 16, 9:28 PM · MediaWiki-Configuration
Legoktm added a comment to T148609: Review and deploy Linter extension to Wikimedia wikis.

As I mentioned on IRC, I think the huge increase in queries was caused by the inclusion in the API meta=siteinfo endpoint which in hindsight is called pretty frequently. We should consider not including it by default (another parameter) and putting it behind some caching.

Sun, Apr 16, 7:37 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm committed R1995:8302db893fef: Separate linter-numerrors bidi from rest of the line (authored by Ebraminio).
Separate linter-numerrors bidi from rest of the line
Sun, Apr 16, 7:37 AM
Legoktm committed R1995:379137df59b0: Revert "Expose category totals in API response" (authored by Legoktm).
Revert "Expose category totals in API response"
Sun, Apr 16, 7:37 AM
Legoktm added a reverting commit for R1995:45b4bf6382ad: Expose category totals in API response: R1995:379137df59b0: Revert "Expose category totals in API response".
Sun, Apr 16, 7:37 AM
Legoktm updated subscribers of T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function.

+@Anomie and @TTO since this is related to the UserGroupMembership stuff. I think I have a band-aid patch that should mitigate most of this?

Sun, Apr 16, 7:25 AM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm renamed T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function from "UserGroupMembership::insert() needs a positive user ID. Did you forget to add your User object to the database before calling addGroup()" to "UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function".
Sun, Apr 16, 7:11 AM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm triaged T163032: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function as "Unbreak Now!" priority.
Sun, Apr 16, 7:10 AM · Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Legoktm added a comment to T163042: Linter extension should provide sufficent information to locate markup it considered malformed..

Well in this case it was caused by a template: https://la.wiktionary.org/w/index.php?title=luna&type=revision&diff=169447&oldid=169438

Sun, Apr 16, 2:52 AM · MediaWiki-extensions-Linter

Sat, Apr 15

Legoktm added a comment to T148609: Review and deploy Linter extension to Wikimedia wikis.

Sorry about the trouble :/

Sat, Apr 15, 3:27 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added a comment to T161556: Implement a way to have linter reprocess all pages .

Sorry I forgot to comment here - I ended up writing a small python script to do this for now: https://git.legoktm.com/legoktm/parsoid-reparse

Sat, Apr 15, 3:15 AM · Services (watching), Parsoid, MediaWiki-extensions-Linter

Fri, Apr 14

Legoktm added a comment to T153454: Enable BotPasswords (or similar feature) for non-bot accounts.

Any account can use bot passwords? There's no limitation that restricts it only to bots.

Fri, Apr 14, 11:06 AM · MediaWiki-Authentication-and-authorization, User-Urbanecm
Legoktm merged T162893: LintErrors should have namespace selector into T162918: Different handling for lint errors in User: and other non-article namespaces.
Fri, Apr 14, 7:20 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Parsoid, MediaWiki-extensions-Linter
Legoktm merged task T162893: LintErrors should have namespace selector into T162918: Different handling for lint errors in User: and other non-article namespaces.
Fri, Apr 14, 7:20 AM · MediaWiki-extensions-Linter
Legoktm added a comment to T153055: Support API query for list of errors for arbitrary wikitext (for pre-save checks).

If we add a prop=linterrors I think that should work out the best. Then you can retrieve the current revision text plus hte errors with prop=revisions|linterrors or something.

Fri, Apr 14, 7:15 AM · MediaWiki-extensions-Linter
Legoktm closed T162898: have txt export for LintErrors as "Declined".

There's a list=linterrors API module: https://www.mediawiki.org/w/api.php?action=help&modules=query%2Blinterrors

Fri, Apr 14, 7:07 AM · MediaWiki-extensions-Linter
Legoktm committed R1995:fbff1cffff4d: Add namespace filter to Special:LintErrors (authored by Legoktm).
Add namespace filter to Special:LintErrors
Fri, Apr 14, 3:52 AM
Legoktm claimed T162918: Different handling for lint errors in User: and other non-article namespaces.

The API already had a namespace filter. I don't think we want to discard stuff in the user namespace as people might be working on drafts, etc., but having a namespace filter will make it easy for people to ignore it if they want to.

Fri, Apr 14, 3:50 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Parsoid, MediaWiki-extensions-Linter
Legoktm created T162980: Add a TOC/navigation thing to action=info.
Fri, Apr 14, 2:54 AM · Easy, MediaWiki-Interface

Thu, Apr 13

Legoktm added a comment to T162918: Different handling for lint errors in User: and other non-article namespaces.

I think the UI needs a namespace filter of some kind.

Thu, Apr 13, 4:34 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, Parsoid, MediaWiki-extensions-Linter

Wed, Apr 12

Legoktm closed T48705: Parsoid-based wikitext "linting" tool for "buggy" / "deprecated" wikitext usage; keywords: broken wikitext information as "Resolved".

The Linter extension is now deployed to all Wikimedia wikis, so the main infrastructure is in place. We've already seen 2 new lint categories be added during the rollout phase, so more checks can always be added.

Wed, Apr 12, 9:07 PM · Community-Liaisons, MediaWiki-extensions-Linter, Parsoid
Jdforrester-WMF awarded T48705: Parsoid-based wikitext "linting" tool for "buggy" / "deprecated" wikitext usage; keywords: broken wikitext information a Party Time token.
Wed, Apr 12, 9:04 PM · Community-Liaisons, MediaWiki-extensions-Linter, Parsoid
Legoktm closed T148609: Review and deploy Linter extension to Wikimedia wikis as "Resolved".

This is now deployed to all wikis.

Wed, Apr 12, 8:46 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm closed T148609: Review and deploy Linter extension to Wikimedia wikis, a subtask of T33235: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking), as "Resolved".
Wed, Apr 12, 8:46 PM · Tracking, Wikimedia-Extension-setup
Legoktm closed T148609: Review and deploy Linter extension to Wikimedia wikis, a subtask of T48705: Parsoid-based wikitext "linting" tool for "buggy" / "deprecated" wikitext usage; keywords: broken wikitext information, as "Resolved".
Wed, Apr 12, 8:46 PM · Community-Liaisons, MediaWiki-extensions-Linter, Parsoid
Legoktm closed T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors, a subtask of T148609: Review and deploy Linter extension to Wikimedia wikis, as "Resolved".
Wed, Apr 12, 8:45 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm closed T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors as "Resolved".

No more reports of delayed updates have come in since, closing as resolved.

Wed, Apr 12, 8:45 PM · MediaWiki-extensions-Linter
Legoktm closed T162605: Table 'labtestwiki.linter' doesn't exist (208.80.153.14) as "Resolved".

Thanks @bd808 .

Wed, Apr 12, 7:14 PM · User-bd808, Release-Engineering-Team, MediaWiki-extensions-Linter, Wikimedia-log-errors, Labs
Legoktm added a subtask for T157670: Changes to MediaWiki code related to parsing can leave links tables out of date: T135964: Force pages to be fully re-parsed occasionally.
Wed, Apr 12, 4:41 AM · MediaWiki-Parser, MediaWiki-Page-editing, Parsing-Team
Legoktm added a parent task for T135964: Force pages to be fully re-parsed occasionally: T157670: Changes to MediaWiki code related to parsing can leave links tables out of date.
Wed, Apr 12, 4:41 AM · MediaWiki-Database, MediaWiki-Cache, MediaWiki-Parser
Legoktm added a comment to T162751: Lift IP cap for 186.179.xxx.xx (ongoing hackathon).

There was a little lock in the top right corner and there were also no "edit..." links available.

Wed, Apr 12, 4:27 AM · Wikimedia-Site-requests

Tue, Apr 11

Legoktm added a comment to T162751: Lift IP cap for 186.179.xxx.xx (ongoing hackathon).

Also please provide the specific error message that is being seen - can they not create new accounts? Or is it editing at all? The latter would be a different issue unrelated to the IP account creation cap.

Tue, Apr 11, 10:38 PM · Wikimedia-Site-requests
Legoktm added a comment to T162751: Lift IP cap for 186.179.xxx.xx (ongoing hackathon).

What's the specific IP address that needs whitelisting?

Tue, Apr 11, 10:36 PM · Wikimedia-Site-requests
Legoktm added a comment to T161232: Should we bump minimum supported MySQL Version?.

For MariaDB, is it the same version number?

Tue, Apr 11, 9:08 PM · ArchCom-RfC, RfC, DBA, MediaWiki-Database
Legoktm added a comment to T156543: Provide Debian packages for stable MediaWiki releases.

That sounds good to me.

Tue, Apr 11, 3:49 AM · MediaWiki-Debian
Legoktm updated the image for MediaWiki-Debian from F6728012: fa-briefcase-blue.png to F7477462: profile.
Tue, Apr 11, 3:48 AM
Legoktm added a comment to T162563: Fatal error of type DBQueryError, with previous PHP Notice: Undefined offset: 1.

UserMerge is not currently being used on Wikimedia sites, so this isn't a deployment blocker.

Tue, Apr 11, 1:48 AM · Regression, MediaWiki-extensions-UserMerge
Legoktm removed a parent task for T162563: Fatal error of type DBQueryError, with previous PHP Notice: Undefined offset: 1: T160552: MW-1.29.0-wmf.20 deployment blockers.
Tue, Apr 11, 1:48 AM · Regression, MediaWiki-extensions-UserMerge
Legoktm removed a subtask for T160552: MW-1.29.0-wmf.20 deployment blockers: T162563: Fatal error of type DBQueryError, with previous PHP Notice: Undefined offset: 1.
Tue, Apr 11, 1:47 AM · Release, Release-Engineering-Team (Deployment-Blockers)

Mon, Apr 10

Legoktm created T162643: MW 1.28.1 tarball has languages/i18n/{en,qqx}.json.rej files.
Mon, Apr 10, 10:24 PM · MediaWiki-Releasing, MW-1.28-release
Legoktm added a comment to T119772: Create dashboard showing MediaWiki tarball download statistics.

To get an idea of how many people are using the MediaWiki tarballs. Additionally, this data could be used to see if people are still downloading old versions, how fast people are moving over to downloading new versions, etc.

Mon, Apr 10, 7:22 PM · Analytics, MediaWiki-Releasing
Legoktm added a comment to T162605: Table 'labtestwiki.linter' doesn't exist (208.80.153.14).

Disabling Linter there is also fine with me, I'm just not sure what the expectations for that wiki are...

Mon, Apr 10, 2:41 PM · User-bd808, Release-Engineering-Team, MediaWiki-extensions-Linter, Wikimedia-log-errors, Labs
Legoktm added a comment to T162605: Table 'labtestwiki.linter' doesn't exist (208.80.153.14).
legoktm@terbium:~$ mwscript extensions/WikimediaMaintenance/createExtensionTables.php --wiki=labtestwiki linter
[92e48de08cd9afda7d22366d] [no req]   DBConnectionError from line 757 of /srv/mediawiki/php-1.29.0-wmf.19/includes/libs/rdbms/database/Database.php: Cannot access the database: Access denied for user 'wikiadmin'@'10.64.32.13' (using password: YES) (208.80.153.14)
Backtrace:
#0 /srv/mediawiki/php-1.29.0-wmf.19/includes/libs/rdbms/loadbalancer/LoadBalancer.php(978): Database->reportConnectionError(string)
#1 /srv/mediawiki/php-1.29.0-wmf.19/includes/libs/rdbms/loadbalancer/LoadBalancer.php(649): Wikimedia\Rdbms\LoadBalancer->reportConnectionError()
#2 /srv/mediawiki/php-1.29.0-wmf.19/includes/GlobalFunctions.php(3078): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, boolean)
#3 /srv/mediawiki/php-1.29.0-wmf.19/maintenance/Maintenance.php(1250): wfGetDB(integer, array, boolean)
#4 /srv/mediawiki/php-1.29.0-wmf.19/extensions/WikimediaMaintenance/createExtensionTables.php(36): Maintenance->getDB(integer)
#5 /srv/mediawiki/php-1.29.0-wmf.19/maintenance/doMaintenance.php(111): CreateExtensionTables->execute()
#6 /srv/mediawiki/php-1.29.0-wmf.19/extensions/WikimediaMaintenance/createExtensionTables.php(149): require_once(string)
#7 /srv/mediawiki/multiversion/MWScript.php(99): require_once(string)
#8 {main}
Mon, Apr 10, 2:28 PM · User-bd808, Release-Engineering-Team, MediaWiki-extensions-Linter, Wikimedia-log-errors, Labs

Sun, Apr 9

Legoktm added a project to T162564: Linter doesn't know "frame" alias on cswiki: Parsoid.

That means Parsoid doesn't know about it for some reason :/

Sun, Apr 9, 9:37 PM · Parsoid, MediaWiki-extensions-Linter
Legoktm added a comment to T162541: Access changes for MarcoAurelio.

:(

Sun, Apr 9, 7:44 PM · Discovery, Labs, Wikimedia-Portals, Tool-Labs-tools-stewardbots, wikitech.wikimedia.org
Legoktm edited projects for T162536: Patch file for 1.28.1, added: MediaWiki-Releasing, MW-1.28-release; removed Release.
Sun, Apr 9, 2:13 AM · MW-1.28-release, MediaWiki-Releasing

Sat, Apr 8

Legoktm added a comment to T148958: Interwiki.php causes "MemcachedBagOStuff.php: Key contains invalid characters".

Maybe it needs to use ObjectCache::getMainWANInstance()->makeKey() instead of relying on the wfMemcKey which uses ObjectCache::getLocalClusterInstance()->makeKey()?

Sat, Apr 8, 4:41 AM · MW-1.27-release-notes, MediaWiki-Interwiki, Patch-For-Review, Performance-Team, MW-1.27-release, Regression

Fri, Apr 7

Legoktm added a comment to T156924: Allow integration of data from etcd into the MediaWiki configuration.
$wgConfigRegistry = function () {
    return new MultiConfig( [
        new EtcdConfig( [ ... ] ),
        new GlobalVarConfig
    ] );
};
$config = MediaWikiServices::getInstance()->getMainConfig();
$wmfMasterDatacenter = $config->get( 'wmfMasterDatacenter' );
Fri, Apr 7, 11:34 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-Platform-Team, Patch-For-Review, Wikimedia-Multiple-active-datacenters, Services (watching), Performance-Team, discovery-system, User-Joe, User-mobrovac, MediaWiki-Configuration, Operations, Wikimedia-Developer-Summit (2017)
Legoktm removed a project from T62147: *links rows get lost randomly: Parsoid-Web-API.

This doesn't have anything to do with Parsoid-Web-API ...

Fri, Apr 7, 4:20 PM · Chinese-Sites, MediaWiki-General-or-Unknown
Legoktm added a comment to T162415: Make global userpage Babel links point to Meta instead of locally. .

Please provide an example page, I'm not sure what links you're referring to.

Fri, Apr 7, 12:24 AM · GlobalUserPage, MediaWiki-extensions-Babel

Thu, Apr 6

mmodell awarded T109140: Special:UserLogin?returnto=interwiki:foo will redirect to external sites a Love token.
Thu, Apr 6, 11:01 PM · Patch-For-Review, Security, Privacy, MediaWiki-User-login-and-signup
Legoktm added a comment to T162397: array_slice() expects an array in ApiRecordLint.

Yep, right before it in the logs:

Apr  6 18:49:17 mw1192:  [Thu Apr  6 18:49:17 2017] [hphp] [18491:7fbf0b3ff700:139559:000001] [] \nNotice: Undefined index: dsr in /srv/mediawiki/php-1.29.0-wmf.18/extensions/Linter/includes/ApiRecordLint.php on line 65
Thu, Apr 6, 7:09 PM · MediaWiki-extensions-Linter, Wikimedia-log-errors
Legoktm added a comment to T162397: array_slice() expects an array in ApiRecordLint.

Hmm, I guess parsoid is sending lint errors without a 'dsr' field?

Thu, Apr 6, 7:05 PM · MediaWiki-extensions-Linter, Wikimedia-log-errors
Legoktm committed R1995:777f37a73078: Split statsd metrics by wiki (authored by Legoktm).
Split statsd metrics by wiki
Thu, Apr 6, 6:43 PM
Legoktm committed R1995:eacb3c0d0d3e: Split statsd metrics by wiki (authored by Legoktm).
Split statsd metrics by wiki
Thu, Apr 6, 6:23 PM
Legoktm closed T152664: Linter should record metrics in statsd so we can have a historical view of errors increasing/being fixed as "Resolved".
Thu, Apr 6, 6:10 PM · Patch-For-Review, MediaWiki-extensions-Linter
Legoktm reopened T162300: donation page format error as "Open".

This isn't fixed yet...there shouldn't be any reason to use <html> in system messages. The rollback is just a temporary fix.

Thu, Apr 6, 4:11 AM · Patch-For-Review, Unplanned-Sprint-Work, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog

Wed, Apr 5

Legoktm added a comment to T162300: donation page format error.

This was caused by T156184: Make rawHTML mode not apply to system messages.

Wed, Apr 5, 7:40 PM · Patch-For-Review, Unplanned-Sprint-Work, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog
Legoktm renamed T162275: Add API parameter to use RemexHTML as the tidier for action=parse from "Add API parameter to use RemexHTML as the tidier" to "Add API parameter to use RemexHTML as the tidier for action=parse".
Wed, Apr 5, 3:39 PM · MediaWiki-API, Tidy

Tue, Apr 4

Legoktm created T162191: test-requirements.txt in ci-config still points to precise deb.
Tue, Apr 4, 7:59 PM · Zuul, Technical-Debt, Continuous-Integration-Config
Legoktm created T162188: Pick/develop a PHP library for etcd to use in MediaWiki.
Tue, Apr 4, 7:37 PM · MediaWiki-Platform-Team, MediaWiki-Configuration
Legoktm added a comment to D613: Update group list.
[pid: 10417|app: 0|req: 25/141] 10.68.21.49 () {36 vars in 545 bytes} [Tue Apr  4 18:09:07 2017] GET /ldap/group/ldap_ops => generated 291 bytes in 35 msecs (HTTP/1.1 500) 
2 headers in 84 bytes (1 switches on core 0)
[2017-04-04 18:14:28,580] ERROR in app: Exception on /group/ldap_ops [GET]
Traceback (most recent call last):
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/data/project/ldap/www/python/src/app.py", line 69, in group
    members=members
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/templating.py", line 134, in render_template
    context, ctx.app)
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/flask/templating.py", line 116, in _render
    rv = template.render(context)
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/project/ldap/www/python/venv/local/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/project/ldap/www/python/src/templates/group.html", line 12, in top-level template code
    {% for member in members %}
  File "/data/project/ldap/www/python/src/app.py", line 47, in member_list
    'uid': info[0][1]['uid'][0],
KeyError: 'uid'
Tue, Apr 4, 7:29 PM
Legoktm added a comment to T162129: Someone is parsing all enwiki pages using the action api at a rate of ~2M pages/hour.

Requests do not have a user agent

Tue, Apr 4, 5:47 PM · Operations, DBA, MediaWiki-API, Traffic
Legoktm added a comment to D613: Update group list.

Hmm, https://tools.wmflabs.org/ldap/group/ldap_ops is 500. I'll have to investigate what's going wrong there.

Tue, Apr 4, 5:42 PM

Mon, Apr 3

Legoktm added a comment to T63750: Implement a proper edit preview for MediaWiki:Sidebar.

This could be implemented using a custom content model instead of treating it as wikitext.

Mon, Apr 3, 8:34 PM · WorkType-NewFunctionality, MediaWiki-General-or-Unknown
Legoktm claimed T148609: Review and deploy Linter extension to Wikimedia wikis.
Mon, Apr 3, 8:12 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added a project to T148609: Review and deploy Linter extension to Wikimedia wikis: MediaWiki-Platform-Team.
Mon, Apr 3, 8:11 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), DBA, MediaWiki-Platform-Team, User-notice, Patch-For-Review, MediaWiki-extensions-Linter, Wikimedia-Extension-setup
Legoktm added projects to T162080: Reset admin password for wikimania-program mailing list: Operations, Wikimedia-Mailing-lists.
Mon, Apr 3, 7:16 PM · Wikimedia-Mailing-lists, Operations

Sun, Apr 2

Legoktm added a comment to T161856: WikiBugs stopped reporting 2 hours, 12 minutes, 37 seconds.

Did anyone do anything? Or did it magically start working again?

Sun, Apr 2, 7:19 PM · Wikibugs

Wed, Mar 29

Legoktm edited projects for T161713: Please re-check Andrew Russel Green's access in phabricator, added: WMF-NDA-Requests; removed LDAP-Access-Requests.

Phabricator groups aren't managed in LDAP, a Phabricator admin will need to do the magic (e.g. @Aklapper)

Wed, Mar 29, 4:09 PM · WMF-NDA-Requests
Legoktm committed rEAUG063136905ce6: Initial commit (authored by Legoktm).
Initial commit
Wed, Mar 29, 4:58 AM
Legoktm committed rEAUGdb1b7c04d97a: Initial commit (authored by Legoktm).
Initial commit
Wed, Mar 29, 4:56 AM

Tue, Mar 28

Shizhao awarded T108557: Review and deploy UrlShortener extension to Wikimedia wikis a Dislike token.
Tue, Mar 28, 2:19 PM · Wikimedia-Multiple-active-datacenters, Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup

Mar 27 2017

Legoktm added a comment to T161278: Add default gadget styling to Parsoid's output.

If skins is an empty list, then it means all skins. Using formatversion=2 (https://en.wikipedia.org/w/api.php?action=query&list=gadgets&gaprop=id|metadata&formatversion=2) gives real booleans for the default field.

Mar 27 2017, 9:20 PM · Parsoid
Legoktm added a comment to T160599: Parsoid's linter doesn't know about thumbtime parameter.
mysql:wikiadmin@db1078 [testwiki]> select * from linter where linter_id=418;
+-----------+-------------+------------+--------------+------------+----------------+
| linter_id | linter_page | linter_cat | linter_start | linter_end | linter_params  |
+-----------+-------------+------------+--------------+------------+----------------+
|       418 |       94868 |          3 |            0 |         41 | {"items":[""]} |
+-----------+-------------+------------+--------------+------------+----------------+
1 row in set (0.00 sec)
Mar 27 2017, 9:15 PM · Patch-For-Review, MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T161558: Parsoid linter request failed with The "revision" parameter must be set.

For comparison, https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2017.03.27/parsoid?id=AVsRRBOlWOR5i8OuPwtp&_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-7d,mode:quick,to:now)) has oldId.

Mar 27 2017, 8:52 PM · Patch-For-Review, Parsoid, MediaWiki-extensions-Linter