Page MenuHomePhabricator

Legoktm (Legoktm)
UserAdministrator

Projects (99)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (239 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Sat, Apr 20

Legoktm added a comment to T63115: Drop URL parameter setlang.

Changing server state like this (user options) should not be possible solely using GET parameters.

Sat, Apr 20, 2:42 AM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector
Legoktm reopened T63115: Drop URL parameter setlang as "Open".
Sat, Apr 20, 2:40 AM · Performance-Team (Radar), Technical-Debt, UniversalLanguageSelector
Legoktm added a comment to T221061: Short URL Shortcuts: Whole domain components need to be predetermined, not just the sister components.

This is going to be so abused for political statements and by LTAs once they find its availability.

Sat, Apr 20, 2:39 AM · MediaWiki-extensions-ShortUrl

Wed, Apr 17

Legoktm added a comment to T221279: patch-coverage HTML report is missing details of new file coverage.

Relevant code is https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/phpunit-patch-coverage/+/master/src/HtmlReport.php#51

Wed, Apr 17, 10:12 PM · phpunit-patch-coverage

Tue, Apr 16

Legoktm added a comment to T141832: MediaWiki message delivery should respect 'bot' flags.

Since they are explicitly not marked as minor, why would flagging them as bot edits at the village pump cause people not to see them?

Tue, Apr 16, 5:01 AM · Patch-For-Review, User-DannyS712, MassMessage
Legoktm added a comment to T141832: MediaWiki message delivery should respect 'bot' flags.

Um, this is mostly intentional. We *want* people to see new messages posted on the village pump, etc.

Tue, Apr 16, 4:51 AM · Patch-For-Review, User-DannyS712, MassMessage

Mon, Apr 15

Legoktm added a comment to T187045: Decide on future of Extension:ShortUrl on Wikimedia Wikis.

Can we just deprecate ShortUrl in favor of UrlShotener?

Sounds good to me, but what do we do about Cool URIs don't change?

Mon, Apr 15, 9:44 PM · Code-Stewardship-Reviews, MediaWiki-extensions-ShortUrl
Legoktm created T220996: Deprecate and remove ExtensionRegistry::load().
Mon, Apr 15, 3:09 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-D3r1ck01, Technical-Debt (Deprecation), Patch-For-Review, good first bug, MW-1.34-release, MediaWiki-Configuration
Legoktm created T220994: Add ExtensionRegistry::getLazyLoadedAttribute().
Mon, Apr 15, 3:07 PM · Performance-Team (Radar), MediaWiki-Configuration
Legoktm added a comment to T220986: [Regression] Increase in APCBagOStuff::get cost.

Would an increase in the size of stuff being stored in APC by the ExtensionRegistry be related? rMWd1666a89fff6: resourceloader: Support TestModules registration via extension.json probably caused extension.json stuffs to get even bigger. We currently don't optimize what we store at all (there's definitely some low hanging fruit).

Mon, Apr 15, 2:33 PM · MediaWiki-Cache, Performance-Team
Legoktm added a comment to T220424: XmlDUmpWriter::writeRevision sometimes broken by duplicate keys in Link Cache.

one page is Commons:Deletion_requests/Files_uploaded_by_Nabila.selim in the main namespace (0),

Mon, Apr 15, 4:50 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-Export-or-Import, Dumps-Generation
Legoktm added a comment to T220928: ShortUrl: code stewardship review.

Somewhat of a dupe of T187045: Decide on future of Extension:ShortUrl on Wikimedia Wikis. I think the main open question is a technical one, do we a) add a read only mode to ShortUrl, and keep it deployed forever, or b) move the logic for short url into UrlShortener, so we only have one thing deployed and routing stuff.

Mon, Apr 15, 12:35 AM · MediaWiki-extensions-ShortUrl, Code-Stewardship-Reviews

Sun, Apr 14

Legoktm added a comment to T220190: Make UrlShortener 404s cacheable.

Should we have a CDN purge when we create new short codes just in case the 404 was cached?

Sun, Apr 14, 8:53 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Traffic, User-Ladsgroup, Operations, MediaWiki-extensions-UrlShortener
Legoktm added a comment to T220190: Make UrlShortener 404s cacheable.

@Ladsgroup is there anything else left to do here?

Sun, Apr 14, 8:51 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Traffic, User-Ladsgroup, Operations, MediaWiki-extensions-UrlShortener
Legoktm added a comment to T220923: URL Shortener Should Not Mystery Meat Important Links.

"Should" and "Does" are two different things, though. The fact that something as basic as "Logout" has this flaw does not inspire me with confidence that other, more important things are not broken.

Sun, Apr 14, 8:48 PM · MediaWiki-extensions-UrlShortener
Legoktm updated subscribers of T25227: Use token when logging out.
Sun, Apr 14, 8:42 PM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Legoktm added a comment to T220923: URL Shortener Should Not Mystery Meat Important Links.

There's probably a LOT of action urls that should be blacklisted. A trap would be someone creates a link that executes an action that has higher privileges and tricks a sysop into clicking it, etc.

Sun, Apr 14, 8:28 PM · MediaWiki-extensions-UrlShortener
Legoktm merged Restricted Task into T25227: Use token when logging out.
Sun, Apr 14, 8:18 PM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Legoktm added a comment to T25227: Use token when logging out.

Related: T220923: URL Shortener Should Not Mystery Meat Important Links.

Sun, Apr 14, 8:17 PM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Legoktm added a comment to T220920: apc.enable_cli should be enabled in PHP jobs.

IIRC apc has a history of causing weird bugs in CI with stuff not being invalidated properly. I don't know of those bugs still exist, but if you want a persistent cache to test with, you should use HashBagOStuff.

Sun, Apr 14, 7:34 PM · Continuous-Integration-Config
Legoktm added a comment to T193824: Determine a standard way of installing MediaWiki lib/extension dependencies within containers.

In general I think that's a good idea. Two things I think we'll need to do:

Sun, Apr 14, 10:14 AM · Core Platform Team Kanban (Contractor - Doing), Core Platform Team (Extension Management (TEC13)), Patch-For-Review, Release-Engineering-Team (Kanban), Release Pipeline
Legoktm added a comment to T108602: Equivalent URLs are not canonicalized and deduplicated.

We should already be deduplicating HTTPS/HTTP.

Sun, Apr 14, 8:34 AM · MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), Patch-For-Review, MediaWiki-extensions-UrlShortener
Legoktm merged T108565: Shortening only a domain without a trailing slash fails into T220718: URLs with no slashes after domain name are "invalid" but are still shortened.
Sun, Apr 14, 8:33 AM · MediaWiki-extensions-UrlShortener
Legoktm merged task T108565: Shortening only a domain without a trailing slash fails into T220718: URLs with no slashes after domain name are "invalid" but are still shortened.
Sun, Apr 14, 8:33 AM · MediaWiki-extensions-UrlShortener
Legoktm closed T219986: Shortened URLs won't redirect when there's data as Resolved.
Sun, Apr 14, 8:32 AM · User-Ladsgroup, Patch-For-Review, Operations, Traffic, MediaWiki-extensions-UrlShortener

Fri, Apr 12

Legoktm added a project to T220836: Guidelines for Rust/Go tools deployment: Packaging.
Fri, Apr 12, 8:12 PM · Packaging, serviceops
Niedzielski awarded T179361: Move MobileFrontend/Minerva's svg_check.sh script into a reusable, separate library a Love token.
Fri, Apr 12, 5:29 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), User-Jdlrobson, Release-Engineering-Team (Watching / External), MinervaNeue, Librarization
Legoktm added a comment to T220703: Increase the max length of URL to be shortened.

This is not enough for some Wikidata queries that main contain up to 4000 characters. My suggestion is to increase the limit to 10K and see if there are some use cases of longer URLs.

Fri, Apr 12, 5:25 PM · Security, Wikimedia-Site-requests, MediaWiki-extensions-UrlShortener
Legoktm added a comment to T220759: Provide an alternative to wgExtensionMessagesFiles for non-message i18n.

https://www.mediawiki.org/wiki/Requests_for_comment/Move_i18n_data_into_JSON

Fri, Apr 12, 12:13 AM · MediaWiki-Internationalization, Technical-Debt, MediaWiki-Configuration

Thu, Apr 11

Jc86035 awarded T108557: Review and deploy UrlShortener extension to Wikimedia wikis a Like token.
Thu, Apr 11, 2:20 PM · User-notice, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ladsgroup, Availability (MediaWiki-MultiDC), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup
Legoktm renamed T220662: Beta cluster: MassMessage fails with PHP fatal error because of Declaration of JobQueueEventBus::doAck() must be compatible with that of JobQueue::doAck() from Beta cluster: MassMessage fails with PHP fatal error to Beta cluster: MassMessage fails with PHP fatal error because of Declaration of JobQueueEventBus::doAck() must be compatible with that of JobQueue::doAck().
Thu, Apr 11, 12:32 AM · WMF-JobQueue, MediaWiki-JobQueue, Analytics, EventBus, Beta-Cluster-reproducible, User-DannyS712
Legoktm added a comment to T220589: Support phan in MediaWiki's default composer.json.

Because phan requires PHP >=7.0 (other dev deps require >=5.6.99) and until recently also required specific versions of php-ast, which would have make composer install really inconvenient for a lot of people.

Thu, Apr 11, 12:13 AM · MediaWiki-Core-Testing, MediaWiki-General-or-Unknown

Wed, Apr 10

Legoktm added projects to T220662: Beta cluster: MassMessage fails with PHP fatal error because of Declaration of JobQueueEventBus::doAck() must be compatible with that of JobQueue::doAck(): MediaWiki-JobQueue, WMF-JobQueue.
Wed, Apr 10, 11:58 PM · WMF-JobQueue, MediaWiki-JobQueue, Analytics, EventBus, Beta-Cluster-reproducible, User-DannyS712
Legoktm triaged T220662: Beta cluster: MassMessage fails with PHP fatal error because of Declaration of JobQueueEventBus::doAck() must be compatible with that of JobQueue::doAck() as Unbreak Now! priority.

I haven't verified myself, but if this is an issue, it's UBN.

Wed, Apr 10, 11:58 PM · WMF-JobQueue, MediaWiki-JobQueue, Analytics, EventBus, Beta-Cluster-reproducible, User-DannyS712

Tue, Apr 9

Legoktm added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

@Daimona - @Bawolff and I created a 2.0.0 branch from master just now for development of new versions of the SecurityCheckPlugin that leverage PluginV2 and newer versions of PHP and Phan.

Tue, Apr 9, 9:53 PM · Patch-For-Review, phan-taint-check-plugin
Legoktm added a comment to T220432: Clean up "easter egg" short URLs before extension goes live.

I'm going to defer to @Ladsgroup since he's taken over the main deployment, but I do think we went a bit overboard on the easter eggs. My initial plan was to have no more than 10 joke/easter egg style ones, and then allocate "b" -> wikibooks, "c" -> commons, etc.

Tue, Apr 9, 4:47 PM · MediaWiki-extensions-UrlShortener
TheDJ awarded T116986: Set up UrlShortener dumps a Love token.
Tue, Apr 9, 11:59 AM · Datasets-Archiving, Patch-For-Review, Datasets-General-or-Unknown, MediaWiki-extensions-UrlShortener
Legoktm added a comment to T108557: Review and deploy UrlShortener extension to Wikimedia wikis.

Should we ping archive.org to make sure they are properly archived into perpetuity like all the bit.ly links etc are these days ?

Tue, Apr 9, 7:53 AM · User-notice, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ladsgroup, Availability (MediaWiki-MultiDC), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup

Mon, Apr 8

Legoktm added a comment to T193330: What to do with the Angry Cat.

I always thought the cat was paying homage to MonoBook's book.

Mon, Apr 8, 3:47 AM · Timeless

Sun, Apr 7

Legoktm added a comment to T220313: Is MWMessagePack unused and/or worth keeping around?.

The only use I found via grepping git log was in ProfilerMwprof (rMWc5e6ce0f9e4d: Add ProfilerMwprof), which was removed in rMWefd2fcc575a0: Remove ProfileMwprof.

Sun, Apr 7, 11:14 PM · User-D3r1ck01, Patch-For-Review, Technical-Debt, MediaWiki-General-or-Unknown
Legoktm created T220313: Is MWMessagePack unused and/or worth keeping around?.
Sun, Apr 7, 11:04 PM · User-D3r1ck01, Patch-For-Review, Technical-Debt, MediaWiki-General-or-Unknown

Sat, Apr 6

Legoktm added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

And filed https://github.com/symfony/symfony/issues/30877 with symfony.

Sat, Apr 6, 5:57 AM · Patch-For-Review, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
Mill <mill@mail.com> committed rEMWV865abaecdff5: s4baaaaaaaaaaa (authored by Legoktm).
s4baaaaaaaaaaa
Sat, Apr 6, 1:59 AM
Legoktm added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

OK, I haven't seen any OOMs after deploying that change. I also submitted https://github.com/phan/phan/pull/2634 ("Avoid repeatedly calculating the terminal's width") upstream based on hashar's analysis.

Sat, Apr 6, 1:28 AM · Patch-For-Review, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
Mill <mill@mail.com> committed rESLF20359e292013: %5eobaaaaaaaaaaa (authored by Legoktm).
%5eobaaaaaaaaaaa
Sat, Apr 6, 12:48 AM

Fri, Apr 5

Legoktm added a project to T218750: Re-enable use of Gerrit HTTP token to push patchsets: VPS-project-libraryupgrader.
Fri, Apr 5, 11:20 PM · VPS-project-libraryupgrader, Release-Engineering-Team, Gerrit
Mill <mill@mail.com> committed rICMV8c59f8acf14d: g5baaaaaaaaaaa (authored by Legoktm).
g5baaaaaaaaaaa
Fri, Apr 5, 11:13 PM
Mill <mill@mail.com> committed rEPTGc85f4238f699: %2ambaaaaaaaaaaa (authored by Legoktm).
%2ambaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rEPTG219f7d837bb0: qmbaaaaaaaaaaa (authored by Legoktm).
qmbaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rEPTG2079a24d5747: !mbaaaaaaaaaaa (authored by Legoktm).
!mbaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rEPTGa29286fb8019: )mbaaaaaaaaaaa (authored by Legoktm).
)mbaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rEPTGb19e35037d76: pmbaaaaaaaaaaa (authored by Legoktm).
pmbaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rEPTGf9882b7782de: (mbaaaaaaaaaaa (authored by Legoktm).
(mbaaaaaaaaaaa
Fri, Apr 5, 11:07 PM
Mill <mill@mail.com> committed rELINTe54d633ad91e: grbaaaaaaaaaaa (authored by Legoktm).
grbaaaaaaaaaaa
Fri, Apr 5, 10:42 PM
Mill <mill@mail.com> committed rELINTd895feb95b00: ewbaaaaaaaaaaa (authored by Legoktm).
ewbaaaaaaaaaaa
Fri, Apr 5, 10:42 PM
Mill <mill@mail.com> committed rELINTee98d5159f02: !1baaaaaaaaaaa (authored by Legoktm).
!1baaaaaaaaaaa
Fri, Apr 5, 10:42 PM
Mill <mill@mail.com> committed rQUIBBLE78fcc19e6212: %5etbaaaaaaaaaaa (authored by Legoktm).
%5etbaaaaaaaaaaa
Fri, Apr 5, 10:32 PM
Mill <mill@mail.com> committed rQUIBBLEf262bdc867b9: dpbaaaaaaaaaaa (authored by Legoktm).
dpbaaaaaaaaaaa
Fri, Apr 5, 10:32 PM
Legoktm added a comment to T203069: Deploy wikidiff2 v1.8.1 with changed signature.

@Legoktm How shall we handle the PHP update of wikidiff2 now that buster is frozen, maybe upload 1.8.1 to experimental and I'll rebuild this in component/php72 fo deployment to production?

Sure, I can do that.

Fri, Apr 5, 9:12 PM · Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, WMDE-QWERTY-Sprint-2019-03-06, WMDE-QWERTY-Sprint-2019-01-23, WMDE-QWERTY-Sprint-2019-01-10, WMDE-QWERTY-Sprint-2018-08-29, wikidiff2, MediaWiki-History-and-Diffs, TCB-Team
Legoktm closed T220151: Add CI checks to tool-ldap as Resolved.

Thanks!

Fri, Apr 5, 8:24 AM · Patch-For-Review, Tool-ldap, Continuous-Integration-Config
Legoktm placed T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access) up for grabs.
Fri, Apr 5, 8:03 AM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests
Legoktm added a comment to T203069: Deploy wikidiff2 v1.8.1 with changed signature.

@Legoktm How shall we handle the PHP update of wikidiff2 now that buster is frozen, maybe upload 1.8.1 to experimental and I'll rebuild this in component/php72 fo deployment to production?

Fri, Apr 5, 7:42 AM · Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, WMDE-QWERTY-Sprint-2019-03-06, WMDE-QWERTY-Sprint-2019-01-23, WMDE-QWERTY-Sprint-2019-01-10, WMDE-QWERTY-Sprint-2018-08-29, wikidiff2, MediaWiki-History-and-Diffs, TCB-Team
Legoktm added a comment to T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access).

The right answer here is to add Kunal to the Gerrit-Mangers group, I believe. Correct, @hashar ?

Fri, Apr 5, 7:14 AM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests
Legoktm added a watcher for Tool-ldap: Legoktm.
Fri, Apr 5, 5:15 AM

Thu, Apr 4

Legoktm added a comment to T219873: Create a suite of end-to-end API test for MediaWiki core.

My previous attempt at this: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/307913

Thu, Apr 4, 5:43 AM · MediaWiki-General-or-Unknown, Code-Health, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), Epic

Mon, Apr 1

Legoktm added a comment to T218135: +2 in mediawiki/* for WMDE engineers.

Also, to have a clarity, I wanted to ask how to proceed with user Jeroen De Dauw. Whle @Legoktm did a right thing above, I need to ask who is going to decide on whether this user is permitted to be added to wmde-mediawiki group?

Mon, Apr 1, 11:34 PM · MediaWiki-Gerrit-Group-Requests
Legoktm added a comment to T219703: Move `tool-ldap` from Differential to Gerrit.
tools.ldap@tools-sgebastion-07:~/www/python/src$ git remote -v
origin	https://phabricator.wikimedia.org/source/tool-ldap.git (fetch)
origin	https://phabricator.wikimedia.org/source/tool-ldap.git (push)
tools.ldap@tools-sgebastion-07:~/www/python/src$ git remote set-url origin https://gerrit.wikimedia.org/r/labs/tools/ldap
tools.ldap@tools-sgebastion-07:~/www/python/src$ git remote -v
origin	https://gerrit.wikimedia.org/r/labs/tools/ldap (fetch)
origin	https://gerrit.wikimedia.org/r/labs/tools/ldap (push)
tools.ldap@tools-sgebastion-07:~/www/python/src$ git pull
remote: Counting objects: 4, done
remote: Finding sources: 100% (3/3)
remote: Getting sizes: 100% (3/3)
remote: Compressing objects: 100% (290/290)
remote: Total 3 (delta 1), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
From https://gerrit.wikimedia.org/r/labs/tools/ldap
   d797c2b..30de8d5  master     -> origin/master
Updating d797c2b..30de8d5
Fast-forward
 .gitreview | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .gitreview
Mon, Apr 1, 10:15 PM · Tool-ldap, User-MarcoAurelio
Legoktm closed D1146: app: list new `gerritadmin` LDAP group.
Mon, Apr 1, 9:34 PM · Tool-ldap
Legoktm accepted D1146: app: list new `gerritadmin` LDAP group.

Pushed and deployed.

Mon, Apr 1, 9:34 PM · Tool-ldap
Legoktm committed rTLDAPd797c2ba316a: Add 'gerritadmin' to list of LDAP groups (authored by MarcoAurelio).
Add 'gerritadmin' to list of LDAP groups
Mon, Apr 1, 9:04 PM
Legoktm added a comment to T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access).

Is there anything SRE needs to do here or are we waiting for the T219012 discussion to reach a consensus?

Mon, Apr 1, 8:50 PM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests
Legoktm added a comment to T219703: Move `tool-ldap` from Differential to Gerrit.

Please. It would be nice if all of my tools could be moved en-masse. I suppose it would be worthwhile to script it?

Mon, Apr 1, 8:39 PM · Tool-ldap, User-MarcoAurelio
Legoktm added a comment to D1146: app: list new `gerritadmin` LDAP group.

I don't have arcanist set up anymore, can you email me or pastebin this as a .patch file? git format-patch HEAD~1 should do it. IIRC the suggested "Patch without arc" doesn't retain authorship information.

Mon, Apr 1, 8:37 PM · Tool-ldap
Legoktm added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

Disabling phan isn't an option due to the amount of issues it regularly catches. Worst case we can revert the upgrade but that's going to be tricky....

Mon, Apr 1, 8:34 PM · Patch-For-Review, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan

Fri, Mar 29

Legoktm committed rTWDE2603d1199225: Fix path to dblists (authored by Legoktm).
Fix path to dblists
Fri, Mar 29, 1:57 AM
Legoktm closed T219555: 500 error on self closing tag report as Resolved.
commit 2603d119922583d92f0392df9c1ddb9c57ac1562 (HEAD -> master, origin/master, origin/HEAD)
Author: Kunal Mehta <legoktm@member.fsf.org>
Date:   Thu Mar 28 18:50:15 2019 -0700
Fri, Mar 29, 1:52 AM · Tools

Thu, Mar 28

Legoktm added a comment to T219248: Codesearch index for operations/puppet may be outdated.

So when I set this up in January, I assumed hound would do the git pulls by itself. I guess it doesn't, and we need a cronjob to do so. Pulled it manually for now.

Thu, Mar 28, 8:14 AM · VPS-project-codesearch
Legoktm closed T216941: Upgrade SecurePoll extension to use newer phan as Resolved.
Thu, Mar 28, 8:00 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, phan, MediaWiki-extensions-SecurePoll

Wed, Mar 27

Legoktm added a comment to T219051: whois tool: 500 - Internal Server Error.

For the record, the problem seems to have been resolved before I do anything. Ideally I'd like to know the reason in order to prevent similar issues in future, but I'm not really sure.

Wed, Mar 27, 6:12 AM · Tools

Tue, Mar 26

Legoktm renamed T219219: Please add libgnutls-dev to toolforge from Please add libgnutls-dev to Please add libgnutls-dev to toolforge.
Tue, Mar 26, 8:13 AM · Toolforge (Software install/update)

Mon, Mar 25

Legoktm reopened T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access) as "Open".

This is not a duplicate of T219012.

Mon, Mar 25, 3:47 PM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests
Legoktm committed R2061:f0fedf46a5bc: Switch to pymysql (authored by Legoktm).
Switch to pymysql
Mon, Mar 25, 8:06 AM
Legoktm created T219114: phan 1.2.6 is OOMing on MediaWiki core.
Mon, Mar 25, 5:43 AM · Patch-For-Review, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan

Sun, Mar 24

Legoktm committed rLLUP8f39e194172c: Normalize <exclude name="Foo"></exclude> (authored by Legoktm).
Normalize <exclude name="Foo"></exclude>
Sun, Mar 24, 10:19 PM
D3r1ck01 awarded T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access) a Like token.
Sun, Mar 24, 7:54 PM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests
Legoktm added a project to T152478: Doxygen method docs are not inherited (only when abstract classes are involved?): Upstream.
Sun, Mar 24, 3:40 AM · Upstream, Documentation, MediaWiki-Documentation
Legoktm added a project to T219001: Doxygen doesn't handle `@inheritDoc` by default, only `@inheritdoc`: Upstream.

Filed an issue upstream for #3: https://github.com/doxygen/doxygen/issues/6900

Sun, Mar 24, 3:39 AM · Upstream, Patch-For-Review, MediaWiki-Codesniffer, Documentation, MediaWiki-Documentation
Legoktm added a comment to T218170: Review removal of ukwikimedia wiki.

AIUI the wiki was never formally deleted (just closed), the domain was redirected and the wiki continued to exist until these errors started cropping up and people began cleaning it up one by one.

Sun, Mar 24, 3:30 AM · Release-Engineering-Team (Backlog), Deployments
Legoktm added a comment to T218686: Create Gerrit Administrator right policy.

We need a dedicated policy. Granting Gerrit administrative rights is a lot more responsibilities and require a lot of trust. It is the same level as granting rights to the puppet repository.

Sun, Mar 24, 3:25 AM · Operations, Release-Engineering-Team, Gerrit
Legoktm added a comment to T218135: +2 in mediawiki/* for WMDE engineers.

Thanks @daniel. So I created a wmde-mediawiki group (https://gerrit.wikimedia.org/r/admin/groups/1597) with everyone listed except for Jeroen. But... due to recent permissions shuffles I can't actually grant the proper rights (T219086), so stay tuned...

Sun, Mar 24, 3:22 AM · MediaWiki-Gerrit-Group-Requests
Legoktm created T219086: Add legoktm to gerritadmin LDAP group (restoring previously held access).
Sun, Mar 24, 3:18 AM · Release-Engineering-Team (Kanban), User-greg, LDAP-Access-Requests

Sat, Mar 23

Legoktm committed rEIWSae99cd45da67: Remove empty tests/phan directory (authored by Legoktm).
Remove empty tests/phan directory
Sat, Mar 23, 10:52 PM
Legoktm committed rECOG6d8c5b8e7cdd: Remove empty tests/phan directory (authored by Legoktm).
Remove empty tests/phan directory
Sat, Mar 23, 10:38 PM
Legoktm committed rEFLIfa0b6190eab8: Remove empty phan stubs directory (authored by Legoktm).
Remove empty phan stubs directory
Sat, Mar 23, 10:38 PM
Legoktm committed rERSLc7c406f3e24f: Remove empty tests/phan directory (authored by Legoktm).
Remove empty tests/phan directory
Sat, Mar 23, 10:37 PM

Mar 23 2019

Legoktm closed T217479: mwext-php70-phan-docker doesn't use composer cache as Resolved.

\o/

Mar 23 2019, 3:45 AM · Patch-For-Review, phan, Continuous-Integration-Infrastructure

Mar 22 2019

Legoktm claimed T218324: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null".
Mar 22 2019, 8:06 PM · Patch-For-Review, MediaWiki-Codesniffer
Legoktm added a comment to T218816: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants null even if type is nullable.

?string and string|null mean the same thing, I suppose the question is which of those we want in the docs.

Mar 22 2019, 7:59 PM · MediaWiki-Codesniffer

Mar 21 2019

Legoktm committed rEWETef1112763d92: build: Updating mediawiki/mediawiki-phan-config to 0.5.0 (authored by Legoktm).
build: Updating mediawiki/mediawiki-phan-config to 0.5.0
Mar 21 2019, 10:16 PM
Legoktm committed rEASRe93ef38e010a: Add phan (authored by Legoktm).
Add phan
Mar 21 2019, 9:46 PM