Page MenuHomePhabricator

Legoktm (Legoktm)
UserAdministrator

Projects (101)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:30 PM (272 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Yesterday

Legoktm added a comment to T240567: luasandbox on Debian Buster pulls in some default php7.3 packages though PHP 7.4 is installed from a DPA.

Further, I note that the dependencies on the Debian package are correct: the package distributed by Debian contains a version of LuaSandbox compiled for use with the version of PHP distributed by Debian, and depends on that PHP version. It does not contain a version of LuaSandbox compiled for use with a version of PHP not (yet) distributed by Debian, and so does not depend on that PHP version that Debian does not (yet) distribute.

Thu, Dec 12, 6:55 PM · LuaSandbox, User-MacFan4000, PHP 7.4 support
Legoktm added a comment to T187154: Performance regression from ExtensionRegistry::loadFromQueue on PHP7.

I don't really have a good understanding of how HHVM and PHP7 APC caches differ, and what makes the PHP7 version slower enough that it is causing a perf regression. It would be helpful to know if we make the size of the array that we're caching smaller, will that speed up apcu_fetch?

Thu, Dec 12, 9:09 AM · Core Platform Team Workboards (Clinic Duty Team), PHP 7.2 support, Release-Engineering-Team-TODO, Performance-Team (Radar)
Legoktm closed T189059: Find out if there's a plan to get rid of using globals in PHP code as Resolved.

I'm going to mark this as resolved, because the title of the task ("Find out if there's a plan") has been answered in T189059#4033153 with no follow-up questions. If more details are needed, please re-open.

Thu, Dec 12, 9:01 AM · Release-Engineering-Team (Code Health), Release-Engineering-Team-TODO, Wikimedia-Incident, MediaWiki-Configuration
Legoktm renamed T206949: ExtensionProcessor::storeToArray() should respect merge strategies instead of using array_merge_recursive unconditionally from Where do we merge non-config globals between extensions? to ExtensionProcessor::storeToArray() should respect merge strategies instead of using array_merge_recursive unconditionally.
Thu, Dec 12, 8:58 AM · MediaWiki-Configuration
Legoktm triaged T206949: ExtensionProcessor::storeToArray() should respect merge strategies instead of using array_merge_recursive unconditionally as Lowest priority.

So I think there's technically a problem, but it's not a problem in practice (though its a nasty trap we should fix).

Thu, Dec 12, 8:58 AM · MediaWiki-Configuration
Legoktm created T240535: Clean up ExtensionRegistry autoloading mess.
Thu, Dec 12, 8:54 AM · Technical-Debt, MediaWiki-Core-Testing, MediaWiki-Configuration
Legoktm added a comment to T226462: ExtensionFunctions defined in wmf-config are run after extensions' own ExtensionFunctions.

Order of extension functions (and other registry stuff) isn't guaranteed. If they need to run in a specific order, we need to figure out a different solution.

Thu, Dec 12, 8:43 AM · Wikimedia-General-or-Unknown, MediaWiki-Configuration
Legoktm changed the status of T229098: AutoloadNamespaces and AutoloadClasses seems to be ignored in extension.json from Open to Stalled.

Please provide the actual code (a zip file or git repository link) to reproduce with. This functionality works across hundreds of MW extensions with no issues, so I suspect the issue is more likely in your extension.

Thu, Dec 12, 8:39 AM · MediaWiki-Configuration
Legoktm committed rLCSH8fcb2805d444: Add FIXME to handle phabricator.nichework.com URLs (authored by Legoktm).
Add FIXME to handle phabricator.nichework.com URLs
Thu, Dec 12, 2:34 AM
Legoktm committed rLCSHba703e83a21b: Index master of special_extensions aka CentralNotice (authored by Legoktm).
Index master of special_extensions aka CentralNotice
Thu, Dec 12, 2:34 AM
Legoktm created T240521: Archive the mediawiki/debian git repository.
Thu, Dec 12, 2:04 AM · MediaWiki-Debian, GitHub-Mirrors, Repository-Admins, Cleanup
Legoktm added a comment to T225028: CentralNotice missing from "Deployed" preset on Codesearch.

How's that?

Thu, Dec 12, 1:15 AM · Patch-For-Review, VPS-project-codesearch
Legoktm added a comment to T239466: Possible to circumvent title-blacklist (CVE-2019-19709).

Do we know what MediaWiki version this was introduced in?

Thu, Dec 12, 12:47 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security

Wed, Dec 11

Jdforrester-WMF awarded T220994: Add ExtensionRegistry::getLazyLoadedAttribute() a Like token.
Wed, Dec 11, 9:54 PM · Patch-For-Review, Core Platform Team, Performance-Team (Radar), MediaWiki-Configuration
Legoktm added a comment to T225028: CentralNotice missing from "Deployed" preset on Codesearch.

Indexing wmf_deploy is blocked on https://github.com/hound-search/hound/issues/9 / https://github.com/hound-search/hound/pull/275 upstream. If we want to just index master, that should be straightforward.

Wed, Dec 11, 9:54 PM · Patch-For-Review, VPS-project-codesearch
Legoktm merged T240508: CentralNotice is missing from the "deployed" code search results into T225028: CentralNotice missing from "Deployed" preset on Codesearch.
Wed, Dec 11, 9:51 PM · Patch-For-Review, VPS-project-codesearch
Legoktm merged task T240508: CentralNotice is missing from the "deployed" code search results into T225028: CentralNotice missing from "Deployed" preset on Codesearch.
Wed, Dec 11, 9:51 PM · VPS-project-codesearch

Tue, Dec 10

Legoktm closed T231518: Add *.wmflabs.org to w.wiki shortener as Declined.

As I said in the recently-merged ticket:
"If the whole tools subdomain cannot be whitelisted, there should be a whitelist on a tool-by-tool basis"

Tue, Dec 10, 8:28 PM · Wikimedia-Site-requests, Security-Team, MediaWiki-extensions-UrlShortener

Mon, Dec 2

Legoktm added a comment to T239642: We need to run tests on the PHP code in the deploy repo.

IIRC we should be able to use a job like mediawiki/vendor which uses the existing dependencies, and adds the development dependencies on top. I forgot how exactly that's implemented now and whether it's quibble specific.

Mon, Dec 2, 8:46 PM · Parsoid-PHP

Wed, Nov 27

Legoktm added a comment to T236963: Deploy version 1.10.0 of wikidiff2 to production.

@tstarling is the gpg key that you used to sign that release available anywhere? https://www.mediawiki.org/keys/keys.txt still has your old ones. I'm currently not able to verify the release to update it in Debian.

Wed, Nov 27, 6:02 AM · serviceops, Operations, wikidiff2, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Sun, Nov 24

Legoktm changed the status of T239005: SLF bot should have +2 right and automaticly merge own patches from Open to Stalled.

This is currently on purpose. The following things would need to be resolved for me to feel comfortable enabling automatic +2 for SLF:

Sun, Nov 24, 7:07 AM · Gerrit-Privilege-Requests, MediaWiki-extensions-SecureLinkFixer

Fri, Nov 22

Krinkle awarded T177159: Avoid indexing of local "copies" of the central user page a Orange Medal token.
Fri, Nov 22, 9:01 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), GlobalUserPage

Sat, Nov 16

Legoktm added a comment to T237931: Running update.php on freshly installed MW 1.31.5 with PostgreSQL fails: Error: 42703 ERROR: column "adsrc" does not exist.

Thank you Reedy <3

Sat, Nov 16, 7:26 AM · MW-1.31-release-notes, MW-1.31-release, MediaWiki-Debian, PostgreSQL, MediaWiki-Installer

Fri, Nov 15

Amire80 awarded T209310: Consider implementing Module:No globals / Log globals in Scribunto itself a Like token.
Fri, Nov 15, 3:44 PM · MediaWiki-extensions-Scribunto
Legoktm claimed T216864: uprightdiff fails to build with opencv 4.

Found it, was missing a -lopencv_imgcodecs. Proper patch coming soon.

Fri, Nov 15, 3:29 AM · Patch-For-Review, uprightdiff

Nov 11 2019

Legoktm created T237931: Running update.php on freshly installed MW 1.31.5 with PostgreSQL fails: Error: 42703 ERROR: column "adsrc" does not exist.
Nov 11 2019, 10:27 AM · MW-1.31-release-notes, MW-1.31-release, MediaWiki-Debian, PostgreSQL, MediaWiki-Installer
Legoktm added a comment to T237923: mwcore-phpunit-coverage-patch runs against old MW code.

This is one of the edge cases where phpunit-patch-coverage won't work. The standard workflow is to install PHPUnit, run coverage, then checkout the previous commit, run coverage again, and diff the result. We only install PHPUnit at the first step because installing it a second time (for a potentially different version) isn't needed 99% of the time.

Nov 11 2019, 9:14 AM · Release-Engineering-Team-TODO, Test-Coverage, phpunit-patch-coverage, Quibble
Legoktm raised the priority of T216864: uprightdiff fails to build with opencv 4 from Low to High.
Nov 11 2019, 4:50 AM · Patch-For-Review, uprightdiff
Legoktm added a comment to T216864: uprightdiff fails to build with opencv 4.

After fiddling around with autoconf/automake to find opencv4:

Nov 11 2019, 4:43 AM · Patch-For-Review, uprightdiff

Oct 21 2019

Legoktm added a comment to T235113: Upgrade PHPCS to 28.0.0 in all repos.

And also, please upgrade wikibase/wikibase-codesniffer to 1.0.0, which brings in the 28.0.0 version of mw-codesniffer.

Oct 21 2019, 7:21 PM · LibUp, MediaWiki-Codesniffer

Oct 20 2019

Legoktm committed R2145:f5854a976433: Use PHP 7.2 (authored by Legoktm).
Use PHP 7.2
Oct 20 2019, 6:41 PM
Legoktm committed R2145:4bb1a82abe9c: Move date_log_dir into utils.py (authored by Legoktm).
Move date_log_dir into utils.py
Oct 20 2019, 6:41 PM
Legoktm committed R2145:bab6dda31ebf: Use integration/composer instead of packaged version (authored by Legoktm).
Use integration/composer instead of packaged version
Oct 20 2019, 6:41 PM
Legoktm committed R2145:cb78b707cf38: Start checking PHP dependencies for security issues too (authored by Legoktm).
Start checking PHP dependencies for security issues too
Oct 20 2019, 6:41 PM
Legoktm committed R2145:c46abaa47b33: Automatically disable failing stylelint rules on upgrade (authored by Legoktm).
Automatically disable failing stylelint rules on upgrade
Oct 20 2019, 6:41 PM
Legoktm committed R2145:1002b7eee94c: run: Cleanup deleted/archived repositories (authored by Legoktm).
run: Cleanup deleted/archived repositories
Oct 20 2019, 6:41 PM
Legoktm committed R2145:bd585503374f: Use gerrit-replica for cloning (authored by Legoktm).
Use gerrit-replica for cloning
Oct 20 2019, 6:41 PM
Legoktm committed R2145:2195769e7b68: Fix eslint auto-fixing (authored by Legoktm).
Fix eslint auto-fixing
Oct 20 2019, 6:41 PM
Legoktm committed R2145:3e11891e30b8: Always add .eslintcache to .gitignore if eslint caching is enabled (authored by Legoktm).
Always add .eslintcache to .gitignore if eslint caching is enabled
Oct 20 2019, 6:41 PM
Legoktm committed R2145:56c16f478767: grunt: Add ability to remove entire sections and reorder tasks (authored by Legoktm).
grunt: Add ability to remove entire sections and reorder tasks
Oct 20 2019, 6:41 PM
Legoktm committed R2145:7f6d32b9f0e4: Don't fatal if JSON data is incomplete (authored by Legoktm).
Don't fatal if JSON data is incomplete
Oct 20 2019, 6:41 PM
Legoktm committed R2145:4d060dcb7d27: push: Avoid creating an extra git remote while pushing (authored by Legoktm).
push: Avoid creating an extra git remote while pushing
Oct 20 2019, 6:41 PM
Legoktm committed R2145:30422ca855fd: web: Don't fatal if npm-audit data is incomplete (authored by Legoktm).
web: Don't fatal if npm-audit data is incomplete
Oct 20 2019, 6:41 PM
Legoktm committed R2145:0f8dcaaef9ce: Run eslint --fix when upgrading eslint and disable failing rules (authored by Legoktm).
Run eslint --fix when upgrading eslint and disable failing rules
Oct 20 2019, 6:41 PM
Legoktm committed R2145:fe14c69f3d25: Add hooks for npm upgrades (authored by Legoktm).
Add hooks for npm upgrades
Oct 20 2019, 6:41 PM
Legoktm committed R2145:49ee90d6d59d: Turn test_sha1 into a unit test (authored by Legoktm).
Turn test_sha1 into a unit test
Oct 20 2019, 6:41 PM
Legoktm committed R2145:6bf98ecead9f: Start logging earlier, and make sure we log Python exceptions too (authored by Legoktm).
Start logging earlier, and make sure we log Python exceptions too
Oct 20 2019, 6:41 PM
Legoktm committed R2145:e950af066400: Remove some debugging that's no longer needed (authored by Legoktm).
Remove some debugging that's no longer needed
Oct 20 2019, 6:41 PM
Legoktm committed R2145:31f1ddf7f8b5: Resort operations in Dockerfile so we're not reinstalling Pipfile every time (authored by Legoktm).
Resort operations in Dockerfile so we're not reinstalling Pipfile every time
Oct 20 2019, 6:41 PM
Legoktm committed R2145:a23f36f7c1c5: Support 'canaries' in libup-run (authored by Legoktm).
Support 'canaries' in libup-run
Oct 20 2019, 6:41 PM
Legoktm committed R2145:a6968a58d76a: Increase test coverage (authored by Legoktm).
Increase test coverage
Oct 20 2019, 6:41 PM
Legoktm committed R2145:c66807ca073b: Remove some resolved TODOs (authored by Legoktm).
Remove some resolved TODOs
Oct 20 2019, 6:41 PM
Legoktm committed R2145:7071d20ba690: Try a different way of setting git author/email (authored by Legoktm).
Try a different way of setting git author/email
Oct 20 2019, 6:41 PM
Legoktm committed R2145:7272ed24fd54: Add bug link to codesniffer hack (authored by Legoktm).
Add bug link to codesniffer hack
Oct 20 2019, 6:41 PM
Legoktm committed R2145:84d7ca2de088: Don't upgrade mediawiki/mediawiki-codesniffer 19.x (authored by Legoktm).
Don't upgrade mediawiki/mediawiki-codesniffer 19.x
Oct 20 2019, 6:41 PM
Legoktm committed R2145:363f01d208a3: Use git's environment variables to pass author/email (authored by Legoktm).
Use git's environment variables to pass author/email
Oct 20 2019, 6:41 PM
Legoktm committed R2145:dea15071c0f6: Run push operation outside of the container (authored by Legoktm).
Run push operation outside of the container
Oct 20 2019, 6:41 PM
Legoktm committed R2145:768ad2d7d206: Install known_hosts for the nobody user account (authored by Legoktm).
Install known_hosts for the nobody user account
Oct 20 2019, 6:41 PM
Legoktm committed R2145:1abd41e19fc0: Add a bit of debugging to figure out why pushing isn't working (authored by Legoktm).
Add a bit of debugging to figure out why pushing isn't working
Oct 20 2019, 6:41 PM
Legoktm committed R2145:8d53e3bc8d7a: libup-celery: Disable PrivateTmp so it can access ssh-agent socket (authored by Legoktm).
libup-celery: Disable PrivateTmp so it can access ssh-agent socket
Oct 20 2019, 6:41 PM
Legoktm committed R2145:44560cc72884: Mount DATA_ROOT and CONFIG_REPO into push container (authored by Legoktm).
Mount DATA_ROOT and CONFIG_REPO into push container
Oct 20 2019, 6:41 PM
Legoktm committed R2145:8eb6364d8bf4: Add integration tests for shell (authored by Legoktm).
Add integration tests for shell
Oct 20 2019, 6:41 PM
Legoktm committed R2145:3df3dbf96b61: Exit earlier if there are no composer updates (authored by Legoktm).
Exit earlier if there are no composer updates
Oct 20 2019, 6:41 PM
Legoktm committed R2145:775565a781f6: Configure and use ssh-agent (authored by Legoktm).
Configure and use ssh-agent
Oct 20 2019, 6:41 PM
Legoktm committed R2145:ceb67e7538f3: npm audit: Only care about 'action': 'update' (authored by Legoktm).
npm audit: Only care about 'action': 'update'
Oct 20 2019, 6:41 PM
Legoktm committed R2145:94909ad89d8d: data['push'] might not always be set (authored by Legoktm).
data['push'] might not always be set
Oct 20 2019, 6:41 PM
Legoktm committed R2145:79d98fb06846: Only run tests for upgraded libraries if we upgrade anything (authored by Legoktm).
Only run tests for upgraded libraries if we upgrade anything
Oct 20 2019, 6:41 PM
Legoktm committed R2145:4b924ea27cb8: Workaround bug in SaveDict that prevented log entries from being properly saved (authored by Legoktm).
Workaround bug in SaveDict that prevented log entries from being properly saved
Oct 20 2019, 6:41 PM
Legoktm committed R2145:d05f087cf8a9: Install all of python2 for node-gyp (authored by Legoktm).
Install all of python2 for node-gyp
Oct 20 2019, 6:41 PM
Legoktm committed R2145:2e15094dbc68: library: Suppress a bug in distutils (authored by Legoktm).
library: Suppress a bug in distutils
Oct 20 2019, 6:41 PM
Legoktm committed R2145:f78b31ce346c: Limit celery concurrency to 1 (authored by Legoktm).
Limit celery concurrency to 1
Oct 20 2019, 6:41 PM
Legoktm committed R2145:d539b8bbeb70: Add a basic listing of repositories with errors (authored by Legoktm).
Add a basic listing of repositories with errors
Oct 20 2019, 6:41 PM
Legoktm committed R2145:b9bce02a0571: Don't try rollbacking partial changes, it doesn't work (authored by Legoktm).
Don't try rollbacking partial changes, it doesn't work
Oct 20 2019, 6:41 PM
Legoktm committed R2145:7234dd5a55e3: Turn Library.is_newer() into unit tests, not integration (authored by Legoktm).
Turn Library.is_newer() into unit tests, not integration
Oct 20 2019, 6:41 PM
Legoktm committed R2145:55bb31ba27be: Improve ng tests by verifying fixes (authored by Legoktm).
Improve ng tests by verifying fixes
Oct 20 2019, 6:41 PM
Legoktm committed R2145:c154fdb0a124: Add 'push' config kill switch (authored by Legoktm).
Add 'push' config kill switch
Oct 20 2019, 6:41 PM
Legoktm committed R2145:c175c79e0a47: web: Avoid errors in case npm audit report doesn't have 'dev' set (authored by Legoktm).
web: Avoid errors in case npm audit report doesn't have 'dev' set
Oct 20 2019, 6:41 PM
Legoktm committed R2145:aec0850a2549: Drop pyfakefs (authored by Legoktm).
Drop pyfakefs
Oct 20 2019, 6:41 PM
Legoktm committed R2145:cb0b9691f416: Finish coverage for gruntfile.parse_section() (authored by Legoktm).
Finish coverage for gruntfile.parse_section()
Oct 20 2019, 6:41 PM
Legoktm committed R2145:4b591c2cf41e: Move tests into separate directory (authored by Legoktm).
Move tests into separate directory
Oct 20 2019, 6:41 PM
Legoktm committed R2145:0924c379648b: Set proper permissions when creating the new log directory (authored by Legoktm).
Set proper permissions when creating the new log directory
Oct 20 2019, 6:41 PM
Legoktm committed R2145:567ef163b701: Copy in ~/.gitconfig instead of running git config during build (authored by Legoktm).
Copy in ~/.gitconfig instead of running git config during build
Oct 20 2019, 6:41 PM
Legoktm committed R2145:aecbb31bf9ef: Modernize tox configuration (authored by Legoktm).
Modernize tox configuration
Oct 20 2019, 6:41 PM
Legoktm committed R2145:fda997fa747d: Pull good releases from config/ git repository, not wiki (authored by Legoktm).
Pull good releases from config/ git repository, not wiki
Oct 20 2019, 6:41 PM
Legoktm committed R2145:658acb8644c4: Make sure we save data if the docker container exits unhappily (authored by Legoktm).
Make sure we save data if the docker container exits unhappily
Oct 20 2019, 6:41 PM
Legoktm committed R2145:ffe24ed95c6c: Add .gitreview (authored by Legoktm).
Add .gitreview
Oct 20 2019, 6:41 PM
Legoktm committed R2145:3daa1aeac9b9: Don't fatal if a composer dep isn't in packagist (authored by Legoktm).
Don't fatal if a composer dep isn't in packagist
Oct 20 2019, 6:41 PM
Legoktm committed R2145:26ec2e2867be: Fully rollback npm changes if `npm test` fails (authored by Legoktm).
Fully rollback npm changes if `npm test` fails
Oct 20 2019, 6:41 PM
Legoktm committed R2145:2dc655f2fd7c: web: Expose latest log file (authored by Legoktm).
web: Expose latest log file
Oct 20 2019, 6:41 PM
Legoktm committed R2145:b4cdb008259a: Add some more debug logging (authored by Legoktm).
Add some more debug logging
Oct 20 2019, 6:41 PM
Legoktm committed R2145:9560cd3b1394: Put options on top when editing eslint grunt configuration (authored by Legoktm).
Put options on top when editing eslint grunt configuration
Oct 20 2019, 6:41 PM
Legoktm committed R2145:32c648193291: Save logs (authored by Legoktm).
Save logs
Oct 20 2019, 6:41 PM
Legoktm committed R2145:3799d1e2704c: Don't run dockerfile as root (authored by Legoktm).
Don't run dockerfile as root
Oct 20 2019, 6:41 PM
Legoktm committed R2145:06a7f3814f8e: Adjust eslint config to enable caching and reporting extra disables (authored by Legoktm).
Adjust eslint config to enable caching and reporting extra disables
Oct 20 2019, 6:41 PM
Legoktm committed R2145:9cc0a793f2d5: ...and actually save our changes to .gitignore (authored by Legoktm).
...and actually save our changes to .gitignore
Oct 20 2019, 6:41 PM
Legoktm committed R2145:cf48525b9688: Set `private: true` in package.json for MediaWiki extensions & skins (authored by Legoktm).
Set `private: true` in package.json for MediaWiki extensions & skins
Oct 20 2019, 6:41 PM
Legoktm committed R2145:ff49a2477cd4: Set `root: true` in .eslintrc.json (authored by Legoktm).
Set `root: true` in .eslintrc.json
Oct 20 2019, 6:41 PM
Legoktm committed R2145:e339f05ca4ba: Make it easier to change packagist mirror in the future (authored by Legoktm).
Make it easier to change packagist mirror in the future
Oct 20 2019, 6:41 PM
Legoktm committed R2145:2bc5e894603e: Only push patches if there are updates and no pre-existing changes (authored by Legoktm).
Only push patches if there are updates and no pre-existing changes
Oct 20 2019, 6:41 PM
Legoktm committed R2145:3f2849fe7e76: Delete legacy upgrade.py code (authored by Legoktm).
Delete legacy upgrade.py code
Oct 20 2019, 6:41 PM