Software developer on the Wikidata team at Wikimedia Germany (he/him, Berlin timezone). Private account: @LucasWerkmeister.
User Details
- User Since
- Apr 3 2017, 2:45 PM (367 w, 4 d)
- Availability
- Available
- IRC Nick
- Lucas_WMDE
- LDAP User
- Lucas Werkmeister (WMDE)
- MediaWiki User
- Lucas Werkmeister (WMDE) [ Global Accounts ]
Yesterday
Thu, Apr 18
I guess this is almost a duplicate of T168365: Use new standard MediaWiki error reporting with Wikibase API and/or T168367: Disable custom error reporting in the API if new error format is requested. – I hadn’t seen those tasks before.
It looks like it’s possible to get similar information out of Kubernetes:
Maybe we can work on this during the hackathon? I’ve heard a few interested people will be there :)
Wed, Apr 17
Yeah, it feels like the sort of tool it could be quite useful for.
I’ve squashed the above change into the Gerrit change that introduces the class; moving to peer review in case someone wants to take a look, but I don’t think it needs a lot more time spent on it :)
Easy enough to fix:
I actually can’t reproduce this at all anymore. Let’s just chalk it up to the WIP-ness of the previous patches (which are now less WIP – I’m testing Wikibase 1ff1c5334f and EntitySchema 8f0596f2f1) and close it as invalid. If the problem comes back we can reopen the task or create a new one.
This is probably a side effect of us not having a real “expert” yet (T362004). I’ll see if I can hack together a sham expert to confirm this theory.
Tue, Apr 16
It looks like the above three changes are enough to make PHP 8.2 and 8.3 pass \o/
Previous bastions had (due to the grid) all the locales which I'd like to avoid.
I also get a locale error (“manpath: can't set the locale; make sure $LC_* and $LANG are correct”) when connecting to toolforge-dev with normal SSH:
Is this still an UBN? I’m not really sure how the above two patches relate to this.
There are a bunch of additional failures in this build (for this change) (from this video); some of them look like they don’t really require separate tasks, so let’s attach some fixes directly here, I think.
Prio Notes:
Prio Notes:
Prio Notes:
It’s documented here, by the way: https://www.mediawiki.org/wiki/Manual:Collapsible_elements#Custom_toggle_link_placement
Mon, Apr 15
Okay, I see. Anyway – we should definitely be able to document the props (even if there’s just one of them at the moment) – see the query+info docs for comparison: MediaWiki supports adding a documentation message for each supported value.
Apparently this was still open and assigned to me… let’s assume it’s fixed, feel free to reopen otherwise. (There’s been some movement in these browser tests anyways, e.g. they’ve been ported to async mode in T300807.)
@thiemowmde can you see if it works better now?
Yeah, I think the other test failure in the linked CI build (“Expectation failed for method name is "addCategory" when invoked 1 time(s).”) also would make some sense with a broken message cache – in that case, TrackingCategories might resolve the tracking category to an empty / disabled category, and therefore not call addCategory() on the ParserOutput.
Wikibase’s own CI seems to be working at least, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1019064 was merged just an hour ago.
Scratch all that, my Cite was just outdated. After updating it I can’t reproduce the error anymore.
Yeah, splitting the job also sounds fine to me.
(why would you pass an empty value?)
Locally, git bisect says the first bad commit is Deprecate use of dynamic properties attached to Parser (T343227). However, it fails with an error Use of MediaWiki\Parser\Parser::$extCite was deprecated in MediaWiki 1.42. that I don’t see in the linked CI output.
Fri, Apr 12
(Probably not a blocker for the release, just related to it.)
Potential options:
I think this is actually done \o/
To make use of the new mechanism implemented in the patch from the Product Platform team
Thu, Apr 11
I would expect the datavalue {"value":{"id":"E1"},"type":"wikibase-entityid"} to work, when property is set to the property ID of a property with data type EntitySchema. (For comparison, for item properties, {"value":{"id":"Q1"},"type":"wikibase-entityid"} works.)
(While change_object_id belongs to a WikibaseRepo table, it’s still part of the change dispatching system, so we expect that this whole task belongs with the Wikidata Integrations Team.)